vfs_fruit: remove check for number of xattrs from ad_convert_xattr
[samba.git] / source3 / modules / vfs_fruit.c
index b0dd0f062bd16c9b1f044d90db09eb72abe10633..a3dabcd31c1edea0462cc758af31bf73dc849ea4 100644 (file)
@@ -141,6 +141,7 @@ struct fruit_config_data {
        bool aapl_zero_file_id;
        const char *model;
        bool time_machine;
+       off_t time_machine_max_size;
 
        /*
         * Additional options, all enabled by default,
@@ -261,6 +262,7 @@ typedef enum {ADOUBLE_META, ADOUBLE_RSRC} adouble_type_t;
 #define ADEDLEN_VERSION     4
 #define ADEDLEN_FILLER      16
 #define AD_FILLER_TAG       "Netatalk        " /* should be 16 bytes */
+#define AD_FILLER_TAG_OSX   "Mac OS X        " /* should be 16 bytes */
 #define ADEDLEN_NENTRIES    2
 #define AD_HEADER_LEN       (ADEDLEN_MAGIC + ADEDLEN_VERSION + \
                             ADEDLEN_FILLER + ADEDLEN_NENTRIES) /* 26 */
@@ -413,6 +415,7 @@ struct adouble {
        adouble_type_t            ad_type;
        uint32_t                  ad_magic;
        uint32_t                  ad_version;
+       uint8_t                   ad_filler[ADEDLEN_FILLER];
        struct ad_entry           ad_eid[ADEID_MAX];
        char                     *ad_data;
        struct ad_xattr_header    adx_header;
@@ -482,6 +485,10 @@ static int ad_fset(struct adouble *ad, files_struct *fsp);
 static int adouble_path(TALLOC_CTX *ctx,
                        const struct smb_filename *smb_fname__in,
                        struct smb_filename **ppsmb_fname_out);
+static AfpInfo *afpinfo_new(TALLOC_CTX *ctx);
+static ssize_t afpinfo_pack(const AfpInfo *ai, char *buf);
+static AfpInfo *afpinfo_unpack(TALLOC_CTX *ctx, const void *data);
+
 
 /**
  * Return a pointer to an AppleDouble entry
@@ -832,6 +839,8 @@ static bool ad_unpack(struct adouble *ad, const size_t nentries,
                return false;
        }
 
+       memcpy(ad->ad_filler, ad->ad_data + ADEDOFF_FILLER, ADEDLEN_FILLER);
+
        adentries = RSVAL(ad->ad_data, ADEDOFF_NENTRIES);
        if (adentries != nentries) {
                DEBUG(1, ("invalid number of entries: %zu\n",
@@ -933,16 +942,75 @@ static bool ad_unpack(struct adouble *ad, const size_t nentries,
        return true;
 }
 
+static bool ad_convert_move_reso(struct adouble *ad,
+                                const struct smb_filename *smb_fname)
+{
+       char *map = MAP_FAILED;
+       size_t maplen;
+       ssize_t len;
+       int rc;
+       bool ok;
+
+       if (ad_getentrylen(ad, ADEID_RFORK) == 0) {
+               return true;
+       }
+
+       maplen = ad_getentryoff(ad, ADEID_RFORK) +
+               ad_getentrylen(ad, ADEID_RFORK);
+
+       /* FIXME: direct use of mmap(), vfs_aio_fork does it too */
+       map = mmap(NULL, maplen, PROT_READ|PROT_WRITE, MAP_SHARED,
+                  ad->ad_fd, 0);
+       if (map == MAP_FAILED) {
+               DBG_ERR("mmap AppleDouble: %s\n", strerror(errno));
+               return false;
+       }
+
+
+       memmove(map + ADEDOFF_RFORK_DOT_UND,
+               map + ad_getentryoff(ad, ADEID_RFORK),
+               ad_getentrylen(ad, ADEID_RFORK));
+
+       rc = munmap(map, maplen);
+       if (rc != 0) {
+               DBG_ERR("munmap failed: %s\n", strerror(errno));
+               return false;
+       }
+
+       ad_setentryoff(ad, ADEID_RFORK, ADEDOFF_RFORK_DOT_UND);
+
+       ok = ad_pack(ad);
+       if (!ok) {
+               DBG_WARNING("ad_pack [%s] failed\n", smb_fname->base_name);
+               return false;
+       }
+
+       len = sys_pwrite(ad->ad_fd, ad->ad_data, AD_DATASZ_DOT_UND, 0);
+       if (len != AD_DATASZ_DOT_UND) {
+               DBG_ERR("%s: bad size: %zd\n", smb_fname->base_name, len);
+               return false;
+       }
+
+       return true;
+}
+
 static bool ad_convert_xattr(struct adouble *ad,
                             const struct smb_filename *smb_fname,
-                            char *map)
+                            bool *converted_xattr)
 {
        static struct char_mappings **string_replace_cmaps = NULL;
+       char *map = MAP_FAILED;
+       size_t maplen;
        uint16_t i;
+       ssize_t len;
        int saved_errno = 0;
        NTSTATUS status;
+       int rc;
+       bool ok;
 
-       if (ad->adx_header.adx_num_attrs == 0) {
+       *converted_xattr = false;
+
+       if (ad_getentrylen(ad, ADEID_FINDERI) == ADEDLEN_FINDERI) {
                return true;
        }
 
@@ -958,6 +1026,17 @@ static bool ad_convert_xattr(struct adouble *ad,
                TALLOC_FREE(mappings);
        }
 
+       maplen = ad_getentryoff(ad, ADEID_RFORK) +
+               ad_getentrylen(ad, ADEID_RFORK);
+
+       /* FIXME: direct use of mmap(), vfs_aio_fork does it too */
+       map = mmap(NULL, maplen, PROT_READ|PROT_WRITE, MAP_SHARED,
+                  ad->ad_fd, 0);
+       if (map == MAP_FAILED) {
+               DBG_ERR("mmap AppleDouble: %s\n", strerror(errno));
+               return false;
+       }
+
        for (i = 0; i < ad->adx_header.adx_num_attrs; i++) {
                struct ad_xattr_entry *e = &ad->adx_entries[i];
                char *mapped_name = NULL;
@@ -976,14 +1055,16 @@ static bool ad_convert_xattr(struct adouble *ad,
                    !NT_STATUS_EQUAL(status, NT_STATUS_NONE_MAPPED))
                {
                        DBG_ERR("string_replace_allocate failed\n");
-                       return -1;
+                       ok = false;
+                       goto fail;
                }
 
                tmp = mapped_name;
                mapped_name = talloc_asprintf(talloc_tos(), ":%s", tmp);
                TALLOC_FREE(tmp);
                if (mapped_name == NULL) {
-                       return -1;
+                       ok = false;
+                       goto fail;
                }
 
                stream_name = synthetic_smb_fname(talloc_tos(),
@@ -994,7 +1075,8 @@ static bool ad_convert_xattr(struct adouble *ad,
                TALLOC_FREE(mapped_name);
                if (stream_name == NULL) {
                        DBG_ERR("synthetic_smb_fname failed\n");
-                       return -1;
+                       ok = false;
+                       goto fail;
                }
 
                DBG_DEBUG("stream_name: %s\n", smb_fname_str_dbg(stream_name));
@@ -1021,7 +1103,8 @@ static bool ad_convert_xattr(struct adouble *ad,
                TALLOC_FREE(stream_name);
                if (!NT_STATUS_IS_OK(status)) {
                        DBG_ERR("SMB_VFS_CREATE_FILE failed\n");
-                       return -1;
+                       ok = false;
+                       goto fail;
                }
 
                nwritten = SMB_VFS_PWRITE(fsp,
@@ -1033,16 +1116,168 @@ static bool ad_convert_xattr(struct adouble *ad,
                        saved_errno = errno;
                        close_file(NULL, fsp, ERROR_CLOSE);
                        errno = saved_errno;
-                       return -1;
+                       ok = false;
+                       goto fail;
                }
 
                status = close_file(NULL, fsp, NORMAL_CLOSE);
                if (!NT_STATUS_IS_OK(status)) {
-                       return -1;
+                       ok = false;
+                       goto fail;
                }
                fsp = NULL;
        }
 
+       ad_setentrylen(ad, ADEID_FINDERI, ADEDLEN_FINDERI);
+
+       ok = ad_pack(ad);
+       if (!ok) {
+               DBG_WARNING("ad_pack [%s] failed\n", smb_fname->base_name);
+               goto fail;
+       }
+
+       len = sys_pwrite(ad->ad_fd, ad->ad_data, AD_DATASZ_DOT_UND, 0);
+       if (len != AD_DATASZ_DOT_UND) {
+               DBG_ERR("%s: bad size: %zd\n", smb_fname->base_name, len);
+               ok = false;
+               goto fail;
+       }
+
+       ok = ad_convert_move_reso(ad, smb_fname);
+       if (!ok) {
+               goto fail;
+       }
+
+       *converted_xattr = true;
+       ok = true;
+
+fail:
+       rc = munmap(map, maplen);
+       if (rc != 0) {
+               DBG_ERR("munmap failed: %s\n", strerror(errno));
+               return false;
+       }
+
+       return ok;
+}
+
+static bool ad_convert_finderinfo(struct adouble *ad,
+                                 const struct smb_filename *smb_fname)
+{
+       char *p_ad = NULL;
+       AfpInfo *ai = NULL;
+       DATA_BLOB aiblob;
+       struct smb_filename *stream_name = NULL;
+       files_struct *fsp = NULL;
+       size_t size;
+       ssize_t nwritten;
+       NTSTATUS status;
+       int saved_errno = 0;
+       int cmp;
+
+       cmp = memcmp(ad->ad_filler, AD_FILLER_TAG_OSX, ADEDLEN_FILLER);
+       if (cmp != 0) {
+               return true;
+       }
+
+       p_ad = ad_get_entry(ad, ADEID_FINDERI);
+       if (p_ad == NULL) {
+               return false;
+       }
+
+       ai = afpinfo_new(talloc_tos());
+       if (ai == NULL) {
+               return false;
+       }
+
+       memcpy(ai->afpi_FinderInfo, p_ad, ADEDLEN_FINDERI);
+
+       aiblob = data_blob_talloc(talloc_tos(), NULL, AFP_INFO_SIZE);
+       if (aiblob.data == NULL) {
+               TALLOC_FREE(ai);
+               return false;
+       }
+
+       size = afpinfo_pack(ai, (char *)aiblob.data);
+       TALLOC_FREE(ai);
+       if (size != AFP_INFO_SIZE) {
+               return false;
+       }
+
+       stream_name = synthetic_smb_fname(talloc_tos(),
+                                         smb_fname->base_name,
+                                         AFPINFO_STREAM,
+                                         NULL,
+                                         smb_fname->flags);
+       if (stream_name == NULL) {
+               data_blob_free(&aiblob);
+               DBG_ERR("synthetic_smb_fname failed\n");
+               return false;
+       }
+
+       DBG_DEBUG("stream_name: %s\n", smb_fname_str_dbg(stream_name));
+
+       status = SMB_VFS_CREATE_FILE(
+               ad->ad_handle->conn,            /* conn */
+               NULL,                           /* req */
+               0,                              /* root_dir_fid */
+               stream_name,                    /* fname */
+               FILE_GENERIC_WRITE,             /* access_mask */
+               FILE_SHARE_READ | FILE_SHARE_WRITE, /* share_access */
+               FILE_OPEN_IF,                   /* create_disposition */
+               0,                              /* create_options */
+               0,                              /* file_attributes */
+               INTERNAL_OPEN_ONLY,             /* oplock_request */
+               NULL,                           /* lease */
+               0,                              /* allocation_size */
+               0,                              /* private_flags */
+               NULL,                           /* sd */
+               NULL,                           /* ea_list */
+               &fsp,                           /* result */
+               NULL,                           /* psbuf */
+               NULL, NULL);                    /* create context */
+       TALLOC_FREE(stream_name);
+       if (!NT_STATUS_IS_OK(status)) {
+               DBG_ERR("SMB_VFS_CREATE_FILE failed\n");
+               return false;
+       }
+
+       nwritten = SMB_VFS_PWRITE(fsp,
+                                 aiblob.data,
+                                 aiblob.length,
+                                 0);
+       if (nwritten == -1) {
+               DBG_ERR("SMB_VFS_PWRITE failed\n");
+               saved_errno = errno;
+               close_file(NULL, fsp, ERROR_CLOSE);
+               errno = saved_errno;
+               return false;
+       }
+
+       status = close_file(NULL, fsp, NORMAL_CLOSE);
+       if (!NT_STATUS_IS_OK(status)) {
+               return false;
+       }
+       fsp = NULL;
+
+       return true;
+}
+
+static bool ad_convert_truncate(struct adouble *ad,
+                               const struct smb_filename *smb_fname)
+{
+       int rc;
+
+       /*
+        * FIXME: direct ftruncate(), but we don't have a fsp for the
+        * VFS call
+        */
+       rc = ftruncate(ad->ad_fd, ADEDOFF_RFORK_DOT_UND +
+                      ad_getentrylen(ad, ADEID_RFORK));
+       if (rc != 0) {
+               return false;
+       }
+
        return true;
 }
 
@@ -1050,59 +1285,37 @@ static bool ad_convert_xattr(struct adouble *ad,
  * Convert from Apple's ._ file to Netatalk
  *
  * Apple's AppleDouble may contain a FinderInfo entry longer then 32
- * bytes containing packed xattrs. Netatalk can't deal with that, so
- * we simply discard the packed xattrs.
+ * bytes containing packed xattrs.
  *
  * @return -1 in case an error occurred, 0 if no conversion was done, 1
  * otherwise
  **/
 static int ad_convert(struct adouble *ad,
-                     const struct smb_filename *smb_fname,
-                     int fd)
+                     const struct smb_filename *smb_fname)
 {
-       int rc = 0;
-       char *map = MAP_FAILED;
-       size_t origlen;
        bool ok;
+       bool converted_xattr = false;
 
-       origlen = ad_getentryoff(ad, ADEID_RFORK) +
-               ad_getentrylen(ad, ADEID_RFORK);
-
-       /* FIXME: direct use of mmap(), vfs_aio_fork does it too */
-       map = mmap(NULL, origlen, PROT_READ|PROT_WRITE, MAP_SHARED, fd, 0);
-       if (map == MAP_FAILED) {
-               DEBUG(2, ("mmap AppleDouble: %s\n", strerror(errno)));
-               rc = -1;
-               goto exit;
-       }
-
-       ok = ad_convert_xattr(ad, smb_fname, map);
+       ok = ad_convert_xattr(ad, smb_fname, &converted_xattr);
        if (!ok) {
                return -1;
        }
 
-       if (ad_getentrylen(ad, ADEID_RFORK) > 0) {
-               memmove(map + ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI,
-                       map + ad_getentryoff(ad, ADEID_RFORK),
-                       ad_getentrylen(ad, ADEID_RFORK));
+       if (converted_xattr) {
+               ok = ad_convert_truncate(ad, smb_fname);
+               if (!ok) {
+                       return -1;
+               }
        }
 
-       ad_setentrylen(ad, ADEID_FINDERI, ADEDLEN_FINDERI);
-       ad_setentryoff(ad, ADEID_RFORK,
-                      ad_getentryoff(ad, ADEID_FINDERI) + ADEDLEN_FINDERI);
-
-       /*
-        * FIXME: direct ftruncate(), but we don't have a fsp for the
-        * VFS call
-        */
-       rc = ftruncate(fd, ad_getentryoff(ad, ADEID_RFORK)
-                      + ad_getentrylen(ad, ADEID_RFORK));
-
-exit:
-       if (map != MAP_FAILED) {
-               munmap(map, origlen);
+       ok = ad_convert_finderinfo(ad, smb_fname);
+       if (!ok) {
+               DBG_ERR("Failed to convert [%s]\n",
+                       smb_fname_str_dbg(smb_fname));
+               return -1;
        }
-       return rc;
+
+       return 0;
 }
 
 /**
@@ -1296,12 +1509,10 @@ static ssize_t ad_read_rsrc_xattr(struct adouble *ad)
 static ssize_t ad_read_rsrc_adouble(struct adouble *ad,
                                const struct smb_filename *smb_fname)
 {
-       struct adouble *meta_ad = NULL;
        SMB_STRUCT_STAT sbuf;
        char *p_ad = NULL;
-       char *p_meta_ad = NULL;
-       ssize_t len;
        size_t size;
+       ssize_t len;
        int ret;
        bool ok;
 
@@ -1357,59 +1568,17 @@ static ssize_t ad_read_rsrc_adouble(struct adouble *ad,
                return -1;
        }
 
-       if (ad_getentrylen(ad, ADEID_FINDERI) == ADEDLEN_FINDERI) {
-               return len;
-       }
-
        /*
         * Try to fixup AppleDouble files created by OS X with xattrs
-        * appended to the ADEID_FINDERI entry. We simply remove the
-        * xattrs blob, this means any fancy xattr that was stored
-        * there is lost.
+        * appended to the ADEID_FINDERI entry.
         */
 
-       ret = ad_convert(ad, smb_fname, ad->ad_fd);
+       ret = ad_convert(ad, smb_fname);
        if (ret != 0) {
                DBG_WARNING("Failed to convert [%s]\n", smb_fname->base_name);
                return len;
        }
 
-       ok = ad_pack(ad);
-       if (!ok) {
-               DBG_WARNING("ad_pack [%s] failed\n", smb_fname->base_name);
-               return -1;
-       }
-
-       len = sys_pwrite(ad->ad_fd, ad->ad_data, AD_DATASZ_DOT_UND, 0);
-       if (len != AD_DATASZ_DOT_UND) {
-               DBG_ERR("%s: bad size: %zd\n", smb_fname->base_name, len);
-               return -1;
-       }
-
-       meta_ad = ad_init(talloc_tos(), ad->ad_handle, ADOUBLE_META);
-       if (meta_ad == NULL) {
-               return -1;
-       }
-
-       p_ad = ad_get_entry(ad, ADEID_FINDERI);
-       if (p_ad == NULL) {
-               TALLOC_FREE(meta_ad);
-               return -1;
-       }
-       p_meta_ad = ad_get_entry(meta_ad, ADEID_FINDERI);
-       if (p_meta_ad == NULL) {
-               TALLOC_FREE(meta_ad);
-               return -1;
-       }
-
-       memcpy(p_meta_ad, p_ad, ADEDLEN_FINDERI);
-
-       ret = ad_set(meta_ad, smb_fname);
-       TALLOC_FREE(meta_ad);
-       if (ret != 0) {
-               return -1;
-       }
-
        return len;
 }
 
@@ -1819,6 +1988,7 @@ static int init_fruit_config(vfs_handle_struct *handle)
 {
        struct fruit_config_data *config;
        int enumval;
+       const char *tm_size_str = NULL;
 
        config = talloc_zero(handle->conn, struct fruit_config_data);
        if (!config) {
@@ -1917,6 +2087,13 @@ static int init_fruit_config(vfs_handle_struct *handle)
        config->model = lp_parm_const_string(
                -1, FRUIT_PARAM_TYPE_NAME, "model", "MacSamba");
 
+       tm_size_str = lp_parm_const_string(
+               SNUM(handle->conn), FRUIT_PARAM_TYPE_NAME,
+               "time machine max size", NULL);
+       if (tm_size_str != NULL) {
+               config->time_machine_max_size = conv_str_size(tm_size_str);
+       }
+
        SMB_VFS_HANDLE_SET_DATA(handle, config,
                                NULL, struct fruit_config_data,
                                return -1);
@@ -2256,7 +2433,7 @@ static off_t access_to_netatalk_brl(enum apple_fork fork_type,
 static off_t denymode_to_netatalk_brl(enum apple_fork fork_type,
                                      uint32_t deny_mode)
 {
-       off_t offset;
+       off_t offset = 0;
 
        switch (deny_mode) {
        case DENY_READ:
@@ -2311,7 +2488,6 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
                                   uint32_t deny_mode)
 {
        NTSTATUS status = NT_STATUS_OK;
-       struct byte_range_lock *br_lck = NULL;
        bool open_for_reading, open_for_writing, deny_read, deny_write;
        off_t off;
        bool have_read = false;
@@ -2369,6 +2545,8 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
 
                /* Set locks */
                if ((access_mask & FILE_READ_DATA) && have_read) {
+                       struct byte_range_lock *br_lck = NULL;
+
                        off = access_to_netatalk_brl(fork_type, FILE_READ_DATA);
                        br_lck = do_lock(
                                handle->conn->sconn->msg_ctx, fsp,
@@ -2376,13 +2554,16 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
                                READ_LOCK, POSIX_LOCK, false,
                                &status, NULL);
 
+                       TALLOC_FREE(br_lck);
+
                        if (!NT_STATUS_IS_OK(status))  {
                                return status;
                        }
-                       TALLOC_FREE(br_lck);
                }
 
                if ((deny_mode & DENY_READ) && have_read) {
+                       struct byte_range_lock *br_lck = NULL;
+
                        off = denymode_to_netatalk_brl(fork_type, DENY_READ);
                        br_lck = do_lock(
                                handle->conn->sconn->msg_ctx, fsp,
@@ -2390,10 +2571,11 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
                                READ_LOCK, POSIX_LOCK, false,
                                &status, NULL);
 
+                       TALLOC_FREE(br_lck);
+
                        if (!NT_STATUS_IS_OK(status)) {
                                return status;
                        }
-                       TALLOC_FREE(br_lck);
                }
        }
 
@@ -2419,6 +2601,8 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
 
                /* Set locks */
                if ((access_mask & FILE_WRITE_DATA) && have_read) {
+                       struct byte_range_lock *br_lck = NULL;
+
                        off = access_to_netatalk_brl(fork_type, FILE_WRITE_DATA);
                        br_lck = do_lock(
                                handle->conn->sconn->msg_ctx, fsp,
@@ -2426,13 +2610,15 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
                                READ_LOCK, POSIX_LOCK, false,
                                &status, NULL);
 
+                       TALLOC_FREE(br_lck);
+
                        if (!NT_STATUS_IS_OK(status)) {
                                return status;
                        }
-                       TALLOC_FREE(br_lck);
-
                }
                if ((deny_mode & DENY_WRITE) && have_read) {
+                       struct byte_range_lock *br_lck = NULL;
+
                        off = denymode_to_netatalk_brl(fork_type, DENY_WRITE);
                        br_lck = do_lock(
                                handle->conn->sconn->msg_ctx, fsp,
@@ -2440,15 +2626,14 @@ static NTSTATUS fruit_check_access(vfs_handle_struct *handle,
                                READ_LOCK, POSIX_LOCK, false,
                                &status, NULL);
 
+                       TALLOC_FREE(br_lck);
+
                        if (!NT_STATUS_IS_OK(status)) {
                                return status;
                        }
-                       TALLOC_FREE(br_lck);
                }
        }
 
-       TALLOC_FREE(br_lck);
-
        return status;
 }
 
@@ -2879,21 +3064,65 @@ static NTSTATUS readdir_attr_macmeta(struct vfs_handle_struct *handle,
        return status;
 }
 
-/* Search MS NFS style ACE with UNIX mode */
-static NTSTATUS check_ms_nfs(vfs_handle_struct *handle,
-                            files_struct *fsp,
-                            const struct security_descriptor *psd,
-                            mode_t *pmode,
-                            bool *pdo_chmod)
+static NTSTATUS remove_virtual_nfs_aces(struct security_descriptor *psd)
 {
+       NTSTATUS status;
        uint32_t i;
-       struct fruit_config_data *config = NULL;
 
-       *pdo_chmod = false;
+       if (psd->dacl == NULL) {
+               return NT_STATUS_OK;
+       }
 
-       SMB_VFS_HANDLE_GET_DATA(handle, config,
-                               struct fruit_config_data,
-                               return NT_STATUS_UNSUCCESSFUL);
+       for (i = 0; i < psd->dacl->num_aces; i++) {
+               /* MS NFS style mode/uid/gid */
+               int cmp = dom_sid_compare_domain(
+                               &global_sid_Unix_NFS,
+                               &psd->dacl->aces[i].trustee);
+               if (cmp != 0) {
+                       /* Normal ACE entry. */
+                       continue;
+               }
+
+               /*
+                * security_descriptor_dacl_del()
+                * *must* return NT_STATUS_OK as we know
+                * we have something to remove.
+                */
+
+               status = security_descriptor_dacl_del(psd,
+                               &psd->dacl->aces[i].trustee);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DBG_WARNING("failed to remove MS NFS style ACE: %s\n",
+                               nt_errstr(status));
+                       return status;
+               }
+
+               /*
+                * security_descriptor_dacl_del() may delete more
+                * then one entry subsequent to this one if the
+                * SID matches, but we only need to ensure that
+                * we stay looking at the same element in the array.
+                */
+               i--;
+       }
+       return NT_STATUS_OK;
+}
+
+/* Search MS NFS style ACE with UNIX mode */
+static NTSTATUS check_ms_nfs(vfs_handle_struct *handle,
+                            files_struct *fsp,
+                            struct security_descriptor *psd,
+                            mode_t *pmode,
+                            bool *pdo_chmod)
+{
+       uint32_t i;
+       struct fruit_config_data *config = NULL;
+
+       *pdo_chmod = false;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct fruit_config_data,
+                               return NT_STATUS_UNSUCCESSFUL);
 
        if (!global_fruit_config.nego_aapl) {
                return NT_STATUS_OK;
@@ -2916,7 +3145,12 @@ static NTSTATUS check_ms_nfs(vfs_handle_struct *handle,
                }
        }
 
-       return NT_STATUS_OK;
+       /*
+        * Remove any incoming virtual ACE entries generated by
+        * fruit_fget_nt_acl().
+        */
+
+       return remove_virtual_nfs_aces(psd);
 }
 
 /****************************************************************************
@@ -3145,7 +3379,7 @@ static int fruit_open_meta(vfs_handle_struct *handle,
                return -1;
        }
 
-       fio = (struct fio *)VFS_ADD_FSP_EXTENSION(handle, fsp, struct fio, NULL);
+       fio = VFS_ADD_FSP_EXTENSION(handle, fsp, struct fio, NULL);
        fio->type = ADOUBLE_META;
        fio->config = config;
 
@@ -3312,7 +3546,7 @@ static int fruit_open_rsrc(vfs_handle_struct *handle,
                return -1;
        }
 
-       fio = (struct fio *)VFS_ADD_FSP_EXTENSION(handle, fsp, struct fio, NULL);
+       fio = VFS_ADD_FSP_EXTENSION(handle, fsp, struct fio, NULL);
        fio->type = ADOUBLE_RSRC;
        fio->config = config;
 
@@ -3776,11 +4010,11 @@ static int fruit_rmdir(struct vfs_handle_struct *handle,
                TALLOC_FREE(ad);
 
                ret = SMB_VFS_NEXT_UNLINK(handle, ad_smb_fname);
-               TALLOC_FREE(ad_smb_fname);
                if (ret != 0) {
                        DBG_ERR("Deleting [%s] failed\n",
                                smb_fname_str_dbg(ad_smb_fname));
                }
+               TALLOC_FREE(ad_smb_fname);
        }
 
 exit_rmdir:
@@ -3878,6 +4112,11 @@ static ssize_t fruit_pread_meta(vfs_handle_struct *handle,
                return 0;
        }
 
+       if (fio == NULL) {
+               DBG_ERR("Failed to fetch fsp extension");
+               return -1;
+       }
+
        /* Yes, macOS always reads from offset 0 */
        offset = 0;
        to_return = MIN(n, AFP_INFO_SIZE);
@@ -3941,6 +4180,11 @@ static ssize_t fruit_pread_rsrc(vfs_handle_struct *handle,
        struct fio *fio = (struct fio *)VFS_FETCH_FSP_EXTENSION(handle, fsp);
        ssize_t nread;
 
+       if (fio == NULL) {
+               errno = EINVAL;
+               return -1;
+       }
+
        switch (fio->config->rsrc) {
        case FRUIT_RSRC_STREAM:
                nread = fruit_pread_rsrc_stream(handle, fsp, data, n, offset);
@@ -4090,26 +4334,35 @@ static ssize_t fruit_pwrite_meta_stream(vfs_handle_struct *handle,
                                        size_t n, off_t offset)
 {
        AfpInfo *ai = NULL;
-       int ret;
+       size_t nwritten;
+       bool ok;
 
        ai = afpinfo_unpack(talloc_tos(), data);
        if (ai == NULL) {
                return -1;
        }
 
-       if (ai_empty_finderinfo(ai)) {
-               ret = SMB_VFS_NEXT_UNLINK(handle, fsp->fsp_name);
-               if (ret != 0 && errno != ENOENT && errno != ENOATTR) {
-                       DBG_ERR("Can't delete metadata for %s: %s\n",
-                               fsp_str_dbg(fsp), strerror(errno));
-                       TALLOC_FREE(ai);
-                       return -1;
-               }
+       nwritten = SMB_VFS_NEXT_PWRITE(handle, fsp, data, n, offset);
+       if (nwritten != n) {
+               return -1;
+       }
 
+       if (!ai_empty_finderinfo(ai)) {
                return n;
        }
 
-       return SMB_VFS_NEXT_PWRITE(handle, fsp, data, n, offset);
+       ok = set_delete_on_close(
+                       fsp,
+                       true,
+                       handle->conn->session_info->security_token,
+                       handle->conn->session_info->unix_token);
+       if (!ok) {
+               DBG_ERR("set_delete_on_close on [%s] failed\n",
+                       fsp_str_dbg(fsp));
+               return -1;
+       }
+
+       return n;
 }
 
 static ssize_t fruit_pwrite_meta_netatalk(vfs_handle_struct *handle,
@@ -4120,26 +4373,13 @@ static ssize_t fruit_pwrite_meta_netatalk(vfs_handle_struct *handle,
        AfpInfo *ai = NULL;
        char *p = NULL;
        int ret;
+       bool ok;
 
        ai = afpinfo_unpack(talloc_tos(), data);
        if (ai == NULL) {
                return -1;
        }
 
-       if (ai_empty_finderinfo(ai)) {
-               ret = SMB_VFS_REMOVEXATTR(handle->conn,
-                                         fsp->fsp_name,
-                                         AFPINFO_EA_NETATALK);
-
-               if (ret != 0 && errno != ENOENT && errno != ENOATTR) {
-                       DBG_ERR("Can't delete metadata for %s: %s\n",
-                               fsp_str_dbg(fsp), strerror(errno));
-                       return -1;
-               }
-
-               return n;
-       }
-
        ad = ad_fget(talloc_tos(), handle, fsp, ADOUBLE_META);
        if (ad == NULL) {
                ad = ad_init(talloc_tos(), handle, ADOUBLE_META);
@@ -4164,6 +4404,22 @@ static ssize_t fruit_pwrite_meta_netatalk(vfs_handle_struct *handle,
        }
 
        TALLOC_FREE(ad);
+
+       if (!ai_empty_finderinfo(ai)) {
+               return n;
+       }
+
+       ok = set_delete_on_close(
+               fsp,
+               true,
+               handle->conn->session_info->security_token,
+               handle->conn->session_info->unix_token);
+       if (!ok) {
+               DBG_ERR("set_delete_on_close on [%s] failed\n",
+                       fsp_str_dbg(fsp));
+               return -1;
+       }
+
        return n;
 }
 
@@ -4187,6 +4443,11 @@ static ssize_t fruit_pwrite_meta(vfs_handle_struct *handle,
                return -1;
        }
 
+       if (fio == NULL) {
+               DBG_ERR("Failed to fetch fsp extension");
+               return -1;
+       }
+
        switch (fio->config->meta) {
        case FRUIT_META_STREAM:
                nwritten = fruit_pwrite_meta_stream(handle, fsp, data,
@@ -4264,6 +4525,11 @@ static ssize_t fruit_pwrite_rsrc(vfs_handle_struct *handle,
        struct fio *fio = (struct fio *)VFS_FETCH_FSP_EXTENSION(handle, fsp);
        ssize_t nwritten;
 
+       if (fio == NULL) {
+               DBG_ERR("Failed to fetch fsp extension");
+               return -1;
+       }
+
        switch (fio->config->rsrc) {
        case FRUIT_RSRC_STREAM:
                nwritten = fruit_pwrite_rsrc_stream(handle, fsp, data, n, offset);
@@ -4820,6 +5086,40 @@ static int fruit_fstat(vfs_handle_struct *handle, files_struct *fsp,
        return rc;
 }
 
+static NTSTATUS delete_invalid_meta_stream(
+       vfs_handle_struct *handle,
+       const struct smb_filename *smb_fname,
+       TALLOC_CTX *mem_ctx,
+       unsigned int *pnum_streams,
+       struct stream_struct **pstreams)
+{
+       struct smb_filename *sname = NULL;
+       int ret;
+       bool ok;
+
+       ok = del_fruit_stream(mem_ctx, pnum_streams, pstreams, AFPINFO_STREAM);
+       if (!ok) {
+               return NT_STATUS_INTERNAL_ERROR;
+       }
+
+       sname = synthetic_smb_fname(talloc_tos(),
+                                   smb_fname->base_name,
+                                   AFPINFO_STREAM_NAME,
+                                   NULL, 0);
+       if (sname == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       ret = SMB_VFS_NEXT_UNLINK(handle, sname);
+       TALLOC_FREE(sname);
+       if (ret != 0) {
+               DBG_ERR("Removing [%s] failed\n", smb_fname_str_dbg(sname));
+               return map_nt_error_from_unix(errno);
+       }
+
+       return NT_STATUS_OK;
+}
+
 static NTSTATUS fruit_streaminfo_meta_stream(
        vfs_handle_struct *handle,
        struct files_struct *fsp,
@@ -4831,8 +5131,14 @@ static NTSTATUS fruit_streaminfo_meta_stream(
        struct stream_struct *stream = *pstreams;
        unsigned int num_streams = *pnum_streams;
        struct smb_filename *sname = NULL;
+       char *full_name = NULL;
+       uint32_t name_hash;
+       struct share_mode_lock *lck = NULL;
+       struct file_id id = {0};
+       bool delete_on_close_set;
        int i;
        int ret;
+       NTSTATUS status;
        bool ok;
 
        for (i = 0; i < num_streams; i++) {
@@ -4845,35 +5151,76 @@ static NTSTATUS fruit_streaminfo_meta_stream(
                return NT_STATUS_OK;
        }
 
-       if (stream[i].size == AFP_INFO_SIZE) {
-               return NT_STATUS_OK;
-       }
+       if (stream[i].size != AFP_INFO_SIZE) {
+               DBG_ERR("Removing invalid AFPINFO_STREAM size [%jd] from [%s]\n",
+                       (intmax_t)stream[i].size, smb_fname_str_dbg(smb_fname));
 
-       DBG_ERR("Removing invalid AFPINFO_STREAM size [%"PRIdMAX"] "
-               "from [%s]\n", (intmax_t)stream[i].size,
-               smb_fname_str_dbg(smb_fname));
-
-       ok = del_fruit_stream(mem_ctx, pnum_streams, pstreams, AFPINFO_STREAM);
-       if (!ok) {
-               return NT_STATUS_INTERNAL_ERROR;
+               return delete_invalid_meta_stream(handle, smb_fname, mem_ctx,
+                                                 pnum_streams, pstreams);
        }
 
+       /*
+        * Now check if there's a delete-on-close pending on the stream. If so,
+        * hide the stream. This behaviour was verified against a macOS 10.12
+        * SMB server.
+        */
+
        sname = synthetic_smb_fname(talloc_tos(),
                                    smb_fname->base_name,
                                    AFPINFO_STREAM_NAME,
                                    NULL, 0);
        if (sname == NULL) {
-               return NT_STATUS_NO_MEMORY;
+               status = NT_STATUS_NO_MEMORY;
+               goto out;
        }
 
-       ret = SMB_VFS_NEXT_UNLINK(handle, sname);
-       TALLOC_FREE(sname);
+       ret = SMB_VFS_NEXT_STAT(handle, sname);
        if (ret != 0) {
-               DBG_ERR("Removing [%s] failed\n", smb_fname_str_dbg(sname));
-               return map_nt_error_from_unix(errno);
+               status = map_nt_error_from_unix(errno);
+               goto out;
        }
 
-       return NT_STATUS_OK;
+       id = SMB_VFS_NEXT_FILE_ID_CREATE(handle, &sname->st);
+
+       lck = get_existing_share_mode_lock(talloc_tos(), id);
+       if (lck == NULL) {
+               status = NT_STATUS_OK;
+               goto out;
+       }
+
+       full_name = talloc_asprintf(talloc_tos(),
+                                   "%s%s",
+                                   sname->base_name,
+                                   AFPINFO_STREAM);
+       if (full_name == NULL) {
+               status = NT_STATUS_NO_MEMORY;
+               goto out;
+       }
+
+       status = file_name_hash(handle->conn, full_name, &name_hash);
+       if (!NT_STATUS_IS_OK(status)) {
+               goto out;
+       }
+
+       delete_on_close_set = is_delete_on_close_set(lck, name_hash);
+       if (delete_on_close_set) {
+               ok = del_fruit_stream(mem_ctx,
+                                     pnum_streams,
+                                     pstreams,
+                                     AFPINFO_STREAM);
+               if (!ok) {
+                       status = NT_STATUS_INTERNAL_ERROR;
+                       goto out;
+               }
+       }
+
+       status  = NT_STATUS_OK;
+
+out:
+       TALLOC_FREE(sname);
+       TALLOC_FREE(lck);
+       TALLOC_FREE(full_name);
+       return status;
 }
 
 static NTSTATUS fruit_streaminfo_meta_netatalk(
@@ -5269,6 +5616,11 @@ static int fruit_ftruncate_rsrc(struct vfs_handle_struct *handle,
        struct fio *fio = (struct fio *)VFS_FETCH_FSP_EXTENSION(handle, fsp);
        int ret;
 
+       if (fio == NULL) {
+               DBG_ERR("Failed to fetch fsp extension");
+               return -1;
+       }
+
        switch (fio->config->rsrc) {
        case FRUIT_RSRC_XATTR:
                ret = fruit_ftruncate_rsrc_xattr(handle, fsp, offset);
@@ -5320,6 +5672,13 @@ static int fruit_ftruncate(struct vfs_handle_struct *handle,
                  (intmax_t)offset);
 
        if (fio == NULL) {
+               if (offset == 0 &&
+                   global_fruit_config.nego_aapl &&
+                   is_ntfs_stream_smb_fname(fsp->fsp_name) &&
+                   !is_ntfs_default_stream_smb_fname(fsp->fsp_name))
+               {
+                       return SMB_VFS_NEXT_UNLINK(handle, fsp->fsp_name);
+               }
                return SMB_VFS_NEXT_FTRUNCATE(handle, fsp, offset);
        }
 
@@ -5540,6 +5899,13 @@ static NTSTATUS fruit_fget_nt_acl(vfs_handle_struct *handle,
                return NT_STATUS_OK;
        }
 
+       /* First remove any existing ACE's with NFS style mode/uid/gid SIDs. */
+       status = remove_virtual_nfs_aces(*ppdesc);
+       if (!NT_STATUS_IS_OK(status)) {
+               DBG_WARNING("failed to remove MS NFS style ACEs\n");
+               return status;
+       }
+
        /* MS NFS style mode */
        sid_compose(&sid, &global_sid_Unix_NFS_Mode, fsp->fsp_name->st.st_ex_mode);
        init_sec_ace(&ace, &sid, SEC_ACE_TYPE_ACCESS_DENIED, 0, 0);
@@ -5573,24 +5939,53 @@ static NTSTATUS fruit_fget_nt_acl(vfs_handle_struct *handle,
 static NTSTATUS fruit_fset_nt_acl(vfs_handle_struct *handle,
                                  files_struct *fsp,
                                  uint32_t security_info_sent,
-                                 const struct security_descriptor *psd)
+                                 const struct security_descriptor *orig_psd)
 {
        NTSTATUS status;
        bool do_chmod;
        mode_t ms_nfs_mode = 0;
        int result;
+       struct security_descriptor *psd = NULL;
+       uint32_t orig_num_aces = 0;
+
+       if (orig_psd->dacl != NULL) {
+               orig_num_aces = orig_psd->dacl->num_aces;
+       }
+
+       psd = security_descriptor_copy(talloc_tos(), orig_psd);
+       if (psd == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
 
        DBG_DEBUG("fruit_fset_nt_acl: %s\n", fsp_str_dbg(fsp));
 
        status = check_ms_nfs(handle, fsp, psd, &ms_nfs_mode, &do_chmod);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(1, ("fruit_fset_nt_acl: check_ms_nfs failed%s\n", fsp_str_dbg(fsp)));
+               TALLOC_FREE(psd);
                return status;
        }
 
+       /*
+        * If only ms_nfs ACE entries were sent, ensure we set the DACL
+        * sent/present flags correctly now we've removed them.
+        */
+
+       if (orig_num_aces != 0) {
+               /*
+                * Are there any ACE's left ?
+                */
+               if (psd->dacl->num_aces == 0) {
+                       /* No - clear the DACL sent/present flags. */
+                       security_info_sent &= ~SECINFO_DACL;
+                       psd->type &= ~SEC_DESC_DACL_PRESENT;
+               }
+       }
+
        status = SMB_VFS_NEXT_FSET_NT_ACL(handle, fsp, security_info_sent, psd);
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(1, ("fruit_fset_nt_acl: SMB_VFS_NEXT_FSET_NT_ACL failed%s\n", fsp_str_dbg(fsp)));
+               TALLOC_FREE(psd);
                return status;
        }
 
@@ -5608,10 +6003,12 @@ static NTSTATUS fruit_fset_nt_acl(vfs_handle_struct *handle,
                                  result, (unsigned)ms_nfs_mode,
                                  strerror(errno)));
                        status = map_nt_error_from_unix(errno);
+                       TALLOC_FREE(psd);
                        return status;
                }
        }
 
+       TALLOC_FREE(psd);
        return NT_STATUS_OK;
 }
 
@@ -5937,8 +6334,426 @@ static NTSTATUS fruit_offload_write_recv(struct vfs_handle_struct *handle,
        return NT_STATUS_OK;
 }
 
+static char *fruit_get_bandsize_line(char **lines, int numlines)
+{
+       static regex_t re;
+       static bool re_initialized = false;
+       int i;
+       int ret;
+
+       if (!re_initialized) {
+               ret = regcomp(&re, "^[[:blank:]]*<key>band-size</key>$", 0);
+               if (ret != 0) {
+                       return NULL;
+               }
+               re_initialized = true;
+       }
+
+       for (i = 0; i < numlines; i++) {
+               regmatch_t matches[1];
+
+               ret = regexec(&re, lines[i], 1, matches, 0);
+               if (ret == 0) {
+                       /*
+                        * Check if the match was on the last line, sa we want
+                        * the subsequent line.
+                        */
+                       if (i + 1 == numlines) {
+                               return NULL;
+                       }
+                       return lines[i + 1];
+               }
+               if (ret != REG_NOMATCH) {
+                       return NULL;
+               }
+       }
+
+       return NULL;
+}
+
+static bool fruit_get_bandsize_from_line(char *line, size_t *_band_size)
+{
+       static regex_t re;
+       static bool re_initialized = false;
+       regmatch_t matches[2];
+       uint64_t band_size;
+       int ret;
+       bool ok;
+
+       if (!re_initialized) {
+               ret = regcomp(&re,
+                             "^[[:blank:]]*"
+                             "<integer>\\([[:digit:]]*\\)</integer>$",
+                             0);
+               if (ret != 0) {
+                       return false;
+               }
+               re_initialized = true;
+       }
+
+       ret = regexec(&re, line, 2, matches, 0);
+       if (ret != 0) {
+               DBG_ERR("regex failed [%s]\n", line);
+               return false;
+       }
+
+       line[matches[1].rm_eo] = '\0';
+
+       ok = conv_str_u64(&line[matches[1].rm_so], &band_size);
+       if (!ok) {
+               return false;
+       }
+       *_band_size = (size_t)band_size;
+       return true;
+}
+
+/*
+ * This reads and parses an Info.plist from a TM sparsebundle looking for the
+ * "band-size" key and value.
+ */
+static bool fruit_get_bandsize(vfs_handle_struct *handle,
+                              const char *dir,
+                              size_t *band_size)
+{
+#define INFO_PLIST_MAX_SIZE 64*1024
+       char *plist = NULL;
+       struct smb_filename *smb_fname = NULL;
+       files_struct *fsp = NULL;
+       uint8_t *file_data = NULL;
+       char **lines = NULL;
+       char *band_size_line = NULL;
+       size_t plist_file_size;
+       ssize_t nread;
+       int numlines;
+       int ret;
+       bool ok = false;
+       NTSTATUS status;
+
+       plist = talloc_asprintf(talloc_tos(),
+                               "%s/%s/Info.plist",
+                               handle->conn->connectpath,
+                               dir);
+       if (plist == NULL) {
+               ok = false;
+               goto out;
+       }
+
+       smb_fname = synthetic_smb_fname(talloc_tos(), plist, NULL, NULL, 0);
+       if (smb_fname == NULL) {
+               ok = false;
+               goto out;
+       }
+
+       ret = SMB_VFS_NEXT_LSTAT(handle, smb_fname);
+       if (ret != 0) {
+               DBG_INFO("Ignoring Sparsebundle without Info.plist [%s]\n", dir);
+               ok = true;
+               goto out;
+       }
+
+       plist_file_size = smb_fname->st.st_ex_size;
+
+       if (plist_file_size > INFO_PLIST_MAX_SIZE) {
+               DBG_INFO("%s is too large, ignoring\n", plist);
+               ok = true;
+               goto out;
+       }
+
+       status = SMB_VFS_NEXT_CREATE_FILE(
+               handle,                         /* conn */
+               NULL,                           /* req */
+               0,                              /* root_dir_fid */
+               smb_fname,                      /* fname */
+               FILE_GENERIC_READ,              /* access_mask */
+               FILE_SHARE_READ | FILE_SHARE_WRITE, /* share_access */
+               FILE_OPEN,                      /* create_disposition */
+               0,                              /* create_options */
+               0,                              /* file_attributes */
+               INTERNAL_OPEN_ONLY,             /* oplock_request */
+               NULL,                           /* lease */
+               0,                              /* allocation_size */
+               0,                              /* private_flags */
+               NULL,                           /* sd */
+               NULL,                           /* ea_list */
+               &fsp,                           /* result */
+               NULL,                           /* psbuf */
+               NULL, NULL);                    /* create context */
+       if (!NT_STATUS_IS_OK(status)) {
+               DBG_INFO("Opening [%s] failed [%s]\n",
+                        smb_fname_str_dbg(smb_fname), nt_errstr(status));
+               ok = false;
+               goto out;
+       }
+
+       file_data = talloc_array(talloc_tos(), uint8_t, plist_file_size);
+       if (file_data == NULL) {
+               ok = false;
+               goto out;
+       }
+
+       nread = SMB_VFS_NEXT_PREAD(handle, fsp, file_data, plist_file_size, 0);
+       if (nread != plist_file_size) {
+               DBG_ERR("Short read on [%s]: %zu/%zd\n",
+                       fsp_str_dbg(fsp), nread, plist_file_size);
+               ok = false;
+               goto out;
+
+       }
+
+       status = close_file(NULL, fsp, NORMAL_CLOSE);
+       fsp = NULL;
+       if (!NT_STATUS_IS_OK(status)) {
+               DBG_ERR("close_file failed: %s\n", nt_errstr(status));
+               ok = false;
+               goto out;
+       }
+
+       lines = file_lines_parse((char *)file_data,
+                                plist_file_size,
+                                &numlines,
+                                talloc_tos());
+       if (lines == NULL) {
+               ok = false;
+               goto out;
+       }
+
+       band_size_line = fruit_get_bandsize_line(lines, numlines);
+       if (band_size_line == NULL) {
+               DBG_ERR("Didn't find band-size key in [%s]\n",
+                       smb_fname_str_dbg(smb_fname));
+               ok = false;
+               goto out;
+       }
+
+       ok = fruit_get_bandsize_from_line(band_size_line, band_size);
+       if (!ok) {
+               DBG_ERR("fruit_get_bandsize_from_line failed\n");
+               goto out;
+       }
+
+       DBG_DEBUG("Parsed band-size [%zu] for [%s]\n", *band_size, plist);
+
+out:
+       if (fsp != NULL) {
+               status = close_file(NULL, fsp, NORMAL_CLOSE);
+               if (!NT_STATUS_IS_OK(status)) {
+                       DBG_ERR("close_file failed: %s\n", nt_errstr(status));
+               }
+               fsp = NULL;
+       }
+       TALLOC_FREE(plist);
+       TALLOC_FREE(smb_fname);
+       TALLOC_FREE(file_data);
+       TALLOC_FREE(lines);
+       return ok;
+}
+
+struct fruit_disk_free_state {
+       off_t total_size;
+};
+
+static bool fruit_get_num_bands(vfs_handle_struct *handle,
+                               char *bundle,
+                               size_t *_nbands)
+{
+       char *path = NULL;
+       struct smb_filename *bands_dir = NULL;
+       DIR *d = NULL;
+       struct dirent *e = NULL;
+       size_t nbands;
+       int ret;
+
+       path = talloc_asprintf(talloc_tos(),
+                              "%s/%s/bands",
+                              handle->conn->connectpath,
+                              bundle);
+       if (path == NULL) {
+               return false;
+       }
+
+       bands_dir = synthetic_smb_fname(talloc_tos(),
+                                       path,
+                                       NULL,
+                                       NULL,
+                                       0);
+       TALLOC_FREE(path);
+       if (bands_dir == NULL) {
+               return false;
+       }
+
+       d = SMB_VFS_NEXT_OPENDIR(handle, bands_dir, NULL, 0);
+       if (d == NULL) {
+               TALLOC_FREE(bands_dir);
+               return false;
+       }
+
+       nbands = 0;
+
+       for (e = SMB_VFS_NEXT_READDIR(handle, d, NULL);
+            e != NULL;
+            e = SMB_VFS_NEXT_READDIR(handle, d, NULL))
+       {
+               if (ISDOT(e->d_name) || ISDOTDOT(e->d_name)) {
+                       continue;
+               }
+               nbands++;
+       }
+
+       ret = SMB_VFS_NEXT_CLOSEDIR(handle, d);
+       if (ret != 0) {
+               TALLOC_FREE(bands_dir);
+               return false;
+       }
+
+       DBG_DEBUG("%zu bands in [%s]\n", nbands, smb_fname_str_dbg(bands_dir));
+
+       TALLOC_FREE(bands_dir);
+
+       *_nbands = nbands;
+       return true;
+}
+
+static bool fruit_tmsize_do_dirent(vfs_handle_struct *handle,
+                                  struct fruit_disk_free_state *state,
+                                  struct dirent *e)
+{
+       bool ok;
+       char *p = NULL;
+       size_t sparsebundle_strlen = strlen("sparsebundle");
+       size_t bandsize = 0;
+       size_t nbands;
+       off_t tm_size;
+
+       p = strstr(e->d_name, "sparsebundle");
+       if (p == NULL) {
+               return true;
+       }
+
+       if (p[sparsebundle_strlen] != '\0') {
+               return true;
+       }
+
+       DBG_DEBUG("Processing sparsebundle [%s]\n", e->d_name);
+
+       ok = fruit_get_bandsize(handle, e->d_name, &bandsize);
+       if (!ok) {
+               /*
+                * Beware of race conditions: this may be an uninitialized
+                * Info.plist that a client is just creating. We don't want let
+                * this to trigger complete failure.
+                */
+               DBG_ERR("Processing sparsebundle [%s] failed\n", e->d_name);
+               return true;
+       }
+
+       ok = fruit_get_num_bands(handle, e->d_name, &nbands);
+       if (!ok) {
+               /*
+                * Beware of race conditions: this may be a backup sparsebundle
+                * in an early stage lacking a bands subdirectory. We don't want
+                * let this to trigger complete failure.
+                */
+               DBG_ERR("Processing sparsebundle [%s] failed\n", e->d_name);
+               return true;
+       }
+
+       if (bandsize > SIZE_MAX/nbands) {
+               DBG_ERR("tmsize overflow: bandsize [%zu] nbands [%zu]\n",
+                       bandsize, nbands);
+               return false;
+       }
+       tm_size = bandsize * nbands;
+
+       if (state->total_size + tm_size < state->total_size) {
+               DBG_ERR("tmsize overflow: bandsize [%zu] nbands [%zu]\n",
+                       bandsize, nbands);
+               return false;
+       }
+
+       state->total_size += tm_size;
+
+       DBG_DEBUG("[%s] tm_size [%jd] total_size [%jd]\n",
+                 e->d_name, (intmax_t)tm_size, (intmax_t)state->total_size);
+
+       return true;
+}
+
+/**
+ * Calculate used size of a TimeMachine volume
+ *
+ * This assumes that the volume is used only for TimeMachine.
+ *
+ * - readdir(basedir of share), then
+ * - for every element that matches regex "^\(.*\)\.sparsebundle$" :
+ * - parse "\1.sparsebundle/Info.plist" and read the band-size XML key
+ * - count band files in "\1.sparsebundle/bands/"
+ * - calculate used size of all bands: band_count * band_size
+ **/
+static uint64_t fruit_disk_free(vfs_handle_struct *handle,
+                               const struct smb_filename *smb_fname,
+                               uint64_t *_bsize,
+                               uint64_t *_dfree,
+                               uint64_t *_dsize)
+{
+       struct fruit_config_data *config = NULL;
+       struct fruit_disk_free_state state = {0};
+       DIR *d = NULL;
+       struct dirent *e = NULL;
+       uint64_t dfree;
+       uint64_t dsize;
+       int ret;
+       bool ok;
+
+       SMB_VFS_HANDLE_GET_DATA(handle, config,
+                               struct fruit_config_data,
+                               return UINT64_MAX);
+
+       if (!config->time_machine ||
+           config->time_machine_max_size == 0)
+       {
+               return SMB_VFS_NEXT_DISK_FREE(handle,
+                                             smb_fname,
+                                             _bsize,
+                                             _dfree,
+                                             _dsize);
+       }
+
+       d = SMB_VFS_NEXT_OPENDIR(handle, smb_fname, NULL, 0);
+       if (d == NULL) {
+               return UINT64_MAX;
+       }
+
+       for (e = SMB_VFS_NEXT_READDIR(handle, d, NULL);
+            e != NULL;
+            e = SMB_VFS_NEXT_READDIR(handle, d, NULL))
+       {
+               ok = fruit_tmsize_do_dirent(handle, &state, e);
+               if (!ok) {
+                       SMB_VFS_NEXT_CLOSEDIR(handle, d);
+                       return UINT64_MAX;
+               }
+       }
+
+       ret = SMB_VFS_NEXT_CLOSEDIR(handle, d);
+       if (ret != 0) {
+               return UINT64_MAX;
+       }
+
+       dsize = config->time_machine_max_size / 512;
+       dfree = dsize - (state.total_size / 512);
+       if (dfree > dsize) {
+               dfree = 0;
+       }
+
+       *_bsize = 512;
+       *_dsize = dsize;
+       *_dfree = dfree;
+       return dfree / 2;
+}
+
 static struct vfs_fn_pointers vfs_fruit_fns = {
        .connect_fn = fruit_connect,
+       .disk_free_fn = fruit_disk_free,
 
        /* File operations */
        .chmod_fn = fruit_chmod,
@@ -5972,7 +6787,7 @@ static struct vfs_fn_pointers vfs_fruit_fns = {
        .fset_nt_acl_fn = fruit_fset_nt_acl,
 };
 
-NTSTATUS vfs_fruit_init(TALLOC_CTX *);
+static_decl_vfs;
 NTSTATUS vfs_fruit_init(TALLOC_CTX *ctx)
 {
        NTSTATUS ret = smb_register_vfs(SMB_VFS_INTERFACE_VERSION, "fruit",