torture3: Fix CID 1435119 Error handling issues (CHECKED_RETURN)
[samba.git] / source3 / lib / util_tdb.c
index 1d210a1e579921b0e0cc51cfdfa6b70f1efdf2e5..1e533e825346bf39cf0cfb2ec6d4f0e844346bba 100644 (file)
 */
 
 #include "includes.h"
+#include "system/filesys.h"
+#include "util_tdb.h"
+#include "cbuf.h"
+
 #undef malloc
 #undef realloc
 #undef calloc
 /* these are little tdb utility functions that are meant to make
    dealing with a tdb database a little less cumbersome in Samba */
 
-static SIG_ATOMIC_T gotalarm;
-
-/***************************************************************
- Signal function to tell us we timed out.
-****************************************************************/
-
-static void gotalarm_sig(void)
-{
-       gotalarm = 1;
-}
-
-/****************************************************************************
- Lock a chain with timeout (in seconds).
-****************************************************************************/
-
-static int tdb_chainlock_with_timeout_internal( TDB_CONTEXT *tdb, TDB_DATA key, unsigned int timeout, int rw_type)
-{
-       /* Allow tdb_chainlock to be interrupted by an alarm. */
-       int ret;
-       gotalarm = 0;
-
-       if (timeout) {
-               CatchSignal(SIGALRM, SIGNAL_CAST gotalarm_sig);
-               tdb_setalarm_sigptr(tdb, &gotalarm);
-               alarm(timeout);
-       }
-
-       if (rw_type == F_RDLCK)
-               ret = tdb_chainlock_read(tdb, key);
-       else
-               ret = tdb_chainlock(tdb, key);
-
-       if (timeout) {
-               alarm(0);
-               tdb_setalarm_sigptr(tdb, NULL);
-               CatchSignal(SIGALRM, SIGNAL_CAST SIG_IGN);
-               if (gotalarm && (ret == -1)) {
-                       DEBUG(0,("tdb_chainlock_with_timeout_internal: alarm (%u) timed out for key %s in tdb %s\n",
-                               timeout, key.dptr, tdb_name(tdb)));
-                       /* TODO: If we time out waiting for a lock, it might
-                        * be nice to use F_GETLK to get the pid of the
-                        * process currently holding the lock and print that
-                        * as part of the debugging message. -- mbp */
-                       return -1;
-               }
-       }
-
-       return ret;
-}
-
-/****************************************************************************
- Write lock a chain. Return -1 if timeout or lock failed.
-****************************************************************************/
-
-int tdb_chainlock_with_timeout( TDB_CONTEXT *tdb, TDB_DATA key, unsigned int timeout)
-{
-       return tdb_chainlock_with_timeout_internal(tdb, key, timeout, F_WRLCK);
-}
-
-int tdb_lock_bystring_with_timeout(TDB_CONTEXT *tdb, const char *keyval,
-                                  int timeout)
-{
-       TDB_DATA key = string_term_tdb_data(keyval);
-
-       return tdb_chainlock_with_timeout(tdb, key, timeout);
-}
-
-/****************************************************************************
- Read lock a chain by string. Return -1 if timeout or lock failed.
-****************************************************************************/
-
-int tdb_read_lock_bystring_with_timeout(TDB_CONTEXT *tdb, const char *keyval, unsigned int timeout)
-{
-       TDB_DATA key = string_term_tdb_data(keyval);
-
-       return tdb_chainlock_with_timeout_internal(tdb, key, timeout, F_RDLCK);
-}
-
-
-
-
 int tdb_trans_store_bystring(TDB_CONTEXT *tdb, const char *keystr,
                             TDB_DATA data, int flags)
 {
@@ -122,17 +45,17 @@ int tdb_trans_store_bystring(TDB_CONTEXT *tdb, const char *keystr,
  integers and strings.
 ****************************************************************************/
 
-static size_t tdb_pack_va(uint8 *buf, int bufsize, const char *fmt, va_list ap)
+static size_t tdb_pack_va(uint8_t *buf, int bufsize, const char *fmt, va_list ap)
 {
-       uint8 bt;
-       uint16 w;
-       uint32 d;
+       uint8_t bt;
+       uint16_t w;
+       uint32_t d;
        int i;
        void *p;
        int len;
        char *s;
        char c;
-       uint8 *buf0 = buf;
+       uint8_t *buf0 = buf;
        const char *fmt0 = fmt;
        int bufsize0 = bufsize;
 
@@ -140,19 +63,19 @@ static size_t tdb_pack_va(uint8 *buf, int bufsize, const char *fmt, va_list ap)
                switch ((c = *fmt++)) {
                case 'b': /* unsigned 8-bit integer */
                        len = 1;
-                       bt = (uint8)va_arg(ap, int);
+                       bt = (uint8_t)va_arg(ap, int);
                        if (bufsize && bufsize >= len)
                                SSVAL(buf, 0, bt);
                        break;
                case 'w': /* unsigned 16-bit integer */
                        len = 2;
-                       w = (uint16)va_arg(ap, int);
+                       w = (uint16_t)va_arg(ap, int);
                        if (bufsize && bufsize >= len)
                                SSVAL(buf, 0, w);
                        break;
                case 'd': /* signed 32-bit integer (standard int in most systems) */
                        len = 4;
-                       d = va_arg(ap, uint32);
+                       d = va_arg(ap, uint32_t);
                        if (bufsize && bufsize >= len)
                                SIVAL(buf, 0, d);
                        break;
@@ -206,7 +129,7 @@ static size_t tdb_pack_va(uint8 *buf, int bufsize, const char *fmt, va_list ap)
        return PTR_DIFF(buf, buf0);
 }
 
-size_t tdb_pack(uint8 *buf, int bufsize, const char *fmt, ...)
+size_t tdb_pack(uint8_t *buf, int bufsize, const char *fmt, ...)
 {
        va_list ap;
        size_t result;
@@ -217,7 +140,7 @@ size_t tdb_pack(uint8 *buf, int bufsize, const char *fmt, ...)
        return result;
 }
 
-bool tdb_pack_append(TALLOC_CTX *mem_ctx, uint8 **buf, size_t *len,
+bool tdb_pack_append(TALLOC_CTX *mem_ctx, uint8_t **buf, size_t *len,
                     const char *fmt, ...)
 {
        va_list ap;
@@ -228,10 +151,10 @@ bool tdb_pack_append(TALLOC_CTX *mem_ctx, uint8 **buf, size_t *len,
        va_end(ap);
 
        if (mem_ctx != NULL) {
-               *buf = TALLOC_REALLOC_ARRAY(mem_ctx, *buf, uint8,
+               *buf = talloc_realloc(mem_ctx, *buf, uint8_t,
                                            (*len) + len1);
        } else {
-               *buf = SMB_REALLOC_ARRAY(*buf, uint8, (*len) + len1);
+               *buf = SMB_REALLOC_ARRAY(*buf, uint8_t, (*len) + len1);
        }
 
        if (*buf == NULL) {
@@ -256,18 +179,18 @@ bool tdb_pack_append(TALLOC_CTX *mem_ctx, uint8 **buf, size_t *len,
  integers and strings.
 ****************************************************************************/
 
-int tdb_unpack(const uint8 *buf, int bufsize, const char *fmt, ...)
+int tdb_unpack(const uint8_t *buf, int bufsize, const char *fmt, ...)
 {
        va_list ap;
-       uint8 *bt;
-       uint16 *w;
-       uint32 *d;
+       uint8_t *bt;
+       uint16_t *w;
+       uint32_t *d;
        int len;
        int *i;
        void **p;
        char *s, **b, **ps;
        char c;
-       const uint8 *buf0 = buf;
+       const uint8_t *buf0 = buf;
        const char *fmt0 = fmt;
        int bufsize0 = bufsize;
 
@@ -277,21 +200,21 @@ int tdb_unpack(const uint8 *buf, int bufsize, const char *fmt, ...)
                switch ((c=*fmt++)) {
                case 'b': /* unsigned 8-bit integer */
                        len = 1;
-                       bt = va_arg(ap, uint8 *);
+                       bt = va_arg(ap, uint8_t *);
                        if (bufsize < len)
                                goto no_space;
                        *bt = SVAL(buf, 0);
                        break;
                case 'w': /* unsigned 16-bit integer */
                        len = 2;
-                       w = va_arg(ap, uint16 *);
+                       w = va_arg(ap, uint16_t *);
                        if (bufsize < len)
                                goto no_space;
                        *w = SVAL(buf, 0);
                        break;
-               case 'd': /* signed 32-bit integer (standard int in most systems) */
+               case 'd': /* unsigned 32-bit integer (standard int in most systems) */
                        len = 4;
-                       d = va_arg(ap, uint32 *);
+                       d = va_arg(ap, uint32_t *);
                        if (bufsize < len)
                                goto no_space;
                        *d = IVAL(buf, 0);
@@ -311,12 +234,17 @@ int tdb_unpack(const uint8 *buf, int bufsize, const char *fmt, ...)
                case 'P': /* null-terminated string */
                        /* Return malloc'ed string. */
                        ps = va_arg(ap,char **);
-                       len = strlen((const char *)buf) + 1;
+                       len = strnlen((const char *)buf, bufsize) + 1;
+                       if (bufsize < len)
+                               goto no_space;
                        *ps = SMB_STRDUP((const char *)buf);
+                       if (*ps == NULL) {
+                               goto no_space;
+                       }
                        break;
                case 'f': /* null-terminated string */
                        s = va_arg(ap,char *);
-                       len = strlen((const char *)buf) + 1;
+                       len = strnlen((const char *)buf, bufsize) + 1;
                        if (bufsize < len || len > sizeof(fstring))
                                goto no_space;
                        memcpy(s, buf, len);
@@ -369,6 +297,9 @@ int tdb_unpack(const uint8 *buf, int bufsize, const char *fmt, ...)
  Log tdb messages via DEBUG().
 ****************************************************************************/
 
+static void tdb_log(TDB_CONTEXT *tdb, enum tdb_debug_level level,
+                   const char *format, ...) PRINTF_ATTRIBUTE(3,4);
+
 static void tdb_log(TDB_CONTEXT *tdb, enum tdb_debug_level level, const char *format, ...)
 {
        va_list ap;
@@ -395,14 +326,11 @@ TDB_CONTEXT *tdb_open_log(const char *name, int hash_size, int tdb_flags,
                          int open_flags, mode_t mode)
 {
        TDB_CONTEXT *tdb;
-       struct tdb_logging_context log_ctx;
+       struct tdb_logging_context log_ctx = { .log_fn = tdb_log };
 
        if (!lp_use_mmap())
                tdb_flags |= TDB_NOMMAP;
 
-       log_ctx.log_fn = tdb_log;
-       log_ctx.log_private = NULL;
-
        if ((hash_size == 0) && (name != NULL)) {
                const char *base = strrchr_m(name, '/');
                if (base != NULL) {
@@ -414,7 +342,7 @@ TDB_CONTEXT *tdb_open_log(const char *name, int hash_size, int tdb_flags,
                hash_size = lp_parm_int(-1, "tdb_hashsize", base, 0);
        }
 
-       tdb = tdb_open_ex(name, hash_size, tdb_flags, 
+       tdb = tdb_open_ex(name, hash_size, tdb_flags,
                          open_flags, mode, &log_ctx, NULL);
        if (!tdb)
                return NULL;
@@ -439,9 +367,7 @@ int tdb_trans_store(struct tdb_context *tdb, TDB_DATA key, TDB_DATA dbuf,
 
        if ((res = tdb_store(tdb, key, dbuf, flag)) != 0) {
                DEBUG(10, ("tdb_store failed\n"));
-               if (tdb_transaction_cancel(tdb) != 0) {
-                       smb_panic("Cancelling transaction failed");
-               }
+               tdb_transaction_cancel(tdb);
                return res;
        }
 
@@ -468,9 +394,7 @@ int tdb_trans_delete(struct tdb_context *tdb, TDB_DATA key)
 
        if ((res = tdb_delete(tdb, key)) != 0) {
                DEBUG(10, ("tdb_delete failed\n"));
-               if (tdb_transaction_cancel(tdb) != 0) {
-                       smb_panic("Cancelling transaction failed");
-               }
+               tdb_transaction_cancel(tdb);
                return res;
        }
 
@@ -481,171 +405,131 @@ int tdb_trans_delete(struct tdb_context *tdb, TDB_DATA key)
        return res;
 }
 
-/*
- Log tdb messages via DEBUG().
-*/
-static void tdb_wrap_log(TDB_CONTEXT *tdb, enum tdb_debug_level level, 
-                        const char *format, ...) PRINTF_ATTRIBUTE(3,4);
-
-static void tdb_wrap_log(TDB_CONTEXT *tdb, enum tdb_debug_level level, 
-                        const char *format, ...)
+int tdb_data_cmp(TDB_DATA t1, TDB_DATA t2)
 {
-       va_list ap;
-       char *ptr = NULL;
-       int debuglevel = 0;
        int ret;
-
-       switch (level) {
-       case TDB_DEBUG_FATAL:
-               debuglevel = 0;
-               break;
-       case TDB_DEBUG_ERROR:
-               debuglevel = 1;
-               break;
-       case TDB_DEBUG_WARNING:
-               debuglevel = 2;
-               break;
-       case TDB_DEBUG_TRACE:
-               debuglevel = 5;
-               break;
-       default:
-               debuglevel = 0;
-       }               
-
-       va_start(ap, format);
-       ret = vasprintf(&ptr, format, ap);
-       va_end(ap);
-
-       if (ret != -1) {
-               const char *name = tdb_name(tdb);
-               DEBUG(debuglevel, ("tdb(%s): %s", name ? name : "unnamed", ptr));
-               free(ptr);
+       if (t1.dptr == NULL && t2.dptr != NULL) {
+               return -1;
        }
+       if (t1.dptr != NULL && t2.dptr == NULL) {
+               return 1;
+       }
+       if (t1.dptr == t2.dptr) {
+               return t1.dsize - t2.dsize;
+       }
+       ret = memcmp(t1.dptr, t2.dptr, MIN(t1.dsize, t2.dsize));
+       if (ret == 0) {
+               return t1.dsize - t2.dsize;
+       }
+       return ret;
 }
 
-static struct tdb_wrap *tdb_list;
-
-/* destroy the last connection to a tdb */
-static int tdb_wrap_destructor(struct tdb_wrap *w)
-{
-       tdb_close(w->tdb);
-       DLIST_REMOVE(tdb_list, w);
-       return 0;
-}                               
-
-/*
-  wrapped connection to a tdb database
-  to close just talloc_free() the tdb_wrap pointer
- */
-struct tdb_wrap *tdb_wrap_open(TALLOC_CTX *mem_ctx,
-                              const char *name, int hash_size, int tdb_flags,
-                              int open_flags, mode_t mode)
+char *tdb_data_string(TALLOC_CTX *mem_ctx, TDB_DATA d)
 {
-       struct tdb_wrap *w;
-       struct tdb_logging_context log_ctx;
-       log_ctx.log_fn = tdb_wrap_log;
-
-       if (!lp_use_mmap())
-               tdb_flags |= TDB_NOMMAP;
-
-       for (w=tdb_list;w;w=w->next) {
-               if (strcmp(name, w->name) == 0) {
-                       /*
-                        * Yes, talloc_reference is exactly what we want
-                        * here. Otherwise we would have to implement our own
-                        * reference counting.
-                        */
-                       return talloc_reference(mem_ctx, w);
-               }
-       }
+       int len;
+       char *ret = NULL;
+       cbuf *ost = cbuf_new(mem_ctx);
 
-       w = talloc(mem_ctx, struct tdb_wrap);
-       if (w == NULL) {
+       if (ost == NULL) {
                return NULL;
        }
 
-       if (!(w->name = talloc_strdup(w, name))) {
-               talloc_free(w);
-               return NULL;
+       len = cbuf_printf(ost, "%zu:", d.dsize);
+       if (len == -1) {
+               goto done;
        }
 
-       if ((hash_size == 0) && (name != NULL)) {
-               const char *base = strrchr_m(name, '/');
-               if (base != NULL) {
-                       base += 1;
-               }
-               else {
-                       base = name;
-               }
-               hash_size = lp_parm_int(-1, "tdb_hashsize", base, 0);
+       if (d.dptr == NULL) {
+               len = cbuf_puts(ost, "<NULL>", -1);
+       } else {
+               len = cbuf_print_quoted(ost, (const char*)d.dptr, d.dsize);
        }
-
-       w->tdb = tdb_open_ex(name, hash_size, tdb_flags, 
-                            open_flags, mode, &log_ctx, NULL);
-       if (w->tdb == NULL) {
-               talloc_free(w);
-               return NULL;
+       if (len == -1) {
+               goto done;
        }
 
-       talloc_set_destructor(w, tdb_wrap_destructor);
+       cbuf_swapptr(ost, &ret, 0);
+       talloc_steal(mem_ctx, ret);
 
-       DLIST_ADD(tdb_list, w);
+done:
+       talloc_free(ost);
+       return ret;
+}
 
-       return w;
+static sig_atomic_t gotalarm;
+
+/***************************************************************
+ Signal function to tell us we timed out.
+****************************************************************/
+
+static void gotalarm_sig(int signum)
+{
+       gotalarm = 1;
 }
 
-NTSTATUS map_nt_error_from_tdb(enum TDB_ERROR err)
+/****************************************************************************
+ Lock a chain with timeout (in seconds).
+****************************************************************************/
+
+static int tdb_chainlock_with_timeout_internal( TDB_CONTEXT *tdb, TDB_DATA key, unsigned int timeout, int rw_type)
 {
-       struct { enum TDB_ERROR err; NTSTATUS status; } map[] =
-               { { TDB_SUCCESS,        NT_STATUS_OK },
-                 { TDB_ERR_CORRUPT,    NT_STATUS_INTERNAL_DB_CORRUPTION },
-                 { TDB_ERR_IO,         NT_STATUS_UNEXPECTED_IO_ERROR },
-                 { TDB_ERR_OOM,        NT_STATUS_NO_MEMORY },
-                 { TDB_ERR_EXISTS,     NT_STATUS_OBJECT_NAME_COLLISION },
-
-                 /*
-                  * TDB_ERR_LOCK is very broad, we could for example
-                  * distinguish between fcntl locks and invalid lock
-                  * sequences. So NT_STATUS_FILE_LOCK_CONFLICT is a
-                  * compromise.
-                  */
-                 { TDB_ERR_LOCK,       NT_STATUS_FILE_LOCK_CONFLICT },
-                 /*
-                  * The next two ones in the enum are not actually used
-                  */
-                 { TDB_ERR_NOLOCK,     NT_STATUS_FILE_LOCK_CONFLICT },
-                 { TDB_ERR_LOCK_TIMEOUT, NT_STATUS_FILE_LOCK_CONFLICT },
-                 { TDB_ERR_NOEXIST,    NT_STATUS_NOT_FOUND },
-                 { TDB_ERR_EINVAL,     NT_STATUS_INVALID_PARAMETER },
-                 { TDB_ERR_RDONLY,     NT_STATUS_ACCESS_DENIED }
-               };
+       /* Allow tdb_chainlock to be interrupted by an alarm. */
+       int ret;
+       gotalarm = 0;
 
-       int i;
+       if (timeout) {
+               CatchSignal(SIGALRM, gotalarm_sig);
+               tdb_setalarm_sigptr(tdb, &gotalarm);
+               alarm(timeout);
+       }
+
+       if (rw_type == F_RDLCK)
+               ret = tdb_chainlock_read(tdb, key);
+       else
+               ret = tdb_chainlock(tdb, key);
 
-       for (i=0; i < sizeof(map) / sizeof(map[0]); i++) {
-               if (err == map[i].err) {
-                       return map[i].status;
+       if (timeout) {
+               alarm(0);
+               tdb_setalarm_sigptr(tdb, NULL);
+               CatchSignal(SIGALRM, SIG_IGN);
+               if (gotalarm && (ret != 0)) {
+                       DEBUG(0,("tdb_chainlock_with_timeout_internal: alarm (%u) timed out for key %s in tdb %s\n",
+                               timeout, key.dptr, tdb_name(tdb)));
+                       /* TODO: If we time out waiting for a lock, it might
+                        * be nice to use F_GETLK to get the pid of the
+                        * process currently holding the lock and print that
+                        * as part of the debugging message. -- mbp */
+                       return -1;
                }
        }
 
-       return NT_STATUS_INTERNAL_ERROR;
+       return ret == 0 ? 0 : -1;
 }
 
-int tdb_data_cmp(TDB_DATA t1, TDB_DATA t2)
+/****************************************************************************
+ Write lock a chain. Return non-zero if timeout or lock failed.
+****************************************************************************/
+
+int tdb_chainlock_with_timeout( TDB_CONTEXT *tdb, TDB_DATA key, unsigned int timeout)
 {
-       int ret;
-       if (t1.dptr == NULL && t2.dptr != NULL) {
-               return -1;
-       }
-       if (t1.dptr != NULL && t2.dptr == NULL) {
-               return 1;
-       }
-       if (t1.dptr == t2.dptr) {
-               return t1.dsize - t2.dsize;
-       }
-       ret = memcmp(t1.dptr, t2.dptr, MIN(t1.dsize, t2.dsize));
-       if (ret == 0) {
-               return t1.dsize - t2.dsize;
-       }
-       return ret;
+       return tdb_chainlock_with_timeout_internal(tdb, key, timeout, F_WRLCK);
+}
+
+int tdb_lock_bystring_with_timeout(TDB_CONTEXT *tdb, const char *keyval,
+                                  int timeout)
+{
+       TDB_DATA key = string_term_tdb_data(keyval);
+
+       return tdb_chainlock_with_timeout(tdb, key, timeout);
+}
+
+/****************************************************************************
+ Read lock a chain by string. Return non-zero if timeout or lock failed.
+****************************************************************************/
+
+int tdb_read_lock_bystring_with_timeout(TDB_CONTEXT *tdb, const char *keyval, unsigned int timeout)
+{
+       TDB_DATA key = string_term_tdb_data(keyval);
+
+       return tdb_chainlock_with_timeout_internal(tdb, key, timeout, F_RDLCK);
 }