s3-talloc Change TALLOC_ARRAY() to talloc_array()
[samba.git] / source3 / groupdb / mapping_tdb.c
index 9f2b250cca038e96a5fd9d276b540ccbcd334887..cf8857cda541990cff878745933d5ea41b361999 100644 (file)
  */
 
 #include "includes.h"
+#include "system/filesys.h"
+#include "passdb.h"
 #include "groupdb/mapping.h"
+#include "dbwrap.h"
+#include "util_tdb.h"
+#include "../libcli/security/security.h"
 
 static struct db_context *db; /* used for driver files */
 
-static bool enum_group_mapping(const DOM_SID *domsid, enum lsa_SidType sid_name_use, GROUP_MAP **pp_rmap,
-                              size_t *p_num_entries, bool unix_only);
-static bool group_map_remove(const DOM_SID *sid);
-       
+static bool enum_group_mapping(const struct dom_sid *domsid,
+                              enum lsa_SidType sid_name_use,
+                              GROUP_MAP **pp_rmap,
+                              size_t *p_num_entries,
+                              bool unix_only);
+static bool group_map_remove(const struct dom_sid *sid);
+
+static bool mapping_switch(const char *ldb_path);
+
 /****************************************************************************
  Open the group mapping tdb.
 ****************************************************************************/
 static bool init_group_mapping(void)
 {
+       const char *ldb_path;
+
        if (db != NULL) {
                return true;
        }
 
-       db = db_open(NULL, state_path("group_mapping.tdb"), 0, TDB_DEFAULT,
-                    O_RDWR|O_CREAT, 0600);
+       db = db_open(NULL, state_path("group_mapping.tdb"), 0,
+                          TDB_DEFAULT, O_RDWR|O_CREAT, 0600);
        if (db == NULL) {
                DEBUG(0, ("Failed to open group mapping database: %s\n",
                          strerror(errno)));
                return false;
        }
 
-#if 0
-       /*
-        * This code was designed to handle a group mapping version
-        * upgrade. mapping_tdb is not active by default anymore, so ignore
-        * this here.
-        */
-       {
+       ldb_path = state_path("group_mapping.ldb");
+       if (file_exist(ldb_path) && !mapping_switch(ldb_path)) {
+               unlink(state_path("group_mapping.tdb"));
+               return false;
+
+       } else {
+               /* handle upgrade from old versions of the database */
+#if 0 /* -- Needs conversion to dbwrap -- */
                const char *vstring = "INFO/version";
                int32 vers_id;
                GROUP_MAP *map_table = NULL;
@@ -96,13 +109,12 @@ static bool init_group_mapping(void)
 
                        SAFE_FREE( map_table );
                }
-       }
 #endif
-
+       }
        return true;
 }
 
-static char *group_mapping_key(TALLOC_CTX *mem_ctx, const DOM_SID *sid)
+static char *group_mapping_key(TALLOC_CTX *mem_ctx, const struct dom_sid *sid)
 {
        char *sidstr, *result;
 
@@ -111,7 +123,7 @@ static char *group_mapping_key(TALLOC_CTX *mem_ctx, const DOM_SID *sid)
                return NULL;
        }
 
-       result = talloc_asprintf(mem_ctx, "GROUP_PREFIX%s", sidstr);
+       result = talloc_asprintf(mem_ctx, "%s%s", GROUP_PREFIX, sidstr);
 
        TALLOC_FREE(sidstr);
        return result;
@@ -127,13 +139,13 @@ static bool add_mapping_entry(GROUP_MAP *map, int flag)
 
        key = group_mapping_key(talloc_tos(), &map->sid);
        if (key == NULL) {
-               return NULL;
+               return false;
        }
 
-       len = tdb_pack(NULL, sizeof(buf), "ddff",
+       len = tdb_pack(NULL, 0, "ddff",
                map->gid, map->sid_name_use, map->nt_name, map->comment);
 
-       buf = TALLOC_ARRAY(key, char, len);
+       buf = talloc_array(key, char, len);
        if (!buf) {
                TALLOC_FREE(key);
                return false;
@@ -141,8 +153,9 @@ static bool add_mapping_entry(GROUP_MAP *map, int flag)
        len = tdb_pack((uint8 *)buf, len, "ddff", map->gid,
                       map->sid_name_use, map->nt_name, map->comment);
 
-       status = dbwrap_store_bystring(
-               db, key, make_tdb_data((uint8_t *)buf, len), flag);
+       status = dbwrap_trans_store(
+               db, string_term_tdb_data(key),
+               make_tdb_data((uint8_t *)buf, len), TDB_REPLACE);
 
        TALLOC_FREE(key);
 
@@ -154,7 +167,7 @@ static bool add_mapping_entry(GROUP_MAP *map, int flag)
  Return the sid and the type of the unix group.
 ****************************************************************************/
 
-static bool get_group_map_from_sid(DOM_SID sid, GROUP_MAP *map)
+static bool get_group_map_from_sid(struct dom_sid sid, GROUP_MAP *map)
 {
        TDB_DATA dbuf;
        char *key;
@@ -162,7 +175,7 @@ static bool get_group_map_from_sid(DOM_SID sid, GROUP_MAP *map)
 
        /* the key is the SID, retrieving is direct */
 
-       key = group_mapping_key(talloc_tos(), &map->sid);
+       key = group_mapping_key(talloc_tos(), &sid);
        if (key == NULL) {
                return false;
        }
@@ -278,20 +291,20 @@ static bool get_group_map_from_ntname(const char *name, GROUP_MAP *map)
  Remove a group mapping entry.
 ****************************************************************************/
 
-static bool group_map_remove(const DOM_SID *sid)
+static bool group_map_remove(const struct dom_sid *sid)
 {
        char *key;
-       bool result;
+       NTSTATUS status;
 
        key = group_mapping_key(talloc_tos(), sid);
        if (key == NULL) {
                return false;
        }
 
-       result = NT_STATUS_IS_OK(dbwrap_delete_bystring(db, key));
+       status = dbwrap_trans_delete(db, string_term_tdb_data(key));
 
        TALLOC_FREE(key);
-       return result;
+       return NT_STATUS_IS_OK(status);
 }
 
 /****************************************************************************
@@ -299,7 +312,7 @@ static bool group_map_remove(const DOM_SID *sid)
 ****************************************************************************/
 
 struct enum_map_state {
-       const DOM_SID *domsid;
+       const struct dom_sid *domsid;
        enum lsa_SidType sid_name_use;
        bool unix_only;
 
@@ -331,7 +344,7 @@ static int collect_map(struct db_record *rec, void *private_data)
        }
 
        if ((state->domsid != NULL) &&
-           (sid_compare_domain(state->domsid, &map.sid) != 0)) {
+           (dom_sid_compare_domain(state->domsid, &map.sid) != 0)) {
                DEBUG(11,("enum_group_mapping: group %s is not in domain\n",
                          sid_string_dbg(&map.sid)));
                return 0;
@@ -350,7 +363,7 @@ static int collect_map(struct db_record *rec, void *private_data)
        return 0;
 }
 
-static bool enum_group_mapping(const DOM_SID *domsid,
+static bool enum_group_mapping(const struct dom_sid *domsid,
                               enum lsa_SidType sid_name_use,
                               GROUP_MAP **pp_rmap,
                               size_t *p_num_entries, bool unix_only)
@@ -363,7 +376,7 @@ static bool enum_group_mapping(const DOM_SID *domsid,
        state.num_maps = 0;
        state.maps = NULL;
 
-       if (db->traverse_read(db, collect_map, (void *)&state) != 0) {
+       if (db->traverse_read(db, collect_map, (void *)&state) < 0) {
                return false;
        }
 
@@ -376,8 +389,8 @@ static bool enum_group_mapping(const DOM_SID *domsid,
 /* This operation happens on session setup, so it should better be fast. We
  * store a list of aliases a SID is member of hanging off MEMBEROF/SID. */
 
-static NTSTATUS one_alias_membership(const DOM_SID *member,
-                              DOM_SID **sids, size_t *num)
+static NTSTATUS one_alias_membership(const struct dom_sid *member,
+                              struct dom_sid **sids, size_t *num)
 {
        fstring tmp;
        fstring key;
@@ -399,15 +412,18 @@ static NTSTATUS one_alias_membership(const DOM_SID *member,
        p = (const char *)dbuf.dptr;
 
        while (next_token_talloc(frame, &p, &string_sid, " ")) {
-               DOM_SID alias;
+               struct dom_sid alias;
+               uint32_t num_sids;
 
                if (!string_to_sid(&alias, string_sid))
                        continue;
 
-               status= add_sid_to_array_unique(NULL, &alias, sids, num);
+               num_sids = *num;
+               status= add_sid_to_array_unique(NULL, &alias, sids, &num_sids);
                if (!NT_STATUS_IS_OK(status)) {
                        goto done;
                }
+               *num = num_sids;
        }
 
 done:
@@ -415,8 +431,8 @@ done:
        return status;
 }
 
-static NTSTATUS alias_memberships(const DOM_SID *members, size_t num_members,
-                                 DOM_SID **sids, size_t *num)
+static NTSTATUS alias_memberships(const struct dom_sid *members, size_t num_members,
+                                 struct dom_sid **sids, size_t *num)
 {
        size_t i;
 
@@ -431,10 +447,11 @@ static NTSTATUS alias_memberships(const DOM_SID *members, size_t num_members,
        return NT_STATUS_OK;
 }
 
-static bool is_aliasmem(const DOM_SID *alias, const DOM_SID *member)
+static bool is_aliasmem(const struct dom_sid *alias, const struct dom_sid *member)
 {
-       DOM_SID *sids;
-       size_t i, num;
+       struct dom_sid *sids;
+       size_t i;
+       size_t num;
 
        /* This feels the wrong way round, but the on-disk data structure
         * dictates it this way. */
@@ -442,7 +459,7 @@ static bool is_aliasmem(const DOM_SID *alias, const DOM_SID *member)
                return False;
 
        for (i=0; i<num; i++) {
-               if (sid_compare(alias, &sids[i]) == 0) {
+               if (dom_sid_compare(alias, &sids[i]) == 0) {
                        TALLOC_FREE(sids);
                        return True;
                }
@@ -452,7 +469,7 @@ static bool is_aliasmem(const DOM_SID *alias, const DOM_SID *member)
 }
 
 
-static NTSTATUS add_aliasmem(const DOM_SID *alias, const DOM_SID *member)
+static NTSTATUS add_aliasmem(const struct dom_sid *alias, const struct dom_sid *member)
 {
        GROUP_MAP map;
        char *key;
@@ -479,12 +496,18 @@ static NTSTATUS add_aliasmem(const DOM_SID *alias, const DOM_SID *member)
                return NT_STATUS_NO_MEMORY;
        }
 
+       if (db->transaction_start(db) != 0) {
+               DEBUG(0, ("transaction_start failed\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
        rec = db->fetch_locked(db, key, string_term_tdb_data(key));
 
        if (rec == NULL) {
                DEBUG(10, ("fetch_lock failed\n"));
                TALLOC_FREE(key);
-               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+               status = NT_STATUS_INTERNAL_DB_CORRUPTION;
+               goto cancel;
        }
 
        sid_to_fstring(string_sid, alias);
@@ -498,7 +521,8 @@ static NTSTATUS add_aliasmem(const DOM_SID *alias, const DOM_SID *member)
 
        if (new_memberstring == NULL) {
                TALLOC_FREE(key);
-               return NT_STATUS_NO_MEMORY;
+               status = NT_STATUS_NO_MEMORY;
+               goto cancel;
        }
 
        status = rec->store(rec, string_term_tdb_data(new_memberstring), 0);
@@ -507,14 +531,29 @@ static NTSTATUS add_aliasmem(const DOM_SID *alias, const DOM_SID *member)
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("Could not store record: %s\n", nt_errstr(status)));
+               goto cancel;
+       }
+
+       if (db->transaction_commit(db) != 0) {
+               DEBUG(0, ("transaction_commit failed\n"));
+               status = NT_STATUS_INTERNAL_DB_CORRUPTION;
+               return status;
+       }
+
+       return NT_STATUS_OK;
+
+ cancel:
+       if (db->transaction_cancel(db) != 0) {
+               smb_panic("transaction_cancel failed");
        }
 
        return status;
 }
 
 struct aliasmem_state {
-       const DOM_SID *alias;
-       DOM_SID **sids;
+       TALLOC_CTX *mem_ctx;
+       const struct dom_sid *alias;
+       struct dom_sid **sids;
        size_t *num;
 };
 
@@ -534,13 +573,14 @@ static int collect_aliasmem(struct db_record *rec, void *priv)
        frame = talloc_stackframe();
 
        while (next_token_talloc(frame, &p, &alias_string, " ")) {
-               DOM_SID alias, member;
+               struct dom_sid alias, member;
                const char *member_string;
+               uint32_t num_sids;
 
                if (!string_to_sid(&alias, alias_string))
                        continue;
 
-               if (sid_compare(state->alias, &alias) != 0)
+               if (dom_sid_compare(state->alias, &alias) != 0)
                        continue;
 
                /* Ok, we found the alias we're looking for in the membership
@@ -558,20 +598,23 @@ static int collect_aliasmem(struct db_record *rec, void *priv)
                if (!string_to_sid(&member, member_string))
                        continue;
 
-               if (!NT_STATUS_IS_OK(add_sid_to_array(NULL, &member,
+               num_sids = *state->num;
+               if (!NT_STATUS_IS_OK(add_sid_to_array(state->mem_ctx, &member,
                                                      state->sids,
-                                                     state->num)))
+                                                     &num_sids)))
                {
                        /* talloc fail. */
                        break;
                }
+               *state->num = num_sids;
        }
 
        TALLOC_FREE(frame);
        return 0;
 }
 
-static NTSTATUS enum_aliasmem(const DOM_SID *alias, DOM_SID **sids, size_t *num)
+static NTSTATUS enum_aliasmem(const struct dom_sid *alias, TALLOC_CTX *mem_ctx,
+                             struct dom_sid **sids, size_t *num)
 {
        GROUP_MAP map;
        struct aliasmem_state state;
@@ -589,28 +632,35 @@ static NTSTATUS enum_aliasmem(const DOM_SID *alias, DOM_SID **sids, size_t *num)
        state.alias = alias;
        state.sids = sids;
        state.num = num;
+       state.mem_ctx = mem_ctx;
 
        db->traverse_read(db, collect_aliasmem, &state);
        return NT_STATUS_OK;
 }
 
-static NTSTATUS del_aliasmem(const DOM_SID *alias, const DOM_SID *member)
+static NTSTATUS del_aliasmem(const struct dom_sid *alias, const struct dom_sid *member)
 {
        NTSTATUS status;
-       DOM_SID *sids;
+       struct dom_sid *sids;
        size_t i, num;
        bool found = False;
        char *member_string;
        char *key;
        fstring sid_string;
 
+       if (db->transaction_start(db) != 0) {
+               DEBUG(0, ("transaction_start failed\n"));
+               return NT_STATUS_INTERNAL_DB_CORRUPTION;
+       }
+
        status = alias_memberships(member, 1, &sids, &num);
 
-       if (!NT_STATUS_IS_OK(status))
-               return status;
+       if (!NT_STATUS_IS_OK(status)) {
+               goto cancel;
+       }
 
        for (i=0; i<num; i++) {
-               if (sid_compare(&sids[i], alias) == 0) {
+               if (dom_sid_compare(&sids[i], alias) == 0) {
                        found = True;
                        break;
                }
@@ -618,7 +668,8 @@ static NTSTATUS del_aliasmem(const DOM_SID *alias, const DOM_SID *member)
 
        if (!found) {
                TALLOC_FREE(sids);
-               return NT_STATUS_MEMBER_NOT_IN_ALIAS;
+               status = NT_STATUS_MEMBER_NOT_IN_ALIAS;
+               goto cancel;
        }
 
        if (i < num)
@@ -631,19 +682,20 @@ static NTSTATUS del_aliasmem(const DOM_SID *alias, const DOM_SID *member)
        key = talloc_asprintf(sids, "%s%s", MEMBEROF_PREFIX, sid_string);
        if (key == NULL) {
                TALLOC_FREE(sids);
-               return NT_STATUS_NO_MEMORY;
+               status = NT_STATUS_NO_MEMORY;
+               goto cancel;
        }
 
        if (num == 0) {
                status = dbwrap_delete_bystring(db, key);
-               TALLOC_FREE(sids);
-               return status;
+               goto commit;
        }
 
        member_string = talloc_strdup(sids, "");
        if (member_string == NULL) {
                TALLOC_FREE(sids);
-               return NT_STATUS_NO_MEMORY;
+               status = NT_STATUS_NO_MEMORY;
+               goto cancel;
        }
 
        for (i=0; i<num; i++) {
@@ -655,18 +707,285 @@ static NTSTATUS del_aliasmem(const DOM_SID *alias, const DOM_SID *member)
 
                if (member_string == NULL) {
                        TALLOC_FREE(sids);
-                       return NT_STATUS_NO_MEMORY;
+                       status = NT_STATUS_NO_MEMORY;
+                       goto cancel;
                }
        }
 
        status = dbwrap_store_bystring(
                db, key, string_term_tdb_data(member_string), 0);
-
+ commit:
        TALLOC_FREE(sids);
 
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10, ("dbwrap_store_bystring failed: %s\n",
+                          nt_errstr(status)));
+               goto cancel;
+       }
+
+       if (db->transaction_commit(db) != 0) {
+               DEBUG(0, ("transaction_commit failed\n"));
+               status = NT_STATUS_INTERNAL_DB_CORRUPTION;
+               return status;
+       }
+
+       return NT_STATUS_OK;
+
+ cancel:
+       if (db->transaction_cancel(db) != 0) {
+               smb_panic("transaction_cancel failed");
+       }
        return status;
 }
 
+
+/* -- ldb->tdb switching code -------------------------------------------- */
+
+/* change this if the data format ever changes */
+#define LTDB_PACKING_FORMAT 0x26011967
+
+/* old packing formats (not supported for now,
+ * it was never used for group mapping AFAIK) */
+#define LTDB_PACKING_FORMAT_NODN 0x26011966
+
+static unsigned int pull_uint32(uint8_t *p, int ofs)
+{
+       p += ofs;
+       return p[0] | (p[1]<<8) | (p[2]<<16) | (p[3]<<24);
+}
+
+/*
+  unpack a ldb message from a linear buffer in TDB_DATA
+*/
+static int convert_ldb_record(TDB_CONTEXT *ltdb, TDB_DATA key,
+                             TDB_DATA data, void *ptr)
+{
+       TALLOC_CTX *tmp_ctx = talloc_tos();
+       GROUP_MAP map;
+       uint8_t *p;
+       uint32_t format;
+       uint32_t num_el;
+       unsigned int remaining;
+       unsigned int i, j;
+       size_t len;
+       char *name;
+       char *val;
+       char *q;
+       uint32_t num_mem = 0;
+       struct dom_sid *members = NULL;
+
+       p = (uint8_t *)data.dptr;
+       if (data.dsize < 8) {
+               errno = EIO;
+               goto failed;
+       }
+
+       format = pull_uint32(p, 0);
+       num_el = pull_uint32(p, 4);
+       p += 8;
+
+       remaining = data.dsize - 8;
+
+       switch (format) {
+       case LTDB_PACKING_FORMAT:
+               len = strnlen((char *)p, remaining);
+               if (len == remaining) {
+                       errno = EIO;
+                       goto failed;
+               }
+
+               if (*p == '@') {
+                       /* ignore special LDB attributes */
+                       return 0;
+               }
+
+               if (strncmp((char *)p, "rid=", 4)) {
+                       /* unknown entry, ignore */
+                       DEBUG(3, ("Found unknown entry in group mapping "
+                                 "database named [%s]\n", (char *)p));
+                       return 0;
+               }
+
+               remaining -= len + 1;
+               p += len + 1;
+               break;
+
+       case LTDB_PACKING_FORMAT_NODN:
+       default:
+               errno = EIO;
+               goto failed;
+       }
+
+       if (num_el == 0) {
+               /* bad entry, ignore */
+               return 0;
+       }
+
+       if (num_el > remaining / 6) {
+               errno = EIO;
+               goto failed;
+       }
+
+       ZERO_STRUCT(map);
+
+       for (i = 0; i < num_el; i++) {
+               uint32_t num_vals;
+
+               if (remaining < 10) {
+                       errno = EIO;
+                       goto failed;
+               }
+               len = strnlen((char *)p, remaining - 6);
+               if (len == remaining - 6) {
+                       errno = EIO;
+                       goto failed;
+               }
+               name = talloc_strndup(tmp_ctx, (char *)p, len);
+               if (name == NULL) {
+                       errno = ENOMEM;
+                       goto failed;
+               }
+               remaining -= len + 1;
+               p += len + 1;
+
+               num_vals = pull_uint32(p, 0);
+               if (strcasecmp_m(name, "member") == 0) {
+                       num_mem = num_vals;
+                       members = talloc_array(tmp_ctx, struct dom_sid, num_mem);
+                       if (members == NULL) {
+                               errno = ENOMEM;
+                               goto failed;
+                       }
+               } else if (num_vals != 1) {
+                       errno = EIO;
+                       goto failed;
+               }
+
+               p += 4;
+               remaining -= 4;
+
+               for (j = 0; j < num_vals; j++) {
+                       len = pull_uint32(p, 0);
+                       if (len > remaining-5) {
+                               errno = EIO;
+                               goto failed;
+                       }
+
+                       val = talloc_strndup(tmp_ctx, (char *)(p + 4), len);
+                       if (val == NULL) {
+                               errno = ENOMEM;
+                               goto failed;
+                       }
+
+                       remaining -= len+4+1;
+                       p += len+4+1;
+
+                       /* we ignore unknown or uninteresting attributes
+                        * (objectclass, etc.) */
+                       if (strcasecmp_m(name, "gidNumber") == 0) {
+                               map.gid = strtoul(val, &q, 10);
+                               if (*q) {
+                                       errno = EIO;
+                                       goto failed;
+                               }
+                       } else if (strcasecmp_m(name, "sid") == 0) {
+                               if (!string_to_sid(&map.sid, val)) {
+                                       errno = EIO;
+                                       goto failed;
+                               }
+                       } else if (strcasecmp_m(name, "sidNameUse") == 0) {
+                               map.sid_name_use = strtoul(val, &q, 10);
+                               if (*q) {
+                                       errno = EIO;
+                                       goto failed;
+                               }
+                       } else if (strcasecmp_m(name, "ntname") == 0) {
+                               strlcpy(map.nt_name, val,
+                                       sizeof(map.nt_name));
+                       } else if (strcasecmp_m(name, "comment") == 0) {
+                               strlcpy(map.comment, val,
+                                       sizeof(map.comment));
+                       } else if (strcasecmp_m(name, "member") == 0) {
+                               if (!string_to_sid(&members[j], val)) {
+                                       errno = EIO;
+                                       goto failed;
+                               }
+                       }
+
+                       TALLOC_FREE(val);
+               }
+
+               TALLOC_FREE(name);
+       }
+
+       if (!add_mapping_entry(&map, 0)) {
+               errno = EIO;
+               goto failed;
+       }
+
+       if (num_mem) {
+               for (j = 0; j < num_mem; j++) {
+                       NTSTATUS status;
+                       status = add_aliasmem(&map.sid, &members[j]);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               errno = EIO;
+                               goto failed;
+                       }
+               }
+       }
+
+       if (remaining != 0) {
+               DEBUG(0, ("Errror: %d bytes unread in ltdb_unpack_data\n",
+                         remaining));
+       }
+
+       return 0;
+
+failed:
+       return -1;
+}
+
+static bool mapping_switch(const char *ldb_path)
+{
+       TDB_CONTEXT *ltdb;
+       TALLOC_CTX *frame;
+       char *new_path;
+       int ret;
+
+       frame = talloc_stackframe();
+
+       ltdb = tdb_open_log(ldb_path, 0, TDB_DEFAULT, O_RDONLY, 0600);
+       if (ltdb == NULL) goto failed;
+
+       /* ldb is just a very fancy tdb, read out raw data and perform
+        * conversion */
+       ret = tdb_traverse(ltdb, convert_ldb_record, NULL);
+       if (ret == -1) goto failed;
+
+       if (ltdb) {
+               tdb_close(ltdb);
+               ltdb = NULL;
+       }
+
+       /* now rename the old db out of the way */
+       new_path = state_path("group_mapping.ldb.replaced");
+       if (!new_path) {
+               goto failed;
+       }
+       if (rename(ldb_path, new_path) != 0) {
+               DEBUG(0,("Failed to rename old group mapping database\n"));
+               goto failed;
+       }
+       TALLOC_FREE(frame);
+       return True;
+
+failed:
+       DEBUG(0, ("Failed to switch to tdb group mapping database\n"));
+       if (ltdb) tdb_close(ltdb);
+       TALLOC_FREE(frame);
+       return False;
+}
+
 static const struct mapping_backend tdb_backend = {
        .add_mapping_entry         = add_mapping_entry,
        .get_group_map_from_sid    = get_group_map_from_sid,