Add the "backup" toggle command to smbclient. In order for this to be
[samba.git] / source3 / client / client.c
index b485df7741abeb5b9ed968505652911d96f4a2ae..47d44705d2d80d9758703168e68fad53af9e2727 100644 (file)
@@ -36,6 +36,7 @@
 #include "libsmb/clirap.h"
 #include "trans2.h"
 #include "libsmb/nmblib.h"
+#include "include/ntioctl.h"
 
 #ifndef REGISTER
 #define REGISTER 0
@@ -87,6 +88,7 @@ static bool prompt = true;
 static bool recurse = false;
 static bool showacls = false;
 bool lowercase = false;
+static bool backup_intent = false;
 
 static struct sockaddr_storage dest_ss;
 static char dest_ss_str[INET6_ADDRSTRLEN];
@@ -310,8 +312,11 @@ static int do_dskattr(void)
        TALLOC_CTX *ctx = talloc_tos();
        NTSTATUS status;
 
-       if ( !cli_resolve_path(ctx, "", auth_info, cli, client_get_cur_dir(), &targetcli, &targetpath)) {
-               d_printf("Error in dskattr: %s\n", cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli,
+                                 client_get_cur_dir(), &targetcli,
+                                 &targetpath);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Error in dskattr: %s\n", nt_errstr(status));
                return 1;
        }
 
@@ -364,6 +369,7 @@ static int do_cd(const char *new_dir)
        uint32 attributes;
        int ret = 1;
        TALLOC_CTX *ctx = talloc_stackframe();
+       NTSTATUS status;
 
        newdir = talloc_strdup(ctx, new_dir);
        if (!newdir) {
@@ -405,8 +411,10 @@ static int do_cd(const char *new_dir)
        new_cd = clean_name(ctx, new_cd);
        client_set_cur_dir(new_cd);
 
-       if ( !cli_resolve_path(ctx, "", auth_info, cli, new_cd, &targetcli, &targetpath)) {
-               d_printf("cd %s: %s\n", new_cd, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, new_cd,
+                                 &targetcli, &targetpath);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("cd %s: %s\n", new_cd, nt_errstr(status));
                client_set_cur_dir(saved_dir);
                goto out;
        }
@@ -419,8 +427,7 @@ static int do_cd(const char *new_dir)
        /* Use a trans2_qpathinfo to test directories for modern servers.
           Except Win9x doesn't support the qpathinfo_basic() call..... */
 
-       if (targetcli->protocol > PROTOCOL_LANMAN2 && !targetcli->win95) {
-               NTSTATUS status;
+       if (cli_state_protocol(targetcli) > PROTOCOL_LANMAN2 && !targetcli->win95) {
 
                status = cli_qpathinfo_basic(targetcli, targetpath, &sbuf,
                                             &attributes);
@@ -436,7 +443,6 @@ static int do_cd(const char *new_dir)
                        goto out;
                }
        } else {
-               NTSTATUS status;
 
                targetpath = talloc_asprintf(ctx,
                                "%s%s",
@@ -581,12 +587,12 @@ static NTSTATUS display_finfo(struct cli_state *cli_state, struct file_info *fin
                                   afname, nt_errstr(status)));
                } else {
                        struct security_descriptor *sd = NULL;
-                       sd = cli_query_secdesc(cli_state, fnum, ctx);
-                       if (!sd) {
+                       status = cli_query_secdesc(cli_state, fnum,
+                                                  ctx, &sd);
+                       if (!NT_STATUS_IS_OK(status)) {
                                DEBUG( 0, ("display_finfo() failed to "
-                                       "get security descriptor: %s",
-                                       cli_errstr(cli_state)));
-                               status = cli_nt_error(cli_state);
+                                          "get security descriptor: %s",
+                                          nt_errstr(status)));
                        } else {
                                display_sec_desc(sd);
                        }
@@ -857,8 +863,12 @@ NTSTATUS do_list(const char *mask,
 
                        /* check for dfs */
 
-                       if ( !cli_resolve_path(ctx, "", auth_info, cli, head, &targetcli, &targetpath ) ) {
-                               d_printf("do_list: [%s] %s\n", head, cli_errstr(cli));
+                       status = cli_resolve_path(ctx, "", auth_info, cli,
+                                                 head, &targetcli,
+                                                 &targetpath);
+                       if (!NT_STATUS_IS_OK(status)) {
+                               d_printf("do_list: [%s] %s\n", head,
+                                        nt_errstr(status));
                                remove_do_list_queue_head();
                                continue;
                        }
@@ -896,8 +906,9 @@ NTSTATUS do_list(const char *mask,
                }
        } else {
                /* check for dfs */
-               if (cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetpath)) {
-
+               status = cli_resolve_path(ctx, "", auth_info, cli, mask,
+                                         &targetcli, &targetpath);
+               if (NT_STATUS_IS_OK(status)) {
                        status = cli_list(targetcli, targetpath, attribute,
                                          do_list_helper, targetcli);
                        if (!NT_STATUS_IS_OK(status)) {
@@ -907,8 +918,8 @@ NTSTATUS do_list(const char *mask,
                        }
                        TALLOC_FREE(targetpath);
                } else {
-                       d_printf("do_list: [%s] %s\n", mask, cli_errstr(cli));
-                       ret_status = cli_nt_error(cli);
+                       d_printf("do_list: [%s] %s\n", mask, nt_errstr(status));
+                       ret_status = status;
                }
        }
 
@@ -1077,8 +1088,10 @@ static int do_get(const char *rname, const char *lname_in, bool reget)
                strlower_m(lname);
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, rname, &targetcli, &targetname ) ) {
-               d_printf("Failed to open %s: %s\n", rname, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, rname, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Failed to open %s: %s\n", rname, nt_errstr(status));
                return 1;
        }
 
@@ -1459,8 +1472,10 @@ static bool do_mkdir(const char *name)
        char *targetname = NULL;
        NTSTATUS status;
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, name, &targetcli, &targetname)) {
-               d_printf("mkdir %s: %s\n", name, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, name, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("mkdir %s: %s\n", name, nt_errstr(status));
                return false;
        }
 
@@ -1515,6 +1530,7 @@ static int cmd_mkdir(void)
        TALLOC_CTX *ctx = talloc_tos();
        char *mask = NULL;
        char *buf = NULL;
+        NTSTATUS status;
 
        mask = talloc_strdup(ctx, client_get_cur_dir());
        if (!mask) {
@@ -1545,7 +1561,9 @@ static int cmd_mkdir(void)
                        return 1;
                }
 
-               if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
+               status = cli_resolve_path(ctx, "", auth_info, cli, mask,
+                                         &targetcli, &targetname);
+               if (!NT_STATUS_IS_OK(status)) {
                        return 1;
                }
 
@@ -1715,6 +1733,23 @@ static int do_allinfo(const char *name)
                         (unsigned long long)streams[i].size);
        }
 
+       if (mode & FILE_ATTRIBUTE_REPARSE_POINT) {
+               char *subst, *print;
+               uint32_t flags;
+
+               status = cli_readlink(cli, name, talloc_tos(), &subst, &print,
+                                     &flags);
+               if (!NT_STATUS_IS_OK(status)) {
+                       d_fprintf(stderr, "cli_readlink returned %s\n",
+                                 nt_errstr(status));
+               } else {
+                       d_printf("symlink: subst=[%s], print=[%s], flags=%x\n",
+                                subst, print, flags);
+                       TALLOC_FREE(subst);
+                       TALLOC_FREE(print);
+               }
+       }
+
        status = cli_ntcreate(cli, name, 0,
                              CREATE_ACCESS_READ, 0,
                              FILE_SHARE_READ|FILE_SHARE_WRITE
@@ -1811,8 +1846,10 @@ static int do_put(const char *rname, const char *lname, bool reput)
        struct push_state state;
        NTSTATUS status;
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, rname, &targetcli, &targetname)) {
-               d_printf("Failed to open %s: %s\n", rname, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, rname,
+                                 &targetcli, &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Failed to open %s: %s\n", rname, nt_errstr(status));
                return 1;
        }
 
@@ -1912,7 +1949,7 @@ static int do_put(const char *rname, const char *lname, bool reput)
 
        if (f == x_stdin) {
                cli_shutdown(cli);
-               exit(0);
+               exit(rc);
        }
 
        return rc;
@@ -2201,7 +2238,9 @@ static int do_cancel(int job)
                d_printf("Job %d cancelled\n",job);
                return 0;
        } else {
-               d_printf("Error cancelling job %d : %s\n",job,cli_errstr(cli));
+               NTSTATUS status = cli_nt_error(cli);
+               d_printf("Error cancelling job %d : %s\n",
+                        job, nt_errstr(status));
                return 1;
        }
 }
@@ -2389,8 +2428,10 @@ static int cmd_wdel(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("cmd_wdel %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("cmd_wdel %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
@@ -2413,6 +2454,7 @@ static int cmd_open(void)
        char *targetname = NULL;
        struct cli_state *targetcli;
        uint16_t fnum = (uint16_t)-1;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("open <filename>\n");
@@ -2426,20 +2468,27 @@ static int cmd_open(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("open %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("open %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_ntcreate(targetcli, targetname, 0,
+       status = cli_ntcreate(targetcli, targetname, 0,
                        FILE_READ_DATA|FILE_WRITE_DATA, 0,
-                       FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_OPEN, 0x0, 0x0, &fnum))) {
-               if (NT_STATUS_IS_OK(cli_ntcreate(targetcli, targetname, 0,
+                       FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_OPEN,
+                       0x0, 0x0, &fnum);
+       if (!NT_STATUS_IS_OK(status)) {
+               status = cli_ntcreate(targetcli, targetname, 0,
                                FILE_READ_DATA, 0,
-                               FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_OPEN, 0x0, 0x0, &fnum))) {
+                               FILE_SHARE_READ|FILE_SHARE_WRITE, FILE_OPEN,
+                               0x0, 0x0, &fnum);
+               if (NT_STATUS_IS_OK(status)) {
                        d_printf("open file %s: for read/write fnum %d\n", targetname, fnum);
                } else {
-                       d_printf("Failed to open file %s. %s\n", targetname, cli_errstr(cli));
+                       d_printf("Failed to open file %s. %s\n",
+                                targetname, nt_errstr(status));
                }
        } else {
                d_printf("open file %s: for read/write fnum %d\n", targetname, fnum);
@@ -2502,6 +2551,7 @@ static int cmd_posix_open(void)
        struct cli_state *targetcli;
        mode_t mode;
        uint16_t fnum;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("posix_open <filename> 0<mode>\n");
@@ -2521,19 +2571,28 @@ static int cmd_posix_open(void)
        }
        mode = (mode_t)strtol(buf, (char **)NULL, 8);
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("posix_open %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("posix_open %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_open(targetcli, targetname, O_CREAT|O_RDWR, mode, &fnum))) {
-               if (!NT_STATUS_IS_OK(cli_posix_open(targetcli, targetname, O_CREAT|O_RDONLY, mode, &fnum))) {
-                       d_printf("posix_open file %s: for read/write fnum %d\n", targetname, fnum);
+       status = cli_posix_open(targetcli, targetname, O_CREAT|O_RDWR, mode,
+                               &fnum);
+       if (!NT_STATUS_IS_OK(status)) {
+               status = cli_posix_open(targetcli, targetname,
+                                       O_CREAT|O_RDONLY, mode, &fnum);
+               if (!NT_STATUS_IS_OK(status)) {
+                       d_printf("Failed to open file %s. %s\n", targetname,
+                                nt_errstr(status));
                } else {
-                       d_printf("Failed to open file %s. %s\n", targetname, cli_errstr(cli));
+                       d_printf("posix_open file %s: for readonly fnum %d\n",
+                                targetname, fnum);
                }
        } else {
-               d_printf("posix_open file %s: for read/write fnum %d\n", targetname, fnum);
+               d_printf("posix_open file %s: for read/write fnum %d\n",
+                        targetname, fnum);
        }
 
        return 0;
@@ -2547,6 +2606,7 @@ static int cmd_posix_mkdir(void)
        char *targetname = NULL;
        struct cli_state *targetcli;
        mode_t mode;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("posix_mkdir <filename> 0<mode>\n");
@@ -2566,13 +2626,17 @@ static int cmd_posix_mkdir(void)
        }
        mode = (mode_t)strtol(buf, (char **)NULL, 8);
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("posix_mkdir %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("posix_mkdir %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_mkdir(targetcli, targetname, mode))) {
-               d_printf("Failed to open file %s. %s\n", targetname, cli_errstr(cli));
+       status = cli_posix_mkdir(targetcli, targetname, mode);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Failed to open file %s. %s\n",
+                        targetname, nt_errstr(status));
        } else {
                d_printf("posix_mkdir created directory %s\n", targetname);
        }
@@ -2586,6 +2650,7 @@ static int cmd_posix_unlink(void)
        char *buf = NULL;
        char *targetname = NULL;
        struct cli_state *targetcli;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("posix_unlink <filename>\n");
@@ -2599,13 +2664,17 @@ static int cmd_posix_unlink(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("posix_unlink %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("posix_unlink %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_unlink(targetcli, targetname))) {
-               d_printf("Failed to unlink file %s. %s\n", targetname, cli_errstr(cli));
+       status = cli_posix_unlink(targetcli, targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Failed to unlink file %s. %s\n",
+                        targetname, nt_errstr(status));
        } else {
                d_printf("posix_unlink deleted file %s\n", targetname);
        }
@@ -2620,6 +2689,7 @@ static int cmd_posix_rmdir(void)
        char *buf = NULL;
        char *targetname = NULL;
        struct cli_state *targetcli;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("posix_rmdir <filename>\n");
@@ -2633,13 +2703,17 @@ static int cmd_posix_rmdir(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("posix_rmdir %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("posix_rmdir %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_rmdir(targetcli, targetname))) {
-               d_printf("Failed to unlink directory %s. %s\n", targetname, cli_errstr(cli));
+       status = cli_posix_rmdir(targetcli, targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("Failed to unlink directory %s. %s\n",
+                        targetname, nt_errstr(status));
        } else {
                d_printf("posix_rmdir deleted directory %s\n", targetname);
        }
@@ -2652,6 +2726,7 @@ static int cmd_close(void)
        TALLOC_CTX *ctx = talloc_tos();
        char *buf = NULL;
        int fnum;
+       NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("close <fnum>\n");
@@ -2660,8 +2735,9 @@ static int cmd_close(void)
 
        fnum = atoi(buf);
        /* We really should use the targetcli here.... */
-       if (!NT_STATUS_IS_OK(cli_close(cli, fnum))) {
-               d_printf("close %d: %s\n", fnum, cli_errstr(cli));
+       status = cli_close(cli, fnum);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("close %d: %s\n", fnum, nt_errstr(status));
                return 1;
        }
        return 0;
@@ -2779,6 +2855,7 @@ static int cmd_lock(void)
        uint64_t start, len;
        enum brl_type lock_type;
        int fnum;
+       NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("lock <fnum> [r|w] <hex-start> <hex-len>\n");
@@ -2814,8 +2891,9 @@ static int cmd_lock(void)
 
        len = (uint64_t)strtol(buf, (char **)NULL, 16);
 
-       if (!NT_STATUS_IS_OK(cli_posix_lock(cli, fnum, start, len, true, lock_type))) {
-               d_printf("lock failed %d: %s\n", fnum, cli_errstr(cli));
+       status = cli_posix_lock(cli, fnum, start, len, true, lock_type);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("lock failed %d: %s\n", fnum, nt_errstr(status));
        }
 
        return 0;
@@ -2827,6 +2905,7 @@ static int cmd_unlock(void)
        char *buf = NULL;
        uint64_t start, len;
        int fnum;
+       NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("unlock <fnum> <hex-start> <hex-len>\n");
@@ -2848,8 +2927,9 @@ static int cmd_unlock(void)
 
        len = (uint64_t)strtol(buf, (char **)NULL, 16);
 
-       if (!NT_STATUS_IS_OK(cli_posix_unlock(cli, fnum, start, len))) {
-               d_printf("unlock failed %d: %s\n", fnum, cli_errstr(cli));
+       status = cli_posix_unlock(cli, fnum, start, len);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("unlock failed %d: %s\n", fnum, nt_errstr(status));
        }
 
        return 0;
@@ -2867,6 +2947,7 @@ static int cmd_rmdir(void)
        char *buf = NULL;
        char *targetname = NULL;
        struct cli_state *targetcli;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("rmdir <dirname>\n");
@@ -2880,14 +2961,17 @@ static int cmd_rmdir(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli, &targetname)) {
-               d_printf("rmdir %s: %s\n", mask, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, mask, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("rmdir %s: %s\n", mask, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_rmdir(targetcli, targetname))) {
+       status = cli_rmdir(targetcli, targetname);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s removing remote directory file %s\n",
-                        cli_errstr(targetcli),mask);
+                        nt_errstr(status), mask);
        }
 
        return 0;
@@ -2906,6 +2990,7 @@ static int cmd_link(void)
        char *buf2 = NULL;
        char *targetname = NULL;
        struct cli_state *targetcli;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL) ||
            !next_token_talloc(ctx, &cmd_ptr,&buf2,NULL)) {
@@ -2927,8 +3012,10 @@ static int cmd_link(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, oldname, &targetcli, &targetname)) {
-               d_printf("link %s: %s\n", oldname, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, oldname, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("link %s: %s\n", oldname, nt_errstr(status));
                return 1;
        }
 
@@ -2937,8 +3024,10 @@ static int cmd_link(void)
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_hardlink(targetcli, targetname, newname))) {
-               d_printf("%s linking files (%s -> %s)\n", cli_errstr(targetcli), newname, oldname);
+       status = cli_posix_hardlink(targetcli, targetname, newname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("%s linking files (%s -> %s)\n",
+                        nt_errstr(status), newname, oldname);
                return 1;
        }
        return 0;
@@ -2956,6 +3045,7 @@ static int cmd_readlink(void)
        char *targetname = NULL;
        char linkname[PATH_MAX+1];
        struct cli_state *targetcli;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
                d_printf("readlink <name>\n");
@@ -2969,8 +3059,10 @@ static int cmd_readlink(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, name, &targetcli, &targetname)) {
-               d_printf("readlink %s: %s\n", name, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, name, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("readlink %s: %s\n", name, nt_errstr(status));
                return 1;
        }
 
@@ -2979,10 +3071,10 @@ static int cmd_readlink(void)
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_readlink(targetcli, name,
-                       linkname, PATH_MAX+1))) {
+       status = cli_posix_readlink(targetcli, name, linkname, PATH_MAX+1);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s readlink on file %s\n",
-                       cli_errstr(targetcli), name);
+                        nt_errstr(status), name);
                return 1;
        }
 
@@ -3004,6 +3096,7 @@ static int cmd_symlink(void)
        char *buf = NULL;
        char *buf2 = NULL;
        struct cli_state *newcli;
+       NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL) ||
            !next_token_talloc(ctx, &cmd_ptr,&buf2,NULL)) {
@@ -3013,28 +3106,29 @@ static int cmd_symlink(void)
        /* Oldname (link target) must be an untouched blob. */
        oldname = buf;
 
-       newname = talloc_asprintf(ctx,
-                       "%s%s",
-                       client_get_cur_dir(),
-                       buf2);
-       if (!newname) {
-               return 1;
-       }
-
-       /* New name must be present in share namespace. */
-       if (!cli_resolve_path(ctx, "", auth_info, cli, newname, &newcli, &newname)) {
-               d_printf("link %s: %s\n", oldname, cli_errstr(cli));
-               return 1;
-       }
-
-       if (!SERVER_HAS_UNIX_CIFS(newcli)) {
-               d_printf("Server doesn't support UNIX CIFS calls.\n");
-               return 1;
+       if (SERVER_HAS_UNIX_CIFS(cli)) {
+               newname = talloc_asprintf(ctx, "%s%s", client_get_cur_dir(),
+                                         buf2);
+               if (!newname) {
+                       return 1;
+               }
+               /* New name must be present in share namespace. */
+               status = cli_resolve_path(ctx, "", auth_info, cli, newname,
+                                         &newcli, &newname);
+               if (!NT_STATUS_IS_OK(status)) {
+                       d_printf("link %s: %s\n", oldname, nt_errstr(status));
+                       return 1;
+               }
+               status = cli_posix_symlink(newcli, oldname, newname);
+       } else {
+               status = cli_symlink(
+                       cli, oldname, buf2,
+                       buf2[0] == '\\' ? 0 : SYMLINK_FLAG_RELATIVE);
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_symlink(newcli, oldname, newname))) {
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s symlinking files (%s -> %s)\n",
-                       cli_errstr(newcli), newname, newname);
+                        nt_errstr(status), oldname, newname);
                return 1;
        }
 
@@ -3054,6 +3148,7 @@ static int cmd_chmod(void)
        char *targetname = NULL;
        struct cli_state *targetcli;
        mode_t mode;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL) ||
            !next_token_talloc(ctx, &cmd_ptr,&buf2,NULL)) {
@@ -3070,8 +3165,10 @@ static int cmd_chmod(void)
 
        mode = (mode_t)strtol(buf, NULL, 8);
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli, &targetname)) {
-               d_printf("chmod %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("chmod %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
@@ -3080,9 +3177,10 @@ static int cmd_chmod(void)
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_chmod(targetcli, targetname, mode))) {
+       status = cli_posix_chmod(targetcli, targetname, mode);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s chmod file %s 0%o\n",
-                       cli_errstr(targetcli), src, (unsigned int)mode);
+                        nt_errstr(status), src, (unsigned int)mode);
                return 1;
        }
 
@@ -3224,8 +3322,10 @@ static int cmd_getfacl(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli, &targetname)) {
-               d_printf("stat %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("stat %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
@@ -3248,15 +3348,17 @@ static int cmd_getfacl(void)
                return 1;
        }
 
+       status = cli_posix_stat(targetcli, targetname, &sbuf);
        if (!NT_STATUS_IS_OK(cli_posix_stat(targetcli, targetname, &sbuf))) {
                d_printf("%s getfacl doing a stat on file %s\n",
-                       cli_errstr(targetcli), src);
+                        nt_errstr(status), src);
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_getfacl(targetcli, targetname, ctx, &rb_size, &retbuf))) {
+       status = cli_posix_getfacl(targetcli, targetname, ctx, &rb_size, &retbuf);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s getfacl file %s\n",
-                       cli_errstr(targetcli), src);
+                        nt_errstr(status), src);
                return 1;
        }
 
@@ -3393,9 +3495,10 @@ static int cmd_geteas(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
-                             &targetname)) {
-               d_printf("stat %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("stat %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
@@ -3449,9 +3552,10 @@ static int cmd_setea(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
-                             &targetname)) {
-               d_printf("stat %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("stat %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
@@ -3480,6 +3584,7 @@ static int cmd_stat(void)
        SMB_STRUCT_STAT sbuf;
        struct tm *lt;
        time_t tmp_time;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&name,NULL)) {
                d_printf("stat file\n");
@@ -3493,8 +3598,10 @@ static int cmd_stat(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli, &targetname)) {
-               d_printf("stat %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("stat %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
@@ -3503,9 +3610,10 @@ static int cmd_stat(void)
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_stat(targetcli, targetname, &sbuf))) {
+       status = cli_posix_stat(targetcli, targetname, &sbuf);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s stat file %s\n",
-                       cli_errstr(targetcli), src);
+                        nt_errstr(status), src);
                return 1;
        }
 
@@ -3579,6 +3687,7 @@ static int cmd_chown(void)
        char *buf, *buf2, *buf3;
        struct cli_state *targetcli;
        char *targetname = NULL;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL) ||
            !next_token_talloc(ctx, &cmd_ptr,&buf2,NULL) ||
@@ -3597,8 +3706,10 @@ static int cmd_chown(void)
        if (!src) {
                return 1;
        }
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli, &targetname) ) {
-               d_printf("chown %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("chown %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
@@ -3607,9 +3718,10 @@ static int cmd_chown(void)
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_posix_chown(targetcli, targetname, uid, gid))) {
+       status = cli_posix_chown(targetcli, targetname, uid, gid);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s chown file %s uid=%d, gid=%d\n",
-                       cli_errstr(targetcli), src, (int)uid, (int)gid);
+                        nt_errstr(status), src, (int)uid, (int)gid);
                return 1;
        }
 
@@ -3628,6 +3740,7 @@ static int cmd_rename(void)
        struct cli_state *targetcli;
        char *targetsrc;
        char *targetdest;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL) ||
            !next_token_talloc(ctx, &cmd_ptr,&buf2,NULL)) {
@@ -3651,19 +3764,24 @@ static int cmd_rename(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli, &targetsrc)) {
-               d_printf("rename %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetsrc);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("rename %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, dest, &targetcli, &targetdest)) {
-               d_printf("rename %s: %s\n", dest, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, dest, &targetcli,
+                                 &targetdest);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("rename %s: %s\n", dest, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_rename(targetcli, targetsrc, targetdest))) {
+       status = cli_rename(targetcli, targetsrc, targetdest);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("%s renaming files %s -> %s \n",
-                       cli_errstr(targetcli),
+                       nt_errstr(status),
                        targetsrc,
                        targetdest);
                return 1;
@@ -3678,12 +3796,13 @@ static int cmd_rename(void)
 
 static int cmd_volume(void)
 {
-       fstring volname;
-       uint32 serial_num;
+       char *volname;
+       uint32_t serial_num;
        time_t create_date;
        NTSTATUS status;
 
-       status = cli_get_fs_volume_info(cli, volname, &serial_num,
+       status = cli_get_fs_volume_info(cli, talloc_tos(),
+                                       &volname, &serial_num,
                                        &create_date);
        if (!NT_STATUS_IS_OK(status)) {
                d_printf("Error %s getting volume info\n", nt_errstr(status));
@@ -3706,6 +3825,7 @@ static int cmd_hardlink(void)
        char *buf, *buf2;
        struct cli_state *targetcli;
        char *targetname;
+        NTSTATUS status;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL) ||
            !next_token_talloc(ctx, &cmd_ptr,&buf2,NULL)) {
@@ -3729,13 +3849,17 @@ static int cmd_hardlink(void)
                return 1;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli, &targetname)) {
-               d_printf("hardlink %s: %s\n", src, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli, src, &targetcli,
+                                 &targetname);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("hardlink %s: %s\n", src, nt_errstr(status));
                return 1;
        }
 
-       if (!NT_STATUS_IS_OK(cli_nt_hardlink(targetcli, targetname, dest))) {
-               d_printf("%s doing an NT hard link of files\n",cli_errstr(targetcli));
+       status = cli_nt_hardlink(targetcli, targetname, dest);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("%s doing an NT hard link of files\n",
+                        nt_errstr(status));
                return 1;
        }
 
@@ -3799,6 +3923,18 @@ static int cmd_archive(void)
        return 0;
 }
 
+/****************************************************************************
+ Toggle the backup_intent state.
+****************************************************************************/
+
+static int cmd_backup(void)
+{
+       backup_intent = !backup_intent;
+       cli_set_backup_intent(cli, backup_intent);
+       DEBUG(2,("backup intent is now %s\n",backup_intent?"on":"off"));
+       return 1;
+}
+
 /****************************************************************************
  Toggle the lowercaseflag.
 ****************************************************************************/
@@ -4074,8 +4210,11 @@ static bool browse_host(bool sort)
                return true;
        }
 
-       if((ret = cli_RNetShareEnum(cli, browse_fn, NULL)) == -1)
-               d_printf("Error returning browse list: %s\n", cli_errstr(cli));
+       if((ret = cli_RNetShareEnum(cli, browse_fn, NULL)) == -1) {
+               NTSTATUS status = cli_nt_error(cli);
+               d_printf("Error returning browse list: %s\n",
+                        nt_errstr(status));
+       }
 
        return (ret != -1);
 }
@@ -4135,11 +4274,12 @@ static int cmd_vuid(void)
        char *buf;
 
        if (!next_token_talloc(ctx, &cmd_ptr,&buf,NULL)) {
-               d_printf("Current VUID is %d\n", cli->vuid);
+               d_printf("Current VUID is %d\n",
+                        cli_state_get_uid(cli));
                return 0;
        }
 
-       cli->vuid = atoi(buf);
+       cli_state_set_uid(cli, atoi(buf));
        return 0;
 }
 
@@ -4177,7 +4317,100 @@ static int cmd_logon(void)
                return -1;
        }
 
-       d_printf("Current VUID is %d\n", cli->vuid);
+       d_printf("Current VUID is %d\n", cli_state_get_uid(cli));
+       return 0;
+}
+
+/**
+ * close the session
+ */
+
+static int cmd_logoff(void)
+{
+       NTSTATUS status;
+
+       status = cli_ulogoff(cli);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("logoff failed: %s\n", nt_errstr(status));
+               return -1;
+       }
+
+       d_printf("logoff successful\n");
+       return 0;
+}
+
+
+/**
+ * tree connect (connect to a share)
+ */
+
+static int cmd_tcon(void)
+{
+       TALLOC_CTX *ctx = talloc_tos();
+       char *sharename;
+       NTSTATUS status;
+
+       if (!next_token_talloc(ctx, &cmd_ptr, &sharename, NULL)) {
+               d_printf("tcon <sharename>\n");
+               return 0;
+       }
+
+       if (!sharename) {
+               return 1;
+       }
+
+       status = cli_tree_connect(cli, sharename, "?????", "", 0);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("tcon failed: %s\n", nt_errstr(status));
+               return -1;
+       }
+
+       talloc_free(sharename);
+
+       d_printf("tcon to %s successful, tid: %u\n", sharename,
+                cli_state_get_tid(cli));
+       return 0;
+}
+
+/**
+ * tree disconnect (disconnect from a share)
+ */
+
+static int cmd_tdis(void)
+{
+       NTSTATUS status;
+
+       status = cli_tdis(cli);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("tdis failed: %s\n", nt_errstr(status));
+               return -1;
+       }
+
+       d_printf("tdis successful\n");
+       return 0;
+}
+
+
+/**
+ * get or set tid
+ */
+
+static int cmd_tid(void)
+{
+       TALLOC_CTX *ctx = talloc_tos();
+       char *tid_str;
+
+       if (!next_token_talloc(ctx, &cmd_ptr, &tid_str, NULL)) {
+               if (cli_state_has_tcon(cli)) {
+                       d_printf("current tid is %d\n", cli_state_get_tid(cli));
+               } else {
+                       d_printf("no tcon currently\n");
+               }
+       } else {
+               uint16_t tid = atoi(tid_str);
+               cli_state_set_tid(cli, tid);
+       }
+
        return 0;
 }
 
@@ -4201,14 +4434,17 @@ static int cmd_show_connect( void )
        TALLOC_CTX *ctx = talloc_tos();
        struct cli_state *targetcli;
        char *targetpath;
+       NTSTATUS status;
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, client_get_cur_dir(),
-                               &targetcli, &targetpath ) ) {
-               d_printf("showconnect %s: %s\n", cur_dir, cli_errstr(cli));
+       status = cli_resolve_path(ctx, "", auth_info, cli,
+                                 client_get_cur_dir(), &targetcli,
+                                 &targetpath);
+       if (!NT_STATUS_IS_OK(status)) {
+               d_printf("showconnect %s: %s\n", cur_dir, nt_errstr(status));
                return 1;
        }
 
-       d_printf("//%s/%s\n", targetcli->desthost, targetcli->share);
+       d_printf("//%s/%s\n", cli_state_remote_name(targetcli), targetcli->share);
        return 0;
 }
 
@@ -4296,6 +4532,7 @@ static struct {
    {COMPL_NONE,COMPL_NONE}},
   {"altname",cmd_altname,"<file> show alt name",{COMPL_NONE,COMPL_NONE}},
   {"archive",cmd_archive,"<level>\n0=ignore archive bit\n1=only get archive files\n2=only get archive files and reset archive bit\n3=get all files and reset archive bit",{COMPL_NONE,COMPL_NONE}},
+  {"backup",cmd_backup,"toggle backup intent state",{COMPL_NONE,COMPL_NONE}},  
   {"blocksize",cmd_block,"blocksize <number> (default 20)",{COMPL_NONE,COMPL_NONE}},
   {"cancel",cmd_cancel,"<jobid> cancel a print queue entry",{COMPL_NONE,COMPL_NONE}},
   {"case_sensitive",cmd_setcase,"toggle the case sensitive flag to server",{COMPL_NONE,COMPL_NONE}},
@@ -4367,6 +4604,10 @@ static struct {
   {"logon",cmd_logon,"establish new logon",{COMPL_NONE,COMPL_NONE}},
   {"listconnect",cmd_list_connect,"list open connections",{COMPL_NONE,COMPL_NONE}},
   {"showconnect",cmd_show_connect,"display the current active connection",{COMPL_NONE,COMPL_NONE}},
+  {"tcon",cmd_tcon,"connect to a share" ,{COMPL_NONE,COMPL_NONE}},
+  {"tdis",cmd_tdis,"disconnect from a share",{COMPL_NONE,COMPL_NONE}},
+  {"tid",cmd_tid,"show or set the current tid (tree-id)",{COMPL_NONE,COMPL_NONE}},
+  {"logoff",cmd_logoff,"log off (close the session)",{COMPL_NONE,COMPL_NONE}},
   {"..",cmd_cd_oneup,"change the remote directory (up one level)",{COMPL_REMOTE,COMPL_NONE}},
 
   /* Yes, this must be here, see crh's comment above. */
@@ -4447,12 +4688,15 @@ static int process_command_string(const char *cmd_in)
        /* establish the connection if not already */
 
        if (!cli) {
-               cli = cli_cm_open(talloc_tos(), NULL,
-                               have_ip ? dest_ss_str : desthost,
-                               service, auth_info,
-                               true, smb_encrypt,
-                               max_protocol, port, name_type);
-               if (!cli) {
+               NTSTATUS status;
+
+               status = cli_cm_open(talloc_tos(), NULL,
+                                    have_ip ? dest_ss_str : desthost,
+                                    service, auth_info,
+                                    true, smb_encrypt,
+                                    max_protocol, port, name_type,
+                                    &cli);
+               if (!NT_STATUS_IS_OK(status)) {
                        return 1;
                }
        }
@@ -4627,7 +4871,9 @@ static char **remote_completion(const char *text, int len)
                goto cleanup;
        }
 
-       if (!cli_resolve_path(ctx, "", auth_info, cli, dirmask, &targetcli, &targetpath)) {
+       status = cli_resolve_path(ctx, "", auth_info, cli, dirmask, &targetcli,
+                                 &targetpath);
+       if (!NT_STATUS_IS_OK(status)) {
                goto cleanup;
        }
        status = cli_list(targetcli, targetpath, FILE_ATTRIBUTE_DIRECTORY | FILE_ATTRIBUTE_SYSTEM | FILE_ATTRIBUTE_HIDDEN,
@@ -4777,7 +5023,8 @@ static void readline_callback(void)
        static time_t last_t;
        struct timespec now;
        time_t t;
-       int ret, revents;
+       NTSTATUS status;
+       unsigned char garbage[16];
 
        clock_gettime_mono(&now);
        t = now.tv_sec;
@@ -4787,69 +5034,14 @@ static void readline_callback(void)
 
        last_t = t;
 
- again:
-
-       if (cli->fd == -1)
-               return;
-
-       /* We deliberately use receive_smb_raw instead of
-          client_receive_smb as we want to receive
-          session keepalives and then drop them here.
-       */
-
-       ret = poll_intr_one_fd(cli->fd, POLLIN|POLLHUP, 0, &revents);
-
-       if ((ret > 0) && (revents & (POLLIN|POLLHUP|POLLERR))) {
-               NTSTATUS status;
-               size_t len;
-
-               set_smb_read_error(&cli->smb_rw_error, SMB_READ_OK);
-
-               status = receive_smb_raw(cli->fd, cli->inbuf, cli->bufsize, 0, 0, &len);
-
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("Read from server failed, maybe it closed "
-                                 "the connection\n"));
-
-                       finished = true;
-                       smb_readline_done();
-                       if (NT_STATUS_EQUAL(status, NT_STATUS_END_OF_FILE)) {
-                               set_smb_read_error(&cli->smb_rw_error,
-                                                  SMB_READ_EOF);
-                               return;
-                       }
-
-                       if (NT_STATUS_EQUAL(status, NT_STATUS_IO_TIMEOUT)) {
-                               set_smb_read_error(&cli->smb_rw_error,
-                                                  SMB_READ_TIMEOUT);
-                               return;
-                       }
-
-                       set_smb_read_error(&cli->smb_rw_error, SMB_READ_ERROR);
-                       return;
-               }
-               if(CVAL(cli->inbuf,0) != SMBkeepalive) {
-                       DEBUG(0, ("Read from server "
-                               "returned unexpected packet!\n"));
-                       return;
-               }
-
-               goto again;
-       }
-
        /* Ping the server to keep the connection alive using SMBecho. */
-       {
-               NTSTATUS status;
-               unsigned char garbage[16];
-               memset(garbage, 0xf0, sizeof(garbage));
-               status = cli_echo(cli, 1, data_blob_const(garbage, sizeof(garbage)));
-
-               if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(0, ("SMBecho failed. Maybe server has closed "
-                               "the connection\n"));
-                       finished = true;
-                       smb_readline_done();
-               }
+       memset(garbage, 0xf0, sizeof(garbage));
+       status = cli_echo(cli, 1, data_blob_const(garbage, sizeof(garbage)));
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0, ("SMBecho failed (%s). Maybe server has closed "
+                       "the connection\n", nt_errstr(status)));
+               finished = true;
+               smb_readline_done();
        }
 }
 
@@ -4919,12 +5111,13 @@ static int process_stdin(void)
 static int process(const char *base_directory)
 {
        int rc = 0;
+       NTSTATUS status;
 
-       cli = cli_cm_open(talloc_tos(), NULL,
-                       have_ip ? dest_ss_str : desthost,
-                       service, auth_info, true, smb_encrypt,
-                       max_protocol, port, name_type);
-       if (!cli) {
+       status = cli_cm_open(talloc_tos(), NULL,
+                            have_ip ? dest_ss_str : desthost,
+                            service, auth_info, true, smb_encrypt,
+                            max_protocol, port, name_type, &cli);
+       if (!NT_STATUS_IS_OK(status)) {
                return 1;
        }
 
@@ -4952,11 +5145,15 @@ static int process(const char *base_directory)
 
 static int do_host_query(const char *query_host)
 {
-       cli = cli_cm_open(talloc_tos(), NULL,
-                       have_ip ? dest_ss_str : query_host, "IPC$", auth_info, true, smb_encrypt,
-                       max_protocol, port, name_type);
-       if (!cli)
+       NTSTATUS status;
+
+       status = cli_cm_open(talloc_tos(), NULL,
+                            have_ip ? dest_ss_str : query_host,
+                            "IPC$", auth_info, true, smb_encrypt,
+                            max_protocol, port, name_type, &cli);
+       if (!NT_STATUS_IS_OK(status)) {
                return 1;
+       }
 
        browse_host(true);
 
@@ -4978,10 +5175,13 @@ static int do_host_query(const char *query_host)
                   else but port 139... */
 
                cli_shutdown(cli);
-               cli = cli_cm_open(talloc_tos(), NULL,
-                               have_ip ? dest_ss_str : query_host, "IPC$",
-                               auth_info, true, smb_encrypt,
-                               max_protocol, 139, name_type);
+               status = cli_cm_open(talloc_tos(), NULL,
+                                    have_ip ? dest_ss_str : query_host,
+                                    "IPC$", auth_info, true, smb_encrypt,
+                                    max_protocol, 139, name_type, &cli);
+               if (!NT_STATUS_IS_OK(status)) {
+                       cli = NULL;
+               }
        }
 
        if (cli == NULL) {
@@ -5006,12 +5206,15 @@ static int do_tar_op(const char *base_directory)
 
        /* do we already have a connection? */
        if (!cli) {
-               cli = cli_cm_open(talloc_tos(), NULL,
-                       have_ip ? dest_ss_str : desthost,
-                       service, auth_info, true, smb_encrypt,
-                       max_protocol, port, name_type);
-               if (!cli)
+               NTSTATUS status;
+
+               status = cli_cm_open(talloc_tos(), NULL,
+                                    have_ip ? dest_ss_str : desthost,
+                                    service, auth_info, true, smb_encrypt,
+                                    max_protocol, port, name_type, &cli);
+               if (!NT_STATUS_IS_OK(status)) {
                        return 1;
+               }
        }
 
        recurse=true;
@@ -5041,7 +5244,7 @@ static int do_message_op(struct user_auth_info *a_info)
 
        status = cli_connect_nb(desthost, have_ip ? &dest_ss : NULL,
                                port ? port : 139, name_type,
-                               lp_netbios_name(), Undefined, &cli);
+                               lp_netbios_name(), SMB_SIGNING_DEFAULT, 0, &cli);
        if (!NT_STATUS_IS_OK(status)) {
                d_printf("Connection to %s failed. Error %s\n", desthost, nt_errstr(status));
                return 1;
@@ -5112,8 +5315,6 @@ static int do_message_op(struct user_auth_info *a_info)
        pc = poptGetContext("smbclient", argc, (const char **) argv, long_options, 0);
        poptSetOtherOptionHelp(pc, "service <password>");
 
-        lp_set_in_client(true); /* Make sure that we tell lp_load we are */
-
        while ((opt = poptGetNextOpt(pc)) != -1) {
 
                /* if the tar option has been called previouslt, now we need to eat out the leftovers */
@@ -5244,7 +5445,7 @@ static int do_message_op(struct user_auth_info *a_info)
        if ( override_logfile )
                setup_logging( lp_logfile(), DEBUG_FILE );
 
-       if (!lp_load(get_dyn_CONFIGFILE(),true,false,false,true)) {
+       if (!lp_load_client(get_dyn_CONFIGFILE())) {
                fprintf(stderr, "%s: Can't load %s - run testparm to debug it\n",
                        argv[0], get_dyn_CONFIGFILE());
        }