Herb's warning fixes. Also the POSIX locking fix.
[samba.git] / source / rpc_server / srv_spoolss_nt.c
index f974311c7192d84120e57bd1d4814cd27babf478..5a724d6ab6487fbd701f21203a5530eb3b645b8a 100644 (file)
@@ -22,7 +22,6 @@
  *  Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
  */
 
-
 #include "includes.h"
 
 extern int DEBUGLEVEL;
@@ -50,7 +49,7 @@ typedef struct _Printer{
        POLICY_HND printer_hnd;
        BOOL printer_type;
        union {
-               fstring printername;
+               fstring handlename;
                fstring printerservername;
        } dev;
        uint32 type;
@@ -61,6 +60,8 @@ typedef struct _Printer{
                fstring localmachine; 
                uint32 printerlocal;
                SPOOL_NOTIFY_OPTION *option;
+               POLICY_HND client_hnd;
+               uint32 client_connected;
        } notify;
        struct {
                fstring machine;
@@ -79,8 +80,11 @@ typedef struct _counter_printer_0 {
 static ubi_dlList Printer_list;
 static ubi_dlList counter_list;
 
+static struct cli_state cli;
+static uint32 smb_connections=0;
 
-#define OPEN_HANDLE(pnum)    ((pnum!=NULL) && (pnum->open!=False))
+#define OPEN_HANDLE(pnum)    ((pnum!=NULL) && (pnum->open!=False) && (IVAL(pnum->printer_hnd.data,16)==(uint32)sys_getpid()))
+#define OUR_HANDLE(pnum) ((pnum==NULL)?"NULL":(IVAL(pnum->data,16)==sys_getpid()?"OURS":"OTHER"))
 
 /* translate between internal status numbers and NT status numbers */
 static int nt_printj_status(int v)
@@ -100,7 +104,7 @@ static int nt_printq_status(int v)
 {
        switch (v) {
        case LPQ_PAUSED:
-               return PRINTER_STATUS_ERROR;
+               return PRINTER_STATUS_PAUSED;
        case LPQ_QUEUED:
        case LPQ_SPOOLING:
        case LPQ_PRINTING:
@@ -150,8 +154,7 @@ static Printer_entry *find_printer_index_by_hnd(const POLICY_HND *hnd)
 
        for(; find_printer; find_printer = (Printer_entry *)ubi_dlNext(find_printer)) {
 
-               if (memcmp(&(find_printer->printer_hnd), hnd, sizeof(*hnd)) == 0)
-               {
+               if (memcmp(&(find_printer->printer_hnd), hnd, sizeof(*hnd)) == 0) {
                        DEBUG(4,("Found printer handle \n"));
                        /*dump_data(4, hnd->data, sizeof(hnd->data));*/
                        return find_printer;
@@ -168,7 +171,36 @@ static Printer_entry *find_printer_index_by_hnd(const POLICY_HND *hnd)
 ****************************************************************************/
 static void clear_handle(POLICY_HND *hnd)
 {
-       memset(hnd->data, 0, POLICY_HND_SIZE);
+       ZERO_STRUCTP(hnd);
+}
+
+/***************************************************************************
+ Disconnect from the client
+****************************************************************************/
+static BOOL srv_spoolss_replycloseprinter(POLICY_HND *handle)
+{
+       uint32 status;
+
+       /* weird if the test succeds !!! */
+       if (smb_connections==0) {
+               DEBUG(0,("srv_spoolss_replycloseprinter:Trying to close non-existant notify backchannel !\n"));
+               return False;
+       }
+
+       if(!cli_spoolss_reply_close_printer(&cli, handle, &status))
+               return False;
+
+       /* if it's the last connection, deconnect the IPC$ share */
+       if (smb_connections==1) {
+               if(!spoolss_disconnect_from_client(&cli))
+                       return False;
+
+               message_deregister(MSG_PRINTER_NOTIFY);
+       }
+
+       smb_connections--;
+
+       return True;
 }
 
 /****************************************************************************
@@ -178,12 +210,15 @@ static BOOL close_printer_handle(POLICY_HND *hnd)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error closing printer handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("close_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
 
+       if (Printer->notify.client_connected==True)
+               if(!srv_spoolss_replycloseprinter(&Printer->notify.client_hnd))
+                       return ERROR_INVALID_HANDLE;
+
        Printer->open=False;
        Printer->notify.flags=0;
        Printer->notify.options=0;
@@ -191,7 +226,8 @@ static BOOL close_printer_handle(POLICY_HND *hnd)
        Printer->notify.printerlocal=0;
        safe_free(Printer->notify.option);
        Printer->notify.option=NULL;
-       
+       Printer->notify.client_connected=False;
+
        clear_handle(hnd);
 
        ubi_dlRemThis(&Printer_list, Printer);
@@ -208,68 +244,85 @@ static BOOL delete_printer_handle(POLICY_HND *hnd)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error closing printer handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("delete_printer_handle: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
 
-       if (del_a_printer(Printer->dev.printername) != 0) {
-               DEBUG(3,("Error deleting printer %s\n", Printer->dev.printername));
+       if (del_a_printer(Printer->dev.handlename) != 0) {
+               DEBUG(3,("Error deleting printer %s\n", Printer->dev.handlename));
                return False;
        }
 
+       if (*lp_deleteprinter_cmd()) {
+
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_deleteprinter_cmd();
+               char *path;
+               pstring tmp_file;
+               pstring command;
+               int ret;
+               int i;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+               
+               /* Printer->dev.handlename equals portname equals sharename */
+               slprintf(command, sizeof(command), "%s \"%s\"", cmd,
+                                       Printer->dev.handlename);
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       return False;
+               }
+               DEBUGADD(10,("returned [%d]\n", ret));
+               DEBUGADD(10,("Unlinking output file [%s]\n", tmp_file));
+               unlink(tmp_file);
+
+               /* Send SIGHUP to process group... is there a better way? */
+               kill(0, SIGHUP);
+
+               if ( ( i = lp_servicenumber( Printer->dev.handlename ) ) >= 0 ) {
+                       lp_remove_service( i );
+                       lp_killservice( i );
+                       return True;
+               } else
+                       return False;
+       }
+
        return True;
 }      
 
 /****************************************************************************
   return the snum of a printer corresponding to an handle
 ****************************************************************************/
-static BOOL get_printer_snum(const POLICY_HND *hnd, int *number)
+static BOOL get_printer_snum(POLICY_HND *hnd, int *number)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
                
        if (!OPEN_HANDLE(Printer)) {
-               DEBUG(3,("Error getting printer - take a nap quickly !\n"));
+               DEBUG(0,("get_printer_snum: Invalid handle (%s)\n", OUR_HANDLE(hnd)));
                return False;
        }
        
        switch (Printer->printer_type) {
        case PRINTER_HANDLE_IS_PRINTER:            
-               DEBUG(4,("short name:%s\n", Printer->dev.printername));                 
-               *number = print_queue_snum(Printer->dev.printername);
+               DEBUG(4,("short name:%s\n", Printer->dev.handlename));                  
+               *number = print_queue_snum(Printer->dev.handlename);
                return (*number != -1);
        case PRINTER_HANDLE_IS_PRINTSERVER:
                return False;
-               break;
        default:
                return False;
-               break;
        }
 }
 
-/****************************************************************************
-  find first available printer slot. creates a printer handle for you.
- ****************************************************************************/
-static BOOL open_printer_hnd(POLICY_HND *hnd)
-{
-       Printer_entry *new_printer;
-
-       if((new_printer=(Printer_entry *)malloc(sizeof(Printer_entry))) == NULL)
-               return False;
-
-       ZERO_STRUCTP(new_printer);
-       
-       new_printer->open = True;
-       new_printer->notify.option=NULL;
-                               
-       memcpy(&(new_printer->printer_hnd), hnd, sizeof(*hnd));
-       
-       ubi_dlAddHead( &Printer_list, (ubi_dlNode *)new_printer);
-
-       return True;
-}
-
 /****************************************************************************
   set printer handle type.
 ****************************************************************************/
@@ -278,7 +331,7 @@ static BOOL set_printer_hnd_accesstype(POLICY_HND *hnd, uint32 access_required)
        Printer_entry *Printer = find_printer_index_by_hnd(hnd);
 
        if (!OPEN_HANDLE(Printer)) {
-               DEBUG(4,("Error setting printer type=%x", access_required));
+               DEBUG(0,("set_printer_hnd_accesstype: Invalid handle (%s)", OUR_HANDLE(hnd)));
                return False;
        }
 
@@ -288,70 +341,57 @@ static BOOL set_printer_hnd_accesstype(POLICY_HND *hnd, uint32 access_required)
 }
 
 /****************************************************************************
 set printer handle type.
 check if it's \\server or \\server\printer
Set printer handle type.
Check if it's \\server or \\server\printer
 ****************************************************************************/
-static BOOL set_printer_hnd_printertype(POLICY_HND *hnd, char *printername)
+
+static BOOL set_printer_hnd_printertype(Printer_entry *Printer, char *handlename)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
-               
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUGADD(4,("Error setting printer name %s", printername));
-               return False;
-       }
-       
-       DEBUG(3,("Setting printer type=%s\n", printername));
+       DEBUG(3,("Setting printer type=%s\n", handlename));
 
-       if ( strlen(printername) < 3 ) {
-               DEBUGADD(4,("A print server must have at least 1 char ! %s\n", printername));
+       if ( strlen(handlename) < 3 ) {
+               DEBUGADD(4,("A print server must have at least 1 char ! %s\n", handlename));
                return False;
        }
 
        /* it's a print server */
-       if (!strchr(printername+2, '\\')) {
+       if (!strchr(handlename+2, '\\')) {
                DEBUGADD(4,("Printer is a print server\n"));
                Printer->printer_type = PRINTER_HANDLE_IS_PRINTSERVER;          
-               return True;
        }
        /* it's a printer */
        else {
                DEBUGADD(4,("Printer is a printer\n"));
                Printer->printer_type = PRINTER_HANDLE_IS_PRINTER;
-               return True;
        }
 
-       return False;
+       return True;
 }
 
 /****************************************************************************
 set printer handle printername.
Set printer handle name.
 ****************************************************************************/
-static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
+
+static BOOL set_printer_hnd_name(Printer_entry *Printer, char *handlename)
 {
-       Printer_entry *Printer = find_printer_index_by_hnd(hnd);
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        int snum;
        int n_services=lp_numservices();
        char *aprinter;
        BOOL found=False;
        
-       if (!OPEN_HANDLE(Printer)) {
-               DEBUG(0,("Error setting printer name=%s\n", printername));
-               return False;
-       }
-
-       DEBUG(4,("Setting printer name=%s (len=%d)\n", printername, strlen(printername)));
+       DEBUG(4,("Setting printer name=%s (len=%d)\n", handlename, strlen(handlename)));
 
        if (Printer->printer_type==PRINTER_HANDLE_IS_PRINTSERVER) {
                ZERO_STRUCT(Printer->dev.printerservername);
-               strncpy(Printer->dev.printerservername, printername, strlen(printername));
+               strncpy(Printer->dev.printerservername, handlename, strlen(handlename));
                return True;
        }
 
        if (Printer->printer_type!=PRINTER_HANDLE_IS_PRINTER)
                return False;
        
-       aprinter=strchr(printername+2, '\\');
+       aprinter=strchr(handlename+2, '\\');
        aprinter++;
 
        DEBUGADD(5,("searching for [%s] (len=%d)\n", aprinter, strlen(aprinter)));
@@ -374,16 +414,16 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
                if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
                        continue;
 
-               DEBUG(10,("set_printer_hnd_printername: printername [%s], aprinter [%s]\n", 
-                               printer.info_2->printername, aprinter ));
+               DEBUG(10,("set_printer_hnd_name: name [%s], aprinter [%s]\n", 
+                               printer->info_2->printername, aprinter ));
 
-               if ( strlen(printer.info_2->printername) != strlen(aprinter) ) {
-                       free_a_printer(printer, 2);
+               if ( strlen(printer->info_2->printername) != strlen(aprinter) ) {
+                       free_a_printer(&printer, 2);
                        continue;
                }
                
-               if ( strncasecmp(printer.info_2->printername, aprinter, strlen(aprinter)))  {
-                       free_a_printer(printer, 2);
+               if ( strncasecmp(printer->info_2->printername, aprinter, strlen(aprinter)))  {
+                       free_a_printer(&printer, 2);
                        continue;
                }
                
@@ -391,7 +431,7 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
        }
 
        /* 
-        * if we haven't found a printer with the given printername
+        * if we haven't found a printer with the given handlename
         * then it can be a share name as you can open both \\server\printer and
         * \\server\share
         */
@@ -409,21 +449,21 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
                        if ( !(lp_snum_ok(snum) && lp_print_ok(snum) ) )
                                continue;
                
-                       DEBUGADD(5,("share:%s\n",lp_servicename(snum)));
+                       DEBUGADD(5,("set_printer_hnd_name: share:%s\n",lp_servicename(snum)));
 
                        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
                                continue;
 
-                       DEBUG(10,("set_printer_hnd_printername: printername [%s], aprinter [%s]\n", 
-                                       printer.info_2->printername, aprinter ));
+                       DEBUG(10,("set_printer_hnd_name: printername [%s], aprinter [%s]\n", 
+                                       printer->info_2->printername, aprinter ));
 
                        if ( strlen(lp_servicename(snum)) != strlen(aprinter) ) {
-                               free_a_printer(printer, 2);
+                               free_a_printer(&printer, 2);
                                continue;
                        }
                
                        if ( strncasecmp(lp_servicename(snum), aprinter, strlen(aprinter)))  {
-                               free_a_printer(printer, 2);
+                               free_a_printer(&printer, 2);
                                continue;
                        }
                
@@ -437,11 +477,51 @@ static BOOL set_printer_hnd_printername(POLICY_HND *hnd, char *printername)
        }
        
        snum--;
-       DEBUGADD(4,("Printer found: %s -> %s[%x]\n",printer.info_2->printername, lp_servicename(snum),snum));
-       ZERO_STRUCT(Printer->dev.printername);
-       strncpy(Printer->dev.printername, lp_servicename(snum), strlen(lp_servicename(snum)));
-       free_a_printer(printer, 2);
+       DEBUGADD(4,("set_printer_hnd_name: Printer found: %s -> %s[%x]\n",
+                       printer->info_2->printername, lp_servicename(snum),snum));
+
+       ZERO_STRUCT(Printer->dev.handlename);
+       strncpy(Printer->dev.handlename, lp_servicename(snum), strlen(lp_servicename(snum)));
+       
+       free_a_printer(&printer, 2);
+
+       return True;
+}
+
+/****************************************************************************
+  find first available printer slot. creates a printer handle for you.
+ ****************************************************************************/
+
+static BOOL open_printer_hnd(POLICY_HND *hnd, char *name)
+{
+       Printer_entry *new_printer;
+
+       DEBUG(10,("open_printer_hnd: name [%s]\n", name));
+       clear_handle(hnd);
+       create_printer_hnd(hnd);
+
+       if((new_printer=(Printer_entry *)malloc(sizeof(Printer_entry))) == NULL)
+               return False;
+
+       ZERO_STRUCTP(new_printer);
        
+       new_printer->open = True;
+       new_printer->notify.option=NULL;
+                               
+       memcpy(&new_printer->printer_hnd, hnd, sizeof(*hnd));
+       
+       ubi_dlAddHead( &Printer_list, (ubi_dlNode *)new_printer);
+
+       if (!set_printer_hnd_printertype(new_printer, name)) {
+               close_printer_handle(hnd);
+               return False;
+       }
+       
+       if (!set_printer_hnd_name(new_printer, name)) {
+               close_printer_handle(hnd);
+               return False;
+       }
+
        return True;
 }
 
@@ -470,7 +550,7 @@ static BOOL alloc_buffer_size(NEW_BUFFER *buffer, uint32 buffer_size)
        uint32 extra_space;
        uint32 old_offset;
        
-       ps=&(buffer->prs);
+       ps= &buffer->prs;
 
        /* damn, I'm doing the reverse operation of prs_grow() :) */
        if (buffer_size < prs_data_size(ps))
@@ -495,6 +575,72 @@ static BOOL alloc_buffer_size(NEW_BUFFER *buffer, uint32 buffer_size)
        return True;
 }
 
+/***************************************************************************
+ receive the notify message
+****************************************************************************/
+void srv_spoolss_receive_message(int msg_type, pid_t src, void *buf, size_t len)
+{      
+       fstring printer;
+       uint32 status;
+       Printer_entry *find_printer;
+
+       *printer = '\0';
+       fstrcpy(printer,buf);
+
+       if (len == 0) {
+               DEBUG(0,("srv_spoolss_receive_message: got null message !\n"));
+               return;
+       }
+
+       DEBUG(10,("srv_spoolss_receive_message: Got message about printer %s\n", printer ));
+
+       find_printer = (Printer_entry *)ubi_dlFirst(&Printer_list);
+
+       /* Iterate the printer list. */
+       for(; find_printer; find_printer = (Printer_entry *)ubi_dlNext(find_printer)) {
+
+               /* 
+                * if the entry is the given printer or if it's a printerserver
+                * we send the message
+                */
+
+               if (find_printer->printer_type==PRINTER_HANDLE_IS_PRINTER)
+                       if (strcmp(find_printer->dev.handlename, printer))
+                               continue;
+
+               if (find_printer->notify.client_connected==True)
+                       cli_spoolss_reply_rrpcn(&cli, &find_printer->notify.client_hnd, PRINTER_CHANGE_ALL, 0x0, &status);
+
+       }
+}
+
+/***************************************************************************
+ send a notify event
+****************************************************************************/
+static BOOL srv_spoolss_sendnotify(POLICY_HND *handle)
+{
+       fstring printer;
+
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("srv_spoolss_sendnotify: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return False;
+       }
+
+       if (Printer->printer_type==PRINTER_HANDLE_IS_PRINTER)
+               fstrcpy(printer, Printer->dev.handlename);
+       else
+               fstrcpy(printer, "");
+
+       /*srv_spoolss_receive_message(printer);*/
+       DEBUG(10,("srv_spoolss_sendnotify: Sending message about printer %s\n", printer ));
+
+       message_send_all(MSG_PRINTER_NOTIFY, printer, strlen(printer) + 1); /* Null terminate... */
+
+       return True;
+}      
+
 /********************************************************************
  * spoolss_open_printer
  *
@@ -507,8 +653,6 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 {
        fstring name;
        
-       clear_handle(handle);
-       
        if (printername == NULL)
                return ERROR_INVALID_PRINTER_NAME;
 
@@ -518,20 +662,9 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
 
        DEBUGADD(3,("checking name: %s\n",name));
 
-       create_printer_hnd(handle);
-
-       open_printer_hnd(handle);
-       
-       if (!set_printer_hnd_printertype(handle, name)) {
-               close_printer_handle(handle);
+       if (!open_printer_hnd(handle, name))
                return ERROR_INVALID_PRINTER_NAME;
-       }
        
-       if (!set_printer_hnd_printername(handle, name)) {
-               close_printer_handle(handle);
-               return ERROR_INVALID_PRINTER_NAME;
-       }
-
 /*
        if (printer_default->datatype_ptr != NULL)
        {
@@ -547,6 +680,17 @@ uint32 _spoolss_open_printer_ex( const UNISTR2 *printername,
                return ERROR_ACCESS_DENIED;
        }
                
+       /* Disallow MS AddPrinterWizard if access rights are insufficient OR
+          if parameter disables it. The client tries an OpenPrinterEx with
+          SERVER_ALL_ACCESS(0xf0003), which we force to fail. It then tries
+          OpenPrinterEx with SERVER_READ(0x20002) which we allow. This lets
+          it see any printers there, but does not show the MSAPW */
+       if (handle_is_printserver(handle) &&
+               printer_default->access_required != (SERVER_READ) &&
+               !lp_ms_add_printer_wizard() ) {
+               return ERROR_ACCESS_DENIED;
+       }
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
@@ -557,7 +701,7 @@ static BOOL convert_printer_info(const SPOOL_PRINTER_INFO_LEVEL *uni,
 {
        switch (level) {
                case 2: 
-                       uni_2_asc_printer_info_2(uni->info_2, &(printer->info_2));
+                       uni_2_asc_printer_info_2(uni->info_2, &printer->info_2);
                        break;
                default:
                        break;
@@ -572,11 +716,11 @@ static BOOL convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *u
        switch (level) {
                case 3: 
                        printer->info_3=NULL;
-                       uni_2_asc_printer_driver_3(uni->info_3, &(printer->info_3));
+                       uni_2_asc_printer_driver_3(uni->info_3, &printer->info_3);
                        break;
                case 6: 
                        printer->info_6=NULL;
-                       uni_2_asc_printer_driver_6(uni->info_6, &(printer->info_6));
+                       uni_2_asc_printer_driver_6(uni->info_6, &printer->info_6);
                        break;
                default:
                        break;
@@ -585,53 +729,51 @@ static BOOL convert_printer_driver_info(const SPOOL_PRINTER_DRIVER_INFO_LEVEL *u
        return True;
 }
 
-static BOOL convert_devicemode(DEVICEMODE devmode, NT_DEVICEMODE *nt_devmode)
-{
-       unistr_to_dos(nt_devmode->devicename, (char *)devmode.devicename.buffer, 31);
-       unistr_to_dos(nt_devmode->formname, (char *)devmode.formname.buffer, 31);
-
-       nt_devmode->specversion=devmode.specversion;
-       nt_devmode->driverversion=devmode.driverversion;
-       nt_devmode->size=devmode.size;
-       nt_devmode->driverextra=devmode.driverextra;
-       nt_devmode->fields=devmode.fields;
-       nt_devmode->orientation=devmode.orientation;
-       nt_devmode->papersize=devmode.papersize;
-       nt_devmode->paperlength=devmode.paperlength;
-       nt_devmode->paperwidth=devmode.paperwidth;
-       nt_devmode->scale=devmode.scale;
-       nt_devmode->copies=devmode.copies;
-       nt_devmode->defaultsource=devmode.defaultsource;
-       nt_devmode->printquality=devmode.printquality;
-       nt_devmode->color=devmode.color;
-       nt_devmode->duplex=devmode.duplex;
-       nt_devmode->yresolution=devmode.yresolution;
-       nt_devmode->ttoption=devmode.ttoption;
-       nt_devmode->collate=devmode.collate;
-
-       nt_devmode->logpixels=devmode.logpixels;
-       nt_devmode->bitsperpel=devmode.bitsperpel;
-       nt_devmode->pelswidth=devmode.pelswidth;
-       nt_devmode->pelsheight=devmode.pelsheight;
-       nt_devmode->displayflags=devmode.displayflags;
-       nt_devmode->displayfrequency=devmode.displayfrequency;
-       nt_devmode->icmmethod=devmode.icmmethod;
-       nt_devmode->icmintent=devmode.icmintent;
-       nt_devmode->mediatype=devmode.mediatype;
-       nt_devmode->dithertype=devmode.dithertype;
-       nt_devmode->reserved1=devmode.reserved1;
-       nt_devmode->reserved2=devmode.reserved2;
-       nt_devmode->panningwidth=devmode.panningwidth;
-       nt_devmode->panningheight=devmode.panningheight;
-
-       if (nt_devmode->driverextra != 0) 
-       {
+static BOOL convert_devicemode(const DEVICEMODE *devmode, NT_DEVICEMODE *nt_devmode)
+{
+       unistr_to_dos(nt_devmode->devicename, (const char *)devmode->devicename.buffer, 31);
+       unistr_to_dos(nt_devmode->formname, (const char *)devmode->formname.buffer, 31);
+
+       nt_devmode->specversion=devmode->specversion;
+       nt_devmode->driverversion=devmode->driverversion;
+       nt_devmode->size=devmode->size;
+       nt_devmode->driverextra=devmode->driverextra;
+       nt_devmode->fields=devmode->fields;
+       nt_devmode->orientation=devmode->orientation;
+       nt_devmode->papersize=devmode->papersize;
+       nt_devmode->paperlength=devmode->paperlength;
+       nt_devmode->paperwidth=devmode->paperwidth;
+       nt_devmode->scale=devmode->scale;
+       nt_devmode->copies=devmode->copies;
+       nt_devmode->defaultsource=devmode->defaultsource;
+       nt_devmode->printquality=devmode->printquality;
+       nt_devmode->color=devmode->color;
+       nt_devmode->duplex=devmode->duplex;
+       nt_devmode->yresolution=devmode->yresolution;
+       nt_devmode->ttoption=devmode->ttoption;
+       nt_devmode->collate=devmode->collate;
+
+       nt_devmode->logpixels=devmode->logpixels;
+       nt_devmode->bitsperpel=devmode->bitsperpel;
+       nt_devmode->pelswidth=devmode->pelswidth;
+       nt_devmode->pelsheight=devmode->pelsheight;
+       nt_devmode->displayflags=devmode->displayflags;
+       nt_devmode->displayfrequency=devmode->displayfrequency;
+       nt_devmode->icmmethod=devmode->icmmethod;
+       nt_devmode->icmintent=devmode->icmintent;
+       nt_devmode->mediatype=devmode->mediatype;
+       nt_devmode->dithertype=devmode->dithertype;
+       nt_devmode->reserved1=devmode->reserved1;
+       nt_devmode->reserved2=devmode->reserved2;
+       nt_devmode->panningwidth=devmode->panningwidth;
+       nt_devmode->panningheight=devmode->panningheight;
+
+       if (nt_devmode->driverextra != 0) {
                /* if we had a previous private delete it and make a new one */
-               if (nt_devmode->private != NULL)
-                       free(nt_devmode->private);
+               safe_free(nt_devmode->private);
                if((nt_devmode->private=(uint8 *)malloc(nt_devmode->driverextra * sizeof(uint8))) == NULL)
                        return False;
-               memcpy(nt_devmode->private, devmode.private, nt_devmode->driverextra);
+               memcpy(nt_devmode->private, devmode->private, nt_devmode->driverextra);
        }
 
        return True;
@@ -642,6 +784,11 @@ static BOOL convert_devicemode(DEVICEMODE devmode, NT_DEVICEMODE *nt_devmode)
  ********************************************************************/
 uint32 _spoolss_closeprinter(POLICY_HND *handle)
 {
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+
+       if (Printer && Printer->document_started)
+               _spoolss_enddocprinter(handle);          /* print job was not closed */
+
        if (!close_printer_handle(handle))
                return ERROR_INVALID_HANDLE;    
                
@@ -653,8 +800,15 @@ uint32 _spoolss_closeprinter(POLICY_HND *handle)
  ********************************************************************/
 uint32 _spoolss_deleteprinter(POLICY_HND *handle)
 {
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
+
+       if (Printer && Printer->document_started)
+               _spoolss_enddocprinter(handle);          /* print job was not closed */
+
        if (!delete_printer_handle(handle))
                return ERROR_INVALID_HANDLE;    
+
+       srv_spoolss_sendnotify(handle);
                
        return NT_STATUS_NO_PROBLEMO;
 }
@@ -668,8 +822,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
        
        DEBUG(8,("getprinterdata_printer_server:%s\n", value));
                
-       if (!strcmp(value, "BeepEnabled"))
-       {
+       if (!strcmp(value, "BeepEnabled")) {
                *type = 0x4;
                if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
                        return False;
@@ -678,8 +831,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                return True;
        }
 
-       if (!strcmp(value, "EventLog"))
-       {
+       if (!strcmp(value, "EventLog")) {
                *type = 0x4;
                if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
                        return False;
@@ -688,8 +840,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                return True;
        }
 
-       if (!strcmp(value, "NetPopup"))
-       {
+       if (!strcmp(value, "NetPopup")) {
                *type = 0x4;
                if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
                        return False;
@@ -698,8 +849,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                return True;
        }
 
-       if (!strcmp(value, "MajorVersion"))
-       {
+       if (!strcmp(value, "MajorVersion")) {
                *type = 0x4;
                if((*data = (uint8 *)malloc( 4*sizeof(uint8) )) == NULL)
                        return False;
@@ -708,8 +858,7 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                return True;
        }
 
-       if (!strcmp(value, "DefaultSpoolDirectory"))
-       {
+       if (!strcmp(value, "DefaultSpoolDirectory")) {
                pstring string="You are using a Samba server";
                *type = 0x1;                    
                *needed = 2*(strlen(string)+1);         
@@ -718,24 +867,21 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
                memset(*data, 0, (*needed > in_size) ? *needed:in_size);
                
                /* it's done by hand ready to go on the wire */
-               for (i=0; i<strlen(string); i++)
-               {
+               for (i=0; i<strlen(string); i++) {
                        (*data)[2*i]=string[i];
                        (*data)[2*i+1]='\0';
                }                       
                return True;
        }
 
-       if (!strcmp(value, "Architecture"))
-       {                       
+       if (!strcmp(value, "Architecture")) {                   
                pstring string="Windows NT x86";
                *type = 0x1;                    
                *needed = 2*(strlen(string)+1); 
                if((*data  = (uint8 *)malloc( ((*needed > in_size) ? *needed:in_size) *sizeof(uint8))) == NULL)
                        return False;
                memset(*data, 0, (*needed > in_size) ? *needed:in_size);
-               for (i=0; i<strlen(string); i++)
-               {
+               for (i=0; i<strlen(string); i++) {
                        (*data)[2*i]=string[i];
                        (*data)[2*i+1]='\0';
                }                       
@@ -748,11 +894,11 @@ static BOOL getprinterdata_printer_server(fstring value, uint32 *type, uint8 **d
 /********************************************************************
  GetPrinterData on a printer Handle.
 ********************************************************************/
-static BOOL getprinterdata_printer(const POLICY_HND *handle,
+static BOOL getprinterdata_printer(POLICY_HND *handle,
                                fstring value, uint32 *type, 
                                uint8 **data, uint32 *needed, uint32 in_size )
 {
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        int snum=0;
        uint8 *idata=NULL;
        uint32 len;
@@ -760,8 +906,10 @@ static BOOL getprinterdata_printer(const POLICY_HND *handle,
        
        DEBUG(5,("getprinterdata_printer\n"));
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("getprinterdata_printer: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return False;
+       }
 
        if(!get_printer_snum(handle, &snum))
                return False;
@@ -769,27 +917,31 @@ static BOOL getprinterdata_printer(const POLICY_HND *handle,
        if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
                return False;
 
-       if (!get_specific_param(printer, 2, value, &idata, type, &len)) {
-               free_a_printer(printer, 2);
+       if (!get_specific_param(*printer, 2, value, &idata, type, &len)) {
+               free_a_printer(&printer, 2);
                return False;
        }
 
+       free_a_printer(&printer, 2);
+
        DEBUG(5,("getprinterdata_printer:allocating %d\n", in_size));
 
-       if((*data  = (uint8 *)malloc( in_size *sizeof(uint8) )) == NULL) {
-               free_a_printer(printer, 2);
-               return False;
-       }
+       if (in_size) {
+               if((*data  = (uint8 *)malloc( in_size *sizeof(uint8) )) == NULL) {
+                       return False;
+               }
 
-       memset(*data, 0, in_size *sizeof(uint8));
-       /* copy the min(in_size, len) */
-       memcpy(*data, idata, (len>in_size)?in_size:len *sizeof(uint8));
+               memset(*data, 0, in_size *sizeof(uint8));
+               /* copy the min(in_size, len) */
+               memcpy(*data, idata, (len>in_size)?in_size:len *sizeof(uint8));
+       } else {
+               *data = NULL;
+       }
 
        *needed = len;
        
        DEBUG(5,("getprinterdata_printer:copy done\n"));
                        
-       free_a_printer(printer, 2);
        safe_free(idata);
        
        return True;
@@ -798,7 +950,7 @@ static BOOL getprinterdata_printer(const POLICY_HND *handle,
 /********************************************************************
  * spoolss_getprinterdata
  ********************************************************************/
-uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
+uint32 _spoolss_getprinterdata(POLICY_HND *handle, UNISTR2 *valuename,
                                uint32 in_size,
                                uint32 *type,
                                uint32 *out_size,
@@ -827,6 +979,7 @@ uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
        if (!OPEN_HANDLE(Printer)) {
                if((*data=(uint8 *)malloc(4*sizeof(uint8))) == NULL)
                        return ERROR_NOT_ENOUGH_MEMORY;
+               DEBUG(0,("_spoolss_getprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        
@@ -840,18 +993,49 @@ uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
        if (found==False) {
                DEBUG(5, ("value not found, allocating %d\n", *out_size));
                /* reply this param doesn't exist */
-               if((*data=(uint8 *)malloc(*out_size*sizeof(uint8))) == NULL)
-                       return ERROR_NOT_ENOUGH_MEMORY;
-               memset(*data, 0x0, *out_size*sizeof(uint8));
+               if (*out_size) {
+                       if((*data=(uint8 *)malloc(*out_size*sizeof(uint8))) == NULL)
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       memset(*data, '\0', *out_size*sizeof(uint8));
+               } else {
+                       *data = NULL;
+               }
+
                return ERROR_INVALID_PARAMETER;
        }
        
        if (*needed > *out_size)
-               return ERROR_INSUFFICIENT_BUFFER;
+               return ERROR_MORE_DATA;
        else
                return NT_STATUS_NO_PROBLEMO;
 }
 
+/***************************************************************************
+ connect to the client
+****************************************************************************/
+static BOOL srv_spoolss_replyopenprinter(char *printer, uint32 localprinter, uint32 type, POLICY_HND *handle)
+{
+       uint32 status;
+
+       /*
+        * If it's the first connection, contact the client 
+        * and connect to the IPC$ share anonumously
+        */
+       if (smb_connections==0) {
+               if(!spoolss_connect_to_client(&cli, printer+2)) /* the +2 is to strip the leading 2 backslashs */
+                       return False;
+               message_register(MSG_PRINTER_NOTIFY, srv_spoolss_receive_message);
+
+       }
+
+       smb_connections++;
+
+       if(!cli_spoolss_reply_open_printer(&cli, printer, localprinter, type, &status, handle))
+               return False;
+
+       return True;
+}
+
 /********************************************************************
  * _spoolss_rffpcnex
  * ReplyFindFirstPrinterChangeNotifyEx
@@ -863,7 +1047,7 @@ uint32 _spoolss_getprinterdata(const POLICY_HND *handle, UNISTR2 *valuename,
  * in fact ReplyOpenPrinter is the changenotify equivalent on the spoolss pipe
  * called from api_spoolss_rffpcnex 
  ********************************************************************/
-uint32 _spoolss_rffpcnex(const POLICY_HND *handle, uint32 flags, uint32 options,
+uint32 _spoolss_rffpcnex(POLICY_HND *handle, uint32 flags, uint32 options,
                         const UNISTR2 *localmachine, uint32 printerlocal,
                         SPOOL_NOTIFY_OPTION *option)
 {
@@ -871,8 +1055,10 @@ uint32 _spoolss_rffpcnex(const POLICY_HND *handle, uint32 flags, uint32 options,
 
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_rffpcnex: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        Printer->notify.flags=flags;
        Printer->notify.options=options;
@@ -880,36 +1066,42 @@ uint32 _spoolss_rffpcnex(const POLICY_HND *handle, uint32 flags, uint32 options,
        Printer->notify.option=option;
        unistr2_to_ascii(Printer->notify.localmachine, localmachine, sizeof(Printer->notify.localmachine)-1);
 
+       /* connect to the client machine and send a ReplyOpenPrinter */
+       if(srv_spoolss_replyopenprinter(Printer->notify.localmachine, 
+                                       Printer->notify.printerlocal, 1, 
+                                       &Printer->notify.client_hnd))
+               Printer->notify.client_connected=True;
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
 /*******************************************************************
  * fill a notify_info_data with the servername
  ********************************************************************/
-static void spoolss_notify_server_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_server_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue,
+                                                                               NT_PRINTER_INFO_LEVEL *printer)
 {
        pstring temp_name;
 
        snprintf(temp_name, sizeof(temp_name)-1, "\\\\%s", global_myname);
 
-       data->notify_data.data.length=strlen(temp_name);
-       ascii_to_unistr((char *)data->notify_data.data.string, temp_name, sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length= (uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                                       temp_name, sizeof(data->notify_data.data.string), True) - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
  * fill a notify_info_data with the servicename
  * jfmxxxx: it's incorrect should be long_printername
  ********************************************************************/
-static void spoolss_notify_printer_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
+static void spoolss_notify_printer_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue,
+                                                                               NT_PRINTER_INFO_LEVEL *printer)
 {
 /*
        data->notify_data.data.length=strlen(lp_servicename(snum));
-       ascii_to_unistr(data->notify_data.data.string, lp_servicename(snum), sizeof(data->notify_data.data.string)-1);
+       dos_PutUniCode(data->notify_data.data.string, lp_servicename(snum), sizeof(data->notify_data.data.string), True);
 */
-       data->notify_data.data.length=strlen(printer->info_2->printername);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->printername, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                               printer->info_2->printername, sizeof(data->notify_data.data.string), True) - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -917,10 +1109,8 @@ static void spoolss_notify_printer_name(int snum, SPOOL_NOTIFY_INFO_DATA *data,
  ********************************************************************/
 static void spoolss_notify_share_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(lp_servicename(snum));
-       ascii_to_unistr((char *)data->notify_data.data.string,
-                       lp_servicename(snum), 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       lp_servicename(snum), sizeof(data->notify_data.data.string),True) - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -930,10 +1120,8 @@ static void spoolss_notify_port_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, pri
 {
        /* even if it's strange, that's consistant in all the code */
 
-       data->notify_data.data.length=strlen(lp_servicename(snum));
-       ascii_to_unistr((char *)data->notify_data.data.string,
-                       lp_servicename(snum), 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+               lp_servicename(snum), sizeof(data->notify_data.data.string), True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -943,10 +1131,8 @@ static void spoolss_notify_port_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, pri
  ********************************************************************/
 static void spoolss_notify_driver_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(printer->info_2->drivername);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->drivername, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->drivername, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -954,10 +1140,12 @@ static void spoolss_notify_driver_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, p
  ********************************************************************/
 static void spoolss_notify_comment(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(lp_comment(snum));
-       ascii_to_unistr((char *)data->notify_data.data.string,
-                       lp_comment(snum),
-                       sizeof(data->notify_data.data.string)-1);
+       if (*printer->info_2->comment == '\0')
+               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       lp_comment(snum), sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
+       else
+               data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->comment, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -967,10 +1155,8 @@ static void spoolss_notify_comment(int snum, SPOOL_NOTIFY_INFO_DATA *data, print
  ********************************************************************/
 static void spoolss_notify_location(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(printer->info_2->location);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->location, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->location, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -988,10 +1174,8 @@ static void spoolss_notify_devmode(int snum, SPOOL_NOTIFY_INFO_DATA *data, print
  ********************************************************************/
 static void spoolss_notify_sepfile(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(printer->info_2->sepfile);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->sepfile, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->sepfile, sizeof(data->notify_data.data.string)-1,True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1000,10 +1184,8 @@ static void spoolss_notify_sepfile(int snum, SPOOL_NOTIFY_INFO_DATA *data, print
  ********************************************************************/
 static void spoolss_notify_print_processor(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(printer->info_2->printprocessor);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->printprocessor, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->printprocessor, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1012,10 +1194,8 @@ static void spoolss_notify_print_processor(int snum, SPOOL_NOTIFY_INFO_DATA *dat
  ********************************************************************/
 static void spoolss_notify_parameters(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(printer->info_2->parameters);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->parameters, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->parameters, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1024,10 +1204,8 @@ static void spoolss_notify_parameters(int snum, SPOOL_NOTIFY_INFO_DATA *data, pr
  ********************************************************************/
 static void spoolss_notify_datatype(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(printer->info_2->datatype);
-       ascii_to_unistr((char *)data->notify_data.data.string, 
-                       printer->info_2->datatype, 
-                       sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       printer->info_2->datatype, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1048,7 +1226,7 @@ static void spoolss_notify_security_desc(int snum, SPOOL_NOTIFY_INFO_DATA *data,
 static void spoolss_notify_attributes(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
        data->notify_data.value[0] =   PRINTER_ATTRIBUTE_SHARED   \
-                                    | PRINTER_ATTRIBUTE_NETWORK  \
+                                    | PRINTER_ATTRIBUTE_LOCAL  \
                                     | PRINTER_ATTRIBUTE_RAW_ONLY ;
 }
 
@@ -1127,8 +1305,8 @@ static void spoolss_notify_average_ppm(int snum, SPOOL_NOTIFY_INFO_DATA *data, p
  ********************************************************************/
 static void spoolss_notify_username(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(queue->user);
-       ascii_to_unistr((char *)data->notify_data.data.string, queue->user, sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       queue->user, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1144,8 +1322,8 @@ static void spoolss_notify_job_status(int snum, SPOOL_NOTIFY_INFO_DATA *data, pr
  ********************************************************************/
 static void spoolss_notify_job_name(int snum, SPOOL_NOTIFY_INFO_DATA *data, print_queue_struct *queue, NT_PRINTER_INFO_LEVEL *printer)
 {
-       data->notify_data.data.length=strlen(queue->file);
-       ascii_to_unistr((char *)data->notify_data.data.string, queue->file, sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                       queue->file, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1168,8 +1346,8 @@ static void spoolss_notify_job_status_string(int snum, SPOOL_NOTIFY_INFO_DATA *d
                p = "PRINTING";
                break;
        }
-       data->notify_data.data.length=strlen(p);
-       ascii_to_unistr((char *)data->notify_data.data.string, p, sizeof(data->notify_data.data.string)-1);
+       data->notify_data.data.length=(uint32)((dos_PutUniCode((char *)data->notify_data.data.string,
+                               p, sizeof(data->notify_data.data.string)-1, True)  - sizeof(uint16))/sizeof(uint16));
 }
 
 /*******************************************************************
@@ -1198,6 +1376,17 @@ static void spoolss_notify_job_position(int snum, SPOOL_NOTIFY_INFO_DATA *data,
 
 #define END 65535
 
+struct s_notify_info_data_table
+{
+       uint16 type;
+       uint16 field;
+       char *name;
+       uint32 size;
+       void (*fn) (int snum, SPOOL_NOTIFY_INFO_DATA *data,
+                   print_queue_struct *queue,
+                   NT_PRINTER_INFO_LEVEL *printer);
+};
+
 struct s_notify_info_data_table notify_info_data_table[] =
 {
 { PRINTER_NOTIFY_TYPE, PRINTER_NOTIFY_SERVER_NAME,         "PRINTER_NOTIFY_SERVER_NAME",         POINTER,   spoolss_notify_server_name },
@@ -1266,7 +1455,6 @@ static uint32 size_of_notify_info_data(uint16 type, uint16 field)
                     (notify_info_data_table[i].field == field ) )
                {
                        return (notify_info_data_table[i].size);
-                       continue;
                }
                i++;
        }
@@ -1293,7 +1481,6 @@ static BOOL type_of_notify_info_data(uint16 type, uint16 field)
                        {
                                return (True);
                        }
-                       continue;
                }
                i++;
        }
@@ -1346,7 +1533,7 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
        uint16 field;
 
        SPOOL_NOTIFY_INFO_DATA *current_data;
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        print_queue_struct *queue=NULL;
        
        DEBUG(4,("construct_notify_printer_info\n"));
@@ -1358,12 +1545,9 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
                option_type->count, lp_servicename(snum)));
        
        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
-       {
                return False;
-       }
 
-       for(field_num=0; field_num<option_type->count; field_num++)
-       {
+       for(field_num=0; field_num<option_type->count; field_num++) {
                field = option_type->fields[field_num];
                DEBUGADD(4,("notify [%d]: type [%x], field [%x]\n", field_num, type, field));
 
@@ -1371,18 +1555,17 @@ static BOOL construct_notify_printer_info(SPOOL_NOTIFY_INFO *info, int snum, SPO
                        continue;
                
                if((info->data=Realloc(info->data, (info->count+1)*sizeof(SPOOL_NOTIFY_INFO_DATA))) == NULL) {
-                       free_a_printer(printer, 2);
                        return False;
                }
-               current_data=&(info->data[info->count]);
+               current_data=&info->data[info->count];
 
                construct_info_data(current_data, type, field, id);             
-               notify_info_data_table[j].fn(snum, current_data, queue, &printer);
+               notify_info_data_table[j].fn(snum, current_data, queue, printer);
 
                info->count++;
        }
 
-       free_a_printer(printer, 2);
+       free_a_printer(&printer, 2);
        return True;
 }
 
@@ -1398,7 +1581,7 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
        uint16 field;
 
        SPOOL_NOTIFY_INFO_DATA *current_data;
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        
        DEBUG(4,("construct_notify_jobs_info\n"));
        
@@ -1409,31 +1592,26 @@ static BOOL construct_notify_jobs_info(print_queue_struct *queue, SPOOL_NOTIFY_I
                option_type->count));
 
        if (get_a_printer(&printer, 2, lp_servicename(snum))!=0)
-       {       
                return False;
-       }
        
-       for(field_num=0; field_num<option_type->count; field_num++)
-       {
+       for(field_num=0; field_num<option_type->count; field_num++) {
                field = option_type->fields[field_num];
 
                if (!search_notify(type, field, &j) )
                        continue;
 
                if((info->data=Realloc(info->data, (info->count+1)*sizeof(SPOOL_NOTIFY_INFO_DATA))) == NULL) {
-                       free_a_printer(printer, 2);
                        return False;
                }
 
                current_data=&(info->data[info->count]);
 
                construct_info_data(current_data, type, field, id);
-               notify_info_data_table[j].fn(snum, current_data, queue, &printer);
+               notify_info_data_table[j].fn(snum, current_data, queue, printer);
                info->count++;
        }
-       
-       free_a_printer(printer, 2);
-       
+
+       free_a_printer(&printer, 2);    
        return True;
 }
 
@@ -1486,8 +1664,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
        info->data=NULL;
        info->count=0;
 
-       for (i=0; i<option->count; i++)
-       {
+       for (i=0; i<option->count; i++) {
                option_type=&(option->ctr.type[i]);
                
                if (option_type->type!=PRINTER_NOTIFY_TYPE)
@@ -1507,8 +1684,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
        DEBUGADD(1,("info->version:[%d], info->flags:[%d], info->count:[%d]\n", info->version, info->flags, info->count));
        DEBUGADD(1,("num\ttype\tfield\tres\tid\tsize\tenc_type\n"));
        
-       for (i=0; i<info->count; i++)
-       {
+       for (i=0; i<info->count; i++) {
                DEBUGADD(1,("[%d]\t[%d]\t[%d]\t[%d]\t[%d]\t[%d]\t[%d]\n",
                i, info->data[i].type, info->data[i].field, info->data[i].reserved,
                info->data[i].id, info->data[i].size, info->data[i].enc_type));
@@ -1523,7 +1699,7 @@ static uint32 printserver_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *
  * fill a notify_info struct with info asked
  * 
  ********************************************************************/
-static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
+static uint32 printer_notify_info(POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info)
 {
        int snum;
        Printer_entry *Printer=find_printer_index_by_hnd(hnd);
@@ -1545,9 +1721,8 @@ static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info
 
        get_printer_snum(hnd, &snum);
 
-       for (i=0; i<option->count; i++)
-       {
-               option_type=&(option->ctr.type[i]);
+       for (i=0; i<option->count; i++) {
+               option_type=&option->ctr.type[i];
                
                switch ( option_type->type ) {
                case PRINTER_NOTIFY_TYPE:
@@ -1559,7 +1734,7 @@ static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info
                        memset(&status, 0, sizeof(status));     
                        count = print_queue_status(snum, &queue, &status);
                        for (j=0; j<count; j++)
-                               construct_notify_jobs_info(&(queue[j]), info, snum, option_type, queue[j].job);
+                               construct_notify_jobs_info(&queue[j], info, snum, option_type, queue[j].job);
                        safe_free(queue);
                        break;
                }
@@ -1573,8 +1748,7 @@ static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info
        DEBUGADD(1,("info->version:[%d], info->flags:[%d], info->count:[%d]\n", info->version, info->flags, info->count));
        DEBUGADD(1,("num\ttype\tfield\tres\tid\tsize\tenc_type\n"));
        
-       for (i=0; i<info->count; i++)
-       {
+       for (i=0; i<info->count; i++) {
                DEBUGADD(1,("[%d]\t[%d]\t[%d]\t[%d]\t[%d]\t[%d]\t[%d]\n",
                i, info->data[i].type, info->data[i].field, info->data[i].reserved,
                info->data[i].id, info->data[i].size, info->data[i].enc_type));
@@ -1586,13 +1760,15 @@ static uint32 printer_notify_info(const POLICY_HND *hnd, SPOOL_NOTIFY_INFO *info
 /********************************************************************
  * spoolss_rfnpcnex
  ********************************************************************/
-uint32 _spoolss_rfnpcnex( const POLICY_HND *handle, uint32 change,
+uint32 _spoolss_rfnpcnex( POLICY_HND *handle, uint32 change,
                          SPOOL_NOTIFY_OPTION *option, SPOOL_NOTIFY_INFO *info)
 {
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_rfnpcnex: Invalid handle (%s).\n",OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        DEBUG(4,("Printer type %x\n",Printer->printer_type));
 
@@ -1614,10 +1790,8 @@ uint32 _spoolss_rfnpcnex( const POLICY_HND *handle, uint32 change,
        switch (Printer->printer_type) {
                case PRINTER_HANDLE_IS_PRINTSERVER:
                        return printserver_notify_info(handle, info);
-                       break;
                case PRINTER_HANDLE_IS_PRINTER:
                        return printer_notify_info(handle, info);
-                       break;
        }
 
        return ERROR_INVALID_HANDLE;
@@ -1631,11 +1805,11 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
 {
        pstring chaine;
        int count;
-       NT_PRINTER_INFO_LEVEL ntprinter;
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        counter_printer_0 *session_counter;
        uint32 global_counter;
        struct tm *t;
-       time_t setup_time;
+       time_t setup_time = time(NULL);
 
        print_queue_struct *queue=NULL;
        print_status_struct status;
@@ -1657,8 +1831,10 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
 
        /* it's the first time, add it to the list */
        if (session_counter==NULL) {
-               if((session_counter=(counter_printer_0 *)malloc(sizeof(counter_printer_0))) == NULL)
+               if((session_counter=(counter_printer_0 *)malloc(sizeof(counter_printer_0))) == NULL) {
+                       free_a_printer(&ntprinter, 2);
                        return False;
+               }
                ZERO_STRUCTP(session_counter);
                session_counter->snum=snum;
                session_counter->counter=0;
@@ -1675,19 +1851,19 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
        global_counter=session_counter->counter;
        
        /* the description and the name are of the form \\server\share */
-       slprintf(chaine,sizeof(chaine)-1,"\\\\%s\\%s",servername, ntprinter.info_2->printername);
-                                                           
-       init_unistr(&(printer->printername), chaine);
+       slprintf(chaine,sizeof(chaine)-1,"\\\\%s\\%s",servername, ntprinter->info_2->printername);
+
+       init_unistr(&printer->printername, chaine);
        
        slprintf(chaine,sizeof(chaine)-1,"\\\\%s", servername);
-       init_unistr(&(printer->servername), chaine);
+       init_unistr(&printer->servername, chaine);
        
        printer->cjobs = count;
        printer->total_jobs = 0;
        printer->total_bytes = 0;
 
        t=gmtime(&setup_time);
-       ntprinter.info_2->setuptime = (uint32)setup_time; /* FIXME !! */
+       ntprinter->info_2->setuptime = (uint32)setup_time; /* FIXME !! */
 
        printer->year = t->tm_year+1900;
        printer->month = t->tm_mon+1;
@@ -1712,11 +1888,11 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
        printer->unknown14 = 0x1;
        printer->unknown15 = 0x024a;            /* 586 Pentium ? */
        printer->unknown16 = 0x0;
-       printer->change_id = ntprinter.info_2->changeid; /* ChangeID in milliseconds*/
+       printer->change_id = ntprinter->info_2->changeid; /* ChangeID in milliseconds*/
        printer->unknown18 = 0x0;
        printer->status = nt_printq_status(status.status);
        printer->unknown20 = 0x0;
-       printer->c_setprinter = ntprinter.info_2->c_setprinter; /* how many times setprinter has been called */
+       printer->c_setprinter = ntprinter->info_2->c_setprinter; /* how many times setprinter has been called */
        printer->unknown22 = 0x0;
        printer->unknown23 = 0x6;               /* 6  ???*/
        printer->unknown24 = 0;                 /* unknown 24 to 26 are always 0 */
@@ -1727,8 +1903,7 @@ static BOOL construct_printer_info_0(PRINTER_INFO_0 *printer, int snum, fstring
        printer->unknown29 = 0;
        
        safe_free(queue);
-
-       free_a_printer(ntprinter, 2);
+       free_a_printer(&ntprinter,2);
        return (True);  
 }
 
@@ -1740,53 +1915,88 @@ static BOOL construct_printer_info_1(fstring server, uint32 flags, PRINTER_INFO_
 {
        pstring chaine;
        pstring chaine2;
-       NT_PRINTER_INFO_LEVEL ntprinter;
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
        if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) != 0)
                return False;
 
        printer->flags=flags;
 
-       snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter.info_2->printername,
-               ntprinter.info_2->drivername, lp_comment(snum));
+       if (*ntprinter->info_2->comment == '\0') {
+               init_unistr(&printer->comment, lp_comment(snum));
+               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter->info_2->printername,
+                       ntprinter->info_2->drivername, lp_comment(snum));
+       }
+       else {
+               init_unistr(&printer->comment, ntprinter->info_2->comment); /* saved comment. */
+               snprintf(chaine,sizeof(chaine)-1,"%s%s,%s,%s",server, ntprinter->info_2->printername,
+                       ntprinter->info_2->drivername, ntprinter->info_2->comment);
+       }
                
-       snprintf(chaine2,sizeof(chaine)-1,"%s%s", server, ntprinter.info_2->printername);
+       snprintf(chaine2,sizeof(chaine)-1,"%s%s", server, ntprinter->info_2->printername);
 
        init_unistr(&printer->description, chaine);
        init_unistr(&printer->name, chaine2);   
-       init_unistr(&printer->comment, lp_comment(snum));
        
-       free_a_printer(ntprinter, 2);
+       free_a_printer(&ntprinter,2);
 
        return True;
 }
 
 /****************************************************************************
+ Free a DEVMODE struct.
+****************************************************************************/
+
+static void free_dev_mode(DEVICEMODE *dev)
+{
+       if (dev == NULL)
+               return;
+
+       if (dev->private)
+               safe_free(dev->private);
+
+       safe_free(dev); 
+}
+
+/****************************************************************************
+ Create a DEVMODE struct. Returns malloced memory.
 ****************************************************************************/
-static BOOL construct_dev_mode(DEVICEMODE *devmode, int snum, char *servername)
+
+static DEVICEMODE *construct_dev_mode(int snum, char *servername)
 {
        char adevice[32];
        char aform[32];
-       NT_PRINTER_INFO_LEVEL printer;  
-       NT_DEVICEMODE *ntdevmode;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_DEVICEMODE *ntdevmode = NULL;
+       DEVICEMODE *devmode = NULL;
 
        DEBUG(7,("construct_dev_mode\n"));
        
-       memset(&(devmode->devicename), 0, 2*sizeof(adevice));
-       memset(&(devmode->formname), 0, 2*sizeof(aform));
-
        DEBUGADD(8,("getting printer characteristics\n"));
 
-       get_a_printer(&printer, 2, lp_servicename(snum));
-       ntdevmode=(printer.info_2)->devmode;
+       if ((devmode = (DEVICEMODE *)malloc(sizeof(DEVICEMODE))) == NULL) {
+               DEBUG(0,("construct_dev_mode: malloc fail.\n"));
+               return NULL;
+       }
+
+       ZERO_STRUCTP(devmode);  
+
+       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               goto fail;
+
+       if (printer->info_2->devmode)
+               ntdevmode = dup_nt_devicemode(printer->info_2->devmode);
+
+       if (ntdevmode == NULL)
+               goto fail;
 
        DEBUGADD(8,("loading DEVICEMODE\n"));
-       snprintf(adevice, sizeof(adevice), "\\\\%s\\%s", global_myname, 
-                                                        printer.info_2->printername);
-       init_unistr(&(devmode->devicename), adevice);
+
+       snprintf(adevice, sizeof(adevice), "\\\\%s\\%s", global_myname, printer->info_2->printername);
+       init_unistr(&devmode->devicename, adevice);
 
        snprintf(aform, sizeof(aform), ntdevmode->formname);
-       init_unistr(&(devmode->formname), aform);
+       init_unistr(&devmode->formname, aform);
 
        devmode->specversion      = ntdevmode->specversion;
        devmode->driverversion    = ntdevmode->driverversion;
@@ -1812,32 +2022,39 @@ static BOOL construct_dev_mode(DEVICEMODE *devmode, int snum, char *servername)
        devmode->mediatype        = ntdevmode->mediatype;
        devmode->dithertype       = ntdevmode->dithertype;
 
-       if (ntdevmode->private != NULL)
-       {
-               if((devmode->private=(uint8 *)malloc(devmode->driverextra*sizeof(uint8))) == NULL) {
-                       free_a_printer(printer, 2);
-                       return False;
-               }
-               memcpy(devmode->private, ntdevmode->private, devmode->driverextra);
+       if (ntdevmode->private != NULL) {
+               if ((devmode->private=(uint8 *)memdup(ntdevmode->private, ntdevmode->driverextra)) == NULL)
+                       goto fail;
        }
 
-       free_a_printer(printer, 2);
+       free_nt_devicemode(&ntdevmode);
+       free_a_printer(&printer,2);
 
-       return True;
+       return devmode;
+
+  fail:
+
+       if (ntdevmode)
+               free_nt_devicemode(&ntdevmode);
+       if (printer)
+               free_a_printer(&printer,2);
+       free_dev_mode(devmode);
+
+       return NULL;
 }
 
 /********************************************************************
  * construct_printer_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
+
 static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer, int snum)
 {
        pstring chaine;
        pstring chaine2;
        pstring sl;
        int count;
-       DEVICEMODE *devmode;
-       NT_PRINTER_INFO_LEVEL ntprinter;
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
 
        print_queue_struct *queue=NULL;
        print_status_struct status;
@@ -1856,62 +2073,53 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
        else
                fstrcpy(sl, '\0');
 
-       snprintf(chaine2, sizeof(chaine)-1, "%s%s%s", servername, sl, ntprinter.info_2->printername);
+       snprintf(chaine2, sizeof(chaine)-1, "%s%s%s", servername, sl, ntprinter->info_2->printername);
 
        init_unistr(&printer->servername, chaine);                              /* servername*/
        init_unistr(&printer->printername, chaine2);                            /* printername*/
        init_unistr(&printer->sharename, lp_servicename(snum));                 /* sharename */
-       init_unistr(&printer->portname, lp_servicename(snum));                  /* port */      
-       init_unistr(&printer->drivername, ntprinter.info_2->drivername);        /* drivername */
-       init_unistr(&printer->comment, lp_comment(snum));                       /* comment */   
-       init_unistr(&printer->location, ntprinter.info_2->location);            /* location */  
-       init_unistr(&printer->sepfile, ntprinter.info_2->sepfile);              /* separator file */
-       init_unistr(&printer->printprocessor, ntprinter.info_2->printprocessor);/* print processor */
-       init_unistr(&printer->datatype, ntprinter.info_2->datatype);            /* datatype */  
-       init_unistr(&printer->parameters, ntprinter.info_2->parameters);        /* parameters (of print processor) */   
-
-       printer->attributes =   PRINTER_ATTRIBUTE_SHARED   \
-                             | PRINTER_ATTRIBUTE_LOCAL  \
-                             | PRINTER_ATTRIBUTE_RAW_ONLY ;                    /* attributes */
-
-       printer->priority = ntprinter.info_2->priority;                         /* priority */  
-       printer->defaultpriority = ntprinter.info_2->default_priority;          /* default priority */
-       printer->starttime = ntprinter.info_2->starttime;                       /* starttime */
-       printer->untiltime = ntprinter.info_2->untiltime;                       /* untiltime */
+       init_unistr(&printer->portname, ntprinter->info_2->portname);                   /* port */      
+       init_unistr(&printer->drivername, ntprinter->info_2->drivername);       /* drivername */
+
+       if (*ntprinter->info_2->comment == '\0')
+               init_unistr(&printer->comment, lp_comment(snum));                       /* comment */   
+       else
+               init_unistr(&printer->comment, ntprinter->info_2->comment); /* saved comment. */
+
+       init_unistr(&printer->location, ntprinter->info_2->location);           /* location */  
+       init_unistr(&printer->sepfile, ntprinter->info_2->sepfile);             /* separator file */
+       init_unistr(&printer->printprocessor, ntprinter->info_2->printprocessor);/* print processor */
+       init_unistr(&printer->datatype, ntprinter->info_2->datatype);           /* datatype */  
+       init_unistr(&printer->parameters, ntprinter->info_2->parameters);       /* parameters (of print processor) */   
+
+       printer->attributes = ntprinter->info_2->attributes;
+
+       printer->priority = ntprinter->info_2->priority;                                /* priority */  
+       printer->defaultpriority = ntprinter->info_2->default_priority;         /* default priority */
+       printer->starttime = ntprinter->info_2->starttime;                      /* starttime */
+       printer->untiltime = ntprinter->info_2->untiltime;                      /* untiltime */
        printer->status = nt_printq_status(status.status);                      /* status */
        printer->cjobs = count;                                                 /* jobs */
-       printer->averageppm = ntprinter.info_2->averageppm;                     /* average pages per minute */
+       printer->averageppm = ntprinter->info_2->averageppm;                    /* average pages per minute */
                        
-       if((devmode=(DEVICEMODE *)malloc(sizeof(DEVICEMODE))) == NULL) 
-               goto err;
-
-       ZERO_STRUCTP(devmode);  
-
-       if(!construct_dev_mode(devmode, snum, servername)) 
-               goto err;
+       if((printer->devmode = construct_dev_mode(snum, servername)) == NULL) {
+               DEBUG(8, ("Returning NULL Devicemode!\n"));
+       }
 
-       printer->devmode=devmode;
-       
-       if (ntprinter.info_2->secdesc.len != 0)
-       {
+       if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
                /* steal the printer info sec_desc structure.  [badly done]. */
-               printer->secdesc = ntprinter.info_2->secdesc.sec;
-               ZERO_STRUCT(ntprinter.info_2->secdesc);
+               printer->secdesc = ntprinter->info_2->secdesc_buf->sec;
+               ntprinter->info_2->secdesc_buf->sec = NULL; /* Stolen memory. */
+               ntprinter->info_2->secdesc_buf->len = 0; /* Stolen memory. */
+               ntprinter->info_2->secdesc_buf->max_len = 0; /* Stolen memory. */
        }
-       else
-       {
+       else {
                printer->secdesc = NULL;
        }
 
+       free_a_printer(&ntprinter, 2);
        safe_free(queue);
-       free_a_printer(ntprinter, 2);
        return True;
-
-  err:
-
-       safe_free(queue);
-       free_a_printer(ntprinter, 2);
-       return False;
 }
 
 /********************************************************************
@@ -1919,23 +2127,53 @@ static BOOL construct_printer_info_2(fstring servername, PRINTER_INFO_2 *printer
  * fill a printer_info_3 struct
  ********************************************************************/
 static BOOL construct_printer_info_3(fstring servername,
-                       PRINTER_INFO_3 *printer, int snum)
+                       PRINTER_INFO_3 **pp_printer, int snum)
 {
-       NT_PRINTER_INFO_LEVEL ntprinter;
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
+       PRINTER_INFO_3 *printer = NULL;
 
        if (get_a_printer(&ntprinter, 2, lp_servicename(snum)) !=0 )
                return False;
-               
-       printer->flags = 4; /* no idea, yet.  see MSDN. */
-       if (ntprinter.info_2->secdesc.len != 0)
-       {
+
+       *pp_printer = NULL;
+       if ((printer = (PRINTER_INFO_3 *)malloc(sizeof(PRINTER_INFO_3))) == NULL) {
+               DEBUG(0,("construct_printer_info_3: malloc fail.\n"));
+               return False;
+       }
+
+       ZERO_STRUCTP(printer);
+       
+       printer->flags = 4; /* These are the components of the SD we are returning. */
+       if (ntprinter->info_2->secdesc_buf && ntprinter->info_2->secdesc_buf->len != 0) {
                /* steal the printer info sec_desc structure.  [badly done]. */
-               printer->sec = *ntprinter.info_2->secdesc.sec;
-               safe_free(ntprinter.info_2->secdesc.sec);
-               ZERO_STRUCT(ntprinter.info_2->secdesc);
+               printer->secdesc = ntprinter->info_2->secdesc_buf->sec;
+
+#if 0
+               /*
+                * Set the flags for the components we are returning.
+                */
+
+               if (printer->secdesc->owner_sid)
+                       printer->flags |= OWNER_SECURITY_INFORMATION;
+
+               if (printer->secdesc->grp_sid)
+                       printer->flags |= GROUP_SECURITY_INFORMATION;
+
+               if (printer->secdesc->dacl)
+                       printer->flags |= DACL_SECURITY_INFORMATION;
+
+               if (printer->secdesc->sacl)
+                       printer->flags |= SACL_SECURITY_INFORMATION;
+#endif
+
+               ntprinter->info_2->secdesc_buf->sec = NULL; /* Stolen the malloced memory. */
+               ntprinter->info_2->secdesc_buf->len = 0; /* Stolen the malloced memory. */
+               ntprinter->info_2->secdesc_buf->max_len = 0; /* Stolen the malloced memory. */
        }
 
-       free_a_printer(ntprinter, 2);
+       free_a_printer(&ntprinter, 2);
+
+       *pp_printer = printer;
        return True;
 }
 
@@ -2117,7 +2355,7 @@ static BOOL enum_all_printers_info_2(fstring servername, NEW_BUFFER *buffer, uin
                                if((printers=Realloc(printers, (*returned +1)*sizeof(PRINTER_INFO_2))) == NULL)
                                        return ERROR_NOT_ENOUGH_MEMORY;
                                DEBUG(4,("ReAlloced memory for [%d] PRINTER_INFO_2\n", *returned));             
-                               memcpy(&(printers[*returned]), &current_prt, sizeof(PRINTER_INFO_2));
+                               memcpy(&printers[*returned], &current_prt, sizeof(PRINTER_INFO_2));
                                (*returned)++;
                        }
                }
@@ -2125,12 +2363,12 @@ static BOOL enum_all_printers_info_2(fstring servername, NEW_BUFFER *buffer, uin
        
        /* check the required size. */  
        for (i=0; i<*returned; i++)
-               (*needed) += spoolss_size_printer_info_2(&(printers[i]));
+               (*needed) += spoolss_size_printer_info_2(&printers[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
                for (i=0; i<*returned; i++) {
-                       safe_free(printers[i].devmode->private);
-                       safe_free(printers[i].devmode);
+                       free_devmode(printers[i].devmode);
+                       free_sec_desc(&printers[i].secdesc);
                }
                safe_free(printers);
                return ERROR_INSUFFICIENT_BUFFER;
@@ -2142,8 +2380,8 @@ static BOOL enum_all_printers_info_2(fstring servername, NEW_BUFFER *buffer, uin
        
        /* clear memory */
        for (i=0; i<*returned; i++) {
-               safe_free(printers[i].devmode->private);
-               safe_free(printers[i].devmode);
+               free_devmode(printers[i].devmode);
+               free_sec_desc(&printers[i].secdesc);
        }
        safe_free(printers);
 
@@ -2257,18 +2495,14 @@ uint32 _spoolss_enumprinters( uint32 flags, const UNISTR2 *servername, uint32 le
        switch (level) {
        case 1:
                return enumprinters_level1(flags, name, buffer, offered, needed, returned);
-               break;
        case 2:
                return enumprinters_level2(flags, name, buffer, offered, needed, returned);
-               break;                          
        case 5:
                return enumprinters_level5(flags, name, buffer, offered, needed, returned);
-               break;                          
        case 3:
        case 4:
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -2354,17 +2588,18 @@ static uint32 getprinter_level_2(fstring servername, int snum, NEW_BUFFER *buffe
        *needed += spoolss_size_printer_info_2(printer);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(printer);
+               free_printer_info_2(printer);
                return ERROR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
-       new_smb_io_printer_info_2("", buffer, printer, 0);      
+       if (!new_smb_io_printer_info_2("", buffer, printer, 0)) {
+               free_printer_info_2(printer);
+               return ERROR_NOT_ENOUGH_MEMORY;
+       }
        
        /* clear memory */
-       safe_free(printer->devmode->private);
-       safe_free(printer->devmode);
-       safe_free(printer);
+       free_printer_info_2(printer);
 
        if (*needed > offered) {
                return ERROR_INSUFFICIENT_BUFFER;
@@ -2380,18 +2615,16 @@ static uint32 getprinter_level_3(fstring servername, int snum, NEW_BUFFER *buffe
        PRINTER_INFO_3 *printer=NULL;
        fstring temp;
 
-       if((printer=(PRINTER_INFO_3*)malloc(sizeof(PRINTER_INFO_3)))==NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
        fstrcpy(temp, "\\\\");
        fstrcat(temp, servername);
-       construct_printer_info_3(temp, printer, snum);
+       if (!construct_printer_info_3(temp, &printer, snum))
+               return ERROR_NOT_ENOUGH_MEMORY;
        
        /* check the required size. */  
        *needed += spoolss_size_printer_info_3(printer);
 
        if (!alloc_buffer_size(buffer, *needed)) {
-               safe_free(printer);
+               free_printer_info_3(printer);
                return ERROR_INSUFFICIENT_BUFFER;
        }
 
@@ -2399,8 +2632,8 @@ static uint32 getprinter_level_3(fstring servername, int snum, NEW_BUFFER *buffe
        new_smb_io_printer_info_3("", buffer, printer, 0);      
        
        /* clear memory */
-       free_sec_desc(&printer->sec);
-
+       free_printer_info_3(printer);
+       
        if (*needed > offered) {
                return ERROR_INSUFFICIENT_BUFFER;
        }
@@ -2434,94 +2667,88 @@ uint32 _spoolss_getprinter(POLICY_HND *handle, uint32 level,
                return getprinter_level_3(servername,snum, buffer, offered, needed);
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }      
                
 /********************************************************************
- * construct_printer_driver_info_1
- * fill a construct_printer_driver_info_1 struct
+ * fill a DRIVER_INFO_1 struct
  ********************************************************************/
-static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_1(DRIVER_INFO_1 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername, fstring architecture)
 {
-       init_unistr( &(info->name), driver.info_3->name);
+       init_unistr( &info->name, driver.info_3->name);
 }
 
-static void construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, 
-                                            fstring servername, fstring architecture)
+/********************************************************************
+ * construct_printer_driver_info_1
+ ********************************************************************/
+static uint32 construct_printer_driver_info_1(DRIVER_INFO_1 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
 
        ZERO_STRUCT(driver);
-       ZERO_STRUCT(printer);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );
-       get_a_printer_driver(&driver, 3, printer.info_2->drivername, architecture);     
-       
+       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       if (get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+
        fill_printer_driver_info_1(info, driver, servername, architecture);
-       
-       free_a_printer_driver(driver, 3);
-       free_a_printer(printer, 2);
+
+       free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /********************************************************************
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_2(DRIVER_INFO_2 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
 {
-       pstring where;
        pstring temp_driverpath;
        pstring temp_datafile;
        pstring temp_configfile;
-       fstring short_archi;
-
-       get_short_archi(short_archi,architecture);
-       
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\%s\\", servername, short_archi, driver.info_3->name);
 
        info->version=driver.info_3->cversion;
 
-       init_unistr( &(info->name),         driver.info_3->name );
-       init_unistr( &(info->architecture), architecture );
-       
-       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "%s%s", where, 
-                driver.info_3->driverpath);
-       init_unistr( &(info->driverpath),   temp_driverpath );
+       init_unistr( &info->name, driver.info_3->name );
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "\\\\%s%s", servername, driver.info_3->driverpath);
+       init_unistr( &info->driverpath, temp_driverpath );
 
-       snprintf(temp_datafile,   sizeof(temp_datafile)-1, "%s%s", where, 
-                driver.info_3->datafile);
-       init_unistr( &(info->datafile),     temp_datafile );
+       snprintf(temp_datafile, sizeof(temp_datafile)-1, "\\\\%s%s", servername, driver.info_3->datafile);
+       init_unistr( &info->datafile, temp_datafile );
 
-       snprintf(temp_configfile, sizeof(temp_configfile)-1, "%s%s", where, 
-                driver.info_3->configfile);
-       init_unistr( &(info->configfile),   temp_configfile );  
+       snprintf(temp_configfile, sizeof(temp_configfile)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+       init_unistr( &info->configfile, temp_configfile );      
 }
 
 /********************************************************************
  * construct_printer_driver_info_2
  * fill a printer_info_2 struct
  ********************************************************************/
-static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture)
+static uint32 construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
 
        ZERO_STRUCT(printer);
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );
-       get_a_printer_driver(&driver, 3, printer.info_2->drivername, architecture);     
+       if (!get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       if (!get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version) != 0)
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
 
-       fill_printer_driver_info_2(info, driver, servername, architecture);
+       fill_printer_driver_info_2(info, driver, servername);
 
-       free_a_printer_driver(driver, 3);
-       free_a_printer(printer, 2);
+       free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
 }
 
 /********************************************************************
@@ -2529,7 +2756,7 @@ static void construct_printer_driver_info_2(DRIVER_INFO_2 *info, int snum, fstri
  *
  * convert an array of ascii string to a UNICODE string
  ********************************************************************/
-static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *where)
+static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *servername)
 {
        int i=0;
        int j=0;
@@ -2540,17 +2767,21 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *whe
        *uni_array=NULL;
 
        while (1) {
-               v = char_array[i];
-               snprintf(line, sizeof(line)-1, "%s%s", where, v);
+               if (char_array == NULL)
+                       v = "";
+               else {
+                       v = char_array[i];
+                       if (!v) v = ""; /* hack to handle null lists */
+               }
+               if (strlen(v) == 0) break;
+               snprintf(line, sizeof(line)-1, "\\\\%s%s", servername, v);
                DEBUGADD(6,("%d:%s:%d\n", i, line, strlen(line)));
                if((*uni_array=Realloc(*uni_array, (j+strlen(line)+2)*sizeof(uint16))) == NULL) {
                        DEBUG(0,("init_unistr_array: Realloc error\n" ));
                        return;
                }
-               ascii_to_unistr((char *)(*uni_array+j), line , 2*strlen(line));
-               j+=strlen(line)+1;                      
+               j += (dos_PutUniCode((char *)(*uni_array+j), line , sizeof(uint16)*strlen(line), True) / sizeof(uint16) );
                i++;
-               if (strlen(v) == 0) break;
        }
        
        if (*uni_array) {
@@ -2564,77 +2795,186 @@ static void init_unistr_array(uint16 **uni_array, fstring *char_array, char *whe
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, 
-                                       NT_PRINTER_DRIVER_INFO_LEVEL driver, 
-                                      fstring servername, fstring architecture)
+static void fill_printer_driver_info_3(DRIVER_INFO_3 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
 {
-       pstring where;
        pstring temp_driverpath;
        pstring temp_datafile;
        pstring temp_configfile;
        pstring temp_helpfile;
-       fstring short_archi;
-       
-       get_short_archi(short_archi, architecture);
-       
-       snprintf(where,sizeof(where)-1,"\\\\%s\\print$\\%s\\%s\\", servername, short_archi, driver.info_3->name);
+
+       ZERO_STRUCTP(info);
 
        info->version=driver.info_3->cversion;
 
-       init_unistr( &(info->name),         driver.info_3->name );      
-       init_unistr( &(info->architecture), architecture );
-       
-       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "%s%s", where, driver.info_3->driverpath);          
-       init_unistr( &(info->driverpath), temp_driverpath );
-       
-       snprintf(temp_datafile,   sizeof(temp_datafile)-1,   "%s%s", where, driver.info_3->datafile); 
-       init_unistr( &(info->datafile), temp_datafile );
-       
-       snprintf(temp_configfile, sizeof(temp_configfile)-1, "%s%s", where, driver.info_3->configfile);
-       init_unistr( &(info->configfile), temp_configfile );    
-       
-       snprintf(temp_helpfile,   sizeof(temp_helpfile)-1,   "%s%s", where, driver.info_3->helpfile);
-       init_unistr( &(info->helpfile), temp_helpfile );
+       init_unistr( &info->name, driver.info_3->name );        
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "\\\\%s%s", servername, driver.info_3->driverpath);                 
+       init_unistr( &info->driverpath, temp_driverpath );
+
+       snprintf(temp_datafile, sizeof(temp_datafile)-1, "\\\\%s%s", servername, driver.info_3->datafile); 
+       init_unistr( &info->datafile, temp_datafile );
 
-       init_unistr( &(info->monitorname), driver.info_3->monitorname );
-       init_unistr( &(info->defaultdatatype), driver.info_3->defaultdatatype );
+       snprintf(temp_configfile, sizeof(temp_configfile)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+       init_unistr( &info->configfile, temp_configfile );      
+
+       snprintf(temp_helpfile, sizeof(temp_helpfile)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
+       init_unistr( &info->helpfile, temp_helpfile );
+
+       init_unistr( &info->monitorname, driver.info_3->monitorname );
+       init_unistr( &info->defaultdatatype, driver.info_3->defaultdatatype );
 
        info->dependentfiles=NULL;
-       init_unistr_array(&(info->dependentfiles), driver.info_3->dependentfiles, where);
+       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, servername);
 }
 
 /********************************************************************
  * construct_printer_info_3
  * fill a printer_info_3 struct
  ********************************************************************/
-static void construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, 
-                                            fstring servername, fstring architecture)
+static uint32 construct_printer_driver_info_3(DRIVER_INFO_3 *info, int snum, fstring servername, fstring architecture, uint32 version)
 {      
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
+       uint32 status=0;
+       ZERO_STRUCT(driver);
 
-       ZERO_STRUCT(printer);
+       status=get_a_printer(&printer, 2, lp_servicename(snum) );
+       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
+       if (status != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
+       DEBUG(8,("construct_printer_driver_info_3: status: %d\n", status));
+       if (status != 0) {
+               free_a_printer(&printer,2);
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+       }
+
+       fill_printer_driver_info_3(info, driver, servername);
+
+       free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
+}
+
+/********************************************************************
+ * construct_printer_info_6
+ * fill a printer_info_6 struct - we know that driver is really level 3. This sucks. JRA.
+ ********************************************************************/
+
+static void fill_printer_driver_info_6(DRIVER_INFO_6 *info, NT_PRINTER_DRIVER_INFO_LEVEL driver, fstring servername)
+{
+       pstring temp_driverpath;
+       pstring temp_datafile;
+       pstring temp_configfile;
+       pstring temp_helpfile;
+       fstring nullstr;
+
+       ZERO_STRUCTP(info);
+       memset(&nullstr, '\0', sizeof(fstring));
+
+       info->version=driver.info_3->cversion;
+
+       init_unistr( &info->name, driver.info_3->name );        
+       init_unistr( &info->architecture, driver.info_3->environment );
+
+       snprintf(temp_driverpath, sizeof(temp_driverpath)-1, "\\\\%s%s", servername, driver.info_3->driverpath);                 
+       init_unistr( &info->driverpath, temp_driverpath );
+
+       snprintf(temp_datafile, sizeof(temp_datafile)-1, "\\\\%s%s", servername, driver.info_3->datafile); 
+       init_unistr( &info->datafile, temp_datafile );
+
+       snprintf(temp_configfile, sizeof(temp_configfile)-1, "\\\\%s%s", servername, driver.info_3->configfile);
+       init_unistr( &info->configfile, temp_configfile );      
+
+       snprintf(temp_helpfile, sizeof(temp_helpfile)-1, "\\\\%s%s", servername, driver.info_3->helpfile);
+       init_unistr( &info->helpfile, temp_helpfile );
+
+       init_unistr( &info->monitorname, driver.info_3->monitorname );
+       init_unistr( &info->defaultdatatype, driver.info_3->defaultdatatype );
+
+       info->dependentfiles=NULL;
+       init_unistr_array(&info->dependentfiles, driver.info_3->dependentfiles, servername);
+
+       info->previousdrivernames=NULL;
+       init_unistr_array(&info->previousdrivernames, &nullstr, servername);
+
+       info->driver_date.low=0;
+       info->driver_date.high=0;
+
+       info->padding=0;
+       info->driver_version_low=0;
+       info->driver_version_high=0;
+
+       init_unistr( &info->mfgname, "");
+       init_unistr( &info->oem_url, "");
+       init_unistr( &info->hardware_id, "");
+       init_unistr( &info->provider, "");
+}
+
+/********************************************************************
+ * construct_printer_info_6
+ * fill a printer_info_6 struct
+ ********************************************************************/
+static uint32 construct_printer_driver_info_6(DRIVER_INFO_6 *info, int snum, fstring servername, fstring architecture, uint32 version)
+{      
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_PRINTER_DRIVER_INFO_LEVEL driver;
+       uint32 status=0;
        ZERO_STRUCT(driver);
 
-       get_a_printer(&printer, 2, lp_servicename(snum) );      
-       get_a_printer_driver(&driver, 3, printer.info_2->drivername, architecture);     
+       status=get_a_printer(&printer, 2, lp_servicename(snum) );
+       DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
+       if (status != 0)
+               return ERROR_INVALID_PRINTER_NAME;
+
+       status=get_a_printer_driver(&driver, 3, printer->info_2->drivername, architecture, version);    
+       DEBUG(8,("construct_printer_driver_info_6: status: %d\n", status));
+       if (status != 0) {
+               free_a_printer(&printer,2);
+               return ERROR_UNKNOWN_PRINTER_DRIVER;
+       }
+
+       fill_printer_driver_info_6(info, driver, servername);
+
+       free_a_printer(&printer,2);
+
+       return NT_STATUS_NO_PROBLEMO;
+}
+
+/****************************************************************************
+****************************************************************************/
+
+static void free_printer_driver_info_3(DRIVER_INFO_3 *info)
+{
+       safe_free(info->dependentfiles);
+}
 
-       fill_printer_driver_info_3(info, driver, servername, architecture);
+/****************************************************************************
+****************************************************************************/
 
-       free_a_printer_driver(driver, 3);
-       free_a_printer(printer, 2);
+static void free_printer_driver_info_6(DRIVER_INFO_6 *info)
+{
+       safe_free(info->dependentfiles);
+       
 }
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level1(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_1 *info=NULL;
+       uint32 status;
        
        if((info=(DRIVER_INFO_1 *)malloc(sizeof(DRIVER_INFO_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       construct_printer_driver_info_1(info, snum, servername, architecture);
+       status=construct_printer_driver_info_1(info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               safe_free(info);
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_1(info);
@@ -2658,14 +2998,19 @@ static uint32 getprinterdriver2_level1(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level2(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_2 *info=NULL;
+       uint32 status;
        
        if((info=(DRIVER_INFO_2 *)malloc(sizeof(DRIVER_INFO_2))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
        
-       construct_printer_driver_info_2(info, snum, servername, architecture);
+       status=construct_printer_driver_info_2(info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               safe_free(info);
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_2(info);
@@ -2689,24 +3034,64 @@ static uint32 getprinterdriver2_level2(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+static uint32 getprinterdriver2_level3(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
 {
        DRIVER_INFO_3 info;
+       uint32 status;
 
        ZERO_STRUCT(info);
 
-       construct_printer_driver_info_3(&info, snum, servername, architecture);
+       status=construct_printer_driver_info_3(&info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               return status;
+       }
 
        /* check the required size. */  
        *needed += spoolss_size_printer_driver_info_3(&info);
 
        if (!alloc_buffer_size(buffer, *needed)) {
+               free_printer_driver_info_3(&info);
                return ERROR_INSUFFICIENT_BUFFER;
        }
 
        /* fill the buffer with the structures */
        new_smb_io_printer_driver_info_3("", buffer, &info, 0);
 
+       free_printer_driver_info_3(&info);
+
+       if (*needed > offered)
+               return ERROR_INSUFFICIENT_BUFFER;
+       else
+               return NT_STATUS_NO_PROBLEMO;
+}
+
+/****************************************************************************
+****************************************************************************/
+static uint32 getprinterdriver2_level6(fstring servername, fstring architecture, uint32 version, int snum, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+{
+       DRIVER_INFO_6 info;
+       uint32 status;
+
+       ZERO_STRUCT(info);
+
+       status=construct_printer_driver_info_6(&info, snum, servername, architecture, version);
+       if (status != NT_STATUS_NO_PROBLEMO) {
+               return status;
+       }
+
+       /* check the required size. */  
+       *needed += spoolss_size_printer_driver_info_6(&info);
+
+       if (!alloc_buffer_size(buffer, *needed)) {
+               free_printer_driver_info_6(&info);
+               return ERROR_INSUFFICIENT_BUFFER;
+       }
+
+       /* fill the buffer with the structures */
+       new_smb_io_printer_driver_info_6("", buffer, &info, 0);
+
+       free_printer_driver_info_6(&info);
+
        if (*needed > offered)
                return ERROR_INSUFFICIENT_BUFFER;
        else
@@ -2715,7 +3100,7 @@ static uint32 getprinterdriver2_level3(fstring servername, fstring architecture,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_getprinterdriver2(const POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level, 
+uint32 _spoolss_getprinterdriver2(POLICY_HND *handle, const UNISTR2 *uni_arch, uint32 level, 
                                uint32 clientmajorversion, uint32 clientminorversion,
                                NEW_BUFFER *buffer, uint32 offered,
                                uint32 *needed, uint32 *servermajorversion, uint32 *serverminorversion)
@@ -2738,28 +3123,25 @@ uint32 _spoolss_getprinterdriver2(const POLICY_HND *handle, const UNISTR2 *uni_a
 
        switch (level) {
        case 1:
-               return getprinterdriver2_level1(servername, architecture, snum, buffer, offered, needed);
-               break;
+               return getprinterdriver2_level1(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        case 2:
-               return getprinterdriver2_level2(servername, architecture, snum, buffer, offered, needed);
-               break;                          
+               return getprinterdriver2_level2(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        case 3:
-               return getprinterdriver2_level3(servername, architecture, snum, buffer, offered, needed);
-               break;                          
+               return getprinterdriver2_level3(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
+       case 6:
+               return getprinterdriver2_level6(servername, architecture, clientmajorversion, snum, buffer, offered, needed);
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_startpageprinter(const POLICY_HND *handle)
+uint32 _spoolss_startpageprinter(POLICY_HND *handle)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (OPEN_HANDLE(Printer))
-       {
+       if (OPEN_HANDLE(Printer)) {
                Printer->page_started=True;
                return 0x0;
        }
@@ -2770,13 +3152,12 @@ uint32 _spoolss_startpageprinter(const POLICY_HND *handle)
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_endpageprinter(const POLICY_HND *handle)
+uint32 _spoolss_endpageprinter(POLICY_HND *handle)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error in endpageprinter printer handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_endpageprinter: Invalid handle (%s).\n",OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        
@@ -2785,26 +3166,45 @@ uint32 _spoolss_endpageprinter(const POLICY_HND *handle)
        return NT_STATUS_NO_PROBLEMO;
 }
 
+/****************************************************************************
+ Return a user struct for a pipe user.
+****************************************************************************/
+
+static struct current_user *get_current_user(struct current_user *user, pipes_struct *p)
+{
+       if (p->ntlmssp_auth_validated) {
+               memcpy(user, &p->pipe_user, sizeof(struct current_user));
+       } else {
+               extern struct current_user current_user;
+               memcpy(user, &current_user, sizeof(struct current_user));
+       }
+
+       return user;
+}
 
 /********************************************************************
  * api_spoolss_getprinter
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-uint32 _spoolss_startdocprinter( const POLICY_HND *handle, uint32 level,
-                               DOC_INFO *docinfo, uint32 *jobid)
+uint32 _spoolss_startdocprinter(POLICY_HND *handle, uint32 level,
+                               pipes_struct *p, DOC_INFO *docinfo, 
+                               uint32 *jobid)
 {
        DOC_INFO_1 *info_1 = &docinfo->doc_info_1;
        int snum;
        pstring jobname;
        fstring datatype;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       struct current_user user;
 
-       if (!OPEN_HANDLE(Printer))
-       {
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_startdocprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
 
+       get_current_user(&user, p);
+
        /*
         * a nice thing with NT is it doesn't listen to what you tell it.
         * when asked to send _only_ RAW datas, it tries to send datas
@@ -2817,35 +3217,34 @@ uint32 _spoolss_startdocprinter( const POLICY_HND *handle, uint32 level,
         * server-side code. *nnnnnggggh!*
         */
        
-       if (info_1->p_datatype != 0)
-       {
-               unistr2_to_ascii(datatype, &(info_1->docname), sizeof(datatype));
-               if (strcmp(datatype, "RAW") != 0)
-               {
+       if (info_1->p_datatype != 0) {
+               unistr2_to_ascii(datatype, &info_1->datatype, sizeof(datatype));
+               if (strcmp(datatype, "RAW") != 0) {
                        (*jobid)=0;
                        return ERROR_INVALID_DATATYPE;
                }               
        }                
        
        /* get the share number of the printer */
-       if (!get_printer_snum(handle, &snum))
-       {
+       if (!get_printer_snum(handle, &snum)) {
                return ERROR_INVALID_HANDLE;
        }
 
        unistr2_to_ascii(jobname, &info_1->docname, sizeof(jobname));
        
-       Printer->jobid = print_job_start(snum, jobname);
+       Printer->jobid = print_job_start(&user, snum, jobname);
+
+       /* An error occured in print_job_start() so return an appropriate
+          NT error code. */
 
-       /* need to map error codes properly - for now give out of
-          memory as I don't know the correct codes (tridge) */
        if (Printer->jobid == -1) {
-               return ERROR_NOT_ENOUGH_MEMORY;
+               return map_nt_error_from_unix(errno);
        }
        
        Printer->document_started=True;
        (*jobid) = Printer->jobid;
 
+       srv_spoolss_sendnotify(handle);
        return 0x0;
 }
 
@@ -2854,13 +3253,12 @@ uint32 _spoolss_startdocprinter( const POLICY_HND *handle, uint32 level,
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-uint32 _spoolss_enddocprinter(const POLICY_HND *handle)
+uint32 _spoolss_enddocprinter(POLICY_HND *handle)
 {
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error in enddocprinter handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_enddocprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        
@@ -2868,25 +3266,27 @@ uint32 _spoolss_enddocprinter(const POLICY_HND *handle)
        print_job_end(Printer->jobid);
        /* error codes unhandled so far ... */
 
+       srv_spoolss_sendnotify(handle);
+
        return 0x0;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_writeprinter( const POLICY_HND *handle,
+uint32 _spoolss_writeprinter( POLICY_HND *handle,
                                uint32 buffer_size,
-                               const uint8 *buffer,
+                               uint8 *buffer,
                                uint32 *buffer_written)
 {
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
-       {
-               DEBUG(3,("Error in writeprinter handle\n"));
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_writeprinter: Invalid handle (%s)\n",OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
 
-       (*buffer_written) = print_job_write(Printer->jobid, buffer, buffer_size);
+       (*buffer_written) = print_job_write(Printer->jobid, (char *)buffer, 
+                                           buffer_size);
 
        return 0x0;
 }
@@ -2896,158 +3296,370 @@ uint32 _spoolss_writeprinter( const POLICY_HND *handle,
  * called from the spoolss dispatcher
  *
  ********************************************************************/
-static uint32 control_printer(const POLICY_HND *handle, uint32 command)
+static uint32 control_printer(POLICY_HND *handle, uint32 command,
+                             pipes_struct *p)
 {
+       struct current_user user;
        int snum;
+       int errcode = 0;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       get_current_user(&user, p);
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("control_printer: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        if (!get_printer_snum(handle, &snum) )   
                return ERROR_INVALID_HANDLE;
 
        switch (command) {
        case PRINTER_CONTROL_PAUSE:
-               if (print_queue_pause(snum)) {
+               if (print_queue_pause(&user, snum, &errcode)) {
+                       srv_spoolss_sendnotify(handle);
                        return 0;
                }
                break;
        case PRINTER_CONTROL_RESUME:
        case PRINTER_CONTROL_UNPAUSE:
-               if (print_queue_resume(snum)) {
+               if (print_queue_resume(&user, snum, &errcode)) {
+                       srv_spoolss_sendnotify(handle);
                        return 0;
                }
                break;
        case PRINTER_CONTROL_PURGE:
-               if (print_queue_purge(snum)) {
+               if (print_queue_purge(&user, snum, &errcode)) {
+                       srv_spoolss_sendnotify(handle);
                        return 0;
                }
                break;
        }
 
+       if (errcode)
+               return (uint32)errcode;
+
        return ERROR_INVALID_FUNCTION;
 }
 
+/********************************************************************
+ * api_spoolss_abortprinter
+ ********************************************************************/
+
+uint32 _spoolss_abortprinter(POLICY_HND *handle, pipes_struct *p)
+{
+       return control_printer(handle, PRINTER_CONTROL_PURGE, p);
+}
+
 /********************************************************************
  * called by spoolss_api_setprinter
  * when updating a printer description
  ********************************************************************/
-static uint32 update_printer(const POLICY_HND *handle, uint32 level,
-                           const SPOOL_PRINTER_INFO_LEVEL *info,
-                           const DEVICEMODE *devmode)
+static uint32 update_printer_sec(POLICY_HND *handle, uint32 level,
+                                const SPOOL_PRINTER_INFO_LEVEL *info,
+                                pipes_struct *p, SEC_DESC_BUF *secdesc_ctr)
 {
+       struct current_user user;
+       uint32 result;
        int snum;
-       NT_PRINTER_INFO_LEVEL printer;
-       NT_DEVICEMODE *nt_devmode;
-       Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       nt_devmode=NULL;
-       
-       DEBUG(8,("update_printer\n"));
-       
-       if (level!=2) {
-               DEBUG(0,("Send a mail to jfm@samba.org\n"));
-               DEBUGADD(0,("with the following message: update_printer: level!=2\n"));
-               return ERROR_INVALID_LEVEL;
-       }
+       Printer_entry *Printer = find_printer_index_by_hnd(handle);
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer) || !get_printer_snum(handle, &snum)) {
+               DEBUG(0,("update_printer_sec: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
-       if (!get_printer_snum(handle, &snum) )
-               return ERROR_INVALID_HANDLE;
-       
-       get_a_printer(&printer, 2, lp_servicename(snum));
+       /* Work out which user is performing the operation */
+       get_current_user(&user, p);
 
-       DEBUGADD(8,("Converting info_2 struct\n"));
-       convert_printer_info(info, &printer, level);
-       
-       if ((info->info_2)->devmode_ptr != 0) {
-               /* we have a valid devmode
-                  convert it and link it*/
-               
-               /* the nt_devmode memory is already alloced
-                * while doing the get_a_printer call
-                * but the devmode private part is not
-                * it's done by convert_devicemode
-                */
-               DEBUGADD(8,("Converting the devicemode struct\n"));
-               nt_devmode=printer.info_2->devmode;
-               
-               init_devicemode(nt_devmode);
-                               
-               convert_devicemode(*devmode, nt_devmode);
-       }
-       else {
-               if (printer.info_2->devmode != NULL)
-                       free(printer.info_2->devmode);
-               printer.info_2->devmode=NULL;
-       }
-                       
-       if (add_a_printer(printer, 2)!=0) {
-               free_a_printer(printer, 2);
-               
-               /* I don't really know what to return here !!! */
-               return ERROR_ACCESS_DENIED;
+       /* Check the user has permissions to change the security
+          descriptor.  By experimentation with two NT machines, the user
+          requires Full Access to the printer to change security
+          information. */ 
+       if (!print_access_check(&user, snum, PRINTER_ACCESS_ADMINISTER)) {
+               result = ERROR_ACCESS_DENIED;
+               goto done;
        }
 
-       free_a_printer(printer, 2);
+       result = nt_printing_setsec(Printer->dev.handlename, secdesc_ctr);
 
-       return NT_STATUS_NO_PROBLEMO;
+ done:
+       return result;
 }
 
-/****************************************************************************
-****************************************************************************/
-uint32 _spoolss_setprinter(const POLICY_HND *handle, uint32 level,
-                          const SPOOL_PRINTER_INFO_LEVEL *info,
-                          const DEVMODE_CTR devmode_ctr,
-                          uint32 command)
+/********************************************************************
+ Do Samba sanity checks on a printer info struct.
+ ********************************************************************/
+
+static BOOL check_printer_ok(NT_PRINTER_INFO_LEVEL_2 *info, int snum)
 {
+       /*
+        * Ensure that this printer is shared under the correct name
+        * as this is what Samba insists upon.
+        */
+
+       if (!(info->attributes & PRINTER_ATTRIBUTE_SHARED)) {
+               DEBUG(10,("check_printer_ok: SHARED check failed (%x).\n", (unsigned int)info->attributes ));
+               return False;
+       }
+
+       if (!(info->attributes & PRINTER_ATTRIBUTE_RAW_ONLY)) {
+               /* NT forgets to set the raw attribute but sends the correct type. */
+               if (strequal(info->datatype, "RAW"))
+                       info->attributes |= PRINTER_ATTRIBUTE_RAW_ONLY;
+               else {
+                       DEBUG(10,("check_printer_ok: RAW check failed (%x).\n", (unsigned int)info->attributes ));
+                       return False;
+               }
+       }
+
+       if (!strequal(info->sharename, lp_servicename(snum))) {
+               DEBUG(10,("check_printer_ok: NAME check failed (%s) (%s).\n", info->sharename, lp_servicename(snum)));
+               return False;
+       }
+
+       return True;
+}
+
+/****************************************************************************
+****************************************************************************/
+static BOOL add_printer_hook(NT_PRINTER_INFO_LEVEL *printer)
+{
+       pid_t local_pid = sys_getpid();
+       char *cmd = lp_addprinter_cmd();
+       char *path;
+       char **qlines;
+       pstring tmp_file;
+       pstring command;
+       pstring driverlocation;
+       int numlines;
+       int ret;
+
+       if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+               path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+       else
+               path = tmpdir();
+
+       /* build driver path... only 9X architecture is needed for legacy reasons */
+       slprintf(driverlocation, sizeof(driverlocation)-1, "\\\\%s\\print$\\WIN40\\0",
+                       global_myname);
+       /* change \ to \\ for the shell */
+       all_string_sub(driverlocation,"\\","\\\\",sizeof(pstring));
+       
+       slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+       slprintf(command, sizeof(command), "%s \"%s\" \"%s\" \"%s\" \"%s\" \"%s\" \"%s\"",
+                       cmd, printer->info_2->printername, printer->info_2->sharename,
+                       printer->info_2->portname, printer->info_2->drivername,
+                       printer->info_2->location, driverlocation);
+
+       unlink(tmp_file);
+       DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+       ret = smbrun(command, tmp_file, False);
+       DEBUGADD(10,("returned [%d]\n", ret));
+
+       if ( ret != 0 ) {
+               unlink(tmp_file);
+               return False;
+       }
+
+       numlines = 0;
+       qlines = file_lines_load(tmp_file, &numlines);
+       DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+       DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+       unlink(tmp_file);
+
+       if(numlines) {
+               /* Set the portname to what the script says the portname should be. */
+               strncpy(printer->info_2->portname, qlines[0], sizeof(printer->info_2->portname));
+               DEBUGADD(6,("Line[0] = [%s]\n", qlines[0]));
+
+               /* Send SIGHUP to process group... is there a better way? */
+               kill(0, SIGHUP);
+               add_all_printers();
+       }
+
+       file_lines_free(qlines);
+       return True;
+}
+
+/********************************************************************
+ * called by spoolss_api_setprinter
+ * when updating a printer description
+ ********************************************************************/
+
+static uint32 update_printer(POLICY_HND *handle, uint32 level,
+                           const SPOOL_PRINTER_INFO_LEVEL *info,
+                           DEVICEMODE *devmode)
+{
+       int snum;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       uint32 result;
+
+       DEBUG(8,("update_printer\n"));
        
-       if (!OPEN_HANDLE(Printer))
+       result = NT_STATUS_NO_PROBLEMO;
+
+       /* Check calling user has permission to update printer description */ 
+
+       if (level!=2) {
+               DEBUG(0,("Send a mail to samba@samba.org\n"));
+               DEBUGADD(0,("with the following message: update_printer: level!=2\n"));
+               result = ERROR_INVALID_LEVEL;
+               goto done;
+       }
+
+       if (!OPEN_HANDLE(Printer)) {
+               result = ERROR_INVALID_HANDLE;
+               goto done;
+       }
+
+       if (!get_printer_snum(handle, &snum)) {
+               result = ERROR_INVALID_HANDLE;
+               goto done;
+       }
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("printer property change denied by security "
+                         "descriptor\n"));
+               result = ERROR_ACCESS_DENIED;
+               goto done;
+       }
+       
+       if(get_a_printer(&printer, 2, lp_servicename(snum)) != 0) {
+               result = ERROR_INVALID_HANDLE;
+               goto done;
+       }
+
+       DEBUGADD(8,("Converting info_2 struct\n"));
+
+       /*
+        * convert_printer_info converts the incoming
+        * info from the client and overwrites the info
+        * just read from the tdb in the pointer 'printer'.
+        */
+
+       convert_printer_info(info, printer, level);
+       
+       if (info->info_2->devmode_ptr != 0) {
+               /* we have a valid devmode
+                  convert it and link it*/
+
+               /*
+                * Ensure printer->info_2->devmode is a valid pointer 
+                * as we will be overwriting it in convert_devicemode().
+                */
+               
+               if (printer->info_2->devmode == NULL)
+                       printer->info_2->devmode = construct_nt_devicemode(printer->info_2->printername);
+
+               DEBUGADD(8,("Converting the devicemode struct\n"));
+               convert_devicemode(devmode, printer->info_2->devmode);
+
+       } else {
+               if (printer->info_2->devmode != NULL)
+                       free_nt_devicemode(&printer->info_2->devmode);
+               printer->info_2->devmode=NULL;
+       }
+
+       /*
+        * Do sanity check on the requested changes for Samba.
+        */
+
+       if (!check_printer_ok(printer->info_2, snum)) {
+               result = ERROR_INVALID_PARAMETER;
+               goto done;
+       }
+
+       if (*lp_addprinter_cmd() )
+               if ( !add_printer_hook(printer) ) {
+                       result = ERROR_ACCESS_DENIED;
+                       goto done;
+               }
+       
+       if (add_a_printer(*printer, 2)!=0) {
+               /* I don't really know what to return here !!! */
+               result = ERROR_ACCESS_DENIED;
+               goto done;
+       }
+
+ done:
+       free_a_printer(&printer, 2);
+
+       srv_spoolss_sendnotify(handle);
+
+       return result;
+}
+
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_setprinter(POLICY_HND *handle, uint32 level,
+                          const SPOOL_PRINTER_INFO_LEVEL *info,
+                          DEVMODE_CTR devmode_ctr,
+                          SEC_DESC_BUF *secdesc_ctr,
+                          uint32 command, pipes_struct *p)
+{
+       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+       
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_setprinter: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        /* check the level */   
        switch (level) {
                case 0:
-                       return control_printer(handle, command);
-                       break;
+                       return control_printer(handle, command, p);
                case 2:
                        return update_printer(handle, level, info, devmode_ctr.devmode);
-                       break;
+               case 3:
+                       return update_printer_sec(handle, level, info, p,
+                                                 secdesc_ctr);
                default:
                        return ERROR_INVALID_LEVEL;
-                       break;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_fcpn(const POLICY_HND *handle)
+uint32 _spoolss_fcpn(POLICY_HND *handle)
 {
        Printer_entry *Printer= find_printer_index_by_hnd(handle);
        
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_fcpn: Invalid handle (%s)\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
-       
+       }
+
+       if (Printer->notify.client_connected==True)
+               if(!srv_spoolss_replycloseprinter(&Printer->notify.client_hnd))
+                       return ERROR_INVALID_HANDLE;
+
        Printer->notify.flags=0;
        Printer->notify.options=0;
        Printer->notify.localmachine[0]='\0';
        Printer->notify.printerlocal=0;
+       if (Printer->notify.option)
+               safe_free(Printer->notify.option->ctr.type);
        safe_free(Printer->notify.option);
        Printer->notify.option=NULL;
-       
+       Printer->notify.client_connected=False;
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addjob(const POLICY_HND *handle, uint32 level,
-                       NEW_BUFFER *buffer, uint32 offered)
+uint32 _spoolss_addjob(POLICY_HND *handle, uint32 level,
+                      NEW_BUFFER *buffer, uint32 offered,
+                      uint32 *needed)
 {
-       return NT_STATUS_NO_PROBLEMO;
+       *needed = 0;
+       return ERROR_INVALID_PARAMETER; /* this is what a NT server
+                                           returns for AddJob. AddJob
+                                           must fail on non-local
+                                           printers */
 }
 
 /****************************************************************************
@@ -3064,19 +3676,19 @@ static void fill_job_info_1(JOB_INFO_1 *job_info, print_queue_struct *queue,
        snprintf(temp_name, sizeof(temp_name), "\\\\%s", global_myname);
 
        job_info->jobid=queue->job;     
-       init_unistr(&(job_info->printername), lp_servicename(snum));
-       init_unistr(&(job_info->machinename), temp_name);
-       init_unistr(&(job_info->username), queue->user);
-       init_unistr(&(job_info->document), queue->file);
-       init_unistr(&(job_info->datatype), "RAW");
-       init_unistr(&(job_info->text_status), "");
+       init_unistr(&job_info->printername, lp_servicename(snum));
+       init_unistr(&job_info->machinename, temp_name);
+       init_unistr(&job_info->username, queue->user);
+       init_unistr(&job_info->document, queue->file);
+       init_unistr(&job_info->datatype, "RAW");
+       init_unistr(&job_info->text_status, "");
        job_info->status=nt_printj_status(queue->status);
        job_info->priority=queue->priority;
        job_info->position=position;
        job_info->totalpages=0;
        job_info->pagesprinted=0;
 
-       make_systemtime(&(job_info->submitted), t);
+       make_systemtime(&job_info->submitted, t);
 }
 
 /****************************************************************************
@@ -3085,8 +3697,7 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
                             int position, int snum)
 {
        pstring temp_name;
-       DEVICEMODE *devmode;
-       NT_PRINTER_INFO_LEVEL ntprinter;
+       NT_PRINTER_INFO_LEVEL *ntprinter = NULL;
        pstring chaine;
 
        struct tm *t;
@@ -3100,17 +3711,19 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
 
        job_info->jobid=queue->job;
        
-       snprintf(chaine, sizeof(chaine)-1, "\\\\%s\\%s", global_myname, ntprinter.info_2->printername);
-       init_unistr(&(job_info->printername), chaine);
+       snprintf(chaine, sizeof(chaine)-1, "\\\\%s\\%s", global_myname, ntprinter->info_2->printername);
+
+       init_unistr(&job_info->printername, chaine);
        
-       init_unistr(&(job_info->machinename), temp_name);
-       init_unistr(&(job_info->username), queue->user);
-       init_unistr(&(job_info->document), queue->file);
-       init_unistr(&(job_info->notifyname), queue->user);
-       init_unistr(&(job_info->datatype), "RAW");
-       init_unistr(&(job_info->printprocessor), "winprint");
-       init_unistr(&(job_info->parameters), "");
-       init_unistr(&(job_info->text_status), "");
+       init_unistr(&job_info->machinename, temp_name);
+       init_unistr(&job_info->username, queue->user);
+       init_unistr(&job_info->document, queue->file);
+       init_unistr(&job_info->notifyname, queue->user);
+       init_unistr(&job_info->datatype, "RAW");
+       init_unistr(&job_info->printprocessor, "winprint");
+       init_unistr(&job_info->parameters, "");
+       init_unistr(&job_info->drivername, ntprinter->info_2->drivername);
+       init_unistr(&job_info->text_status, "");
        
 /* and here the security descriptor */
 
@@ -3125,19 +3738,12 @@ static BOOL fill_job_info_2(JOB_INFO_2 *job_info, print_queue_struct *queue,
        job_info->timeelapsed=0;
        job_info->pagesprinted=0;
 
-       if((devmode=(DEVICEMODE *)malloc(sizeof(DEVICEMODE))) == NULL) {
-               free_a_printer(ntprinter, 2);
+       if((job_info->devmode = construct_dev_mode(snum, global_myname)) == NULL) {
+               free_a_printer(&ntprinter, 2);
                return False;
        }
 
-       ZERO_STRUCTP(devmode);  
-       if(!construct_dev_mode(devmode, snum, global_myname)) {
-               free_a_printer(ntprinter, 2);
-               return False;
-       }
-       job_info->devmode=devmode;
-
-       free_a_printer(ntprinter, 2);
+       free_a_printer(&ntprinter, 2);
        return (True);
 }
 
@@ -3159,13 +3765,13 @@ static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
        }
        
        for (i=0; i<*returned; i++)
-               fill_job_info_1(&(info[i]), &(queue[i]), i, snum);
+               fill_job_info_1(&info[i], &queue[i], i, snum);
 
        safe_free(queue);
 
        /* check the required size. */  
        for (i=0; i<*returned; i++)
-               (*needed) += spoolss_size_job_info_1(&(info[i]));
+               (*needed) += spoolss_size_job_info_1(&info[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
                safe_free(info);
@@ -3174,7 +3780,7 @@ static uint32 enumjobs_level1(print_queue_struct *queue, int snum,
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_job_info_1("", buffer, &(info[i]), 0);       
+               new_smb_io_job_info_1("", buffer, &info[i], 0); 
 
        /* clear memory */
        safe_free(info);
@@ -3205,13 +3811,13 @@ static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
        }
        
        for (i=0; i<*returned; i++)
-               fill_job_info_2(&(info[i]), &(queue[i]), i, snum);
+               fill_job_info_2(&(info[i]), &queue[i], i, snum);
 
        safe_free(queue);
 
        /* check the required size. */  
        for (i=0; i<*returned; i++)
-               (*needed) += spoolss_size_job_info_2(&(info[i]));
+               (*needed) += spoolss_size_job_info_2(&info[i]);
 
        if (!alloc_buffer_size(buffer, *needed)) {
                safe_free(info);
@@ -3220,7 +3826,7 @@ static uint32 enumjobs_level2(print_queue_struct *queue, int snum,
 
        /* fill the buffer with the structures */
        for (i=0; i<*returned; i++)
-               new_smb_io_job_info_2("", buffer, &(info[i]), 0);       
+               new_smb_io_job_info_2("", buffer, &info[i], 0); 
 
        /* clear memory */
        safe_free(info);
@@ -3257,38 +3863,42 @@ uint32 _spoolss_enumjobs( POLICY_HND *handle, uint32 firstjob, uint32 numofjobs,
        *returned = print_queue_status(snum, &queue, &prt_status);
        DEBUGADD(4,("count:[%d], status:[%d], [%s]\n", *returned, prt_status.status, prt_status.message));
 
+       if (*returned == 0) {
+               safe_free(queue);
+               return NT_STATUS_NO_PROBLEMO;
+       }
+
        switch (level) {
        case 1:
                return enumjobs_level1(queue, snum, buffer, offered, needed, returned);
-               break;
        case 2:
                return enumjobs_level2(queue, snum, buffer, offered, needed, returned);
-               break;                          
        default:
                safe_free(queue);
                *returned=0;
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_schedulejob( const POLICY_HND *handle, uint32 jobid)
+uint32 _spoolss_schedulejob( POLICY_HND *handle, uint32 jobid)
 {
        return 0x0;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setjob( const POLICY_HND *handle,
+uint32 _spoolss_setjob( POLICY_HND *handle,
                                uint32 jobid,
                                uint32 level,
+                pipes_struct *p,
                                JOB_INFO *ctr,
                                uint32 command)
 
 {
+       struct current_user user;
        int snum;
        print_status_struct prt_status;
                
@@ -3301,17 +3911,28 @@ uint32 _spoolss_setjob( const POLICY_HND *handle,
        if (!print_job_exists(jobid)) {
                return ERROR_INVALID_PRINTER_NAME;
        }
-       
+
+       get_current_user(&user, p);     
+
        switch (command) {
        case JOB_CONTROL_CANCEL:
        case JOB_CONTROL_DELETE:
-               if (print_job_delete(jobid)) return 0x0;
+               if (print_job_delete(&user, jobid)) {
+                       srv_spoolss_sendnotify(handle);
+                       return 0x0;
+               }
                break;
        case JOB_CONTROL_PAUSE:
-               if (print_job_pause(jobid)) return 0x0;
+               if (print_job_pause(&user, jobid)) {
+                       srv_spoolss_sendnotify(handle);
+                       return 0x0;
+               }               
                break;
        case JOB_CONTROL_RESUME:
-               if (print_job_resume(jobid)) return 0x0;
+               if (print_job_resume(&user, jobid)) {
+                       srv_spoolss_sendnotify(handle);
+                       return 0x0;
+               }
                break;
        default:
                return ERROR_INVALID_LEVEL;
@@ -3323,29 +3944,55 @@ uint32 _spoolss_setjob( const POLICY_HND *handle,
 /****************************************************************************
  Enumerates all printer drivers at level 1.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level1(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_1 *driver_info_1=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if((driver_info_1=(DRIVER_INFO_1 *)malloc(*returned * sizeof(DRIVER_INFO_1))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_1(&(driver_info_1[i]), driver, servername, architecture );
-               free_a_printer_driver(driver, 3);
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_1=(DRIVER_INFO_1 *)Realloc(driver_info_1, (*returned+ndrivers) * sizeof(DRIVER_INFO_1))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+
+               for (i=0; i<ndrivers; i++) {
+                       uint32 status;
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
+                               safe_free(list);
+                               return status;
+                       }
+                       fill_printer_driver_info_1(&driver_info_1[*returned+i], driver, servername, architecture );             
+                       free_a_printer_driver(driver, 3);
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
        
-       safe_free(list);
-       
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
-               *needed += spoolss_size_printer_driver_info_1(&(driver_info_1[i]));
+               *needed += spoolss_size_printer_driver_info_1(&driver_info_1[i]);
        }
 
        if (!alloc_buffer_size(buffer, *needed)) {
@@ -3356,7 +4003,7 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
        /* fill the buffer with the form structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d] to buffer\n",i));
-               new_smb_io_printer_driver_info_1("", buffer, &(driver_info_1[i]), 0);
+               new_smb_io_printer_driver_info_1("", buffer, &driver_info_1[i], 0);
        }
 
        safe_free(driver_info_1);
@@ -3372,26 +4019,52 @@ static uint32 enumprinterdrivers_level1(fstring *list, fstring servername, fstri
 /****************************************************************************
  Enumerates all printer drivers at level 2.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level2(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_2 *driver_info_2=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if (*returned > 0 && 
-           !(driver_info_2=(DRIVER_INFO_2 *)malloc(*returned * sizeof(DRIVER_INFO_2))))
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_2(&(driver_info_2[i]), driver, servername, architecture );
-               free_a_printer_driver(driver, 3);
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_2=(DRIVER_INFO_2 *)Realloc(driver_info_2, (*returned+ndrivers) * sizeof(DRIVER_INFO_2))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+               
+               for (i=0; i<ndrivers; i++) {
+                       uint32 status;
+
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
+                               safe_free(list);
+                               return status;
+                       }
+                       fill_printer_driver_info_2(&driver_info_2[*returned+i], driver, servername);            
+                       free_a_printer_driver(driver, 3);
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
        
-       safe_free(list);
-       
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
@@ -3422,29 +4095,56 @@ static uint32 enumprinterdrivers_level2(fstring *list, fstring servername, fstri
 /****************************************************************************
  Enumerates all printer drivers at level 3.
 ****************************************************************************/
-static uint32 enumprinterdrivers_level3(fstring *list, fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
+static uint32 enumprinterdrivers_level3(fstring servername, fstring architecture, NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
        int i;
+       int ndrivers;
+       uint32 version;
+       fstring *list = NULL;
+
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
        DRIVER_INFO_3 *driver_info_3=NULL;
 
-       ZERO_STRUCT(driver);
+       *returned=0;
 
-       if((driver_info_3=(DRIVER_INFO_3 *)malloc((*returned)*sizeof(DRIVER_INFO_3))) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
+#define MAX_VERSION 4
 
-       for (i=0; i<*returned; i++) {
-               get_a_printer_driver(&driver, 3, list[i], architecture);
-               fill_printer_driver_info_3(&(driver_info_3[i]), driver, servername, architecture );
-               free_a_printer_driver(driver, 3);
+       for (version=0; version<MAX_VERSION; version++) {
+               list=NULL;
+               ndrivers=get_ntdrivers(&list, architecture, version);
+               DEBUGADD(4,("we have:[%d] drivers in environment [%s] and version [%d]\n", ndrivers, architecture, version));
+
+               if(ndrivers == -1)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+
+               if(ndrivers != 0) {
+                       if((driver_info_3=(DRIVER_INFO_3 *)Realloc(driver_info_3, (*returned+ndrivers) * sizeof(DRIVER_INFO_3))) == NULL) {
+                               safe_free(list);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+               }
+
+               for (i=0; i<ndrivers; i++) {
+                       uint32 status;
+
+                       DEBUGADD(5,("\tdriver: [%s]\n", list[i]));
+                       ZERO_STRUCT(driver);
+                       if ((status = get_a_printer_driver(&driver, 3, list[i], architecture, version)) != 0) {
+                               safe_free(list);
+                               return status;
+                       }
+                       fill_printer_driver_info_3(&driver_info_3[*returned+i], driver, servername);            
+                       free_a_printer_driver(driver, 3);
+               }       
+
+               *returned+=ndrivers;
+               safe_free(list);
        }
-       
-       safe_free(list);
-       
+
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding driver [%d]'s size\n",i));
-               *needed += spoolss_size_printer_driver_info_3(&(driver_info_3[i]));
+               *needed += spoolss_size_printer_driver_info_3(&driver_info_3[i]);
        }
 
        if (!alloc_buffer_size(buffer, *needed)) {
@@ -3452,10 +4152,10 @@ static uint32 enumprinterdrivers_level3(fstring *list, fstring servername, fstri
                return ERROR_INSUFFICIENT_BUFFER;
        }
        
-       /* fill the buffer with the form structures */
+       /* fill the buffer with the driver structures */
        for (i=0; i<*returned; i++) {
-               DEBUGADD(6,("adding form [%d] to buffer\n",i));
-               new_smb_io_printer_driver_info_3("", buffer, &(driver_info_3[i]), 0);
+               DEBUGADD(6,("adding driver [%d] to buffer\n",i));
+               new_smb_io_printer_driver_info_3("", buffer, &driver_info_3[i], 0);
        }
 
        for (i=0; i<*returned; i++)
@@ -3478,8 +4178,7 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
                                    NEW_BUFFER *buffer, uint32 offered,
                                    uint32 *needed, uint32 *returned)
 {
-       int i;
-       fstring *list;
+       fstring *list = NULL;
        fstring servername;
        fstring architecture;
 
@@ -3489,37 +4188,27 @@ uint32 _spoolss_enumprinterdrivers( UNISTR2 *name, UNISTR2 *environment, uint32
        *returned=0;
 
        unistr2_to_ascii(architecture, environment, sizeof(architecture)-1);
-       *returned=get_ntdrivers(&list, architecture);
 
-       DEBUGADD(4,("we have: [%d] drivers in environment [%s]\n", *returned, architecture));
-       if(*returned == -1)
-               return ERROR_NOT_ENOUGH_MEMORY;
-
-       for (i=0; i<*returned; i++)
-               DEBUGADD(5,("driver: [%s]\n", list[i]));
-       
        switch (level) {
        case 1:
-               return enumprinterdrivers_level1(list, servername, architecture, buffer, offered, needed, returned);
-               break;
+               return enumprinterdrivers_level1(servername, architecture, buffer, offered, needed, returned);
        case 2:
-               return enumprinterdrivers_level2(list, servername, architecture, buffer, offered, needed, returned);
-               break;
+               return enumprinterdrivers_level2(servername, architecture, buffer, offered, needed, returned);
        case 3:
-               return enumprinterdrivers_level3(list, servername, architecture, buffer, offered, needed, returned);
-               break;
+               return enumprinterdrivers_level3(servername, architecture, buffer, offered, needed, returned);
        default:
+               *returned=0;
+               safe_free(list);
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
 /****************************************************************************
 ****************************************************************************/
-static void fill_form_1(FORM_1 *form, nt_forms_struct *list, int position)
+static void fill_form_1(FORM_1 *form, nt_forms_struct *list)
 {
        form->flag=list->flag;
-       init_unistr(&(form->name), list->name);
+       init_unistr(&form->name, list->name);
        form->width=list->width;
        form->length=list->length;
        form->left=list->left;
@@ -3530,7 +4219,7 @@ static void fill_form_1(FORM_1 *form, nt_forms_struct *list, int position)
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level, 
+uint32 _new_spoolss_enumforms( POLICY_HND *handle, uint32 level, 
                               NEW_BUFFER *buffer, uint32 offered, 
                               uint32 *needed, uint32 *numofforms)
 {
@@ -3546,9 +4235,11 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
        *numofforms = get_ntforms(&list);
        DEBUGADD(5,("Number of forms [%d]\n",     *numofforms));
 
+       if (*numofforms == 0) return ERROR_NO_MORE_ITEMS;
+
        switch (level) {
        case 1:
-               if((forms_1=(FORM_1 *)malloc(*numofforms * sizeof(FORM_1))) == NULL) {
+               if ((forms_1=(FORM_1 *)malloc(*numofforms * sizeof(FORM_1))) == NULL) {
                        *numofforms=0;
                        return ERROR_NOT_ENOUGH_MEMORY;
                }
@@ -3556,7 +4247,7 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
                /* construct the list of form structures */
                for (i=0; i<*numofforms; i++) {
                        DEBUGADD(6,("Filling form number [%d]\n",i));
-                       fill_form_1(&(forms_1[i]), &(list[i]), i);
+                       fill_form_1(&forms_1[i], &list[i]);
                }
                
                safe_free(list);
@@ -3564,7 +4255,7 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
                /* check the required size. */
                for (i=0; i<*numofforms; i++) {
                        DEBUGADD(6,("adding form [%d]'s size\n",i));
-                       buffer_size += spoolss_size_form_1(&(forms_1[i]));
+                       buffer_size += spoolss_size_form_1(&forms_1[i]);
                }
 
                *needed=buffer_size;            
@@ -3577,7 +4268,7 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
                /* fill the buffer with the form structures */
                for (i=0; i<*numofforms; i++) {
                        DEBUGADD(6,("adding form [%d] to buffer\n",i));
-                       new_smb_io_form_1("", buffer, &(forms_1[i]), 0);
+                       new_smb_io_form_1("", buffer, &forms_1[i], 0);
                }
 
                safe_free(forms_1);
@@ -3596,20 +4287,83 @@ uint32 _new_spoolss_enumforms( const POLICY_HND *handle, uint32 level,
 
 }
 
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_getform( POLICY_HND *handle, uint32 level, UNISTR2 *uni_formname, NEW_BUFFER *buffer, uint32 offered, uint32 *needed)
+{
+       nt_forms_struct *list=NULL;
+       FORM_1 form_1;
+       fstring form_name;
+       int buffer_size=0;
+       int numofforms, i;
+
+       unistr2_to_ascii(form_name, uni_formname, sizeof(form_name)-1);
+
+       DEBUG(4,("_spoolss_getform\n"));
+       DEBUGADD(5,("Offered buffer size [%d]\n", offered));
+       DEBUGADD(5,("Info level [%d]\n",          level));
+
+       numofforms = get_ntforms(&list);
+       DEBUGADD(5,("Number of forms [%d]\n",     numofforms));
+
+       if (numofforms == 0)
+               return ERROR_NO_MORE_ITEMS;
+
+       switch (level) {
+       case 1:
+
+               /* Check if the requested name is in the list of form structures */
+               for (i=0; i<numofforms; i++) {
+
+                       DEBUG(4,("_spoolss_getform: checking form %s (want %s)\n", list[i].name, form_name));
+
+                       if (strequal(form_name, list[i].name)) {
+                               DEBUGADD(6,("Found form %s number [%d]\n", form_name, i));
+                               fill_form_1(&form_1, &list[i]);
+                               break;
+                       }
+               }
+               
+               safe_free(list);
+
+               /* check the required size. */
+
+               *needed=spoolss_size_form_1(&form_1);
+               
+               if (!alloc_buffer_size(buffer, buffer_size)){
+                       return ERROR_INSUFFICIENT_BUFFER;
+               }
+
+               if (*needed > offered) {
+                       return ERROR_INSUFFICIENT_BUFFER;
+               }
+
+               /* fill the buffer with the form structures */
+               DEBUGADD(6,("adding form %s [%d] to buffer\n", form_name, i));
+               new_smb_io_form_1("", buffer, &form_1, 0);
+
+               return NT_STATUS_NO_PROBLEMO;
+                       
+       default:
+               safe_free(list);
+               return ERROR_INVALID_LEVEL;
+       }
+}
+
 /****************************************************************************
 ****************************************************************************/
 static void fill_port_1(PORT_INFO_1 *port, char *name)
 {
-       init_unistr(&(port->port_name), name);
+       init_unistr(&port->port_name, name);
 }
 
 /****************************************************************************
 ****************************************************************************/
 static void fill_port_2(PORT_INFO_2 *port, char *name)
 {
-       init_unistr(&(port->port_name), name);
-       init_unistr(&(port->monitor_name), "Moniteur Local");
-       init_unistr(&(port->description), "Local Port");
+       init_unistr(&port->port_name, name);
+       init_unistr(&port->monitor_name, "Local Monitor");
+       init_unistr(&port->description, "Local Port");
 #define PORT_TYPE_WRITE 1
        port->port_type=PORT_TYPE_WRITE;
        port->reserved=0x0;     
@@ -3620,31 +4374,75 @@ static void fill_port_2(PORT_INFO_2 *port, char *name)
 ****************************************************************************/
 static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       int n_services=lp_numservices();
-       int snum;
-       int i=0;
-       
        PORT_INFO_1 *ports=NULL;
+       int i=0;
 
-       for (snum=0; snum<n_services; snum++)
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                       (*returned)++;
+       if (*lp_enumports_cmd()) {
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_enumports_cmd();
+               char *path;
+               char **qlines;
+               pstring tmp_file;
+               pstring command;
+               int numlines;
+               int ret;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 1);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               DEBUG(10,("Returned [%d]\n", ret));
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       /* Is this the best error to return here? */
+                       return ERROR_ACCESS_DENIED;
+               }
 
-       if((ports=(PORT_INFO_1 *)malloc( (*returned+1) * sizeof(PORT_INFO_1) )) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
-       for (snum=0; snum<n_services; snum++) {
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
-                       DEBUGADD(6,("Filling port number [%d]\n", i));
-                       fill_port_1(&(ports[i]), lp_servicename(snum));
-                       i++;
+               numlines = 0;
+               qlines = file_lines_load(tmp_file, &numlines);
+               DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+               unlink(tmp_file);
+
+               if(numlines) {
+                       if((ports=(PORT_INFO_1 *)malloc( numlines * sizeof(PORT_INFO_1) )) == NULL) {
+                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               file_lines_free(qlines);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+
+                       for (i=0; i<numlines; i++) {
+                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                               fill_port_1(&ports[i], qlines[i]);
+                       }
+
+                       file_lines_free(qlines);
                }
+
+               *returned = numlines;
+
+       } else {
+               *returned = 1; /* Sole Samba port returned. */
+
+               if((ports=(PORT_INFO_1 *)malloc( sizeof(PORT_INFO_1) )) == NULL)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+       
+               DEBUG(10,("enumports_level_1: port name %s\n", SAMBA_PRINTER_PORT_NAME));
+
+               fill_port_1(&ports[0], SAMBA_PRINTER_PORT_NAME);
        }
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding port [%d]'s size\n", i));
-               *needed += spoolss_size_port_info_1(&(ports[i]));
+               *needed += spoolss_size_port_info_1(&ports[i]);
        }
                
        if (!alloc_buffer_size(buffer, *needed)) {
@@ -3655,7 +4453,7 @@ static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *need
        /* fill the buffer with the ports structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding port [%d] to buffer\n", i));
-               new_smb_io_port_1("", buffer, &(ports[i]), 0);
+               new_smb_io_port_1("", buffer, &ports[i], 0);
        }
 
        safe_free(ports);
@@ -3668,37 +4466,82 @@ static uint32 enumports_level_1(NEW_BUFFER *buffer, uint32 offered, uint32 *need
                return NT_STATUS_NO_PROBLEMO;
 }
 
-
 /****************************************************************************
  enumports level 2.
 ****************************************************************************/
+
 static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *needed, uint32 *returned)
 {
-       int n_services=lp_numservices();
-       int snum;
-       int i=0;
-       
        PORT_INFO_2 *ports=NULL;
+       int i=0;
 
-       for (snum=0; snum<n_services; snum++)
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) )
-                       (*returned)++;
+       if (*lp_enumports_cmd()) {
+               pid_t local_pid = sys_getpid();
+               char *cmd = lp_enumports_cmd();
+               char *path;
+               char **qlines;
+               pstring tmp_file;
+               pstring command;
+               int numlines;
+               int ret;
+
+               if (*lp_pathname(lp_servicenumber(PRINTERS_NAME)))
+                       path = lp_pathname(lp_servicenumber(PRINTERS_NAME));
+               else
+                       path = tmpdir();
+
+               slprintf(tmp_file, sizeof(tmp_file), "%s/smbcmd.%d", path, local_pid);
+               slprintf(command, sizeof(command), "%s \"%d\"", cmd, 2);
+
+               unlink(tmp_file);
+               DEBUG(10,("Running [%s > %s]\n", command,tmp_file));
+               ret = smbrun(command, tmp_file, False);
+               DEBUGADD(10,("returned [%d]\n", ret));
+               if (ret != 0) {
+                       unlink(tmp_file);
+                       /* Is this the best error to return here? */
+                       return ERROR_ACCESS_DENIED;
+               }
 
-       if((ports=(PORT_INFO_2 *)malloc( (*returned+1) * sizeof(PORT_INFO_2) )) == NULL)
-               return ERROR_NOT_ENOUGH_MEMORY;
-       
-       for (snum=0; snum<n_services; snum++) {
-               if ( lp_browseable(snum) && lp_snum_ok(snum) && lp_print_ok(snum) ) {
-                       DEBUGADD(6,("Filling port number [%d]\n", i));
-                       fill_port_2(&(ports[i]), lp_servicename(snum));
-                       i++;
+               numlines = 0;
+               qlines = file_lines_load(tmp_file, &numlines);
+               DEBUGADD(10,("Lines returned = [%d]\n", numlines));
+               DEBUGADD(10,("Unlinking port file [%s]\n", tmp_file));
+               unlink(tmp_file);
+
+               if(numlines) {
+                       if((ports=(PORT_INFO_2 *)malloc( numlines * sizeof(PORT_INFO_2) )) == NULL) {
+                               DEBUG(10,("Returning ERROR_NOT_ENOUGH_MEMORY [%x]\n", ERROR_NOT_ENOUGH_MEMORY));
+                               file_lines_free(qlines);
+                               return ERROR_NOT_ENOUGH_MEMORY;
+                       }
+
+                       for (i=0; i<numlines; i++) {
+                               DEBUG(6,("Filling port number [%d] with port [%s]\n", i, qlines[i]));
+                               fill_port_2(&(ports[i]), qlines[i]);
+                       }
+
+                       file_lines_free(qlines);
                }
+
+               *returned = numlines;
+
+       } else {
+
+               *returned = 1;
+
+               if((ports=(PORT_INFO_2 *)malloc( sizeof(PORT_INFO_2) )) == NULL)
+                       return ERROR_NOT_ENOUGH_MEMORY;
+       
+               DEBUG(10,("enumports_level_2: port name %s\n", SAMBA_PRINTER_PORT_NAME));
+
+               fill_port_2(&ports[0], SAMBA_PRINTER_PORT_NAME);
        }
 
        /* check the required size. */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding port [%d]'s size\n", i));
-               *needed += spoolss_size_port_info_2(&(ports[i]));
+               *needed += spoolss_size_port_info_2(&ports[i]);
        }
                
        if (!alloc_buffer_size(buffer, *needed)) {
@@ -3709,7 +4552,7 @@ static uint32 enumports_level_2(NEW_BUFFER *buffer, uint32 offered, uint32 *need
        /* fill the buffer with the ports structures */
        for (i=0; i<*returned; i++) {
                DEBUGADD(6,("adding port [%d] to buffer\n", i));
-               new_smb_io_port_2("", buffer, &(ports[i]), 0);
+               new_smb_io_port_2("", buffer, &ports[i], 0);
        }
 
        safe_free(ports);
@@ -3737,13 +4580,10 @@ uint32 _spoolss_enumports( UNISTR2 *name, uint32 level,
        switch (level) {
        case 1:
                return enumports_level_1(buffer, offered, needed, returned);
-               break;
        case 2:
                return enumports_level_2(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -3755,41 +4595,66 @@ static uint32 spoolss_addprinterex_level_2( const UNISTR2 *uni_srv_name,
                                uint32 user_switch, const SPOOL_USER_CTR *user,
                                POLICY_HND *handle)
 {
-       NT_PRINTER_INFO_LEVEL printer;  
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        fstring name;
-       fstring share_name;
+       int snum;
 
-       clear_handle(handle);
-       
-       /* NULLify info_2 here */
-       /* don't put it in convert_printer_info as it's used also with non-NULL values */
-       printer.info_2=NULL;
+       if ((printer = (NT_PRINTER_INFO_LEVEL *)malloc(sizeof(NT_PRINTER_INFO_LEVEL))) == NULL) {
+               DEBUG(0,("spoolss_addprinterex_level_2: malloc fail.\n"));
+               return ERROR_NOT_ENOUGH_MEMORY;
+       }
 
-       /* convert from UNICODE to ASCII */
-       convert_printer_info(info, &printer, 2);
+       ZERO_STRUCTP(printer);
 
-       unistr2_to_ascii(share_name, &((info->info_2)->printername), sizeof(share_name)-1);
-       
-       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname, share_name);
+       /* convert from UNICODE to ASCII - this allocates the info_2 struct inside *printer.*/
+       convert_printer_info(info, printer, 2);
 
-       /* write the ASCII on disk */
-       if (add_a_printer(printer, 2) != 0x0)
+       if (*lp_addprinter_cmd() )
+               if ( !add_printer_hook(printer) ) {
+                       free_a_printer(&printer,2);
+                       return ERROR_ACCESS_DENIED;
+       }
+
+       slprintf(name, sizeof(name)-1, "\\\\%s\\%s", global_myname,
+             printer->info_2->sharename);
+
+       if ((snum = print_queue_snum(printer->info_2->sharename)) == -1) {
+               free_a_printer(&printer,2);
                return ERROR_ACCESS_DENIED;
+       }
 
-       create_printer_hnd(handle);
+       /* you must be a printer admin to add a new printer */
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               free_a_printer(&printer,2);
+               return ERROR_ACCESS_DENIED;             
+       }
+       
+       /*
+        * Do sanity check on the requested changes for Samba.
+        */
 
-       open_printer_hnd(handle);
+       if (!check_printer_ok(printer->info_2, snum)) {
+               free_a_printer(&printer,2);
+               return ERROR_INVALID_PARAMETER;
+       }
 
-       if (!set_printer_hnd_printertype(handle, name)) {
-               close_printer_handle(handle);
+       /* write the ASCII on disk */
+       if (add_a_printer(*printer, 2) != 0) {
+               free_a_printer(&printer,2);
                return ERROR_ACCESS_DENIED;
        }
 
-       if (!set_printer_hnd_printername(handle, name)) {
-               close_printer_handle(handle);
+       if (!open_printer_hnd(handle, name)) {
+               /* Handle open failed - remove addition. */
+               del_a_printer(printer->info_2->sharename);
+               free_a_printer(&printer,2);
                return ERROR_ACCESS_DENIED;
        }
 
+       free_a_printer(&printer,2);
+
+       srv_spoolss_sendnotify(handle);
+
        return NT_STATUS_NO_PROBLEMO;
 }
 
@@ -3806,93 +4671,55 @@ uint32 _spoolss_addprinterex( const UNISTR2 *uni_srv_name, uint32 level,
                        /* we don't handle yet */
                        /* but I know what to do ... */
                        return ERROR_INVALID_LEVEL;
-                       break;
                case 2:
                        return spoolss_addprinterex_level_2(uni_srv_name, info, 
                                                            unk0, unk1, unk2, unk3,
                                                            user_switch, user, handle);
-                       break;
                default:
                        return ERROR_INVALID_LEVEL;
-                       break;
        }
 }
 
-/****************************************************************************
- Modify internal driver heirarchy.
-****************************************************************************/
-
-static uint32 modify_driver_heirarchy(NT_PRINTER_DRIVER_INFO_LEVEL *driver, uint32 level)
-{
-       pstring path_old;
-       pstring path_new;
-       pstring short_archi;
-       int snum = find_service("print$");
-       char *model = NULL;
-
-       *short_archi = '\0';
-       switch (level) {
-               case 3:
-                       get_short_archi(short_archi, driver->info_3->environment);
-                       model = driver->info_3->name;
-                       break;
-               case 6:
-                       get_short_archi(short_archi, driver->info_6->environment);
-                       model = driver->info_6->name;
-                       break;
-               default:
-                       DEBUG(0,("modify_driver_heirarchy: unknown info level (%d)\n", level));
-                       return ERROR_INVALID_LEVEL;
-                       break;
-       }
-
-       slprintf(path_old, sizeof(path_old)-1, "%s/%s/TMP_%u", lp_pathname(snum), short_archi,
-               (unsigned int)sys_getpid());
-       slprintf(path_new, sizeof(path_new)-1, "%s/%s/%s", lp_pathname(snum), short_archi, model);
-
-       DEBUG(10,("_spoolss_addprinterdriver: old_path=%s, new_path=%s\n",
-                       path_old, path_new ));
-       if (dos_rename(path_old, path_new) == -1) {
-               DEBUG(0,("modify_driver_heirarchy: rename failed (%s)\n", strerror(errno) ));
-               /* We need to clean up here.... - how ? */
-               return ERROR_ACCESS_DENIED; /* We need a generic mapping from NT errors here... */
-       }
-
-       return NT_STATUS_NO_PROBLEMO;
-}
-
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addprinterdriver( const UNISTR2 *server_name,
-                               uint32 level,
-                               const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
+uint32 _spoolss_addprinterdriver(pipes_struct *p, const UNISTR2 *server_name,
+                                uint32 level, const SPOOL_PRINTER_DRIVER_INFO_LEVEL *info)
 {
+       uint32 err = NT_STATUS_NO_PROBLEMO;
        NT_PRINTER_DRIVER_INFO_LEVEL driver;
-       uint32 err;
+       struct current_user user;
+       
        ZERO_STRUCT(driver);
+
+       get_current_user(&user, p);     
        
        convert_printer_driver_info(info, &driver, level);
 
-       if (add_a_printer_driver(driver, level)!=0)
-               return ERROR_ACCESS_DENIED;
+       DEBUG(5,("Cleaning driver's information\n"));
+       clean_up_driver_struct(driver, level);
 
-       if ((err = modify_driver_heirarchy(&driver, level)) != 0) {
-               safe_free(driver.info_3);
-               safe_free(driver.info_6);
-               return err;
+       DEBUG(5,("Moving driver to final destination\n"));
+       if(!move_driver_to_download_area(driver, level, &user, &err)) {
+               if (err == 0)
+                       err = ERROR_ACCESS_DENIED;
+               goto done;
        }
 
-       safe_free(driver.info_3);
-       safe_free(driver.info_6);
+       if (add_a_printer_driver(driver, level)!=0) {
+               err = ERROR_ACCESS_DENIED;
+               goto done;
+       }
 
-       return NT_STATUS_NO_PROBLEMO;
+ done:
+       free_a_printer_driver(driver, level);
+       return err;
 }
 
 /****************************************************************************
 ****************************************************************************/
 static void fill_driverdir_1(DRIVER_DIRECTORY_1 *info, char *name)
 {
-       init_unistr(&(info->name), name);
+       init_unistr(&info->name, name);
 }
 
 /****************************************************************************
@@ -3903,15 +4730,17 @@ static uint32 getprinterdriverdir_level_1(UNISTR2 *name, UNISTR2 *uni_environmen
        pstring long_archi;
        pstring short_archi;
        DRIVER_DIRECTORY_1 *info=NULL;
-       
+
+       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
+
+       if (get_short_archi(short_archi, long_archi)==FALSE)
+               return ERROR_INVALID_ENVIRONMENT;
+
        if((info=(DRIVER_DIRECTORY_1 *)malloc(sizeof(DRIVER_DIRECTORY_1))) == NULL)
                return ERROR_NOT_ENOUGH_MEMORY;
-       
-       unistr2_to_ascii(long_archi, uni_environment, sizeof(long_archi)-1);
-       get_short_archi(short_archi, long_archi);
-               
-       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s\\TMP_%u", global_myname, short_archi,
-               (unsigned int)sys_getpid());
+
+       slprintf(path, sizeof(path)-1, "\\\\%s\\print$\\%s", global_myname, short_archi);
+
        DEBUG(4,("printer driver directory: [%s]\n", path));
 
        fill_driverdir_1(info, path);
@@ -3946,22 +4775,20 @@ uint32 _spoolss_getprinterdriverdirectory(UNISTR2 *name, UNISTR2 *uni_environmen
        switch(level) {
        case 1:
                return getprinterdriverdir_level_1(name, uni_environment, buffer, offered, needed);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
        
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
+uint32 _spoolss_enumprinterdata(POLICY_HND *handle, uint32 idx,
                                uint32 in_value_len, uint32 in_data_len,
                                uint32 *out_max_value_len, uint16 **out_value, uint32 *out_value_len,
                                uint32 *out_type,
                                uint32 *out_max_data_len, uint8  **data_out, uint32 *out_data_len)
 {
-       NT_PRINTER_INFO_LEVEL printer;
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
        
        fstring value;
        
@@ -3988,13 +4815,15 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
 
        DEBUG(5,("spoolss_enumprinterdata\n"));
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_enumprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        if (!get_printer_snum(handle, &snum))
                return ERROR_INVALID_HANDLE;
        
-       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0x0)
+       if (get_a_printer(&printer, 2, lp_servicename(snum)) != 0)
                return ERROR_INVALID_HANDLE;
 
        /* 
@@ -4004,28 +4833,61 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
         */
        if ( (in_value_len==0) && (in_data_len==0) ) {
                DEBUGADD(6,("Activating NT mega-hack to find sizes\n"));
-               
+
+#if 0
+               /*
+                * NT can ask for a specific parameter size - we need to return NO_MORE_ITEMS
+                * if this parameter size doesn't exist.
+                * Ok - my opinion here is that the client is not asking for the greatest
+                * possible size of all the parameters, but is asking specifically for the size needed
+                * for this specific parameter. In that case we can remove the loop below and
+                * simplify this lookup code considerably. JF - comments welcome. JRA.
+                */
+
+               if (!get_specific_param_by_index(*printer, 2, idx, value, &data, &type, &data_len)) {
+                       safe_free(data);
+                       free_a_printer(&printer, 2);
+                       return ERROR_NO_MORE_ITEMS;
+               }
+#endif
+
+               safe_free(data);
+               data = NULL;
+
                param_index=0;
                biggest_valuesize=0;
                biggest_datasize=0;
                
-               while (get_specific_param_by_index(printer, 2, param_index, value, &data, &type, &data_len)) {
+               while (get_specific_param_by_index(*printer, 2, param_index, value, &data, &type, &data_len)) {
                        if (strlen(value) > biggest_valuesize) biggest_valuesize=strlen(value);
                        if (data_len > biggest_datasize) biggest_datasize=data_len;
 
                        DEBUG(6,("current values: [%d], [%d]\n", biggest_valuesize, biggest_datasize));
 
                        safe_free(data);
+                       data = NULL;
                        param_index++;
                }
 
+               /*
+                * I think this is correct, it doesn't break APW and
+                * allows Gerald's Win32 test programs to work correctly,
+                * but may need altering.... JRA.
+                */
+
+               if (param_index == 0) {
+                       /* No parameters found. */
+                       free_a_printer(&printer, 2);
+                       return ERROR_NO_MORE_ITEMS;
+               }
+
                /* the value is an UNICODE string but realvaluesize is the length in bytes including the leading 0 */
                *out_value_len=2*(1+biggest_valuesize);
                *out_data_len=biggest_datasize;
 
                DEBUG(6,("final values: [%d], [%d]\n", *out_value_len, *out_data_len));
 
-               free_a_printer(printer, 2);             
+               free_a_printer(&printer, 2);
                return NT_STATUS_NO_PROBLEMO;
        }
        
@@ -4034,12 +4896,14 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
         * that's the number of bytes not the number of unicode chars
         */
 
-       if (!get_specific_param_by_index(printer, 2, idx, value, &data, &type, &data_len)) {
-               free_a_printer(printer, 2);
+       if (!get_specific_param_by_index(*printer, 2, idx, value, &data, &type, &data_len)) {
                safe_free(data);
+               free_a_printer(&printer, 2);
                return ERROR_NO_MORE_ITEMS;
        }
 
+       free_a_printer(&printer, 2);
+
        /* 
         * the value is:
         * - counted in bytes in the request
@@ -4049,36 +4913,36 @@ uint32 _spoolss_enumprinterdata(const POLICY_HND *handle, uint32 idx,
         * take a pause *before* coding not *during* coding
         */
         
-       *out_max_value_len=in_value_len;
+       *out_max_value_len=(in_value_len/sizeof(uint16));
        if((*out_value=(uint16 *)malloc(in_value_len*sizeof(uint8))) == NULL) {
-               free_a_printer(printer, 2);
                safe_free(data);
                return ERROR_NOT_ENOUGH_MEMORY;
        }
-       ascii_to_unistr((char *)*out_value, value, *out_max_value_len);
-       *out_value_len=2*(1+strlen(value));
+       
+       ZERO_STRUCTP(*out_value);
+       *out_value_len = (uint32)dos_PutUniCode((char *)*out_value, value, in_value_len, True);
 
        *out_type=type;
 
        /* the data is counted in bytes */
        *out_max_data_len=in_data_len;
        if((*data_out=(uint8 *)malloc(in_data_len*sizeof(uint8))) == NULL) {
-               free_a_printer(printer, 2);
                safe_free(data);
                return ERROR_NOT_ENOUGH_MEMORY;
        }
-       memcpy(*data_out, data, data_len);
+       
+       ZERO_STRUCTP(*data_out);
+       memcpy(*data_out, data, (size_t)data_len);
        *out_data_len=data_len;
 
        safe_free(data);
        
-       free_a_printer(printer, 2);
        return NT_STATUS_NO_PROBLEMO;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
+uint32 _spoolss_setprinterdata( POLICY_HND *handle,
                                const UNISTR2 *value,
                                uint32 type,
                                uint32 max_len,
@@ -4086,9 +4950,8 @@ uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
                                uint32 real_len,
                                uint32 numeric_data)
 {
-       NT_PRINTER_INFO_LEVEL printer;
-       NT_PRINTER_PARAM *param = NULL;
-               
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_PRINTER_PARAM *param = NULL;         
        int snum=0;
        uint32 status = 0x0;
        Printer_entry *Printer=find_printer_index_by_hnd(handle);
@@ -4096,32 +4959,81 @@ uint32 _spoolss_setprinterdata( const POLICY_HND *handle,
        DEBUG(5,("spoolss_setprinterdata\n"));
 
        
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_setprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        if (!get_printer_snum(handle, &snum))
                return ERROR_INVALID_HANDLE;
 
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("security descriptor change denied by existing "
+                         "security descriptor\n"));
+               return ERROR_ACCESS_DENIED;
+       }
+
        status = get_a_printer(&printer, 2, lp_servicename(snum));
        if (status != 0x0)
                return ERROR_INVALID_NAME;
 
        convert_specific_param(&param, value , type, data, real_len);
-       unlink_specific_param_if_exist(printer.info_2, param);
+       unlink_specific_param_if_exist(printer->info_2, param);
        
-       if (!add_a_specific_param(printer.info_2, param))
+       if (!add_a_specific_param(printer->info_2, param))
                status = ERROR_INVALID_PARAMETER;
        else
-               status = add_a_printer(printer, 2);
+               status = add_a_printer(*printer, 2);
+
+       free_a_printer(&printer, 2);
+       return status;
+}
 
-       free_a_printer(printer, 2);
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_deleteprinterdata( POLICY_HND *handle, const UNISTR2 *value)
+{
+       NT_PRINTER_INFO_LEVEL *printer = NULL;
+       NT_PRINTER_PARAM param;
+       int snum=0;
+       uint32 status = 0x0;
+       Printer_entry *Printer=find_printer_index_by_hnd(handle);
        
+       DEBUG(5,("spoolss_deleteprinterdata\n"));
+       
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_deleteprinterdata: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return ERROR_INVALID_HANDLE;
+       }
+
+       if (!get_printer_snum(handle, &snum))
+               return ERROR_INVALID_HANDLE;
+
+       if (!print_access_check(NULL, snum, PRINTER_ACCESS_ADMINISTER)) {
+               DEBUG(3, ("_spoolss_deleteprinterdata: security descriptor change denied by existing "
+                         "security descriptor\n"));
+               return ERROR_ACCESS_DENIED;
+       }
+
+       status = get_a_printer(&printer, 2, lp_servicename(snum));
+       if (status != 0x0)
+               return ERROR_INVALID_NAME;
+
+       ZERO_STRUCTP(&param);
+       unistr2_to_ascii(param.value, value, sizeof(param.value)-1);
+
+       if(!unlink_specific_param_if_exist(printer->info_2, &param))
+               status = ERROR_INVALID_PARAMETER;
+       else
+               status = add_a_printer(*printer, 2);
+
+       free_a_printer(&printer, 2);
        return status;
 }
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_addform( const POLICY_HND *handle,
+uint32 _spoolss_addform( POLICY_HND *handle,
                                uint32 level,
                                const FORM *form)
 {
@@ -4131,8 +5043,10 @@ uint32 _spoolss_addform( const POLICY_HND *handle,
 
        DEBUG(5,("spoolss_addform\n"));
 
-       if (!OPEN_HANDLE(Printer))
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_addform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
+       }
 
        count=get_ntforms(&list);
        if(!add_a_form(&list, form, &count))
@@ -4146,7 +5060,32 @@ uint32 _spoolss_addform( const POLICY_HND *handle,
 
 /****************************************************************************
 ****************************************************************************/
-uint32 _spoolss_setform( const POLICY_HND *handle,
+uint32 _spoolss_deleteform( POLICY_HND *handle, UNISTR2 *form_name)
+{
+       int count=0;
+       uint32 ret = 0;
+       nt_forms_struct *list=NULL;
+       Printer_entry *Printer = find_printer_index_by_hnd(handle);
+
+       DEBUG(5,("spoolss_deleteform\n"));
+
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_deleteform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
+               return ERROR_INVALID_HANDLE;
+       }
+
+       count = get_ntforms(&list);
+       if(!delete_a_form(&list, form_name, &count, &ret))
+               return ERROR_INVALID_PARAMETER;
+
+       safe_free(list);
+
+       return ret;
+}
+
+/****************************************************************************
+****************************************************************************/
+uint32 _spoolss_setform( POLICY_HND *handle,
                                const UNISTR2 *uni_name,
                                uint32 level,
                                const FORM *form)
@@ -4157,8 +5096,8 @@ uint32 _spoolss_setform( const POLICY_HND *handle,
 
        DEBUG(5,("spoolss_setform\n"));
 
-       if (!OPEN_HANDLE(Printer))
-       {
+       if (!OPEN_HANDLE(Printer)) {
+               DEBUG(0,("_spoolss_setform: Invalid handle (%s).\n", OUR_HANDLE(handle)));
                return ERROR_INVALID_HANDLE;
        }
        count=get_ntforms(&list);
@@ -4182,7 +5121,7 @@ static uint32 enumprintprocessors_level_1(NEW_BUFFER *buffer, uint32 offered, ui
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "winprint");
+       init_unistr(&info_1->name, "winprint");
 
        *needed += spoolss_size_printprocessor_info_1(info_1);
 
@@ -4222,10 +5161,8 @@ uint32 _spoolss_enumprintprocessors(UNISTR2 *name, UNISTR2 *environment, uint32
        switch (level) {
        case 1:
                return enumprintprocessors_level_1(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4241,7 +5178,7 @@ static uint32 enumprintprocdatatypes_level_1(NEW_BUFFER *buffer, uint32 offered,
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "RAW");
+       init_unistr(&info_1->name, "RAW");
 
        *needed += spoolss_size_printprocdatatype_info_1(info_1);
 
@@ -4274,10 +5211,8 @@ uint32 _spoolss_enumprintprocdatatypes(UNISTR2 *name, UNISTR2 *processor, uint32
        switch (level) {
        case 1:
                return enumprintprocdatatypes_level_1(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4293,7 +5228,7 @@ static uint32 enumprintmonitors_level_1(NEW_BUFFER *buffer, uint32 offered, uint
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_1->name), "Local Port");
+       init_unistr(&info_1->name, "Local Port");
 
        *needed += spoolss_size_printmonitor_info_1(info_1);
 
@@ -4324,9 +5259,9 @@ static uint32 enumprintmonitors_level_2(NEW_BUFFER *buffer, uint32 offered, uint
 
        (*returned) = 0x1;
        
-       init_unistr(&(info_2->name), "Local Port");
-       init_unistr(&(info_2->environment), "Windows NT X86");
-       init_unistr(&(info_2->dll_name), "localmon.dll");
+       init_unistr(&info_2->name, "Local Port");
+       init_unistr(&info_2->environment, "Windows NT X86");
+       init_unistr(&info_2->dll_name, "localmon.dll");
 
        *needed += spoolss_size_printmonitor_info_2(info_2);
 
@@ -4366,13 +5301,10 @@ uint32 _spoolss_enumprintmonitors(UNISTR2 *name,uint32 level,
        switch (level) {
        case 1:
                return enumprintmonitors_level_1(buffer, offered, needed, returned);
-               break;          
        case 2:
                return enumprintmonitors_level_2(buffer, offered, needed, returned);
-               break;
        default:
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 
@@ -4431,9 +5363,11 @@ static uint32 getjob_level_2(print_queue_struct *queue, int count, int snum, uin
 {
        int i=0;
        BOOL found=False;
-       JOB_INFO_2 *info_2=NULL;
+       JOB_INFO_2 *info_2;
        info_2=(JOB_INFO_2 *)malloc(sizeof(JOB_INFO_2));
 
+       ZERO_STRUCTP(info_2);
+
        if (info_2 == NULL) {
                safe_free(queue);
                return ERROR_NOT_ENOUGH_MEMORY;
@@ -4464,6 +5398,7 @@ static uint32 getjob_level_2(print_queue_struct *queue, int count, int snum, uin
 
        new_smb_io_job_info_2("", buffer, info_2, 0);
 
+       free_dev_mode(info_2->devmode);
        safe_free(info_2);
 
        if (*needed > offered)
@@ -4500,15 +5435,11 @@ uint32 _spoolss_getjob( POLICY_HND *handle, uint32 jobid, uint32 level,
        switch (level) {
        case 1:
                return getjob_level_1(queue, count, snum, jobid, buffer, offered, needed);
-               break;
        case 2:
                return getjob_level_2(queue, count, snum, jobid, buffer, offered, needed);
-               break;
        default:
                safe_free(queue);
                return ERROR_INVALID_LEVEL;
-               break;
        }
 }
 #undef OLD_NTDOMAIN
-