r7016: - added smb.conf parm 'web tls = true/false'
[samba.git] / source / param / loadparm.c
index 978d86a9a3ada1093c724b049b3d8ee48c887946..10660ffde72c3b013cc2f1cafe59420e1f1882fd 100644 (file)
  */
 
 #include "includes.h"
+#include "version.h"
 #include "dynconfig.h"
 #include "system/time.h"
 #include "system/iconv.h"
 #include "system/network.h"
 #include "system/printing.h"
 #include "librpc/gen_ndr/ndr_svcctl.h"
+#include "librpc/gen_ndr/ndr_samr.h"
+#include "librpc/gen_ndr/ndr_nbt.h"
 #include "dlinklist.h"
+#include "param/loadparm.h"
 
 BOOL in_client = False;                /* Not in the client by default */
 static BOOL bLoaded = False;
@@ -99,40 +103,6 @@ static BOOL defaults_saved = False;
 #define FLAG_CMDLINE    0x8000 /* this option was set from the command line */
 
 
-/* the following are used by loadparm for option lists */
-typedef enum
-{
-  P_BOOL,P_BOOLREV,P_CHAR,P_INTEGER,P_OCTAL,P_LIST,
-  P_STRING,P_USTRING,P_ENUM,P_SEP
-} parm_type;
-
-typedef enum
-{
-  P_LOCAL,P_GLOBAL,P_SEPARATOR,P_NONE
-} parm_class;
-
-struct enum_list {
-       int value;
-       const char *name;
-};
-
-struct parm_struct
-{
-       const char *label;
-       parm_type type;
-       parm_class class;
-       void *ptr;
-       BOOL (*special)(const char *, char **);
-       const struct enum_list *enum_list;
-       uint_t flags;
-       union {
-               BOOL bvalue;
-               int ivalue;
-               char *svalue;
-               char cvalue;
-               char **lvalue;
-       } def;
-};
 
 
 struct param_opt {
@@ -167,9 +137,10 @@ typedef struct
        char *szSMBPasswdFile;
        char *szSAM_URL;
        char *szSPOOLSS_URL;
+       char *szWINS_URL;
        char *szPrivateDir;
        char **szPreloadModules;
-       char *szPasswordServer;
+       char **szPasswordServers;
        char *szSocketOptions;
        char *szRealm;
        char *szADSserver;
@@ -188,7 +159,7 @@ typedef struct
        char **szNetbiosAliases;
        char *szNetbiosScope;
        char *szDomainOtherSIDs;
-       char *szNameResolveOrder;
+       char **szNameResolveOrder;
        char *szPanicAction;
        char *szAddUserScript; 
        char *szAddMachineScript;
@@ -207,6 +178,12 @@ typedef struct
        BOOL bWinbindUseDefaultDomain;
        char *szIDMapBackend;
        char *szGuestaccount;
+       char *swat_directory;
+       BOOL web_tls;
+       char *web_keyfile;
+       char *web_certfile;
+       char *web_cafile;
+       char *web_crlfile;
        int max_mux;
        int max_xmit;
        int pwordlevel;
@@ -231,6 +208,10 @@ typedef struct
        int winbind_cache_time;
        int iLockSpinCount;
        int iLockSpinTime;
+       int nbt_port;
+       int dgram_port;
+       int cldap_port;
+       int web_port;
        char *socket_options;
        BOOL bDNSproxy;
        BOOL bWINSsupport;
@@ -538,7 +519,7 @@ static struct parm_struct parm_table[] = {
        {"path", P_STRING, P_LOCAL, &sDefault.szPath, NULL, NULL, FLAG_BASIC | FLAG_ADVANCED | FLAG_SHARE | FLAG_PRINT | FLAG_DEVELOPER},
        {"directory", P_STRING, P_LOCAL, &sDefault.szPath, NULL, NULL, FLAG_HIDE},
        {"workgroup", P_USTRING, P_GLOBAL, &Globals.szWorkgroup, NULL, NULL, FLAG_BASIC | FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
-       {"realm", P_USTRING, P_GLOBAL, &Globals.szRealm, NULL, NULL, FLAG_BASIC | FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
+       {"realm", P_STRING, P_GLOBAL, &Globals.szRealm, NULL, NULL, FLAG_BASIC | FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
        {"ADS server", P_STRING, P_GLOBAL, &Globals.szADSserver, NULL, NULL, FLAG_BASIC | FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
        {"netbios name", P_USTRING, P_GLOBAL, &Globals.szNetbiosName, NULL, NULL, FLAG_BASIC | FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
        {"netbios aliases", P_LIST, P_GLOBAL, &Globals.szNetbiosAliases, NULL, NULL, FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
@@ -560,10 +541,11 @@ static struct parm_struct parm_table[] = {
        {"idmap backend", P_STRING, P_GLOBAL, &Globals.szIDMapBackend, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"null passwords", P_BOOL, P_GLOBAL, &Globals.bNullPasswords, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"obey pam restrictions", P_BOOL, P_GLOBAL, &Globals.bObeyPamRestrictions, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
-       {"password server", P_STRING, P_GLOBAL, &Globals.szPasswordServer, NULL, NULL, FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
+       {"password server", P_LIST, P_GLOBAL, &Globals.szPasswordServers, NULL, NULL, FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
        {"smb passwd file", P_STRING, P_GLOBAL, &Globals.szSMBPasswdFile, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"sam database", P_STRING, P_GLOBAL, &Globals.szSAM_URL, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"spoolss database", P_STRING, P_GLOBAL, &Globals.szSPOOLSS_URL, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"wins database", P_STRING, P_GLOBAL, &Globals.szWINS_URL, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"private dir", P_STRING, P_GLOBAL, &Globals.szPrivateDir, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"non unix account range", P_STRING, P_GLOBAL, &Globals.szNonUnixAccountRange, handle_non_unix_account_range, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"root directory", P_STRING, P_GLOBAL, &Globals.szRootdir, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
@@ -610,6 +592,16 @@ static struct parm_struct parm_table[] = {
        {"Protocol Options", P_SEP, P_SEPARATOR},
        
        {"smb ports", P_LIST, P_GLOBAL, &Globals.smb_ports, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"nbt port", P_INTEGER, P_GLOBAL, &Globals.nbt_port, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"dgram port", P_INTEGER, P_GLOBAL, &Globals.dgram_port, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"cldap port", P_INTEGER, P_GLOBAL, &Globals.cldap_port, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"web port", P_INTEGER, P_GLOBAL, &Globals.web_port, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"web tls", P_BOOL, P_GLOBAL, &Globals.web_tls, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"web tls keyfile", P_STRING, P_GLOBAL, &Globals.web_keyfile, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"web tls certfile", P_STRING, P_GLOBAL, &Globals.web_certfile, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"web tls cafile", P_STRING, P_GLOBAL, &Globals.web_cafile, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"web tls crlfile", P_STRING, P_GLOBAL, &Globals.web_crlfile, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
+       {"swat directory", P_STRING, P_GLOBAL, &Globals.swat_directory, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"large readwrite", P_BOOL, P_GLOBAL, &Globals.bLargeReadwrite, NULL, NULL, FLAG_DEVELOPER},
        {"max protocol", P_ENUM, P_GLOBAL, &Globals.maxprotocol, NULL, enum_protocol, FLAG_DEVELOPER},
        {"min protocol", P_ENUM, P_GLOBAL, &Globals.minprotocol, NULL, enum_protocol, FLAG_DEVELOPER},
@@ -625,7 +617,7 @@ static struct parm_struct parm_table[] = {
        {"max mux", P_INTEGER, P_GLOBAL, &Globals.max_mux, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"max xmit", P_INTEGER, P_GLOBAL, &Globals.max_xmit, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
 
-       {"name resolve order", P_STRING, P_GLOBAL, &Globals.szNameResolveOrder, NULL, NULL, FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
+       {"name resolve order", P_LIST, P_GLOBAL, &Globals.szNameResolveOrder, NULL, NULL, FLAG_ADVANCED | FLAG_WIZARD | FLAG_DEVELOPER},
        {"max ttl", P_INTEGER, P_GLOBAL, &Globals.max_ttl, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER}, 
        {"max wins ttl", P_INTEGER, P_GLOBAL, &Globals.max_wins_ttl, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
        {"min wins ttl", P_INTEGER, P_GLOBAL, &Globals.min_wins_ttl, NULL, NULL, FLAG_ADVANCED | FLAG_DEVELOPER},
@@ -895,6 +887,7 @@ static void init_printer_values(void)
 static void init_globals(void)
 {
        int i;
+       char *myname;
 
        DEBUG(3, ("Initialising global parameters\n"));
 
@@ -913,7 +906,9 @@ static void init_globals(void)
        do_parameter("socket options", "TCP_NODELAY");
 #endif
        do_parameter("workgroup", DEFAULT_WORKGROUP);
-       do_parameter("netbios name", get_myname());
+       myname = get_myname();
+       do_parameter("netbios name", myname);
+       SAFE_FREE(myname);
        do_parameter("max protocol", "NT1");
        do_parameter("name resolve order", "lmhosts wins host bcast");
 
@@ -921,14 +916,17 @@ static void init_globals(void)
 
        do_parameter("fstype", FSTYPE_STRING);
        do_parameter("ntvfs handler", "unixuid default");
+       do_parameter("max connections", "-1");
 
-       do_parameter("dcerpc endpoint servers", "epmapper srvsvc wkssvc rpcecho samr netlogon lsarpc spoolss drsuapi winreg IOXIDResolver IRemoteActivation");
-       do_parameter("server services", "smb rpc");
-       do_parameter("auth methods", "guest sam_ignoredomain");
+       do_parameter("dcerpc endpoint servers", "epmapper srvsvc wkssvc rpcecho samr netlogon lsarpc spoolss drsuapi winreg dssetup");
+       do_parameter("server services", "smb rpc nbt ldap cldap web");
+       do_parameter("auth methods", "anonymous sam_ignoredomain");
        do_parameter("smb passwd file", dyn_SMB_PASSWD_FILE);
        do_parameter("private dir", dyn_PRIVATE_DIR);
        do_parameter_var("sam database", "tdb://%s/sam.ldb", dyn_PRIVATE_DIR);
        do_parameter_var("spoolss database", "tdb://%s/spoolss.ldb", dyn_PRIVATE_DIR);
+       do_parameter_var("wins database", "tdb://%s/wins.ldb", dyn_PRIVATE_DIR);
+       do_parameter_var("registry:HKEY_LOCAL_MACHINE", "ldb:/%s/hklm.ldb", dyn_PRIVATE_DIR);
        do_parameter("guest account", GUEST_ACCOUNT);
 
        /* using UTF8 by default allows us to support all chars */
@@ -1037,8 +1035,21 @@ static void init_globals(void)
        do_parameter("use spnego", "True");
 
        do_parameter("smb ports", SMB_PORTS);
+       do_parameter("nbt port", "137");
+       do_parameter("dgram port", "138");
+       do_parameter("cldap port", "389");
+       do_parameter("web port", "901");
+       do_parameter("swat directory", dyn_SWATDIR);
 
        do_parameter("nt status support", "True");
+
+       do_parameter("max wins ttl", "432000");
+       do_parameter("min wins ttl", "10");
+
+       do_parameter("web tls", "True");
+       do_parameter_var("web tls keyfile", "%s/tls/key.pem", dyn_PRIVATE_DIR);
+       do_parameter_var("web tls certfile", "%s/tls/cert.pem", dyn_PRIVATE_DIR);
+       do_parameter_var("web tls cafile", "%s/tls/ca.pem", dyn_PRIVATE_DIR);
 }
 
 static TALLOC_CTX *lp_talloc;
@@ -1081,7 +1092,7 @@ static const char *lp_string(const char *s)
        if (!lp_talloc)
                lp_talloc = talloc_init("lp_talloc");
 
-       ret = (char *)talloc(lp_talloc, len + 100);     /* leave room for substitution */
+       ret = talloc_array(lp_talloc, char, len + 100); /* leave room for substitution */
 
        if (!ret)
                return NULL;
@@ -1134,7 +1145,17 @@ static const char *lp_string(const char *s)
  int fn_name(int i) {return(LP_SNUM_OK(i)? ServicePtrs[(i)]->val : sDefault.val);}
 
 FN_GLOBAL_LIST(lp_smb_ports, &Globals.smb_ports)
+FN_GLOBAL_INTEGER(lp_nbt_port, &Globals.nbt_port)
+FN_GLOBAL_INTEGER(lp_dgram_port, &Globals.dgram_port)
+FN_GLOBAL_INTEGER(lp_cldap_port, &Globals.cldap_port)
+FN_GLOBAL_INTEGER(lp_web_port, &Globals.web_port)
 FN_GLOBAL_STRING(lp_dos_charset, &Globals.dos_charset)
+FN_GLOBAL_STRING(lp_swat_directory, &Globals.swat_directory)
+FN_GLOBAL_BOOL(lp_web_tls, &Globals.web_tls)
+FN_GLOBAL_STRING(lp_web_keyfile, &Globals.web_keyfile)
+FN_GLOBAL_STRING(lp_web_certfile, &Globals.web_certfile)
+FN_GLOBAL_STRING(lp_web_cafile, &Globals.web_cafile)
+FN_GLOBAL_STRING(lp_web_crlfile, &Globals.web_crlfile)
 FN_GLOBAL_STRING(lp_unix_charset, &Globals.unix_charset)
 FN_GLOBAL_STRING(lp_display_charset, &Globals.display_charset)
 FN_GLOBAL_STRING(lp_logfile, &Globals.szLogFile)
@@ -1142,6 +1163,7 @@ FN_GLOBAL_STRING(lp_configfile, &Globals.szConfigFile)
 FN_GLOBAL_STRING(lp_smb_passwd_file, &Globals.szSMBPasswdFile)
 FN_GLOBAL_STRING(lp_sam_url, &Globals.szSAM_URL)
 FN_GLOBAL_STRING(lp_spoolss_url, &Globals.szSPOOLSS_URL)
+FN_GLOBAL_STRING(lp_wins_url, &Globals.szWINS_URL)
 FN_GLOBAL_STRING(lp_private_dir, &Globals.szPrivateDir)
 FN_GLOBAL_STRING(lp_serverstring, &Globals.szServerString)
 FN_GLOBAL_STRING(lp_printcapname, &Globals.szPrintcapname)
@@ -1156,8 +1178,8 @@ FN_GLOBAL_STRING(lp_hosts_equiv, &Globals.szHostsEquiv)
 FN_GLOBAL_STRING(lp_auto_services, &Globals.szAutoServices)
 FN_GLOBAL_STRING(lp_passwd_program, &Globals.szPasswdProgram)
 FN_GLOBAL_STRING(lp_passwd_chat, &Globals.szPasswdChat)
-FN_GLOBAL_STRING(lp_passwordserver, &Globals.szPasswordServer)
-FN_GLOBAL_STRING(lp_name_resolve_order, &Globals.szNameResolveOrder)
+FN_GLOBAL_LIST(lp_passwordserver, &Globals.szPasswordServers)
+FN_GLOBAL_LIST(lp_name_resolve_order, &Globals.szNameResolveOrder)
 FN_GLOBAL_STRING(lp_realm, &Globals.szRealm)
 FN_GLOBAL_STRING(lp_ads_server, &Globals.szADSserver)
 FN_GLOBAL_STRING(lp_socket_options, &Globals.socket_options)
@@ -1312,7 +1334,7 @@ static void init_copymap(service * pservice);
 /* This is a helper function for parametrical options support. */
 /* It returns a pointer to parametrical option value if it exists or NULL otherwise */
 /* Actual parametrical functions are quite simple */
-static const char *get_parametrics(int lookup_service, const char *type, const char *option)
+const char *lp_get_parametric(int lookup_service, const char *type, const char *option)
 {
        char *vfskey;
         struct param_opt *data;
@@ -1407,8 +1429,8 @@ static BOOL lp_bool(const char *s)
 
 const char *lp_parm_string(int lookup_service, const char *type, const char *option)
 {
-       const char *value = get_parametrics(lookup_service, type, option);
-       
+       const char *value = lp_get_parametric(lookup_service, type, option);
+
        if (value)
                return lp_string(value);
 
@@ -1419,13 +1441,13 @@ const char *lp_parm_string(int lookup_service, const char *type, const char *opt
 /* Parametric option has following syntax: 'Type: option = value' */
 /* Returned value is allocated in 'lp_talloc' context */
 
-char **lp_parm_string_list(int lookup_service, const char *type, const char *option,
-                          const char *separator)
+const char **lp_parm_string_list(int lookup_service, const char *type, const char *option,
+                                const char *separator)
 {
-       const char *value = get_parametrics(lookup_service, type, option);
+       const char *value = lp_get_parametric(lookup_service, type, option);
        
        if (value)
-               return str_list_make(value, separator);
+               return str_list_make(talloc_autofree_context(), value, separator);
 
        return NULL;
 }
@@ -1433,27 +1455,27 @@ char **lp_parm_string_list(int lookup_service, const char *type, const char *opt
 /* Return parametric option from a given service. Type is a part of option before ':' */
 /* Parametric option has following syntax: 'Type: option = value' */
 
-int lp_parm_int(int lookup_service, const char *type, const char *option)
+int lp_parm_int(int lookup_service, const char *type, const char *option, int default_v)
 {
-       const char *value = get_parametrics(lookup_service, type, option);
+       const char *value = lp_get_parametric(lookup_service, type, option);
        
        if (value)
                return lp_int(value);
 
-       return (-1);
+       return default_v;
 }
 
 /* Return parametric option from a given service. Type is a part of option before ':' */
 /* Parametric option has following syntax: 'Type: option = value' */
 
-unsigned long lp_parm_ulong(int lookup_service, const char *type, const char *option)
+unsigned long lp_parm_ulong(int lookup_service, const char *type, const char *option, unsigned long default_v)
 {
-       const char *value = get_parametrics(lookup_service, type, option);
+       const char *value = lp_get_parametric(lookup_service, type, option);
        
        if (value)
                return lp_ulong(value);
 
-       return (0);
+       return default_v;
 }
 
 /* Return parametric option from a given service. Type is a part of option before ':' */
@@ -1461,7 +1483,7 @@ unsigned long lp_parm_ulong(int lookup_service, const char *type, const char *op
 
 BOOL lp_parm_bool(int lookup_service, const char *type, const char *option, BOOL default_v)
 {
-       const char *value = get_parametrics(lookup_service, type, option);
+       const char *value = lp_get_parametric(lookup_service, type, option);
        
        if (value)
                return lp_bool(value);
@@ -1501,15 +1523,17 @@ static void free_service(service *pservice)
        for (i = 0; parm_table[i].label; i++) {
                if ((parm_table[i].type == P_STRING ||
                     parm_table[i].type == P_USTRING) &&
-                   parm_table[i].class == P_LOCAL)
+                   parm_table[i].class == P_LOCAL) {
                        string_free((char **)
                                    (((char *)pservice) +
                                     PTR_DIFF(parm_table[i].ptr, &sDefault)));
-               else if (parm_table[i].type == P_LIST &&
-                        parm_table[i].class == P_LOCAL)
-                            str_list_free((char ***)
-                                           (((char *)pservice) +
-                                            PTR_DIFF(parm_table[i].ptr, &sDefault)));
+               } else if (parm_table[i].type == P_LIST &&
+                          parm_table[i].class == P_LOCAL) {
+                       char ***listp = (char ***)(((char *)pservice) + 
+                                                  PTR_DIFF(parm_table[i].ptr, &sDefault));
+                       talloc_free(*listp);
+                       *listp = NULL;
+               }
        }
                                
        DEBUG(5,("Freeing parametrics:\n"));
@@ -1568,9 +1592,7 @@ static int add_a_service(const service *pservice, const char *name)
        if (i == iNumServices) {
                service **tsp;
                
-               tsp = (service **) Realloc(ServicePtrs,
-                                          sizeof(service *) *
-                                          num_to_alloc);
+               tsp = realloc_p(ServicePtrs, service *, num_to_alloc);
                                           
                if (!tsp) {
                        DEBUG(0,("add_a_service: failed to enlarge ServicePtrs!\n"));
@@ -1578,8 +1600,7 @@ static int add_a_service(const service *pservice, const char *name)
                }
                else {
                        ServicePtrs = tsp;
-                       ServicePtrs[iNumServices] =
-                               (service *) malloc(sizeof(service));
+                       ServicePtrs[iNumServices] = malloc_p(service);
                }
                if (!ServicePtrs[iNumServices]) {
                        DEBUG(0,("add_a_service: out of memory!\n"));
@@ -1653,32 +1674,34 @@ int lp_add_service(const char *pszService, int iDefaultService)
  Add the IPC service.
 ***************************************************************************/
 
-static BOOL lp_add_ipc(const char *ipc_name, BOOL guest_ok)
+static BOOL lp_add_hidden(const char *name, const char *fstype, BOOL guest_ok)
 {
        pstring comment;
-       int i = add_a_service(&sDefault, ipc_name);
+       int i = add_a_service(&sDefault, name);
 
        if (i < 0)
                return (False);
 
        slprintf(comment, sizeof(comment) - 1,
-                "IPC Service (%s)", Globals.szServerString);
+                "%s Service (%s)", fstype, Globals.szServerString);
 
        string_set(&ServicePtrs[i]->szPath, tmpdir());
        string_set(&ServicePtrs[i]->szUsername, "");
        string_set(&ServicePtrs[i]->comment, comment);
-       string_set(&ServicePtrs[i]->fstype, "IPC");
-       ServicePtrs[i]->iMaxConnections = 0;
+       string_set(&ServicePtrs[i]->fstype, fstype);
+       ServicePtrs[i]->iMaxConnections = -1;
        ServicePtrs[i]->bAvailable = True;
        ServicePtrs[i]->bRead_only = True;
        ServicePtrs[i]->bGuest_only = False;
        ServicePtrs[i]->bGuest_ok = guest_ok;
        ServicePtrs[i]->bPrint_ok = False;
-       ServicePtrs[i]->bBrowseable = sDefault.bBrowseable;
+       ServicePtrs[i]->bBrowseable = False;
 
-       lp_do_parameter(i, "ntvfs handler", "default");
+       if (strcasecmp(fstype, "IPC") == 0) {
+               lp_do_parameter(i, "ntvfs handler", "default");
+       }
 
-       DEBUG(3, ("adding IPC service\n"));
+       DEBUG(3, ("adding hidden service %s\n", name));
 
        return (True);
 }
@@ -1745,6 +1768,28 @@ static int map_parameter(const char *pszParmName)
        return (-1);
 }
 
+
+/*
+  return the parameter structure for a parameter
+*/
+struct parm_struct *lp_parm_struct(const char *name)
+{
+       int parmnum = map_parameter(name);
+       if (parmnum == -1) return NULL;
+       return &parm_table[parmnum];
+}
+
+/*
+  return the parameter pointer for a parameter
+*/
+void *lp_parm_ptr(int snum, struct parm_struct *parm)
+{
+       if (snum == -1) {
+               return parm->ptr;
+       }
+       return ((char *)ServicePtrs[snum]) + PTR_DIFF(parm->ptr, &sDefault);
+}
+
 /***************************************************************************
  Set a boolean variable from the text value stored in the passed string.
  Returns True in success, False if the passed string does not correctly 
@@ -1817,20 +1862,14 @@ static void copy_service(service * pserviceDest, service * pserviceSource, BOOL
 
                        switch (parm_table[i].type) {
                                case P_BOOL:
-                               case P_BOOLREV:
                                        *(BOOL *)dest_ptr = *(BOOL *)src_ptr;
                                        break;
 
                                case P_INTEGER:
                                case P_ENUM:
-                               case P_OCTAL:
                                        *(int *)dest_ptr = *(int *)src_ptr;
                                        break;
 
-                               case P_CHAR:
-                                       *(char *)dest_ptr = *(char *)src_ptr;
-                                       break;
-
                                case P_STRING:
                                        string_set(dest_ptr,
                                                   *(char **)src_ptr);
@@ -1842,7 +1881,8 @@ static void copy_service(service * pserviceDest, service * pserviceSource, BOOL
                                        strupper(*(char **)dest_ptr);
                                        break;
                                case P_LIST:
-                                       str_list_copy((char ***)dest_ptr, *(const char ***)src_ptr);
+                                       *(const char ***)dest_ptr = str_list_copy(talloc_autofree_context(), 
+                                                                                 *(const char ***)src_ptr);
                                        break;
                                default:
                                        break;
@@ -1873,7 +1913,7 @@ static void copy_service(service * pserviceDest, service * pserviceSource, BOOL
                        pdata = pdata->next;
                }
                if (not_added) {
-                       paramo = smb_xmalloc(sizeof(*paramo));
+                       paramo = smb_xmalloc_p(struct param_opt);
                        paramo->key = strdup(data->key);
                        paramo->value = strdup(data->value);
                        DLIST_ADD(pserviceDest->param_opt, paramo);
@@ -1905,6 +1945,7 @@ static BOOL service_ok(int iService)
                        DEBUG(0, ("WARNING: [%s] service MUST be printable!\n",
                               ServicePtrs[iService]->szService));
                        ServicePtrs[iService]->bPrint_ok = True;
+                       update_server_announce_as_printserver();
                }
                /* [printers] service must also be non-browsable. */
                if (ServicePtrs[iService]->bBrowseable)
@@ -1942,7 +1983,7 @@ static void add_to_file_list(const char *fname, const char *subfname)
        }
 
        if (!f) {
-               f = (struct file_lists *)malloc(sizeof(file_lists[0]));
+               f = malloc_p(struct file_lists);
                if (!f)
                        return;
                f->next = file_lists;
@@ -2015,7 +2056,7 @@ static BOOL handle_include(const char *pszParmValue, char **ptr)
 
        string_set(ptr, fname);
 
-       if (file_exist(fname, NULL))
+       if (file_exist(fname))
                return (pm_process(fname, do_section, do_parameter));
 
        DEBUG(2, ("Can't find include file %s\n", fname));
@@ -2187,7 +2228,7 @@ static void init_copymap(service * pservice)
 {
        int i;
        SAFE_FREE(pservice->copymap);
-       pservice->copymap = (BOOL *)malloc(sizeof(BOOL) * NUMPARAMETERS);
+       pservice->copymap = malloc_array_p(BOOL, NUMPARAMETERS);
        if (!pservice->copymap)
                DEBUG(0,
                      ("Couldn't allocate copymap!! (size %d)\n",
@@ -2249,7 +2290,7 @@ static BOOL lp_do_parameter_parametric(int snum, const char *pszParmName, const
                }
        }
 
-       paramo = smb_xmalloc(sizeof(*paramo));
+       paramo = smb_xmalloc_p(struct param_opt);
        paramo->key = strdup(name);
        paramo->value = strdup(pszParmValue);
        paramo->flags = flags;
@@ -2336,25 +2377,13 @@ BOOL lp_do_parameter(int snum, const char *pszParmName, const char *pszParmValue
                        set_boolean(parm_ptr, pszParmValue);
                        break;
 
-               case P_BOOLREV:
-                       set_boolean(parm_ptr, pszParmValue);
-                       *(BOOL *)parm_ptr = !*(BOOL *)parm_ptr;
-                       break;
-
                case P_INTEGER:
                        *(int *)parm_ptr = atoi(pszParmValue);
                        break;
 
-               case P_CHAR:
-                       *(char *)parm_ptr = *pszParmValue;
-                       break;
-
-               case P_OCTAL:
-                       sscanf(pszParmValue, "%o", (int *)parm_ptr);
-                       break;
-
                case P_LIST:
-                       *(char ***)parm_ptr = str_list_make(pszParmValue, NULL);
+                       *(const char ***)parm_ptr = str_list_make(talloc_autofree_context(), 
+                                                                 pszParmValue, NULL);
                        break;
 
                case P_STRING:
@@ -2493,6 +2522,8 @@ BOOL lp_set_option(const char *option)
 }
 
 
+#define BOOLSTR(b) ((b) ? "Yes" : "No")
+
 /***************************************************************************
  Print a parameter of the specified type.
 ***************************************************************************/
@@ -2516,26 +2547,10 @@ static void print_parameter(struct parm_struct *p, void *ptr, FILE * f)
                        fprintf(f, "%s", BOOLSTR(*(BOOL *)ptr));
                        break;
 
-               case P_BOOLREV:
-                       fprintf(f, "%s", BOOLSTR(!*(BOOL *)ptr));
-                       break;
-
                case P_INTEGER:
                        fprintf(f, "%d", *(int *)ptr);
                        break;
 
-               case P_CHAR:
-                       fprintf(f, "%c", *(char *)ptr);
-                       break;
-
-               case P_OCTAL:
-                       if (*(int *)ptr == -1) {
-                               fprintf(f, "-1");
-                       } else {
-                               fprintf(f, "0%o", *(int *)ptr);
-                       }
-                       break;
-
                case P_LIST:
                        if ((char ***)ptr && *(char ***)ptr) {
                                char **list = *(char ***)ptr;
@@ -2565,19 +2580,15 @@ static BOOL equal_parameter(parm_type type, void *ptr1, void *ptr2)
 {
        switch (type) {
                case P_BOOL:
-               case P_BOOLREV:
                        return (*((BOOL *)ptr1) == *((BOOL *)ptr2));
 
                case P_INTEGER:
                case P_ENUM:
-               case P_OCTAL:
                        return (*((int *)ptr1) == *((int *)ptr2));
 
-               case P_CHAR:
-                       return (*((char *)ptr1) == *((char *)ptr2));
-               
                case P_LIST:
-                       return str_list_compare(*(char ***)ptr1, *(char ***)ptr2);
+                       return str_list_equal((const char **)(*(char ***)ptr1), 
+                                             (const char **)(*(char ***)ptr2));
 
                case P_STRING:
                case P_USTRING:
@@ -2653,21 +2664,16 @@ static BOOL is_default(int i)
                return False;
        switch (parm_table[i].type) {
                case P_LIST:
-                       return str_list_compare (parm_table[i].def.lvalue, 
-                                               *(char ***)parm_table[i].ptr);
+                       return str_list_equal((const char **)parm_table[i].def.lvalue, 
+                                             (const char **)(*(char ***)parm_table[i].ptr));
                case P_STRING:
                case P_USTRING:
                        return strequal(parm_table[i].def.svalue,
                                        *(char **)parm_table[i].ptr);
                case P_BOOL:
-               case P_BOOLREV:
                        return parm_table[i].def.bvalue ==
                                *(BOOL *)parm_table[i].ptr;
-               case P_CHAR:
-                       return parm_table[i].def.cvalue ==
-                               *(char *)parm_table[i].ptr;
                case P_INTEGER:
-               case P_OCTAL:
                case P_ENUM:
                        return parm_table[i].def.ivalue ==
                                *(int *)parm_table[i].ptr;
@@ -2911,8 +2917,8 @@ static void lp_save_defaults(void)
                        continue;
                switch (parm_table[i].type) {
                        case P_LIST:
-                               str_list_copy(&(parm_table[i].def.lvalue),
-                                           *(const char ***)parm_table[i].ptr);
+                               parm_table[i].def.lvalue = str_list_copy(talloc_autofree_context(), 
+                                                                        *(const char ***)parm_table[i].ptr);
                                break;
                        case P_STRING:
                        case P_USTRING:
@@ -2923,16 +2929,10 @@ static void lp_save_defaults(void)
                                }
                                break;
                        case P_BOOL:
-                       case P_BOOLREV:
                                parm_table[i].def.bvalue =
                                        *(BOOL *)parm_table[i].ptr;
                                break;
-                       case P_CHAR:
-                               parm_table[i].def.cvalue =
-                                       *(char *)parm_table[i].ptr;
-                               break;
                        case P_INTEGER:
-                       case P_OCTAL:
                        case P_ENUM:
                                parm_table[i].def.ivalue =
                                        *(int *)parm_table[i].ptr;
@@ -2961,7 +2961,10 @@ static void set_server_role(void)
                case SEC_DOMAIN:
                case SEC_ADS:
                        if (lp_domain_logons()) {
-                               server_role = ROLE_DOMAIN_PDC;
+                               if (Globals.bDomainMaster) /* auto or yes */ 
+                                       server_role = ROLE_DOMAIN_PDC;
+                               else
+                                       server_role = ROLE_DOMAIN_BDC;
                                break;
                        }
                        server_role = ROLE_DOMAIN_MEMBER;
@@ -3022,13 +3025,6 @@ BOOL lp_load(const char *pszFname, BOOL global_only, BOOL save_defaults,
        bInGlobalSection = True;
        bGlobalOnly = global_only;
 
-       init_globals();
-
-       if (save_defaults)
-       {
-               lp_save_defaults();
-       }
-
        if (Globals.param_opt != NULL) {
                struct param_opt *next;
                for (data=Globals.param_opt; data; data=next) {
@@ -3041,6 +3037,13 @@ BOOL lp_load(const char *pszFname, BOOL global_only, BOOL save_defaults,
                }
        }
        
+       init_globals();
+
+       if (save_defaults)
+       {
+               lp_save_defaults();
+       }
+
        /* We get sections first, so have to start 'behind' to make up */
        iServiceIndex = -1;
        bRetval = pm_process(n2, do_section, do_parameter);
@@ -3056,8 +3059,8 @@ BOOL lp_load(const char *pszFname, BOOL global_only, BOOL save_defaults,
        if (add_ipc) {
                /* When 'restrict anonymous = 2' guest connections to ipc$
                   are denied */
-               lp_add_ipc("IPC$", (lp_restrict_anonymous() < 2));
-               lp_add_ipc("ADMIN$", False);
+               lp_add_hidden("IPC$", "IPC", (lp_restrict_anonymous() < 2));
+               lp_add_hidden("ADMIN$", "DISK", False);
        }
 
        set_server_role();
@@ -3217,6 +3220,9 @@ static void set_default_server_announce_type(void)
 
        if (lp_host_msdfs())
                default_server_announce |= SV_TYPE_DFS_SERVER;
+
+       /* TODO: only announce us as print server when we are a print server */
+       default_server_announce |= SV_TYPE_PRINTQ_SERVER;
 }
 
 /***********************************************************