r5118: added support for node status replies in nbtd. nmblookup -S now works against...
[samba.git] / source / librpc / ndr / ndr_basic.c
index fcf64b6790e742874bf05f493ae0a254302c0d97..61b3c9ec4dcaaea8f11f23dee4db20d7caed4061 100644 (file)
 
 #include "includes.h"
 
+#define NDR_BE(ndr) (((ndr)->flags & (LIBNDR_FLAG_BIGENDIAN|LIBNDR_FLAG_LITTLE_ENDIAN)) == LIBNDR_FLAG_BIGENDIAN)
+#define NDR_SVAL(ndr, ofs) (NDR_BE(ndr)?RSVAL(ndr->data,ofs):SVAL(ndr->data,ofs))
+#define NDR_IVAL(ndr, ofs) (NDR_BE(ndr)?RIVAL(ndr->data,ofs):IVAL(ndr->data,ofs))
+#define NDR_IVALS(ndr, ofs) (NDR_BE(ndr)?RIVALS(ndr->data,ofs):IVALS(ndr->data,ofs))
+#define NDR_SSVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSSVAL(ndr->data,ofs,v); } else SSVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVAL(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVAL(ndr->data,ofs,v); } else SIVAL(ndr->data,ofs,v); } while (0)
+#define NDR_SIVALS(ndr, ofs, v) do { if (NDR_BE(ndr))  { RSIVALS(ndr->data,ofs,v); } else SIVALS(ndr->data,ofs,v); } while (0)
+
+
+/*
+  check for data leaks from the server by looking for non-zero pad bytes
+  these could also indicate that real structure elements have been
+  mistaken for padding in the IDL
+*/
+void ndr_check_padding(struct ndr_pull *ndr, size_t n)
+{
+       size_t ofs2 = (ndr->offset + (n-1)) & ~(n-1);
+       int i;
+       for (i=ndr->offset;i<ofs2;i++) {
+               if (ndr->data[i] != 0) {
+                       break;
+               }
+       }
+       if (i<ofs2) {
+               DEBUG(0,("WARNING: Non-zero padding to %d: ", n));
+               for (i=ndr->offset;i<ofs2;i++) {
+                       DEBUG(0,("%02x ", ndr->data[i]));
+               }
+               DEBUG(0,("\n"));
+       }
+
+}
+
 /*
   parse a uint8
 */
-NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8 *v)
+NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8_t *v)
 {
        NDR_PULL_NEED_BYTES(ndr, 1);
        *v = CVAL(ndr->data, ndr->offset);
@@ -37,52 +70,102 @@ NTSTATUS ndr_pull_uint8(struct ndr_pull *ndr, uint8 *v)
 /*
   parse a uint16
 */
-NTSTATUS ndr_pull_uint16(struct ndr_pull *ndr, uint16 *v)
+NTSTATUS ndr_pull_uint16(struct ndr_pull *ndr, uint16_t *v)
 {
        NDR_PULL_ALIGN(ndr, 2);
        NDR_PULL_NEED_BYTES(ndr, 2);
-       *v = SVAL(ndr->data, ndr->offset);
+       *v = NDR_SVAL(ndr, ndr->offset);
        ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
 
 /*
-  parse a uint32
+  parse a uint32_t
 */
-NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, uint32 *v)
+NTSTATUS ndr_pull_uint32(struct ndr_pull *ndr, uint32_t *v)
 {
        NDR_PULL_ALIGN(ndr, 4);
        NDR_PULL_NEED_BYTES(ndr, 4);
-       *v = IVAL(ndr->data, ndr->offset);
+       *v = NDR_IVAL(ndr, ndr->offset);
        ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
 /*
-  parse a HYPER_T
+  parse a int32_t
 */
-NTSTATUS ndr_pull_HYPER_T(struct ndr_pull *ndr, HYPER_T *v)
+NTSTATUS ndr_pull_int32(struct ndr_pull *ndr, int32_t *v)
 {
-       NDR_PULL_ALIGN(ndr, 8);
+       NDR_PULL_ALIGN(ndr, 4);
+       NDR_PULL_NEED_BYTES(ndr, 4);
+       *v = NDR_IVALS(ndr, ndr->offset);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
+
+/*
+  parse a pointer
+*/
+NTSTATUS ndr_pull_ptr(struct ndr_pull *ndr, uint32_t *v)
+{
+       NTSTATUS status;
+       status = ndr_pull_uint32(ndr, v);
+       if (*v != 0) {
+               ndr->ptr_count++;
+       }
+       return status;
+}
+
+/*
+  parse a udlong
+*/
+NTSTATUS ndr_pull_udlong(struct ndr_pull *ndr, uint64_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 4);
        NDR_PULL_NEED_BYTES(ndr, 8);
-       v->low = IVAL(ndr->data, ndr->offset);
-       v->high = IVAL(ndr->data, ndr->offset+4);
+       *v = NDR_IVAL(ndr, ndr->offset);
+       *v |= (uint64_t)(NDR_IVAL(ndr, ndr->offset+4)) << 32;
        ndr->offset += 8;
        return NT_STATUS_OK;
 }
 
+/*
+  parse a dlong
+*/
+NTSTATUS ndr_pull_dlong(struct ndr_pull *ndr, int64_t *v)
+{
+       return ndr_pull_udlong(ndr, (uint64_t *)v);
+}
+
+/*
+  parse a hyper
+*/
+NTSTATUS ndr_pull_hyper(struct ndr_pull *ndr, uint64_t *v)
+{
+       NDR_PULL_ALIGN(ndr, 8);
+       return ndr_pull_udlong(ndr, v);
+}
+
 /*
   pull a NTSTATUS
 */
 NTSTATUS ndr_pull_NTSTATUS(struct ndr_pull *ndr, NTSTATUS *status)
 {
-       uint32 v;
+       uint32_t v;
        NDR_CHECK(ndr_pull_uint32(ndr, &v));
        *status = NT_STATUS(v);
        return NT_STATUS_OK;
 }
 
+/*
+  push a NTSTATUS
+*/
+NTSTATUS ndr_push_NTSTATUS(struct ndr_push *ndr, NTSTATUS status)
+{
+       return ndr_push_uint32(ndr, NT_STATUS_V(status));
+}
+
 void ndr_print_NTSTATUS(struct ndr_print *ndr, const char *name, NTSTATUS *r)
 {
        ndr->print(ndr, "%-25s: %s", name, nt_errstr(*r));
@@ -93,21 +176,29 @@ void ndr_print_NTSTATUS(struct ndr_print *ndr, const char *name, NTSTATUS *r)
 */
 NTSTATUS ndr_pull_WERROR(struct ndr_pull *ndr, WERROR *status)
 {
-       uint32 v;
+       uint32_t v;
        NDR_CHECK(ndr_pull_uint32(ndr, &v));
        *status = W_ERROR(v);
        return NT_STATUS_OK;
 }
 
-void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR *r)
+/*
+  push a WERROR
+*/
+NTSTATUS ndr_push_WERROR(struct ndr_push *ndr, WERROR status)
 {
-       ndr->print(ndr, "%-25s: %s", name, win_errstr(*r));
+       return ndr_push_uint32(ndr, W_ERROR_V(status));
+}
+
+void ndr_print_WERROR(struct ndr_print *ndr, const char *name, WERROR r)
+{
+       ndr->print(ndr, "%-25s: %s", name, win_errstr(r));
 }
 
 /*
   parse a set of bytes
 */
-NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32 n)
+NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, uint8_t *data, uint32_t n)
 {
        NDR_PULL_NEED_BYTES(ndr, n);
        memcpy(data, ndr->data + ndr->offset, n);
@@ -118,7 +209,7 @@ NTSTATUS ndr_pull_bytes(struct ndr_pull *ndr, char *data, uint32 n)
 /*
   pull an array of uint8
 */
-NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, char *data, uint32 n)
+NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, uint8_t *data, uint32_t n)
 {
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -130,9 +221,9 @@ NTSTATUS ndr_pull_array_uint8(struct ndr_pull *ndr, int ndr_flags, char *data, u
 /*
   pull an array of uint16
 */
-NTSTATUS ndr_pull_array_uint16(struct ndr_pull *ndr, int ndr_flags, uint16 *data, uint32 n)
+NTSTATUS ndr_pull_array_uint16(struct ndr_pull *ndr, int ndr_flags, uint16_t *data, uint32_t n)
 {
-       uint32 i;
+       uint32_t i;
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
        }
@@ -143,11 +234,11 @@ NTSTATUS ndr_pull_array_uint16(struct ndr_pull *ndr, int ndr_flags, uint16 *data
 }
 
 /*
-  pull a const array of uint32
+  pull a const array of uint32_t
 */
-NTSTATUS ndr_pull_array_uint32(struct ndr_pull *ndr, int ndr_flags, uint32 *data, uint32 n)
+NTSTATUS ndr_pull_array_uint32(struct ndr_pull *ndr, int ndr_flags, uint32_t *data, uint32_t n)
 {
-       uint32 i;
+       uint32_t i;
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
        }
@@ -158,21 +249,41 @@ NTSTATUS ndr_pull_array_uint32(struct ndr_pull *ndr, int ndr_flags, uint32 *data
 }
 
 /*
-  parse a GUID
+  pull a const array of hyper
+*/
+NTSTATUS ndr_pull_array_hyper(struct ndr_pull *ndr, int ndr_flags, uint64_t *data, uint32_t n)
+{
+       uint32_t i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_pull_hyper(ndr, &data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+/*
+  pull a const array of WERROR
 */
-NTSTATUS ndr_pull_GUID(struct ndr_pull *ndr, int ndr_flags, GUID *guid)
+NTSTATUS ndr_pull_array_WERROR(struct ndr_pull *ndr, int ndr_flags, WERROR *data, uint32_t n)
 {
-       if (ndr_flags & NDR_SCALARS) {
-               return ndr_pull_bytes(ndr, guid->info, GUID_SIZE);
+       uint32_t i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_pull_WERROR(ndr, &data[i]));
        }
        return NT_STATUS_OK;
 }
 
 
+
 /*
   push a uint8
 */
-NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8 v)
+NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8_t v)
 {
        NDR_PUSH_NEED_BYTES(ndr, 1);
        SCVAL(ndr->data, ndr->offset, v);
@@ -183,40 +294,69 @@ NTSTATUS ndr_push_uint8(struct ndr_push *ndr, uint8 v)
 /*
   push a uint16
 */
-NTSTATUS ndr_push_uint16(struct ndr_push *ndr, uint16 v)
+NTSTATUS ndr_push_uint16(struct ndr_push *ndr, uint16_t v)
 {
        NDR_PUSH_ALIGN(ndr, 2);
        NDR_PUSH_NEED_BYTES(ndr, 2);
-       SSVAL(ndr->data, ndr->offset, v);
+       NDR_SSVAL(ndr, ndr->offset, v);
        ndr->offset += 2;
        return NT_STATUS_OK;
 }
 
 /*
-  push a uint32
+  push a uint32_t
 */
-NTSTATUS ndr_push_uint32(struct ndr_push *ndr, uint32 v)
+NTSTATUS ndr_push_uint32(struct ndr_push *ndr, uint32_t v)
 {
        NDR_PUSH_ALIGN(ndr, 4);
        NDR_PUSH_NEED_BYTES(ndr, 4);
-       SIVAL(ndr->data, ndr->offset, v);
+       NDR_SIVAL(ndr, ndr->offset, v);
        ndr->offset += 4;
        return NT_STATUS_OK;
 }
 
 /*
-  push a HYPER_T
+  push a int32_t
 */
-NTSTATUS ndr_push_HYPER_T(struct ndr_push *ndr, HYPER_T v)
+NTSTATUS ndr_push_int32(struct ndr_push *ndr, int32_t v)
 {
-       NDR_PUSH_ALIGN(ndr, 8);
+       NDR_PUSH_ALIGN(ndr, 4);
+       NDR_PUSH_NEED_BYTES(ndr, 4);
+       NDR_SIVALS(ndr, ndr->offset, v);
+       ndr->offset += 4;
+       return NT_STATUS_OK;
+}
+
+/*
+  push a uint64
+*/
+NTSTATUS ndr_push_udlong(struct ndr_push *ndr, uint64_t v)
+{
+       NDR_PUSH_ALIGN(ndr, 4);
        NDR_PUSH_NEED_BYTES(ndr, 8);
-       SIVAL(ndr->data, ndr->offset, v.low);
-       SIVAL(ndr->data, ndr->offset+4, v.high);
+       NDR_SIVAL(ndr, ndr->offset, (v & 0xFFFFFFFF));
+       NDR_SIVAL(ndr, ndr->offset+4, (v>>32));
        ndr->offset += 8;
        return NT_STATUS_OK;
 }
 
+/*
+  push a int64
+*/
+NTSTATUS ndr_push_dlong(struct ndr_push *ndr, int64_t v)
+{
+       return ndr_push_udlong(ndr, (uint64_t)v);
+}
+
+/*
+  push a hyper
+*/
+NTSTATUS ndr_push_hyper(struct ndr_push *ndr, uint64_t v)
+{
+       NDR_PUSH_ALIGN(ndr, 8);
+       return ndr_push_udlong(ndr, v);
+}
+
 NTSTATUS ndr_push_align(struct ndr_push *ndr, size_t size)
 {
        NDR_PUSH_ALIGN(ndr, size);
@@ -232,7 +372,7 @@ NTSTATUS ndr_pull_align(struct ndr_pull *ndr, size_t size)
 /*
   push some bytes
 */
-NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32 n)
+NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const uint8_t *data, uint32_t n)
 {
        NDR_PUSH_NEED_BYTES(ndr, n);
        memcpy(ndr->data + ndr->offset, data, n);
@@ -240,10 +380,21 @@ NTSTATUS ndr_push_bytes(struct ndr_push *ndr, const char *data, uint32 n)
        return NT_STATUS_OK;
 }
 
+/*
+  push some zero bytes
+*/
+NTSTATUS ndr_push_zero(struct ndr_push *ndr, uint32_t n)
+{
+       NDR_PUSH_NEED_BYTES(ndr, n);
+       memset(ndr->data + ndr->offset, 0, n);
+       ndr->offset += n;
+       return NT_STATUS_OK;
+}
+
 /*
   push an array of uint8
 */
-NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const char *data, uint32 n)
+NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const uint8_t *data, uint32_t n)
 {
        if (!(ndr_flags & NDR_SCALARS)) {
                return NT_STATUS_OK;
@@ -252,9 +403,24 @@ NTSTATUS ndr_push_array_uint8(struct ndr_push *ndr, int ndr_flags, const char *d
 }
 
 /*
-  push an array of uint32
+  push an array of uint16
 */
-NTSTATUS ndr_push_array_uint32(struct ndr_push *ndr, int ndr_flags, const uint32 *data, uint32 n)
+NTSTATUS ndr_push_array_uint16(struct ndr_push *ndr, int ndr_flags, const uint16_t *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_uint16(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+/*
+  push an array of uint32_t
+*/
+NTSTATUS ndr_push_array_uint32(struct ndr_push *ndr, int ndr_flags, const uint32_t *data, uint32_t n)
 {
        int i;
        if (!(ndr_flags & NDR_SCALARS)) {
@@ -266,6 +432,36 @@ NTSTATUS ndr_push_array_uint32(struct ndr_push *ndr, int ndr_flags, const uint32
        return NT_STATUS_OK;
 }
 
+/*
+  push an array of hyper
+*/
+NTSTATUS ndr_push_array_hyper(struct ndr_push *ndr, int ndr_flags, const uint64_t *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_hyper(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
+/*
+  push an array of hyper
+*/
+NTSTATUS ndr_push_array_WERROR(struct ndr_push *ndr, int ndr_flags, const WERROR *data, uint32_t n)
+{
+       int i;
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+       for (i=0;i<n;i++) {
+               NDR_CHECK(ndr_push_WERROR(ndr, data[i]));
+       }
+       return NT_STATUS_OK;
+}
+
 /*
   save the current position
  */
@@ -283,161 +479,540 @@ void ndr_push_restore(struct ndr_push *ndr, struct ndr_push_save *save)
 }
 
 /*
-  this is used when a packet has a 4 byte length field. We remember the start position
-  and come back to it later to fill in the size
+  push a 1 if a pointer is non-NULL, otherwise 0
 */
-NTSTATUS ndr_push_length4_start(struct ndr_push *ndr, struct ndr_push_save *save)
+NTSTATUS ndr_push_ptr(struct ndr_push *ndr, const void *p)
 {
-       NDR_PUSH_ALIGN(ndr, 4);
-       ndr_push_save(ndr, save);
-       return ndr_push_uint32(ndr, 0);
+       uint32_t ptr = 0;
+       if (p) {
+               /* we do this to ensure that we generate unique ref ids,
+                  which means we can handle the case where a MS programmer
+                  forgot to mark a pointer as unique */
+               ndr->ptr_count++;
+               ptr = ndr->ptr_count;
+       }
+       return ndr_push_uint32(ndr, ptr);
 }
 
-NTSTATUS ndr_push_length4_end(struct ndr_push *ndr, struct ndr_push_save *save)
+
+/*
+  pull a general string from the wire
+*/
+NTSTATUS ndr_pull_string(struct ndr_pull *ndr, int ndr_flags, const char **s)
 {
-       struct ndr_push_save save2;
-       ndr_push_save(ndr, &save2);
-       ndr_push_restore(ndr, save);
-       NDR_CHECK(ndr_push_uint32(ndr, save2.offset - ndr->offset));
-       ndr_push_restore(ndr, &save2);
+       char *as=NULL;
+       uint32_t len1, ofs, len2;
+       uint16_t len3;
+       int ret;
+       int chset = CH_UTF16;
+       unsigned byte_mul = 2;
+       unsigned flags = ndr->flags;
+       unsigned c_len_term = 0;
+
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+
+       if (NDR_BE(ndr)) {
+               chset = CH_UTF16BE;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_ASCII) {
+               chset = CH_DOS;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_ASCII;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_UTF8) {
+               chset = CH_UTF8;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_UTF8;
+       }
+
+       flags &= ~LIBNDR_FLAG_STR_CONFORMANT;
+       if (flags & LIBNDR_FLAG_STR_CHARLEN) {
+               c_len_term = 1;
+               flags &= ~LIBNDR_FLAG_STR_CHARLEN;
+       }
+
+       switch (flags & LIBNDR_STRING_FLAGS) {
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
+               if (ofs != 0) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, "non-zero array offset with string flags 0x%x\n",
+                                             ndr->flags & LIBNDR_STRING_FLAGS);
+               }
+               NDR_CHECK(ndr_pull_uint32(ndr, &len2));
+               if (len2 > len1) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, 
+                                             "Bad string lengths len1=%u ofs=%u len2=%u\n", 
+                                             len1, ofs, len2);
+               }
+               if (len2 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               NDR_PULL_NEED_BYTES(ndr, (len2 + c_len_term)*byte_mul);
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           (len2 + c_len_term)*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, (len2 + c_len_term)*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < (len2 + c_len_term)) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == (len2 + c_len_term)) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE4:
+       case LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_PULL_NEED_BYTES(ndr, (len1 + c_len_term)*byte_mul);
+               if (len1 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           (len1 + c_len_term)*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, (len1 + c_len_term)*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < (len1 + c_len_term)) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == (len1 + c_len_term)) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_LEN4:
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
+               if (ofs != 0) {
+                       return ndr_pull_error(ndr, NDR_ERR_STRING, "non-zero array offset with string flags 0x%x\n",
+                                             ndr->flags & LIBNDR_STRING_FLAGS);
+               }
+               NDR_CHECK(ndr_pull_uint32(ndr, &len1));
+               NDR_PULL_NEED_BYTES(ndr, (len1 + c_len_term)*byte_mul);
+               if (len1 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           (len1 + c_len_term)*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, (len1 + c_len_term)*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < (len1 + c_len_term)) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == (len1 + c_len_term)) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+
+       case LIBNDR_FLAG_STR_SIZE2:
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
+               NDR_PULL_NEED_BYTES(ndr, (len3 + c_len_term)*byte_mul);
+               if (len3 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           (len3 + c_len_term)*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, (len3 + c_len_term)*byte_mul));
+
+               /* this is a way of detecting if a string is sent with the wrong
+                  termination */
+               if (ndr->flags & LIBNDR_FLAG_STR_NOTERM) {
+                       if (strlen(as) < (len3 + c_len_term)) {
+                               DEBUG(6,("short string '%s'\n", as));
+                       }
+               } else {
+                       if (strlen(as) == (len3 + c_len_term)) {
+                               DEBUG(6,("long string '%s'\n", as));
+                       }
+               }
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
+               NDR_CHECK(ndr_pull_uint16(ndr, &len3));
+               NDR_PULL_NEED_BYTES(ndr, len3);
+               if (len3 == 0) {
+                       *s = talloc_strdup(ndr, "");
+                       break;
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len3,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len3));
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_NULLTERM:
+               if (byte_mul == 1) {
+                       len1 = ascii_len_n((const char *)(ndr->data+ndr->offset), ndr->data_size - ndr->offset);
+               } else {
+                       len1 = utf16_len_n(ndr->data+ndr->offset, ndr->data_size - ndr->offset);
+               }
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len1));
+               *s = as;
+               break;
+
+       case LIBNDR_FLAG_STR_FIXLEN15:
+       case LIBNDR_FLAG_STR_FIXLEN32:
+               len1 = (flags & LIBNDR_FLAG_STR_FIXLEN32)?32:15;
+               NDR_PULL_NEED_BYTES(ndr, len1*byte_mul);
+               ret = convert_string_talloc(ndr, chset, CH_UNIX, 
+                                           ndr->data+ndr->offset, 
+                                           len1*byte_mul,
+                                           (void **)&as);
+               if (ret == -1) {
+                       return ndr_pull_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               NDR_CHECK(ndr_pull_advance(ndr, len1*byte_mul));
+               *s = as;
+               break;
+
+       default:
+               return ndr_pull_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
+                                     ndr->flags & LIBNDR_STRING_FLAGS);
+       }
+
        return NT_STATUS_OK;
 }
 
+
 /*
-  push a 1 if a pointer is non-NULL, otherwise 0
+  push a general string onto the wire
 */
-NTSTATUS ndr_push_ptr(struct ndr_push *ndr, const void *p)
+NTSTATUS ndr_push_string(struct ndr_push *ndr, int ndr_flags, const char *s)
 {
-       return ndr_push_uint32(ndr, p?0xaabbccdd:0);
+       ssize_t s_len, c_len, d_len;
+       int ret;
+       int chset = CH_UTF16;
+       unsigned flags = ndr->flags;
+       unsigned byte_mul = 2;
+       unsigned c_len_term = 1;
+
+       if (!(ndr_flags & NDR_SCALARS)) {
+               return NT_STATUS_OK;
+       }
+
+       if (NDR_BE(ndr)) {
+               chset = CH_UTF16BE;
+       }
+       
+       s_len = s?strlen(s):0;
+       c_len = s?strlen_m(s):0;
+
+       if (flags & LIBNDR_FLAG_STR_ASCII) {
+               chset = CH_DOS;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_ASCII;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_UTF8) {
+               chset = CH_UTF8;
+               byte_mul = 1;
+               flags &= ~LIBNDR_FLAG_STR_UTF8;
+       }
+
+       flags &= ~LIBNDR_FLAG_STR_CONFORMANT;
+
+       if (flags & LIBNDR_FLAG_STR_CHARLEN) {
+               c_len_term = 0;
+               flags &= ~LIBNDR_FLAG_STR_CHARLEN;
+       }
+
+       switch (flags & LIBNDR_STRING_FLAGS) {
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len+c_len_term));
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len+c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len+1,
+                                    ndr->data+ndr->offset, 
+                                    byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_LEN4|LIBNDR_FLAG_STR_SIZE4|LIBNDR_FLAG_STR_NOTERM:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len));
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len));
+               NDR_PUSH_NEED_BYTES(ndr, c_len*byte_mul);
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len,
+                                    ndr->data+ndr->offset, c_len*byte_mul);
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += c_len*byte_mul;
+               break;
+
+       case LIBNDR_FLAG_STR_LEN4:
+               NDR_CHECK(ndr_push_uint32(ndr, 0));
+               NDR_CHECK(ndr_push_uint32(ndr, c_len + c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE4:
+               NDR_CHECK(ndr_push_uint32(ndr, c_len + c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE2:
+               NDR_CHECK(ndr_push_uint16(ndr, c_len + c_len_term));
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len + 1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_NULLTERM:
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*(c_len+1));
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len+1,
+                                    ndr->data+ndr->offset, byte_mul*(c_len+1));
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*(c_len+1);
+               break;
+
+       case LIBNDR_FLAG_STR_SIZE2|LIBNDR_FLAG_STR_NOTERM|LIBNDR_FLAG_STR_BYTESIZE:
+               NDR_CHECK(ndr_push_uint16(ndr, c_len*byte_mul));
+               NDR_PUSH_NEED_BYTES(ndr, c_len*byte_mul);
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len,
+                                    ndr->data+ndr->offset, c_len*byte_mul);
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += c_len*byte_mul;
+               break;
+
+       case LIBNDR_FLAG_STR_FIXLEN15:
+       case LIBNDR_FLAG_STR_FIXLEN32:
+               d_len = (flags & LIBNDR_FLAG_STR_FIXLEN32)?32:15;
+               NDR_PUSH_NEED_BYTES(ndr, byte_mul*d_len);
+               ret = convert_string(CH_UNIX, chset, 
+                                    s, s_len,
+                                    ndr->data+ndr->offset, byte_mul*d_len);
+               if (ret == -1) {
+                       return ndr_push_error(ndr, NDR_ERR_CHARCNV, 
+                                             "Bad character conversion");
+               }
+               ndr->offset += byte_mul*d_len;
+               break;
+
+       default:
+               return ndr_push_error(ndr, NDR_ERR_STRING, "Bad string flags 0x%x\n",
+                                     ndr->flags & LIBNDR_STRING_FLAGS);
+       }
+
+       return NT_STATUS_OK;
 }
 
 /*
-  push a comformant, variable ucs2 string onto the wire from a C string
+  push a general string onto the wire
 */
-NTSTATUS ndr_push_unistr(struct ndr_push *ndr, const char *s)
+size_t ndr_string_array_size(struct ndr_push *ndr, const char *s)
 {
-       char *ws;
-       ssize_t len;
-       len = push_ucs2_talloc(ndr->mem_ctx, (smb_ucs2_t **)&ws, s);
-       if (len == -1) {
-               return NT_STATUS_INVALID_PARAMETER;
+       size_t c_len;
+       unsigned flags = ndr->flags;
+       unsigned byte_mul = 2;
+       unsigned c_len_term = 1;
+
+       if (flags & LIBNDR_FLAG_STR_FIXLEN32) {
+               return 32;
        }
-       NDR_CHECK(ndr_push_uint32(ndr, len/2));
-       NDR_CHECK(ndr_push_uint32(ndr, 0));
-       NDR_CHECK(ndr_push_uint32(ndr, len/2));
-       NDR_CHECK(ndr_push_bytes(ndr, ws, len));
-       return NT_STATUS_OK;
+       if (flags & LIBNDR_FLAG_STR_FIXLEN15) {
+               return 15;
+       }
+       
+       c_len = s?strlen_m(s):0;
+
+       if (flags & (LIBNDR_FLAG_STR_ASCII|LIBNDR_FLAG_STR_UTF8)) {
+               byte_mul = 1;
+       }
+
+       if (flags & LIBNDR_FLAG_STR_NOTERM) {
+               c_len_term = 0;
+       }
+
+       c_len = c_len + c_len_term;
+
+       if (flags & LIBNDR_FLAG_STR_BYTESIZE) {
+               c_len = c_len * byte_mul;
+       }
+
+       return c_len;
 }
 
+
 /*
-  push a comformant, variable ucs2 string onto the wire from a C string
-  don't send the null
+  push a NTTIME
 */
-NTSTATUS ndr_push_unistr_noterm(struct ndr_push *ndr, const char *s)
+NTSTATUS ndr_push_NTTIME(struct ndr_push *ndr, NTTIME t)
 {
-       char *ws;
-       ssize_t len;
-       len = push_ucs2_talloc(ndr->mem_ctx, (smb_ucs2_t **)&ws, s);
-       if (len == -1) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-       NDR_CHECK(ndr_push_uint32(ndr, len/2 - 1));
-       NDR_CHECK(ndr_push_uint32(ndr, 0));
-       NDR_CHECK(ndr_push_uint32(ndr, len/2 - 1));
-       NDR_CHECK(ndr_push_bytes(ndr, ws, len - 2));
+       NDR_CHECK(ndr_push_udlong(ndr, t));
        return NT_STATUS_OK;
 }
 
 /*
-  pull a comformant, variable ucs2 string from the wire into a C string
+  pull a NTTIME
 */
-NTSTATUS ndr_pull_unistr(struct ndr_pull *ndr, const char **s)
+NTSTATUS ndr_pull_NTTIME(struct ndr_pull *ndr, NTTIME *t)
 {
-       char *ws, *as=NULL;
-       uint32 len1, ofs, len2;
-
-       NDR_CHECK(ndr_pull_uint32(ndr, &len1));
-       NDR_CHECK(ndr_pull_uint32(ndr, &ofs));
-       NDR_CHECK(ndr_pull_uint32(ndr, &len2));
-       if (len2 > len1) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-       NDR_ALLOC_N(ndr, ws, (len1+1)*2);
-       NDR_CHECK(ndr_pull_bytes(ndr, ws, len2*2));
-       SSVAL(ws, len1*2, 0);
-       SSVAL(ws, len2*2, 0);
-       pull_ucs2_talloc(ndr->mem_ctx, &as, (const smb_ucs2_t *)ws);
-       if (!as) {
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-       *s = as;
+       NDR_CHECK(ndr_pull_udlong(ndr, t));
        return NT_STATUS_OK;
 }
 
 /*
-  pull a comformant, variable ucs2 string from the wire into a C string
+  push a NTTIME
 */
-NTSTATUS ndr_pull_unistr_noterm(struct ndr_pull *ndr, const char **s)
+NTSTATUS ndr_push_NTTIME_1sec(struct ndr_push *ndr, NTTIME t)
 {
-       return ndr_pull_unistr(ndr, s);
+       t /= 10000000;
+       NDR_CHECK(ndr_push_hyper(ndr, t));
+       return NT_STATUS_OK;
 }
 
 /*
-  push a 4 byte offset pointer, remembering where we are so we can later fill
-  in the correct value
+  pull a NTTIME_1sec
 */
-NTSTATUS ndr_push_offset(struct ndr_push *ndr, struct ndr_push_save *ofs)
+NTSTATUS ndr_pull_NTTIME_1sec(struct ndr_pull *ndr, NTTIME *t)
 {
-       NDR_PUSH_ALIGN(ndr, 4);
-       ndr_push_save(ndr, ofs);
-       return ndr_push_uint32(ndr, 0);
+       NDR_CHECK(ndr_pull_hyper(ndr, t));
+       (*t) *= 10000000;
+       return NT_STATUS_OK;
 }
 
 /*
-  fill in the correct offset in a saved offset pointer
-  the offset is taken relative to 'save'
+  pull a NTTIME_hyper
 */
-NTSTATUS ndr_push_offset_ptr(struct ndr_push *ndr, 
-                            struct ndr_push_save *ofs, 
-                            struct ndr_push_save *save)
+NTSTATUS ndr_pull_NTTIME_hyper(struct ndr_pull *ndr, NTTIME *t)
 {
-       struct ndr_push_save save2;
-       ndr_push_save(ndr, &save2);
-       ndr_push_restore(ndr, ofs);
-       NDR_CHECK(ndr_push_uint32(ndr, save2.offset - save->offset));
-       ndr_push_restore(ndr, &save2);
+       NDR_CHECK(ndr_pull_hyper(ndr, t));
        return NT_STATUS_OK;
 }
 
-
 /*
-  push a GUID
+  push a NTTIME_hyper
 */
-NTSTATUS ndr_push_GUID(struct ndr_push *ndr, int ndr_flags, GUID *guid)
+NTSTATUS ndr_push_NTTIME_hyper(struct ndr_push *ndr, NTTIME t)
 {
-       if (ndr_flags & NDR_SCALARS) {
-               return ndr_push_bytes(ndr, guid->info, GUID_SIZE);
-       }
+       NDR_CHECK(ndr_push_hyper(ndr, t));
        return NT_STATUS_OK;
 }
 
 /*
-  push a NTTIME
+  push a time_t
 */
-NTSTATUS ndr_push_NTTIME(struct ndr_push *ndr, NTTIME t)
+NTSTATUS ndr_push_time_t(struct ndr_push *ndr, time_t t)
 {
-       NDR_CHECK(ndr_push_uint32(ndr, t.low));
-       NDR_CHECK(ndr_push_uint32(ndr, t.high));
-       return NT_STATUS_OK;
+       return ndr_push_uint32(ndr, t);
 }
 
 /*
-  pull a NTTIME
+  pull a time_t
 */
-NTSTATUS ndr_pull_NTTIME(struct ndr_pull *ndr, NTTIME *t)
+NTSTATUS ndr_pull_time_t(struct ndr_pull *ndr, time_t *t)
 {
-       NDR_CHECK(ndr_pull_uint32(ndr, &t->low));
-       NDR_CHECK(ndr_pull_uint32(ndr, &t->high));
+       uint32_t tt;
+       NDR_CHECK(ndr_pull_uint32(ndr, &tt));
+       *t = tt;
        return NT_STATUS_OK;
 }
 
@@ -447,24 +1022,71 @@ void ndr_print_struct(struct ndr_print *ndr, const char *name, const char *type)
        ndr->print(ndr, "%s: struct %s", name, type);
 }
 
-void ndr_print_uint8(struct ndr_print *ndr, const char *name, uint8 v)
+void ndr_print_enum(struct ndr_print *ndr, const char *name, const char *type, 
+                   const char *val, uint_t value)
+{
+       if (ndr->flags & LIBNDR_PRINT_ARRAY_HEX) {
+               ndr->print(ndr, "%-25s: %s (0x%X)", name, val?val:"UNKNOWN_ENUM_VALUE", value);
+       } else {
+               ndr->print(ndr, "%-25s: %s (%d)", name, val?val:"UNKNOWN_ENUM_VALUE", value);
+       }
+}
+
+void ndr_print_bitmap_flag(struct ndr_print *ndr, size_t size, const char *flag_name, uint_t flag, uint_t value)
+{
+       /* this is an attempt to support multi-bit bitmap masks */
+       value &= flag;
+
+       while (!(flag & 1)) {
+               flag >>= 1;
+               value >>= 1;
+       }       
+       if (flag == 1) {
+               ndr->print(ndr, "   %d: %-25s", value, flag_name);
+       } else {
+               ndr->print(ndr, "0x%02x: %-25s (%d)", value, flag_name, value);
+       }
+}
+
+void ndr_print_uint8(struct ndr_print *ndr, const char *name, uint8_t v)
 {
        ndr->print(ndr, "%-25s: 0x%02x (%u)", name, v, v);
 }
 
-void ndr_print_uint16(struct ndr_print *ndr, const char *name, uint16 v)
+void ndr_print_uint16(struct ndr_print *ndr, const char *name, uint16_t v)
 {
        ndr->print(ndr, "%-25s: 0x%04x (%u)", name, v, v);
 }
 
-void ndr_print_uint32(struct ndr_print *ndr, const char *name, uint32 v)
+void ndr_print_uint32(struct ndr_print *ndr, const char *name, uint32_t v)
 {
        ndr->print(ndr, "%-25s: 0x%08x (%u)", name, v, v);
 }
 
-void ndr_print_HYPER_T(struct ndr_print *ndr, const char *name, HYPER_T v)
+void ndr_print_int32(struct ndr_print *ndr, const char *name, int32_t v)
+{
+       ndr->print(ndr, "%-25s: %d", name, v);
+}
+
+void ndr_print_udlong(struct ndr_print *ndr, const char *name, uint64_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%08x%08x (%llu)", name,
+                  (uint32_t)(v >> 32),
+                  (uint32_t)(v & 0xFFFFFFFF),
+                  v);
+}
+
+void ndr_print_dlong(struct ndr_print *ndr, const char *name, int64_t v)
+{
+       ndr->print(ndr, "%-25s: 0x%08x%08x (%lld)", name, 
+                  (uint32_t)(v >> 32), 
+                  (uint32_t)(v & 0xFFFFFFFF),
+                  v);
+}
+
+void ndr_print_hyper(struct ndr_print *ndr, const char *name, uint64_t v)
 {
-       ndr->print(ndr, "%-25s: 0x%08x%08x", name, v.high, v.low);
+       ndr_print_dlong(ndr, name, v);
 }
 
 void ndr_print_ptr(struct ndr_print *ndr, const char *name, const void *p)
@@ -476,7 +1098,7 @@ void ndr_print_ptr(struct ndr_print *ndr, const char *name, const void *p)
        }
 }
 
-void ndr_print_unistr(struct ndr_print *ndr, const char *name, const char *s)
+void ndr_print_string(struct ndr_print *ndr, const char *name, const char *s)
 {
        if (s) {
                ndr->print(ndr, "%-25s: '%s'", name, s);
@@ -485,28 +1107,45 @@ void ndr_print_unistr(struct ndr_print *ndr, const char *name, const char *s)
        }
 }
 
-void ndr_print_unistr_noterm(struct ndr_print *ndr, const char *name, const char *s)
+void ndr_print_NTTIME(struct ndr_print *ndr, const char *name, NTTIME t)
 {
-       ndr_print_unistr(ndr, name, s);
+       ndr->print(ndr, "%-25s: %s", name, nt_time_string(ndr, t));
 }
 
-void ndr_print_NTTIME(struct ndr_print *ndr, const char *name, NTTIME t)
+void ndr_print_NTTIME_1sec(struct ndr_print *ndr, const char *name, NTTIME t)
 {
-       ndr->print(ndr, "%-25s: %s", name, nt_time_string(ndr->mem_ctx, &t));
+       /* this is a standard NTTIME here
+        * as it's already converted in the pull/push code
+        */
+       ndr_print_NTTIME(ndr, name, t);
 }
 
-void ndr_print_union(struct ndr_print *ndr, const char *name, uint16 level, const char *type)
+void ndr_print_NTTIME_hyper(struct ndr_print *ndr, const char *name, NTTIME t)
 {
-       ndr->print(ndr, "%-25s: union %s(case %u)", name, type, level);
+       ndr_print_NTTIME(ndr, name, t);
 }
 
-void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16 level)
+void ndr_print_time_t(struct ndr_print *ndr, const char *name, time_t t)
+{
+       if (t == (time_t)-1 || t == 0) {
+               ndr->print(ndr, "%-25s: (time_t)%d", name, (int)t);
+       } else {
+               ndr->print(ndr, "%-25s: %s", name, timestring(ndr, t));
+       }
+}
+
+void ndr_print_union(struct ndr_print *ndr, const char *name, int level, const char *type)
+{
+       ndr->print(ndr, "%-25s: union %s(case %d)", name, type, level);
+}
+
+void ndr_print_bad_level(struct ndr_print *ndr, const char *name, uint16_t level)
 {
        ndr->print(ndr, "UNKNOWN LEVEL %u", level);
 }
 
-void ndr_print_array_uint32(struct ndr_print *ndr, const char *name, 
-                           const uint32 *data, uint32 count)
+void ndr_print_array_WERROR(struct ndr_print *ndr, const char *name, 
+                           const WERROR *data, uint32_t count)
 {
        int i;
 
@@ -516,15 +1155,15 @@ void ndr_print_array_uint32(struct ndr_print *ndr, const char *name,
                char *idx=NULL;
                asprintf(&idx, "[%d]", i);
                if (idx) {
-                       ndr_print_uint32(ndr, idx, data[i]);
+                       ndr_print_WERROR(ndr, idx, data[i]);
                        free(idx);
                }
        }
        ndr->depth--;   
 }
 
-void ndr_print_array_uint8(struct ndr_print *ndr, const char *name, 
-                          const uint8 *data, uint32 count)
+void ndr_print_array_hyper(struct ndr_print *ndr, const char *name, 
+                           const uint64_t *data, uint32_t count)
 {
        int i;
 
@@ -534,142 +1173,83 @@ void ndr_print_array_uint8(struct ndr_print *ndr, const char *name,
                char *idx=NULL;
                asprintf(&idx, "[%d]", i);
                if (idx) {
-                       ndr_print_uint8(ndr, idx, data[i]);
+                       ndr_print_hyper(ndr, idx, data[i]);
                        free(idx);
                }
        }
        ndr->depth--;   
 }
 
-void ndr_print_GUID(struct ndr_print *ndr, const char *name, const struct GUID *guid)
-{
-       ndr->print(ndr, "%-25s: %08x-%04x-%04x-%02x%02x-%02x%02x%02x%02x%02x%02x", 
-                  name,
-                  IVAL(guid->info, 0), SVAL(guid->info, 4), SVAL(guid->info, 6),
-                  guid->info[8], guid->info[9],
-                  guid->info[10], guid->info[11], guid->info[12], guid->info[13], 
-                  guid->info[14], guid->info[15]);
-}
-
-
-/*
-  pull a null terminated UCS2 string
-*/
-NTSTATUS ndr_pull_nstring(struct ndr_pull *ndr, int ndr_flags, const char **s)
-{
-       int ret;
-
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
-
-       ret = convert_string_talloc(ndr->mem_ctx, CH_UCS2, CH_UNIX, 
-                                   ndr->data+ndr->offset, 
-                                   ndr->data_size - ndr->offset,
-                                   (const void **)s);
-       if (ret == -1) {
-               return ndr_pull_error(ndr, NDR_ERR_CHARCNV, "Bad character conversion");
-       }
-       ndr->offset += ret;
-       return NT_STATUS_OK;
-}
-
-/*
-  pull a length prefixed UCS2 string
-*/
-NTSTATUS ndr_pull_lstring(struct ndr_pull *ndr, int ndr_flags, const char **s)
+void ndr_print_array_uint32(struct ndr_print *ndr, const char *name, 
+                           const uint32_t *data, uint32_t count)
 {
-       int ret;
-       uint32 size;
-
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
-
-       NDR_CHECK(ndr_pull_uint32(ndr, &size));
-       if (size == 0) {
-               *s = NULL;
-               return NT_STATUS_OK;
-       }
-
-       NDR_PULL_NEED_BYTES(ndr, size*2);
+       int i;
 
-       ret = convert_string_talloc(ndr->mem_ctx, CH_UCS2, CH_UNIX, 
-                                   ndr->data+ndr->offset, 
-                                   size*2,
-                                   (const void **)s);
-       if (ret == -1) {
-               return ndr_pull_error(ndr, NDR_ERR_CHARCNV, "Bad character conversion");
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_uint32(ndr, idx, data[i]);
+                       free(idx);
+               }
        }
-       ndr->offset += size*2;
-       return NT_STATUS_OK;
+       ndr->depth--;   
 }
 
-/*
-  push a spoolss style "relative string"
-*/
-NTSTATUS ndr_push_nstring(struct ndr_push *ndr, int ndr_flags, const char **s)
+void ndr_print_array_uint16(struct ndr_print *ndr, const char *name, 
+                           const uint16_t *data, uint32_t count)
 {
-       uint32 len;
-       int ret;
-
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
+       int i;
 
-       len = 2*(strlen_m(*s)+1);
-       NDR_PUSH_NEED_BYTES(ndr, len);
-       ret = push_ucs2(NULL, ndr->data + ndr->offset, *s, len, STR_TERMINATE);
-       if (ret == -1) {
-               return ndr_push_error(ndr, NDR_ERR_CHARCNV, "Bad string conversion");
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_uint16(ndr, idx, data[i]);
+                       free(idx);
+               }
        }
-       ndr->offset += len;
-       return NT_STATUS_OK;
+       ndr->depth--;   
 }
 
-/*
-  push a length prefixed ucs2 string
-*/
-NTSTATUS ndr_push_lstring(struct ndr_push *ndr, int ndr_flags, const char **s)
+void ndr_print_array_uint8(struct ndr_print *ndr, const char *name, 
+                          const uint8_t *data, uint32_t count)
 {
-       uint32 len;
-       int ret;
-
-       if (!(ndr_flags & NDR_SCALARS)) {
-               return NT_STATUS_OK;
-       }
+       int i;
 
-       if (! *s) {
-               NDR_CHECK(ndr_push_uint32(ndr, 0));
-               return NT_STATUS_OK;
+       if (count <= 600 && (ndr->flags & LIBNDR_PRINT_ARRAY_HEX)) {
+               char s[1202];
+               for (i=0;i<count;i++) {
+                       snprintf(&s[i*2], 3, "%02x", data[i]);
+               }
+               s[i*2] = 0;
+               ndr->print(ndr, "%-25s: %s", name, s);
+               return;
        }
 
-       len = (strlen_m(*s)+1);
-
-       NDR_CHECK(ndr_push_uint32(ndr, len));
-       NDR_PUSH_NEED_BYTES(ndr, len*2);
-
-       ret = push_ucs2(NULL, ndr->data + ndr->offset, *s, len*2, STR_TERMINATE);
-       if (ret == -1) {
-               return ndr_push_error(ndr, NDR_ERR_CHARCNV, "Bad string conversion");
+       ndr->print(ndr, "%s: ARRAY(%d)", name, count);
+       ndr->depth++;
+       for (i=0;i<count;i++) {
+               char *idx=NULL;
+               asprintf(&idx, "[%d]", i);
+               if (idx) {
+                       ndr_print_uint8(ndr, idx, data[i]);
+                       free(idx);
+               }
        }
-       ndr->offset += len*2;
-       return NT_STATUS_OK;
-}
-
-void ndr_print_nstring(struct ndr_print *ndr, const char *name, const char **s)
-{
-       ndr_print_unistr(ndr, name, *s);
-}
-
-void ndr_print_lstring(struct ndr_print *ndr, const char *name, const char **s)
-{
-       ndr_print_unistr(ndr, name, *s);
+       ndr->depth--;   
 }
 
 void ndr_print_DATA_BLOB(struct ndr_print *ndr, const char *name, DATA_BLOB r)
 {
        ndr->print(ndr, "%-25s: DATA_BLOB length=%u", name, r.length);
+       if (r.length) {
+               dump_data(10, r.data, r.length);
+       }
 }
 
 
@@ -678,7 +1258,19 @@ void ndr_print_DATA_BLOB(struct ndr_print *ndr, const char *name, DATA_BLOB r)
 */
 NTSTATUS ndr_push_DATA_BLOB(struct ndr_push *ndr, DATA_BLOB blob)
 {
-       NDR_CHECK(ndr_push_uint32(ndr, blob.length));
+       if (ndr->flags & LIBNDR_ALIGN_FLAGS) {
+               if (ndr->flags & LIBNDR_FLAG_ALIGN2) {
+                       blob.length = NDR_ALIGN(ndr, 2);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN4) {
+                       blob.length = NDR_ALIGN(ndr, 4);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN8) {
+                       blob.length = NDR_ALIGN(ndr, 8);
+               }
+               NDR_PUSH_ALLOC_SIZE(ndr, blob.data, blob.length);
+               data_blob_clear(&blob);
+       } else if (!(ndr->flags & LIBNDR_FLAG_REMAINING)) {
+               NDR_CHECK(ndr_push_uint32(ndr, blob.length));
+       }
        NDR_CHECK(ndr_push_bytes(ndr, blob.data, blob.length));
        return NT_STATUS_OK;
 }
@@ -688,42 +1280,38 @@ NTSTATUS ndr_push_DATA_BLOB(struct ndr_push *ndr, DATA_BLOB blob)
 */
 NTSTATUS ndr_pull_DATA_BLOB(struct ndr_pull *ndr, DATA_BLOB *blob)
 {
-       uint32 length;
-       NDR_CHECK(ndr_pull_uint32(ndr, &length));
+       uint32_t length;
+
+       if (ndr->flags & LIBNDR_ALIGN_FLAGS) {
+               if (ndr->flags & LIBNDR_FLAG_ALIGN2) {
+                       length = NDR_ALIGN(ndr, 2);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN4) {
+                       length = NDR_ALIGN(ndr, 4);
+               } else if (ndr->flags & LIBNDR_FLAG_ALIGN8) {
+                       length = NDR_ALIGN(ndr, 8);
+               }
+               if (ndr->data_size - ndr->offset < length) {
+                       length = ndr->data_size - ndr->offset;
+               }
+       } else if (ndr->flags & LIBNDR_FLAG_REMAINING) {
+               length = ndr->data_size - ndr->offset;
+       } else {
+               NDR_CHECK(ndr_pull_uint32(ndr, &length));
+       }
        NDR_PULL_NEED_BYTES(ndr, length);
-       *blob = data_blob_talloc(ndr->mem_ctx, ndr->data+ndr->offset, length);
+       *blob = data_blob_talloc(ndr, ndr->data+ndr->offset, length);
        ndr->offset += length;
        return NT_STATUS_OK;
 }
 
-
-/*
-  parse a policy handle
-*/
-NTSTATUS ndr_pull_policy_handle(struct ndr_pull *ndr, 
-                               struct policy_handle *r)
-{
-       NDR_CHECK(ndr_pull_bytes(ndr, r->data, 20));
-       return NT_STATUS_OK;
-}
-
-/*
-  push a policy handle
-*/
-NTSTATUS ndr_push_policy_handle(struct ndr_push *ndr, 
-                               struct policy_handle *r)
+uint32 ndr_size_DATA_BLOB(int ret, const DATA_BLOB *data, int flags)
 {
-       NDR_CHECK(ndr_push_bytes(ndr, r->data, 20));
-       return NT_STATUS_OK;
+       return ret + data->length;
 }
 
-
-void ndr_print_policy_handle(struct ndr_print *ndr, const char *name, struct policy_handle *r)
+uint32 ndr_size_string(int ret, const char * const* string, int flags) 
 {
-       ndr->print(ndr, "%-25s: policy_handle %02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x", 
-                  name, 
-                  r->data[0], r->data[1], r->data[2], r->data[3], r->data[4], 
-                  r->data[5], r->data[6], r->data[7], r->data[8], r->data[9], 
-                  r->data[10], r->data[11], r->data[12], r->data[13], r->data[14], 
-                  r->data[15], r->data[16], r->data[17], r->data[18], r->data[19]);
+       /* FIXME: Is this correct for all strings ? */
+       if(!(*string)) return ret;
+       return ret+strlen(*string)+1;
 }