r4460: Add a new GENSEC module: gensec_gssapi
[samba.git] / source / libcli / auth / spnego.c
index ed938c4a11526da953544d99497efef7020014e5..8b4be6eb751f17d38ee349a10ecbbc364ee33ba4 100644 (file)
@@ -23,6 +23,7 @@
 */
 
 #include "includes.h"
+#include "auth/auth.h"
 
 #undef DBGC_CLASS
 #define DBGC_CLASS DBGC_AUTH
@@ -37,30 +38,27 @@ enum spnego_state_position {
 };
 
 struct spnego_state {
-       TALLOC_CTX *mem_ctx;
        uint_t ref_count;
        enum spnego_message_type expected_packet;
        enum spnego_state_position state_position;
        struct gensec_security *sub_sec_security;
+       BOOL no_response_expected;
 };
 
+
 static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_security)
 {
        struct spnego_state *spnego_state;
-       TALLOC_CTX *mem_ctx = talloc_init("gensec_spnego_client_start");
-       if (!mem_ctx) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       spnego_state = talloc_p(mem_ctx, struct spnego_state);
-               
+
+       spnego_state = talloc_p(gensec_security, struct spnego_state);          
        if (!spnego_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
        spnego_state->expected_packet = SPNEGO_NEG_TOKEN_INIT;
        spnego_state->state_position = SPNEGO_CLIENT_START;
-       spnego_state->mem_ctx = mem_ctx;
        spnego_state->sub_sec_security = NULL;
+       spnego_state->no_response_expected = False;
 
        gensec_security->private_data = spnego_state;
        return NT_STATUS_OK;
@@ -69,20 +67,16 @@ static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_securi
 static NTSTATUS gensec_spnego_server_start(struct gensec_security *gensec_security)
 {
        struct spnego_state *spnego_state;
-       TALLOC_CTX *mem_ctx = talloc_init("gensec_spnego_server_start");
-       if (!mem_ctx) {
-               return NT_STATUS_NO_MEMORY;
-       }
-       spnego_state = talloc_p(mem_ctx, struct spnego_state);
-               
+
+       spnego_state = talloc_p(gensec_security, struct spnego_state);          
        if (!spnego_state) {
                return NT_STATUS_NO_MEMORY;
        }
 
        spnego_state->expected_packet = SPNEGO_NEG_TOKEN_INIT;
        spnego_state->state_position = SPNEGO_SERVER_START;
-       spnego_state->mem_ctx = mem_ctx;
        spnego_state->sub_sec_security = NULL;
+       spnego_state->no_response_expected = False;
 
        gensec_security->private_data = spnego_state;
        return NT_STATUS_OK;
@@ -92,8 +86,10 @@ static NTSTATUS gensec_spnego_server_start(struct gensec_security *gensec_securi
   wrappers for the spnego_*() functions
 */
 static NTSTATUS gensec_spnego_unseal_packet(struct gensec_security *gensec_security, 
-                                    TALLOC_CTX *mem_ctx, 
-                                    uint8_t *data, size_t length, DATA_BLOB *sig)
+                                           TALLOC_CTX *mem_ctx, 
+                                           uint8_t *data, size_t length, 
+                                           const uint8_t *whole_pdu, size_t pdu_length, 
+                                           DATA_BLOB *sig)
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
 
@@ -103,47 +99,57 @@ static NTSTATUS gensec_spnego_unseal_packet(struct gensec_security *gensec_secur
        }
        
        return gensec_unseal_packet(spnego_state->sub_sec_security, 
-                                   mem_ctx, data, length, sig); 
+                                   mem_ctx, 
+                                   data, length, 
+                                   whole_pdu, pdu_length,
+                                   sig); 
 }
 
 static NTSTATUS gensec_spnego_check_packet(struct gensec_security *gensec_security, 
-                                    TALLOC_CTX *mem_ctx, 
-                                    const uint8_t *data, size_t length, 
-                                    const DATA_BLOB *sig)
+                                          TALLOC_CTX *mem_ctx, 
+                                          const uint8_t *data, size_t length, 
+                                          const uint8_t *whole_pdu, size_t pdu_length, 
+                                          const DATA_BLOB *sig)
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
 
-       return NT_STATUS_NOT_IMPLEMENTED;
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
                return NT_STATUS_INVALID_PARAMETER;
        }
        
        return gensec_check_packet(spnego_state->sub_sec_security, 
-                               mem_ctx, data, length, sig);
+                                  mem_ctx, 
+                                  data, length, 
+                                  whole_pdu, pdu_length,
+                                  sig);
 }
 
 static NTSTATUS gensec_spnego_seal_packet(struct gensec_security *gensec_security, 
-                                   TALLOC_CTX *mem_ctx, 
-                                   uint8_t *data, size_t length, 
-                                   DATA_BLOB *sig)
+                                         TALLOC_CTX *mem_ctx, 
+                                         uint8_t *data, size_t length, 
+                                         const uint8_t *whole_pdu, size_t pdu_length, 
+                                         DATA_BLOB *sig)
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
 
-       return NT_STATUS_NOT_IMPLEMENTED;
        if (spnego_state->state_position != SPNEGO_DONE 
            && spnego_state->state_position != SPNEGO_FALLBACK) {
                return NT_STATUS_INVALID_PARAMETER;
        }
        
        return gensec_seal_packet(spnego_state->sub_sec_security, 
-                                 mem_ctx, data, length, sig);
+                                 mem_ctx, 
+                                 data, length, 
+                                 whole_pdu, pdu_length,
+                                 sig);
 }
 
 static NTSTATUS gensec_spnego_sign_packet(struct gensec_security *gensec_security, 
-                                   TALLOC_CTX *mem_ctx, 
-                                   const uint8_t *data, size_t length, 
-                                   DATA_BLOB *sig)
+                                         TALLOC_CTX *mem_ctx, 
+                                         const uint8_t *data, size_t length, 
+                                         const uint8_t *whole_pdu, size_t pdu_length, 
+                                         DATA_BLOB *sig)
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
 
@@ -153,11 +159,60 @@ static NTSTATUS gensec_spnego_sign_packet(struct gensec_security *gensec_securit
        }
        
        return gensec_sign_packet(spnego_state->sub_sec_security, 
-                                 mem_ctx, data, length, sig);
+                                 mem_ctx, 
+                                 data, length, 
+                                 whole_pdu, pdu_length,
+                                 sig);
+}
+
+static NTSTATUS gensec_spnego_wrap(struct gensec_security *gensec_security, 
+                                  TALLOC_CTX *mem_ctx, 
+                                  const DATA_BLOB *in, 
+                                  DATA_BLOB *out)
+{
+       struct spnego_state *spnego_state = gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               DEBUG(1, ("gensec_spnego_wrap: wrong state for wrap\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       return gensec_wrap(spnego_state->sub_sec_security, 
+                          mem_ctx, in, out);
+}
+
+static NTSTATUS gensec_spnego_unwrap(struct gensec_security *gensec_security, 
+                                    TALLOC_CTX *mem_ctx, 
+                                    const DATA_BLOB *in, 
+                                    DATA_BLOB *out)
+{
+       struct spnego_state *spnego_state = gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               DEBUG(1, ("gensec_spnego_unwrap: wrong state for unwrap\n"));
+               return NT_STATUS_INVALID_PARAMETER;
+       }
+       
+       return gensec_unwrap(spnego_state->sub_sec_security, 
+                            mem_ctx, in, out);
+}
+
+static size_t gensec_spnego_sig_size(struct gensec_security *gensec_security) 
+{
+       struct spnego_state *spnego_state = gensec_security->private_data;
+
+       if (spnego_state->state_position != SPNEGO_DONE 
+           && spnego_state->state_position != SPNEGO_FALLBACK) {
+               return 0;
+       }
+       
+       return gensec_sig_size(spnego_state->sub_sec_security);
 }
 
 static NTSTATUS gensec_spnego_session_key(struct gensec_security *gensec_security, 
-                                   DATA_BLOB *session_key)
+                                         DATA_BLOB *session_key)
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
        if (!spnego_state->sub_sec_security) {
@@ -200,7 +255,12 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                if (!all_ops[i]->oid) {
                        continue;
                }
-               nt_status = gensec_subcontext_start(gensec_security, 
+               if (strcasecmp(GENSEC_OID_SPNEGO,all_ops[i]->oid) == 0) {
+                       continue;
+               }
+
+               nt_status = gensec_subcontext_start(spnego_state, 
+                                                   gensec_security, 
                                                    &spnego_state->sub_sec_security);
                if (!NT_STATUS_IS_OK(nt_status)) {
                        return nt_status;
@@ -209,8 +269,9 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                nt_status = gensec_start_mech_by_oid(spnego_state->sub_sec_security,
                                                     all_ops[i]->oid);
                if (!NT_STATUS_IS_OK(nt_status)) {
-                       gensec_end(&spnego_state->sub_sec_security);
-                                       continue;
+                       talloc_free(spnego_state->sub_sec_security);
+                       spnego_state->sub_sec_security = NULL;
+                       continue;
                }
                nt_status = gensec_update(spnego_state->sub_sec_security,
                                                          out_mem_ctx, in, out);
@@ -218,7 +279,8 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                        spnego_state->state_position = SPNEGO_FALLBACK;
                        return nt_status;
                }
-               gensec_end(&spnego_state->sub_sec_security);
+               talloc_free(spnego_state->sub_sec_security);
+               spnego_state->sub_sec_security = NULL;
        }
        DEBUG(1, ("Failed to parse SPNEGO request\n"));
        return NT_STATUS_INVALID_PARAMETER;
@@ -236,7 +298,8 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
        DATA_BLOB null_data_blob = data_blob(NULL,0);
 
        for (i=0; mechType && mechType[i]; i++) {
-               nt_status = gensec_subcontext_start(gensec_security,
+               nt_status = gensec_subcontext_start(spnego_state,
+                                                   gensec_security,
                                                    &spnego_state->sub_sec_security);
                if (!NT_STATUS_IS_OK(nt_status)) {
                        break;
@@ -245,7 +308,8 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                nt_status = gensec_start_mech_by_oid(spnego_state->sub_sec_security,
                                                     mechType[i]);
                if (!NT_STATUS_IS_OK(nt_status)) {
-                       gensec_end(&spnego_state->sub_sec_security);
+                       talloc_free(spnego_state->sub_sec_security);
+                       spnego_state->sub_sec_security = NULL;
                        continue;
                }
                
@@ -264,15 +328,15 @@ static NTSTATUS gensec_spnego_parse_negTokenInit(struct gensec_security *gensec_
                if (!NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED) && !NT_STATUS_IS_OK(nt_status)) {
                        DEBUG(1, ("SPNEGO(%s) NEG_TOKEN_INIT failed: %s\n", 
                                  spnego_state->sub_sec_security->ops->name, nt_errstr(nt_status)));
-                               gensec_end(&spnego_state->sub_sec_security);
-               } else {
-                       break;
+                       talloc_free(spnego_state->sub_sec_security);
+                       spnego_state->sub_sec_security = NULL;
                }
+               return nt_status;
        }
        if (!mechType || !mechType[i]) {
                DEBUG(1, ("SPNEGO: Could not find a suitable mechtype in NEG_TOKEN_INIT\n"));
        }
-       return nt_status;
+       return NT_STATUS_INVALID_PARAMETER;
 }
 
 /** create a client negTokenInit 
@@ -287,23 +351,18 @@ static NTSTATUS gensec_spnego_client_negTokenInit(struct gensec_security *gensec
 {
        DATA_BLOB null_data_blob = data_blob(NULL,0);
        NTSTATUS nt_status;
-       int num_ops;
        const char **mechTypes = NULL;
        DATA_BLOB unwrapped_out = data_blob(NULL,0);
 
-       if (num_ops < 1) {
-               DEBUG(1, ("no GENSEC backends available\n"));
-               return NT_STATUS_INVALID_PARAMETER;
-       }
-
-       mechTypes = gensec_security_oids(out_mem_ctx, OID_SPNEGO);
+       mechTypes = gensec_security_oids(out_mem_ctx, GENSEC_OID_SPNEGO);
 
        if (!mechTypes) {
                DEBUG(1, ("no GENSEC OID backends available\n"));
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       nt_status = gensec_subcontext_start(gensec_security, 
+       nt_status = gensec_subcontext_start(spnego_state, 
+                                           gensec_security, 
                                            &spnego_state->sub_sec_security);
        if (!NT_STATUS_IS_OK(nt_status)) {
                return nt_status;
@@ -312,12 +371,13 @@ static NTSTATUS gensec_spnego_client_negTokenInit(struct gensec_security *gensec
        nt_status = gensec_start_mech_by_oid(spnego_state->sub_sec_security,
                                             mechTypes[0]);
        if (!NT_STATUS_IS_OK(nt_status)) {
-               gensec_end(&spnego_state->sub_sec_security);
-                       return nt_status;
+               talloc_free(spnego_state->sub_sec_security);
+               spnego_state->sub_sec_security = NULL;
+               return nt_status;
        }
        nt_status = gensec_update(spnego_state->sub_sec_security,
                                  out_mem_ctx, in, &unwrapped_out);
-       if (NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
+       if (NT_STATUS_IS_OK(nt_status) || NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
                struct spnego_data spnego_out;
                spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
                spnego_out.negTokenInit.mechTypes = mechTypes;
@@ -333,11 +393,17 @@ static NTSTATUS gensec_spnego_client_negTokenInit(struct gensec_security *gensec
                /* set next state */
                spnego_state->expected_packet = SPNEGO_NEG_TOKEN_TARG;
                spnego_state->state_position = SPNEGO_CLIENT_TARG;
-               return nt_status;
-       }
-       gensec_end(&spnego_state->sub_sec_security);
+               
+               if (NT_STATUS_IS_OK(nt_status)) {
+                       spnego_state->no_response_expected = True;
+               }
+
+               return NT_STATUS_MORE_PROCESSING_REQUIRED;
+       } 
+       talloc_free(spnego_state->sub_sec_security);
+       spnego_state->sub_sec_security = NULL;
 
-       DEBUG(1, ("Failed to setup SPNEGO netTokenInit request\n"));
+       DEBUG(1, ("Failed to setup SPNEGO negTokenInit request: %s\n", nt_errstr(nt_status)));
        return NT_STATUS_INVALID_PARAMETER;
 }
 
@@ -358,25 +424,28 @@ static NTSTATUS gensec_spnego_server_negTokenTarg(struct gensec_security *gensec
 
        /* compose reply */
        spnego_out.type = SPNEGO_NEG_TOKEN_TARG;
-       spnego_out.negTokenTarg.supportedMech 
-               = spnego_state->sub_sec_security->ops->oid;
        spnego_out.negTokenTarg.responseToken = unwrapped_out;
        spnego_out.negTokenTarg.mechListMIC = null_data_blob;
-       
+       spnego_out.negTokenTarg.supportedMech = NULL;
+
        if (NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
+               spnego_out.negTokenTarg.supportedMech
+                       = spnego_state->sub_sec_security->ops->oid;
                spnego_out.negTokenTarg.negResult = SPNEGO_ACCEPT_INCOMPLETE;
                spnego_state->state_position = SPNEGO_SERVER_TARG;
        } else if (NT_STATUS_IS_OK(nt_status)) {
+               if (unwrapped_out.data) {
+                       spnego_out.negTokenTarg.supportedMech
+                               = spnego_state->sub_sec_security->ops->oid;
+               }
                spnego_out.negTokenTarg.negResult = SPNEGO_ACCEPT_COMPLETED;
                spnego_state->state_position = SPNEGO_DONE;
        } else {
                spnego_out.negTokenTarg.negResult = SPNEGO_REJECT;
-               DEBUG(1, ("SPNEGO(%s) login failed: %s\n", 
-                         spnego_state->sub_sec_security->ops->name, 
-                         nt_errstr(nt_status)));
+               DEBUG(2, ("SPNEGO login failed: %s\n", nt_errstr(nt_status)));
                spnego_state->state_position = SPNEGO_DONE;
        }
-       
+
        if (spnego_write_data(out_mem_ctx, out, &spnego_out) == -1) {
                DEBUG(1, ("Failed to write SPNEGO reply to NEG_TOKEN_TARG\n"));
                return NT_STATUS_INVALID_PARAMETER;
@@ -389,7 +458,7 @@ static NTSTATUS gensec_spnego_server_negTokenTarg(struct gensec_security *gensec
 
 
 static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TALLOC_CTX *out_mem_ctx, 
-                              const DATA_BLOB in, DATA_BLOB *out) 
+                                    const DATA_BLOB in, DATA_BLOB *out) 
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
        DATA_BLOB null_data_blob = data_blob(NULL, 0);
@@ -402,7 +471,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        *out = data_blob(NULL, 0);
 
        if (!out_mem_ctx) {
-               out_mem_ctx = spnego_state->mem_ctx;
+               out_mem_ctx = spnego_state;
        }
 
        /* and switch into the state machine */
@@ -426,7 +495,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        if (spnego.type != spnego_state->expected_packet) {
                                DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                          spnego_state->expected_packet));
-                               dump_data(1, (const char *)in.data, in.length);
+                               dump_data(1, in.data, in.length);
                                spnego_free_data(&spnego);
                                return NT_STATUS_INVALID_PARAMETER;
                        }
@@ -449,12 +518,13 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        
                        return nt_status;
                } else {
-                       const char **mechlist = gensec_security_oids(out_mem_ctx, OID_SPNEGO);
+                       const char **mechlist = gensec_security_oids(out_mem_ctx, GENSEC_OID_SPNEGO);
 
                        spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
                        spnego_out.negTokenInit.mechTypes = mechlist;
                        spnego_out.negTokenInit.reqFlags = 0;
-                       spnego_out.negTokenInit.mechListMIC = null_data_blob;
+                       spnego_out.negTokenInit.mechListMIC
+                               = data_blob_string_const(gensec_get_target_principal(gensec_security));
                        spnego_out.negTokenInit.mechToken = unwrapped_out;
                        
                        if (spnego_write_data(out_mem_ctx, out, &spnego_out) == -1) {
@@ -474,19 +544,20 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        {
                /* The server offers a list of mechanisms */
                
-               char *my_mechs[] = {NULL, NULL};
+               const char *my_mechs[] = {NULL, NULL};
                NTSTATUS nt_status = NT_STATUS_INVALID_PARAMETER;
 
                if (!in.length) {
                        /* client to produce negTokenInit */
-                       return gensec_spnego_client_negTokenInit(gensec_security, spnego_state, out_mem_ctx, in, out);
+                       return gensec_spnego_client_negTokenInit(gensec_security, spnego_state, 
+                                                                out_mem_ctx, in, out);
                }
                
                len = spnego_read_data(in, &spnego);
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
@@ -494,7 +565,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (spnego.type != spnego_state->expected_packet) {
                        DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                  spnego_state->expected_packet));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        spnego_free_data(&spnego);
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -504,6 +575,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        nt_status = gensec_set_target_principal(gensec_security, 
                                                                spnego.negTokenInit.targetPrincipal);
                        if (!NT_STATUS_IS_OK(nt_status)) {
+                               spnego_free_data(&spnego);
                                return nt_status;
                        }
                }
@@ -516,6 +588,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                                                             &unwrapped_out);
 
                if (!NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED) && !NT_STATUS_IS_OK(nt_status)) {
+                       spnego_free_data(&spnego);
                        return nt_status;
                }
 
@@ -536,6 +609,10 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                /* set next state */
                spnego_state->expected_packet = SPNEGO_NEG_TOKEN_TARG;
                spnego_state->state_position = SPNEGO_CLIENT_TARG;
+
+               if (NT_STATUS_IS_OK(nt_status)) {
+                       spnego_state->no_response_expected = True;
+               }
                
                return NT_STATUS_MORE_PROCESSING_REQUIRED;
        }
@@ -550,7 +627,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
@@ -558,7 +635,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (spnego.type != spnego_state->expected_packet) {
                        DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                  spnego_state->expected_packet));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        spnego_free_data(&spnego);
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -590,7 +667,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                
                if (len == -1) {
                        DEBUG(1, ("Invalid SPNEGO request:\n"));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        return NT_STATUS_INVALID_PARAMETER;
                }
                
@@ -598,7 +675,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                if (spnego.type != spnego_state->expected_packet) {
                        DEBUG(1, ("Invalid SPNEGO request: %d, expected %d\n", spnego.type, 
                                  spnego_state->expected_packet));
-                       dump_data(1, (const char *)in.data, in.length);
+                       dump_data(1, in.data, in.length);
                        spnego_free_data(&spnego);
                        return NT_STATUS_INVALID_PARAMETER;
                }
@@ -607,10 +684,14 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
                        return NT_STATUS_ACCESS_DENIED;
                }
 
-               nt_status = gensec_update(spnego_state->sub_sec_security,
-                                         out_mem_ctx, 
-                                         spnego.negTokenTarg.responseToken, 
-                                         &unwrapped_out);
+               if (spnego_state->no_response_expected) {
+                       nt_status = NT_STATUS_OK;
+               } else {
+                       nt_status = gensec_update(spnego_state->sub_sec_security,
+                                                 out_mem_ctx, 
+                                                 spnego.negTokenTarg.responseToken, 
+                                                 &unwrapped_out);
+               } 
                
                
                if (NT_STATUS_IS_OK(nt_status) 
@@ -667,40 +748,42 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
        return NT_STATUS_INVALID_PARAMETER;
 }
 
-static void gensec_spnego_end(struct gensec_security *gensec_security)
+static BOOL gensec_spnego_have_feature(struct gensec_security *gensec_security,
+                                      uint32 feature) 
 {
        struct spnego_state *spnego_state = gensec_security->private_data;
-
-       if (spnego_state->sub_sec_security) {
-               gensec_end(&spnego_state->sub_sec_security);
+       if (!spnego_state->sub_sec_security) {
+               return False;
        }
-
-       talloc_destroy(spnego_state->mem_ctx);
-
-       gensec_security->private_data = NULL;
+       
+       return gensec_have_feature(spnego_state->sub_sec_security, 
+                                  feature);
 }
 
 static const struct gensec_security_ops gensec_spnego_security_ops = {
        .name           = "spnego",
        .sasl_name      = "GSS-SPNEGO",
        .auth_type      = DCERPC_AUTH_TYPE_SPNEGO,
-       .oid            = OID_SPNEGO,
+       .oid            = GENSEC_OID_SPNEGO,
        .client_start   = gensec_spnego_client_start,
        .server_start   = gensec_spnego_server_start,
        .update         = gensec_spnego_update,
        .seal_packet    = gensec_spnego_seal_packet,
        .sign_packet    = gensec_spnego_sign_packet,
+       .sig_size       = gensec_spnego_sig_size,
        .check_packet   = gensec_spnego_check_packet,
        .unseal_packet  = gensec_spnego_unseal_packet,
+       .wrap           = gensec_spnego_wrap,
+       .unwrap         = gensec_spnego_unwrap,
        .session_key    = gensec_spnego_session_key,
        .session_info   = gensec_spnego_session_info,
-       .end            = gensec_spnego_end
+       .have_feature   = gensec_spnego_have_feature
 };
 
 NTSTATUS gensec_spnego_init(void)
 {
        NTSTATUS ret;
-       ret = register_backend("gensec", &gensec_spnego_security_ops);
+       ret = gensec_register(&gensec_spnego_security_ops);
        if (!NT_STATUS_IS_OK(ret)) {
                DEBUG(0,("Failed to register '%s' gensec backend!\n",
                        gensec_spnego_security_ops.name));