Check error returns from strupper_m() (in all reasonable places).

[samba.git] / libgpo / gpext / gpext.c

diff --git a/libgpo/gpext/gpext.c b/libgpo/gpext/gpext.c
index 8bda729d692e8897dbdf69aebe8f993a81bc01fa..df84475754ddb3195d480a099cdeb9f7f5117f7f 100644 (file)
--- a/libgpo/gpext/gpext.c
+++ b/libgpo/gpext/gpext.c
@@ -440,7 +440,9 @@ static WERROR gp_extension_store_reg_entry(TALLOC_CTX *mem_ctx,
        subkeyname = GUID_string2(mem_ctx, &entry->guid);
        W_ERROR_HAVE_NO_MEMORY(subkeyname);
 
-       strupper_m(discard_const_p(char, subkeyname));
+       if (!strupper_m(discard_const_p(char, subkeyname))) {
+               return WERR_INVALID_PARAM;
+       }
 
        werr = gp_store_reg_subkey(mem_ctx,
                                   subkeyname,