libcli smb smb1cli_trans: fix ubsan warning
[samba.git] / auth / auth_sam_reply.c
1 /*
2    Unix SMB/CIFS implementation.
3
4    Convert a server info struct into the form for PAC and NETLOGON replies
5
6    Copyright (C) Andrew Bartlett <abartlet@samba.org> 2004-2011
7    Copyright (C) Stefan Metzmacher <metze@samba.org>  2005
8
9    This program is free software; you can redistribute it and/or modify
10    it under the terms of the GNU General Public License as published by
11    the Free Software Foundation; either version 3 of the License, or
12    (at your option) any later version.
13
14    This program is distributed in the hope that it will be useful,
15    but WITHOUT ANY WARRANTY; without even the implied warranty of
16    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
17    GNU General Public License for more details.
18
19    You should have received a copy of the GNU General Public License
20    along with this program.  If not, see <http://www.gnu.org/licenses/>.
21 */
22
23 #include "includes.h"
24 #include "librpc/gen_ndr/auth.h"
25 #include "libcli/security/security.h"
26 #include "auth/auth_sam_reply.h"
27
28 static NTSTATUS auth_convert_user_info_dc_sambaseinfo(TALLOC_CTX *mem_ctx,
29                                 const struct auth_user_info_dc *user_info_dc,
30                                 struct netr_SamBaseInfo *sam)
31 {
32         NTSTATUS status;
33         const struct auth_user_info *info;
34
35         ZERO_STRUCTP(sam);
36
37         if (user_info_dc->num_sids > PRIMARY_USER_SID_INDEX) {
38                 status = dom_sid_split_rid(sam, &user_info_dc->sids[PRIMARY_USER_SID_INDEX],
39                                            &sam->domain_sid, &sam->rid);
40                 if (!NT_STATUS_IS_OK(status)) {
41                         return status;
42                 }
43         } else {
44                 return NT_STATUS_INVALID_PARAMETER;
45         }
46
47         if (user_info_dc->num_sids > PRIMARY_GROUP_SID_INDEX) {
48                 status = dom_sid_split_rid(NULL, &user_info_dc->sids[PRIMARY_GROUP_SID_INDEX],
49                                            NULL, &sam->primary_gid);
50                 if (!NT_STATUS_IS_OK(status)) {
51                         return status;
52                 }
53         } else {
54                 /* if we have to encode something like SYSTEM (with no
55                  * second SID in the token) then this is the only
56                  * choice */
57                 sam->primary_gid = sam->rid;
58         }
59
60         info = user_info_dc->info;
61
62         sam->logon_time = info->last_logon;
63         sam->logoff_time =  info->last_logoff;
64         sam->kickoff_time = info->acct_expiry;
65         sam->last_password_change = info->last_password_change;
66         sam->allow_password_change = info->allow_password_change;
67         sam->force_password_change = info->force_password_change;
68
69 #define _COPY_STRING_TALLOC(src_name, dst_name) do { \
70         if (info->src_name != NULL) {\
71                 sam->dst_name.string = talloc_strdup(mem_ctx, info->src_name); \
72                 if (sam->dst_name.string == NULL) { \
73                         return NT_STATUS_NO_MEMORY; \
74                 } \
75         } \
76 } while(0)
77         _COPY_STRING_TALLOC(account_name, account_name);
78         _COPY_STRING_TALLOC(full_name, full_name);
79         _COPY_STRING_TALLOC(logon_script, logon_script);
80         _COPY_STRING_TALLOC(profile_path, profile_path);
81         _COPY_STRING_TALLOC(home_directory, home_directory);
82         _COPY_STRING_TALLOC(home_drive, home_drive);
83         _COPY_STRING_TALLOC(logon_server, logon_server);
84         _COPY_STRING_TALLOC(domain_name, logon_domain);
85 #undef _COPY_STRING_TALLOC
86
87         sam->logon_count = info->logon_count;
88         sam->bad_password_count = info->bad_password_count;
89         sam->groups.count = 0;
90         sam->groups.rids = NULL;
91
92         if (user_info_dc->num_sids > PRIMARY_GROUP_SID_INDEX) {
93                 size_t i;
94                 sam->groups.rids = talloc_array(mem_ctx, struct samr_RidWithAttribute,
95                                                 user_info_dc->num_sids);
96
97                 if (sam->groups.rids == NULL)
98                         return NT_STATUS_NO_MEMORY;
99
100                 for (i=PRIMARY_GROUP_SID_INDEX; i<user_info_dc->num_sids; i++) {
101                         struct dom_sid *group_sid = &user_info_dc->sids[i];
102                         if (!dom_sid_in_domain(sam->domain_sid, group_sid)) {
103                                 /* We handle this elsewhere */
104                                 continue;
105                         }
106                         sam->groups.rids[sam->groups.count].rid =
107                                 group_sid->sub_auths[group_sid->num_auths-1];
108
109                         sam->groups.rids[sam->groups.count].attributes =
110                                 SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
111                         sam->groups.count += 1;
112                 }
113         }
114
115         sam->user_flags = 0; /* w2k3 uses NETLOGON_EXTRA_SIDS | NETLOGON_NTLMV2_ENABLED */
116         if (!user_info_dc->info->authenticated) {
117                 sam->user_flags |= NETLOGON_GUEST;
118         }
119         sam->acct_flags = user_info_dc->info->acct_flags;
120         sam->sub_auth_status = 0;
121         sam->last_successful_logon = 0;
122         sam->last_failed_logon = 0;
123         sam->failed_logon_count = 0;
124         sam->reserved = 0;
125
126         ZERO_STRUCT(sam->key);
127         if (user_info_dc->user_session_key.length == sizeof(sam->key.key)) {
128                 memcpy(sam->key.key, user_info_dc->user_session_key.data, sizeof(sam->key.key));
129         }
130
131         ZERO_STRUCT(sam->LMSessKey);
132         if (user_info_dc->lm_session_key.length == sizeof(sam->LMSessKey.key)) {
133                 memcpy(sam->LMSessKey.key, user_info_dc->lm_session_key.data,
134                        sizeof(sam->LMSessKey.key));
135         }
136
137         return NT_STATUS_OK;
138 }
139
140 /* Note that the validity of the _sam6 structure is only as long as
141  * the user_info_dc it was generated from */
142 NTSTATUS auth_convert_user_info_dc_saminfo6(TALLOC_CTX *mem_ctx,
143                                             const struct auth_user_info_dc *user_info_dc,
144                                             struct netr_SamInfo6 **_sam6)
145 {
146         NTSTATUS status;
147         struct netr_SamInfo6 *sam6 = NULL;
148         size_t i;
149
150         sam6 = talloc_zero(mem_ctx, struct netr_SamInfo6);
151         if (sam6 == NULL) {
152                 return NT_STATUS_NO_MEMORY;
153         }
154
155         status = auth_convert_user_info_dc_sambaseinfo(sam6,
156                                                        user_info_dc,
157                                                        &sam6->base);
158         if (!NT_STATUS_IS_OK(status)) {
159                 TALLOC_FREE(sam6);
160                 return status;
161         }
162
163         sam6->sids = talloc_array(sam6, struct netr_SidAttr,
164                                   user_info_dc->num_sids);
165         if (sam6->sids == NULL) {
166                 TALLOC_FREE(sam6);
167                 return NT_STATUS_NO_MEMORY;
168         }
169
170         /* We don't put the user and group SIDs in there */
171         for (i=2; i<user_info_dc->num_sids; i++) {
172                 if (dom_sid_in_domain(sam6->base.domain_sid, &user_info_dc->sids[i])) {
173                         continue;
174                 }
175                 sam6->sids[sam6->sidcount].sid = dom_sid_dup(sam6->sids, &user_info_dc->sids[i]);
176                 if (sam6->sids[sam6->sidcount].sid == NULL) {
177                         TALLOC_FREE(sam6);
178                         return NT_STATUS_NO_MEMORY;
179                 }
180                 sam6->sids[sam6->sidcount].attributes =
181                         SE_GROUP_MANDATORY | SE_GROUP_ENABLED_BY_DEFAULT | SE_GROUP_ENABLED;
182                 sam6->sidcount += 1;
183         }
184         if (sam6->sidcount) {
185                 sam6->base.user_flags |= NETLOGON_EXTRA_SIDS;
186         } else {
187                 sam6->sids = NULL;
188         }
189
190         if (user_info_dc->info->dns_domain_name != NULL) {
191                 sam6->dns_domainname.string = talloc_strdup(sam6,
192                                         user_info_dc->info->dns_domain_name);
193                 if (sam6->dns_domainname.string == NULL) {
194                         TALLOC_FREE(sam6);
195                         return NT_STATUS_NO_MEMORY;
196                 }
197         }
198
199         if (user_info_dc->info->user_principal_name != NULL) {
200                 sam6->principal_name.string = talloc_strdup(sam6,
201                                         user_info_dc->info->user_principal_name);
202                 if (sam6->principal_name.string == NULL) {
203                         TALLOC_FREE(sam6);
204                         return NT_STATUS_NO_MEMORY;
205                 }
206         }
207
208         *_sam6 = sam6;
209         return NT_STATUS_OK;
210 }
211
212 /* Note that the validity of the _sam2 structure is only as long as
213  * the user_info_dc it was generated from */
214 NTSTATUS auth_convert_user_info_dc_saminfo2(TALLOC_CTX *mem_ctx,
215                                            const struct auth_user_info_dc *user_info_dc,
216                                            struct netr_SamInfo2 **_sam2)
217 {
218         NTSTATUS status;
219         struct netr_SamInfo6 *sam6 = NULL;
220         struct netr_SamInfo2 *sam2 = NULL;
221
222         sam2 = talloc_zero(mem_ctx, struct netr_SamInfo2);
223         if (sam2 == NULL) {
224                 return NT_STATUS_NO_MEMORY;
225         }
226
227         status = auth_convert_user_info_dc_saminfo6(sam2, user_info_dc, &sam6);
228         if (!NT_STATUS_IS_OK(status)) {
229                 TALLOC_FREE(sam2);
230                 return status;
231         }
232         sam2->base      = sam6->base;
233
234         *_sam2 = sam2;
235         return NT_STATUS_OK;
236 }
237
238 /* Note that the validity of the _sam3 structure is only as long as
239  * the user_info_dc it was generated from */
240 NTSTATUS auth_convert_user_info_dc_saminfo3(TALLOC_CTX *mem_ctx,
241                                            const struct auth_user_info_dc *user_info_dc,
242                                            struct netr_SamInfo3 **_sam3)
243 {
244         NTSTATUS status;
245         struct netr_SamInfo6 *sam6 = NULL;
246         struct netr_SamInfo3 *sam3 = NULL;
247
248         sam3 = talloc_zero(mem_ctx, struct netr_SamInfo3);
249         if (sam3 == NULL) {
250                 return NT_STATUS_NO_MEMORY;
251         }
252
253         status = auth_convert_user_info_dc_saminfo6(sam3, user_info_dc, &sam6);
254         if (!NT_STATUS_IS_OK(status)) {
255                 TALLOC_FREE(sam3);
256                 return status;
257         }
258         sam3->base      = sam6->base;
259         sam3->sidcount  = sam6->sidcount;
260         sam3->sids      = sam6->sids;
261
262         *_sam3 = sam3;
263         return NT_STATUS_OK;
264 }
265
266 /**
267  * Make a user_info struct from the info3 or similar returned by a domain logon.
268  *
269  * The netr_SamInfo3 is also a key structure in the source3 auth subsystem
270  */
271
272 NTSTATUS make_user_info_SamBaseInfo(TALLOC_CTX *mem_ctx,
273                                     const char *account_name,
274                                     const struct netr_SamBaseInfo *base,
275                                     bool authenticated,
276                                     struct auth_user_info **_user_info)
277 {
278         struct auth_user_info *info;
279
280         info = talloc_zero(mem_ctx, struct auth_user_info);
281         NT_STATUS_HAVE_NO_MEMORY(info);
282
283         if (base->account_name.string) {
284                 info->account_name = talloc_strdup(info, base->account_name.string);
285         } else {
286                 info->account_name = talloc_strdup(info, account_name);
287         }
288         NT_STATUS_HAVE_NO_MEMORY(info->account_name);
289
290         if (base->logon_domain.string) {
291                 info->domain_name = talloc_strdup(info, base->logon_domain.string);
292                 NT_STATUS_HAVE_NO_MEMORY(info->domain_name);
293         }
294
295         if (base->full_name.string) {
296                 info->full_name = talloc_strdup(info, base->full_name.string);
297                 NT_STATUS_HAVE_NO_MEMORY(info->full_name);
298         }
299         if (base->logon_script.string) {
300                 info->logon_script = talloc_strdup(info, base->logon_script.string);
301                 NT_STATUS_HAVE_NO_MEMORY(info->logon_script);
302         }
303         if (base->profile_path.string) {
304                 info->profile_path = talloc_strdup(info, base->profile_path.string);
305                 NT_STATUS_HAVE_NO_MEMORY(info->profile_path);
306         }
307         if (base->home_directory.string) {
308                 info->home_directory = talloc_strdup(info, base->home_directory.string);
309                 NT_STATUS_HAVE_NO_MEMORY(info->home_directory);
310         }
311         if (base->home_drive.string) {
312                 info->home_drive = talloc_strdup(info, base->home_drive.string);
313                 NT_STATUS_HAVE_NO_MEMORY(info->home_drive);
314         }
315         if (base->logon_server.string) {
316                 info->logon_server = talloc_strdup(info, base->logon_server.string);
317                 NT_STATUS_HAVE_NO_MEMORY(info->logon_server);
318         }
319         info->last_logon = base->logon_time;
320         info->last_logoff = base->logoff_time;
321         info->acct_expiry = base->kickoff_time;
322         info->last_password_change = base->last_password_change;
323         info->allow_password_change = base->allow_password_change;
324         info->force_password_change = base->force_password_change;
325         info->logon_count = base->logon_count;
326         info->bad_password_count = base->bad_password_count;
327         info->acct_flags = base->acct_flags;
328
329         /* Only set authenticated if both NETLOGON_GUEST is not set, and authenticated is set */
330         info->authenticated = (authenticated && (!(base->user_flags & NETLOGON_GUEST)));
331
332         *_user_info = info;
333         return NT_STATUS_OK;
334 }
335
336 struct auth_user_info *auth_user_info_copy(TALLOC_CTX *mem_ctx,
337                                            const struct auth_user_info *src)
338 {
339         struct auth_user_info *dst = NULL;
340
341         dst = talloc_zero(mem_ctx, struct auth_user_info);
342         if (dst == NULL) {
343                 return NULL;
344         }
345
346         *dst = *src;
347 #define _COPY_STRING(_mem, _str) do { \
348         if ((_str) != NULL) { \
349                 (_str) = talloc_strdup((_mem), (_str)); \
350                 if ((_str) == NULL) { \
351                         TALLOC_FREE(dst); \
352                         return NULL; \
353                 } \
354         } \
355 } while(0)
356         _COPY_STRING(dst, dst->account_name);
357         _COPY_STRING(dst, dst->user_principal_name);
358         _COPY_STRING(dst, dst->domain_name);
359         _COPY_STRING(dst, dst->dns_domain_name);
360         _COPY_STRING(dst, dst->full_name);
361         _COPY_STRING(dst, dst->logon_script);
362         _COPY_STRING(dst, dst->profile_path);
363         _COPY_STRING(dst, dst->home_directory);
364         _COPY_STRING(dst, dst->home_drive);
365         _COPY_STRING(dst, dst->logon_server);
366 #undef _COPY_STRING
367
368         return dst;
369 }
370
371 /**
372  * Make a user_info_dc struct from the info3 returned by a domain logon
373  */
374 NTSTATUS make_user_info_dc_netlogon_validation(TALLOC_CTX *mem_ctx,
375                                               const char *account_name,
376                                               uint16_t validation_level,
377                                               const union netr_Validation *validation,
378                                                bool authenticated,
379                                               struct auth_user_info_dc **_user_info_dc)
380 {
381         NTSTATUS status;
382         struct auth_user_info_dc *user_info_dc = NULL;
383         const struct netr_SamBaseInfo *base = NULL;
384         uint32_t sidcount = 0;
385         const struct netr_SidAttr *sids = NULL;
386         const char *dns_domainname = NULL;
387         const char *principal = NULL;
388         uint32_t i;
389
390         switch (validation_level) {
391         case 2:
392                 if (!validation || !validation->sam2) {
393                         return NT_STATUS_INVALID_PARAMETER;
394                 }
395                 base = &validation->sam2->base;
396                 break;
397         case 3:
398                 if (!validation || !validation->sam3) {
399                         return NT_STATUS_INVALID_PARAMETER;
400                 }
401                 base = &validation->sam3->base;
402                 sidcount = validation->sam3->sidcount;
403                 sids = validation->sam3->sids;
404                 break;
405         case 6:
406                 if (!validation || !validation->sam6) {
407                         return NT_STATUS_INVALID_PARAMETER;
408                 }
409                 base = &validation->sam6->base;
410                 sidcount = validation->sam6->sidcount;
411                 sids = validation->sam6->sids;
412                 dns_domainname = validation->sam6->dns_domainname.string;
413                 principal = validation->sam6->principal_name.string;
414                 break;
415         default:
416                 return NT_STATUS_INVALID_LEVEL;
417         }
418
419         user_info_dc = talloc(mem_ctx, struct auth_user_info_dc);
420         NT_STATUS_HAVE_NO_MEMORY(user_info_dc);
421
422         /*
423            Here is where we should check the list of
424            trusted domains, and verify that the SID
425            matches.
426         */
427         if (!base->domain_sid) {
428                 DEBUG(0, ("Cannot operate on a Netlogon Validation without a domain SID"));
429                 return NT_STATUS_INVALID_PARAMETER;
430         }
431
432         /* The IDL layer would be a better place to check this, but to
433          * guard the integer addition below, we double-check */
434         if (base->groups.count > 65535) {
435                 return NT_STATUS_INVALID_PARAMETER;
436         }
437
438         user_info_dc->num_sids = 2;
439
440         user_info_dc->sids = talloc_array(user_info_dc, struct dom_sid,  user_info_dc->num_sids + base->groups.count);
441         NT_STATUS_HAVE_NO_MEMORY(user_info_dc->sids);
442
443         user_info_dc->sids[PRIMARY_USER_SID_INDEX] = *base->domain_sid;
444         if (!sid_append_rid(&user_info_dc->sids[PRIMARY_USER_SID_INDEX], base->rid)) {
445                 return NT_STATUS_INVALID_PARAMETER;
446         }
447
448         user_info_dc->sids[PRIMARY_GROUP_SID_INDEX] = *base->domain_sid;
449         if (!sid_append_rid(&user_info_dc->sids[PRIMARY_GROUP_SID_INDEX], base->primary_gid)) {
450                 return NT_STATUS_INVALID_PARAMETER;
451         }
452
453         for (i = 0; i < base->groups.count; i++) {
454                 /* Skip primary group, already added above */
455                 if (base->groups.rids[i].rid == base->primary_gid) {
456                         continue;
457                 }
458                 user_info_dc->sids[user_info_dc->num_sids] = *base->domain_sid;
459                 if (!sid_append_rid(&user_info_dc->sids[user_info_dc->num_sids], base->groups.rids[i].rid)) {
460                         return NT_STATUS_INVALID_PARAMETER;
461                 }
462                 user_info_dc->num_sids++;
463         }
464
465         /* Copy 'other' sids.  We need to do sid filtering here to
466            prevent possible elevation of privileges.  See:
467
468            http://www.microsoft.com/windows2000/techinfo/administration/security/sidfilter.asp
469          */
470
471         /*
472          * The IDL layer would be a better place to check this, but to
473          * guard the integer addition below, we double-check
474          */
475         if (sidcount > UINT16_MAX) {
476                 return NT_STATUS_INVALID_PARAMETER;
477         }
478
479         if (sidcount > 0) {
480                 struct dom_sid *dgrps = user_info_dc->sids;
481                 size_t dgrps_count;
482
483                 dgrps_count = user_info_dc->num_sids + sidcount;
484                 dgrps = talloc_realloc(user_info_dc, dgrps, struct dom_sid,
485                                        dgrps_count);
486                 if (dgrps == NULL) {
487                         return NT_STATUS_NO_MEMORY;
488                 }
489
490                 for (i = 0; i < sidcount; i++) {
491                         if (sids[i].sid) {
492                                 dgrps[user_info_dc->num_sids] = *sids[i].sid;
493                                 user_info_dc->num_sids++;
494                         }
495                 }
496
497                 user_info_dc->sids = dgrps;
498
499                 /* Where are the 'global' sids?... */
500         }
501
502         status = make_user_info_SamBaseInfo(user_info_dc, account_name, base, authenticated, &user_info_dc->info);
503         if (!NT_STATUS_IS_OK(status)) {
504                 return status;
505         }
506
507         if (dns_domainname != NULL) {
508                 user_info_dc->info->dns_domain_name = talloc_strdup(user_info_dc->info,
509                                                                     dns_domainname);
510                 if (user_info_dc->info->dns_domain_name == NULL) {
511                         return NT_STATUS_NO_MEMORY;
512                 }
513         }
514
515         if (principal != NULL) {
516                 user_info_dc->info->user_principal_name = talloc_strdup(user_info_dc->info,
517                                                                         principal);
518                 if (user_info_dc->info->user_principal_name == NULL) {
519                         return NT_STATUS_NO_MEMORY;
520                 }
521         }
522
523         /* ensure we are never given NULL session keys */
524
525         if (all_zero(base->key.key, sizeof(base->key.key))) {
526                 user_info_dc->user_session_key = data_blob(NULL, 0);
527         } else {
528                 user_info_dc->user_session_key = data_blob_talloc(user_info_dc, base->key.key, sizeof(base->key.key));
529                 NT_STATUS_HAVE_NO_MEMORY(user_info_dc->user_session_key.data);
530         }
531
532         if (all_zero(base->LMSessKey.key, sizeof(base->LMSessKey.key))) {
533                 user_info_dc->lm_session_key = data_blob(NULL, 0);
534         } else {
535                 user_info_dc->lm_session_key = data_blob_talloc(user_info_dc, base->LMSessKey.key, sizeof(base->LMSessKey.key));
536                 NT_STATUS_HAVE_NO_MEMORY(user_info_dc->lm_session_key.data);
537         }
538
539         *_user_info_dc = user_info_dc;
540         return NT_STATUS_OK;
541 }
542
543 /**
544  * Make a user_info_dc struct from the PAC_LOGON_INFO supplied in the krb5 logon
545  */
546 NTSTATUS make_user_info_dc_pac(TALLOC_CTX *mem_ctx,
547                               const struct PAC_LOGON_INFO *pac_logon_info,
548                               const struct PAC_UPN_DNS_INFO *pac_upn_dns_info,
549                               struct auth_user_info_dc **_user_info_dc)
550 {
551         uint32_t i;
552         NTSTATUS nt_status;
553         union netr_Validation validation;
554         struct auth_user_info_dc *user_info_dc;
555         const struct PAC_DOMAIN_GROUP_MEMBERSHIP *rg = NULL;
556         size_t sidcount;
557
558         rg = &pac_logon_info->resource_groups;
559
560         validation.sam3 = discard_const_p(struct netr_SamInfo3, &pac_logon_info->info3);
561
562         nt_status = make_user_info_dc_netlogon_validation(mem_ctx, "", 3, &validation,
563                                                           true, /* This user was authenticated */
564                                                           &user_info_dc);
565         if (!NT_STATUS_IS_OK(nt_status)) {
566                 return nt_status;
567         }
568
569         if (pac_logon_info->info3.base.user_flags & NETLOGON_RESOURCE_GROUPS) {
570                 rg = &pac_logon_info->resource_groups;
571         }
572
573         if (rg == NULL) {
574                 *_user_info_dc = user_info_dc;
575                 return NT_STATUS_OK;
576         }
577
578         if (rg->groups.count > 0) {
579                 /* The IDL layer would be a better place to check this, but to
580                  * guard the integer addition below, we double-check */
581                 if (rg->groups.count > 65535) {
582                         talloc_free(user_info_dc);
583                         return NT_STATUS_INVALID_PARAMETER;
584                 }
585
586                 /*
587                   Here is where we should check the list of
588                   trusted domains, and verify that the SID
589                   matches.
590                 */
591                 if (rg->domain_sid == NULL) {
592                         talloc_free(user_info_dc);
593                         DEBUG(0, ("Cannot operate on a PAC without a resource domain SID"));
594                         return NT_STATUS_INVALID_PARAMETER;
595                 }
596
597                 sidcount = user_info_dc->num_sids + rg->groups.count;
598                 user_info_dc->sids
599                         = talloc_realloc(user_info_dc, user_info_dc->sids, struct dom_sid, sidcount);
600                 if (user_info_dc->sids == NULL) {
601                         TALLOC_FREE(user_info_dc);
602                         return NT_STATUS_NO_MEMORY;
603                 }
604
605                 for (i = 0; i < rg->groups.count; i++) {
606                         bool ok;
607
608                         user_info_dc->sids[user_info_dc->num_sids] = *rg->domain_sid;
609                         ok = sid_append_rid(&user_info_dc->sids[user_info_dc->num_sids],
610                                             rg->groups.rids[i].rid);
611                         if (!ok) {
612                                 return NT_STATUS_INVALID_PARAMETER;
613                         }
614                         user_info_dc->num_sids++;
615                 }
616         }
617
618         if (pac_upn_dns_info != NULL) {
619                 user_info_dc->info->user_principal_name =
620                         talloc_strdup(user_info_dc->info,
621                                       pac_upn_dns_info->upn_name);
622                 if (user_info_dc->info->user_principal_name == NULL) {
623                         return NT_STATUS_NO_MEMORY;
624                 }
625
626                 user_info_dc->info->dns_domain_name =
627                         talloc_strdup(user_info_dc->info,
628                                       pac_upn_dns_info->dns_domain_name);
629                 if (user_info_dc->info->dns_domain_name == NULL) {
630                         return NT_STATUS_NO_MEMORY;
631                 }
632
633                 if (pac_upn_dns_info->flags & PAC_UPN_DNS_FLAG_CONSTRUCTED) {
634                         user_info_dc->info->user_principal_constructed = true;
635                 }
636         }
637
638         *_user_info_dc = user_info_dc;
639         return NT_STATUS_OK;
640 }