VERSION: move COPYRIGHT_STARTUP_MESSAGE as SAMBA_COPYRIGHT_STRING into version.h We also prodive a samba_copyright_string() helper similar to samba_version_string(). BUG: https://bugzilla.samba.org/show_bug.cgi?id=15377 Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Björn Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Dec 15 10:44:42 UTC 2023 on atb-devel-224
libsmb: Pass neg contexts through sync smbXcli_negprot_recv() Looks much larger than it is, there's a lot of callers too feed NULL to. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Mon Sep 25 19:59:17 UTC 2023 on atb-devel-224
waf: Build nmbd with -Wno-error=stringop-overflow We use strlcpy() which has been added to glibc recently. This means we also get fortification for strlcpy() now: source3/nmbd/nmbd_browsesync.c: In function ‘find_domain_master_name_query_success’: source3/nmbd/nmbd_browsesync.c:337:9: warning: ‘strlcpy’ writing 257 bytes into a region of size 16 overflows the destination [-Wstringop-overflow=] 337 | strlcpy(userdata->data, work->work_group, size - sizeof(*userdata)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ We allocate memory for the userdata struct + fstring. However the data pointer we use only is 16 bytes. Also nowadays you would use offsetof() for the allocation calculation, but it only works correctly on newer compilers like gcc > 7. We could make use of it in future after CentOS 7 is gone. As we don't want to touch nmbd anymore, just silence the warnings. Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
s3:nmbd: Fix code spelling Signed-off-by: Andreas Schneider <asn@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Mon Jul 17 12:41:21 UTC 2023 on atb-devel-224
nmbd_become_lmb.c: use DBG* macros instead of static log level numbers Some log levels change because the macros don't cover all the previously used log levels or because importance was slightly reconsidered. BUG: https://bugzilla.samba.org/show_bug.cgi?id=4143 Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
nmbd/asyncdns.c: use DBG* macros instead of static log level numbers Some log levels change because the macros don't cover all the previously used log levels or because importance was slightly reconsidered. BUG: https://bugzilla.samba.org/show_bug.cgi?id=4143 Signed-off-by: Bjoern Jacke <bjacke@samba.org> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
debug: Remove "override_logfile" The only writer to this variable left with c377845d27d4dcd7. The closest match for override_logfile is is_default_dyn_LOGFILEBASE() with the opposite logic. Signed-off-by: Volker Lendecke <vl@samba.org> Reviewed-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Sat Sep 18 00:53:28 UTC 2021 on sn-devel-184