9 years agobuild(waf): Fail "configure --with-cluster-support" if ctdb support is not available. master-cluster-checks
Björn Baumbach [Tue, 30 Oct 2012 15:04:10 +0000 (16:04 +0100)]
build(waf): Fail "configure --with-cluster-support" if ctdb support is not available.

Currently, configure only warns if cluster support is not found.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agos3-torture:test_ctdbconn: fix the build against older ctdb versions
Björn Baumbach [Tue, 30 Oct 2012 15:45:30 +0000 (16:45 +0100)]
s3-torture:test_ctdbconn: fix the build against older ctdb versions

by checking if we have the ctdb_protocol.h and including ctdb_private.h otherwise.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agos3:ctdb library: fix the build against older ctdb versions
Björn Baumbach [Wed, 17 Oct 2012 14:54:33 +0000 (16:54 +0200)]
s3:ctdb library: fix the build against older ctdb versions

by checking if we have the ctdb_protocol.h and including ctdb_private.h otherwise.

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agobuild(waf): check if we have ctdb_protocol.h in the cluster checks
Björn Baumbach [Tue, 30 Oct 2012 12:59:41 +0000 (13:59 +0100)]
build(waf): check if we have ctdb_protocol.h in the cluster checks

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agobuild(autoconf): check if we have ctdb_protocol.h in the cluster checks
Björn Baumbach [Tue, 30 Oct 2012 12:26:24 +0000 (13:26 +0100)]
build(autoconf): check if we have ctdb_protocol.h in the cluster checks

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agobuild(autoconf): fix check for ctdb_private.h
Björn Baumbach [Tue, 30 Oct 2012 12:40:48 +0000 (13:40 +0100)]
build(autoconf): fix check for ctdb_private.h

Signed-off-by: Björn Baumbach <bb@sernet.de>
Reviewed-by: Michael Adam <obnox@samba.org>
9 years agobuild(waf): fix the cluster(ctdb) build without system talloc installed
Michael Adam [Tue, 30 Oct 2012 13:43:42 +0000 (14:43 +0100)]
build(waf): fix the cluster(ctdb) build without system talloc installed

This is analogous to the earlier patch for tdb.
It temporarily adds the talloc include path to the
includes search list for the ctdb-header configure checks.

Signed-off-by: Michael Adam <obnox@samba.org>
Tested-by: Björn Baumbach <bb@sernet.de>
9 years agobuild(waf): fix a tab indentation to spaces
Michael Adam [Tue, 30 Oct 2012 13:41:04 +0000 (14:41 +0100)]
build(waf): fix a tab indentation to spaces

Signed-off-by: Michael Adam <obnox@samba.org>
9 years agotest-chgdcpass: test the ldap case for server password change
Andrew Tridgell [Thu, 1 Nov 2012 03:11:02 +0000 (14:11 +1100)]
test-chgdcpass: test the ldap case for server password change

use samba-tool drs options which does both RPC and LDAP connections

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

Autobuild-User(master): Andrew Tridgell <tridge@samba.org>
Autobuild-Date(master): Thu Nov  1 07:21:17 CET 2012 on sn-devel-104

9 years agos4-ldapclient: cope with logon failure retry in LDAP
Andrew Tridgell [Thu, 1 Nov 2012 03:10:14 +0000 (14:10 +1100)]
s4-ldapclient: cope with logon failure retry in LDAP

similar to what was done for rpc and cifs, we now retry once on logon
failure for ldap, allowing for a new ticket to be fetched when a
server password changes while we have a valid ticket for the old

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-librpc: set error code to LOGON_FAILURE on RPC fault with access denied
Andrew Tridgell [Thu, 1 Nov 2012 02:42:52 +0000 (13:42 +1100)]
s4-librpc: set error code to LOGON_FAILURE on RPC fault with access denied

this allows the client code to trigger a retry with a new password
callback for NTLM connections

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agosamba-tool: "drs options" does not need a samdb connection
Andrew Tridgell [Thu, 1 Nov 2012 02:31:47 +0000 (13:31 +1100)]
samba-tool: "drs options" does not need a samdb connection

this gives us a handy pure RPC client test for use in blackbox testing

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-librpc: try a 2nd logon for more error cases
Andrew Tridgell [Thu, 1 Nov 2012 02:30:47 +0000 (13:30 +1100)]
s4-librpc: try a 2nd logon for more error cases

not all servers give LOGON_FAILURE on authentication failures, so we
need to do the retry with a new ticket on a wider range of error types

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoldb: fixed callers for ldb_pack_data() and ldb_unpack_data()
Andrew Tridgell [Wed, 31 Oct 2012 05:06:03 +0000 (16:06 +1100)]
ldb: fixed callers for ldb_pack_data() and ldb_unpack_data()

with ltdb_pack_data() and ltdb_unpack_data() now moved into common, we
need to increase the minor version and fixup callers of the API

Note that this relies on struct ldb_val being the same shape as
TDB_DATA, in much the same way as we rely on ldb_val and DATA_BLOB
being the same shape.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoldb: move ldb_pack.c into common
Andrew Tridgell [Wed, 31 Oct 2012 04:39:09 +0000 (15:39 +1100)]
ldb: move ldb_pack.c into common

this code should not be tied to the ldb_tdb backend, both because it
could be used for any record oriented backend, and because it should
be exposed for use by diagnosis/repair tools such as the recently
added ldbdump tool

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agotest_chgdpass: use drs bind to test password change on RPC
Andrew Tridgell [Wed, 31 Oct 2012 07:45:25 +0000 (18:45 +1100)]
test_chgdpass: use drs bind to test password change on RPC

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agos4-librpc: use cli_credentials_failed_kerberos_login to cope with stale tickets
Andrew Tridgell [Wed, 31 Oct 2012 07:44:23 +0000 (18:44 +1100)]
s4-librpc: use cli_credentials_failed_kerberos_login to cope with stale tickets

This allows our RPC client code to cope with a kerberos server
changing password while we have a valid service ticket

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agotest_chgdpass: added test for kerberos retry
Andrew Tridgell [Wed, 31 Oct 2012 07:00:43 +0000 (18:00 +1100)]
test_chgdpass: added test for kerberos retry

this tests that we correctly retry with a new ccache entry when a
server changes its password while we have a valid ticket

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agolibcli: use cli_credentials_failed_kerberos_login() to cope with server changes
Andrew Tridgell [Wed, 31 Oct 2012 06:59:54 +0000 (17:59 +1100)]
libcli: use cli_credentials_failed_kerberos_login() to cope with server changes

if a server changes while we have a valid ticket we want to retry
after removing the ccache entry.

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoauth: added cli_credentials_failed_kerberos_login()
Andrew Tridgell [Wed, 31 Oct 2012 06:58:20 +0000 (17:58 +1100)]
auth: added cli_credentials_failed_kerberos_login()

this is used to support retrying kerberos connections after removing a
ccache entry, to cope with a server being re-built while our client
still has a valid service ticket

Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>

9 years agoutil: remove accidently committed hunk
Björn Jacke [Wed, 31 Oct 2012 14:31:08 +0000 (15:31 +0100)]
util: remove accidently committed hunk

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Wed Oct 31 19:25:30 CET 2012 on sn-devel-104

9 years agoAdd regression test for bug #9329 - Directory listing with SeBackup can crash smbd.
Jeremy Allison [Mon, 29 Oct 2012 21:49:36 +0000 (14:49 -0700)]
Add regression test for bug #9329 - Directory listing with SeBackup can crash smbd.

Ensure we exercise the SeBackup code path on directory listings.

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Wed Oct 31 03:21:38 CET 2012 on sn-devel-104

9 years agoldb: Add ldbdump, based on tdbdump
Andrew Bartlett [Tue, 30 Oct 2012 04:41:27 +0000 (15:41 +1100)]
ldb: Add ldbdump, based on tdbdump

This uses a tdb_traverse or (more usefully) the tdb_rescue API, like tdbdump.

The difference here is that it uses ldb helper functions to further
eliminate faulty records, which avoids creating duplicates in the output.

(The duplicates come from parts of records that are left in blank space
in the db, which tdb_rescue finds, but which are not actually a full

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 30 23:56:11 CET 2012 on sn-devel-104

9 years agoldb: Remove no-longer-existing ltdb_unpack_data_free from ldb_tdb.h
Andrew Bartlett [Mon, 29 Oct 2012 23:22:28 +0000 (10:22 +1100)]
ldb: Remove no-longer-existing ltdb_unpack_data_free from ldb_tdb.h

9 years agoldb: Change ltdb_unpack_data to take an ldb_context
Andrew Bartlett [Mon, 29 Oct 2012 23:21:42 +0000 (10:21 +1100)]
ldb: Change ltdb_unpack_data to take an ldb_context

It always de-references the module to find the ldb anyway.

Andrew Bartlett

9 years agosamba-tool: Add samba-tool processes subcommand
Andrew Bartlett [Mon, 29 Oct 2012 04:36:36 +0000 (15:36 +1100)]
samba-tool: Add samba-tool processes subcommand

This will allow administrators to inspect the process list in a
similar way to what running on a platform with setproctitle might

--pid= returns the registered server names for a PID (eg kdc, cldap_server)
--name= returns the pids registered with a particular name.

Andrew Bartlett

9 years agopymessaging: Add irpc_servers_byname() and irpc_all_servers()
Andrew Bartlett [Mon, 29 Oct 2012 04:34:41 +0000 (15:34 +1100)]
pymessaging: Add irpc_servers_byname() and irpc_all_servers()

This will allow python scripts to inspect the process list.

Andrew Bartlett

9 years agopymessaging: Use the server_id IDL structure rather than a tuple
Andrew Bartlett [Mon, 29 Oct 2012 04:33:59 +0000 (15:33 +1100)]
pymessaging: Use the server_id IDL structure rather than a tuple

This will make it easier to pass this structure in and out.  The tuple is still
accepted as input.

Andrew Bartlett

9 years agoimessaging: Add irpc_all_servers() to list all available servers
Andrew Bartlett [Mon, 29 Oct 2012 04:32:21 +0000 (15:32 +1100)]
imessaging: Add irpc_all_servers() to list all available servers

This is implemented with a tdb_traverse_read(), and will allow a tool
to disover the name and server_id of all Samba processes, as each
process registers itself to recieve messages.

Andrew Bartlett

9 years agos3fs-utils: Free the popt context in smbcacls and smbquotas.
Andreas Schneider [Mon, 29 Oct 2012 20:12:14 +0000 (21:12 +0100)]
s3fs-utils: Free the popt context in smbcacls and smbquotas.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed by: Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 30 20:22:46 CET 2012 on sn-devel-104

9 years agos3fs-net: Use talloc for memory allocation.
Andreas Schneider [Mon, 29 Oct 2012 20:12:13 +0000 (21:12 +0100)]
s3fs-net: Use talloc for memory allocation.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed by: Jeremy Allison <jra@samba.org>

9 years agos3:docs document shadow:snapdirseverywhere option of vfs_shadow_copy2
Christian Ambach [Tue, 30 Oct 2012 14:39:02 +0000 (15:39 +0100)]
s3:docs document shadow:snapdirseverywhere option of vfs_shadow_copy2

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Oct 30 18:32:57 CET 2012 on sn-devel-104

9 years agos3:smb2_read: fix SMBD_SMB2_NUM_IOV_PER_REQ check for sendfile() support (bug #9341)
Stefan Metzmacher [Tue, 30 Oct 2012 10:08:19 +0000 (11:08 +0100)]
s3:smb2_read: fix SMBD_SMB2_NUM_IOV_PER_REQ check for sendfile() support (bug #9341)

Reported-by: Sebastien LAVEZE <sebastien.laveze@mindspeed.com>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Tested-by: Sebastien LAVEZE <sebastien.laveze@mindspeed.com>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Oct 30 16:49:26 CET 2012 on sn-devel-104

9 years agowafbuild: use -Wstack-protector if available
Björn Jacke [Tue, 30 Oct 2012 12:00:58 +0000 (13:00 +0100)]
wafbuild: use -Wstack-protector if available

Autobuild-User(master): Björn Jacke <bj@sernet.de>
Autobuild-Date(master): Tue Oct 30 15:04:30 CET 2012 on sn-devel-104

9 years agowafbuild: use WERROR_FLAGS in wscript_configure_system_mitkrb5
Björn Jacke [Tue, 30 Oct 2012 11:19:24 +0000 (12:19 +0100)]
wafbuild: use WERROR_FLAGS in wscript_configure_system_mitkrb5

9 years agoccan/wafbuild: use WERROR_CFLAGS instead of -Werror
Björn Jacke [Tue, 30 Oct 2012 11:07:26 +0000 (12:07 +0100)]
ccan/wafbuild: use WERROR_CFLAGS instead of -Werror

9 years agowafbuild: reorder the Werror checks so that the ambigous w2 option is being checked...
Björn Jacke [Tue, 30 Oct 2012 10:48:25 +0000 (11:48 +0100)]
wafbuild: reorder the Werror checks so that the ambigous w2 option is being checked last

9 years agowafbuild: merge the missing IBM compiler Werror flag "-qhalt=w" to waf
Björn Jacke [Tue, 30 Oct 2012 10:37:34 +0000 (11:37 +0100)]
wafbuild: merge the missing IBM compiler Werror flag "-qhalt=w" to waf

9 years agowfabuild: fix the -errwarn compile flag test
Björn Jacke [Tue, 30 Oct 2012 10:32:52 +0000 (11:32 +0100)]
wfabuild: fix the -errwarn compile flag test

as in the autoconf build this must be "-errwarn=%all"

9 years agopackaging: Add NetworkManager dispatcher script for winbind.
Andreas Schneider [Fri, 26 Oct 2012 10:46:21 +0000 (12:46 +0200)]
packaging: Add NetworkManager dispatcher script for winbind.

Signed-off-by: Andreas Schneider <asn@cryptomilk.org>
Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Tue Oct 30 13:17:02 CET 2012 on sn-devel-104

9 years agos3: Use file_id_string in file_id_string_tos
Volker Lendecke [Mon, 29 Oct 2012 15:41:15 +0000 (16:41 +0100)]
s3: Use file_id_string in file_id_string_tos

Reviewed by Jeremy Allison <jra@samba.org>

Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Tue Oct 30 00:05:34 CET 2012 on sn-devel-104

9 years agos3: Fix some nonempty line endings
Volker Lendecke [Mon, 29 Oct 2012 15:35:49 +0000 (16:35 +0100)]
s3: Fix some nonempty line endings

Reviewed by Jeremy Allison <jra@samba.org>

9 years agolib/param: fix line length of DEBUG statments touched in previous commit in set_varia...
Michael Adam [Mon, 29 Oct 2012 14:16:04 +0000 (15:16 +0100)]
lib/param: fix line length of DEBUG statments touched in previous commit in set_variable()

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
Autobuild-User(master): Ira Cooper <ira@samba.org>
Autobuild-Date(master): Mon Oct 29 21:55:35 CET 2012 on sn-devel-104

9 years agolib/param: fix function name (set_variable) in debug statements
Michael Adam [Mon, 29 Oct 2012 13:52:50 +0000 (14:52 +0100)]
lib/param: fix function name (set_variable) in debug statements

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
9 years agolib/param: fix function name (lpcfg_file_list_changed) in a debug message
Michael Adam [Mon, 29 Oct 2012 12:44:54 +0000 (13:44 +0100)]
lib/param: fix function name (lpcfg_file_list_changed) in a debug message

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Ira Cooper <ira@samba.org>
9 years agos3:smbd:durable: remove a TODO comment about write time updates
Michael Adam [Tue, 23 Oct 2012 15:18:47 +0000 (17:18 +0200)]
s3:smbd:durable: remove a TODO comment about write time updates

This has been done.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): David Disseldorp <ddiss@samba.org>
Autobuild-Date(master): Mon Oct 29 20:12:18 CET 2012 on sn-devel-104

9 years agoBUG 9326: Fix net ads join message for the dns domain.
Andreas Schneider [Tue, 23 Oct 2012 15:12:59 +0000 (17:12 +0200)]
BUG 9326: Fix net ads join message for the dns domain.

We don't get a realm back from the server which is useable as a realm on
Unix. On Unix they are case sensitive and on Windows they aren't. This
confuses uses and if we write realm they try to use it as it came back
in lowercase.

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Günther Deschner <gd@samba.org>
Autobuild-User(master): Günther Deschner <gd@samba.org>
Autobuild-Date(master): Mon Oct 29 18:26:19 CET 2012 on sn-devel-104

9 years agoFix bug #9329 - Directory listing with SeBackup can crash smbd.
Jeremy Allison [Fri, 26 Oct 2012 00:07:29 +0000 (17:07 -0700)]
Fix bug #9329 - Directory listing with SeBackup can crash smbd.

When we do a become_root()/unbecome_root() pair to temporarily
raise privilege, this NULLs out the NT token. If we're within
a become_root()/unbecome_root() pair then return the previous
token on the stack as our NT token. This is what we should be
using to check against NT ACLs in the file server. This copes
with security context changing when removing a file on close
under the context of another user (when 2 users have a file
open, one sets delete on close and then the other user has
to actually do the delete).

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Michael Adam <obnox@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Mon Oct 29 16:26:20 CET 2012 on sn-devel-104

9 years agopackaging: Move smbprint to a comman location.
Andreas Schneider [Wed, 17 Oct 2012 16:25:41 +0000 (18:25 +0200)]
packaging: Move smbprint to a comman location.

This also removes all the duplicate smbprint scripts.

This fixes bug #9301.

Signed-off-by: Andreas Schneider <asn@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Mon Oct 29 14:08:37 CET 2012 on sn-devel-104

9 years agopidl: Remove depends_on=PIDL_MISC as it sets -I/ into CFLAGS
Andrew Bartlett [Sun, 28 Oct 2012 08:57:58 +0000 (19:57 +1100)]
pidl: Remove depends_on=PIDL_MISC as it sets -I/ into CFLAGS

This in turn causes an include of <net/if.h> to hang on some systems, as
/net/ means to run the automounter!

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Mon Oct 29 01:23:39 CET 2012 on sn-devel-104

9 years agobuild: Remove support for IDL-generated files in git tree
Andrew Bartlett [Sun, 28 Oct 2012 08:38:10 +0000 (19:38 +1100)]
build: Remove support for IDL-generated files in git tree

This was added in a9ea3d6fa510286b83c4bda42c9a857da3625451 but is no
longer required, as we do not store IDL-generated files in GIT.

Andrew Bartlett

9 years agolib/replace: Return size of xattr if size argument is 0
Andrew Bartlett [Sat, 27 Oct 2012 08:15:58 +0000 (19:15 +1100)]
lib/replace: Return size of xattr if size argument is 0

This makes rep_{f,}getxattr a more complete replacement for the linux function.

Andrew Bartlett

9 years agosource3.selftest: Move last variables to selftesthelpers.
Jelmer Vernooij [Sat, 27 Oct 2012 13:31:06 +0000 (05:31 -0800)]
source3.selftest: Move last variables to selftesthelpers.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat Oct 27 19:08:42 CEST 2012 on sn-devel-104

9 years agosource3.selftest: Move more variables to be in common.
Jelmer Vernooij [Sat, 27 Oct 2012 13:23:57 +0000 (05:23 -0800)]
source3.selftest: Move more variables to be in common.

9 years agoselftesthelpers: Fix detection of tap2subunit.
Jelmer Vernooij [Sat, 27 Oct 2012 01:31:40 +0000 (17:31 -0800)]
selftesthelpers: Fix detection of tap2subunit.

Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date(master): Sat Oct 27 16:57:49 CEST 2012 on sn-devel-104

9 years agoTestCaseInTempDir: Use addCleanup rather than tearDown.
Jelmer Vernooij [Fri, 26 Oct 2012 23:58:06 +0000 (15:58 -0800)]
TestCaseInTempDir: Use addCleanup rather than tearDown.

9 years agoselftest: Add --random-order option.
Jelmer Vernooij [Fri, 26 Oct 2012 23:53:57 +0000 (15:53 -0800)]
selftest: Add --random-order option.

9 years agosource4.selftest.tests: Add FIXME about database verification.
Jelmer Vernooij [Fri, 26 Oct 2012 22:40:09 +0000 (14:40 -0800)]
source4.selftest.tests: Add FIXME about database verification.

9 years agoselftesthelpers: Simplify detection of tap2subunit.
Jelmer Vernooij [Fri, 26 Oct 2012 22:14:42 +0000 (14:14 -0800)]
selftesthelpers: Simplify detection of tap2subunit.

9 years agosource3.selftests.tests: Use common plansmbtorture4testsuite() function.
Jelmer Vernooij [Fri, 26 Oct 2012 22:06:47 +0000 (14:06 -0800)]
source3.selftests.tests: Use common plansmbtorture4testsuite() function.

9 years agosource3.selftest.tests: Add suffix for smbclient3/ntlm_auth3.
Jelmer Vernooij [Fri, 26 Oct 2012 22:00:07 +0000 (14:00 -0800)]
source3.selftest.tests: Add suffix for smbclient3/ntlm_auth3.

9 years agosource3.selftest.tests: Remove tabs.
Jelmer Vernooij [Fri, 26 Oct 2012 21:56:30 +0000 (13:56 -0800)]
source3.selftest.tests: Remove tabs.

9 years agosource4.selftest.tests: Add suffix for smbclient4/nmblookup4.
Jelmer Vernooij [Fri, 26 Oct 2012 21:52:55 +0000 (13:52 -0800)]
source4.selftest.tests: Add suffix for smbclient4/nmblookup4.

9 years agoselftesthelpers: Add function for printing smbtorture4 version.
Jelmer Vernooij [Fri, 26 Oct 2012 21:51:54 +0000 (13:51 -0800)]
selftesthelpers: Add function for printing smbtorture4 version.

9 years agoselftest: Move determining of smbtorture4 options to selftesthelpers.
Jelmer Vernooij [Fri, 26 Oct 2012 21:38:32 +0000 (13:38 -0800)]
selftest: Move determining of smbtorture4 options to selftesthelpers.

9 years agoselftest/selftesthelpers: Share environment handling for extra smbtorture options.
Jelmer Vernooij [Fri, 26 Oct 2012 21:12:54 +0000 (13:12 -0800)]
selftest/selftesthelpers: Share environment handling for extra smbtorture options.

9 years agoselftest/selftesthelpers.py: Share configuration variable, strip whitespace.
Jelmer Vernooij [Fri, 26 Oct 2012 21:09:45 +0000 (13:09 -0800)]
selftest/selftesthelpers.py: Share configuration variable, strip whitespace.

9 years agoselftesthelpers: Share code for listing smbtorture4 tests.
Jelmer Vernooij [Fri, 26 Oct 2012 21:03:32 +0000 (13:03 -0800)]
selftesthelpers: Share code for listing smbtorture4 tests.

9 years agosource4.selftest.tests: Rename plansmbtorturesuite() to plansmbtorture4suite().
Jelmer Vernooij [Fri, 26 Oct 2012 19:51:19 +0000 (11:51 -0800)]
source4.selftest.tests: Rename plansmbtorturesuite() to plansmbtorture4suite().

9 years agosource4.selftest.tests: Consistent naming of smbtorture binary.
Jelmer Vernooij [Fri, 26 Oct 2012 19:50:41 +0000 (11:50 -0800)]
source4.selftest.tests: Consistent naming of smbtorture binary.

9 years agolibcli/smb: fix unitialized padding in smb2_create_blob_push_one() (bug #9209)
Stefan Metzmacher [Sat, 27 Oct 2012 06:11:14 +0000 (08:11 +0200)]
libcli/smb: fix unitialized padding in smb2_create_blob_push_one() (bug #9209)

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Sat Oct 27 10:05:22 CEST 2012 on sn-devel-104

9 years agosefltest: use TestCaseInTempDir and setUp/tearDown for posixacl.py temp file
Andrew Bartlett [Fri, 26 Oct 2012 23:59:43 +0000 (10:59 +1100)]
sefltest: use TestCaseInTempDir and setUp/tearDown for posixacl.py temp file

This manages the temp file more reliably, and reduces the repeated
code in each test case.

Pair-Programmed-With: Jelmer Vernooij <jelmer@samba.org>

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Sat Oct 27 04:37:58 CEST 2012 on sn-devel-104

9 years agoprovision: Fix comments in checksysvolacl
Andrew Bartlett [Fri, 26 Oct 2012 22:20:52 +0000 (09:20 +1100)]
provision: Fix comments in checksysvolacl

9 years agopam_winbind: fix segfault in pam_sm_authenticate()
David Disseldorp [Wed, 2 Nov 2011 17:39:03 +0000 (18:39 +0100)]
pam_winbind: fix segfault in pam_sm_authenticate()

Ensure the potentially null winbind context is not dereferenced on


Signed-off-by: Andreas Schneider <asn@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 22:40:57 CEST 2012 on sn-devel-104

9 years agontlm_auth: Increase debug level if we use config domain name.
Andreas Schneider [Fri, 26 Oct 2012 16:07:59 +0000 (18:07 +0200)]
ntlm_auth: Increase debug level if we use config domain name.

If an application like evolution-ews is using ntlm_auth it will alwys
get this message cause the is no winbind running and it is not needed.

Reviewed-by: Simo Sorce <idra@samba.org>
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date(master): Fri Oct 26 20:13:45 CEST 2012 on sn-devel-104

9 years agovfstest: set umask(0) in vfstest
Andrew Bartlett [Fri, 26 Oct 2012 03:23:39 +0000 (14:23 +1100)]
vfstest: set umask(0) in vfstest

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Fri Oct 26 10:07:03 CEST 2012 on sn-devel-104

9 years agopysmbd: Set umask to 0 during smbd operations
Andrew Bartlett [Fri, 26 Oct 2012 03:22:07 +0000 (14:22 +1100)]
pysmbd: Set umask to 0 during smbd operations

9 years agopysmbd: Remember to close files after setting the NT ACL
Andrew Bartlett [Thu, 25 Oct 2012 23:07:02 +0000 (10:07 +1100)]
pysmbd: Remember to close files after setting the NT ACL

9 years agopysmbd: Add hook for unlink() so python scripts can remove xattr.tdb entries
Andrew Bartlett [Fri, 26 Oct 2012 06:25:53 +0000 (17:25 +1100)]
pysmbd: Add hook for unlink() so python scripts can remove xattr.tdb entries

If we do not provide a way to remove files from xattr.tdb, we can re-use the inode.

Andrew Bartlett

9 years agos3:smbd:durable: factor stat checks out into vfs_default_durable_reconnect_check_stat()
Michael Adam [Tue, 23 Oct 2012 11:00:02 +0000 (13:00 +0200)]
s3:smbd:durable: factor stat checks out into vfs_default_durable_reconnect_check_stat()

This makes vfs_default_durable_reconnect() simpler to read
and it reduces code duplication in the failure case handling.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Thu Oct 25 23:03:13 CEST 2012 on sn-devel-104

9 years agopython-ntacls: Cope with ACL revision 4
Andrew Bartlett [Wed, 24 Oct 2012 07:24:12 +0000 (18:24 +1100)]
python-ntacls: Cope with ACL revision 4

This is the new revision with the hash of the posix or system ACL.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 25 15:04:39 CEST 2012 on sn-devel-104

9 years agodbwrap: use talloc_stackframe() in db_tdb_log_key()
Andrew Bartlett [Wed, 24 Oct 2012 07:23:04 +0000 (18:23 +1100)]
dbwrap: use talloc_stackframe() in db_tdb_log_key()

We can not be sure that there is already a talloc_stackframe() in place
so we must create one.

Andrew Bartlett

9 years agoselftest: Always unlink the tempf in posixacl test
Andrew Bartlett [Thu, 25 Oct 2012 09:18:28 +0000 (20:18 +1100)]
selftest: Always unlink the tempf in posixacl test

9 years agoselftest: Cover the important non-Samba invalidation of the NT ACL
Andrew Bartlett [Thu, 25 Oct 2012 09:17:55 +0000 (20:17 +1100)]
selftest: Cover the important non-Samba invalidation of the NT ACL

This covers the case where we have a valid hash of the posix ACL (or the NT ACL from the
POSIX ACL) and we notice it no longer matches.

Andrew Bartlett

9 years agoselftest: Cover one more NT ACL invalidation case and improve comments
Andrew Bartlett [Thu, 25 Oct 2012 08:58:15 +0000 (19:58 +1100)]
selftest: Cover one more NT ACL invalidation case and improve comments

This tries to show the difference between the cases where we trap
the POSIX ACL change and where we actually detect an OS-level change.

Andrew Bartlett

9 years agoselftest: Add many more tests for our posix ACL handling
Andrew Bartlett [Thu, 25 Oct 2012 05:27:19 +0000 (16:27 +1100)]
selftest: Add many more tests for our posix ACL handling

This tests the mapping of posix ACLs to NT ACLs, the invalidation of
NT ACLs stored as an xattr and ensures this security-critical code
continues to work in the long term.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 25 10:05:16 CEST 2012 on sn-devel-104

9 years agopysmbd: Fix pysmbd octal mode handling
Andrew Bartlett [Thu, 25 Oct 2012 05:25:22 +0000 (16:25 +1100)]
pysmbd: Fix pysmbd octal mode handling

It is clearly too long since Computer Science 101... ;-)

Andrew Bartlett

9 years agodsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING when there is no SID
Andrew Bartlett [Wed, 24 Oct 2012 05:41:52 +0000 (16:41 +1100)]
dsdb-cracknames: Return DRSUAPI_DS_NAME_STATUS_NO_MAPPING when there is no SID

If there is no SID for an object being mapped, then there is no NT4 name.

We need to return DRSUAPI_DS_NAME_STATUS_NO_MAPPING rather than
error out with anything other than WERR_OK as the return value.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Oct 25 04:43:25 CEST 2012 on sn-devel-104

9 years agos4:dns_server: fix formatting difference compared to v4-0-test
Stefan Metzmacher [Tue, 23 Oct 2012 13:00:27 +0000 (15:00 +0200)]
s4:dns_server: fix formatting difference compared to v4-0-test

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Stefan Metzmacher <metze@samba.org>
Autobuild-Date(master): Wed Oct 24 10:12:51 CEST 2012 on sn-devel-104

9 years agodsdb-cracknames: Always use talloc_zero()
Andrew Bartlett [Wed, 24 Oct 2012 00:56:02 +0000 (11:56 +1100)]
dsdb-cracknames: Always use talloc_zero()

Otherwise, we will return un-initialised values to the caller, which will
attempt to push them onto the wire.

Found by Greg Dickie <greg@justaguy.ca>.

Andrew Bartlett

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Wed Oct 24 05:12:04 CEST 2012 on sn-devel-104

9 years agobuild(waf): Fix the --with-cluster build
Michael Adam [Tue, 23 Oct 2012 13:53:17 +0000 (15:53 +0200)]
build(waf): Fix the --with-cluster build

The problem with the cluster/ctdb configure checks in Samba
currently is, that the headers need to include <tdb.h>.
If there are no system tdb headers, configure fails to find
tdb headers at this stage. Since the include is only required
for some defines (TDB_DATA), the workaround is to temporarily
add the included tdb copy's include path to the include search
path in the configure test. The ctdb we run against will most
likely have been compiled against a different version of TDB

To properly fix this, we might need to change ctdb to rely
on an external tdb library. Or to incorporate ctdb into samba
as a component that uses the same shipped tdb version.

Signed-off-by: Michael Adam <obnox@samba.org>
Signed-off-by: Volker Lendecke <vl@samba.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Autobuild-User(master): Michael Adam <obnox@samba.org>
Autobuild-Date(master): Tue Oct 23 18:29:26 CEST 2012 on sn-devel-104

9 years agolib/tsocket: fix loop in tdgram_bsd_recvfrom() (bug #9184)
Stefan Metzmacher [Tue, 2 Oct 2012 10:20:26 +0000 (12:20 +0200)]
lib/tsocket: fix loop in tdgram_bsd_recvfrom() (bug #9184)

If the socket is not readable yet, we need to retry
if tsocket_bsd_pending() returns 0.

See also


Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 23 14:44:21 CEST 2012 on sn-devel-104

9 years agobuild: Add #define FREEBSD on FreeBSD
Andrew Bartlett [Tue, 23 Oct 2012 06:53:58 +0000 (17:53 +1100)]
build: Add #define FREEBSD on FreeBSD

This makes waf match autoconf

Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Oct 23 11:11:44 CEST 2012 on sn-devel-104

9 years agolib/replace: Fix configure on FreeBSD: define_ret is not correct here
Andrew Bartlett [Tue, 23 Oct 2012 06:31:03 +0000 (17:31 +1100)]
lib/replace: Fix configure on FreeBSD: define_ret is not correct here

define_ret is for when the output of the compiled and run program
should be put into the configure define.  This is not the case

Andrew Bartlett

9 years agolib/replace: Fix detection of prctl
Andrew Bartlett [Tue, 23 Oct 2012 06:14:55 +0000 (17:14 +1100)]
lib/replace: Fix detection of prctl

9 years agolib/replace: Fix detection of rpcsrv/yp_prot.h on FreeBSD
Andrew Bartlett [Tue, 23 Oct 2012 06:14:43 +0000 (17:14 +1100)]
lib/replace: Fix detection of rpcsrv/yp_prot.h on FreeBSD

9 years agovfs: Fix compilation of ACL support on solaris
Andrew Bartlett [Tue, 23 Oct 2012 05:13:28 +0000 (16:13 +1100)]
vfs: Fix compilation of ACL support on solaris

9 years agowaf: Create a libnss_wins.so symlink.
Andreas Schneider [Wed, 17 Oct 2012 16:17:27 +0000 (18:17 +0200)]
waf: Create a libnss_wins.so symlink.

The last 3 patches fixe bug #9299 - nsswitch modules under Linux need a symbolic
to their so version library.


Reviewed-by: David Disseldorp <ddiss@samba.org>
Autobuild-User(master): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(master): Mon Oct 22 10:48:16 CEST 2012 on sn-devel-104

9 years agowaf: Create a libnss_winbind.so symlink.
Andreas Schneider [Wed, 17 Oct 2012 16:16:15 +0000 (18:16 +0200)]
waf: Create a libnss_winbind.so symlink.

This fixes bug #9299.

9 years agowafsamba: If we define a realname and a soname create a symlink.
Andreas Schneider [Wed, 17 Oct 2012 16:03:55 +0000 (18:03 +0200)]
wafsamba: If we define a realname and a soname create a symlink.

This is needed that libnss_winbind.so.2 and libnss_wins.so.2 will get a
corresponding symlinks.