STEP07: (TODO) check session key length !=0 in bind_auth_return
authorMichael Adam <obnox@samba.org>
Fri, 8 May 2015 21:45:42 +0000 (23:45 +0200)
committerMichael Adam <obnox@samba.org>
Fri, 15 May 2015 09:46:53 +0000 (11:46 +0200)
TODO: correct return code??

source3/smbd/smb2_sesssetup.c

index c8983ffd66b712b82824a851ea4c94e490a3c284..f821a23d771e019a48b359fa036e8f3a8bc5355a 100644 (file)
@@ -578,7 +578,10 @@ static NTSTATUS smbd_smb2_bind_auth_return(struct smbXsrv_session *session,
                return NT_STATUS_NOT_SUPPORTED;
        }
 
-       //TODO: verify session_info->session_key.length != 0
+       if (session_info->session_key.length == 0) {
+               /* TODO: return code? */
+               return NT_STATUS_LOGON_FAILURE;
+       }
 
        ZERO_STRUCT(session_key);
        memcpy(session_key, session_info->session_key.data,