Fix white space to match FreeRADIUS.

Change-Id: Ie814a790c15381036ba6bdb1d066012bb15bfb33
Reviewed-on: https://code.wireshark.org/review/21812
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Merge with FreeRADIUS.

They changed some names and added an attribute.

They also removed Aruba-AP-Name with no obvious indication of why; we
leave it in for now.

Give new URLs for attribute lists.

Change-Id: I270573b7d29f47572042abe46e4a531003e6a48e
Reviewed-on: https://code.wireshark.org/review/21811
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Merge with FreeRADIUS and update.

Pick up the copyright notice and $Id value.

Don't double-comment-out the items we handle in
packet-radius_packetcable.c; they're already commented out in the
FreeRADIUS version, and that reduces the number of differences between
us and them.  Note in a comment before them that we're handling them in
packet-radius_packetcable.c.

Add a comment pointing at various CableLabs specs before the attributes,
noting where in the specs they're mentioned. (Hint: NOT in a section
about RADIUS!  I guess the idea is that some protocol *other* than
RADIUS can be used to transfer them.)

Change-Id: Ib16fb10df9a434f79a05ce0537c671076aff11a2
Reviewed-on: https://code.wireshark.org/review/21810
Reviewed-by: Guy Harris <guy@alum.mit.edu>

sharkd: Fix build using system Speex library (autotools)

Change-Id: I1798f3dc76704c646d67d11533f8dc32ebab7401
Reviewed-on: https://code.wireshark.org/review/21793
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>

Fix capitalization of "WiMAX" in END-VENDOR.

Change-Id: I35e30b824b9ed8debfbb6a05d72b2396f7132204
Reviewed-on: https://code.wireshark.org/review/21809
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Update item for dictionary.airespace.

Change-Id: I5bacf0700a6bac4204a322d60812d5ece7a73be0
Reviewed-on: https://code.wireshark.org/review/21808
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Merge with the FreeRADIUS version.

Pick up the copyright notice and other comments.

Update the list of URLs, and include the new attributes as copied from
the Cisco support forum article.

Change-Id: I5f8c8833fa88e2538f3132c85a4baa4c8691eccb
Reviewed-on: https://code.wireshark.org/review/21807
Reviewed-by: Guy Harris <guy@alum.mit.edu>

dictionary.h3c is now the same as the FreeRADIUS one.

Change-Id: I0fe227ce7c0e8a3010c6d74eb8f511dd4986aba8
Reviewed-on: https://code.wireshark.org/review/21806
Reviewed-by: Guy Harris <guy@alum.mit.edu>

WSDG: trivial: fix a link

Asciidoc will just create a link from a URL that appears in the text. If
we want the link to appear as an address without a description, there's
no need to add an empty description. We should, however, have a space
behind the link to separate it from the text that follows.

Change-Id: Ic01b1dbbea922d785776f1965481ed58f389e30a
Reviewed-on: https://code.wireshark.org/review/21789
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

gif: expert info for unknown data block type

Before this patch, the dissector would assume that any data block type
that is unknown must be the trailer byte. Check explicitly if we have a
trailer byte and bring up an expert info for unknown data block types.

Change-Id: I4c3087eb403e2e668a22628062edd0240309a2bc
Reviewed-on: https://code.wireshark.org/review/21790
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Another update from FreeRADIUS.

Picks up copyright notice and

  commit 803477f565678f56bac8739aab0b11e0fdf0ff13
  Author: Mathieu Simon <mathieu.simon@simweb.ch>
  Date:   Mon Jan 20 16:04:17 2014 +0100

      Extend the H3C dictionary based on public manuals

      Try to extend the H3C dictionary based on what is scattered on
      their pages. At least most of it is found quite consistently in
      the product-specific "Security Configuration Guides".

      This compilation/crosschecking is based H3C documentation for
      listed devices:
      - H3C S12500 and S6800 Switches
      - H3C WA WLAN Access Points
      - H3C MSR Routers

      Remarks:
      Does not stick with H3C's use of of underline in attribute naming.

  commit 3046419a3a40d0146cea18083c496703b965d8c4
  Author: Mathieu Simon <mathieu.simon@simweb.ch>
  Date:   Mon Jan 20 14:56:00 2014 +0100

      Revisit H3C Exec-Privilege

      Try to match H3C terminology as close as to their documentation.

      - The Attribute name seems to not exactly match documentation,
        found consistently user i.e. in:
        - H3C S12500: Configurations Guides
        - H3C WA Series: Security Configuration Guide

      - Rename privilege levels to match H3C's documentation
        (previously likely more 3Com-ish). The levels naming
        are being used consistently mentioned throughout:
        - H3C SecPath F1000-E: Operational Manual
        - H3C S5500-SI: Operation Manual

  commit 6182027784b9a81af57f9e0e76bc80c94b2ba692
  Author: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
  Date:   Sun Jan 19 22:45:58 2014 +0000

      Add H3C HW-Exec-Privilege as posted by Mathieu Simon

Change-Id: I06d14266a5a60fdeb8ccf9d780db9526df86e5e3
Reviewed-on: https://code.wireshark.org/review/21805
Reviewed-by: Guy Harris <guy@alum.mit.edu>

dictionary.freeswitch is now the same as the FreeRADIUS one.

Change-Id: I885104eeb2a42a7bceb912f3bb437f48a8836c57
Reviewed-on: https://code.wireshark.org/review/21804
Reviewed-by: Guy Harris <guy@alum.mit.edu>

dictionary.nortel is now from the v4.0.x FreeRADIUS branch.

Change-Id: I4b6d4e7cce3e2e5a31d60aeeaa392c816f616f8e
Reviewed-on: https://code.wireshark.org/review/21803
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Another update from FreeRADIUS.

Picks up

  commit c329540701fecbd4ec0ca995a8cdafb907aca60a
  Author: Alan T. DeKok <aland@freeradius.org>
  Date:   Mon Feb 13 20:59:29 2012 +0100

      Added User-Role attribute

and adds copyright information.

Change-Id: I293213e39cf5b8fd44956e5a2b0c0153eb4243df
Reviewed-on: https://code.wireshark.org/review/21802
Reviewed-by: Guy Harris <guy@alum.mit.edu>

dictionary.eltex is now from FreeRADIUS.

Change-Id: Ic871389d71ac5b9a78d7a2023425df1acbd93447
Reviewed-on: https://code.wireshark.org/review/21801
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Another update from FreeRADIUS.

Includes

  commit 3128d4f1b562ddbcf3b2db2a54659be79f953262
  Author: Alan Buxey <alan.buxey@gmail.com>
  Date:   Sun Jul 21 23:01:57 2013 +0100

      more spelling issues cleared

from FreeRADIUS.

Change-Id: I94cc842306b5d0329eb3981acdee63dd877abff8
Reviewed-on: https://code.wireshark.org/review/21800
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Another update from FreeRADIUS.

Copyright, whitespace changs, adds missing END-VENDOR.

Change-Id: I1219f83a99e4ebee3af70498848a0b440c6c3bc1
Reviewed-on: https://code.wireshark.org/review/21799
Reviewed-by: Guy Harris <guy@alum.mit.edu>

packet-rsl.c: fixed emlpp priority bit range

Based on 3GPP TS 48.058 eMLPP Priority takes bits 1-3 not 1-2.
There is also decalred value_string rsl_emlpp_prio_vals (line 2605)
that contains 8 values not 4 as expected for 1-2 bits.

Change-Id: Iea77f8dbff9af3b25fd298f1a9703c1e34c06d30
Reviewed-on: https://code.wireshark.org/review/21797
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>

More updates from FreeRADIUS.

Picks up copyright notices, comment changes, and whitespace cleanups.

Change-Id: I42a265bb1f835bfa6cc1f6090d612b7a731f1b1a
Reviewed-on: https://code.wireshark.org/review/21798
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Update from FreeRADIUS.

See

    http://www.urbandictionary.com/define.php?term=authentification

Change-Id: Ia9756b160fc9a144a6fff1e51b6abb743faa4f69
Reviewed-on: https://code.wireshark.org/review/21796
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Copy over some comment-and-whitespace-only changes from FreeRADIUS.

This adds copyright notices and makes other cleanups.

Change-Id: I5975b563dffd704a336160d08efde42203c81676
Reviewed-on: https://code.wireshark.org/review/21795
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Sync up again.

They also fixed up the whitespace.

Change-Id: I44eb94bccfd24c027930b7e385255fbec7ca0431
Reviewed-on: https://code.wireshark.org/review/21794
Reviewed-by: Guy Harris <guy@alum.mit.edu>

radius: Sync with FreeRADIUS

add Dell EMC dictonary

commit 2b2a7dc5654abf740ff7ffb52fc0807a5e0f1781
Author: Alan T. DeKok <aland@freeradius.org>
Date:   Wed May 24 15:55:05 2017 -0400

    as posted to the list

Change-Id: If3e7e7f401c6f1eca5292f0f323c2cd86dfd3fcc
Reviewed-on: https://code.wireshark.org/review/21787
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Put back whitespace cleanups.

(I'll send those to the FreeRADIUS people.)

Change-Id: I9163c2710e2924e657b19f2d48bd310bb805244c
Reviewed-on: https://code.wireshark.org/review/21792
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Copy over the file from the current FreeRADIUS.

That adds the FreeRADIUS copyright notice.

Change-Id: Id6e05214a59b0fcf31e2c0f5ccd4a31632c08459
Reviewed-on: https://code.wireshark.org/review/21791
Reviewed-by: Guy Harris <guy@alum.mit.edu>

RADIUS: sync with FreeRADIUS

commit 766b61dc2b6a75ce66819891ae4d3dcf2d6954ed
Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
Date:   Mon May 29 16:56:02 2017 +0000

    dictionary.patton: fix indent

    using ./format.pl

commit 1c0c6d24953203417c18dbc7d02688d990c6d3d4
Author: Brice Schaffner <brice.schaffner@gmail.com>
Date:   Thu May 11 10:05:24 2017 +0000

    Added missing Patton Vendor Attributes

    Added some new Patton Vendor Attributes to the list.
    These attributes are now supported on the newest Patton device running on Trinity software version 3.11.2.

Change-Id: I4e1de392886494418e2e44d7f7a935c96a6f8425
Reviewed-on: https://code.wireshark.org/review/21786
Reviewed-by: Guy Harris <guy@alum.mit.edu>

GTK: Bugfix not allowing extcap capture filters to be verified.

Matches Id45052f21ebb290bf92c201370584156a65f2e19

Change-Id: I2b097d176ec3ce0637af95d66d2f58b834c79ea2
Reviewed-on: https://code.wireshark.org/review/21783
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Fix up dissector tables' UI names.

This was inspired by using the Decode-As UI to decode Field "SSL TCP Dissector"
Value (port) XXX as YYY.  "SSL Port" makes more sense as the UI name.

Change-Id: Id6398a5dc79e32bddc4f1bfcf0a468ae1364808f
Reviewed-on: https://code.wireshark.org/review/19573
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Extend display filter len() to support all string and byte field types.

len() can now handle FT_STRING, FT_STRINGZ, FT_STRINGZPAD,
FT_UINT_STRING, FT_BYTES, and FT_UINT_BYTES
through the use of fvalue_length()

Change-Id: I53baf2657f7804f64e63e4645d0b84b782ae9b08
Reviewed-on: https://code.wireshark.org/review/21775
Reviewed-by: Michael Mann <mmann78@netscape.net>

Qt: Fix capture filter verification for non-extcap interfaces.

Change-Id: Id45052f21ebb290bf92c201370584156a65f2e19
Reviewed-on: https://code.wireshark.org/review/21777
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Update some comments.

We're no longer commenting out dictionary.rfc6929 or dictionary.rfc6930,
as we now support those extensions.

Make other comments more closely resemble the tip of the master branch
in FreeRADIUS.

Change-Id: I19144bc6c6ff478d6637bf9679df2c737db82186
Reviewed-on: https://code.wireshark.org/review/21779
Reviewed-by: Guy Harris <guy@alum.mit.edu>

packet-mq: Handle MQV902

Add various new defines for WMQ902

Change-Id: I2000f35a01e484d2e4665d1fe4a91a74f6c33236
Reviewed-on: https://code.wireshark.org/review/21747
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

GTK+Qt: Show Osmux Packet Counter on Telephony menu

Change-Id: I565b0d2d43dd98781f77a302a20bd841e3e4650e
Reviewed-on: https://code.wireshark.org/review/21598
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>

Fixup support of BASE_UNIT_STRING for 64 bit based integer fields

proto.c’s proto_custom_set() was missing a test for
BASE_UNIT_STRING under the 64 bit based integer case.  Any
custom columns sourced from a field stored in a 64 bit integer
and having the BASE_UNIT_STRING attribute would only display the
units but not the actual number.

With this patch 64 bit based integer fields having the
BASE_UNIT_STRING attribute will now properly display both
their value and units when added to the packet list as a
custom column.

Change-Id: Icb9532771eb2f4098891dedd82886fd6223ce7a6
Reviewed-on: https://code.wireshark.org/review/21771
Petri-Dish: Jim Young <jim.young.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

proto_tree_add_bytes_format[_value] can handle NULL trees

v2.3.0rc0-3618-gd962e7ae71 tried to simplify logic, but missed
use of TRY_TO_FAKE_THIS_REPR.  Create a "friendlier" version
TRY_TO_FAKE_THIS_REPR_NESTED which allows for the "base"
proto_tree_add_xxx to be called in proto_tree_add_xxx_format[_value]
functions.

Bug: 13736
Change-Id: I98883ad4581d2327edb8da5efd8ef8a89b55e3d0
Reviewed-on: https://code.wireshark.org/review/21764
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

RADIUS: Add Vendor ID, Vendor Type and Vendor Length fields

Change-Id: I241bfb5d77374d8dd1428fb550d9e913a2d3570a
Reviewed-on: https://code.wireshark.org/review/21756
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

proto.c : fix indent

Change-Id: Ib2f9b7bee59d6fa60972df7adf7caaaf9921d975
Reviewed-on: https://code.wireshark.org/review/21776
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

cql: Dump row results

Bug: 13709
Change-Id: If96e947e14d5bd0ccdc52bf0b618f34c64dd6780
Signed-off-by: Benoît Canet <benoit@scylladb.com>
Reviewed-on: https://code.wireshark.org/review/21637
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

[Automatic update for 2017-05-28]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: Iac064b8029219fcd67a92db28a3209659113a978
Reviewed-on: https://code.wireshark.org/review/21772
Reviewed-by: Gerald Combs <gerald@wireshark.org>

List all plugin files for static build

The automake file has a list of plugin files used to support static
builds. This list should be consistent with the files in the tree.
This change aligns the list with the current plugin files.

Change-Id: I463a4dbf21651b1a8917049b5a705a93c0744591
Reviewed-on: https://code.wireshark.org/review/21698
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

LAPDm: Support the LAPDm B4 Frame Format

The B4 Frame Format is used on the downlink SACCH and has no length
field.

While the comment on top of packet-lapdm.c claimed ever since its
introduction in 2009 that B4 was a supported format, in fact it was not
supported yet.  This patch makes handling the length field conditional
to a frame format that has a length field, and introduces lapdm_data_t
that can be passed using call_dissector_with_data().

The GSMTAP dissector is updated to use this mechanism to specify the
frame format based on the channel type.

Change-Id: I52cb1cedbc8c7baf65e70d3e050e8932573647aa
Reviewed-on: https://code.wireshark.org/review/21767
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Qt: About dialog fails when configured without plugins

The about dialog compilation fails when plugins and LUA are disabled.
Add the missing preprocessor statements.
Also make the plugin tab really empty when there's nothing to report.

Change-Id: Idba0dc86e7110e56b2d949f517c966a121d28e47
Reviewed-on: https://code.wireshark.org/review/21768
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Report syntax errors in UAT prefs parsing

Add the cause for a syntax error while parsing UATs. Example output:

    $ tshark -ouat:ssl_keys:,
    tshark: Invalid -o flag "uat:ssl_keys:,": ssl_keys:1: No IP address given.
    $ tshark -ouat:unknown:,
    tshark: Invalid -o flag "uat:unknown:,": Unknown preference

Change-Id: I549406c4e31a81d29f487ef47bdb3c22da084947
Reviewed-on: https://code.wireshark.org/review/21748
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Reviewed-by: Michael Mann <mmann78@netscape.net>

WSUG: Add a TCP Analysis section.

Try to document as accurately as possible the circumstances under which
each TCP analysis flag is added.

Update some TCP debugging code.

Change-Id: I793756f73b8ade328e150acf32bc203792e29449
Reviewed-on: https://code.wireshark.org/review/21749
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Modbus: Add dissection of each bit for holding coils and discrete inputs

Bug: 13734
Change-Id: Ifd89bc1055edd7c123395ce0511594fc88d151a2
Reviewed-on: https://code.wireshark.org/review/21759
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Added IEEE CID support to the make-manuf script.  These prefixes are commonly used in IEEE 802.11 MAC address randomization.

Change-Id: I94ed29d31c81df0e4f514d7c354073182c116f75
Reviewed-on: https://code.wireshark.org/review/21737
Reviewed-by: Michael Mann <mmann78@netscape.net>

GTK: Don't allow extcap capture filters to be verified.

There isn't an API to do it and if WinPcap isn't present it can
cause a crash.

Change-Id: I5338f854acb26f0822ac027e6c853a550da3f7b1
Reviewed-on: https://code.wireshark.org/review/21758
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Don't try to compile capture filter if pcap_compile isn't available.

This is most likely due to WinPcap not being installed.

Bug: 13672
Change-Id: Ic7069f98c7f8068cdc5045204c2e23ab56b3f7eb
Reviewed-on: https://code.wireshark.org/review/21757
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>

FP - Fixed bug in heur PCH dissector

Calculated length in bits ( * 8 ) then checked as bytes

Change-Id: Ic9ef94bcdce40fc6463bf472d1e3a4a3cf05b1ba
Reviewed-on: https://code.wireshark.org/review/21755
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>

checkAPIs.pl: Add check to make sure tvb_get_ function isn't used in proto_tree_add_xxx

Check for situations for things like proto_tree_add_uint, where the "uint" passed
is a call to tvb_get_ntohl().  For that, proto_tree_add_item should be used.

Change-Id: Ibe14678bd66b05f612b125ca289f671c499a2990
Reviewed-on: https://code.wireshark.org/review/21685
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-lpp.c: Create temporary variables for some proto_tree_add_uint calculations.

Pacify checkAPIs.pl

Change-Id: I03be9eaa4f47df48d8809d205997ee4db47707b7
Reviewed-on: https://code.wireshark.org/review/21743
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-lte-rrc.c: Create temporary variables for some proto_tree_add_uint calculations.

Pacify checkAPIs.pl

Change-Id: I1801bd92aeb34e3e3240b15cef024718062852d7
Reviewed-on: https://code.wireshark.org/review/21744
Reviewed-by: Michael Mann <mmann78@netscape.net>

umts_fp: Fix Dereference of null pointer found by Clang analyzer

Change-Id: I9b35429d7599c95e0231cec835ac3cd1fca6b06b
Reviewed-on: https://code.wireshark.org/review/21752
Reviewed-by: sswsdev <sswsdev@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

umts_fp: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

Change-Id: Ia3f467e7cbec0a253da42b4d549de75330c91366
Reviewed-on: https://code.wireshark.org/review/21751
Reviewed-by: sswsdev <sswsdev@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

RADIUS: Add support for extended attributes (RFC 6929)

Bug: 13176
Change-Id: I22cdce01d8e7d5b69c2013684a98a9a48acc0d13
Reviewed-on: https://code.wireshark.org/review/21727
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

icq: Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

Change-Id: Ic009ea5bce2f349ede407e0bed3a8640262433d2
Reviewed-on: https://code.wireshark.org/review/21753
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Simplify proto_tree_add_bytes_format[_value]

Call proto_tree_add_bytes first so it can do all of the basic
field checks that were being duplicated.

Change-Id: Idc9a3cbf9498aa612a39cc80e3381eba52ce9fa4
Reviewed-on: https://code.wireshark.org/review/21750
Reviewed-by: Anders Broman <a.broman58@gmail.com>

packet-icq.c: Use more FT_UINT_STRING

Makes it simpler than proto_tree_add_string + tvb_get_string_enc combo.

Change-Id: Id25d1cc1ed727a6211d9ce113d54dd29c9bbdfcb
Reviewed-on: https://code.wireshark.org/review/21745
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-gsm_a_rr.c: proto_tree_add_uint -> proto_tree_add_bits_item

Change-Id: Iacf9328ddaa51f9459fd19752bcde70d9312e425
Reviewed-on: https://code.wireshark.org/review/21746
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

NBAP: Create E-DCH channel info

Adding missing creation and insertion of the E-DCH channel
info the the FP conversation info struct

Change-Id: Ic7dfb5b9579133ff84b2fc4fff73a3560055dcca
Reviewed-on: https://code.wireshark.org/review/21742
Reviewed-by: S. Shapira <sswsdev@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>

SMB2: set session server port in partial capture

When dissecting a capture that does not have a session setup exchange,
assume tree connect response packets are coming from the server and set
the port accordingly.

This is needed for decryption because the decryption key is different
depending on which side the message was created on. We need to set the
server port to know if a packet was made on the server.

Change-Id: I80229ed6d69821bc0c76808e57bdb2fc53fcceb3
Reviewed-on: https://code.wireshark.org/review/21741
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

[RANAP] Pretify info column.

Change-Id: I7f1832cd818d76843e00b689883e28ed46633585
Reviewed-on: https://code.wireshark.org/review/21739
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Revert "Fix issue with dissecting multiple DT1 packets in the frame"

Bug: 13651
This reverts commit daefa86695ecb6f859615ccd1bee6269e2c568a5.

Change-Id: I50eee7ae99bc471d95365a8da0271188d826ac46
Reviewed-on: https://code.wireshark.org/review/21738
Reviewed-by: Anders Broman <a.broman58@gmail.com>

UMTS FP: Fixed heuristic FACH dissector

Dissector was not adding the correct TB size & TB count to the conversation
info for the longer RACH variant (52 bytes long)

Change-Id: Iace894929684af3e0eb9804cbc57cdc169f136a9
Reviewed-on: https://code.wireshark.org/review/21736
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

ZigBee: Add attribute and command names from Events cluster

Bug: 13360
Change-Id: Ie6c5cb4d592490716204ff56dea11e92e071f740
Reviewed-on: https://code.wireshark.org/review/21662
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

[RANAP] Update to 3GPP TS 25.413 V14.0.0 (2017-03)

Change-Id: I5d448a4daf438b05a30473e999574803e5d6ade9
Reviewed-on: https://code.wireshark.org/review/21730
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-dccp.c: Don't use tvb_get_ptr for getting a uint number.

Use the tvb_get_ntohXXX instead.

Change-Id: I8d5c6ac2f2c8b1ac9237297f06709513fc2c9113
Reviewed-on: https://code.wireshark.org/review/21733
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-h261.c: Use proto_tree_add_item

Change-Id: Ifbb69d0bd2a71c4dd022c6dbae2ed84c2bf5f912
Reviewed-on: https://code.wireshark.org/review/21732
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-rfc2190.c: Use proto_tree_add_item instead of proto_tree_add_xxx.

Use hf_ fields with bitmasks instead of manually computing bits.

Change-Id: I342ac9288155647fc6600223f892513bab351a7c
Reviewed-on: https://code.wireshark.org/review/21731
Reviewed-by: Michael Mann <mmann78@netscape.net>

packet-megaco.c: Rename my_proto_tree_add_string -> megaco_tree_add_string.

It can trip up some of the check*.pl scripts and makes it clearer it's
very megaco specific.

Change-Id: Idb8ee104f59e07d5cfabd7aaedf23f915fad51b3
Reviewed-on: https://code.wireshark.org/review/21734
Reviewed-by: Michael Mann <mmann78@netscape.net>

Create temporary variables for some proto_tree_add_<datatype> calculations.

checkAPIs.pl doesn't like tvb_get_* parameters because it thinks
proto_tree_add_item should be used.  This is just to pacify the check.

Change-Id: I2df1233fe8c7976c257197079c06d24e472303b5
Reviewed-on: https://code.wireshark.org/review/21735
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

dnp3: fix parser when a packed variation is used with prefix value qualifier

Bug: 13733
Change-Id: I4d490793b54816e731d72bf1317d3779a05ae011
Reviewed-on: https://code.wireshark.org/review/21722
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>

[Automatic update for 2017-05-21]

Update manuf, services enterprise-numbers, translations, and other items.

Change-Id: I4a0774a6aa3ecb101b7ca0a87571544dc936012d
Reviewed-on: https://code.wireshark.org/review/21723
Reviewed-by: Gerald Combs <gerald@wireshark.org>

QUIC: fix some indent issue

Change-Id: If259cb4c37b10aca9f5b8e16f409acc8412f0622
Reviewed-on: https://code.wireshark.org/review/21719
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Revert "Change exports from Q.932 to use VALS_WITH_TABLE in the same way as QSIG"

This reverts commit d3b72329359103f298e4f633b8c83fe2ce3c7517.

Revert "Fix debian symbols check after Q.932 symbols removal"

This reverts commit 3bc43e377076d1097321e2f7ffc89f52ee33afa0.

Change-Id: Ib0623ab289613f48c73d38d038131a69cbf2190b
Reviewed-on: https://code.wireshark.org/review/21720
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>

If we don't have an ARUUID, don't use it as if we do.

Don't use random on-the-stack data as a UUID.

Change-Id: I77961e1404ad73a484a7fc865bc54219dc239b4d
Reviewed-on: https://code.wireshark.org/review/21721
Reviewed-by: Guy Harris <guy@alum.mit.edu>

UMTS FP: Refactored FP Conversation Info struct

Moved some fields which are only relevant to HS-DSCH / E-DCH  channel into appropriate 'channel specific' structs.
Also renamed "dchs_in_flow_list" to  "dch_ids_in_flow_list"

Change-Id: I7bdeb74c7b1eda0872c0243f0e5f229df2691866
Reviewed-on: https://code.wireshark.org/review/21707
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Show structures as FT_NONE, not FT_STRING.

Change-Id: I51577b6a92ff2401671065b1e6313db9a438c675
Reviewed-on: https://code.wireshark.org/review/21718
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Openflow(v6): enhance display of Port and Port Description

Change-Id: I6252989f5f57d68049da825da194e0443b91ae09
Reviewed-on: https://code.wireshark.org/review/21702
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Qt: Add check for packet bytes

Disable menu items handling packet bytes if not having any.

Bug: 13723
Change-Id: I9cdb1185910f865c61a8ee74e3cf3177159bf315
Reviewed-on: https://code.wireshark.org/review/21710
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>

Qt: Check for no tvb in Show Packet Bytes

Bug: 13723
Change-Id: I145fe93fc05a9cfdc6c0fc949274a1e88dcf2f1e
Reviewed-on: https://code.wireshark.org/review/21709
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>

msnip: Verify pinfo->dst is a valid IPv4 address

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1678
Bug: 13725
Change-Id: Ib61733200658b4cca0bb0f45e5445b0ed3c12ab0
Reviewed-on: https://code.wireshark.org/review/21712
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

IS-IS: Add support for CRYPTO_AUTH authentication type

CRYPTO_AUTH (generic cryptographic authentication) is documented in
RFC 5310, https://tools.ietf.org/html/rfc5310.

Sample IS-IS .pcap files using CRYPTO_AUTH (HMAC-SHA1/HMAC-SHA256) can
be found at https://c0decafe.de/svn/codename_loki/test/.

Bug: 13727
Change-Id: If25edc5985e13de56ab6bade570f06e0e9db276c
Reviewed-on: https://code.wireshark.org/review/21697
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

TLS: Add Reserved Extension type from GREASE

See https://tools.ietf.org/html/draft-ietf-tls-grease

Change-Id: I305a35c50f6aa94f94f20974babb7c871393f9e7
Reviewed-on: https://code.wireshark.org/review/21706
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

TLS: add Reserved Supported Group from GREASE

See https://tools.ietf.org/html/draft-ietf-tls-grease

Change-Id: Iaf5ec11eba3b28cff5d292326166eae26fabda99
Reviewed-on: https://code.wireshark.org/review/21705
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

TLS: Update list of Supported Groups Registry

https://www.iana.org/assignments/tls-parameters/tls-parameters.xhtml#tls-parameters-8

Change-Id: I5beca54eb4dc644647b0f40ec005d8e3bf23222f
Reviewed-on: https://code.wireshark.org/review/21704
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

TLS: Update draft tls-chacha20poly1305 to RFC 7905

and also remove some blankline

Change-Id: I5e66a64c95697f8e92d346b7b4c8956eadf967d3
Reviewed-on: https://code.wireshark.org/review/19955
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

TLS: Add Reserved cipher from GREASE

See https://tools.ietf.org/html/draft-ietf-tls-grease

Change-Id: I890e33a6b5afb51d768b0264023b51682642f867
Reviewed-on: https://code.wireshark.org/review/19871
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

Fix debian symbols check after Q.932 symbols removal

Change-Id: Ib68c11220b67f31f69c8fc1524f8492caa577f57
Fixes: v2.3.0rc0-3576-gd3b7232935 ("Change exports from Q.932 to use VALS_WITH_TABLE in the same way as QSIG")
Reviewed-on: https://code.wireshark.org/review/21708
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

Openflow(v6): Display reserved field for Port Description flag

Change-Id: I2d09e47fe54df7b0e5f89395b93c25d769566f42
Reviewed-on: https://code.wireshark.org/review/21703
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

SDP: Handle incomplete media attributes

Media attributes have a format of name:value, where, if the value
is missing the colon is missing too. Sometimes the colon is there,
while the value is missing. Even though this is in error, continue
dissecting the other attributes.

Bug: 13698
Change-Id: I369b6db657b33a368f4b12134412100774105615
Reviewed-on: https://code.wireshark.org/review/21699
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

afp: fix indent (use tab)

Change-Id: I774942860a5d82cfa9003e0363561374caa095ae
Reviewed-on: https://code.wireshark.org/review/21701
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Rename AVP Emergency-Indication to Emergency-Services

Renamed in 29.273 Rel 14

Change-Id: I171510869ed2c8a77a983e7c37bbdcb7494ad076
Reviewed-on: https://code.wireshark.org/review/21696
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

odb-ii: Fix Dereference of null pointer found by Clang analyzer

Change-Id: Ic19a59efffba1f19d3469445e8733fce8ab4cf98
Reviewed-on: https://code.wireshark.org/review/21689
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>

ZigBee: Fix proto_tree_add_item wrong last argument

Change-Id: Ie68acb7eb584be2ac30f9a257949d8d26661e95a
Reviewed-on: https://code.wireshark.org/review/21667
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

UMTS FP: Track Paging Indications in PCH

The dissector now carries the 'Paging Indication Bitmap' between subsequent PCH frames.
The reason for this is any frame containing the bitmap 'wakes up' users to read the subsequence frame. This feature allows us to see which paging groups were called for each frame.
Also refactored some Paging Indication related fields in the umts convoersation object and tree items.

Change-Id: I5e55e916ec31b60bc93238b397e07a1260906736
Reviewed-on: https://code.wireshark.org/review/21686
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

SMTP: allow multiple TCP ports/ranges to be registered

Change-Id: Ie470f6b2ffbdc156a1756466826ef6f42e54b8be
Reviewed-on: https://code.wireshark.org/review/21666
Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

mrdisc: Verify pinfo->dst is a valid IPv4 address

Change-Id: I828a60091ef59a0381feddfcb6dd7a0d20be67f9
Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1550
Bug: 13707
Reviewed-on: https://code.wireshark.org/review/21687
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Change exports from Q.932 to use VALS_WITH_TABLE in the same way as QSIG
(because value tables with WS_DLL_PUBLIC can not be used to initialize hf array)

Change-Id: I45f3a2783e8b0258de79c8198a0382a4281a02eb
Reviewed-on: https://code.wireshark.org/review/21690
Reviewed-by: Anders Broman <a.broman58@gmail.com>

UA/UDP: Create TLV for Connect and make fields filterable

Change-Id: I9c709fa2e69b7ac3a2c136c12d6810d4e716b15f
Reviewed-on: https://code.wireshark.org/review/21693
Reviewed-by: Anders Broman <a.broman58@gmail.com>