metze/wireshark/wip.git
7 years agoUpdate and add icons for capture comments / annotations.
Gerald Combs [Wed, 7 Mar 2012 20:56:01 +0000 (20:56 -0000)]
Update and add icons for capture comments / annotations.

svn path=/trunk/; revision=41406

7 years agoFrom Sylvain Munaut: Call the new dissector from the GSMTap dissector for GMR-1 chann...
Anders Broman [Wed, 7 Mar 2012 20:09:48 +0000 (20:09 -0000)]
From Sylvain Munaut: Call the new dissector from the GSMTap dissector for GMR-1 channels using LAPSat

svn path=/trunk/; revision=41405

7 years agoFrom Sylvain Munaut: Add support LAPSat : GMR-1 Datalink layer https://bugs.wireshark...
Anders Broman [Wed, 7 Mar 2012 19:53:03 +0000 (19:53 -0000)]
From Sylvain Munaut: Add support LAPSat : GMR-1 Datalink layer https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6918

svn path=/trunk/; revision=41404

7 years agoIEEE1588 PTPv2 over IPv6 -> Padding issue. https://bugs.wireshark.org/bugzilla/show_b...
Anders Broman [Wed, 7 Mar 2012 18:17:07 +0000 (18:17 -0000)]
IEEE1588 PTPv2 over IPv6 -> Padding issue. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6836

svn path=/trunk/; revision=41403

7 years agoThe User & Network direction is reversed https://bugs.wireshark.org/bugzilla/show_bug...
Anders Broman [Wed, 7 Mar 2012 17:02:27 +0000 (17:02 -0000)]
The User & Network direction is reversed https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6656

svn path=/trunk/; revision=41402

7 years agoFix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
Bill Meier [Wed, 7 Mar 2012 16:54:12 +0000 (16:54 -0000)]
Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
 (Use a valid 'parent field width' in the hf[] 'display' field.

svn path=/trunk/; revision=41401

7 years agoUpdate descriptions of hf[] FIELDDISPLAY and BITMASK fields.
Bill Meier [Wed, 7 Mar 2012 16:38:08 +0000 (16:38 -0000)]
Update descriptions of hf[] FIELDDISPLAY and BITMASK fields.

svn path=/trunk/; revision=41400

7 years agoRevise and enable test for hf[] FT_BOOLEAN fields with a non-zero bit mask and with...
Bill Meier [Wed, 7 Mar 2012 16:19:24 +0000 (16:19 -0000)]
Revise and enable test for hf[] FT_BOOLEAN fields with a non-zero bit mask and with BASE_... in the 'display' field.

svn path=/trunk/; revision=41399

7 years ago Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
Bill Meier [Wed, 7 Mar 2012 16:02:48 +0000 (16:02 -0000)]
 Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
 (Use a valid 'parent field width' in the hf[] 'display' field.

svn path=/trunk/; revision=41398

7 years agoAdd editor modelines; Fix some indentation.
Bill Meier [Wed, 7 Mar 2012 16:01:31 +0000 (16:01 -0000)]
Add editor modelines; Fix some indentation.

svn path=/trunk/; revision=41397

7 years agoFix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
Bill Meier [Wed, 7 Mar 2012 15:39:39 +0000 (15:39 -0000)]
Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
(Use a valid 'parent field width' in the hf[] 'display' field.

svn path=/trunk/; revision=41396

7 years agoISO SSAP: ActivityStart: Invalid decoding the activity parameter as a BER Integer...
Anders Broman [Wed, 7 Mar 2012 15:18:22 +0000 (15:18 -0000)]
ISO SSAP: ActivityStart: Invalid decoding the activity parameter as a BER Integer - decode as bytes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=2873

svn path=/trunk/; revision=41395

7 years agoFrom Yegor Yefremov: Add dissector for CANopen protocol https://bugs.wireshark.org...
Anders Broman [Wed, 7 Mar 2012 14:28:29 +0000 (14:28 -0000)]
From Yegor Yefremov: Add dissector for CANopen protocol https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6651 with some modifications

svn path=/trunk/; revision=41394

7 years agoLocation Number not decoded as per Q.763 https://bugs.wireshark.org/bugzilla/show_bug...
Anders Broman [Wed, 7 Mar 2012 12:06:16 +0000 (12:06 -0000)]
Location Number not decoded as per Q.763 https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6781

svn path=/trunk/; revision=41393

7 years agoComment fix: i10n -> i18n
Jörg Mayer [Wed, 7 Mar 2012 11:58:05 +0000 (11:58 -0000)]
Comment fix: i10n -> i18n

svn path=/trunk/; revision=41392

7 years agoUpdate Qt Documentation about translation/i18n
Alexis La Goutte [Wed, 7 Mar 2012 10:41:15 +0000 (10:41 -0000)]
Update Qt Documentation about translation/i18n

svn path=/trunk/; revision=41391

7 years agoFrom Joerg Mayer
Alexis La Goutte [Wed, 7 Mar 2012 10:23:50 +0000 (10:23 -0000)]
From Joerg Mayer
Add i18n to Cmake

svn path=/trunk/; revision=41390

7 years agoAdd i18n to QtShark
Alexis La Goutte [Wed, 7 Mar 2012 10:16:33 +0000 (10:16 -0000)]
Add i18n to QtShark
The goal is only to translate the Gui (Not dissector)
Actually, there is only a french translation.

To try, (if you are not French) launch qtshark with LANG=fr ./qtshark (in ui/qt folder)

Missing some feature :
* Add preference to select (force) your language
* Some Gui Text, it no available for translation
* Documentation about how to translate (Coming soon...)
* Your translation !

svn path=/trunk/; revision=41389

7 years agoUSB: unknown GET DESCRIPTOR response triggers assert failure https://bugs.wireshark...
Anders Broman [Wed, 7 Mar 2012 09:35:44 +0000 (09:35 -0000)]
USB: unknown GET DESCRIPTOR response triggers assert failure https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6826

svn path=/trunk/; revision=41388

7 years agoFrom Martin Kaiser: correct sorting for wiretap's file type list
Anders Broman [Wed, 7 Mar 2012 08:03:42 +0000 (08:03 -0000)]
From Martin Kaiser: correct sorting for wiretap's file type list

svn path=/trunk/; revision=41387

7 years agoWhitespace cleanup.
Bill Meier [Tue, 6 Mar 2012 22:29:42 +0000 (22:29 -0000)]
Whitespace cleanup.

svn path=/trunk/; revision=41386

7 years agoFix benign issue: For FT_BOOLEAN fields with a zero bitmask, use BASE_NONE for 'display'
Bill Meier [Tue, 6 Mar 2012 22:12:42 +0000 (22:12 -0000)]
Fix benign issue: For FT_BOOLEAN fields with a zero bitmask, use BASE_NONE for 'display'

svn path=/trunk/; revision=41385

7 years agoReformat long lines...
Bill Meier [Tue, 6 Mar 2012 22:00:59 +0000 (22:00 -0000)]
Reformat long lines...

svn path=/trunk/; revision=41384

7 years agoFix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
Bill Meier [Tue, 6 Mar 2012 21:12:43 +0000 (21:12 -0000)]
Fix incorrect packet-details display of certain 1 bit FT_BOOLEAN fields.
Also: reformat a few lines.

svn path=/trunk/; revision=41383

7 years agoAdd a note about using GetSystemTimePreciseAsFileTime.
Gerald Combs [Tue, 6 Mar 2012 21:11:31 +0000 (21:11 -0000)]
Add a note about using GetSystemTimePreciseAsFileTime.

svn path=/trunk/; revision=41382

7 years agoAdd an entry for annotations.
Gerald Combs [Tue, 6 Mar 2012 21:11:08 +0000 (21:11 -0000)]
Add an entry for annotations.

svn path=/trunk/; revision=41381

7 years agoAdd test for correct usage of hf[] FT_BOOLEAN 'display' field;
Bill Meier [Tue, 6 Mar 2012 20:56:51 +0000 (20:56 -0000)]
Add test for correct usage of hf[] FT_BOOLEAN 'display' field;
(Commented out until all the incorrect usages in Wireshark have been fixed).

svn path=/trunk/; revision=41380

7 years agoEmphasize corrext usage of FT_BOOLEAN 'display' field.
Bill Meier [Tue, 6 Mar 2012 20:51:50 +0000 (20:51 -0000)]
Emphasize corrext usage of FT_BOOLEAN 'display' field.
Specificaly:
 For a field type FT_BOOLEAN:
 - If the bitmask field is zero, then the 'display' field
   must be 'BASE_NONE';
 - If the bitmask field is non-zero, then the 'display' field
   must be the field-width of the parent bit field.

svn path=/trunk/; revision=41379

7 years agoFix incorrect packet-details display of a 1 bit FT_BOOLEAN field.
Bill Meier [Tue, 6 Mar 2012 20:11:43 +0000 (20:11 -0000)]
Fix incorrect packet-details display of a 1 bit FT_BOOLEAN field.

svn path=/trunk/; revision=41378

7 years agoUse tvb_new_subset_remaining(...) rather than tvb_new_subset(...,-1,-1);
Bill Meier [Tue, 6 Mar 2012 17:33:35 +0000 (17:33 -0000)]
Use tvb_new_subset_remaining(...) rather than tvb_new_subset(...,-1,-1);
Fix up a number of the comments;
Use #if 0/#endif rather than /* */ to comment out code;
Do some minor reformatting.

svn path=/trunk/; revision=41377

7 years agoUse tvb_new_subset_remaining(...) rather than tvb_new_subset(...,-1,-1).
Bill Meier [Tue, 6 Mar 2012 17:24:21 +0000 (17:24 -0000)]
Use tvb_new_subset_remaining(...) rather than tvb_new_subset(...,-1,-1).

svn path=/trunk/; revision=41376

7 years agoUse tvb_new-subset_remaining(...) rather than tvb_new_subset(...,-1,-1);
Bill Meier [Tue, 6 Mar 2012 17:11:01 +0000 (17:11 -0000)]
Use tvb_new-subset_remaining(...) rather than tvb_new_subset(...,-1,-1);
Add an additional note about duplicate filter names in the hf[] array;
Convert "4 space tabs" to 4 spaces.

svn path=/trunk/; revision=41375

7 years agoUse tvb_new_subset_remaining() rather than tvb_new_subset();
Bill Meier [Tue, 6 Mar 2012 16:58:09 +0000 (16:58 -0000)]
Use tvb_new_subset_remaining() rather than tvb_new_subset();
#include <styring.h> not req'd (in a few cases);
Minor reformating & whitespace cleanup.

svn path=/trunk/; revision=41374

7 years agoCall X2AP dissector.
Martin Mathieson [Tue, 6 Mar 2012 13:56:02 +0000 (13:56 -0000)]
Call X2AP dissector.

svn path=/trunk/; revision=41373

7 years agoFrom Steve Magnani: USB: incorrect decoding of Endpoint-targeted class-specific SETUP...
Anders Broman [Tue, 6 Mar 2012 09:25:53 +0000 (09:25 -0000)]
From Steve Magnani: USB: incorrect decoding of Endpoint-targeted class-specific SETUP https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6910

svn path=/trunk/; revision=41371

7 years agoTry to make the buildbot happy
Anders Broman [Tue, 6 Mar 2012 09:24:49 +0000 (09:24 -0000)]
Try to make the buildbot happy

svn path=/trunk/; revision=41370

7 years agoFrom Martin Kaiser: capture dialogue: unitialized pointer is dereferenced, assigning...
Anders Broman [Tue, 6 Mar 2012 09:16:50 +0000 (09:16 -0000)]
From Martin Kaiser: capture dialogue: unitialized pointer is dereferenced, assigning an arbitrary dlt to a capture interface https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6914

svn path=/trunk/; revision=41369

7 years agoFrom Mike Wakerly: Add wiretap suport for LINKTYPE_NFC_LLCP
Anders Broman [Tue, 6 Mar 2012 09:02:06 +0000 (09:02 -0000)]
From Mike Wakerly: Add wiretap suport for LINKTYPE_NFC_LLCP

svn path=/trunk/; revision=41368

7 years agoFrom Cal Turney: Try to fix the remaining warnings. https://bugs.wireshark.org/bugzil...
Anders Broman [Tue, 6 Mar 2012 08:45:54 +0000 (08:45 -0000)]
From Cal Turney: Try to fix the remaining warnings. https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6883

svn path=/trunk/; revision=41367

7 years agoUse tvb_new_subset_remaining() rather than tvb_new_subset();
Bill Meier [Tue, 6 Mar 2012 03:20:17 +0000 (03:20 -0000)]
Use tvb_new_subset_remaining() rather than tvb_new_subset();
Do minir whitespace cleanup.

svn path=/trunk/; revision=41366

7 years agoUse tvb_new_subset_remaining() instead of tvb_new_subset();
Bill Meier [Tue, 6 Mar 2012 02:28:04 +0000 (02:28 -0000)]
Use tvb_new_subset_remaining() instead of tvb_new_subset();
Reformat some long lines.

svn path=/trunk/; revision=41365

7 years agoProhibit using anything other than FT_BOOLEANs with true_false_strings.
Jeff Morriss [Tue, 6 Mar 2012 02:27:29 +0000 (02:27 -0000)]
Prohibit using anything other than FT_BOOLEANs with true_false_strings.
Prohibit using FT_BOOLEANS with value_strings.

svn path=/trunk/; revision=41364

7 years agoDon't use FT_BOOLEAN with value_strings: the code to generate
Jeff Morriss [Tue, 6 Mar 2012 02:19:23 +0000 (02:19 -0000)]
Don't use FT_BOOLEAN with value_strings: the code to generate
representations of former is expecting true_false_strings--which are quite
different than the latter.

svn path=/trunk/; revision=41363

7 years agoDon't use FT_*INT with true_false strings: the code to generate
Jeff Morriss [Tue, 6 Mar 2012 02:04:10 +0000 (02:04 -0000)]
Don't use FT_*INT with true_false strings: the code to generate
representations of former is expecting value_strings--which are quite
different than the latter.

svn path=/trunk/; revision=41362

7 years agoDon't use FT_*INT with true_false strings: the code to generate
Jeff Morriss [Tue, 6 Mar 2012 01:55:21 +0000 (01:55 -0000)]
Don't use FT_*INT with true_false strings: the code to generate
representations of former is expecting value_strings--which are quite
different than the latter.

svn path=/trunk/; revision=41361

7 years agoBinary and source tarballs should be compressed with bzip2 only
Jörg Mayer [Mon, 5 Mar 2012 22:13:09 +0000 (22:13 -0000)]
Binary and source tarballs should be compressed with bzip2 only
(xz is not an options that cmake offers).

svn path=/trunk/; revision=41360

7 years agoFix the infinite-loop fuzz failure reported in https://bugs.wireshark.org/bugzilla...
Jeff Morriss [Mon, 5 Mar 2012 21:59:52 +0000 (21:59 -0000)]
Fix the infinite-loop fuzz failure reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6907 :

Don't try to display tone entries if there are none (but there is length for
them).  Could/should be an expert_info.

svn path=/trunk/; revision=41359

7 years agoFix filter name: "iee17221.channels" --> "ieee17221.channels"
Bill Meier [Mon, 5 Mar 2012 20:50:25 +0000 (20:50 -0000)]
Fix filter name: "iee17221.channels" --> "ieee17221.channels"

svn path=/trunk/; revision=41358

7 years agoVarious changes:
Bill Meier [Mon, 5 Mar 2012 18:57:18 +0000 (18:57 -0000)]
Various changes:
- Use proper proto_tree_add_item() 'encoding' arg (instead of TRUE/FALSE);
- Call col_append_fstr() even when 'tree==NULL';
- Use value_string_ext to access the larger value_string tables;
- Handle tvb_reported_length() can return -1;
- Remove 'set but never used' variable and associated line of code;
- Remove unneeded #include <prefs.h>;
- Remove empty proto_reg_handoff();
- Do minor whitespace cleanup.

svn path=/trunk/; revision=41357

7 years agoUse a dedicated treview for packet comments.
Anders Broman [Mon, 5 Mar 2012 13:34:55 +0000 (13:34 -0000)]
Use a dedicated treview for packet comments.

svn path=/trunk/; revision=41356

7 years agoFrom Cal Turney:
Anders Broman [Mon, 5 Mar 2012 12:06:26 +0000 (12:06 -0000)]
From Cal Turney:
Bugs in the tshark '-z io,stat' output:
1: The LOAD stat in the last row of the output is inaccurate because rpc.time
is divided by the full interval rather than limiting it to the capture
duration.
2: An The empty comma field (for outputting total frames and bytes) is ignored
when it is the first field in the command.
3: Intervals at the end of capture that contain no data are not displayed. Such
intervals are as important to see as those (zero data intervals) that occur
earlier in the capture.
4: Floating point numbers are not properly aligned under their column headers.

Enhancements to '-z io,stat' output:
1. Column widths are determined by the maximum magnitude of their values rather
than set to a fixed width of 15 chars which allows for more stats to be
displayed per row without wrapping.
2. To improve readability, filters wrap at 102 chars or the table width,
whichever is greater, and wrap on the nearest space. An option can be added to
alter the 102-char limit.
3. Column numbers begin at 1 instead of 0.
4. The columns and entire output are enclosed in a border for improved
presentability in reports. The table can be imported into a spreadsheet by
specifying the vertical bar as the data delimiter.

"Fixed" compiling on Ubuntu

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6883

svn path=/trunk/; revision=41355

7 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Mon, 5 Mar 2012 09:50:42 +0000 (09:50 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41354

7 years agoFrom Ryan Doyle via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6874
Alexis La Goutte [Mon, 5 Mar 2012 09:49:37 +0000 (09:49 -0000)]
From Ryan Doyle via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6874
New dissector: performance co-pilot protocol

Attached patch implements dissection of the Performance Co-Pilot (PCP) protocol.

From me :
* Add Wireshark Modelines
* Fix encoding args
* Fix Clang Warning

svn path=/trunk/; revision=41353

7 years agoUse correct lenght when writing if_filter_str.
Anders Broman [Mon, 5 Mar 2012 09:32:21 +0000 (09:32 -0000)]
Use correct lenght when writing if_filter_str.

svn path=/trunk/; revision=41352

7 years agoFix calculation of pading for if_filter_str.
Anders Broman [Mon, 5 Mar 2012 09:21:36 +0000 (09:21 -0000)]
Fix calculation of pading for if_filter_str.

svn path=/trunk/; revision=41351

7 years agoFrom Martin Kaiser:
Anders Broman [Mon, 5 Mar 2012 08:34:36 +0000 (08:34 -0000)]
From Martin Kaiser:
wiretap mpeg2 ts: eof vs short read
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6909

svn path=/trunk/; revision=41350

7 years agoFrom Martin Kaiser:
Anders Broman [Mon, 5 Mar 2012 08:30:39 +0000 (08:30 -0000)]
From Martin Kaiser:
wiretap mpeg2 ts: more thorough check for sync byte.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6908

svn path=/trunk/; revision=41349

7 years agoFix comment.
Guy Harris [Mon, 5 Mar 2012 06:43:44 +0000 (06:43 -0000)]
Fix comment.

svn path=/trunk/; revision=41347

7 years agoTrust but verify that there's no g_snprintf() buffer overflow.
Bill Meier [Mon, 5 Mar 2012 00:46:31 +0000 (00:46 -0000)]
Trust but verify that there's no g_snprintf() buffer overflow.

svn path=/trunk/; revision=41346

7 years agoCleanup:
Bill Meier [Mon, 5 Mar 2012 00:01:28 +0000 (00:01 -0000)]
Cleanup:
- packet-erf.h not used elsewhere; move to packet-erf.c;
- reformat long lines;
- minor code re-arrangement;
- whitespace cleanup.

svn path=/trunk/; revision=41345

7 years agoFix bugs in buffer overflow checking used with calls to g_snprintf();
Bill Meier [Sun, 4 Mar 2012 23:34:58 +0000 (23:34 -0000)]
Fix bugs in buffer overflow checking used with calls to g_snprintf();

svn path=/trunk/; revision=41344

7 years ago(Trivial) Fix a typo.
Bill Meier [Sun, 4 Mar 2012 23:01:39 +0000 (23:01 -0000)]
(Trivial) Fix a typo.

svn path=/trunk/; revision=41343

7 years agoSquelch a can't-really-happen uninitialized reference warning.
Guy Harris [Sun, 4 Mar 2012 20:49:17 +0000 (20:49 -0000)]
Squelch a can't-really-happen uninitialized reference warning.

svn path=/trunk/; revision=41342

7 years agoUse parentheses
Anders Broman [Sun, 4 Mar 2012 19:31:33 +0000 (19:31 -0000)]
Use parentheses

svn path=/trunk/; revision=41341

7 years agoforgotten update
Anders Broman [Sun, 4 Mar 2012 19:03:03 +0000 (19:03 -0000)]
forgotten update

svn path=/trunk/; revision=41340

7 years agoif_filter isn't a string per se,The first byte of the Option Data keeps a code of...
Anders Broman [Sun, 4 Mar 2012 19:01:14 +0000 (19:01 -0000)]
if_filter isn't a string per se,The first byte of the Option Data keeps a code of the filter used

svn path=/trunk/; revision=41339

7 years agoFrom Martin Kaiser: DVB-CI authentication resource https://bugs.wireshark.org/bugzill...
Anders Broman [Sun, 4 Mar 2012 16:16:03 +0000 (16:16 -0000)]
From Martin Kaiser: DVB-CI authentication resource https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6905

svn path=/trunk/; revision=41338

7 years ago"From Jan Šafránek: Add support for AES in Microsoft Network Logon Negotiation option...
Anders Broman [Sun, 4 Mar 2012 16:07:24 +0000 (16:07 -0000)]
"From Jan Šafránek: Add support for AES in Microsoft Network Logon Negotiation options https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6895"

svn path=/trunk/; revision=41337

7 years ago[Automatic manuf, services and enterprise-numbers update for 2012-03-04]
Gerald Combs [Sun, 4 Mar 2012 15:03:37 +0000 (15:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-03-04]

svn path=/trunk/; revision=41334

7 years agoMake sure all names in NRB records are null-terminated; report an error
Guy Harris [Sun, 4 Mar 2012 02:20:25 +0000 (02:20 -0000)]
Make sure all names in NRB records are null-terminated; report an error
if they're not.  Also report an error for zero-length names.

Handle multiple names per IP address - the pcap-NG spec says "one or
more zero-terminated strings containing the DNS entries for that
address."

Use a Buffer to hold NRB records, so there's no maximum size (well,
there is a maximum size, because the record length is 16 bits, but let's
not allocate 64KiB on the stack if we don't have to).

svn path=/trunk/; revision=41332

7 years agoChange all hf[] FT_UINT? fields referencing 'avp_bool_vals' to be FT_BOOLEAN fields.
Bill Meier [Sat, 3 Mar 2012 21:58:38 +0000 (21:58 -0000)]
Change all hf[] FT_UINT? fields referencing 'avp_bool_vals' to be FT_BOOLEAN fields.
#include <stdio.h> not req'd;
Add editor modelines for "3 space" indentation.

svn path=/trunk/; revision=41331

7 years agoFrom Jose Pedro Oliveira: Fix typos
Anders Broman [Sat, 3 Mar 2012 16:17:20 +0000 (16:17 -0000)]
From Jose Pedro Oliveira: Fix typos

svn path=/trunk/; revision=41330

7 years agoUse 'wireshark' icon from theme
Balint Reczey [Sat, 3 Mar 2012 15:40:38 +0000 (15:40 -0000)]
Use 'wireshark' icon from theme

This makes Wireshark able to use SVG icon when it is installed

svn path=/trunk/; revision=41329

7 years agoUse wtap_dump_open_ng(), so we preserve all the interfaces in pcap-NG
Guy Harris [Sat, 3 Mar 2012 00:14:16 +0000 (00:14 -0000)]
Use wtap_dump_open_ng(), so we preserve all the interfaces in pcap-NG
files.

svn path=/trunk/; revision=41328

7 years agoDon't look at the interface_id field of the packet header if
Guy Harris [Sat, 3 Mar 2012 00:13:25 +0000 (00:13 -0000)]
Don't look at the interface_id field of the packet header if
WTAP_HAS_INTERFACE_ID isn't set in the presence flags.

svn path=/trunk/; revision=41327

7 years agoMake SVG images useable as icons
Balint Reczey [Fri, 2 Mar 2012 23:31:48 +0000 (23:31 -0000)]
Make SVG images useable as icons

svn path=/trunk/; revision=41326

7 years agoDon't add an FT_BYTES with proto_tree_add_uint().
Jeff Morriss [Fri, 2 Mar 2012 22:24:12 +0000 (22:24 -0000)]
Don't add an FT_BYTES with proto_tree_add_uint().

svn path=/trunk/; revision=41325

7 years agoFix a few bugs found by Clang analysis:
Jeff Morriss [Fri, 2 Mar 2012 20:17:36 +0000 (20:17 -0000)]
Fix a few bugs found by Clang analysis:

packet-ieee17221.c:3123:10: warning: Value stored to 'mr_offset' is never read
- Put the offset increment inside the loop

packet-ieee17221.c:2888:10: warning: Value stored to 'mr_subtree' is never read
 - Use the newly-created subtree (instead of the parent tree)

packet-ieee17221.c:2692:13: warning: Value stored to 'next_tvb' is never read
- Use next_tvb (instead of the main tvb which doesn't start at the
  correct offset)

svn path=/trunk/; revision=41324

8 years agoTypo
Anders Broman [Fri, 2 Mar 2012 13:53:30 +0000 (13:53 -0000)]
Typo

svn path=/trunk/; revision=41323

8 years agoUse the expert system to show packet comments.
Anders Broman [Fri, 2 Mar 2012 13:31:16 +0000 (13:31 -0000)]
Use the expert system to show packet comments.
The packet comment widget should be replaced by a ListView with two columns,  packet no and Comment.

svn path=/trunk/; revision=41322

8 years agoUpdate comment - now that we support adding comments to files, a capture
Guy Harris [Fri, 2 Mar 2012 11:41:50 +0000 (11:41 -0000)]
Update comment - now that we support adding comments to files, a capture
that we've saved to a particular path, or that we've read in, could
still be unsaved if we add comments to it.

svn path=/trunk/; revision=41321

8 years agoFix indentation.
Guy Harris [Fri, 2 Mar 2012 11:36:44 +0000 (11:36 -0000)]
Fix indentation.

svn path=/trunk/; revision=41320

8 years agoRemove now unused variables.
Anders Broman [Fri, 2 Mar 2012 11:25:17 +0000 (11:25 -0000)]
Remove now unused variables.

svn path=/trunk/; revision=41319

8 years agoFix typo and add Modelines information
Alexis La Goutte [Fri, 2 Mar 2012 11:11:59 +0000 (11:11 -0000)]
Fix typo and add Modelines information

svn path=/trunk/; revision=41318

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:10:08 +0000 (11:10 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41317

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:09:47 +0000 (11:09 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41316

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:09:34 +0000 (11:09 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41315

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:09:15 +0000 (11:09 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41314

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:08:49 +0000 (11:08 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41313

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:07:50 +0000 (11:07 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41312

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:07:36 +0000 (11:07 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41311

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:06:52 +0000 (11:06 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41310

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:06:37 +0000 (11:06 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41309

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:06:17 +0000 (11:06 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41308

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:05:50 +0000 (11:05 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41307

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:05:23 +0000 (11:05 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41306

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:05:08 +0000 (11:05 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41305

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:04:51 +0000 (11:04 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41304

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:04:31 +0000 (11:04 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41303

8 years agoFix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
Alexis La Goutte [Fri, 2 Mar 2012 11:04:09 +0000 (11:04 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang

svn path=/trunk/; revision=41302