Evan Huus [Wed, 20 Feb 2013 20:49:36 +0000 (20:49 -0000)]
From Chris Maynard via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8360
Bail out if length is less than the minimum required length.
svn path=/trunk/; revision=47776
Evan Huus [Wed, 20 Feb 2013 20:41:33 +0000 (20:41 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8359
Prevent an infinite loop if we don't recognize the param type and
the length is 0.
svn path=/trunk/; revision=47775
Gerald Combs [Wed, 20 Feb 2013 20:16:49 +0000 (20:16 -0000)]
Forcing everyone to use the development update channel probably isn't
the best idea.
svn path=/trunk/; revision=47774
Gerald Combs [Wed, 20 Feb 2013 19:58:55 +0000 (19:58 -0000)]
As jrsoftware.org/iskb.php?mutexsessions points out, a session
mutex may not be visible to other sessions and we may not be able to
create a global mutex. Try to create both, and make each one accessible
to all users. Update the NSIS installer to check for both global and
session mutexes.
svn path=/trunk/; revision=47773
Anders Broman [Wed, 20 Feb 2013 19:50:12 +0000 (19:50 -0000)]
From Michael Mann:
Add text/parameters
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5714
If we need something better we should make a text/parameters dissector I suppose.
svn path=/trunk/; revision=47772
Gerald Combs [Wed, 20 Feb 2013 16:42:34 +0000 (16:42 -0000)]
1.9.0 → 1.9.1.
svn path=/trunk/; revision=47771
Gerald Combs [Wed, 20 Feb 2013 16:36:47 +0000 (16:36 -0000)]
Build 1.9.0.
svn path=/trunk/; revision=47770
Guy Harris [Wed, 20 Feb 2013 08:37:40 +0000 (08:37 -0000)]
Fix copy-and-pasteo.
svn path=/trunk/; revision=47769
Guy Harris [Wed, 20 Feb 2013 08:10:14 +0000 (08:10 -0000)]
Add a tvb_new_subset_length() that takes a tvbuff, an offset in a
tvbuff, and a length from that offset, and returns a subset tvbuff
referring to that data (or throws an exception). This does what most if
not all calls to tvb_new_subset() (other than the ones that really
should be calls to tvb_new_subset_remaining()) should be doing, i.e.
setting the reported length of the tvbuff to the specified length and
calculating the appropriate value of the captured length based on that.
We aren't using it yet, but we will....
svn path=/trunk/; revision=47768
Gerald Combs [Wed, 20 Feb 2013 06:51:16 +0000 (06:51 -0000)]
Add software_update.c.
svn path=/trunk/; revision=47767
Gerald Combs [Wed, 20 Feb 2013 05:04:57 +0000 (05:04 -0000)]
Only call create_app_running_mutex on Windows.
svn path=/trunk/; revision=47766
Chris Maynard [Wed, 20 Feb 2013 03:06:46 +0000 (03:06 -0000)]
From Edwin Groothuis via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8353 : Document http-related '-z' statistics; also add document -z help.
From me: Don't print an error message for "-z help".
(Only "http,stat," is suitable for backport to 1.8 and 1.6)
svn path=/trunk/; revision=47763
Gerald Combs [Wed, 20 Feb 2013 03:01:12 +0000 (03:01 -0000)]
Exclude create_app_running_mutex.
svn path=/trunk/; revision=47762
Chris Maynard [Wed, 20 Feb 2013 02:15:20 +0000 (02:15 -0000)]
Fix Coverity CID 751720: Logically dead code.
In fixing this bug, also fix another: Be sure to use tvb_length() and not tvb_reported_length() in get_utp_version(), since this is essentially where the heuristics are being applied to decide whether to accept the packet or not.
svn path=/trunk/; revision=47761
Guy Harris [Wed, 20 Feb 2013 01:38:58 +0000 (01:38 -0000)]
And one more case where tvb_new_subset_remaining() is appropriate.
svn path=/trunk/; revision=47760
Guy Harris [Wed, 20 Feb 2013 01:37:08 +0000 (01:37 -0000)]
Clean up white space - get rid of 4-space tabs.
Reformat the hf[] array to be consistent, and get rid of some bogus
blurbs (probably copy-and-pasteos).
svn path=/trunk/; revision=47759
Gerald Combs [Wed, 20 Feb 2013 01:19:42 +0000 (01:19 -0000)]
When any of our executables start on Windows create or open a "Wireshark
is running" mutex. Have the NSIS installer check for this mutex and ask
the user to close Wireshark if it's found. While not perfect this makes
the WinSparkle update process much less annoying.
svn path=/trunk/; revision=47758
Guy Harris [Wed, 20 Feb 2013 01:01:32 +0000 (01:01 -0000)]
Swallow up tvb_set_real_data_no_exceptions() into tvb_new_real_data() -
the only caller is tvb_new_real_data().
svn path=/trunk/; revision=47757
Guy Harris [Wed, 20 Feb 2013 00:57:10 +0000 (00:57 -0000)]
Reflect that tvb_new() is now an internal routine.
svn path=/trunk/; revision=47756
Guy Harris [Wed, 20 Feb 2013 00:56:44 +0000 (00:56 -0000)]
Improve a comment - what matters is that tvb_new_real_data() can throw
an exception, not how it happens to be implemented currently.
svn path=/trunk/; revision=47755
Chris Maynard [Wed, 20 Feb 2013 00:53:19 +0000 (00:53 -0000)]
Fix Coverity CID 984638: Unused pointer value.
svn path=/trunk/; revision=47754
Guy Harris [Wed, 20 Feb 2013 00:09:41 +0000 (00:09 -0000)]
No more tvb_new(), so no more need for tvb_set_real_data() or
tvb_set_subset(); code should use tvb_new_real_data() and various
tvb_new_subset routines. (Neither tvb_new() nor tvb_set_real_data() nor
tvb_set_subset() were exported in libwireshark.def, nor were they used
outside tvbuff.c; tvb_set_real_data() and tvb_set_subset() weren't even
being used *inside* tvbuff.c.)
svn path=/trunk/; revision=47753
Guy Harris [Tue, 19 Feb 2013 23:55:19 +0000 (23:55 -0000)]
Make tvb_new() an internal routine to epan/tvbuff.c; we export various
routines to create new tvbuffs that do what dissectors need to do, and
those are the only routines that should be used.
svn path=/trunk/; revision=47752
Guy Harris [Tue, 19 Feb 2013 23:17:07 +0000 (23:17 -0000)]
How can I get a new tvbuff that starts at an offset within a given
tvbuff and runs to the end of the tvbuff? Let me count the ways....
Replace a bunch of different ways of doing that (some incorrect, in that
they're not properly handling tvbuffs where the captured and reported
lengths are different) with tvb_new_subset_remaining().
svn path=/trunk/; revision=47751
Gerald Combs [Tue, 19 Feb 2013 23:05:27 +0000 (23:05 -0000)]
Register the gui.update.interval preference.
svn path=/trunk/; revision=47750
Gerald Combs [Tue, 19 Feb 2013 22:57:40 +0000 (22:57 -0000)]
Enable automatic updates for Win64. Fix a copy/paste error.
svn path=/trunk/; revision=47749
Gerald Combs [Tue, 19 Feb 2013 22:21:17 +0000 (22:21 -0000)]
Add automatic software update checks for Win32 using WinSparkle. Add
preferences (currently hidden) to disable updates, set the update
frequency, and set the update "channel" (stable vs development). Add a
"Help" menu item to manually check for updates.
svn path=/trunk/; revision=47748
Anders Broman [Tue, 19 Feb 2013 18:53:47 +0000 (18:53 -0000)]
Remove experiment with global code
svn path=/trunk/; revision=47747
Anders Broman [Tue, 19 Feb 2013 18:44:06 +0000 (18:44 -0000)]
Add the remaining asn1 files "CODE global" not handled yet.
svn path=/trunk/; revision=47746
Guy Harris [Tue, 19 Feb 2013 07:06:55 +0000 (07:06 -0000)]
calc_checksum() should be passed the length of the block to be
checksummed, which is the length of the TPDU, not that length + 1.
Calculate the TPDU length correctly - use
tvb_reported_length_remaining(), not tvb_length_remaining() (we want the
*actual* length, not the amount of captured data we have), and take the
offset handed to the dissector routine into account. Don't take the
length indicator into account for TPDUs with user data, as they run to
the end of the lower-level packet containing the TPDU(s). The CLTP UD
TPDU contains user data.
Note that this dissects both COTP *and* CLTP (that's why it's
"packet-ositp.c", not "packet-cotp.c").
Separate some groups of #includes with blank lines.
svn path=/trunk/; revision=47745
Chris Maynard [Tue, 19 Feb 2013 04:48:34 +0000 (04:48 -0000)]
According to wikipedia, the A6M was outdated by 1944. Let it rest in peace.
svn path=/trunk/; revision=47744
Guy Harris [Tue, 19 Feb 2013 03:55:14 +0000 (03:55 -0000)]
Whitespace tweaks.
svn path=/trunk/; revision=47743
Chris Maynard [Tue, 19 Feb 2013 01:56:42 +0000 (01:56 -0000)]
Don't call expert_add_info_format() from within an if (tree) {} block.
Misc. whitespace changes, remove tabs, add modelines to match current scheme.
svn path=/trunk/; revision=47742
Michael Mann [Tue, 19 Feb 2013 01:34:15 +0000 (01:34 -0000)]
Bugfix OSITP - Incorrect TP4 checksum calculation (ATN extended checksum) in case of multiple TPDU's per frame.
Bug 8293 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8293)
svn path=/trunk/; revision=47741
Guy Harris [Mon, 18 Feb 2013 22:37:07 +0000 (22:37 -0000)]
For each dynamic-payload hash table, keep a Boolean indicating whether
it's been used in an rtp_set_address() or srtp_set_address() call and,
if that Boolean is set, don't free the hash table; this fixes a case
where the hash table was freed while it was in use.
svn path=/trunk/; revision=47740
Michael Mann [Mon, 18 Feb 2013 22:12:07 +0000 (22:12 -0000)]
Use tcp_dissect_pdus for better dissection on TCP. Adjusted UDP dissection accordingly.
Various cleanup to use proto_tree_add_item more often.
svn path=/trunk/; revision=47739
Anders Broman [Mon, 18 Feb 2013 19:34:04 +0000 (19:34 -0000)]
Dissect more supplementarry services
svn path=/trunk/; revision=47738
Guy Harris [Mon, 18 Feb 2013 19:31:46 +0000 (19:31 -0000)]
Enums aren't guaranteed to be able to hold a value that doesn't fit in
an int, so don't use enums for special values of the PLP length field.
In addition, use G_GINT64_CONSTANT() to tag them as appropriate for a
guint64.
svn path=/trunk/; revision=47737
Evan Huus [Mon, 18 Feb 2013 18:19:38 +0000 (18:19 -0000)]
From Alex Gaertner via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8313
Misc. fixes to the SML dissector:
- one more define added
- removed data_handle (unused)
- removed "check = tvb_get_guint8(tvb, temp_offset);" (value hasn't changed)
- added PI_NOTE
- CRC fixed, calculation now correct if CRC is transmitted as UINT8
From me:
- clean up indentation
- change modelines to actually match the indentation most commonly used
svn path=/trunk/; revision=47736
Alexis La Goutte [Mon, 18 Feb 2013 17:24:30 +0000 (17:24 -0000)]
Fix small typo in TPC Report IE
svn path=/trunk/; revision=47734
Alexis La Goutte [Mon, 18 Feb 2013 17:24:21 +0000 (17:24 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=47733
Alexis La Goutte [Mon, 18 Feb 2013 17:24:07 +0000 (17:24 -0000)]
From 802.11-2012.pdf Update Reason Code and Status Code fields
svn path=/trunk/; revision=47732
Alexis La Goutte [Mon, 18 Feb 2013 17:23:57 +0000 (17:23 -0000)]
Display Power Constraint in DEC (and fix a small typo)
svn path=/trunk/; revision=47731
Anders Broman [Mon, 18 Feb 2013 06:26:09 +0000 (06:26 -0000)]
Add more ASN1 files.
svn path=/trunk/; revision=47730
Jaap Keuter [Mon, 18 Feb 2013 06:19:04 +0000 (06:19 -0000)]
Fix for bug 8321:
Feed the tap before trying to dissect the payload. This prevents a malformed
payload from blocking the tap, resulting in incorrect RTP statistics.
svn path=/trunk/; revision=47729
Bill Meier [Mon, 18 Feb 2013 05:41:13 +0000 (05:41 -0000)]
Revert SVN #47724, #47726 & #47727.
Some rethinking required since I failed to
understand some of the details as to how
proto_tree_write_fields() really works. :(
svn path=/trunk/; revision=47728
Bill Meier [Mon, 18 Feb 2013 01:59:17 +0000 (01:59 -0000)]
Use consistent indentation & formatting style.
svn path=/trunk/; revision=47727
Bill Meier [Mon, 18 Feb 2013 01:18:51 +0000 (01:18 -0000)]
Don't use index as a variable name (i knew that..).
Fixes compiler warning.
svn path=/trunk/; revision=47726
Michael Mann [Mon, 18 Feb 2013 00:58:21 +0000 (00:58 -0000)]
Bugfix data combined via ssl_desegment_app_data not visible via "Follow SSL Stream"
From Joe McEachern, bug 6434 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6434)
svn path=/trunk/; revision=47725
Bill Meier [Mon, 18 Feb 2013 00:51:59 +0000 (00:51 -0000)]
Implement proto_tree_write_fields without using ep_strbufs.
- Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8348:
"tshark -T fields can't print the full value of fields where the value,
as a text string, is longer than 65535 bytes"
- Reduces ep memory allocation & string copies;
svn path=/trunk/; revision=47724
Michael Mann [Sun, 17 Feb 2013 23:00:57 +0000 (23:00 -0000)]
Improve SSH state machine so IGNORED messages don't upset the dissection by throwing the "packet count" off.
Bug 5064 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5064)
svn path=/trunk/; revision=47723
Chris Maynard [Sun, 17 Feb 2013 22:44:47 +0000 (22:44 -0000)]
Fix Coverity CID 981983: Unused pointer value.
Additionally:
1) Remove check_col()'s
2) Don't call expert_add_info_format() from within an if (tree) {} block.
3) tvb_reported_length_remaining() can return -1; be sure to handle it.
4) Misc. whitespace changes.
svn path=/trunk/; revision=47722
Michael Mann [Sun, 17 Feb 2013 22:15:16 +0000 (22:15 -0000)]
Remove C++ incompatibilities in c1222 dissector.
Also addresses an implicit cast in the epan/uat.h file
Bug 8342 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8342)
svn path=/trunk/; revision=47721
Pascal Quantin [Sun, 17 Feb 2013 21:48:18 +0000 (21:48 -0000)]
Update ITU-T E.212 to bulletin 1019 (01.I.2013)
svn path=/trunk/; revision=47720
Guy Harris [Sun, 17 Feb 2013 21:24:31 +0000 (21:24 -0000)]
Get rid of zero-length array - we allow Wireshark to be compiled with
compilers that don't support zero-length arrays.
svn path=/trunk/; revision=47719
Guy Harris [Sun, 17 Feb 2013 21:14:14 +0000 (21:14 -0000)]
Add a macro to calculate, from the size of an AirpcapKeysCollection
structure, the number of keys in the key list, and use it.
svn path=/trunk/; revision=47718
Guy Harris [Sun, 17 Feb 2013 20:00:53 +0000 (20:00 -0000)]
Squelch some more warnings.
svn path=/trunk/; revision=47717
Guy Harris [Sun, 17 Feb 2013 19:58:56 +0000 (19:58 -0000)]
Squelch some warnings.
svn path=/trunk/; revision=47716
Michael Mann [Sun, 17 Feb 2013 19:36:08 +0000 (19:36 -0000)]
Support for SCU/SCP Role Selection and Asynchronous Operations Window Negotiation
From Stefan Allers. Bug 8347 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8347)
svn path=/trunk/; revision=47715
Anders Broman [Sun, 17 Feb 2013 19:35:17 +0000 (19:35 -0000)]
Try to fix merge problem.
svn path=/trunk/; revision=47714
Anders Broman [Sun, 17 Feb 2013 19:28:59 +0000 (19:28 -0000)]
Add a preferense to the Q.932 dissector wether facility messages should be dissected as QSIG or ETSI.
Add the ISUP Supplementary services dissector.
svn path=/trunk/; revision=47713
Guy Harris [Sun, 17 Feb 2013 19:14:10 +0000 (19:14 -0000)]
Oops, the list is of Makefiles, not of directories that should contain
Makefiles.
svn path=/trunk/; revision=47712
Guy Harris [Sun, 17 Feb 2013 19:12:35 +0000 (19:12 -0000)]
Add asn1/isdn-sup to the list of directories in which to generate a
Makefile.
svn path=/trunk/; revision=47711
Guy Harris [Sun, 17 Feb 2013 19:08:12 +0000 (19:08 -0000)]
Give it an RCS ID.
svn path=/trunk/; revision=47710
Guy Harris [Sun, 17 Feb 2013 19:07:27 +0000 (19:07 -0000)]
Get rid of trailing CRs, set the usual svn properties to expand $Id$ and
use native line endings.
svn path=/trunk/; revision=47709
Michael Mann [Sun, 17 Feb 2013 19:07:14 +0000 (19:07 -0000)]
Bugfix DoS in CIMD dissector. Bug 8346 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8346)
svn path=/trunk/; revision=47708
Anders Broman [Sun, 17 Feb 2013 18:32:35 +0000 (18:32 -0000)]
Add isdn-sup to the asn1 makefiles.
svn path=/trunk/; revision=47707
Anders Broman [Sun, 17 Feb 2013 18:27:04 +0000 (18:27 -0000)]
Add the files for an initial ISDN Supplimentary Services(ETSI) dissector.
svn path=/trunk/; revision=47706
Michael Mann [Sun, 17 Feb 2013 18:25:22 +0000 (18:25 -0000)]
Only allow one packet to act as an SDP response. This should probably be caught at a higher layer (SIP), but the safety net should be there.
Also, cleanup SIP "response error" range.
Fixes crash in bug 8343 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8343)
svn path=/trunk/; revision=47705
Evan Huus [Sun, 17 Feb 2013 15:06:35 +0000 (15:06 -0000)]
Use wmem memory to build most of the diameter hf and ett arrays.
Cleans up many valgrind errors, since we were losing our pointers to
the arrays before shutdown.
svn path=/trunk/; revision=47702
Gerald Combs [Sun, 17 Feb 2013 15:03:20 +0000 (15:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2013-02-17]
svn path=/trunk/; revision=47701
Evan Huus [Sun, 17 Feb 2013 14:39:16 +0000 (14:39 -0000)]
From Alyssa Milburn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8341
With small additional changes by me
Make many of the length and offset fields in the websocket dissector unsigned.
This fixes a case where we could attempt to malloc (unsigned)-1 bytes of memory.
Also fix one small copy-paste string typo.
svn path=/trunk/; revision=47700
Guy Harris [Sun, 17 Feb 2013 03:45:06 +0000 (03:45 -0000)]
Add a macro that, for a given count of keys, returns the total size of
an AirpcapKeysCollection structure with that number of keys, and use it
instead of doing the calculation manually.
svn path=/trunk/; revision=47699
Guy Harris [Sun, 17 Feb 2013 03:28:23 +0000 (03:28 -0000)]
Clean up white space (use spaces instead of tabs).
svn path=/trunk/; revision=47698
Guy Harris [Sun, 17 Feb 2013 03:16:57 +0000 (03:16 -0000)]
Clean up white space (get rid of 4-space tabs).
svn path=/trunk/; revision=47697
Evan Huus [Sat, 16 Feb 2013 17:43:16 +0000 (17:43 -0000)]
Add missing G_GUINT64_CONSTANT for 32-bit platforms.
svn path=/trunk/; revision=47696
Evan Huus [Sat, 16 Feb 2013 16:48:30 +0000 (16:48 -0000)]
From Alex Gaertner via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8313
New dissector for the SML protocol.
svn path=/trunk/; revision=47695
Evan Huus [Sat, 16 Feb 2013 14:59:00 +0000 (14:59 -0000)]
From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8287
Request-response tracking and response-time calculation for HTTP.
svn path=/trunk/; revision=47694
Pascal Quantin [Sat, 16 Feb 2013 13:55:10 +0000 (13:55 -0000)]
Fix typo error
svn path=/trunk/; revision=47693
Jaap Keuter [Sat, 16 Feb 2013 13:49:42 +0000 (13:49 -0000)]
From Alyssa Milburn:
This patch adds a check for a zero count to the existing sanity check code.
From me:
In addition drop superfluous sanity check.
svn path=/trunk/; revision=47692
Jörg Mayer [Sat, 16 Feb 2013 10:31:20 +0000 (10:31 -0000)]
Add Ethertype for Network Controller Sideband Interface
svn path=/trunk/; revision=47691
Michael Mann [Sat, 16 Feb 2013 02:10:50 +0000 (02:10 -0000)]
Add decryption algorithm preference to SNMP dissector.
Bug 8328 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8328)
svn path=/trunk/; revision=47690
Martin Mathieson [Sat, 16 Feb 2013 00:11:28 +0000 (00:11 -0000)]
Set more preferences to be on by default.
svn path=/trunk/; revision=47689
Martin Mathieson [Sat, 16 Feb 2013 00:05:37 +0000 (00:05 -0000)]
Make the number of RAPIDs in an RAR PDU a generated field.
svn path=/trunk/; revision=47688
Martin Mathieson [Sat, 16 Feb 2013 00:00:06 +0000 (00:00 -0000)]
Show resegmented data as grey.
svn path=/trunk/; revision=47687
Martin Mathieson [Fri, 15 Feb 2013 23:43:30 +0000 (23:43 -0000)]
Add support for reading/writing 'sprint' lines from test scripts.
svn path=/trunk/; revision=47686
Evan Huus [Fri, 15 Feb 2013 20:58:59 +0000 (20:58 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8337
Make offset unsigned and add an additional sanity check.
svn path=/trunk/; revision=47681
Guy Harris [Fri, 15 Feb 2013 20:10:19 +0000 (20:10 -0000)]
Get rid of an extra blank line.
svn path=/trunk/; revision=47677
Evan Huus [Fri, 15 Feb 2013 17:32:34 +0000 (17:32 -0000)]
From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8264
Improve handling of truncated USB Configuration descriptors.
In contrast to other descriptor types, configuration descriptors have varying
lengths and may be quite long. This makes them much more prone to truncation
by a host that is cautious about reading large descriptors.
A real-world case has arisen where a host requests a partial configuration
descriptor of a USB webcam, and wireshark improperly reports that the response
is malformed.
Change configuration descriptor dissection to distinguish between truncation
induced by the host, which is not an error, and descriptor truncation or
reporting of invalid descriptor lengths by the device, which are.
This patch also relieves class-specific dissectors of the burden of checking
that the descriptor length and type fields are available, and that all the
bytes claimed by the descriptor length are also available.
svn path=/trunk/; revision=47676
Evan Huus [Fri, 15 Feb 2013 16:59:20 +0000 (16:59 -0000)]
From Lori Tribble via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8331
Fix UCS-2 string decoding for strings longer than 127 characters.
svn path=/trunk/; revision=47675
Michael Mann [Fri, 15 Feb 2013 15:31:24 +0000 (15:31 -0000)]
Fix Voice RTP player crash if player is closed while playing
Bug 8065 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8065)
svn path=/trunk/; revision=47674
Evan Huus [Fri, 15 Feb 2013 15:24:39 +0000 (15:24 -0000)]
From Hannes Mezger via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8327
Updates to the OPCUA plugin so that subtrees of the dissector select the
appropriate number of bytes. Also fix dissection of the array dimensions
field for matrix values and the highlighting for empty string fields.
svn path=/trunk/; revision=47673
Evan Huus [Fri, 15 Feb 2013 13:10:06 +0000 (13:10 -0000)]
From Alyssa Milburn via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8335
Make length field unsigned so that negative values fail the bounds check and
throw a regular exception before getting passed to glib (where they cause a
program-ending assert failure instead).
svn path=/trunk/; revision=47672
Bill Meier [Fri, 15 Feb 2013 02:50:36 +0000 (02:50 -0000)]
Comment out a number of unused hf[] enrries found by checkhf.
svn path=/trunk/; revision=47670
Guy Harris [Fri, 15 Feb 2013 01:38:45 +0000 (01:38 -0000)]
Add a new WSLUA_CLASS_FNREG_ALIAS() macro to register methods where the
function name isn't the same as the method name; this is used if we're
providing compatibility aliases for method names.
Use WSLUA_CLASS_FNREG() and WSLUA_CLASS_FNREG_ALIAS() for all method
registrations.
Fix the spelling of "prepend", but leave a compatibility alias in place.
svn path=/trunk/; revision=47667
Bill Meier [Fri, 15 Feb 2013 01:31:27 +0000 (01:31 -0000)]
Fix a set of obscure bugs found by checkhf.
svn path=/trunk/; revision=47666
Guy Harris [Fri, 15 Feb 2013 00:43:04 +0000 (00:43 -0000)]
Put in a comment explaining what the signal strength value probably
means here.
svn path=/trunk/; revision=47665
Guy Harris [Fri, 15 Feb 2013 00:34:05 +0000 (00:34 -0000)]
Put in a comment explaining what the signal strength value means here.
svn path=/trunk/; revision=47664
Guy Harris [Thu, 14 Feb 2013 22:38:50 +0000 (22:38 -0000)]
Show the signal strength as a percentage in the RSSI column, as that's
what it is.
svn path=/trunk/; revision=47663
Guy Harris [Thu, 14 Feb 2013 22:38:12 +0000 (22:38 -0000)]
Show the signal strength as dBm, as that's what it is in the PPI header.
svn path=/trunk/; revision=47662