Chris Maynard [Wed, 10 Jul 2013 16:18:37 +0000 (16:18 -0000)]
Add strnatcmp by Martin Pool for 'natural order' string comparisons, and make use of it in editcap and mergecap for listing encapsulation types. For example:
Before:
user0 - USER 0
user1 - USER 1
user10 - USER 10
user11 - USER 11
user12 - USER 12
user13 - USER 13
user14 - USER 14
user15 - USER 15
user2 - USER 2
user3 - USER 3
user4 - USER 4
user5 - USER 5
user6 - USER 6
user7 - USER 7
user8 - USER 8
user9 - USER 9
After:
user0 - USER 0
user1 - USER 1
user2 - USER 2
user3 - USER 3
user4 - USER 4
user5 - USER 5
user6 - USER 6
user7 - USER 7
user8 - USER 8
user9 - USER 9
user10 - USER 10
user11 - USER 11
user12 - USER 12
user13 - USER 13
user14 - USER 14
user15 - USER 15
svn path=/trunk/; revision=50482
Anders Broman [Wed, 10 Jul 2013 05:08:06 +0000 (05:08 -0000)]
From Javier Godoy:
Proper dissection of responses with insufficient allocation length.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8919
svn path=/trunk/; revision=50481
Anders Broman [Wed, 10 Jul 2013 05:00:43 +0000 (05:00 -0000)]
From Joe McEachern:
SIP stats shows incorrect values for Max/Ave setup times.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8897
BACKPORT 1.8 1.10
svn path=/trunk/; revision=50480
Jakub Zawadzki [Wed, 10 Jul 2013 01:50:27 +0000 (01:50 -0000)]
Fix bug #8908: Strange behavior of tree expand/collapse in packet details
Only expand subtree when parent was also expanded
svn path=/trunk/; revision=50479
Evan Huus [Wed, 10 Jul 2013 00:32:57 +0000 (00:32 -0000)]
The last bits of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8828
Convert the last DISSECTOR_ASSERTs into potential expert infos, and do the right
offset manipulation and verification to avoid long (or infinite) loops when
those conditions are hit. This includes fixing some long loops I accidentally
introduced in r50432.
svn path=/trunk/; revision=50478
Jakub Zawadzki [Tue, 9 Jul 2013 23:10:04 +0000 (23:10 -0000)]
tvbuff: use ep_strbuf_append_unichar()
svn path=/trunk/; revision=50477
Martin Kaiser [Tue, 9 Jul 2013 20:51:48 +0000 (20:51 -0000)]
fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8916
reported by Laurent Butti
a TPDU's length field must never be 0
this length field was decremented without prior checking,
allocating length-1 bytes of memory caused a dissector assert
svn path=/trunk/; revision=50474
Pascal Quantin [Tue, 9 Jul 2013 20:39:09 +0000 (20:39 -0000)]
Upgrade LTE RRC dissector to v11.4.0
svn path=/trunk/; revision=50473
Michael Mann [Tue, 9 Jul 2013 20:35:26 +0000 (20:35 -0000)]
Fix some uninitialized variable warnings reported in bug 8904 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8904) by setting conversation structure (smtp_session_state) to all zeros.
svn path=/trunk/; revision=50472
Stig Bjørlykke [Tue, 9 Jul 2013 19:00:11 +0000 (19:00 -0000)]
Avoid having double "Default" entry in "Create New Profile".
#BACKPORT 1.10
svn path=/trunk/; revision=50471
Alexis La Goutte [Tue, 9 Jul 2013 18:08:40 +0000 (18:08 -0000)]
From Thomas ERSFELD (GSOC13) via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8710 QtShark doesn't have a statistics summary window
Add Summary Statistics to qtshark (Statistics => Summary)
Now, use tabs to split summary display (File Capture details, Capture Statistics)
Add also Comment Summary tab (to replace Statistics => Comments Summary)
From me :
Fix order of summary files in Qtshark.pro
svn path=/trunk/; revision=50470
Chris Maynard [Tue, 9 Jul 2013 18:01:44 +0000 (18:01 -0000)]
Another change that should have been part of r50465, which removed the limits to the number of characters in the display filter(s). [Technically, there is still the inherent 65535 limit.]
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=50469
Chris Maynard [Tue, 9 Jul 2013 16:58:07 +0000 (16:58 -0000)]
Use sizeof() instead of hard-coded values. Other minor whitespace cleanup.
svn path=/trunk/; revision=50466
Chris Maynard [Tue, 9 Jul 2013 16:44:47 +0000 (16:44 -0000)]
Remove the advanced filter field arbitrary text limit of 100 and remove the filter field arbitrary text limit of 256.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8909
#BACKPORT(1.10,1.8)
svn path=/trunk/; revision=50465
Jakub Zawadzki [Tue, 9 Jul 2013 16:22:53 +0000 (16:22 -0000)]
tvb subset: move setting tvb->ds_tvb to tvb_new_with_subset()
svn path=/trunk/; revision=50464
Jeff Morriss [Tue, 9 Jul 2013 14:15:30 +0000 (14:15 -0000)]
From X via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8914 :
Correct AVP codes 712 and 713, add 714-719.
Add and fix some enum codes.
Update specification version.
From me: Fix up indentation.
svn path=/trunk/; revision=50463
Alexis La Goutte [Tue, 9 Jul 2013 13:09:05 +0000 (13:09 -0000)]
From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8905 SCSI OSD: per-attribute subtree
The response of the OSD-2 LIST command may contain attributes in multi-object retrieved attributes format. Currently all proto_items for that attributes are put under the SCSI Payload tree, yielding a large list of items:
Partition Id
Object Type
Attribute Page
Attribute Number
Attribute Length
(optional attribute-specific fields)
Attribute Page, ...
Partition Id
Object Type
Attribute Page, ...
...
This patch classifies the OSD-2 LIST attributes (from the Data In buffer) in one tree per object and one sub-tree per attribute
Partition Id (ett_osd_multi_object tree)
Object Type
Attribute (ett_osd_attribute tree)
Attribute Page
Attribute Number
Attribute Length
(optional attribute-specific fields)
Attribute, ...
Partition Id
Object Type
Attribute Page, ...
...
The same approach is applied to attributes in the Get/Set attributes segments.
A function *attribute_page_numbers_t lookup_osd_attribute(page,number) was created, with common code that is called from dissect_osd_attributes_list, dissect_osd_attribute_value and dissect_osd2_attribute_list_entry.
The trees are built in function dissect_osd_attribute_list_entry. That function was modified for avoiding code duplication with case 0x09 of dissect_osd_attributes_list. A missing padding was added in the process.
The function dissect_osd_partition_id now returns proto_item*, so that we can create a subtree rooted at the partition_id (previously it returned an offset, but the return value was unused).
From me:
Fix clang warning duplicate code...
Remove some trailing whitespace
svn path=/trunk/; revision=50462
Guy Harris [Tue, 9 Jul 2013 09:54:19 +0000 (09:54 -0000)]
Fix uninstallation of Cairo - uninstall, don't install!
svn path=/trunk/; revision=50461
Guy Harris [Tue, 9 Jul 2013 09:31:45 +0000 (09:31 -0000)]
Fix missing $ before variable name.
Look at the lua-*-done file to get the version number of the version of
Lua we installed.
svn path=/trunk/; revision=50460
Guy Harris [Tue, 9 Jul 2013 08:48:07 +0000 (08:48 -0000)]
CPPFLAGS contains the flags for the C preprocessor; CXXFLAGS contains
the flags for the C++ compiler.
If we're building for 10.5, force a 32-bit build.
svn path=/trunk/; revision=50459
Guy Harris [Tue, 9 Jul 2013 08:47:05 +0000 (08:47 -0000)]
Fix the uninstall procedure for Lua - the man pages are installed into
/usr/local/man/man1, not /usr/local/man.
svn path=/trunk/; revision=50458
Anders Broman [Tue, 9 Jul 2013 05:14:33 +0000 (05:14 -0000)]
prefs.c: In function 'capture_column_set_cb':
prefs.c:1745: warning: unused variable 'syntax_error'
svn path=/trunk/; revision=50457
Guy Harris [Tue, 9 Jul 2013 04:41:34 +0000 (04:41 -0000)]
Use older versions of some libraries, and build 32-bit, when building
for Leopard. Fix some issues that came up with the older versions.
We don't support building *on* Leopard - we check for that up front - so
eliminate some code to handle that.
When uninstalling, check for the installed version by looking at the
name of the -done file, so we don't have to trust the _VERSION settings.
We don't appear to need to build our own versions of libpng or pixman
when building *on* Snow Leopard *for* Leopard.
The libffi configure patch for GLib appears not to be necessary -
perhaps building and installing pkg-config *before* building GLib makes
it no longer necessary - and it doesn't work with older versions of
GLib, so don't apply it.
svn path=/trunk/; revision=50456
Anders Broman [Tue, 9 Jul 2013 04:22:43 +0000 (04:22 -0000)]
From Cal Turney:
Wireshark crashes when switching from a v1.11.0 profile to a v1.4.6 prof and then to a v1.5.1 profile.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8884
#BACKPORT 1.10
svn path=/trunk/; revision=50455
Michael Mann [Tue, 9 Jul 2013 01:18:52 +0000 (01:18 -0000)]
Batch of filterable expert infos.
svn path=/trunk/; revision=50454
Guy Harris [Mon, 8 Jul 2013 22:56:55 +0000 (22:56 -0000)]
Download, build, and install pkg-config before GLib, courtesy of the
"use your internal version of GLib" flag for pkg-config's configure
script. This simplifies things a little bit.
Fix an indentation error while we're at it.
svn path=/trunk/; revision=50453
Jeff Morriss [Mon, 8 Jul 2013 21:12:06 +0000 (21:12 -0000)]
Fix the very long loop reported in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8911 :
In parseFields() ensure that we have at least one byte so that callers
don't have to protect against it returning an offset which hasn't incremented.
Remove a couple of now-unnecessary length-remaining (aka "will the offset
move?") checks.
In some other checks, use tvb_ensure_length_remaining() rather than calling
tvb_length_remaining() and (potentially) THROWing an exception. I'm not sure
if these are really necessary now or not...
svn path=/trunk/; revision=50450
Jeff Morriss [Mon, 8 Jul 2013 19:49:17 +0000 (19:49 -0000)]
Include the output (fuzz'd) file name in the output when fuzz (or randpkt)
testing fails.
Useful for when you want to use up a few spare CPU cores running multiple
simultaneous fuzz tests...
svn path=/trunk/; revision=50449
Pascal Quantin [Mon, 8 Jul 2013 18:49:42 +0000 (18:49 -0000)]
Fix "Could not compile color filter "Checksum Errors" from saved filters: eth.fcs_bad (type=Label) cannot participate in '==' comparison" warning
svn path=/trunk/; revision=50448
Gerald Combs [Mon, 8 Jul 2013 16:54:18 +0000 (16:54 -0000)]
New Qt feature: Show related packet list items in the frame number
column. Conversation spans (setup frame to last frame) are shown with a
square bracket. Linked frames are shown with a circle.
Use correct column justifications in Qt. Move common
justification-related packet list code to ui/packet_list_utils.[ch].
Add a last_frame element to conversation_t.
svn path=/trunk/; revision=50447
Alexis La Goutte [Mon, 8 Jul 2013 16:37:47 +0000 (16:37 -0000)]
Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
svn path=/trunk/; revision=50446
Jeff Morriss [Mon, 8 Jul 2013 16:25:13 +0000 (16:25 -0000)]
From Jim Young via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8906 :
This patch augments Wireshark's and tshark's augument usage reports (-? and
-t?) and the Wireshark and tshark man pages to list all available timestamp
options available for the -t option.
svn path=/trunk/; revision=50445
Jakub Zawadzki [Mon, 8 Jul 2013 05:59:07 +0000 (05:59 -0000)]
Fixes for tmp_fld_check_value():
- FT_FRAMENUM can't have strings
- mask hfinfo->display to compare with valid BASE_ value
svn path=/trunk/; revision=50444
Guy Harris [Sun, 7 Jul 2013 21:38:04 +0000 (21:38 -0000)]
Clean up comments.
svn path=/trunk/; revision=50440
Jakub Zawadzki [Sun, 7 Jul 2013 21:32:12 +0000 (21:32 -0000)]
ups? first add + 1, then multiply.
svn path=/trunk/; revision=50438
Martin Kaiser [Sun, 7 Jul 2013 19:03:03 +0000 (19:03 -0000)]
fixed a typo in the expert infos
svn path=/trunk/; revision=50435
Jakub Zawadzki [Sun, 7 Jul 2013 17:13:17 +0000 (17:13 -0000)]
tree_is_expanded: make it bit array.
Right now we have about 36K of ett items, and tree_is_expanded takes: 144K of memory (36K*sizeof(gboolean))
By making tree_is_expanded bit array, it reduce size to 4.5K (36K/8)
svn path=/trunk/; revision=50434
Jakub Zawadzki [Sun, 7 Jul 2013 16:33:49 +0000 (16:33 -0000)]
Make tree_is_expanded array static, add setter/getter function.
svn path=/trunk/; revision=50433
Evan Huus [Sun, 7 Jul 2013 16:18:18 +0000 (16:18 -0000)]
A bit more of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8828
svn path=/trunk/; revision=50432
Gerald Combs [Sun, 7 Jul 2013 14:03:38 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2013-07-07]
svn path=/trunk/; revision=50429
Evan Huus [Sat, 6 Jul 2013 23:53:09 +0000 (23:53 -0000)]
Revert part of r50415. As pointed out by Jakub, some of the value_string
functions are called when no dissection is going on, and so can't use
wmem_packet_scope().
svn path=/trunk/; revision=50428
Jakub Zawadzki [Sat, 6 Jul 2013 23:46:31 +0000 (23:46 -0000)]
proto.c: add few more cases when oct/hex can show up with signed number
remove invalid comment about HEX/OCT print not supported for signed numbers.
svn path=/trunk/; revision=50427
Guy Harris [Sat, 6 Jul 2013 23:29:50 +0000 (23:29 -0000)]
Check for an OS X deployment target early, so that as many
tests using the compiler are done using the flags that
we'll be using when building.
Add a -mmacosx-version-min flag to CFLAGS/CPPFLAGS/LDFLAGS so that the
compiler tests use them. This may, or may not, obviate the need to set
MACOSX_DEPLOYMENT_TARGET in OSX_DEPLOY_TARGET.
svn path=/trunk/; revision=50426
Guy Harris [Sat, 6 Jul 2013 23:00:56 +0000 (23:00 -0000)]
We need Cairo if we're building on 10.5 *or* if we're building *for*
10.5 on a later OS.
Fix the download path for libpng, and update the version to the
currently-available version.
svn path=/trunk/; revision=50425
Evan Huus [Sat, 6 Jul 2013 22:03:52 +0000 (22:03 -0000)]
From Marko Hrastovec via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8886
Fix an error in the scaling factor of field I062/380 subfield #28 in the Asterix
dissector.
svn path=/trunk/; revision=50424
Evan Huus [Sat, 6 Jul 2013 21:55:10 +0000 (21:55 -0000)]
From Peter Hatina via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8888
We're allocating an array of pointers, not an array of objects, so make the
sizeof() reflect that to avoid over-allocating.
svn path=/trunk/; revision=50423
Pascal Quantin [Sat, 6 Jul 2013 21:43:44 +0000 (21:43 -0000)]
Add UE Id to UDP framing protocol
svn path=/trunk/; revision=50422
Guy Harris [Sat, 6 Jul 2013 21:21:54 +0000 (21:21 -0000)]
Use consistent 4-space no-tab indentation.
svn path=/trunk/; revision=50421
Pascal Quantin [Sat, 6 Jul 2013 21:07:42 +0000 (21:07 -0000)]
Count SDUs even when dumping only the MAC header
svn path=/trunk/; revision=50420
Guy Harris [Sat, 6 Jul 2013 19:34:21 +0000 (19:34 -0000)]
Squelch some warnings that show up with, for example, the GCC 4.2.1 that
comes with Xcode 3.2.6 (it's not a real problem, but that requires more
flow analysis than that version of the compiler does, apparently).
svn path=/trunk/; revision=50419
Guy Harris [Sat, 6 Jul 2013 19:32:07 +0000 (19:32 -0000)]
Don't install the GNU autotools on Snow Leopard and earlier; they were
shipped with those versions of OS X, and I had some problems with the
newer versions on Snow Leopard (the Makefile was doing weird stuff that
caused build failures in wsutil, moving .Tlo files to .Plo files; I
didn't investigate futher).
svn path=/trunk/; revision=50418
Evan Huus [Sat, 6 Jul 2013 18:40:56 +0000 (18:40 -0000)]
Use epan-scoped memory for 6lowpan preference names. Another ~300 bytes gone.
svn path=/trunk/; revision=50417
Evan Huus [Sat, 6 Jul 2013 18:31:35 +0000 (18:31 -0000)]
Use epan-scoped memory for XML field strings. Another ~35KB leaks fixed.
Running `tshark -v` (which has the happy effect of doing
epan_init();
epan_cleanup();
with no practical work in-between), now leaks a hair less than 2KB of memory on
my machine. It was over 500KB earlier today :)
svn path=/trunk/; revision=50416
Evan Huus [Sat, 6 Jul 2013 18:25:27 +0000 (18:25 -0000)]
Wmem-ify value-strings. Another ~10KB gone.
svn path=/trunk/; revision=50415
Evan Huus [Sat, 6 Jul 2013 18:14:04 +0000 (18:14 -0000)]
Use epan-scoped memory for h248 packages. Fixes another ~24KB of leaks.
svn path=/trunk/; revision=50414
Evan Huus [Sat, 6 Jul 2013 18:06:56 +0000 (18:06 -0000)]
Regenerate p1 dissector.
svn path=/trunk/; revision=50413
Evan Huus [Sat, 6 Jul 2013 18:01:57 +0000 (18:01 -0000)]
Build dynamic diameter value_string arrays with wmem arrays not garrays.
Fixes another ~60KB of leaks.
svn path=/trunk/; revision=50412
Evan Huus [Sat, 6 Jul 2013 17:47:32 +0000 (17:47 -0000)]
Add wmem_array_sort() which just hands off to the standard library's qsort().
svn path=/trunk/; revision=50411
Guy Harris [Sat, 6 Jul 2013 16:42:30 +0000 (16:42 -0000)]
Add a --enable-osx-deploy-target option to set the deployment target
when building for OS X; that causes the MACOSX_DEPLOYMENT_TARGET
environment variable to be set when building (so that, for example, we
don't use linker features available on the version on which we're
building but not on the minimum OS version for which we're building),
and causes the SDK for that version to be used (so that, for example, we
don't link with libraries with later version numbers than the ones
provided with the OS version for which we're building).
svn path=/trunk/; revision=50410
Evan Huus [Sat, 6 Jul 2013 16:11:36 +0000 (16:11 -0000)]
Remove unused data structures from new expert code. Cleans up another ~17KB
of leaks, and I suspect they won't be necessary (we can always add them back
using wmem if they do turn out to be needed).
svn path=/trunk/; revision=50409
Evan Huus [Sat, 6 Jul 2013 16:08:12 +0000 (16:08 -0000)]
Convert xml's dynamic hf array from a garray to a wmem_array. Cleans up another
~200KB of leaks in epan library.
svn path=/trunk/; revision=50408
Evan Huus [Sat, 6 Jul 2013 13:31:31 +0000 (13:31 -0000)]
Add our license header to plugin moduleinfo.h files. Cleans up a batch of
licensecheck warnings.
svn path=/trunk/; revision=50407
Evan Huus [Sat, 6 Jul 2013 12:54:13 +0000 (12:54 -0000)]
Allocate expert protocol structs with wmem, cleans up a few KB of leaks in
epan_cleanup().
svn path=/trunk/; revision=50406
Evan Huus [Sat, 6 Jul 2013 12:45:33 +0000 (12:45 -0000)]
Build diameter's hf array in a wmem array instead of a garray. Fixes ~270KB of
leak when running epan_cleanup().
svn path=/trunk/; revision=50405
Guy Harris [Sat, 6 Jul 2013 08:33:07 +0000 (08:33 -0000)]
In some versions of some OSes, even <string.h> declares index() under
some circumstances. Use array_index as a variable name instead, to
avoid warnings.
svn path=/trunk/; revision=50404
Guy Harris [Sat, 6 Jul 2013 08:29:01 +0000 (08:29 -0000)]
For C string functions, the header to include is <string.h>, not
<strings.h>.
svn path=/trunk/; revision=50403
Guy Harris [Sat, 6 Jul 2013 06:16:06 +0000 (06:16 -0000)]
Add a "-t <target>" flag to set the deployment target OS version; that
causes a -mmacosx-version-min flag to be used, to keep the compiler and
linker from using features not supported by that OS version, and causes
the support libraries to be built against the SDK for that OS version,
so they don't request library versions later than the one shipped with
that version.
svn path=/trunk/; revision=50402
Evan Huus [Sat, 6 Jul 2013 04:08:07 +0000 (04:08 -0000)]
Trivial code style: use wmem_new in a few places, and remove extraneous
whitespace.
svn path=/trunk/; revision=50401
Evan Huus [Sat, 6 Jul 2013 04:02:08 +0000 (04:02 -0000)]
Simple growable array implementation for wmem.
svn path=/trunk/; revision=50400
Michael Mann [Sat, 6 Jul 2013 02:53:45 +0000 (02:53 -0000)]
Fix display filter errors caught by checkfiltername.pl
svn path=/trunk/; revision=50399
Michael Mann [Sat, 6 Jul 2013 02:52:16 +0000 (02:52 -0000)]
Add support for filterable expert info fields. Statistics don't separate out the expert info fields from the hf_ fields because we're really just looking for display filter name errors, regardless of source.
svn path=/trunk/; revision=50398
Evan Huus [Sat, 6 Jul 2013 02:49:57 +0000 (02:49 -0000)]
Fix the last remnant of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8160
Correctly calculate delta-displayed time when using two-pass dissection with a
display filter.
svn path=/trunk/; revision=50397
Michael Mann [Sat, 6 Jul 2013 01:20:38 +0000 (01:20 -0000)]
Fix duplicate diplay filter names found by checkfiltername.pl
svn path=/trunk/; revision=50396
Evan Huus [Sat, 6 Jul 2013 00:44:10 +0000 (00:44 -0000)]
From Fabio Tarabelloni via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8718
Zigbee messaging cluster dissector.
svn path=/trunk/; revision=50395
Evan Huus [Sat, 6 Jul 2013 00:01:59 +0000 (00:01 -0000)]
From Chris Bontje via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8860
Numerous changes and fixes to the selfm dissector. Too many to bother listing
here, see the bug for full details.
svn path=/trunk/; revision=50394
Luis Ontanon [Fri, 5 Jul 2013 23:57:07 +0000 (23:57 -0000)]
Yet another iteration:
- improve the parameter api
- Add a parameter set message to the NEW child message to set parameters in bulk in the child
- some more harvestig from tshark
svn path=/trunk/; revision=50393
Evan Huus [Fri, 5 Jul 2013 23:53:25 +0000 (23:53 -0000)]
Fix the use of va_args in the new expert code. Passing a va_list to a ... is
valid, but doesn't do what you actually want most of the time.
svn path=/trunk/; revision=50392
Guy Harris [Fri, 5 Jul 2013 23:27:10 +0000 (23:27 -0000)]
Get rid of extra blank line.
svn path=/trunk/; revision=50391
Guy Harris [Fri, 5 Jul 2013 23:26:15 +0000 (23:26 -0000)]
Add a -u flag to uninstall the support tools and libraries.
svn path=/trunk/; revision=50390
Guy Harris [Fri, 5 Jul 2013 23:19:58 +0000 (23:19 -0000)]
LIBFFI_CFLAGS and LIBFFI_LIBS are defined only to suppress the attempt
to run pkg-config to get their values; they should be set equal to the
values that would be returned by pkg-config for libffi with the --cflags
and --libs arguments, respectively. They should *NOT* include the
values of CFLAGS and LDFLAGS supplied in the environment; those should
be handled separately.
svn path=/trunk/; revision=50389
Evan Huus [Fri, 5 Jul 2013 22:54:51 +0000 (22:54 -0000)]
Fix compile errors: remove unused parameters, fix format string.
svn path=/trunk/; revision=50388
Michael Mann [Fri, 5 Jul 2013 20:47:24 +0000 (20:47 -0000)]
Major cleanup to ICQ dissector. Still needs a bunch of proto_tree_add_text -> proto_tree_add_xxx conversion (although the conversion seems simple but tedious).
The big problem appears to be that this dissector doesn't support an ICQ version in use today. Maybe having it look less scary will encourage someone to submit a patch that supports a more recent version.
svn path=/trunk/; revision=50387
Martin Kaiser [Fri, 5 Jul 2013 18:37:36 +0000 (18:37 -0000)]
fix compiler warning
packet-mpls-echo.c: In function 'dissect_mpls_echo_tlv':
packet-mpls-echo.c:1136:38: error: 'ddsti' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
packet-mpls-echo.c:1065:17: note: 'ddsti' was declared here
svn path=/trunk/; revision=50386
Michael Mann [Fri, 5 Jul 2013 14:22:35 +0000 (14:22 -0000)]
Make checkAPIs.pl a little more discerning when looking for too many proto_tree_add_text()s. I believe the intent was to ignore "small" dissectors that didn't have enough fields to qualify, but the previous logic ignored dissectors that were (almost) all proto_tree_add_text and no proto_tree_add_xxx.
I'm flexible on the definition of "small" (20 "fields"), but I think checkAPIs should flag the "all proto_tree_add_text" dissectors.
svn path=/trunk/; revision=50385
Michael Mann [Fri, 5 Jul 2013 03:10:36 +0000 (03:10 -0000)]
Batch of filterable expert infos.
svn path=/trunk/; revision=50384
Guy Harris [Thu, 4 Jul 2013 23:16:23 +0000 (23:16 -0000)]
Use xcrun --show-sdk-path to find out where the system include files are
hidden, rather than a "compile a program" hack.
svn path=/trunk/; revision=50383
Guy Harris [Thu, 4 Jul 2013 18:11:59 +0000 (18:11 -0000)]
More details in a comment.
svn path=/trunk/; revision=50382
Pascal Quantin [Thu, 4 Jul 2013 12:11:54 +0000 (12:11 -0000)]
Add channel id to UDP framing protocol and allow to dissect only the header of a signalling PDU (as we do for data PDUs)
svn path=/trunk/; revision=50381
Luis Ontanon [Thu, 4 Jul 2013 05:34:25 +0000 (05:34 -0000)]
some more harvesting from tshark
svn path=/trunk/; revision=50380
Guy Harris [Thu, 4 Jul 2013 00:39:54 +0000 (00:39 -0000)]
Add more comments indicating what this is doing.
svn path=/trunk/; revision=50379
Guy Harris [Thu, 4 Jul 2013 00:12:27 +0000 (00:12 -0000)]
Global variables considered harmful.
svn path=/trunk/; revision=50378
Michael Mann [Wed, 3 Jul 2013 23:43:26 +0000 (23:43 -0000)]
expert_add_info_format_text + proto_tree_add_text = proto_tree_add_expert_format, where applicable.
svn path=/trunk/; revision=50377
Jakub Zawadzki [Wed, 3 Jul 2013 22:57:53 +0000 (22:57 -0000)]
PROTO_REGISTRAR_GET_NTH() not needed after TRY_TO_FAKE_THIS_ITEM
svn path=/trunk/; revision=50376
Pascal Quantin [Wed, 3 Jul 2013 21:26:12 +0000 (21:26 -0000)]
Fix a null pointer dereference in downlink direction
svn path=/trunk/; revision=50374
Pascal Quantin [Wed, 3 Jul 2013 20:03:52 +0000 (20:03 -0000)]
Clear info column when using UDP framing
svn path=/trunk/; revision=50373
Jakub Zawadzki [Wed, 3 Jul 2013 17:44:46 +0000 (17:44 -0000)]
Optimize proto_item_prepend_text: if there's no fi->rep avoid one strlcpy().
svn path=/trunk/; revision=50372
Stephen Fisher [Wed, 3 Jul 2013 17:07:23 +0000 (17:07 -0000)]
Change grammar (obsoleted -> obsolete) in RIP preferences.
svn path=/trunk/; revision=50371
Alexis La Goutte [Wed, 3 Jul 2013 16:46:29 +0000 (16:46 -0000)]
From Oliver Gasser via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8863 Add CAA support to DNS dissector
Add informationa about Certificate Authority Authorization (CAA) data to the DNS dissector. See the RFC [1] for more information. Suggestions and improvements are welcome.
[1] http://tools.ietf.org/html/rfc6844
svn path=/trunk/; revision=50370
Alexis La Goutte [Wed, 3 Jul 2013 16:46:20 +0000 (16:46 -0000)]
Remove trailing whitespace
svn path=/trunk/; revision=50369
Alexis La Goutte [Wed, 3 Jul 2013 16:46:11 +0000 (16:46 -0000)]
Fix some warnings from fix-encoding-args tools.
svn path=/trunk/; revision=50368