metze/wireshark/wip.git
6 years agoGet rid of -Wshadow warning - I guess we're including something that
Guy Harris [Wed, 14 Aug 2013 01:18:58 +0000 (01:18 -0000)]
Get rid of -Wshadow warning - I guess we're including something that
gets <getopt.h>, so we get the optarg global.

svn path=/trunk/; revision=51350

6 years agoInclude config.h first; it defines _FILE_OFFSET_BITS, and if some system
Guy Harris [Wed, 14 Aug 2013 01:15:59 +0000 (01:15 -0000)]
Include config.h first; it defines _FILE_OFFSET_BITS, and if some system
header later causes it to be redefined - as happens on my Solaris 11
virtual machine - we get a redefinition warning, which gets treated as
an error.

svn path=/trunk/; revision=51349

6 years agoGet rid of -Wshadow warning - I guess we're including something that
Guy Harris [Wed, 14 Aug 2013 00:41:02 +0000 (00:41 -0000)]
Get rid of -Wshadow warning - I guess we're including something that
gets <getopt.h>, so we get the optarg global.

svn path=/trunk/; revision=51348

6 years agoUN*X pathnames + PL/I's comment syntax = surprises. Yay C++ (and C99).
Guy Harris [Wed, 14 Aug 2013 00:37:14 +0000 (00:37 -0000)]
UN*X pathnames + PL/I's comment syntax = surprises.  Yay C++ (and C99).

svn path=/trunk/; revision=51347

6 years agoGet rid of -Wshadow warning - I guess we're including something that
Guy Harris [Wed, 14 Aug 2013 00:35:27 +0000 (00:35 -0000)]
Get rid of -Wshadow warning - I guess we're including something that
gets <getopt.h>, so we get the optarg global.

svn path=/trunk/; revision=51346

6 years agoUse 4-space indentation consistently.
Guy Harris [Wed, 14 Aug 2013 00:33:36 +0000 (00:33 -0000)]
Use 4-space indentation consistently.

svn path=/trunk/; revision=51345

6 years agoInclude config.h first; it defines _FILE_OFFSET_BITS, and if some system
Guy Harris [Wed, 14 Aug 2013 00:31:14 +0000 (00:31 -0000)]
Include config.h first; it defines _FILE_OFFSET_BITS, and if some system
header later causes it to be redefined - as happens on my Solaris 11
virtual machine - we get a redefinition warning, which gets treated as
an error.

svn path=/trunk/; revision=51344

6 years agoAdd in more comments on the whole "get the path of the executable from
Guy Harris [Tue, 13 Aug 2013 23:37:32 +0000 (23:37 -0000)]
Add in more comments on the whole "get the path of the executable from
the kernel" thing, and add the NetBSD and DragonFly BSD /proc links (if
they don't mount /proc, that doesn't work, but it doesn't get in the
way).

On Solaris, check for getexecname, just in case somebody tries to build
on an old Solaris that doesn't support it (that could well end up being
the least of their problems, but at least they won't ask us to diagnose
that one).

svn path=/trunk/; revision=51343

6 years agoAs suggested in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9033
Evan Huus [Tue, 13 Aug 2013 22:41:34 +0000 (22:41 -0000)]
As suggested in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9033

Make epan_free a no-op if the pointer is NULL. This fixes 99% of the cases
causing problems for wmem_leave_file_scope() - remove that XXX comment and add
back the assertion.

Remove the cleanup_dissection call from epan_cleanup, it doesn't make sense
there. init_dissection is only called from epan_new, so cleanup_dissection
should only be called from epan_free.

Add one missing epan_free call to tshark revealed by the above changes.

svn path=/trunk/; revision=51342

6 years agoMake what appear to be the intended changes so that all variables are used or
Evan Huus [Tue, 13 Aug 2013 22:24:59 +0000 (22:24 -0000)]
Make what appear to be the intended changes so that all variables are used or
removed and it compiles.

svn path=/trunk/; revision=51341

6 years agoFix intended proto_tree_add_item() call that mistakenly called
Guy Harris [Tue, 13 Aug 2013 18:03:17 +0000 (18:03 -0000)]
Fix intended proto_tree_add_item() call that mistakenly called
proto_tree_add_uint(); caught by the checkAPI script run in a Windows
build.

svn path=/trunk/; revision=51340

6 years agoFrom Mark Phillips via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9038
Alexis La Goutte [Tue, 13 Aug 2013 17:50:22 +0000 (17:50 -0000)]
From Mark Phillips via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9038
802.11 HT Extended Capabilities B10 decode incorrect

#Backport 1.10 and 1.8

Within the 802.11 HT Capabilities IE the "HT Extended Capabilities" B10's name is incorrect.

It is currently titled "High Throughput". This is incorrect/missleading. It should be something like "High Throughput Control (+HTC)". The field indicates if the "High Throughput Control (HTC)" field is supported - not if HT itself is supported.

svn path=/trunk/; revision=51339

6 years agoUse start_offset to set the item length in the usual pattern (assuming this was
Evan Huus [Tue, 13 Aug 2013 13:28:14 +0000 (13:28 -0000)]
Use start_offset to set the item length in the usual pattern (assuming this was
intended). Fixes the unused variable warning on start_offset.

svn path=/trunk/; revision=51338

6 years agoSome improvements to the bundle protocol:
Michael Mann [Tue, 13 Aug 2013 11:37:27 +0000 (11:37 -0000)]
Some improvements to the bundle protocol:
1. Cleanly break out Convergence Layer Protocol (TCPCL) into its own (new-style) pure dissector.
2. Make Bundle dissection into a new style dissector and clean so that it can be called using call_disssector.
3. Use tcp_dissect_pdus for TCPCL protocol instead of "manual" while loop.  This allows contact header to benefit from TCP fragmentation.
4. Make time fields use time field types so they can be filterable.
5. A few functions were move to remove need for static declaration at top of file.
6. Remove pri_hdr_procflags global variable.

Next up - making more fields filterable.

svn path=/trunk/; revision=51337

6 years agoAdd missing return (reported as missing break by coverity)
Martin Mathieson [Tue, 13 Aug 2013 10:40:06 +0000 (10:40 -0000)]
Add missing return (reported as missing break by coverity)

svn path=/trunk/; revision=51336

6 years agoShow the Lua plugin being loaded in the splash screen.
Stig Bjørlykke [Tue, 13 Aug 2013 10:38:30 +0000 (10:38 -0000)]
Show the Lua plugin being loaded in the splash screen.

svn path=/trunk/; revision=51335

6 years agoImplement in cmake:
Jörg Mayer [Tue, 13 Aug 2013 09:58:09 +0000 (09:58 -0000)]
Implement in cmake:

http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=51322

> User: guy
> Date: 2013/08/12 01:01 PM
>
> Log:
>  Just check whether dladdr() is available; we check in the code whether
>  it succeeds, so there's no point in checking whether it succeeds in a
>  sample program.

svn path=/trunk/; revision=51334

6 years agoFix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9035 :
Pascal Quantin [Tue, 13 Aug 2013 08:19:41 +0000 (08:19 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9035 :
Indicate the right direction in info column

svn path=/trunk/; revision=51333

6 years agoWrap in "extern "C"" for the benefit of C++ code including it.
Guy Harris [Tue, 13 Aug 2013 07:58:06 +0000 (07:58 -0000)]
Wrap in "extern "C"" for the benefit of C++ code including it.

svn path=/trunk/; revision=51332

6 years agoFrom Javier Godoy:
Anders Broman [Tue, 13 Aug 2013 05:29:04 +0000 (05:29 -0000)]
From Javier Godoy:
Dissect additional OSD-2 service actions (CREATE/REMOVE PARTITION, GET/SET ATTRIBUTES, QUERY).

This patch adds support for some OSD-2 service actions, following the approach described in bug 8832.

The implemented service actions are:
 - CREATE PARTITION
 - REMOVE PARTITION
 - REMOVE COLLECTION
 - GET ATTRIBUTES
 - SET ATTRIBUTES
 - QUERY

The following service action codes was #defined
 - OSD_2_REMOVE_PARTITION 0x888c

The following trees were added
 - ett_osd2_query_criteria_entry

The following fields were added:
 - hf_scsi_osd2_remove_scope (REMOVE PARTITION)
 - hf_scsi_osd2_immed_tr (QUERY)
 - hf_scsi_osd2_matches_collection_object_id (QUERY)
 - hf_scsi_osd2_query_type (query list CDB continuation descriptor)
 - hf_scsi_osd2_query_entry_length (query list CDB continuation descriptor)
 - hf_scsi_osd2_query_attributes_page (query list CDB continuation descriptor)
 - hf_scsi_osd2_query_attribute_number (query list CDB continuation descriptor)
 - hf_scsi_osd2_query_minimum_attribute_value_length (query list CDB continuation descriptor)*
 - hf_scsi_osd2_query_maximum_attribute_value_length (query list CDB continuation descriptor)*
 * (dissection of the attribute value in query descriptors is not implemented yet)

The following value_string arrays were added:
 - scsi_osd2_remove_scope_val (OSD2r4 Table 143)
 - scsi_osd2_query_type_vals (OSD2r4 Table 75)

The following value_string arrays were updated:
 - scsi_osd_svcaction_vals
 - scsi_osd2_object_descriptor_format_val

The following functions were added:
 - dissect_osd2_query
 - dissect_osd2_query_list_descriptor (dissect CDB continuation descriptor type 0x0002)

The following expert_info fields were added:
 - ei_osd2_query_values_equal (PI_PROTOCOL,PI_NOTE) - the minimum and maximum attribute values are equal in a query descriptor entry

Changes in dissect_osd2_cdb_continuation:
 - Dissect case 0x0002

Changes in dissect_osd_*
 - Initialize extra_data->osd2
 - Dissect OSD-2 specific fields
 - Call dissect_osd_cdb_continuation_length / dissect_osd_cdb_continuation  (if osd2)
 - Version-specific increment of offset after dissecting capability/security_parameters

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9029

svn path=/trunk/; revision=51331

6 years agoFrom Yaniv Kaul:
Anders Broman [Tue, 13 Aug 2013 05:19:48 +0000 (05:19 -0000)]
From Yaniv Kaul:
small addition to SCSI dissection (media rotation speed analysis)

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9030

svn path=/trunk/; revision=51330

6 years agoCreate the dissector hash table in only one place, and specify that its values
Evan Huus [Tue, 13 Aug 2013 03:11:28 +0000 (03:11 -0000)]
Create the dissector hash table in only one place, and specify that its values
should be freed when it is destroyed. This requires splitting packet_init in
two: the hash table which must be created before protocol registration, and the
caching of common protocol handles, which must happen after registration.

svn path=/trunk/; revision=51329

6 years agoWhen freeing the preferences of a module, also free the preferences of its
Evan Huus [Tue, 13 Aug 2013 02:56:55 +0000 (02:56 -0000)]
When freeing the preferences of a module, also free the preferences of its
submodule.

svn path=/trunk/; revision=51328

6 years agoOnly rescan packets if we have packets to rescan. Fixes at least the surface
Evan Huus [Tue, 13 Aug 2013 02:18:04 +0000 (02:18 -0000)]
Only rescan packets if we have packets to rescan. Fixes at least the surface
problem in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9033

The underlying scoping issues may not be fully resolved yet.

svn path=/trunk/; revision=51327

6 years agoFix name resolution tests:
Evan Huus [Tue, 13 Aug 2013 01:41:51 +0000 (01:41 -0000)]
Fix name resolution tests:
- if we find a name during lookup, return it even if it's not a dummy
- read personal hosts after global hosts so that they take precedence

Neither of these problems appear to be new - the recent work did not change this
logic, so I have no idea how come name resolution wasn't failing before, but I
guess the old hash table was weirder than I thought...

svn path=/trunk/; revision=51326

6 years agoBe sure to initialize the jumbo flag when creating a new chunk header by
Evan Huus [Mon, 12 Aug 2013 23:35:35 +0000 (23:35 -0000)]
Be sure to initialize the jumbo flag when creating a new chunk header by
splitting an existing chunk. Thanks to Jeff for catching this one.

svn path=/trunk/; revision=51325

6 years ago- Extract variables from Makefile.common.
Jörg Mayer [Mon, 12 Aug 2013 22:17:06 +0000 (22:17 -0000)]
- Extract variables from Makefile.common.
- Apply this to asn1/c1222/

svn path=/trunk/; revision=51324

6 years agoIf we're looking for some version of GTK+, and don't find it, fail.
Guy Harris [Mon, 12 Aug 2013 20:24:59 +0000 (20:24 -0000)]
If we're looking for some version of GTK+, and don't find it, fail.
That way, if somebody specifies --with-gtk[23] and that version of GTK+
isn't found, we fail with an indication that the version of GTK+ they
asked for isn't there, and if no GUI toolkit was specified, and they
didn't explicitly say "don't build Wireshark", we look for GTK+ 3 and,
if it's not found, let the user know explicitly.

svn path=/trunk/; revision=51323

6 years agoJust check whether dladdr() is available; we check in the code whether
Guy Harris [Mon, 12 Aug 2013 20:01:30 +0000 (20:01 -0000)]
Just check whether dladdr() is available; we check in the code whether
it succeeds, so there's no point in checking whether it succeeds in a
sample program.

svn path=/trunk/; revision=51322

6 years agoFix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9031 :
Pascal Quantin [Mon, 12 Aug 2013 19:23:08 +0000 (19:23 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9031 :
SIP contact-param parsing should be stopped when finding a comma separator

svn path=/trunk/; revision=51321

6 years agoTell a bit more of the story of dladdr()'s ability, or lack of same, to
Guy Harris [Mon, 12 Aug 2013 18:51:06 +0000 (18:51 -0000)]
Tell a bit more of the story of dladdr()'s ability, or lack of same, to
return a path for the executable image not based on argv[0].

svn path=/trunk/; revision=51320

6 years agoMove initalisation of IPv4 hastable to the host_name_lookup_init() rotine.
Anders Broman [Mon, 12 Aug 2013 18:33:08 +0000 (18:33 -0000)]
Move initalisation of IPv4 hastable to the host_name_lookup_init() rotine.

svn path=/trunk/; revision=51319

6 years agoFrom Tommy Wu:
Anders Broman [Mon, 12 Aug 2013 18:29:42 +0000 (18:29 -0000)]
From Tommy Wu:
-         AppId is unsigned.
-         Add Relay application.

svn path=/trunk/; revision=51318

6 years agoFix error when enable "debug" in wiretap/pcapng.c file
Alexis La Goutte [Mon, 12 Aug 2013 17:46:04 +0000 (17:46 -0000)]
Fix error when enable "debug" in wiretap/pcapng.c file

With gcc :
pcapng.c: In function 'pcapng_read_packet_block':
pcapng.c:1147:9: error: request for member 'pseudo_header' in something not a structure or union

With clang :
pcapng.c:1150:86: error: member reference type 'struct wtap_pkthdr *' is a pointer; maybe you meant to use '->'?
                       pcap_get_phdr_size(int_data.wtap_encap, &wblock->packet_header.pseudo_header));
                                                                ~~~~~~~~~~~~~~~~~~~~~^
                                                                                     ->
(Error message from clang is better...)

svn path=/trunk/; revision=51317

6 years agoFix shorten-64-to-32 error when build with clang 3.4
Alexis La Goutte [Mon, 12 Aug 2013 17:45:54 +0000 (17:45 -0000)]
Fix shorten-64-to-32 error when build with clang 3.4

mcast_stream.c:393:29: error: implicit conversion loses integer precision: 'long' to 'gint32' (aka 'int')
      [-Werror,-Wshorten-64-to-32]
        usec = buffer[cur].tv_usec - buffer[prev].tv_usec;
             ~ ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~

svn path=/trunk/; revision=51316

6 years agoUse "command -v", required by recent POSIX, rather than "which"; I seem
Guy Harris [Mon, 12 Aug 2013 17:16:08 +0000 (17:16 -0000)]
Use "command -v", required by recent POSIX, rather than "which"; I seem
to remember this being suggested relatively recently on some mailing list
(either one of the Wireshark lists or tcpdump-workers, I think).

Handle systems where /usr/X11R6/bin is a symlink to /usr/bin and where
the user running autogen.sh has /usr/X11R6/bin before /usr/bin in their
$PATH.

svn path=/trunk/; revision=51315

6 years agoDouble click Lua scripts in About Plugins list to open in an editor.
Stig Bjørlykke [Mon, 12 Aug 2013 12:59:21 +0000 (12:59 -0000)]
Double click Lua scripts in About Plugins list to open in an editor.

svn path=/trunk/; revision=51314

6 years agocoverity 280403 (logically dead code)
Martin Kaiser [Mon, 12 Aug 2013 10:15:01 +0000 (10:15 -0000)]
coverity 280403 (logically dead code)

set first to FALSE after the first block was dissected

svn path=/trunk/; revision=51313

6 years agoCheck presence of PagingRecordList before trying to fetch the number of Paging Ids
Pascal Quantin [Mon, 12 Aug 2013 09:56:30 +0000 (09:56 -0000)]
Check presence of PagingRecordList before trying to fetch the number of Paging Ids

svn path=/trunk/; revision=51312

6 years agoFix copy paste error and reinitialize actx->private_data to NULL once used
Pascal Quantin [Mon, 12 Aug 2013 09:26:24 +0000 (09:26 -0000)]
Fix copy paste error and reinitialize actx->private_data to NULL once used

svn path=/trunk/; revision=51311

6 years agoFix a comment.
Guy Harris [Mon, 12 Aug 2013 09:18:54 +0000 (09:18 -0000)]
Fix a comment.

Fix calls checking the Linux version number.

svn path=/trunk/; revision=51310

6 years agoOn some platforms, to get dladdr() you need to link with -ldl. First
Guy Harris [Mon, 12 Aug 2013 09:09:32 +0000 (09:09 -0000)]
On some platforms, to get dladdr() you need to link with -ldl.  First
try it without -ldl (in case the OS doesn't have it - not a good idea,
as it complicates the build process for cross-platform tools that might
require it on other platforms, but "not a good idea" never stopped UN*X
vendors in the past) and, if that fails, try it with -ldl.

svn path=/trunk/; revision=51309

6 years agoAdd in a bunch of UNIX-platform-specific ways of getting executable path
Guy Harris [Mon, 12 Aug 2013 08:28:34 +0000 (08:28 -0000)]
Add in a bunch of UNIX-platform-specific ways of getting executable path
information supplied by the kernel; sadly, we can't trust dladdr() to
use those mechanisms, so we try this first.

Expand the comment about finding the application bundle path given the
executable image path.

svn path=/trunk/; revision=51308

6 years agoAdd a comment discussing the layout of application bundles and the
Guy Harris [Mon, 12 Aug 2013 01:20:20 +0000 (01:20 -0000)]
Add a comment discussing the layout of application bundles and the
directories we should - and perhaps should *not* - set up.

svn path=/trunk/; revision=51307

6 years agoIf we weren't started with special privileges, try to figure out if
Guy Harris [Mon, 12 Aug 2013 00:59:34 +0000 (00:59 -0000)]
If we weren't started with special privileges, try to figure out if
we're running from inside an OS X app bundle and, if we are, save the
pathname of the top-level bundle directory and use it to get the
pathnames of global data files, plugins, and Python modules.

This obviates the need to set special environment variables for them in
the launcher scripts, so get rid of the commands to do that.

The @rpathification of binaries also obviates the need for the
commented-out setting of DYLD_LIBRARY_PATH, so get rid of that as well.

svn path=/trunk/; revision=51306

6 years agoReorder and group chunk header flags. Reduces the bit-twiddling needed by the
Evan Huus [Sun, 11 Aug 2013 23:49:56 +0000 (23:49 -0000)]
Reorder and group chunk header flags. Reduces the bit-twiddling needed by the
compiler and provides a surprising (if fairly small) performance win.

svn path=/trunk/; revision=51305

6 years agoSplit jumbo_free and jumbo_realloc into their own functions for readability and
Evan Huus [Sun, 11 Aug 2013 22:32:46 +0000 (22:32 -0000)]
Split jumbo_free and jumbo_realloc into their own functions for readability and
consistency (they are called just once and will be inlined by any reasonable
compiler).

Also add some comments, fix some spacing etc. No functional changes.

svn path=/trunk/; revision=51304

6 years agoMove the null check outside the function call. Simpler, and more efficient for
Evan Huus [Sun, 11 Aug 2013 22:20:35 +0000 (22:20 -0000)]
Move the null check outside the function call. Simpler, and more efficient for
compilers that decide not to inline.

svn path=/trunk/; revision=51303

6 years agoLittle optimization: move two statements inside an if block.
Evan Huus [Sun, 11 Aug 2013 19:33:30 +0000 (19:33 -0000)]
Little optimization: move two statements inside an if block.

svn path=/trunk/; revision=51302

6 years agoUse g_hashtable for IPv4 name resolution.
Anders Broman [Sun, 11 Aug 2013 19:02:26 +0000 (19:02 -0000)]
Use g_hashtable for IPv4 name resolution.

svn path=/trunk/; revision=51301

6 years agoDon't let a valgrind-output-parsing error hide the fact that it was an error of
Evan Huus [Sun, 11 Aug 2013 17:48:49 +0000 (17:48 -0000)]
Don't let a valgrind-output-parsing error hide the fact that it was an error of
some sort: if we don't recognize valgrind's output then something somewhere went
wrong and we should be informed.

svn path=/trunk/; revision=51300

6 years agoAdd support for allocating more than will fit in a single block, through the use
Evan Huus [Sun, 11 Aug 2013 17:18:19 +0000 (17:18 -0000)]
Add support for allocating more than will fit in a single block, through the use
of a jumbo flag in the chunk header.

svn path=/trunk/; revision=51299

6 years agoInstead of using a glib slist to track the list of blocks, embed a short
Evan Huus [Sun, 11 Aug 2013 16:06:07 +0000 (16:06 -0000)]
Instead of using a glib slist to track the list of blocks, embed a short
doubly-linked list at the head of each block. This was intended as a step
towards supporting allocations bigger than the usual block size, but also shows
up as a 2% performance improvement in the speed test, so win-win.

svn path=/trunk/; revision=51298

6 years agoSmall optimization: the master-list and recycler cases are different enough that
Evan Huus [Sun, 11 Aug 2013 14:20:00 +0000 (14:20 -0000)]
Small optimization: the master-list and recycler cases are different enough that
doing all the safety checks was unnecessarily slow. Do only the appropriate
checks for each case.

svn path=/trunk/; revision=51296

6 years ago[Automatic manuf, services and enterprise-numbers update for 2013-08-11]
Gerald Combs [Sun, 11 Aug 2013 14:03:40 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2013-08-11]

svn path=/trunk/; revision=51294

6 years agoSplit some asserts so it is more clear what the problem is when they are
Evan Huus [Sun, 11 Aug 2013 13:44:11 +0000 (13:44 -0000)]
Split some asserts so it is more clear what the problem is when they are
triggered.

svn path=/trunk/; revision=51293

6 years agoFree a few hash tables in packet.c when we shutdown.
Evan Huus [Sun, 11 Aug 2013 13:42:12 +0000 (13:42 -0000)]
Free a few hash tables in packet.c when we shutdown.

svn path=/trunk/; revision=51292

6 years agoModelines and consistent indentation.
Evan Huus [Sun, 11 Aug 2013 00:50:51 +0000 (00:50 -0000)]
Modelines and consistent indentation.

Also tweak some ifdefs of function signatures. The multiple braces were
confusing my folder and my indenter, so ifdef *only* the changed parameters and
leave the bracing alone. This has the benefit of being a bit clearer too, I
think.

svn path=/trunk/; revision=51291

6 years agoFix 130KB of leaked memory exposed (or caused?) by the conversion to glib hash
Evan Huus [Sun, 11 Aug 2013 00:35:22 +0000 (00:35 -0000)]
Fix 130KB of leaked memory exposed (or caused?) by the conversion to glib hash
tables.

svn path=/trunk/; revision=51290

6 years agoInitialize float variables with float constants, not double constants,
Guy Harris [Sat, 10 Aug 2013 21:34:15 +0000 (21:34 -0000)]
Initialize float variables with float constants, not double constants,
and assign float constants, not double constants, to float variables.
Floating-point constants are double by default; you have to add "f" to
the end to make them float.

This squelches 64-bit-to-32-bit warnings.

svn path=/trunk/; revision=51289

6 years agoRPKI-RTR is not a asn1 dissector...
Alexis La Goutte [Sat, 10 Aug 2013 21:32:48 +0000 (21:32 -0000)]
RPKI-RTR is not a asn1 dissector...

svn path=/trunk/; revision=51288

6 years agoUpdate .gitignore
Alexis La Goutte [Sat, 10 Aug 2013 21:32:40 +0000 (21:32 -0000)]
Update .gitignore

Add :
packaging/macosx/Wireshark_package.pmdoc/index.xml
and lib(wireshark/wiretap/wsutil).so.*

svn path=/trunk/; revision=51287

6 years agoFix (-W)header-guard error found by clang 3.4
Alexis La Goutte [Sat, 10 Aug 2013 21:32:32 +0000 (21:32 -0000)]
Fix (-W)header-guard error found by clang 3.4

./frame_tvbuff.h:25:9: error: '__FRAME_TVBUFF__' is used as a header guard here,
      followed by #define of a different macro [-Werror,-Wheader-guard]
#ifndef __FRAME_TVBUFF__
        ^~~~~~~~~~~~~~~~
./frame_tvbuff.h:26:9: note: '__FRAME_TVBUFF_H__' is defined here; did you mean
      '__FRAME_TVBUFF__'?
#define __FRAME_TVBUFF_H__
        ^~~~~~~~~~~~~~~~~~
        __FRAME_TVBUFF__

svn path=/trunk/; revision=51286

6 years agoFix (-W)header-guard error found by clang 3.4
Alexis La Goutte [Sat, 10 Aug 2013 21:32:24 +0000 (21:32 -0000)]
Fix (-W)header-guard error found by clang 3.4

./packet-ldp.h:26:9: error: '__PACKET_LDP_H_' is used as a header guard here,
      followed by #define of a different macro [-Werror,-Wheader-guard]
#ifndef __PACKET_LDP_H_
        ^~~~~~~~~~~~~~~
./packet-ldp.h:27:9: note: '__PACKET_LDP_H__' is defined here; did you mean
      '__PACKET_LDP_H_'?
#define __PACKET_LDP_H__
        ^~~~~~~~~~~~~~~~
        __PACKET_LDP_H_

svn path=/trunk/; revision=51285

6 years agoFix (-W)header-guard error found by clang 3.4
Alexis La Goutte [Sat, 10 Aug 2013 21:32:16 +0000 (21:32 -0000)]
Fix (-W)header-guard error found by clang 3.4

./packet-idp.h:25:9: error: '__PACKET_IDP_H__' is used as a header guard here,
      followed by #define of a different macro [-Werror,-Wheader-guard]
#ifndef __PACKET_IDP_H__
        ^~~~~~~~~~~~~~~~
./packet-idp.h:26:9: note: '__PACKET_IPX_H__' is defined here; did you mean
      '__PACKET_IDP_H__'?
#define __PACKET_IPX_H__
        ^~~~~~~~~~~~~~~~
        __PACKET_IDP_H__

svn path=/trunk/; revision=51284

6 years agoFix (-W)header-guard error found by clang 3.4
Alexis La Goutte [Sat, 10 Aug 2013 21:32:08 +0000 (21:32 -0000)]
Fix (-W)header-guard error found by clang 3.4

../../epan/dissectors/packet-mpeg-sect.h:26:9: error: '__PACKET_MPEG_SECT_H_' is
      used as a header guard here, followed by #define of a different macro
      [-Werror,-Wheader-guard]
#ifndef __PACKET_MPEG_SECT_H_
        ^~~~~~~~~~~~~~~~~~~~~
../../epan/dissectors/packet-mpeg-sect.h:27:9: note: '__PACKET_MPEG_SECT_H__' is
      defined here; did you mean '__PACKET_MPEG_SECT_H_'?
#define __PACKET_MPEG_SECT_H__
        ^~~~~~~~~~~~~~~~~~~~~~
        __PACKET_MPEG_SECT_H_

svn path=/trunk/; revision=51283

6 years agoFix (-W)header-guard error found by clang 3.4
Alexis La Goutte [Sat, 10 Aug 2013 21:31:59 +0000 (21:31 -0000)]
Fix (-W)header-guard error found by clang 3.4

./packet-osi-options.h:26:9: error: '_PACKET_OSI_OPTION_H' is used as a header
      guard here, followed by #define of a different macro
      [-Werror,-Wheader-guard]
#ifndef _PACKET_OSI_OPTION_H
        ^~~~~~~~~~~~~~~~~~~~
./packet-osi-options.h:27:9: note: '_PACKET_OSI_OPTIONS_H' is defined here; did
      you mean '_PACKET_OSI_OPTION_H'?
#define _PACKET_OSI_OPTIONS_H
        ^~~~~~~~~~~~~~~~~~~~~
        _PACKET_OSI_OPTION_H

svn path=/trunk/; revision=51282

6 years agoFix (-W)header-guard error found by clang 3.4
Alexis La Goutte [Sat, 10 Aug 2013 21:31:51 +0000 (21:31 -0000)]
Fix (-W)header-guard error found by clang 3.4

./packet-bluetooth-hci.h:24:9: error: '__PACKET_BLUETOOTH_HCI_H__' is used as a
      header guard here, followed by #define of a different macro
      [-Werror,-Wheader-guard]
#ifndef __PACKET_BLUETOOTH_HCI_H__
        ^~~~~~~~~~~~~~~~~~~~~~~~~~
./packet-bluetooth-hci.h:25:9: note: '__PACKET_BLUETOOTH_HCI__H__' is defined
      here; did you mean '__PACKET_BLUETOOTH_HCI_H__'?
#define __PACKET_BLUETOOTH_HCI__H__
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~
        __PACKET_BLUETOOTH_HCI_H__

svn path=/trunk/; revision=51281

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:31:43 +0000 (21:31 -0000)]
Fix (-W)documentation error found by Clang

rawshark.c:889:11: error: parameter 'fd' not found in the function declaration
      [-Werror,-Wdocumentation]
 * @param fd [IN] A POSIX file descriptor.  Because that's _exactly_ the sort
          ^~
rawshark.c:889:11: note: did you mean 'pd'?
 * @param fd [IN] A POSIX file descriptor.  Because that's _exactly_ the sort
          ^~
          pd

svn path=/trunk/; revision=51280

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:31:35 +0000 (21:31 -0000)]
Fix (-W)documentation error found by Clang

In file included from main_menubar.c:110:
../../ui/gtk/proto_help.h:39:5: error: '@return' command used in a comment that
      is attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
../../ui/gtk/proto_help.h:47:5: error: '@return' command used in a comment that
      is attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~

svn path=/trunk/; revision=51279

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:31:27 +0000 (21:31 -0000)]
Fix (-W)documentation error found by Clang

../../epan/ftypes/../emem.h:34:3: error: empty paragraph passed to '@details'
      command [-Werror,-Wdocumentation]
 */
  ^

svn path=/trunk/; revision=51278

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:31:19 +0000 (21:31 -0000)]
Fix (-W)documentation error found by Clang

../../ui/gtk/gui_stat_menu.h:47:11: error: parameter 'group' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param group the menu group this stat should be registered to
          ^~~~~

svn path=/trunk/; revision=51277

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:31:10 +0000 (21:31 -0000)]
Fix (-W)documentation error found by Clang

../../ui/gtk/filter_autocomplete.h:41:15: error: empty paragraph passed to
      '@param' command [-Werror,-Wdocumentation]
 * @param event
   ~~~~~~~~~~~^
../../ui/gtk/filter_autocomplete.h:49:15: error: empty paragraph passed to
      '@param' command [-Werror,-Wdocumentation]
 * @param event
   ~~~~~~~~~~~^

svn path=/trunk/; revision=51276

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:31:02 +0000 (21:31 -0000)]
Fix (-W)documentation error found by Clang

../ui/preference_utils.h:40:11: error: parameter 'pref:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param pref: A preference.
          ^~~~~
../ui/preference_utils.h:40:11: note: did you mean 'pref'?
 * @param pref: A preference.
          ^~~~~
          pref
../ui/preference_utils.h:41:11: error: parameter 'unused:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param unused: unused
          ^~~~~~~
../ui/preference_utils.h:41:11: note: did you mean 'unused'?
 * @param unused: unused
          ^~~~~~~
          unused
../ui/preference_utils.h:48:11: error: parameter 'pref:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param pref: A preference.
          ^~~~~
../ui/preference_utils.h:48:11: note: did you mean 'pref'?
 * @param pref: A preference.
          ^~~~~
          pref
../ui/preference_utils.h:49:11: error: parameter 'changed_p:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param changed_p: A pointer to a gboolean. Set to TRUE if the prefere...
          ^~~~~~~~~~
../ui/preference_utils.h:49:11: note: did you mean 'changed_p'?
 * @param changed_p: A pointer to a gboolean. Set to TRUE if the prefere...
          ^~~~~~~~~~
          changed_p
../ui/preference_utils.h:60:11: error: parameter 'unused:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param unused: unused
          ^~~~~~~
../ui/preference_utils.h:60:11: note: did you mean 'unused'?
 * @param unused: unused
          ^~~~~~~
          unused

svn path=/trunk/; revision=51275

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:30:54 +0000 (21:30 -0000)]
Fix (-W)documentation error found by Clang

../ui/preference_utils.h:40:11: error: parameter 'pref:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param pref: A preference.
          ^~~~~
../ui/preference_utils.h:40:11: note: did you mean 'pref'?
 * @param pref: A preference.
          ^~~~~
          pref
../ui/preference_utils.h:41:11: error: parameter 'unused:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param unused: unused
          ^~~~~~~
../ui/preference_utils.h:41:11: note: did you mean 'unused'?
 * @param unused: unused
          ^~~~~~~
          unused
../ui/preference_utils.h:48:11: error: parameter 'pref:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param pref: A preference.
          ^~~~~
../ui/preference_utils.h:48:11: note: did you mean 'pref'?
 * @param pref: A preference.
          ^~~~~
          pref
../ui/preference_utils.h:49:11: error: parameter 'changed_p:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param changed_p: A pointer to a gboolean. Set to TRUE if the prefere...
          ^~~~~~~~~~
../ui/preference_utils.h:49:11: note: did you mean 'changed_p'?
 * @param changed_p: A pointer to a gboolean. Set to TRUE if the prefere...
          ^~~~~~~~~~
          changed_p
../ui/preference_utils.h:60:11: error: parameter 'unused:' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param unused: unused
          ^~~~~~~
../ui/preference_utils.h:60:11: note: did you mean 'unused'?
 * @param unused: unused
          ^~~~~~~
          unused

svn path=/trunk/; revision=51274

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:30:46 +0000 (21:30 -0000)]
Fix (-W)documentation error found by Clang

./packet_list_utils.h:37:11: error: parameter 'col[IN]' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param col[IN] The column number.
          ^~~~~~~
./packet_list_utils.h:38:11: error: parameter 'cf[IN]' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param cf[IN] The capture file containing the packet data.
          ^~~~~~
./packet_list_utils.h:47:11: error: parameter 'col[IN]' not found in the
      function declaration [-Werror,-Wdocumentation]
 * @param col[IN] The column number.
          ^~~~~~~
./packet_list_utils.h:48:11: error: parameter 'cf[IN]' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param cf[IN] The capture file containing the packet data.
          ^~~~~~

svn path=/trunk/; revision=51273

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:30:38 +0000 (21:30 -0000)]
Fix (-W)documentation error found by Clang

../../asn1/c1222/packet-c1222-template.c:348:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:349:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:350:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param length
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:351:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param offset
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:758:11: error: parameter 'keybuf' not
      found in the function declaration [-Werror,-Wdocumentation]
 * \param keybuf is updated with a copy of the key data if successful lookup.
          ^~~~~~
../../asn1/c1222/packet-c1222-template.c:758:11: note: did you mean 'keybuff'?
 * \param keybuf is updated with a copy of the key data if successful lookup.
          ^~~~~~
          keybuff
../../asn1/c1222/packet-c1222-template.c:879:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:880:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param offset
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:881:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param len
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:882:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:883:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1023:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1024:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1025:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1047:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1048:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1049:16: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param offset
   ~~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1068:13: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tvb
   ~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1069:15: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param pinfo
   ~~~~~~~~~~~^
../../asn1/c1222/packet-c1222-template.c:1070:14: error: empty paragraph passed
      to '\param' command [-Werror,-Wdocumentation]
 * \param tree
   ~~~~~~~~~~^

svn path=/trunk/; revision=51272

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:30:30 +0000 (21:30 -0000)]
Fix (-W)documentation error found by Clang

packet-umts_fp.c:3486:12: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
* @param tvb
  ~~~~~~~~~^
packet-umts_fp.c:3488:13: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
* @param tree
  ~~~~~~~~~~^
packet-umts_fp.c:3489:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
* @param offset
  ~~~~~~~~~~~~^
packet-umts_fp.c:3491:4: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
* @return Void.
  ~^~~~~~~~~~~~

svn path=/trunk/; revision=51271

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:30:18 +0000 (21:30 -0000)]
Fix (-W)documentation error found by Clang

packet-ucp.c:781:5: error: '\return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * \return              For 'int'-types, the value of the field.
   ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
packet-ucp.c:954:17: error: parameter 'field' not found in the function
      declaration [-Werror,-Wdocumentation]
 * \param       field   The actual field, whose value needs displaying
                ^~~~~

svn path=/trunk/; revision=51270

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:30:08 +0000 (21:30 -0000)]
Fix (-W)documentation error found by Clang

packet-knet.c:466:5: error: '@return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-knet.c:518:5: error: '@return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-knet.c:677:5: error: '@return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-knet.c:697:5: error: '@return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-knet.c:717:5: error: '@return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-knet.c:731:5: error: '@return' command used in a comment that is attached
      to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~

svn path=/trunk/; revision=51269

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:59 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

packet-jxta.c:1668:13: error: parameter 'names' not found in the function
      declaration [-Werror,-Wdocumentation]
*   @param  names The table of names.
            ^~~~~
packet-jxta.c:1668:13: note: did you mean 'names_table'?
*   @param  names The table of names.
            ^~~~~
            names_table

svn path=/trunk/; revision=51268

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:51 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

./packet-gsm_rlcmac.h:1086:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< MS Radio Access capability IE >
^~~
/**<
./packet-gsm_rlcmac.h:1089:26: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
typedef guint8 A5_bits_t;/*<A5 bits> ::= < A5/1 : bit> <A5/2 : bit> <A5/...
                         ^~~~~
                         /**<
packet-gsm_rlcmac.c:169:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Global TFI IE >*/
^~~
/**<
packet-gsm_rlcmac.c:171:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Starting Frame Number Description IE >*/
^~~
/**<
packet-gsm_rlcmac.c:174:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Ack/Nack Description IE >*/
^~~
/**<
packet-gsm_rlcmac.c:178:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Packet Timing Advance IE >*/
^~~
/**<
packet-gsm_rlcmac.c:183:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Power Control Parameters IE >*/
^~~
/**<
packet-gsm_rlcmac.c:191:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Global Power Control Parameters IE >*/
^~~
/**<
packet-gsm_rlcmac.c:195:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Global Packet Timing Advance IE >*/
^~~
/**<
packet-gsm_rlcmac.c:197:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Channel Quality Report struct >*/
^~~
/**<
packet-gsm_rlcmac.c:210:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< EGPRS Ack/Nack Description >*/
^~~
/**<
packet-gsm_rlcmac.c:216:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*<P1 Rest Octets>*/
^~~~~
/**<
packet-gsm_rlcmac.c:218:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*<P2 Rest Octets>*/
^~~~~
/**<
packet-gsm_rlcmac.c:264:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< SI 13 Rest Octets >*/
^~~
/**<
packet-gsm_rlcmac.c:288:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Packet TBF Release message content >*/
^~~
/**<
packet-gsm_rlcmac.c:293:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Packet Control Acknowledgement message content >*/
^~~
/**<
packet-gsm_rlcmac.c:299:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Packet Downlink Dummy Control Block message content >*/
^~~
/**<
packet-gsm_rlcmac.c:301:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< Packet Uplink Dummy Control Block message content >*/
^~~
/**<
packet-gsm_rlcmac.c:305:1: error: not a Doxygen trailing comment
      [-Werror,-Wdocumentation]
/*< MS Radio Access capability IE >*/
^~~
/**<

svn path=/trunk/; revision=51267

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:42 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

packet-eigrp.c:633:10: error: unrecognized parameter passing direction, valid
      directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[in|out] tree  detail dissection result
         ^~~~~~~~
packet-eigrp.c:638:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:691:10: error: unrecognized parameter passing direction, valid
      directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[in|out] tree  detail dissection result
         ^~~~~~~~
packet-eigrp.c:696:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:765:10: error: unrecognized parameter passing direction, valid
      directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[in|out] tree  detail dissection result
         ^~~~~~~~
packet-eigrp.c:769:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:814:10: error: unrecognized parameter passing direction, valid
      directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[in|out] tree  detail dissection result
         ^~~~~~~~
packet-eigrp.c:818:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:853:10: error: unrecognized parameter passing direction, valid
      directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[in|out] tree  detail dissection result
         ^~~~~~~~
packet-eigrp.c:857:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:878:10: error: unrecognized parameter passing direction, valid
      directions are '[in]', '[out]' and '[in,out]' [-Werror,-Wdocumentation]
 * @param[in|out] tree  detail dissection result
         ^~~~~~~~
packet-eigrp.c:882:19: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param[out] None
   ~~~~~~~~~~~~~~~^
packet-eigrp.c:884:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:880:15: error: parameter 'pinfo' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[in] pinfo     general data about the protocol
              ^~~~~
packet-eigrp.c:881:15: error: parameter 'ti' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[in] ti        protocol item
              ^~
packet-eigrp.c:882:16: error: parameter 'None' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[out] None
               ^~~~
packet-eigrp.c:902:19: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param[out] None
   ~~~~~~~~~~~~~~~^
packet-eigrp.c:904:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~
packet-eigrp.c:902:16: error: parameter 'None' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[out] None
               ^~~~
packet-eigrp.c:1712:15: error: parameter 'pinfo' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[in] pinfo     general data about the protocol
              ^~~~~
packet-eigrp.c:1712:15: note: did you mean 'ti'?
 * @param[in] pinfo     general data about the protocol
              ^~~~~
              ti
packet-eigrp.c:2585:18: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param[in] void
   ~~~~~~~~~~~~~~^
packet-eigrp.c:2585:15: error: parameter 'void' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[in] void
              ^~~~
packet-eigrp.c:3324:18: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param[in] void
   ~~~~~~~~~~~~~~^
packet-eigrp.c:3324:15: error: parameter 'void' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param[in] void
              ^~~~

svn path=/trunk/; revision=51266

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:33 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

./packet-ssl-utils.h:463:16: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 @param comp_str
 ~~~~~~~~~~~~~~^

svn path=/trunk/; revision=51265

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:24 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

./packet-mstp.h:31:13: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param val
   ~~~~~~~~~^
./packet-mstp.h:41:13: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
./packet-mstp.h:42:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
./packet-mstp.h:43:14: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
./packet-mstp.h:44:17: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param subtree
   ~~~~~~~~~~~~~^
./packet-mstp.h:45:16: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^
./packet-mstp.h:46:5: error: '@return' command used in a comment that is
      attached to a function returning void [-Werror,-Wdocumentation]
 * @return none
   ~^~~~~~~~~~~

svn path=/trunk/; revision=51264

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:16 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

./packet-cell_broadcast.h:33:13: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
./packet-cell_broadcast.h:34:14: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
./packet-cell_broadcast.h:35:16: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^
./packet-cell_broadcast.h:43:13: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
./packet-cell_broadcast.h:44:14: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
./packet-cell_broadcast.h:45:16: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^
./packet-cell_broadcast.h:53:13: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
./packet-cell_broadcast.h:54:15: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
./packet-cell_broadcast.h:55:14: error: empty paragraph passed to '@param'
      command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^

svn path=/trunk/; revision=51263

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:29:08 +0000 (21:29 -0000)]
Fix (-W)documentation error found by Clang

../../epan/xdlc.h:48:29: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
#define XDLC_N_R_MASK           0xE0    /*< basic */
                                        ^~~
                                        /**<
../../epan/xdlc.h:50:34: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
#define XDLC_N_R_EXT_MASK       0xFE00  /*< extended */
                                        ^~~
                                        /**<
../../epan/xdlc.h:52:29: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
#define XDLC_N_S_MASK           0x0E    /*< basic */
                                        ^~~
                                        /**<
../../epan/xdlc.h:54:34: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
#define XDLC_N_S_EXT_MASK       0x00FE  /*< extended */
                                        ^~~
                                        /**<
../../epan/xdlc.h:60:24: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
#define XDLC_P_F                0x10    /*< basic */
                                        ^~~
                                        /**<
../../epan/xdlc.h:61:29: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
#define XDLC_P_F_EXT    0x0100  /*< extended */
                                ^~~
                                /**<

svn path=/trunk/; revision=51262

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:59 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

packet-bacapp.c:78:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
packet-bacapp.c:79:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
packet-bacapp.c:80:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
packet-bacapp.c:100:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
packet-bacapp.c:101:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
packet-bacapp.c:102:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
packet-bacapp.c:103:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^
packet-bacapp.c:110:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
packet-bacapp.c:111:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
packet-bacapp.c:112:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
packet-bacapp.c:113:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^
packet-bacapp.c:130:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
packet-bacapp.c:131:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
packet-bacapp.c:132:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
packet-bacapp.c:133:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^
packet-bacapp.c:146:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tvb
   ~~~~~~~~~^
packet-bacapp.c:147:15: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param pinfo
   ~~~~~~~~~~~^
packet-bacapp.c:148:14: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param tree
   ~~~~~~~~~~^
packet-bacapp.c:149:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param offset
   ~~~~~~~~~~~~^

packet-bacapp.c:251:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^
packet-bacapp.c:263:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^
packet-bacapp.c:275:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^
packet-bacapp.c:288:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^
packet-bacapp.c:300:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^
packet-bacapp.c:325:24: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param service_choice
   ~~~~~~~~~~~~~~~~~~~~^
packet-bacapp.c:338:24: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param service_choice
   ~~~~~~~~~~~~~~~~~~~~^
packet-bacapp.c:521:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^
packet-bacapp.c:522:13: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param src
   ~~~~~~~~~^
packet-bacapp.c:521:11: error: parameter 'label' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param label
          ^~~~~
packet-bacapp.c:522:11: error: parameter 'src' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param src
          ^~~
packet-bacapp.c:654:11: error: parameter 'tree' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param tree the tree to append this item to
          ^~~~
packet-bacapp.c:654:11: note: did you mean 'subtree'?
 * @param tree the tree to append this item to
          ^~~~
          subtree
packet-bacapp.c:723:11: error: parameter 'tree' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param tree the tree to append this item to
          ^~~~
packet-bacapp.c:723:11: note: did you mean 'subtree'?
 * @param tree the tree to append this item to
          ^~~~
          subtree
packet-bacapp.c:749:11: error: parameter 'tree' not found in the function
      declaration [-Werror,-Wdocumentation]
 * @param tree the tree to append this item to
          ^~~~
packet-bacapp.c:749:11: note: did you mean 'subtree'?
 * @param tree the tree to append this item to
          ^~~~
          subtree
packet-bacapp.c:1076:24: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param service_choice
   ~~~~~~~~~~~~~~~~~~~~^
packet-bacapp.c:1266:17: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param service
   ~~~~~~~~~~~~~^
packet-bacapp.c:1337:4: error: unknown command tag name 'pram'; did you mean
      'param'? [-Werror,-Wdocumentation]
 * @pram pinfo
   ^~~~~
    param
packet-bacapp.c:1337:14: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @pram pinfo
         ~~~~^
packet-bacapp.c:1366:15: error: empty paragraph passed to '@param' command
      [-Werror,-Wdocumentation]
 * @param label
   ~~~~~~~~~~~^

svn path=/trunk/; revision=51261

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:50 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

packet-9p.c:342:16: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
        guint16  len; /*< Length of the string */
                      ^~~
                      /**<
packet-9p.c:343:13: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
        char *str; /*< The string */
                   ^~~
                   /**<
packet-9p.c:364:15: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
        guint8 type; /*< Type */
                     ^~~
                     /**<
packet-9p.c:365:19: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
        guint32 version; /*< Monotonically incrementing version number */
                         ^~~
                         /**<
packet-9p.c:366:16: error: not a Doxygen trailing comment [-Werror,-Wdocumentation]
        guint64 path; /*< Per-server-unique ID for a file system element */
                      ^~~
                      /**<
5 errors generated

svn path=/trunk/; revision=51260

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:42 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

../../epan/wmem/wmem_user_cb.h:52:11: error: parameter 'allocator' not found in the function declaration
      [-Werror,-Wdocumentation]
 * @param allocator The allocator that triggered this callback.
          ^~~~~~~~~
../../epan/wmem/wmem_user_cb.h:53:11: error: parameter 'event' not found in the function declaration
      [-Werror,-Wdocumentation]
 * @param event     The event type that triggered this callback.
          ^~~~~
../../epan/wmem/wmem_user_cb.h:54:11: error: parameter 'user_data' not found in the function declaration
      [-Werror,-Wdocumentation]
 * @param user_data Whatever user_data was originally passed to the call to
          ^~~~~~~~~
../../epan/wmem/wmem_user_cb.h:63:11: error: parameter 'recurring' not found in the function declaration
      [-Werror,-Wdocumentation]
 * @param recurring If this is FALSE then the callback is called exactly once.
          ^~~~~~~~~
4 errors generated.

svn path=/trunk/; revision=51259

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:33 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

../../epan/expert.h:176:9: warning: parameter 'pi' not found in the function declaration [-Wdocumentation]
 @param pi Current protocol item (or NULL)
        ^~
../../epan/expert.h:176:9: note: did you mean 'tree'?
 @param pi Current protocol item (or NULL)
        ^~
        tree
../../epan/expert.h:195:9: warning: parameter 'pi' not found in the function declaration [-Wdocumentation]
 @param pi Current protocol item (or NULL)
        ^~
2 warnings generated.

svn path=/trunk/; revision=51258

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:25 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

../../epan/uat.h:245:23: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 * @param num_items_ptr
   ~~~~~~~~~~~~~~~~~~~^
1 error generated.

svn path=/trunk/; revision=51257

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:17 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

../../epan/range.h:87:11: error: empty paragraph passed to '@return' command [-Werror,-Wdocumentation]
 * @return
   ~~~~~~~^
../../epan/range.h:86:11: error: parameter 'max_value'' not found in the function declaration [-Werror,-Wdocumentation]
 * @param max_value' specifies the maximum value in a range.
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../epan/range.h:86:11: note: did you mean 'max_value'?
 * @param max_value' specifies the maximum value in a range.
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
          max_value

svn path=/trunk/; revision=51256

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:10 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

In file included from ../../epan/packet.h:29:
./../proto.h:1775:16: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 @param protocol
 ~~~~~~~~~~~~~~^
./../proto.h:1947:13: error: empty paragraph passed to '@param' command [-Werror,-Wdocumentation]
 @param flags
 ~~~~~~~~~~~^

svn path=/trunk/; revision=51255

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:28:01 +0000 (21:28 -0000)]
Fix (-W)documentation error found by Clang

airpdcap.c:131:11: error: parameter 'password' not found in the function declaration [-Werror,-Wdocumentation]
 * @param password [IN] pointer to a password (sequence of between 8 and
          ^~~~~~~~
airpdcap.c:154:11: error: parameter 'password' not found in the function declaration [-Werror,-Wdocumentation]
 * @param password [IN] pointer to a password (sequence of between 8 and
          ^~~~~~~~

svn path=/trunk/; revision=51254

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:27:52 +0000 (21:27 -0000)]
Fix (-W)documentation error found by Clang

../../epan/emem.h:560:5: error: '@return' command used in a comment that is attached to a function returning void
      [-Werror,-Wdocumentation]
 * @return void
   ~^~~~~~~~~~~

svn path=/trunk/; revision=51253

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:27:42 +0000 (21:27 -0000)]
Fix (-W)documentation error found by Clang

./str_util.h:72:11: error: parameter 'str' not found in the function declaration [-Werror,-Wdocumentation]
 * @param str The string to be checked
          ^~~
./str_util.h:72:11: note: did you mean 'string'?
 * @param str The string to be checked
          ^~~
          string
./str_util.h:80:11: error: parameter 'str' not found in the function declaration [-Werror,-Wdocumentation]
 * @param str The string to be checked
          ^~~
./str_util.h:80:11: note: did you mean 'string'?
 * @param str The string to be checked
          ^~~
          string

svn path=/trunk/; revision=51252

6 years agoFix (-W)documentation error found by Clang
Alexis La Goutte [Sat, 10 Aug 2013 21:27:34 +0000 (21:27 -0000)]
Fix (-W)documentation error found by Clang

../wsutil/crc16.h:68:11: error: parameter 'pBuffer' not found in the function declaration [-Werror,-Wdocumentation]
 * @param pBuffer a pointer to a buffer of the given length
          ^~~~~~~
../wsutil/crc16.h:68:11: note: did you mean 'buf'?
 * @param pBuffer a pointer to a buffer of the given length
          ^~~~~~~
          buf
../wsutil/crc16.h:77:11: error: parameter 'pBuffer' not found in the function declaration [-Werror,-Wdocumentation]
 * @param pBuffer a pointer to a buffer of the given length
          ^~~~~~~
../wsutil/crc16.h:77:11: note: did you mean 'buf'?
 * @param pBuffer a pointer to a buffer of the given length
          ^~~~~~~
          buf

svn path=/trunk/; revision=51251

6 years agoFix error when build with clang 3.0
Alexis La Goutte [Sat, 10 Aug 2013 21:27:26 +0000 (21:27 -0000)]
Fix error when build with clang 3.0

dumpcap.c:3981:88: error: implicit conversion loses integer precision: 'const __suseconds_t'
      (aka 'const long') to 'guint32' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                                                             phdr->ts.tv_sec, phdr->ts.tv_usec,
                                                                              ~~~~~~~~~^~~~~~~
dumpcap.c:3989:73: error: implicit conversion loses integer precision: 'const __suseconds_t'
      (aka 'const long') to 'guint32' (aka 'unsigned int') [-Werror,-Wshorten-64-to-32]
                                              phdr->ts.tv_sec, phdr->ts.tv_usec,
                                                               ~~~~~~~~~^~~~~~~

svn path=/trunk/; revision=51250

6 years agoFix error when build with clang 3.0
Alexis La Goutte [Sat, 10 Aug 2013 21:27:17 +0000 (21:27 -0000)]
Fix error when build with clang 3.0

wiretap/lanalyzer.c:643:24: error: implicit conversion loses integer precision: 'const __suseconds_t'
      (aka 'const long') to 'gint32' (aka 'int') [-Werror,-Wshorten-64-to-32]
      gint32 usec = a->tv_usec;
             ~~~~   ~~~^~~~~~~

svn path=/trunk/; revision=51249