Chris Maynard [Mon, 29 Jul 2013 15:43:37 +0000 (15:43 -0000)]
Trivial: Fix typo.
svn path=/trunk/; revision=51011
Guy Harris [Mon, 29 Jul 2013 08:37:18 +0000 (08:37 -0000)]
In the comments for pcap_link_type, point to
http://www.tcpdump.org/linktypes.html for the details, rather than to
some particular OS's net/bpf.h (assuming it even has one), and speak of
it as a LINKTYPE_ value rather than a DLT_ value (in those cases where
the LINKTYPE_ value for a given link-layer header type is different from
the DLT_ value, it's the LINKTYPE_ value that should be passed to
text2pcap, as it's what gets written to the file, and those should be
the always-platform-independent LINKTYPE_ values rather than the
possibly-platform-dependent DLT_ values).
svn path=/trunk/; revision=51008
Guy Harris [Mon, 29 Jul 2013 08:30:42 +0000 (08:30 -0000)]
The argument to the -l flag to text2pcap is a LINKTYPE_ value, not a
DLT_ value, which is good because it's a numerical value and the
numerical values for some link-layer header types are OS-dependent, but
the numerical values for all LINKTYPE_ values are OS-independent. Use
LINKTYPE_RAW, not the value for the DLT_RAW on some but not all OSes,
for raw IP.
Also, 7 is LINKTYPE_ARCNET_BSD, emphasis on the "_BSD"; there's also a
Linux encapsulation for ARCNet that is different. Note that it's the
BSD flavor.
svn path=/trunk/; revision=51005
Pascal Quantin [Mon, 29 Jul 2013 07:54:24 +0000 (07:54 -0000)]
Try to fix error: uninitialized const 'zeroes' is invalid in C++ [-Werror=c++-compat]
svn path=/trunk/; revision=51004
Guy Harris [Mon, 29 Jul 2013 07:34:07 +0000 (07:34 -0000)]
Make a never-changed pile-o-zeroes const.
svn path=/trunk/; revision=51003
Guy Harris [Mon, 29 Jul 2013 07:30:34 +0000 (07:30 -0000)]
Make a never-changed table const.
svn path=/trunk/; revision=51002
Guy Harris [Mon, 29 Jul 2013 07:28:28 +0000 (07:28 -0000)]
Make non-static a variable that doesn't need to be static.
svn path=/trunk/; revision=51001
Guy Harris [Mon, 29 Jul 2013 00:54:33 +0000 (00:54 -0000)]
The base_secs value should be a time_t, as it's calculated using
mktime(). That eliminates the need for casts.
It should *also* be part of a per-wtap-structure private data structure,
not a global variable; make it so.
svn path=/trunk/; revision=51000
Guy Harris [Mon, 29 Jul 2013 00:34:23 +0000 (00:34 -0000)]
Add a URL for a STANAG 4607 spec.
Fix some typoes in comments.
svn path=/trunk/; revision=50999
Guy Harris [Mon, 29 Jul 2013 00:27:20 +0000 (00:27 -0000)]
Clean up white space a bit, make the description of the capture column
type depend on what values are supported, add some comments.
Regularize the curly bracket style a bit.
svn path=/trunk/; revision=50998
Evan Huus [Sun, 28 Jul 2013 23:58:30 +0000 (23:58 -0000)]
Use the portable g_ntohl, also add some casts.
svn path=/trunk/; revision=50997
Evan Huus [Sun, 28 Jul 2013 23:41:18 +0000 (23:41 -0000)]
From Linas Vepstas via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8962
Enhancement: Add STANAG 4607 file format
svn path=/trunk/; revision=50996
Guy Harris [Sun, 28 Jul 2013 22:37:45 +0000 (22:37 -0000)]
Close a memory leak.
svn path=/trunk/; revision=50993
Evan Huus [Sun, 28 Jul 2013 22:02:00 +0000 (22:02 -0000)]
Remove unused variable caught by GCC 4.8.
svn path=/trunk/; revision=50992
Guy Harris [Sun, 28 Jul 2013 21:12:07 +0000 (21:12 -0000)]
If a core Wireshark developer repeatedly can't remember that the
argument to the -F flag for pcap format is "libpcap", not "pcap", we
have a problem. Make it "pcap", and add a backwards-compatibility hack
to support using "libpcap" as well.
Update the man pages to refer to it as pcap as well, and fix the
capitalization of "WinPcap" (see http://www.winpcap.org) while we're at
it.
Also, refer to http://www.tcpdump.org/linktypes.html for the list of
link-layer header types for pcap and pcap-ng.
svn path=/trunk/; revision=50989
Stig Bjørlykke [Sun, 28 Jul 2013 20:59:59 +0000 (20:59 -0000)]
Add support for 64 bit value string in Lua.
Lua cannot store a 64 bit integer with full precision, which is used
for keys in tables, so this is not a 100% solution. But it will probably
be good enough for value strings, and it is better to have some support
than no support.
svn path=/trunk/; revision=50988
Guy Harris [Sun, 28 Jul 2013 20:34:52 +0000 (20:34 -0000)]
Explain what the big loop in update_properties_all() is doing, and
what's done after that.
If we want to set the all-interfaces capture filter string, just set it,
don't add anything to the drop-down list for it.
If, after we've succeeded starting a capture, all active interfaces have
the same capture filter, *do* add that filter to the all-interfaces
recent capture filters list.
Also, free g_strduped capture filter strings when we're done with them.
svn path=/trunk/; revision=50986
Guy Harris [Sun, 28 Jul 2013 20:24:27 +0000 (20:24 -0000)]
Add a comment.
In recent_add_cfilter(), the list we're working on is cfilter_list;
properly remove an item from it - don't assign the result to
recent_cfilter_list, assign it to cfilter_list. This may fix some
crashes and Valgrind errors.
svn path=/trunk/; revision=50984
Evan Huus [Sun, 28 Jul 2013 20:05:04 +0000 (20:05 -0000)]
Much simpler (and possibly faster) fix for the 64-bit value string label issue.
svn path=/trunk/; revision=50983
Evan Huus [Sun, 28 Jul 2013 19:56:23 +0000 (19:56 -0000)]
As caught by Stig: 64-bit value strings could print the field name twice.
Don't do that.
svn path=/trunk/; revision=50982
Anders Broman [Sun, 28 Jul 2013 19:25:14 +0000 (19:25 -0000)]
Update to handle version 9.
svn path=/trunk/; revision=50981
Pascal Quantin [Sun, 28 Jul 2013 16:26:29 +0000 (16:26 -0000)]
From David Richards via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8870 :
Add Windows specific items to .gitignore
svn path=/trunk/; revision=50979
Jörg Mayer [Sun, 28 Jul 2013 15:48:34 +0000 (15:48 -0000)]
Looks like cfilter_combo_utils.c got removed.
svn path=/trunk/; revision=50978
Graham Bloice [Sun, 28 Jul 2013 14:40:56 +0000 (14:40 -0000)]
Added more build artefacts to the clean target
svn path=/trunk/; revision=50977
Pascal Quantin [Sun, 28 Jul 2013 14:35:42 +0000 (14:35 -0000)]
Align info column for UM MCCH/MTCH PDUs
svn path=/trunk/; revision=50976
Gerald Combs [Sun, 28 Jul 2013 14:03:35 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2013-07-28]
svn path=/trunk/; revision=50973
Graham Bloice [Sun, 28 Jul 2013 13:57:12 +0000 (13:57 -0000)]
clean target misses some build artefacts; capinfos.lib and editcap.lib
svn path=/trunk/; revision=50972
Evan Huus [Sun, 28 Jul 2013 12:55:37 +0000 (12:55 -0000)]
Don't force the allocator choice in the data-structure tests, we want to be able
to override that to simple for valgrinding (we still force the allocator in the
allocator and timing tests, of course).
svn path=/trunk/; revision=50971
Evan Huus [Sun, 28 Jul 2013 12:46:44 +0000 (12:46 -0000)]
Fix a bug in the gc routine discovered while formally working out parts of the
algorithm.
Also add a test case to excercise it for future.
svn path=/trunk/; revision=50970
Pascal Quantin [Sun, 28 Jul 2013 12:36:48 +0000 (12:36 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8841 :
Fix PER normally small non-negative whole number dissection when it is greater than or equal to 64
svn path=/trunk/; revision=50969
Pascal Quantin [Sun, 28 Jul 2013 11:32:06 +0000 (11:32 -0000)]
From Michal Labedzki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8948 :
Bluetooth: add missing PSM strings
svn path=/trunk/; revision=50968
Jakub Zawadzki [Sun, 28 Jul 2013 10:47:31 +0000 (10:47 -0000)]
Store protocol fields in single linked list, saves about 1 MB of memory.
svn path=/trunk/; revision=50967
Graham Bloice [Sun, 28 Jul 2013 09:57:52 +0000 (09:57 -0000)]
Improved info column with multiple pdu's in a frame
svn path=/trunk/; revision=50966
Guy Harris [Sun, 28 Jul 2013 09:36:31 +0000 (09:36 -0000)]
Get rid of some unused variables.
Register those hf[] arrays that weren't getting registered.
Reformat all hf[] array initializations.
svn path=/trunk/; revision=50965
Jakub Zawadzki [Sun, 28 Jul 2013 08:41:26 +0000 (08:41 -0000)]
dfilter: move convertion to byte to seperate function
svn path=/trunk/; revision=50964
Michael Mann [Sun, 28 Jul 2013 00:11:30 +0000 (00:11 -0000)]
Fix compile error that resulted from whitespace cleanup.
svn path=/trunk/; revision=50963
Michael Mann [Sun, 28 Jul 2013 00:07:49 +0000 (00:07 -0000)]
Make many items filterable for Vines dissectors.
Add support for FT_VINES type.
svn path=/trunk/; revision=50962
Evan Huus [Sun, 28 Jul 2013 00:00:37 +0000 (00:00 -0000)]
Little optimizations.
Move a few assignments around to avoid one extra subtraction. I suspect having
the two if statements next to each other is friendly to the compiler's optimizer
as well.
Shaves ~1.3% off my timing tests, bringing the new design *very* close to the
old one in raw allocation speed.
svn path=/trunk/; revision=50961
Evan Huus [Sat, 27 Jul 2013 23:35:59 +0000 (23:35 -0000)]
Little things make big differences: somehow while I was experimenting this
unobtrusive if statement got dropped. Without it the allocator exhibits the old
bad behaviour of 3x memory usage and heavy fragmentation.
We want it back, thank you very much.
svn path=/trunk/; revision=50960
Evan Huus [Sat, 27 Jul 2013 23:01:24 +0000 (23:01 -0000)]
Small optimization: conjoin two mutually exclusive ifs with an else.
svn path=/trunk/; revision=50959
Evan Huus [Sat, 27 Jul 2013 22:51:27 +0000 (22:51 -0000)]
Simplify out an addition that happened a lot by performing it once on the
variable it affected, since that variable wasn't used for any other purpose.
svn path=/trunk/; revision=50958
Guy Harris [Sat, 27 Jul 2013 22:37:26 +0000 (22:37 -0000)]
Have separate lists of recent capture filters for all interfaces, in
addition to a "global" list. Store all of those lists in the recent
file. Maintain the lists in ui/recent.c, rather than attaching them to
widgets; have the code that populates the combo boxes get the lists from
the ui/recent.c code.
This makes a little more of the code GUI-toolkit-independent, and should
fix bug 7278.
#BACKPORT 1.10, 1.8
svn path=/trunk/; revision=50956
Evan Huus [Sat, 27 Jul 2013 22:27:28 +0000 (22:27 -0000)]
Redesign of the wmem block allocator.
What was becoming apparent as more dissectors started using wmem was that the
old block allocator design had issues with memory fragmentation. This keeps the
same underlying memory layout, but completely changes how free blocks are kept.
It runs about 3% slower in my tests (still an order of magnitude faster than
g_malloc) but uses about 1/3 the memory.
I suspect some simple optimizations could reclaim that 3% as well - the design
is fast, but I did not code particularly for speed.
Thoroughly tested with the existing test suite (which caught half a dozen bugs
in my first draft) so it should actually work!
svn path=/trunk/; revision=50955
Evan Huus [Sat, 27 Jul 2013 21:56:43 +0000 (21:56 -0000)]
Use a #define, tweak a comment.
svn path=/trunk/; revision=50954
Guy Harris [Sat, 27 Jul 2013 21:23:19 +0000 (21:23 -0000)]
Clean up indentation.
svn path=/trunk/; revision=50953
Jakub Zawadzki [Sat, 27 Jul 2013 20:57:58 +0000 (20:57 -0000)]
make some variables static
svn path=/trunk/; revision=50952
Jakub Zawadzki [Sat, 27 Jul 2013 19:14:34 +0000 (19:14 -0000)]
Support drange for functions
last think from bug #8979
+ fix semcheck.c:875: warning: signed and unsigned type in conditional expression
svn path=/trunk/; revision=50951
Jakub Zawadzki [Sat, 27 Jul 2013 18:55:05 +0000 (18:55 -0000)]
Some more work related to bug #8979 and previous commit
- Make http.location[0:4] == lower(http.location) behave the same as lower(http.location) == http.location[0:4]
- fix compiler errors + comments
svn path=/trunk/; revision=50950
Jakub Zawadzki [Sat, 27 Jul 2013 17:17:15 +0000 (17:17 -0000)]
Fix bug #8979: Comparing function call and a range in the filter crashes Wireshark
store whole node, don't assume it's always STTYPE_FIELD
svn path=/trunk/; revision=50949
Martin Kaiser [Sat, 27 Jul 2013 16:48:06 +0000 (16:48 -0000)]
if we capture on multiple interfaces, the output file will be pcapn-ng
even if we enforce pcap ouput format via -P
in such a case, we *can* write a capture comment to the output file
svn path=/trunk/; revision=50948
Martin Kaiser [Sat, 27 Jul 2013 16:39:10 +0000 (16:39 -0000)]
add --capture-comment to dumpcap's manpage
svn path=/trunk/; revision=50947
Martin Kaiser [Sat, 27 Jul 2013 16:28:03 +0000 (16:28 -0000)]
only one --capture-comment option may be given to dumpcap
svn path=/trunk/; revision=50946
Martin Kaiser [Sat, 27 Jul 2013 16:25:08 +0000 (16:25 -0000)]
command line option --capture-comment for dumpcap
svn path=/trunk/; revision=50945
Martin Kaiser [Sat, 27 Jul 2013 16:16:57 +0000 (16:16 -0000)]
use capture_comment from the capture_options structure
when we write the SHB
svn path=/trunk/; revision=50944
Martin Kaiser [Sat, 27 Jul 2013 16:13:29 +0000 (16:13 -0000)]
add capture_comment to the capture_options structure
svn path=/trunk/; revision=50943
Evan Huus [Sat, 27 Jul 2013 13:50:52 +0000 (13:50 -0000)]
Add the proper license header and attribution to Balint's git-compare-abis script.
svn path=/trunk/; revision=50942
Evan Huus [Fri, 26 Jul 2013 23:51:00 +0000 (23:51 -0000)]
Follow-up to r50935: add support for 64-bit value strings in more places that
need it, I think this is all of them.
svn path=/trunk/; revision=50941
Evan Huus [Fri, 26 Jul 2013 23:16:16 +0000 (23:16 -0000)]
Switch on field length for the length_min/max fields of IPFix. Like several
other nearby fields, they are different lengths in different versions of the
spec.
Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8918
svn path=/trunk/; revision=50940
Evan Huus [Fri, 26 Jul 2013 22:52:34 +0000 (22:52 -0000)]
Squelch MSVC warnings. It doesn't know that DISSECTOR_ASSERT_NOT_REACHED doesn't
return.
svn path=/trunk/; revision=50939
Evan Huus [Fri, 26 Jul 2013 21:51:39 +0000 (21:51 -0000)]
Add 64-bit value strings and the appropriate tooling (including yet another
overloaded use of the DISPLAY field). Thanks to Jakub for pointing out I'd done
this wrong the first time (months ago in r49357).
Fixes severity display for collectd protocol, originally filed at:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8472
svn path=/trunk/; revision=50935
Guy Harris [Fri, 26 Jul 2013 21:49:42 +0000 (21:49 -0000)]
Give more detailed diagnostics for errors.
Actually *check* for errors when reading.
svn path=/trunk/; revision=50934
Guy Harris [Fri, 26 Jul 2013 21:25:33 +0000 (21:25 -0000)]
Send error messages to the standard error, and include the program name
in the error message.
svn path=/trunk/; revision=50928
Guy Harris [Fri, 26 Jul 2013 21:06:38 +0000 (21:06 -0000)]
The descriptive name for a field is the field full name; the name used
in packet-matching expressions and TShark's -e flag and... is the
field's abbreviated name.
svn path=/trunk/; revision=50927
Michael Mann [Fri, 26 Jul 2013 18:30:10 +0000 (18:30 -0000)]
Add support for common FT_ETHER cases.
Bugfix gauging where the "field text" argument when parsing the proto_tree_add_text call.
svn path=/trunk/; revision=50925
Michael Mann [Fri, 26 Jul 2013 18:27:38 +0000 (18:27 -0000)]
Add display filters courtesy of convert_proto_tree_add_text.pl
svn path=/trunk/; revision=50924
Jakub Zawadzki [Fri, 26 Jul 2013 18:10:55 +0000 (18:10 -0000)]
Fix bug #8980 - IO graph/advanced, max/min/summ error on frames with multiple Diameter messages
tap_iostat_packet() was fetching only first item for FT_RELATIVE_TIME.
svn path=/trunk/; revision=50923
Pascal Quantin [Fri, 26 Jul 2013 17:07:57 +0000 (17:07 -0000)]
Fix Frame Indicator analysis logic
svn path=/trunk/; revision=50920
Evan Huus [Fri, 26 Jul 2013 16:42:06 +0000 (16:42 -0000)]
whitespace
svn path=/trunk/; revision=50919
Alexis La Goutte [Fri, 26 Jul 2013 16:26:29 +0000 (16:26 -0000)]
Enhance BGP Update (Path Attribute)
Step 2 ! Make Path Attribute field filterable...
svn path=/trunk/; revision=50918
Alexis La Goutte [Fri, 26 Jul 2013 16:26:21 +0000 (16:26 -0000)]
Enhance BGP Update
First step ! Remove ugly double switch(bgpa_type)... (use proto_item_append_text)
svn path=/trunk/; revision=50917
Alexis La Goutte [Fri, 26 Jul 2013 16:26:04 +0000 (16:26 -0000)]
From Thomas ERSFELD (GSoC13)
Automatic resize the content of UAT window dialog
svn path=/trunk/; revision=50916
Bill Meier [Fri, 26 Jul 2013 16:19:00 +0000 (16:19 -0000)]
gtk_widget_modify_font() has been renamed to gtk_widget_override_font() in GTK3
svn path=/trunk/; revision=50915
Anders Broman [Fri, 26 Jul 2013 15:58:17 +0000 (15:58 -0000)]
Add dissection of more IEs
svn path=/trunk/; revision=50912
Evan Huus [Fri, 26 Jul 2013 13:06:50 +0000 (13:06 -0000)]
Document that pinfo-scoped memory is also needed for anything passed to
add_new_data_source().
svn path=/trunk/; revision=50911
Pascal Quantin [Fri, 26 Jul 2013 10:39:23 +0000 (10:39 -0000)]
Align info column for AM/UM/TM PDUs
svn path=/trunk/; revision=50910
Pascal Quantin [Fri, 26 Jul 2013 10:21:05 +0000 (10:21 -0000)]
Add Channel ID to MTCH PDUs
svn path=/trunk/; revision=50909
Alexis La Goutte [Fri, 26 Jul 2013 08:51:59 +0000 (08:51 -0000)]
From Jouni Malinen via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8972 ieee80211: Dissect QoS Mapping information
This patch adds support for dissecting QoS Map Configure frame and QoS Map Set element per Interworking functionality that was added in IEEE 802.11u
svn path=/trunk/; revision=50908
Alexis La Goutte [Fri, 26 Jul 2013 07:02:12 +0000 (07:02 -0000)]
Oups... Revert my change (See revision 50905)
svn path=/trunk/; revision=50907
Alexis La Goutte [Fri, 26 Jul 2013 06:54:11 +0000 (06:54 -0000)]
Fix compilation of qtshark
ui/qt/uat_dialog.cpp: In member function ‘void UatDialog::stringPrefTextChanged(const QString&)’:
ui/qt/uat_dialog.cpp:371:10: error: variable ‘enable_ok’ set but not used [-Werror=unused-but-set-variable]
And remove a tabs
svn path=/trunk/; revision=50906
Guy Harris [Fri, 26 Jul 2013 06:51:59 +0000 (06:51 -0000)]
Guess what the intent of the enable_ok Boolean was.
svn path=/trunk/; revision=50905
Gerald Combs [Fri, 26 Jul 2013 01:48:05 +0000 (01:48 -0000)]
Call on_uatTreeWidget_itemActivated directly. Fixes compilation on
older versions of Qt.
svn path=/trunk/; revision=50904
Jeff Morriss [Fri, 26 Jul 2013 01:45:48 +0000 (01:45 -0000)]
From Cal Turney and Jiří Engelthaler via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8908 :
The fix for bug 5585 (r35583) is no longer necessary (thanks to r50516) and it
causes the screen to flicker when clicking on bytes in the bytes pane.
svn path=/trunk/; revision=50903
Jeff Morriss [Fri, 26 Jul 2013 01:35:44 +0000 (01:35 -0000)]
From Роман Донченко via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8977 :
In SSH, the protocol version message is terminated by CR LF. Wireshark, in the
info column, strips out the LF, but not the CR.
Attaching a patch to rectify that.
Also, as requested, update the contributor's email address in AUTHORS.
svn path=/trunk/; revision=50902
Jeff Morriss [Fri, 26 Jul 2013 01:18:34 +0000 (01:18 -0000)]
From Dirk via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8952 :
Microsoft describes a feature called Bind Time Feature Negotiation used in
DCE/RPC Bind/BindAck PDUs. See http://msdn.microsoft.com/en-us/library/
cc243715.aspx
In the Bind PDU they encode 2 bits into the Transfer Syntax UUID. In the
BindAck PDU they encode 2 bits into the result code. The attached patch
dissects these two special bits. For the UUID I've simply added 4 UUIDs each
with the same name; this works best with the DCE/RPC UUID lookup code. If
Microsoft would ever introduce more bits we could change this to a better
handling, since the current solution obviously doesn't scale.
Apart from adding new hf_ and ett_ variables and using them, I've also renamed
"Transport Syntax" to "Transfer Syntax", since the specifications only use
"Transfer".
svn path=/trunk/; revision=50901
Jeff Morriss [Fri, 26 Jul 2013 01:09:41 +0000 (01:09 -0000)]
From Javier Godoy via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8951 :
Currently, the only attribute that is dissected is attribute 82 in page 1.
The approach for dissecting an attribute requires defining a function that
processes the attribute-specific fields. However, most attributes consists of
a single field, and the only difference between attributes is because of their
length and format (that is already defined for the header field). The current
code also assumes that the attribute length is always correct (e.g. the
attribute has 8 bytes if the field is registered as FT_UINT64).
As a proof of concept, this patch adds support for 3 attributes in the Current
Command attributes page (see OSD2r4 section 7.1.3.31) and prepares a framework
for dissecting additional attributes (dissection of additional attributes will
be delivered in a separate patch).
From me:
Move the new length checking up to the caller rather than repeating it in
every attribute dissector.
Use proto_tree_add_expert_format() instead of proto_tree_add_text() plus
expert_add_info().
Fix checkfiltername.pl error:
scsi_osd.scsi_osd_attribute_length.invalid duplicates PROTOABBREV of scsi_osd
Remove trailing white space and fix up some indentation.
svn path=/trunk/; revision=50900
Jeff Morriss [Fri, 26 Jul 2013 00:24:54 +0000 (00:24 -0000)]
From Chen Li via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8949 :
Fix the dissection of the port number in announce_peers request in BTDHT.
svn path=/trunk/; revision=50899
Evan Huus [Fri, 26 Jul 2013 00:23:09 +0000 (00:23 -0000)]
Add missing ui_uat_dialog.h dependency.
The fact that we're listing these manually is kind of ugly...
svn path=/trunk/; revision=50898
Evan Huus [Thu, 25 Jul 2013 23:58:49 +0000 (23:58 -0000)]
Use the pinfo pool for adding data sources in the h245 dissector. The packet
pool is freed before the packet is displayed or otherwise processed, so adding
data sources from it leads to use-after-free errors.
Not sure why this wasn't showing up in the fuzz-bot valgrind step, there
are lots of h245 captures in the menagerie...
svn path=/trunk/; revision=50897
Gerald Combs [Thu, 25 Jul 2013 23:49:47 +0000 (23:49 -0000)]
Add a UAT dialog. Make UAT preferences uat_t * instead of void *.
C++-ize the UAT headers.
Add an ElidedLabel widget. Use it in the File Set, Profile, and UAT
dialogs.
Update the Qt README.
svn path=/trunk/; revision=50896
Evan Huus [Thu, 25 Jul 2013 23:28:38 +0000 (23:28 -0000)]
Multiple improvements and bug-fixes for the fuzz-test script:
- fix a few pieces of bad indentation
- exit cleanly in all cases where we receive a SIGINT or other signal
- check for valgrind bugs and dissector errors with every set of arguments (-nr
vs -nVxr etc) not just the last
- consider it an error if valgrind reports more than 500KB of leaked memory
For the last point, 500KB is hopefully a safe choice for now since we only leak
about 2KB "by default" and I have no idea what the state of most "non-default"
code is with respect to memory leaks. I would like to eventually work this
down to 0 of course :)
svn path=/trunk/; revision=50895
Evan Huus [Thu, 25 Jul 2013 22:45:02 +0000 (22:45 -0000)]
Fix a bug in the Kafka dissector handling PRODUCE requests with a RequiredAcks
field of 0 - we don't expect a response to them.
svn path=/trunk/; revision=50894
Michael Mann [Thu, 25 Jul 2013 19:11:31 +0000 (19:11 -0000)]
Add a few filters to keep checkAPIs.pl happy.
svn path=/trunk/; revision=50893
Jeff Morriss [Thu, 25 Jul 2013 18:37:18 +0000 (18:37 -0000)]
As pointed out in https://wireshark.org/lists/wireshark-dev/201307/msg00153.html :
The fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3290 needs
to allow for giving a length of -1 for FT_STRINGZ's.
This is another fix for https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8960
(in addition to r50836). There's no point in reverting that revision, though,
since there was no need to use a length of -1 in that case.
svn path=/trunk/; revision=50892
Pascal Quantin [Thu, 25 Jul 2013 17:33:57 +0000 (17:33 -0000)]
Add a smarter UM analysis for MCCH/MTCH channels
svn path=/trunk/; revision=50891
Jakub Zawadzki [Thu, 25 Jul 2013 17:19:17 +0000 (17:19 -0000)]
Optimize proto_item_append_string()
- When old string empty just pass new one (like: frame.protocols)
- if not, use ep_strconcat()
svn path=/trunk/; revision=50890
Jeff Morriss [Thu, 25 Jul 2013 15:40:39 +0000 (15:40 -0000)]
Make it easier to add custom (proprietary) Diameter XML files.
svn path=/trunk/; revision=50889
Guy Harris [Thu, 25 Jul 2013 10:05:41 +0000 (10:05 -0000)]
Fix some warnings that show up on OS X.
Clean up indentation (use 4-space indentation, and no tabs).
svn path=/trunk/; revision=50888
Guy Harris [Thu, 25 Jul 2013 09:53:28 +0000 (09:53 -0000)]
Fix some more bugs that caused compiler warnings.
svn path=/trunk/; revision=50887
Guy Harris [Thu, 25 Jul 2013 09:03:02 +0000 (09:03 -0000)]
Get rid of an unused variable (set, but not used).
Get rid of extra arguments to expert_add_info_format_text() - as with
any other printf-like routine, if the format string has no % items, you
don't need to pass any additional arguments after that - you don't have
to tack on a BASE_NONE just for the lulz.
svn path=/trunk/; revision=50886
Anders Broman [Thu, 25 Jul 2013 04:40:37 +0000 (04:40 -0000)]
Commiting Jakub Zawadzkis memory_dlg even if he does not think it's ready yet so others can add to it if they like. Fixed it to work on Windows too. It can always be removed if nothing comes of it.
svn path=/trunk/; revision=50885