Bluetooth: A2DP: Add AVRCP song position indicator

"sbc.avrcp_song_position" can be used to determine time synchronization
between AVRCP and A2DP. It is updated on every
AVRCP PlaybackPositionChanged. Also provide version for aptx.

Change-Id: I48cd49f0fee54131a738290e2a70a24d33ba1d22
Reviewed-on: https://code.wireshark.org/review/5290
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>

Qt: Fix non-translate-able text

Change-Id: I8c2376117ca1ac92c341ba938929af2d13e23f72
Reviewed-on: https://code.wireshark.org/review/5291
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>

Qt: Fix typo

Change-Id: Idc2b945ac3bd5de961cc9c581398dc12f6831070
Reviewed-on: https://code.wireshark.org/review/5292
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>

Bluetooth: AVRCP: Improve command/response trancing

Make command/response tracking field filterable and jumpable.

Change-Id: Ib0dfc9ea9954f8d29d06ceda3d44a7f95c94bc53
Reviewed-on: https://code.wireshark.org/review/5288
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>

Bluetooth: AVRCP: Fix swappend SongPosition and SongLength

SongPosition and SongLength are swapped in Info column. Fix it.

Change-Id: I4c9bece51dbfe62885e8426a8aef07f336670099
Reviewed-on: https://code.wireshark.org/review/5287
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>

Bluetooth: AVDTP: Add possibility to force decode as APT-X

Change-Id: Id99647846c9bc7666f33938c811358576353390d
Reviewed-on: https://code.wireshark.org/review/5286
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>

dtd_preparse : fix indent (Use tabs)

Change-Id: Iec6ef7109ccea8a164db4f62af9fae1dceba6ae6
Reviewed-on: https://code.wireshark.org/review/5282
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Gtk Utils: fix unknown command tag name 'parm'; did you mean 'param'? (-Wdocumentation)

Change-Id: I89f242bf916d22e0a4a665696ec3fe5ee02b8a1f
Reviewed-on: https://code.wireshark.org/review/5283
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Multipath TCP checksum requires M flag set as well as enough option length.

Bug: 10692
Change-Id: I8d9874a2c0a6b98497d43804bcf27a8c7e152a9b
Reviewed-on: https://code.wireshark.org/review/5275
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Always create a subtree for Mobility options, even if it doesn't have a specific dissection function.

Bug: 10618
Change-Id: Ic4d52485a6bd96f906b4a0d61b75a31bfad4e8f8
Reviewed-on: https://code.wireshark.org/review/5276
Reviewed-by: Michael Mann <mmann78@netscape.net>

Dissector for elasticsearch protocol

Provides dissection for the elasticsearch protocol. This includes full
dissection of the multicast discovery protocol, the HTTP query interface
and partial dissection of the binary protocol.

Change-Id: I738fb498976e44fa05168c2bc3a7e842a9e96df9
Reviewed-on: https://code.wireshark.org/review/4948
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

batadv: Add dissector support for batadv v15

The packet format for batman-adv v15 supports:

 * Complete reordered packet type ids
 * reordered flags
 * type-version-length-value data containers
 * new types for coding packets and unicast transfer of TVLVs
 * dropped packet types for vis, translation table query and roaming
 * reordered packet formats
 * transparent fragmentation of batadv packets

Change-Id: I9e6733f9dd6b54eeecda19cf570599161d28b46e
Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
Reviewed-on: https://code.wireshark.org/review/5175
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

epl: Duplicated Frames

  Remake of the duplicated frames filter with
  less memory usage.

Change-Id: I7c8694b5ae69c919b866bbc661bad5e3f0a3e1d7
Reviewed-on: https://code.wireshark.org/review/4773
Reviewed-by: Roland Knall <rknall@gmail.com>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

hf_cc_loss is supposed to be a floating-point value, divided by 65535.

That's what the code did when it used proto_tree_add_text(); make it do
so now.  That squelches a run-time error.

Reformat the script-added hf_ values while we're at it.

Change-Id: I48d16280c523faa3b266e8df37f5e0e0b2827712
Reviewed-on: https://code.wireshark.org/review/5270
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Get rid of spaces before tabs.

Change-Id: I70ff250a905ac578d7e3afc63a82a5fcb3983608
Reviewed-on: https://code.wireshark.org/review/5269
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Add dissector table for sFlow header dissection.

Change-Id: I189a5b2d5f769395fa5e387f8be49b81903fb252
Reviewed-on: https://code.wireshark.org/review/5262
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Handle duplicate attribute and TLV entries specially.

For attributes, handle them the same way we handle duplicate vendors.

For TLVs, ignore duplicates; they shouldn't happen.

Change-Id: Ie968478c40a9b7848fa8ea25b144eda8656e5874
Reviewed-on: https://code.wireshark.org/review/5268
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Eliminate proto_tree_add_text for some dissectors.

Change-Id: Ide14bcac0b1563bee4260ac9c1a280ba99e97e71
Reviewed-on: https://code.wireshark.org/review/5261
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Handle new vendors and changes to vendors differently.

If, when adding a new vendor, we already find a vendor with the given
ID, don't bother adding it to the vendors-by-ID table with the same ID,
and, if and only if the vendor name has changed, remove it from the
vendors-by-name table, free the old name, replace it with the new name,
and, add it back to the vendors-by-name table with the new name.

Bug: 10666
Change-Id: I43ebcb57c742563157c71b01ebc0b35797a408e1
Reviewed-on: https://code.wireshark.org/review/5265
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Squelch a compiler warning.

Some compilers complain that we're casting a 16-bit integer to a
pointer; making it a standard-size integer squelches the warning.

Change-Id: Iba0e767d7801afdc369b64a1cf050bf8db37da7b
Reviewed-on: https://code.wireshark.org/review/5264
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Qt: Flatten group boxes.

As discussed in change 5185, the "big 3" HIGs discourage the use of
traditional group boxes. Flatten our existing ones.

Change-Id: I68ef4aa9fd0f69a42750bf735df2250a468bfb2d
Reviewed-on: https://code.wireshark.org/review/5263
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Add Decode As functionality for MPLS PW Associated Channel Type.

Add CFM and MPLS dissector as possible decoders.

Bug: 10574
Change-Id: Ic39c6b8d68b965ff9d342f5ee789a8eff3134a5a
Reviewed-on: https://code.wireshark.org/review/4935
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Fix warning: no previous prototype for function ... [-Wmissing-prototypes]

warning coming after g055e4768ece and g421913b721

Change-Id: I5caeeb89c559faef8007f2946c68c7172b75dfa8
Reviewed-on: https://code.wireshark.org/review/5250
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

[Art-Net]
- The heuristic chek was missing "e" out of "Art-Net\0"
- tvb_length() - tvb_captured_length()

Change-Id: Iad9900f3a22e2fdbd0d6056efc1af90511cc458a
Reviewed-on: https://code.wireshark.org/review/5257
Reviewed-by: Anders Broman <a.broman58@gmail.com>

ADB: fix  warning: no newline at end of file [-Wnewline-eof]

Warning found by Clang

Change-Id: I7b801808aefa294e32fff560ea1a49620f0e0ea0
Reviewed-on: https://code.wireshark.org/review/5249
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Updates in it translation.

Change-Id: I9e90fca521f17f4ae49e132990f77b2610807e6d
Reviewed-on: https://code.wireshark.org/review/5248
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I1540c7878692625a9e38b48f8681c07bab852a64
Reviewed-on: https://code.wireshark.org/review/5234
Reviewed-by: Michael Mann <mmann78@netscape.net>

Fix SMPP timestamp decoding when the current date/time's offset to UTC is
different from the timestamp's offset to UTC.

The fix for bug 6712 ignored the fact that daylight savings will affect the
offset from UTC--and whether daylight savings is in effect today might be
different than whether it was in effect in the timestamp we're decoding.

Bug: 10672
Change-Id: Ie513c361cff41007f2328cd9ca9ca4800ffef500
Reviewed-on: https://code.wireshark.org/review/5245
Petri-Dish: Michael Mann <mmann78@netscape.net>
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up
on the OSX 10.5 buildbot.

Change-Id: I49e066feab8b980ea85371095234e96e89db71e1
Reviewed-on: https://code.wireshark.org/review/5247
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>

Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up with gcc 4.8.3.

Change-Id: I71c9013670dd6e8c74e039bd252cfac2c9e95a18
Reviewed-on: https://code.wireshark.org/review/5246
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>

[GTP] Fix decoding of UMTS GTP QoS Profile i n Radius and Diameter
messages.
Fixes Bug 10688

Change-Id: Iff29ae3f6cee1b4ad12a0e5c5d7fd3da1c9343af
Reviewed-on: https://code.wireshark.org/review/5244
Reviewed-by: Anders Broman <a.broman58@gmail.com>

[Radius] Make dictionary.starent.vsa1 the default dictionary.
at least with the trace in Bug 10688 that makes the most sense.

Change-Id: I76213449076a2f49a4b72c6dd87b022fb10b9eef
Reviewed-on: https://code.wireshark.org/review/5242
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Tools: Add fix_pragma_wdocumentation to UNKNOWN licence

Change-Id: Ib5665924b99644c52c95d408c7cff19509cf3eb2
Reviewed-on: https://code.wireshark.org/review/5241
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

hiqnet: Use correct filter names; Fix specification of hf_dhcp

   "foo.flags..." --> "hiqnet.flags...";
   Use BASE_NONE for hf_dchp.

Change-Id: Ic3ca4754a1daeefc831dbfcd6a280fe19f8efbf3
Reviewed-on: https://code.wireshark.org/review/5240
Reviewed-by: Bill Meier <wmeier@newsguy.com>

Add tools for fix -Wdocumentation

Use pragma to disable -Wdocumentation when include glib.h, gmodule or gtk/gtk.h

Change-Id: I576c0d5c4a12ac3b505ac9543646356ff29ac814
Reviewed-on: https://code.wireshark.org/review/5198
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Hiqnet: fix warning found by fix-encoding-args tools

Change-Id: I7e513ec5b617217cd238861f5f02d44edce0bedd
Reviewed-on: https://code.wireshark.org/review/5239
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Hiqnet: fix Mac OS X buildbot

Change-Id: Ia4fec86ed389ccb558fe9e1acfb6e87b7012bb75
warning: declaration of 'strlen' shadows a global declaration
Reviewed-on: https://code.wireshark.org/review/5237
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Hiqnet: fix typo lenght => length

Change-Id: I104d8bb0c56899faef6f4d608859e7b1a34e45a4
Reviewed-on: https://code.wireshark.org/review/5238
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Initial Harman HiQnet dissector

Change-Id: I43042edde09395e328d84bf4b172465829915a98
Reviewed-on: https://code.wireshark.org/review/5014
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Status_Flags

Implementation for this event parameter type was missing

Bug: 9626
Change-Id: Iea0bc819858bbf5660d97cfd0c418a963ac149fb
Reviewed-on: https://code.wireshark.org/review/5228
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Fix a problem that causes build failures with CMake on Yosemite.

Change-Id: I52e81656470df887eb3c53b2632bf5a310b1b063
Reviewed-on: https://code.wireshark.org/review/5229
Reviewed-by: Guy Harris <guy@alum.mit.edu>

Allow building under OSX Yosemite using cmake.

CFPropertyListCreateFromStream() has been deprecated in Yosemite, in favor of CFPropertyListCreateWithStream(). The autotools
build checks for the existence of the new function, but the cmake build does not. So, add a check for it to CMakeLists.txt, and
update cmakeconfig.h.in to provide the "template" for HAVE_CFPROPERTYLISTCREATEWITHSTREAM.

Change-Id: I1a4e3e1ce83092ecf7725527b921eeca80b18d4b
Note: CFPropertyListCreateWithStream() works under Mavericks as well.
Reviewed-on: https://code.wireshark.org/review/5226
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Stig Bjørlykke <stig@bjorlykke.org>

amqp: Misc changes;

- amqp_1_0_dissectiom: Use MIN(32-bit-length, 0xFFFF) as the length to dissect;
  The original code just used the low-order 16 bits of the 32-bit length
  field  as the length to dissect.
  Add an expert warning if the actual PDU length is > 65K.

- tvb_length() --> tvb_reported_length()

Change-Id: I3230600f460a8bd495eeec17fa6e704bf24de1a2
Reviewed-on: https://code.wireshark.org/review/5225
Reviewed-by: Bill Meier <wmeier@newsguy.com>

USB: consider the device class when we try to select the next dissector

at the moment, we only use the interface class, even in situations where
it's not applicable (e.g. control request that's not addressed to an
interface or an endpoint) - this is a hack that works because some
dissectors register for interface class "unknown", I'm trying to make
this workaround obsolete

Change-Id: I6bf4253a2f8bf5a75ea1a08c3e52d36f80abd7ab
Reviewed-on: https://code.wireshark.org/review/5215
Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Sean Stalley <seanstalley@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Use correct offset and lenght for Choice EOC.

Change-Id: I8152e1a07768a3bc245bbafa7c24901ba26a2478
Reviewed-on: https://code.wireshark.org/review/5224
Reviewed-by: Anders Broman <a.broman58@gmail.com>

WCCP: fix parsing of extended assignment data element

Bug: 10641
Change-Id: I51322757c5aa7877fa8ff7915330ff24e7a8cbe2
Reviewed-on: https://code.wireshark.org/review/5221
Reviewed-by: Michael Mann <mmann78@netscape.net>

Improved deregistering fields.

This improvement avoids use of deallocated memory (crash) if using a
deregistered field in display filter, color filter, custom column and
other cases when the field is used as "interesting field".

This functionality is currently used in http, imf and ldap preferences.

Also removed unused proto_registrar_n() as this does not work correctly
after deregistering fields.

Change-Id: I043e3bf7a98bd773c9801e712a012d1eab8a7f94
Reviewed-on: https://code.wireshark.org/review/5161
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Stig Bjørlykke <stig@bjorlykke.org>

Fixed memory leakage in col_cleanup.

Several fields in cinfo is allocated memory and must be freed here
to avoid memory leakage when recreating the packet list.

Do not allocate memory for col_expr[] as this points to static strings
or other allocated strings.

Change-Id: I840377e3c590b1a3e2a38e0537465a028041d1e9
Reviewed-on: https://code.wireshark.org/review/5137
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Try to fix dist.

Change-Id: Ib4332bace88f9db7a06867861c40627e2bdc55f0
Reviewed-on: https://code.wireshark.org/review/5218
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Fix an include.

Change-Id: Ic46b24cac01c49be01c7ad9e8a12b276fcdf81a5
Reviewed-on: https://code.wireshark.org/review/5217
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Finish converting the User's Guide to AsciiDoc.

As with the Developer's Guide, add user-guide-docinfo.xml, which lets us
carry over DocBook front matter. Remove the meta_info chapter. Most of
its contents are now in user-guide-docinfo.xml. Add a DocBook revision
history based on hints from the Git/SVN/CVS revision history.

Remove the various makefile targets for converting AsciiDoc files to
DocBook chapters. Remove GPL_appendix.xml. We use the AsciiDoc version.

Change-Id: I543fa2a92f2c735c5f00c97ec65cff2187e09e3a
Reviewed-on: https://code.wireshark.org/review/5216
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Add subdissector table for MPLS PW Associated Channel Type

Change-Id: Id72fcbe74b91b4eb25fb4d3f3d47a1d53c2857b2
Reviewed-on: https://code.wireshark.org/review/5212
Reviewed-by: Michael Mann <mmann78@netscape.net>

WSUG: Convert ``Command Line Tools'' to AsciiDoc.

Move the idl2wrs section to the Developer's Guide. Leave most of the
other content intact for now.

Change-Id: I98c6eeab62af5cc55e3ce23ab1107df02b1a22cf
Reviewed-on: https://code.wireshark.org/review/5214
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Restore a "ti" assignment that slightly altered dissection.

Change-Id: I94cd7893a2e6b3668499d41519649f6a7782aa60
Reviewed-on: https://code.wireshark.org/review/5213
Reviewed-by: Michael Mann <mmann78@netscape.net>

WSUG: Convert ``Troubleshooting'' to AsciiDoc.

The chapter is disabled so its final output hasn't been checked. Leave
most of the content intact for now.

Change-Id: I2147ee2863e7ededadf892794a836b4dc8055649
Reviewed-on: https://code.wireshark.org/review/5211
Reviewed-by: Gerald Combs <gerald@wireshark.org>

WSUG: Convert ``Protocols'',  ``Messages'', and ``How Wireshark Works''
to AsciiDoc.

``How Wireshark Works'' is disabled, so its final output hasn't been
checked.

Leave most of the content intact for now.

Change-Id: Ia78951faa3ffd9c6d2e23067dbfb954ab4042f60
Reviewed-on: https://code.wireshark.org/review/5210
Reviewed-by: Gerald Combs <gerald@wireshark.org>

WSUG: Convert ``Files'' to AsciiDoc.

Leave most of the content intact for now.

Change-Id: I78f47b8310cb41ac5a07d352e56ec907b36665f8
Reviewed-on: https://code.wireshark.org/review/5209
Reviewed-by: Gerald Combs <gerald@wireshark.org>

[Automatic manuf, services and enterprise-numbers update for 2014-11-09]

Change-Id: Icfdef00a4b9b303bde89bf57077817f25e47d190
Reviewed-on: https://code.wireshark.org/review/5206
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Create a subdissector table for juniper payload protocols.

Change-Id: I60fd9c6c486b9b3b90e32fb9ccce3973569cc2ee
Reviewed-on: https://code.wireshark.org/review/5204
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>

Try to fix wsluarm dependency.

Change-Id: I90f6a400bb5078c7719c3088d87c4632b810346b
Reviewed-on: https://code.wireshark.org/review/5205
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Convert the Lua reference to AsciiDoc.

Move it to the Developer's Guide while we're here.

Nudge the markup in epan/wslua where needed. Note that we should
probably convert it to AsciiDoc (if we're going to keep it in the DG) or
Doxygen.

Change-Id: Ie175111043f98b7a37eeeb8d185a833d8e866f8b
Reviewed-on: https://code.wireshark.org/review/5203
Reviewed-by: Gerald Combs <gerald@wireshark.org>

Fix error: parameter 'XX' not found in the function declaration (-Wdocumentation)

Change-Id: I5850b813989bd6ed33263c0fae3aa29e977e82ec
Reviewed-on: https://code.wireshark.org/review/5195
Reviewed-by: Evan Huus <eapache@gmail.com>

SNMP: Fix warning found by -Wunused-const-variable

Change-Id: If3fcab128e3e6bce04f4922568ab7ff8575b01fe
warning: unused variable 'smux_types' [-Wunused-const-variable]
Reviewed-on: https://code.wireshark.org/review/5194
Reviewed-by: Evan Huus <eapache@gmail.com>

PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

Change-Id: I4bfc67705ee824e68f14e4177a3194d66bbbe165
Reviewed-on: https://code.wireshark.org/review/5188
Reviewed-by: Evan Huus <eapache@gmail.com>

BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Characterstring

Implementation for this event parameter type was missing

Bug: 9625
Change-Id: I575d387ec4764fa1ecd365624d13e3f41e2473c6
Reviewed-on: https://code.wireshark.org/review/5189
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>

simplify the while-loop in dissect_pmip6_opt_cr()

Bug: 10676
Change-Id: I5614c640d3fd23196984eb2bb013ba15fb318305
Reviewed-on: https://code.wireshark.org/review/5200
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

simple fix for bug 10676

Bug: 10676
Change-Id: I442aa2ce44309655190752e715279d7325647336
Reviewed-on: https://code.wireshark.org/review/5199
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

Create real subdissectors to the IGMP protocol.

Change-Id: I79ee9413b87722bfe4782342737cff03cfc34495
Reviewed-on: https://code.wireshark.org/review/5179
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

fix a copy&paste mistake: type -> length

Change-Id: Ifafdc150c655caf4c7046e3038a6b5e4eeb3cf80
Reviewed-on: https://code.wireshark.org/review/5193
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

fix a crash in the endpoint dialogue

compile Wireshark with GeoIP enabled
load a USB capture
open Statistics / Endpoints
   the tree is empty, USB is not amongst the selected Enpoint Types
select USB in the Endpoint Types list
-> crash

to fix this, add a NULL check for cur_tree to EndpointDialog::tabChanged()

Change-Id: I43d963ae5cd451120ac354e89e37ccbbbc2c5910
Reviewed-on: https://code.wireshark.org/review/5192
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

remove parent parameter from dissect_usb_setup_response()

Change-Id: Ib4a5cc3b783d3a4a1477624678964a9627d582e6
Reviewed-on: https://code.wireshark.org/review/5191
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

remove parent parameter from dissect_usb_setup_request()

Change-Id: I5a24de9a12e301d472e701140299304e2cb4fcfc
Reviewed-on: https://code.wireshark.org/review/5190
Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
Tested-by: Martin Kaiser <wireshark@kaiser.cx>

Add checkfiltername.pl to pre-commit script

Change-Id: I34d8aa7034a4aacc2a95b35a30f25356b33a51b9
Reviewed-on: https://code.wireshark.org/review/5187
Reviewed-by: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

batadv: Add missing padding to batadv_unicast_4addr_v14

The already frozen packet format of batman-adv for Linux 3.5 was rejected by
David S. Miller. The 4addr format v14 was therefore changed after the freeze
and published in his final form in Linux 3.8.

Change-Id: I519476c4c6d62b403e197fae6a853d9bbe61f9bc
Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
Reviewed-on: https://code.wireshark.org/review/5174
Reviewed-by: Michael Mann <mmann78@netscape.net>

Don't forward-declare amqp_0_10_get_size_field(), as it no longer exists.

Change-Id: I796826bafd0768b610c9afbde8407fd9d3cc775e
Reviewed-on: https://code.wireshark.org/review/5180
Reviewed-by: Guy Harris <guy@alum.mit.edu>

amqp: handle potential overflows when dissecting amqp_0_10 PDUs;

Bug: 10582
Change-Id: I2fbb16b9d641dfe872aed468f8b944f7ef274261
Reviewed-on: https://code.wireshark.org/review/5176
Reviewed-by: Bill Meier <wmeier@newsguy.com>

dictionary: add missing TLV definition for WiMAX-Downlink-Granted-QoS

The type of the value of the Downlink-Granted-QoS is defined as tlv, but the
TLV definition has not given in the file.

This changeset adds the definition as per WiMAX Forum specification.
As per the spec, the TLV definition is same as the QoS-Descriptor TLV.

<Reference>

Section 5.4.2.29 QoS-Descriptor and 5.4.2.63 Downlink Granted-QoS in
WMF-T33-001-R010v05.

Change-Id: I72d97ed6f7532239cba62cc4cd1b6693fcd43123

dictionary: change type of WiMAX-Uplink-Granted-QoS VSA

This changeset changes the type of WiMAX-Uplink-Granted VSA to tlv and
provides the TLV definition as per WiMAX Forum Specification.

The TLV definition is same as the QoS-Descriptor VSA.

<Reference>

Section 5.4.2.30 Uplink Granted-QoS and 5.4.2.29 QoS-Descriptor in
WMF-T33-001-R010v05.

Change-Id: If6b505bc985c0fb41b19cf2d2fc7b4f887c72b7a
Reviewed-on: https://code.wireshark.org/review/5158
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

DNS: WKS RR Protocol field is read as 4 bytes instead of 1

In the attached pcap file, there's a single DNS packet with WKS RR in the Prerequisites section.
The Protocol field of this RR is read as if it is 4 bytes long instead of 1, which actually reads part of the bytes of the following RR.

Found by boaz

Bug:10675
Change-Id: Icf12c7f3864b629a242598373c06eee4de0ca098
Reviewed-on: https://code.wireshark.org/review/5170
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

DNS: fix name length and label count for a root server

Bug: 10674
Change-Id: I44297bfa64c31ab53d2aa61b6e54253b7a5a1e27
Reviewed-on: https://code.wireshark.org/review/5167
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Fixed hf field blurb values after changes from change 5166

Change-Id: I1c32fb3629c714d72b5398ad82d219d8786980a1
Reviewed-on: https://code.wireshark.org/review/5171
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

GTPv2: Update Indication with Octet 8 and 9 dissection.

Change-Id: Ifa18f31a98932236b102db0f4f28169a7eb72978
Reviewed-on: https://code.wireshark.org/review/5169
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Fix all remaining filter name errors found with checkfiltername.pl

This should make it possible to add checkfiltername.pl to the pre-commit script.

Change-Id: Icdee7e4ea3381fa1467bb4b5caf0f60c255adec0
Reviewed-on: https://code.wireshark.org/review/5166
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>

epl: Reassembly table fix

 Fixed an error that retransmitted frames were added to the
 reassembly table.

Change-Id: I314412cb8f2ce49142e4b7f001613948f5e03bf6
Reviewed-on: https://code.wireshark.org/review/4916
Reviewed-by: Roland Knall <rknall@gmail.com>
Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

Call the default language preference setting "Use system setting".

That more correctly describes it - it doesn't do any form of automatic
detection of anything, it just picks up the system settings from
wherever Qt picks them up.

Change-Id: I62d40719728cc9735e3b8f3e4202b7e61fc3f43b
Reviewed-on: https://code.wireshark.org/review/5165
Reviewed-by: Guy Harris <guy@alum.mit.edu>

nfs: parse full setclientid CLID_INUSE reply

Note there can be some extra data in the CLID_INUSE case.

(Future work: dissect_nfs_clientaddr4 could use some improvement.)

Ping-Bug: 10649
Change-Id: I92f34c6cc7a9328458f1e4391b04009f5e47290b
Reviewed-on: https://code.wireshark.org/review/5141
Reviewed-by: Bruce Fields <jbrucefields@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>

mrcpv2: Fixed a memory leakage.

Moved mrcpv2_tcp_range to proto_reg_handoff and removed the unused
range_empty() init.

Change-Id: I0bb704db62299c9b3f54e2924162738bf7290ab6
Reviewed-on: https://code.wireshark.org/review/5156
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

rtsp: Fixed a memory leakage.

Moved rtsp_tcp_port_range to proto_reg_handoff and removed the unused
range_empty() init.

Change-Id: I695bc5a78d8e6177f2b2847ecee58a0d973d7d1c
Reviewed-on: https://code.wireshark.org/review/5157
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

Improve error message by including the (expected) class information

The code checks whether the tag AND class are matching with their expected values, but only the tag information is shown in the error message.
When the class is not matching, the error message shows the given and expected tags which are the same, confusing the user what is wrong with it.

Furthermore, the messages for SEQUENCE and SEQUENCE OF are made the same/similar.

Change-Id: I6c1d0968c903105ec7f6e0648d589a4263a8ca18
Reviewed-on: https://code.wireshark.org/review/5162
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>

BER: Fix offset and length of EOC in Sequence loop

Change-Id: I4384339688c1dda5e011b7ff7772940fd61de8d1
Reviewed-on: https://code.wireshark.org/review/5164
Reviewed-by: Anders Broman <a.broman58@gmail.com>

Always process the expert info for the new open request message.

Change-Id: I38a4bee1b482f320c7e2fd685cf5823ddb4f8d36
Reviewed-on: https://code.wireshark.org/review/5163
Reviewed-by: Michael Tüxen <tuexen@wireshark.org>

lbtrm: Use correct variable for outgoing_mc_address.

Change-Id: I17e06e39de0de347926825741897646507691657
Reviewed-on: https://code.wireshark.org/review/5155
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>

coap: fix a bug; do some cleanup.

  Bug fix: do initial calls to col_...() *before* the dissection code so
           that proper column info is displayed even if the dissector
           exits early because of an exception, etc.

  Cleanup:
    - Use wmem_strbuf instead of static fixed length char arrays;
    - Create/use an extended value_string;
    - Use %u (not %d) when formatting unsigned values;
    - Use strchr() to search a string for a character;
    - Misc ...

Change-Id: I57ca584f989c3ab1cf141270cc50160f9fb980ae
Reviewed-on: https://code.wireshark.org/review/5153
Reviewed-by: Bill Meier <wmeier@newsguy.com>

Lua: Fixed some memory leakages.

Change-Id: I5e14c2e5a3868ec40d1989876b06919aa9ece4a1
Reviewed-on: https://code.wireshark.org/review/5138
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Evan Huus <eapache@gmail.com>

rpc: fix regression in gbfc5483174d

value can be NULL, in which case memduping it will crash

Bug: 10667
Change-Id: I8950fae94d80a2f06f24a785532536ad73f1855d
Reviewed-on: https://code.wireshark.org/review/5152
Reviewed-by: Evan Huus <eapache@gmail.com>

nfs: clean up fh_expire_type dissection

This is a bit simpler and makes the field searchable.

Ping-Bug: 10649
Change-ID: I68386f987c419c0b6cbc181f29c6bce6c04fcfdb
Reviewed-on: https://code.wireshark.org/review/5145
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

nfs: NFSv4.2 SEEK, ALLOCATE, DEALLOCATE support

NFSv4.2 is still a draft, but these three ops are implemented at least
for Linux now and are very unlikely to change any further.

Ping-Bug: 10649
Change-Id: Ia2917de59fb2b0ed7191c9f362b7eb60756d7634
Reviewed-on: https://code.wireshark.org/review/5143
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>

nfs: interpret aclsupport attribute

It's not an interesting attribute but I've occasionally been annoyed by
having to look it up just to verify a server isn't doing something nuts.

Ping-Bug: 10649
Change-Id: I660b62039075a4044946e590ee75ed5690290bc5
Reviewed-on: https://code.wireshark.org/review/5146
Reviewed-by: Michael Mann <mmann78@netscape.net>

nfs: label NFSv4 CREATE symlink arguments more helpfully

Currently it's hard to tell which field is the name of the symlink and
which is the target; both are labeled just "Name".

Ping-Bug: 10649
Change-Id: I1322a3652ffbcee920a6808dcc5613cefe8d8588
Reviewed-on: https://code.wireshark.org/review/5142
Reviewed-by: Michael Mann <mmann78@netscape.net>

nfs: fix open result_flags

The protocol values here are all wrong, and miss new flags from rfc
5661.

Ping-Bug: 10649
Change-Id: I03fb2b521b415dbca5d4b77eda609eb8084da57c
Reviewed-on: https://code.wireshark.org/review/5140
Reviewed-by: Michael Mann <mmann78@netscape.net>

Enable some runtime sanity checks when using at least gcc 4.9

Change-Id: I33208d4c27a27fb9222577ca176357035eeb7ba1
Reviewed-on: https://code.wireshark.org/review/5150
Reviewed-by: Jörg Mayer <jmayer@loplof.de>