Stephen Fisher [Tue, 30 Nov 2010 23:42:47 +0000 (23:42 -0000)]
Fix bug #5453: Use GetSystemNativeInfo() function if found on the machine running Wireshark instead of GetSystemInfo(), so that we obtain the machine's actual architecture even when running under WOW64 x86 emulation.
svn path=/trunk/; revision=35084
Jeff Morriss [Tue, 30 Nov 2010 22:33:29 +0000 (22:33 -0000)]
Update the manuf file (ahead of this weekend's auto-update) to reflect rev 35082's change to make-manuf.
svn path=/trunk/; revision=35083
Jeff Morriss [Tue, 30 Nov 2010 22:28:34 +0000 (22:28 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=4102 :
Limit the length of manuf names to 8 characters in make-manuf (this matches
the (old) limit in addr_resolv.c).
Dynamically allocate memory to store the manuf name in epan/addr_resolv.c so
that we don't end up corrupting the UTF-8 if/when we need to truncate the
string.
svn path=/trunk/; revision=35082
Jeff Morriss [Tue, 30 Nov 2010 21:32:04 +0000 (21:32 -0000)]
Convert the .c file names to .obj before putting them in WIRESHARK_GTK_OBJECTS.
svn path=/trunk/; revision=35081
Jeff Morriss [Tue, 30 Nov 2010 20:57:43 +0000 (20:57 -0000)]
Move the port audio source into a separate variable which is not run through checkapi.
svn path=/trunk/; revision=35080
Gerald Combs [Tue, 30 Nov 2010 17:46:09 +0000 (17:46 -0000)]
We don't include a comprehensive display filter reference; don't say we
do.
svn path=/trunk/; revision=35079
Chris Maynard [Tue, 30 Nov 2010 17:08:37 +0000 (17:08 -0000)]
Rename conflicting draft v2 and v8 display filter fields. Fixes bug 4059.
svn path=/trunk/; revision=35078
Jeff Morriss [Tue, 30 Nov 2010 17:06:13 +0000 (17:06 -0000)]
From Toralf Foerster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5432 :
The attached patch against that dissector contains :
FIX:
- counting statistics over encrypted packages (line 610 ff)
NEW:
- tag sametime message type 0x0025 as known
MISC:
- better comment
- new line clean ups
svn path=/trunk/; revision=35077
Martin Mathieson [Tue, 30 Nov 2010 15:10:17 +0000 (15:10 -0000)]
From Pascal Quantin:
I just found a small bug in LTE PDCP dissector with current top of tree.
If global preference global_pdcp_dissect_user_plane_as_ip is set to true, the dissector will try to decode an IP frame even with signalling plane.
PDCP-LTE
...0 0000 = Seq Num: 0
Signalling Data:
0800183aa808
MAC: 0x00000000 (0)
[Malformed Packet: IP]
[Expert Info (Error/Malformed): Malformed Packet (Exception occurred)]
With the attached patch, I get the correct output for both signalling and user plane PDUs.
svn path=/trunk/; revision=35076
Jeff Morriss [Tue, 30 Nov 2010 02:04:55 +0000 (02:04 -0000)]
Oh yeah, there's a reason we don't put targets in Makefile.common: the first target in a makefile is what you get when you just run make (without a target). Revert 35073 and 35069.
svn path=/trunk/; revision=35075
Sake Blok [Mon, 29 Nov 2010 22:50:21 +0000 (22:50 -0000)]
Fix "colorize with filter" functionality that got broken with the new_packet_list.
svn path=/trunk/; revision=35074
Jeff Morriss [Mon, 29 Nov 2010 22:34:04 +0000 (22:34 -0000)]
Move some checkapi targets into Makefile.common
svn path=/trunk/; revision=35073
Jeff Morriss [Mon, 29 Nov 2010 22:11:39 +0000 (22:11 -0000)]
Remove a no-longer-used variable.
svn path=/trunk/; revision=35072
Jeff Morriss [Mon, 29 Nov 2010 21:46:53 +0000 (21:46 -0000)]
Fix the checkapi target.
svn path=/trunk/; revision=35071
Anders Broman [Mon, 29 Nov 2010 21:40:49 +0000 (21:40 -0000)]
Change SIP TCP port preference to a range preference.
svn path=/trunk/; revision=35070
Jeff Morriss [Mon, 29 Nov 2010 20:53:22 +0000 (20:53 -0000)]
Move the checkapi targes to Makefile.common. Rename Makefile.nmake's WIRESHARK_GTK_SRC to WIRESHARK_GTK_ALL_SRC to avoid reusing the variable of the same name from Makefile.common; Put DIRTY_GENERATED_C_FILES back in that variable since checkapi is no longer run on it.
svn path=/trunk/; revision=35069
Stephen Fisher [Mon, 29 Nov 2010 20:43:24 +0000 (20:43 -0000)]
Add "Length" as a new default column on a trial basis between the protocol
and info columns per discussion on -dev list:
http://www.wireshark.org/lists/wireshark-dev/201011/msg00151.html
svn path=/trunk/; revision=35068
Jeff Morriss [Mon, 29 Nov 2010 20:37:24 +0000 (20:37 -0000)]
Remove DIRTY_GENERATED_C_FILES from WIRESHARK_GTK_SRC so we don't run checkapi on it. Also remove capture_if_details_dlg_win32.c from the checkapi list since it's in WIRESHARK_GTK_SRC (which is in the list of files checkapi is run against).
svn path=/trunk/; revision=35067
Jeff Morriss [Mon, 29 Nov 2010 20:09:09 +0000 (20:09 -0000)]
Remove file_dlg_win32.c and print_win32.c from the checkapi target.
svn path=/trunk/; revision=35066
Jeff Morriss [Mon, 29 Nov 2010 20:07:43 +0000 (20:07 -0000)]
Add DIRTY_GENERATED_C_FILES to GENERATED_FILES (so they get cleaned up by distclean).
svn path=/trunk/; revision=35065
Anders Broman [Mon, 29 Nov 2010 18:15:09 +0000 (18:15 -0000)]
From Andrei Emeltchenko:
Wrong link type in a packet(bluethouth).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5449
svn path=/trunk/; revision=35064
Chris Maynard [Mon, 29 Nov 2010 17:22:05 +0000 (17:22 -0000)]
Fix typos.
svn path=/trunk/; revision=35063
Anders Broman [Mon, 29 Nov 2010 13:27:00 +0000 (13:27 -0000)]
From Vincent Helfre:
Make it possible to dissect NAS EPS messages without security header.
svn path=/trunk/; revision=35062
Anders Broman [Mon, 29 Nov 2010 13:12:35 +0000 (13:12 -0000)]
From Vincent Helfre:
I have fixed some issue in the measurement information decoding in packet-gsm_a_rr.c.
svn path=/trunk/; revision=35061
Anders Broman [Mon, 29 Nov 2010 13:02:31 +0000 (13:02 -0000)]
Try to fix Buildbot crash output: fuzz-2010-11-28-11164.pcap
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5448
svn path=/trunk/; revision=35060
Martin Mathieson [Mon, 29 Nov 2010 12:09:18 +0000 (12:09 -0000)]
Allow DCT error strings containing given subsets to be filtered upon.
svn path=/trunk/; revision=35059
Jörg Mayer [Sun, 28 Nov 2010 21:45:15 +0000 (21:45 -0000)]
Make the Primary name element filterable in response records.
Same for Nameserver names.
svn path=/trunk/; revision=35058
Jörg Mayer [Sun, 28 Nov 2010 21:44:06 +0000 (21:44 -0000)]
u3.c has moved.
svn path=/trunk/; revision=35057
Anders Broman [Sun, 28 Nov 2010 21:08:03 +0000 (21:08 -0000)]
From Slava:
Bug with RWH parsing in Infiniband dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5444
svn path=/trunk/; revision=35056
Anders Broman [Sun, 28 Nov 2010 21:03:43 +0000 (21:03 -0000)]
From Robert Groenenberg:
Assert when using ASN.1 dissector with loading a 'type table'
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5447
svn path=/trunk/; revision=35055
Anders Broman [Sun, 28 Nov 2010 20:58:26 +0000 (20:58 -0000)]
From Alex Badea:
gsm_a_rr: System Information Type 4 / CBCH mobile allocation dissected incorrectly
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5436
svn path=/trunk/; revision=35054
Gerald Combs [Sun, 28 Nov 2010 16:03:43 +0000 (16:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-28]
svn path=/trunk/; revision=35051
Martin Mathieson [Sun, 28 Nov 2010 15:37:40 +0000 (15:37 -0000)]
Fix calling of LTE RRC dissector for "rrc_lte_r8" frames.
svn path=/trunk/; revision=35050
Guy Harris [Sun, 28 Nov 2010 00:53:23 +0000 (00:53 -0000)]
Partially clean up white space.
svn path=/trunk/; revision=35049
Guy Harris [Sun, 28 Nov 2010 00:41:47 +0000 (00:41 -0000)]
Clean up white space.
svn path=/trunk/; revision=35048
Guy Harris [Sun, 28 Nov 2010 00:19:49 +0000 (00:19 -0000)]
Clean up white space.
svn path=/trunk/; revision=35047
Stephen Fisher [Sun, 28 Nov 2010 00:15:21 +0000 (00:15 -0000)]
Move u3 code to top-level directory since it's not GTK specific
svn path=/trunk/; revision=35046
Guy Harris [Sun, 28 Nov 2010 00:13:38 +0000 (00:13 -0000)]
Don't report an error twice.
svn path=/trunk/; revision=35045
Guy Harris [Sun, 28 Nov 2010 00:02:39 +0000 (00:02 -0000)]
Add GCC-style printf annotation to the routines that now take a format
string and format arguments, and fix issues warned about by that.
svn path=/trunk/; revision=35044
Guy Harris [Sun, 28 Nov 2010 00:00:58 +0000 (00:00 -0000)]
Clean up white space.
svn path=/trunk/; revision=35043
Guy Harris [Sat, 27 Nov 2010 23:06:14 +0000 (23:06 -0000)]
Make some other statusbar routines take a format string and format args,
and get rid of an unnecessary string pointer.
Make the argument to welcome_header_push_msg() a const pointer.
svn path=/trunk/; revision=35042
Guy Harris [Sat, 27 Nov 2010 21:50:49 +0000 (21:50 -0000)]
Move main_statusbar.h to the top-level directory; none of its routines
use GTK+ data types, so, at least in theory, it could be implemented
atop another toolkit.
Make statusbar_push_temporary_msg() take a format string and format
arguments. Use it instead of simple_status(), and change one call to
just take a format string and arguments rather than to take the result
of using that format string and arguments with g_strdup_printf() and
passing the result to statusbar_push_temporary_msg().
svn path=/trunk/; revision=35041
Stephen Fisher [Sat, 27 Nov 2010 18:52:02 +0000 (18:52 -0000)]
Remove "not tested" note on MSVC 2010's vcredist instructions
svn path=/trunk/; revision=35040
Bill Meier [Sat, 27 Nov 2010 18:00:21 +0000 (18:00 -0000)]
Add svn:keywords & svn:eol-style properties.
svn path=/trunk/; revision=35039
Stephen Fisher [Sat, 27 Nov 2010 16:51:24 +0000 (16:51 -0000)]
From OKANO Takayoshi via bug #5442: Fix typos in documentation
svn path=/trunk/; revision=35038
Stephen Fisher [Sat, 27 Nov 2010 01:13:25 +0000 (01:13 -0000)]
Fix typo in comment
svn path=/trunk/; revision=35037
Stephen Fisher [Fri, 26 Nov 2010 23:50:56 +0000 (23:50 -0000)]
Define HAVE_GTK in config.h when compiling with GTK for the GUI
svn path=/trunk/; revision=35036
Stephen Fisher [Fri, 26 Nov 2010 23:33:05 +0000 (23:33 -0000)]
Mention SSHv2 RFCs
svn path=/trunk/; revision=35035
Stephen Fisher [Fri, 26 Nov 2010 20:57:46 +0000 (20:57 -0000)]
Fix the rest of the include paths after the move of native win32 code to win32 and out of the gtk directory in r35032
svn path=/trunk/; revision=35034
Stephen Fisher [Fri, 26 Nov 2010 20:13:00 +0000 (20:13 -0000)]
Fix the Windows buildbot after r35032
svn path=/trunk/; revision=35033
Stephen Fisher [Fri, 26 Nov 2010 19:16:06 +0000 (19:16 -0000)]
Move native Win32 code to its own directory and out of gtk directory (hopefully without breaking any builds)
svn path=/trunk/; revision=35032
Stephen Fisher [Fri, 26 Nov 2010 17:54:45 +0000 (17:54 -0000)]
Remove comment stating that Microsoft Visual Studio 2010 doesn't work since the express edition does (and presumably the full edition does also)
svn path=/trunk/; revision=35031
Balint Reczey [Thu, 25 Nov 2010 23:00:16 +0000 (23:00 -0000)]
Add libtool version info to libwsutil.
From Eloy Paris <peloy@debian.org>
http://svn.debian.org/wsvn/collab-maint/ext-maint/wireshark/branches/wireshark-1.4.x%2Blibseparation/debian/patches/25_libwsutil-version.patch
svn path=/trunk/; revision=35030
Jaap Keuter [Thu, 25 Nov 2010 19:59:19 +0000 (19:59 -0000)]
Fix for bug 5435:
Add support for dissecting SLL type 0x17 frames.
svn path=/trunk/; revision=35029
Anders Broman [Thu, 25 Nov 2010 15:21:24 +0000 (15:21 -0000)]
Update comments to point to the previous commit to enhance traceabillity.
svn path=/trunk/; revision=35028
Anders Broman [Thu, 25 Nov 2010 13:56:29 +0000 (13:56 -0000)]
Remove threading of tap update.
See http://www.wireshark.org/lists/wireshark-dev/200611/msg00199.html
svn path=/trunk/; revision=35027
Jaap Keuter [Thu, 25 Nov 2010 07:01:39 +0000 (07:01 -0000)]
Create proper Help reference.
svn path=/trunk/; revision=35026
Chris Maynard [Wed, 24 Nov 2010 17:33:58 +0000 (17:33 -0000)]
Add support for USB isochronous. From Marton Nemeth via bug #5370.
svn path=/trunk/; revision=35025
Chris Maynard [Wed, 24 Nov 2010 17:10:48 +0000 (17:10 -0000)]
Attempt to fix warnings not previously seen with VS2008EE.
svn path=/trunk/; revision=35024
Anders Broman [Wed, 24 Nov 2010 16:35:23 +0000 (16:35 -0000)]
From Johannes Lange:
Function dissect_per_bit_string_display might read more bytes than available (PER dissector).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5394
svn path=/trunk/; revision=35023
Chris Maynard [Wed, 24 Nov 2010 16:24:44 +0000 (16:24 -0000)]
When listing encapsulation types with -T or file types with -F, sort them.
svn path=/trunk/; revision=35022
Anders Broman [Wed, 24 Nov 2010 16:21:04 +0000 (16:21 -0000)]
From Johannes Lange:
Bug 5393 - Wrong length calculation in new_octet_aligned_subset_bits() (PER dissector) .
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5393
svn path=/trunk/; revision=35021
Anders Broman [Wed, 24 Nov 2010 15:15:28 +0000 (15:15 -0000)]
Tighten the heuristic.
svn path=/trunk/; revision=35020
Jaap Keuter [Wed, 24 Nov 2010 08:41:22 +0000 (08:41 -0000)]
Try to fix dummy header settings alignment.
svn path=/trunk/; revision=35019
Bill Meier [Wed, 24 Nov 2010 03:43:09 +0000 (03:43 -0000)]
Whitespace cleanup;
Add some braces;
svn path=/trunk/; revision=35018
Bill Meier [Wed, 24 Nov 2010 02:11:43 +0000 (02:11 -0000)]
Tighten up code dissecting message header.
This corrects the specific issue reported in Bug #3317
wherein the dissector decided there was a valid but unknown
header when dissecting a binary (non text) message with a ":"
as the last byte.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3317
Note that a larger issue remains: the IMF dissector
presumably shouldn't really even try to dissect a
binary payload (which is proably encrypted text).
svn path=/trunk/; revision=35017
Anders Broman [Tue, 23 Nov 2010 19:42:11 +0000 (19:42 -0000)]
Remove Supported Channels lenght check fixes
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5430
svn path=/trunk/; revision=35016
Anders Broman [Tue, 23 Nov 2010 17:33:57 +0000 (17:33 -0000)]
From Vincent Helfre:
Bug in tvb_get_bits32(), The last bitshift is too large, which causes the least significant bits to be 0 all the time.
svn path=/trunk/; revision=35015
Jeff Morriss [Tue, 23 Nov 2010 15:27:18 +0000 (15:27 -0000)]
Based on https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391#c11 : put some DISSECTOR_ASSERTs and THROW's back in.
svn path=/trunk/; revision=35014
Martin Mathieson [Tue, 23 Nov 2010 11:01:48 +0000 (11:01 -0000)]
Check the DDI while dissecting the header.
svn path=/trunk/; revision=35013
Gerald Combs [Mon, 22 Nov 2010 21:05:55 +0000 (21:05 -0000)]
Use g_path_get_dirname in init_progfile_dir on Windows. Leave the
non-Windows code alone since it needs to check for a libtool-ized path.
svn path=/trunk/; revision=35012
Stig Bjørlykke [Mon, 22 Nov 2010 21:05:49 +0000 (21:05 -0000)]
Initialize no_assoc.app_info=0.
svn path=/trunk/; revision=35011
Gerald Combs [Mon, 22 Nov 2010 20:43:22 +0000 (20:43 -0000)]
Make sure we pass a directory path and not a file path to
SetCurrentDirectory. Should fix bug 5420.
svn path=/trunk/; revision=35010
Anders Broman [Mon, 22 Nov 2010 20:24:12 +0000 (20:24 -0000)]
From Mike Morrin:
In bssmap, track L3 handover target (GSM or UMTS) between PDUs
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5294
svn path=/trunk/; revision=35009
Bill Meier [Mon, 22 Nov 2010 19:45:03 +0000 (19:45 -0000)]
Remove print_update_dynamic() decl from file_dlg_win32.h since only used in [...].c
svn path=/trunk/; revision=35008
Jeff Morriss [Mon, 22 Nov 2010 18:48:54 +0000 (18:48 -0000)]
From Emil Wojak via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5391 :
I'd like to share my enhancements to the TDS dissector with everyone.
The list of improvements follows:
- nearly complete dissection of RPC calls,
- detection and dissection of the ALL_HEADERS rule,
- corrected some existing proto_tree fields to support filters,
- other minor fixes where the interpretation of data conflicted with the
official documentation from MS.
I tested the new code on a variety of different TDS captures with many diverse
RPC calls. The code compiles and works on 32-bit Linux, I didn't check those
changes on other platforms though.
From me:
- terminate all value_strings
- change ++*offset to *offset += 1 (I think that's more readable)
- replace all the dissector assertions which could be caused by malformed
packets with expert infos
- Don't throw ReportedBoundsError when the packets have unexpected data in
them, just report an expert info and continue on
svn path=/trunk/; revision=35007
Bill Meier [Mon, 22 Nov 2010 17:17:46 +0000 (17:17 -0000)]
Prevent "MS-DOS style path detected" messages for several commands (when "nodosfilewarning" not set).
svn path=/trunk/; revision=35006
Jeff Morriss [Mon, 22 Nov 2010 16:19:39 +0000 (16:19 -0000)]
From Stephane Bryant via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5358 :
This is a dissector for reload framed message:
ReLOAD packets can be inserted in frame message, as described in
draft-ietf-p2psip-base-10
From me: remove some unnecessary includes.
svn path=/trunk/; revision=35005
Anders Broman [Mon, 22 Nov 2010 15:02:06 +0000 (15:02 -0000)]
Remove faulty return, probably forgotten during test.
Fixing dissection on Via header.
svn path=/trunk/; revision=35004
Bill Meier [Mon, 22 Nov 2010 14:59:33 +0000 (14:59 -0000)]
Remove 'keywords' property.
svn path=/trunk/; revision=35003
Bill Meier [Mon, 22 Nov 2010 14:57:58 +0000 (14:57 -0000)]
Remove 'keywords' property from a few files.
svn path=/trunk/; revision=35002
Martin Mathieson [Mon, 22 Nov 2010 13:37:13 +0000 (13:37 -0000)]
Add another (unsupported) channel type identifier.
svn path=/trunk/; revision=35001
Martin Mathieson [Mon, 22 Nov 2010 13:28:49 +0000 (13:28 -0000)]
Add sequence analysis for PDCP, based upon RLC/UM.
For now, only enable it for logged PDCP frames, i.e. not for PDCP found inside RLC (that won't work properly until RLC re-assembly is implemented).
svn path=/trunk/; revision=35000
Jörg Mayer [Mon, 22 Nov 2010 12:03:28 +0000 (12:03 -0000)]
Add new files to cmake as well
svn path=/trunk/; revision=34999
Chris Maynard [Mon, 22 Nov 2010 05:09:57 +0000 (05:09 -0000)]
Display priority and protocol, even in the case of WCCP2_SERVICE_STANDARD, but
indicate that these fields are unused in this case and must be zero.
Furthermore, if the value is non-zero, add an expert info warning about it.
Fixes bug 3631.
svn path=/trunk/; revision=34998
Bill Meier [Sun, 21 Nov 2010 19:33:46 +0000 (19:33 -0000)]
Fix properties.
svn path=/trunk/; revision=34997
Bill Meier [Sun, 21 Nov 2010 19:03:17 +0000 (19:03 -0000)]
Add $Id$; Fix some properties.
svn path=/trunk/; revision=34996
Bill Meier [Sun, 21 Nov 2010 18:57:21 +0000 (18:57 -0000)]
Add $Id$
svn path=/trunk/; revision=34995
Gerald Combs [Sun, 21 Nov 2010 16:03:40 +0000 (16:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2010-11-21]
svn path=/trunk/; revision=34992
Jaap Keuter [Sun, 21 Nov 2010 12:36:24 +0000 (12:36 -0000)]
Fix for bug 5425:
Add support for dissecting SLL type 0x0C frames.
svn path=/trunk/; revision=34991
Stig Bjørlykke [Sun, 21 Nov 2010 11:28:42 +0000 (11:28 -0000)]
Removed unused route_preference.
svn path=/trunk/; revision=34990
Anders Broman [Sun, 21 Nov 2010 10:41:01 +0000 (10:41 -0000)]
From Jakub Zawadzki via Alexander Koeppe.
Improvement of checking available length highlighting byteview data.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5383
svn path=/trunk/; revision=34989
Anders Broman [Sun, 21 Nov 2010 10:30:35 +0000 (10:30 -0000)]
From Alexis La Goutte:
ICMPv6 Enhancements : make ICMP option filterable.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5424
svn path=/trunk/; revision=34988
Jaap Keuter [Sat, 20 Nov 2010 18:14:30 +0000 (18:14 -0000)]
Fix for bug 5422:
Add support for dissecting SLL type 0x03 frames.
svn path=/trunk/; revision=34987
Jaap Keuter [Sat, 20 Nov 2010 16:14:30 +0000 (16:14 -0000)]
Add missing update of user-guide.xml for revision 34983.
svn path=/trunk/; revision=34986
Bill Meier [Sat, 20 Nov 2010 15:33:09 +0000 (15:33 -0000)]
Remove svn:executable and svn:keywords properties.
svn path=/trunk/; revision=34985
Sake Blok [Sat, 20 Nov 2010 14:55:02 +0000 (14:55 -0000)]
Repair copy (summary and as filter) functionality in the packet-list context menu. It got broken in the bulk of work required to move to the UImanager.
svn path=/trunk/; revision=34984
Jaap Keuter [Sat, 20 Nov 2010 13:41:04 +0000 (13:41 -0000)]
Add description of File|Import option.
svn path=/trunk/; revision=34983
Guy Harris [Fri, 19 Nov 2010 19:02:08 +0000 (19:02 -0000)]
Clean up blurbs a bit. Not much we can do about "Description" - what is
it a description *of*?
svn path=/trunk/; revision=34978
Jeff Morriss [Fri, 19 Nov 2010 18:54:19 +0000 (18:54 -0000)]
Verify the number of rectangles, sub-rectangles, the number of bytes of cut
text, etc. are "sane" before:
1) requesting enough bytes (from reassembly) to dissect them all
2) (and) attempting to add them all to the tree
Request all the bytes we'll need to dissect all those rectangles/sub-rectangles
before starting dissection rather than checking before dissecting each
rectangle/sub-rectangle.
Use tvb_get_ephemeral_string().
Use _U_ to mark unused arguments.
Fix up some indentation.
Get rid of one more DISSECTOR_ASSERT.
svn path=/trunk/; revision=34977