Balint Reczey [Sat, 2 Mar 2013 22:11:26 +0000 (22:11 -0000)]
Make Solaris Studio hide internal shared library symbols by default
svn path=/trunk/; revision=48020
Evan Huus [Sat, 2 Mar 2013 21:29:05 +0000 (21:29 -0000)]
Export some wmem functions using the new scheme.
svn path=/trunk/; revision=48019
Evan Huus [Sat, 2 Mar 2013 21:28:29 +0000 (21:28 -0000)]
Don't include wmem.h in packet_info.h, just use the struct name directly.
Otherwise wmem tweaks require rebuilding the entire tree for no particular
reason.
svn path=/trunk/; revision=48018
Evan Huus [Sat, 2 Mar 2013 21:16:32 +0000 (21:16 -0000)]
Don't pass -v straight to valgrind, it's rarely useful. Just increasing
num-callers is usually enough.
svn path=/trunk/; revision=48017
Michael Mann [Sat, 2 Mar 2013 21:05:32 +0000 (21:05 -0000)]
Convert at least enough proto_tree_add_text to proto_tree_add_item/expert_info to passify checkAPIs.pl.
Removed check_col calls.
svn path=/trunk/; revision=48016
Guy Harris [Sat, 2 Mar 2013 21:01:08 +0000 (21:01 -0000)]
Move the setting of pt to where it was before the changes, so it's
before the point at which it's added to the protocol tree.
Put the ATM channel in the ATM tree rather than the top-level tree.
Fix the name for the CPI field (copy-and-pasteo).
svn path=/trunk/; revision=48015
Anders Broman [Sat, 2 Mar 2013 19:34:50 +0000 (19:34 -0000)]
Rearrang the code to align with sqlite lemon and copy over a few more things.
svn path=/trunk/; revision=48014
Anders Broman [Sat, 2 Mar 2013 19:21:38 +0000 (19:21 -0000)]
From beroset:
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48013
Bill Meier [Sat, 2 Mar 2013 17:47:56 +0000 (17:47 -0000)]
Minor tweaks to "ColorSelection" UI:
- For each choice (marked/ignored fg/bg) always show orig color as "prev color";
- Improve spacing between widgets.
Also;
- Add a few explanatory comments;
- Add editor modelines;
- Cleanup whitespace/long-lines/formatting.
svn path=/trunk/; revision=48012
Evan Huus [Sat, 2 Mar 2013 16:39:56 +0000 (16:39 -0000)]
Define a new exception for reassembly errors, and throw it in several cases
instead of using DISSECTOR_ASSERT. When a dissector passes bad data to the
reassembly machine, that isn't necessarily the dissector's fault - the data may
come straight from the packet, and the dissector may not have enough information
to know it's bad without telling the reassembly machine in the first place.
Also fix a bug in the reassembly machine. If it were given a fragment and all of
the following conditions were met:
- the other associated fragments were already marked as done (reassembled)
- the fragment went beyond the end of the conceptual reassembled buffer
- the dissector had not set the PARTIAL_REASSEMBLY flag
then the reassembly machine would incorrectly think there was an overlap and
run past the end of the already-reassembled buffer.
Should fix the rest of
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8380
#BACKPORT
This is probably too big and intrusive to backport directly, and parts of it
will need adapting anyways since reassemble.c has changed. But the bug exists
and crashes in 1.6 and 1.8, so we'll have to do something.
svn path=/trunk/; revision=48011
Evan Huus [Sat, 2 Mar 2013 16:23:21 +0000 (16:23 -0000)]
Pass the same offset to tvb_ensure_bytes_exist and fragment_add.
One minor part of https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8380
svn path=/trunk/; revision=48010
Michael Mann [Sat, 2 Mar 2013 16:00:43 +0000 (16:00 -0000)]
General cleanup including:
1. Convert proto_tree_add_text to proto_tree_add_item/expert info
2. Change to "new style" dissector
3. Use standard malformed packet interface
Reviewed by Francesco Fondelli
svn path=/trunk/; revision=48009
Anders Broman [Sat, 2 Mar 2013 14:51:04 +0000 (14:51 -0000)]
Use explicit casts.
svn path=/trunk/; revision=48008
Pascal Quantin [Sat, 2 Mar 2013 13:12:24 +0000 (13:12 -0000)]
Fix a copy/paste error and factorize dissection of extension header length and next extension header
svn path=/trunk/; revision=48007
Anders Broman [Sat, 2 Mar 2013 12:10:56 +0000 (12:10 -0000)]
From beroset:
remove C++ incompatibilities
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=48006
Anders Broman [Sat, 2 Mar 2013 12:09:50 +0000 (12:09 -0000)]
Wite space changes.
svn path=/trunk/; revision=48005
Anders Broman [Sat, 2 Mar 2013 11:33:46 +0000 (11:33 -0000)]
From Lakshmi Narayana Madala :
GTP dissector enhanced to support UDP Port extension header.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8418
svn path=/trunk/; revision=48004
Anders Broman [Sat, 2 Mar 2013 11:32:25 +0000 (11:32 -0000)]
lemon.c:3176:8: error: attempt to free a non-heap object ‘buf’
svn path=/trunk/; revision=48003
Anders Broman [Sat, 2 Mar 2013 10:56:17 +0000 (10:56 -0000)]
Becport more code.
svn path=/trunk/; revision=48002
Anders Broman [Sat, 2 Mar 2013 10:03:43 +0000 (10:03 -0000)]
Missed one place.
svn path=/trunk/; revision=48001
Anders Broman [Sat, 2 Mar 2013 09:54:52 +0000 (09:54 -0000)]
lemon.c:78:14: note: expected ‘int (*)(const void *, const void *)’ but argument is of type ‘int (*)(const char *, const char *)’
svn path=/trunk/; revision=48000
Anders Broman [Sat, 2 Mar 2013 09:06:03 +0000 (09:06 -0000)]
From beroset:
remove C++ incompatibilities from frame_data_sequence.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=47999
Anders Broman [Sat, 2 Mar 2013 09:04:52 +0000 (09:04 -0000)]
More backports from sqlite lemon to try to address warnings.
svn path=/trunk/; revision=47998
Anders Broman [Sat, 2 Mar 2013 08:40:49 +0000 (08:40 -0000)]
lemon.c:4628:5: error: conflicting types for ‘Configcmp’
lemon.c:366:5: note: previous declaration of ‘Configcmp’ was here
svn path=/trunk/; revision=47997
Anders Broman [Sat, 2 Mar 2013 08:19:31 +0000 (08:19 -0000)]
More backports from sqlite lemon to try to address warnings.
svn path=/trunk/; revision=47996
Balint Reczey [Sat, 2 Mar 2013 01:00:20 +0000 (01:00 -0000)]
Move expert_group_vals expert_severity_vals constant definitions to expert.h
svn path=/trunk/; revision=47995
Balint Reczey [Sat, 2 Mar 2013 00:35:57 +0000 (00:35 -0000)]
Remove asn1/dsp from autotools Makefile system since it lacks distclean target
svn path=/trunk/; revision=47994
Anders Broman [Fri, 1 Mar 2013 23:54:06 +0000 (23:54 -0000)]
Backports from sqlite lemon.
svn path=/trunk/; revision=47993
Balint Reczey [Fri, 1 Mar 2013 23:53:11 +0000 (23:53 -0000)]
Export libwireshark symbols using WS_DLL_PUBLIC define
Also remove old WS_VAR_IMPORT define and related Makefile magic
everywhere in the project.
svn path=/trunk/; revision=47992
Jeff Morriss [Fri, 1 Mar 2013 22:58:23 +0000 (22:58 -0000)]
Fix a cut-n-pasteo and add a const cast to quiet a warning.
svn path=/trunk/; revision=47991
Evan Huus [Fri, 1 Mar 2013 22:57:13 +0000 (22:57 -0000)]
From Steve Magnani via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8338
Centralize logic related to per-interface conversations, and expose it for use
by class-specific dissectors.
Class-specific descriptor dissectors also need to know the interface in whose
context they are called to work.
This is a prerequisite for a USB Video Class dissector, which needs to decode
many class-specific descriptors.
svn path=/trunk/; revision=47990
Anders Broman [Fri, 1 Mar 2013 21:37:48 +0000 (21:37 -0000)]
Backport const casts from sqlite lemon.
svn path=/trunk/; revision=47989
Anders Broman [Fri, 1 Mar 2013 20:36:59 +0000 (20:36 -0000)]
From beroset:
remove C++ incompatibilities from packet-xml.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=47988
Anders Broman [Fri, 1 Mar 2013 20:32:20 +0000 (20:32 -0000)]
try to remove C++ incompatibilities from lemon
svn path=/trunk/; revision=47987
Pascal Quantin [Fri, 1 Mar 2013 19:32:23 +0000 (19:32 -0000)]
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :
Remove C++ incompatibilities from packet-asn1.c
svn path=/trunk/; revision=47984
Evan Huus [Fri, 1 Mar 2013 19:10:04 +0000 (19:10 -0000)]
Revert r47839, it is not needed with r47979.
svn path=/trunk/; revision=47980
Evan Huus [Fri, 1 Mar 2013 19:08:30 +0000 (19:08 -0000)]
Add a much better workaround for bug #8382 and some expert info.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8382
svn path=/trunk/; revision=47979
Pascal Quantin [Fri, 1 Mar 2013 19:05:25 +0000 (19:05 -0000)]
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :
Remove C++ incompatibilities from WiMAX plugins
svn path=/trunk/; revision=47978
Pascal Quantin [Fri, 1 Mar 2013 18:35:51 +0000 (18:35 -0000)]
From Ed Beroset via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416 :
Remove C++ incompatibilities from packet-smb.C
svn path=/trunk/; revision=47977
Bill Meier [Fri, 1 Mar 2013 16:31:42 +0000 (16:31 -0000)]
Fix [-W shadow] issue in SVN #47958 in a slightly different manner than the fix SVN #47960.
svn path=/trunk/; revision=47976
Chris Maynard [Fri, 1 Mar 2013 16:13:44 +0000 (16:13 -0000)]
Whitespace changes: Convert spaces to tabs. Add modelines.
svn path=/trunk/; revision=47975
Evan Huus [Fri, 1 Mar 2013 13:24:24 +0000 (13:24 -0000)]
Addendum to r47962, caught by Jakub Zawadzki via
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8379
Respect the offset given us by TCP when fetching PDU len.
svn path=/trunk/; revision=47974
Chris Maynard [Fri, 1 Mar 2013 07:02:08 +0000 (07:02 -0000)]
Fix Coverity CID 280396: Logically dead code.
svn path=/trunk/; revision=47973
Chris Maynard [Fri, 1 Mar 2013 06:52:25 +0000 (06:52 -0000)]
Fix Coverity CID 280371: Logically dead code.
svn path=/trunk/; revision=47972
Anders Broman [Fri, 1 Mar 2013 06:44:37 +0000 (06:44 -0000)]
Fix warning: C++ style comments are not allowed in ISO C90 [enabled by default]
svn path=/trunk/; revision=47971
Chris Maynard [Fri, 1 Mar 2013 06:29:18 +0000 (06:29 -0000)]
Fix Coverity CID 280369: Logically dead code.
svn path=/trunk/; revision=47970
Chris Maynard [Fri, 1 Mar 2013 06:20:41 +0000 (06:20 -0000)]
Convert spaces to tabs in capture_step_snapshot().
(Maybe this will make the XP buildbot happy so test.sh succeeds again?)
svn path=/trunk/; revision=47969
Anders Broman [Fri, 1 Mar 2013 06:01:51 +0000 (06:01 -0000)]
From beroset:
remove C++ incompatibilities from packet-pw-atm.c
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8416
svn path=/trunk/; revision=47968
Chris Maynard [Fri, 1 Mar 2013 05:46:07 +0000 (05:46 -0000)]
Fix Coverity CID 280367: Logically dead code.
svn path=/trunk/; revision=47967
Chris Maynard [Fri, 1 Mar 2013 05:40:49 +0000 (05:40 -0000)]
Fix Coverity CID 280365: Logically dead code.
#BACKPORT (1.8, 1.6)
svn path=/trunk/; revision=47966
Chris Maynard [Fri, 1 Mar 2013 05:29:12 +0000 (05:29 -0000)]
Fix Coverity CID 280362: Logically dead code.
#BACKPORT (1.8, 1.6)
svn path=/trunk/; revision=47965
Chris Maynard [Fri, 1 Mar 2013 05:04:03 +0000 (05:04 -0000)]
Fix Coverity CID 280391: Logically dead code.
svn path=/trunk/; revision=47964
Chris Maynard [Fri, 1 Mar 2013 04:53:26 +0000 (04:53 -0000)]
Fix Coverity CID 988967: Logically dead code.
svn path=/trunk/; revision=47963
Evan Huus [Fri, 1 Mar 2013 02:07:58 +0000 (02:07 -0000)]
From Sebastiano Di Paola via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8379
New dissector for the honeypot-feeds protocol.
From me: Misc. tweaks to expert info layout and remove a few unneeded initializers.
svn path=/trunk/; revision=47962
Evan Huus [Fri, 1 Mar 2013 01:39:33 +0000 (01:39 -0000)]
Add some 'const's to satisfy latest GCC.
svn path=/trunk/; revision=47961
Evan Huus [Thu, 28 Feb 2013 23:44:32 +0000 (23:44 -0000)]
Rename a variable s/color_edit_dlg/color_edit_window/ to fix a -Wshadow error
svn path=/trunk/; revision=47960
Evan Huus [Thu, 28 Feb 2013 23:39:47 +0000 (23:39 -0000)]
Re-add statement accidentally removed in r47950 that was resulting in a
variable being used uninitialized.
svn path=/trunk/; revision=47959
Bill Meier [Thu, 28 Feb 2013 23:05:09 +0000 (23:05 -0000)]
color_edit_dlg update:
- Significantly simplify & rework code;
- Use GtkColorChooser instead of GtkColorSelection if GTK 3.4 or newer.
- Minor UI cleanup (default buttons & etc)
- Fix crash which occurred in the (existing) GTK3 related code.
- Fix some other relatively minor bugs (including some minor memory leaks);
- Remove some old, commented-out code;
- Use a more consistent naming scheme for certain variables.
svn path=/trunk/; revision=47958
Jeff Morriss [Thu, 28 Feb 2013 23:02:38 +0000 (23:02 -0000)]
Make it so that alternate-prefix RPM builds actually work.
Use the prefix from 'configure' in the RPM (so: to build an RPM which installs
in /opt do "./configure --prefix=/opt && make rpm-package").
(Maybe this approach should also be used for the other options in the .spec
file.)
Only clean up if building the RPM was successful.
svn path=/trunk/; revision=47957
Michael Mann [Thu, 28 Feb 2013 23:01:31 +0000 (23:01 -0000)]
Replace proto_tree_add_text with proto_tree_add_item/expert_info
svn path=/trunk/; revision=47956
Pascal Quantin [Thu, 28 Feb 2013 22:22:52 +0000 (22:22 -0000)]
Fix dissection of feedback with large CID
svn path=/trunk/; revision=47955
Balint Reczey [Thu, 28 Feb 2013 22:17:06 +0000 (22:17 -0000)]
Revert "Fix MSVC build errors related to symbol visibility"
This reverts commit r47952.
The problem was different from what I originally thought, thus
the commit was obsolete.
svn path=/trunk/; revision=47954
Balint Reczey [Thu, 28 Feb 2013 21:42:23 +0000 (21:42 -0000)]
Add -DWS_BUILD_DLL to wiretap Windows builds
It fixes symbol exporting from DLLs.
svn path=/trunk/; revision=47953
Balint Reczey [Thu, 28 Feb 2013 21:11:32 +0000 (21:11 -0000)]
Fix MSVC build errors related to symbol visibility
svn path=/trunk/; revision=47952
Pascal Quantin [Thu, 28 Feb 2013 21:05:27 +0000 (21:05 -0000)]
Add SVN keywords
svn path=/trunk/; revision=47951
Michael Mann [Thu, 28 Feb 2013 20:17:33 +0000 (20:17 -0000)]
Use proto_tree_add_item (or similar) instead of proto_item_add_text.
svn path=/trunk/; revision=47950
Michael Mann [Thu, 28 Feb 2013 20:07:15 +0000 (20:07 -0000)]
Convert proto_item_add_text to proto_item_add_item.
General whitespace cleanup, add modelines.
svn path=/trunk/; revision=47949
Balint Reczey [Thu, 28 Feb 2013 19:35:59 +0000 (19:35 -0000)]
Export libwiretap symbols using WS_DLL_PUBLIC define
TODO: hide flex-generated functions
svn path=/trunk/; revision=47948
Guy Harris [Thu, 28 Feb 2013 18:13:41 +0000 (18:13 -0000)]
Update a comment.
svn path=/trunk/; revision=47947
Anders Broman [Thu, 28 Feb 2013 17:56:02 +0000 (17:56 -0000)]
Dissect japan ISUP Charging Info IE.
svn path=/trunk/; revision=47946
Anders Broman [Thu, 28 Feb 2013 17:55:07 +0000 (17:55 -0000)]
Avoid a packet rescan if we don't have an AirPcap adapter.
svn path=/trunk/; revision=47945
Jeff Morriss [Thu, 28 Feb 2013 17:29:10 +0000 (17:29 -0000)]
Be a little quieter (and do a little more cleanup) when building RPMs.
svn path=/trunk/; revision=47944
Jeff Morriss [Thu, 28 Feb 2013 15:27:56 +0000 (15:27 -0000)]
Add a #define for the default capture buffer size and use it.
svn path=/trunk/; revision=47942
Balint Reczey [Thu, 28 Feb 2013 15:27:15 +0000 (15:27 -0000)]
Add ws_symbol_export.h WIRESHARK_COMMON_INCLUDES to fix failing distcheck
svn path=/trunk/; revision=47941
Jeff Morriss [Thu, 28 Feb 2013 15:16:46 +0000 (15:16 -0000)]
From Anders: revert r47934: it doesn't work everywhere.
See email discussion on -dev.
svn path=/trunk/; revision=47940
Jeff Morriss [Thu, 28 Feb 2013 14:36:41 +0000 (14:36 -0000)]
From Anders: more places to increase the default capture buffer size.
svn path=/trunk/; revision=47939
Balint Reczey [Thu, 28 Feb 2013 14:09:46 +0000 (14:09 -0000)]
Export libwsutil symbols using WS_DLL_PUBLIC define
This change replaces *.def and *.sym file usage following the
guideline at http://gcc.gnu.org/wiki/Visibility
svn path=/trunk/; revision=47938
Jeff Morriss [Thu, 28 Feb 2013 13:59:47 +0000 (13:59 -0000)]
Default capture buffer size is now 2MB.
svn path=/trunk/; revision=47937
Pascal Quantin [Thu, 28 Feb 2013 08:13:40 +0000 (08:13 -0000)]
From Hadriel Kaplan via https://wireshark.org/lists/wireshark-dev/201302/msg00216.html :
Fix dissection of method name in case of RAck header
svn path=/trunk/; revision=47936
Anders Broman [Thu, 28 Feb 2013 06:37:41 +0000 (06:37 -0000)]
Update the text of dumpcap -h, default buffer size should be 2 MB.
svn path=/trunk/; revision=47935
Gerald Combs [Thu, 28 Feb 2013 04:44:38 +0000 (04:44 -0000)]
str_util.c: Although the glib documentation doesn't explicitly say so,
it looks like the thousands grouping (') modifier is supported so use it
in format_size.
capinfos.c: Set our locale.
svn path=/trunk/; revision=47934
Guy Harris [Thu, 28 Feb 2013 04:29:43 +0000 (04:29 -0000)]
Combine all the flags fields into one field, and get rid of the
commented-out/#if-ed-out "Data1" field, as it's the same field.
Give the flags in that field names including "flags".
Shuffle the fields around to put "Flags" (a/k/a Data1) where Data1 was,
and put the bits in that field after it.
Update the URL for the spec at IBM.
Reformat the entries in hf_netb[] to use the same style.
svn path=/trunk/; revision=47933
Chris Maynard [Thu, 28 Feb 2013 03:15:57 +0000 (03:15 -0000)]
Fix Coverity CID 719419: Dereference after null check.
svn path=/trunk/; revision=47932
Chris Maynard [Thu, 28 Feb 2013 02:48:16 +0000 (02:48 -0000)]
Fix Coverity CID 280377: Dead default in switch.
svn path=/trunk/; revision=47931
Chris Maynard [Thu, 28 Feb 2013 02:37:14 +0000 (02:37 -0000)]
Fix Coverity CID 280366: Dead default in switch.
svn path=/trunk/; revision=47930
Guy Harris [Thu, 28 Feb 2013 00:09:26 +0000 (00:09 -0000)]
The LDAP dissector uses register_frame_end_routine(), so it needs to
include packet-frame.h.
svn path=/trunk/; revision=47928
Pascal Quantin [Wed, 27 Feb 2013 23:08:17 +0000 (23:08 -0000)]
Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8378 :
A detailed diagnostic information contains either a SMS-SUBMIT-REPORT or a SMS-DELIVERY-REPORT. Set P2P direction accordingly.
svn path=/trunk/; revision=47927
Guy Harris [Wed, 27 Feb 2013 23:07:25 +0000 (23:07 -0000)]
Include <epan/show_exception.h>, as show_exception() is called.
svn path=/trunk/; revision=47926
Guy Harris [Wed, 27 Feb 2013 23:02:18 +0000 (23:02 -0000)]
Get rid of unnecessary includes of "packet-frame.h".
svn path=/trunk/; revision=47925
Guy Harris [Wed, 27 Feb 2013 22:43:54 +0000 (22:43 -0000)]
Move show_exception() and show_reported_bounds_error() to
epan/show_exception.c, as it's used outside
epan/dissectors/packet-frame.c. Update their callers to include
<epan/show_exception.h> to get their declaration.
Add a CATCH_NONFATAL_ERRORS macro that catches all exceptions that, if
there's more stuff in the packet to dissect after the dissector call
that threw the exception, doesn't mean you shouldn't go ahead and
dissect that stuff. Use it in all those cases, including ones where
BoundsError was inappropriately being caught (you want those passed up
to the top level, so that the packet is reported as having been cut
short in the capture process).
Add a CATCH_BOUNDS_ERRORS macro that catches all exceptions that
correspond to running past the end of the data for a tvbuff; use it
rather than explicitly catching those exceptions individually, and
rather than just catching all exceptions (the only place that
DissectorError should be caught, for example, is at the top level, so
dissector bugs show up in the protocol tree).
Don't catch and then immediately rethrow exceptions without doing
anything else; just let the exceptions go up to the final catcher.
Use show_exception() to report non-fatal errors, rather than doing it
yourself.
If a dissector is called from Lua, catch all non-fatal errors and use
show_exception() to report them rather than catching only
ReportedBoundsError and adding a proto_malformed item.
Don't catch exceptions when constructing a trailer tvbuff in
packet-ieee8023.c - just construct it after the payload has been
dissected, and let whatever exceptions that throws be handled at the top
level.
Avoid some TRY/CATCH/ENDTRY cases by using checks such as
tvb_bytes_exist() before even looking in the tvbuff.
svn path=/trunk/; revision=47924
Guy Harris [Wed, 27 Feb 2013 22:07:44 +0000 (22:07 -0000)]
For subvectors, make a top-level item to cover the entire subvector, and
put the length, identifier, and value as visible sub-items underneath
it. If the length is bad, add an expert info indication under the item
for the length, rather than using proto_malformed. Add checks for the
lengths of each type of subvector.
Add some more subvector types from IEEE 802.5-1998, and use the names
from that spec.
svn path=/trunk/; revision=47923
Guy Harris [Wed, 27 Feb 2013 22:04:40 +0000 (22:04 -0000)]
When decompressing, put an entry into the protocol tree that covers all
the compressed data, put the entries for particular parts of that data
under that entry, and, when we have a problem decompressing, add an
expert info item to that entry, rather than just adding text or using
proto_malformed. Do so for *all* decompression problems; in particular,
check for decompressed_entry() returning NULL, which it can do.
tvb_new_child_real_data() won't throw an exception, so don't bother
checking for that.
If, after the first pass, we can't find the uncompressed data for a
frame, report it as a dissector bug.
Check whether we have room for a byte in the uncompressed data buffer
*before* copying it.
Other cleanups.
svn path=/trunk/; revision=47922
Pascal Quantin [Wed, 27 Feb 2013 21:19:37 +0000 (21:19 -0000)]
From J. Schoenwaelder via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8410 :
Fix dissection of flowDurationMicroseconds in Netflow dissector
svn path=/trunk/; revision=47921
Anders Broman [Wed, 27 Feb 2013 20:38:43 +0000 (20:38 -0000)]
Increase the default buffer size to 2MB.
svn path=/trunk/; revision=47920
Anders Broman [Wed, 27 Feb 2013 20:02:38 +0000 (20:02 -0000)]
Dissect Japan ISUP Charge rate transfer (flexible charging) .
svn path=/trunk/; revision=47919
Chris Maynard [Wed, 27 Feb 2013 16:18:16 +0000 (16:18 -0000)]
Use ENC_NA for single byte fields, as that appears to be the generally agreed upon convention. Add modelines.
#BACKPORT(1.8) + r47915
svn path=/trunk/; revision=47918
Bill Meier [Wed, 27 Feb 2013 16:15:18 +0000 (16:15 -0000)]
Use consistent indentation; Add editor modelines.
svn path=/trunk/; revision=47917
Jeff Morriss [Wed, 27 Feb 2013 16:12:19 +0000 (16:12 -0000)]
Add a %prefix option for users who want to (easily) configure Wireshark to
install in a non-standard location.
Assume the desktop-integration stuff goes in /usr (regardless of our prefix).
This (with r47914) fixes RPM generation when someone uses a prefix other than
/usr .
Also: run desktop-file-validate on the wireshark.desktop file (just in case it
wasn't installed with desktop-file-install).
svn path=/trunk/; revision=47916
Michael Mann [Wed, 27 Feb 2013 16:08:48 +0000 (16:08 -0000)]
Protocol is ENC_BIG_ENDIAN, adjust accordingly.
Bug 8407 (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8407)
svn path=/trunk/; revision=47915
Jeff Morriss [Wed, 27 Feb 2013 16:08:16 +0000 (16:08 -0000)]
Don't install the desktop-integration files in our (Wireshark's) data
directory (which is based on our installation prefix): there's no guarantee
that the desktop also uses the same prefix.
Add a note about how we might be able to find the desktop's data directory
should anyone actually run GNOME with a prefix other than /usr .
Also use 'desktop-file-install' to install the desktop file (if configure
found that command).
svn path=/trunk/; revision=47914