Stig Bjørlykke [Wed, 2 Nov 2016 19:26:11 +0000 (20:26 +0100)]
btl2cap: Initialize reassembly values
Values in psm_data structure used in reassembly must be initialized
to zero to ensure that the reassembly logic works.
Change-Id: I47c636dde60f28a8dcd9a366664fd23019a12323
Reviewed-on: https://code.wireshark.org/review/18633
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Dario Lombardo [Wed, 2 Nov 2016 13:15:41 +0000 (14:15 +0100)]
sshdump: use g_shell_quote in the right way.
Change-Id: I3f71dabe92d3b00192f36fc57ebb7673b2327620
Reviewed-on: https://code.wireshark.org/review/18623
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Julian Cable [Fri, 11 Mar 2016 17:19:14 +0000 (12:19 -0500)]
Bugfix dissection of DCP-ETSI
Fix root cause in dissect_af
Bug: 12252
Change-Id: Ia20fc7bad39e80062e177b4ddd7c7bb87accf328
Reviewed-on: https://code.wireshark.org/review/14644
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 2 Nov 2016 12:28:29 +0000 (13:28 +0100)]
TLS(1.3): Add new Alert
Change-Id: Ice365bf3ca2198b3d81994a5670ac50add3e53dc
Reviewed-on: https://code.wireshark.org/review/18620
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Adam Goldman [Wed, 2 Nov 2016 13:16:56 +0000 (09:16 -0400)]
opa-mad: Fix several issues with the SA and SM parse functions
Add support for SA(PortGroupTableRecord). Fixed parse errors in
SA(CableInfoRecord), SA(BufferControlTable), SA(PathRecord),
SA(PortInfo), & SM/SA(SMInfo). Moved SA(FabricInfoRecord) to be in SA
Sections. Remove the attribute modifier 'ALL' bit being incorrectly
used in SM/SA. Add support for the valid case when SA returns with
zero records and a none zero MAD status.
Change-Id: I9bdc87d113be045132a78ecf5c8b4ffa3ac29900
Signed-off-by: Adam Goldman <adam.goldman@intel.com>
Reviewed-on: https://code.wireshark.org/review/18629
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Rémy Léone [Wed, 2 Nov 2016 15:53:07 +0000 (16:53 +0100)]
ieee802.15.4: fix small typo
Change-Id: I23c58ef5cbf116402d25089bae3d83168b8af974
Reviewed-on: https://code.wireshark.org/review/18632
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Alexis La Goutte [Mon, 24 Oct 2016 07:11:06 +0000 (09:11 +0200)]
Update .mailmap
Change-Id: I9962ced39ce3fd31cff446a99ba1c0b6ebfb1bbf
Reviewed-on: https://code.wireshark.org/review/18596
Reviewed-by: Erik de Jong <erikdejong@gmail.com>
Reviewed-by: Anish Bhatt <anish@gatech.edu>
Reviewed-by: Francisco Javier Sánchez-Roselly <franciscojavier.sanchezroselly@ujaen.es>
Reviewed-by: Mikael Kanstrup <mikael.kanstrup@gmail.com>
Reviewed-by: Franklin Mathieu <snaipe@diacritic.io>
Reviewed-by: Boris Bochkaryov <Boris-Bochkaryov@yandex.ru>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Peter Wu [Mon, 31 Oct 2016 21:49:20 +0000 (22:49 +0100)]
make-version.pl: fix --print-vcs output
Detect earlier whether to write VCSVERSION to version.h such that the
--vcs-version output matches the contents of version.h.
Change-Id: I5c05087679bb7861cd5884426b39fa362bf23a16
Fixes: v2.1.0rc0-2770-geeded81 ("Add option to disable version.h")
Reviewed-on: https://code.wireshark.org/review/18599
Reviewed-by: João Valverde <j@v6e.pt>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 2 Nov 2016 08:47:48 +0000 (09:47 +0100)]
Openflow (v4/v5): Add vOXM vlan mask field
Bug: 12979
Change-Id: I7f0e806081704dfeaf40ce1e4e41271ffd5e3023
Reviewed-on: https://code.wireshark.org/review/18618
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 2 Nov 2016 07:36:33 +0000 (08:36 +0100)]
FIX: fix spelling typo found by lintian
Change-Id: I3616de3ecd7ca52f2da4af13f35967eeed61414e
Reviewed-on: https://code.wireshark.org/review/18613
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 2 Nov 2016 12:27:14 +0000 (13:27 +0100)]
btatt: fix spelling typo found by lintian
Change-Id: I3fdc71e927bdb0d5408db46656c23b23dc31489a
Reviewed-on: https://code.wireshark.org/review/18621
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Pascal Quantin [Wed, 2 Nov 2016 08:31:52 +0000 (09:31 +0100)]
SNA: fix dissection of GDS Variables
Decode the header as specified in http://www.retrocomputing.net/info/doc/GA27-3136-20_SNA_Formats.pdf chapter 13.
Note that the Information field is not decoded yet.
Bug: 13084
Change-Id: Iaaee344ef0b2805906a3eeae1134479abf9d403e
Reviewed-on: https://code.wireshark.org/review/18616
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Benoît Canet [Tue, 18 Oct 2016 13:27:37 +0000 (15:27 +0200)]
Packaging: Add dependencies for lz4 and snappy packages
Do it for Debian-like, RPM-based, and MacOS (via Homebrew) systems.
Signed-off-by: Benoît Canet <benoit@scylladb.com>
Signed-off-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Change-Id: I52802301815243021c039da6a27af6c534792439
Reviewed-on: https://code.wireshark.org/review/18272
Reviewed-by: Benoît Canet <benoit@scylladb.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Dario Lombardo [Mon, 31 Oct 2016 11:37:14 +0000 (12:37 +0100)]
Qt: add "search authors" feature.
Add a search field in the authors tab. The list of authors has became
huge and it's very hard to find someone in it. Having a fast way to
search yourself or your friends would be fun.
Change-Id: I0c6a5e8d5893d6f7b5a3258e63bdc91969f53d31
Reviewed-on: https://code.wireshark.org/review/18594
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Alexis La Goutte [Wed, 2 Nov 2016 08:51:34 +0000 (09:51 +0100)]
pre-commit: fix indent
Change-Id: I50291be3fd275cde8af42c45c17e52345d1c6215
Reviewed-on: https://code.wireshark.org/review/18619
Reviewed-by: Michael Mann <mmann78@netscape.net>
Guy Harris [Wed, 2 Nov 2016 08:43:34 +0000 (01:43 -0700)]
Fix some errors.
Th link throughput and latency objects are just 32-bit integers; process
them as such and, as they're bytes-per-second and microsecond values,
respectively, show them as decimal, rather than as hex, as most of us
have 10, not 16, fingers.
The ETX metric object is a 16-bit integer; process it as such, and show
it in decimal as well.
Attach an expert info representing an error to the item in error.
Change-Id: I57dfac0127d263724cc6940a0457d63e17616b64
Reviewed-on: https://code.wireshark.org/review/18617
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Joerg Mayer [Wed, 2 Nov 2016 05:56:30 +0000 (06:56 +0100)]
Add snappy compression library setup
Change-Id: I060d3056dc386f44aec703ddd0fe024866a51fcf
Reviewed-on: https://code.wireshark.org/review/18611
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Jeff Morriss [Wed, 2 Nov 2016 01:29:11 +0000 (21:29 -0400)]
Validate the Diameter XML files in the pre-commit script.
Validation requires xmllint but will pass (with a complaint) if the committer
does not have xmllint installed.
Change-Id: I336a1c8ad8e1f98805a284d8c4736810b1a9c54e
Reviewed-on: https://code.wireshark.org/review/18609
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Adam Goldman [Tue, 1 Nov 2016 14:24:48 +0000 (10:24 -0400)]
opa-mad: Fixed malformed SA(FabricInfoRecord) reserved field
Change-Id: I1b20a49008e41728cb10cd11765833a762f66505
Reviewed-on: https://code.wireshark.org/review/18603
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Jeff Morriss [Wed, 2 Nov 2016 01:11:40 +0000 (21:11 -0400)]
Add a few more T6a/T6b and charging AVPs.
Fix a mistake in a comment.
Change-Id: Ibb12ff3036fb42fe5e3955c67c7c9989f8ffca63
Reviewed-on: https://code.wireshark.org/review/18610
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Michael Mann [Mon, 31 Oct 2016 05:10:56 +0000 (01:10 -0400)]
Move Base32_encode from packet-fc00.c to wsutil (as ws_base32_decode)
There could be some reuse out of it, so but it with the rest of the
general utilities.
Change-Id: I404c135b933660a82678510b9ca2701985c5632a
Reviewed-on: https://code.wireshark.org/review/18589
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Parav Pandit [Sun, 30 Oct 2016 08:20:48 +0000 (04:20 -0400)]
packet-infiniband: Fixed IP based connections & other minor fixes
1. Fixed setting right address type instead of AT_IB for RoCE and RRoCE
depending on address type given by pinfo where address type would be
IPv4 or IPV6.
Fail to do so was resulting into infiniband dissector adding
conversation info based on AT_IB type vs payload dissectors dissecting
based on pinfo. Fixing this allows to add/search based on right
address type.
(Tested for Infiniband and RRoCE)
2. Added support to pass already parsed CM attribute id from infiniand to
other mad private data dissectors so that right dissection of private data
can be done based on CM attribute id (message type).
Moved CM attribute id definitions to header file so that private data
dissectors based on CM attribute id can reuse these values without
duplicate defines.
(Tested for Infiniband and RRoCE)
3. Added direction client to server/server to client, (active/passive) to
conversation_data for payload dissectors which cannot dissect only based
on payload content without knowing the direction.
(Tested for RRoCE)
4. Fixed IP CM to claim all 92 bytes of private data (including consumer
private data), instead of just 36 bytes of header because its part of IP
CM private data.
(Tested for Infiniband and RRoCE)
5. Fixed MAD header to claim all 232 (256-24) bytes of data as it belongs
to it in the tree.
(Tested for Infiniband and RRoCE)
6. Fixed getting ip version by performing AND operation first to extract IP
version field.
(Tested for RRoCE-IPV4 and Infiniband)
Change-Id: I37daca6a089784b61c25e10cdc8f3cf028ca8c58
Tested-by: paravpandit@yahoo.com
Reviewed-on: https://code.wireshark.org/review/18573
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Pascal Quantin [Mon, 31 Oct 2016 22:02:44 +0000 (23:02 +0100)]
Small fixes for JSON output
- reinitialize the variable used to insert comma between packets when
performing a new export
- ensure that escaped ASCII characters are code on 4 digits characters
Change-Id: Ib557da4843f6b98f793b60e417260ebb27a38b99
Ping-Bug: 13073
Reviewed-on: https://code.wireshark.org/review/18598
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Joakim Karlsson [Tue, 1 Nov 2016 17:57:04 +0000 (18:57 +0100)]
gtp: fix and improve user location information
* Fixed RAI which was broken
* Improved CGI and SAI
Change-Id: I1807b628ef54e2f3e94551c26301f1376bef0914
Reviewed-on: https://code.wireshark.org/review/18604
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Joerg Mayer [Wed, 2 Nov 2016 00:47:00 +0000 (01:47 +0100)]
Add lz4 setup.
Change-Id: If3b51e719a0a745eac0862f882b912e1d0f72587
Reviewed-on: https://code.wireshark.org/review/18608
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Joakim Karlsson [Tue, 1 Nov 2016 20:11:05 +0000 (21:11 +0100)]
gtp: correction of octet14 in QoSProfile
* Added Spare4
* Corrected order
Change-Id: I93384452d73bd519784b8c11ab5671797d16fc99
Reviewed-on: https://code.wireshark.org/review/18606
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Sean O. Stalley [Tue, 1 Nov 2016 21:55:35 +0000 (14:55 -0700)]
MAUSB: Fix width of Cancel Transfer Status field
Width of this field was increased in the 1.0a MA USB Update.
Change-Id: Ib1a40dee6fbcfd389c982b53c4b51f538c1973e7
Reviewed-on: https://code.wireshark.org/review/18607
Reviewed-by: Michael Mann <mmann78@netscape.net>
Arjen Zonneveld [Wed, 12 Oct 2016 20:15:59 +0000 (22:15 +0200)]
Add BGP dissector support for draft-heitz-idr-large-community-04
Parses large communities as specified in https://tools.ietf.org/html/draft-heitz-idr-large-community-04
Path Attribute - LARGE_COMMUNITY: 65536:1:1 65536:1:2 65536:1:3
Flags: 0xc0, Optional, Transitive: Optional, Transitive, Complete
1... .... = Optional: Optional
.1.. .... = Transitive: Transitive
..0. .... = Partial: Complete
...0 .... = Length: Regular length
Type Code: LARGE_COMMUNITY (32)
Length: 36
Large communities: 65536:1:1
Global Administrator: 65536
Local Data Part 1: 1
Local Data Part 2: 1
Large communities: 65536:1:2
Global Administrator: 65536
Local Data Part 1: 1
Local Data Part 2: 2
Large communities: 65536:1:3
Global Administrator: 65536
Local Data Part 1: 1
Local Data Part 2: 3
Bug: 13083
Change-Id: I8db0601f621ceb6fb2e170ed9bfc2747091495ee
Reviewed-on: https://code.wireshark.org/review/18172
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Joakim Karlsson [Tue, 1 Nov 2016 18:36:32 +0000 (19:36 +0100)]
gtp: decoding correlation-id
Change-Id: Ie9d399c10b6599bfc463e27ca3cfcb3c06d8b588
Reviewed-on: https://code.wireshark.org/review/18605
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
AndersBroman [Tue, 1 Nov 2016 12:14:47 +0000 (13:14 +0100)]
[GTPv2] Basic dissection of IE Integer Number and value_string updates.
Change-Id: I4b5fa57121b56daf55ac2ae3a966679c5ab874fb
Reviewed-on: https://code.wireshark.org/review/18602
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Tue, 1 Nov 2016 09:00:24 +0000 (10:00 +0100)]
gsm_dtap: fix spelling typo found by lintian
Change-Id: I4f3895195c61b908dd081dd6950b16832d62519f
Reviewed-on: https://code.wireshark.org/review/18600
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Pascal Quantin [Mon, 31 Oct 2016 20:16:37 +0000 (21:16 +0100)]
GPRSCDR: remove obsolete ASN.1 files
Change-Id: I4264f594a9c60c07a400187148d6c68120986c3c
Reviewed-on: https://code.wireshark.org/review/18597
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Jan Spevak [Fri, 28 Oct 2016 13:58:17 +0000 (15:58 +0200)]
GPRS_CDR: update record definitions
Records defined according to 3GPP TS release 14 in new .asn files.
Updated Makefiles and dissector files generated via asn2ws
Change-Id: I6da2782c58178550962f63dbd526b827e0d8394b
Reviewed-on: https://code.wireshark.org/review/18552
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Jaap Keuter [Mon, 31 Oct 2016 07:27:14 +0000 (08:27 +0100)]
PW_ACH: Use proper symbolic names
Collect all used PW Associated Channel Types and use them in the
subdissector table registrations.
Change-Id: I5d196bceefdb4560b1f4388ff86898e316e5e2ae
Reviewed-on: https://code.wireshark.org/review/18590
Reviewed-by: Jaap Keuter <jaap.keuter@xs4all.nl>
Petri-Dish: Jaap Keuter <jaap.keuter@xs4all.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Thomas Wiens [Mon, 31 Oct 2016 09:57:49 +0000 (10:57 +0100)]
bitmask: add missing break statement
Change-Id: Ia9cb54431c8c274c46e299b6a6da8cac14bda88e
Reviewed-on: https://code.wireshark.org/review/18591
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Dario Lombardo [Wed, 26 Oct 2016 09:57:29 +0000 (11:57 +0200)]
sshdump: remove default filter from capture mode.
This allow to capture without any filter.
Bug: 13048
Change-Id: I29fb1a7367375b9f3d83a4f610789ae159735198
Reviewed-on: https://code.wireshark.org/review/18561
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Guy Harris [Mon, 31 Oct 2016 01:47:59 +0000 (18:47 -0700)]
Handle -K, -n, -N, and -u in the common dissection option code.
Also update tfshark to use that code.
Change-Id: Ic03fb8ff48c8bfc460298d180b436e53f0076cbe
Reviewed-on: https://code.wireshark.org/review/18588
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Guy Harris [Mon, 31 Oct 2016 00:37:10 +0000 (17:37 -0700)]
Have the routine that handles dissection options not exit.
Have it return TRUE if the option is OK and FALSE if it isn't, and let
its caller exit as appropriate.
Also, rename it - it's not adding something to a collection, it's just
handling the option.
Change-Id: I41863cbb67b7c257d900d3011609891b9b4a7467
Reviewed-on: https://code.wireshark.org/review/18587
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Guy Harris [Sun, 30 Oct 2016 23:06:24 +0000 (16:06 -0700)]
Don't use proto_tree_add_{uint,uint64}() to add signed integer values.
Change-Id: I8c5506b746f16e5b79d024be5594cb71f95eced1
Reviewed-on: https://code.wireshark.org/review/18584
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Guy Harris [Sun, 30 Oct 2016 21:07:33 +0000 (14:07 -0700)]
Have routines for parsing options that affect dissection.
Have them handle -d, -t, --disable-protocol, --disable-heuristic, and
--enable-heuristic for TShark and both flavors of Wireshark.
Change-Id: I612c276b1f9df8a2092202d23ab3d48be7857e85
Reviewed-on: https://code.wireshark.org/review/18583
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Pascal Quantin [Sun, 30 Oct 2016 18:41:26 +0000 (19:41 +0100)]
POP: replace wmem_strndup by tvb_memcpy
gdd3b977 introduced the use of wmem_strndup to ensure that the string is
NULL terminated.
But it also stops as soon as it finds a NULL character, which can happen
with malformed packets. So let's copy all the bytes with tvb_memcpy and
add manually a NULL character at the end of the buffer for safeness.
Bug: 13074
Change-Id: I9ae65d739a92bc6167e4acfc275e1909f3890815
Reviewed-on: https://code.wireshark.org/review/18582
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Roland Knall [Sun, 30 Oct 2016 18:48:16 +0000 (19:48 +0100)]
InterfaceList: Fix build without pcap
Change-Id: I2b1a955270e7d3fe0097b09517a268263facd1be
Reviewed-on: https://code.wireshark.org/review/18580
Reviewed-by: Roland Knall <rknall@gmail.com>
Gerald Combs [Sun, 30 Oct 2016 15:12:17 +0000 (08:12 -0700)]
[Automatic update for 2016-10-30]
Update manuf, services enterprise-numbers, translations, and other items.
Change-Id: I192e3989204931901b9890366860abdfddf990a4
Reviewed-on: https://code.wireshark.org/review/18577
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Guy Harris [Sun, 30 Oct 2016 09:08:15 +0000 (02:08 -0700)]
Update libssh to 0.7.3.
Also, don't try to uninstall it, as CMake helpfully provides no
uninstall target.
Change-Id: I936a8adeecc3c1f0ca71d044467846ffc33ae7b2
Reviewed-on: https://code.wireshark.org/review/18574
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Graham Bloice [Sat, 29 Oct 2016 17:08:18 +0000 (18:08 +0100)]
dnp3: improve data link layer dissection
Improve the dissection of the data chunks.
Change-Id: Ic87c84f0c3ea2ccceecb376698eed6b2f6a4e614
Reviewed-on: https://code.wireshark.org/review/18566
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Alexis La Goutte [Tue, 18 Oct 2016 15:10:20 +0000 (17:10 +0200)]
wlan_statistics_dialog (Qt): Fix display when there is no packets_
Make sure we don't pass an invalid value to PercentBarDelegate. Make
sure PercentBarDelegate handles invalid values more gracefully.
Change-Id: I18f07542be3432d0fcf5dff479eef2ea4d5e7931
Reviewed-on: https://code.wireshark.org/review/18276
Reviewed-by: Gerald Combs <gerald@wireshark.org>
Petri-Dish: Gerald Combs <gerald@wireshark.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
erikdejong [Thu, 20 Oct 2016 20:14:50 +0000 (22:14 +0200)]
sip: fix Authorization header with mixed quoted parameters
Fix to correctly read unquoted parameter values in Authorization lines.
Code in master branch will look for double quotes as the end of a
parameter value even in case the value is not enclosed in double quotes.
This fix checks if the first character in a value is a double quote in
which case it will scan until a non-escaped finishing double quote is
found to determine the end of the value string. If no double quote is
found as the start of the parameter value it will scan for a comma as
the end of the value string.
Change-Id: I5322caa146d3213bc94ad24528c2fa23cdea10f2
Bug: 13035
Reviewed-on: https://code.wireshark.org/review/18344
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Dario Lombardo [Fri, 28 Oct 2016 21:00:24 +0000 (23:00 +0200)]
hpfeeds: restore channel name in tree.
The channel name is also set in pinfo->match_string to be printed
by the json subdissector.
Change-Id: I9a1c4576ce6d253ef415bda7392b37f2c063c2db
Reviewed-on: https://code.wireshark.org/review/18560
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Michael Mann [Fri, 28 Oct 2016 00:58:23 +0000 (20:58 -0400)]
Allow ampq messages to be bigger than 64k
Also fix a field type conflict noticed in provided capture
Bug: 13050
Change-Id: I3d2643299b6db2729641c72b2e1f054f170b4907
Reviewed-on: https://code.wireshark.org/review/18571
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Joerg Mayer [Sat, 29 Oct 2016 06:59:18 +0000 (08:59 +0200)]
Fix two warnings when compiling with rpcap support on macOS.
One is an unused variable warning turning error, the other is
[ 71%] Building C object ui/CMakeFiles/ui.dir/recent.c.o
/Users/jmayer/worktmp/wireshark/git/ui/recent.c:494:23: error: implicit conversion loses integer precision:
'glong' (aka 'long') to 'gint' (aka 'int') [-Werror,-Wshorten-64-to-32]
rh->auth_type = auth_type;
~ ^~~~~~~~~
1 error generated.
Please review.
Change-Id: If838f8fa1e8a76dc8c6cc78db495befdd527da92
Reviewed-on: https://code.wireshark.org/review/18544
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Alexis La Goutte [Wed, 26 Oct 2016 19:38:35 +0000 (21:38 +0200)]
DHCPv6: Remove check for Relay Data option about Bulk Leasequery reply
Bug: 13025
Change-Id: Ie9c12d4f013b5b88b9cce6a09577bc017a3ed655
Reviewed-on: https://code.wireshark.org/review/18480
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Pascal Quantin [Sat, 29 Oct 2016 22:14:04 +0000 (00:14 +0200)]
OpenFlow 1.4: check length to avoid rewinding offset
Bug: 13071
Change-Id: Ia9d55212fe8423311222330ed516da35ee9f53de
Reviewed-on: https://code.wireshark.org/review/18565
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Pascal Quantin [Sat, 29 Oct 2016 18:15:45 +0000 (20:15 +0200)]
DCERPC: save strings in wmem file scope
Bug: 13072
Change-Id: Ib5f3d91be822a3d7180d95e3299dec978941c1d5
Reviewed-on: https://code.wireshark.org/review/18564
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Graham Bloice [Sat, 29 Oct 2016 15:42:19 +0000 (16:42 +0100)]
dnp3: fix indent and variable names
Change-Id: I86339a47f78c7b54e57896cc42184a27b5326cb0
Reviewed-on: https://code.wireshark.org/review/18563
Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
Yasuyuki Tanaka [Fri, 28 Oct 2016 19:07:48 +0000 (21:07 +0200)]
ieee802154: avoid extra dissection on Payload IEs & Cmd ID
Bug:13068
Change-Id: I4db500030ac2608e57bab4281f44576de9792076
Reviewed-on: https://code.wireshark.org/review/18558
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Yasuyuki Tanaka [Fri, 28 Oct 2016 19:47:38 +0000 (21:47 +0200)]
ieee802154: handle multiple slotframe descriptors properly
Bug: 13069
Change-Id: Ia89b29413b565235c8af40adb5722b9e2528d651
Reviewed-on: https://code.wireshark.org/review/18559
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Jörg Mayer [Sat, 29 Oct 2016 06:34:17 +0000 (06:34 +0000)]
Revert "Instead of supressing the warning of policy 42, set MACOSX_RPATH.":
---------
CMake Warning (dev):
Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake
--help-policy CMP0042" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
MACOSX_RPATH is not specified for the following targets:
epan
wiretap
wscodecs
wsutil
This warning is for project developers. Use -Wno-dev to suppress it.
-----------
This reverts commit
4728bc201bddc34a7834aedf65704c7aa1c9daf1.
Change-Id: I7ea056d56c0352b54be5bebadc35de6173ef593f
Reviewed-on: https://code.wireshark.org/review/18562
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Joerg Mayer [Fri, 28 Oct 2016 09:49:06 +0000 (11:49 +0200)]
Instead of supressing the warning of policy 42, set MACOSX_RPATH.
Fixes picking up the system libpcap instead of the one in /usr/local/lib/
Change-Id: I488c8512fc2cde145107062a6e8b7815ad764a3b
Reviewed-on: https://code.wireshark.org/review/18545
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Mirko Parthey [Thu, 27 Oct 2016 15:43:33 +0000 (17:43 +0200)]
ISAKMP: Rename identifiers for readability
Rename attribute dissecting functions and their local variables to
improve code readability, and adjust white space.
old new
------------------------------------------------------------------
dissect_rohc_supported dissect_rohc_attribute
dissect_transform_ike2_attribute dissect_ike2_transform_attribute
option attribute
optlen value_len
rohc attr_type
transform_attr_type attr_type
cfg_attr_type attr_type
rohc_tree tree
transform_attr_type_tree tree
cfg_attr_type_tree tree
sub_rohc_tree attr_tree
sub_transform_attr_type_tree attr_tree
sub_cfg_attr_type_tree attr_tree
rohc_item attr_item
transform_attr_type_item attr_item
cfg_attr_type_item attr_item
------------------------------------------------------------------
Change-Id: I135e5deb802edc575e7fddd1bb397272aac0888c
Reviewed-on: https://code.wireshark.org/review/18553
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Dario Lombardo [Fri, 28 Oct 2016 15:10:02 +0000 (17:10 +0200)]
hpfeeds: don't pass channel name to heuristic dissector.
Change-Id: Id7dd6e680b1bf798970c513561139bf19891129c
Reviewed-on: https://code.wireshark.org/review/18554
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Roland Knall <rknall@gmail.com>
Yasuyuki Tanaka [Fri, 28 Oct 2016 15:37:59 +0000 (17:37 +0200)]
ICMPv6: resolve type errors on proto_tree_add_bitmask()
Bug: 13066
Change-Id: Ia00441a6eea49c56f75f1757041bc7732ff32d00
Reviewed-on: https://code.wireshark.org/review/18555
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
João Valverde [Wed, 26 Oct 2016 16:07:47 +0000 (17:07 +0100)]
Implement registration of capture dissectors by name
Mirror it after protocol dissector API.
Change-Id: I7985bcfa9e07654c7cf005efec94efc205d7a304
Reviewed-on: https://code.wireshark.org/review/18496
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 26 Oct 2016 19:09:43 +0000 (21:09 +0200)]
LACP: Add HP IRF vendor TLV
Change-Id: I8c0d18f104bf37686b9b53ad9e7d1b9f8a709f5c
Reviewed-on: https://code.wireshark.org/review/18519
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 26 Oct 2016 07:03:07 +0000 (09:03 +0200)]
LACP: Add field for extra bytes (vendor specific)
Change-Id: I0b9725ed8972de3cb84215face3bae65eb27d575
Reviewed-on: https://code.wireshark.org/review/18518
Reviewed-by: Michael Mann <mmann78@netscape.net>
Alexis La Goutte [Wed, 26 Oct 2016 06:04:25 +0000 (08:04 +0200)]
LACP: Remove if(tree) check
and reindent
Change-Id: I3c8835f03e52858e7cb3262043a3fc895b1c4d19
Reviewed-on: https://code.wireshark.org/review/18517
Reviewed-by: Michael Mann <mmann78@netscape.net>
Jaap Keuter [Fri, 28 Oct 2016 05:37:52 +0000 (07:37 +0200)]
MPLS: Mark only Bottom-of-Stack label as flow label
When preference 'Assume bottom of stack label as flow label' is set
all labels are shown as flow labels. This has to be limited to that
MPLS label where Bottom-of-Stack is TRUE.
Change-Id: Iaa8abd095edb7de7f745a78c742a9347d4dbf3d9
Reviewed-on: https://code.wireshark.org/review/18516
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Dario Lombardo [Fri, 28 Oct 2016 10:24:38 +0000 (12:24 +0200)]
Qt: fix typo in layout_preferences_frame.
Change-Id: I3827557445670c4a5b86b1fde0871c8828e91e68
Reviewed-on: https://code.wireshark.org/review/18546
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Harald Welte [Sat, 15 Oct 2016 18:18:16 +0000 (20:18 +0200)]
gsm_abis_om2000: Issue Expert Info when Enable Result != ENABLED
The point of sending an Enable Request is to enable the respective MO.
If the MO responds with any MO state != ENABLED there is something
fishy. Let's inform the user with some Expert Info about it.
Change-Id: Ib33e5dbc37894049b93bb71782787b8c96c04326
Reviewed-on: https://code.wireshark.org/review/18454
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Jeff Morriss [Thu, 27 Oct 2016 21:36:39 +0000 (17:36 -0400)]
automake: separate crypt C and header files.
Only pass the C files files to checkAPIs (to match cmake and to allow
checkAPIs to pass this directory).
Change-Id: I305aeaaf1882061bad166957ae83383a0f35dfb7
Reviewed-on: https://code.wireshark.org/review/18513
Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michael Mann <mmann78@netscape.net>
Pascal Quantin [Fri, 28 Oct 2016 12:41:40 +0000 (14:41 +0200)]
ANSI IS-637 A: fix decoding of IA5 SMS
Give the right buffer to the decoding function
Bug: 13065
Change-Id: I0e41e04fb68602d95ea6f060c1a37c8b8596134d
Reviewed-on: https://code.wireshark.org/review/18548
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Joakim Karlsson [Thu, 27 Oct 2016 19:18:13 +0000 (21:18 +0200)]
diameter: improvement of AVP 18
Will now show country and operator
Change-Id: Ic16623c226228ab0c3e31d33cda81953c80551d6
Reviewed-on: https://code.wireshark.org/review/18512
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
João Valverde [Thu, 27 Oct 2016 08:24:06 +0000 (09:24 +0100)]
make-version: Clean up handling of VCSVERSION
Change-Id: If8228267da4a9290f5abf99c5ac518c3dec0a283
Reviewed-on: https://code.wireshark.org/review/18443
Petri-Dish: João Valverde <j@v6e.pt>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
Alexis La Goutte [Thu, 27 Oct 2016 16:22:30 +0000 (18:22 +0200)]
btavdtp: fix fix spelling typo found by lintian
Change-Id: I15d4343787a7c6b1c16ca8aa77ef2ddd159e6ef0
Reviewed-on: https://code.wireshark.org/review/18543
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:19:09 +0000 (18:19 +0200)]
btatt: fix fix spelling typo found by lintian
Change-Id: I405e73d15badfa98c311391f22c57314e83bb9d0
Reviewed-on: https://code.wireshark.org/review/18542
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:16:13 +0000 (18:16 +0200)]
bthci_cmd: fix fix spelling typo found by lintian
Change-Id: Ic7fd85db374df24358e53be66cd2432dca6a23d2
Reviewed-on: https://code.wireshark.org/review/18541
Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:15:04 +0000 (18:15 +0200)]
carp: fix fix spelling typo found by lintian
Change-Id: I6a6b305863d5ecf2de7acad485d8079dca6993f4
Reviewed-on: https://code.wireshark.org/review/18540
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:13:56 +0000 (18:13 +0200)]
glusterfs: fix fix spelling typo found by lintian
Change-Id: I8f9f7b237b0191bbccfd65e3f70bf3f638a7c5ad
Reviewed-on: https://code.wireshark.org/review/18539
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:13:00 +0000 (18:13 +0200)]
diameter_3gpp: fix fix spelling typo found by lintian
Change-Id: Ibee969abd9d393a7d5b4c6ab5b2eb204f54654a1
Reviewed-on: https://code.wireshark.org/review/18538
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:09:35 +0000 (18:09 +0200)]
FIX: fix fix spelling typo found by lintian
Change-Id: I090457663759a5ee012402ef746d358aacfbe08c
Reviewed-on: https://code.wireshark.org/review/18537
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:07:26 +0000 (18:07 +0200)]
RSVP: fix fix spelling typo found by lintian
Change-Id: I191473b1b95b293665b5617721c33ce978f5ce08
Reviewed-on: https://code.wireshark.org/review/18536
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:06:07 +0000 (18:06 +0200)]
gsm_rlcmac: fix fix spelling typo found by lintian
Change-Id: I949067c5f18f48ba954e54e6ca0c224744f85e41
Reviewed-on: https://code.wireshark.org/review/18535
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:05:03 +0000 (18:05 +0200)]
hartip: fix fix spelling typo found by lintian
Change-Id: I89798a1dc1931ce44bc511da90726ff27ddfe583
Reviewed-on: https://code.wireshark.org/review/18534
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:04:37 +0000 (18:04 +0200)]
usb-audio: fix fix spelling typo found by lintian
Change-Id: I853bc068cfca477c2ec5968d8b9a17873ec8011c
Reviewed-on: https://code.wireshark.org/review/18533
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:02:29 +0000 (18:02 +0200)]
ieee802154: fix fix spelling typo found by lintian
Change-Id: I0d3d56447aab6f012338016875bc05a9eaf3a2be
Reviewed-on: https://code.wireshark.org/review/18532
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:01:53 +0000 (18:01 +0200)]
RADIUS: fix fix spelling typo found by lintian
Change-Id: Iea8c96064c39d0e4aee5db6c72a8c120c56e495e
Reviewed-on: https://code.wireshark.org/review/18531
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:00:47 +0000 (18:00 +0200)]
homeplug-av: fix fix spelling typo found by lintian
Change-Id: If75ea5e7e9ce16d270244f2a5aac86ad3abb30eb
Reviewed-on: https://code.wireshark.org/review/18529
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:59:46 +0000 (17:59 +0200)]
NTLMSSP: fix fix spelling typo found by lintian
Change-Id: I1f4c9340fcb33e2d92fc3d85d2e212da0ab6e1e2
Reviewed-on: https://code.wireshark.org/review/18528
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:59:08 +0000 (17:59 +0200)]
WAI: fix fix spelling typo found by lintian
Change-Id: I3d468c3b1ff0eb79136bc07859442ebd184c456f
Reviewed-on: https://code.wireshark.org/review/18527
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:58:39 +0000 (17:58 +0200)]
SSL: fix fix spelling typo found by lintian
Change-Id: Ied94f5fa5858fd6d9da7183eb05e32430554ec33
Reviewed-on: https://code.wireshark.org/review/18526
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:57:17 +0000 (17:57 +0200)]
mausb: fix fix spelling typo found by lintian
Change-Id: I23c5b35d4d55c3d1c78b9a631a1eb728ecf365fa
Reviewed-on: https://code.wireshark.org/review/18525
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:56:18 +0000 (17:56 +0200)]
MIH: fix fix spelling typo found by lintian
Change-Id: Ie8000bfaf086582f36dd88a06cb0b01e0a377096
Reviewed-on: https://code.wireshark.org/review/18524
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:55:26 +0000 (17:55 +0200)]
OSPF: fix fix spelling typo found by lintian
Change-Id: I8058a9277163fbcdb5ad2e67b44bf0d4e3ea2283
Reviewed-on: https://code.wireshark.org/review/18523
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 16:01:16 +0000 (18:01 +0200)]
mac-lte: fix fix spelling typo found by lintian
Change-Id: Ifeff48a14f06e58a4e667d5b9f343b5bfc61911a
Reviewed-on: https://code.wireshark.org/review/18530
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:54:41 +0000 (17:54 +0200)]
CMAkelists: fix typo on comment
Change-Id: I572ebbbae9ac91e2d566a39d0dae462bc40bcac8
Reviewed-on: https://code.wireshark.org/review/18522
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:53:34 +0000 (17:53 +0200)]
quic: fix fix spelling typo found by lintian
Change-Id: Ifeadd5f7b9760e0ce2a58b2c1a3c497bc5f4cda0
Reviewed-on: https://code.wireshark.org/review/18521
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Alexis La Goutte [Thu, 27 Oct 2016 15:51:48 +0000 (17:51 +0200)]
rpcrdma: fix fix spelling typo found by lintian
Change-Id: If057ecf07b6707a5b72b8a29ccf6388b16f4826a
Reviewed-on: https://code.wireshark.org/review/18520
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Pascal Quantin [Thu, 27 Oct 2016 19:28:17 +0000 (21:28 +0200)]
POP: ensure that line buffer is NULL terminated
Bug: 13054
Change-Id: Id3bdbaa1b8d6d445daaa66d922bac74ec097b79b
Reviewed-on: https://code.wireshark.org/review/18511
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Roland Knall [Tue, 25 Oct 2016 12:27:56 +0000 (14:27 +0200)]
ManageInterfacesDialog: New handling of pipes
This moves the handling of pipes to the new InterfaceTreeModel as well.
It also includes a new PathChooserDelegate and cache handling for adding
data to an interface list without putting it into storage
Change-Id: Id255a81161b4da517e26127abe8ea7f5eb36d55a
Reviewed-on: https://code.wireshark.org/review/18497
Reviewed-by: Roland Knall <rknall@gmail.com>
Pascal Quantin [Thu, 27 Oct 2016 21:41:51 +0000 (23:41 +0200)]
merge.c: do not give a NULL pointer when saving SHB comment option
Bug: 13060
Change-Id: Ib3dd019f73305e4006b312d324502e4a138c6a16
Reviewed-on: https://code.wireshark.org/review/18514
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
Dario Lombardo [Mon, 24 Oct 2016 14:15:22 +0000 (16:15 +0200)]
checkAPI: move atoi from soft-deprecated to prohibited.
The atoi function has been completely removed from the tree.
It's still present in the GTK code, but, since GTK compilation
has been removed in the default, checkAPI target doesn't complain,
as well as the buildbot.
Change-Id: I436d6f333b99b9188734155c1f92273420354947
Reviewed-on: https://code.wireshark.org/review/18432
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
git.samba.org / metze / wireshark / wip.git / log