6 years agoDon't call gtk_widget_unregister_window() in bytes_view_unrealize() after GTK+ 3.8.0
Balint Reczey [Fri, 31 May 2013 20:57:07 +0000 (20:57 -0000)]
Don't call gtk_widget_unregister_window() in bytes_view_unrealize() after GTK+ 3.8.0

to prevent double invocation causing crash.

This fixes .
The patch is from Jakub Zawadzki.

svn path=/trunk/; revision=49655

6 years agoAdd UDT dissector. Bug 8741 (
Michael Mann [Fri, 31 May 2013 20:37:46 +0000 (20:37 -0000)]
Add UDT dissector.  Bug 8741 (

From Chas Williams

svn path=/trunk/; revision=49654

6 years agoReport the operation number in all places where we note that we don't
Guy Harris [Fri, 31 May 2013 19:00:28 +0000 (19:00 -0000)]
Report the operation number in all places where we note that we don't
know about a given operation number.

svn path=/trunk/; revision=49653

6 years agoFix the integer overflow case Jakub caught in
Evan Huus [Fri, 31 May 2013 13:08:03 +0000 (13:08 -0000)]
Fix the integer overflow case Jakub caught in

Also use indentation consistent with the rest of the file.

svn path=/trunk/; revision=49652

6 years agoCheck USB CCID length to see if subdissectors should be called instead of doing it...
Michael Mann [Fri, 31 May 2013 12:54:35 +0000 (12:54 -0000)]
Check USB CCID length to see if subdissectors should be called instead of doing it blindly (which could lead to malformed packets).  Bug 8735 (

Also minor cleanup of column info.

svn path=/trunk/; revision=49651

6 years agoUse #ifdefs in the XML to include or exclude the packet-editor and
Guy Harris [Fri, 31 May 2013 07:06:10 +0000 (07:06 -0000)]
Use #ifdefs in the XML to include or exclude the packet-editor and
capture menu items, rather than hiding them at run time.

For the capture menu items, translate the GtkAction callback calling
sequence to the normal widget callback calling sequence with individual
routines for each action, rather than a generic translator.

svn path=/trunk/; revision=49649

6 years agoDon't intentionally use -1 as an hfindex: while only naughty before, with the
Jeff Morriss [Fri, 31 May 2013 02:27:40 +0000 (02:27 -0000)]
Don't intentionally use -1 as an hfindex: while only naughty before, with the
changes from r49644 you'll get complaints about the hf being unregistered...

Note that this code also intentionally passes -1 as an ett_index.  It doesn't
currently complain so I'm leaving it alone for now...

svn path=/trunk/; revision=49648

6 years agoIOSTAT: plot LOAD y-axis in number of I/O not number of I/O times 1000
Ronnie Sahlberg [Fri, 31 May 2013 02:14:19 +0000 (02:14 -0000)]
IOSTAT: plot LOAD y-axis in number of I/O  not number of I/O times 1000

svn path=/trunk/; revision=49647

6 years agoOh yeah, -R is now -Y in trunk.
Jeff Morriss [Fri, 31 May 2013 02:03:03 +0000 (02:03 -0000)]
Oh yeah, -R is now -Y in trunk.

svn path=/trunk/; revision=49646

6 years agoGet rid of most of the if(tree) checks: the proto_tree_add_*() functions
Jeff Morriss [Fri, 31 May 2013 01:46:40 +0000 (01:46 -0000)]
Get rid of most of the if(tree) checks: the proto_tree_add_*() functions
don't need them any more and, as shown in
we really want to check if we're looking at something beyond the end of the TVB
(in order to break out of very long loops).

svn path=/trunk/; revision=49645

6 years ago(Finally!) check in part of Didier's patch to fix
Jeff Morriss [Fri, 31 May 2013 01:46:28 +0000 (01:46 -0000)]
(Finally!) check in part of Didier's patch to fix
(TRY_TO_FAKE_THIS_ITEM disables bounds errors):

Before calling TRY_TO_FAKE_THIS_ITEM() check if the length given (or, in
the case of FT_UINT_{STRING,BYTES}, the length we retrieve from the TVB)
exceeds what's left in the TVB.

Do this only for proto_tree_add_item() for now (it's the most commonly used
and thus the biggest trouble maker in this area).

Similar changes for other APIs will come later (if nothing blows up).  Despite
the fuzz failures this bug has caused I'm not sure about back-porting it...

svn path=/trunk/; revision=49644

6 years agoAs discussed in :
Jeff Morriss [Fri, 31 May 2013 01:38:55 +0000 (01:38 -0000)]
As discussed in :

Running tshark with a read filter ("-R") and without building the full tree
("-V") causes it to run into some more bugs (usually loops adding more than
100000 items to the tree).  Add some (commented out for now) code to do

svn path=/trunk/; revision=49643

6 years agoPut back some conversation list and endpoint list statistics presumably
Guy Harris [Thu, 30 May 2013 22:40:31 +0000 (22:40 -0000)]
Put back some conversation list and endpoint list statistics presumably
lost in the conversion to GTKUiManager.

svn path=/trunk/; revision=49642

6 years agoAdd a stat group REGISTER_STAT_GROUP_TELEPHONY_GSM for the Telephony/GSM
Guy Harris [Thu, 30 May 2013 22:32:10 +0000 (22:32 -0000)]
Add a stat group REGISTER_STAT_GROUP_TELEPHONY_GSM for the Telephony/GSM
statistics menu.

Have the CAMEL counter register itself in that menu, rather than having
main_menubar.c create the menu item for it.

svn path=/trunk/; revision=49641

6 years agoAdd Doxygen boilerplate for some of our core modules and data structures.
Gerald Combs [Thu, 30 May 2013 22:20:21 +0000 (22:20 -0000)]
Add Doxygen boilerplate for some of our core modules and data structures.

svn path=/trunk/; revision=49640

6 years agoInstall fop and asciidoc too
Jeff Morriss [Thu, 30 May 2013 21:47:24 +0000 (21:47 -0000)]
Install fop and asciidoc too

svn path=/trunk/; revision=49639

6 years agoOops: revert 49636. We tell a2x to use fop to generate the PDFs.
Jeff Morriss [Thu, 30 May 2013 21:41:17 +0000 (21:41 -0000)]
Oops: revert 49636. We tell a2x to use fop to generate the PDFs.

svn path=/trunk/; revision=49638

6 years agoAdd SEL RTAC to list of new protocols.
Jeff Morriss [Thu, 30 May 2013 21:37:26 +0000 (21:37 -0000)]
Add SEL RTAC to list of new protocols.

svn path=/trunk/; revision=49637

6 years agoWhich release notes targets we can build no longer depends on whether we HAVE_FOP.
Jeff Morriss [Thu, 30 May 2013 21:33:04 +0000 (21:33 -0000)]
Which release notes targets we can build no longer depends on whether we HAVE_FOP.

svn path=/trunk/; revision=49636

6 years agoFrom Chris Bontje via :
Pascal Quantin [Thu, 30 May 2013 20:51:18 +0000 (20:51 -0000)]
From Chris Bontje via :
SEL RTAC (Real Time Automation Controller) EIA-232 Serial-Line Dissection

svn path=/trunk/; revision=49635

6 years agoUpgrade user manual
Pascal Quantin [Thu, 30 May 2013 20:13:56 +0000 (20:13 -0000)]
Upgrade user manual

svn path=/trunk/; revision=49634

6 years agoUse gtk_widget_register_window() and gtk_widget_unregister_window()
Balint Reczey [Thu, 30 May 2013 16:42:32 +0000 (16:42 -0000)]
Use gtk_widget_register_window() and gtk_widget_unregister_window()

instead of deprecated gdk_window_set_user_data() for GTK+ 3 >= 3.8

svn path=/trunk/; revision=49633

6 years agoGet rid of C++/C99-style comments.
Jeff Morriss [Thu, 30 May 2013 12:54:24 +0000 (12:54 -0000)]
Get rid of C++/C99-style comments.

svn path=/trunk/; revision=49632

6 years agoRename "http.response_ts" to "http.time" to be inline with other response time fiels...
Sake Blok [Thu, 30 May 2013 07:16:04 +0000 (07:16 -0000)]
Rename "http.response_ts" to "http.time" to be inline with other response time fiels (like dns.time and smb.time etc)

svn path=/trunk/; revision=49630

6 years agoFrom Cal Turney:
Anders Broman [Thu, 30 May 2013 05:30:08 +0000 (05:30 -0000)]
From Cal Turney:
Preferences with trailing commas are ignored.

svn path=/trunk/; revision=49629

6 years agoFrom Chris Pane:
Anders Broman [Thu, 30 May 2013 05:24:37 +0000 (05:24 -0000)]
From Chris Pane:
Updates to IEEE 1722.1 dissector for Draft 23R2.

svn path=/trunk/; revision=49628

6 years doesn't need to be executable (it is sourced, not executed); remove...
Jeff Morriss [Thu, 30 May 2013 00:36:58 +0000 (00:36 -0000)] doesn't need to be executable (it is sourced, not executed); remove the svn:executable property.

svn path=/trunk/; revision=49626

6 years agoExit if we can't load the library.
Jeff Morriss [Thu, 30 May 2013 00:35:46 +0000 (00:35 -0000)]
Exit if we can't load the library.

svn path=/trunk/; revision=49625

6 years agoBatch (some of) the plugins to filterable expert infos. The Profinet plugin started...
Michael Mann [Wed, 29 May 2013 23:41:33 +0000 (23:41 -0000)]
Batch (some of) the plugins to filterable expert infos.  The Profinet plugin started to get a bit complex in determining filter names (especially the DCOM stuff), so I'll leave that to someone more familiar with the protocol.

svn path=/trunk/; revision=49624

6 years agoFix the infinite recursion problem reported in
Jeff Morriss [Wed, 29 May 2013 22:43:20 +0000 (22:43 -0000)]
Fix the infinite recursion problem reported in :

We can't solely rely on the port in the URI to determine whether we will be
recursively called by decode_tcp_ports().  Instead also check the conversation
entry too: if we find that we are the subdissector for this conversation
(which we might be--without the port being in our list of ports--if we
heuristically picked up the conversation or the user did Decode-As),
just bail out and dissect the payload as data.

svn path=/trunk/; revision=49623

6 years agoFix and clarify name resolution preference tooltips. Print the
Gerald Combs [Wed, 29 May 2013 18:01:03 +0000 (18:01 -0000)]
Fix and clarify name resolution preference tooltips. Print the
description before the name+type since that's presumably what people
are looking for.

svn path=/trunk/; revision=49622

6 years agoAdjust some fonts and colors.
Gerald Combs [Wed, 29 May 2013 17:58:01 +0000 (17:58 -0000)]
Adjust some fonts and colors.

svn path=/trunk/; revision=49621

6 years agoIf using cygwin, there is no pbcopy or xsel, but we do have putclip.
Chris Maynard [Wed, 29 May 2013 15:59:19 +0000 (15:59 -0000)]
If using cygwin, there is no pbcopy or xsel, but we do have putclip.

svn path=/trunk/; revision=49618

6 years agowslua: Adda a wtap_encaps name to replace wtap which is too generic.
Luis Ontanon [Wed, 29 May 2013 15:52:25 +0000 (15:52 -0000)]
wslua: Adda a wtap_encaps name to replace wtap which is too generic.

svn path=/trunk/; revision=49617

6 years agoCorrect the c-ares directory name in the clean_setup target.
Chris Maynard [Wed, 29 May 2013 15:41:57 +0000 (15:41 -0000)]
Correct the c-ares directory name in the clean_setup target.

svn path=/trunk/; revision=49616

6 years agoBugfix crash when 'SCTP' -> 'Prepare Filter for this Association' has no associations...
Michael Mann [Wed, 29 May 2013 13:50:45 +0000 (13:50 -0000)]
Bugfix crash when 'SCTP' -> 'Prepare Filter for this Association' has no associations.  Bug 8731 (

Dialog (wants to) pop up noting no associations, but sctp_set_filter() wants to press on assuming there is an association. Added NULL check to prevent assumption.

svn path=/trunk/; revision=49610

6 years agoFix what looks to be a typo in definition of wtap_encaps.
Jeff Morriss [Wed, 29 May 2013 13:03:52 +0000 (13:03 -0000)]
Fix what looks to be a typo in definition of wtap_encaps.

svn path=/trunk/; revision=49609

6 years ago fix for bug 7465
Luis Ontanon [Wed, 29 May 2013 06:50:28 +0000 (06:50 -0000)]
 fix for bug 7465
add a wiretap file type table to init.lua

svn path=/trunk/; revision=49608

6 years agoFix the fuzz failure reported in
Jeff Morriss [Wed, 29 May 2013 03:19:31 +0000 (03:19 -0000)]
Fix the fuzz failure reported in :

Make proto_tree_children_foreach() NULL-tree safe.  Crash is new since r49602
took out an if(tree).

svn path=/trunk/; revision=49607

6 years agoIn ICMP taps, don't use g_slist_insert_sorted (which results in
Evan Huus [Tue, 28 May 2013 23:20:44 +0000 (23:20 -0000)]
In ICMP taps, don't use g_slist_insert_sorted (which results in
n^2 time on the number of packets). Just prepend to the list, then sort
it when we actually need to calculate the statistics.

Should fix

svn path=/trunk/; revision=49606

6 years agoAs described in the thread starting with:
Jeff Morriss [Tue, 28 May 2013 22:33:33 +0000 (22:33 -0000)]
As described in the thread starting with:

The PC and SSN are mandatory for the SCCP "user table" to work.  Complain if
they are not given.

svn path=/trunk/; revision=49605

6 years agoUse the local libtool rather than whatever is in PATH. This works just
Evan Huus [Tue, 28 May 2013 22:29:02 +0000 (22:29 -0000)]
Use the local libtool rather than whatever is in PATH. This works just
the same everywhere I've tested except my mac setup where it works better
(since the libtool in PATH doesn't have --mode=execute for some strange reason).

This is fairly experimental - feel free to revert if it breaks something.

svn path=/trunk/; revision=49604

6 years agoAdd some info to make it easier to see when SI config changes:
Martin Mathieson [Tue, 28 May 2013 22:11:56 +0000 (22:11 -0000)]
Add some info to make it easier to see when SI config changes:
- show systemInfoModification in info column (and expert info), also
  show number of UEs paged
- add expert item when systemInfoValueTag changes
- for MIB, add SFN to info column

svn path=/trunk/; revision=49603

6 years agoBatch of filterable expert infos. This (mostly) completes the non-ASN.1 list of...
Michael Mann [Tue, 28 May 2013 03:11:44 +0000 (03:11 -0000)]
Batch of filterable expert infos.  This (mostly) completes the non-ASN.1 list of (built-in) dissectors that only had a small handful of add_expert_info_format calls.

svn path=/trunk/; revision=49602

6 years agoRemove unused variable caught by recent GCC
Evan Huus [Tue, 28 May 2013 00:48:09 +0000 (00:48 -0000)]
Remove unused variable caught by recent GCC

svn path=/trunk/; revision=49601

6 years agoBatch of filterable expert infos
Michael Mann [Mon, 27 May 2013 23:21:11 +0000 (23:21 -0000)]
Batch of filterable expert infos

svn path=/trunk/; revision=49600

6 years agoPostfix FT_NONE fields with "_element" string to reduce number of incompatible filter...
Pascal Quantin [Mon, 27 May 2013 20:26:49 +0000 (20:26 -0000)]
Postfix FT_NONE fields with "_element" string to reduce number of incompatible filters in ASN.1 dissectors

svn path=/trunk/; revision=49599

6 years agoFrom Chris Hellberg via :
Pascal Quantin [Mon, 27 May 2013 18:58:24 +0000 (18:58 -0000)]
From Chris Hellberg via :
M3UA dissector RFC display update

svn path=/trunk/; revision=49598

6 years agoFix compiler warning
Michael Mann [Mon, 27 May 2013 17:35:21 +0000 (17:35 -0000)]
Fix compiler warning

svn path=/trunk/; revision=49597

6 years agoBatch of filterable expert infos
Michael Mann [Mon, 27 May 2013 17:30:43 +0000 (17:30 -0000)]
Batch of filterable expert infos

svn path=/trunk/; revision=49596

6 years agoFrom jamie Neufeld:
Anders Broman [Mon, 27 May 2013 16:27:50 +0000 (16:27 -0000)]
From jamie Neufeld:
Add an option to selct if payload is to be dissected as SYNC.

svn path=/trunk/; revision=49595

6 years agoFrom Jouni Malinen via Wi...
Alexis La Goutte [Mon, 27 May 2013 16:20:57 +0000 (16:20 -0000)]
From Jouni Malinen via Wi-Fi Display dissector

This matches the style used for Wi-Fi Display and gets rid of a minimal
header file for functionality that extends packet-ieee80211.c.

svn path=/trunk/; revision=49594

6 years agoFrom Jouni Malinen via Wi...
Alexis La Goutte [Mon, 27 May 2013 16:20:29 +0000 (16:20 -0000)]
From Jouni Malinen via Wi-Fi Display dissector

The attached patch adds initial support for dissecting Wi-Fi Display information element

svn path=/trunk/; revision=49593

6 years agoSCSI Add decoding of Block Device Characteristics VPD page
Ronnie Sahlberg [Mon, 27 May 2013 03:44:06 +0000 (03:44 -0000)]
SCSI Add decoding of Block Device Characteristics VPD page

svn path=/trunk/; revision=49592

6 years agoSCSI: Print the INQUIRY EVPD page name in the info column
Ronnie Sahlberg [Mon, 27 May 2013 03:13:31 +0000 (03:13 -0000)]
SCSI: Print the INQUIRY EVPD page name in the info column

svn path=/trunk/; revision=49591

6 years agoSCSI: add dissection of Tiemout Descriptor for REPORT SUPPORTED OPCODES
Ronnie Sahlberg [Mon, 27 May 2013 01:09:49 +0000 (01:09 -0000)]
SCSI: add dissection of Tiemout Descriptor for REPORT SUPPORTED OPCODES

svn path=/trunk/; revision=49590

6 years agoSCSI: Add dissection of the data-out buffer for SANITIZE service action OVERWRITE
Ronnie Sahlberg [Sun, 26 May 2013 18:38:56 +0000 (18:38 -0000)]
SCSI: Add dissection of the data-out buffer for SANITIZE service action OVERWRITE

svn path=/trunk/; revision=49589

6 years ago[Automatic manuf, services and enterprise-numbers update for 2013-05-26]
Gerald Combs [Sun, 26 May 2013 14:03:39 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2013-05-26]

svn path=/trunk/; revision=49585

6 years agoBatch of filterable expert infos.
Michael Mann [Sun, 26 May 2013 03:29:07 +0000 (03:29 -0000)]
Batch of filterable expert infos.

svn path=/trunk/; revision=49584

6 years agoFirst batch of doxygen for wmem. Remove some things from README.wmem now that
Evan Huus [Sun, 26 May 2013 02:40:40 +0000 (02:40 -0000)]
First batch of doxygen for wmem. Remove some things from README.wmem now that
they're in doxygen instead.

svn path=/trunk/; revision=49583

6 years agoSCSI: Add basic decoding of SANITIZE opcode
Ronnie Sahlberg [Sat, 25 May 2013 22:47:10 +0000 (22:47 -0000)]
SCSI: Add basic decoding of SANITIZE opcode

svn path=/trunk/; revision=49582

6 years agoBatch of filterable expert_infos.
Michael Mann [Sat, 25 May 2013 17:06:40 +0000 (17:06 -0000)]
Batch of filterable expert_infos.

svn path=/trunk/; revision=49581

6 years agoObject::connect: No such signal WiresharkApplication::captureCaptureUpdateContinue...
Alexis La Goutte [Sat, 25 May 2013 15:20:42 +0000 (15:20 -0000)]
Object::connect: No such signal WiresharkApplication::captureCaptureUpdateContinue(capture_options*) Object::connect: (sender name: 'qtshark')

An omission with latest change in capture_session...

svn path=/trunk/; revision=49579

6 years agoUse -DBUILD_qtshark=YES for build qtshark with cmake (May be set by default ON qtshar...
Alexis La Goutte [Sat, 25 May 2013 15:20:34 +0000 (15:20 -0000)]
Use -DBUILD_qtshark=YES for build qtshark with cmake (May be set by default ON qtshark with cmake ?)

svn path=/trunk/; revision=49578

6 years agoApply change of Bug 8706 ( "Stream" should be changed to "Follow Stream" in the ...
Alexis La Goutte [Sat, 25 May 2013 15:20:23 +0000 (15:20 -0000)]
Apply change of Bug 8706 ( "Stream" should be changed to "Follow Stream" in the 'Font and Colors' dialog ) / revision 49488 to Qtshark

svn path=/trunk/; revision=49577

6 years agoFrom Fabio Tarabelloni: more minor formatting and comment fixes.
Evan Huus [Sat, 25 May 2013 13:01:25 +0000 (13:01 -0000)]
From Fabio Tarabelloni: more minor formatting and comment fixes.

svn path=/trunk/; revision=49576

6 years agoFrom Fabio Tarabelloni: fix copy-pasted comment.
Evan Huus [Sat, 25 May 2013 12:25:51 +0000 (12:25 -0000)]
From Fabio Tarabelloni: fix copy-pasted comment.

svn path=/trunk/; revision=49575

6 years agoUpdate the release notes for the changes since 1.10 branched: one new
Evan Huus [Sat, 25 May 2013 03:46:08 +0000 (03:46 -0000)]
Update the release notes for the changes since 1.10 branched: one new
protocol, one file format, and Michael's filterable expert info.

Hopefully keeping this up to date as we go will make Gerald's job a bit
easier when the next release rolls around.

svn path=/trunk/; revision=49574

6 years agoAdd filterable expert info.
Michael Mann [Sat, 25 May 2013 03:27:31 +0000 (03:27 -0000)]
Add filterable expert info.

svn path=/trunk/; revision=49573

6 years agoMenu labels aren't paths, they're just the strings shown to the user for
Guy Harris [Sat, 25 May 2013 02:37:51 +0000 (02:37 -0000)]
Menu labels aren't paths, they're just the strings shown to the user for
the menu item.

svn path=/trunk/; revision=49572

6 years agoFrom Fabio Tarabelloni via
Evan Huus [Sat, 25 May 2013 01:45:16 +0000 (01:45 -0000)]
From Fabio Tarabelloni via

ZigBee ZCL OnOff cluster dissection.

Also, fix decryption of APS commands.

svn path=/trunk/; revision=49571

6 years agoAdd Mike Garratt to the list of authors for (at the very least) his contributions...
Chris Maynard [Sat, 25 May 2013 00:54:30 +0000 (00:54 -0000)]
Add Mike Garratt to the list of authors for (at the very least) his contributions from bug6645, committed in r46083.

svn path=/trunk/; revision=49570

6 years agoEdit comments
Anders Broman [Fri, 24 May 2013 22:38:53 +0000 (22:38 -0000)]
Edit comments

svn path=/trunk/; revision=49569

6 years agouse key in all p_add_proto_data() p_get_proto_data()
Anders Broman [Fri, 24 May 2013 22:38:25 +0000 (22:38 -0000)]
use key in all p_add_proto_data() p_get_proto_data()

svn path=/trunk/; revision=49568

6 years agoFrom LI Hai via :
Pascal Quantin [Fri, 24 May 2013 20:55:42 +0000 (20:55 -0000)]
From LI Hai via :
Add MAC-DATA support to TETRA dissector and other minor improvements

svn path=/trunk/; revision=49567

6 years agoBluetooth: Highlight correct bytes in some SDP trees (Part 2). Bug 8700 (https:...
Michael Mann [Fri, 24 May 2013 19:40:09 +0000 (19:40 -0000)]
Bluetooth: Highlight correct bytes in some SDP trees (Part 2).  Bug 8700 (

svn path=/trunk/; revision=49566

6 years agoEnsure most severe is displayed in expert column. Bug 7733 (https://bugs.wireshark...
Michael Mann [Fri, 24 May 2013 19:23:36 +0000 (19:23 -0000)]
Ensure most severe is displayed in expert column.  Bug 7733 (


svn path=/trunk/; revision=49565

6 years agoexpert_add_info(): we can't use va_start()/va_end() so don't try to use a va_list...
Jeff Morriss [Fri, 24 May 2013 19:14:09 +0000 (19:14 -0000)]
expert_add_info(): we can't use va_start()/va_end() so don't try to use a va_list (which isn't used by the called function) either.

svn path=/trunk/; revision=49564

6 years agoexpert_add_info() doesn't take a variable number of args; don't use va_start()/va_end().
Jeff Morriss [Fri, 24 May 2013 18:15:09 +0000 (18:15 -0000)]
expert_add_info() doesn't take a variable number of args; don't use va_start()/va_end().

svn path=/trunk/; revision=49563

6 years agoexpert_add_info_format_text(): use the correct argument numbers in G_GNUC_PRINTF().
Jeff Morriss [Fri, 24 May 2013 18:12:00 +0000 (18:12 -0000)]
expert_add_info_format_text(): use the correct argument numbers in G_GNUC_PRINTF().

svn path=/trunk/; revision=49562

6 years agoUse new expert info API in idl dissectors. These generated about 50% of the add_expe...
Michael Mann [Fri, 24 May 2013 18:09:57 +0000 (18:09 -0000)]
Use new expert info API in idl dissectors.  These generated about 50% of the add_expert_info_format() calls.

svn path=/trunk/; revision=49561

6 years agofirst batch of dissectors to use the new expert info API.
Michael Mann [Fri, 24 May 2013 18:02:54 +0000 (18:02 -0000)]
first batch of dissectors to use the new expert info API.

svn path=/trunk/; revision=49560

6 years agoAdd expert info configuration framework. Bug 2412 (
Michael Mann [Fri, 24 May 2013 17:59:36 +0000 (17:59 -0000)]
Add expert info configuration framework.  Bug 2412 (

Expert info "fields" can now be registered/addressed by name.  Right now, the basic framework allows expert info fields to become "display filters".  However more could be done, like user preferences overriding default severity level, speeding up expert info dialog load time by not needing to redissect a file, etc.

Long term goal is to have all expert_info filterable and have the functionality of expert_add_info_format() include the "registered index".  expert_add_info_format_text() is the workaround until all current calls to expert_add_info_format() have been updated with either expert_add_info() or expert_add_info_format_text().  Then the remaining expert_add_info_format_text() will be renamed to expert_add_info_format().

svn path=/trunk/; revision=49559

6 years agoHow to mess with a keyboard...
Pascal Quantin [Fri, 24 May 2013 17:43:36 +0000 (17:43 -0000)]
How to mess with a keyboard...

svn path=/trunk/; revision=49558

6 years agoOne more compilation fix for gcc 4.3.2 ('toi' may be used uninitialized in this function)
Pascal Quantin [Fri, 24 May 2013 17:36:19 +0000 (17:36 -0000)]
One more compilation fix for gcc 4.3.2 ('toi' may be used uninitialized in this function)

svn path=/trunk/; revision=49557

6 years agoRemove unused function parameter, rename variable to avoid shadowing.
Evan Huus [Fri, 24 May 2013 17:24:58 +0000 (17:24 -0000)]
Remove unused function parameter, rename variable to avoid shadowing.

svn path=/trunk/; revision=49556

6 years agoOverhauled the RMT dissectors. Not sure each needs its own file, but since this...
Michael Mann [Fri, 24 May 2013 17:06:23 +0000 (17:06 -0000)]
Overhauled the RMT dissectors.  Not sure each needs its own file, but since this involves multiple RFCs, they remain split out by that.  More are now a "pure" dissector and not a "decoding function hook".

Some Notes:
1. Converted to "new style" dissectors with data being passed between dissectors
2. Combined header files into one since there wasn't much that should have really been in the header files.  Implemented functionality is in c module of respective dissector.

Not sure if LCT preferences should just be in the LCT dissector and not the RMT-ALC "parent", but kept for backwards compatibility.

svn path=/trunk/; revision=49555

6 years agoFix :
Jeff Morriss [Fri, 24 May 2013 15:28:04 +0000 (15:28 -0000)]
Fix :

If we're not doing dissection (in 2-pass mode) then don't try to mark frames
as depended upon: in that case epan has not been initialized so we shouldn't
be looking in the edt (and anyway without dissection there won't be any
dependent frames).

(I'm not convinced there's any reason to run 2-pass mode without dissection,

svn path=/trunk/; revision=49554

6 years agoAs suggested by Moshe Kaplan in
Jeff Morriss [Fri, 24 May 2013 14:45:55 +0000 (14:45 -0000)]
As suggested by Moshe Kaplan in :

When pointing people to the mailing lists, point them directly to the lists
page rather than explaining where to look for the link on the main page (the
directions were several years out of date).

While there also fix up some of the indentation and add a link to the Q&A site
in the developer's guide.

svn path=/trunk/; revision=49553

6 years agoHave register_param_stat() add menu items, rather than having the menu
Guy Harris [Fri, 24 May 2013 03:10:56 +0000 (03:10 -0000)]
Have register_param_stat() add menu items, rather than having the menu
items hardcoded into ui/gtk/main_menubar.c

Get rid of more stuff implying that the code for adding menu items is
used only by Lua, as it's also used by register_param_stat().

Add the items to the menu list sorted by the menu item name shown to the

Get rid of some const declarations that are lies.

Use the label given for a menu item as the label in the menu, rather
than parsing it from a token.

svn path=/trunk/; revision=49552

6 years agoAdd an optimization to req_resp_hdrs_do_reassembly that shaves about 20% off
Evan Huus [Fri, 24 May 2013 02:31:26 +0000 (02:31 -0000)]
Add an optimization to req_resp_hdrs_do_reassembly that shaves about 20% off
the load time of one of my sample captures that is HTTP-but-not-really.

Also add modelines.

svn path=/trunk/; revision=49551

6 years agoAnd another (cosmetic) change for that.
Guy Harris [Fri, 24 May 2013 01:11:07 +0000 (01:11 -0000)]
And another (cosmetic) change for that.

svn path=/trunk/; revision=49550

6 years agoA long-overdue rename of register_dfilter_stat() to
Guy Harris [Fri, 24 May 2013 01:10:16 +0000 (01:10 -0000)]
A long-overdue rename of register_dfilter_stat() to
register_param_stat() to reflect that it's for arbitrary statistics tap
parameters, not just a display filter.

svn path=/trunk/; revision=49549

6 years agoRename register_lua_menu_bar_menu_items() to
Guy Harris [Fri, 24 May 2013 01:05:39 +0000 (01:05 -0000)]
Rename register_lua_menu_bar_menu_items() to
register_menu_bar_menu_items(), to emphasize that it's not just for Lua.

svn path=/trunk/; revision=49548

6 years agoWe don't want to restrict the ability to dynamically add statistics
Guy Harris [Thu, 23 May 2013 23:32:20 +0000 (23:32 -0000)]
We don't want to restrict the ability to dynamically add statistics
menus to Lua taps.

svn path=/trunk/; revision=49547

6 years agoFix computation of TP-User-Data-Length when SMS is coded with GSM 7 bit default alpha...
Pascal Quantin [Thu, 23 May 2013 20:28:59 +0000 (20:28 -0000)]
Fix computation of TP-User-Data-Length when SMS is coded with GSM 7 bit default alphabet and TP-User-Data-Header field is present

svn path=/trunk/; revision=49546

6 years agoIt's actually enough just to add some blank lines without the need for the <pre>...
Chris Maynard [Thu, 23 May 2013 17:45:21 +0000 (17:45 -0000)]
It's actually enough just to add some blank lines without the need for the <pre> tags.

svn path=/trunk/; revision=49545

6 years agoUse a single #ifdef HAVE_LUA/#endif for two routines (currently) used
Guy Harris [Thu, 23 May 2013 03:26:22 +0000 (03:26 -0000)]
Use a single #ifdef HAVE_LUA/#endif for two routines (currently) used
only from the Lua code.

svn path=/trunk/; revision=49544

6 years agoAdd -p option to the valgrind script for profiling with callgrind.
Evan Huus [Thu, 23 May 2013 02:30:40 +0000 (02:30 -0000)]
Add -p option to the valgrind script for profiling with callgrind.

svn path=/trunk/; revision=49543

6 years agoNo need for those arguments to be pointers to arrays of const pointers,
Guy Harris [Thu, 23 May 2013 01:25:06 +0000 (01:25 -0000)]
No need for those arguments to be pointers to arrays of const pointers,
especially given that we end up freeing what all of those pointers point

svn path=/trunk/; revision=49542