metze/wireshark/wip.git
11 years ago*NIX (autofoo and cmake) part of the fix for
Jeff Morriss [Tue, 18 Sep 2012 21:42:13 +0000 (21:42 -0000)]
*NIX (autofoo and cmake) part of the fix for
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6134 :

Make VERSION_MAJOR, VERSION_MINOR, and VERSION_MICRO available in config.h so
(e.g.) dissector writers can #if around them as necessary to make a piece of
code compile with different versions of Wireshark.  (Hopefully VERSION_MICRO
is not important in this respect!)

Windows also defines VERSION_EXTRA which can be used to help identify custom
builds; this is not done for these build methods (yet?).

svn path=/trunk/; revision=44986

11 years agoFrom Daniel via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7716
Alexis La Goutte [Tue, 18 Sep 2012 20:46:05 +0000 (20:46 -0000)]
From Daniel via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7716
Adding VHT Radiotap fields support

Parsing and UI representation for recently adopted VHT Radiotap fields for
802.11ac specification
http://www.radiotap.org/defined-fields/VHT

From me :
* Make checkAPIs happy
* Fix wrong last argument for some proto_tree_add_item
* Use proto_tree_add_item when it is possible

svn path=/trunk/; revision=44985

11 years agoUse g_malloc0
Jakub Zawadzki [Tue, 18 Sep 2012 20:07:06 +0000 (20:07 -0000)]
Use g_malloc0

svn path=/trunk/; revision=44984

11 years agoTrivial typo/copy-and-paste comment fix.
Chris Maynard [Tue, 18 Sep 2012 20:03:03 +0000 (20:03 -0000)]
Trivial typo/copy-and-paste comment fix.

svn path=/trunk/; revision=44983

11 years agoAdd stuff to config to build with VS2012. However: build currently fails.
Bill Meier [Tue, 18 Sep 2012 19:42:04 +0000 (19:42 -0000)]
Add stuff to config to build with VS2012. However: build currently fails.

svn path=/trunk/; revision=44982

11 years agoAdd ui/qt/console.lua to .gitignore
Alexis La Goutte [Tue, 18 Sep 2012 19:31:29 +0000 (19:31 -0000)]
Add ui/qt/console.lua to .gitignore

svn path=/trunk/; revision=44981

11 years agoRevert r44978: dissector_add_uint: Legalize formerly improper use of the API when...
Jakub Zawadzki [Tue, 18 Sep 2012 19:29:00 +0000 (19:29 -0000)]
Revert r44978: dissector_add_uint: Legalize formerly improper use of the API when calling it with pattern value of 0

dissector_add_uint() is *not only* used by tcp.port/udp.port dissector tables where 0 is not valid port number,
in some dissector tables 0 is valid protocol number, packet type, etc..

Sample dissectors using dissector_add_uint(.pattern = 0):
  packet-ansi_637.c:2348: dissector_add_uint("ansi_a.sms", 0, ansi_637_trans_handle);
  packet-cip.c:6017:      dissector_add_uint("cip.class.iface", 0, cip_class_generic_handle );
  packet-lon.c:723:       dissector_add_uint("cnip.protocol", 0, lon_handle);
  packet-q931.c:3599:     dissector_add_uint("lapd.sapi", LAPD_SAPI_Q931 /* 0 */, q931_handle);

svn path=/trunk/; revision=44980

11 years agoIf all ports are set to 0, then register the handle so "Decode As..." works.
Chris Maynard [Tue, 18 Sep 2012 19:28:44 +0000 (19:28 -0000)]
If all ports are set to 0, then register the handle so "Decode As..." works.

svn path=/trunk/; revision=44979

11 years agodissector_add_uint:
Jörg Mayer [Tue, 18 Sep 2012 19:04:04 +0000 (19:04 -0000)]
dissector_add_uint:
   Legalize formerly improper use of the API when calling it with
   pattern value of 0

svn path=/trunk/; revision=44978

11 years agoFix up proto_reg_handoff_hazelcast(), setting "initialized" to TRUE once initialized...
Chris Maynard [Tue, 18 Sep 2012 18:20:02 +0000 (18:20 -0000)]
Fix up proto_reg_handoff_hazelcast(), setting "initialized" to TRUE once initialized and also avoiding duplicate "tcp.port" registration.

svn path=/trunk/; revision=44977

11 years agoDon't register to udp port 0.
Chris Maynard [Tue, 18 Sep 2012 18:15:21 +0000 (18:15 -0000)]
Don't register to udp port 0.

svn path=/trunk/; revision=44976

11 years agoDon't register to udp/tcp port 0, but use dissector_add_handle() instead.
Chris Maynard [Tue, 18 Sep 2012 18:14:24 +0000 (18:14 -0000)]
Don't register to udp/tcp port 0, but use dissector_add_handle() instead.

svn path=/trunk/; revision=44975

11 years agoAdd python cache and temporary files to the list of files to clean up.
Jeff Morriss [Tue, 18 Sep 2012 17:40:50 +0000 (17:40 -0000)]
Add python cache and temporary files to the list of files to clean up.

svn path=/trunk/; revision=44974

11 years agoFix dissection of Scheduling Information MAC Control Element when it is the only...
Pascal Quantin [Tue, 18 Sep 2012 17:26:00 +0000 (17:26 -0000)]
Fix dissection of Scheduling Information MAC Control Element when it is the only LCID in the MCH PDU

svn path=/trunk/; revision=44973

11 years agoIf we have PYTHON use make-tap-reg.py (in both autofoo and Windows): it's
Jeff Morriss [Tue, 18 Sep 2012 15:15:39 +0000 (15:15 -0000)]
If we have PYTHON use make-tap-reg.py (in both autofoo and Windows): it's
slightly faster than the old shell-script version on *NIX and it seems
significantly faster on Windows.

svn path=/trunk/; revision=44972

11 years agoIf we have PYTHON use make-tap-reg.py (like we do on Windows): it's slightly
Jeff Morriss [Tue, 18 Sep 2012 14:48:28 +0000 (14:48 -0000)]
If we have PYTHON use make-tap-reg.py (like we do on Windows): it's slightly
faster than the old shell-script version (~150 msec instead of ~500 msec on
my system).

svn path=/trunk/; revision=44971

11 years agoparse nfsv4.1 SEQUENCE status flags (https://bugs.wireshark.org/bugzilla/show_bug...
Michael Mann [Tue, 18 Sep 2012 14:12:17 +0000 (14:12 -0000)]
parse nfsv4.1 SEQUENCE status flags (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7726)

svn path=/trunk/; revision=44970

11 years agoOnly provide the parameter data in the tvb used when calling subdissector for private...
Anders Broman [Tue, 18 Sep 2012 07:39:14 +0000 (07:39 -0000)]
Only provide the parameter data in the tvb used when calling subdissector for private extensions.
Add vendor ID to item.
Show flags in hex.

svn path=/trunk/; revision=44967

11 years agoFix uninitialized value warnings from GCC.
Evan Huus [Tue, 18 Sep 2012 02:17:24 +0000 (02:17 -0000)]
Fix uninitialized value warnings from GCC.

svn path=/trunk/; revision=44966

11 years agoDo some reformatting.
Bill Meier [Tue, 18 Sep 2012 01:34:08 +0000 (01:34 -0000)]
Do some reformatting.

svn path=/trunk/; revision=44965

11 years agoFrom Michael Lum: Fix typo.
Bill Meier [Tue, 18 Sep 2012 00:47:37 +0000 (00:47 -0000)]
From Michael Lum: Fix typo.

svn path=/trunk/; revision=44964

11 years agoAdd Gerald's recent qt text-import work to CMake build.
Evan Huus [Tue, 18 Sep 2012 00:40:10 +0000 (00:40 -0000)]
Add Gerald's recent qt text-import work to CMake build.

svn path=/trunk/; revision=44963

11 years agoInitialize all hf's to -1, not 0.
Chris Maynard [Tue, 18 Sep 2012 00:33:19 +0000 (00:33 -0000)]
Initialize all hf's to -1, not 0.

svn path=/trunk/; revision=44962

11 years agoTwo hf's were not initialized to -1. They are now.
Chris Maynard [Tue, 18 Sep 2012 00:25:57 +0000 (00:25 -0000)]
Two hf's were not initialized to -1.  They are now.

svn path=/trunk/; revision=44961

11 years agoMake the help button do something.
Gerald Combs [Tue, 18 Sep 2012 00:17:04 +0000 (00:17 -0000)]
Make the help button do something.

svn path=/trunk/; revision=44960

11 years agoInitialize ett's and hf's to "-1", not "- 1".
Chris Maynard [Tue, 18 Sep 2012 00:16:01 +0000 (00:16 -0000)]
Initialize ett's and hf's to "-1", not "- 1".

svn path=/trunk/; revision=44959

11 years agoAdjust the Import Text dialog size policy, although it's still not
Gerald Combs [Tue, 18 Sep 2012 00:05:55 +0000 (00:05 -0000)]
Adjust the Import Text dialog size policy, although it's still not
quite right.

svn path=/trunk/; revision=44958

11 years agoRestore set_last_open_dir. We need it on Windows.
Gerald Combs [Mon, 17 Sep 2012 23:59:50 +0000 (23:59 -0000)]
Restore set_last_open_dir. We need it on Windows.

svn path=/trunk/; revision=44957

11 years agoAdd a text import dialog. Use libui.
Gerald Combs [Mon, 17 Sep 2012 23:40:53 +0000 (23:40 -0000)]
Add a text import dialog. Use libui.

svn path=/trunk/; revision=44956

11 years agoPut back the part of the regexp's that avoids finding function prototypes.
Jeff Morriss [Mon, 17 Sep 2012 21:56:52 +0000 (21:56 -0000)]
Put back the part of the regexp's that avoids finding function prototypes.

svn path=/trunk/; revision=44955

11 years agoRather than reading the dissectors line by line and searching for the
Jeff Morriss [Mon, 17 Sep 2012 21:30:24 +0000 (21:30 -0000)]
Rather than reading the dissectors line by line and searching for the
registration and handoff routines in each line, read the whole file into
memory and then do one findall() search. Store the matches in sets to avoid
duplication.

(This also simplifies the number of regexps we're looking for.)

This speeds up the generation of register.c (when there is no cache)
significantly (on my system the time taken drops from ~32 seconds to ~5
seconds).

svn path=/trunk/; revision=44954

11 years agoThere is no proto_reg_handoff_data() so don't prototype it. Remove unnecessary inclu...
Jeff Morriss [Mon, 17 Sep 2012 21:26:19 +0000 (21:26 -0000)]
There is no proto_reg_handoff_data() so don't prototype it.  Remove unnecessary include (glib.h).

svn path=/trunk/; revision=44953

11 years agoUnique-ify the list of dissector registration and handoff functions while we
Jeff Morriss [Mon, 17 Sep 2012 20:37:39 +0000 (20:37 -0000)]
Unique-ify the list of dissector registration and handoff functions while we
sort them.  Avoids the double registration problem discussed on -dev today.

Note: the sorted() call requires Python 2.4+ but I think that's OK now.

svn path=/trunk/; revision=44952

11 years ago#include <epan/prefs.h> not req'd.
Bill Meier [Mon, 17 Sep 2012 18:05:21 +0000 (18:05 -0000)]
#include <epan/prefs.h> not req'd.

svn path=/trunk/; revision=44951

11 years agoCleanup:
Bill Meier [Mon, 17 Sep 2012 17:47:43 +0000 (17:47 -0000)]
Cleanup:
 - fix two cases of potential infinite loop while dissecting;
   [for (guint8 i; i <= guint8 end; i++)]
 - col_...() fcns should not be called under 'if (tree)'
 - remove unneeded initializers;
 - move proto_reg_handoff...() to the end of the file as per convention;
 - remove some boilerplate comments;
 - use consistent indentation and whitespace style;
 - remove some trailing whitespace.

svn path=/trunk/; revision=44950

11 years agoCleanup:
Bill Meier [Mon, 17 Sep 2012 16:05:43 +0000 (16:05 -0000)]
Cleanup:
- fix several instances of a potential infinte loop while dissecting TLVs;
  (it would be nice to have a valid capture file so this dissector can be fuzz-tested)
- move proto_reg_handoff...() to the end of the file as per convention;
- do find_dissector() only once in proto_reg_handoff...();
- reformat some long lines;
- replace some tabs by spaces and do other whitespace changes.

svn path=/trunk/; revision=44949

11 years agoUpdate dissection of Request type IE
Pascal Quantin [Mon, 17 Sep 2012 16:04:36 +0000 (16:04 -0000)]
Update dissection of Request type IE

svn path=/trunk/; revision=44948

11 years agoHandle SDP_CRYPTO optional parameters better.
Anders Broman [Mon, 17 Sep 2012 15:37:28 +0000 (15:37 -0000)]
Handle SDP_CRYPTO optional parameters better.

svn path=/trunk/; revision=44946

11 years agoFrom me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Alexis La Goutte [Mon, 17 Sep 2012 15:19:18 +0000 (15:19 -0000)]
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Enhance DNS Dissector

Enhance DNS : make DNSKEY type filterable

svn path=/trunk/; revision=44945

11 years agoFrom me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Alexis La Goutte [Mon, 17 Sep 2012 15:18:54 +0000 (15:18 -0000)]
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Enhance DNS Dissector

Enhance DNS : make RRSIG type filterable

svn path=/trunk/; revision=44944

11 years agoFrom me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Alexis La Goutte [Mon, 17 Sep 2012 15:18:32 +0000 (15:18 -0000)]
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Enhance DNS Dissector

Enhance DNS : make TXT, SPF type filterable

svn path=/trunk/; revision=44943

11 years agoFrom me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Alexis La Goutte [Mon, 17 Sep 2012 15:17:48 +0000 (15:17 -0000)]
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Enhance DNS Dissector

Enhance DNS : make MX filtereable

svn path=/trunk/; revision=44942

11 years agoFrom me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Alexis La Goutte [Mon, 17 Sep 2012 15:16:34 +0000 (15:16 -0000)]
From me via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7709
Enhance DNS Dissector

Enhance DNS : make HINFO filtereable

svn path=/trunk/; revision=44941

11 years agocallsinfo->stop_fd not set in all branches for UNISTIM.
Anders Broman [Mon, 17 Sep 2012 14:51:08 +0000 (14:51 -0000)]
callsinfo->stop_fd not set in all branches for UNISTIM.

svn path=/trunk/; revision=44940

11 years agoFix errors in the packet length checks.
Anders Broman [Mon, 17 Sep 2012 12:13:34 +0000 (12:13 -0000)]
Fix errors in the packet length checks.

svn path=/trunk/; revision=44939

11 years agoAdd IPv6 heuristic.
Anders Broman [Mon, 17 Sep 2012 10:46:56 +0000 (10:46 -0000)]
Add IPv6 heuristic.

svn path=/trunk/; revision=44938

11 years agoAdd eol-style and keywords to SVN properties.
Evan Huus [Mon, 17 Sep 2012 02:22:23 +0000 (02:22 -0000)]
Add eol-style and keywords to SVN properties.

svn path=/trunk/; revision=44936

11 years agoMake it compile with GCC.
Evan Huus [Mon, 17 Sep 2012 02:05:49 +0000 (02:05 -0000)]
Make it compile with GCC.

svn path=/trunk/; revision=44935

11 years agoAdd IETF ForCES(Forwarding and Control Element Separation) dissector (https://bugs...
Michael Mann [Mon, 17 Sep 2012 01:38:52 +0000 (01:38 -0000)]
Add IETF ForCES(Forwarding and Control Element Separation) dissector (https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3534)

svn path=/trunk/; revision=44934

11 years agoMinor cleanup:
Bill Meier [Mon, 17 Sep 2012 00:42:22 +0000 (00:42 -0000)]
Minor cleanup:
- remove unneeded gtk_table_resize() [in prep for using gtk_grid for GTK3];
- use g_hash_table)_full() to specify function to free 'value'
- Fix some whitespace.

svn path=/trunk/; revision=44933

11 years agoMinor cleanup:
Bill Meier [Mon, 17 Sep 2012 00:03:19 +0000 (00:03 -0000)]
Minor cleanup:
- simplify code related to use of GHashTables;
- use consistent whitespace and formatting style.

svn path=/trunk/; revision=44932

11 years agoCleanup:
Bill Meier [Sun, 16 Sep 2012 23:02:07 +0000 (23:02 -0000)]
Cleanup:
- remove unneeded gtk_table_resize() [in prep for using GtkGrid for GTK3];
- simplify code relating to use of a GHashTable;
- add comment about use of !! magic !! numeric constants;
- do some additional whitespace cleanup.

svn path=/trunk/; revision=44931

11 years agoTrivial cleanup:
Bill Meier [Sun, 16 Sep 2012 19:06:42 +0000 (19:06 -0000)]
Trivial cleanup:
- Remove unneeded #includes;
- Use consistent whitespace and formatting style.

svn path=/trunk/; revision=44930

11 years ago(trivial) fix a typo
Bill Meier [Sun, 16 Sep 2012 18:00:56 +0000 (18:00 -0000)]
(trivial) fix a typo

svn path=/trunk/; revision=44929

11 years agoAdd packet-interlink to CMake build to maintain parity with automake as of
Evan Huus [Sun, 16 Sep 2012 17:57:15 +0000 (17:57 -0000)]
Add packet-interlink to CMake build to maintain parity with automake as of
revision 44927.

svn path=/trunk/; revision=44928

11 years agoComplete process of moving packet-interlink to a built-in dissector:
Bill Meier [Sun, 16 Sep 2012 17:26:49 +0000 (17:26 -0000)]
Complete process of moving packet-interlink to a built-in dissector:
- Add packet-interlink.c to Makefile.common
   (Not included in SVN #37610-37612);
   See: https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6005
- Also: update signature for dissect_interlink_heur() (as per recent changes).

svn path=/trunk/; revision=44927

11 years ago[Automatic manuf, services and enterprise-numbers update for 2012-09-16]
Gerald Combs [Sun, 16 Sep 2012 14:03:36 +0000 (14:03 -0000)]
[Automatic manuf, services and enterprise-numbers update for 2012-09-16]

svn path=/trunk/; revision=44924

11 years agoCompile and install schemas if GTK3 is used, nsis needs update too
Anders Broman [Sun, 16 Sep 2012 09:55:44 +0000 (09:55 -0000)]
Compile and install schemas if GTK3 is used, nsis needs update too

svn path=/trunk/; revision=44923

11 years agoWork around Solaris 11's pkg-config being in /usr/ccs/bin but its
Guy Harris [Sun, 16 Sep 2012 01:49:59 +0000 (01:49 -0000)]
Work around Solaris 11's pkg-config being in /usr/ccs/bin but its
aclocal directory apparently being in /usr/share/aclocal rather than the
non-existent /usr/ccs/share/aclocal.  (/usr/ccs is sort of an extension
of /usr for developers; I'm not sure why they stuck the pkg-config stuff
under /usr/share rather than /usr/ccs/share given that it's of interest
only to developers.)

svn path=/trunk/; revision=44922

11 years agoFrom Pontus Fuchs via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728
Evan Huus [Sat, 15 Sep 2012 20:16:14 +0000 (20:16 -0000)]
From Pontus Fuchs via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7728

Make right-click + apply-as-filter work in the packet list for non-ethernet
frames (such as ieee 802.11 frames).

svn path=/trunk/; revision=44921

11 years agoAdd support for bzr checkouts (similar to git checkouts) to make-version.pl.
Evan Huus [Sat, 15 Sep 2012 16:09:07 +0000 (16:09 -0000)]
Add support for bzr checkouts (similar to git checkouts) to make-version.pl.

Also, add modelines.

svn path=/trunk/; revision=44920

11 years agoTrivial whitespace formatting cleanup;
Bill Meier [Sat, 15 Sep 2012 14:46:13 +0000 (14:46 -0000)]
Trivial whitespace formatting cleanup;

svn path=/trunk/; revision=44919

11 years agoMinor cleanup:
Bill Meier [Sat, 15 Sep 2012 14:20:20 +0000 (14:20 -0000)]
Minor cleanup:
- Remove unneeded #includes;
- Remove unused function [which uses deprecated gtk_table...()];
- Use consistent whitespace formatting style.

svn path=/trunk/; revision=44918

11 years agoTrivial cleanup;
Bill Meier [Sat, 15 Sep 2012 14:08:48 +0000 (14:08 -0000)]
Trivial cleanup;
  Remove a few unneeded initializers;
  Fix a few typos in comments;
  Use consistent formatting style.

svn path=/trunk/; revision=44917

11 years agoFrom Niels Widger via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7725
Evan Huus [Sat, 15 Sep 2012 13:58:57 +0000 (13:58 -0000)]
From Niels Widger via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7725

Add get_filter method to Wireshark's Lua interface (to correspond with the
already-exposed set_filter method).

svn path=/trunk/; revision=44916

11 years agoAvoid a stack-smash when decoding the new DNS option field if the length is
Evan Huus [Sat, 15 Sep 2012 13:49:27 +0000 (13:49 -0000)]
Avoid a stack-smash when decoding the new DNS option field if the length is
malformed.

Fixes https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7730

svn path=/trunk/; revision=44915

11 years agoDon't redefine WIRESHARK_UI_SRC
Anders Broman [Sat, 15 Sep 2012 10:01:21 +0000 (10:01 -0000)]
Don't redefine WIRESHARK_UI_SRC

svn path=/trunk/; revision=44914

11 years agotext_import_scanner_lex.h and text_import_scanner.c are now part of
Guy Harris [Sat, 15 Sep 2012 08:43:27 +0000 (08:43 -0000)]
text_import_scanner_lex.h and text_import_scanner.c are now part of
libui, not libgtkui.

svn path=/trunk/; revision=44913

11 years ago*Do* use DIRTY_GENERATED_C_FILES, as it's defined; sadly, flex doesn't
Guy Harris [Sat, 15 Sep 2012 08:19:39 +0000 (08:19 -0000)]
*Do* use DIRTY_GENERATED_C_FILES, as it's defined; sadly, flex doesn't
generate warning-free files.

svn path=/trunk/; revision=44911

11 years agoDIRTY_GENERATED_C_FILES is empty, and isn't used by ui/gtk/Makefile.am,
Guy Harris [Sat, 15 Sep 2012 08:18:57 +0000 (08:18 -0000)]
DIRTY_GENERATED_C_FILES is empty, and isn't used by ui/gtk/Makefile.am,
so get rid of it, and stop using it in ui/gtk/Makefile.make; we don't
want to encourage people to create source files that get warnings.

svn path=/trunk/; revision=44910

11 years agoNobody uses DIRTY_GENERATED_C_FILES, so get rid of it; we don't want to
Guy Harris [Sat, 15 Sep 2012 08:17:53 +0000 (08:17 -0000)]
Nobody uses DIRTY_GENERATED_C_FILES, so get rid of it; we don't want to
encourage people to create source files that get warnings.

svn path=/trunk/; revision=44909

11 years agoUpdate CMakeLists to respect the recent libui changes so that wireshark and
Evan Huus [Sat, 15 Sep 2012 02:52:29 +0000 (02:52 -0000)]
Update CMakeLists to respect the recent libui changes so that wireshark and
qtshark build again.

(Also, first commit trying to use bzr as an svn client, so apologies if
 something unexpected breaks)

svn path=/trunk/; revision=44908

11 years agolibgtkui_dirty → libui_dirty.
Gerald Combs [Fri, 14 Sep 2012 21:06:26 +0000 (21:06 -0000)]
libgtkui_dirty → libui_dirty.

svn path=/trunk/; revision=44907

11 years agoMore fixes for the text import move.
Gerald Combs [Fri, 14 Sep 2012 20:55:11 +0000 (20:55 -0000)]
More fixes for the text import move.

svn path=/trunk/; revision=44906

11 years agoDeletions from the last commit didn't make it for some reason.
Gerald Combs [Fri, 14 Sep 2012 20:47:55 +0000 (20:47 -0000)]
Deletions from the last commit didn't make it for some reason.

svn path=/trunk/; revision=44905

11 years agoCreate a common libui using CMake similar to what we do with Autotools.
Gerald Combs [Fri, 14 Sep 2012 20:23:18 +0000 (20:23 -0000)]
Create a common libui using CMake similar to what we do with Autotools.
Move the GTK+ text import code to the common UI directory. Create
wtap_encap_requires_phdr() from code in file_import_dlg.c.

svn path=/trunk/; revision=44904

11 years agoFix up the (#if'd out) sequence number analysis debug code so that it compiles and...
Jeff Morriss [Fri, 14 Sep 2012 18:20:59 +0000 (18:20 -0000)]
Fix up the (#if'd out) sequence number analysis debug code so that it compiles and is easier to read.  Also fix up some white space.

svn path=/trunk/; revision=44903

11 years agoUse consistent indentation and formatting style;
Bill Meier [Fri, 14 Sep 2012 15:19:15 +0000 (15:19 -0000)]
Use consistent indentation and formatting style;
Fix a few typos; Fix long line.

svn path=/trunk/; revision=44902

11 years agoTry to make the buildbot happy.
Anders Broman [Fri, 14 Sep 2012 14:40:47 +0000 (14:40 -0000)]
Try to make the buildbot happy.

svn path=/trunk/; revision=44901

11 years agoHeuristically dissect TIPC IP payloads.
Anders Broman [Fri, 14 Sep 2012 14:14:46 +0000 (14:14 -0000)]
Heuristically dissect TIPC IP payloads.

svn path=/trunk/; revision=44900

11 years agoFrom Mike Morrin:
Anders Broman [Fri, 14 Sep 2012 14:05:50 +0000 (14:05 -0000)]
From Mike Morrin:
Fix pedantic compiler warnings in csn.1 dissectors.

There is some tricky casting going on in csn.1 structures.  To eliminate all
the warnings, the function pointers needed to be moved out of the object
pointer unions.  Fortunately macros (mostly) hide these changes from the
protocol dissector tables.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7686

svn path=/trunk/; revision=44899

11 years agoAddress buildbot error:
Anders Broman [Fri, 14 Sep 2012 11:42:46 +0000 (11:42 -0000)]
Address buildbot error:
packet-nstrace.c: In function 'dissect_nstrace':
packet-nstrace.c:131: warning: 'dst_vmname_len' may be used uninitialized in this function
packet-nstrace.c:131: warning: 'src_vmname_len' may be used uninitialized in this function

svn path=/trunk/; revision=44898

11 years agoFrom Michal Labedzki:
Anders Broman [Fri, 14 Sep 2012 11:30:07 +0000 (11:30 -0000)]
From Michal Labedzki:
Bluetooth: Add color for HID dissector

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=44897

11 years agoFrom Michal Labedzki:
Anders Broman [Fri, 14 Sep 2012 11:27:57 +0000 (11:27 -0000)]
From Michal Labedzki:
Bluetooth: minor fix in HID
Applied by hand and changed offset to be signed as per WS convention.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7639

svn path=/trunk/; revision=44896

11 years agoFrom Nikhil Kalu:
Anders Broman [Fri, 14 Sep 2012 11:11:37 +0000 (11:11 -0000)]
From Nikhil Kalu:
Enhancement to add more trace record fields in Citrix NetScaler capture file format.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7713

svn path=/trunk/; revision=44895

11 years agoFrom Michal Labedzki:
Anders Broman [Fri, 14 Sep 2012 11:02:24 +0000 (11:02 -0000)]
From Michal Labedzki:
Add Bluetooth Protocol BNEP. Supported version: 1.0.

I changed offset to be an int to follow WS convention.While at it I changed other types to fit the tvb_get routines.

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7719

svn path=/trunk/; revision=44894

11 years agoFix enumeration value for Virtual RAT-Type
Pascal Quantin [Fri, 14 Sep 2012 08:32:04 +0000 (08:32 -0000)]
Fix enumeration value for Virtual RAT-Type

svn path=/trunk/; revision=44893

11 years agoFrom Josip Medved:
Anders Broman [Fri, 14 Sep 2012 08:28:18 +0000 (08:28 -0000)]
From Josip Medved:
Updated multiple enumerations (Event-Trigger, Reporting-Level, IP-CAN-Type,
Rule-Failure-Code and RAT-Type) to get them in sync with ETSI TS 129 212
V10.6.0 (2012-03).

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7727

svn path=/trunk/; revision=44892

11 years agoFrom Claude LeFrancois:
Anders Broman [Fri, 14 Sep 2012 08:24:35 +0000 (08:24 -0000)]
From Claude LeFrancois:
Cosmetic changes to GTPv2(Add text to itenms)
Minor code changes by me.

svn path=/trunk/; revision=44891

11 years agoUse the latet GTK3+ bundles when building with GTK3
Anders Broman [Fri, 14 Sep 2012 06:21:55 +0000 (06:21 -0000)]
Use the latet GTK3+ bundles when building with GTK3

svn path=/trunk/; revision=44890

11 years agoUse consistent indentation and formatting.
Bill Meier [Fri, 14 Sep 2012 03:24:23 +0000 (03:24 -0000)]
Use consistent indentation and formatting.

svn path=/trunk/; revision=44889

11 years agoRemove our local copy of WinPcap and download it from
Gerald Combs [Thu, 13 Sep 2012 21:28:28 +0000 (21:28 -0000)]
Remove our local copy of WinPcap and download it from
wireshark-win{32,64}-libs instead. In win-setup.sh only try to unzip
files ending in .zip. PortableApps and U3 packaging changes are untested.

svn path=/trunk/; revision=44888

11 years agoMinor tweek for GTK3
Anders Broman [Thu, 13 Sep 2012 05:29:53 +0000 (05:29 -0000)]
Minor tweek for GTK3

svn path=/trunk/; revision=44887

11 years agoSCSI: Update INQUIRY standard page and decode the flags depending on which version...
Ronnie Sahlberg [Thu, 13 Sep 2012 01:28:57 +0000 (01:28 -0000)]
SCSI: Update INQUIRY standard page and decode the flags depending on which version of SPC that the device claims conformance to.

svn path=/trunk/; revision=44886

11 years agoAlso disable the resize grip on the profile bar (as it is on the info and
Jeff Morriss [Wed, 12 Sep 2012 21:02:54 +0000 (21:02 -0000)]
Also disable the resize grip on the profile bar (as it is on the info and
packets bars; this is for GTK < 3.0).

This fixes the problem I had that the profile bar normally took up way too
much (horizontal) room when I start Wireshark (causing the contents of the
much more interesting packets bar to be truncated).

svn path=/trunk/; revision=44885

11 years agoFix FBI true_false_string array and remove a useless hf variable
Pascal Quantin [Wed, 12 Sep 2012 12:29:59 +0000 (12:29 -0000)]
Fix FBI true_false_string array and remove a useless hf variable

svn path=/trunk/; revision=44884

11 years agoFrom Mike Morrin:
Anders Broman [Wed, 12 Sep 2012 12:07:53 +0000 (12:07 -0000)]
From Mike Morrin:
* fixup of dissection of message type for PRACH messages.
* fixed dissection of optional octet 2/3 in dl control messages
* removed a few more duplicate hf items
* changed all M_BIT macros to M_UINT, as M_BIT does not use the referenced hf.
* fixed dissection of ul_tfi and dl_tfi so that assignments and usage can be
filtered more easily
* fixed missing references to existing value strings and converted to tfs
strings where possible

https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7686

svn path=/trunk/; revision=44883

11 years agoAdd doxygen hints.
Anders Broman [Wed, 12 Sep 2012 10:27:37 +0000 (10:27 -0000)]
Add doxygen hints.

svn path=/trunk/; revision=44882

11 years agoFrom Esa Haapamäki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7718 :
Pascal Quantin [Wed, 12 Sep 2012 10:21:00 +0000 (10:21 -0000)]
From Esa Haapamäki via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=7718 :
Fix dissection of NAS Uplink and Downlink Count in MM Context IE

svn path=/trunk/; revision=44881

11 years agoAs suggested by Anatoly in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5699 :
Jeff Morriss [Tue, 11 Sep 2012 13:11:33 +0000 (13:11 -0000)]
As suggested by Anatoly in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5699 :

Followup to r44844: use a better cast (intptr_t instead of long long).

svn path=/trunk/; revision=44880