Anders Broman [Fri, 6 Mar 2009 17:16:56 +0000 (17:16 -0000)]
Get rid of a Clist and move the functon to display floats with two decimals to gui_utils.
svn path=/trunk/; revision=27621
Bill Meier [Fri, 6 Mar 2009 15:41:02 +0000 (15:41 -0000)]
From Michael Speck: Fix so compiles with VC6
svn path=/trunk/; revision=27620
Bill Meier [Fri, 6 Mar 2009 00:24:06 +0000 (00:24 -0000)]
Correct bug in heuristic so as to strengthen it a bit.
Specifically: a little research verifies that the correct
heuristic is: Succeed if the byte at offset 0 is an STX *and* the
bytes at offset 3/4 correspond to a valid OICQ command.
The code was actually effectively doing an *or* and thus the
heuristic was quite weak.
svn path=/trunk/; revision=27619
Stig Bjørlykke [Thu, 5 Mar 2009 22:29:15 +0000 (22:29 -0000)]
Use some default true_false_string's.
Fixed a typo.
svn path=/trunk/; revision=27618
Stig Bjørlykke [Thu, 5 Mar 2009 22:25:36 +0000 (22:25 -0000)]
Addded tfs_used_notused.
svn path=/trunk/; revision=27617
Bill Meier [Thu, 5 Mar 2009 16:41:50 +0000 (16:41 -0000)]
Remove stuff that's really "non-public" from .h files.
(Include in .c files as needed).
svn path=/trunk/; revision=27616
Jaap Keuter [Thu, 5 Mar 2009 07:21:43 +0000 (07:21 -0000)]
Addition of Ping and PingAck messages.
svn path=/trunk/; revision=27615
Stephen Fisher [Thu, 5 Mar 2009 04:55:51 +0000 (04:55 -0000)]
Remove an unused variable.
svn path=/trunk/; revision=27614
Bill Meier [Thu, 5 Mar 2009 04:32:08 +0000 (04:32 -0000)]
Oops! Fix the fix
svn path=/trunk/; revision=27613
Bill Meier [Thu, 5 Mar 2009 04:14:01 +0000 (04:14 -0000)]
Minor rework of reg_handoff ...
svn path=/trunk/; revision=27612
Bill Meier [Thu, 5 Mar 2009 04:12:12 +0000 (04:12 -0000)]
Prefs callback not req'd ...
svn path=/trunk/; revision=27611
Bill Meier [Thu, 5 Mar 2009 04:10:45 +0000 (04:10 -0000)]
Minor rework of reg_handoff ...
svn path=/trunk/; revision=27610
Bill Meier [Thu, 5 Mar 2009 04:04:38 +0000 (04:04 -0000)]
Several small revisions:
- "if (!initialized)" not req'd in reg_handoff;
- call find_dissector for "ppp" and "fr" only
once in reg-handoff instead of each time the
sub-dissector is called.
- Move hf[] & etc to within proto_register...
svn path=/trunk/; revision=27609
Guy Harris [Thu, 5 Mar 2009 03:05:02 +0000 (03:05 -0000)]
Get rid of an unused global variable.
svn path=/trunk/; revision=27608
Guy Harris [Wed, 4 Mar 2009 20:39:10 +0000 (20:39 -0000)]
Fix typo that caused compiler warnings.
svn path=/trunk/; revision=27607
Anders Broman [Wed, 4 Mar 2009 19:59:56 +0000 (19:59 -0000)]
From Neil Piercy:
Embedded RRC messages not dissected.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3300
svn path=/trunk/; revision=27606
Anders Broman [Wed, 4 Mar 2009 19:51:55 +0000 (19:51 -0000)]
- Use correct length in TLV-E and LV-E.
- Update PD values to the latest spec.
- Remove some non ASCII chars.
- Start dissecton of LTE NAS ESM EPS messages and IE's.
svn path=/trunk/; revision=27605
Stig Bjørlykke [Wed, 4 Mar 2009 07:50:17 +0000 (07:50 -0000)]
Map "x.25.*" preferences to "x25.*".
svn path=/trunk/; revision=27604
Stig Bjørlykke [Tue, 3 Mar 2009 22:46:47 +0000 (22:46 -0000)]
From Neil Piercy (bug 3299):
Added support for length greater than 127 (less than 16K).
svn path=/trunk/; revision=27603
Anders Broman [Tue, 3 Mar 2009 22:33:45 +0000 (22:33 -0000)]
Use correct length.
svn path=/trunk/; revision=27602
Anders Broman [Tue, 3 Mar 2009 22:33:14 +0000 (22:33 -0000)]
Fix a typo.
svn path=/trunk/; revision=27601
Stig Bjørlykke [Tue, 3 Mar 2009 22:22:13 +0000 (22:22 -0000)]
Added the missing file.
svn path=/trunk/; revision=27600
Anders Broman [Tue, 3 Mar 2009 22:16:26 +0000 (22:16 -0000)]
Change key_len to guint16.
svn path=/trunk/; revision=27599
Stig Bjørlykke [Tue, 3 Mar 2009 22:06:11 +0000 (22:06 -0000)]
Moved the dissector_handle_t.
svn path=/trunk/; revision=27598
Stig Bjørlykke [Tue, 3 Mar 2009 22:04:44 +0000 (22:04 -0000)]
Removed unused rpcap_handle.
svn path=/trunk/; revision=27597
Stig Bjørlykke [Tue, 3 Mar 2009 22:02:17 +0000 (22:02 -0000)]
Moved the dissector_handle_t.
svn path=/trunk/; revision=27596
Stig Bjørlykke [Tue, 3 Mar 2009 22:00:10 +0000 (22:00 -0000)]
Renamed filter name to x25 to be like other X protocols.
svn path=/trunk/; revision=27595
Stig Bjørlykke [Tue, 3 Mar 2009 21:57:43 +0000 (21:57 -0000)]
Added support for Memcache Binary Protocol.
svn path=/trunk/; revision=27594
Stig Bjørlykke [Tue, 3 Mar 2009 21:38:49 +0000 (21:38 -0000)]
Add expert info when bad checksum.
svn path=/trunk/; revision=27593
Martin Mathieson [Tue, 3 Mar 2009 20:55:38 +0000 (20:55 -0000)]
Add a newline at the end of the file.
svn path=/trunk/; revision=27592
Anders Broman [Tue, 3 Mar 2009 20:07:38 +0000 (20:07 -0000)]
Artem Tamazov:
Introduction of decoding of MPLS payloads as HDLC PW (RFC4618)
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3297
svn path=/trunk/; revision=27591
Anders Broman [Tue, 3 Mar 2009 20:01:01 +0000 (20:01 -0000)]
Artem Tamazov:
MPLS payload dissection: +menu for default, ~pw-eth, ~pw-generic
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3294
svn path=/trunk/; revision=27590
Anders Broman [Tue, 3 Mar 2009 19:51:08 +0000 (19:51 -0000)]
From Alvaro Vega Garcia:
Support ZIOP and MIOP (specialized CORBA protocols).
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3238
svn path=/trunk/; revision=27589
Anders Broman [Tue, 3 Mar 2009 19:26:45 +0000 (19:26 -0000)]
From Sven Eckelmann:
Support aggregated originator messages in B.A.T.M.A.N. dissector.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3268
svn path=/trunk/; revision=27588
Anders Broman [Tue, 3 Mar 2009 19:22:54 +0000 (19:22 -0000)]
From Michael Lum:
pESN detection fix and additional dissection enhancements.
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3254
svn path=/trunk/; revision=27587
Anders Broman [Tue, 3 Mar 2009 18:26:07 +0000 (18:26 -0000)]
Export the E212 dissection routine.
svn path=/trunk/; revision=27586
Anders Broman [Tue, 3 Mar 2009 18:25:25 +0000 (18:25 -0000)]
Use the SCTP ppid for S1AP.
svn path=/trunk/; revision=27585
Anders Broman [Tue, 3 Mar 2009 18:24:10 +0000 (18:24 -0000)]
Update UMA towards the most recent 3GPP spec, and export InterRATHandoverInfo
from the RRC dissector.
svn path=/trunk/; revision=27584
Anders Broman [Tue, 3 Mar 2009 05:52:46 +0000 (05:52 -0000)]
Try to make the solaris buildbot happy.
svn path=/trunk/; revision=27583
Gerald Combs [Mon, 2 Mar 2009 21:33:11 +0000 (21:33 -0000)]
More Windows compiler flag cleanups. Fix a problem with my last commit
that would break compilation for older compilers. Create a "DLL_LDFLAGS"
variable and use it in DLLs and plugins. Use PLUGIN_LDFLAGS and
DLL_LDFLAGS where needed. Don't force i386 code in the TPG plugin.
svn path=/trunk/; revision=27582
Stephen Fisher [Mon, 2 Mar 2009 21:30:17 +0000 (21:30 -0000)]
Remove a variable that is no longer used as of svn rev 27580
svn path=/trunk/; revision=27581
Anders Broman [Mon, 2 Mar 2009 20:20:39 +0000 (20:20 -0000)]
Use gtk_combo_box_new_text ().
svn path=/trunk/; revision=27580
Gerald Combs [Mon, 2 Mar 2009 18:57:35 +0000 (18:57 -0000)]
Disable manifest building for our DLLs. This attempts to fix bug 3272.
svn path=/trunk/; revision=27579
Gerald Combs [Mon, 2 Mar 2009 18:40:56 +0000 (18:40 -0000)]
Fix our keyword anchor.
svn path=/trunk/; revision=27578
Gerald Combs [Mon, 2 Mar 2009 18:30:16 +0000 (18:30 -0000)]
Add a version to register-cache.pkl and use it to rebuild the cache from
scratch when needed.
svn path=/trunk/; revision=27577
Anders Broman [Mon, 2 Mar 2009 07:31:06 +0000 (07:31 -0000)]
Code cleanup.
svn path=/trunk/; revision=27576
Jeff Morriss [Sun, 1 Mar 2009 21:37:30 +0000 (21:37 -0000)]
Fix conversation tracking bug noticed in:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3216#c2
(Basically: how the dissector was dissecting frames--in the GUI--changed based
on the order you had clicked on them.)
... by rewriting how the frame states are maintained: rather than maintaining
a g_hash table of frames and their states, hang the (now se_alloc'd) frame
data off the frame (using p_*_proto_data()).
svn path=/trunk/; revision=27575
Anders Broman [Sun, 1 Mar 2009 20:39:44 +0000 (20:39 -0000)]
Add more IE dissection.
svn path=/trunk/; revision=27574
Gerald Combs [Sun, 1 Mar 2009 16:03:39 +0000 (16:03 -0000)]
[Automatic manuf update for 2009-03-01]
svn path=/trunk/; revision=27572
Jaap Keuter [Sun, 1 Mar 2009 15:32:17 +0000 (15:32 -0000)]
From Carles Kishimoto:
Dissector for the proprietary protocol FEFD (Far End Failure Detction) from Force10networks.
svn path=/trunk/; revision=27571
Guy Harris [Sun, 1 Mar 2009 08:24:24 +0000 (08:24 -0000)]
Clean up display of QoS PS Buffer State field.
svn path=/trunk/; revision=27570
Guy Harris [Sun, 1 Mar 2009 07:26:59 +0000 (07:26 -0000)]
Show bit 4 of the QoS field for frames not coming from an AP.
Make the TXOP Limit, Queue Size, and TXOP Duration Request part of the
QoS field separate named fields, and show them in a bit better fashion.
svn path=/trunk/; revision=27569
Jeff Morriss [Sat, 28 Feb 2009 19:30:56 +0000 (19:30 -0000)]
From Toralf Forster via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3216 :
Implement mysql_dissect_row_packet().
From me: change all tvb_length_remaining() calls to
tvb_reported_length_remaining() so the dissector will throw an exception if
the packets are truncated.
svn path=/trunk/; revision=27568
Jeff Morriss [Sat, 28 Feb 2009 19:14:14 +0000 (19:14 -0000)]
Remove a whole bunch of if(tree)'s that were protecting single
proto_tree_add_*() calls: those APIs check if tree is NULL too and taking
out the dissector's ifs makes the code easier to read.
svn path=/trunk/; revision=27567
Jeff Morriss [Sat, 28 Feb 2009 18:26:46 +0000 (18:26 -0000)]
From Alex Turbov via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3291 :
SNAC(4,2) actually have uint32_t type of last field and its mean time in
milliseconds
svn path=/trunk/; revision=27566
Jeff Morriss [Sat, 28 Feb 2009 04:27:43 +0000 (04:27 -0000)]
From Michael Lum via https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=3281 :
The LCS Client Type parameter in a BSSMAP Perform Location Request is not being
dissected (1.1 trunk).
The LCS Priority and LCS QoS are fine.
svn path=/trunk/; revision=27565
Martin Mathieson [Fri, 27 Feb 2009 17:36:06 +0000 (17:36 -0000)]
Fix counting of 'predefined' bytes.
svn path=/trunk/; revision=27564
Stig Bjørlykke [Fri, 27 Feb 2009 12:51:11 +0000 (12:51 -0000)]
Update the services file from IANA's port-numbers.
svn path=/trunk/; revision=27563
Martin Mathieson [Fri, 27 Feb 2009 11:18:15 +0000 (11:18 -0000)]
Some context names now do include '-', so allow it.
svn path=/trunk/; revision=27562
Anders Broman [Fri, 27 Feb 2009 07:09:25 +0000 (07:09 -0000)]
Add GTK deprecated functions.
svn path=/trunk/; revision=27561
Stig Bjørlykke [Thu, 26 Feb 2009 22:26:42 +0000 (22:26 -0000)]
Remember the last used profile and restore this on startup.
svn path=/trunk/; revision=27560
Stig Bjørlykke [Thu, 26 Feb 2009 22:24:18 +0000 (22:24 -0000)]
Don't write the recent file when leaving a deleted profile.
svn path=/trunk/; revision=27559
Anders Broman [Thu, 26 Feb 2009 21:41:07 +0000 (21:41 -0000)]
gtk_menu_append is deprecated and should not be used in newly-written code. Use gtk_menu_shell_append().
svn path=/trunk/; revision=27558
Stig Bjørlykke [Thu, 26 Feb 2009 21:30:33 +0000 (21:30 -0000)]
Use same coloring rule for icmp and icmpv6.
svn path=/trunk/; revision=27557
Anders Broman [Thu, 26 Feb 2009 21:11:06 +0000 (21:11 -0000)]
gtk_label_set -> gtk_label_set_text
"gtk_label_set is deprecated and should not be used in newly-written code.
Aliases gtk_label_set_text()."
svn path=/trunk/; revision=27556
Anders Broman [Thu, 26 Feb 2009 20:55:19 +0000 (20:55 -0000)]
gtk_list_store_insert_with_values() requires GTK+ 2.6 or later.
From Jakub Zawadzki further optimisations.
svn path=/trunk/; revision=27555
Anders Broman [Thu, 26 Feb 2009 16:46:00 +0000 (16:46 -0000)]
Another small performance boost.
svn path=/trunk/; revision=27554
Stig Bjørlykke [Thu, 26 Feb 2009 14:49:13 +0000 (14:49 -0000)]
Removed some spaces in BCH Bytes and PCH Bytes.
svn path=/trunk/; revision=27553
Martin Mathieson [Thu, 26 Feb 2009 11:47:37 +0000 (11:47 -0000)]
More layout improvements (thanks Stig).
svn path=/trunk/; revision=27552
Stephen Fisher [Thu, 26 Feb 2009 07:55:09 +0000 (07:55 -0000)]
Fix (private) bug #3278: When first opening the RTP stream analysis window,
it hangs for a while before allowing the user to interact with the window.
Fixed by setting columns to fixed height and fixed width.
Also: Don't display columns we were hiding in the CList version of this
window.
svn path=/trunk/; revision=27551
Jaap Keuter [Thu, 26 Feb 2009 05:42:55 +0000 (05:42 -0000)]
From Didier Gautheron:
ECWmin and ECWmax in the Beacon WME Information Element are not displayed correctly.
They appear as equal each to the other. It should be: byte2 & 0x0f, (byte2 & 0xf0) >> 4.
svn path=/trunk/; revision=27550
Jaap Keuter [Wed, 25 Feb 2009 23:19:56 +0000 (23:19 -0000)]
From Mark C. Brown:
Added support for HPVM (Integrity Virtual Machines) guest AVIO (Accelerated Virtual IO) driver IGSSN.
Cleaned up the trace record checks.
Made the default ethernet if the nettl subsystem is not recognized.
svn path=/trunk/; revision=27549
Stig Bjørlykke [Wed, 25 Feb 2009 21:28:40 +0000 (21:28 -0000)]
Added make-tap-reg.py
svn path=/trunk/; revision=27548
Stig Bjørlykke [Wed, 25 Feb 2009 20:28:36 +0000 (20:28 -0000)]
Added a few service values.
svn path=/trunk/; revision=27547
Martin Mathieson [Wed, 25 Feb 2009 18:02:09 +0000 (18:02 -0000)]
More updates to LTE MAC stats. Layout working better now.
svn path=/trunk/; revision=27546
Bill Meier [Wed, 25 Feb 2009 16:23:38 +0000 (16:23 -0000)]
Prefs callback not req'd; hf[]: Use NULL (not "") for empty blurb.
svn path=/trunk/; revision=27545
Stig Bjørlykke [Wed, 25 Feb 2009 14:12:38 +0000 (14:12 -0000)]
Added initial support for Canon BJNP.
svn path=/trunk/; revision=27544
Martin Mathieson [Wed, 25 Feb 2009 11:33:47 +0000 (11:33 -0000)]
Add a preference to control checking of reserved bits.
svn path=/trunk/; revision=27543
Guy Harris [Wed, 25 Feb 2009 11:25:12 +0000 (11:25 -0000)]
Put in a comment discussing ways of better handling the FCS in various
protocols.
Clean up white space.
svn path=/trunk/; revision=27542
Guy Harris [Wed, 25 Feb 2009 10:05:04 +0000 (10:05 -0000)]
Explain conversations and circuits.
svn path=/trunk/; revision=27541
Guy Harris [Wed, 25 Feb 2009 09:26:27 +0000 (09:26 -0000)]
Clean up the comments in the L2TP dissector about RFCs.
Clean up indentation a bit.
Clean up the L2TPv3 dissection a bit.
Make an OAM cell dissector, and have the L2TP dissector call it.
svn path=/trunk/; revision=27540
Jaap Keuter [Wed, 25 Feb 2009 06:33:56 +0000 (06:33 -0000)]
From Alex Turbov:
Decoding SNAC(13,1a) leads to DISSECTOR_ASSERT_NOT_REACHED in proto.c:1006
because of invalid call to proto_tree_add_item() in
dissect_aim_snac_ssi_auth_reply() (@ packet-aim-ssi.c).
svn path=/trunk/; revision=27539
Guy Harris [Wed, 25 Feb 2009 00:36:31 +0000 (00:36 -0000)]
Port Mapping Protocol, not Plug-'n-Play.
Give the I-D number and a URL to the (now-expired) draft.
svn path=/trunk/; revision=27538
Stig Bjørlykke [Wed, 25 Feb 2009 00:28:19 +0000 (00:28 -0000)]
Removed mark for unused pinfo, its in use.
svn path=/trunk/; revision=27537
Stig Bjørlykke [Wed, 25 Feb 2009 00:22:47 +0000 (00:22 -0000)]
Added support for NAT Port Mapping Protocol (NAT-PMP).
svn path=/trunk/; revision=27536
Jaap Keuter [Tue, 24 Feb 2009 18:09:27 +0000 (18:09 -0000)]
Get the Windows build going again.
svn path=/trunk/; revision=27535
Martin Mathieson [Tue, 24 Feb 2009 17:57:25 +0000 (17:57 -0000)]
Fix some of the UE issues in this window.
- don't use table with one row for common channel counts
- the UEs table now grows to fill vertical space as window is resized
- 4 rows UE details still don't all show...
svn path=/trunk/; revision=27534
Jaap Keuter [Tue, 24 Feb 2009 17:24:03 +0000 (17:24 -0000)]
Add posibility to mark protocol as private. This prevents inadvertent Wiki access.
svn path=/trunk/; revision=27533
Anders Broman [Tue, 24 Feb 2009 07:04:41 +0000 (07:04 -0000)]
From Vincent Helfre:
Build the register routines for wtap plugins.
svn path=/trunk/; revision=27532
Jaap Keuter [Tue, 24 Feb 2009 06:37:45 +0000 (06:37 -0000)]
From Jerry Kotland:
There's a slight error with one of the 802.11n SM Power Save labels.
Currently, when SM Power save == 3, the label is "SM enabled".
According to 802.11n Draft 2.07 it should be "SM Power Save disabled".
svn path=/trunk/; revision=27531
Stephen Fisher [Mon, 23 Feb 2009 23:50:03 +0000 (23:50 -0000)]
The beginnings of a World of Warcraft (WoW) protocol dissector.
svn path=/trunk/; revision=27530
Jaap Keuter [Mon, 23 Feb 2009 22:07:19 +0000 (22:07 -0000)]
Fix for bug 3247:
Incorrect index adjustment causes failure to dissect multiple capabilities in optional parameters.
svn path=/trunk/; revision=27529
Stig Bjørlykke [Mon, 23 Feb 2009 20:44:11 +0000 (20:44 -0000)]
From Kip McAtee (bug 3274):
Don't indicate incorrect Payload Length when having trailing FCS.
svn path=/trunk/; revision=27528
Jaap Keuter [Mon, 23 Feb 2009 20:01:00 +0000 (20:01 -0000)]
From Steve Karg:
The ConfirmedEventNotification decoding was only done as far as context tag 8,
so BACnetNotificationParameters 9, 10, and 11 displayed as malformed packet.
Added context tag decoding for BACnetNotificationParameters 9, 10, and 11.
Added missing breaks in several switch statements.
Corrected some dissector aborts.
Added several new enumerations from the latest BACnet 135-2008 standard, and
updated the list of BACnet Vendor IDs.
svn path=/trunk/; revision=27527
Guy Harris [Mon, 23 Feb 2009 19:00:30 +0000 (19:00 -0000)]
Have the minimum snapshot length be 1 byte, and have a snapshot length
of 0 mean 65535, similar to what tcpdump does.
Fixes bug 2731.
svn path=/trunk/; revision=27526
Stig Bjørlykke [Mon, 23 Feb 2009 17:28:31 +0000 (17:28 -0000)]
Use bold labels for headings.
svn path=/trunk/; revision=27525
Martin Mathieson [Mon, 23 Feb 2009 16:15:49 +0000 (16:15 -0000)]
Use separate variables for different 'scrolled_window' instances
svn path=/trunk/; revision=27524
Stig Bjørlykke [Mon, 23 Feb 2009 16:04:29 +0000 (16:04 -0000)]
Ah, the line was not supposed to be there.
svn path=/trunk/; revision=27523
Stig Bjørlykke [Mon, 23 Feb 2009 15:39:05 +0000 (15:39 -0000)]
Make it compile.
svn path=/trunk/; revision=27522
Martin Mathieson [Mon, 23 Feb 2009 15:33:59 +0000 (15:33 -0000)]
Add an LTE MAC stats window.
I'm struggling with the layout - I'll ask the dev list for ideas...
svn path=/trunk/; revision=27521