metze/wireshark/wip.git
4 years agoAdd boundary check for 802.11 decryption
Peter Wu [Sat, 28 Nov 2015 00:24:12 +0000 (01:24 +0100)]
Add boundary check for 802.11 decryption

Fixed stack-based buffer overflow when the frame length exceeds 8KB.

Bug: 11790
Change-Id: I20db8901765a7660e587057e955d4fb5a8645574
Reviewed-on: https://code.wireshark.org/review/12237
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years agoSanity check iSeries packet length to prevent heap-based buffer overflow.
Michael Mann [Sat, 28 Nov 2015 01:37:36 +0000 (20:37 -0500)]
Sanity check iSeries packet length to prevent heap-based buffer overflow.

Bug: 11798
Change-Id: I7aebe709ef4014a385819835ef6effabbb4f0ca4
Reviewed-on: https://code.wireshark.org/review/12238
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoRemove the GSSAPI specific members out of packet_info structure.
Michael Mann [Fri, 27 Nov 2015 15:59:09 +0000 (10:59 -0500)]
Remove the GSSAPI specific members out of packet_info structure.

The last piece was the NTLMSSP dissector and that is now handled by passing a pointer to a tvbuff* as dissector data for the NTLMSSP dissector to (possibly) "return" a tvbuff* with decrypted data.

Change-Id: I2606172e4d0ebb5fc6353921d5b5f41a4792f9e5
Reviewed-on: https://code.wireshark.org/review/12232
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoQt: reload after applying parameters in UDP multicast dialog
Peter Wu [Fri, 27 Nov 2015 17:10:52 +0000 (18:10 +0100)]
Qt: reload after applying parameters in UDP multicast dialog

Noticed this message in stderr, started investigating:

    QObject::connect: No such signal MulticastStatisticsDialog::updateFilter(QString&,bool) in ui/qt/multicast_statistics_dialog.cpp:247
    QObject::connect:  (sender name:   'TapParameterDialog')
    QObject::connect:  (receiver name: 'TapParameterDialog')

Verified that after this patch, the "Max Burst" changes from "4/100ms"
to "1/1ms" when modifying "Burst measurement interval (ms)" from 100 to
1 using rtp-norm-transfer.pcap from the SampleCaptures wiki.

Change-Id: I803ff9e5a542a5fd3507b086f29628fbf5602784
Reviewed-on: https://code.wireshark.org/review/12228
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoQt: set focus to text box when opening search frame
Pascal Quantin [Fri, 27 Nov 2015 23:09:46 +0000 (00:09 +0100)]
Qt: set focus to text box when opening search frame

Change-Id: Iac932365bc2fa7a5d5102a5f5455ea01daa86590
Reviewed-on: https://code.wireshark.org/review/12236
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoQt: fix "go to packet" broken by g56625dd
Pascal Quantin [Fri, 27 Nov 2015 23:06:56 +0000 (00:06 +0100)]
Qt: fix "go to packet" broken by g56625dd

Keeping auto scroll is required to update the row displayed.
Instead catch the mouse event and stop auto scroll only during that time.

Change-Id: Ibc5b0a4115192fc3e01e63c82e67761e5aed9d3b
Reviewed-on: https://code.wireshark.org/review/12235
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years ago[ASN1 custom dissectors]Add the abillity to build custom ASN1 based
AndersBroman [Fri, 27 Nov 2015 15:25:23 +0000 (16:25 +0100)]
[ASN1 custom dissectors]Add the abillity to build custom ASN1 based
dissectors.

Change-Id: Icb8b68672e0fd9c636dc02fe3ca46eb9a1e51420
Reviewed-on: https://code.wireshark.org/review/12223
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoFix ISO C forbids an empty translation unit [-Wpedantic] (airpcap)
João Valverde [Wed, 25 Nov 2015 00:45:06 +0000 (00:45 +0000)]
Fix ISO C forbids an empty translation unit [-Wpedantic] (airpcap)

Autotools only warning.

Change-Id: I30f33d2f8611d662dbc62326862707bf05ad3f60
Reviewed-on: https://code.wireshark.org/review/12150
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoFix crash in UDP Multicast Streams dialog
Peter Wu [Fri, 27 Nov 2015 16:57:34 +0000 (17:57 +0100)]
Fix crash in UDP Multicast Streams dialog

Attempting to open the UDP Multicast Streams dialog in the GTK UI
triggers an instant crash (heap-buffer-overflow).

Déjà vu. This is the same problem that plagued the RTP Streams dialog.
This patch is based on the fix in v1.99.3rc0-33-g2c65b33
(mcaststream_dlg_update confused GList vs. mcaststream_tapinfo_t).

After fixing that, the dialog crashed shortly after setting parameters
(heap-use-after-free). That fix is based on v1.99.10rc0-292-gb02a0ee
(after a retap, the old items were still present in the list).

Just that change was not enough as clearing the list still triggered a
signal, possibly because of the "changed" signal (while the RTP player
uses a selection setter function). Apply the patch based on
v1.99.10rc0-270-g01bd832 (disable selection while clearing).

Change-Id: I152bac6f954d8d1c5c20d6c7d56a196c3e20c681
Reviewed-on: https://code.wireshark.org/review/12227
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoQt: remove automatic horizontal scrolling when selecting a row
Pascal Quantin [Fri, 27 Nov 2015 16:01:05 +0000 (17:01 +0100)]
Qt: remove automatic horizontal scrolling when selecting a row

QTreeView automatically scrolls so as to show as much as possible the content of the selected column.
Let's get rid of that.
Rename PacketList::setAutoScroll() so that it does not overload QAbstractItemView::setAutoscroll()

Change-Id: I09fb54f9b31c3025efddce6a4e709baaf107702d
Reviewed-on: https://code.wireshark.org/review/12225
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoFix display of bytes as EBCDIC
Pascal Quantin [Fri, 27 Nov 2015 10:34:51 +0000 (11:34 +0100)]
Fix display of bytes as EBCDIC

MSVC compiler does not support properly setting an enum being part of a bit field.
For example the following code:
pinfo->fd->flags.encoding = PACKET_CHAR_ENC_CHAR_EBCDIC;
changes pinfo->fd->flags.encoding from 0x0 to 0xfffffffe instead of 0x1
Let's put back an unsigned int definition (like it is in master-1.12 branch) and add explicit casts where required

Bug: 11787
Change-Id: Idae0140fb6c172f1b3dbf10baefc8cfb00128f4c
Reviewed-on: https://code.wireshark.org/review/12220
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoFix crash in Capture File Properties dialog
Peter Wu [Fri, 27 Nov 2015 15:32:54 +0000 (16:32 +0100)]
Fix crash in Capture File Properties dialog

Fixes crash when a capture file is closed while the capture file
properties dialog is open.

Change-Id: Iba35be38e1f53d422ff8428a672703385d477660
Reviewed-on: https://code.wireshark.org/review/12224
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years ago[COAP] Add "2.31 Continue" code
Michael Mann [Fri, 27 Nov 2015 13:41:21 +0000 (08:41 -0500)]
[COAP] Add "2.31 Continue" code

Bug: 11682
Change-Id: I77c7b9cdb39f18dabe0de0f11d9132ae074e3686
Reviewed-on: https://code.wireshark.org/review/12222
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agowtap: Disable ISO C forbids conversion [-Wpedantic]
João Valverde [Thu, 26 Nov 2015 02:51:46 +0000 (02:51 +0000)]
wtap: Disable ISO C forbids conversion [-Wpedantic]

  wtap.c:74:25: warning: ISO C forbids conversion of object pointer
  to function pointer type [-Wpedantic]

Choose ISO C or dynamic loading, can't have both.

Change-Id: I6d48073dadaf7c1710bd87ed71a2e7b65970d47e
Reviewed-on: https://code.wireshark.org/review/12165
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agopcapng: Fix ISO C forbids conversion [-Wpedantic]
João Valverde [Thu, 26 Nov 2015 01:29:36 +0000 (01:29 +0000)]
pcapng: Fix ISO C forbids conversion [-Wpedantic]

pcapng.c:461:31: warning: ISO C forbids passing argument 3 of 'g_hash_table_insert' between function pointer and 'void *' [-Wpedantic]
pcapng.c:1404:32: warning: ISO C forbids conversion of object pointer to function pointer type [-Wpedantic]
pcapng.c:1918:32: warning: ISO C forbids conversion of object pointer to function pointer type [-Wpedantic]

Change-Id: I535633098cc5d37442732dd92e8c9d3cda36631a
Reviewed-on: https://code.wireshark.org/review/12161
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agosshdump: move build check
Dario Lombardo [Wed, 25 Nov 2015 15:35:14 +0000 (16:35 +0100)]
sshdump: move build check

Check was made too early, when libssh was still unchecked.

Change-Id: I6c84548b48e99d277f67f3a7ea06b4e759111034
Reviewed-on: https://code.wireshark.org/review/12141
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoconfigure.ac: Fix CXXFLAGS with optimization for HP-UX
João Valverde [Fri, 27 Nov 2015 01:27:36 +0000 (01:27 +0000)]
configure.ac: Fix CXXFLAGS with optimization for HP-UX

Change-Id: I0cdef95ce44fb5c6112998697dbafe23c3ee13ab
Reviewed-on: https://code.wireshark.org/review/12212
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoSMB sidsnooping: use sid as key and name as value
Peter Wu [Wed, 25 Nov 2015 22:15:58 +0000 (23:15 +0100)]
SMB sidsnooping: use sid as key and name as value

Fixes "cast from 'const char *' to 'char *' drops const qualifier
[-Wcast-qual]", but changes the internal representation of
sid_name_table.

Change-Id: Ia853c3cf3010ea0cd1e2c975a23dd97e15be0fd6
Reviewed-on: https://code.wireshark.org/review/12157
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: João Valverde <j@v6e.pt>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoNGHTTP2: Update to 1.5.0
Alexis La Goutte [Thu, 26 Nov 2015 18:32:40 +0000 (19:32 +0100)]
NGHTTP2: Update to 1.5.0

Change-Id: I18ec89d1d053014a023217f6a07d72c7791fd436
Reviewed-on: https://code.wireshark.org/review/12199
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoQt: Check zero recent column width
Stig Bjørlykke [Thu, 26 Nov 2015 18:15:44 +0000 (19:15 +0100)]
Qt: Check zero recent column width

Hidden columns may have been stored with zero width, so ensure
we always check for this when fetching.

Change-Id: I625c05adccaf2d81198fdeeccf7feeb9a9eb82c2
Reviewed-on: https://code.wireshark.org/review/12196
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years ago[LDAP] Bugfix counting of search results.
Michael Mann [Thu, 26 Nov 2015 14:09:23 +0000 (09:09 -0500)]
[LDAP] Bugfix counting of search results.

Bug: 11761
Change-Id: Icd955b848edc9f802331f25ab1b8684aa2631553
Reviewed-on: https://code.wireshark.org/review/12184
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoQt: display RTP/IAX2 graph analysis arrival time as absolute instead of relative
Pascal Quantin [Thu, 26 Nov 2015 18:08:47 +0000 (19:08 +0100)]
Qt: display RTP/IAX2 graph analysis arrival time as absolute instead of relative

It makes it easier to synchronize the graph and packet list

Change-Id: Ia0c6bc46227c1ff9267622ff52b5a5d966cd6e6a
Reviewed-on: https://code.wireshark.org/review/12195
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoQt: display RTP stream Y axis values as milliseconds
Pascal Quantin [Thu, 26 Nov 2015 17:31:58 +0000 (18:31 +0100)]
Qt: display RTP stream Y axis values as milliseconds

Bug: 11784
Change-Id: I505338d85788e0889999622ff392ca8fe5f46836
Reviewed-on: https://code.wireshark.org/review/12194
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoQt: Make About->Plugins scrollable
Stig Bjørlykke [Thu, 26 Nov 2015 19:31:12 +0000 (20:31 +0100)]
Qt: Make About->Plugins scrollable

Bug: 11427
Change-Id: Iebc693bc2a035bad3bc2491af4b5a12c9e7d2fa5
Reviewed-on: https://code.wireshark.org/review/12201
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoqt: add initializers (CID 1311487)
Dario Lombardo [Thu, 26 Nov 2015 15:26:38 +0000 (16:26 +0100)]
qt: add initializers (CID 1311487)

Change-Id: I3152548aa3237dc76e898986120f662cbe56fa38
Reviewed-on: https://code.wireshark.org/review/12188
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoMP4ves: fix no previous prototype for ... [-Wmissing-prototypes]
Alexis La Goutte [Thu, 26 Nov 2015 18:25:32 +0000 (19:25 +0100)]
MP4ves: fix no previous prototype for ... [-Wmissing-prototypes]

Change-Id: I89579ad371decb46a312ee4c3e967bd80709ef1d
Reviewed-on: https://code.wireshark.org/review/12198
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoOfficially remove tvb_get_string and tvb_get_stringz.
Michael Mann [Thu, 26 Nov 2015 20:10:06 +0000 (15:10 -0500)]
Officially remove tvb_get_string and tvb_get_stringz.

Almost all replacements were done awhile ago, just put the final nail in the coffin.

Change-Id: I0a708d886da5a500c2a1e2c9ee2736794bdb9411
Reviewed-on: https://code.wireshark.org/review/12206
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoRemove manual setting of pinfo->current_proto.
Michael Mann [Thu, 26 Nov 2015 13:25:32 +0000 (08:25 -0500)]
Remove manual setting of pinfo->current_proto.

Calling a protocol dissection function will properly set/restore pinfo->current_proto, so there's no need to duplicate it.

Change-Id: Ic2ec0b35fa4d46a98f3410bf238056425076e4a9
Reviewed-on: https://code.wireshark.org/review/12205
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoScan pcapng change time to unsigned
João Valverde [Thu, 26 Nov 2015 22:07:09 +0000 (22:07 +0000)]
Scan pcapng change time to unsigned

Fixes warning:

  nettrace_3gpp_32_423.c:813:4: warning: format '%u' expects argument
  of type 'unsigned int *', but argument 3 has type 'int *' [-Wformat=]

Change-Id: I4bfcc19ecac115d5aa2e222dfed8ea8b0b450d71
Reviewed-on: https://code.wireshark.org/review/12211
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoqt: add initializers to extcap dialog (CID 1297113)
Dario Lombardo [Thu, 26 Nov 2015 15:35:03 +0000 (16:35 +0100)]
qt: add initializers to extcap dialog (CID 1297113)

Change-Id: I3c0d116554a663a1a6449d805c9fe860d4c9911e
Reviewed-on: https://code.wireshark.org/review/12190
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoChange Lua tests to reflect the disappearance of WTAP_ENCAP_IEEE_802_11_AIROPEEK.
Guy Harris [Thu, 26 Nov 2015 21:33:33 +0000 (13:33 -0800)]
Change Lua tests to reflect the disappearance of WTAP_ENCAP_IEEE_802_11_AIROPEEK.

The old global tests don't work; get rid of them.  Fix the values of the
Lua globals in the new test, and get rid of IEEE_802_11_AIROPEEK.

(Yes, if you have a Lua script that depends on IEEE_802_11_AIROPEEK
being defined, or that depends on the values of the Wiretap
encapsulations not changing, it breaks.  Fix it.)

Change-Id: I245c1c0c3ba1c450f7950c754624c51b5564848a
Reviewed-on: https://code.wireshark.org/review/12210
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoDon't allow the "Ethertype" pseudo-protocol's dissection to be disabled.
Guy Harris [Thu, 26 Nov 2015 20:25:43 +0000 (12:25 -0800)]
Don't allow the "Ethertype" pseudo-protocol's dissection to be disabled.

It's not a real protocol, it's a helper dissector for various protocols,
and it makes no sense to disable it; doing so means that the Ethertype
field itself isn't disabled, and allowing it to be disabled means that
you can't do "Disable All", and manually enable Ethernet, IPv4, IPv6,
and TCP to disable dissection of protocols running atop TCP on Ethernet.

(See

    https://ask.wireshark.org/questions/48011/enabled-protocols-negation-of-disabled-proto

for an example of somebody who wants to do exactly that.)

Change-Id: Ibdd6ef53503de548e14cecc3766040c3a0b101d4
Reviewed-on: https://code.wireshark.org/review/12207
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years ago[mp2t] use the correct file infomation for PCR detection
Martin Kaiser [Mon, 23 Nov 2015 13:49:03 +0000 (21:49 +0800)]
[mp2t] use the correct file infomation for PCR detection

when we check for an mpeg2 transport stream, we're trying to detect an
initial offset before the first sync byte and the length of additional
data appended to each packet

use those values when we go through the file again and verify the PCR

Bug: 11749
Change-Id: Iab03cb271d23d38f850ca857b64ca47ba4501175
Reviewed-on: https://code.wireshark.org/review/12183
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoPCEP: support of "PCEP Extensions for Establishing
Francesco Fondelli [Thu, 26 Nov 2015 12:04:12 +0000 (13:04 +0100)]
PCEP: support of "PCEP Extensions for Establishing
Relationships Between Sets of LSPs", draft-ietf-pce-association-group-00

Bug: 11782
Change-Id: I1f0886bc30a71af54b51dea771a927d1f5742ca9
Signed-off-by: Francesco Fondelli <francesco.fondelli@gmail.com>
Reviewed-on: https://code.wireshark.org/review/12179
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoWrong field name for signal strength as a percentage.
Guy Harris [Thu, 26 Nov 2015 19:59:53 +0000 (11:59 -0800)]
Wrong field name for signal strength as a percentage.

Copy-and-pasteo.

Change-Id: I42ba4f172f9b837f01d3b30f2d14e7ee066f3e83
Reviewed-on: https://code.wireshark.org/review/12203
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoProcess the radio information internally for AiroPeek classic files.
Guy Harris [Thu, 26 Nov 2015 19:42:32 +0000 (11:42 -0800)]
Process the radio information internally for AiroPeek classic files.

Process it in libwiretap; no need to hand it to libwireshark for
dissection, it can just dissect the radio information pseudo-header with
the processed information.

Change-Id: I482697947eecbd3967cf1910ba2fa2bff805cd66
Reviewed-on: https://code.wireshark.org/review/12202
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoQt: make Files Set dialog modeless
Pascal Quantin [Thu, 26 Nov 2015 14:57:32 +0000 (15:57 +0100)]
Qt: make Files Set dialog modeless

Otherwise you need to close the window each time you change the file
so as to browse its content...

Change-Id: Ibf8485695cec34bb950ad98cb671e77d4f663b63
Reviewed-on: https://code.wireshark.org/review/12187
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoQt: clear new_visible_rows_ when closing a capture file
Pascal Quantin [Thu, 26 Nov 2015 13:22:20 +0000 (14:22 +0100)]
Qt: clear new_visible_rows_ when closing a capture file

Bug: 11756
Change-Id: Iccc92963f81c3ded143953c8c1fad27cd57a7bc2
Reviewed-on: https://code.wireshark.org/review/12182
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoQt: Use correct column width when switching profile
Stig Bjørlykke [Tue, 24 Nov 2015 19:42:50 +0000 (20:42 +0100)]
Qt: Use correct column width when switching profile

QTreeView::setColumnHidden() saves column width on hide and restores
column width on show.  When switching from a profile with hidden
columns to a profile where this columns are shown we get a
sectionResized() signal with the saved width from the old profile,
initiated from columnsChanged() -> setColumnVisibility().
We must avoid setting this as a new column width because this is
recent values from a old column layout.

In other cases we use setColumnVisibility() we don’t need to set
a new column width either, because we store the column width ourself.

Don't store column width when hiding column (new_width == 0).
Restore column width when showing column because profiles may have
changed the packet_list layout.

Change-Id: I7e89c3477402ec6d621cd2015ee74b086f60d6cb
Reviewed-on: https://code.wireshark.org/review/12111
Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4 years agoLua: Switch URL to documentation to HTTPS
Uli Heilmeier [Thu, 26 Nov 2015 12:44:33 +0000 (13:44 +0100)]
Lua: Switch URL to documentation to HTTPS

URL to documentation with https as suggested by Alexis.
(s. commit ecc9c74326183e8d03eddfdbc1557919f3be6046)

Change-Id: I64d82b0c07cce5658eb8f4ae758f1a42946b837a
Reviewed-on: https://code.wireshark.org/review/12181
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoChange TCP transmission window full message
Michael Mann [Thu, 26 Nov 2015 12:22:01 +0000 (07:22 -0500)]
Change TCP transmission window full message

Bug: 11741
Change-Id: I2b3adc82bc44fd4e83e6f04b7e9bdcfaadf1b445
Reviewed-on: https://code.wireshark.org/review/12180
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoautotools: do not apply CFLAGS in reverse order
Peter Wu [Thu, 26 Nov 2015 10:26:13 +0000 (11:26 +0100)]
autotools: do not apply CFLAGS in reverse order

Fixes false "-Wvariadic-macros" because "-Wpedantic" came after
"-Wno-variadic-macros". While at it, avoid (unintentionally?) adding
-fPIE to all C++ programs (via CXXFLAGS).

Availability of flags is checked by appending a flag (in case the user
has something like CFLAGS=-Wno-error).

This removes a -fPIE check for CXXFLAGS and removes 5
-Woverlength-strings and 9 -Wvariadic-macros warnings from make with
Clang 3.7.0. configure and compile times were equal. (A diff between the
configure outputs showed no other changes.)

This reverts commit cf0d762d7304aa569ea25faf999c74bbe94f9023 and applies
a different approach.

Ping-Bug: 10791
Change-Id: Ic7b4137e2d98b06bc7625091be9bc7dd69182586
Reviewed-on: https://code.wireshark.org/review/12175
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agocmake: add asn1 target, avoid unnecessary rebuilds
Peter Wu [Tue, 24 Nov 2015 22:18:44 +0000 (23:18 +0100)]
cmake: add asn1 target, avoid unnecessary rebuilds

Add an "asn1" build target that rebuilds all ASN.1 dissectors.

Do not always generate the ASN.1 dissector when invoking the
"generate_dissector-PROTO" target. Use a special "packet-PROTO-stamp"
file to detect whether the dissector is out of date.

This indirection is needed because cmake removes output files from
add_custom_command in the clean target, but we would like to keep the
generated packet-PROTO.c files.

Make all EXTRA_CNF and EXPORT_DEPENDS point to absolute paths for
generated exported configs (PROTO-exp.cnf). This is done by automake too
and is needed for proper dependency tracking. Example: when h225.cnf is
updated, h225-exp.cnf needs to be generated. That is the purpose of the
"generate-h225-exp.cnf" target. Now h235 (and other) dissectors need to
be regenerated as well because the h225-exp.cnf is updated. This is why
there is a separate add_custom_command and add_custom_target.

Change-Id: I8cfc1f8f43cea595267b21eae30b4548f3407c0b
Reviewed-on: https://code.wireshark.org/review/12080
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoFix ISO C restricts enumerator values to range of 'int' [-Wpedantic]
João Valverde [Wed, 25 Nov 2015 19:18:13 +0000 (19:18 +0000)]
Fix ISO C restricts enumerator values to range of 'int' [-Wpedantic]

Change-Id: I0609d1920038feb47eae9cef9bce2ee80f9720b7
Reviewed-on: https://code.wireshark.org/review/12160
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoCompletely remove "old style" dissector support.
Michael Mann [Wed, 25 Nov 2015 15:11:53 +0000 (10:11 -0500)]
Completely remove "old style" dissector support.

The typedef for the "old style" has been removed as well as any old vs new style checks.

The release notes have been updated to reflect the API change, even though the search/replace of the "new style" function names hasn't happen yet.  But it will be coming shortly...

Change-Id: I6d1eeb51d30e3b2b27f0eafd85fe0ddc0ca25b14
Reviewed-on: https://code.wireshark.org/review/12153
Petri-Dish: Anders Broman <a.broman58@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoRemove use of APPEND_BOOLEAN_FLAG in favor of proto_tree_add_bitmask_with_flags.
Michael Mann [Wed, 25 Nov 2015 16:25:11 +0000 (11:25 -0500)]
Remove use of APPEND_BOOLEAN_FLAG in favor of proto_tree_add_bitmask_with_flags.

The "flags" used in proto_tree_add_bitmask-like functions can provide the same functionality of APPEND_BOOLEAN_FLAG, so it simplifies the dissector.

Change-Id: I7c87cbcc9b33588bc0eea6630e03b591f9f27fc8
Reviewed-on: https://code.wireshark.org/review/12145
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoL2TP: Correct L2TP over IP SHA1 message digest
Nicolas S. Dade [Thu, 26 Nov 2015 07:24:52 +0000 (23:24 -0800)]
L2TP: Correct L2TP over IP SHA1 message digest

It should match the MD5 code, and skip over the 0x00000000 session id
at the start of tvb.

Change-Id: Ia3bee2bd07015523acc49bd7cb0247c3f1ac986e
Reviewed-on: https://code.wireshark.org/review/12168
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoAdd BMT_NO_FLAGS for proto_tree_add_bitmask_XXX_with_flags.
Michael Mann [Thu, 26 Nov 2015 03:15:49 +0000 (22:15 -0500)]
Add BMT_NO_FLAGS for proto_tree_add_bitmask_XXX_with_flags.

This prevents some false positives for fix-encoding_args.pl which doesn't like constant values (like 0) passed as the last argument to any proto_tree_add_xxx call.

Change-Id: Iab7b09b425bf0d48126533daa0e65490bd7b8890
Reviewed-on: https://code.wireshark.org/review/12167
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoNSIS: refuse to install on Windows XP or Server 2003
Gerald Combs [Thu, 19 Nov 2015 22:34:39 +0000 (14:34 -0800)]
NSIS: refuse to install on Windows XP or Server 2003

Warn the user when installing on Windows Server 2003 along with XP.
CMake builds are not targeting them, and their support was officially
dropped with Wireshark 1.12.
Update our copy of GetWindowsVersion.nsh with "Alternate Script With
Server Versions" from http://nsis.sourceforge.net/Get_Windows_version.

Change-Id: I762859ea13e1ecd91757eeab360a39d1e6116144
Reviewed-on: https://code.wireshark.org/review/11972
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoSCTP: add another NULL dereference check
Pascal Quantin [Thu, 26 Nov 2015 08:23:06 +0000 (09:23 +0100)]
SCTP: add another NULL dereference check

This is a follow-up of g2259bf8

Change-Id: I4dfb839fcd016a8d7a7210e6358d230025eb96a3
Reviewed-on: https://code.wireshark.org/review/12171
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoAdd a check for the day of the month.
Guy Harris [Thu, 26 Nov 2015 08:02:12 +0000 (00:02 -0800)]
Add a check for the day of the month.

Also, fix the month check ("month" is in the range 1 through 12, not 0
through 11), and if neither sscanf() gets the right number of fields,
fail immediately.

Change-Id: I3f0da49e969c020c292facb843b9741116647302
Reviewed-on: https://code.wireshark.org/review/12170
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoQt: Redissect packets when changing profile
Stig Bjørlykke [Wed, 25 Nov 2015 19:51:09 +0000 (20:51 +0100)]
Qt: Redissect packets when changing profile

When changing profile the protocol/dissector preferences may change
so we need to redissect according to new settings.

We should probably have a preferences diff to check if a redissect
is needed, like it is in the preferences dialog.

Bug: 11757
Change-Id: I025bbc7297966986a697f2a6368d9a74e3c1ba72
Reviewed-on: https://code.wireshark.org/review/12156
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4 years agoDocument tvb_get_guintXXX and tvb_get_ieee_XXX
Michael Mann [Thu, 26 Nov 2015 02:40:43 +0000 (21:40 -0500)]
Document tvb_get_guintXXX and tvb_get_ieee_XXX

Change-Id: I498c0ca39befa0c0117ee78c23714bf7af193ce9
Reviewed-on: https://code.wireshark.org/review/12164
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agocmake: print the current CMAKE_C_FLAGS/CMAKE_CXX_FLAGS
Peter Wu [Wed, 25 Nov 2015 10:59:37 +0000 (11:59 +0100)]
cmake: print the current CMAKE_C_FLAGS/CMAKE_CXX_FLAGS

It is misleading to print RelWithDebInfo flags if I am using Debug.

Change-Id: I575d5c950cbe9d59852799c28fd88426f20cdaab
Reviewed-on: https://code.wireshark.org/review/12133
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years ago[RUDP] Use proto_tree_add_bitmask instead of something homegrown.
Michael Mann [Wed, 25 Nov 2015 20:18:02 +0000 (15:18 -0500)]
[RUDP] Use proto_tree_add_bitmask instead of something homegrown.

Also don't put calls to dissectors under an if (tree), even for the data dissector.

Change-Id: Ia897d7ae7aa61c89e92949225a54f40d56c1df74
Reviewed-on: https://code.wireshark.org/review/12155
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoReplace tvb_get_enctohl and tvb_get_enctohs with the functions already created in...
Michael Mann [Wed, 25 Nov 2015 19:11:06 +0000 (14:11 -0500)]
Replace tvb_get_enctohl and tvb_get_enctohs with the functions already created in tvbuff.h

Change-Id: Id44d4b11e0ba140f6ec4a8e87eaaa8eacbc2d8b6
Reviewed-on: https://code.wireshark.org/review/12151
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoRemove create_dissector_handle
Michael Mann [Wed, 25 Nov 2015 14:30:38 +0000 (09:30 -0500)]
Remove create_dissector_handle

Change-Id: I1ad7c112eda45a41c3f94b04348e328d44d8f585
Reviewed-on: https://code.wireshark.org/review/12152
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoMost fields in an ISO 8601 date/time are unsigned.
Guy Harris [Thu, 26 Nov 2015 03:01:07 +0000 (19:01 -0800)]
Most fields in an ISO 8601 date/time are unsigned.

Add some bounds checks while we're at it.

Change-Id: I19804aee10496fd68f95a27865f8f455d3abbe9f
Reviewed-on: https://code.wireshark.org/review/12166
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoISUP: fix a wrong removal of proto_tree_add_text()
Pascal Quantin [Wed, 25 Nov 2015 17:56:16 +0000 (18:56 +0100)]
ISUP: fix a wrong removal of proto_tree_add_text()

Bug: 11768
Change-Id: I42199f391f6559de88ce37104bd74a9f4be77e09
Reviewed-on: https://code.wireshark.org/review/12149
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoSCTP: verify frame pointer before dereferencing it
Pascal Quantin [Wed, 25 Nov 2015 16:53:30 +0000 (17:53 +0100)]
SCTP: verify frame pointer before dereferencing it

Bug: 11767
Change-Id: Icd01550e0aaa4cd0cc33ae3acc0ef702c38f4db4
Reviewed-on: https://code.wireshark.org/review/12146
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoPPP: RTP IPHC Compressed Non TCP packets and D bit zero packets (RFC 2507)
John A. Thacker [Wed, 25 Nov 2015 16:07:26 +0000 (11:07 -0500)]
PPP: RTP IPHC Compressed Non TCP packets and D bit zero packets (RFC 2507)

Add support for RFC 2507 style IP Header Compression Compressed Non TCP packets
(PPP protocol 0x0065). Also support RTP IPHC Full Header packets (protocol
0x0061) where the D bit is unset. Add expert info for when the D bit is unset
but the sequence number is nonzero.

Also fix an existing typo where the CUDP16 handle was being called for the
CUDP8 "ethertype" for NDISWAN (very rare.)

Bug: 11776
Change-Id: I9a7adcc5fdd4ee49bb75724142684043bd664111
Reviewed-on: https://code.wireshark.org/review/12143
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agowmem: add initializer (CID 1340194).
Dario Lombardo [Wed, 25 Nov 2015 16:00:26 +0000 (17:00 +0100)]
wmem: add initializer (CID 1340194).

Change-Id: I7b3d7a95af213a198b62c1475ba2125f8fe37ee6
Reviewed-on: https://code.wireshark.org/review/12142
Petri-Dish: Guy Harris <guy@alum.mit.edu>
Reviewed-by: Evan Huus <eapache@gmail.com>
4 years agoWPA (IEEE802.11) decryption function cleanups
Alexander Wetzel [Sun, 22 Nov 2015 13:01:23 +0000 (14:01 +0100)]
WPA (IEEE802.11) decryption function cleanups

 - Updated AirPDcapPacketProcess function description
 - Try to return better error codes
 - Remove broken/useless return of keys from AirPDcapRsna4WHandshake

Change-Id: I1e4e0a76f6d1307e11c0466f17935dd7030561e1
Reviewed-on: https://code.wireshark.org/review/12033
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoRTPS: feature to add a preference that enables the dissection
Juanjo Martin [Tue, 24 Nov 2015 17:59:54 +0000 (18:59 +0100)]
RTPS: feature to add a preference that enables the dissection
of the RTPS special announcements that RTI sends. They just start
by RTPX and are sent to the domain 0 always.

Bug: 11765
Change-Id: I00b47f1aa1702bb35aeb8c4686c7012fecc94baa
Reviewed-on: https://code.wireshark.org/review/12105
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoqt: move file close (CID 1159303)
Dario Lombardo [Wed, 25 Nov 2015 16:20:11 +0000 (17:20 +0100)]
qt: move file close (CID 1159303)

Change-Id: Ib21327babc77324313a1b3e2dd6ba0987a8fb333
Reviewed-on: https://code.wireshark.org/review/12144
Reviewed-by: Michael Mann <mmann78@netscape.net>
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoRemove 'filetap' residue from .gitignore
João Valverde [Wed, 25 Nov 2015 14:17:31 +0000 (14:17 +0000)]
Remove 'filetap' residue from .gitignore

Change-Id: Ica5aff181e3b5031bd0be59c71a6bfa485e5c199
Reviewed-on: https://code.wireshark.org/review/12148
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4 years agoTACACS: fix indent (and add modelines)
Alexis La Goutte [Wed, 25 Nov 2015 10:51:51 +0000 (11:51 +0100)]
TACACS: fix indent (and add modelines)

Change-Id: Ia8d52e9d8f8600c28988dd8d3cc11c7fe08943a3
Reviewed-on: https://code.wireshark.org/review/12131
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agocreate_dissector_handle -> new_create_dissector_handle for ASN.1 dissectors
Michael Mann [Tue, 24 Nov 2015 23:03:04 +0000 (18:03 -0500)]
create_dissector_handle -> new_create_dissector_handle for ASN.1 dissectors

Change-Id: I3d7a61a5ddd79b7bcbec5b9c515470848f413fd5
Reviewed-on: https://code.wireshark.org/review/12121
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoRequire BER dissector (OID) registration to be "new style".
Michael Mann [Tue, 24 Nov 2015 18:13:18 +0000 (13:13 -0500)]
Require BER dissector (OID) registration to be "new style".

Both old and new style API existed, just remove the "old" one.

Change-Id: If725e778a0ecad5a431d634ed5c4856b4a281013
Reviewed-on: https://code.wireshark.org/review/12107
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoasn2wrs.py: always use relative paths
Peter Wu [Tue, 24 Nov 2015 23:24:40 +0000 (00:24 +0100)]
asn2wrs.py: always use relative paths

Avoids absolute paths when using cmake and doing an in-tree build.

Before (source directory is /tmp/wireshark):

    /*--- Included file: /tmp/wireshark/asn1/t38/packet-t38-exp.h ---*/

After:

    /*--- Included file: packet-t38-exp.h ---*/

Change-Id: Id5c98bff7b97447479e1a09751701f2f52132b20
Reviewed-on: https://code.wireshark.org/review/12118
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years agoPress Start instead of Manage Interfaces on Enter
Peter Wu [Wed, 25 Nov 2015 11:51:35 +0000 (12:51 +0100)]
Press Start instead of Manage Interfaces on Enter

In the Capture Interfaces dialog, the default dialog action was
non-existing. Fix Extcap while at it (searched for "YesRole").

Reported on #wireshark at Freenode.

Change-Id: I7920b806a855acc20dcd2081f6b0d58e993b4ac1
Reviewed-on: https://code.wireshark.org/review/12136
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years agoFix memory leak in write_prefs
Mikael Kanstrup [Mon, 23 Nov 2015 15:33:42 +0000 (16:33 +0100)]
Fix memory leak in write_prefs

Valgrind reports leaks like these:
384 bytes in 8 blocks are definitely lost in loss record 43,909 of 46,703
  at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0xD6A055F: __vasprintf_chk (vasprintf_chk.c:80)
  by 0xA5FD0FB: g_vasprintf (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0xA5D8C7F: g_strdup_vprintf (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0xA5D8D1B: g_strdup_printf (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0x6854FA6: write_prefs (prefs.c:4941)
  by 0x733A9A: prefs_main_write (preference_utils.c:266)
  by 0x5F8A5C: CaptureInterfacesDialog::saveOptionsToPreferences() (capture_interfaces_dialog.cpp:851)
  by 0x5F93CD: CaptureInterfacesDialog::on_manage_clicked() (capture_interfaces_dialog.cpp:858)
  by 0x7182AC: CaptureInterfacesDialog::qt_static_metacall(QObject*, QMetaObject::Call, int, void**) (capture_interfaces_dialog.moc.cpp:316)
  by 0x718822: CaptureInterfacesDialog::qt_metacall(QMetaObject::Call, int, void**) (capture_interfaces_dialog.moc.cpp:413)
  by 0xBEBE36C: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)

When storing user preferences the constructed pathname of user's
preferences file is not freed properly.

Change-Id: I5cdc53ca836503af048e1d06e4614d83ef8921ac
Reviewed-on: https://code.wireshark.org/review/12114
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years agocreate_dissector_handle -> new_create_dissector_handle
Michael Mann [Wed, 25 Nov 2015 02:59:51 +0000 (21:59 -0500)]
create_dissector_handle -> new_create_dissector_handle

This finalizes the transformation for dissectors.

Change-Id: Ie5986b72bb69a6e8779ca3f5e20a80357c9e6fea
Reviewed-on: https://code.wireshark.org/review/12122
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoFix memory leak in capture_get_if_capabilities
Mikael Kanstrup [Mon, 23 Nov 2015 15:33:40 +0000 (16:33 +0100)]
Fix memory leak in capture_get_if_capabilities

Valgrind reports memory leaks like these:
154 bytes in 10 blocks are possibly lost in loss record 8,660 of 11,855
  at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0xBD9EA38: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
  by 0xBDB3358: g_strndup (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
  by 0xBDB49AD: g_strsplit (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3200.4)
  by 0x502291: capture_get_if_capabilities (capture_ifinfo.c:269)
  by 0x50A4CC: scan_local_interfaces (iface_lists.c:186)
  by 0x4C4BBD: refresh_local_interface_lists (capture_dlg.c:6117)
  by 0x504EC8: iface_mon_handler2 (iface_monitor.c:113)
  by 0xC9ADF1D: ??? (in /lib/libnl-3.so.200.3.0)
  by 0xC56DF19: ??? (in /usr/lib/libnl-route-3.so.200.3.0)
  by 0xC9ABE5E: nl_cache_parse (in /lib/libnl-3.so.200.3.0)
  by 0xC9AF5CA: nl_msg_parse (in /lib/libnl-3.so.200.3.0)

Under certain conditions raw_list variable was not freed properly.

Change-Id: Ibbaf0d67d983ee6912cfc9dc1a3169bc773b03c9
Reviewed-on: https://code.wireshark.org/review/12112
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoFix buffer overrun in zlib decompression
Peter Wu [Sun, 22 Nov 2015 17:16:46 +0000 (18:16 +0100)]
Fix buffer overrun in zlib decompression

After updating next_in (to remove the gzip header), avail_in must also
be updated. Failing to do makes zlib read past the input buffer. In
theory this would resukt in a buffer overrun of at most double the input
length, in practice zlib returns as soon as the compression fails (after
reading a few bytes).

Bug: 11548
Change-Id: If71691a2846338f46d866964a77cc4e74a9b61dd
Reviewed-on: https://code.wireshark.org/review/12038
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years agoFix memory leaks related to hide_interface function
Mikael Kanstrup [Mon, 23 Nov 2015 15:33:41 +0000 (16:33 +0100)]
Fix memory leaks related to hide_interface function

Valgrind report leaks like these:
6 bytes in 6 blocks are definitely lost in loss record 2,197 of 46,703
  at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0xA5C1610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0xA5D8B0E: g_strdup (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0x69A211: ManageInterfacesDialog::localAccepted() (manage_interfaces_dialog.cpp:454)
  by 0x69A500: ManageInterfacesDialog::on_buttonBox_accepted() (manage_interfaces_dialog.cpp:211)
  by 0x71DB32: ManageInterfacesDialog::qt_metacall(QMetaObject::Call, int, void**) (manage_interfaces_dialog.moc.cpp:245)
  by 0xBEBE36C: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
  by 0xBEBE2A5: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
  by 0xAF87E41: QAbstractButton::clicked(bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
  by 0xAD11095: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
  by 0xAD11BAD: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
  by 0xAD11D23: QAbstractButton::mouseReleaseEvent(QMouseEvent*) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)

96 bytes in 4 blocks are definitely lost in loss record 42,458 of 52,779
  at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
  by 0xA5C1610: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0xA5D722D: g_slice_alloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0xA5B84F3: g_list_append (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.4002.0)
  by 0x731F9A: hide_interface (iface_lists.c:426)
  by 0x69A211: ManageInterfacesDialog::localAccepted() (manage_interfaces_dialog.cpp:454)
  by 0x69A4F0: ManageInterfacesDialog::on_buttonBox_accepted() (manage_interfaces_dialog.cpp:211)
  by 0x71DB22: ManageInterfacesDialog::qt_metacall(QMetaObject::Call, int, void**) (manage_interfaces_dialog.moc.cpp:245)
  by 0xBEBE36C: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
  by 0xBEBE2A5: QMetaObject::activate(QObject*, int, int, void**) (in /usr/lib/x86_64-linux-gnu/libQt5Core.so.5.2.1)
  by 0xAF87E41: QAbstractButton::clicked(bool) (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)
  by 0xAD11095: ??? (in /usr/lib/x86_64-linux-gnu/libQt5Widgets.so.5.2.1)

These are caused by leaks inside hide_interface function and among
its users. Fixed by letting hide_interface function free its
resources properly and making sure the users follow the pattern.

Change-Id: I91527b83d36dc38b402d0f4a1db4b7db40fd83f9
Reviewed-on: https://code.wireshark.org/review/12113
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
4 years agoPrint guint64's with G_GUINT64_FORMAT.
Guy Harris [Wed, 25 Nov 2015 11:33:44 +0000 (03:33 -0800)]
Print guint64's with G_GUINT64_FORMAT.

There is no guarantee that they will be long's, and thus no guarantee
that they can be printed with "%lu".

Change-Id: I5c2ff844a1024332f01dec58489a2d304ba4e7ce
Reviewed-on: https://code.wireshark.org/review/12135
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agocmake: fix dependencies for copy_data_files
Peter Wu [Wed, 25 Nov 2015 10:08:16 +0000 (11:08 +0100)]
cmake: fix dependencies for copy_data_files

Ensure that files from INSTALL_FILES depend on html_docs, not the parent
target copy_data_files (that would not help at all). Ensure that lua
scripts are generated before copying them (another moved dependency).
Explicitly track the help files that have to be textified for Windows
(this finalizes the addition of proper dependencies to copy_data_files
targets).

Since there is no compelling reason for the extra
copy_data_files_depends target now, remove it and move copy_data_files a
bit further in the file such that the dependencies can be set.

While at it, remove the unnecessary make_directory, the copy_data_files
target will create it automatically when copying a file into it.

Should fix the problem reported at https://code.wireshark.org/review/12028

Change-Id: I81e56c93ac0fc85e7385605b9c780a80b3d43c85
Reviewed-on: https://code.wireshark.org/review/12130
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoDon't check whether the C++ compiler supports a flag if there isn't one.
Guy Harris [Wed, 25 Nov 2015 10:53:48 +0000 (02:53 -0800)]
Don't check whether the C++ compiler supports a flag if there isn't one.

If we didn't find a C++ compiler, we can't check whether the
non-existent C++ compiler supports a flag, so don't do so.

Change-Id: I3d3232acae2dfc40deb0b01f35656ef53c4f1640
Reviewed-on: https://code.wireshark.org/review/12132
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoLua: fix URL to documentation
Uli Heilmeier [Wed, 25 Nov 2015 09:17:18 +0000 (10:17 +0100)]
Lua: fix URL to documentation

The Lua reference has been moved from User's Guide to Developer's Guide.

Change-Id: I3489d774e54310ce49997e33d5318adf5e0bb2bc
Reviewed-on: https://code.wireshark.org/review/12128
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4 years agoFix copy-and-pasteo.
Guy Harris [Wed, 25 Nov 2015 08:49:16 +0000 (00:49 -0800)]
Fix copy-and-pasteo.

Presumably the intent was to check for either of the two "CRC dropped"
event types.

(CID 1340186.)

Change-Id: Ieea8f5ab80bebbdbb683998a6747e5130d46b92d
Reviewed-on: https://code.wireshark.org/review/12127
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoProfinet: All SubframeData elements are not decoded
Birol Capa [Tue, 24 Nov 2015 14:23:33 +0000 (16:23 +0200)]
Profinet: All SubframeData elements are not decoded

In PDevData/PDirSubframeData/SubframeBlock, not all SubframeData elements are decoded/shown.
However, all bytes of the SubframeBlock are highlighted in the binary stream correctly.

Change-Id: Ic69999dff524e2e0c48a619def111c4bf9cca5e1
Reviewed-on: https://code.wireshark.org/review/12100
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoUse try_val_to_str_ext() in print_uuid().
Guy Harris [Wed, 25 Nov 2015 06:21:15 +0000 (22:21 -0800)]
Use try_val_to_str_ext() in print_uuid().

That's a much cleaner way of determining whether you found no matchin
bluetooth_uuid_vals_ext than checking whether val_to_str_ext_const()
returned the "use this if unknown" value.

It also lets us avoid a wmem_strdup().

Make print_numeric_uuid() and print_uuid() return const gchar *; there's
no reason for them *not* to be const, and that means we don't have to
throw away constness.

Change-Id: I62fb0b81c64c107dfea6c16ca8c5b9593f8f2a9d
Reviewed-on: https://code.wireshark.org/review/12126
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoFix typo.
Guy Harris [Wed, 25 Nov 2015 06:00:07 +0000 (22:00 -0800)]
Fix typo.

Convert the if-chain to a switch() statement while we're at it; if it
had been one originally, the compiler would have reported that there
were duplicate cases and failed.

(CID 1340190.)

Change-Id: I297ab32c51842af889bd6bebe764c0e45d57cea0
Reviewed-on: https://code.wireshark.org/review/12125
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoProfinet: ARProperties that contains Combined Object Container Bit
Birol Capa [Tue, 24 Nov 2015 14:13:15 +0000 (16:13 +0200)]
Profinet: ARProperties that contains Combined Object Container Bit

New ARProperties has a bit that contains if usage of Combined Object Container is required or not.

Change-Id: Ia4420cdf161d79933fcc0d8ffb411c02bfe26f3b
Reviewed-on: https://code.wireshark.org/review/12098
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoCheck whether create_tempfile() fails.
Guy Harris [Wed, 25 Nov 2015 05:38:05 +0000 (21:38 -0800)]
Check whether create_tempfile() fails.

Thanks and a tip of the Hatlo hat to Coverity for finding this.

Change-Id: Ie9d4089443e52ef427e0cc8ae6e90a9d9787134e
Reviewed-on: https://code.wireshark.org/review/12123
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoNo declarations in the middle of code.
Guy Harris [Wed, 25 Nov 2015 02:48:47 +0000 (18:48 -0800)]
No declarations in the middle of code.

We crank up pedantic warnings enough that this provokes "warning: ISO
C90 forbids mixed declarations and code" on the OS X 10.5 buildbot.

Change-Id: Ic3962f20d85e3ed003b84b298f83d12c3ae25ea1
Reviewed-on: https://code.wireshark.org/review/12120
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoAvoid colliding definitions of wmem_tree_t.
Guy Harris [Tue, 24 Nov 2015 23:40:44 +0000 (15:40 -0800)]
Avoid colliding definitions of wmem_tree_t.

Change-Id: I643eae3c35f96591770ab03ce44a85c806f17e1c
Reviewed-on: https://code.wireshark.org/review/12119
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoRemove support for "old style" dissectors in PER API.
Michael Mann [Tue, 24 Nov 2015 18:34:11 +0000 (13:34 -0500)]
Remove support for "old style" dissectors in PER API.

Most of it wasn't used in current Wireshark source anyway.

Change-Id: If395e4e940adc76a2701d226ba4f7c9b17cb795d
Reviewed-on: https://code.wireshark.org/review/12108
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoIntroduces augmented interval trees
Matthieu Coudron [Wed, 11 Nov 2015 02:19:43 +0000 (03:19 +0100)]
Introduces augmented interval trees

Interval trees (wmem_itree_t) are implemented as an extension of wmem_tree with a
guint64-based range as the key.
This is useful for instance in MPTCP analysis, to look for packets
matching a range defined by a mapping across TCP subflows.

Change-Id: Iea706d44fe975e390a4191ad0257ef37d5c71525
Reviewed-on: https://code.wireshark.org/review/11714
Reviewed-by: Evan Huus <eapache@gmail.com>
Petri-Dish: Evan Huus <eapache@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Guy Harris <guy@alum.mit.edu>
4 years agoQt: Save preferences when hide/show columns
Stig Bjørlykke [Tue, 24 Nov 2015 19:06:00 +0000 (20:06 +0100)]
Qt: Save preferences when hide/show columns

To preserve the hide/show column settings between switching profiles
the settings have to be saved.

Change-Id: I6f72b2980be149676e1c1099a604c8c6d0d995bf
Reviewed-on: https://code.wireshark.org/review/12109
Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4 years agoVoIP: fix a null dereference when trying to retrieve the time of a T.38 tapped packet
Pascal Quantin [Tue, 24 Nov 2015 15:35:55 +0000 (16:35 +0100)]
VoIP: fix a null dereference when trying to retrieve the time of a T.38 tapped packet

Rather than trying to retrieve frame_data from the packet number row (while it could be filtered) let's use pinfo.

Bug: 11596
Change-Id: I53966bfdfbeb0c5918c3524f4b9748ea425fe8a5
Reviewed-on: https://code.wireshark.org/review/12103
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoQt: check that a file name was selected before trying to export follow content
Pascal Quantin [Tue, 24 Nov 2015 14:10:21 +0000 (15:10 +0100)]
Qt: check that a file name was selected before trying to export follow content

Bug: 11763
Change-Id: Iab117fe9f572eccc3cf88a9f3ff86a22aa0e33c9
Reviewed-on: https://code.wireshark.org/review/12099
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years agoArt-Net: Add missing ArtSync opcode
Ryan Mullen [Tue, 24 Nov 2015 15:18:16 +0000 (10:18 -0500)]
Art-Net: Add missing ArtSync opcode

Change-Id: I789219b4016507c7590598f4b04dd254abf13f5f
Reviewed-on: https://code.wireshark.org/review/12101
Reviewed-by: Anders Broman <a.broman58@gmail.com>
4 years agoRemove register_dissector.
Michael Mann [Tue, 24 Nov 2015 12:36:49 +0000 (07:36 -0500)]
Remove register_dissector.

new_register_dissector will eventually take its place, but that search/replace should be done when all "old style" APIs have been removed.

Change-Id: Ic3fdec67d5761fd72beeca7355f9de617562bb77
Reviewed-on: https://code.wireshark.org/review/12095
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoRemove the LDAP wrapping for registering dissectors and just use dissector_add_string...
Michael Mann [Tue, 24 Nov 2015 13:37:13 +0000 (08:37 -0500)]
Remove the LDAP wrapping for registering dissectors and just use dissector_add_string directly.

Change-Id: I307ee31562a5a84bc62691f367e3b8df3cb3f244
Reviewed-on: https://code.wireshark.org/review/12097
Petri-Dish: Michael Mann <mmann78@netscape.net>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoConvert T.124 API to use "new style" dissectors.
Michael Mann [Tue, 24 Nov 2015 13:22:57 +0000 (08:22 -0500)]
Convert T.124 API to use "new style" dissectors.

This seems like an unnecessary encapsulation of registering a dissector, but it can be used at runtime and not just a handoff function.

Change-Id: Ic13e34b5cecf493115f27a984bb886f2f76bc7de
Reviewed-on: https://code.wireshark.org/review/12096
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agoConvert XMPP dissector to "new style".
Michael Mann [Tue, 24 Nov 2015 12:01:26 +0000 (07:01 -0500)]
Convert XMPP dissector to "new style".

Wasn't sure if the absence/disabling of the XML dissector should prevent this dissector from doing anything, but left the current implementation that allows it mostly because XMPP has an IANA registered TCP port.

Change-Id: Ie08b262d611e4d9add9566f440e3d825d6b0b55c
Reviewed-on: https://code.wireshark.org/review/12094
Petri-Dish: Michael Mann <mmann78@netscape.net>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
4 years agosshdump: add default filter even when interfaces are not listed.
Dario Lombardo [Tue, 24 Nov 2015 09:20:10 +0000 (10:20 +0100)]
sshdump: add default filter even when interfaces are not listed.

Change-Id: I7fc6157a4ef0fff9b94f2ee222379f8d6d2962a9
Reviewed-on: https://code.wireshark.org/review/12090
Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4 years ago[Custom plugins] CUSTOM_PLUGIN_IN_FILES is no longer required.
AndersBroman [Tue, 24 Nov 2015 11:59:37 +0000 (12:59 +0100)]
[Custom plugins] CUSTOM_PLUGIN_IN_FILES is no longer required.

Change-Id: I329a26ece145d70221d47c728e11dca54416a5cf
Reviewed-on: https://code.wireshark.org/review/12092
Reviewed-by: Anders Broman <a.broman58@gmail.com>