13 years agoAdd redirects to the ICMP filter.
Gerald Combs [Mon, 13 Feb 2006 20:11:43 +0000 (20:11 -0000)]
Add redirects to the ICMP filter.

svn path=/trunk/; revision=17284

13 years agoRemove a couple of unused variables.
Gerald Combs [Mon, 13 Feb 2006 20:10:23 +0000 (20:10 -0000)]
Remove a couple of unused variables.

svn path=/trunk/; revision=17283

13 years agoFrom Mike Duigou:
Anders Broman [Mon, 13 Feb 2006 19:45:38 +0000 (19:45 -0000)]
From Mike Duigou:
- Improves ability of dissector to find conversations without seeing
whole stream.

- Fixes some issues with dissection of data which requires reassembly.

- Adds the ability to dissect jxta conversations from SCTP streams.

- Better handling of welcome message.

- Adds direct dissection of compressed SRDI data.

- Has been run through extensive fuzz testing.

- Fixes compiler warnings with previous patch 17141

svn path=/trunk/; revision=17282

13 years agoPaolo Abeni
Jörg Mayer [Mon, 13 Feb 2006 17:06:41 +0000 (17:06 -0000)]
Paolo Abeni

the attached patch fix a couple of possible memory leak in the ssl
decryption code, add some indentation fix, more comments and add the
preference to select the debug output (missing in previous patch)

svn path=/trunk/; revision=17281

13 years agoAdd tempfile.h to the list of headeer files. That was the problem, not
Guy Harris [Mon, 13 Feb 2006 01:30:03 +0000 (01:30 -0000)]
Add tempfile.h to the list of headeer files.  That was the problem, not
the pathname in the #include.

svn path=/trunk/; revision=17280

13 years agoLook for "tempfile.h" in the top-level directory.
Guy Harris [Sun, 12 Feb 2006 23:48:34 +0000 (23:48 -0000)]
Look for "tempfile.h" in the top-level directory.

svn path=/trunk/; revision=17279

13 years agoMove create_tempfile() to tempfile.c out of util.c. This means dumpcap
Guy Harris [Sun, 12 Feb 2006 21:52:18 +0000 (21:52 -0000)]
Move create_tempfile() to tempfile.c out of util.c.  This means dumpcap
no longer needs util.c, so it no longer includes routines that use
host_ip_af(), so it no longer needs to define its own host_ip_af().

That also means dumpcap.c no longer needs to include <sys/socket.h>.

svn path=/trunk/; revision=17278

13 years agoAt least on UN*X, the first argument - argv[0] - is supposed to be the
Guy Harris [Sun, 12 Feb 2006 20:55:11 +0000 (20:55 -0000)]
At least on UN*X, the first argument - argv[0] - is supposed to be the
name of the program as used to run it (command name/path name).  Pass
that - otherwise, we pass "-i" as argv[0], and dumpcap ignores it and
treats the capture device as the first argument and doesn't handle it
correctly (i.e., it doesn't capture on that device).

svn path=/trunk/; revision=17277

13 years agoDistinguish between pipe_read_block() returning 0 (EOF) or a negative
Guy Harris [Sun, 12 Feb 2006 20:41:28 +0000 (20:41 -0000)]
Distinguish between pipe_read_block() returning 0 (EOF) or a negative
value (error reading).

svn path=/trunk/; revision=17276

13 years agoInstead of using (commented-out) g_warning() calls to log errors reading
Guy Harris [Sun, 12 Feb 2006 20:35:15 +0000 (20:35 -0000)]
Instead of using (commented-out) g_warning() calls to log errors reading
and writing the sync pipe, using g_log() calls at the G_LOG_LEVEL_DEBUG
or G_LOG_LEVEL_WARNING levels, so we can get at them if necessary.  Add
some messages for errors for which we had no logging.

svn path=/trunk/; revision=17275

13 years agoSend LOG_DOMAIN_CAPTURE_CHILD messages to our log handler, so they don't
Guy Harris [Sun, 12 Feb 2006 20:17:55 +0000 (20:17 -0000)]
Send LOG_DOMAIN_CAPTURE_CHILD messages to our log handler, so they don't
go to the standard output (as is the case for some such messages,
including the "child is sending an error message to the parent" message,
which shows up if we fail to exec dumpcap).  *Anything* other than an
official capture-child message written to the standard output by the
capture child confuses the heck out of the parent, and can cause it to
think the child closed the pipe (resulting, in the case described in the
previous parenthetical note, in no dialog box being displayed for
dumpcap not being executed).

svn path=/trunk/; revision=17274

13 years agofuzz testing revealed that an infinite loop in the uma dissector was only partly...
Lars Roland [Sun, 12 Feb 2006 14:29:41 +0000 (14:29 -0000)]
fuzz testing revealed that an infinite loop in the uma dissector was only partly fixed in revision 17119.

This will fix the infinite loop and bug 738.

svn path=/trunk/; revision=17273

13 years agoadd rfc1964 stuff and (incomplete) KRB_CRED support.
Ronnie Sahlberg [Sun, 12 Feb 2006 13:18:48 +0000 (13:18 -0000)]
add   rfc1964 stuff and (incomplete) KRB_CRED support.

KRB_CRED does not currently even try to decrypt EncKrbCredPart   but it is better than no KRB_CRED dissection at all.

svn path=/trunk/; revision=17272

13 years agoWell, it doesn't help to apply patches and then forget to actually
Jörg Mayer [Sun, 12 Feb 2006 12:48:01 +0000 (12:48 -0000)]
Well, it doesn't help to apply patches and then forget to actually
commit them.
Patch by Paolo Abeni: remove some commented out code.

svn path=/trunk/; revision=17271

13 years agoadd a minor comment
Ulf Lamping [Sun, 12 Feb 2006 12:04:17 +0000 (12:04 -0000)]
add a minor comment

svn path=/trunk/; revision=17270

13 years agofreebsd needs to define AF_INET6, seems to need sys/socket.h
Ulf Lamping [Sun, 12 Feb 2006 11:35:02 +0000 (11:35 -0000)]
freebsd needs to define AF_INET6, seems to need sys/socket.h

svn path=/trunk/; revision=17269

13 years agoExport get_progfile_dir() and init_progfile_dir().
Guy Harris [Sun, 12 Feb 2006 04:35:15 +0000 (04:35 -0000)]
Export get_progfile_dir() and init_progfile_dir().

svn path=/trunk/; revision=17268

13 years agoAdd a routine to attempt to get the absolute pathname of the executable
Guy Harris [Sun, 12 Feb 2006 03:15:29 +0000 (03:15 -0000)]
Add a routine to attempt to get the absolute pathname of the executable
file, strip off the last component to get the pathname of the directory
containing the executable file, and save it for future use.  On Windows,
you can get that from the OS, but, on UN*X, you have to look at argv[0]
and derive the absolute path from that (argv[0] is not guaranteed to be
an absolute path, or even a path at all).  (In addition, if you're
running from the build directory, you might have to strip off a ".libs/"
added to argv[0] as an artifact of the libtoolizing script.)

Use that in the About dialog, and use it to construct the path of

Don't put quotes into the path of dumpcap; you don't have to quote
strings with spaces in them when handing them to execvp and, in fact,
you *mustn't* quote them, as the quotes will be treated as part of the

svn path=/trunk/; revision=17267

13 years agoRe-UTF-8-ify.
Guy Harris [Sun, 12 Feb 2006 02:04:23 +0000 (02:04 -0000)]

svn path=/trunk/; revision=17266

13 years ago"default on" for dumpcap generation (it's required at least for Ethereal's capturing...
Ulf Lamping [Sun, 12 Feb 2006 01:45:58 +0000 (01:45 -0000)]
"default on" for dumpcap generation (it's required at least for Ethereal's capturing now)

svn path=/trunk/; revision=17265

13 years agoadd generation of dumpcap manpage
Ulf Lamping [Sun, 12 Feb 2006 01:40:20 +0000 (01:40 -0000)]
add generation of dumpcap manpage

svn path=/trunk/; revision=17264

13 years agomark an unused parameter
Ulf Lamping [Sun, 12 Feb 2006 01:38:02 +0000 (01:38 -0000)]
mark an unused parameter

svn path=/trunk/; revision=17263

13 years agoFix up indentation.
Guy Harris [Sun, 12 Feb 2006 00:59:34 +0000 (00:59 -0000)]
Fix up indentation.

svn path=/trunk/; revision=17262

13 years agoAdd userdata arguments to a bunch of stat initialization routines to
Guy Harris [Sun, 12 Feb 2006 00:54:56 +0000 (00:54 -0000)]
Add userdata arguments to a bunch of stat initialization routines to
squelch compiler warnings.  Tag one existing such argument as unused to
squelch another warning.

Fix up some indentation.

svn path=/trunk/; revision=17261

13 years agowe still need sync_pipe_errmsg_to_parent() for the *NIX build
Ulf Lamping [Sun, 12 Feb 2006 00:03:10 +0000 (00:03 -0000)]
we still need sync_pipe_errmsg_to_parent() for the *NIX build

svn path=/trunk/; revision=17260

13 years agoadd dumpcap.exe and the corresponding HTML manpage to the distribution
Ulf Lamping [Sat, 11 Feb 2006 23:58:07 +0000 (23:58 -0000)]
add dumpcap.exe and the corresponding HTML manpage to the distribution

svn path=/trunk/; revision=17259

13 years agovarious capture child related minor cleanups
Ulf Lamping [Sat, 11 Feb 2006 23:47:03 +0000 (23:47 -0000)]
various capture child related minor cleanups

svn path=/trunk/; revision=17258

13 years agofont_init don't need to know if running as a capture_child, this will simply no longe...
Ulf Lamping [Sat, 11 Feb 2006 23:35:31 +0000 (23:35 -0000)]
font_init don't need to know if running as a capture_child, this will simply no longer happen.

svn path=/trunk/; revision=17257

13 years agothe point of no return ...
Ulf Lamping [Sat, 11 Feb 2006 23:25:11 +0000 (23:25 -0000)]
the point of no return ...

using dumpcap as the capture child for Ethereal.

dumpcap is a plain console application now, even for Win32 (so no WinMain, create_console and special piping stuff reguired). The undocumented command line option -Z will switch dumpcap into "child mode", using binary instead of plain text output messages to communicate with a parent Ethereal.

Ethereal's main.c no longer needs to distinguish between child mode or not, so some simplifying here.

capture_sync.c has to call dumpcap in a "hidden window" mode using CreateProcess instead of spawnvp, otherwise an uggly console window would appear. The handles created by _pipe doesn't seem to be inheritable for this function, using CreatePipe instead.

The file capture_loop.c is only needed by dumpcap, removed from Ethereal link objects.

Some debugging aid added and other minor cleanup done.

svn path=/trunk/; revision=17256

13 years agominor bugfix: restore the Ethereal icon (after capturing) at the right places
Ulf Lamping [Sat, 11 Feb 2006 17:08:32 +0000 (17:08 -0000)]
minor bugfix: restore the Ethereal icon (after capturing) at the right places

svn path=/trunk/; revision=17255

13 years agoThis was missing from last check-in
Luis Ontanon [Sat, 11 Feb 2006 15:22:43 +0000 (15:22 -0000)]
This was missing from last check-in

svn path=/trunk/; revision=17254

13 years agoPaolo Abeni:
Jörg Mayer [Sat, 11 Feb 2006 13:41:17 +0000 (13:41 -0000)]
Paolo Abeni:

The attached patch cleanup the debug infrastructure for ssl dissector.
Debug messages are by default off and can be enabled via the ssl
dissector preference. Debug output can be directed to stderr or file.

svn path=/trunk/; revision=17253

13 years ago add an userdata argument to register_stat_cmd_arg() and its callback to use the...
Luis Ontanon [Sat, 11 Feb 2006 13:05:24 +0000 (13:05 -0000)]
 add an userdata argument to register_stat_cmd_arg() and its callback to use the callback for multiple registrations.

svn path=/trunk/; revision=17252

13 years agoIn "Save As", support only file types we can write to; that simplifies
Guy Harris [Sat, 11 Feb 2006 11:21:38 +0000 (11:21 -0000)]
In "Save As", support only file types we can write to; that simplifies
the logic, making it easier to get it right (fewer interactions between
components of the dialog - the file type doesn't affect whether we can
save some but not all packets).  It also means we don't offer a file
type for saving, only to take it away if you choose anything other than
saving all packets.

If the capture file is a temporary file from a capture done in the
current Ethereal session, it's libpcap format, which we can write to, so
you would be able to save it.

If it's a saved file we read in, saving the file in its entirety in its
own format is just copying the file, and it's not clear supporting that
adds enough useful functionality to justify the extra complication.

Fix "range_update_dynamics()" to update all the rows of the range
button/count table properly (make the button active iff there's
a non-zero count in the currently-selected column, make a count active
iff the column is selected), to select the "Captured" column if the
count of displayed packets goes to zero, and to select the "Save all
packets" row if the count of packets in the currently-selected row and
column goes to zero.  (XXX - we should perhaps do that with the
"user-defined range" counts as well, which would involve updating the
counts on every change to the range field.)

svn path=/trunk/; revision=17251

13 years agoSquelch some compiler warnings.
Guy Harris [Sat, 11 Feb 2006 09:54:10 +0000 (09:54 -0000)]
Squelch some compiler warnings.

svn path=/trunk/; revision=17250

13 years agoSquelch some compiler warnings by declaring RADIUS AVP dissectors to
Guy Harris [Sat, 11 Feb 2006 09:50:11 +0000 (09:50 -0000)]
Squelch some compiler warnings by declaring RADIUS AVP dissectors to
return pointers to const strings.

svn path=/trunk/; revision=17249

13 years agoDisplay g_error messages in the console window unconditionally, if preferences aren...
Lars Roland [Sat, 11 Feb 2006 03:50:25 +0000 (03:50 -0000)]
Display g_error messages in the console window unconditionally, if preferences aren't loaded yet.
This way we ensure that errors are displayed during protocol registration.

Use g_error instead of g_warning, if not allowed characters are used in display filter names for protocols. Extend the error message in this case.

svn path=/trunk/; revision=17248

13 years agoFrom ENDOH Akira:
Luis Ontanon [Sat, 11 Feb 2006 00:13:23 +0000 (00:13 -0000)]
From ENDOH Akira:
  Add heuristic dissection of XML to SIP bodies with unknown media_type.

svn path=/trunk/; revision=17247

13 years agotcp analysis
Ronnie Sahlberg [Fri, 10 Feb 2006 22:24:21 +0000 (22:24 -0000)]
tcp analysis

RST segments should not be checked for and not marked as

svn path=/trunk/; revision=17246

13 years agoWhen using GTK 2.8, we need the cairo dlls, so add them to the install-gtk2-deps...
Lars Roland [Fri, 10 Feb 2006 14:13:06 +0000 (14:13 -0000)]
When using GTK 2.8, we need the cairo dlls, so add them to the install-gtk2-deps target

svn path=/trunk/; revision=17245

13 years agoFrom Paolo Abeni:
Anders Broman [Fri, 10 Feb 2006 13:20:11 +0000 (13:20 -0000)]
From Paolo Abeni:
 The attached patch fix bug 732.
 The problem was in the client key dissection. On ssl v3 the encrypted
 data is the whole record data, on tls v1 the encrypted data is preceded
 by the 2 bytes length of the encrypted data itself.

svn path=/trunk/; revision=17244

13 years agoThe target is called eug_html_chunked not eug_htmlchunk
Ulf Lamping [Fri, 10 Feb 2006 09:27:32 +0000 (09:27 -0000)]
The target is called eug_html_chunked not eug_htmlchunk

The pdf (and chm) targets are called differently in the two Makefiles (user-guide... vs. eug...), and I don't know which one is better (while keeping in mind that this will require changes in the documentation and elsewhere as well if we change it).

svn path=/trunk/; revision=17243

13 years agoASF messages are in big-endian byte order, not little. From Alert
Tim Potter [Fri, 10 Feb 2006 04:45:32 +0000 (04:45 -0000)]
ASF messages are in big-endian byte order, not little.  From Alert
Standard Format Specification, v2.0, p.51.

svn path=/trunk/; revision=17242

13 years agoAdd newline to end of file to quiten compiler warning.
Tim Potter [Fri, 10 Feb 2006 02:10:33 +0000 (02:10 -0000)]
Add newline to end of file to quiten compiler warning.

svn path=/trunk/; revision=17241

13 years agoremove all calls to exit() from the capture_opts.c and replace them by status return...
Ulf Lamping [Fri, 10 Feb 2006 02:05:30 +0000 (02:05 -0000)]
remove all calls to exit() from the capture_opts.c and replace them by status return values (0,1 or 2).

This way makes it much easier to debug, e.g. to set a common breakpoint if a command line parameter fails.

svn path=/trunk/; revision=17240

13 years agoonly a backup, nothing changed for now.
Ulf Lamping [Fri, 10 Feb 2006 01:27:23 +0000 (01:27 -0000)]
only a backup, nothing changed for now.

second try to bring dumpcap to life. Currently it's working, but the child (dumpcap) will show an annoying Win32 console window while running.

svn path=/trunk/; revision=17239

13 years agosome improvements in the console output handling
Ulf Lamping [Fri, 10 Feb 2006 01:18:24 +0000 (01:18 -0000)]
some improvements in the console output handling

svn path=/trunk/; revision=17238

13 years agoadd dumpcap manual page
Ulf Lamping [Thu, 9 Feb 2006 21:49:02 +0000 (21:49 -0000)]
add dumpcap manual page

svn path=/trunk/; revision=17237

13 years agoWin32 inconvenience: a call to g_error will terminate the program and the user won...
Ulf Lamping [Thu, 9 Feb 2006 21:37:14 +0000 (21:37 -0000)]
Win32 inconvenience: a call to g_error will terminate the program and the user won't see anything.

To avoid this, the log handler in the error case:

- opens a console window (regardless of the users settings)
- waits for a keypress before continuing to terminate the program

This way, the user will be notified that there's a problem, instead of simply seeing a terminating program only.

svn path=/trunk/; revision=17236

13 years agofix# 733: don't crash on unknown msg_types
Ulf Lamping [Thu, 9 Feb 2006 21:02:02 +0000 (21:02 -0000)]
fix# 733: don't crash on unknown msg_types

svn path=/trunk/; revision=17235

13 years agoRe-enable the PacketCable RADIUS code and add a few EM updates.
Gerald Combs [Thu, 9 Feb 2006 20:24:57 +0000 (20:24 -0000)]
Re-enable the PacketCable RADIUS code and add a few EM updates.
Sponsored by CableLabs.

svn path=/trunk/; revision=17233

13 years agoAdd PacketCable Multimedia updates. Sponsored by CableLabs.
Gerald Combs [Thu, 9 Feb 2006 19:41:20 +0000 (19:41 -0000)]
Add PacketCable Multimedia updates.  Sponsored by CableLabs.

svn path=/trunk/; revision=17232

13 years agontp_fmt_ts() doesn't take two arguments any more.
Gerald Combs [Thu, 9 Feb 2006 19:22:15 +0000 (19:22 -0000)]
ntp_fmt_ts() doesn't take two arguments any more.

svn path=/trunk/; revision=17231

13 years agoAdd support for PacketCable CCC-encapsulated RTP data, described in
Gerald Combs [Thu, 9 Feb 2006 17:42:42 +0000 (17:42 -0000)]
Add support for PacketCable CCC-encapsulated RTP data, described in

Sponsored by CableLabs.

svn path=/trunk/; revision=17230

13 years agoAdd decryption support. For this to work, you MUST link against
Gerald Combs [Thu, 9 Feb 2006 17:32:14 +0000 (17:32 -0000)]
Add decryption support.  For this to work, you MUST link against
the Nettle library and specify a Pluto log file in the preferences.
The Pluto log MUST include the encryption key used in each phase.

Add filters for many fields (and get rid of a lot of
proto_tree_add_text()s in the process).

Fix up whitespace.

Sponsored by CableLabs.

svn path=/trunk/; revision=17229

13 years agoAdd heuristic dissection of XML
Luis Ontanon [Thu, 9 Feb 2006 13:05:32 +0000 (13:05 -0000)]
Add heuristic dissection of XML

svn path=/trunk/; revision=17228

13 years agoRicardo Muggli:
Jörg Mayer [Thu, 9 Feb 2006 09:18:15 +0000 (09:18 -0000)]
Ricardo Muggli:

The attached patch will fix ethereal so it will only do network address
resolution when network address resolution is enabled. Even when the
RESOLV_NETWORK flag was set ethereal would try to resolve addresses in
the add_ether_byip function.

svn path=/trunk/; revision=17227

13 years agoHannes Gredler:
Jörg Mayer [Thu, 9 Feb 2006 09:15:21 +0000 (09:15 -0000)]
Hannes Gredler:

attached a patch that supports filtering for
Juniper's meta information prepended
before packets (logical encapsulation, ifd index etc.)


declare juniper_ext_get_tlv_value static

svn path=/trunk/; revision=17226

13 years agoOlivier Montanuy:
Jörg Mayer [Thu, 9 Feb 2006 09:11:06 +0000 (09:11 -0000)]
Olivier Montanuy:

This is a simple patch to the Netflow v9 dissector, that let it decode
Netflow v9 MPLS-Aware, a feature of Cisco 12000 IOS 12.0.24S and above
on Cisco 12000, 7500 and 7200 that is very useful for MPLS-VPN networks.

svn path=/trunk/; revision=17225

13 years agoFrom Bill Meier
Lars Roland [Thu, 9 Feb 2006 07:03:54 +0000 (07:03 -0000)]
From Bill Meier
The following patch prevents a windows nmake of Ethereal from
relinking libethereal.dll
when DOXYGEN is not defined in config.nmake and
there are no changes to libethereal.dll dependents.

svn path=/trunk/; revision=17224

13 years agoremove a duplicated name
Lars Roland [Thu, 9 Feb 2006 06:57:25 +0000 (06:57 -0000)]
remove a duplicated name

svn path=/trunk/; revision=17223

13 years agoExport the right name.
Guy Harris [Thu, 9 Feb 2006 06:47:29 +0000 (06:47 -0000)]
Export the right name.

svn path=/trunk/; revision=17222

13 years agoAdd "proto_tree_add_XXX_format_value()" routines, which are like the
Guy Harris [Thu, 9 Feb 2006 04:18:23 +0000 (04:18 -0000)]
Add "proto_tree_add_XXX_format_value()" routines, which are like the
"proto_tree_add_XXX_format()" routines except that the format doesn't
have to include the field name - the field name, followed by ": ", are
put into the representation string, followed by the result of the
formatting, so you just format the value with the format string, not the
entire representation.

svn path=/trunk/; revision=17221

13 years ago* DissectorTable.add does not allow to add lua protocols that don't have a dissector.
Luis Ontanon [Wed, 8 Feb 2006 23:26:52 +0000 (23:26 -0000)]
* DissectorTable.add does not allow to add lua protocols that don't have a dissector.
* ProtoFiled.uint checks the base to be a valid value to avoid an assertion in proto.c while registering the field array
* save one lua table lookup by using a reference to the dissectors table instead of looking for it by name
* set data_hanlde's value to avoid a crash while invoking it.
* make the TvbRange of Tree:add_item really optional.

svn path=/trunk/; revision=17220

13 years agoAdd support for PacketCable option 60/suboption 5.23. Sponsored by
Gerald Combs [Wed, 8 Feb 2006 23:09:17 +0000 (23:09 -0000)]
Add support for PacketCable option 60/suboption 5.23.  Sponsored by

svn path=/trunk/; revision=17219

13 years agoInclude glib.h, so FALSE is defined when compiling statically.
Jörg Mayer [Wed, 8 Feb 2006 17:04:21 +0000 (17:04 -0000)]
Include glib.h, so FALSE is defined when compiling statically.

svn path=/trunk/; revision=17218

13 years agoPaolo Abeni:
Jörg Mayer [Wed, 8 Feb 2006 12:45:14 +0000 (12:45 -0000)]
Paolo Abeni:

the attached patch clean a bit the ssl decryption related code, removing
a macro I used when the code was still for an external plugin.

svn path=/trunk/; revision=17217

13 years agoCall "get_credential_info()", so any later calls to privileges.c
Guy Harris [Wed, 8 Feb 2006 10:22:20 +0000 (10:22 -0000)]
Call "get_credential_info()", so any later calls to privileges.c
routines will have the UID info (not that it matters in this case,

svn path=/trunk/; revision=17216

13 years agosmb2:
Ronnie Sahlberg [Wed, 8 Feb 2006 08:48:23 +0000 (08:48 -0000)]
if the secblob starts with 'NTLMSSP'   call the ntlmssp handle directly and not the gssapi one

dont change offset when dissecting a client_time,   offset will be changed properly later outside the switch.

svn path=/trunk/; revision=17215

13 years agoFix up some comments.
Guy Harris [Wed, 8 Feb 2006 03:25:22 +0000 (03:25 -0000)]
Fix up some comments.

svn path=/trunk/; revision=17214

13 years agoClean up the comments for files_identical(), and fix up the UNIX
Guy Harris [Wed, 8 Feb 2006 02:06:09 +0000 (02:06 -0000)]
Clean up the comments for files_identical(), and fix up the UNIX
implementation to check whether the stat calls succeed and to check not
only that the files have the same inumber but that they also are on the
same file system.

svn path=/trunk/; revision=17213

13 years agoTry to fix a grammar error in the XML code I added for -X
Luis Ontanon [Wed, 8 Feb 2006 00:31:33 +0000 (00:31 -0000)]
Try to fix a grammar error in the XML code I added for -X

svn path=/trunk/; revision=17212

13 years agoMake file_exists() work on macosx (and other unices)
Luis Ontanon [Wed, 8 Feb 2006 00:06:38 +0000 (00:06 -0000)]
Make file_exists() work on macosx (and other unices)

svn path=/trunk/; revision=17211

13 years agoChanged how files are loaded.
Luis Ontanon [Wed, 8 Feb 2006 00:02:15 +0000 (00:02 -0000)]
Changed how files are loaded.

load $ETH/init.lua if it exists
if we are not runninig on special privileges
  load $USER/init.lua
  and then all the files given with cmd line option -X lua_script:file.lua

svn path=/trunk/; revision=17210

13 years agosvn:keywords and svn:eol-style
Luis Ontanon [Tue, 7 Feb 2006 22:18:05 +0000 (22:18 -0000)]
svn:keywords and svn:eol-style

svn path=/trunk/; revision=17209

13 years agoForgotten from last commit
Luis Ontanon [Tue, 7 Feb 2006 22:11:01 +0000 (22:11 -0000)]
Forgotten from last commit

svn path=/trunk/; revision=17208

13 years agoeXtenstion options access to the -X command line options
Luis Ontanon [Tue, 7 Feb 2006 22:08:12 +0000 (22:08 -0000)]
eXtenstion options access to the -X command line options

svn path=/trunk/; revision=17207

13 years agosmb2 signing
Ronnie Sahlberg [Tue, 7 Feb 2006 21:30:21 +0000 (21:30 -0000)]
smb2 signing

add dissection of the "Signature present" bit
and the 16 byte signature field in the header

svn path=/trunk/; revision=17206

13 years agoNewlines in preference comments causes problems in reading the prefeerence file.
Anders Broman [Tue, 7 Feb 2006 19:31:54 +0000 (19:31 -0000)]
Newlines in preference comments causes problems in reading the prefeerence file.

svn path=/trunk/; revision=17205

13 years agoPacket-bssap.c - Dissect BCD coded IE:s
Anders Broman [Tue, 7 Feb 2006 19:29:51 +0000 (19:29 -0000)]
Packet-bssap.c - Dissect BCD coded IE:s
Packet-g723.c - B0 and B1 should be treated together.
packet-tipc.c - Change desgementation code to handle more than 2 segments.

svn path=/trunk/; revision=17204

13 years agoadd the CLIENT_TIME ntlmv2 addr name type
Ronnie Sahlberg [Tue, 7 Feb 2006 12:50:58 +0000 (12:50 -0000)]
add the CLIENT_TIME ntlmv2 addr name type

svn path=/trunk/; revision=17203

13 years agohandmerged patch from metze it conflicted with recent P bit patch i checked in
Ronnie Sahlberg [Tue, 7 Feb 2006 12:01:34 +0000 (12:01 -0000)]
handmerged patch from metze it conflicted with recent P bit patch i checked in

svn path=/trunk/; revision=17202

13 years agorename Logoff to SessionLogoff to make it consistent with
Ronnie Sahlberg [Tue, 7 Feb 2006 11:32:10 +0000 (11:32 -0000)]
rename Logoff to SessionLogoff   to make it consistent with

svn path=/trunk/; revision=17201

13 years agoPaolo Abeni:
Jörg Mayer [Tue, 7 Feb 2006 10:26:20 +0000 (10:26 -0000)]
Paolo Abeni:

>There is still an issue into the HAVE_LIBGNUTLS macro definition. I'm
>fixing it and cleaning a bit the windows side configuration. I hope to
>post soon the fix.

The attached patch should fix the issue. I missed to modify the
config.win32 file and I misstyped a few macros name.

svn path=/trunk/; revision=17200

13 years agoPeter Kjellerstedt:
Jörg Mayer [Tue, 7 Feb 2006 10:22:41 +0000 (10:22 -0000)]
Peter Kjellerstedt:

GTK_WRAP_WORD_CHAR does not exist in old versions of GTK2+
(2.2.1 and earlier).  The following patch should make it
compile again (solution borrowed from GAIM).

svn path=/trunk/; revision=17199

13 years agolua autofoo:
Jörg Mayer [Tue, 7 Feb 2006 09:49:38 +0000 (09:49 -0000)]
lua autofoo:

- Fail if with-lua was given but liblualib is missing
- Make the test for liblualib succeed on my system
  (make sure the test gets linked with liblua and libm).

svn path=/trunk/; revision=17198

13 years agoadd dissection of the P (PID Valid) bit in the header
Ronnie Sahlberg [Tue, 7 Feb 2006 09:28:02 +0000 (09:28 -0000)]
add dissection of the P (PID Valid) bit in the header

If the P bit is NOT set, then flag the PID field as "(not valid)"
Sicne the TID might be undefined/0 in the response to a "pending" read
we cant use that solely to determine if a read was for a named/pipe (==dcerpc)
Assume that only NamedPipe reads can be STATUS_PENDING and thus have the P bit set and assume it IS dcerpc if the P bit is set.

svn path=/trunk/; revision=17197

13 years agochanges to build lua plugin with MSVC6:
Lars Roland [Tue, 7 Feb 2006 09:12:43 +0000 (09:12 -0000)]
changes to build lua plugin with MSVC6:
- nmake makefile for lua plugin added.
- declare variables at the beginning of a function.
- proto_reg_handoff_lua was removed, remove remaining calls, too.
- missing functions to libethereal.def added.

add lua plugin to installer, if available.

svn path=/trunk/; revision=17196

13 years agoadd dissection of
Ronnie Sahlberg [Tue, 7 Feb 2006 08:48:51 +0000 (08:48 -0000)]
add dissection of
SMB/SetFileInfo level 1023
SMB2/SetInfo/FILE_INFO level 0x17

FILE_PIPE_INFO   infolevel

svn path=/trunk/; revision=17195

13 years agoDissect channel needed.
Anders Broman [Tue, 7 Feb 2006 04:57:30 +0000 (04:57 -0000)]
Dissect channel needed.

svn path=/trunk/; revision=17194

13 years agoAdd a RFC value.
Anders Broman [Tue, 7 Feb 2006 04:56:37 +0000 (04:56 -0000)]
Add a RFC value.

svn path=/trunk/; revision=17193

13 years agoinit_routines was moved back to globals.
Luis Ontanon [Tue, 7 Feb 2006 03:47:13 +0000 (03:47 -0000)]
init_routines was moved back to globals.

svn path=/trunk/; revision=17192

13 years agoI Noticed a crash when registering a tap with filter during handoff (that's when...
Luis Ontanon [Tue, 7 Feb 2006 03:06:02 +0000 (03:06 -0000)]
I Noticed a crash when registering a tap with filter during handoff (that's when I had lua starting) trying to see if I could move dfilter_init() before protocol registration I discovered register_final_registration_routine() neat!

Lua protocols won't need a handoff routine anymore!!

svn path=/trunk/; revision=17191

13 years ago+ gui_enabled()
Luis Ontanon [Mon, 6 Feb 2006 23:58:07 +0000 (23:58 -0000)]
+ gui_enabled()
* make  the gui routines call-able since the first line of the script

svn path=/trunk/; revision=17190

13 years ago- fix a leak
Luis Ontanon [Mon, 6 Feb 2006 23:54:54 +0000 (23:54 -0000)]
- fix a leak
- register the funnel mini-api ASAP

svn path=/trunk/; revision=17189

13 years agoForgot to add ssl-dlg.h to the distro
Jörg Mayer [Mon, 6 Feb 2006 15:47:05 +0000 (15:47 -0000)]
Forgot to add ssl-dlg.h to the distro

svn path=/trunk/; revision=17188

13 years agoPaolo Abeni
Jörg Mayer [Mon, 6 Feb 2006 15:00:49 +0000 (15:00 -0000)]
Paolo Abeni

the attached patch set correctly the title of the 'Follow SSL stream'
dialog, to fix one issue reported by Nail Devis.
Unfortunaly there isn't an easy way to enable the 'Follow SSL stream'
dialog only for ssl session without knowing the value of proto_ssl (the
ssl protocol id), because the ssl dissector can run on user specified
ports (configured via preferences)

svn path=/trunk/; revision=17187

13 years agoprettify class/infolevel for GetInfo/SetInfo
Ronnie Sahlberg [Mon, 6 Feb 2006 13:17:11 +0000 (13:17 -0000)]
prettify class/infolevel for GetInfo/SetInfo

svn path=/trunk/; revision=17186

13 years agofix some variable declarations bugs (code not conforming to ANSI-C)
Ulf Lamping [Mon, 6 Feb 2006 13:06:15 +0000 (13:06 -0000)]
fix some variable declarations bugs (code not conforming to ANSI-C)

svn path=/trunk/; revision=17185

13 years agoDeclare -ssl_stream_cb in ssl-dlg.h
Jörg Mayer [Mon, 6 Feb 2006 12:41:58 +0000 (12:41 -0000)]
Declare -ssl_stream_cb in ssl-dlg.h

svn path=/trunk/; revision=17184