dcerpc-spoolss: use value_name variable to store string (CID: 1158734).

Change-Id: I30780134b3d8a8e48b8b4997ea27ce82171b4508
Reviewed-on: https://code.wireshark.org/review/25069
Petri-Dish: Dario Lombardo <lomato@gmail.com>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>

diff --git a/epan/dissectors/packet-dcerpc-spoolss.c b/epan/dissectors/packet-dcerpc-spoolss.c
index 5191c9fab1a3b66bdb4c83a791bac2da1608f709..5145f2ebb6532971b73f0aae0e1ffbe767d38400 100644 (file)
--- a/epan/dissectors/packet-dcerpc-spoolss.c
+++ b/epan/dissectors/packet-dcerpc-spoolss.c
@@ -781,13 +781,11 @@ SpoolssGetPrinterData_q(tvbuff_t *tvb, int offset,
        value_name = NULL;
        offset = dissect_ndr_cvstring(
                tvb, offset, pinfo, tree, di, drep, sizeof(guint16),
-               hf_printerdata_value, TRUE, NULL);
+               hf_printerdata_value, TRUE, &value_name);
        /* GetPrinterData() stores the printerdata in se_data */
        if(!pinfo->fd->flags.visited){
-               if(!dcv->se_data){
-                       if(value_name){
-                               dcv->se_data = wmem_strdup(wmem_file_scope(), value_name);
-                       }
+               if(!dcv->se_data && value_name){
+                       dcv->se_data = wmem_strdup(wmem_file_scope(), value_name);
                }
        }