sharkd: check for NULL before dereference (found by clang).
authorDario Lombardo <lomato@gmail.com>
Tue, 16 Jan 2018 11:43:34 +0000 (12:43 +0100)
committerAlexis La Goutte <alexis.lagoutte@gmail.com>
Thu, 18 Jan 2018 06:07:13 +0000 (06:07 +0000)
Change-Id: If49504b3360e325555a624b11a43ac30884748c9
Reviewed-on: https://code.wireshark.org/review/25337
Petri-Dish: Jakub Zawadzki <darkjames-ws@darkjames.pl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
sharkd_session.c

index fbae19fd02a5bd696da860e1e7de74db9a579391..2453b1311ce2a898e7be14493d8d465462763c7b 100644 (file)
@@ -1101,6 +1101,9 @@ sharkd_session_packet_tap_expert_cb(void *tapdata, packet_info *pinfo _U_, epan_
        expert_info_t *ei             = (expert_info_t *) pointer;
 
        ei = (expert_info_t *) g_memdup(ei, sizeof(*ei));
+       if (ei == NULL)
+               return FALSE;
+
        ei->protocol = g_string_chunk_insert_const(etd->text, ei->protocol);
        ei->summary  = g_string_chunk_insert_const(etd->text, ei->summary);