Properly check the return value of color_filters_set_tmp().
authorGuy Harris <guy@alum.mit.edu>
Tue, 9 Feb 2016 21:17:18 +0000 (13:17 -0800)
committerGuy Harris <guy@alum.mit.edu>
Tue, 9 Feb 2016 21:18:02 +0000 (21:18 +0000)
It returns FALSE, not TRUE, on failure.

Bug: 12101
Change-Id: I2fb4f407d2040e7b84f17af197de81555d64c647
Reviewed-on: https://code.wireshark.org/review/13857
Reviewed-by: Guy Harris <guy@alum.mit.edu>
ui/qt/main_window_slots.cpp

index 1069fa9427309f9b7b1f8a5e66026f5af52f1b63..0c163f7de8781a41b6b1fd0f9e0cbb4a821ed145 100644 (file)
@@ -2390,7 +2390,7 @@ void MainWindow::colorizeWithFilter()
     if (ok) {
         // Assume "Color X"
         gchar *err_msg = NULL;
-        if (color_filters_set_tmp(color_number, filter.toUtf8().constData(), FALSE, &err_msg)) {
+        if (!color_filters_set_tmp(color_number, filter.toUtf8().constData(), FALSE, &err_msg)) {
             simple_dialog(ESD_TYPE_ERROR, ESD_BTN_OK, "%s", err_msg);
             g_free(err_msg);
         }