Revert "Pass all arguments to options as --option=argument."
authorGuy Harris <guy@alum.mit.edu>
Thu, 26 Jul 2018 21:42:28 +0000 (21:42 +0000)
committerGuy Harris <guy@alum.mit.edu>
Thu, 26 Jul 2018 21:43:24 +0000 (21:43 +0000)
This reverts commit 137d45f52c6ff3deb56721a6e37be5c4ed8f095a.

Don't. Make. The. Argument. To. Your. Extcap. Program. Specific.
Options. Optional. (Unless they're Boolean, in which case we never
pass an argument - we just pass the option if it's true and don't
pass it if it's false.)

Change-Id: I11e4ecaa196fd94c493d51e1f73e90267e1d9b1d
Reviewed-on: https://code.wireshark.org/review/28866
Reviewed-by: Guy Harris <guy@alum.mit.edu>
extcap.c

index 4a61ad536bf53796bb478cc8f2b239908e87fe9d..1744655685cc53fcab51df8600129685484c7b09 100644 (file)
--- a/extcap.c
+++ b/extcap.c
@@ -1355,11 +1355,8 @@ GPtrArray *extcap_prepare_arguments(interface_options *interface_opts)
                     else
                     {
                         if (stored && strlen(stored) > 0) {
-                            char *argstring;
-
-                            argstring = g_strdup_printf("%s=%s", arg_iter->call, stored);
-                            add_arg(argstring);
-                            g_free(argstring);
+                            add_arg(arg_iter->call);
+                            add_arg(stored);
                         }
                     }