androiddump: There is no need to make full copy optarg
authorMichal Labedzki <michal.labedzki@tieto.com>
Tue, 22 Dec 2015 10:51:17 +0000 (11:51 +0100)
committerMichael Mann <mmann78@netscape.net>
Mon, 18 Jan 2016 16:09:18 +0000 (16:09 +0000)
Copy pointer is enough.

Change-Id: I51188a8434f6e4ba1d9bf3456bd29e027dd40f35
Reviewed-on: https://code.wireshark.org/review/13393
Reviewed-by: Michael Mann <mmann78@netscape.net>
extcap/androiddump.c

index febd3ffeb6b97e581d5f18635a98ea2a145b497d..a0847e2e88227375868071b8138b8a6b5cd3cabf 100644 (file)
@@ -2445,7 +2445,7 @@ int main(int argc, char **argv) {
             do_dlts = 1;
             break;
         case OPT_INTERFACE:
-            interface = strdup(optarg);
+            interface = optarg;
             break;
         case OPT_CONFIG:
             do_config = 1;
@@ -2457,13 +2457,13 @@ int main(int argc, char **argv) {
             /* currently unused */
             break;
         case OPT_FIFO:
-            fifo = strdup(optarg);
+            fifo = optarg;
             break;
         case OPT_HELP:
             help();
             return 0;
         case OPT_CONFIG_ADB_SERVER_IP:
-            adb_server_ip = strdup(optarg);
+            adb_server_ip = optarg;
             break;
         case OPT_CONFIG_ADB_SERVER_TCP_PORT:
             adb_server_tcp_port = &local_adb_server_tcp_port;
@@ -2488,7 +2488,7 @@ int main(int argc, char **argv) {
             bt_forward_socket = (g_ascii_strncasecmp(optarg, "TRUE", 4) == 0);
             break;
         case OPT_CONFIG_BT_LOCAL_IP:
-            bt_local_ip = strdup(optarg);
+            bt_local_ip = optarg;
             break;
         case OPT_CONFIG_BT_LOCAL_TCP_PORT:
             bt_local_tcp_port = &local_bt_local_tcp_port;