Qt (KeyPressEvent): Missing break in switch (CID 1159205, 1159206, 1159208, 1159209)
authorAlexis La Goutte <alexis.lagoutte@gmail.com>
Mon, 22 Dec 2014 19:54:10 +0000 (20:54 +0100)
committerAnders Broman <a.broman58@gmail.com>
Wed, 24 Dec 2014 17:02:05 +0000 (17:02 +0000)
Change-Id: I40b7c7eefb269570e6a1c5c9ec310fa97840d42d
Reviewed-on: https://code.wireshark.org/review/5995
Reviewed-by: Anders Broman <a.broman58@gmail.com>
ui/qt/column_preferences_frame.cpp
ui/qt/filter_expressions_preferences_frame.cpp
ui/qt/preferences_dialog.cpp
ui/qt/uat_dialog.cpp

index f11dda65ed9b42328fac3549cfda275fbe866642..f272a15dee386d7a9b8b92d119ff9670abec9035 100644 (file)
@@ -137,6 +137,7 @@ void ColumnPreferencesFrame::keyPressEvent(QKeyEvent *evt)
         case Qt::Key_Escape:
             cur_line_edit_->setText(saved_col_string_);
             new_idx = saved_combo_idx_;
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             switch (cur_column_) {
@@ -164,6 +165,7 @@ void ColumnPreferencesFrame::keyPressEvent(QKeyEvent *evt)
         switch (evt->key()) {
         case Qt::Key_Escape:
             cur_combo_box_->setCurrentIndex(saved_combo_idx_);
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             // XXX The combo box eats enter and return
index 46eba30ad9ff352f33b987d35589f5b92ecb1ee8..36d0a46a9a67713d7050d97382b2de0e97c78b46 100644 (file)
@@ -130,6 +130,7 @@ void FilterExpressionsPreferencesFrame::keyPressEvent(QKeyEvent *evt)
         switch (evt->key()) {
         case Qt::Key_Escape:
             cur_line_edit_->setText(saved_col_string_);
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             switch (cur_column_) {
index 4702c664f1b8f30dc532548f964ad526cebdfe18..486e627dd3b4f92d290a391ff7cd8f366dbfdd09 100644 (file)
@@ -362,6 +362,7 @@ void PreferencesDialog::keyPressEvent(QKeyEvent *evt)
         switch (evt->key()) {
         case Qt::Key_Escape:
             cur_line_edit_->setText(saved_string_pref_);
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             switch (cur_pref_type_) {
@@ -387,6 +388,7 @@ void PreferencesDialog::keyPressEvent(QKeyEvent *evt)
         switch (evt->key()) {
         case Qt::Key_Escape:
             cur_combo_box_->setCurrentIndex(saved_combo_idx_);
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             // XXX The combo box eats enter and return
index ce45d429f39fe6290129e58b7cd1eed676d79873..bd6d9b768f11c860a082d4d2be906d1d3fda3137 100644 (file)
@@ -125,6 +125,7 @@ void UatDialog::keyPressEvent(QKeyEvent *evt)
         switch (evt->key()) {
         case Qt::Key_Escape:
             cur_line_edit_->setText(saved_string_pref_);
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             stringPrefEditingFinished();
@@ -136,6 +137,7 @@ void UatDialog::keyPressEvent(QKeyEvent *evt)
         switch (evt->key()) {
         case Qt::Key_Escape:
             cur_combo_box_->setCurrentIndex(saved_combo_idx_);
+            /* Fall Through */
         case Qt::Key_Enter:
         case Qt::Key_Return:
             // XXX The combo box eats enter and return