QUIC: Diversification nonce is only present from server to client
authorAlexis La Goutte <alexis.lagoutte@gmail.com>
Sat, 4 Jun 2016 16:06:42 +0000 (18:06 +0200)
committerMichael Mann <mmann78@netscape.net>
Sun, 5 Jun 2016 23:44:10 +0000 (23:44 +0000)
For avoid problem with some middle boxes (don't yet supported >= Q033)

See https://groups.google.com/a/chromium.org/d/msg/proto-quic/kQVDZal_iwo/7dNgo4u6FgAJ for more information

Change-Id: I918e7f4400549fd6e78f3ce727e8cae0c10b464b
Reviewed-on: https://code.wireshark.org/review/15720
Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Michael Mann <mmann78@netscape.net>
epan/dissectors/packet-quic.c

index 1c86a670bf6ac156d08bb1b3d4e282f222e61e7d..b451f9b252726a7f45b3fda01e5ce5fc876541ae 100644 (file)
@@ -1841,11 +1841,12 @@ dissect_quic_common(tvbuff_t *tvb, packet_info *pinfo, proto_tree *tree,
 
     /* Diversification Nonce */
     if(puflags & PUFLAGS_DNONCE && quic_info->version >= 33){
-        proto_tree_add_item(quic_tree, hf_quic_diversification_nonce, tvb, offset, 32, ENC_NA);
-        offset += 32;
+        if(pinfo->srcport == 443){ /* Diversification nonce is only present from server to client */
+            proto_tree_add_item(quic_tree, hf_quic_diversification_nonce, tvb, offset, 32, ENC_NA);
+            offset += 32;
+        }
     }
 
-
     /* Packet Number */
 
     /* Get len of packet number (and packet number), may be a more easy function to get the length... */