Revert "Another message from Clang for unknown -f and -m flags."
authorPeter Wu <peter@lekensteyn.nl>
Thu, 8 Oct 2015 10:00:49 +0000 (12:00 +0200)
committerPeter Wu <peter@lekensteyn.nl>
Wed, 14 Oct 2015 16:53:36 +0000 (16:53 +0000)
This reverts commit 5e5e2019ee09fb0901f35948f570baff8a884adb.

This change was proposed in https://cmake.org/Bug/view.php?id=13194 to
catch some Clang warnings concerning invalid -m flags, but it is causing
legitimate breakage when setting CMAKE_C_FLAGS=-gsplit-dwarf.
CMakeFiles/CMakeError.log shows:

    /usr/bin/clang  -gsplit-dwarf -DC__W_VALID    CMakeFiles/cmTC_04cc8.dir/src.c.o  -o cmTC_04cc8 -rdynamic
    clang-3.7: warning: argument unused during compilation: '-gsplit-dwarf'

With the additional regex, basic checks (like -Wall but also -fPIE) are
incorrectly reported as unsupported. Follow upstreams action here and
remove it, it is still not present as of CMake 3.3.2.

Change-Id: I8a1e97b16c2bb929436cca669fdb42f33612c490
Reviewed-on: https://code.wireshark.org/review/10880
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Jörg Mayer <jmayer@loplof.de>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
cmake/modules/CheckCCompilerFlag.cmake

index ac21e0f7566c9f74e526c7e9bb002053fa488d1d..167db21394266b6be7127293cb06a9ab1a517460 100644 (file)
@@ -37,7 +37,6 @@ macro (CHECK_C_COMPILER_FLAG _FLAG _RESULT)
      FAIL_REGEX "command line option .* is valid for .* but not for C" # GNU
      FAIL_REGEX "unrecognized .*option"                     # GNU
      FAIL_REGEX "unknown .*option"                          # Clang
-     FAIL_REGEX "argument unused during compilation: "      # Clang
      FAIL_REGEX "optimization flag .* is not supported"     # Clang
      FAIL_REGEX "ignoring unknown option"                   # MSVC
      FAIL_REGEX "warning D9002"                             # MSVC, any lang