Fix handling of --extcap-version with an argument.
authorGuy Harris <guy@alum.mit.edu>
Fri, 6 Apr 2018 05:05:44 +0000 (22:05 -0700)
committerGuy Harris <guy@alum.mit.edu>
Fri, 6 Apr 2018 05:06:18 +0000 (05:06 +0000)
Not all versions of getopt_long() allow, for an option for which the
argument is optional, --xyzzy {value}; at least some of them, such as
the *BSD/macOS one, require --xyzzy={value}.  Make it so.

Change-Id: I856d9f253535d804c7674d209054bc6ce10ee91d
Reviewed-on: https://code.wireshark.org/review/26772
Reviewed-by: Guy Harris <guy@alum.mit.edu>
extcap.c

index a6a34544f249abf07aa17dcbbbcb7ca6abeefc03..79c5bb43afd067c87b930e7c99f3262043539e9a 100644 (file)
--- a/extcap.c
+++ b/extcap.c
@@ -1778,11 +1778,9 @@ extcap_load_interface_list(void)
         }
 
         arguments = g_list_append(arguments, g_strdup(EXTCAP_ARGUMENT_LIST_INTERFACES));
-        arguments = g_list_append(arguments, g_strdup(EXTCAP_ARGUMENT_VERSION));
 
         get_ws_version_number(&major, &minor, NULL);
-
-        arguments = g_list_append(arguments, g_strdup_printf("%d.%d", major, minor));
+        arguments = g_list_append(arguments, g_strdup_printf("%s=%d.%d", EXTCAP_ARGUMENT_VERSION, major, minor));
 
         extcap_callback_info_t cb_info;
         cb_info.data = NULL;