Have the frame_tvbuff.c routines not use the global cfile.
authorGuy Harris <guy@alum.mit.edu>
Fri, 8 Dec 2017 08:30:55 +0000 (00:30 -0800)
committerGuy Harris <guy@alum.mit.edu>
Fri, 8 Dec 2017 08:31:41 +0000 (08:31 +0000)
commit8aa14236f8b0ea69901ea9ed87ebabd0d278e973
treeb49b5d6b0ee5d647cf33054c5f280d2dc4fa4f99
parentf29b3deb6d867b16fb8bc4bd5f66a5b6326a6727
Have the frame_tvbuff.c routines not use the global cfile.

Have the routines that create them take a pointer to a struct
packet_provider_data, store that in the tvbuff data, and use it to get
the wtap from which packets are being read.

While we're at it, don't include globals.h in any header files, and
include it in source files iff the source file actually uses cfile.  Add
whatever includes that requires.

Change-Id: I9f1ee391f951dc427ff62c80f67aa4877a37c229
Reviewed-on: https://code.wireshark.org/review/24733
Reviewed-by: Guy Harris <guy@alum.mit.edu>
91 files changed:
capchild/capture_sync.c
epan/exported_pdu.h
epan/tap.h
file.c
fileset.c
frame_tvbuff.c
frame_tvbuff.h
rawshark.c
sharkd.c
sharkd.h
sharkd_session.c
tfshark.c
tshark.c
ui/gtk/addr_resolution_dlg.c
ui/gtk/capture_dlg.c
ui/gtk/capture_file_dlg.h
ui/gtk/conversations_table.c
ui/gtk/dcerpc_stat.c
ui/gtk/decode_as_dlg.c
ui/gtk/drag_and_drop.c
ui/gtk/edit_packet_comment_dlg.c
ui/gtk/expert_comp_dlg.c
ui/gtk/expert_comp_table.c
ui/gtk/export_object_dlg.c
ui/gtk/export_pdu_dlg.c
ui/gtk/export_sslkeys.c
ui/gtk/fileset_dlg.c
ui/gtk/filter_expression_save_dlg.c
ui/gtk/filter_expression_save_dlg.h
ui/gtk/filter_utils.c
ui/gtk/firewall_dlg.c
ui/gtk/flow_graph.c
ui/gtk/follow_stream.c
ui/gtk/funnel_stat.c
ui/gtk/graph_analysis.c
ui/gtk/hostlist_table.c
ui/gtk/iax2_analysis.c
ui/gtk/io_stat.c
ui/gtk/mac_lte_stat_dlg.c
ui/gtk/main.c
ui/gtk/main.h
ui/gtk/main_filter_toolbar.c
ui/gtk/main_statusbar.c
ui/gtk/main_toolbar.c
ui/gtk/main_welcome.c
ui/gtk/manual_addr_resolv.c
ui/gtk/packet_history.c
ui/gtk/packet_list.c
ui/gtk/packet_list_store.c
ui/gtk/packet_panes.c
ui/gtk/packet_win.c
ui/gtk/prefs_dlg.c
ui/gtk/prefs_gui.c
ui/gtk/print_dlg.c
ui/gtk/profile_dlg.c
ui/gtk/proto_dlg.c
ui/gtk/response_time_delay_table.c
ui/gtk/rlc_lte_stat_dlg.c
ui/gtk/rpc_stat.c
ui/gtk/rtp_analysis.c
ui/gtk/sctp_assoc_analyse.c
ui/gtk/sctp_byte_graph_dlg.c
ui/gtk/sctp_chunk_stat.c
ui/gtk/sctp_chunk_stat_dlg.c
ui/gtk/sctp_error_dlg.c
ui/gtk/sctp_graph_dlg.c
ui/gtk/sctp_stat_dlg.c
ui/gtk/service_response_time_table.c
ui/gtk/simple_stattable.c
ui/gtk/stats_tree_stat.c
ui/gtk/summary_dlg.c
ui/gtk/supported_protos_dlg.c
ui/gtk/uat_gui.c
ui/gtk/wlan_stat_dlg.c
ui/proto_hier_stats.c
ui/qt/address_editor_frame.cpp
ui/qt/export_pdu_dialog.cpp
ui/qt/gsm_map_summary_dialog.cpp
ui/qt/iax2_analysis_dialog.cpp
ui/qt/lte_rlc_graph_dialog.cpp
ui/qt/models/packet_list_record.cpp
ui/qt/mtp3_summary_dialog.cpp
ui/qt/packet_dialog.cpp
ui/qt/packet_list.cpp
ui/qt/rtp_analysis_dialog.cpp
ui/qt/utils/frame_information.cpp
ui/tap-rlc-graph.c
ui/tap-rtp-common.c
ui/tap-tcp-stream.c
ui/tap_export_pdu.c
ui/win32/file_dlg_win32.c