Force HAVE_REMOTE to be defined when including pcap.h with remote support.
authorGuy Harris <guy@alum.mit.edu>
Thu, 11 May 2017 10:56:44 +0000 (03:56 -0700)
committerGuy Harris <guy@alum.mit.edu>
Thu, 11 May 2017 10:57:22 +0000 (10:57 +0000)
commit79eab8ca070f978415126f85b0777ab4ab02f0a2
tree2e525b1b6adee7397fb80362fc0016a76cb93b5e
parent871a8a2cccf79fae30c30a99fa21a4fa4dfbae16
Force HAVE_REMOTE to be defined when including pcap.h with remote support.

WinPcap made the mistake of having stuff in its public header fines
depend on a configuration #define, HAVE_REMOTE; this means that we need
to forcibly define it when building with remote capture support.

The tip of the libpcap master branch does not have that botch; hopefully
future versions of libpcap-for-Windows will be based on that libpcap and
thus lack that botch as well.

Defining HAVE_REMOTE in config.h is not the right fix, as it makes it
look like a *Wireshark* configuration option that code in Wireshark
should test, rather than a *WinPcap* configuration option that the
pcap.h that ships with the WinPcap SDK should have been changed, as part
of the build process, to correctly define or not, so that users of
WinPcap don't have to define it themselves.

Change-Id: I62d1eca6d3c900d0dcc9fbc011db77f595a86313
Reviewed-on: https://code.wireshark.org/review/21593
Reviewed-by: Guy Harris <guy@alum.mit.edu>
caputils/capture-pcap-util-unix.c
caputils/capture-pcap-util.h
caputils/capture_wpcap_packet.c
extcap/androiddump.c
ringbuffer.c
trigcap.c
ui/gtk/airpcap_dlg.c
ui/qt/capture_filter_syntax_worker.cpp
ui/qt/compiled_filter_output.cpp