Fix RTP player crash on invalid streams
authorPeter Wu <peter@lekensteyn.nl>
Fri, 20 Nov 2015 19:08:10 +0000 (20:08 +0100)
committerPeter Wu <peter@lekensteyn.nl>
Sun, 22 Nov 2015 11:25:06 +0000 (11:25 +0000)
commit74247f96a998797e933f09f566f60406b9ba92b4
treeb77012c9d077d22003861cea1a6766b882dc72aa
parent26366ef795739920c858f5b7459476dc56677410
Fix RTP player crash on invalid streams

On Linux with pulseaudio, the RTP player can crash when an invalid RTP
stream is played. Prevent that by detecting when stream playback fails.

Since the stateChanged signal receiver is registered on the same
thread, it is guaranteed that any outputStateChanged calls happen before
returning from audio_output_->start().

GTK+ not have this issue, its player simply does not show the decoded
stream at all.

Change-Id: I51a91a7f410ef3d46551bc8df0049542efbb806f
Reviewed-on: https://code.wireshark.org/review/11997
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
ui/qt/rtp_audio_stream.cpp