ncp2222 - Convert process_bitfield -> proto_tree_add_bitmask and other cleanup.
authorMichael Mann <mmann78@netscape.net>
Wed, 16 Sep 2015 17:09:12 +0000 (13:09 -0400)
committerMichael Mann <mmann78@netscape.net>
Thu, 17 Sep 2015 18:24:09 +0000 (18:24 +0000)
commit6646b00b5f7606a179614f7d5ba6d7f62cea0b64
tree91bfd4269a9c7c8ee15de20ccf5883a29165d4f3
parenta4c2a29a9cdfbe663e637649ae1dc8cc6f8e5c49
ncp2222 - Convert process_bitfield -> proto_tree_add_bitmask and other cleanup.

The dissector is doing a lot of unnecessary "manual" operations.  Start the process of simplifying that to encourage use of general APIs and put control of the "field name" in the hands of the hf_ entry it belongs with.

Change-Id: I5b048c04858ac4a846a276ba12d61c665deb66f8
Reviewed-on: https://code.wireshark.org/review/10547
Reviewed-by: Michael Mann <mmann78@netscape.net>
epan/dissectors/packet-ncp2222.inc
tools/ncp2222.py