ISAKMP: Reduce code duplication
authorMirko Parthey <mirko.parthey@web.de>
Thu, 8 Sep 2016 21:00:34 +0000 (23:00 +0200)
committerPeter Wu <peter@lekensteyn.nl>
Sun, 18 Sep 2016 13:58:22 +0000 (13:58 +0000)
commit553e119672a27b068ec14073dbc1456df06d0ec3
tree93c663b3910e0491f56510280f173cbfbf6d201b
parentca2a9699810ccbb6a8230c8035228a1e2ba2b3db
ISAKMP: Reduce code duplication

Equalize attribute dissecting functions:
* Convert all attribute type names to range_string.
  Add "Unassigned" and "Private use" ranges while we are at it.
* Swap the order of format and type fields for config attributes.

Move common code into the new function dissect_attribute_header().
Try to keep the parameter list short:
* Group the hfindex values for attribute details into a struct.
* Merge attribute subtree types.

Add a colon in the main attribute item label for visual separation.

Skip dissection of config attributes for unknown IKE versions.

Change-Id: I6e6286f3d4cf16f3cd16a23aca540c4af72f3442
Reviewed-on: https://code.wireshark.org/review/17663
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
Reviewed-by: Peter Wu <peter@lekensteyn.nl>
epan/dissectors/packet-isakmp.c