TLS: fix reassembly regression when extending a PDU
authorPeter Wu <peter@lekensteyn.nl>
Mon, 1 Oct 2018 22:00:16 +0000 (00:00 +0200)
committerAnders Broman <a.broman58@gmail.com>
Tue, 2 Oct 2018 04:43:10 +0000 (04:43 +0000)
commit2263ce4f63f91f58d840c628dccaec6a72a0d6fc
treefd089488f2bd10ae6f391205839544d402851b3d
parentfdecc62c73bdbf60efb2f2461e1f1a4ae5d44852
TLS: fix reassembly regression when extending a PDU

The fragment identifier was changed, but fragment_set_partial_reassembly
was left unchanged which broke reassembly/decryption when a subdissector
finishes reassembly, but then requests further reassembly (like HTTP
with chunked encoding). This bug results in a faulty "Reassembly error,
protocol TLS: New fragment past old data limits" message.

Bug: 15158
Change-Id: I636ef623dd65c3feb58da29adf7125d8458f038f
Fixes: v2.9.0rc0-2003-gbe16d87c60 ("TLS: fix broken reassembly with multiple PDUs in the same frame")
Reviewed-on: https://code.wireshark.org/review/29967
Petri-Dish: Peter Wu <peter@lekensteyn.nl>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@gmail.com>
epan/dissectors/packet-tls.c