Get the "Decode As" dialog working, albeit with a few warts. It differs
authorGerald Combs <gerald@wireshark.org>
Tue, 10 Dec 2013 19:23:26 +0000 (19:23 -0000)
committerGerald Combs <gerald@wireshark.org>
Tue, 10 Dec 2013 19:23:26 +0000 (19:23 -0000)
commit17a67c3b5cb80619ab7e1260a05a28e888cee09e
tree538f734525e8a488e4fc60ad4eff509a80458c8f
parent5fa7d37e377abb89e317f4ebd47ebea69ebe0fd9
Get the "Decode As" dialog working, albeit with a few warts. It differs
from the GTK flavor in two major ways:

- The "Decode As" and "User Specified Decodes" dialog have been unified.
- You can modify the decode as behavior at any time, not just when you
  have a packet selected.

Revert part of 53498 so that we can move items marked

/*** THE FOLLOWING SHOULD NOT BE USED BY ANY DISSECTORS!!! ***/

from epan/decode_as.h to ui/decode_as_utils.h.

Move "save" code from decode_as_dlg.c to decode_as_utils.c as well.

In packet-dcerpc.c don't register a table named "ethertype". We might
want to add checks for duplicate table names.

To do:
- Add support for ranges?
- Either add support for DCERPC or make DCERPC use a regular dissector
  table.
- Fix string selectors (i.e. BER).

svn path=/trunk/; revision=53910
19 files changed:
epan/decode_as.c
epan/decode_as.h
epan/dissectors/packet-ber.c
epan/dissectors/packet-dcerpc.c
epan/packet.c
epan/packet.h
epan/prefs.c
ui/CMakeLists.txt
ui/Makefile.common
ui/decode_as_utils.c [new file with mode: 0644]
ui/decode_as_utils.h [new file with mode: 0644]
ui/gtk/decode_as_dlg.c
ui/gtk/main.c
ui/qt/decode_as_dialog.cpp
ui/qt/decode_as_dialog.h
ui/qt/decode_as_dialog.ui
ui/qt/preferences_dialog.ui
ui/qt/stats_tree_dialog.cpp
ui/qt/wireshark_application.cpp