Don't pick up junk from an unset error-number variable.
authorGuy Harris <guy@alum.mit.edu>
Fri, 16 Sep 2016 01:32:21 +0000 (18:32 -0700)
committerGuy Harris <guy@alum.mit.edu>
Fri, 16 Sep 2016 01:32:47 +0000 (01:32 +0000)
commit1158576622d677884a3ce4aa169873d453897c9d
tree63148a483bee62370303d80bf3dc5ee3ba02c599
parent7a7d162a494e3ccf15f58f1d710dcf645cfa02b1
Don't pick up junk from an unset error-number variable.

Keep the actual error code and pointer-to-error-string in the scanner
state, rather than pointers to the variables passed in to us.
Initialize them to 0 and NULL, respectively.

That way, when the actual scanner routine returns, we don't check for an
error by looking at the error variable pointed to by our argument, which
might not have been set by the scanner and might have stack junk in it,
we look at a structure member we set to 0 before the scan.

Change-Id: I81a4fd6d5cf5e56f5638fae1253c48dc50c9c36d
Reviewed-on: https://code.wireshark.org/review/17721
Reviewed-by: Guy Harris <guy@alum.mit.edu>
wiretap/ascend-int.h
wiretap/ascend.y
wiretap/ascend_scanner.l