1 $Id: ChangeLog,v 1.33 2003/12/13 00:55:10 gerald Exp $
4 2003-12-13 00:38 gerald
8 Add packet-isup.h as well.
10 2003-12-13 00:22 gerald
14 Add packet-ansi_map.h to the distribution.
16 2003-12-12 23:47 obiot
20 Always dissect a sm_submit otherwise reassembly of short messages
23 2003-12-12 23:35 obiot
27 Move info column update code outside of if (tree).
33 Add some checks to make sure we're not running past the end of
34 the RR we're dissecting. (Some RR's still don't do that check,
35 as they don't maintain an "rr_len" variable, and as
36 "get_dns_name()" doesn't do any length checking.)
38 That obviates the need for having "compute_key_id()" check the
39 length, as we won't even get to calling it if the RR is too
40 short. Have it still do a check for sanity, but just abort if
41 the check fails, and have it return -1 if the algorithm is
44 Don't bother processing T_CERT RRs if we're not building a
45 protocol tree, don't fetch data from a T_CERT RR until we put it
46 into the tree, and fix the bug that change found, namely that we
47 were using the wrong variable in the "val_to_str()" call for the
52 * packet-ses.c, packet-ses.h:
54 From Yuriy Sidelnikov: if the first SPDU in a TSDU has a type of
55 1 or 2, treat it specially - a type of 1 means GIVE_TOKENS, not
56 DATA_TRANSFER, in that case.
64 display the PIM hello option values in brackets after the
68 in the LAN prune delay option dissector:
70 put the top-level item for the option into the
72 options tree rather than the PIM main tree;
74 calculate the correct LAN prune delay and display
76 units of milliseconds;
78 calculate the correct override interval and
80 in units of milliseconds;
82 fix the offset and length calculation.
86 * AUTHORS, packet-ansi_a.c, packet-ansi_a.h, packet-ansi_map.c,
87 packet-ansi_map.h, packet-isup.c, packet-isup.h, gtk/Makefile.am,
88 gtk/Makefile.nmake, gtk/ansi_map_stat.c, gtk/isup_stat.c:
92 Fix point code display.
94 Add taps for ANSI MAP and ISUP statistics.
96 2003-12-12 16:06 gerald
100 Switch from gettext 0.13 to 0.12.1.
102 2003-12-12 02:50 gerald
104 * gtk/: dlg_utils.c, main.c:
106 In "dlg_window_new()" check to see if "top_level" has been
107 initialized, as is the case for the spawned capture process.
109 2003-12-11 21:23 ulfl
111 * packet-afp.c, packet-bssap.c, packet-cops.c, packet-esis.c,
112 packet-gsm_sms.c, packet-isakmp.c, packet-osi-options.c,
113 gtk/dcerpc_stat.c, plugins/docsis/packet-tlv.c,
114 plugins/docsis/packet-vendor.c, wiretap/erf.c,
117 prevent MSVC warning: "warning C4761: Größenkonflikt im Argument.
118 Konvertierung vorgenommen" -> size conflict in argument,
125 Have "compute_key_id()" return different values for different
126 errors, and have its caller put an entry into the tree for "we
127 don't support the algorithm" (the "RR too short" error is a
134 Add "/usr/local/include" in case the PCRE header file is there.
136 2003-12-11 08:54 ulfl
140 replaced type u_int32_t by glib's guint32 (to satisfy MSVC)
148 2003-12-10 23:21 gerald
150 * README.win32, packaging/nsis/ethereal.nsi:
152 Update the Windows environment to GLib 2.2.3 and GTK+
153 1.3.0-20030717. This requires replacing libintl-1.dll from the
154 libintl package (which is no longer used) with intl.dll from
155 intl.dll from the gettext package.
157 2003-12-10 22:52 gram
161 Analyzer's PDML will be changed to start the packet offset (the
162 "pos" field) at 0 instead of 1. This works better for Ethereal,
163 as our offsets start at 0. Change the "geninfo" pseudo-protocol
164 to use pos="0" instead of pos="1".
166 2003-12-10 22:38 obiot
168 * epan/dfilter/Makefile.nmake:
170 PCRE support requires $(PCRE_CFLAGS) in CFLAGS.
172 2003-12-10 22:27 obiot
176 WSP status code is hexadecimal.
178 2003-12-10 21:50 gerald
180 * config.nmake, configure.in, epan/configure.in:
182 Bump the version to 0.10.0. It could be (and has been) argued
183 that the last release should have been 0.10.0.
189 Oops, I checked the wrong tap into CVS somehow.
191 2003-12-10 21:12 gerald
193 * epan/ftypes/: ftypes-int.h, ftypes.h:
195 Make the _pcre_tuple_t struct internal.
201 From David Fort: compute and display the key ID in a DNS KEY RR,
208 From Anders Broman: add CIC to Info column.
212 * AUTHORS, Makefile.am, Makefile.nmake, packet-igap.c,
213 packet-igap.h, packet-igmp.c:
215 From Akira Endoh: IGAP support.
221 Squelch a compiler warning.
223 2003-12-10 19:05 ulfl
225 * packaging/nsis/ethereal.nsi:
227 added some more uninstall info and offering only removal of
228 program (instead of modify/repair)
234 Check whether the packet length is less than the length of the
235 packet header, and give up if it is.
237 2003-12-09 23:45 obiot
241 Mark parameter data as unused in callback_create_help().
243 2003-12-09 23:15 obiot
245 * epan/ftypes/Makefile.nmake:
247 Internal PCRE field type for efficient RE parsing in dfilters.
249 2003-12-09 23:02 obiot
251 * epan/: ftypes/Makefile.am, ftypes/ftype-pcre.c,
252 ftypes/ftype-string.c, ftypes/ftypes.c, ftypes/ftypes.h,
255 Internal PCRE field type for efficient RE parsing in dfilters.
257 2003-12-09 22:41 ulfl
259 * file.c, gtk/main.h, gtk/menu.c:
261 print system enhanced, more print ranges and expanded states
263 2003-12-09 22:27 ulfl
267 print system enhanced, more print ranges and expanded states
269 2003-12-09 22:21 ulfl
271 * print.h, tethereal.c, gtk/print_dlg.c:
273 print system enhanced, more print ranges and expanded states
275 2003-12-09 22:04 ulfl
279 print system enhanced, more print ranges and expanded states
283 * Makefile.am, Makefile.nmake, packet-gsm_a.c, packet-gsm_a.h,
284 tap-ansi_astat.c, tap-gsm_astat.c, gtk/Makefile.am,
285 gtk/Makefile.nmake, gtk/ansi_a_stat.c, gtk/gsm_a_stat.c:
289 new taps for GSM A-interface;
291 fixes for ANSI A-interface taps.
295 * column.c, column.h, file.c, ui_util.h, epan/column-utils.c,
296 epan/column_info.h, gtk/main.c, gtk/packet_list.c:
298 Don't automatically size the columns - that's expensive in large
299 captures, as it has to compute the width of an auto-resizing
300 column in every row. Just pick fixed widths for the columns (and
301 tune the width of the "Protocol" column so that it's not narrower
302 than the column title).
304 2003-12-09 05:56 gram
306 * tethereal.c, doc/README.xml-output, doc/tethereal.pod,
309 -Tpdml and -Tps force -V. Thus, -V is no longer required when
310 using -Tpdml. Eventually, -Tps will not force -V, and will print
311 summaries when -V is not selected. However, work still has to be
318 Add a new attribute type RADIUS_IP6_ADDRESS for IPv6 addresses.
320 Put in a note explaining the enum for those types.
322 From Rui Carmo: add all 3GPP VSA's.
326 * epan/: resolv.c, to_str.c, to_str.h:
328 Add "ip6_to_str_buf()", by analogy to "ip_to_str_buf()".
334 From Michael Lum: fix incorrect switch values which resulted in
335 NULL strings being passed to ..._add_text().
341 As per Didier Gautheron, dissect TCP options regardless of
342 whether we're building a protocol tree, so the Info column is set
347 * packet-alcap.c, packet-ansi_637.c, packet-ansi_683.c,
348 packet-ansi_a.c, packet-ansi_map.c, packet-gsm_a.c,
349 packet-gsm_map.c, packet-gsm_sms.c, epan/to_str.c, epan/to_str.h:
351 Get rid of the private "my_decode_bitfield_value()" a number of
352 dissectors had. Instead, rename it
353 "other_decode_bitfield_value()", put it in "epan/to_str.c", and
354 make "decode_bitfield_value()" use it.
360 Add a "doc" target, as per Ulf Lamping's comment.
364 * doc/ethereal-filter.pod.template:
366 Note the types of fields for which the "contains" operator is
369 Always capitalize the names "Ethereal" and "Tethereal" (we don't
370 capitalize the command names, however, as they're
373 Note that you can find out from the GUI whether Ethereal was
374 built with the PCRE library or not.
382 "proto_construct_dfilter_string()" can return a null pointer,
383 e.g. for protocol tree fields that don't have values and that are
386 Combine the "if (fi->hfinfo->type != FT_PROTOCOL && fi->length >
387 0)" stuff to show the raw value into the previous "if".
391 * AUTHORS, packet-mtp3.c, packet-mtp3.h, packet-sccp.c,
392 epan/packet_info.h, epan/to_str.c:
394 From Michael Lum: support an AT_SS7PC address type for SS7 point
395 codes, and set the direction in pinfo for SS7 packets based on
396 source and destination addresses.
402 From Jamie Fournier: don't show UNKUUID information for fragments
403 for known dissectors.
409 From Greg Morris: ecode the attribute structure instead of
410 reporting a really long undecoded string.
414 * packaging/nsis/ethereal.nsi:
416 From Lars Roland: fix a typo.
420 * packaging/nsis/Makefile.nmake:
422 From Lars Roland: fix the NSIS Makefile to handle PCRE.
426 * packet-isis-clv.c, packet-isis-clv.h, packet-isis-hello.c,
427 packet-isis-hello.h, packet-isis-lsp.c, packet-isis-lsp.h,
428 packet-isis-snp.c, packet-isis-snp.h:
432 - unify the IS-IS CLV space IS-IS uses a unified CLV space
433 across all Level and PDU Types there is no need to define PDU-
434 and Level- Specific CLV Types;
436 - clean up Authentication CLV TLV #10 is the official supported
437 TLV for carrying authentication information- todays code
438 displays TLV #10 as non-standard which is wrong; also the
439 notion of "Domain" "Authentication" and "Link" password has
440 disappeared from contemporary routing SW;
442 - add IP Authentication CLV dissector this CLV is depreciated -
443 however it is using different semantics than TLV #10 so we need
444 a dedicated dissector;
446 - add Checksum CLV dissector add support for RFC 3358 Checksum
447 CLVs majority of code re-used from the LSP checksum
448 verification dissector.
450 2003-12-08 20:37 obiot
452 * packet-wsp.c, packet-mmse.c, packet-wbxml.c:
454 Get rid of the integer media type dissector table in WSP, WBXML
461 From Didier Gautheron: check packet format in get_dsi_pdu_len.
467 From Didier Gautheron: add offset and size parameters in info
468 colum for read and write commands.
476 Call subdissectors regardless of whether we're building a
477 protocol tree or not.
479 Use the "media_type" dissector table to hand off to
480 subdissectors, rather than wiring in SDP.
482 Put the message body into a subtree of the SIP tree
486 2003-12-08 19:25 ulfl
490 moved "File->Save Highlighted Data" to "File->Export->Raw Packet
493 2003-12-08 17:54 ulfl
497 updated to reflect the menu redesign changes
499 2003-12-08 17:49 ulfl
503 removed seperator between the two print menuitems
505 2003-12-07 19:09 obiot
509 Update address of Johan Feyaerts. Dfilter matches operator.
511 2003-12-07 18:32 obiot
513 * doc/ethereal-filter.pod.template:
515 Clarify dfilter syntax (mainly the implicit exists operator), add
516 subsections in syntax section, add description of new "contains"
517 operator (and inform that it is only available if libpcre has
520 2003-12-07 18:09 obiot
522 * packet-mmse.c, packet-wbxml.c, packet-wsp.c:
524 Remove the literal WSP content type dissector table, and replace
525 it with the "media_type" table defined in the HTTP dissector.
527 2003-12-07 09:43 oabad
531 Update various set_menu_object_data() calls to reflect recent
532 menu hierarchy changes. This avoids a crash when selecting "Folow
533 TCP stream" from the "Analyze" menu.
539 Register the SDP dissector with the media_type dissector table
546 Use a cleanup handler to free the Content-Type header value, so
547 it gets freed even if we throw an exception after processing the
548 Content-Type header but before we call a subdissector.
554 Change the name of the variable holding the dissector table
555 pointer to match the previous checkin.
559 * packet-http.c, packet-mmse.c:
561 Rename the "http.content_type" dissector table to "media_type",
562 as it's for use in any dissector that uses Internet media types.
568 Only check the destination address if it's AT_ETHER; otherwise,
569 there's no guarantee that "data[5]" exists or can be interpreted
576 From Devin Heitmueller: include the AES ciphersuites from RFC
583 Put the "-V" flag in boldface, so pod2man doesn't whine.
585 2003-12-07 00:04 gerald
587 * Makefile.nmake, README.win32, config.h.win32, config.nmake,
588 epan/Makefile.nmake, epan/config.h.win32,
589 epan/ftypes/Makefile.nmake, packaging/nsis/ethereal.nsi:
591 Add PCRE support to the Windows build.
593 2003-12-06 19:26 oabad
597 Check if pinfo->dl_dst.data is not NULL before accessing the data
598 (it was NULL in one of my "linux cooked" captures which contains
599 no destination address).
601 2003-12-06 19:14 jmayer
605 Declaration included the line above
607 2003-12-06 16:35 gram
609 * Makefile.am, acinclude.m4, configure.in, util.c,
610 epan/acinclude.m4, epan/configure.in, epan/dfilter/dfvm.c,
611 epan/dfilter/dfvm.h, epan/dfilter/gencode.c,
612 epan/dfilter/grammar.lemon, epan/dfilter/scanner.l,
613 epan/dfilter/semcheck.c, epan/dfilter/sttype-test.c,
614 epan/dfilter/sttype-test.h, epan/ftypes/ftype-bytes.c,
615 epan/ftypes/ftype-double.c, epan/ftypes/ftype-integer.c,
616 epan/ftypes/ftype-ipv4.c, epan/ftypes/ftype-none.c,
617 epan/ftypes/ftype-string.c, epan/ftypes/ftype-time.c,
618 epan/ftypes/ftype-tvbuff.c, epan/ftypes/ftypes.c,
619 epan/ftypes/ftypes.h:
623 New "matches" operater in display filter language. Uses PCRE.
625 If a "matches" operator is found in a dfilter while libpcre has
626 not been used to build the binary, then an exception is thrown
627 after using dfilter_fail() to set an apporporiate error message.
629 2003-12-06 06:22 gram
633 slab.h needs to be in libethereal_a_SOURCES
635 2003-12-06 06:09 gram
637 * Makefile.am, packet-frame.c, packet-frame.h, print.c, print.h,
638 tethereal.c, doc/README.xml-output, doc/tethereal.pod,
639 epan/proto.c, epan/proto.h, tools/EtherealXML.py,
640 tools/Makefile.am, tools/msnchat:
642 Add the ability to print packet dissections in PDML (an XML-based
643 format) to tethereal. It could be added to Ethereal, but the GUI
644 changes to allow the user to select PDML as a print format have
647 Provide a python module (EtherealXML.py) to help parse PDML.
649 Provide a sample app (msnchat) which uses tethereal and
650 EtherealXML.py to reconstruct MSN Chat sessions from packet
651 capture files. It produces a nice HTML report of the chat
654 Document tethereal's PDML and EtherealXML.py usage in
655 doc/README.xml-output
657 Update tethereal's manpage to reflect the new [-T pdml|ps|text]
662 * file.c, ui_util.h, gtk/packet_list.c:
664 From Jeff Morriss: avoid at least some N^2 behavior when changing
665 the time stamp format.
671 "hf_ccsds_secheader" is an FT_BOOLEAN; use
672 "proto_tree_add_boolean()" for it.
674 2003-12-05 16:00 gerald
676 * Makefile.nmake, README.win32, config.nmake:
678 Switch over to Net-SNMP 5.1. A ZIP file of the Net-SNMP 5.1
679 sources plus a static Windows library (netsnmp.lib) has been
682 http://www.ethereal.com/distribution/win32/development/
684 The Net-SNMP documentation recommends against using a DLL at the
691 We have to parse the SDP packet even if we're not building a
692 protocol tree, as we might be setting up a conversation.
698 Subdissectors must be called regardless of whether a protocol
703 * plugins/mgcp/packet-mgcp.c:
705 Subdissectors must be called regardless of whether a protocol
710 * plugins/asn1/Makefile.am:
712 From some reason, at least on Mac OS X 10.3, the change to have
713 the protocol tree stuff not use GNodes means that the ASN.1
714 plugin now needs to be explicitly linked against GLib in order to
715 get access to the GNode routines, otherwise you get errors from
720 * epan/: proto.c, proto.h:
722 It turns out the protocol tree parent link was used, so we need
723 it in our new scheme.
727 * file.c, print.c, proto_hier_stats.c, tap-protohierstat.c,
728 epan/proto.c, epan/proto.h, gtk/proto_draw.c, gtk/rtp_analysis.c:
730 Don't use GNodes for the protocol tree, put the sibling pointer,
731 and pointers to the first *and* last child, in the "proto_node"
732 structure itself. That saves us one level of indirection and
733 memory allocation, and lets us append to a tree by appending to
734 the last child directly, rather than having to scan through the
735 list of siblings of the first child to find the end of that list.
737 2003-12-04 08:15 sahlberg
743 if the kerberos blob contains a krb error, print the error string
746 2003-12-04 08:13 sahlberg
752 some implementations specify GSSAPI in the bind call. the
753 encapsulation seems to be the same as GSS-SPNEGO so handle it the
756 2003-12-04 06:02 gram
760 Add {0, NULL} to the vals_wsp_reason_codes value_string array.
762 2003-12-04 05:59 gram
766 Add {0, NULL} to all the value_string arrays.
768 2003-12-04 05:57 gram
772 Add {0, NULL} to the reply_table_v5 value_string array.
774 2003-12-04 05:55 gram
778 ldp.msg.tlv.returned.msg.ubit needs to be an FT_BOOLEAN field,
779 not an FT_UINT8, since it is using a true_false_string struct to
780 print its values. Add {0, NULL} to the fec_vc_interfaceparm
783 2003-12-04 05:47 gram
787 Add {0, NULL} to the isup_Pass_on_not_possible_indicator_vals and
788 ISUP_Broadband_narrowband_interworking_indicator_vals
791 2003-12-04 05:40 gram
795 Add {0, NULL} to end of fc_swils_rscn_addrfmt_val value_string
798 2003-12-04 05:38 gram
802 Add {0, NULL} to end of fcencap_proto_vals value_string array.
806 * filters.c, filters.h, gtk/dcerpc_stat.c,
807 gtk/endpoint_talkers_table.c, gtk/fc_stat.c, gtk/filter_prefs.c,
808 gtk/find_dlg.c, gtk/h225_counter.c, gtk/h225_ras_srt.c,
809 gtk/ldap_stat.c, gtk/mgcp_stat.c, gtk/prefs_dlg.c,
810 gtk/rpc_stat.c, gtk/service_response_time_table.c,
813 In GTK+ 2.x, "gtk_entry_get_text()" returns a "const gchar *";
814 assign its value to pointer-to-const variables.
818 * AUTHORS, Makefile.am, Makefile.nmake, packet-gsm_map.c,
821 From Felix Fei: GSM MAP support.
825 Modified for better TCAP separation, fixed EOC handling
829 Added parameter parsing (although not dissection or
834 * AUTHORS, packet-ansi_a.c, packet-ansi_a.h, tap-ansi_astat.c,
835 gtk/Makefile.am, gtk/Makefile.nmake, gtk/ansi_a_stat.c:
837 From Michael Lum: Ethereal tap for ANSI A-interface.
839 Tweak some Makefile.nmake whitespace.
843 * packet-mtp2.c, packet-mtp3.c:
845 From Jeff Morriss: add support for WTAP_ENCAP_MTP2 and
850 * wiretap/: AUTHORS, libpcap.c, wtap.c, wtap.h:
852 From Jeff Morriss: add support for libpcap MTP2 and MTP3
855 Add a missing entry in "encap_table[]" for Bluetooth H4, and fix
862 From Greg Morris: handle the backwards compatibility flag for
869 From Greg Morris: the "File->Save Highlighted" menu item has no
870 icon, so don't use "ITEM_FACTORY_STOCK_ENTRY()" for it.
874 * wiretap/airopeek9.c:
876 "strtoul()" returns a "long", not a "long long".
878 2003-12-03 10:14 sahlberg
882 Replace two expensive macros with a much simpler mechanism to
883 prevent memory leaks due to exceptions.
885 makes my tethereal testcase ~1% faster.
887 2003-12-03 09:50 sahlberg
889 * epan/: proto.c, tvbuff.c, tvbuff.h:
893 replace tvb_raw_offset() which is essentially a simple assignment
894 and which is called a lot with a macro.
896 this makes my tethereal testcase 2-3% faster.
900 * packet-ncp2222.inc, print.c, proto_hier_stats.c,
901 tap-protohierstat.c, epan/proto.c, epan/proto.h,
902 epan/ftypes/ftypes.c, epan/ftypes/ftypes.h, gtk/main.c,
903 gtk/menu.c, gtk/prefs_dlg.c, gtk/rtp_analysis.c:
905 The "ptr_u" unions no longer have a "next" pointer - they now
906 just have one member - or have one that's not used, so get rid of
911 * epan/: proto.c, proto.h, slab.h, ftypes/ftypes.c,
914 Instead of requiring slab-allocated structures to have a "next"
915 pointer, when adding them to the free list, cast the pointer to
916 the structure to a pointer to a "freed_item_t" which contains the
919 This reduces the memory requirement for some of those structures,
920 and leaves us free to slab-allocate structures that have a "next"
921 pointer for other reasons.
923 2003-12-03 08:43 sahlberg
927 Update to SMB ReadAndX replies.
929 There might be a 4 (not 2) byte datalen high field. If there is
930 no such field (due to an early dialect being used) these bytes
931 are often 0xff. If these four bytes are all 0xff dont display
942 * file.c, tethereal.c, epan/column-utils.c, epan/column_info.h,
945 From Didier Gautheron: for each column format type, save the
946 first and last columns, if any, with that format, and use that to
947 speed up processing of columns with a particular format and
948 checking whether we're displaying a column with a particular
953 * packet-ncp2222.inc, packet-smb-sidsnooping.c, tap-iostat.c,
954 epan/proto.c, epan/proto.h, epan/dfilter/dfvm.c,
955 epan/ftypes/ftypes.c, epan/ftypes/ftypes.h, gtk/io_stat.c,
956 gtk/main.c, gtk/rtp_analysis.c:
958 From Didier Gautheron: put an "fvalue_t" structure into a
959 "field_info" structure, rather than separately allocating
960 "fvalue_t"s and having the "field_info" structure point to them -
961 this appears to speed up protocol tree construction a bit.
965 * wiretap/airopeek9.c:
967 Check for errors and EOF, and handle them appropriately; don't
968 treat all errors when reading the header as indications that the
969 file isn't an AiroPeek V9 file.
971 Put in comments nothing some additional checks we should do.
975 * AUTHORS, doc/ethereal.pod, wiretap/AUTHORS, wiretap/Makefile.am,
976 wiretap/Makefile.nmake, wiretap/airopeek9.c, wiretap/airopeek9.h,
977 wiretap/file_access.c, wiretap/wtap.h:
979 From Martijn Schipper: support for reading AiroPeek files in V9
980 capture file format (AiroPeek 2.x).
986 Tomas Kukosa noted that the TPKT dissector spends a significant
987 amount of time in "find_protocol_by_id()"; the protocol_t pointer
988 for a protocol doesn't change over time, so get that pointer when
989 the protocol is registered and save it.
997 1) fix description of Check Point version 5004;
999 2) add description of Check Point version 5005.
1001 2003-12-02 10:23 sahlberg
1003 * epan/: proto.c, tvbuff.c, tvbuff.h:
1005 Move the definition of the tvbuff_t structure and friends to
1006 tvbuff.h so that we can change tvb_get_ds_tvb() into a macro.
1008 This function was a single line assignment and was called a lot.
1010 This made tethereal ~2.5% faster in one testcase I use.
1012 2003-12-02 09:47 sahlberg
1014 * epan/: proto.c, ftypes/ftypes.c, ftypes/ftypes.h:
1016 Use the LSAB_ALLOC and SLAB_FREE macros to allocate/free fvalue_t
1019 2003-12-02 09:11 sahlberg
1021 * epan/: proto.c, slab.h:
1023 Moving SLAB_ALLOC and SLAB_FREE to its own header file
1025 2003-12-02 09:05 guy
1027 * AUTHORS, packet-isakmp.c, doc/ethereal.pod:
1029 From Arnaud Jacques: fix a typo, and handle another CheckPoint
1032 2003-12-02 06:06 guy
1038 Correct several problems with zoneset decodes (e.g. the
1040 and zone name lengths do *not* include the pad bytes, so
1042 offset calculation needed to be fixed).
1044 Move the decode of zoneset name into the routine
1045 "dissect_fcfzs_zoneset", so that it is done in only one
1048 2003-12-02 05:53 guy
1052 Don't call the presentation layer dissector if we don't have a
1055 2003-12-02 02:58 guy
1057 * packet-bssap.c, packet-tcap.c:
1059 From Michael Lum: don't register the handoff routine for
1060 dissectors as a preference change callback if the ports they
1061 register on aren't preferences.
1063 2003-12-01 23:41 guy
1065 * epan/value_string.c, epan/value_string.h,
1066 plugins/plugin_api_list.c, plugins/Xass-list,
1067 plugins/Xplugin_api.c, plugins/Xplugin_api.h,
1068 plugins/Xplugin_api_decls.h, plugins/Xplugin_table.h:
1070 From Tomas Kukosa: add "decode_enumerated_bitfield_shifted()",
1071 which is like "decode_enumerated_bitfield()" but handles
1072 value_string tables containing values as they appear in the
1073 bitfield rather than as they appear in the item containing the
1076 2003-12-01 23:26 guy
1080 From Michael Lum: add a preference setting to specify the
1081 parameter tag for "Protocol Data 1", as it changed between draft
1084 2003-12-01 23:05 guy
1086 * Makefile.am, Makefile.nmake, packet-ansi_a.c, packet-ansi_a.h,
1087 packet-bssap.c, tap-ansi_astat.c:
1091 add a message statistics tap for ANSI A interface for
1094 fix the BSSAP, BSMAP, and DTAP interface dissectors to
1096 subdissectors even if no protocol tree is being built.
1098 2003-12-01 22:25 guy
1102 From Michael Lum: add a heuristic RANAP dissector, for use atop
1103 SCCP, as the SCCP dissector currently doesn't support
1104 conversations to be given dissectors.
1106 2003-12-01 20:27 gerald
1110 Don't automatically fill in a capture filter if CLIENTNAME is set
1113 2003-12-01 17:25 gerald
1117 Updates for new zlib.
1119 2003-12-01 17:19 gerald
1121 * packaging/nsis/ethereal.nsi:
1123 Switch from zlib.dll to zlib1.dll.
1125 2003-12-01 17:17 gerald
1129 Switch to the new (and official) zlib DLL from www.gzip.org.
1131 2003-12-01 06:59 sharpe
1133 * wiretap/file_access.c:
1135 It's RedHat, not Red Hat.
1137 2003-12-01 02:01 guy
1139 * gtk/: file_dlg.c, file_dlg.h, print_dlg.c, proto_draw.c:
1141 "select_file_cb()" only needs a title, not a "construct_args_t" -
1142 "construct_args_t" is for use with filter dialogs, and the
1143 members other than the title apply only to filter dialogs.
1145 Have "select_file_cb()" actually use the title supplied to it.
1147 2003-12-01 01:57 sharpe
1151 Fix the accelerator issue ...
1153 2003-11-30 23:05 guy
1157 Not all platforms have <unistd.h> - in particular, Windows
1160 If you're using "open()", "close()", "read()", "write()", etc.,
1161 you should include <io.h> on Windows.
1163 2003-11-30 18:01 sharpe
1167 Fix some warnings in proto_draw.c
1169 2003-11-30 04:40 sharpe
1173 Rename that to Save Highlighted with Ctl-H as the accellerator.
1175 2003-11-30 04:37 sharpe
1179 Add Save Selected as a menu item in the File Menu.
1181 This still has a way to go, though, because the menu item should
1182 be greyed out until something is Highlighted.
1184 2003-11-30 04:21 sharpe
1186 * gtk/: color_dlg.c, file_dlg.c, file_dlg.h, menu.c, print_dlg.c,
1187 proto_draw.c, toolbar.c:
1189 Move print_file_cb out of gtk/print_dlg.c and into gtk/file_dlg.c
1190 and rename it to select_file_cb to reflect its function.
1192 While this cleans things up a bit, I am still not happy because
1193 now filter_prefs.h must be included before file_dlg.h just to get
1196 2003-11-29 12:34 jmayer
1198 * doc/README.tapping:
1202 2003-11-29 06:15 sharpe
1206 Properly capitalize the string for the menu item.
1208 2003-11-29 06:09 sharpe
1210 * gtk/: file_dlg.h, menu.c, print_dlg.c, proto_draw.c:
1212 Add an entry in the byte_view pane that allows the user to save
1213 the highlighted data to a file. This allows the user to select
1214 some stuff, and analyse it with external tools, and is very
1215 useful for quickly prototying dissectors etc.
1217 This works by retrieving the info that is needed to define where
1218 the selected region is.
1220 It puts up a dialog box that asks for the file to save in.
1222 However, it is an ugly hack, because it reuses print_file_cb,
1223 while print_file_cb should be moved into file_dlg.c.
1225 It also needs to have some warning dialogs put up in error cases.
1227 Finally, it would be good to be able to select a region in the
1228 byte_view, which you can do with click and drag, and then have a
1229 menu item to save the selected bytes.
1231 2003-11-29 03:55 guy
1233 * AUTHORS, packet-gtp.c, doc/ethereal.pod:
1235 From melerski [AT] poczta.onet.pl: fix a problem with unknown
1238 2003-11-28 19:13 ulfl
1242 renamed frame to packet in all GUI elements moved "Enabled
1243 Protocols" and such from "View" to "Analyze" toplevel menu
1245 2003-11-28 19:02 ulfl
1249 renamed frame to packet in all GUI elements
1251 2003-11-28 19:00 ulfl
1253 * gtk/capture_info_dlg.c:
1255 use dlg_window_new instead of gtk_window_new
1257 2003-11-28 18:59 ulfl
1259 * gtk/: toolbar.c, find_dlg.c:
1261 renamed frame to packet in all GUI elements
1263 2003-11-28 00:44 ulfl
1265 * gtk/capture_info_dlg.c:
1267 label changed from "Portions" to "% of total" as suggested by Guy
1269 2003-11-28 00:13 ulfl
1273 using dlg_utils.c functions to catch the ESC key to close the
1276 2003-11-28 00:07 ulfl
1278 * gtk/: supported_protos_dlg.c, plugins_dlg.c:
1280 using dlg_utils.c functions to catch the ESC key to close the
1283 2003-11-27 23:25 ulfl
1287 using dlg_utils.c functions to catch the ESC key to close the
1290 2003-11-27 22:29 guy
1294 "representation", in an "item_label_t", is now an array, not a
1295 pointer, so "fi->rep->representation" can't be null.
1297 2003-11-27 22:15 guy
1299 * tap-rpcstat.c, tap-wspstat.c:
1301 Fix comments to correctly refer to the "-z" option.
1303 2003-11-27 22:14 guy
1307 From Michael Lum: fix the usage message to refer to "-z", not
1310 2003-11-27 22:12 guy
1314 Show the -z flag in the usage message.
1316 2003-11-27 22:04 guy
1320 From Michael Lum: fix the usage message to say "-z", not "-Z".
1322 2003-11-27 21:20 guy
1324 * AUTHORS, packet-rtp-events.c, doc/ethereal.pod:
1326 From Arsen Chaloyan: fix offsets in "proto_tree_add" calls.
1328 2003-11-27 21:09 guy
1330 * etypes.h, packet-ethertype.c, plugins/rtnet/packet-rtnet.c:
1332 From Erwin Rol: RTCFG support.
1334 Add in a URL to the RTNET home page.
1336 2003-11-27 21:02 guy
1340 From David Fort: fix to previous patch.
1342 2003-11-27 20:34 ulfl
1346 Redesign of the whole menu structure, to be more intuitive to the
1347 user and conforms somewhat better to the Gnome Human Interface
1350 2003-11-27 17:18 ulfl
1354 bugfix: removed access violation when using "File/Print Packet".
1355 The label_ptr could be NULL, when calling function print_line
1357 2003-11-27 00:22 ulfl
1361 using text files from help dir, to display the help texts. the
1362 "dynamic protocol fields" are already moved to
1363 gtk/supported_protos_dlg.c
1365 2003-11-27 00:17 ulfl
1367 * help/: capture_filters.h, display_filters.h, faq.h, overview.h,
1370 Added this intermediate files, until a Makfile.am is available
1373 2003-11-26 23:23 guy
1375 * AUTHORS, packet-dns.c, doc/ethereal.pod:
1377 From David Fort: DNS DSS RR support.
1379 2003-11-26 12:22 sahlberg
1381 * epan/: proto.c, proto.h:
1385 create generic macros for allocating/freeing structures.
1387 remove one more slow GMemChunk and replace it with a simple
1390 ~4% speed improvement in my tests.
1392 the allocated data is never freed. this may be a problem if
1393 ethereal is ever supported on a platform lacking resource
1394 tracking but makes the implementation faster and simpler.
1396 2003-11-26 02:58 guy
1398 * AUTHORS, packet-giop.c, doc/ethereal.pod:
1400 From Patrick Kursawe: rename "getline()" so it doesn't collide
1401 with the "getline()" declared in <stdio.h> with recent versions
1404 Fix a typo in the AUTHORS file.
1406 2003-11-26 02:54 guy
1410 From Jaime Fournier: fix a typo.
1412 2003-11-25 20:26 guy
1414 * AUTHORS, packet-ucp.c, doc/ethereal.pod:
1416 From Reinhard Speyerer: handle 10-digit UCP dates, which lack a
1419 2003-11-25 20:02 guy
1423 As with fvalue_t, so with field_info and item_label - the
1424 individual items aren't individually g_mallocated and can't be
1425 g_freed, only the chunks can.
1427 2003-11-25 19:25 guy
1429 * epan/ftypes/ftypes.c:
1431 Individual fvalue_t's aren't individually allocated with
1432 "g_malloc()", so they can't be freed with "g_free()"; keep a list
1433 of the chunks of "fvalue_t"s, which are whare are allocated with
1434 "g_malloc()", so we can free them all.
1436 2003-11-25 18:02 guy
1440 From Anders Broman: add more SIP headers, and the PUBLISH method.
1442 2003-11-25 14:16 sahlberg
1446 replace free_node_field_info with a macro since it is only called
1447 from one other place in the code and this reduces one unnecessary
1448 function call overhead. and it makes ethereal ~1% faster.
1450 2003-11-25 14:11 sahlberg
1454 rename FREE_FIELD_INFO to FIELD_INFO_FREE for consistency
1456 2003-11-25 14:10 sahlberg
1460 create a FIELD_INFO_NEW for consistency
1462 2003-11-25 14:07 sahlberg
1464 * file.c, print.c, epan/proto.c, epan/proto.h, gtk/proto_draw.c:
1466 remove another slow GMemChunk from ethereal making ethereal a
1469 2003-11-25 13:23 sahlberg
1473 change free_field_info to FREE_FIELD_INFO to indicate it is a
1474 macro and not a function
1476 2003-11-25 13:20 sahlberg
1478 * epan/proto.c, epan/dfilter/dfvm.c, epan/ftypes/ftype-ipv4.c,
1479 epan/ftypes/ftype-string.c, epan/ftypes/ftypes-int.h,
1480 epan/ftypes/ftypes.c, epan/ftypes/ftypes.h,
1481 gtk/dfilter_expr_dlg.c:
1483 fvalue_free() is one of the most called functions. This function
1484 is also very small, so small that teh overhead for the actual
1485 function call and return is likely to be a significant part of
1488 change it into a macro and make it thus slightly faster by
1489 eliminating the function call overhead.
1491 2003-11-25 08:50 sahlberg
1493 * epan/ftypes/: ftypes.c, ftypes.h:
1495 Change the handling of temporary allocation of fvalue_t
1496 structures to be faster. Use a similar technique as was used in
1497 epan/proto.c to speed up the field_info allocation/deallocation
1500 2003-11-25 08:19 guy
1504 From Jaime Fournier: show the RPC version of the unknown
1505 interface in the Info column.
1507 2003-11-25 08:10 guy
1509 * AUTHORS, Makefile.am, Makefile.nmake, packet-dcerpc-budb.c,
1510 packet-dcerpc-epm4.c, packet-dcerpc-icl_rpc.c,
1511 packet-dcerpc-rs_prop_acct.c:
1513 From Jamie Fournier: DCE RPC EPM version 4 support, and stub
1514 support for BUDB, ICL RPC, and RS_PROP_ACCT DCE RPC-based
1517 2003-11-25 05:58 guy
1521 "file_seek()" sets "*err" - we don't have to set it ourselves.
1523 The same is true of "parse_cosine_rec_hdr()".
1525 2003-11-25 05:56 guy
1527 * wiretap/network_instruments.c:
1529 "file_seek()" sets "*err" - there's no need to set it ourselves.
1530 It returns -1 on errors, so just check for that.
1532 2003-11-25 00:21 guy
1538 2003-11-24 23:46 guy
1542 Eliminate compiler warnings.
1544 2003-11-24 22:11 guy
1546 * packet-ncp2222.inc, print.c, proto_hier_stats.c,
1547 tap-protohierstat.c, epan/proto.c, epan/proto.h, gtk/main.c,
1548 gtk/menu.c, gtk/prefs_dlg.c, gtk/rtp_analysis.c:
1550 Make the recent epan/proto.{c,h} change compile.
1552 2003-11-24 21:42 guy
1554 * ipproto.c, ipproto.h, packet-mip6.c:
1556 Preserve 62 as an (old) IP protocol type for mobility headers.
1558 2003-11-24 21:12 sahlberg
1560 * epan/: proto.c, proto.h:
1562 performance enhancement to proto.c
1564 Removed the GMemChunk used to allocate/free field_info structures
1565 and used a free list to store the freed structs until they are
1568 Ethereal will allocate more field_info structs as it needs to but
1569 never free them. Instead the are just placed in a cheap and fast
1570 free list so that if we want to use the struct again, this will
1573 This affects the speed of the two functions alloc_field_info()
1574 that should be slightly faster now free_field_info() that was
1575 replaced with a 2 line macro.
1577 All in all my testing suggests that ethereal is 2-3% faster with
1580 2003-11-24 17:41 ulfl
1584 bugfix: corrected clean and distclean targets
1586 2003-11-24 00:34 guy
1588 * AUTHORS, Makefile.am, Makefile.nmake, packet-ccsds.c,
1591 From Scott Hovis :CCSDS (Consultative Committee for Space Data
1594 2003-11-24 00:05 guy
1598 From Anders Broman: fix dissection of GRS/GRA messages.
1600 2003-11-23 23:42 guy
1604 Include the BFD dissector when building with MSVC++.
1606 2003-11-23 22:00 gerald
1608 * AUTHORS, Makefile.am, packet-bfd.c:
1610 From Hannes Gredler: Add support for Bi-directional Fault
1613 2003-11-22 12:02 jmayer
1617 - Bugfix: Passworddecoding should only be done for attribute 2,
1618 but not for VSA 2 - Fixme comment about length handling
1619 added - Cleanup: Setting a variable to the right type removes the
1620 necessity for casts.
1622 2003-11-22 11:12 sahlberg
1626 Change the way signalType is dissected to be compatible with and
1627 dissect the packets from Martin R and Paul H.
1629 I still think ethereal was correct before this patch and that
1630 this patch is not compatible with teh standard. Anyway, that
1631 doesnt matter much. With this patch ethereal will dissect the
1632 packets properly. Time to study x691 again.
1634 2003-11-22 08:35 guy
1636 * ipproto.h, packet-ipv6.h:
1638 From Martti Kuparinen: use correct values for Mobile IPv6.
1640 2003-11-22 04:41 sahlberg
1644 As per Guys suggestion, continue optimizing proto.c to macroize
1645 it and make it even faster
1647 2003-11-21 22:18 guy
1651 From Olivier Biot: fix up the description of the
1652 "port_number_udh_means_wsp" preference.
1654 2003-11-21 22:00 guy
1660 * Fix the WSP dissector so a Quoted-string with
1662 trailing quote is displayed without duplicated final
1664 issue a warning in the protocol tree.
1665 * Remove the Openwave x-up-proxy-client-id header
1667 was incorrectly decoded as a text string, and process
1669 the default Openwave header parser.
1670 * Fix byte highlighting of some WSP parameters.
1671 * Rename the WSP parameter filter names so they don't all
1675 2003-11-21 21:58 guy
1677 * packet-wbxml.c, epan/packet.c, epan/packet_info.h:
1681 * Add a "match_string" field to the "packet_info"
1683 saving the string value that matched in a string
1685 lookup, by analogy to "match_port" - this was required
1687 dissection with token rendering of WBXML content when
1689 ID was given (e.g. Nokia/Ericsson OTA provisioning
1691 * Add support for textual content type based WBXML token
1693 * Add extra WBXML public identifiers.
1694 * Add the Nokia/Ericsson OTA provisioning (version 7)
1697 * Inform the user when a content-type based token match
1700 2003-11-21 21:33 guy
1702 * AUTHORS, packet-dcerpc-srvsvc.c, doc/ethereal.pod:
1704 From Eric Wedel: fix dissection of NetServerDiskEnum reply.
1706 2003-11-21 19:24 guy
1710 From Lars Ruoff: use the pointer to the RTP payload, rather than
1711 extracting the data from the frame directly.
1713 2003-11-21 14:58 sahlberg
1715 * epan/: proto.c, proto.h:
1719 In the GPROF logs proto_registrar_get_nth() used to take anything
1720 between 2.5 and 5.5% of the time.
1722 Replace the GLIB array with a handroleld one for one of the
1725 the function should now be virtually zero cost and thus ethereal
1726 should be 2.5-5.5% faster on those traces.
1728 anyone that wants to, please rerun GPROF with this fix and see
1731 2003-11-21 08:40 guy
1733 * packet-dcerpc-epm.c:
1735 A "handle_t" as the first argument to a call doesn't seem to be
1736 sent over the wire, at least in the DCE RPC 1.1 code.
1738 That suggests that the first 24 bytes of a Map request are the
1739 UUID pointer that the EPM IDL says should be there, not a context
1742 2003-11-21 08:33 guy
1746 Maybe the problem is that the compilers used on AIX weren't
1747 defining "AIX", and that code was never compiled. Libpcap uses
1748 "_AIX" to conditionally compile in the extra AIX BPF support;
1751 2003-11-21 08:30 guy
1755 Pass "strncmp()" the right number of arguments. (Why hasn't
1756 anybody reported this as a problem when compiling on AIX?
1757 Doesn't any compiler complain that "strncmp()" isn't being passed
1758 enough arguments? GCC sure did in a test program I built on
1761 2003-11-21 04:01 guy
1765 From Jamie Fournier: add the UUID to the Info column for datagram
1768 2003-11-21 02:57 guy
1770 * AUTHORS, Makefile.am, Makefile.nmake, packet-dcerpc-rs_plcy.c:
1772 From Jamie Fournier: DCERPC RS_PLCY support.
1774 2003-11-21 02:48 guy
1776 * packet-dcerpc-ndr.c, packet-dcerpc.h:
1778 The 32-bit integer at the beginning of a context_handle is called
1779 "context_handle_attributes" in the DCE RPC 1.1 "nbase.idl".
1780 Rename our structure member accordingly.
1782 Note in a comment that we should perhaps display a context_handle
1783 as the attributes and UUID.
1785 Use "proto_tree_add_item()", not "proto_tree_add_bytes()", to put
1786 the context handle raw data into the protocol tree.
1788 2003-11-20 23:34 guy
1790 * packet-rtp.c, packet-rtp.h, gtk/Makefile.am, gtk/Makefile.nmake,
1791 gtk/rtp_stream.c, gtk/rtp_stream.h, gtk/rtp_stream_dlg.c:
1795 - added a pointer to raw rtp data to _rtp_info that can
1799 - RTP packets are passed to the tap queue only if they
1801 error packets (so that you don't need to filter out
1805 - use that pointer in rtp_stream, so it handles packets
1807 padding, and should handle RTP packets fragmented
1811 - moved rtp_stream from tap sources to normal files
1812 (prevents on-start-up registration of the rtp_stream
1816 - rtp_stream tap gets registered/unregistered with the
1819 i.e. the tap is registered as long as the dialog box is
1821 Alternatively, it is de-/registered on demand if RTP
1823 called directly on a packet.
1825 - rtp_stream tap listener no longer uses a filter in
1827 ` and does not need to have a proto tree being built.
1828 (performance increase)
1830 - fixed: RTP Streams list will get updated in real time
1832 dialog box is open while a redissection takes place.
1834 2003-11-20 23:21 guy
1836 * packet-dcerpc-srvsvc.c:
1838 #if 0-out some no-longer-used routines.
1840 Use #if 0/#endif rather than comments to remove the code that
1841 used to refer to those routines - it's a bit more robust in the
1842 presence of comments (there aren't currently any, but, just in
1843 case somebody adds them...).
1845 2003-11-20 22:50 guy
1849 From Olivier Biot: add support for media type
1850 "application/x-prov.syncset+wbxml".
1852 2003-11-20 22:38 guy
1856 From Martin Mathieson:
1858 - Add some summary info to REGISTER requests and
1860 - Tidy up whitespace a little
1862 2003-11-20 22:24 guy
1868 * Fix an incorrectly #ifdef'ed return introduced by the
1871 * Remove the parsed_length parameter from the function
1873 of the tag and attribute dissectors - have it return
1875 parsed length, instead
1876 * Throw ReportedBoundsError exceptions if we run past the
1878 the tvbuff, rather than putting a special entry in
1879 * Produce consistent and extensive debug logging (enabled
1881 defining DEBUG_wbxml)
1882 * Get rid of the dozens of "#ifdef DEBUG ... #endif"
1886 2003-11-20 19:05 guy
1890 From Hannes Gredler: "print_system_id()" should call
1891 "print_system_id_buf()", not "print_nsap_net_buf()". (What idiot
1892 made *that* mistake? :-))
1894 2003-11-20 14:29 nneul
1900 2003-11-20 06:43 sharpe
1902 * packet-dcerpc-srvsvc.c:
1904 Clean up some IDL and remove some structures that Windows of all
1905 flavors does not understand. SHARE_INFO_1004, 1005, 1006, 1007,
1906 and 1501 seem not to be understood by any, and it can screw up
1909 2003-11-20 05:20 guy
1913 Use "tvb_get_string()" in "proto_tree_set_string_tvb()" - it
1914 won't leak memory if it throws an exception, as it checks whether
1915 the entire string is in the tvbuff *before* allocating a buffer
1916 for it, and that also means that if the length is absurdly large,
1917 an exception will be thrown, rather than the memory allocation
1920 2003-11-20 05:04 guy
1924 On Mac OS X, disable the alarm/longjmp stuff for timing out name
1925 resolution queries - it runs a significant risk of crashing
1926 applications that do that.
1928 2003-11-20 04:28 gerald
1930 * AUTHORS, doc/ethereal.pod:
1932 Update Jakob Schlyter's address.
1934 2003-11-19 22:55 guy
1938 From Olivier Biot: fix the WBXML dissector in cases where
1939 dissection is interrupted because of a short frame or packets not
1940 being reassembled, and provide additional debug logging.
1942 2003-11-19 22:13 nneul
1944 * Makefile.am, Makefile.nmake, packet-sebek.c:
1946 Add dissector for the SEBEK kernel read() data capture and/or
1947 rootkit tool used as part of the HoneyNet project.
1949 Info at: http://project.honeynet.org/tools/sebek/
1951 2003-11-19 21:24 guy
1957 correct (and document) the offset computation in the
1959 and parameter_value_q() functions.
1963 - a copy-paste with a missing replacement;
1964 - content-disposition uses parameters not q-values;
1965 - missing "+" for the calculation of parameter-offsets;
1966 - white-space cleanup;
1969 2003-11-19 09:58 guy
1971 * packet-isis-lsp.c, packet-isis-lsp.h:
1973 Fix the ATT bit definitions.
1975 2003-11-19 09:49 guy
1979 Get rid of unused variables.
1981 2003-11-19 09:43 guy
1985 From Olivier Biot: get rid of no-longer-used routines.
1987 2003-11-19 09:32 sahlberg
1991 Update to TCP, when we see a SYN|ACK packetm reset base_ack to
1992 the current ACK-1 so that it looks right when doing relative
1993 sequence numbers. I.e. SEQ : seq==0 ack==0 SEQ|ACK
1994 seq==0 ack==1 ACK seq==1 ack==1
1996 This looks much more correct.
1998 This change also fixes the problem reported to ethereal-dev
1999 recently with "Follow TCP Stream" dropping the first character of
2002 2003-11-19 07:13 sharpe
2004 * packet-dcerpc-wkssvc.c:
2008 2003-11-19 04:30 guy
2012 From Dave Sclarsky: fix the offset for the Node WWN.
2014 2003-11-19 04:26 guy
2018 Get rid of some unused arguments and variables.
2020 Clean up the handling of the footer, so that it works even with
2023 2003-11-19 04:05 guy
2027 "uint" preferences should be "guint"s, not "int"s.
2029 2003-11-19 04:02 guy
2035 2003-11-19 04:00 guy
2037 * AUTHORS, Makefile.am, Makefile.nmake, packet-cpfi.c,
2040 From Dave Sclarsky: CPFI support.
2042 2003-11-19 03:53 guy
2044 * packet-smb-browse.c, packet-smb-logon.c, packet-smb-mailslot.c:
2046 "dissect_mailslot_browse()", "dissect_mailslot_lanman()", and
2047 "dissect_smb_logon()" always return TRUE, so just get rid of
2050 "call_dissector()" automatically calls the data dissector if the
2051 protocol for the dissector being called is disabled, so we don't
2052 have to check its result and call the data dissector if it
2055 2003-11-19 02:58 guy
2059 Register the MMSE dissector with the "http.content_type"
2060 dissector table, rathe than as a heuristic subdissector of HTTP.
2062 2003-11-19 01:50 guy
2064 * gtk/supported_protos_dlg.c:
2066 Use "OK" for the "OK" button, as we do elsewhere.
2068 2003-11-19 01:45 guy
2074 Implement quoted-string parsing by appending the closing
2076 to the string value. If the quoted-string value does not
2078 with a quote, dissection resumes but a warning is
2080 Textual headers are assumed to be 0x00 terminated
2082 have a malformed packet or a short frame).
2084 The Trailer header is also dissected now, and the charset
2085 parameter dissection has been rewritten.
2087 The Content-ID header dissector was registered at the
2089 the Trailer dissector; this has also been fixed.
2091 2003-11-19 01:39 guy
2093 * packet-ansi_map.c:
2095 From Michael Lum: fix param_digits() subtree for "Nature of
2098 2003-11-19 00:10 ulfl
2102 redraw supported_protos dialog, if GUI prefs changed
2104 2003-11-19 00:04 ulfl
2108 added supported_protos menu item
2110 2003-11-19 00:02 ulfl
2114 added supported_protos_dlg
2116 2003-11-19 00:01 ulfl
2118 * gtk/Makefile.nmake:
2120 added supported_protos_dlg.obj
2122 2003-11-18 23:56 ulfl
2124 * gtk/: supported_protos_dlg.c, supported_protos_dlg.h:
2126 seperated "supported protocols and protocol fields" dialog,
2127 coming from help_dlg.c/.h
2129 2003-11-18 23:40 ulfl
2133 generate "static" help content
2135 2003-11-18 23:11 ulfl
2137 * help/: capture_filters.txt, convert-include.sh, Makefile.nmake,
2138 display_filters.txt, faq.txt, overview.txt, well_known.txt:
2140 "static content" and make environment of redesigned online help
2142 2003-11-18 19:56 guy
2148 dissect the RFC 2610 DHCP options for SLP;
2150 dissect Novell-specific options 85, 86, and 87.
2152 2003-11-18 19:46 guy
2156 From Lars Roland: the window size passed to
2157 "tcp_analyze_sequence_number()" is a "guint32", as it might be
2158 scaled - make the arugment a "guint32" as well.
2160 2003-11-18 19:36 guy
2162 * plugins/: Xass-list, Xplugin_api.c, Xplugin_api.h,
2163 Xplugin_api_decls.h, Xplugin_table.h:
2165 Get rid of the second "col_set_fence()" entry.
2167 2003-11-18 19:34 guy
2169 * plugins/plugin_api_list.c:
2171 The second of the "col_set_fence()" entries is the one that
2172 should've been removed; that way, the ordinals of existing
2173 entries in the function vector is preserved.
2175 2003-11-18 19:31 guy
2177 * plugins/Makefile.nmake:
2179 From Lars Roland: put missing "enttec" into "all" list.
2181 2003-11-18 19:29 ulfl
2183 * gtk/capture_dlg.c:
2185 removed MSVC compiler warnings
2187 2003-11-18 19:28 guy
2191 From Matthias Drochner:
2193 extensions need only be a multiple of 4 bytes in length,
2197 put in a missing increment of "offset".
2199 2003-11-18 19:27 ulfl
2205 2003-11-18 19:26 ulfl
2207 * plugins/plugin_api_list.c:
2209 col_set_fence occurs twice, removed one appearance
2211 2003-11-18 19:20 guy
2213 * epan/filesystem.h:
2215 From Tomas Kukosa: add "extern"s so that the plugin API stuff
2218 2003-11-18 19:20 ulfl
2222 includes changed, to be working with MSVC also
2224 2003-11-18 19:18 ulfl
2226 * plugins/rdm/Makefile.nmake:
2228 corrected cut and paste errors, makefile was unchanged copied
2231 2003-11-18 08:59 guy
2233 * plugins/: Xass-list, Xplugin_api.c, Xplugin_api.h,
2234 Xplugin_api_decls.h, Xplugin_table.h:
2236 Add "col_get_writable()", "col_set_writable()", and
2237 "col_set_fence()" to the plugin API list.
2239 2003-11-18 08:58 guy
2241 * plugins/Xplugin_table.h:
2243 Export "protocol_t" as an opaque type.
2245 Make "proto_is_protocol_enabled()" and
2246 "proto_get_protocol_short_name()" take a "protocol_t *" as an
2247 argument, so they don't have to look up the "protocol_t" - this
2248 will probably speed them up considerably, and they're called on
2249 almost every dissector handoff.
2251 Get rid of a number of "proto_is_protocol_enabled()" calls that
2252 aren't necessary (dissectors called through handles, including
2253 those called through dissector tables, or called as heuristic
2254 dissectors, aren't even called if their protocol isn't enabled).
2256 Change some direct dissector calls to go through handles.
2258 2003-11-18 08:55 guy
2260 * plugins/plugin_api_list.c:
2262 Add "col_get_writable()", "col_set_writable()", and
2263 "col_set_fence()" to the plugin API list.
2265 2003-11-18 08:13 guy
2267 * configure.in, epan/configure.in, wiretap/configure.in:
2269 From Olivier Biot: add a "--enable-profile-build" flag to request
2270 that "-pg" binaries be built.
2272 2003-11-18 08:04 guy
2276 Content-Type values are case-insensitive; force them to lower
2277 case (subdissectors must register their Content-Type values as
2280 Don't include parameters in the value we look up in the
2281 Content-Type subdissector table.
2283 2003-11-18 07:49 guy
2287 Add an "http.content_type" dissector table,
2289 Process the Content-Type header, and, if one is found, look up
2290 its value in the aforementioned dissector table.
2292 2003-11-18 07:08 guy
2296 Handle concatenated SPDUs.
2298 Handle the Serial Number parameter.
2300 2003-11-18 06:31 guy
2302 * config.guess, config.sub:
2304 Latest config.guess and config.sub from
2306 http://savannah.gnu.org/projects/config/
2308 2003-11-18 06:06 ulfl
2310 * gtk/capture_info_dlg.c:
2312 removed MSVC warnings
2314 2003-11-18 04:19 gerald
2318 Document the capture filter changes that were just checked in.
2320 2003-11-18 04:16 gerald
2322 * util.c, util.h, gtk/main.c:
2324 Check the environment variables SSH_CONNECTION, SSH_CLIENT,
2325 REMOTEHOST, DISPLAY, and CLIENTNAME (in that order). If any of
2326 them are set, create a capture filter that excludes their traffic
2327 and set it as the default. The longer filters should be
2328 efficient without being overly long; they may need some tweaking.
2330 2003-11-18 00:46 ulfl
2334 removed some warnings
2336 2003-11-17 22:56 sahlberg
2340 updates to ip_to_str[_buf]() to make them faster.
2342 This functin was in a recent profiling run the fifth most
2343 expensive function. It consumed ~3.5% of the total cpu in that
2346 Using a static table this function is now just over twice as fast
2349 My testrun calling it 10.000.000 times in a loop changed the
2350 execution time from ~17.3s ro ~8.2s
2352 If this test was representative for the speedup and if ~3.5 in
2353 the profile run was representative for normal cases this should
2354 make ethereal ~1.8% faster. Woohoo. (low hanging fruit)
2356 2003-11-17 22:34 guy
2358 * plugins/: acn/Makefile.am, artnet/Makefile.am, asn1/Makefile.am,
2359 gryphon/Makefile.am, mgcp/Makefile.am, pcli/Makefile.am,
2362 Fix the copyright notices (Gerald has the copyright on Ethereal).
2364 2003-11-17 22:31 guy
2366 * plugins/giop/Makefile.am:
2368 Tweak the introductory comment.
2370 2003-11-17 22:29 guy
2372 * plugins/: enttec/.cvsignore, rdm/.cvsignore:
2374 Fix the .cvsignore files.
2376 2003-11-17 22:26 guy
2378 * plugins/rdm/packet-rdm.c:
2380 From Erwin Rol: check the checksum in RDM packets.
2382 2003-11-17 22:09 guy
2386 From Loïc Minier: append $(EXEEXT) to the names of binaries, so
2387 that the configure script generates the right executable image
2388 file names on Cygwin.
2390 2003-11-17 21:52 guy
2394 From Lars Roland: use the c= and m= information to set up
2395 conversations to use RTP/RTCP.
2397 2003-11-17 20:57 guy
2399 * AUTHORS, Makefile.am, configure.in,
2400 packaging/nsis/Makefile.nmake, packaging/nsis/ethereal.nsi,
2401 plugins/Makefile.am, plugins/Makefile.nmake,
2402 plugins/artnet/ChangeLog, plugins/artnet/moduleinfo.h,
2403 plugins/artnet/packet-artnet.c, plugins/enttec/.cvsignore,
2404 plugins/enttec/AUTHORS, plugins/enttec/COPYING,
2405 plugins/enttec/ChangeLog, plugins/enttec/INSTALL,
2406 plugins/enttec/Makefile.am, plugins/enttec/Makefile.nmake,
2407 plugins/enttec/NEWS, plugins/enttec/moduleinfo.h,
2408 plugins/enttec/packet-enttec.c, plugins/rdm/.cvsignore,
2409 plugins/rdm/AUTHORS, plugins/rdm/COPYING,
2410 plugins/rdm/Makefile.am, plugins/rdm/Makefile.nmake,
2411 plugins/rdm/moduleinfo.h, plugins/rdm/packet-rdm.c:
2413 From Erwin Rol: initial ENTTEC support and RDM support.
2415 2003-11-17 20:00 guy
2417 * gtk/capture_info_dlg.c:
2419 Not all compilers allow array/structure/union members of
2420 automatic variables to be initialized to non-constant values (C89
2421 says that "All the expressions in an initializer for an object
2422 that has static storage duration or in an initializer list for an
2423 object that has aggregate or union type shall be constant
2424 expressions"; presumably the intent of the former was to avoid
2425 run-time initialization and of the latter was to let the
2426 initialization be done by copying from a compile-time-created
2427 blob of memory), so we have to initialize "info->counts" by hand.
2429 2003-11-17 19:40 guy
2435 2003-11-17 18:23 ulfl
2437 * etypes.h, packet-ethertype.c:
2439 added ETHERTYPE_PROFINET
2441 2003-11-17 00:27 guy
2443 * gtk/capture_info_dlg.c:
2445 "capture()" takes a "struct pcap_stat *" argument, so you need to
2446 include <pcap.h> before including "capture.h".
2448 Include "dlg_utils.h" to declare "dlg_set_cancel()".
2450 2003-11-17 00:26 guy
2454 Get rid of a no-longer-used variable.
2456 2003-11-16 23:17 guy
2458 * Makefile.am, disabled_protos.c, packet-alcap.c,
2459 packet-ansi_637.c, packet-ansi_683.c, packet-ansi_a.c,
2460 packet-ansi_map.c, packet-atalk.c, packet-clnp.c,
2461 packet-dcerpc.c, packet-dcerpc.h, packet-dvmrp.c, packet-fcip.c,
2462 packet-giop.c, packet-giop.h, packet-gsm_a.c, packet-gsm_sms.c,
2463 packet-gssapi.c, packet-gssapi.h, packet-iscsi.c,
2464 packet-mrdisc.c, packet-msnip.c, packet-pim.c, packet-ppp.c,
2465 packet-rpc.c, packet-rpc.h, packet-smb-browse.c,
2466 packet-smb-browse.h, packet-smb-logon.c, packet-smb-logon.h,
2467 packet-smb-mailslot.c, packet-smb-pipe.c, packet-snmp.c,
2468 packet-tpkt.c, prefs.c, epan/packet.c, epan/proto.c,
2469 epan/proto.h, gtk/dfilter_expr_dlg.c, gtk/help_dlg.c,
2470 gtk/proto_dlg.c, plugins/plugin_api_list.c:
2472 Export "protocol_t" as an opaque type.
2474 Make "proto_is_protocol_enabled()" and
2475 "proto_get_protocol_short_name()" take a "protocol_t *" as an
2476 argument, so they don't have to look up the "protocol_t" - this
2477 will probably speed them up considerably, and they're called on
2478 almost every dissector handoff.
2480 Get rid of a number of "proto_is_protocol_enabled()" calls that
2481 aren't necessary (dissectors called through handles, including
2482 those called through dissector tables, or called as heuristic
2483 dissectors, aren't even called if their protocol isn't enabled).
2485 Change some direct dissector calls to go through handles.
2487 2003-11-16 23:11 sahlberg
2489 * AUTHORS, Makefile.am, Makefile.nmake, h225-persistentdata.c,
2490 h225-persistentdata.h, packet-h225.c, packet-h225.h,
2491 tap-h225rassrt.c, doc/ethereal.pod, doc/tethereal.pod,
2492 gtk/Makefile.am, gtk/Makefile.nmake, gtk/h225_ras_srt.c:
2494 From Lars Roland Service Response times for H225 RAS
2496 2003-11-16 22:33 sahlberg
2502 The hf field we give to dissect_per_object_string is a FT_STRING
2503 and not a FT_BYTES. This caused ethereal to abort with an assert
2506 This fixes the issue that Keith French recently brought up in his
2507 mailing to ethereal-users
2509 2003-11-15 23:58 guy
2513 From Olivier Biot: fix the offset for the Encoding-Version header
2514 in the general form.
2516 2003-11-15 23:48 guy
2520 From Michael Lum: add <shift><control> hotkeys for Protocols and
2523 2003-11-15 11:46 ulfl
2527 GTK2 specific: use some Ethereal specific stock icons generated
2530 2003-11-15 11:44 ulfl
2532 * gtk/: toolbar.c, toolbar.h:
2534 handlebar removed, GTK2 specific: generate some Ethereal specific
2535 stock icons and use them in the toolbar
2537 2003-11-15 11:39 ulfl
2541 added gdk_pixbuf to GTK2 specific libs to link (needed in
2544 2003-11-15 10:06 ulfl
2548 removed no longer used gtk includes
2550 2003-11-15 08:53 ulfl
2552 * gtk/capture_info_dlg.c:
2554 seperated capture dialog from capture.c and put into new
2555 gtk/capture_info_dlg.c, added some tiny bars, that will indicate
2556 the percentage, added ESC key handler and use of GTK_STOCK button
2558 2003-11-15 08:50 ulfl
2560 * gtk/capture_dlg.c:
2562 added "#include <epan/packet.h>" to be able to include
2565 2003-11-15 08:47 ulfl
2567 * capture.c, capture.h, gtk/Makefile.am, gtk/Makefile.nmake:
2569 seperated capture dialog from capture.c and put into new
2570 gtk/capture_info_dlg.c
2572 2003-11-14 21:18 guy
2576 When it comes to whether to use "select()" or not, even if you're
2577 building in Cygwin's pretend-it's-UNIX environment, we need to
2578 treat the platform as Windows.
2580 Get rid of the BSD #define - just check for the platforms on
2581 which we mustn't use "select()".
2583 2003-11-14 19:20 guy
2585 * doc/README.developer:
2587 Fix the stuff that talks about adding to DISSECTOR_SOURCES to
2588 talk about adding to DISSECTOR_SRC instead, and update it to
2589 mention "Makefile.nmake" in the first instance.
2591 2003-11-14 18:59 guy
2595 From Josef Korelus: update the offset after decoding an IE.
2597 2003-11-14 10:11 guy
2601 Fix the heuristics so that they recognize Linux DLT_NULL headers.
2603 2003-11-14 02:07 guy
2607 Add support for the compact form of headers.
2609 2003-11-14 01:35 guy
2613 From Michael Lum: fix up handling of ABORT package.
2615 2003-11-14 01:27 guy
2619 From Olivier Biot: fix the debugging output of
2620 "tvb_get_guintvar()".
2622 2003-11-13 23:44 guy
2626 From Olivier Biot: use "g_strdup_printf()" to generate
2627 dynamically-allocated sprintf output.
2629 2003-11-13 23:38 guy
2631 * packet-eapol.c, packet-isup.c, packet-ldp.c, packet-m2ua.c,
2634 Require that field names contain only alphanumerics, "-", "_",
2637 Fix the names that contained other characters.
2639 2003-11-13 23:13 guy
2643 From Jaime Fournier: get rid of space in field name.
2645 2003-11-13 20:53 sahlberg
2649 Change the gboolean controlling whether to use TCP Sequence
2650 Number Analysis and TCP Relative Sequence Numbers to default to
2651 ENABLED instead of DISABLED.
2653 These features do not consume that much memory or CPU but will
2654 greatly enhance the feature set of ethereal. Make it enabled by
2655 default so also those that never venture into the preferences
2656 dialog will benefit from it.
2658 2003-11-13 08:22 sahlberg
2660 * file.c, doc/ethereal.pod:
2662 For Time Reference frames reset the counter for
2663 CulmulativeBytes. This makes the CulmulativeBytes field make
2664 more sense since if we want something to be a TimeReference frame
2665 it is likely that we also want to measure BOTH time and number of
2666 bytes (==culmulative bytes) until the event we are looking at.
2668 2003-11-13 08:16 sahlberg
2672 Change the strings shown for ICMP TTL exceeded to match the
2673 wording in the standard
2675 2003-11-13 05:08 gerald
2679 We can't pass NULLs to proto_tree_add_text(). Replace a bunch of
2680 occurrences of match_strval() with val_to_str() so that we don't
2683 These changes fix a problem with a file from Martin Dubovsky;
2684 otherwise they haven't been heavily tested.
2686 2003-11-12 23:17 guy
2688 * plugins/docsis/packet-docsis.c:
2690 From Anand Narwani: fix bitmask for Active Grants field.
2692 2003-11-12 22:44 guy
2698 implement the TE header decoding;
2700 fix the exported add_content_type function;
2702 reimplement the header parameter dissection so the
2704 also show up in the related header.
2706 2003-11-12 21:22 guy
2712 * Better decoding of TZSP header.
2713 * Handle unknown tags in packet.
2714 * Removed encapsulation types which are not actually
2716 * Added tags for original length and sensor address.
2717 * Fix signedness of some fields.
2719 Get rid of unused "hf_tzsp_reserved" variable.
2721 Use -1 rather than "tvb_length(tvb)" when constructing the
2722 top-level protocol tree item, and set the length if we have
2723 payload that we dissect separately.
2725 Have "add_option_info()" take a starting offset, rather than
2726 constructing a subset tvbuff for it.
2728 Clean up indentation.
2730 2003-11-12 20:44 guy
2732 * AUTHORS, packet-ntp.c, doc/ethereal.pod:
2734 From Matthias Drochner: support for mode 6 and mode 7 control
2735 packets and NTP4 autokey extension data.
2737 2003-11-12 19:04 ulfl
2741 completely redesigned print dialog layout, to be more obvious to
2744 2003-11-12 18:48 gerald
2748 Remove MAX_DECODE_BUFFER_SIZE; it's no longer used.
2750 2003-11-12 09:00 guy
2754 Put stub data back where it was in the tree before.
2756 2003-11-12 08:58 guy
2760 If what remains of the SMB byte count exceeds the data left in
2761 the tvbuff, show what's left as extra byte parameters - don't act
2762 as if there aren't any extra byte parameters.
2764 2003-11-11 20:49 guy
2766 * packet-null.c, wiretap/snoop.c:
2768 From Brian Ginsbach: fix handling of IRIX and UNICOS/mp snoop
2769 captures on loopback interfaces.
2771 2003-11-11 20:33 guy
2775 Add parameter length checking.
2777 2003-11-11 20:11 guy
2781 From Mohammad Hanif: fix dissection of RSVP DETOUR object code.
2783 2003-11-11 20:08 guy
2785 * image/toolbar/capture_24.xpm, image/toolbar/cfilter_24.xpm,
2786 image/toolbar/dfilter_24.xpm, image/toolbar/stock_close_24.xpm,
2787 image/toolbar/stock_colorselector_24.xpm,
2788 image/toolbar/stock_help_24.xpm,
2789 image/toolbar/stock_jump_to_24.xpm,
2790 image/toolbar/stock_open_24.xpm,
2791 image/toolbar/stock_preferences_24.xpm,
2792 image/toolbar/stock_print_24.xpm,
2793 image/toolbar/stock_refresh_24.xpm,
2794 image/toolbar/stock_right_arrow_24.xpm,
2795 image/toolbar/stock_save_24.xpm,
2796 image/toolbar/stock_search_24.xpm,
2797 image/toolbar/stock_stop_24.xpm, plugins/asn1/moduleinfo.h:
2799 Get rid of carriage returns in source files.
2801 2003-11-11 19:24 guy
2805 Make the declaration of "process_tcp_payload()" match the
2808 2003-11-11 19:23 guy
2812 "tacplus_pref_cb()" takes no arguments, not an unspecified list
2815 2003-11-11 18:25 guy
2819 Get rid of GLib 1.3 support - current versions of GTK+ 1.3
2820 require GLib 2.0, and earlier versions are sufficiently buggy
2821 that we don't want to support them.
2823 2003-11-11 13:59 ulfl
2825 * gtk/print_mswin.c:
2827 added some print dialog flags, to disable some unsupported print
2828 features (e.g. selection of pages from X to Y)
2830 2003-11-11 08:29 guy
2832 * AUTHORS, Makefile.am, Makefile.nmake, packet-ses.c, packet-ses.h,
2835 From Yuriy Sidelnikov: ISO 8327-1 Session Protocol support.
2837 2003-11-11 06:10 guy
2839 * plugins/: plugin_api_list.c, Xass-list, Xplugin_api.c,
2840 Xplugin_api.h, Xplugin_api_decls.h, Xplugin_table.h:
2842 Add "asn1_id_decode1()" to the list of exported functions.
2844 2003-11-11 05:54 guy
2846 * packet-ansi_map.c:
2852 Added IEI level decoding of cdma2000 Handoff * IOS data
2855 2003-11-11 05:51 guy
2861 Change P_xxx to ANSI_A_E_xxx.
2863 Fix decoding of some parameters.
2865 Fix initialization of ett array.
2867 2003-11-11 05:23 guy
2871 The user interface preference page has only 9 rows in the GTK+
2874 2003-11-11 05:09 guy
2878 Create the last two items in the GUI preferences page's first
2879 column the same way the other items are created - in order, going
2880 down the page, and using "pos++" as the table position.
2882 2003-11-10 22:31 guy
2886 From Albert Chin: <stdlib.h> on HP-UX 11.00 (and possibly 10.20
2887 and perhaps some versions of Digital/Tru64 UNIX) drags in
2888 <wait.h>, which drags in <sys/procset.h>, which defines P_SID in
2889 ways that cause this not to compile. Use P_MY_SID instead.
2891 2003-11-10 21:42 guy
2897 "aliasAddress", in an EndPoint sequence, is a sequence of
2900 Don't update the Info or Protocol columns in a pdu_item.
2902 2003-11-10 20:22 guy
2904 * packet-dcerpc-epm.c:
2908 1. Add dissection of inquiry type (rpc_c_ep_all_elts /
2909 rpc_c_ep_match_by_if / rpc_c_ep_match_by_obj /
2910 rpc_c_ep_match_by_both).
2912 2. The version field seems incorrect to me - I believe it
2914 should be version 2.0, not 0.2.
2915 I suspect that the insertion of version information to
2917 table is also wrong, (and the get for the version
2919 used _letohl() ) - but I did not change it.
2921 3. Clean up some white space.
2923 2003-11-10 20:15 guy
2927 From Albert Chin: dynamically allocate the "ett" array - some
2928 compilers (such as at least one older version of the HP C
2929 compiler) can't cope with constant expressions that involve the
2930 "?" operator, it appears; they think it's not a constant
2933 Also, as Albert notes, there's no reason for "ett" to be static
2936 2003-11-10 08:14 sahlberg
2940 The Q.931 dissector never checked whether the codeset variable
2941 was set to a reasonable value or not.
2943 This was problematic and caused crashes since this variable is
2944 used as an index into an array where we grab a pointer (which is
2945 later dereferenced).
2947 Dereferencing that pointer will have surprising effects. Usually
2950 Update Q.931 to verify sanity of the codeset variable everytime
2953 2003-11-10 08:02 sahlberg
2957 Bugfix for ethereal crashes
2959 If the ByteCount field in the SMB PDU spanned beyond the end of
2960 the packet because the packet was short or because the BC field
2961 was corrupted and contained garbade data then the tree item for
2962 the command (the subtree just after the SMBHeader subtree) would
2963 describe data continuing beyond the end of the packet.
2965 If we selected one such tree in the dissect pane and used
2966 Prepare/Match Selected this would cause the filter build thing
2967 to try to access data beyod the end of the packet and ethereal
2970 Change the END_OF_SMB macro so that it shrinks bc so that bc
2971 never describes data beyond the end of the packet.
2973 2003-11-10 07:44 sahlberg
2975 * packet-ldap.c, gtk/dcerpc_stat.c:
2977 Not all LDAP PDUs are aligned to the start of a TCP segment.
2979 If we failed to dissect the GSS-SPNEGO blob it probably means
2980 that the segment is somewhere in the middle of an LDAP PDU.
2982 Just bail out and stop dissecting the PDU instead of aborting
2983 ethereal completely using g_assert() since this is not really a
2984 pathological error, its just something that can and will happen
2987 2003-11-09 22:57 guy
2991 Fix the type of the "integer" argument to
2992 "asn1_uint32_value_decode()", as per a note by Michael Lum.
2994 2003-11-09 22:55 guy
2996 * AUTHORS, packet-rtcp.c, packet-rtp.c, doc/ethereal.pod:
2998 From Martin Mathieson: display the bitfields for
3000 - the first 2 bytes of RTP headers
3001 - the first byte of RTCP report.
3003 2003-11-09 22:49 guy
3005 * packet-ansi_map.c:
3007 From Michael Lum: add the ability to put parameter data at the
3008 end of the parameter name so that the user doesn't have to open
3009 the parameter subtree to see the most important data.
3011 Use "%u", not "%d", to print unsigned quantities.
3013 Get rid of includes of <gmodule.h> (we're not loading any code at
3014 run-time in the dissector itself), and <sys/types.h> and
3015 <netinet/in.h> (we shouldn't need either of those).
3017 2003-11-09 22:41 guy
3021 From Michael Lum get rid of non-portable "%N$" constructs in
3024 Use "%u", not "%d", to print unsigned quantities.
3026 Get rid of includes of <gmodule.h> (we're not loading any code at
3027 run-time in the dissector itself), and <sys/types.h> and
3028 <netinet/in.h> (we shouldn't need either of those).
3030 2003-11-09 22:32 guy
3034 Remove accidentally-inserted letter.
3036 2003-11-09 22:30 guy
3042 Fix some incorrect bit shifts.
3044 Get rid of non-portable "%N$" constructs in printf
3047 Use "%u", not "%d", to print unsigned quantities.
3049 2003-11-09 22:15 guy
3051 * plugins/asn1/packet-asn1.c:
3053 From Albert Chin: the HP-UX 10.20 C compiler doesn't allow
3055 typedef enum _foo foo;
3060 You have to define the enum before using it in a typedef. (If I
3061 had my ANSI C89 standard handy, I could say whether that was
3062 legal ANSI C or not.)
3064 2003-11-09 22:13 guy
3068 From Albert Chin: get rid of null statements outside of function
3069 bodies (that's what the ";" in
3079 2003-11-09 19:53 guy
3081 * packet-dcerpc-dcom.h:
3083 From Albert Chin: get rid of C++ comments.
3085 2003-11-09 01:36 guy
3091 Copy the "gui_fileopen_*" fields in "copy_prefs()".
3093 Fix a typo in "free_prefs()".
3095 2003-11-08 05:47 guy
3097 * packet-tcp.c, packet-tcp.h:
3099 Have "decode_tcp_ports()" handle only the handoff to a
3100 subdissector - and have it return TRUE if we succeeded, FALSE
3101 otherwise - and have an internal "process_tcp_payload()" routine
3102 handle the (TCP-specific) PDU tracking and sequence number
3103 analysis, with an argument to indicate whether it should do that
3104 or not (i.e., whether it's being handed a TCP segment or
3107 2003-11-08 00:09 guy
3109 * AUTHORS, packet-rsvp.c, doc/ethereal.pod:
3111 From Mohammad Hanif:
3113 correct and enhance support for RSVP FAST_REROUTE and
3116 draft-ietf-mpls-rsvp-lsp-fastreroute-03.txt);
3118 support an RSVP SESSION_OBJECT object with ctype = 1.
3120 object contains resource affinities (source: RFC 3209).
3122 2003-11-08 00:02 guy
3124 * packet-msproxy.c, packet-socks.c, packet-tcp.c, packet-tcp.h:
3126 "decode_tcp_ports()" is for use by protocols that proxy
3127 transport-layer packets/sessions, e.g. MSProxy and SOCKS. It
3128 should not cause any of the TCP-specific stuff such as sequence
3129 number analysis or PDU tracking to be done. (Actually, MSProxy
3130 and SOCKS should offer desegmentation services *themselves* and
3131 do their *own* PDU tracking, rather than just passing stuff on to
3132 "decode_tcp_ports()", but that's another matter.)
3134 Make "tcp_tree" once again be a local variable to
3135 "dissect_tcp()", and pass it as an argument to those functions
3138 2003-11-07 23:27 guy
3140 * Makefile.nmake, config.h.win32, config.nmake,
3141 wiretap/Makefile.nmake, wiretap/config.h.win32:
3143 Let people configure whether to build with Zlib or not solely by
3144 controlling whether ZLIB_DIR is defined or not in config.nmake.
3146 2003-11-07 23:26 guy
3148 * gtk/Makefile.nmake:
3150 Nothing here should require zlib.h, so we shouldn't need to do
3153 2003-11-07 20:23 guy
3157 From Olivier Biot: implement the Range, Content-Range and
3158 Content-Disposition headers.
3160 2003-11-07 20:07 guy
3164 From Olivier Biot: add dissection for the Content-Base headeer.
3166 2003-11-07 08:50 guy
3168 * packet-fcels.c, packet-fcels.h:
3172 - Added support for displaying support for
3173 Multicast/Broadcast supported
3174 bits in *LOGI common service params
3175 - Removed restriction for "Random Relative Offset" & its
3177 PLOGI or PDISC only. Some HBAs set it even in FLOGI.
3179 2003-11-07 08:47 guy
3185 - Added support for decoding related to Security in *LOGI
3187 - Added support for new LS_RJT code for authentication
3189 - Brought packet-fcsp.c up-to-date with FC-SP rev 1.2
3191 2003-11-07 05:26 sahlberg
3193 * Makefile.am, Makefile.nmake, packet-kpasswd.c:
3195 New protocol: MS Kpasswd (RFC3244)
3197 KPasswd is partially dissected for UDP.
3199 It would be very useful if someone added dissection of the asn.1
3200 encoded AP_REQ and the KRB-PRIV blobs. I dont think I will add
3203 2003-11-07 04:03 sahlberg
3207 In some captures we might have already established and BOUND LDAP
3208 session where GSS-SPNEGO is used. If we havent seen the BIND
3209 call ethereal would assume it is vanilla non-GSS-SPNEGO LDAP and
3210 would fail to decode the packet.
3212 Add heuristics to the LDAP dissector so that IF the first 4 bytes
3213 of the LDAP PDU looks like ity could be a length field and IF the
3214 fifth byte has the value 0x60 then assume what we have is
3215 GSS-SPNEGO and assume this and all further commands on this
3216 session is GSS-SPNEGO as well.
3218 2003-11-07 03:47 guy
3222 Make a field for the Content-Type entity header, and give it an
3223 EH_ value so it can be handled specially (with a string dissector
3224 table so that subdissectors can register for particular content
3227 2003-11-07 01:29 guy
3229 * gtk/: menu.c, toolbar.c, toolbar.h:
3231 "File->Open" should be available whether or not we have a captue
3234 The toolbar equivalent should *not* be available if we have an
3235 "Update list of packets in real time" capture running.
3237 The toolbar "Save" button should not be available if we don't
3238 have an unsaved capture file.
3240 2003-11-06 23:02 guy
3244 Make Shift+Control+S an accelerator for "Save As...", as per the
3247 2003-11-06 22:45 guy
3249 * wiretap/: file_access.c, netmon.c, network_instruments.c,
3250 network_instruments.h, wtap-int.h:
3252 From Scott Emberley: support for writing Network Instruments
3255 2003-11-06 09:52 guy
3257 * doc/README.plugins:
3259 Note that not all OSes on which Ethereal runs can support
3262 Note that you have to modify plugins/Makefile.nmake.
3264 Fix "plugin/" to "plugins/".
3266 Update the sample Makefile.am and Makefile.nmake to match the
3267 current state of affairs.
3269 2003-11-06 09:47 guy
3271 * doc/README.developer:
3273 Warn people not to use the "numbered argument" feature that many
3274 UNIX printf's implement.
3276 2003-11-06 09:32 guy
3278 * plugins/acn/packet-acn.c:
3280 From Erwin Rol: fix some switched fields.
3282 2003-11-06 09:28 guy
3286 From Michael Lum: have the SCCP dissector register itself by
3289 2003-11-06 09:18 sahlberg
3291 * packet-ldap.c, packet-tcp.c:
3293 Update to LDAP and TCP
3295 LDAP messages that span multiple segments will throw an exception
3296 unless we have reassembly enabled.
3298 Update TCP so that IF an exception was thrown that we still pick
3299 up any hints provided by the subdissector about where the next
3302 Update LDAP so that it will rpovide hints to TCP about where the
3303 next LDAP PDU starts in the sequence number space.
3305 Thus now ethereal can find and dissect LDAP PDUs that starts
3306 somewhere in the middle of a TCP segment.
3308 2003-11-06 09:13 guy
3314 Catch another case where we need to check for a null
3317 2003-11-06 09:05 guy
3319 * plugins/: acn/Makefile.nmake, artnet/Makefile.nmake,
3320 asn1/Makefile.nmake, docsis/Makefile.nmake,
3321 gryphon/Makefile.nmake, lwres/Makefile.nmake,
3322 megaco/Makefile.nmake, mgcp/Makefile.nmake, pcli/Makefile.nmake,
3323 rtnet/Makefile.nmake:
3325 Use "$(OBJECTS)" whenever a complete list of .obj files appears,
3326 rather than repeating the list from the setting of OBJECTS.
3328 2003-11-06 08:54 guy
3332 Add a mechanism to handle various entity headers, allowing their
3333 (string) values to be put into the protocol tree as fields and
3334 allowing some headers to get special treatment, and use it for
3335 Authorization, Proxy-Authorization, WWW-Authenticate, and
3338 2003-11-06 08:51 sahlberg
3344 If we have short or malformed PDUs in protocols above TCP this
3345 will generate an exception and thus some of the stateful things
3346 such as keeping track of and printing the tcp analysis data will
3347 be shourcutted and not called.
3349 Add a wrapper around the call to the subdissectors above TCP so
3350 that if an exception is generated we will still catch it and
3351 explicitely call tcp_print_sequence_number_analysis() so that
3352 also short packets are handled well.
3354 2003-11-06 07:44 sahlberg
3358 Bugfix for dcerpc parsing of encrypted short packets.
3360 Sometimes if we cant decrypt a DCERPC packet decrypted_tvb is
3363 do not pass a NULL pointer to show_stub_data() since this will
3366 2003-11-05 20:19 guy
3370 Get rid of includes of <gmodule.h> (we're not loading any code at
3371 run-time in the dissector itself), and <sys/types.h> and
3372 <netinet/in.h> (we shouldn't need either of those, and they might
3373 be responsible for dragging in <sys/procset.h> on Digital UNIX -
3374 that header defines P_SID in a way that conflicts with our
3377 2003-11-05 20:10 guy
3379 * plugins/acn/packet-acn.c:
3381 Update from Erwin Rol.
3383 2003-11-05 20:10 guy
3387 A "GHashFunc()" returns a "guint", not a "gint".
3389 2003-11-05 09:04 sahlberg
3393 the LDAP service response time dialog
3395 2003-11-05 09:04 sahlberg
3397 * packet-ldap.c, packet-ldap.h, doc/ethereal.pod, gtk/Makefile.am,
3398 gtk/Makefile.nmake, gtk/service_response_time_table.c:
3400 update for LDAP measure the response time for some LDAP commands
3401 and add a service response time dialog for it
3403 2003-11-05 04:23 guy
3407 From Olivier Biot: have a separate subtree ett_ value for
3410 2003-11-04 22:14 guy
3414 Sigh. Some snoop files have 6 bytes of padding; assume the file
3415 is a snoop file unless it has enoguh padding to hold a Shomiti
3416 trailer record. (DEAR SUN MICROSYSTEMS: PLEASE DO NOT STUFF 16
3417 OR MORE BYTES OF PADDING INTO A SNOOP PACKET. THANK YOU. HAVE A
3420 Add a little paranoia about the record and captured data lengths.
3422 2003-11-04 21:44 guy
3426 Get rid of all the UDP-encapsulated IPSec stuff.
3428 draft-ietf-ipsec-udp-encaps-06 says "The UDP port numbers are the
3429 same as used by IKE traffic, as defined in [Kiv05]", and
3430 "[Kiv05]" is draft-ietf-ipsec-nat-t-ike-05, which has been
3431 superseded by draft-ietf-ipsec-nat-t-ike-07; the latter appears
3432 to imply that it goes over port 4500, not port 500.
3434 We already have a draft-ietf-ipsec-udp-encaps-06 dissector for
3435 port 4500 (packet-ipsec-udp.c), and it's not entirely clear to me
3436 how, if draft-ietf-ipsec-udp-encaps-06 traffic *did* go over port
3437 500, you'd distinguish it from regular ISAKMP traffic.
3439 2003-11-04 20:33 guy
3443 Skip the check for the module if a page doesn't have a module.
3445 2003-11-04 20:22 guy
3449 Clean up the way we find the properties page for a given protocol
3450 somewhat; this fixes a bug wherein we were assuming all modules
3451 necessarily had preference pages (they won't, if the only
3452 preferences for the module are obsolete preferences).
3454 2003-11-04 19:47 guy
3460 * Extra headers: Encoding-Version, WWW-Authenticate,
3463 * Fix memory allocate/free in header parsing functions &
3466 * Add missing "ok = TRUE" for some header parsing
3469 * Header subfields all share the same subtree identifier
3473 * Get rid of unused header fields and subtrees
3475 * Some whitespace changes
3477 2003-11-04 18:37 guy
3479 * plugins/asn1/packet-asn1.c, plugins/gryphon/packet-gryphon.c,
3480 AUTHORS, doc/ethereal.pod:
3482 From Masaki Chikama: fix static compilation of "generic ASN.1"
3483 and Gryphon plugins.
3485 2003-11-04 16:44 gerald
3487 * plugins/asn1/packet-asn1.c:
3489 #ifdef out "#include <gtk/gtk.h>", so that --disable-ethereal
3492 2003-11-04 08:16 guy
3496 If we've already constructed a subset tvbuff, don't construct an
3497 identical one and throw away the first one.