2 Author: Michael Mann <mmann78@netscape.net>
3 Date: Mon Dec 8 21:40:24 2014 -0500
5 Refactor "color" conversation filters
7 Have dissectors register their desire to be part of "color" conversation filters and have the GUI use that registered list. GUI actually using API will come in a separate commit.
9 Change-Id: I5ffe922d97894fe7bf3182056b76ab5839a9461a
10 Reviewed-on: https://code.wireshark.org/review/5658
11 Reviewed-by: Michael Mann <mmann78@netscape.net>
12 Petri-Dish: Michael Mann <mmann78@netscape.net>
13 Reviewed-by: Anders Broman <a.broman58@gmail.com>
16 Author: Michael Mann <mmann78@netscape.net>
17 Date: Sat Dec 6 15:39:26 2014 -0500
19 Eliminate some proto_tree_add_text in packet-bgp.c
21 Change-Id: I05fabe9786125e2167fe4010733f61000d0e7914
22 Reviewed-on: https://code.wireshark.org/review/5670
23 Reviewed-by: Michael Mann <mmann78@netscape.net>
24 Reviewed-by: Matthieu Texier <matthieu@texier.tv>
25 Reviewed-by: Anders Broman <a.broman58@gmail.com>
28 Author: Guy Harris <guy@alum.mit.edu>
29 Date: Wed Dec 10 00:39:13 2014 -0800
31 Expose find_heur_dissector_list().
33 We already have find_dissector_table(); expose
34 find_heur_dissector_list() as well, so that heuristic dissector lists
37 Change-Id: I3f50413b8b10fd3129fcdc2344cb1447f0946ce9
38 Reviewed-on: https://code.wireshark.org/review/5701
39 Reviewed-by: Guy Harris <guy@alum.mit.edu>
42 Author: Sergey Avseyev <sergey.avseyev@gmail.com>
43 Date: Wed Dec 10 04:19:55 2014 +0300
45 packet-couchbase.c: dissect more DCP commands
47 Change-Id: I0e06c89cdda3c1f8e98412fd20737ff6afd26666
48 Reviewed-on: https://code.wireshark.org/review/5694
49 Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
50 Reviewed-by: Michael Mann <mmann78@netscape.net>
51 Petri-Dish: Michael Mann <mmann78@netscape.net>
52 Reviewed-by: Anders Broman <a.broman58@gmail.com>
55 Author: Sergey Avseyev <sergey.avseyev@gmail.com>
56 Date: Thu Dec 4 13:22:22 2014 +0300
58 Riemann protocol dissector
60 Homepage: http://riemann.io/
63 http://files.avsej.net/riemann-sample.pcapng
66 https://github.com/aphyr/riemann-java-client/blob/master/src/main/proto/riemann/proto.proto
69 http://riemann.io/howto.html#write-a-client
72 Change-Id: I28634453423127fe647eb92e48072a90a7f5d232
73 Reviewed-on: https://code.wireshark.org/review/5620
74 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
75 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
76 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
77 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
78 Reviewed-by: Anders Broman <a.broman58@gmail.com>
81 Author: Pascal Quantin <pascal.quantin@gmail.com>
82 Date: Wed Dec 10 07:41:23 2014 +0100
84 ICQ: fix icq.meta_user.found_authorization field registration
86 Change-Id: I8c39073b8d1237f8af7f7061f331b3d59ae81142
87 Reviewed-on: https://code.wireshark.org/review/5699
88 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
91 Author: Pascal Quantin <pascal.quantin@gmail.com>
92 Date: Wed Dec 10 07:37:23 2014 +0100
94 NFS: do not duplicate field name in blurb
96 Change-Id: I565823e2ba3c712506710f911e118cd48c895523
97 Reviewed-on: https://code.wireshark.org/review/5698
98 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
101 Author: Michael Mann <mmann78@netscape.net>
102 Date: Sat Dec 6 12:57:33 2014 -0500
104 Eliminate proto_tree_add_text from packet-icq.c
106 Change-Id: I2f4bcd8c4a6cf534bb5b6b5c5aa7e21075968ee3
107 Reviewed-on: https://code.wireshark.org/review/5696
108 Reviewed-by: Michael Mann <mmann78@netscape.net>
109 Petri-Dish: Michael Mann <mmann78@netscape.net>
110 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
111 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
114 Author: Bill Meier <wmeier@newsguy.com>
115 Date: Tue Dec 9 23:48:46 2014 -0500
117 nfs: expert...() shouldn't be called under 'if(tree)'
119 Change-Id: I4f8c55ea4194d1246ea19368e0f5890ad1248f47
120 Reviewed-on: https://code.wireshark.org/review/5697
121 Reviewed-by: Bill Meier <wmeier@newsguy.com>
124 Author: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
125 Date: Sun Nov 9 10:58:43 2014 +0100
127 nfs: decode dCache NFS file handle
129 add support for dCache NFS/pNFS
130 project page: http://www.dcache.org
133 Change-Id: I24a88419ec070305e609d1b49b44994a464eb098
134 Signed-off-by: Tigran Mkrtchyan <tigran.mkrtchyan@desy.de>
135 Reviewed-on: https://code.wireshark.org/review/5236
136 Reviewed-by: Michael Mann <mmann78@netscape.net>
137 Petri-Dish: Michael Mann <mmann78@netscape.net>
138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
141 Author: J. Bruce Fields <bfields@redhat.com>
142 Date: Thu Oct 30 14:53:07 2014 -0400
144 nfs: fix failure to parse EXCHANGE_ID arguments
146 The exchange_id spo_must_enforce/spo_must_allow bitmaps are exceeding
147 this arbitrary MAX_BITMAPS constant, causing EXCHANGE_ID parsing to
150 Even in the case of attributes we may need more than 4 words soon, even
151 if we don't I'm not sure if it's actually illegal to zero-pad them out
152 to something longer, and even if that is illegal I don't think it's
153 really helpful of wireshark to stop parsing.
155 Keep the constant just as a sanity check but make it really large.
158 Change-Id: I3dff3ebde2d7f74f8cbe60a92c853463da66ae6a
159 Reviewed-on: https://code.wireshark.org/review/5144
160 Reviewed-by: Evan Huus <eapache@gmail.com>
161 Reviewed-by: Michael Mann <mmann78@netscape.net>
164 Author: Gerald Combs <gerald@wireshark.org>
165 Date: Tue Dec 9 16:54:17 2014 -0800
167 Qt: Obey main toolbar icon preferences.
169 Remove the preferences for the filter toolbar and mark them GTK+-only.
171 Change-Id: Ie48b19aee29a1cfcea4c41ca6c08ddbba3102377
172 Reviewed-on: https://code.wireshark.org/review/5693
173 Petri-Dish: Gerald Combs <gerald@wireshark.org>
174 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
175 Reviewed-by: Gerald Combs <gerald@wireshark.org>
178 Author: Guy Harris <guy@alum.mit.edu>
179 Date: Tue Dec 9 15:14:22 2014 -0800
181 Add media playback icons.
183 Change-Id: I5a9ba1314b0c93098e7b802618f73c7fca608b04
184 Reviewed-on: https://code.wireshark.org/review/5692
185 Reviewed-by: Guy Harris <guy@alum.mit.edu>
188 Author: Pascal Quantin <pascal.quantin@gmail.com>
189 Date: Tue Dec 9 23:46:05 2014 +0100
191 LTE RRC: upgrade dissector to v12.3.0
193 Change-Id: Iac974bf505bed270fc1f9409a7d61c80ebca17a5
194 Reviewed-on: https://code.wireshark.org/review/5691
195 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
198 Author: Gerald Combs <gerald@wireshark.org>
199 Date: Tue Nov 18 16:21:42 2014 -0800
201 Qt: Initial VoIP Calls dialog.
203 Add Telephony menu items for VoIP Calls and SIP Flows. Put VoIP Calls at
204 the top, since that seems to be the primary item.
206 Add configure-time checks for QtMultimediaWidgets in anticipation of
207 adding a VoIP playback dialog.
209 Add an icon for the playback button. (Yes, I've been avoiding
210 GNOME-level gratuitous icons so far but this is one of the rare
211 occiasions where it makes sense.)
213 Add a help link define for the VoIP calls dialog.
215 Change-Id: I5d0799685c598ad9af76fe9667f8ea7d14b66050
216 Reviewed-on: https://code.wireshark.org/review/5674
217 Petri-Dish: Gerald Combs <gerald@wireshark.org>
218 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
219 Reviewed-by: Gerald Combs <gerald@wireshark.org>
222 Author: Gerald Combs <gerald@wireshark.org>
223 Date: Tue Dec 9 13:22:20 2014 -0800
225 Fix ranlib "has no symbols" errors in the codecs directory.
227 Don't build the G.722 or G.726 codecs for now. Each are wrapped in
228 "#ifdef HAVE_SPANDSP", which we don't define.
230 Conditionally compile the SBC codec.
232 Change-Id: I5f09ff66514f967d4f0611c943b4e6a975b8994b
233 Reviewed-on: https://code.wireshark.org/review/5690
234 Reviewed-by: Gerald Combs <gerald@wireshark.org>
237 Author: Gerald Combs <gerald@wireshark.org>
238 Date: Tue Dec 9 11:24:59 2014 -0800
240 Fix filename matching.
242 Change-Id: I2bdfd3ad2798ed1443d06c42b05c9962b8e8041d
243 Reviewed-on: https://code.wireshark.org/review/5689
244 Reviewed-by: Gerald Combs <gerald@wireshark.org>
247 Author: Gerald Combs <gerald@wireshark.org>
248 Date: Wed Nov 12 14:24:16 2014 -0800
250 Qt: Update and rename the summary dialog.
252 Go back to a single view similar to the GTK+ UI. Apply layouts using Qt
255 Rename the menu item and class to "Capture File Properties". It's not
256 really a summary if it contains details such as "marked average bits
257 per second". We might want to move this to a "Properties" item under
258 the "File" menu similar to other applications.
260 Add the GTK+ summary icon (for now) to the toolbar and open the
261 properties dialog on clicking.
263 Singleton dialogs delenda est[1]. Let the user open as many summaries on
264 as many capture files as he or she wishes. Also, global cfile delenda
267 Don't blindly include QtGui. Add specific components instead.
269 Use consistent method names, variable names, and patterns. Try to
270 document what "consistent" means.
272 Adjust the way we display some statistics to match the summary bar, e.g.
273 displayed = captured if we don't have a filter applied.
278 Change-Id: I11793b1d79dd0c3f70414ac8592b86181da59916
279 Reviewed-on: https://code.wireshark.org/review/5274
280 Reviewed-by: Gerald Combs <gerald@wireshark.org>
283 Author: Michael Mann <mmann78@netscape.net>
284 Date: Fri Dec 5 19:41:12 2014 -0500
286 Eliminate proto_tree_add_text from packet-ppp.c.
288 Some of the conversions to proto_tree_add_xxx calls involved using explicit sizes instead of the "option length", so there is skipping of the "byte highlighting" of the type + length bytes.
290 Change-Id: Ibfe09a089fb33ba43121de079aca81742d48db4c
291 Reviewed-on: https://code.wireshark.org/review/5636
292 Reviewed-by: Michael Mann <mmann78@netscape.net>
293 Petri-Dish: Michael Mann <mmann78@netscape.net>
294 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
295 Reviewed-by: Christopher Maynard <Christopher.Maynard@gtech.com>
298 Author: Pascal Quantin <pascal.quantin@gmail.com>
299 Date: Sun Dec 7 20:54:05 2014 +0100
301 LTE: Update MAC and RLC dissectors to Release 12
303 Change-Id: I036a0d1180b6481e8cc27210ed44eda4ba078a27
304 Reviewed-on: https://code.wireshark.org/review/5659
305 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
306 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
307 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
310 Author: Guy Harris <guy@alum.mit.edu>
311 Date: Tue Dec 9 00:54:34 2014 -0800
315 Change-Id: I181129595c7259f5c0af5308f0ca0190dce67eb7
316 Reviewed-on: https://code.wireshark.org/review/5687
317 Reviewed-by: Guy Harris <guy@alum.mit.edu>
320 Author: Irene Ruengeler <ruengeler@wireshark.org>
321 Date: Fri Dec 5 10:04:29 2014 +0100
323 Fix GTK warning in EXTCAP parts
325 Change-Id: I3a4d9baf3592db1394d1177a19014cbef9140759
326 Reviewed-on: https://code.wireshark.org/review/5628
327 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
328 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
329 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
330 Reviewed-by: Irene Ruengeler <iruengeler@googlemail.com>
333 Author: Michael Mann <mmann78@netscape.net>
334 Date: Thu Nov 27 23:18:32 2014 -0500
336 Eliminate proto_tree_add_text from some dissectors.
338 Change-Id: I44cc6b70ec4dfc565934da499f46fca60a4ded93
339 Reviewed-on: https://code.wireshark.org/review/5524
340 Reviewed-by: Michael Mann <mmann78@netscape.net>
341 Petri-Dish: Michael Mann <mmann78@netscape.net>
342 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
343 Reviewed-by: Anders Broman <a.broman58@gmail.com>
346 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
347 Date: Fri Dec 5 07:42:34 2014 +0100
349 SCTP: Missing break in switch (CID 1135556)
351 Change-Id: I00939bb9699493fe7af21497d9e9c013cc3d2e62
352 Reviewed-on: https://code.wireshark.org/review/5650
353 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
354 Reviewed-by: Anders Broman <a.broman58@gmail.com>
357 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
358 Date: Wed Dec 3 16:46:46 2014 +0100
360 GVSP: Missing break in switch (CID 1247683 & 1247684)
362 Change-Id: Ibd3aef4101126f02453bab10cd5ca31e716334de
363 Reviewed-on: https://code.wireshark.org/review/5617
364 Reviewed-by: W Moxam <warrenm@ptgrey.com>
365 Reviewed-by: Anders Broman <a.broman58@gmail.com>
368 Author: Guy Harris <guy@alum.mit.edu>
369 Date: Mon Dec 8 20:04:23 2014 -0800
371 Nothing to free there.
373 pcapng_read_block() never sets *err_info if it returns
374 PCAPNG_BLOCK_NOT_SHB - that happens on an EOF, a short read, or on a
375 successful read of something that doesn't look like an SHB.
377 Change-Id: I23ad6aa1c95d800b068a798a4aad1d70d07ac281
378 Reviewed-on: https://code.wireshark.org/review/5686
379 Reviewed-by: Guy Harris <guy@alum.mit.edu>
382 Author: Guy Harris <guy@alum.mit.edu>
383 Date: Mon Dec 8 19:57:21 2014 -0800
385 Manually fix a pidl bug - that field should be an FT_STRING.
387 No, I don't know why it's making it FT_NONE; it's a bit of a weird data
388 type, with a string inside a structure.
390 Change-Id: I27a6d7577ef4a9f4da8ddad2cad97ad097135e90
391 Reviewed-on: https://code.wireshark.org/review/5685
392 Reviewed-by: Guy Harris <guy@alum.mit.edu>
395 Author: Guy Harris <guy@alum.mit.edu>
396 Date: Mon Dec 8 19:24:33 2014 -0800
398 LDAP's DirSyncFlags are a bitfield, so show it as an unsigned integer in hex.
400 Change-Id: I2a06b13528ad7dfc587bfb9c1333d4f7a497614e
401 Reviewed-on: https://code.wireshark.org/review/5684
402 Reviewed-by: Guy Harris <guy@alum.mit.edu>
405 Author: Guy Harris <guy@alum.mit.edu>
406 Date: Mon Dec 8 17:30:04 2014 -0800
408 Don't try to look in a non-existent hash table.
410 We only create hash tables if somebody puts a handler in one, so we need
411 to check whether the hash table exists first, to avoid run-time warnings.
413 Change-Id: I739d2d808935e651b11bd44b258f168a42ca4b7c
414 Reviewed-on: https://code.wireshark.org/review/5683
415 Reviewed-by: Guy Harris <guy@alum.mit.edu>
418 Author: Guy Harris <guy@alum.mit.edu>
419 Date: Mon Dec 8 16:13:39 2014 -0800
421 Don't put bitmasks under an FT_NONE.
423 Change-Id: I172c68d233e3887a94c0835234613dfd483ee5af
424 Reviewed-on: https://code.wireshark.org/review/5682
425 Reviewed-by: Guy Harris <guy@alum.mit.edu>
428 Author: Guy Harris <guy@alum.mit.edu>
429 Date: Mon Dec 8 16:06:11 2014 -0800
431 Values in a value_string_ext *must* be sorted.
433 Change-Id: I0c2bcd81955375abf3af24e42c70bea0bb960083
434 Reviewed-on: https://code.wireshark.org/review/5681
435 Reviewed-by: Guy Harris <guy@alum.mit.edu>
438 Author: Guy Harris <guy@alum.mit.edu>
439 Date: Mon Dec 8 15:36:26 2014 -0800
441 Don't put bitmasks under an FT_NONE.
443 proto_tree_add_bitmask() requires that the field under which it's
444 putting the bitmasks be an FT_INTn or FT_UINTn, so that it can determine
445 the length of the field.
447 Arguably, proto_tree_add_bitmask() should, instead, take a length
448 argument, just as other proto_tree_add_ routines do, and, arguably, we
449 should perhaps not even have FT_UINTn and FT_INTn, just FT_UINT and
450 FT_INT, with the display width for hex and octal (leading zeroes)
451 determined by the actual length of the field or something such as that,
452 or as part of the field that also contains the base.
454 But, even with that, we might want to require an FT_UINTn or FT_INTn
455 anyway, at least in cases where the value of the field as a whole is
458 Change-Id: I4dff8fb1686a30b7d145c089dd1be7f96ecf23e0
459 Reviewed-on: https://code.wireshark.org/review/5680
460 Reviewed-by: Guy Harris <guy@alum.mit.edu>
463 Author: Guy Harris <guy@alum.mit.edu>
464 Date: Mon Dec 8 15:25:50 2014 -0800
466 Have different MTP2 dissectors for different metadata and CRC.
468 Have separate MTP2 dissectors for:
470 MTP2 frames with no pseudo-header and no CRC;
472 MTP2 frames with a pseudo-header and no CRC;
474 MTP2 frames with no pseudo-header and a CRC;
476 and call the appropriate dissector in the appropriate places.
478 While we're at it, get rid of a global variable - pass the "use extended
479 sequence numbers" flag down through the dissection code path, rather
480 than having it as a global.
482 Change-Id: Id8da1fbe3529e3ffadd5c30646cbc922f506a01f
483 Reviewed-on: https://code.wireshark.org/review/5679
484 Reviewed-by: Guy Harris <guy@alum.mit.edu>
487 Author: Balint Reczey <balint@balintreczey.hu>
488 Date: Sat Nov 15 09:44:22 2014 +0100
490 Add missing build-dependencies for the Debian package
492 They are libparse-yapp-perl and libsbc-dev.
494 Change-Id: I474179bb805acb87f8bf316730d63eb294e10a69
495 Reviewed-on: https://code.wireshark.org/review/5322
496 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
497 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
500 Author: Gerald Combs <gerald@wireshark.org>
501 Date: Mon Dec 8 14:09:33 2014 -0800
503 It's a reasonable expectation that we will have C++ style comments in
506 Change-Id: Iedbf2a2d3cbfee00912e6e883928836932dea566
507 Reviewed-on: https://code.wireshark.org/review/5678
508 Reviewed-by: Gerald Combs <gerald@wireshark.org>
511 Author: Gerald Combs <gerald@wireshark.org>
512 Date: Mon Dec 8 13:41:02 2014 -0800
514 Remove an unnecessary include.
516 Change-Id: I55332c21ea66ee7d564c2b338cba524ea774b19c
517 Reviewed-on: https://code.wireshark.org/review/5677
518 Reviewed-by: Gerald Combs <gerald@wireshark.org>
521 Author: Guy Harris <guy@alum.mit.edu>
522 Date: Mon Dec 8 11:40:35 2014 -0800
524 Use correct expression in a "length too short" message.
526 Doesn't change the behavior of the code, but makes it more consistent.
528 Change-Id: I6f07fbbb4c7d14d8a46ecfd1c419d951c356fd77
529 Reviewed-on: https://code.wireshark.org/review/5672
530 Reviewed-by: Guy Harris <guy@alum.mit.edu>
533 Author: Hannes Mezger <hannes.mezger@ascolab.com>
534 Date: Mon Dec 8 11:20:16 2014 +0100
536 Fix full name of NodeId namespace index field, was a copy&pase error
538 Change-Id: I7b1eea9965880e35c65f04406ff756d245b568d4
539 Reviewed-on: https://code.wireshark.org/review/5668
540 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
543 Author: AndersBroman <anders.broman@ericsson.com>
544 Date: Wed Dec 3 12:36:18 2014 +0100
546 Try to improve reassembly when SIP PDU starts in the middle of a segment
547 and continues trough the next segment(s).
549 Change-Id: I8efe69361fda0c60ec6544cc6bbe28c91f07207c
550 Reviewed-on: https://code.wireshark.org/review/5583
551 Reviewed-by: Anders Broman <a.broman58@gmail.com>
554 Author: Maarten Bezemer <maarten.bezemer@gmail.com>
555 Date: Thu Nov 27 15:09:52 2014 +0100
557 Fix showing error dialog when calling vsimple_error_message_box()
559 SimpleDialog requires a parent, when none is provided (as there is no parent available during startup), the error message is queued and displayed after MainWindow is available.
560 Calling SimpleDialog::exec() directly returns if no parent is set (hence the dialog is not shown)
562 This resulted in silently ignoring error messages that were shown using vsimple_error_message_box(), as this function did not provide a parent (and the queue messages were not dequeued anymore as the MainWindow was already available)
564 Change-Id: I2f4c1b4926c196ab40b035161cec530105396537
565 Reviewed-on: https://code.wireshark.org/review/5519
566 Reviewed-by: Michael Mann <mmann78@netscape.net>
569 Author: Michael Mann <mmann78@netscape.net>
570 Date: Sat Nov 29 15:58:56 2014 -0500
572 Add proto_tree_add_bitmask_with_flags.
574 It's proto_tree_add_bitmask with the ability to control the data appended to header.
576 Change-Id: Icce97437ba7cfc9158ec204a837da8db8138424a
577 Reviewed-on: https://code.wireshark.org/review/5533
578 Reviewed-by: Michael Mann <mmann78@netscape.net>
581 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
582 Date: Fri Dec 5 09:02:37 2014 +0100
584 802.11: fix indent (use 2 spaces) and modelines for 802.11 h file
586 Change-Id: If886809d9eeb900bb94c045413ff1295519b8311
587 Reviewed-on: https://code.wireshark.org/review/5641
588 Reviewed-by: Michael Mann <mmann78@netscape.net>
591 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
592 Date: Tue Nov 25 12:23:52 2014 +0100
594 CAPWAP: Add some IEE802.11 Message Element Type (RFC5416)
596 * IEEE 802.11 Antenna (1025)
597 * IEEE 802.11 Direct Sequence Control (1028)
598 * IEEE 802.11 MAC Operation (1030)
599 * IEEE 802.11 MIC Countermeasures (1031)
600 * IEEE 802.11 Multi-Domain Capability (1032)
601 * IEEE 802.11 Station (1036)
602 * IEEE 802.11 Supported Rates (1040)
603 * IEEE 802.11 Tx Power (1041)
604 * IEEE 802.11 Tx Power Level (1042)
605 * IEEE 802.11 WTP Radio Configuration (1046)
607 Enhance 802.11 Rate Set (1034)
609 Change-Id: Ib37bc4081e75af051d80d023ddba689ecd9bf9ff
610 Reviewed-on: https://code.wireshark.org/review/5481
611 Reviewed-by: Michael Mann <mmann78@netscape.net>
614 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
615 Date: Fri Dec 5 09:00:13 2014 +0100
617 802.11: Add ieee80211_supported_rates_vals_ext to be exported
619 It will be reused by CAPWAP dissector (* Rates Message Element)
621 Change-Id: I60ce12f382a35cdc2747baf23e2e3c30a305a8bd
622 Reviewed-on: https://code.wireshark.org/review/5640
623 Petri-Dish: Michael Mann <mmann78@netscape.net>
624 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
625 Reviewed-by: Michael Mann <mmann78@netscape.net>
628 Author: Guy Harris <guy@alum.mit.edu>
629 Date: Sun Dec 7 12:17:48 2014 -0800
631 Add checks for non-null-terminated strings.
633 Change-Id: Iaad2d2f76e5d554800ba2c79d5c01f4b9da6fa0b
634 Reviewed-on: https://code.wireshark.org/review/5660
635 Reviewed-by: Guy Harris <guy@alum.mit.edu>
638 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
639 Date: Fri Dec 5 07:56:36 2014 +0100
641 Endpoint: wrong filter when select a SCTP endpoint (INVALID == a.x.y.z ...)
643 Change-Id: I396e9af7971ee8be6fc9548162ff37fe704f0289
644 Reviewed-on: https://code.wireshark.org/review/5651
645 Reviewed-by: Michael Mann <mmann78@netscape.net>
648 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
649 Date: Sun Dec 7 19:51:16 2014 +0100
651 dcerpc: Missing break in switch (CID 280449 & 280450 & 284051)
653 Change-Id: I68fa9650c234c0f1fb8464b464a781b54f2c728c
654 Reviewed-on: https://code.wireshark.org/review/5657
655 Reviewed-by: Michael Mann <mmann78@netscape.net>
658 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
659 Date: Sun Dec 7 19:48:17 2014 +0100
661 iec104: Missing break in switch (CID 280459)
663 Change-Id: I6abc157368a78e1abfde672728b88a36ba6e76cc
664 Reviewed-on: https://code.wireshark.org/review/5656
665 Reviewed-by: Michael Mann <mmann78@netscape.net>
668 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
669 Date: Sun Dec 7 19:46:53 2014 +0100
671 AFS: Missing break in switch (CID 280434 & 280435)
673 Change-Id: Ia0a39f7e4670d74325ddc40b34cd56ca018c0bde
674 Reviewed-on: https://code.wireshark.org/review/5655
675 Reviewed-by: Michael Mann <mmann78@netscape.net>
678 Author: Martin Kaiser <wireshark@kaiser.cx>
679 Date: Sun Dec 7 19:36:32 2014 +0100
681 make our counting a bit clearer
683 Change-Id: Ie64573f5a0b6e921a5011e487eea8e55f72b9a0b
684 Reviewed-on: https://code.wireshark.org/review/5653
685 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
686 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
689 Author: Martin Kaiser <wireshark@kaiser.cx>
690 Date: Sun Dec 7 19:27:57 2014 +0100
692 don't initialize variables if the first thing we do is assign a
693 different value to them
695 Change-Id: I719db9180b2ba5f21653086f2697ca9bac68d6b1
696 Reviewed-on: https://code.wireshark.org/review/5652
697 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
698 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
701 Author: Martin Kaiser <wireshark@kaiser.cx>
702 Date: Sat Dec 6 18:28:37 2014 +0100
704 make sure that we don't read past the end of the compressed buffer
707 Change-Id: I30054c4a75ec86ea603cf78b702be5255c35f549
708 Reviewed-on: https://code.wireshark.org/review/5642
709 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
710 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
713 Author: Michael Mann <mmann78@netscape.net>
714 Date: Fri Dec 5 19:42:47 2014 -0500
716 Eliminate proto_tree_add_text from packet-telnet.c
718 Change-Id: I0e8610f381e650f2c5b3f78ea927b727ec9ac62a
719 Reviewed-on: https://code.wireshark.org/review/5637
720 Petri-Dish: Michael Mann <mmann78@netscape.net>
721 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
722 Reviewed-by: Michael Mann <mmann78@netscape.net>
725 Author: Gerald Combs <gerald@wireshark.org>
726 Date: Sun Dec 7 08:05:11 2014 -0800
728 [Automatic manuf, services and enterprise-numbers update for 2014-12-07]
730 Change-Id: Ice8195b09120fb21144e504289a64fd5af84775b
731 Reviewed-on: https://code.wireshark.org/review/5647
732 Reviewed-by: Gerald Combs <gerald@wireshark.org>
735 Author: Guy Harris <guy@alum.mit.edu>
736 Date: Sat Dec 6 15:59:07 2014 -0800
738 The packet encapsulation is in pkt_encap, not rec_type.
740 rec_type is the type of record (which isn't necessarily a packet; future
741 work on libwiretap will let it return non-packet data); if it's a packet
742 (REC_TYPE_PACKET), then pkt_encap contains the "link-layer"
743 encapsulation for the packet (in quotes because it may contain metadata
744 not transmitted over the network).
746 Change-Id: I6f32b02f4466df6d7b07dbdc9d77e881830ac749
747 Reviewed-on: https://code.wireshark.org/review/5645
748 Reviewed-by: Guy Harris <guy@alum.mit.edu>
751 Author: Michael Mann <mmann78@netscape.net>
752 Date: Sat Dec 6 16:21:07 2014 -0500
754 Remove annex_a_used from packet_info structure.
756 Change-Id: I660caa8283aecff5060c6ed476f316bc5793373e
757 Reviewed-on: https://code.wireshark.org/review/5643
758 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
761 Author: Guy Harris <guy@alum.mit.edu>
762 Date: Fri Dec 5 20:53:39 2014 -0800
764 Don't go past the end of the "extra data".
766 The "extra data", according to the RF5 API manual I have, is "hardware
767 parameters", so change some names.
769 Report an error if the variable parts of the configuration event record
770 run past the record length.
772 Report an error if the hardware parameters are too short.
774 For the purportedly DS0 hardware parameters, don't assume they'll be
775 long enough for the mask; they might not be.
777 Change-Id: Ib63d042e4ede32216fb474c4ecdba84db1387abc
778 Reviewed-on: https://code.wireshark.org/review/5638
779 Reviewed-by: Guy Harris <guy@alum.mit.edu>
782 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
783 Date: Wed Dec 3 16:39:58 2014 +0100
785 RPKI-RTR: Missing break in switch (CID 1233099)
787 Change-Id: I01f01ce51fb1c9deb857ef01696b406b97dca3a9
788 Reviewed-on: https://code.wireshark.org/review/5616
789 Reviewed-by: Michael Mann <mmann78@netscape.net>
792 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
793 Date: Wed Dec 3 16:48:48 2014 +0100
795 PCEP: Missing break in switch (CID 1247685)
797 Change-Id: Id001a6c1e116fdabfd51c354832ca68f50e65e7d
798 Reviewed-on: https://code.wireshark.org/review/5618
799 Reviewed-by: Michael Mann <mmann78@netscape.net>
802 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
803 Date: Thu Dec 4 10:57:16 2014 +0100
805 BT obex: Missing break in switch (CID 1132031)
807 Change-Id: I6b8fc8db006bc3b8f8f4bac019cb7e240931d3b5
808 Reviewed-on: https://code.wireshark.org/review/5619
809 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
810 Reviewed-by: Michael Mann <mmann78@netscape.net>
813 Author: Guy Harris <guy@alum.mit.edu>
814 Date: Fri Dec 5 15:46:58 2014 -0800
816 Fix some copy-and-pasteos in error messages.
818 Change-Id: I1fe3434e69a08aae3d7413067275b3d7ee1552f5
819 Reviewed-on: https://code.wireshark.org/review/5634
820 Reviewed-by: Guy Harris <guy@alum.mit.edu>
823 Author: Guy Harris <guy@alum.mit.edu>
824 Date: Fri Dec 5 13:14:31 2014 -0800
826 Get rid of a trailing blank.
828 Change-Id: I0cf6d04f5075ba1f064c40f4b39b32b6976b54c7
829 Reviewed-on: https://code.wireshark.org/review/5633
830 Reviewed-by: Guy Harris <guy@alum.mit.edu>
833 Author: Guy Harris <guy@alum.mit.edu>
834 Date: Fri Dec 5 13:04:59 2014 -0800
836 Fix varargs handling in col_{add,append}_lstr().
838 We do multiple va_start() calls using the first string in the list of
839 strings; do *not* use the first-string argument to iterate over all the
840 argument strings, as that means that only the first va_start() call will
841 do the right thing, use a separate variable.
844 Change-Id: Ic4a6c24f911e335d147883a25d30289628836875
845 Reviewed-on: https://code.wireshark.org/review/5630
846 Reviewed-by: Guy Harris <guy@alum.mit.edu>
849 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
850 Date: Tue Dec 2 09:40:46 2014 -0500
852 Strengthen association matching when we haven't seen the INIT/INIT-ACK.
854 The fact that the vtag matches the initiate tag doesn't mean much if both are 0
857 Also leave in some (commented-out) debug to make debugging this stuff easier
860 Change-Id: Id007de8bf9d2d4e0bb18309ed3e2572fedda45f1
861 Reviewed-on: https://code.wireshark.org/review/5571
862 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
865 Author: Stephen Fisher <sfisher@sdf.org>
866 Date: Thu Dec 4 16:59:43 2014 -0700
868 Look for python3 in addition to python in configure script.
870 Change-Id: I77ff22aabdbbbf7376483b53d8795e7fbf0c0433
871 Reviewed-on: https://code.wireshark.org/review/5627
872 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
875 Author: Stephen Fisher <sfisher@sdf.org>
876 Date: Thu Dec 4 13:15:41 2014 -0700
878 Make autogen.sh look for "python3" if "python" isn't found before
881 Change-Id: Id109c78f90da71c54c7b4fd6df20cc153248f46f
882 Reviewed-on: https://code.wireshark.org/review/5623
883 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
886 Author: Martin Kaiser <wireshark@kaiser.cx>
887 Date: Thu Dec 4 22:49:42 2014 +0100
889 use the same data types as in i2c_phdr
891 Change-Id: Ic0abcf8173a690a1dc0cd250f5e8770eb92a5aa9
892 Reviewed-on: https://code.wireshark.org/review/5626
893 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
894 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
897 Author: Martin Kaiser <wireshark@kaiser.cx>
898 Date: Thu Dec 4 22:38:16 2014 +0100
900 simplify dissect_i2c()
902 Change-Id: I67dd6ae5dc48b297e5c04aba2fe53e3e159d2611
903 Reviewed-on: https://code.wireshark.org/review/5625
904 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
905 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
908 Author: Martin Kaiser <wireshark@kaiser.cx>
909 Date: Thu Dec 4 22:25:39 2014 +0100
911 dont't manually throw a ReportedBoundsError if the packet is empty
912 use tvb_captured_length() instead of tvb_length()
914 Change-Id: I7e7efd69515fc3e30c986ac5d9a56b4db1931c10
915 Reviewed-on: https://code.wireshark.org/review/5624
916 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
917 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
920 Author: Pascal Quantin <pascal.quantin@gmail.com>
921 Date: Thu Dec 4 14:38:35 2014 +0100
923 3GPP: upgrade 2G/3G NAS dissector to v12.7.0 and NAS EPS dissector to v12.6.0
925 Change-Id: I1e5bc5d28cb956b333c302b1cb18335b59d096a8
926 Reviewed-on: https://code.wireshark.org/review/5621
927 Reviewed-by: Anders Broman <a.broman58@gmail.com>
928 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
931 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
932 Date: Thu Dec 4 09:54:08 2014 -0500
934 There's no need to talk about update-alternatives here.
936 Our "make install" process does nothing with 'alternatives'. Our RPMs do use
937 alternatives but they do the necessary update-alternatives stuff already.
939 (If someone wants to set up Linux "make install"s to use alternatives it would
940 make sense to put these notes to the user back in.)
942 Change-Id: Ib7f4655a222ccaee83830a97b213656856cee73e
943 Reviewed-on: https://code.wireshark.org/review/5622
944 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
947 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
948 Date: Wed Dec 3 22:12:52 2014 -0500
950 Add a MIME type for Tektronix rf5 files and register Wireshark for that type of
953 The magic matching comes from wiretap/k12.c.
955 (Yes, I just made the application/x-tektronix-rf5 MIME type up.)
957 Change-Id: Iafd7300aa7f2664bb06e1330caede10785c21d68
958 Reviewed-on: https://code.wireshark.org/review/5607
959 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
962 Author: Steve Karg <skarg@users.sourceforge.net>
963 Date: Wed Dec 3 13:30:42 2014 -0600
965 BACnet: fix dissection of exception-schedule property.
967 The exception schedule special-event disection already used matched
968 open-close tags and only needed to check for an unmatched close tag
969 to exit when used with ReadPropertyMultiple service.
972 Change-Id: I54f2f6f3f470138a6a88f84c62fd15b07ea74c37
973 Reviewed-on: https://code.wireshark.org/review/5593
974 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
975 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
976 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
979 Author: Michele Baldessari <michele@acksyn.org>
980 Date: Wed Dec 3 20:14:33 2014 +0100
982 Add resource-id parsing to the X11 errors that return it
984 - Rename BadColor to BadColormap as the former does not exist in the X11
986 - Parse the bad resource id field in case of the following errors:
987 BadColormap, BadWindow, BadPixmap, BadCursor, BadFont, BadDrawable,
988 BadGC and BadIDChoice
990 Change-Id: I5b23d32189e1a8bb291c656cf6383a85b3e89642
991 Reviewed-on: https://code.wireshark.org/review/5592
992 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
995 Author: Guy Harris <guy@alum.mit.edu>
996 Date: Thu Dec 4 00:03:03 2014 -0800
998 Don't do the desktop integration stuff if we're not building Wireshark.
1000 Wireshark is the desktop app; if we're not building it (i.e., we're only
1001 building the command-line TShark), we don't need any desktop files.
1003 Change-Id: Id8244b417fd53c9d55b4d77fe3ad748c98868ad7
1004 Reviewed-on: https://code.wireshark.org/review/5615
1005 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1008 Author: Guy Harris <guy@alum.mit.edu>
1009 Date: Wed Dec 3 23:56:10 2014 -0800
1011 Don't do all the fd.o desktop integration stuff on OS X.
1013 It doesn't need it, so don't install those files, or uninstall them, or
1014 suggest running various unnecessary commands after the installation
1017 Change-Id: Ieecab22884723670f47f2fc7cc1ac827f48c1967
1018 Reviewed-on: https://code.wireshark.org/review/5614
1019 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1022 Author: Bill Meier <wmeier@newsguy.com>
1023 Date: Wed Dec 3 15:22:39 2014 -0500
1025 Rename some filter names to fix cases of duplicate filter names.
1027 Note: Use of most of these filter names could have caused a Wireshark crash.
1029 Change-Id: I393402a25dd26d174baff77f4706f6d5f43a94ae
1030 Reviewed-on: https://code.wireshark.org/review/5610
1031 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1034 Author: Bill Meier <wmeier@newsguy.com>
1035 Date: Wed Dec 3 15:19:36 2014 -0500
1037 mac-lte: Rename expert filter name to fix conflict with same name in hf[]
1039 Change-Id: I906a195b3c6a1e68f273decc9c443a233af4f9be
1040 Reviewed-on: https://code.wireshark.org/review/5609
1041 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1044 Author: Bill Meier <wmeier@newsguy.com>
1045 Date: Wed Dec 3 14:14:53 2014 -0500
1047 mausb: Rename expert filter names to fix dup filter names.
1049 Change-Id: Id650c3aff6d073b05e844574ffbde8fec4368f49
1050 Reviewed-on: https://code.wireshark.org/review/5608
1051 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1054 Author: Guy Harris <guy@alum.mit.edu>
1055 Date: Wed Dec 3 18:37:50 2014 -0800
1057 Put a bunch of suggestions in post-install/post-uninstall hooks.
1059 This covers a bunch of commands that might have to be run after "make
1060 install". ("might" - none are needed on OS X, for example, as it's a
1061 different desktop and its dynamic loader doesn't have a cache that you
1062 have to manually update whenever you install a new shared library.)
1064 Change-Id: I21e1728bdde26a7ab1585fdfb54f63fdc1c25dd6
1065 Reviewed-on: https://code.wireshark.org/review/5606
1066 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1069 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1070 Date: Wed Dec 3 16:59:08 2014 -0500
1072 Fix building of RPMs and get RPM builds working with a prefix other than /usr again.
1074 (Change I567269d8e45e6543d9e39dbedc49830adf7edb9f made the desktop files
1075 install outside of /usr/share/ .)
1077 RPMs now build and work regardless of the prefix but the desktop integration stuff
1078 only works if the prefix is /usr or (if you're lucky) /usr/local .
1080 Change-Id: If20e0127a044eac1ba099f959a90d068c4bb2ae5
1081 Reviewed-on: https://code.wireshark.org/review/5600
1082 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
1085 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1086 Date: Wed Dec 3 20:02:04 2014 -0500
1088 Tell the loader where to find our libraries if we're being installed
1089 someplace other than /usr .
1091 Change-Id: I42cbe98bcfc0e8ba2aa08f651044db051d31205c
1092 (cherry picked from commit 25d9695cb3536b672f4cd8bc280e2a3c816a0d8a)
1094 packaging/rpm/SPECS/wireshark.spec.in
1095 Reviewed-on: https://code.wireshark.org/review/5605
1096 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
1099 Author: Gerald Combs <gerald@wireshark.org>
1100 Date: Wed Dec 3 16:05:29 2014 -0800
1102 CMake: Don't cache LUA_LIBRARIES.
1104 Don't cache the LUA_LIBRARIES variable. This matches the behavior of the
1105 other library modules and fixes a compilation problem on my machine
1106 where /usr/local/lib/liblua.dylib wasn't showing up in the various
1107 build.make and link.txt files.
1109 Change-Id: Ib75ef303f2e67b266a246621718d0ea2ab885dca
1110 Reviewed-on: https://code.wireshark.org/review/5603
1111 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1114 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1115 Date: Wed Dec 3 17:54:45 2014 -0500
1117 Make a note that cmake needs to install the freedesktop integration files too.
1119 Change-Id: I5eeeb2fa32e8f90bc56f0515e0fc9f6c5f88eb79
1120 Reviewed-on: https://code.wireshark.org/review/5602
1121 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
1124 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1125 Date: Wed Dec 3 17:05:00 2014 -0500
1127 Don't run gtk-update-icon-cache when uninstalling the Qt package. But do run
1128 it when installing the gnome package.
1130 Change-Id: I0bbd9c0edc3fb6fe0e672aa3dbea5ba23d847d87
1131 Reviewed-on: https://code.wireshark.org/review/5598
1132 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
1135 Author: Pascal Quantin <pascal.quantin@gmail.com>
1136 Date: Wed Dec 3 20:48:08 2014 +0100
1138 FC: fix dissection when packets are captured with Fibre Channel FC-2 encapsulation type
1140 This is broken since ga9dd765
1143 Change-Id: Id4f282d9e0104bfa2314e2348aedf31233a671bd
1144 Reviewed-on: https://code.wireshark.org/review/5594
1145 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1146 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1147 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1148 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1151 Author: Martin Kaiser <wireshark@kaiser.cx>
1152 Date: Sat Nov 29 19:00:58 2014 +0100
1154 start dissecting the stsz box
1156 Change-Id: Ia8fce9307bae33c44d630af403980d162afd88c2
1157 Reviewed-on: https://code.wireshark.org/review/5597
1158 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
1159 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
1162 Author: Martin Kaiser <wireshark@kaiser.cx>
1163 Date: Sat Nov 29 18:50:59 2014 +0100
1167 Change-Id: I4eadf2b613b7803c81593e517408631f8375ab2c
1168 Reviewed-on: https://code.wireshark.org/review/5596
1169 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
1170 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
1173 Author: Martin Kaiser <wireshark@kaiser.cx>
1174 Date: Sat Nov 29 12:58:20 2014 +0100
1176 start dissecting the mvhd box
1178 Change-Id: I66c1973daa89690f6aaa10891408e93e886875ea
1179 Reviewed-on: https://code.wireshark.org/review/5595
1180 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
1181 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
1184 Author: Guy Harris <guy@alum.mit.edu>
1185 Date: Wed Dec 3 11:03:23 2014 -0800
1187 Squelch some "can't happen in reality" warnings.
1189 (I guess newer versions of GCC/Clang know that dissect_eh_frame() is
1190 never called with a segment_size of 0, so the loop is traversed at least
1191 once. NOTE: if it ever *is* called with a segment_size of 0, then
1192 that's a genuine bug and needs to be fixed.)
1194 Also, segment_size is used; no need to mark it as unused.
1196 Change-Id: I63b7a580a853b55f22494de73b4c4e6f9a387647
1197 Reviewed-on: https://code.wireshark.org/review/5591
1198 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1201 Author: AndersBroman <anders.broman@ericsson.com>
1202 Date: Wed Dec 3 12:57:38 2014 +0100
1204 Try to please the buildboots by plasing th '#' at the begining of the
1207 Change-Id: Ie17e83504e7fbccb71190b3fdbfb6ad3507a806e
1208 Reviewed-on: https://code.wireshark.org/review/5584
1209 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1212 Author: Peter Wu <peter@lekensteyn.nl>
1213 Date: Tue Nov 25 15:16:48 2014 +0100
1215 elf: fix .eh_frame parsing, add expert info for bad CIE length
1217 Fixes, matching LSB 4.1[1] and the AMD64 ABI[2]:
1218 - Multiple CIE entries can exist after the first one. Introduce a CFI
1219 subtree and add CIE and FDE records below it. Merge comon parsing
1220 functionality of CIE/FDE. A CIE terminator is treated specially, and
1221 added instead of a CFI subtree.
1222 - Validate the header length before using it to avoid a dissector
1223 assert. This condition is triggered by a binary produced by a buggy
1225 - Add two expert items: one to detect an invalid CIE length (too small
1226 or too large) and one to detect a segment which is larger than the
1227 CFI records (to catch the gold linker bug[3] where the segment begins
1229 - Do not overload the elf.eh_frame.length field with the value of the
1230 Extended Length, instead use elf.eh_frame.extended_length (likewise
1232 - Stop tracking the subsection size with another variable
1233 (remaining_length), just store the end of the entry.
1234 - Fix typos in descriptions, improved / shortened field descriptions.
1236 Tested with the 'bad' and 'good' binary from bug 10726 as well as the
1237 'a' binary from bug 8818 (which introduced this code). Decodes properly.
1239 [1]: https://refspecs.linuxfoundation.org/LSB_4.1.0/LSB-Core-generic/LSB-Core-generic/ehframechpt.html
1240 [2]: http://www.x86-64.org/documentation/abi.pdf
1241 [3]: https://sourceware.org/bugzilla/show_bug.cgi?id=17639
1244 Change-Id: I523600b8141bd8953ae468051a57357ab199a258
1245 Reviewed-on: https://code.wireshark.org/review/5488
1246 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
1247 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
1248 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1249 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
1252 Author: Guy Harris <guy@alum.mit.edu>
1253 Date: Wed Dec 3 01:06:02 2014 -0800
1255 Install the other desktop files with "make install" as well.
1257 (And remove them with "make uninstall".)
1259 Change-Id: I76b554bf1a1272813d61c8d2c96cda0a152eebb5
1260 Reviewed-on: https://code.wireshark.org/review/5582
1261 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1264 Author: Maarten Bezemer <maarten.bezemer@gmail.com>
1265 Date: Fri Nov 28 16:53:04 2014 +0100
1267 Support dissecting REAL (BER) data values
1269 Both exponent and 'integer N' values are limited:
1270 * max exponent is 3 octets/24-bits
1271 * max integer N is 8 octets/64-bit
1273 Tested with zero value/length, integers, doubles, positive and negative numbers all using the Basic Encoding Rules (BER)
1275 Change-Id: If92e1b3e209c42909b8cb76e6f50b8e6cd1da0da
1276 Reviewed-on: https://code.wireshark.org/review/5527
1277 Reviewed-by: Michael Mann <mmann78@netscape.net>
1278 Petri-Dish: Michael Mann <mmann78@netscape.net>
1279 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1280 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1283 Author: AndersBroman <anders.broman@ericsson.com>
1284 Date: Wed Dec 3 09:55:08 2014 +0100
1286 Make dissect_sip_tcp() a new style dissector.
1288 Change-Id: I773f6738b3ed507e1ce031ee308d16de4bdeb7d4
1289 Reviewed-on: https://code.wireshark.org/review/5580
1290 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1293 Author: Guy Harris <guy@alum.mit.edu>
1294 Date: Wed Dec 3 00:21:59 2014 -0800
1296 Use $(srcdir) when installing image/wsicon.svg.
1298 We're not necessarily running from the top-level source directory.
1300 Change-Id: I0bb815275f85630e5316bf593f4ac098d9475308
1301 Reviewed-on: https://code.wireshark.org/review/5579
1302 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1305 Author: Guy Harris <guy@alum.mit.edu>
1306 Date: Wed Dec 3 00:18:01 2014 -0800
1308 Uninstall the icons with "make uninstall".
1310 Just in case not all shells expand {list}, create the apps/icons and
1311 apps/mimetypes directories separately; that makes it a bit clearer in
1314 Change-Id: I25b3426a17a2ca7e1ce3ce1f7f9e1c650db511a7
1315 Reviewed-on: https://code.wireshark.org/review/5578
1316 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1319 Author: Guy Harris <guy@alum.mit.edu>
1320 Date: Tue Dec 2 22:21:13 2014 -0800
1322 Get rid of trailing blank.
1324 Change-Id: Ia0eecbbe1ff1778d5c34338e042c0518895663b4
1325 Reviewed-on: https://code.wireshark.org/review/5577
1326 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1329 Author: Guy Harris <guy@alum.mit.edu>
1330 Date: Tue Dec 2 22:19:01 2014 -0800
1332 Always install icons, and install them under $(datadir).
1334 We always install them because of bug 10737.
1336 We install them under $(datadir) because that's where we should install
1337 our data - if your desktop environment can't find the icons there,
1338 either it's broken (file a bug) or misconfigured (fix the configuration
1339 or, if you didn't configure it, file a bug).
1342 Change-Id: I567269d8e45e6543d9e39dbedc49830adf7edb9f
1343 Reviewed-on: https://code.wireshark.org/review/5576
1344 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1347 Author: Bill Meier <wmeier@newsguy.com>
1348 Date: Tue Dec 2 17:34:29 2014 -0500
1350 Fix instances of duplicate display-filter-names with incompatible types.
1352 Change-Id: I3b5afb8a59f6443624708b9fecfdcbe93dad59ef
1353 Note: Some of the filters, when/if used, could have caused Wireshark crashes.
1354 Reviewed-on: https://code.wireshark.org/review/5575
1355 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1358 Author: Pascal Quantin <pascal.quantin@gmail.com>
1359 Date: Tue Dec 2 22:18:55 2014 +0100
1361 L2TP: add dissection of H bits
1363 As requested in https://ask.wireshark.org/questions/38280/l2tp-dmpt-header-h-bit
1365 Change-Id: If6cb61c720505e547432e87faf2a36bb4ec6e7c5
1366 Reviewed-on: https://code.wireshark.org/review/5574
1367 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1370 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1371 Date: Tue Dec 2 16:09:26 2014 +0100
1373 Couchbase: fix missing comma...
1375 Change-Id: Ic86e07b434e693d2f0fbd9518a23ed49cf49f24d
1376 Reviewed-on: https://code.wireshark.org/review/5572
1377 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1380 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1381 Date: Tue Dec 2 15:32:34 2014 +0100
1383 Couchbase: fix Extended value string 'opcode_vals' forced to fall back to linear search
1385 entry 85, value 128 [0x80] < previous entry, value 245 [0xf5]
1387 Change-Id: I14bbe276eef5fdaa70561764ac4e6f2e174ceabe
1388 Reviewed-on: https://code.wireshark.org/review/5570
1389 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1392 Author: Stig Bjørlykke <stig@bjorlykke.org>
1393 Date: Mon Dec 1 15:00:13 2014 +0100
1395 cms: Handle media_type pkcs7-mime and pkcs7-signature
1397 Change-Id: I7db4e67ffe99a9f3b41d0b507d9837e0237d4547
1398 Reviewed-on: https://code.wireshark.org/review/5558
1399 Reviewed-by: Michael Mann <mmann78@netscape.net>
1402 Author: Stig Bjørlykke <stig@bjorlykke.org>
1403 Date: Mon Dec 1 15:13:25 2014 +0100
1405 imf: Added base64 content encoding support
1407 Change-Id: I668b9c3dfcac83c698e83d4111af8bd19ec8076c
1408 Reviewed-on: https://code.wireshark.org/review/5559
1409 Reviewed-by: Michael Mann <mmann78@netscape.net>
1412 Author: Sergey Avseyev <sergey.avseyev@gmail.com>
1413 Date: Tue Nov 18 21:11:22 2014 +0300
1415 Update Couchbase dissector
1417 * Include DCP port to the list default ports
1418 * Parse payloads for DCP commands:
1422 * Reorganize if conditions to cases
1423 * Update list of known commands
1425 Change-Id: Id37b5c61f0d1084628c6286fd6e4ad722e1d6d99
1426 Reviewed-on: https://code.wireshark.org/review/5388
1427 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1428 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1429 Reviewed-by: Sergey Avseyev <sergey.avseyev@gmail.com>
1430 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1431 Reviewed-by: Michael Mann <mmann78@netscape.net>
1434 Author: AndersBroman <anders.broman@ericsson.com>
1435 Date: Tue Dec 2 12:53:46 2014 +0100
1437 Make it possible to register an OID dissector to dissect
1438 ManagementExtension.
1440 Change-Id: I52c626b0d7a63214ccecf13d62e0a2850c2dee07
1441 Reviewed-on: https://code.wireshark.org/review/5569
1442 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1445 Author: Pascal Quantin <pascal.quantin@gmail.com>
1446 Date: Mon Dec 1 17:21:41 2014 +0100
1448 6LoWPAN: use manually managed memory for the stateful address decompression preferences
1451 Change-Id: I9d1b7ce2782f7cd133ab3ba02b0dd43afab3e145
1452 Reviewed-on: https://code.wireshark.org/review/5560
1453 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1454 Reviewed-by: Evan Huus <eapache@gmail.com>
1455 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1458 Author: Matthieu Texier <matthieu@texier.tv>
1459 Date: Mon Dec 1 23:48:44 2014 +0100
1461 BGP: Incorrect decoding AS numbers when mixed AS size
1463 Fix AS Path Heuristic
1465 Issue reported by Jon
1468 Change-Id: Ie5e4108bd93464a2d1076dcc4f322171ea8e68cb
1469 Reviewed-on: https://code.wireshark.org/review/5564
1470 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1473 Author: Stig Bjørlykke <stig@bjorlykke.org>
1474 Date: Mon Dec 1 14:57:07 2014 +0100
1476 multipart: Handle multipart/signed
1478 Change-Id: I39742dcce79fc41344c64e5266304c8c120aeb7c
1479 Reviewed-on: https://code.wireshark.org/review/5557
1480 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1483 Author: Stig Bjørlykke <stig@bjorlykke.org>
1484 Date: Mon Dec 1 14:47:02 2014 +0100
1486 multipart: Don't include boundary in preamble.
1488 Change-Id: I2d2fd28462b974e4ad656e36f2562633d0743962
1489 Reviewed-on: https://code.wireshark.org/review/5556
1490 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1493 Author: Bill Meier <wmeier@newsguy.com>
1494 Date: Mon Dec 1 23:08:50 2014 -0500
1496 dftest: load plugins so plugin display filters can also be tested.
1498 Change-Id: Ideab88b525cf58b05502f11fb1cf0f58b2864c42
1499 Reviewed-on: https://code.wireshark.org/review/5566
1500 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1503 Author: Bill Meier <wmeier@newsguy.com>
1504 Date: Mon Dec 1 12:13:03 2014 -0500
1506 alljoyn: Rename some filters; Fix some filter types.
1509 - Rename various "alljoyn.header..." display filter
1510 names releated to the alljoyn "message header"
1511 to "alljoyn.mess_header..." to distinguish
1512 the fields from actual alljoyn "header" fields.
1513 This also fixes the duplicate use of the display
1514 filter name "alljoyn.header".
1515 - Don't use FT_PROTOCOL for a field type.
1517 Change-Id: Id4e78f36716cf6064638aecd5faf561bcbc88b46
1518 Reviewed-on: https://code.wireshark.org/review/5561
1519 Petri-Dish: Bill Meier <wmeier@newsguy.com>
1520 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1521 Reviewed-by: Joe Huffman <jhuffman@codeaurora.org>
1522 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1525 Author: Yann Lejeune <ylejeune@netyl.org>
1526 Date: Mon Dec 1 19:08:31 2014 +0100
1528 BGP: fix dissection of BGP community tag
1530 The offset used for BGP community tag dissection is a wrong one.
1533 Change-Id: I1d1d443568bb97a0b3b95a312762ac0a3102326a
1534 Reviewed-on: https://code.wireshark.org/review/5562
1535 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1538 Author: Michael Mann <mmann78@netscape.net>
1539 Date: Mon Nov 24 10:10:12 2014 -0500
1541 Remove private_data member from packet_info structure.
1543 Dissectors should pass data directly to their subdissectors through the data parameter (of new-style dissectors). This avoids unintentional "trampling" from other dissectors trying to "share" private_data member.
1545 Change-Id: I2efef5c8dfeef64588ba3ac6e695b469238c6468
1546 Reviewed-on: https://code.wireshark.org/review/5487
1547 Petri-Dish: Michael Mann <mmann78@netscape.net>
1548 Reviewed-by: Michael Mann <mmann78@netscape.net>
1551 Author: Michael Mann <mmann78@netscape.net>
1552 Date: Mon Dec 1 00:18:41 2014 -0500
1554 Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
1556 Part 3 of many, but this concludes the strict conversion to proto_tree_add_bitmask. Patches to follow with use proto_tree_add_bitmask_xxx (some functions still need to be written)
1558 Change-Id: Ic2435667c6a7f1d40602124e5044954d2a296180
1559 Reviewed-on: https://code.wireshark.org/review/5553
1560 Reviewed-by: Michael Mann <mmann78@netscape.net>
1561 Petri-Dish: Michael Mann <mmann78@netscape.net>
1562 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1565 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1566 Date: Mon Dec 1 10:29:29 2014 +0100
1568 SNA: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
1570 Change-Id: I7a491488e67890c6cde98beec6a4935b10505afb
1571 Reviewed-on: https://code.wireshark.org/review/5555
1572 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1573 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1574 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1577 Author: Marko Hrastovec <marko.hrastovec@gmail.com>
1578 Date: Mon Dec 1 09:43:26 2014 +0100
1580 Asterix: fix Coverity scan (1025624 & 1025625: Missing break in switch)
1583 Two comments are added to the code to notify Coverity scan that breaks are not put in switch statement intentionally.
1585 Change-Id: Ie391790ee7365da56ddf0bf7b19042c9a11efddd
1586 Reviewed-on: https://code.wireshark.org/review/5554
1587 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1590 Author: Michael Mann <mmann78@netscape.net>
1591 Date: Sun Nov 30 12:51:30 2014 -0500
1593 Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
1597 Change-Id: I50815e7738b011382392f3078a7107d3d9eec4ec
1598 Reviewed-on: https://code.wireshark.org/review/5542
1599 Reviewed-by: Michael Mann <mmann78@netscape.net>
1600 Petri-Dish: Michael Mann <mmann78@netscape.net>
1601 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1604 Author: Michael Mann <mmann78@netscape.net>
1605 Date: Sun Nov 30 15:53:45 2014 -0500
1607 Improve checkfiltername.pl for pre-commit script.
1609 1. Bugfix grep statement checking if file is "autogenerated"
1610 2. Add to the list of "whitelist" duplicates. Many more were found after #1 was changed.
1612 Change-Id: Idea764c0c8b5fa4f30c9acaab9ba10340834d4f5
1613 Reviewed-on: https://code.wireshark.org/review/5547
1614 Petri-Dish: Evan Huus <eapache@gmail.com>
1615 Reviewed-by: Evan Huus <eapache@gmail.com>
1616 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1617 Reviewed-by: Michael Mann <mmann78@netscape.net>
1620 Author: Michael Mann <mmann78@netscape.net>
1621 Date: Sun Nov 30 16:17:26 2014 -0500
1623 Update display filter names per checkfiltername.pl
1625 Change-Id: I7694a6f8d8ccec3109fb86ccefee5798de57757d
1626 Reviewed-on: https://code.wireshark.org/review/5548
1627 Petri-Dish: Michael Mann <mmann78@netscape.net>
1628 Reviewed-by: Evan Huus <eapache@gmail.com>
1629 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1630 Reviewed-by: Michael Mann <mmann78@netscape.net>
1633 Author: Peter Wu <peter@lekensteyn.nl>
1634 Date: Sat Nov 29 19:32:30 2014 +0100
1636 qt: use qstring_strdup
1638 Replaces the more verbose `g_strdup(foo.toUtf8().constData())` by
1639 `qstring_strdup(foo)`. While at it, plug a minor memleak in
1642 Change-Id: I32b53f972b4e3998ac9beabd98647a381b7b42e3
1643 Reviewed-on: https://code.wireshark.org/review/5531
1644 Petri-Dish: Gerald Combs <gerald@wireshark.org>
1645 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1646 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1649 Author: Guy Harris <guy@alum.mit.edu>
1650 Date: Sun Nov 30 17:03:20 2014 -0800
1652 Squelch another compiler warning.
1654 Change-Id: Ib79bb30e67dacdda2e87f39438c4a836632d55bd
1655 Reviewed-on: https://code.wireshark.org/review/5552
1656 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1659 Author: Guy Harris <guy@alum.mit.edu>
1660 Date: Sun Nov 30 17:00:04 2014 -0800
1662 Squelch a compiler warning.
1664 Change-Id: Ic904f9b8551353192e872cb896f198572da83e27
1665 Reviewed-on: https://code.wireshark.org/review/5551
1666 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1669 Author: Guy Harris <guy@alum.mit.edu>
1670 Date: Sun Nov 30 16:57:09 2014 -0800
1674 Change-Id: I858248e252a09f4348e7ab88bef81c8452f39051
1675 Reviewed-on: https://code.wireshark.org/review/5550
1676 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1679 Author: Peter Wu <peter@lekensteyn.nl>
1680 Date: Sat Nov 29 19:29:26 2014 +0100
1682 qt: fix use-after-free pattern
1684 qstring.toUtf8() returns a QByteArray object and .constData() returns
1685 a pointer inside that object. It is not safe to store this pointer as
1686 it will become invalid after the statement. Store a const reference
1687 instead. (Due to scoping differences, some are copy-assigned though.)
1689 In the UAT dialog, strlen(bytes.constData()) has also been replaced by
1690 bytes.size() as an optimization.
1694 Change-Id: Ie09f999a32d0ef1abaa1e658b9403b74bedffc37
1695 Reviewed-on: https://code.wireshark.org/review/5528
1696 Petri-Dish: Gerald Combs <gerald@wireshark.org>
1697 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1698 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1701 Author: Guy Harris <guy@alum.mit.edu>
1702 Date: Sun Nov 30 16:30:19 2014 -0800
1704 Add a Buffer to wtap_pkthdr to hold file-type-specific packet metadata.
1706 For example, this can be used for pcap-ng options not mapped to
1707 file-type-independent metadata values.
1709 Change-Id: I398b324c62c1cc1cc61eb5e9631de00481b4aadc
1710 Reviewed-on: https://code.wireshark.org/review/5549
1711 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1714 Author: Pascal Quantin <pascal.quantin@gmail.com>
1715 Date: Sun Nov 30 20:29:34 2014 +0100
1717 win32: use target file format when checking if it supports comments
1720 Change-Id: Ib74f213630d6d382118c09b3cbf998b28cbc045e
1721 Reviewed-on: https://code.wireshark.org/review/5544
1722 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1725 Author: Guy Harris <guy@alum.mit.edu>
1726 Date: Sun Nov 30 11:27:18 2014 -0800
1728 Change some names to make them the same in multiple lists.
1730 Change-Id: I20ca39f69052b4134147577ae5be74c05b4d5e48
1731 Reviewed-on: https://code.wireshark.org/review/5543
1732 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1735 Author: Gerald Combs <gerald@wireshark.org>
1736 Date: Sun Nov 30 08:05:01 2014 -0800
1738 [Automatic manuf, services and enterprise-numbers update for 2014-11-30]
1740 Change-Id: I582091ce31fdd9e961b1000c2b58ef6cb2adca0d
1741 Reviewed-on: https://code.wireshark.org/review/5539
1742 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1745 Author: Guy Harris <guy@alum.mit.edu>
1746 Date: Sat Nov 29 16:57:20 2014 -0800
1748 Update to reflect current reality.
1750 Change-Id: I6defd7ffe92e9e07f4ff41166449d5a086800846
1751 Reviewed-on: https://code.wireshark.org/review/5538
1752 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1755 Author: Guy Harris <guy@alum.mit.edu>
1756 Date: Sat Nov 29 15:01:34 2014 -0800
1758 Fix tfshark.c to match changes to epan/print.[ch].
1760 Change-Id: I765cd0dbb5451b578ccabd221afc477a6559e60c
1761 Reviewed-on: https://code.wireshark.org/review/5537
1762 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1765 Author: Guy Harris <guy@alum.mit.edu>
1766 Date: Sat Nov 29 14:43:22 2014 -0800
1768 Clean up routine names, don't pass capture_file into libwireshark.
1770 Give all routines in epan/print.c that write a particular format a name
1771 beginning with write_{formatname}.
1773 If routines write columns, rather than the raw protocol tree, don't give
1774 it a name containing proto_tree.
1776 Get rid of empty preamble/finale routines.
1778 For CSV, the preamble routine writes out column titles, so call it
1779 write_csv_column_titles().
1781 For C arrays, the body routine writes out raw hex data, so call it
1782 write_carrays_hex_data().
1784 capture_file isn't a structure defined by libwireshark, so don't make it
1785 an argument passed into libwireshark.
1787 Change-Id: I5a7e04de9382cf51a59d9d9802f815b8b3558332
1788 Reviewed-on: https://code.wireshark.org/review/5536
1789 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1792 Author: Michael Mann <mmann78@netscape.net>
1793 Date: Sat Nov 29 15:41:12 2014 -0500
1795 Use proto_tree_add_bitmask for groups of proto_tree_add_boolean.
1799 Change-Id: I77a5789ac23388e6a5f8098dc398592f39638124
1800 Reviewed-on: https://code.wireshark.org/review/5532
1801 Petri-Dish: Michael Mann <mmann78@netscape.net>
1802 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1803 Reviewed-by: Michael Mann <mmann78@netscape.net>
1806 Author: Bill Meier <wmeier@newsguy.com>
1807 Date: Sat Nov 29 17:01:30 2014 -0500
1809 Rename some hf[] display filter names to fix dups.
1811 Change-Id: Ibe932bc37e03194f1801ec4eed4da1ff31370de3
1812 Reviewed-on: https://code.wireshark.org/review/5535
1813 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1816 Author: Bill Meier <wmeier@newsguy.com>
1817 Date: Sat Nov 29 17:00:07 2014 -0500
1819 ieee80211; Rename some hf[] display filter names to fix dups and for clarity.
1821 Change-Id: Ibcca2d7f85130b4a5a74808d88735513cfc0b580
1822 Reviewed-on: https://code.wireshark.org/review/5534
1823 Reviewed-by: Bill Meier <wmeier@newsguy.com>
1826 Author: Guy Harris <guy@alum.mit.edu>
1827 Date: Sat Nov 29 07:26:42 2014 +0000
1829 Revert "Add QNX' QNET protocol"
1831 This reverts commit 72b91a56f86e3bbab700900366f81dc8c353b91d.
1833 value_string_ext tables ***MUST*** be sorted numerically, otherwise the code prints warnings such as the ones in
1835 http://buildbot.wireshark.org/trunk/builders/Ubuntu%2014.04%20x64/builds/1419/steps/test.sh/logs/stdio
1837 Fix this and resubmit.
1839 Change-Id: I448025bb7b19a607e992831202ed31d243ce70d8
1840 Reviewed-on: https://code.wireshark.org/review/5530
1841 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1844 Author: Guy Harris <guy@alum.mit.edu>
1845 Date: Fri Nov 28 23:10:44 2014 -0800
1847 Sadly, index() was the name of a routine in V7, so....
1849 Change-Id: Id83899de08e0ad8e5664dddfb6ca268e7d0bd54d
1850 Reviewed-on: https://code.wireshark.org/review/5529
1851 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1854 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1855 Date: Tue Jun 17 17:03:11 2014 +0200
1857 Add QNX' QNET protocol
1859 no ethertype 0x8203-0x8205 support in trunk.
1860 0x8204 is QNX OS VER 6's qnet ethernet protocol number.
1863 Change-Id: I5f3e910876bb7fb86de2111f856d026fdf220917
1864 Reviewed-on: https://code.wireshark.org/review/2954
1865 Petri-Dish: Michael Mann <mmann78@netscape.net>
1866 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1867 Reviewed-by: Michael Mann <mmann78@netscape.net>
1870 Author: cbontje <cbontje@gmail.com>
1871 Date: Thu Nov 20 15:13:37 2014 -0700
1873 Add optional user Fast SER preference for SEL Fast Message Protocol
1875 * Also cleanup description of remaining preferences
1879 Change-Id: I81faba77d8b88b24c65156f5139067233869154b
1880 Reviewed-on: https://code.wireshark.org/review/5416
1881 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1882 Petri-Dish: Michael Mann <mmann78@netscape.net>
1883 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1884 Reviewed-by: Michael Mann <mmann78@netscape.net>
1887 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1888 Date: Thu Nov 27 16:23:58 2014 +0100
1890 Endpoint: wrong filter when select a TCP endpoint (INVALID == a.x.y.z ...)
1892 Change-Id: If56209f1274245f54100d0acfaf14098c8df4582
1893 Reviewed-on: https://code.wireshark.org/review/5520
1894 Reviewed-by: Michael Mann <mmann78@netscape.net>
1897 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1898 Date: Thu Nov 27 12:29:13 2014 +0100
1900 Endpoint: wrong filter when select a UDP endpoint (INVALID == a.x.y.z ...)
1902 Change-Id: Ie46d6c201df0b0164a8bf96c02d6430734fd2948
1903 Reviewed-on: https://code.wireshark.org/review/5518
1904 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1905 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1906 Reviewed-by: Michael Mann <mmann78@netscape.net>
1909 Author: Peter Wu <peter@lekensteyn.nl>
1910 Date: Tue Nov 25 19:40:12 2014 +0100
1912 elf: fix FDE Count formatting
1914 Displays the FDE Count as a number, not a series of bytes.
1916 Change-Id: I60dd426cb5305a5001a8200578008b7c4a99c64e
1917 Reviewed-on: https://code.wireshark.org/review/5489
1918 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
1919 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
1920 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1921 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
1924 Author: Pascal Quantin <pascal.quantin@gmail.com>
1925 Date: Tue Nov 25 23:14:50 2014 +0100
1927 TCP: move Windows Scaling and SCPS checks after options decoding
1929 This was changed in g8881f3f in an attempt to avoid throwing an exception when decoding the options field
1932 Change-Id: Ia4b49f484d6255090c5a6e425a9716b48ccc4cb5
1933 Reviewed-on: https://code.wireshark.org/review/5495
1934 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1935 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1938 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1939 Date: Thu Nov 27 11:11:18 2014 +0100
1941 Endpoint dialog (Qt): Add missing text to translate
1943 Change-Id: I375b348b6d6e35c212f76fc73135990a93560a75
1944 Reviewed-on: https://code.wireshark.org/review/5517
1945 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1948 Author: Michael Mann <mmann78@netscape.net>
1949 Date: Thu Nov 27 22:33:22 2014 -0500
1951 Eliminate proto_tree_add_text from packet-sna.c.
1953 Also convert many of the proto_tree_add_boolean calls into proto_tree_add_bitmask.
1955 Change-Id: I1fb2f943abed28434a2aadc48eb7e9ffb766f463
1956 Reviewed-on: https://code.wireshark.org/review/5523
1957 Reviewed-by: Michael Mann <mmann78@netscape.net>
1958 Petri-Dish: Michael Mann <mmann78@netscape.net>
1959 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1962 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1963 Date: Wed Nov 26 20:08:07 2014 +0100
1965 RADIUS: Sync with FreeRADIUS Master
1967 commit 30dac6d3dc87aaaa9c29ecdb33874fa57c2bcbc6
1968 Author: Alan T. DeKok <aland@freeradius.org>
1969 Date: Tue Nov 25 16:45:45 2014 -0500
1973 commit ee79c59d3a1cae76fcb1940710d9a0f7fbdf8427
1974 Author: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
1975 Date: Thu Nov 13 17:39:46 2014 -0500
1977 Add memcached rlm_cache_driver
1979 commit 6277960bc830891123b00400af56912e51d4d311
1980 Author: Alan T. DeKok <aland@freeradius.org>
1981 Date: Tue Oct 28 17:01:49 2014 -0400
1983 Add FreeRADIUS-Response-Delay-USec
1985 Change-Id: I705d0e852d38eaace4f71cfc0a38ecdd41c0b58f
1986 Reviewed-on: https://code.wireshark.org/review/5510
1987 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1988 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1989 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1992 Author: Guy Harris <guy@alum.mit.edu>
1993 Date: Thu Nov 27 16:07:16 2014 -0800
1995 Make the ENTTEC dissector reject packets that don't look like ENTTEC packets.
1997 This should avoid questions like
1999 https://ask.wireshark.org/questions/38198/what-is-enttec-in-a-pcap-file
2001 It also splits DMX-over-UDP and DMX-over-TCP into separate dissectors,
2004 1) DMX-over-TCP has only config packets, DMX-over-UDP has the
2007 2) that would let us do reassembly, if necessary, for
2010 Change-Id: I2606c814693028c7ba2bbc458e45c853372baaf3
2011 Reviewed-on: https://code.wireshark.org/review/5522
2012 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2015 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2016 Date: Wed Nov 26 16:38:30 2014 +0100
2018 Qt: Add long option for -R (--read-filter) and -Y (--display-filter)
2020 Change-Id: Id535c04493f6c6df88006d922ee43cff9f4b70a1
2021 Reviewed-on: https://code.wireshark.org/review/5507
2022 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
2025 Author: Enrico Jorns <ejo@pengutronix.de>
2026 Date: Fri Sep 26 12:07:03 2014 +0200
2028 canopen: LSS dissection
2030 Dissection of Layer setting services (LSS) sub-protocol
2031 according to CiA 305.
2033 Change-Id: I24ca1827b25c30a672fb31cad390b3c1486102f4
2034 Reviewed-on: https://code.wireshark.org/review/5516
2035 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2036 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2037 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2040 Author: Maarten Bezemer <maarten.bezemer@gmail.com>
2041 Date: Thu Nov 27 11:24:40 2014 +0100
2043 LEX and YACC are required
2045 When building both LEX (flex) and YACC (bison or yacc) are required to generate C files from l(ex) and y(acc) files
2047 Change-Id: I8892a05eb437d0bef613b68f681225df2cb2c6b4
2048 Reviewed-on: https://code.wireshark.org/review/5515
2049 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
2050 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2051 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2054 Author: Guy Harris <guy@alum.mit.edu>
2055 Date: Thu Nov 27 00:15:24 2014 -0800
2057 Note that this document is a bit old.
2059 Change-Id: Ie9a45acf1d3bc116d73b6430b058ffdcabead42b
2060 Reviewed-on: https://code.wireshark.org/review/5514
2061 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2064 Author: Bill Meier <wmeier@newsguy.com>
2065 Date: Wed Nov 26 20:41:16 2014 -0500
2067 Fix a number of dup hf[] filter-names probably mostly resulting from cut/paste errs
2069 Change-Id: Id658b9e1803b2f5b92e711a3ce981ff602333d98
2070 Reviewed-on: https://code.wireshark.org/review/5513
2071 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2074 Author: Bill Meier <wmeier@newsguy.com>
2075 Date: Wed Nov 26 18:18:57 2014 -0500
2077 Fix a number of dup hf[] filter-names probably resulting from cut/paste errs.
2079 Change-Id: I9242300b2ace3155c1506b584a90f073100a305e
2080 Reviewed-on: https://code.wireshark.org/review/5512
2081 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2084 Author: Pascal Quantin <pascal.quantin@gmail.com>
2085 Date: Wed Nov 26 23:01:48 2014 +0100
2087 XML: pass XML structure to caller through p_(add|get)_proto_data functions
2089 Since ge3a04bb data parameter is used for the media-type string
2092 Change-Id: I3df640079a8bf57f4bd86a1baa08cbf9a3a7e1b3
2093 Reviewed-on: https://code.wireshark.org/review/5511
2094 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2095 Reviewed-by: Michael Mann <mmann78@netscape.net>
2098 Author: Enrico Jorns <ejo@pengutronix.de>
2099 Date: Thu Sep 25 12:53:26 2014 +0200
2101 canopen: Enhanced SDO decoding
2103 * Move sdo dissection to separate function
2105 Added dissect_sdo() function to handle the more complex SDO dissection.
2107 * SDO command specifier decoding
2109 Decoding of both client and server command specifier for SDO transfers
2110 according to CiA 301 Chaper 7.2.4.3.
2112 Note: Fully decoding block transfer frames is more complex and not supported
2115 * basic SDO abort code decoding
2117 SDO abort codes as specified in CiA 301 Chapter 7.2.4.3.17 (Table 22).
2119 * Basic value ranges for object dict index parameter
2121 Object dict ranges as specified in CiA 301 7.4.1 (Table 41)
2123 * cs-based multiplexer and data decoding
2125 A data width of 4 byte is valid only for expedited transfer and a
2126 multiplex value is present only in initialisation messages.
2128 This patch now handles also normal sdo segment data.
2130 Reference: CiA 301, Chapter 7.2.4.3.3 and 7.2.4.3.6
2132 Change-Id: I37005894082d62eed1ddd85e09e3676aa3af8222
2133 Reviewed-on: https://code.wireshark.org/review/5504
2134 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2135 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2136 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2137 Reviewed-by: Michael Mann <mmann78@netscape.net>
2140 Author: Stephen Fisher <sfisher@sdf.org>
2141 Date: Wed Nov 26 10:09:03 2014 -0700
2143 Update the URL for the CPUID instruction documentation.
2145 Change-Id: I9729b3aa11027783a3557468743e91e180a6de8d
2146 Reviewed-on: https://code.wireshark.org/review/5509
2147 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2150 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2151 Date: Wed Nov 26 15:20:27 2014 +0100
2153 WCCP: Remove uneeded check (pinfo & info_tree)
2155 Remove also some false positive Dereference of null pointer
2157 Change-Id: I09687993531827c6e4f5178f3414ddd9a2702038
2158 Reviewed-on: https://code.wireshark.org/review/5506
2159 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2160 Reviewed-by: Evan Huus <eapache@gmail.com>
2161 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2162 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2165 Author: Michael Mann <mmann78@netscape.net>
2166 Date: Sat Nov 22 16:15:17 2014 -0500
2168 Remove the use of pinfo->private_data from dissectors that just save it to restore it.
2170 Change-Id: I13197cc48068bb35ee12a7023cfe5f76bbc4e264
2171 Reviewed-on: https://code.wireshark.org/review/5486
2172 Petri-Dish: Michael Mann <mmann78@netscape.net>
2173 Reviewed-by: Michael Mann <mmann78@netscape.net>
2176 Author: Martin Kaiser <wireshark@kaiser.cx>
2177 Date: Sat Nov 22 12:58:43 2014 +0100
2179 Qt: support the -R option to set a read filter on the command line
2181 rename display_filter to read_filter in some places to make it clear
2184 modify MainWindow::openCaptureFile() so that a read filter can be set
2185 when the file name is passed in cf_path, not only when it's chosen from
2186 a file selection dialogue
2188 don't display the read filter string in the filter toolbar
2190 Change-Id: Ie8dc94cbd1ff7e61ce1e2a55518a28297daa5d51
2191 Reviewed-on: https://code.wireshark.org/review/5446
2192 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2195 Author: AndersBroman <anders.broman@ericsson.com>
2196 Date: Wed Nov 26 13:36:03 2014 +0100
2198 [MGCP] When changing tvb_length(tvb) -> tvb_reported_length(tvb) it turns
2199 out that tvb_new_subset(tvb, tvb_sectionbegin, sectionlen, -1) causes a
2200 problem as reported_length is set to -1, set it to sectionlen.
2202 Change-Id: I650d3fa1390be5add66ed44d0f70929b9eb0aad6
2203 Reviewed-on: https://code.wireshark.org/review/5505
2204 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2207 Author: Michael Mann <mmann78@netscape.net>
2208 Date: Sat Nov 22 11:54:54 2014 -0500
2210 Remove sccp_info member from packet_info structure.
2212 sccp_msg_info_t* is now passed from SCCP dissector to its subdissectors through dissector data parameter.
2214 Change-Id: Iab4aae58f8995e844f72e02e9f2de36e83589fc0
2215 Reviewed-on: https://code.wireshark.org/review/5442
2216 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2219 Author: Bill Meier <wmeier@newsguy.com>
2220 Date: Tue Nov 25 13:49:12 2014 -0500
2222 openflow: Use (what appear to be the) correct filter names for a few fields.
2224 Change-Id: I2acd93d99942601b34c85177d21bbc2c4a4e2633
2225 Reviewed-on: https://code.wireshark.org/review/5492
2226 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2229 Author: Enrico Jorns <ejo@pengutronix.de>
2230 Date: Thu Oct 2 16:09:38 2014 +0200
2232 canopen: Improve NMT error control and SYNC message dissection
2234 1. Also show Reserved/Toggle bit of NMT error control
2236 In case of the node guarding protocol this bit is used as a toggle bit.
2237 In case of the hearbeat protocol this bit is reserved.
2239 Reference: CiA 301 (rev 4.2.0), Chap. 7.2.8.3.2
2241 2. Show optional 'counter' parameter of SYNC messages if available
2243 Reference: CiA 301 (rev 4.2.0), Chap. 7.2.5.3.1
2245 Change-Id: I5dc0ab65e95fec4846a9c8bd8972ef2eba664ee2
2246 Reviewed-on: https://code.wireshark.org/review/5484
2247 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2248 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2249 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2250 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2253 Author: Evan Huus <eapache@gmail.com>
2254 Date: Tue Nov 25 20:27:07 2014 -0500
2256 dec-dnart: use pinfo-scoped memory for addresses
2258 They may be accessed during the print phase, at which point packet-scope memory
2259 has already been freed.
2262 Change-Id: Ifcf5fc0c0857614edf85349b12dfe605abf6fef7
2263 Reviewed-on: https://code.wireshark.org/review/5497
2264 Reviewed-by: Evan Huus <eapache@gmail.com>
2267 Author: Evan Huus <eapache@gmail.com>
2268 Date: Tue Nov 25 20:16:05 2014 -0500
2270 wccp: use pinfo-scope memory for addresses
2272 They may be accessed during the print phase, at which point packet-scope memory
2273 has already been freed.
2276 Change-Id: Ia2b160fd9de4ccaa3a4b8d9cb70fb9b32d4e08a0
2277 Reviewed-on: https://code.wireshark.org/review/5496
2278 Reviewed-by: Evan Huus <eapache@gmail.com>
2281 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2282 Date: Tue Nov 25 12:39:53 2014 +0100
2284 conversation_table: fix indent (use 4spaces) and add modelines info
2286 Change-Id: I76784f0252dcd095a3016ed014632e2a5c09265b
2287 Reviewed-on: https://code.wireshark.org/review/5483
2288 Reviewed-by: Evan Huus <eapache@gmail.com>
2291 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2292 Date: Tue Nov 25 12:37:59 2014 +0100
2294 conversation_table: fix warning when generate documentation (doxygen)
2296 epan/conversation_table.h:335: warning: The following parameters of add_hostlist_table_data(conv_hash_t *ch, const address *addr, guint32 port, gboolean sender, int num_frames, int num_bytes, hostlist_dissector_info_t *host_info, port_type port_type_val) are not documented:
2297 parameter 'host_info'
2298 parameter 'port_type_val'
2300 Change-Id: I6c3b29750c856eb2665981553fcb8eecd8fe34ee
2301 Reviewed-on: https://code.wireshark.org/review/5482
2302 Reviewed-by: Evan Huus <eapache@gmail.com>
2305 Author: Gerald Combs <gerald@wireshark.org>
2306 Date: Mon Nov 24 14:51:13 2014 -0600
2308 Consolidate sequence analysis code.
2310 Move scattered code for seq_analysis_info_t creation and destruction to
2311 tap-sequence-analysis.[ch].
2313 Change-Id: I87c14b1c83105a48d0ab149a3abba71e2a2fe21f
2314 Reviewed-on: https://code.wireshark.org/review/5479
2315 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2316 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2317 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2320 Author: Yaniv Kaul <mykaul@gmail.com>
2321 Date: Tue Nov 25 21:24:23 2014 +0100
2323 SCSI: type and scope fields are ignored in some SCSI persistent reserve service actions
2326 Change-Id: Id34f57b2a0b89867eec1b0a13db2eba037835804
2327 Reviewed-on: https://code.wireshark.org/review/5493
2328 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2329 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2332 Author: Stephen Fisher <sfisher@sdf.org>
2333 Date: Tue Nov 25 14:44:03 2014 -0700
2335 Add on to the dummy.cpp hack that forces wireshark to be linked with a
2336 c++ compiler to automatically create a dummy.cpp file and remove it when
2337 make clean is issued. This allows make tags to work again since the
2340 Change-Id: I17191ad2acc281734fa12da4d347fd3116018f67
2341 Reviewed-on: https://code.wireshark.org/review/5494
2342 Petri-Dish: Stephen Fisher <sfisher@sdf.org>
2343 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2344 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2347 Author: Bill Meier <wmeier@newsguy.com>
2348 Date: Tue Nov 25 00:43:06 2014 -0500
2350 openflow: Minor changes
2352 - Remove unneeded/undefined forward declarations;
2353 - Create/use some extended value-strings;
2354 - Do some whitespace changes.
2356 Change-Id: I7961864f0e404e141d2887584751116011f8d941
2357 Reviewed-on: https://code.wireshark.org/review/5490
2358 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2361 Author: Bill Meier <wmeier@newsguy.com>
2362 Date: Tue Nov 25 12:53:43 2014 -0500
2364 proto.c: proto_registrar_dump_values(): don't skip "same name" fields.
2366 It appears that Wireshark allows (and currently has) fields with the
2367 same name with differing "strings" content.
2369 Change-Id: Iddac5a2c9f456a97ea676f2007f43d786482eebd
2370 Reviewed-on: https://code.wireshark.org/review/5491
2371 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2374 Author: Michael Mann <mmann78@netscape.net>
2375 Date: Sat Nov 22 19:24:06 2014 -0500
2377 Remove support for pinfo->private_data in "data-text-lines", "data-l1-events" and "urlencoded-form" dissectors. Data must be passed from parent through dissectors data parameter.
2379 Change-Id: I24ab56ce7d99f8ed670f4a50453223d4e6a46983
2380 Reviewed-on: https://code.wireshark.org/review/5463
2381 Petri-Dish: Michael Mann <mmann78@netscape.net>
2382 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2385 Author: Michael Mann <mmann78@netscape.net>
2386 Date: Sat Nov 22 20:47:59 2014 -0500
2388 Ensure dissector data parameter is used instead of pinfo->private_data when passing data between dissectors using the "media_type" subdissector.
2390 Change-Id: I82cbfed770b41404bc42cb6a4413db07d04dffdc
2391 Reviewed-on: https://code.wireshark.org/review/5462
2392 Reviewed-by: Michael Mann <mmann78@netscape.net>
2393 Petri-Dish: Michael Mann <mmann78@netscape.net>
2394 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2395 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2398 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2399 Date: Mon Nov 24 19:50:11 2014 +0100
2401 pre-commit tools: Add arg option to specify the commit id to be checked
2403 If no commit id specify, it is HEAD
2405 Thanks to Michal for the help :-)
2407 Change-Id: Ibf579aed47c7574f9a01d868ae0d55bbe789a8a2
2408 Reviewed-on: https://code.wireshark.org/review/5474
2409 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2410 Reviewed-by: Evan Huus <eapache@gmail.com>
2413 Author: Enrico Jorns <ejo@pengutronix.de>
2414 Date: Tue Nov 25 10:08:05 2014 +0100
2416 canopen: Fixed tree expansion
2418 Previously the COB-ID and Type subtree also used the main ett_canopen
2419 variable. This made control of subtree expansion impossible as both
2420 parent and subtree nodes shared the same state.
2422 Change-Id: I3dabf7f399e83bfcfbf78bc0e633e3696776c043
2423 Reviewed-on: https://code.wireshark.org/review/5480
2424 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2427 Author: Stephen Fisher <sfisher@sdf.org>
2428 Date: Mon Nov 24 12:01:46 2014 -0700
2430 Remove unused ui_simple_dialog.h from qt Makefile.common
2432 Change-Id: I366a52a037462cb059565365ea1eec5be228078f
2433 Reviewed-on: https://code.wireshark.org/review/5475
2434 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2435 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2438 Author: Michael Mann <mmann78@netscape.net>
2439 Date: Sat Nov 22 18:17:20 2014 -0500
2441 Have media dissector take its "media type parameter" from dissector data parameter instead of pinfo->private_data.
2443 Change-Id: I0a0cb0b4838bc4e55a759fb6031355892c220c8e
2444 Reviewed-on: https://code.wireshark.org/review/5461
2445 Reviewed-by: Michael Mann <mmann78@netscape.net>
2446 Petri-Dish: Michael Mann <mmann78@netscape.net>
2447 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2450 Author: Michael Mann <mmann78@netscape.net>
2451 Date: Mon Nov 24 10:26:00 2014 -0500
2453 Remove use of pinfo->private_data since it's not used anywhere.
2455 Change-Id: Ibb47fd1a0d498cc9791ca31ee625395905a7e999
2456 Reviewed-on: https://code.wireshark.org/review/5464
2457 Reviewed-by: Michael Mann <mmann78@netscape.net>
2458 Petri-Dish: Michael Mann <mmann78@netscape.net>
2459 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2462 Author: Joe Fowler <fowlerja@us.ibm.com>
2463 Date: Tue Nov 18 13:13:46 2014 -0500
2465 Add new dissector for Shared Memory Communications over RDMA protocol (SMC-R)
2467 RFC draft http://www.ietf.org/id/draft-fox-tcpm-shared-memory-rdma-05.txt
2468 used as reference for packet dissection.
2470 A small change was made to packet-infiniband, to add the Queue Number to the
2471 info column. This allows for easy indentification of session traffic for a
2474 Also: infiniband: tvb_length() --> tvb_captured_length()
2477 Change-Id: I774ceffaa5c271cb6a28ab4ed21e53cd42f2547b
2478 Reviewed-on: https://code.wireshark.org/review/5386
2479 Petri-Dish: Bill Meier <wmeier@newsguy.com>
2480 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2481 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2484 Author: Martin Kaiser <wireshark@kaiser.cx>
2485 Date: Sat Nov 22 11:59:50 2014 +0100
2487 Qt: support the -Y option to set an initial display filter
2489 Change-Id: I7627265b876c6994b163df1c5b037f4dae2f6d42
2490 Reviewed-on: https://code.wireshark.org/review/5445
2491 Reviewed-by: Evan Huus <eapache@gmail.com>
2494 Author: Michael Mann <mmann78@netscape.net>
2495 Date: Sun Nov 23 23:06:34 2014 -0500
2497 Eliminate proto_tree_add_text from some dissectors.
2499 Change-Id: Iadd80aab291e5de714891a9f3c79edeca19e9b93
2500 Reviewed-on: https://code.wireshark.org/review/5458
2501 Reviewed-by: Michael Mann <mmann78@netscape.net>
2502 Petri-Dish: Michael Mann <mmann78@netscape.net>
2503 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2504 Reviewed-by: Evan Huus <eapache@gmail.com>
2507 Author: Matthieu Coudron <mattator@gmail.com>
2508 Date: Tue Nov 18 19:33:53 2014 +0100
2510 TCP: fix wrongly set base_seq when ISN is 0 and tcp_relative_seq is
2513 tcp_analysis::base_seq could be set several times when the
2514 TCP ISN was set to 0, thus inducing some undesired wraps such as 0-1
2517 Change-Id: I69a0dfe677e93bf51015bf7a39ebf888631b12a4
2518 Reviewed-on: https://code.wireshark.org/review/5387
2519 Reviewed-by: Michael Mann <mmann78@netscape.net>
2520 Petri-Dish: Michael Mann <mmann78@netscape.net>
2521 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2522 Reviewed-by: Evan Huus <eapache@gmail.com>
2525 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2526 Date: Wed Nov 19 21:34:20 2014 +0100
2528 hostlist_table (GTK): Fix Dereference of null pointer found by Clang analyzer
2530 Change-Id: If74dc38b2a9724b9d924092796db5b6beb97043c
2531 Reviewed-on: https://code.wireshark.org/review/5400
2532 Reviewed-by: Evan Huus <eapache@gmail.com>
2535 Author: Maarten Bezemer <maarten.bezemer@gmail.com>
2536 Date: Mon Nov 24 16:30:52 2014 +0100
2538 Update debian symbols
2540 * register_tap_ui is removed in a21436eaed
2541 * wtap_read_bytes(_or_eof) are introduced in 670ebda4a6
2543 Change-Id: If815c686d57310f0d87f965b5b5c2a71b651cbad
2544 Reviewed-on: https://code.wireshark.org/review/5465
2545 Petri-Dish: Michael Mann <mmann78@netscape.net>
2546 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2547 Reviewed-by: Michael Mann <mmann78@netscape.net>
2550 Author: Stephen Fisher <sfisher@sdf.org>
2551 Date: Mon Nov 24 16:50:10 2014 -0700
2553 Allow html version of man pages to be found when running from build
2554 directory (they're in doc/ of the build directory).
2556 Change-Id: I425fa847952cf9f74a948a89c0048077dfcf0ae2
2557 Reviewed-on: https://code.wireshark.org/review/5478
2558 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2561 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2562 Date: Fri Nov 21 11:24:50 2014 +0100
2564 A21: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
2568 Remove also double space
2570 Change-Id: I77aa269c1abae18b4fb9daec6cc0ac862cf4ab9f
2571 Reviewed-on: https://code.wireshark.org/review/5421
2572 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2573 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2576 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2577 Date: Mon Nov 24 21:12:55 2014 +0100
2579 Mate: Fix indent (use tabs)
2581 Change-Id: I9a02e4a063dc4fc173ff9b7596acd7f9ceba7aa7
2582 Reviewed-on: https://code.wireshark.org/review/5477
2583 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2586 Author: Stephen Fisher <sfisher@sdf.org>
2587 Date: Mon Nov 24 12:07:59 2014 -0700
2589 Change capitalization of "DNS UDP [p]orts" to match "DNS TCP ports" in prefs
2591 Change-Id: Ib0bffc6d5e4bd6b68f48a843b4b4cab7422aceb7
2592 Reviewed-on: https://code.wireshark.org/review/5476
2593 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2596 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2597 Date: Mon Nov 24 18:11:30 2014 +0100
2599 MIPv6: Enhance ANI dissection
2601 * Fix wrong length for Operator Identifier
2602 * Display Latitude and longitude in Degrees
2605 Change-Id: Idf6ba63db3ff16710fd0de7a7fd2233148cbaf4a
2606 Reviewed-on: https://code.wireshark.org/review/5473
2607 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2610 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2611 Date: Mon Nov 24 18:34:19 2014 +0000
2613 Revert "Allow "(g)make tags" to work again"
2615 This reverts commit 6b8fe87ef48abb95dd303871d0835c153cf8c891.
2617 Change-Id: Ie4f681186c1555e6ab966e7db687035f7fc5e60f
2618 Reviewed-on: https://code.wireshark.org/review/5472
2619 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2622 Author: Stephen Fisher <sfisher@sdf.org>
2623 Date: Thu Nov 20 10:35:45 2014 -0700
2625 Allow "(g)make tags" to work again
2627 Change-Id: Idcff82aceedbf42652741564e06ca53984078361
2628 Reviewed-on: https://code.wireshark.org/review/5413
2629 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2630 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2633 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2634 Date: Mon Nov 24 18:18:00 2014 +0100
2636 CPHA : tvb_length -> tvb_reported_length
2638 Change-Id: I49a7ffb1fcff71d49593ab009036f21c3ae6a2d0
2639 Reviewed-on: https://code.wireshark.org/review/5471
2640 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2643 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2644 Date: Mon Nov 24 17:16:52 2014 +0100
2646 CPHA: Update versions lists
2648 Use also value_string ext
2650 Request from Hugo van der Kooij
2653 Change-Id: I0603687215b7e82a987a4a6cde00eb996b04a77c
2654 Reviewed-on: https://code.wireshark.org/review/5466
2655 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2658 Author: Stephen Fisher <sfisher@sdf.org>
2659 Date: Fri Nov 21 16:23:24 2014 -0700
2661 Second attempt at putting a description in the preferences page
2663 Change-Id: I6d196486e824c82d29f1c233ef3230ad8619715d
2664 Reviewed-on: https://code.wireshark.org/review/5434
2665 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
2668 Author: Michael Mann <mmann78@netscape.net>
2669 Date: Sat Nov 22 14:13:10 2014 -0500
2671 Pass data to JSON through dissector data, not pinfo->private_data.
2673 Change-Id: I21dc2777822f0836f486432343cc1238886ad29d
2674 Reviewed-on: https://code.wireshark.org/review/5460
2675 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2678 Author: Bill Meier <wmeier@newsguy.com>
2679 Date: Mon Nov 24 11:38:43 2014 -0500
2681 openflow; Fix a (no-effect) typo in openflow_version_values[]
2683 Change-Id: I7a51face9c675ac3c03f2306ec40293b4835e02e
2684 Reviewed-on: https://code.wireshark.org/review/5468
2685 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2688 Author: AndersBroman <anders.broman@ericsson.com>
2689 Date: Mon Nov 24 17:22:02 2014 +0100
2691 [SIP/DIAMETER] Reinstate the lost dfilter_store_sip_from_addr() and use it
2692 for 3GPP AVP 601 Public-Identity.
2694 Change-Id: I5ef6608e7821779b00f79486860ee5f578828dfc
2695 Reviewed-on: https://code.wireshark.org/review/5467
2696 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2699 Author: Pascal Quantin <pascal.quantin@gmail.com>
2700 Date: Mon Nov 24 15:51:27 2014 +0100
2702 SMTP: escape ASCII strings printed to COL_INFO
2704 This is already done automatically for the hf entries thanks to hfinfo_format_text() function
2707 Change-Id: I9ee56b795234a94f0e59c82a96e3e6cedf71c4e6
2708 Reviewed-on: https://code.wireshark.org/review/5459
2709 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2710 Reviewed-by: Michael Mann <mmann78@netscape.net>
2711 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2712 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2715 Author: Michael Mann <mmann78@netscape.net>
2716 Date: Sun Nov 23 00:12:57 2014 -0500
2718 Pass FrameID as data to the heuristic table, rather than use pinfo->private_data.
2720 Change-Id: Idd5818cbb2b1f8628bb29c2c71dfc6d41df89b5d
2721 Reviewed-on: https://code.wireshark.org/review/5448
2722 Petri-Dish: Michael Mann <mmann78@netscape.net>
2723 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2724 Reviewed-by: Michael Mann <mmann78@netscape.net>
2727 Author: Dave Tapuska <dtapuska@google.com>
2728 Date: Mon Nov 17 17:12:36 2014 -0500
2730 SSL: Implement Extended Master Secret
2732 Store all handshake mesages in a buffer so that we can hash them
2733 correctly when generating the master secret.
2735 This change does not work correctly for DTLS retransmitted packets; that
2736 are in the handshake as they will be hashed twice; which is bad. Looking
2737 for ideas to implement this.
2740 Change-Id: Ied01d4cc37b4270f325070a8d1630d3123577a0d
2741 Reviewed-on: https://code.wireshark.org/review/5168
2742 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
2743 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2744 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2745 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2748 Author: Guy Harris <guy@alum.mit.edu>
2749 Date: Sun Nov 23 17:03:42 2014 -0800
2751 Don't do unsafe pointer casting
2753 Don't cast a pointer-to-int into a pointer-to-pointer and pass the
2754 resulting pointer to g_hash_table_lookup_extended() - pointers and ints
2755 are *not* guaranteed to be the same size. Instead, just have a variable
2756 of type gpointer, pass a pointer to *that*, and then run that result
2757 through GPOINTER_TO_UINT().
2759 This fixes a reproducible crash.
2761 Change-Id: I42954f222ab59866cb909b80d9dbb1d2668d2aff
2762 Reviewed-on: https://code.wireshark.org/review/5457
2763 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2766 Author: Peter Wu <peter@lekensteyn.nl>
2767 Date: Sun Nov 23 23:58:24 2014 +0100
2769 elf: separate ett for program and sections entries
2771 This makes it easier to focus on a single section entry, collapsing all
2774 Change-Id: I3de72065eb279e9449496a7224508e5be85c3757
2775 Reviewed-on: https://code.wireshark.org/review/5456
2776 Reviewed-by: Michael Mann <mmann78@netscape.net>
2779 Author: Guy Harris <guy@alum.mit.edu>
2780 Date: Sun Nov 23 12:30:59 2014 -0800
2782 Presumably the intent is to dump *non*-dummy entries.
2784 I.e., presumably the intent is to dump *resolved* hosts, rather than
2785 *unresolved* hosts where there's no known host name and the name field
2786 is a string form of the address (the premise being that looking the
2787 address up in the hash table repeatedly, and using the already-generated
2788 string, will be faster than generating the string repeatedly).
2790 Change-Id: Iad1beb1d5f9cd9ed92bad5386111cb659614ee4d
2791 Reviewed-on: https://code.wireshark.org/review/5455
2792 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2795 Author: Guy Harris <guy@alum.mit.edu>
2796 Date: Sun Nov 23 00:20:10 2014 -0800
2798 Newlines at the ends of lines, please.
2800 Change-Id: I7b484e3ddac7cb1330c966819514a9468ea69066
2801 Reviewed-on: https://code.wireshark.org/review/5454
2802 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2805 Author: Gerald Combs <gerald@wireshark.org>
2806 Date: Sun Nov 23 08:04:42 2014 -0800
2808 [Automatic manuf, services and enterprise-numbers update for 2014-11-23]
2810 Change-Id: I6f8a66b742571dcde011125df9295daedc5652a7
2811 Reviewed-on: https://code.wireshark.org/review/5450
2812 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2815 Author: Michael Mann <mmann78@netscape.net>
2816 Date: Sat Nov 22 23:11:32 2014 -0500
2818 Remove use of pinfo->private_data (which doesn't appear to be used anyway) and pass it as dissector data.
2820 Some other minor cleanup while in the neighborhood.
2822 Change-Id: I1b0c0567488fa350c14d21c5f5e4cb9746177af1
2823 Reviewed-on: https://code.wireshark.org/review/5447
2824 Petri-Dish: Michael Mann <mmann78@netscape.net>
2825 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2826 Reviewed-by: Michael Mann <mmann78@netscape.net>
2829 Author: Guy Harris <guy@alum.mit.edu>
2830 Date: Sat Nov 22 12:20:05 2014 -0800
2834 Change-Id: Ib1cb41f212bbccd4e20d3621110cbb98c01a7196
2835 Reviewed-on: https://code.wireshark.org/review/5444
2836 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2839 Author: Michael Mann <mmann78@netscape.net>
2840 Date: Sat Nov 22 13:13:22 2014 -0500
2842 Use dissector data to "return" XML data to XMPP dissector.
2844 Change-Id: I9abdc8c3deed35131af1537733d624d5cfced182
2845 Reviewed-on: https://code.wireshark.org/review/5443
2846 Petri-Dish: Michael Mann <mmann78@netscape.net>
2847 Reviewed-by: Michael Mann <mmann78@netscape.net>
2850 Author: Michael Mann <mmann78@netscape.net>
2851 Date: Sun Nov 16 10:22:34 2014 -0500
2853 Cleanup packet-sccp.c in preparation of trying to remove sccp_info member of packet_info.
2855 Convert a handful of global variables into function parameters that get passed through the dissector, so we shouldn't be dependent on pinfo->sccp_info anymore. Removal of pinfo->sccp_info will be done in a separate patch (when the dissectors that use it can be updated).
2857 packet-sua.c may need similar treatment.
2859 Change-Id: If0001638d666afc07e04b02aa32ef31d6223a5de
2860 Reviewed-on: https://code.wireshark.org/review/5343
2861 Reviewed-by: Michael Mann <mmann78@netscape.net>
2862 Petri-Dish: Michael Mann <mmann78@netscape.net>
2863 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2864 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2867 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
2868 Date: Wed Nov 19 22:22:12 2014 -0500
2870 Fix problem where the profile bar moves further left every time Wireshark is
2873 For the saved/restored geometry to be consistently correct we need to always
2874 show the expert info and capture file comment icons. Disable them if no
2875 capture file is open.
2878 Change-Id: I6e254f66a17f8f54f28cfbafb4e0f92e02cff70c
2879 Reviewed-on: https://code.wireshark.org/review/5404
2880 Reviewed-by: Evan Huus <eapache@gmail.com>
2881 Petri-Dish: Evan Huus <eapache@gmail.com>
2882 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2883 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2886 Author: Jesse Gross <jesse@nicira.com>
2887 Date: Tue Nov 18 14:36:30 2014 -0800
2889 Add version check in Geneve dissector.
2891 We should warn when decoding Geneve packets with an unknown
2894 Change-Id: Id40b756c3bb0320b69fbd8ee98830a2b05834a48
2895 Reviewed-on: https://code.wireshark.org/review/5420
2896 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2897 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2898 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2899 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2902 Author: Graham Bloice <graham.bloice@trihedral.com>
2903 Date: Fri Nov 21 23:27:56 2014 +0000
2905 Add the required c flags for some test executables
2907 Change-Id: I93b0c346fff162899e5f97dd2366e01cf99ec38e
2908 Reviewed-on: https://code.wireshark.org/review/5435
2909 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
2910 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2911 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
2914 Author: Guy Harris <guy@alum.mit.edu>
2915 Date: Sat Nov 22 01:07:13 2014 -0800
2917 Get rid of another global in the print code.
2919 Pass the "output only these protocols" hash table as an argument,
2922 Change-Id: Id8540943037e7b9bbfe377120c3f60dbe54fe0f1
2923 Reviewed-on: https://code.wireshark.org/review/5440
2924 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2927 Author: Guy Harris <guy@alum.mit.edu>
2928 Date: Sat Nov 22 00:28:12 2014 -0800
2930 Pass a capture_file * to write_psml_preamble() in tfshark as well.
2932 Change-Id: I2b2ae78d4b75bb27a44d185b48e3d85794effdb7
2933 Reviewed-on: https://code.wireshark.org/review/5439
2934 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2937 Author: Guy Harris <guy@alum.mit.edu>
2938 Date: Sat Nov 22 00:06:54 2014 -0800
2940 Get rid of write_headers global variable.
2942 Have write_psml_preamble() and write_csv_preamble() take a capture_file *
2943 as an argument, so they can print the column titles themselves, rather
2944 than having to defer it to the routine that prints packet data.
2946 Change-Id: Ifd1b7a13062be8ad46846315976922a752778153
2947 Reviewed-on: https://code.wireshark.org/review/5438
2948 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2951 Author: Guy Harris <guy@alum.mit.edu>
2952 Date: Fri Nov 21 19:32:33 2014 -0800
2956 Change-Id: I3b7340939b8204102bfc7e2e7d83f4d978cf7bad
2957 Reviewed-on: https://code.wireshark.org/review/5437
2958 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2961 Author: Guy Harris <guy@alum.mit.edu>
2962 Date: Fri Nov 21 19:22:54 2014 -0800
2964 Split the low-level print stream code into a separate file.
2966 Put the low-level print stream code from epan/print.c into
2967 epan/print_stream.c, leaving the higher-level stuff in print.c
2969 Change-Id: Iae961f168ec655a29f434257b1af0937fca9f025
2970 Reviewed-on: https://code.wireshark.org/review/5436
2971 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2974 Author: Bill Meier <wmeier@newsguy.com>
2975 Date: Wed Nov 19 13:52:52 2014 -0500
2977 README.heuristic: rework example code.
2979 Specifically: show the use of tcp_dissect_pdus()
2980 for a TCP heuristic dissector
2982 Change-Id: I02f184b2c8ef6ed128ef3d0bc59eed759aae54bb
2983 Reviewed-on: https://code.wireshark.org/review/5399
2984 Reviewed-by: Bill Meier <wmeier@newsguy.com>
2987 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2988 Date: Wed Nov 19 21:34:50 2014 +0100
2990 VoIP Call (GTK): Fix Dereference of null pointer found by Clang analyzer
2992 Change-Id: I80029b6238c78dcab83a6a70eca0af5b66e1488d
2993 Reviewed-on: https://code.wireshark.org/review/5401
2994 Reviewed-by: Evan Huus <eapache@gmail.com>
2997 Author: Irene Ruengeler <ruengeler@wireshark.org>
2998 Date: Mon Nov 17 08:51:12 2014 +0100
3000 Add minimize and maximize buttons to the SCTP analysis windows.
3002 As suggested by Jeff Morriss.
3004 Change-Id: Ibe2d30c31d51ab92377d64068527b424a92e8a64
3005 Reviewed-on: https://code.wireshark.org/review/5361
3006 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
3007 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3008 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
3009 Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
3010 Reviewed-by: Evan Huus <eapache@gmail.com>
3013 Author: Michael Mann <mmann78@netscape.net>
3014 Date: Fri Nov 21 10:43:40 2014 -0500
3018 1. Fixed endianess in CANopen dissector.
3019 According to CiA 301, 7.1.1. (p. 26):
3020 "For numerical data types the encoding is little endian style."
3022 2. Fixed NMT type string in CANopen dissector
3023 NMT function code should not display 'EMERGENCY'
3025 3. Fixed time stamp decoding
3027 * Offset increment was too low for data type size
3028 * Decoding of time_stamp_days must equal time_stamp_msec and thus be letohs instead of ntohs. CANopen data is little-endian encoded.
3030 4. Fix: Use correct description string for NMT error control state bits
3031 canopen.nmt_guard.state was faulty named "Node-ID". This was changed to "State".
3033 5. Fix nmt_guard_state value_string array
3034 CiA 301 desribes only 4 valid values. All other were deleted.
3035 0x00 was renamed from 'Initalisation' to 'Boot-up' following CiA301.
3037 6. Shortened EMERGENCY to EMCY
3039 The term EMCY is the standard abbreviation used in CiA standard for Emergency service.
3041 7. Fix: Allow SYNC and NMT error frames without any payload
3042 NMT node guard remote requests do note have a payload,
3043 SYNC frames only have an optional payload (counter)
3045 If item length is set to -1, decode will cause a 'Malformed Packet' error.
3047 8. Rename MT_NMT_GUARD to MT_NMT_ERR_CTRL which better reflects its scope
3049 Change-Id: I676f9b5f2e4efd8e7c9528fe289e7510c4d43235
3050 Reviewed-on: https://code.wireshark.org/review/5425
3051 Reviewed-by: Michael Mann <mmann78@netscape.net>
3052 Petri-Dish: Michael Mann <mmann78@netscape.net>
3053 Reviewed-by: Evan Huus <eapache@gmail.com>
3056 Author: AndersBroman <anders.broman@ericsson.com>
3057 Date: Fri Nov 21 15:54:59 2014 +0100
3059 Replace tvb_length()
3061 Change-Id: I0b5ad4d588f0b658abaf3892d08d6520ecd2f645
3062 Reviewed-on: https://code.wireshark.org/review/5431
3063 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3066 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3067 Date: Thu Nov 20 19:35:25 2014 -0500
3069 Remove some leftover debug printfs.
3071 Change-Id: I9f4c7f71ae403059a2a236ba095b21753f7938fa
3072 Reviewed-on: https://code.wireshark.org/review/5417
3073 Reviewed-by: Michael Mann <mmann78@netscape.net>
3076 Author: Michał Orynicz <michal.orynicz@tieto.com>
3077 Date: Thu Nov 20 13:16:33 2014 +0100
3079 Fix for very big pid and tid numbers in logcat_text
3081 There can be no space after pid colon if tid is big enough
3082 in logcat long format.
3084 Change-Id: I8e03e78c88e4bef1a5fdb3a04b77f58fa7d055bc
3085 Reviewed-on: https://code.wireshark.org/review/5411
3086 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
3089 Author: Michał Orynicz <michal.orynicz@tieto.com>
3090 Date: Thu Nov 20 13:09:31 2014 +0100
3092 Move text logcat regex strings to shared header
3094 To avoid further duplication of work and bugfixing,
3095 move regex strings to wiretap/logcat_text.h and include
3096 this file in epan/dissectors/packet-logcat-text.c
3098 Change-Id: I82773cda0e3240844139b104c68738ec82788014
3099 Reviewed-on: https://code.wireshark.org/review/5410
3100 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
3101 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3102 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
3105 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3106 Date: Thu Nov 20 20:30:32 2014 -0500
3108 Fix the build: dissect_a21_ie_common() can't be static any more.
3110 Change-Id: I93db6bc35aef9c36a294e530730cd295ad6851ef
3111 Reviewed-on: https://code.wireshark.org/review/5419
3112 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
3115 Author: Guy Harris <guy@alum.mit.edu>
3116 Date: Thu Nov 20 16:57:24 2014 -0800
3118 Include "ws_symbol_export.h" to make sure WS_DLL_PUBLIC is defined.
3120 Wrap the declaration for C++ while we're at it.
3122 Change-Id: Ifcc1b47bab139f5fb8da8c3dd4f20b1ebb99739e
3123 Reviewed-on: https://code.wireshark.org/review/5418
3124 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3127 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3128 Date: Thu Nov 20 20:04:42 2014 +0100
3130 A21: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
3132 Change-Id: Ib2f3816892f1682c175b0dee3c80725caebf3d4d
3133 Reviewed-on: https://code.wireshark.org/review/5415
3134 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3137 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3138 Date: Thu Nov 20 20:04:26 2014 +0100
3140 EPL: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
3142 Change-Id: I40de0c8c2bd40f18a33947367fdeec5a22a3093a
3143 Reviewed-on: https://code.wireshark.org/review/5414
3144 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3147 Author: Michael Mann <mmann78@netscape.net>
3148 Date: Mon Nov 17 20:04:30 2014 -0500
3150 Eliminate proto_tree_add_text from some dissectors.
3152 Change-Id: Ib160211198ca02f7eacf29d04568628c11f208a5
3153 Reviewed-on: https://code.wireshark.org/review/5407
3154 Petri-Dish: Michael Mann <mmann78@netscape.net>
3155 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3156 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3157 Reviewed-by: Michael Mann <mmann78@netscape.net>
3160 Author: AndersBroman <anders.broman@ericsson.com>
3161 Date: Thu Nov 20 16:07:55 2014 +0100
3163 Replace tvb_length...() calls.
3165 Change-Id: Idda7cd56a12b36d18774a1fe324c69eb8f5e4330
3166 Reviewed-on: https://code.wireshark.org/review/5412
3167 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3170 Author: Bill Meier <wmeier@newsguy.com>
3171 Date: Tue Nov 18 22:53:32 2014 -0500
3173 uat: tighten up dec/hex uat field validity checking
3176 - Use the proper code for testing strtol() result;
3177 - Also: Values greater than 32-bits treated as an error
3178 (on LP64 architectures);
3180 Change-Id: I56e8e734fbb9a22dbd9ed4112e24327ffd7ee3c0
3181 Reviewed-on: https://code.wireshark.org/review/5394
3182 Reviewed-by: Bill Meier <wmeier@newsguy.com>
3183 Petri-Dish: Bill Meier <wmeier@newsguy.com>
3184 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3185 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3188 Author: Michael Mann <mmann78@netscape.net>
3189 Date: Sun Nov 16 15:15:52 2014 -0500
3191 Give better hints as to where the "expert info" fields go.
3193 Change-Id: I9b1cee43ef9280504745b136b87507c2b6bb5369
3194 Reviewed-on: https://code.wireshark.org/review/5406
3195 Reviewed-by: Michael Mann <mmann78@netscape.net>
3198 Author: Pascal Quantin <pascal.quantin@gmail.com>
3199 Date: Wed Nov 19 20:10:15 2014 +0100
3201 IrDA: always initialize buffer before accessing it
3204 Change-Id: I8e54f750b70076758d5fd0d7f35f9c782f5d0bf9
3205 Reviewed-on: https://code.wireshark.org/review/5398
3206 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
3207 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
3208 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3209 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3212 Author: Balint Reczey <balint@balintreczey.hu>
3213 Date: Fri Nov 14 21:39:00 2014 +0100
3215 Fix global plugin folder when it is set as an absolute path
3217 This fixes regression in creating Debian packages caused by
3218 80b36cdbde90ac9639938a14e8fd90a79602666a
3220 Change-Id: I46702ad4c9a11ce317da7ef664c84e1f22d3f709
3221 Reviewed-on: https://code.wireshark.org/review/5316
3222 Reviewed-by: Evan Huus <eapache@gmail.com>
3223 Petri-Dish: Evan Huus <eapache@gmail.com>
3224 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
3227 Author: Michał Orynicz <michal.orynicz@tieto.com>
3228 Date: Thu Nov 20 09:55:40 2014 +0100
3230 Fix text logcat for changes in android L
3232 In L, in line "-- beginning of /<buffer>" the "/" was removed.
3233 This commit accomodates text logcat to that change.
3235 Change-Id: I4cbfadf5a8169589f2848ce1a5793cea593ba459
3236 Reviewed-on: https://code.wireshark.org/review/5405
3237 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
3238 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3239 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
3242 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3243 Date: Wed Nov 19 19:18:39 2014 +0100
3245 MIP6: Access network identifier option is not full decoded
3247 * Add subtype Geo Location (2) and Operator Identifier (3)
3248 * Use also offset to calculate the length
3249 * Remove proto_tree_add_text
3251 Issue reported by Ravindranath K M
3254 Change-Id: I9ad81ece856df134f3a706ad774d34e638cb5c94
3255 Reviewed-on: https://code.wireshark.org/review/5397
3256 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3259 Author: Guy Harris <guy@alum.mit.edu>
3260 Date: Wed Nov 19 16:53:36 2014 -0800
3262 White space tweaking to match what's in Samba git.
3264 (Samba git also needs some white space tweaking; this only changes the
3265 cases where we're not obviously "better".)
3267 Change-Id: Iafb9cf8fea67b898b12850a7793806e3fccb39ac
3268 Reviewed-on: https://code.wireshark.org/review/5403
3269 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3272 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3273 Date: Wed Nov 19 21:35:14 2014 +0100
3275 SBC: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
3277 Change-Id: I6ac8e0eed88e78521f7d5623b9afdb6a42900ede
3278 Reviewed-on: https://code.wireshark.org/review/5402
3279 Reviewed-by: Michael Mann <mmann78@netscape.net>
3282 Author: Gerald Combs <gerald@wireshark.org>
3283 Date: Wed Nov 19 09:03:44 2014 -0800
3285 voip_calls: Fix tap callbacks.
3287 We don't need to call the VoIP tap reset and draw callbacks repeately.
3288 Do so only once from the RTP tap. Packet callbacks should return a
3291 Clean up some function names and make some static.
3293 Change-Id: I5c934ce8ce7f279861e8cc73235bbfc27d7fe622
3294 Reviewed-on: https://code.wireshark.org/review/5396
3295 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3298 Author: Bill Meier <wmeier@newsguy.com>
3299 Date: Wed Nov 19 11:25:17 2014 -0500
3301 [pedantic] Replace usage of 'long' and 'long long'
3303 Change-Id: I78fc82c1a83eb04d78a11fc76710c92dfc916208
3304 Reviewed-on: https://code.wireshark.org/review/5395
3305 Reviewed-by: Bill Meier <wmeier@newsguy.com>
3308 Author: Michael Tüxen <tuexen@wireshark.org>
3309 Date: Wed Nov 19 15:57:48 2014 +0100
3311 Add support for PAD chunks.
3313 Add support for PAD chunks as defined in RFC 4820.
3315 Change-Id: I66a83d5d133429154fe40ccef26687c8350463cf
3316 Reviewed-on: https://code.wireshark.org/review/5393
3317 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
3320 Author: Michael Tüxen <tuexen@wireshark.org>
3321 Date: Wed Nov 19 15:35:36 2014 +0100
3323 Fix the length reported as value length.
3325 The length reported as value length for unknown chunks
3326 was actually the chunk length. Therefore it was off by 4.
3328 Change-Id: Ieea79d2c51b4729fc139395174625d1f362d1ee5
3329 Reviewed-on: https://code.wireshark.org/review/5392
3330 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
3333 Author: Michael Mann <mmann78@netscape.net>
3334 Date: Sun Nov 16 13:10:37 2014 -0500
3336 Eliminate proto_tree_add_text from packet-mate.c
3338 Change-Id: I3f4b3eb23b91b219df373b3012fbefa63abfa4d3
3339 Reviewed-on: https://code.wireshark.org/review/5350
3340 Petri-Dish: Michael Mann <mmann78@netscape.net>
3341 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3342 Reviewed-by: Michael Mann <mmann78@netscape.net>
3345 Author: Graham Bloice <graham.bloice@trihedral.com>
3346 Date: Tue Nov 18 15:59:44 2014 +0000
3348 Remove Windows linker flags from the CMake link flags test as the
3349 test doesn't actually pass the flags to the VS linker.
3351 Change-Id: I5d546afcb80a49e39143078bc8f0855b0ba0f7e8
3352 Reviewed-on: https://code.wireshark.org/review/5384
3353 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
3354 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3355 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
3358 Author: Stig Bjørlykke <stig@bjorlykke.org>
3359 Date: Thu Oct 16 13:58:58 2014 +0200
3361 Wiretap: Added file_seek SEEK_END support.
3363 This is needed for Lua File:seek("end").
3365 Change-Id: I28fb23f2f29ca8083c77bf065db8816e039ae5a1
3366 Reviewed-on: https://code.wireshark.org/review/4722
3367 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
3368 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
3369 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
3370 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3371 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3374 Author: Gerald Combs <gerald@wireshark.org>
3375 Date: Tue Nov 18 13:13:35 2014 -0800
3377 voip_calls: Regression fixes.
3379 Fix struct initialization logic. Clear a GQueue instead of deleting it.
3380 Don't crash if we have no sequence diagram items. Make sure we show all
3381 flows and not just invites. Zero allocated memory in a couple of places.
3383 Change-Id: Ia5bb3ba57cf625de4b554b354e098aa0361dff28
3384 Reviewed-on: https://code.wireshark.org/review/5390
3385 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3388 Author: Martin Kaiser <wireshark@kaiser.cx>
3389 Date: Sun Nov 16 19:09:57 2014 +0200
3393 Change-Id: If618b0c3dc0502f5a31dcc580b9116daacb40239
3394 Reviewed-on: https://code.wireshark.org/review/5389
3395 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
3396 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
3399 Author: Sergey Avseyev <sergey.avseyev@gmail.com>
3400 Date: Tue Nov 18 21:11:22 2014 +0300
3402 Update Couchbase dissector:
3404 * Register new commands:
3406 * 0x5d: DCP_BUFFER_ACKNOWLEDGEMENT
3408 * 0x5f: DCP_RESERVED4
3410 Change-Id: I22d8eb8f6628e07b2e2ab2bc137688329eead1be
3411 Reviewed-on: https://code.wireshark.org/review/5385
3412 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3415 Author: Pascal Quantin <pascal.quantin@gmail.com>
3416 Date: Mon Nov 17 22:49:24 2014 +0100
3418 SPDY: do not try to access an uninitialized tvb
3420 Coming when data length = 0
3423 Change-Id: Ibd0730be661d966aa0429480dba97ed7d3e5c471
3424 Reviewed-on: https://code.wireshark.org/review/5377
3425 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3428 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3429 Date: Thu Oct 30 09:16:51 2014 +0100
3431 802.11: Remove proto_tree_add_text
3433 Change-Id: I40d351e3317ff7e207e5c68a39aaedb73faf54f9
3434 Reviewed-on: https://code.wireshark.org/review/5281
3435 Reviewed-by: Michael Mann <mmann78@netscape.net>
3436 Petri-Dish: Michael Mann <mmann78@netscape.net>
3437 Tested-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3438 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3441 Author: Guy Harris <guy@alum.mit.edu>
3442 Date: Mon Nov 17 21:16:19 2014 -0800
3446 Change-Id: Icc474748f755c21d281620c3b0f5d4d90f09223b
3447 Reviewed-on: https://code.wireshark.org/review/5380
3448 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3451 Author: Pascal Quantin <pascal.quantin@gmail.com>
3452 Date: Mon Nov 17 23:22:08 2014 +0100
3454 MIPv6: display Experimental Mobility Message Data as such
3457 Change-Id: I9b16f503418d7464234be3c772b5dae3fb5eb7a9
3458 Reviewed-on: https://code.wireshark.org/review/5378
3459 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3460 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
3461 Reviewed-by: Michael Mann <mmann78@netscape.net>
3464 Author: Gerald Combs <gerald@wireshark.org>
3465 Date: Mon Nov 17 16:43:39 2014 -0800
3467 voip_calls: Move to ui.
3469 Move voip_calls.[ch] to ui. Add callbacks to voip_calls_tapinfo_t.
3470 Remove unused function definitions.
3472 Change-Id: Ib12db7053d53afa81ef2a66dc0cfe681bc624dd2
3473 Reviewed-on: https://code.wireshark.org/review/5379
3474 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3477 Author: Gerald Combs <gerald@zing.org>
3478 Date: Sun Nov 16 11:32:11 2014 -0800
3480 voip_calls: Get rid of global variables.
3482 Move the members of voip_rtp_tapinfo_t to voip_calls_tapinfo_t. Move a
3483 bunch of formerly static variables there as well. Note that we might
3484 want to make them private again at some point. Remove launch_count. It
3485 appeared to be unused.
3487 Wrap the individual registration routines in voip_calls_init_all_taps.
3488 Wrap the removal routines in voip_calls_remove_all_tap_listeners.
3490 Move voip_calls_get_info() to voip_calls_dlg.c. Make it static.
3492 Change-Id: I58f9d91f55cfb5e4b0c048a5a1d5d4b947f4641b
3493 Reviewed-on: https://code.wireshark.org/review/5372
3494 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3495 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3498 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3499 Date: Mon Nov 17 19:10:14 2014 +0100
3501 802.11: Enhance Supported Operating Classes
3503 * Use expert_info to display warning about length (Remove proto_tree_add_text)
3505 Change-Id: I36ce6b6fc1138c53621da4913e23f9f1ceaaca50
3506 Reviewed-on: https://code.wireshark.org/review/5369
3507 Reviewed-by: Michael Mann <mmann78@netscape.net>
3510 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3511 Date: Mon Nov 17 19:03:46 2014 +0100
3513 802.11: Enhance Extenede Channel Switch Announcement
3515 * Use expert info to display warning about launch (remove proto_tree_add_text)
3516 * Remove a check about Unknown data (Not need)
3518 Change-Id: I3ec1d0f5b955019cfe43141df5f712eb1446dce3
3519 Reviewed-on: https://code.wireshark.org/review/5368
3520 Reviewed-by: Michael Mann <mmann78@netscape.net>
3523 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3524 Date: Mon Nov 17 21:43:36 2014 +0100
3526 H248: Fix Dereference of null pointer found by Clang analyzer
3528 Also fix some indent issue
3530 Change-Id: I262bdddd031fec6a0f91b7172bb2d67be3c33000
3531 Reviewed-on: https://code.wireshark.org/review/5370
3532 Reviewed-by: Michael Mann <mmann78@netscape.net>
3535 Author: Pascal Quantin <pascal.quantin@gmail.com>
3536 Date: Mon Nov 17 21:59:14 2014 +0100
3538 DECT: ensure that bfield_data buffer is always fully initiated
3541 Change-Id: I444bc4ff7e542a8aa5ac8e20bac44a823ac74cfd
3542 Reviewed-on: https://code.wireshark.org/review/5371
3543 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3544 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
3545 Reviewed-by: Michael Mann <mmann78@netscape.net>
3548 Author: Joerg Mayer <jmayer@loplof.de>
3549 Date: Mon Nov 17 21:12:54 2014 +0100
3552 Avoide rebuilding the guides each and every time.
3553 Don't print the single file guides to stdout.
3555 Change-Id: Ie94fc4b24676e9abc7258c4ea1c7fd3049a96fb6
3556 Reviewed-on: https://code.wireshark.org/review/5367
3557 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
3560 Author: Joerg Mayer <jmayer@loplof.de>
3561 Date: Mon Nov 17 21:05:11 2014 +0100
3563 Use ntoh24 instead of less readable and less correct code.
3564 Remove redundant / wrong comments.
3565 Add two small (helpful) comments :-)
3567 Change-Id: I9c5451587d744a8418e6a90139b771a055e93387
3568 Reviewed-on: https://code.wireshark.org/review/5366
3569 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
3572 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3573 Date: Mon Nov 17 17:10:36 2014 +0100
3575 LLDP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
3577 Change-Id: I8c750ed9ad775b9be9d12050d200d7f1b4ddb86e
3578 Reviewed-on: https://code.wireshark.org/review/5365
3579 Reviewed-by: Michael Mann <mmann78@netscape.net>
3582 Author: AndersBroman <anders.broman@ericsson.com>
3583 Date: Mon Nov 17 13:36:17 2014 +0100
3585 [BSSMAP] de_mid() used with wrong length.
3587 Change-Id: Ia64f254d85845ff39eacc7a339fdfa646ff9bb50
3588 Reviewed-on: https://code.wireshark.org/review/5364
3589 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3592 Author: Pascal Quantin <pascal.quantin@gmail.com>
3593 Date: Mon Nov 17 10:44:36 2014 +0100
3595 E212: fix bytes highlighting when dissecting the high nibble variant
3597 Change-Id: I376dcb333f7768242dbdb73313870e1e22d959ff
3598 Reviewed-on: https://code.wireshark.org/review/5362
3599 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3602 Author: Michael Mann <mmann78@netscape.net>
3603 Date: Fri Nov 14 15:12:06 2014 -0500
3605 Eliminate proto_tree_add_text
3607 Also some other cleanup to simplify dissector logic.
3609 Change-Id: Ia84300b7eadafe292361014dd0e565ec250cae44
3610 Reviewed-on: https://code.wireshark.org/review/5311
3611 Reviewed-by: Michael Mann <mmann78@netscape.net>
3612 Petri-Dish: Michael Mann <mmann78@netscape.net>
3613 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3614 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3617 Author: Martin Kaiser <wireshark@kaiser.cx>
3618 Date: Tue Nov 11 21:05:03 2014 +0100
3620 display filter: the body of a range should only be
3621 a string, a field name or another range - not an unparsed element
3624 Change-Id: I126143636c940cc73ed6467660f0a573209e2ae9
3625 Reviewed-on: https://code.wireshark.org/review/5243
3626 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
3627 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
3630 Author: Guy Harris <guy@alum.mit.edu>
3631 Date: Sun Nov 16 18:25:56 2014 -0800
3633 Add tshark -G dissector-tables to dump a list of dissector tables.
3635 That list doesn't show the entries in the dissector tables, just
3636 information about the tables themselves.
3638 Clean up some tshark man page issues while we're at it.
3640 Change-Id: I70beee34110f5c0d58105944dd71105a8400f5ca
3641 Reviewed-on: https://code.wireshark.org/review/5360
3642 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3645 Author: Michael Mann <mmann78@netscape.net>
3646 Date: Fri Nov 14 15:13:05 2014 -0500
3648 Eliminate proto_tree_add_text by formatting field hf_opcua_ByteString in a few places.
3650 Change-Id: I9606aa36b7d7b6bb2ef2e7685e6629163ca83ef7
3651 Reviewed-on: https://code.wireshark.org/review/5312
3652 Reviewed-by: Michael Mann <mmann78@netscape.net>
3653 Petri-Dish: Michael Mann <mmann78@netscape.net>
3654 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3655 Reviewed-by: Evan Huus <eapache@gmail.com>
3658 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3659 Date: Sun Nov 16 12:17:40 2014 -0500
3661 Remove some ununused/unmatched <resources/> tags.
3663 Change-Id: I0f8e4381b27d1defeb5980692823d297d2f48bab
3664 Reviewed-on: https://code.wireshark.org/review/5349
3665 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
3666 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3667 Reviewed-by: Evan Huus <eapache@gmail.com>
3670 Author: Pascal Quantin <pascal.quantin@gmail.com>
3671 Date: Sun Nov 16 21:58:36 2014 +0100
3673 PortableApps: ensure that the personal folder is set to the App directory
3675 Otherwise the portable version ends up loading the user local personal profile
3677 Change-Id: Ib670c065319b0dd9673f239ae9459f6ee530f69e
3678 Reviewed-on: https://code.wireshark.org/review/5351
3679 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3680 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
3681 Reviewed-by: Evan Huus <eapache@gmail.com>
3684 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3685 Date: Sun Nov 16 16:12:40 2014 +0100
3687 BATMAN: fix indent and encoding args
3689 use tabs for indent and use fix-encoding-args tools
3691 Change-Id: I5e066c6cbc429021cf21a55d5ffd5b60718ad5f8
3692 Reviewed-on: https://code.wireshark.org/review/5340
3693 Reviewed-by: Michael Mann <mmann78@netscape.net>
3694 Reviewed-by: Evan Huus <eapache@gmail.com>
3697 Author: Guy Harris <guy@alum.mit.edu>
3698 Date: Sun Nov 16 15:21:12 2014 -0800
3700 Make sure the NLPID appears in the protocol tree.
3702 For protocols for which the NLPID is not considered part of the PDU, put
3703 the NLPID into the protocol tree ourselves.
3706 Change-Id: I2676d1934dd468ec755a6f94d95a23f025ba0f25
3707 Reviewed-on: https://code.wireshark.org/review/5358
3708 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3711 Author: Guy Harris <guy@alum.mit.edu>
3712 Date: Sun Nov 16 14:59:23 2014 -0800
3714 Fix a comment to reflect reality.
3716 Change-Id: I812b0246368266c76f7fe9ef355619603c5d37b0
3717 Reviewed-on: https://code.wireshark.org/review/5357
3718 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3721 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3722 Date: Sun Nov 2 16:15:31 2014 +0100
3724 Add unused-const-variable (enable by default on new clang release)
3726 Change-Id: I1d882e02188ba38ec1b5583c5933d0c92f0539e4
3727 Reviewed-on: https://code.wireshark.org/review/5068
3728 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3729 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3730 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
3733 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3734 Date: Sun Nov 16 16:28:51 2014 +0100
3736 mcast_stream: fix indent (use 4 spaces)
3738 Add also modelines info
3740 Change-Id: Idea65bfa25ce8a379c590074ab89a06f935c6648
3741 Reviewed-on: https://code.wireshark.org/review/5344
3742 Reviewed-by: Michael Mann <mmann78@netscape.net>
3745 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3746 Date: Sun Nov 16 16:42:32 2014 +0100
3748 rtp_stream: fix indent (use 4 spaces)
3750 Add also modelines info
3752 Change-Id: I4c4c6d7e292ba387aacb3f71afcac756b2875847
3753 Reviewed-on: https://code.wireshark.org/review/5345
3754 Reviewed-by: Michael Mann <mmann78@netscape.net>
3757 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3758 Date: Sun Nov 16 16:15:27 2014 +0100
3760 BATMAN: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
3762 Change-Id: I6cfabc18921397002a2303f3511fa51bf5b41956
3763 Reviewed-on: https://code.wireshark.org/review/5341
3764 Reviewed-by: Michael Mann <mmann78@netscape.net>
3767 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3768 Date: Sun Nov 16 16:00:35 2014 +0100
3770 RADIUS: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
3772 Change-Id: I5127b737c0d9db08c61a70bb6c16fef030d39f83
3773 Reviewed-on: https://code.wireshark.org/review/5339
3774 Reviewed-by: Michael Mann <mmann78@netscape.net>
3777 Author: Gerald Combs <gerald@wireshark.org>
3778 Date: Sun Nov 16 08:06:50 2014 -0800
3780 [Automatic manuf, services and enterprise-numbers update for 2014-11-16]
3782 Change-Id: Ie677285f75a7ef0390d93469a4f97eaad813fdc0
3783 Reviewed-on: https://code.wireshark.org/review/5346
3784 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3787 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3788 Date: Sun Nov 16 15:27:06 2014 +0100
3790 btavdtp: Add missing break;
3792 Issue found by Clang Analyzer:
3793 Value stored to 'codec_dissector' is never read
3795 Change-Id: I7a9fc5e3ffd04c77cbbb8d5e5b885d8a29468cfd
3796 Reviewed-on: https://code.wireshark.org/review/5330
3797 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
3800 Author: Michael Mann <mmann78@netscape.net>
3801 Date: Sat Nov 15 21:24:27 2014 -0500
3803 Remove file_type_subtype member from packet_info.
3805 Just pass the necessary data to the frame dissector.
3807 Change-Id: I1a4bab32f7b5e28f4e7707794d71b04dab388908
3808 Reviewed-on: https://code.wireshark.org/review/5328
3809 Reviewed-by: Michael Mann <mmann78@netscape.net>
3810 Petri-Dish: Michael Mann <mmann78@netscape.net>
3811 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3812 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3815 Author: Michael Mann <mmann78@netscape.net>
3816 Date: Sat Nov 15 18:47:06 2014 -0500
3818 "Bubble up" the use of pinfo->circuit_id and pinfo->ctype to make it more obvious where in used in hopes that it can be eliminated through passing dissector data (or methods other than using packet_info)
3820 Change-Id: Ib0e7efc123a3f9c06f58b5579c3c25b18818205c
3821 Reviewed-on: https://code.wireshark.org/review/5326
3822 Reviewed-by: Michael Mann <mmann78@netscape.net>
3823 Petri-Dish: Michael Mann <mmann78@netscape.net>
3824 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3825 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3828 Author: Michael Mann <mmann78@netscape.net>
3829 Date: Sat Nov 15 20:35:51 2014 -0500
3831 Remove ipproto member of packet_info.
3833 All situations can be handled with "shimmed" dissector functions.
3835 Change-Id: Ic85483b32d99d3270b193c9f6b29574d8fad46a8
3836 Reviewed-on: https://code.wireshark.org/review/5327
3837 Reviewed-by: Michael Mann <mmann78@netscape.net>
3838 Petri-Dish: Michael Mann <mmann78@netscape.net>
3839 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3840 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3843 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3844 Date: Fri Nov 14 17:42:44 2014 +0100
3846 DNS: NAPTR RR Replacement Length is incorrect
3848 It seems the Replacement Length field calculated by Wireshark (which Wireshark calls "rReplacement Length"), is the length of the first label of the DNS name in the Replacement, instead of the entire DNS name length.
3853 Change-Id: I8b726f3a3bf316d688a40c3ade100d255ca3be42
3854 Reviewed-on: https://code.wireshark.org/review/5300
3855 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
3858 Author: Gerald Combs <gerald@zing.org>
3859 Date: Sat Nov 15 10:36:16 2014 -0800
3861 VoIP calls: Fixup whitespace.
3863 Set modelines and reindent to match the files in the top-level ui
3866 Change-Id: I7ea221e76a4b0ad3b6bcf7a3c8b4645c16aecbba
3867 Reviewed-on: https://code.wireshark.org/review/5325
3868 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3871 Author: Gerald Combs <gerald@zing.org>
3872 Date: Sat Nov 15 09:18:06 2014 -0800
3874 VoIP calls: Start separating common and GTK+-dependent code.
3876 Remove more calls to voip_calls_get_info. Get rid of the global cfile.
3877 Lowercase more function names.
3879 Change-Id: Ieda779779cce9f05e07c54314bceab4a18bae22f
3880 Reviewed-on: https://code.wireshark.org/review/5324
3881 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3884 Author: Robert Grange <robionekenobi@bluewin.ch>
3885 Date: Sat Nov 15 11:35:09 2014 +0100
3887 paquet-mq: Eliminiate proto_tree_add_text
3889 Eliminate proto_tree_add_text for Expert Info
3890 Improve PCF Parameters numeric value display
3892 Change-Id: Ibc259ba05d0591d434e7638d91d6943101d45305
3893 Reviewed-on: https://code.wireshark.org/review/5080
3894 Reviewed-by: Robert Grange <robionekenobi@bluewin.ch>
3895 Petri-Dish: Michael Mann <mmann78@netscape.net>
3896 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3897 Reviewed-by: Michael Mann <mmann78@netscape.net>
3900 Author: Gerald Combs <gerald@zing.org>
3901 Date: Fri Nov 14 18:43:28 2014 -0800
3903 VoIP calls: Use our tap offsets.
3905 Add convenience functions to convert between tap IDs and tapinfo
3906 pointers. Use them to get rid of some calls to voip_calls_get_info().
3908 Lowercase function names. Remove more exit()s.
3910 Change-Id: I187fdc505bc22cc05edafed9e97ede8279ea53f9
3911 Reviewed-on: https://code.wireshark.org/review/5321
3912 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3915 Author: Guy Harris <guy@alum.mit.edu>
3916 Date: Fri Nov 14 19:37:32 2014 -0800
3918 0.0 is a double, 0.0f is a float.
3920 Change-Id: I882bbda2c579cfd7a1b96ce190541262193405e0
3921 Reviewed-on: https://code.wireshark.org/review/5320
3922 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3925 Author: Gerald Combs <gerald@wireshark.org>
3926 Date: Fri Nov 14 19:30:42 2014 -0800
3930 Change-Id: I5cc67fa320b3241d6793575d59e49160ef40b260
3931 Reviewed-on: https://code.wireshark.org/review/5319
3932 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3935 Author: Gregor Miernik <gregor.miernik@hytec.de>
3936 Date: Tue Nov 4 11:53:39 2014 +0100
3938 LLDP: Dissector for Hytec specific extensions added
3940 It provides dissection of objects with additional neighbor and link information
3941 defined by Hytec (pcap example available on wiki.wireshark.org/HYTEC).
3942 Also OUI of "Hytec Geraetebau GmbH" added.
3944 Change-Id: I92119e46fd5f4c4b385ac3df3170a4766fe056b7
3945 Reviewed-on: https://code.wireshark.org/review/5107
3946 Petri-Dish: Michael Mann <mmann78@netscape.net>
3947 Reviewed-by: Michael Mann <mmann78@netscape.net>
3950 Author: Gerald Combs <gerald@wireshark.org>
3951 Date: Fri Nov 14 13:53:58 2014 -0800
3953 VoIP calls: Clean up tap registration and removal.
3955 Start moving away from a global voip_calls_tapinfo_t. Pass the
3956 voip_calls_tapinfo_t struct address to each registration and removal
3959 All of the tap registration and removal routines are called at the same
3960 time. Replace the individual registration tracking booleans with a
3963 Calling exit() from the GUI is rude. Don't do that.
3965 Change-Id: I9535002e2905a45a8cfc9643590b5d2d360ffc24
3966 Reviewed-on: https://code.wireshark.org/review/5318
3967 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3970 Author: Michael Mann <mmann78@netscape.net>
3971 Date: Fri Nov 14 15:18:23 2014 -0500
3973 Eliminate proto_tree_add_text from some plugin dissector files.
3975 Change-Id: Ib2d900833a8763307be6b1cfc8df20d7019d2706
3976 Reviewed-on: https://code.wireshark.org/review/5313
3977 Petri-Dish: Michael Mann <mmann78@netscape.net>
3978 Reviewed-by: Michael Mann <mmann78@netscape.net>
3981 Author: Gerald Combs <gerald@wireshark.org>
3982 Date: Fri Nov 14 13:15:38 2014 -0800
3984 VoIP calls tap ID cleanup.
3986 Remove all of the public dummy members from voip_calls_tapinfo_t. Use
3987 pointer arithmetic to generate private, unique IDs instead.
3989 We weren't removing the SUA listener. Do so. Use the correct M3UA ID.
3991 Change-Id: I8e8cdb6addbc4868aebc004be20a2f57b4acf75b
3992 Reviewed-on: https://code.wireshark.org/review/5315
3993 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3994 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3997 Author: Guy Harris <guy@alum.mit.edu>
3998 Date: Fri Nov 14 15:59:38 2014 -0800
4000 Do the "-z help" processing separately, and do it for Wireshark as well.
4002 Yes, Wireshark does a bunch of GUI stuff, and then takes the window down
4003 before printing the help, but the same is true for some command-line
4004 error messages as well.
4006 Change-Id: Id501468416c83308e4c0a9e7a66116d8d33a9d84
4007 Reviewed-on: https://code.wireshark.org/review/5317
4008 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4011 Author: Guy Harris <guy@alum.mit.edu>
4012 Date: Fri Nov 14 12:29:04 2014 -0800
4014 It's not missing, it's passed on.
4016 Change-Id: Id1b1c7501f357667abb961948afdd816e13a7ad3
4017 Reviewed-on: https://code.wireshark.org/review/5314
4018 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4021 Author: Guy Harris <guy@alum.mit.edu>
4022 Date: Fri Nov 14 12:24:51 2014 -0800
4024 Update Debian symbol files.
4026 Change-Id: Iee66cf87d742780740b572b39c8ecf94f93dc142
4027 Reviewed-on: https://code.wireshark.org/review/5310
4028 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4031 Author: Guy Harris <guy@alum.mit.edu>
4032 Date: Fri Nov 14 12:21:12 2014 -0800
4034 Add a name field to tap_param, for use in error messages.
4036 Change-Id: Ia4317b61ff30e269eba0ee2ea2c46f1668544b1b
4037 Reviewed-on: https://code.wireshark.org/review/5309
4038 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4041 Author: Guy Harris <guy@alum.mit.edu>
4042 Date: Fri Nov 14 12:05:31 2014 -0800
4044 The registered -z parameter string shouldn't end with a comma.
4046 If it ends with a comma, then, if you don't provide any parameters, you
4047 get a "no such -z statistic" message followed by a list of available
4050 If it doesn't end with a comma, then, if you don't provide any
4051 parameters *and* a parameter is required, you get a usage message, which
4052 is more useful - and, in many of those cases, a parameter *isn't*
4055 Change-Id: I81275ea41ad4611d8210ca3cb07c09f0abde58f2
4056 Reviewed-on: https://code.wireshark.org/review/5308
4057 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4060 Author: Guy Harris <guy@alum.mit.edu>
4061 Date: Fri Nov 14 11:25:04 2014 -0800
4063 Add an optional flag and a type for UUID parameters for stat taps.
4065 For future use, with common code to parse the -z argument.
4067 Change-Id: Ib2a11bd5c91b5ac48ced2cd2d112b97c301ff72a
4068 Reviewed-on: https://code.wireshark.org/review/5307
4069 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4072 Author: Stephen Fisher <sfisher@sdf.org>
4073 Date: Fri Nov 14 12:17:36 2014 -0700
4075 Update my e-mail address again.
4077 Change-Id: I0083bbf84658dbb0d4cef91e9e8f5855b8a2ba4f
4078 Reviewed-on: https://code.wireshark.org/review/5306
4079 Reviewed-by: Stephen Fisher <sfisher@sdf.org>
4082 Author: Guy Harris <guy@alum.mit.edu>
4083 Date: Fri Nov 14 10:55:50 2014 -0800
4085 There's nothing GTK+ about TShark.
4087 Remove gtk from routine names in CLI taps.
4089 Change-Id: I0846da9b1e8119ed966b441cb1ca0ce1820fd1c8
4090 Reviewed-on: https://code.wireshark.org/review/5305
4091 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4094 Author: Guy Harris <guy@alum.mit.edu>
4095 Date: Fri Nov 14 10:51:40 2014 -0800
4097 Rename stat_cmd_args.[ch] to stat_tap_ui.[ch].
4099 The intent is to handle more than just command-line arguments; reflect that.
4101 Change-Id: Ia10efda85a9d11c6579d1bec6f789cee30d9e825
4102 Reviewed-on: https://code.wireshark.org/review/5304
4103 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4106 Author: Irene Ruengeler <ruengeler@wireshark.org>
4107 Date: Fri Nov 14 10:06:51 2014 +0100
4109 Allow SCTP graphs to resize with the window they're in.
4112 Change-Id: I3304bd36945619aeb405c74917f21de3faa3fcbb
4113 Reviewed-on: https://code.wireshark.org/review/5284
4114 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
4117 Author: Guy Harris <guy@alum.mit.edu>
4118 Date: Fri Nov 14 10:42:26 2014 -0800
4120 tap_ui -> stat_tap_ui.
4122 The old routine had stat_ in the name, as the expectation was that they
4123 were for statistics taps; that's still the expectation, so have stat_ in
4124 the data structure and routine names.
4126 Change-Id: Ic98d011012b8641173d41fa0ec4f4e625614370a
4127 Reviewed-on: https://code.wireshark.org/review/5303
4128 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4131 Author: Guy Harris <guy@alum.mit.edu>
4132 Date: Fri Nov 14 10:35:42 2014 -0800
4134 Use G_GUINT64_FORMAT to format a guint64.
4136 A 64-bit integer isn't necessarily a long, it might be a long long. Use
4137 G_GUINT64_FORMAT to format it.
4139 Make it a guint64 while we're at it - the field is a FT_GUINT64.
4141 Change-Id: I7ee855905ea77347576005441824b1c4630f5659
4142 Reviewed-on: https://code.wireshark.org/review/5302
4143 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4146 Author: Guy Harris <guy@alum.mit.edu>
4147 Date: Fri Nov 14 10:31:04 2014 -0800
4149 For tap UIs, register a list of parameters and some menu information.
4151 The intent here is to centralize more UI information so that we can move
4152 more tap UI stuff to common code. This is a beginning.
4154 Change-Id: Ic35ac0c01bc7b942aab88177db4065847a5e6c30
4155 Reviewed-on: https://code.wireshark.org/review/5301
4156 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4159 Author: Bill Meier <wmeier@newsguy.com>
4160 Date: Wed Nov 12 23:38:40 2014 -0500
4162 hiqnet: Improve dissection for hiqnet over TCP or UDP
4164 -- Use tcp_dissect_pdus() for hiqnet over tcp so as to properly
4165 handle hiqnet PDUS is a TCP stream of data;
4167 -- Handle possible multiple hiqnet PDUs in a UDP payload.
4169 -- Add Fixme: re multiple hiqnet PDUs in a frame.
4171 Change-Id: I3527c6ea13571d16bcf23dd3771d0a89734a7c5a
4172 Reviewed-on: https://code.wireshark.org/review/5267
4173 Reviewed-by: Raphaël Doursenaud <rdoursenaud@free.fr>
4174 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4177 Author: Bill Meier <wmeier@newsguy.com>
4178 Date: Wed Nov 12 22:04:37 2014 -0500
4180 hiqnet: Simplify code somewhat; Adjust the "names" and display of certain fields.
4182 Specifically: Use proto_tree_add_bitmask() to show the "flags" and
4183 "categories" bitfields (instead of building the fields
4185 The bitfield display changed as follows:
4186 - A bitfield with all bits=0 will have a detailed
4187 dissection tree; (for both 'flags' & 'categories');
4188 - The 'categories' individual bitfields are now
4189 displayed as FT_BOOLEAN (not FT_UINT32).
4191 Change-Id: Icd35698aae492b81b340d08030e6a1563f1640ae
4192 Reviewed-on: https://code.wireshark.org/review/5266
4193 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4196 Author: AndersBroman <anders.broman@ericsson.com>
4197 Date: Fri Nov 14 15:39:45 2014 +0100
4199 [S1AP) Wrong tree used
4200 s1ap.cnf:547:14: error: variable 'subtree' set but not used
4202 Change-Id: I84a345709b1ef9688f3f1a4e876a75dd575c1c2e
4203 Reviewed-on: https://code.wireshark.org/review/5299
4204 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4207 Author: AndersBroman <anders.broman@ericsson.com>
4208 Date: Fri Nov 14 14:53:02 2014 +0100
4210 [S1AP] Let the A21 dissector do further dissection of Cdma2000SectorID
4212 Change-Id: I8c503acf6860b34d24769cdf981dcaeea4667ffb
4213 Reviewed-on: https://code.wireshark.org/review/5298
4214 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4217 Author: Michal Labedzki <michal.labedzki@tieto.com>
4218 Date: Fri Nov 14 13:39:29 2014 +0100
4220 Fix declaration in btavrcp
4222 Change-Id: I47e4ad2baa7ca4c48e8c0eea472e568fc06d3386
4223 Reviewed-on: https://code.wireshark.org/review/5297
4224 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4227 Author: Michal Labedzki <michal.labedzki@tieto.com>
4228 Date: Wed Nov 12 12:00:46 2014 +0100
4230 Bluetooth: Ubertooth: Update to the latest firmware
4233 - add some assign numbers
4234 - implement new type of usb_rx_packet: LE_PROMISC
4236 Change-Id: Iffe01a50f873221c695f16a76c1954d6c82d73df
4237 Reviewed-on: https://code.wireshark.org/review/5289
4238 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
4239 Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
4240 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4241 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4244 Author: AndersBroman <anders.broman@ericsson.com>
4245 Date: Fri Nov 14 12:54:33 2014 +0100
4247 [BSSMAP] Handle vendor specific encoding of "Layer 3 Message Contents".
4249 Change-Id: I351bc0a6a8ae636b2f888a80f61e526096a61b64
4250 Reviewed-on: https://code.wireshark.org/review/5295
4251 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4254 Author: Pascal Quantin <pascal.quantin@gmail.com>
4255 Date: Fri Nov 14 10:07:52 2014 +0100
4257 NAS EPS: fix dissection of APN AMBR IE when first byte is set to 0xFE
4260 Change-Id: I0f359639d5836f557370ab6d6aad45faa4417b6e
4261 Reviewed-on: https://code.wireshark.org/review/5285
4262 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
4263 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4264 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4265 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4268 Author: Michal Labedzki <michal.labedzki@tieto.com>
4269 Date: Sun Nov 2 18:55:40 2014 +0100
4271 Translations: Update Polish translation
4273 All messages are translated now.
4275 Tłumaczenie Wiresharka jest teraz kompletne. Zachęcam do testowania
4278 Change-Id: Iaffb2e581c765b5b3dff7750f878e6391539ebd6
4279 Reviewed-on: https://code.wireshark.org/review/5293
4280 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4283 Author: Michal Labedzki <michal.labedzki@tieto.com>
4284 Date: Wed Nov 12 11:57:12 2014 +0100
4286 Bluetooth: A2DP: Add AVRCP song position indicator
4288 "sbc.avrcp_song_position" can be used to determine time synchronization
4289 between AVRCP and A2DP. It is updated on every
4290 AVRCP PlaybackPositionChanged. Also provide version for aptx.
4292 Change-Id: I48cd49f0fee54131a738290e2a70a24d33ba1d22
4293 Reviewed-on: https://code.wireshark.org/review/5290
4294 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4297 Author: Michal Labedzki <michal.labedzki@tieto.com>
4298 Date: Thu Nov 13 10:52:16 2014 +0100
4300 Qt: Fix non-translate-able text
4302 Change-Id: I8c2376117ca1ac92c341ba938929af2d13e23f72
4303 Reviewed-on: https://code.wireshark.org/review/5291
4304 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4307 Author: Michal Labedzki <michal.labedzki@tieto.com>
4308 Date: Thu Nov 13 19:42:36 2014 +0100
4312 Change-Id: Idc2b945ac3bd5de961cc9c581398dc12f6831070
4313 Reviewed-on: https://code.wireshark.org/review/5292
4314 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4317 Author: Michal Labedzki <michal.labedzki@tieto.com>
4318 Date: Fri Nov 7 15:41:29 2014 +0100
4320 Bluetooth: AVRCP: Improve command/response trancing
4322 Make command/response tracking field filterable and jumpable.
4324 Change-Id: Ib0dfc9ea9954f8d29d06ceda3d44a7f95c94bc53
4325 Reviewed-on: https://code.wireshark.org/review/5288
4326 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4329 Author: Michal Labedzki <michal.labedzki@tieto.com>
4330 Date: Fri Nov 7 10:47:33 2014 +0100
4332 Bluetooth: AVRCP: Fix swappend SongPosition and SongLength
4334 SongPosition and SongLength are swapped in Info column. Fix it.
4336 Change-Id: I4c9bece51dbfe62885e8426a8aef07f336670099
4337 Reviewed-on: https://code.wireshark.org/review/5287
4338 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4341 Author: Michal Labedzki <michal.labedzki@tieto.com>
4342 Date: Mon Nov 3 10:14:28 2014 +0100
4344 Bluetooth: AVDTP: Add possibility to force decode as APT-X
4346 Change-Id: Id99647846c9bc7666f33938c811358576353390d
4347 Reviewed-on: https://code.wireshark.org/review/5286
4348 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
4351 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4352 Date: Wed Nov 12 16:40:02 2014 +0100
4354 dtd_preparse : fix indent (Use tabs)
4356 Change-Id: Iec6ef7109ccea8a164db4f62af9fae1dceba6ae6
4357 Reviewed-on: https://code.wireshark.org/review/5282
4358 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4361 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4362 Date: Wed Nov 12 17:10:40 2014 +0100
4364 Gtk Utils: fix unknown command tag name 'parm'; did you mean 'param'? (-Wdocumentation)
4366 Change-Id: I89f242bf916d22e0a4a665696ec3fe5ee02b8a1f
4367 Reviewed-on: https://code.wireshark.org/review/5283
4368 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4371 Author: Michael Mann <mmann78@netscape.net>
4372 Date: Thu Nov 13 20:37:46 2014 -0500
4374 Multipath TCP checksum requires M flag set as well as enough option length.
4377 Change-Id: I8d9874a2c0a6b98497d43804bcf27a8c7e152a9b
4378 Reviewed-on: https://code.wireshark.org/review/5275
4379 Reviewed-by: Michael Mann <mmann78@netscape.net>
4380 Petri-Dish: Michael Mann <mmann78@netscape.net>
4381 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4384 Author: Michael Mann <mmann78@netscape.net>
4385 Date: Thu Nov 13 22:38:54 2014 -0500
4387 Always create a subtree for Mobility options, even if it doesn't have a specific dissection function.
4390 Change-Id: Ic4d52485a6bd96f906b4a0d61b75a31bfad4e8f8
4391 Reviewed-on: https://code.wireshark.org/review/5276
4392 Reviewed-by: Michael Mann <mmann78@netscape.net>
4395 Author: Ryan Doyle <ryan@doylenet.net>
4396 Date: Wed Nov 12 20:36:49 2014 +1100
4398 Dissector for elasticsearch protocol
4400 Provides dissection for the elasticsearch protocol. This includes full
4401 dissection of the multicast discovery protocol, the HTTP query interface
4402 and partial dissection of the binary protocol.
4404 Change-Id: I738fb498976e44fa05168c2bc3a7e842a9e96df9
4405 Reviewed-on: https://code.wireshark.org/review/4948
4406 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4409 Author: Sven Eckelmann <sven@open-mesh.com>
4410 Date: Wed Oct 1 18:26:12 2014 +0200
4412 batadv: Add dissector support for batadv v15
4414 The packet format for batman-adv v15 supports:
4416 * Complete reordered packet type ids
4418 * type-version-length-value data containers
4419 * new types for coding packets and unicast transfer of TVLVs
4420 * dropped packet types for vis, translation table query and roaming
4421 * reordered packet formats
4422 * transparent fragmentation of batadv packets
4424 Change-Id: I9e6733f9dd6b54eeecda19cf570599161d28b46e
4425 Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
4426 Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
4427 Reviewed-on: https://code.wireshark.org/review/5175
4428 Petri-Dish: Michael Mann <mmann78@netscape.net>
4429 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4430 Reviewed-by: Michael Mann <mmann78@netscape.net>
4433 Author: Lukas Emersberger <lukas.emersberger@br-automation.com>
4434 Date: Fri Oct 17 14:13:06 2014 +0200
4436 epl: Duplicated Frames
4438 Remake of the duplicated frames filter with
4441 Change-Id: I7c8694b5ae69c919b866bbc661bad5e3f0a3e1d7
4442 Reviewed-on: https://code.wireshark.org/review/4773
4443 Reviewed-by: Roland Knall <rknall@gmail.com>
4444 Petri-Dish: Michael Mann <mmann78@netscape.net>
4445 Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
4446 Reviewed-by: Michael Mann <mmann78@netscape.net>
4449 Author: Guy Harris <guy@alum.mit.edu>
4450 Date: Thu Nov 13 00:43:17 2014 -0800
4452 hf_cc_loss is supposed to be a floating-point value, divided by 65535.
4454 That's what the code did when it used proto_tree_add_text(); make it do
4455 so now. That squelches a run-time error.
4457 Reformat the script-added hf_ values while we're at it.
4459 Change-Id: I48d16280c523faa3b266e8df37f5e0e0b2827712
4460 Reviewed-on: https://code.wireshark.org/review/5270
4461 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4464 Author: Guy Harris <guy@alum.mit.edu>
4465 Date: Wed Nov 12 21:22:05 2014 -0800
4467 Get rid of spaces before tabs.
4469 Change-Id: I70ff250a905ac578d7e3afc63a82a5fcb3983608
4470 Reviewed-on: https://code.wireshark.org/review/5269
4471 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4474 Author: Michael Mann <mmann78@netscape.net>
4475 Date: Sun Nov 9 21:13:38 2014 -0500
4477 Add dissector table for sFlow header dissection.
4479 Change-Id: I189a5b2d5f769395fa5e387f8be49b81903fb252
4480 Reviewed-on: https://code.wireshark.org/review/5262
4481 Reviewed-by: Michael Mann <mmann78@netscape.net>
4482 Petri-Dish: Michael Mann <mmann78@netscape.net>
4483 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4484 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4487 Author: Guy Harris <guy@alum.mit.edu>
4488 Date: Wed Nov 12 21:19:41 2014 -0800
4490 Handle duplicate attribute and TLV entries specially.
4492 For attributes, handle them the same way we handle duplicate vendors.
4494 For TLVs, ignore duplicates; they shouldn't happen.
4496 Change-Id: Ie968478c40a9b7848fa8ea25b144eda8656e5874
4497 Reviewed-on: https://code.wireshark.org/review/5268
4498 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4501 Author: Michael Mann <mmann78@netscape.net>
4502 Date: Wed Nov 5 23:07:35 2014 -0500
4504 Eliminate proto_tree_add_text for some dissectors.
4506 Change-Id: Ide14bcac0b1563bee4260ac9c1a280ba99e97e71
4507 Reviewed-on: https://code.wireshark.org/review/5261
4508 Reviewed-by: Michael Mann <mmann78@netscape.net>
4509 Petri-Dish: Michael Mann <mmann78@netscape.net>
4510 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4511 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4514 Author: Guy Harris <guy@alum.mit.edu>
4515 Date: Wed Nov 12 19:01:26 2014 -0800
4517 Handle new vendors and changes to vendors differently.
4519 If, when adding a new vendor, we already find a vendor with the given
4520 ID, don't bother adding it to the vendors-by-ID table with the same ID,
4521 and, if and only if the vendor name has changed, remove it from the
4522 vendors-by-name table, free the old name, replace it with the new name,
4523 and, add it back to the vendors-by-name table with the new name.
4526 Change-Id: I43ebcb57c742563157c71b01ebc0b35797a408e1
4527 Reviewed-on: https://code.wireshark.org/review/5265
4528 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4531 Author: Guy Harris <guy@alum.mit.edu>
4532 Date: Wed Nov 12 18:11:00 2014 -0800
4534 Squelch a compiler warning.
4536 Some compilers complain that we're casting a 16-bit integer to a
4537 pointer; making it a standard-size integer squelches the warning.
4539 Change-Id: Iba0e767d7801afdc369b64a1cf050bf8db37da7b
4540 Reviewed-on: https://code.wireshark.org/review/5264
4541 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4544 Author: Gerald Combs <gerald@zing.org>
4545 Date: Tue Nov 11 09:56:58 2014 -0800
4547 Qt: Flatten group boxes.
4549 As discussed in change 5185, the "big 3" HIGs discourage the use of
4550 traditional group boxes. Flatten our existing ones.
4552 Change-Id: I68ef4aa9fd0f69a42750bf735df2250a468bfb2d
4553 Reviewed-on: https://code.wireshark.org/review/5263
4554 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4557 Author: Michael Mann <mmann78@netscape.net>
4558 Date: Sun Nov 9 15:44:56 2014 -0500
4560 Add Decode As functionality for MPLS PW Associated Channel Type.
4562 Add CFM and MPLS dissector as possible decoders.
4565 Change-Id: Ic39c6b8d68b965ff9d342f5ee789a8eff3134a5a
4566 Reviewed-on: https://code.wireshark.org/review/4935
4567 Petri-Dish: Michael Mann <mmann78@netscape.net>
4568 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4569 Reviewed-by: Michael Mann <mmann78@netscape.net>
4572 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4573 Date: Wed Nov 12 12:57:36 2014 +0100
4575 Fix warning: no previous prototype for function ... [-Wmissing-prototypes]
4577 warning coming after g055e4768ece and g421913b721
4579 Change-Id: I5caeeb89c559faef8007f2946c68c7172b75dfa8
4580 Reviewed-on: https://code.wireshark.org/review/5250
4581 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4582 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4583 Reviewed-by: Michael Mann <mmann78@netscape.net>
4586 Author: AndersBroman <anders.broman@ericsson.com>
4587 Date: Wed Nov 12 14:15:48 2014 +0100
4590 - The heuristic chek was missing "e" out of "Art-Net\0"
4591 - tvb_length() - tvb_captured_length()
4593 Change-Id: Iad9900f3a22e2fdbd0d6056efc1af90511cc458a
4594 Reviewed-on: https://code.wireshark.org/review/5257
4595 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4598 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4599 Date: Wed Nov 12 12:26:22 2014 +0100
4601 ADB: fix warning: no newline at end of file [-Wnewline-eof]
4603 Warning found by Clang
4605 Change-Id: I7b801808aefa294e32fff560ea1a49620f0e0ea0
4606 Reviewed-on: https://code.wireshark.org/review/5249
4607 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4608 Reviewed-by: Michal Orynicz <michal.orynicz@tieto.com>
4609 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4612 Author: Dario Lombardo <lomato@gmail.com>
4613 Date: Wed Nov 12 11:06:45 2014 +0100
4615 Updates in it translation.
4617 Change-Id: I9e90fca521f17f4ae49e132990f77b2610807e6d
4618 Reviewed-on: https://code.wireshark.org/review/5248
4619 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4622 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4623 Date: Tue Nov 11 12:52:04 2014 +0100
4625 PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
4627 Change-Id: I1540c7878692625a9e38b48f8681c07bab852a64
4628 Reviewed-on: https://code.wireshark.org/review/5234
4629 Reviewed-by: Michael Mann <mmann78@netscape.net>
4632 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
4633 Date: Tue Nov 11 15:22:12 2014 -0500
4635 Fix SMPP timestamp decoding when the current date/time's offset to UTC is
4636 different from the timestamp's offset to UTC.
4638 The fix for bug 6712 ignored the fact that daylight savings will affect the
4639 offset from UTC--and whether daylight savings is in effect today might be
4640 different than whether it was in effect in the timestamp we're decoding.
4643 Change-Id: Ie513c361cff41007f2328cd9ca9ca4800ffef500
4644 Reviewed-on: https://code.wireshark.org/review/5245
4645 Petri-Dish: Michael Mann <mmann78@netscape.net>
4646 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
4647 Reviewed-by: Michael Mann <mmann78@netscape.net>
4650 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
4651 Date: Tue Nov 11 20:48:39 2014 -0500
4653 Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up
4654 on the OSX 10.5 buildbot.
4656 Change-Id: I49e066feab8b980ea85371095234e96e89db71e1
4657 Reviewed-on: https://code.wireshark.org/review/5247
4658 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
4661 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
4662 Date: Tue Nov 11 15:37:04 2014 -0500
4664 Fix a couple of (AFAICS false) may-be-used-uninitialized warnings that show up with gcc 4.8.3.
4666 Change-Id: I71c9013670dd6e8c74e039bd252cfac2c9e95a18
4667 Reviewed-on: https://code.wireshark.org/review/5246
4668 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
4671 Author: AndersBroman <a.broman@bredband.net>
4672 Date: Tue Nov 11 21:21:28 2014 +0100
4674 [GTP] Fix decoding of UMTS GTP QoS Profile i n Radius and Diameter
4678 Change-Id: Iff29ae3f6cee1b4ad12a0e5c5d7fd3da1c9343af
4679 Reviewed-on: https://code.wireshark.org/review/5244
4680 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4683 Author: AndersBroman <a.broman@bredband.net>
4684 Date: Tue Nov 11 21:00:16 2014 +0100
4686 [Radius] Make dictionary.starent.vsa1 the default dictionary.
4687 at least with the trace in Bug 10688 that makes the most sense.
4689 Change-Id: I76213449076a2f49a4b72c6dd87b022fb10b9eef
4690 Reviewed-on: https://code.wireshark.org/review/5242
4691 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4694 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4695 Date: Tue Nov 11 19:35:55 2014 +0100
4697 Tools: Add fix_pragma_wdocumentation to UNKNOWN licence
4699 Change-Id: Ib5665924b99644c52c95d408c7cff19509cf3eb2
4700 Reviewed-on: https://code.wireshark.org/review/5241
4701 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4704 Author: Bill Meier <wmeier@newsguy.com>
4705 Date: Tue Nov 11 12:56:34 2014 -0500
4707 hiqnet: Use correct filter names; Fix specification of hf_dhcp
4709 "foo.flags..." --> "hiqnet.flags...";
4710 Use BASE_NONE for hf_dchp.
4712 Change-Id: Ic3ca4754a1daeefc831dbfcd6a280fe19f8efbf3
4713 Reviewed-on: https://code.wireshark.org/review/5240
4714 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4717 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4718 Date: Sat Nov 8 18:21:07 2014 +0100
4720 Add tools for fix -Wdocumentation
4722 Use pragma to disable -Wdocumentation when include glib.h, gmodule or gtk/gtk.h
4724 Change-Id: I576c0d5c4a12ac3b505ac9543646356ff29ac814
4725 Reviewed-on: https://code.wireshark.org/review/5198
4726 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4729 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4730 Date: Tue Nov 11 17:56:05 2014 +0100
4732 Hiqnet: fix warning found by fix-encoding-args tools
4734 Change-Id: I7e513ec5b617217cd238861f5f02d44edce0bedd
4735 Reviewed-on: https://code.wireshark.org/review/5239
4736 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4739 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4740 Date: Tue Nov 11 17:50:17 2014 +0100
4742 Hiqnet: fix Mac OS X buildbot
4744 Change-Id: Ia4fec86ed389ccb558fe9e1acfb6e87b7012bb75
4745 warning: declaration of 'strlen' shadows a global declaration
4746 Reviewed-on: https://code.wireshark.org/review/5237
4747 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4748 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4749 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4752 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4753 Date: Tue Nov 11 17:54:09 2014 +0100
4755 Hiqnet: fix typo lenght => length
4757 Change-Id: I104d8bb0c56899faef6f4d608859e7b1a34e45a4
4758 Reviewed-on: https://code.wireshark.org/review/5238
4759 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4762 Author: Raphaël Doursenaud <rdoursenaud@free.fr>
4763 Date: Mon Oct 20 13:07:56 2014 +0200
4765 Initial Harman HiQnet dissector
4767 Change-Id: I43042edde09395e328d84bf4b172465829915a98
4768 Reviewed-on: https://code.wireshark.org/review/5014
4769 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4770 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4771 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4774 Author: desolat <nuabaranda@web.de>
4775 Date: Tue Nov 11 00:46:05 2014 +0100
4777 BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Status_Flags
4779 Implementation for this event parameter type was missing
4782 Change-Id: Iea0bc819858bbf5660d97cfd0c418a963ac149fb
4783 Reviewed-on: https://code.wireshark.org/review/5228
4784 Reviewed-by: Michael Mann <mmann78@netscape.net>
4785 Petri-Dish: Michael Mann <mmann78@netscape.net>
4786 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4787 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4790 Author: Guy Harris <guy@alum.mit.edu>
4791 Date: Mon Nov 10 19:47:59 2014 -0800
4793 Fix a problem that causes build failures with CMake on Yosemite.
4795 Change-Id: I52e81656470df887eb3c53b2632bf5a310b1b063
4796 Reviewed-on: https://code.wireshark.org/review/5229
4797 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4800 Author: David Ameiss <netshark@ameissnet.com>
4801 Date: Mon Nov 10 14:24:18 2014 -0600
4803 Allow building under OSX Yosemite using cmake.
4805 CFPropertyListCreateFromStream() has been deprecated in Yosemite, in favor of CFPropertyListCreateWithStream(). The autotools
4806 build checks for the existence of the new function, but the cmake build does not. So, add a check for it to CMakeLists.txt, and
4807 update cmakeconfig.h.in to provide the "template" for HAVE_CFPROPERTYLISTCREATEWITHSTREAM.
4809 Change-Id: I1a4e3e1ce83092ecf7725527b921eeca80b18d4b
4810 Note: CFPropertyListCreateWithStream() works under Mavericks as well.
4811 Reviewed-on: https://code.wireshark.org/review/5226
4812 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4813 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
4816 Author: Bill Meier <wmeier@newsguy.com>
4817 Date: Mon Nov 10 15:07:51 2014 -0500
4821 - amqp_1_0_dissectiom: Use MIN(32-bit-length, 0xFFFF) as the length to dissect;
4822 The original code just used the low-order 16 bits of the 32-bit length
4823 field as the length to dissect.
4824 Add an expert warning if the actual PDU length is > 65K.
4826 - tvb_length() --> tvb_reported_length()
4828 Change-Id: I3230600f460a8bd495eeec17fa6e704bf24de1a2
4829 Reviewed-on: https://code.wireshark.org/review/5225
4830 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4833 Author: Martin Kaiser <wireshark@kaiser.cx>
4834 Date: Mon Sep 1 09:47:26 2014 +0200
4836 USB: consider the device class when we try to select the next dissector
4838 at the moment, we only use the interface class, even in situations where
4839 it's not applicable (e.g. control request that's not addressed to an
4840 interface or an endpoint) - this is a hack that works because some
4841 dissectors register for interface class "unknown", I'm trying to make
4842 this workaround obsolete
4844 Change-Id: I6bf4253a2f8bf5a75ea1a08c3e52d36f80abd7ab
4845 Reviewed-on: https://code.wireshark.org/review/5215
4846 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
4847 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4848 Reviewed-by: Sean Stalley <seanstalley@gmail.com>
4849 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4852 Author: AndersBroman <anders.broman@ericsson.com>
4853 Date: Mon Nov 10 17:43:53 2014 +0100
4855 Use correct offset and lenght for Choice EOC.
4857 Change-Id: I8152e1a07768a3bc245bbafa7c24901ba26a2478
4858 Reviewed-on: https://code.wireshark.org/review/5224
4859 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4862 Author: Victor Voronkov <victor.voronkov@gmail.com>
4863 Date: Mon Nov 10 12:07:15 2014 +0100
4865 WCCP: fix parsing of extended assignment data element
4868 Change-Id: I51322757c5aa7877fa8ff7915330ff24e7a8cbe2
4869 Reviewed-on: https://code.wireshark.org/review/5221
4870 Reviewed-by: Michael Mann <mmann78@netscape.net>
4873 Author: Stig Bjørlykke <stig@bjorlykke.org>
4874 Date: Thu Nov 6 11:19:25 2014 +0100
4876 Improved deregistering fields.
4878 This improvement avoids use of deallocated memory (crash) if using a
4879 deregistered field in display filter, color filter, custom column and
4880 other cases when the field is used as "interesting field".
4882 This functionality is currently used in http, imf and ldap preferences.
4884 Also removed unused proto_registrar_n() as this does not work correctly
4885 after deregistering fields.
4887 Change-Id: I043e3bf7a98bd773c9801e712a012d1eab8a7f94
4888 Reviewed-on: https://code.wireshark.org/review/5161
4889 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4890 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
4893 Author: Stig Bjørlykke <stig@bjorlykke.org>
4894 Date: Wed Nov 5 14:36:29 2014 +0100
4896 Fixed memory leakage in col_cleanup.
4898 Several fields in cinfo is allocated memory and must be freed here
4899 to avoid memory leakage when recreating the packet list.
4901 Do not allocate memory for col_expr[] as this points to static strings
4902 or other allocated strings.
4904 Change-Id: I840377e3c590b1a3e2a38e0537465a028041d1e9
4905 Reviewed-on: https://code.wireshark.org/review/5137
4906 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
4907 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4908 Reviewed-by: Michael Mann <mmann78@netscape.net>
4909 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4912 Author: Gerald Combs <gerald@zing.org>
4913 Date: Sun Nov 9 22:16:15 2014 -0800
4917 Change-Id: Ib4332bace88f9db7a06867861c40627e2bdc55f0
4918 Reviewed-on: https://code.wireshark.org/review/5218
4919 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4922 Author: Gerald Combs <gerald@zing.org>
4923 Date: Sun Nov 9 21:28:00 2014 -0800
4927 Change-Id: Ic46b24cac01c49be01c7ad9e8a12b276fcdf81a5
4928 Reviewed-on: https://code.wireshark.org/review/5217
4929 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4932 Author: Gerald Combs <gerald@zing.org>
4933 Date: Sun Nov 9 18:13:57 2014 -0800
4935 Finish converting the User's Guide to AsciiDoc.
4937 As with the Developer's Guide, add user-guide-docinfo.xml, which lets us
4938 carry over DocBook front matter. Remove the meta_info chapter. Most of
4939 its contents are now in user-guide-docinfo.xml. Add a DocBook revision
4940 history based on hints from the Git/SVN/CVS revision history.
4942 Remove the various makefile targets for converting AsciiDoc files to
4943 DocBook chapters. Remove GPL_appendix.xml. We use the AsciiDoc version.
4945 Change-Id: I543fa2a92f2c735c5f00c97ec65cff2187e09e3a
4946 Reviewed-on: https://code.wireshark.org/review/5216
4947 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4948 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4949 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4952 Author: Michael Mann <mmann78@netscape.net>
4953 Date: Sun Nov 9 14:00:01 2014 -0500
4955 Add subdissector table for MPLS PW Associated Channel Type
4957 Change-Id: Id72fcbe74b91b4eb25fb4d3f3d47a1d53c2857b2
4958 Reviewed-on: https://code.wireshark.org/review/5212
4959 Reviewed-by: Michael Mann <mmann78@netscape.net>
4962 Author: Gerald Combs <gerald@zing.org>
4963 Date: Sun Nov 9 11:39:15 2014 -0800
4965 WSUG: Convert ``Command Line Tools'' to AsciiDoc.
4967 Move the idl2wrs section to the Developer's Guide. Leave most of the
4968 other content intact for now.
4970 Change-Id: I98c6eeab62af5cc55e3ce23ab1107df02b1a22cf
4971 Reviewed-on: https://code.wireshark.org/review/5214
4972 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4975 Author: Michael Mann <mmann78@netscape.net>
4976 Date: Sun Nov 9 14:01:39 2014 -0500
4978 Restore a "ti" assignment that slightly altered dissection.
4980 Change-Id: I94cd7893a2e6b3668499d41519649f6a7782aa60
4981 Reviewed-on: https://code.wireshark.org/review/5213
4982 Reviewed-by: Michael Mann <mmann78@netscape.net>
4985 Author: Gerald Combs <gerald@zing.org>
4986 Date: Sun Nov 9 10:20:26 2014 -0800
4988 WSUG: Convert ``Troubleshooting'' to AsciiDoc.
4990 The chapter is disabled so its final output hasn't been checked. Leave
4991 most of the content intact for now.
4993 Change-Id: I2147ee2863e7ededadf892794a836b4dc8055649
4994 Reviewed-on: https://code.wireshark.org/review/5211
4995 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4998 Author: Gerald Combs <gerald@zing.org>
4999 Date: Sun Nov 9 10:07:46 2014 -0800
5001 WSUG: Convert ``Protocols'', ``Messages'', and ``How Wireshark Works''
5004 ``How Wireshark Works'' is disabled, so its final output hasn't been
5007 Leave most of the content intact for now.
5009 Change-Id: Ia78951faa3ffd9c6d2e23067dbfb954ab4042f60
5010 Reviewed-on: https://code.wireshark.org/review/5210
5011 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5014 Author: Gerald Combs <gerald@zing.org>
5015 Date: Sat Nov 8 22:05:52 2014 -0800
5017 WSUG: Convert ``Files'' to AsciiDoc.
5019 Leave most of the content intact for now.
5021 Change-Id: I78f47b8310cb41ac5a07d352e56ec907b36665f8
5022 Reviewed-on: https://code.wireshark.org/review/5209
5023 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5026 Author: Gerald Combs <gerald@wireshark.org>
5027 Date: Sun Nov 9 08:05:15 2014 -0800
5029 [Automatic manuf, services and enterprise-numbers update for 2014-11-09]
5031 Change-Id: Icfdef00a4b9b303bde89bf57077817f25e47d190
5032 Reviewed-on: https://code.wireshark.org/review/5206
5033 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5036 Author: Michael Mann <mmann78@netscape.net>
5037 Date: Sat Nov 8 21:08:52 2014 -0500
5039 Create a subdissector table for juniper payload protocols.
5041 Change-Id: I60fd9c6c486b9b3b90e32fb9ccce3973569cc2ee
5042 Reviewed-on: https://code.wireshark.org/review/5204
5043 Reviewed-by: Michael Mann <mmann78@netscape.net>
5044 Petri-Dish: Michael Mann <mmann78@netscape.net>
5045 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5046 Reviewed-by: Evan Huus <eapache@gmail.com>
5049 Author: Gerald Combs <gerald@zing.org>
5050 Date: Sat Nov 8 22:23:25 2014 -0800
5052 Try to fix wsluarm dependency.
5054 Change-Id: I90f6a400bb5078c7719c3088d87c4632b810346b
5055 Reviewed-on: https://code.wireshark.org/review/5205
5056 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5059 Author: Gerald Combs <gerald@zing.org>
5060 Date: Sun Nov 2 13:20:08 2014 -0800
5062 Convert the Lua reference to AsciiDoc.
5064 Move it to the Developer's Guide while we're here.
5066 Nudge the markup in epan/wslua where needed. Note that we should
5067 probably convert it to AsciiDoc (if we're going to keep it in the DG) or
5070 Change-Id: Ie175111043f98b7a37eeeb8d185a833d8e866f8b
5071 Reviewed-on: https://code.wireshark.org/review/5203
5072 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5075 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5076 Date: Sat Nov 8 18:03:23 2014 +0100
5078 Fix error: parameter 'XX' not found in the function declaration (-Wdocumentation)
5080 Change-Id: I5850b813989bd6ed33263c0fae3aa29e977e82ec
5081 Reviewed-on: https://code.wireshark.org/review/5195
5082 Reviewed-by: Evan Huus <eapache@gmail.com>
5085 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5086 Date: Sat Nov 8 18:01:25 2014 +0100
5088 SNMP: Fix warning found by -Wunused-const-variable
5090 Change-Id: If3fcab128e3e6bce04f4922568ab7ff8575b01fe
5091 warning: unused variable 'smux_types' [-Wunused-const-variable]
5092 Reviewed-on: https://code.wireshark.org/review/5194
5093 Reviewed-by: Evan Huus <eapache@gmail.com>
5096 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5097 Date: Sat Nov 8 11:14:27 2014 +0100
5099 PIM: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
5101 Change-Id: I4bfc67705ee824e68f14e4177a3194d66bbbe165
5102 Reviewed-on: https://code.wireshark.org/review/5188
5103 Reviewed-by: Evan Huus <eapache@gmail.com>
5106 Author: desolat <nuabaranda@web.de>
5107 Date: Sat Nov 8 13:05:03 2014 +0100
5109 BACAPP: fix dissection of event parameters for event notifications of Event_Type Change_of_Characterstring
5111 Implementation for this event parameter type was missing
5114 Change-Id: I575d387ec4764fa1ecd365624d13e3f41e2473c6
5115 Reviewed-on: https://code.wireshark.org/review/5189
5116 Reviewed-by: Michael Mann <mmann78@netscape.net>
5117 Petri-Dish: Michael Mann <mmann78@netscape.net>
5118 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5119 Reviewed-by: Evan Huus <eapache@gmail.com>
5122 Author: Martin Kaiser <wireshark@kaiser.cx>
5123 Date: Sat Nov 8 19:26:12 2014 +0100
5125 simplify the while-loop in dissect_pmip6_opt_cr()
5128 Change-Id: I5614c640d3fd23196984eb2bb013ba15fb318305
5129 Reviewed-on: https://code.wireshark.org/review/5200
5130 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5131 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
5134 Author: Martin Kaiser <wireshark@kaiser.cx>
5135 Date: Sat Nov 8 19:25:05 2014 +0100
5137 simple fix for bug 10676
5140 Change-Id: I442aa2ce44309655190752e715279d7325647336
5141 Reviewed-on: https://code.wireshark.org/review/5199
5142 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5143 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
5146 Author: Michael Mann <mmann78@netscape.net>
5147 Date: Fri Nov 7 07:47:43 2014 -0500
5149 Create real subdissectors to the IGMP protocol.
5151 Change-Id: I79ee9413b87722bfe4782342737cff03cfc34495
5152 Reviewed-on: https://code.wireshark.org/review/5179
5153 Petri-Dish: Michael Mann <mmann78@netscape.net>
5154 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5155 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5156 Reviewed-by: Michael Mann <mmann78@netscape.net>
5159 Author: Martin Kaiser <wireshark@kaiser.cx>
5160 Date: Sat Nov 8 15:50:26 2014 +0100
5162 fix a copy&paste mistake: type -> length
5164 Change-Id: Ifafdc150c655caf4c7046e3038a6b5e4eeb3cf80
5165 Reviewed-on: https://code.wireshark.org/review/5193
5166 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5167 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
5170 Author: Martin Kaiser <wireshark@kaiser.cx>
5171 Date: Sat Nov 8 12:30:39 2014 +0100
5173 fix a crash in the endpoint dialogue
5175 compile Wireshark with GeoIP enabled
5177 open Statistics / Endpoints
5178 the tree is empty, USB is not amongst the selected Enpoint Types
5179 select USB in the Endpoint Types list
5182 to fix this, add a NULL check for cur_tree to EndpointDialog::tabChanged()
5184 Change-Id: I43d963ae5cd451120ac354e89e37ccbbbc2c5910
5185 Reviewed-on: https://code.wireshark.org/review/5192
5186 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5187 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
5190 Author: Martin Kaiser <wireshark@kaiser.cx>
5191 Date: Sat Nov 8 12:12:36 2014 +0100
5193 remove parent parameter from dissect_usb_setup_response()
5195 Change-Id: Ib4a5cc3b783d3a4a1477624678964a9627d582e6
5196 Reviewed-on: https://code.wireshark.org/review/5191
5197 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5198 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
5201 Author: Martin Kaiser <wireshark@kaiser.cx>
5202 Date: Sat Nov 8 11:58:33 2014 +0100
5204 remove parent parameter from dissect_usb_setup_request()
5206 Change-Id: I5a24de9a12e301d472e701140299304e2cb4fcfc
5207 Reviewed-on: https://code.wireshark.org/review/5190
5208 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
5209 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
5212 Author: Michael Mann <mmann78@netscape.net>
5213 Date: Fri Nov 7 22:53:41 2014 -0500
5215 Add checkfiltername.pl to pre-commit script
5217 Change-Id: I34d8aa7034a4aacc2a95b35a30f25356b33a51b9
5218 Reviewed-on: https://code.wireshark.org/review/5187
5219 Reviewed-by: Michael Mann <mmann78@netscape.net>
5220 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5223 Author: Sven Eckelmann <sven@open-mesh.com>
5224 Date: Tue Sep 30 16:39:37 2014 +0200
5226 batadv: Add missing padding to batadv_unicast_4addr_v14
5228 The already frozen packet format of batman-adv for Linux 3.5 was rejected by
5229 David S. Miller. The 4addr format v14 was therefore changed after the freeze
5230 and published in his final form in Linux 3.8.
5232 Change-Id: I519476c4c6d62b403e197fae6a853d9bbe61f9bc
5233 Signed-off-by: Sven Eckelmann <sven@open-mesh.com>
5234 Signed-off-by: Simon Wunderlich <simon@open-mesh.com>
5235 Reviewed-on: https://code.wireshark.org/review/5174
5236 Reviewed-by: Michael Mann <mmann78@netscape.net>
5239 Author: Guy Harris <guy@alum.mit.edu>
5240 Date: Fri Nov 7 15:16:17 2014 -0800
5242 Don't forward-declare amqp_0_10_get_size_field(), as it no longer exists.
5244 Change-Id: I796826bafd0768b610c9afbde8407fd9d3cc775e
5245 Reviewed-on: https://code.wireshark.org/review/5180
5246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5249 Author: Bill Meier <wmeier@newsguy.com>
5250 Date: Fri Nov 7 15:59:17 2014 -0500
5252 amqp: handle potential overflows when dissecting amqp_0_10 PDUs;
5255 Change-Id: I2fbb16b9d641dfe872aed468f8b944f7ef274261
5256 Reviewed-on: https://code.wireshark.org/review/5176
5257 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5260 Author: Masayuki Takemura <masayuki.takemura@gmail.com>
5261 Date: Thu Nov 6 14:56:08 2014 +0900
5263 dictionary: add missing TLV definition for WiMAX-Downlink-Granted-QoS
5265 The type of the value of the Downlink-Granted-QoS is defined as tlv, but the
5266 TLV definition has not given in the file.
5268 This changeset adds the definition as per WiMAX Forum specification.
5269 As per the spec, the TLV definition is same as the QoS-Descriptor TLV.
5273 Section 5.4.2.29 QoS-Descriptor and 5.4.2.63 Downlink Granted-QoS in
5274 WMF-T33-001-R010v05.
5276 Change-Id: I72d97ed6f7532239cba62cc4cd1b6693fcd43123
5278 dictionary: change type of WiMAX-Uplink-Granted-QoS VSA
5280 This changeset changes the type of WiMAX-Uplink-Granted VSA to tlv and
5281 provides the TLV definition as per WiMAX Forum Specification.
5283 The TLV definition is same as the QoS-Descriptor VSA.
5287 Section 5.4.2.30 Uplink Granted-QoS and 5.4.2.29 QoS-Descriptor in
5288 WMF-T33-001-R010v05.
5290 Change-Id: If6b505bc985c0fb41b19cf2d2fc7b4f887c72b7a
5291 Reviewed-on: https://code.wireshark.org/review/5158
5292 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5295 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5296 Date: Fri Nov 7 15:32:53 2014 +0100
5298 DNS: WKS RR Protocol field is read as 4 bytes instead of 1
5300 In the attached pcap file, there's a single DNS packet with WKS RR in the Prerequisites section.
5301 The Protocol field of this RR is read as if it is 4 bytes long instead of 1, which actually reads part of the bytes of the following RR.
5306 Change-Id: Icf12c7f3864b629a242598373c06eee4de0ca098
5307 Reviewed-on: https://code.wireshark.org/review/5170
5308 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5309 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5312 Author: Pascal Quantin <pascal.quantin@gmail.com>
5313 Date: Fri Nov 7 12:47:18 2014 +0100
5315 DNS: fix name length and label count for a root server
5318 Change-Id: I44297bfa64c31ab53d2aa61b6e54253b7a5a1e27
5319 Reviewed-on: https://code.wireshark.org/review/5167
5320 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5321 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
5322 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5325 Author: Graham Bloice <graham.bloice@trihedral.com>
5326 Date: Fri Nov 7 14:54:32 2014 +0000
5328 Fixed hf field blurb values after changes from change 5166
5330 Change-Id: I1c32fb3629c714d72b5398ad82d219d8786980a1
5331 Reviewed-on: https://code.wireshark.org/review/5171
5332 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
5333 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
5334 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5335 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5338 Author: AndersBroman <anders.broman@ericsson.com>
5339 Date: Fri Nov 7 15:12:52 2014 +0100
5341 GTPv2: Update Indication with Octet 8 and 9 dissection.
5343 Change-Id: Ifa18f31a98932236b102db0f4f28169a7eb72978
5344 Reviewed-on: https://code.wireshark.org/review/5169
5345 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5348 Author: Michael Mann <mmann78@netscape.net>
5349 Date: Thu Nov 6 22:10:11 2014 -0500
5351 Fix all remaining filter name errors found with checkfiltername.pl
5353 This should make it possible to add checkfiltername.pl to the pre-commit script.
5355 Change-Id: Icdee7e4ea3381fa1467bb4b5caf0f60c255adec0
5356 Reviewed-on: https://code.wireshark.org/review/5166
5357 Reviewed-by: Michael Mann <mmann78@netscape.net>
5358 Petri-Dish: Michael Mann <mmann78@netscape.net>
5359 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5360 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5363 Author: Lukas Emersberger <lukas.emersberger@br-automation.com>
5364 Date: Thu Oct 23 09:13:39 2014 +0200
5366 epl: Reassembly table fix
5368 Fixed an error that retransmitted frames were added to the
5371 Change-Id: I314412cb8f2ce49142e4b7f001613948f5e03bf6
5372 Reviewed-on: https://code.wireshark.org/review/4916
5373 Reviewed-by: Roland Knall <rknall@gmail.com>
5374 Reviewed-by: Lukas Emersberger <lukas.emersberger@gmail.com>
5375 Reviewed-by: Michael Mann <mmann78@netscape.net>
5378 Author: Guy Harris <guy@alum.mit.edu>
5379 Date: Thu Nov 6 16:46:31 2014 -0800
5381 Call the default language preference setting "Use system setting".
5383 That more correctly describes it - it doesn't do any form of automatic
5384 detection of anything, it just picks up the system settings from
5385 wherever Qt picks them up.
5387 Change-Id: I62d40719728cc9735e3b8f3e4202b7e61fc3f43b
5388 Reviewed-on: https://code.wireshark.org/review/5165
5389 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5392 Author: J. Bruce Fields <bfields@redhat.com>
5393 Date: Mon Apr 15 13:56:20 2013 -0400
5395 nfs: parse full setclientid CLID_INUSE reply
5397 Note there can be some extra data in the CLID_INUSE case.
5399 (Future work: dissect_nfs_clientaddr4 could use some improvement.)
5402 Change-Id: I92f34c6cc7a9328458f1e4391b04009f5e47290b
5403 Reviewed-on: https://code.wireshark.org/review/5141
5404 Reviewed-by: Bruce Fields <jbrucefields@gmail.com>
5405 Reviewed-by: Michael Mann <mmann78@netscape.net>
5408 Author: Stig Bjørlykke <stig@bjorlykke.org>
5409 Date: Thu Nov 6 08:27:55 2014 +0100
5411 mrcpv2: Fixed a memory leakage.
5413 Moved mrcpv2_tcp_range to proto_reg_handoff and removed the unused
5416 Change-Id: I0bb704db62299c9b3f54e2924162738bf7290ab6
5417 Reviewed-on: https://code.wireshark.org/review/5156
5418 Reviewed-by: Evan Huus <eapache@gmail.com>
5419 Petri-Dish: Evan Huus <eapache@gmail.com>
5420 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5421 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5424 Author: Stig Bjørlykke <stig@bjorlykke.org>
5425 Date: Thu Nov 6 08:30:01 2014 +0100
5427 rtsp: Fixed a memory leakage.
5429 Moved rtsp_tcp_port_range to proto_reg_handoff and removed the unused
5432 Change-Id: I695bc5a78d8e6177f2b2847ecee58a0d973d7d1c
5433 Reviewed-on: https://code.wireshark.org/review/5157
5434 Reviewed-by: Evan Huus <eapache@gmail.com>
5435 Petri-Dish: Evan Huus <eapache@gmail.com>
5436 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5437 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5440 Author: Maarten Bezemer <maarten.bezemer@gmail.com>
5441 Date: Thu Nov 6 13:21:03 2014 +0100
5443 Improve error message by including the (expected) class information
5445 The code checks whether the tag AND class are matching with their expected values, but only the tag information is shown in the error message.
5446 When the class is not matching, the error message shows the given and expected tags which are the same, confusing the user what is wrong with it.
5448 Furthermore, the messages for SEQUENCE and SEQUENCE OF are made the same/similar.
5450 Change-Id: I6c1d0968c903105ec7f6e0648d589a4263a8ca18
5451 Reviewed-on: https://code.wireshark.org/review/5162
5452 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
5455 Author: AndersBroman <anders.broman@ericsson.com>
5456 Date: Thu Nov 6 16:57:09 2014 +0100
5458 BER: Fix offset and length of EOC in Sequence loop
5460 Change-Id: I4384339688c1dda5e011b7ff7772940fd61de8d1
5461 Reviewed-on: https://code.wireshark.org/review/5164
5462 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5465 Author: Michael Tüxen <tuexen@wireshark.org>
5466 Date: Thu Nov 6 13:46:24 2014 +0100
5468 Always process the expert info for the new open request message.
5470 Change-Id: I38a4bee1b482f320c7e2fd685cf5823ddb4f8d36
5471 Reviewed-on: https://code.wireshark.org/review/5163
5472 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
5475 Author: Stig Bjørlykke <stig@bjorlykke.org>
5476 Date: Thu Nov 6 08:25:55 2014 +0100
5478 lbtrm: Use correct variable for outgoing_mc_address.
5480 Change-Id: I17e06e39de0de347926825741897646507691657
5481 Reviewed-on: https://code.wireshark.org/review/5155
5482 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5485 Author: Bill Meier <wmeier@newsguy.com>
5486 Date: Thu Nov 6 00:35:24 2014 -0500
5488 coap: fix a bug; do some cleanup.
5490 Bug fix: do initial calls to col_...() *before* the dissection code so
5491 that proper column info is displayed even if the dissector
5492 exits early because of an exception, etc.
5495 - Use wmem_strbuf instead of static fixed length char arrays;
5496 - Create/use an extended value_string;
5497 - Use %u (not %d) when formatting unsigned values;
5498 - Use strchr() to search a string for a character;
5501 Change-Id: I57ca584f989c3ab1cf141270cc50160f9fb980ae
5502 Reviewed-on: https://code.wireshark.org/review/5153
5503 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5506 Author: Stig Bjørlykke <stig@bjorlykke.org>
5507 Date: Wed Nov 5 14:48:43 2014 +0100
5509 Lua: Fixed some memory leakages.
5511 Change-Id: I5e14c2e5a3868ec40d1989876b06919aa9ece4a1
5512 Reviewed-on: https://code.wireshark.org/review/5138
5513 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
5514 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5515 Reviewed-by: Evan Huus <eapache@gmail.com>
5518 Author: Evan Huus <eapache@gmail.com>
5519 Date: Wed Nov 5 23:43:20 2014 -0500
5521 rpc: fix regression in gbfc5483174d
5523 value can be NULL, in which case memduping it will crash
5526 Change-Id: I8950fae94d80a2f06f24a785532536ad73f1855d
5527 Reviewed-on: https://code.wireshark.org/review/5152
5528 Reviewed-by: Evan Huus <eapache@gmail.com>
5531 Author: J. Bruce Fields <bfields@redhat.com>
5532 Date: Fri Oct 31 12:43:07 2014 -0400
5534 nfs: clean up fh_expire_type dissection
5536 This is a bit simpler and makes the field searchable.
5539 Change-ID: I68386f987c419c0b6cbc181f29c6bce6c04fcfdb
5540 Reviewed-on: https://code.wireshark.org/review/5145
5541 Petri-Dish: Michael Mann <mmann78@netscape.net>
5542 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5543 Reviewed-by: Michael Mann <mmann78@netscape.net>
5546 Author: J. Bruce Fields <bfields@redhat.com>
5547 Date: Wed Oct 29 09:00:07 2014 -0400
5549 nfs: NFSv4.2 SEEK, ALLOCATE, DEALLOCATE support
5551 NFSv4.2 is still a draft, but these three ops are implemented at least
5552 for Linux now and are very unlikely to change any further.
5555 Change-Id: Ia2917de59fb2b0ed7191c9f362b7eb60756d7634
5556 Reviewed-on: https://code.wireshark.org/review/5143
5557 Petri-Dish: Michael Mann <mmann78@netscape.net>
5558 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5559 Reviewed-by: Michael Mann <mmann78@netscape.net>
5562 Author: J. Bruce Fields <bfields@redhat.com>
5563 Date: Fri Oct 31 14:55:12 2014 -0400
5565 nfs: interpret aclsupport attribute
5567 It's not an interesting attribute but I've occasionally been annoyed by
5568 having to look it up just to verify a server isn't doing something nuts.
5571 Change-Id: I660b62039075a4044946e590ee75ed5690290bc5
5572 Reviewed-on: https://code.wireshark.org/review/5146
5573 Reviewed-by: Michael Mann <mmann78@netscape.net>
5576 Author: J. Bruce Fields <bfields@redhat.com>
5577 Date: Mon Sep 30 17:54:42 2013 -0400
5579 nfs: label NFSv4 CREATE symlink arguments more helpfully
5581 Currently it's hard to tell which field is the name of the symlink and
5582 which is the target; both are labeled just "Name".
5585 Change-Id: I1322a3652ffbcee920a6808dcc5613cefe8d8588
5586 Reviewed-on: https://code.wireshark.org/review/5142
5587 Reviewed-by: Michael Mann <mmann78@netscape.net>
5590 Author: J. Bruce Fields <bfields@redhat.com>
5591 Date: Fri Oct 17 15:45:39 2014 -0400
5593 nfs: fix open result_flags
5595 The protocol values here are all wrong, and miss new flags from rfc
5599 Change-Id: I03fb2b521b415dbca5d4b77eda609eb8084da57c
5600 Reviewed-on: https://code.wireshark.org/review/5140
5601 Reviewed-by: Michael Mann <mmann78@netscape.net>
5604 Author: Joerg Mayer <jmayer@loplof.de>
5605 Date: Wed Nov 5 21:10:07 2014 +0100
5607 Enable some runtime sanity checks when using at least gcc 4.9
5609 Change-Id: I33208d4c27a27fb9222577ca176357035eeb7ba1
5610 Reviewed-on: https://code.wireshark.org/review/5150
5611 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
5614 Author: Joerg Mayer <jmayer@loplof.de>
5615 Date: Wed Nov 5 21:05:34 2014 +0100
5617 Fix plugin search path: It was relative instead of absolute, resulting
5618 in not found plugins (lib/wireshark/plugins/1.99.1).
5620 Change-Id: Ie81f3c4450789ff7e37c99e197b44e7df47d8df5
5621 Reviewed-on: https://code.wireshark.org/review/5149
5622 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
5625 Author: Stephen Fisher <stephenfisher@centurylink.net>
5626 Date: Wed Nov 5 09:43:00 2014 -0700
5628 Allow the environment variable RCC to set before running configure to
5629 allow for unusual paths for Qt's rcc program (FreeBSD ports puts it in
5630 /usr/local/lib/qt5/bin). This matches the existing functionality of the
5631 MOC and UIC variables/programs.
5633 Change-Id: I885d61bce54d9e893e0c2fc496a9ff767a096ae6
5634 Reviewed-on: https://code.wireshark.org/review/5139
5635 Petri-Dish: Stephen Fisher <stephenfisher@centurylink.net>
5636 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5637 Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
5640 Author: Ambarish Malpani <ambarish@defend7.com>
5641 Date: Tue Nov 4 14:38:07 2014 -0800
5643 Make SSL certificates available to tshark as bytes via the dtls/ssl.handshake.certificate key.
5645 Changed the entries so that users have access to the whole certificate in
5646 tshark. This allows developers to process the certs in custom ways
5648 Change-Id: I113d60b2b3f12c6b15a644ec02bbebf7134f0ece
5649 Reviewed-on: https://code.wireshark.org/review/5119
5650 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
5651 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5654 Author: Michal Labedzki <michal.labedzki@tieto.com>
5655 Date: Tue Nov 4 18:47:11 2014 +0100
5657 Qt: Simplify disabling entries in ContextMenu
5659 We have direct access to every entry (action) in ContextMenu.
5660 Use it instead of storing "actions" and checking its name.
5662 Change-Id: I97a1723898409faf13280c5655b7738661ab594b
5663 Reviewed-on: https://code.wireshark.org/review/5135
5664 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
5665 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
5666 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
5667 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5668 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5671 Author: Matthieu Texier <matthieu@texier.tv>
5672 Date: Mon Sep 15 16:10:51 2014 +0200
5674 pim: BIDIR support (RFC 5015)
5677 Change-Id: Ia93fa76b8d381971f900de4a8ce591f03cd82da0
5678 Reviewed-on: https://code.wireshark.org/review/5118
5679 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5682 Author: Pascal Quantin <pascal.quantin@gmail.com>
5683 Date: Wed Nov 5 12:50:32 2014 +0100
5685 ws_mempbrk_sse42.c: remove inclusion of stdint.h as it's no more required after g79e4da4
5687 Change-Id: I48776a286ba1d412ecda55857938d9daa77fd3f7
5688 Reviewed-on: https://code.wireshark.org/review/5136
5689 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5690 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5691 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5694 Author: Bill Meier <wmeier@newsguy.com>
5695 Date: Wed Nov 5 00:21:33 2014 -0500
5697 mih: tvb_length() --> tvb_reported_length(); Fix some boolean bitfield displays.
5699 Change-Id: I52dd05842afdff4ffd8a70ff56d665ea28d0f63b
5700 Reviewed-on: https://code.wireshark.org/review/5133
5701 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5704 Author: Bill Meier <wmeier@newsguy.com>
5705 Date: Tue Nov 4 22:28:44 2014 -0500
5707 mih: Fix some bugs; Add an XXX comment.
5709 One of the bugs: (2^32) is *not* 2 to the power of 32.
5711 Change-Id: Id4dab16380f757e89c05be4182da3ac92c92abd6
5712 Reviewed-on: https://code.wireshark.org/review/5127
5713 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5716 Author: Bill Meier <wmeier@newsguy.com>
5717 Date: Tue Nov 4 22:34:51 2014 -0500
5719 opensafety: Use 1<<10 (not 2^10) in a #define;
5721 Comment out the #define since it's not actually used. :)
5723 Change-Id: Ia34200d3eb705a74a33cbcf18175a7f780f2d2e2
5724 Reviewed-on: https://code.wireshark.org/review/5128
5725 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5728 Author: Joerg Mayer <jmayer@loplof.de>
5729 Date: Wed Nov 5 04:16:22 2014 +0100
5731 Show the bit-encoding into the (shared) 2-Byte value for
5732 fragment number and sequence number
5734 Change-Id: I38bb61471fe43c5cfa8274e728a56d4cdb132ec1
5735 Reviewed-on: https://code.wireshark.org/review/5126
5736 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
5739 Author: Pascal Quantin <pascal.quantin@gmail.com>
5740 Date: Mon Nov 3 23:32:47 2014 +0100
5742 DNS: replace hash map by red-black tree to fix request/response tracking when transaction id is reused
5745 Change-Id: Id4356dcd6802da40b4a3e2e2095cc9d2932c2c68
5746 Reviewed-on: https://code.wireshark.org/review/5100
5747 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5748 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5749 Reviewed-by: Evan Huus <eapache@gmail.com>
5752 Author: Evan Huus <eapache@gmail.com>
5753 Date: Tue Nov 4 21:31:17 2014 -0500
5755 sigcomp-udvm: fix invalid access
5757 Way back in 2006, svn r20041 (now gd408f2f6fc) worked around a problem by
5758 limiting the amount of buffer dealt with in the udvm_state_access call (changing
5759 it from state_minimum_access_length_buff[n] to STATE_MIN_ACCESS_LEN).
5761 The very next line however, tries to read the same amount of buffer to display
5762 to the user - since it seems nobody ever applied a proper fix for the original
5763 case, just apply the same workaround to the second call.
5766 Change-Id: I32c81ee2a8eb7b30ff7ab1fbbb6ea5f206385d4b
5767 Reviewed-on: https://code.wireshark.org/review/5124
5768 Reviewed-by: Evan Huus <eapache@gmail.com>
5771 Author: Evan Huus <eapache@gmail.com>
5772 Date: Sat Nov 1 16:36:01 2014 -0400
5774 rpc: take a file-scope copy of some RPC procedures
5776 The original may be freed out from underneath us if a duplicate is registered.
5777 Thanks to Bruce Fields for pointing out one case of this I'd missed.
5779 Also replace a bunch of manual "foo.field = 0" with just wmem_new0() instead.
5782 Change-Id: I342bd732f062b0a191cbbf5ae417356385d2fd53
5783 Reviewed-on: https://code.wireshark.org/review/5046
5784 Petri-Dish: Evan Huus <eapache@gmail.com>
5785 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5786 Reviewed-by: Evan Huus <eapache@gmail.com>
5789 Author: Guy Harris <guy@alum.mit.edu>
5790 Date: Tue Nov 4 18:08:47 2014 -0800
5792 Oops, we also need to worry about pcap_get_tstamp_precision().
5794 Change-Id: I60a1f671ba313c59ca1999ab703ee11370608758
5795 Reviewed-on: https://code.wireshark.org/review/5123
5796 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5799 Author: Guy Harris <guy@alum.mit.edu>
5800 Date: Tue Nov 4 17:53:17 2014 -0800
5802 Get rid of unused variable.
5804 Leftover crud before I notied that RTLD_NEXT would do what I want.
5806 Change-Id: I5e510e74c65b211e6cc6c300e760869abb399dc8
5807 Reviewed-on: https://code.wireshark.org/review/5121
5808 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5811 Author: Guy Harris <guy@alum.mit.edu>
5812 Date: Tue Nov 4 17:49:29 2014 -0800
5814 Cope with newer Xcode not having the 10.6 SDK.
5816 The latest Xcode, as of today, has only 10.9 and 10.10 SDKs, which means
5817 that, if we build Wireshark and request a deployment minimum release of
5818 10.6, we'll be building against an SDK in which libpcap has routines
5819 that aren't available in 10.6 and that doesn't use weak linking for
5820 them, so the resulting binary won't actually work on 10.6.
5822 Use the run-time loader to find those routines (currently, only
5823 pcap_set_tstamp_precision()) and call them only if we find them.
5825 On other UN*Xes, we still assume that we'll be running only on the
5826 release against which we were built and newer releases.
5828 Change-Id: Iab20d86fe3be4b299cfb6e25c1f95dc6e1581661
5829 Reviewed-on: https://code.wireshark.org/review/5120
5830 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5833 Author: Guy Harris <guy@alum.mit.edu>
5834 Date: Tue Nov 4 12:43:44 2014 -0800
5836 Add the flag SVGs to the set of files we distribute.
5838 Change-Id: Ib6e9098a4b411eeb1e5f597f3ec5f55e98632ad3
5839 Reviewed-on: https://code.wireshark.org/review/5117
5840 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5843 Author: Guy Harris <guy@alum.mit.edu>
5844 Date: Tue Nov 4 20:36:13 2014 +0000
5846 Revert "Follow a suggestion from libtoolize:"
5848 Sadly, older versions of autoconf - such as the ones on the OS X buildbots - don't know about AC_CONFIG_MACRO_DIRS.
5850 This reverts commit 89291ad4f3293893387b385a0800cad42215ddd4.
5852 Change-Id: Ie4fa71062886f58c7f6014f6b7969921f0b824ae
5853 Reviewed-on: https://code.wireshark.org/review/5116
5854 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5857 Author: Stephen Fisher <stephenfisher@centurylink.net>
5858 Date: Tue Nov 4 12:58:48 2014 -0700
5860 Fix compilation error on FreeBSD 10.0-RELEASE (with clang): change int8_t to
5863 Change-Id: I7974497a8f50e5d18ec74aa7554f058056a6022c
5864 Reviewed-on: https://code.wireshark.org/review/5115
5865 Petri-Dish: Stephen Fisher <stephenfisher@centurylink.net>
5866 Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
5869 Author: Stephen Fisher <stephenfisher@centurylink.net>
5870 Date: Tue Nov 4 11:43:46 2014 -0700
5872 Follow a suggestion from libtoolize:
5874 libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([./aclocal-fallback])' to
5877 This is explained in the libtool manual:
5879 "In the future other Autotools will automatically check the contents of
5880 AC_CONFIG_MACRO_DIRS, but at the moment it is more portable to add the macro
5881 directory to ACLOCAL_AMFLAGS in Makefile.am, which is where the tools currently
5882 look. If libtoolize doesn't see AC_CONFIG_MACRO_DIRS, it too will
5883 honour the first -I argument in ACLOCAL_AMFLAGS when
5884 choosing a directory to store libtool configuration macros in. It is perfectly
5885 sensible to use both AC_CONFIG_MACRO_DIRS and ACLOCAL_AMFLAGS, as long as they
5886 are kept in synchronisation."
5888 Change-Id: Ic203b0b5104ea3423cf8c0042b2278e82bcea332
5889 Reviewed-on: https://code.wireshark.org/review/5113
5890 Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
5893 Author: Stephen Fisher <stephenfisher@centurylink.net>
5894 Date: Tue Nov 4 12:17:45 2014 -0700
5896 Ignore additional generated files:
5898 aclocal-fallback/libtool.m4
5899 aclocal-fallback/ltoptions.m4
5900 aclocal-fallback/ltsugar.m4
5901 aclocal-fallback/ltversion.m4
5902 aclocal-fallback/lt~obsolete.m4
5904 Change-Id: I7c9bb5c383f44800345540ec05a67175bd7267cc
5905 Reviewed-on: https://code.wireshark.org/review/5114
5906 Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
5909 Author: Stephen Fisher <stephenfisher@centurylink.net>
5910 Date: Tue Nov 4 10:11:40 2014 -0700
5912 Fix some compilation errors (size_t to guint/gint) and an unused parameter
5914 Change-Id: I2d64d840c93f951dd5481ca5950ff5587da6843d
5915 Reviewed-on: https://code.wireshark.org/review/5112
5916 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5917 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5920 Author: Bill Meier <wmeier@newsguy.com>
5921 Date: Tue Nov 4 11:15:18 2014 -0500
5923 amqp: Fix a number of bugs in dissect_amqp_0_10_map().
5925 (Among other things: "2 ^ xxx" is *not* 2 to the xxx'th power).
5927 Change-Id: I893b72e853ecbb5d7e6259e950fb347e89eed6c2
5928 Reviewed-on: https://code.wireshark.org/review/5109
5929 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5932 Author: Guy Harris <guy@alum.mit.edu>
5933 Date: Tue Nov 4 04:36:23 2014 -0800
5935 add the type dom_sid28 and call ad-hoc dissector
5937 Pick up change from Samba:
5939 commit 87fb54b77f4b9caaf2b25635b7813e29a448aaa6
5940 Author: Matthieu Patou <mat@matws.net>
5941 Date: Tue Oct 1 12:04:02 2013 -0700
5943 pidl-wireshark: add the type dom_sid28 and call ad-hoc dissector
5945 Change-Id: Ide5041b901b5e1785b5cabd4b6320f830bbef2b8
5946 Reviewed-on: https://code.wireshark.org/review/5108
5947 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5950 Author: Stig Bjørlykke <stig@bjorlykke.org>
5951 Date: Tue Nov 4 12:04:20 2014 +0100
5953 Lua: Fix for register dissectors only once.
5955 The postdissector may be registered before adding the dissector function.
5957 Change-Id: I2285824835491ac91e00515bfb18eb471888eaf8
5958 Reviewed-on: https://code.wireshark.org/review/5106
5959 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
5960 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5961 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
5962 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
5965 Author: Guy Harris <guy@alum.mit.edu>
5966 Date: Tue Nov 4 02:07:30 2014 -0800
5968 SWITCH_TYPE is not always defined, SwitchType() will try to find a fallback
5970 Pick up change from Samba:
5972 commit 4b09df897803e78265fd19f6ff19be6e3d8a3944
5973 Author: Matthieu Patou <mat@matws.net>
5974 Date: Tue Oct 1 12:10:18 2013 -0700
5976 pidl-wireshark: SWITCH_TYPE is not always defined, SwitchType() will try to find a fallback
5978 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
5980 Change-Id: I1f41ece23e8fec30f9cd89a2203ad63ee6e21e36
5981 Reviewed-on: https://code.wireshark.org/review/5105
5982 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5985 Author: Michal Labedzki <michal.labedzki@tieto.com>
5986 Date: Sat Dec 21 17:55:43 2013 +0100
5988 Qt: Dynamic languages
5990 - get language as soon as possible (before creating any Qt objects) to make all
5991 translations working
5992 - dynamic list of supported languages
5993 - runtime change of GUI language (no need to restart application)
5994 - add flags icons support
5995 - search for *.qm languages in buildin resources, then
5996 data dir called "languages" (main directory in sources or
5997 /usr/share/wireshark/languages), then user directory
5998 (UNIX: ~/.wireshark/languages); "languages" directory should contains
5999 files wireshark_xx.qm where xx is language code (en, en_GB, etc.),
6000 and optional xx.svg for flag icon
6001 - try to fix some untranslated manually-created UI items
6002 (need manual reset text of those components)
6004 Change-Id: I62ca8a8cddce47cec9dbcad6b0bd68b6cfd92229
6005 Reviewed-on: https://code.wireshark.org/review/5041
6006 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
6007 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
6010 Author: Stig Bjørlykke <stig@bjorlykke.org>
6011 Date: Fri Oct 31 13:21:46 2014 +0100
6013 Lua: Register dissectors only once.
6015 Change-Id: I883e8560e9d101d34760d09715255e4fccc9eb98
6016 Reviewed-on: https://code.wireshark.org/review/5022
6017 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
6018 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
6019 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
6022 Author: Stephen Fisher <stephenfisher@centurylink.net>
6023 Date: Mon Nov 3 17:05:38 2014 -0700
6025 Also ignore TAGS files in addition to the already ignored tags in .gitignore
6027 Change-Id: Id787cf8dfd3df5fac6d535422e00eff3788570b0
6028 Reviewed-on: https://code.wireshark.org/review/5103
6029 Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
6032 Author: Stephen Fisher <stephenfisher@centurylink.net>
6033 Date: Mon Nov 3 16:39:16 2014 -0700
6035 Update my e-mail address
6037 Change-Id: I46b03b15820c4d3df172528068317ae0ddc8fab2
6038 Reviewed-on: https://code.wireshark.org/review/5102
6039 Reviewed-by: Stephen Fisher <stephenfisher@centurylink.net>
6042 Author: Guy Harris <guy@alum.mit.edu>
6043 Date: Mon Nov 3 15:03:01 2014 -0800
6045 Regenerate DCE RPC dissectors with the current pidl.
6047 Change-Id: I3cfb9399a9e5ed783083fa5b26a39646fb53875f
6048 Reviewed-on: https://code.wireshark.org/review/5101
6049 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6052 Author: Guy Harris <guy@alum.mit.edu>
6053 Date: Mon Nov 3 12:05:47 2014 -0800
6055 generate ALIGN_TO_x_BYTES instructions if the element has the align_x flag
6057 Pick up change from Samba:
6059 commit 93f262ee6d162bf007b79d2daf9de6c49c6163d1
6060 Author: Matthieu Patou <mat@matws.net>
6061 Date: Fri Oct 18 00:04:28 2013 -0700
6063 pidl-wireshark: generate ALIGN_TO_x_BYTES instructions if the element has the align_x flag
6065 Change-Id: I865eae69ea7a8200630d3ad69bda9ac7b1c12255
6066 Reviewed-on: https://code.wireshark.org/review/5099
6067 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6070 Author: Guy Harris <guy@alum.mit.edu>
6071 Date: Mon Nov 3 12:03:32 2014 -0800
6073 if the structure has the flag no_align then set also no_align in the dceprc_info structure
6075 commit 3f6ca430b067705d556031d52736d5a5d5ae8f55
6076 Author: Matthieu Patou <mat@matws.net>
6077 Date: Fri Oct 11 13:18:37 2013 -0700
6079 pidl-wireshark: if the structure has the flag no_align then set also no_align in the dceprc_info structure
6081 Some dissection function will try to do alignment if the no_align flag
6084 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
6086 Change-Id: Ie2377f4d6c1c4f2fde7084ba666bd417568122dd
6087 Reviewed-on: https://code.wireshark.org/review/5098
6088 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6091 Author: Guy Harris <guy@alum.mit.edu>
6092 Date: Mon Nov 3 11:55:34 2014 -0800
6094 Remove casts, make some whitespace changes in generated code.
6096 This is the part of this change from Samba:
6098 commit f0a6043fb201940f438f63c809df7186aa307f01
6099 Author: Matthieu Patou <mat@matws.net>
6100 Date: Sun Oct 5 18:25:27 2014 -0700
6102 pidl-wireshark: handle 8 bits enum and change the signature of enum function to pass the exact type
6104 Instead of passing a uint32 in all cases we pass the exact type
6106 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
6108 that wasn't already in our version.
6110 Change-Id: I7da99cb701c2eedadeb8acb68d32f657dfa85e5b
6111 Reviewed-on: https://code.wireshark.org/review/5097
6112 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6115 Author: Guy Harris <guy@alum.mit.edu>
6116 Date: Mon Nov 3 11:50:53 2014 -0800
6118 add definition for IPV4/IPV6 types
6120 Pick up change from Samba:
6122 commit 49e0dc7ad0f3c29df20badacc4294f1adc375aaf
6123 Author: Matthieu Patou <mat@matws.net>
6124 Date: Fri Oct 25 23:11:37 2013 -0700
6126 pidl-wireshark: add definition for IPV4/IPV6 types
6128 Change-Id: I514f855370c1d9355ffc6ff9b31f8aedd70b9122
6129 Reviewed-on: https://code.wireshark.org/review/5096
6130 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6133 Author: Guy Harris <guy@alum.mit.edu>
6134 Date: Mon Nov 3 11:46:18 2014 -0800
6136 insure that we have an entire match for the variable name
6138 Pick up patch from Samba:
6140 commit fa331f64d1a40350496c7acf68c20cb3fead6eaf
6141 Author: Matthieu Patou <mat@matws.net>
6142 Date: Thu Oct 3 09:45:19 2013 -0700
6144 pidl-wireshark: insure that we have an entire match for the variable name
6146 Change-Id: I1e730dfb3b9eb96a4cda34659297fddeac7801c8
6147 Reviewed-on: https://code.wireshark.org/review/5095
6148 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6151 Author: Guy Harris <guy@alum.mit.edu>
6152 Date: Mon Nov 3 11:44:05 2014 -0800
6154 generate an error for the new Pipe type in typedef
6156 Pick up change from Samba:
6158 commit 5d0d45c9a71f137dc29ca79d49bd558f34bf1ff5
6159 Author: Matthieu Patou <mat@matws.net>
6160 Date: Sun Sep 29 00:42:36 2013 -0700
6162 pidl-wireshark: generate an error for the new Pipe type in typedef
6164 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
6166 Change-Id: I9e6da50b657f774fadf7c3777900d409999d4660
6167 Reviewed-on: https://code.wireshark.org/review/5094
6168 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6171 Author: Guy Harris <guy@alum.mit.edu>
6172 Date: Mon Nov 3 11:34:29 2014 -0800
6174 add a function to change the type of a hf_field
6176 Pick up change from Samba:
6178 commit 755bc4ed29c89fc15d4230ce8b828b3afcfa2912
6179 Author: Matthieu Patou <mat@matws.net>
6180 Date: Thu Oct 3 01:10:48 2013 -0700
6182 pidl-wireshark: add a function to change the type of a hf_field
6184 We can use this to change the type FT_BYTE when we realize that the
6185 object dissected is an array of bytes
6187 Change-Id: I1f24ce834b6a5be0d933b1fdfd9a0baa88c3761a
6188 Reviewed-on: https://code.wireshark.org/review/5093
6189 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6192 Author: Guy Harris <guy@alum.mit.edu>
6193 Date: Mon Nov 3 11:30:26 2014 -0800
6195 Handle the case when the DATA_TYPE is not a simple type
6197 Pick up change from Samba:
6199 commit 343db5326b369cbdef4b723e3056acc2a866a887
6200 Author: Matthieu Patou <mat@matws.net>
6201 Date: Tue Sep 23 01:28:40 2014 -0700
6203 pidl-wireshark: Handle the case when the DATA_TYPE is not a simple type
6205 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
6207 Change-Id: I511a60beb392e5e92701d5ace1260397fb4be851
6208 Reviewed-on: https://code.wireshark.org/review/5092
6209 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6212 Author: Guy Harris <guy@alum.mit.edu>
6213 Date: Mon Nov 3 11:24:18 2014 -0800
6215 Improve string delection in function ContainsString
6217 Pick up patch from Samba:
6219 commit 5740a06b320d56840439fb7fe3b8b27f341ddaa7
6220 Author: Matthieu Patou <mat@matws.net>
6221 Date: Sat Oct 4 21:19:12 2014 -0700
6223 pidl: Improve string delection in function ContainsString
6225 Change-Id: I702c12e4275315511728d5ef6db07e03be9c2b38
6226 Reviewed-on: https://code.wireshark.org/review/5091
6227 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6230 Author: Guy Harris <guy@alum.mit.edu>
6231 Date: Mon Nov 3 11:20:27 2014 -0800
6233 Make the compilation of PIDL produce the same results if the content hasn't changed
6235 Pick up change from Samba:
6237 commit 4986359816704f38d4fad3ddd0d07a0f0a25b335
6238 Author: Matthieu Patou <mat@matws.net>
6239 Date: Mon Sep 22 21:52:14 2014 -0700
6241 pidl: Make the compilation of PIDL producing the same results if the content hasn't change
6243 Newer perl versions don't generate stable results anymore.
6245 Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
6247 Change-Id: Ifced47229b3033d1fae494adff0dee6671304812
6248 Reviewed-on: https://code.wireshark.org/review/5090
6249 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6252 Author: Guy Harris <guy@alum.mit.edu>
6253 Date: Mon Nov 3 11:07:54 2014 -0800
6255 Pass di to one more call to PIDL_dissect_uint8().
6257 The case for type "char" wasn't fixed.
6259 Change-Id: Ia745263cd4d11a3c00b1ecc72e044f4e404da283
6260 Reviewed-on: https://code.wireshark.org/review/5088
6261 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6264 Author: Guy Harris <guy@alum.mit.edu>
6265 Date: Mon Nov 3 08:39:07 2014 -0800
6267 Don't use -msse4.2 with MSVC.
6269 Change-Id: I457d45d9ad05e0eb851e78a7342e666ef9df8ffd
6270 Reviewed-on: https://code.wireshark.org/review/5086
6271 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6274 Author: AndersBroman <anders.broman@ericsson.com>
6275 Date: Mon Nov 3 16:19:10 2014 +0100
6277 tvb_length -> tvb_reported_length
6279 Change-Id: I48b618008c8c8accd6f161bdc42e02906a4765b7
6280 Reviewed-on: https://code.wireshark.org/review/5085
6281 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6284 Author: AndersBroman <anders.broman@ericsson.com>
6285 Date: Mon Nov 3 09:49:50 2014 +0100
6292 As they give errors in the test suit, something may have changed in the
6293 free rasdius syntax,
6295 Change-Id: I27c2c4ea8b96601dfaf48b8dc29273fa6adca655
6296 Reviewed-on: https://code.wireshark.org/review/5084
6297 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6300 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6301 Date: Sun Nov 2 17:07:41 2014 +0100
6303 MIPv6: Mobility Header Link Layer Address is parsed incorrectly
6305 Looking at RFC 5568 (http://tools.ietf.org/html/rfc5568#section-6.4.3)
6306 It says that the Link-Layer Address (LLA) Option, should have an address right after the option code
6310 Change-Id: I6fcd98a7c9896862e4c9547b945cf3848daaf474
6311 Reviewed-on: https://code.wireshark.org/review/5075
6312 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6315 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6316 Date: Mon Oct 27 13:40:45 2014 +0100
6318 HPSW: fix neighbor MAC Address
6320 Use the wrong length for display mac address (6 and no the length of option)
6321 Also fix update of item (don't update the root item)
6323 Change-Id: I38cd1a6a045e797b01cd1a8de5add0949eaa0f01
6324 Reviewed-on: https://code.wireshark.org/review/4950
6325 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6328 Author: Pascal Quantin <pascal.quantin@gmail.com>
6329 Date: Sun Nov 2 12:59:47 2014 +0100
6331 Qt: fix what seems to be a copy/paste error in MainWindow::loadWindowGeometry() (Coverity CID 1158563)
6333 Change-Id: Iaa2a6367fbb434514751e0ed4f273f883798ce8a
6334 Reviewed-on: https://code.wireshark.org/review/5066
6335 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6336 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6339 Author: Pascal Quantin <pascal.quantin@gmail.com>
6340 Date: Sun Nov 2 12:58:26 2014 +0100
6342 Qt: fix a potential memory leak FollowStreamDialog::follow() found by Coverity (CID 1159304)
6344 Change-Id: I53709c6729c6d9156d2ba5ccd83e92bc27433e26
6345 Reviewed-on: https://code.wireshark.org/review/5065
6346 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6347 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6350 Author: Anish Bhatt <anish@chelsio.com>
6351 Date: Mon Oct 27 01:12:21 2014 -0700
6353 [Radius] Update dictionaries from freeradius 3.0.4
6355 Update includes all new/renamed dictionaries in radius, but does not cover any differences in already included dictionaries, which will be handled in a separate update.
6357 Change-Id: I6d1e1cc1815423fb71ec940366964a366ab41a25
6358 Reviewed-on: https://code.wireshark.org/review/4947
6359 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6362 Author: Martin Kaiser <wireshark@kaiser.cx>
6363 Date: Thu Aug 28 18:39:02 2014 +0200
6365 remove parent parameter from try_dissect_next_protocol()
6367 Change-Id: Ib05b67c8741f90444e773e7c9e1378f00f41dad7
6368 Reviewed-on: https://code.wireshark.org/review/5083
6369 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
6370 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
6373 Author: Martin Kaiser <wireshark@kaiser.cx>
6374 Date: Thu Aug 28 18:24:19 2014 +0200
6376 new function proto_tree_get_parent_tree()
6377 it returns the parent tree of a given tree object
6379 Change-Id: I191e0221651ffb5b26df761e9a25075aa0eb2ad3
6380 Reviewed-on: https://code.wireshark.org/review/4954
6381 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
6382 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
6385 Author: Balint Reczey <balint@balintreczey.hu>
6386 Date: Sun Nov 2 20:35:37 2014 +0100
6388 Fix typo: Intrustion -> Intrusion
6390 Change-Id: Iea95556a4d77ff54d46a505903e50134f51d563a
6391 Reviewed-on: https://code.wireshark.org/review/5082
6392 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6395 Author: Guy Harris <guy@alum.mit.edu>
6396 Date: Sun Nov 2 11:26:15 2014 -0800
6400 Change-Id: Icc18cd7369bae21629aafd5631a373485ef75dea
6401 Reviewed-on: https://code.wireshark.org/review/5081
6402 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6405 Author: Guy Harris <guy@alum.mit.edu>
6406 Date: Sun Nov 2 10:37:31 2014 -0800
6408 Handle packagemaker being an ordinary command in /usr/bin.
6410 Change-Id: Ic804a0fdb4dc450683f57be4814a347e20ecd401
6411 Reviewed-on: https://code.wireshark.org/review/5079
6412 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6415 Author: Guy Harris <guy@alum.mit.edu>
6416 Date: Sun Nov 2 10:10:17 2014 -0800
6418 Fix syntax, add a check for failure to find PackageMaker, make sure it's a file.
6420 Change-Id: Id5bb23a8c5ebd8a63a51029de541cd32e484029c
6421 Reviewed-on: https://code.wireshark.org/review/5078
6422 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6425 Author: Guy Harris <guy@alum.mit.edu>
6426 Date: Sun Nov 2 09:25:11 2014 -0800
6428 Handle PackageMaker a bit better.
6430 Look for the binary in various places, rather than looking for
6431 particular directories and adding them to the path. That lets us use
6432 the PackageMaker binary from the PackageMaker.app bundle (it can either
6433 be run as a GUI app or from the command line), so you don't have to have
6434 a symlink to it from one of the directories in question.
6436 Change-Id: I1ad701291698544f96d419663f0b4a669876d2f1
6437 Reviewed-on: https://code.wireshark.org/review/5077
6438 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6441 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6442 Date: Sun Nov 2 16:58:39 2014 +0100
6444 RTPS: fix warning: no previous prototype for function ... [-Wmissing-prototypes]
6446 Change-Id: I1943c1446a7bc3381d869514d7802bc0fbb1f6e3
6447 Reviewed-on: https://code.wireshark.org/review/5072
6448 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6451 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6452 Date: Sun Nov 2 16:41:46 2014 +0100
6454 gsm a dtap: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
6456 Change-Id: Ifbe59a51e5fa6158f9073402f1a1ab63df2dfa42
6457 Reviewed-on: https://code.wireshark.org/review/5071
6458 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6461 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6462 Date: Sun Nov 2 16:41:16 2014 +0100
6464 fcels: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
6466 Change-Id: I1c351348399caea313abb94680a610073b3e5af7
6467 Reviewed-on: https://code.wireshark.org/review/5070
6468 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6471 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6472 Date: Sun Nov 2 16:40:02 2014 +0100
6474 lzxpress: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
6476 Change-Id: I028d8877a845af5830b17abfe7eb10d8528b334a
6477 Reviewed-on: https://code.wireshark.org/review/5069
6478 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6481 Author: Gerald Combs <gerald@wireshark.org>
6482 Date: Sun Nov 2 08:06:55 2014 -0800
6484 [Automatic manuf, services and enterprise-numbers update for 2014-11-02]
6486 Change-Id: Idc5360a39ab2f2f0b0827bc6c71f95e2f175d792
6487 Reviewed-on: https://code.wireshark.org/review/5073
6488 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6491 Author: Michael Mann <mmann78@netscape.net>
6492 Date: Sat Nov 1 16:55:25 2014 -0400
6494 Eliminate proto_tree_add_text from several dissectors.
6496 Change-Id: I6d3125f15d268edd47ef74dd655eb86cb25ee52d
6497 Reviewed-on: https://code.wireshark.org/review/5047
6498 Reviewed-by: Michael Mann <mmann78@netscape.net>
6499 Petri-Dish: Michael Mann <mmann78@netscape.net>
6500 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6501 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6504 Author: Pascal Quantin <pascal.quantin@gmail.com>
6505 Date: Sun Nov 2 12:17:58 2014 +0100
6507 DNS: fix Coverity CID 281285 and CID 1238867
6509 Change-Id: Ia5747a5d0c8c63b7471de624c96e546c7bbfbf57
6510 Reviewed-on: https://code.wireshark.org/review/5064
6511 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6512 Reviewed-by: Michael Mann <mmann78@netscape.net>
6515 Author: Pascal Quantin <pascal.quantin@gmail.com>
6516 Date: Sun Nov 2 13:27:37 2014 +0100
6518 Add identification of Windows (Server) 10
6520 Change-Id: I5ab7a4dc67ceac644faead0d9e460e3babaf6355
6521 Reviewed-on: https://code.wireshark.org/review/5067
6522 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6525 Author: Gerald Combs <gerald@zing.org>
6526 Date: Sat Nov 1 20:52:34 2014 -0700
6528 WSUG: Convert ``Customizing'' to AsciiDoc.
6530 Leave most of the content intact for now.
6532 Change-Id: Id00d942f87e0a25e27333ac56eb9b99311694a13
6533 Reviewed-on: https://code.wireshark.org/review/5063
6534 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6537 Author: Pascal Quantin <pascal.quantin@gmail.com>
6538 Date: Sat Nov 1 22:40:41 2014 +0100
6540 DNS: fix dissection of ISDN RR Sub Address field
6543 Change-Id: I3411d4e5ef534a663940974d98c351976005ee8e
6544 Reviewed-on: https://code.wireshark.org/review/5057
6545 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6546 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
6549 Author: Pascal Quantin <pascal.quantin@gmail.com>
6550 Date: Sat Nov 1 22:08:44 2014 +0100
6552 print: do not try to add an empty hex stream to PDML output for a text only hf
6555 Change-Id: If38af2879b9a20f4755a7843f20c7327d66c95b1
6556 Reviewed-on: https://code.wireshark.org/review/5054
6557 Reviewed-by: Evan Huus <eapache@gmail.com>
6558 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
6559 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6562 Author: Michael Mann <mmann78@netscape.net>
6563 Date: Fri Oct 31 12:24:59 2014 -0400
6565 Announce messages should only have a TLV if the message length is > 64.
6567 Also, cleaned up a unnecessary global variable.
6570 Change-Id: I8ef5658eeb1f7a240b508833baac64719af144d8
6571 Reviewed-on: https://code.wireshark.org/review/5029
6572 Reviewed-by: Evan Huus <eapache@gmail.com>
6573 Petri-Dish: Evan Huus <eapache@gmail.com>
6574 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6575 Reviewed-by: Michael Mann <mmann78@netscape.net>
6578 Author: Pascal Quantin <pascal.quantin@gmail.com>
6579 Date: Sat Nov 1 21:09:41 2014 +0100
6581 Ethernet: fix a trivial typo
6583 Change-Id: Ibf623aa9e7153e7d54dda1000face1bac42a0088
6584 Reviewed-on: https://code.wireshark.org/review/5045
6585 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6588 Author: Pascal Quantin <pascal.quantin@gmail.com>
6589 Date: Sat Nov 1 19:21:31 2014 +0100
6591 DNS: fix display of A6 address suffix field
6594 Change-Id: Ibd119177feecd27d0c6baba255e7e3da37b131bd
6595 Reviewed-on: https://code.wireshark.org/review/5043
6596 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
6597 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6598 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6599 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6602 Author: Robert Grange <robionekenobi@bluewin.ch>
6603 Date: Sat Nov 1 11:27:51 2014 +0100
6605 packet-mq: Use value_string_ext for big value string. more struct dissected
6607 Use of value_string_ext for big value_strign array, sort them, to force use the btree search
6608 parse more integer value with value_string
6611 Change-Id: I49625cf2d46e0974cddde2c7b1767cb7d06ec47d
6612 Reviewed-on: https://code.wireshark.org/review/5037
6613 Petri-Dish: Bill Meier <wmeier@newsguy.com>
6614 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6615 Reviewed-by: Bill Meier <wmeier@newsguy.com>
6618 Author: Gerald Combs <gerald@zing.org>
6619 Date: Sat Nov 1 09:53:07 2014 -0700
6621 Qt: Limit the amount of Follow Stream text.
6623 QTextEdit + QTextDocument don't handle large amounts of data very well.
6624 Truncate our displayed text after 2 MB.
6626 Change-Id: I0b549a0b05a490272bc0d34af0f2c6661c548d0f
6627 Reviewed-on: https://code.wireshark.org/review/5042
6628 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6631 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6632 Date: Fri Oct 31 14:16:11 2014 -0400
6634 Don't check the checksum if we're encapsulated in an (ICMP) error packet.
6636 This is the case when an ICMP echo is returned (e.g., because it's too big).
6638 This effectively applies SVN rev 36193 to ICMPv6.
6641 Change-Id: I29aeaabc2467c818714df448e39b3a93027c8961
6642 Reviewed-on: https://code.wireshark.org/review/5030
6643 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
6644 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6645 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6648 Author: Stig Bjørlykke <stig@bjorlykke.org>
6649 Date: Wed Oct 15 11:54:05 2014 +0200
6651 Validate no_of_bits in ws_sign_ext32 and ws_sign_ext64
6653 The result of the '<<' expression is undefined if no_of_bits - 1 is negative.
6655 Change-Id: I3fff09afe414bdd9d6736ee351f1c542c503b93d
6656 Reviewed-on: https://code.wireshark.org/review/4698
6657 Reviewed-by: Evan Huus <eapache@gmail.com>
6658 Petri-Dish: Evan Huus <eapache@gmail.com>
6659 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6660 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6663 Author: Michal Labedzki <michal.labedzki@tieto.com>
6664 Date: Fri Oct 24 15:48:35 2014 +0200
6666 Translations: Update Polish translation
6668 Still not complete, but almost complete.
6670 Change-Id: I6e793c4f6648b423a42841347d22073c0b079767
6671 Reviewed-on: https://code.wireshark.org/review/5040
6672 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
6675 Author: Michal Labedzki <michal.labedzki@tieto.com>
6676 Date: Sat Oct 25 18:59:41 2014 +0200
6678 Qt: Fix build with Qt < 4.8
6680 Change-Id: I13d4addb16c5c2790703feb63666367d39f36682
6681 Reviewed-on: https://code.wireshark.org/review/5039
6682 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
6685 Author: Michal Labedzki <michal.labedzki@tieto.com>
6686 Date: Fri Oct 24 15:48:56 2014 +0200
6688 Bluetooth: Fix AVRCP UUID
6690 Change-Id: Iaddde4a1ce49b46e4473c1a470760d9cbbe8000e
6691 Reviewed-on: https://code.wireshark.org/review/5038
6692 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
6695 Author: AndersBroman <anders.broman@ericsson.com>
6696 Date: Fri Oct 31 10:10:38 2014 +0100
6698 Missed cahnges from last commit:
6699 - Replace some deprecated APIs
6701 Change-Id: If815e7191afb445c474a59cf1e3af603fc7b0b28
6702 Reviewed-on: https://code.wireshark.org/review/5018
6703 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6706 Author: Guy Harris <guy@alum.mit.edu>
6707 Date: Fri Oct 31 19:50:42 2014 -0700
6709 Set CXXFLAGS to include $VERSION_MIN_FLAGS.
6711 You never know when some library might start using C++, so set CXXFLAGS
6714 Change-Id: I7e49a3446bb6b587e20058be48e06a5f345679c3
6715 Reviewed-on: https://code.wireshark.org/review/5036
6716 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6719 Author: Gerald Combs <gerald@wireshark.org>
6720 Date: Fri Oct 31 16:12:47 2014 -0700
6722 Qt: Better Follow Stream hints.
6724 Show the client and server colors in the hint text.
6726 Change-Id: Iddcda8c3f4f7dc0d8919749aeffc8c09c6445c17
6727 Reviewed-on: https://code.wireshark.org/review/5035
6728 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6731 Author: Gerald Combs <gerald@wireshark.org>
6732 Date: Fri Oct 31 15:49:04 2014 -0700
6734 Qt: Disable our widgets while tapping.
6736 Prevents a crash when changing the spinbox value during the middle of a
6739 Change-Id: I07cea883c72c5975633e4b7046155f9b6de9cc4a
6740 Reviewed-on: https://code.wireshark.org/review/5034
6741 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6744 Author: Guy Harris <guy@alum.mit.edu>
6745 Date: Fri Oct 31 13:08:11 2014 -0700
6747 Don't force a verbose build.
6749 That was probably something I put in while debugging. It can be put
6750 back - or added to some other make command - as necessary.
6752 Change-Id: I184a5b8537c43c87844e6e75f65dd3c0accde9ac
6753 Reviewed-on: https://code.wireshark.org/review/5033
6754 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6757 Author: Guy Harris <guy@alum.mit.edu>
6758 Date: Fri Oct 31 12:27:30 2014 -0700
6760 Undo my personal disabling of the Qt download/build/install.
6762 I did that because I didn't want to wait a day for Qt to build, but
6763 didn't intend to make that change in the official source.
6765 In the longer term, we should perhaps change the script to download and
6766 install a binary package; sadly, their installers can't be made 100%
6767 command-line and automated, but, well, the CMake installer pops up a
6768 dialog, too, and if you don't have Java installed, some of the configure
6769 scripts that check for Java pop up non-blocking "do you want to install
6770 Java?" dialogs from OS X.
6772 Change-Id: I99781d5e54529955bf9363a7ee9d4122403fa955
6773 Reviewed-on: https://code.wireshark.org/review/5032
6774 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6777 Author: Guy Harris <guy@alum.mit.edu>
6778 Date: Fri Oct 31 12:11:22 2014 -0700
6780 For OS X, don't rigidly tie the SDK version to the minimum target version.
6784 https://developer.apple.com/library/mac/documentation/DeveloperTools/Conceptual/cross_development/Configuring/configuring.html#//apple_ref/doc/uid/10000163i-CH1-SW1
6786 the deployment target (minimum target OS version) and SDK version aren't
6787 necessarily the same and, in fact, Apple typically only ship two SDKs
6788 with each Xcode release, so if you want to build for 10.6 with the 10.6
6789 SDK, you have to use a version of Xcode sufficiently old to have the
6792 Here, we instead search for the oldest SDK for an OS whose version is
6793 greater than or equal to the deployment target. Note that this may not
6794 work for X11-based Wireshark, as the X11 libraries can change
6795 incompatibly between releases. (Fortunately, our plan is to kick
6796 X11-based Wireshark to the curb for OS X, removing a large pile of
6797 aggravation for users.)
6799 This also requires some fixes when building Qt and gdk-pixbuf, as some
6800 cases where we were using the minimum OS target version we needed to be
6801 using the SDK version.
6803 For CMake, we're using its native "deployment target" support for OS X,
6804 and hope that it will somehow do the right thing.
6806 Change-Id: Ie8f42c5e4719e7ebdc56b9ba5a330665bee06280
6807 Reviewed-on: https://code.wireshark.org/review/5031
6808 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6811 Author: AndersBroman <anders.broman@ericsson.com>
6812 Date: Fri Oct 31 15:13:36 2014 +0100
6814 Clean up handling of BDC coded numbers a bit.
6816 Change-Id: Ic3d523664e3c78b4ed289b7e5acf3f53614c6d54
6817 Reviewed-on: https://code.wireshark.org/review/5027
6818 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6821 Author: Michael Mann <mmann78@netscape.net>
6822 Date: Fri Oct 31 08:58:52 2014 -0400
6824 Eliminate proto_tree_add_text from packet-gtpv2.c
6826 Change-Id: I127447941e4c926d9194373a405c82145b1392bb
6827 Reviewed-on: https://code.wireshark.org/review/5025
6828 Petri-Dish: Michael Mann <mmann78@netscape.net>
6829 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6830 Reviewed-by: Michael Mann <mmann78@netscape.net>
6833 Author: Michael Mann <mmann78@netscape.net>
6834 Date: Fri Oct 31 09:01:57 2014 -0400
6836 Improve the "guessing" of the hf_ field and encoding values.
6838 Change-Id: Iaa042ef8b794c265870a04f6659720c321978697
6839 Reviewed-on: https://code.wireshark.org/review/5026
6840 Reviewed-by: Michael Mann <mmann78@netscape.net>
6843 Author: Stig Bjørlykke <stig@bjorlykke.org>
6844 Date: Fri Oct 31 13:25:14 2014 +0100
6846 Lua: Only register postdissectors once.
6848 Change-Id: Id41e4ebd19e0b80faa06f628d689bdb77f2b84c9
6849 Reviewed-on: https://code.wireshark.org/review/5023
6850 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
6853 Author: Stig Bjørlykke <stig@bjorlykke.org>
6854 Date: Fri Oct 31 13:03:08 2014 +0100
6856 Remove unused RA_PYTHON_REGISTER and RA_PYTHON_HANDOFF.
6858 Change-Id: Ia2bccb46be79a934dce447ec04dd81e12df9e131
6859 Reviewed-on: https://code.wireshark.org/review/5021
6860 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
6863 Author: AndersBroman <anders.broman@ericsson.com>
6864 Date: Fri Oct 31 13:06:47 2014 +0100
6866 CAMEL: tvb_length... -> tvb_reported_length...
6868 Change-Id: Ia9013127d72f9228b8151338429d9f612ba9a1f4
6869 Reviewed-on: https://code.wireshark.org/review/5020
6870 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6873 Author: AndersBroman <anders.broman@ericsson.com>
6874 Date: Fri Oct 31 10:48:47 2014 +0100
6876 BER: tvb_length... -> tvb_reported_length...
6878 Change-Id: I4868223ab54046977dbe833e6d1a2078d8d2c6d9
6879 Reviewed-on: https://code.wireshark.org/review/5019
6880 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6883 Author: AndersBroman <anders.broman@ericsson.com>
6884 Date: Fri Oct 31 09:58:47 2014 +0100
6887 - packet-dcerpc.c:4664:51: error: unused parameter 'pinfo' [-Werror=unused-parameter]
6888 - packet-dcerpc.c:5083:83: error: unused parameter 'offset' [-Werror=unused-parameter]
6889 - Replace some deprecated APIs
6891 Change-Id: I12cbc92a1f07252ebc3ff638b0a8436b2e226a18
6892 Reviewed-on: https://code.wireshark.org/review/5017
6893 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6896 Author: Guy Harris <guy@alum.mit.edu>
6897 Date: Fri Oct 31 01:50:43 2014 -0700
6899 Fix name of C-Ares source directory & make the name of the -done file match it.
6901 The directory's name begins with "c-ares-", not "cares-". Fix that, and
6902 make the -done file's name begin with "c-ares-" as well.
6904 Change-Id: Ifa178c638ca634ca6b762b12290ccfcc4fa928f9
6905 Reviewed-on: https://code.wireshark.org/review/5015
6906 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6909 Author: Guy Harris <guy@alum.mit.edu>
6910 Date: Fri Oct 31 00:36:39 2014 -0700
6912 The C-Ares "done" file should have a name beginning with cares-.
6914 Fix a presumed copy-and-pasteo.
6916 Change-Id: I6953bfb46741923507bb58b4e48a72d92313e07c
6917 Reviewed-on: https://code.wireshark.org/review/5012
6918 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6921 Author: Michael Mann <mmann78@netscape.net>
6922 Date: Fri Oct 24 22:47:22 2014 -0400
6924 Use tcp_dissect_pdus in DCE/RPC dissector when running atop TCP.
6926 Yes DCE/RPC runs on top of many dissectors, all which need their own fragmentation support, but TCP can give it to you "for free". DCE/RPC protocol format is also very conducive to it.
6929 Change-Id: I0d16854fed3d9c4229c3d2973782f676a51dd719
6930 Reviewed-on: https://code.wireshark.org/review/4923
6931 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6934 Author: Michael Mann <mmann78@netscape.net>
6935 Date: Thu Oct 30 17:08:04 2014 -0400
6937 Sync debian symbol files to current API.
6939 Change-Id: I64b18ac20401f93b6162ecc7ec4935f8b78508f7
6940 Reviewed-on: https://code.wireshark.org/review/5009
6941 Petri-Dish: Michael Mann <mmann78@netscape.net>
6942 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6943 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6946 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6947 Date: Thu Oct 30 09:33:36 2014 +0100
6949 HTTP2: Update to draft-15
6951 * Add new error code (HTTP_1_1_REQUIRED)
6952 * Use hexa value for error code (like the spec)
6953 * Add reference to Alt-SVC spec
6955 Change-Id: Ifbcb32e97168440cb34f59740871b6c896e90461
6956 Reviewed-on: https://code.wireshark.org/review/4992
6957 Reviewed-by: Daniel Stenberg <daniel@haxx.se>
6958 Reviewed-by: Michael Mann <mmann78@netscape.net>
6961 Author: Michael Mann <mmann78@netscape.net>
6962 Date: Thu Oct 30 08:43:24 2014 -0400
6964 Eliminate proto_tree_add_text from packet-fcels.c
6966 Change-Id: Iac322d7c7d66d90994bce377dd8c7e39a36466cf
6967 Reviewed-on: https://code.wireshark.org/review/5003
6968 Petri-Dish: Michael Mann <mmann78@netscape.net>
6969 Reviewed-by: Michael Mann <mmann78@netscape.net>
6972 Author: Martin Kaiser <wireshark@kaiser.cx>
6973 Date: Thu Oct 30 23:13:44 2014 +0100
6975 temporary workaround to stop the fuzz failures
6978 Change-Id: I2132119710392e077f74c92e737e4edce4fcc295
6979 Reviewed-on: https://code.wireshark.org/review/5011
6980 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
6981 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
6984 Author: Gerald Combs <gerald@wireshark.org>
6985 Date: Thu Oct 30 14:36:02 2014 -0700
6987 Add a missing backslash.
6989 Change-Id: Iac79c885fe10805b61512ed2c02cd652f1c3fd7a
6990 Reviewed-on: https://code.wireshark.org/review/5010
6991 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6994 Author: Gerald Combs <gerald@wireshark.org>
6995 Date: Thu Oct 30 13:42:31 2014 -0700
6997 OS X: Don't add libtool control files to the app bundle.
6999 According to https://developer.apple.com/library/mac/technotes/tn2206
7000 the Contents/PlugIns directory should *only* contain executable files.
7001 Only copy .so (and in case we need them) .dylib files.
7003 Change-Id: I01f077735018733926db92e7576f6f4fecb68862
7004 Reviewed-on: https://code.wireshark.org/review/5008
7005 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7008 Author: Michael Mann <mmann78@netscape.net>
7009 Date: Wed Oct 29 17:33:12 2014 -0400
7011 Eliminate proto_tree_add_text from packet-q933.c
7013 Change-Id: If5b85609d3daaf66cbcc15e3127af4e7f5736e52
7014 Reviewed-on: https://code.wireshark.org/review/4995
7015 Petri-Dish: Michael Mann <mmann78@netscape.net>
7016 Reviewed-by: Michael Mann <mmann78@netscape.net>
7019 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7020 Date: Thu Oct 30 14:16:06 2014 -0400
7022 Fix a typo: Unidirected -> Undirected
7024 As reported in https://ask.wireshark.org/questions/37462/possible-mistake-in-bluetooth-low-energy-hci-event-type
7026 Change-Id: Ia6217531208b00c52c89bcb279cbbe67b5163e96
7027 Reviewed-on: https://code.wireshark.org/review/5004
7028 Reviewed-by: Michael Mann <mmann78@netscape.net>
7031 Author: Guy Harris <guy@alum.mit.edu>
7032 Date: Thu Oct 30 12:13:21 2014 -0700
7034 Make the data rate field float, and calculate it for 802.11n.
7037 Change-Id: Ifd4094f308246e92500cc7149c0d42c8496fb9f4
7038 Reviewed-on: https://code.wireshark.org/review/5005
7039 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7042 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7043 Date: Thu Oct 30 11:56:30 2014 -0400
7045 Prohibit ctype APIs (except toupper() which is still used by file.c - make
7048 Also remove a few tabs that were in there.
7050 Change-Id: I1bb2ad726828366a9f7d1a4064b1215b743ad3b5
7051 Reviewed-on: https://code.wireshark.org/review/5000
7052 Reviewed-by: Michael Mann <mmann78@netscape.net>
7055 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7056 Date: Thu Oct 30 11:45:20 2014 -0400
7058 Replace one more isprint() with g_ascii_isprint().
7060 Change-Id: I7d49b0d250a5918a7437a524492e834588c6c8cf
7061 Reviewed-on: https://code.wireshark.org/review/4999
7062 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
7063 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7066 Author: AndersBroman <anders.broman@ericsson.com>
7067 Date: Thu Oct 30 17:40:20 2014 +0100
7069 Add casts to try to please the OSX buildbot.
7071 Change-Id: I66d546ef2dd276bf151b2956ccbe1f2b6c5cb2f5
7072 Reviewed-on: https://code.wireshark.org/review/5002
7073 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7076 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7077 Date: Thu Oct 30 12:01:43 2014 -0400
7079 Tell the user which file __func__ was found in.
7081 Change-Id: Ia69ceaf320cb97447f80a7c090efe6d36262a1c1
7082 Reviewed-on: https://code.wireshark.org/review/5001
7083 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
7086 Author: Michael Mann <mmann78@netscape.net>
7087 Date: Thu Oct 30 11:35:47 2014 -0400
7089 convert_proto_tree_add_text.pl - missed adding an else statement to logic.
7091 Change-Id: I7f31e9ba47d2e94887bd01a84bab356c0c835d92
7092 Reviewed-on: https://code.wireshark.org/review/4998
7093 Reviewed-by: Michael Mann <mmann78@netscape.net>
7096 Author: Matthieu Patou <mat@matws.net>
7097 Date: Fri Oct 10 16:53:20 2014 -0400
7099 Create the compress module for compression functions.
7101 For the moment there is only the lzxpress compression used by DRS
7104 Change-Id: Ifc7e1767934224c0198f0b09caa3efbad979ca1f
7105 Reviewed-on: https://code.wireshark.org/review/4600
7106 Petri-Dish: Anders Broman <a.broman58@gmail.com>
7107 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7108 Reviewed-by: Michael Mann <mmann78@netscape.net>
7111 Author: Michael Mann <mmann78@netscape.net>
7112 Date: Thu Oct 30 11:19:30 2014 -0400
7114 Add logic to determine if a "tvb get" call is used as a parameter to a proto_tree_add_text call. convert_proto_tree_add_text.pl has an easier time determining hf_ field values with a "tvb get" call present, so it's more likely those dissectors will be picked first in eliminating their proto_tree_add_text calls.
7116 Change-Id: I3dd57a73c8e60d8075a6bb987efd52b96b38445c
7117 Reviewed-on: https://code.wireshark.org/review/4997
7118 Reviewed-by: Michael Mann <mmann78@netscape.net>
7121 Author: AndersBroman <anders.broman@ericsson.com>
7122 Date: Thu Oct 30 15:58:58 2014 +0100
7124 Add an RFC reference and fix deprecated API.
7126 Change-Id: I8dcddc6bcbaf462a6e74b76764ea26b7f5b08920
7127 Reviewed-on: https://code.wireshark.org/review/4996
7128 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7131 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7132 Date: Tue Oct 28 21:43:12 2014 -0400
7134 Remove the optional strncasecmp.{h,c} target (for systems that don't have that API).
7136 strncasecmp() has been prohibited for years (in favor of the g_ascii_ version).
7138 Change-Id: I64b7c29099b1c5240757e2026fe3490096a84755
7139 Reviewed-on: https://code.wireshark.org/review/4980
7140 Petri-Dish: Anders Broman <a.broman58@gmail.com>
7141 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7142 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
7145 Author: Guy Harris <guy@alum.mit.edu>
7146 Date: Thu Oct 30 02:03:28 2014 -0700
7148 Dataflow analysis is hard, let's go shopping!
7150 Another case where the compiler didn't figure out that the variables
7151 aren't used if they're not set.
7153 Change-Id: I70bfb06c6d86d41a266a087ece971c40cd697ee9
7154 Reviewed-on: https://code.wireshark.org/review/4994
7155 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7158 Author: Guy Harris <guy@alum.mit.edu>
7159 Date: Thu Oct 30 01:58:15 2014 -0700
7161 Squelch some used-but-not-set warnings (one legitimate, others not).
7163 Also, we don't care how much tagged value data we've read, we just care
7164 whether we've read any or not (EOF reading the first one means "end of
7165 file", EOF reading any of the subsequent ones means "short read").
7167 Change-Id: I2edc54494967b3a88bcc2c79d97eedfded00150d
7168 Reviewed-on: https://code.wireshark.org/review/4993
7169 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7172 Author: Guy Harris <guy@alum.mit.edu>
7173 Date: Thu Oct 30 00:59:31 2014 -0700
7175 Use correct variable.
7177 To check whether data_rate_or_mcs_index is set, check
7178 saw_data_rate_or_mcs_index; we might see a value of 0 for that field
7179 (it's a valid MCS index), so we can't use it as an out-of-band value
7182 Change-Id: I75d7fdb4a90836538c82f56f2afb05c0603278a5
7183 Reviewed-on: https://code.wireshark.org/review/4991
7184 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7187 Author: Guy Harris <guy@alum.mit.edu>
7188 Date: Thu Oct 30 00:06:48 2014 -0700
7190 Extract the center frequency from Peek tagged files.
7192 Change-Id: I44bc278f563264ca20f0250fc3376b6741bdcbfa
7193 Reviewed-on: https://code.wireshark.org/review/4990
7194 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7197 Author: Guy Harris <guy@alum.mit.edu>
7198 Date: Wed Oct 29 23:52:13 2014 -0700
7200 Support the bandwidth and "short GI" fields from Peek tagged files.
7202 Add a number of fields corresponding to components of the radiotap MCS
7203 field, add presence bits for them, and set and dissect the fields
7204 supported by Peek tagged files.
7206 Change-Id: I3fc801a3bc180e1c174d074a794af0f3d338f249
7207 Reviewed-on: https://code.wireshark.org/review/4989
7208 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7211 Author: Guy Harris <guy@alum.mit.edu>
7212 Date: Wed Oct 29 17:08:56 2014 -0700
7214 Handle the MCS index in Peek tagged files.
7216 Use the "MCS index used" extended flag bit to indicate whether the "data
7217 rate or MCS index" field is a data rate or MCS index.
7219 Display the MCS index value if it's present.
7221 (More to come - MCS indices, plus other information, should be used to
7222 calculate the data rate for 11n and beyond.)
7224 Get rid of the hdr_info_t structure while we're at it; just use local
7225 variables for each of the fields.
7227 Change-Id: I546f53a8ebd89078d5f23e1290557b97348aff38
7228 Reviewed-on: https://code.wireshark.org/review/4988
7229 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7232 Author: Guy Harris <guy@alum.mit.edu>
7233 Date: Wed Oct 29 16:03:08 2014 -0700
7235 Expand the 802.11 pseudo-header and support new radio metadata.
7237 Add a set of presence bits, so we can indicate which bits of radio
7238 metadata we do and don't have.
7240 Fill in more radio metadata from capture files, and display it.
7244 Change-Id: Idea2c05442c74af17c14c4d5a8d8025ab27fbd15
7245 Reviewed-on: https://code.wireshark.org/review/4987
7246 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7249 Author: Guy Harris <guy@alum.mit.edu>
7250 Date: Wed Oct 29 10:53:49 2014 -0700
7252 Rename the strnatcmp.c routines and make them use the g_ascii_XXX() routines.
7254 Rename strnatcmp()/strnatcasecmp() to ws_ascii_XXX(), and make them use
7255 the g_ascii_XXX() routines rather than ctype.h routines, to eliminate
7256 locale-dependent behavior.
7258 (If you want locale-dependent "natural order" sorting, you probably want
7259 "dictionary order" sorting, which is more complicated than just natural
7262 Change-Id: I837f2776b2a909b547dc9a6072e497911b5380e5
7263 Reviewed-on: https://code.wireshark.org/review/4985
7264 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7267 Author: AndersBroman <anders.broman@ericsson.com>
7268 Date: Wed Oct 29 16:43:43 2014 +0100
7270 Replace isalpha() with g_ascii_isprint().
7272 Change-Id: I416fd36f65ee80a0b17939bc081ddae0f3f72a32
7273 Reviewed-on: https://code.wireshark.org/review/4984
7274 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7277 Author: AndersBroman <anders.broman@ericsson.com>
7278 Date: Wed Oct 29 16:27:42 2014 +0100
7280 Don't include ctype.h and replace isascii() with _ascii_isprint().
7281 Remove deprecated APIs while at it.
7283 Change-Id: I002ed4a696782caaeeb70a3e4ced4ae81f3d5372
7284 Reviewed-on: https://code.wireshark.org/review/4983
7285 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7288 Author: Alex Tessmer <dev@tessmer.me>
7289 Date: Wed Oct 29 01:57:17 2014 -0700
7291 VXLAN: Fix flag bitmasks
7293 Fix bitmask for flags bits 0-2.
7295 Change-Id: Id7c42a79f0524eae103a586a16b89ccecf031d6f
7296 Reviewed-on: https://code.wireshark.org/review/4982
7297 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7300 Author: AndersBroman <anders.broman@ericsson.com>
7301 Date: Wed Oct 29 09:36:06 2014 +0100
7303 Add missing stuff for custom plugins.
7305 Change-Id: I34a35fe789d473b630b80c4f8f30833e0e04d188
7306 Reviewed-on: https://code.wireshark.org/review/4981
7307 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7310 Author: Gerald Combs <gerald@wireshark.org>
7311 Date: Tue Oct 28 17:10:45 2014 -0700
7313 Qt: Better protocol highlight colors.
7315 Use the "Window" palette colors for protocol-level highlighting.
7317 Change-Id: Ife55d70041aa12110a00782d790be0d747b32562
7318 Reviewed-on: https://code.wireshark.org/review/4979
7319 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7322 Author: Gerald Combs <gerald@wireshark.org>
7323 Date: Tue Oct 28 12:00:44 2014 -0700
7325 Qt: Add a set of 2x 16-pixel toolbar icons.
7327 Optimize the toolbar PNGs.
7329 To do: The rest of the PNGs.
7331 Change-Id: Ieed8b0d099655994d43cdc9cf6c9a094d84c1802
7332 Reviewed-on: https://code.wireshark.org/review/4978
7333 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7336 Author: Guy Harris <guy@alum.mit.edu>
7337 Date: Tue Oct 28 12:02:46 2014 -0700
7339 Get rid of unnecessary include of <wsutil/strnatcmp.h>.
7341 Change-Id: I60d5630478ccc185b9eed8066a902c6599421fad
7342 Reviewed-on: https://code.wireshark.org/review/4977
7343 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7346 Author: Guy Harris <guy@alum.mit.edu>
7347 Date: Tue Oct 28 11:36:38 2014 -0700
7349 Use guint8 for 8-bit unsigned numeric values.
7351 That slightly better expresses the intent.
7353 Also, fix the message printed for bad bytes in a field name to handle
7354 bytes that are bad because they don't correspond to printable ASCII
7357 Change-Id: I01f232c35bbbe30286999b6c607bfcf3d491453d
7358 Reviewed-on: https://code.wireshark.org/review/4976
7359 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7362 Author: Guy Harris <guy@alum.mit.edu>
7363 Date: Tue Oct 28 11:18:40 2014 -0700
7365 Use g_ascii_isalnum() rather than isalnum().
7367 Only *ASCII* alphanumerics are allowed in filterable field names, so use
7368 g_ascii_isalnum() to check for them. That avoids issues with characters
7369 with the 8th bit set and avoids locale-dependent behavior.
7371 Change-Id: I4e3c4eec907f5e576629229fcf154fcf728b7a2e
7372 Reviewed-on: https://code.wireshark.org/review/4973
7373 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7376 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7377 Date: Tue Oct 28 11:15:57 2014 -0400
7379 Add some new features to the list and regenerate NEWS.
7381 Change-Id: I8d0897e63b44c8077b7488b8c8b7a3df0adf37a1
7382 Reviewed-on: https://code.wireshark.org/review/4971
7383 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7386 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
7387 Date: Tue Oct 28 11:19:23 2014 -0400
7389 Add GPLv2+ license header to keep license-check happy.
7391 This change must be reviewed/approved by the script's author (Gerald).
7393 Change-Id: Id89c1d05bf43cdd2d6823b5ef46162a9f11fb263
7394 Reviewed-on: https://code.wireshark.org/review/4972
7395 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7398 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7399 Date: Tue Oct 28 00:02:16 2014 +0100
7401 Pref: Remove unsued function
7403 Fix also warning: no previous prototype for 'prefs_get_uint_preference' [-Wmissing-prototypes]
7405 Change-Id: I4626372a9c131584c515a43e73aa019e2f696d29
7406 Reviewed-on: https://code.wireshark.org/review/4960
7407 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7410 Author: alage <sphinxs1988@googlemail.com>
7411 Date: Mon Oct 20 14:12:59 2014 +0200
7413 Patch for KNXnet/IP dissector
7415 -removed some proto_tree_add_bits_itemand used bitmaks instead
7416 -fixed KNX Groupaddress decoding
7417 -improved apci decoding
7418 -filternames changed
7420 Change-Id: I2593d54c5e94141445e9e8f32204848e9f48ff6a
7421 Reviewed-on: https://code.wireshark.org/review/4874
7422 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7425 Author: Guy Harris <guy@alum.mit.edu>
7426 Date: Tue Oct 28 00:24:49 2014 -0700
7428 Add a comment showing mapping to radiotap.
7430 Useful if we try to provide some "standard" 802.11 metadata header that
7431 can support both radiotap and Peek tagged (and perhaps others).
7433 Change-Id: Ibac9829e3411670a439db7cb77e1694a5641b0a5
7434 Reviewed-on: https://code.wireshark.org/review/4970
7435 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7438 Author: Michael Mann <mmann78@netscape.net>
7439 Date: Wed Oct 22 08:53:07 2014 -0400
7441 Refactor pinfo->circuit_id from H.223 dissector.
7443 Change-Id: Id63e0088047c7948fd190ba4dd5fbcb536e0cc6b
7444 Reviewed-on: https://code.wireshark.org/review/4921
7445 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7448 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7449 Date: Sun Oct 26 11:08:35 2014 +0100
7451 DNS NXT RR is parsed incorrectly
7453 The queries RRs and answers RRs are parsed fine.
7454 However, only the first 2 authoritative RRs are parsed and none of the 3 additional RRs are parsed.
7455 The second authoritative RR is of type NXT, and even though it has data length of 9, Wireshark reads all the bytes until the end of the packet as if they are part of bitmap in this RR (it reads 317 bytes too many).
7456 This causes it to not parse the rest of the RRs correctly.
7461 Change-Id: I22e5987c44a11399b07c3106fbb70c6e9e867afe
7462 Reviewed-on: https://code.wireshark.org/review/4940
7463 Reviewed-by: Michael Mann <mmann78@netscape.net>
7464 Petri-Dish: Michael Mann <mmann78@netscape.net>
7465 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7466 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7469 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7470 Date: Wed Aug 20 12:40:16 2014 +0200
7472 ISIS: Display code/type and length for unknown code/type
7474 Change-Id: Idb70d571ae7d7f5fc87c08012ab380d35b2856a0
7475 Reviewed-on: https://code.wireshark.org/review/4961
7476 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7479 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7480 Date: Mon Oct 27 13:42:37 2014 +0100
7482 HPSW: Fix display of wrong length
7484 Change-Id: Iaa0cff55b4f8bbdd50eec665c134a2f21e21f9d4
7485 Reviewed-on: https://code.wireshark.org/review/4951
7486 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7489 Author: Guy Harris <guy@alum.mit.edu>
7490 Date: Mon Oct 27 23:49:28 2014 -0700
7492 Some additional information from bug 10637.
7494 That bug includes a capture and a screendump of OmniPeek's dissection of
7495 the packet in that capture; this lets us identify some tags as the
7496 center frequency of the 802.11 channel and a set of extended flags used
7497 for 802.11n and 802.11ac.
7499 Show some flags from bug 9586, under the assumption that certain fields
7500 in the Peek tagged header correspond to certain fields in the remote
7503 Change-Id: I0f3c2e6638d6cf5f6ec470d65bd574171a2d958d
7504 Reviewed-on: https://code.wireshark.org/review/4969
7505 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7508 Author: Guy Harris <guy@alum.mit.edu>
7509 Date: Mon Oct 27 23:41:13 2014 -0700
7511 Bug 9586 says bit 0x00000100 in the "802.11n flags" means "802.11ac".
7513 Also, the 0x00000100 flag is "MCS index used", if a dissection of an
7514 802.11n frame by OmniPeek is to be believed and if the "802.11n flags"
7515 have the same meaning in Peek tagged files and in the Peek remote
7518 Rename that field to "extended flags", as it's not just for 802.11n, add
7519 the "802.11ac" flag, and rename the "future use" flag.
7521 Change-Id: I605622801450d5d114c3c971c98960b198346bdd
7522 Reviewed-on: https://code.wireshark.org/review/4968
7523 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7526 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7527 Date: Tue Oct 28 00:01:08 2014 +0100
7529 MAUSB: fix warning: no previous prototype for 'proto_register_wfa_oui' [-Wmissing-prototypes]
7531 Change-Id: I86cc9f6f9cd50a6e081aabc10bce077281eb2d76
7532 Reviewed-on: https://code.wireshark.org/review/4959
7533 Reviewed-by: Sean Stalley <seanstalley@gmail.com>
7534 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7537 Author: Gerald Combs <gerald@wireshark.org>
7538 Date: Mon Oct 27 20:59:31 2014 -0700
7542 Change-Id: I1802fd4e53132e76534b6dadbaa9713249af42e5
7543 Reviewed-on: https://code.wireshark.org/review/4966
7544 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7547 Author: Guy Harris <guy@alum.mit.edu>
7548 Date: Mon Oct 27 20:59:53 2014 -0700
7550 The "data rate" field in the 11n version of the header is an MCS index.
7552 Change-Id: I5f23bec128444b6590b5fc938bbe0e8a679cd31b
7553 Reviewed-on: https://code.wireshark.org/review/4965
7554 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7557 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7558 Date: Mon Oct 27 13:43:15 2014 +0100
7560 HPSW: Fix soft-deprecated APIs warning
7562 Change-Id: I2f69781972fe2737e09d275dc842c4ea744e7fb1
7563 Reviewed-on: https://code.wireshark.org/review/4952
7564 Reviewed-by: Evan Huus <eapache@gmail.com>
7567 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7568 Date: Mon Oct 27 23:59:37 2014 +0100
7570 Knxnetip: fix warning: ISO C does not allow extra ';' outside of a function
7572 Change-Id: I43da305fcf7b8a18699ab1c14ba2b7868aa8897b
7573 Reviewed-on: https://code.wireshark.org/review/4958
7574 Reviewed-by: Evan Huus <eapache@gmail.com>
7577 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7578 Date: Mon Oct 27 23:57:59 2014 +0100
7580 Infiniband: fix warning: C++ style comments are not allowed in ISO C90
7582 Change-Id: I706d6b7cf4c8d0367f485b55fa11a905bff426d1
7583 Reviewed-on: https://code.wireshark.org/review/4957
7584 Reviewed-by: Evan Huus <eapache@gmail.com>
7587 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7588 Date: Mon Oct 27 23:57:05 2014 +0100
7590 Couchbase: fix no previous prototype for ... [-Wmissing-prototypes]
7592 Change-Id: Ieaefb9d50bf0224f4e90585d138867d0b88d5814
7593 Reviewed-on: https://code.wireshark.org/review/4956
7594 Reviewed-by: Evan Huus <eapache@gmail.com>
7597 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7598 Date: Mon Oct 27 23:56:14 2014 +0100
7600 AllJoyn: fix warning: no previous prototype for 'add_padding_item' [-Wmissing-prototypes]
7602 Change-Id: Id18ac125390efa22638845083f7d0d5eaf71cb97
7603 Reviewed-on: https://code.wireshark.org/review/4955
7604 Reviewed-by: Evan Huus <eapache@gmail.com>
7607 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7608 Date: Tue Oct 28 00:10:46 2014 +0100
7610 TN5250: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
7612 Change-Id: Ida9f7198d6e3ef7bab5d787883116600019180ec
7613 Reviewed-on: https://code.wireshark.org/review/4963
7614 Reviewed-by: Evan Huus <eapache@gmail.com>
7617 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
7618 Date: Tue Oct 28 00:10:24 2014 +0100
7620 ADB_cs: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
7622 Change-Id: I88e191c9eaf5f81b3d6d905ec9e7b7d27f0d21a3
7623 Reviewed-on: https://code.wireshark.org/review/4962
7624 Reviewed-by: Evan Huus <eapache@gmail.com>
7627 Author: Gerald Combs <gerald@wireshark.org>
7628 Date: Mon Oct 27 17:32:26 2014 -0700
7630 Qt: Add a set of 2x 24-pixel toolbar icons.
7632 Add a script to create each PNG from its source SVG using Inkscape
7633 (which can conveniently be run from the command line).
7635 Change-Id: Ief7410cf76fb1553ce56f1c6bc1ade03ab5db1d6
7636 Reviewed-on: https://code.wireshark.org/review/4964
7637 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7640 Author: Gerald Combs <gerald@wireshark.org>
7641 Date: Mon Oct 27 10:28:45 2014 -0700
7643 Qt: Add bits display support to the byte view.
7645 Add todo items for showing and hiding the offset, hex/bits, and
7646 ASCII/EBCDIC sections and adding UTF-8 support.
7648 Change-Id: Ia40faf3f939ef1a8fca6fac827057bd89045482a
7649 Reviewed-on: https://code.wireshark.org/review/4949
7650 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7653 Author: Michael Mann <mmann78@netscape.net>
7654 Date: Sun Oct 26 23:16:30 2014 -0400
7656 Add enumerated value 639 to vals_parm_PID.
7658 Per http://www.nowsms.com/discus/messages/1/EMI_UCP_Specification_40-8156.pdf
7661 Change-Id: I55957f7b77b3dcf8c65c288791fed6428a1f4ba5
7662 Reviewed-on: https://code.wireshark.org/review/4944
7663 Reviewed-by: Michael Mann <mmann78@netscape.net>
7666 Author: Gerald Combs <gerald@zing.org>
7667 Date: Sun Oct 26 18:48:14 2014 -0700
7669 Qt: ByteViewText hover information.
7671 When the user hovers over a byte view field, highlight it and show a
7672 description in the status bar.
7674 Add a "byte" status bar context and fix a label stack pop bug.
7676 Keep proto_find_field_from_offset from matching generated items.
7677 Otherwise hovering and selecting finds things like GeoIP entries and
7678 checksum validation information. This affects the GTK+ UI as well.
7680 Change-Id: Ic81c0d8159510a72d30c41f961807d8a48d05e16
7681 Reviewed-on: https://code.wireshark.org/review/4943
7682 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7685 Author: Martin Kaiser <wireshark@kaiser.cx>
7686 Date: Sun Oct 26 23:27:22 2014 +0100
7688 SSL 3.0 and TLS ciphersuite values are two bytes long
7690 Change-Id: I3ea2846fd4273efe654358ad4a317cb9b3670181
7691 Reviewed-on: https://code.wireshark.org/review/4942
7692 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
7693 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
7696 Author: Martin Kaiser <wireshark@kaiser.cx>
7697 Date: Sun Oct 26 23:24:28 2014 +0100
7699 add TLS_FALLBACK_SCSV
7701 Change-Id: I02ef08b6726f935d79cd3ca4f10ead5f1d18ee20
7702 Reviewed-on: https://code.wireshark.org/review/4941
7703 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
7704 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
7707 Author: Gerald Combs <gerald@wireshark.org>
7708 Date: Sun Oct 26 08:06:15 2014 -0700
7710 [Automatic manuf, services and enterprise-numbers update for 2014-10-26]
7712 Change-Id: If2287edfd2a5b1ddcb6e365485020805aaf9cd88
7713 Reviewed-on: https://code.wireshark.org/review/4937
7714 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7717 Author: Michael Mann <mmann78@netscape.net>
7718 Date: Sat Oct 25 19:44:56 2014 -0400
7720 Various Mobile IPv6 bugfixes
7722 Most of this was found by Boaz Brickner, but to prevent a few more bug reports, I tried to find any remaining MIPv6 options that used -1 to read until "end of packet" instead of "end of option"
7724 1. Option-Code and Reserved fields should be 1 byte, not 2 in Local Mobility Anchor Address mobility option
7725 2. IPv6 AUTH mobility option parses Mobility SPI
7726 3. IPv6 MESG-ID (should just be a timestamp field)
7727 4. IPv6 Redirect Mobility Option K and N bits are parsed incorrectly
7729 5. The following options had a field that read until the end of the packet instead of the end of the option:
7731 AUTH Authentication Data
7733 Permanent Home Keygen Token
7736 Experimental Mobility Option
7745 Change-Id: I14c984a237efc1d1a09618d9a4a1caef1eaf8df0
7746 Reviewed-on: https://code.wireshark.org/review/4932
7747 Petri-Dish: Michael Mann <mmann78@netscape.net>
7748 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7749 Reviewed-by: Michael Mann <mmann78@netscape.net>
7752 Author: Sean O. Stalley <sean.stalley@intel.com>
7753 Date: Mon Oct 13 16:09:09 2014 -0700
7755 Use Wifi Alliance OUI for MA USB packets over SNAP
7757 Change-Id: Icf4c995c8fbdb886e8b4e79a1fc7b62ac7137a07
7758 Reviewed-on: https://code.wireshark.org/review/4667
7759 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
7760 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7761 Reviewed-by: Michael Mann <mmann78@netscape.net>
7764 Author: Gerald Combs <gerald@zing.org>
7765 Date: Sat Oct 25 17:19:38 2014 -0700
7767 Use better theme-derived colors. Switch back to AlternateBase for
7768 protocol-level highlighting.
7770 Change-Id: I3de3442885b93093c3a4f5341080713a2039cd4c
7771 Reviewed-on: https://code.wireshark.org/review/4933
7772 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7775 Author: Joseph Huffman <jhuffman@codeaurora.org>
7776 Date: Tue Oct 21 11:23:45 2014 -0700
7778 Added support for AllJoyn Reliable Datagram Protocol.
7780 Change-Id: I3ec37d7aec0c51f9bd0791c8fa0c5ef3dabc9fbf
7781 Signed-off-by: Joseph Huffman <jhuffman@qce.qualcomm.com>
7782 Reviewed-on: https://code.wireshark.org/review/4414
7783 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
7784 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
7785 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7786 Reviewed-by: Michael Mann <mmann78@netscape.net>
7789 Author: Guy Harris <guy@alum.mit.edu>
7790 Date: Sat Oct 25 16:08:02 2014 -0700
7794 Change-Id: I92348f98cd04ff0e7fc05e472075315ca0fd260e
7795 Reviewed-on: https://code.wireshark.org/review/4931
7796 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7799 Author: Guy Harris <guy@alum.mit.edu>
7800 Date: Sat Oct 25 15:40:50 2014 -0700
7802 Get rid of a trailing blank.
7804 Change-Id: I7963f05a78ec764a21d388fcdba618ffbcf935e4
7805 Reviewed-on: https://code.wireshark.org/review/4930
7806 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7809 Author: Guy Harris <guy@alum.mit.edu>
7810 Date: Sat Oct 25 15:38:27 2014 -0700
7814 Change-Id: I55002477a416710592a482725af68cdf2511e063
7815 Reviewed-on: https://code.wireshark.org/review/4929
7816 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7819 Author: Gerald Combs <gerald@zing.org>
7820 Date: Sat Oct 25 13:06:05 2014 -0700
7822 More offset color adjustments.
7824 Change-Id: I52cf406443988624fb0e4a9e180963c599c8b91d
7825 Reviewed-on: https://code.wireshark.org/review/4928
7826 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7829 Author: Gerald Combs <gerald@zing.org>
7830 Date: Sat Oct 25 12:36:32 2014 -0700
7832 Qt: ByteViewText fixups.
7834 Calculate our X coordinate using floating point arithmetic. This should
7835 hopefully fix the wierd subpixel text shifting for some font sizes.
7837 Add alpha blending convenience routines to ColorUtils. Use them to
7838 create the offset colors. The button color palette wasn't working very
7841 Use QFontMetricsF::lineSpacing for our line height.
7843 Note that we don't support the BOLD gui.hex_dump_highlight_style
7844 preference. Leave a hint for anyone wishing to do so. Comment out
7845 related code for now.
7847 Change-Id: Ief77c9c8d00e05560cae6ecd781bd309027f6f5a
7848 Reviewed-on: https://code.wireshark.org/review/4927
7849 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7852 Author: Evan Huus <eapache@gmail.com>
7853 Date: Sat Oct 25 14:08:57 2014 -0400
7855 ncp2222: initialize buffer in build_expert_data
7857 We do a bunch of conditional logic to fill in the buffer, and then were checking
7858 strlen(buffer) to see if we'd actually filled it in or not, but if we hadn't
7859 then the buffer was garbage and strlen(buffer) was throwing valgrind warnings.
7860 Ensure this works as intended by setting the first byte of the buffer
7861 unconditionally at the beginning, so strlen(buffer) returns 0 as expected in
7865 Change-Id: I6f6c29fbbcb601b6ebccb3a4b312f0fa72c169ae
7866 Reviewed-on: https://code.wireshark.org/review/4924
7867 Reviewed-by: Evan Huus <eapache@gmail.com>
7870 Author: Dario Lombardo <lomato@gmail.com>
7871 Date: Tue Oct 21 16:52:21 2014 +0200
7873 Italian translation fixes
7875 Change-Id: I1dec07f6a3e721a4f35c8cde2da136e34d8e4cb2
7876 Reviewed-on: https://code.wireshark.org/review/4915
7877 Reviewed-by: Evan Huus <eapache@gmail.com>
7878 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
7881 Author: Gerald Combs <gerald@wireshark.org>
7882 Date: Fri Oct 24 13:24:23 2014 -0700
7884 Qt: Refactor ByteViewText.
7886 Instead of subclassing QTextEdit and filling it with the entire contents
7887 of our tvbuff, subclass QAbstractScrollArea and draw text by hand only
7888 when needed. The new code should be *much* faster.
7890 Some code based on QHexView by Even Teran
7891 (https://code.google.com/p/qhexview/).
7894 - Finish the bit view implementation.
7896 Change-Id: Ie44de6870d80711cd44324521a17ab76bcefe5e5
7897 Reviewed-on: https://code.wireshark.org/review/4922
7898 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7901 Author: Pascal Quantin <pascal.quantin@gmail.com>
7902 Date: Tue Oct 21 19:38:25 2014 +0200
7904 ESP: honor enable_null_encryption_decode_heuristic preference when the ESP packet does not match any known SA
7906 Otherwise checking the enable_encryption_decode preference will completely ignore enable_null_encryption_decode_heuristic
7908 Change-Id: I34744ddb2080453dab7cd7d34f47b4984969993c
7909 Reviewed-on: https://code.wireshark.org/review/4897
7910 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
7911 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
7912 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
7915 Author: Michael Mann <mmann78@netscape.net>
7916 Date: Wed Oct 22 09:02:46 2014 -0400
7918 Add a "placeholder protocol" for H.223 to avoid confusion when using Decode As.
7920 The Decode As dialog presents two H.223 options and only "trial and error" can determine if you want bitswapping or not.
7922 Change-Id: I9303c73375d130d3097d347bb374019dfc714068
7923 Reviewed-on: https://code.wireshark.org/review/4909
7924 Reviewed-by: Anders Broman <a.broman58@gmail.com>
7925 Reviewed-by: Michael Mann <mmann78@netscape.net>
7928 Author: Gerald Combs <gerald@wireshark.org>
7929 Date: Thu Oct 23 08:41:39 2014 -0700
7931 OS X: Integrate CMake and osx-app.sh
7933 Add a -cb/--create-bundle option to osx-app.sh which builds the
7934 application bundle. Use it in Autotools. (CMake does this by default.)
7936 Copy over linker flags from configure.ac to CMakeLists.txt to support
7937 rpathification and code signing.
7939 Add an osx-app custom target to CMake.
7941 Change-Id: I6c20a1c27f8954aaea62904b7425b9312d994803
7942 Reviewed-on: https://code.wireshark.org/review/4918
7943 Reviewed-by: Gerald Combs <gerald@wireshark.org>
7946 Author: Guy Harris <guy@alum.mit.edu>
7947 Date: Thu Oct 23 03:27:15 2014 -0700
7949 Don't free global_capture_opts.ifaces_err_info.
7951 Leave it around in case InterfaceTree::display() gets invoked without an
7952 intervening call to scan_local_interfaces() (that would cause a
7953 double-free) or in case scan_local_interfaces() gets called afterwards
7954 (as it frees global_capture_opts.ifaces_err_info before setting it
7955 again, so there's no leak there, but there would be a double-free).
7957 This should prevent at least one crash I've seen.
7959 Change-Id: Iedd3959b420c09971557c473cc87aefd4454078c
7960 Reviewed-on: https://code.wireshark.org/review/4917
7961 Reviewed-by: Guy Harris <guy@alum.mit.edu>
7964 Author: Stig Bjørlykke <stig@bjorlykke.org>
7965 Date: Tue Oct 21 13:36:16 2014 +0200
7967 Lua: Added support for FT_EUI64.
7970 Change-Id: I21da496834b83466585f5b77f87970e3fab28b12
7971 Reviewed-on: https://code.wireshark.org/review/4894
7972 Reviewed-by: Michael Mann <mmann78@netscape.net>
7973 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
7974 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
7977 Author: Pascal Quantin <pascal.quantin@gmail.com>
7978 Date: Wed Oct 22 19:48:34 2014 +0200
7980 Couchbase: fix some warnings found by the pre-commit hook
7982 Change-Id: I16c8f5690973465728071abdf85c0f275433951e
7983 Reviewed-on: https://code.wireshark.org/review/4913
7984 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
7987 Author: Gerald Combs <gerald@wireshark.org>
7988 Date: Wed Oct 22 10:05:35 2014 -0700
7990 Qt: Show / hide main widgets.
7992 Remove existing code which uses the visibilityChanged signal. It exists
7993 in QToolbar but not QWidget. Use the actions to drive visibility
7996 Update MainWindow::layoutPanes to respect "recent" settings.
7998 Move the show / hide actions to the top of the View menu to match GTK+.
8000 Change-Id: I670682e2a094945dbd36c80f43cd14515bbca5a6
8001 Reviewed-on: https://code.wireshark.org/review/4911
8002 Petri-Dish: Gerald Combs <gerald@wireshark.org>
8003 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8004 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8007 Author: Pascal Quantin <pascal.quantin@gmail.com>
8008 Date: Wed Oct 22 19:45:36 2014 +0200
8010 Couchbase: fix FSF address and reorder opcode_vals array
8012 Change-Id: I41448f9a111dde24c29984d8e4f053fc2a668c9e
8013 Reviewed-on: https://code.wireshark.org/review/4912
8014 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
8017 Author: AndersBroman <anders.broman@ericsson.com>
8018 Date: Wed Oct 22 16:14:03 2014 +0200
8020 S1AP: Add an S1AP context to be able to determine which message and
8021 message type an IE was sent in. Needed to dissect proprietarry data.
8023 Change-Id: Ie75a2f6a544cb33e22c42457b0edd83e6456bfe5
8024 Reviewed-on: https://code.wireshark.org/review/4910
8025 Reviewed-by: Anders Broman <a.broman58@gmail.com>
8028 Author: Sergey Avseyev <sergey.avseyev@gmail.com>
8029 Date: Wed Jul 9 15:58:13 2014 +0300
8031 Add Couchbase dissector (binary protocol)
8033 Include new Couchbase Server 3.0 DCP support
8035 Change-Id: I38d0edd7d135a92c130a60dab650aef0ab1205be
8036 Reviewed-on: https://code.wireshark.org/review/2956
8037 Reviewed-by: Michael Mann <mmann78@netscape.net>
8040 Author: Pascal Quantin <pascal.quantin@gmail.com>
8041 Date: Wed Oct 22 14:39:59 2014 +0200
8043 Add packet-adb_service.h to epan/dissectors/Makefile.common
8045 Change-Id: Idfcd18d09cc5aa2572a47117d3788bc3c0368fb3
8046 Reviewed-on: https://code.wireshark.org/review/4908
8047 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
8050 Author: Michal Labedzki <michal.labedzki@tieto.com>
8051 Date: Thu Oct 16 12:34:39 2014 +0200
8053 Bluetooth: A2DP: APT-X does not use RTP while there is no content protection
8055 Change-Id: I5ff8ffdda827b08ee7e284c15e70dadc368b009e
8056 Reviewed-on: https://code.wireshark.org/review/4906
8057 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
8058 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8059 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
8062 Author: Michal Labedzki <michal.labedzki@tieto.com>
8063 Date: Sun Feb 2 19:12:55 2014 +0100
8065 Android: Add ADB dissector
8067 Previoulsy added "adb_cs" is only for adb client <-> adb daemon communication
8068 by loopback interface (by TCP). But there is also communication between
8069 adb daemon and device (by TCP or USB). This transport protocol is different, but
8070 now support is done.
8072 ADB services are shared between ADB and ADB_CS so put them into "adb_service"
8073 dissector. There is still some services to be added.
8075 Change-Id: I754331d3dc6ccf3c17445f5563d01cf2fe1489c7
8076 Reviewed-on: https://code.wireshark.org/review/4651
8077 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
8078 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
8081 Author: Michael Mann <mmann78@netscape.net>
8082 Date: Tue Oct 21 17:14:07 2014 -0400
8084 Replace pinfo->circuit_id will passing data through functions.
8086 Change-Id: I5b35ad57c5c40a1393cbc174384b8a275abd763c
8087 Reviewed-on: https://code.wireshark.org/review/4903
8088 Reviewed-by: Michael Mann <mmann78@netscape.net>
8089 Petri-Dish: Michael Mann <mmann78@netscape.net>
8090 Reviewed-by: Anders Broman <a.broman58@gmail.com>
8093 Author: Michael Mann <mmann78@netscape.net>
8094 Date: Tue Oct 21 21:45:51 2014 -0400
8096 Refactor pinfo->circuit_id behavior for ISUP dissector
8098 Change-Id: Idf6e68c53a0a2126f3906bbfa16166821735fc1b
8099 Reviewed-on: https://code.wireshark.org/review/4904
8100 Reviewed-by: Anders Broman <a.broman58@gmail.com>
8103 Author: Gerald Combs <gerald@zing.org>
8104 Date: Tue Oct 21 20:51:34 2014 -0700
8106 OS X: Fix osx-dmg.sh bundle binary path.
8108 Change-Id: Ia7c59de4f8b59dda9dbc484b8fa9ae0c3d88d594
8109 Reviewed-on: https://code.wireshark.org/review/4905
8110 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8113 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8114 Date: Sun Oct 19 15:35:47 2014 +0200
8116 libnghttp2: Update to 0.6.4
8118 Change-Id: Ic8878f818a89ebc1056777a5b0838e8a5b1215d5
8119 Reviewed-on: https://code.wireshark.org/review/4834
8120 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
8121 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8122 Reviewed-by: Michael Mann <mmann78@netscape.net>
8125 Author: Gerald Combs <gerald@wireshark.org>
8126 Date: Tue Oct 21 13:36:10 2014 -0700
8128 Qt: Fill in time display menu items. Other fixes and updates.
8130 Reselect the current packet when we redraw the packet list.
8132 Don't crash if we try to mark when no frame is selected. Try to
8133 invalidate cached packet list strings when needed. Rename
8134 PacketList::updateAll to redrawVisiblePackets so that its purpose is
8135 more clear. When changing the font size, call redrawVisiblePackets
8136 instead of rebuilding the entire list of visible rows.
8138 Change-Id: I6e7a15067e7063d0efc26082170e1795ae3c0779
8139 Reviewed-on: https://code.wireshark.org/review/4901
8140 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8143 Author: Gerald Combs <gerald@wireshark.org>
8144 Date: Tue Oct 21 16:30:24 2014 -0700
8146 osx-app.sh: Add verbosity.
8148 Change-Id: I3cd1c49909af34badd0d5c5f29bfcddb753ef2bf
8149 Reviewed-on: https://code.wireshark.org/review/4902
8150 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8153 Author: Michael Tüxen <tuexen@wireshark.org>
8154 Date: Tue Oct 21 22:26:15 2014 +0200
8156 Fix the condition for an expert info
8158 The condition triggering an expert info if the reliability
8159 parameter is non-zero, but a reliable data channel is
8160 negotiated was wrong. Now the type field is considered
8162 While there, update the reference.
8164 Change-Id: I1f2f78861d6a44c5334fd44e2038bbfdc52fa919
8165 Reviewed-on: https://code.wireshark.org/review/4900
8166 Reviewed-by: Michael Tüxen <tuexen@wireshark.org>
8169 Author: Martin Kaiser <wireshark@kaiser.cx>
8170 Date: Tue Oct 21 20:03:03 2014 +0200
8172 fix wrong offset for ID Capability Flags 1
8173 reported by Jean-Marc Lamond
8176 Change-Id: I481fad9cd0b8d55e3dd3af00cde2897105547f13
8177 Reviewed-on: https://code.wireshark.org/review/4898
8178 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
8179 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
8182 Author: Martin Kaiser <wireshark@kaiser.cx>
8183 Date: Mon Oct 20 22:56:34 2014 +0200
8185 tn5220: prevent another potential endless loop
8186 exit the loop if dissect_unknown_data() returns 0
8188 Change-Id: I681d170d4daf8efb06231790652ff7c941b46d89
8189 Reviewed-on: https://code.wireshark.org/review/4882
8190 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
8193 Author: Martin Kaiser <wireshark@kaiser.cx>
8194 Date: Tue Oct 21 19:39:39 2014 +0200
8196 no need for if(tree)
8198 Change-Id: I529a601ce83c446247cee1e87386622462f24f56
8199 Reviewed-on: https://code.wireshark.org/review/4896
8200 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
8201 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
8204 Author: Martin Kaiser <wireshark@kaiser.cx>
8205 Date: Mon Oct 20 23:01:22 2014 +0200
8207 no need for continue at the end of a while loop, we loop anyway
8209 Change-Id: I96ff9ee0967fcdb2c8122649a2363a36ea2a2882
8210 Reviewed-on: https://code.wireshark.org/review/4884
8211 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
8214 Author: Gerald Combs <gerald@wireshark.org>
8215 Date: Fri Oct 17 18:56:58 2014 -0700
8217 Make the "-qt" option the default in the OS X packaging scripts.
8219 Change-Id: I1e404c342d06381be71735ff6fbc47e9b2b13899
8220 Reviewed-on: https://code.wireshark.org/review/4895
8221 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8224 Author: AndersBroman <anders.broman@ericsson.com>
8225 Date: Tue Oct 21 11:00:40 2014 +0200
8227 Add OID callback for private IEs making it possible to call a dissector
8228 for the private OID.
8230 Change-Id: Ibb86d8523f1aee14ba1a843ec3ad4becc7729013
8231 Reviewed-on: https://code.wireshark.org/review/4893
8232 Reviewed-by: Anders Broman <a.broman58@gmail.com>
8235 Author: AndersBroman <anders.broman@ericsson.com>
8236 Date: Fri Oct 17 16:54:28 2014 +0200
8238 Add OID dissector table for PER based dissection.
8240 Change-Id: Iaf789017e997eddf7d6dc596eb40fdef413bfd68
8241 Reviewed-on: https://code.wireshark.org/review/4778
8242 Reviewed-by: Anders Broman <a.broman58@gmail.com>
8245 Author: Guy Harris <guy@alum.mit.edu>
8246 Date: Tue Oct 21 00:51:17 2014 -0700
8248 Handle an hfindex of -1.
8250 Code generated by the current version of Pidl dissects bitset fields
8251 twice - once with proto_tree_add_item(), which puts the actual item into
8252 the tree, so that we can create a subtree under it, and once with a
8253 dissect_dcerpc_{type}() routine, to fetch the value and step past the
8254 field. The second call passes an hf_ index value of -1; interpret that
8255 as meaning "don't put this into the protocol tree", rather than just
8256 blindly calling proto_tree_add_XXX with -1 and getting a dissector
8259 Change-Id: I42fc023e77514a8a8a25d5c9db11fa3ef053babf
8260 Reviewed-on: https://code.wireshark.org/review/4892
8261 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8264 Author: Guy Harris <guy@alum.mit.edu>
8265 Date: Mon Oct 20 22:29:11 2014 -0700
8267 With CMake, define WANT_PACKET_EDITOR in config.h.
8269 Just as we do with autotools and nmake, define it in config.h, so it's
8270 defined the same for every single file, rather than defining it in one
8271 particular directory's Makefiles, so that it's defined for some code but
8274 Change-Id: Ic41cd10f2b502e0be76c134cbeaad94dff7623f8
8275 Reviewed-on: https://code.wireshark.org/review/4891
8276 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8279 Author: Guy Harris <guy@alum.mit.edu>
8280 Date: Mon Oct 20 18:25:10 2014 -0700
8282 file.c isn't in a DLL, so what it exports shouldn't be WS_DLL_PUBLIC.
8284 Change-Id: I1fcd0422703d21ce3d0764a23bd491708ffc6785
8285 Reviewed-on: https://code.wireshark.org/review/4890
8286 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8289 Author: Guy Harris <guy@alum.mit.edu>
8290 Date: Mon Oct 20 18:23:32 2014 -0700
8292 Fix the earlier checkin.
8294 Remove some trailing white space while we're at it.
8296 Change-Id: If399077a799e24302640776760b4388687ecad4f
8297 Reviewed-on: https://code.wireshark.org/review/4889
8298 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8301 Author: Guy Harris <guy@alum.mit.edu>
8302 Date: Mon Oct 20 17:57:08 2014 -0700
8304 Fix a number of what appear to be errors.
8306 Add checks for too-short length fields.
8308 Increment the offset after some proto_tree_add_item() calls to skip past
8311 Make some other length calculations use the start of the item to which
8312 the length applies, not the start of the *list* of items.
8314 Fix a double-digit field to be 2 bytes long (as the documentation says
8317 Add a comment about a field that isn't always present but that's
8318 specified in a tn5250_add_hf_items() list.
8320 Fix DEFINE PITCH TABLE to match what the documentation appears to say it
8323 Change-Id: Ibcdc580045c68e8d0d8f35011dfe72b9c245e157
8324 Reviewed-on: https://code.wireshark.org/review/4888
8325 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8328 Author: Gerald Combs <gerald@wireshark.org>
8329 Date: Mon Oct 20 16:11:48 2014 -0700
8331 CMake: Use WIRESHARK_LIB_DIR. Fix GThread check on Windows.
8333 Have FindWSWinLibs check for WIRESHARK_LIB_DIR before WIRESHARK_BASE_DIR
8334 to match the behavior of config.nmake and the Windows buildbots, which
8335 set the former but not the latter.
8337 It looks like the latest GLib DLL contains GThread. Adjust
8338 FindGTHREAD2.cmake accordingly.
8340 Change-Id: I0232b1819eca9ba2c39ae6834daddf65af979d7d
8341 Reviewed-on: https://code.wireshark.org/review/4887
8342 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8345 Author: Guy Harris <guy@alum.mit.edu>
8346 Date: Mon Oct 20 16:36:19 2014 -0700
8348 Export cf_set_frame_edited().
8350 Change-Id: I6569b020ff00d6748840a00ca418653d9e3fdb9b
8351 Reviewed-on: https://code.wireshark.org/review/4886
8352 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8355 Author: Evan Huus <eapache@gmail.com>
8356 Date: Mon Oct 20 16:32:42 2014 -0400
8358 kafka: summarize number of messages in a set
8360 Change-Id: I62873a147426079aa4890289320c43ef7f1b26dc
8361 Reviewed-on: https://code.wireshark.org/review/4877
8362 Reviewed-by: Evan Huus <eapache@gmail.com>
8365 Author: Guy Harris <guy@alum.mit.edu>
8366 Date: Mon Oct 20 14:36:52 2014 -0700
8368 Fix support for writing out edited records.
8370 Add a cf_set_frame_edited() routine to set the record header and data
8371 for a record; have it do all the non-GUI work, and have it set the
8372 file's "unsaved changes" flag.
8374 Have the GUI code just call that routine and then update the title bar
8375 to reflect the unsaved changes.
8377 While we're at it, unmark a no-longer-unused argument to save_record().
8379 Change-Id: Ieb513fdf423b388519527621ecec4cf634b98caf
8380 Reviewed-on: https://code.wireshark.org/review/4885
8381 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8384 Author: Stig Bjørlykke <stig@bjorlykke.org>
8385 Date: Mon Oct 20 22:44:25 2014 +0200
8387 Proto: Fixed proto_unregister_field()
8389 This function did not work after svn revision 51396.
8390 This fix affects http, imf and ldap preferences.
8392 Change-Id: I6fcb24c968d03c7d1fdc018cfa907f9cfd8809bb
8393 Reviewed-on: https://code.wireshark.org/review/4881
8394 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
8397 Author: Martin Kaiser <wireshark@kaiser.cx>
8398 Date: Mon Oct 20 22:37:51 2014 +0200
8400 tn5250: fix an endless loop, exit when offset is not incremented
8403 Change-Id: I64509aa49fce4893dee4e7a74a560e09a98830f6
8404 Reviewed-on: https://code.wireshark.org/review/4878
8405 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
8406 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
8409 Author: Gerald Combs <gerald@wireshark.org>
8410 Date: Mon Oct 20 11:20:54 2014 -0700
8412 OS X: Add retina / hidpi support to Info.plist.
8414 This should partially fix the problem described at
8415 https://ask.wireshark.org/questions/37177/pixelated-ui-on-mac-os-x-with-development-1990
8417 Change-Id: I436aae0d5b681e9ff549d257c2244ee67448ab07
8418 Reviewed-on: https://code.wireshark.org/review/4876
8419 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8422 Author: Evan Huus <eapache@gmail.com>
8423 Date: Mon Oct 20 10:08:56 2014 -0400
8425 kafka: compression codec is unsigned
8427 Change-Id: I238e93dd035caa359fed768aa2aac4df5a0ef47e
8428 Reviewed-on: https://code.wireshark.org/review/4875
8429 Reviewed-by: Evan Huus <eapache@gmail.com>
8432 Author: Guy Harris <guy@alum.mit.edu>
8433 Date: Mon Oct 20 02:03:21 2014 -0700
8435 Don't use toupper() in the test program.
8437 We're not including ctype.h in the test program, so don't use toupper().
8438 The test program might not be built with GLib, so don't use
8439 g_ascii_toupper(), either. Just compare against both 'Y' and 'y'.
8441 Change-Id: Iabc04a5fecb04110c0d16b24a047de72eabbb2bc
8442 Reviewed-on: https://code.wireshark.org/review/4870
8443 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8446 Author: Guy Harris <guy@alum.mit.edu>
8447 Date: Mon Oct 20 01:48:56 2014 -0700
8449 Get rid of another toupper() call in favor of g_ascii_toupper().
8451 Change-Id: If527af69ec96a91c4127c95307c3b93b79b53e2f
8452 Reviewed-on: https://code.wireshark.org/review/4865
8453 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8456 Author: Guy Harris <guy@alum.mit.edu>
8457 Date: Mon Oct 20 01:08:19 2014 -0700
8459 Sign, Flex strikes again; it generates code that produces warnings.
8461 Change-Id: Ibd92bd07e537a4ac19e2a5b159ece0e25aa366b1
8462 Reviewed-on: https://code.wireshark.org/review/4861
8463 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8466 Author: Guy Harris <guy@alum.mit.edu>
8467 Date: Mon Oct 20 00:59:26 2014 -0700
8469 And some more comment cleanup.
8471 Change-Id: Idfc541a08de2ed9e1ca8bccca366612830213ead
8472 Reviewed-on: https://code.wireshark.org/review/4858
8473 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8476 Author: Guy Harris <guy@alum.mit.edu>
8477 Date: Mon Oct 20 00:45:26 2014 -0700
8479 More comment cleanup.
8481 Change-Id: Ifa65c3090e204b93ec526358b863fdf9bafc6a03
8482 Reviewed-on: https://code.wireshark.org/review/4857
8483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8486 Author: Guy Harris <guy@alum.mit.edu>
8487 Date: Mon Oct 20 00:41:35 2014 -0700
8489 Clean up some comments.
8491 Change-Id: Ibe96878ba9ae94f9f22a221797fb36d713286d32
8492 Reviewed-on: https://code.wireshark.org/review/4856
8493 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8496 Author: Guy Harris <guy@alum.mit.edu>
8497 Date: Sun Oct 19 23:14:50 2014 -0700
8499 Get rid of calls to ctype.h functions.
8501 They don't handle values outside the range -1 to 127, and their behavior
8502 is locale-dependent. Use g_ascii_isXXX() and g_ascii_toXXX() instead of
8503 isXXX() and toXXX().
8505 If you're checking for printable ASCII, don't use isascii() and don't
8506 use iscntrl(), use g_ascii_isprint(). If you're checking for graphical
8507 ASCII, i.e. printable ASCII except for a space, use g_ascii_isgraph().
8509 Use ws_xton() to convert a hex digit character to the corresponding
8512 Change-Id: Id3039bc586fbf66d8736c2df248c790c0d7a2330
8513 Reviewed-on: https://code.wireshark.org/review/4851
8514 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8517 Author: Guy Harris <guy@alum.mit.edu>
8518 Date: Sun Oct 19 23:01:17 2014 -0700
8520 Get rid of unnecessary includes of ctype.h.
8522 Change-Id: I2cf49f808558147ce77e7d086558966cfb2defca
8523 Reviewed-on: https://code.wireshark.org/review/4850
8524 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8527 Author: Stig Bjørlykke <stig@bjorlykke.org>
8528 Date: Thu Oct 16 14:04:57 2014 +0200
8530 Check if mask_greatest_bit_offset is within limits.
8532 The result of the '>>' expression is undefined if mask_greatest_bit_offset = 0.
8534 Change-Id: I15b094a5220a5075878bad65ab0b8c5279e80e8a
8535 Reviewed-on: https://code.wireshark.org/review/4723
8536 Reviewed-by: Evan Huus <eapache@gmail.com>
8537 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
8538 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
8539 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8540 Reviewed-by: Michael Mann <mmann78@netscape.net>
8543 Author: Michael Mann <mmann78@netscape.net>
8544 Date: Sun Oct 19 19:41:32 2014 -0400
8546 Eliminate proto_tree_add_text from packet-cdp.c
8548 Change-Id: I77e1f5788e0567dcaef9f75e1f45e61c63d54b4e
8549 Reviewed-on: https://code.wireshark.org/review/4849
8550 Petri-Dish: Michael Mann <mmann78@netscape.net>
8551 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8552 Reviewed-by: Michael Mann <mmann78@netscape.net>
8555 Author: Guy Harris <guy@alum.mit.edu>
8556 Date: Sun Oct 19 16:08:46 2014 -0700
8558 This appears to be clean with my build; see if it needs work with others.
8560 Change-Id: I2c3e3ce8e29b26958d42b66eca3c7539b65695ab
8561 Reviewed-on: https://code.wireshark.org/review/4848
8562 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8565 Author: Guy Harris <guy@alum.mit.edu>
8566 Date: Sun Oct 19 16:00:41 2014 -0700
8568 Eliminate a use of a ctype.h function.
8570 That way, we avoid locale-dependent behavior.
8572 Change-Id: I429fde961dc7cb61013756a663d6cd511f19ca70
8573 Reviewed-on: https://code.wireshark.org/review/4845
8574 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8577 Author: Guy Harris <guy@alum.mit.edu>
8578 Date: Sun Oct 19 15:41:04 2014 -0700
8580 Eliminate use of ctype.h routines.
8582 That way, we don't do locale-sensitive case-insensitivity (yes, the
8583 locale can affect case-mapping - in a Turkish locale, "I" isn't the
8584 upper-case version of "i", for example).
8586 Change-Id: I5f7663e85160558ff3769617f924e45049c9c384
8587 Reviewed-on: https://code.wireshark.org/review/4843
8588 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8591 Author: Guy Harris <guy@alum.mit.edu>
8592 Date: Sun Oct 19 15:39:12 2014 -0700
8594 Get rid of unnecessary include of ctype.h.
8596 Change-Id: I30c4d75e16e1816c4a792e023ffe04f5a970b6d3
8597 Reviewed-on: https://code.wireshark.org/review/4842
8598 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8601 Author: Michael Mann <mmann78@netscape.net>
8602 Date: Sun Oct 19 00:29:35 2014 -0400
8604 Remove unnecessary tvb_ensure_bytes_exist calls.
8606 All of the calls removed are followed by proto_tree_add_xxx calls of the same offset/length of the tvb_ensure_bytes_exist call. The proto_tree_add_xxx calls should throw the exception, so we don't need the "double check".
8607 There are probably more calls that can be removed, these were just obvious as first glance, spurred mostly by noticing the (ab)use in packet-wsp.c
8609 Change-Id: I37cee347c8cf8ab0559e21562c802d3b37f4871e
8610 Reviewed-on: https://code.wireshark.org/review/4833
8611 Petri-Dish: Michael Mann <mmann78@netscape.net>
8612 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8613 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
8616 Author: Gerald Combs <gerald@wireshark.org>
8617 Date: Sun Oct 19 08:05:58 2014 -0700
8619 [Automatic manuf, services and enterprise-numbers update for 2014-10-19]
8621 Change-Id: Ifc13fdb5898cad85ba7cd35c28024f3d4fefe70a
8622 Reviewed-on: https://code.wireshark.org/review/4839
8623 Reviewed-by: Gerald Combs <gerald@wireshark.org>
8626 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8627 Date: Sun Oct 19 16:18:29 2014 +0200
8629 TDS: Make buildbot happy
8631 Fix Field 'Server Version' (tds.server_version) is an integral value (FT_UINT32) but is being displayed as BASE_NONE
8633 Change-Id: I601e71ac8e7928ef90fdd16956af3a34bca269a9
8634 Reviewed-on: https://code.wireshark.org/review/4836
8635 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
8638 Author: Bill Meier <wmeier@newsguy.com>
8639 Date: Sun Oct 19 10:04:39 2014 -0400
8641 packet-amqp.c: Temporary/preliminary fix for Bug #10582 (crash)
8643 This is a temporary/preliminary fix to prevent the buildbot fuzz-test
8644 failures seen when testing the capture file attached to Bug #10582.
8646 As noted in the bug, a complete fix will require some reworking of
8649 Change-Id: I2571f1eeb46a7eede04b8d809e87b95f1ff529df
8650 Reviewed-on: https://code.wireshark.org/review/4835
8651 Reviewed-by: Bill Meier <wmeier@newsguy.com>
8654 Author: Michael Mann <mmann78@netscape.net>
8655 Date: Fri Oct 17 10:11:22 2014 -0400
8657 Eliminate proto_tree_add_text from packet-tds.c
8659 Change-Id: Ib3dc7f8a87e55ef34d4847f4837d645e418607a3
8660 Reviewed-on: https://code.wireshark.org/review/4826
8661 Petri-Dish: Michael Mann <mmann78@netscape.net>
8662 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8663 Reviewed-by: Michael Mann <mmann78@netscape.net>
8666 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8667 Date: Sat Oct 18 15:48:28 2014 +0200
8669 PCAPNG (wiretap): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
8671 Change-Id: I6337fe88bbfd76161abc3b51c70402e7e63a435e
8672 Reviewed-on: https://code.wireshark.org/review/4813
8673 Reviewed-by: Evan Huus <eapache@gmail.com>
8676 Author: Michael Mann <mmann78@netscape.net>
8677 Date: Sat Oct 18 20:45:30 2014 -0400
8679 Eliminate proto_tree_add_text from packet-smpp.c
8681 Change-Id: I6e1e62ff7910be535229d7e1a15557879a5cee1f
8682 Reviewed-on: https://code.wireshark.org/review/4832
8683 Reviewed-by: Michael Mann <mmann78@netscape.net>
8686 Author: Michael Mann <mmann78@netscape.net>
8687 Date: Sat Oct 18 20:45:12 2014 -0400
8689 Eliminate proto_tree_add_text from packet-nhrp.c
8691 Change-Id: I51702e9372551a28ea604d21d4bbf0eb4d9588ae
8692 Reviewed-on: https://code.wireshark.org/review/4831
8693 Reviewed-by: Michael Mann <mmann78@netscape.net>
8696 Author: Michael Mann <mmann78@netscape.net>
8697 Date: Sat Oct 18 18:09:57 2014 -0400
8699 Eliminate proto_tree_add_text from packet-ismp.c
8701 Change-Id: Ie2a395b808a8879625185a6de458f61d386cff55
8702 Reviewed-on: https://code.wireshark.org/review/4830
8703 Reviewed-by: Michael Mann <mmann78@netscape.net>
8706 Author: Michael Mann <mmann78@netscape.net>
8707 Date: Sat Oct 18 09:26:52 2014 -0400
8709 Eliminate proto_tree_add_text from packet-arp.c
8711 Change-Id: Ie9596df97a135b411693eefc39fdbd03316166a0
8712 Reviewed-on: https://code.wireshark.org/review/4828
8713 Petri-Dish: Michael Mann <mmann78@netscape.net>
8714 Reviewed-by: Michael Mann <mmann78@netscape.net>
8717 Author: Michael Mann <mmann78@netscape.net>
8718 Date: Sat Oct 18 13:23:28 2014 -0400
8720 Eliminate proto_tree_add_text from packet-ipx.c
8722 Change-Id: Ie084a33be94d91eec7f5f70ef31fcb0835ad266c
8723 Reviewed-on: https://code.wireshark.org/review/4829
8724 Reviewed-by: Michael Mann <mmann78@netscape.net>
8727 Author: Michael Mann <mmann78@netscape.net>
8728 Date: Sat Oct 18 09:25:33 2014 -0400
8730 Eliminate proto_tree_add_text from packet-igrp.c
8732 Change-Id: If73e3bb924036b7746d15058e9fca6f551f9538c
8733 Reviewed-on: https://code.wireshark.org/review/4827
8734 Petri-Dish: Michael Mann <mmann78@netscape.net>
8735 Reviewed-by: Michael Mann <mmann78@netscape.net>
8738 Author: Stig Bjørlykke <stig@bjorlykke.org>
8739 Date: Thu Oct 9 10:10:36 2014 +0200
8741 Lua: Added ProtoField.none
8743 This field can be used for adding filterable subtree entries.
8745 Change-Id: Id395c9a8194dc00e6544170631b48d71ae9dd33e
8746 Reviewed-on: https://code.wireshark.org/review/4573
8747 Reviewed-by: Evan Huus <eapache@gmail.com>
8748 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
8751 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8752 Date: Sat Oct 18 16:08:58 2014 +0200
8754 IPv6: QuickStart option Nonce is read incorrectly
8756 In Wireshark, the option's TTL field looks ok, but the [TTL diff] field points to the byte after the TTL field, which is part of the nonce field.
8757 The nonce field is being read one byte after where it should be read and so the value being read is incorrect.
8758 Moreover, the option data length says 6 but because of the extra byte being read 7 bytes are being read for this option data and the next option is read one byte later incorrectly so the options after the QuickStart option are being read incorrectly.
8763 Change-Id: Icd836b2a5c2f92cef7b6fea61957a85fca5e3352
8764 Reviewed-on: https://code.wireshark.org/review/4815
8765 Reviewed-by: Michael Mann <mmann78@netscape.net>
8768 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8769 Date: Sat Oct 18 16:55:46 2014 +0200
8771 MIPv6: Mobility Option Mobile Node Link Layer Identifier Link-layer Identifier field is read beyond the option data
8773 there's a single IPv6 packet with Mobile Node Link Layer Identifier mobility option.
8774 The option's data length is 9 but and since the Reserved field takes 2 bytes, the Link Layer Identifier field should take 7 bytes.
8775 However, the Link Layer Identifier field is read until the end of the packet, which is 519 bytes.
8778 Change-Id: I518de7f6b75e5b749cb029845fd4846954ca6d0e
8779 Reviewed-on: https://code.wireshark.org/review/4818
8780 Reviewed-by: Michael Mann <mmann78@netscape.net>
8783 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8784 Date: Sat Oct 18 16:45:01 2014 +0200
8786 MIPv6: Mobility Option Binding Authorization Data for FMIPv6 Authenticator field is read beyond the option data
8788 There's a single IPv6 packet with Binding Authorization Data for FMIPv6 mobility option.
8789 The option's data length is 14 but and since the SPI takes 4 bytes, the Authenticator field should take 10 bytes.
8790 However, the Authenticator field is read until the end of the packet, which is 178 bytes.
8794 Change-Id: Ia79c5131d8477c1a7c111c47c2a94e990bbeae4d
8795 Reviewed-on: https://code.wireshark.org/review/4817
8796 Reviewed-by: Michael Mann <mmann78@netscape.net>
8799 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8800 Date: Sat Oct 18 16:31:01 2014 +0200
8802 MIPv6: Mobility Option IPv6 Address/Prefix marks too many bytes for the address/prefix field
8804 One of the mobility options is the IPv6 Address/Prefix.
8805 The prefix length of this option is 52.
8806 Note that according to RFC 5568, the prefix length is in bits and not in bytes.
8807 The IPv6 Address/Prefix field of this option marks 52 bytes.
8809 In addition, I'm not sure that the IPv6 Address/Prefix field is a variable size field.
8810 RFC 5568 section 6.4.2 has a diagram of this options that shows this field as if it always takes 128 bits, and the prefix length field just says the length of the prefix (not the length of the field).
8815 Change-Id: I2a9a35cb7c537ec3b91c9a089f14fa31f41d8c80
8816 Reviewed-on: https://code.wireshark.org/review/4816
8817 Reviewed-by: Michael Mann <mmann78@netscape.net>
8820 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
8821 Date: Sat Oct 18 15:50:32 2014 +0200
8823 GSM(_a_rr): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
8825 Change-Id: I07fe19af11bff3d001193e4af472c05090728392
8826 Reviewed-on: https://code.wireshark.org/review/4814
8827 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
8830 Author: Mikael Kanstrup <mikael.kanstrup@gmail.com>
8831 Date: Sat Oct 11 22:59:14 2014 +0200
8833 Add support for split wiphy dump to Wireless Toolbar
8835 To populate the Wireless Toolbar menu the NL80211_CMD_GET_WIPHY
8836 command is used. Some network interfaces must use split wiphy dump
8837 feature for this command to function properly. One such example is the
8838 D-Link DWA-160 USB adapter that does not show up when used without.
8840 Make use of split wiphy dump feature whenever kernel supports it
8841 to populate the list of monitor interfaces for the Wireless Toolbar.
8844 Change-Id: Idc28e92f91a2488fa48eeb282a0ef1e2bd40a5f0
8845 Reviewed-on: https://code.wireshark.org/review/4611
8846 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
8847 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8848 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
8851 Author: Hannes Mezger <hannes.mezger@ascolab.com>
8852 Date: Thu Oct 16 19:25:08 2014 +0200
8854 Use proto_tree_add_expert_format instead of proto_tree_add_text
8856 Change-Id: Ia017fa9535cbc7570ce6bd442972eedd2143825a
8857 Reviewed-on: https://code.wireshark.org/review/4729
8858 Petri-Dish: Michael Mann <mmann78@netscape.net>
8859 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8860 Reviewed-by: Michael Mann <mmann78@netscape.net>
8863 Author: David Ameiss <netshark@ameissnet.com>
8864 Date: Tue Oct 14 09:14:41 2014 -0500
8866 Converted numerous proto_tree_add_none_format() calls for bitmask/flag items to proto_tree_add_bitmask().
8867 Correctly set the length of LBT-RM and LBT-RU header blocks.
8868 Various other cosmetic cleanups.
8870 Change-Id: If19bbdeb10176b8059fd4cf657719b3b9817bc6a
8871 Reviewed-on: https://code.wireshark.org/review/4776
8872 Petri-Dish: Michael Mann <mmann78@netscape.net>
8873 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
8874 Reviewed-by: Michael Mann <mmann78@netscape.net>
8877 Author: Joerg Mayer <jmayer@loplof.de>
8878 Date: Sat Oct 18 08:45:14 2014 +0200
8880 Add URL to a description of the attributes
8881 Add comments about additional attributes
8883 Change-Id: Ic73039ee6fde954e147a44e0f98def76a7e88fb3
8884 Reviewed-on: https://code.wireshark.org/review/4812
8885 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
8888 Author: Joerg Mayer <jmayer@loplof.de>
8889 Date: Sat Oct 18 08:39:20 2014 +0200
8891 Commit 54b733ce9a0d1cd4ab9b142479368a5e696360be broke compilation of
8892 echld by removing TS_PREC_AUTO_USEC. Replace its use by TS_PREC_AUTO.
8893 No idea whether that's correct but it compiles again.
8894 Trying to commit this brought complaints by checkapi, so fixed them as
8897 Maybe the echld code should be removed, it seems to be unmaintained.
8899 Change-Id: Id9a0a6fc129abd1b8c93629c31a89c2d9ea2243f
8900 Reviewed-on: https://code.wireshark.org/review/4811
8901 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
8904 Author: Guy Harris <guy@alum.mit.edu>
8905 Date: Fri Oct 17 18:22:05 2014 -0700
8907 Get rid of unnecessary includes of ctype.h.
8909 Change-Id: I9e2cd7a9fed33fc2f4b0c0da3603690450f6952d
8910 Reviewed-on: https://code.wireshark.org/review/4809
8911 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8914 Author: Guy Harris <guy@alum.mit.edu>
8915 Date: Fri Oct 17 17:22:30 2014 -0700
8917 Check for printable ASCII in an ENBName.
8919 I'm not sure why the check is only for alphabetical characters; if
8920 that's correct, change this to use g_ascii_isalpha, and change
8921 is_printable_ascii to is_ascii_alpha or something such as that.
8923 Don't use ctype.h routines, as they are locale-dependent.
8925 Change-Id: I61d0672350d35ad918e95d7e96ed5dd263102da9
8926 Reviewed-on: https://code.wireshark.org/review/4805
8927 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8930 Author: Guy Harris <guy@alum.mit.edu>
8931 Date: Fri Oct 17 17:05:51 2014 -0700
8933 Get rid of unnecessary includes of ctype.h.
8935 Change-Id: Ibf9385715b85186f5c7289165acea7233b3fabde
8936 Reviewed-on: https://code.wireshark.org/review/4804
8937 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8940 Author: Guy Harris <guy@alum.mit.edu>
8941 Date: Fri Oct 17 16:57:28 2014 -0700
8943 Get rid of some no-longer-necessary casts.
8945 g_ascii_isXXX() can be handed a char value safely; they won't try to use
8946 it as an index into a table before checking it.
8948 Change-Id: Icf80163fb5f9dccd0b97917e318b1db0bf3e0cf8
8949 Reviewed-on: https://code.wireshark.org/review/4801
8950 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8953 Author: Guy Harris <guy@alum.mit.edu>
8954 Date: Fri Oct 17 16:42:40 2014 -0700
8956 Don't use ctype.h routines.
8958 That avoids locale dependency and handles possibly-signed chars(which
8959 we weren't always doing before).
8961 Change-Id: I89e50678abb8c3e535081c92ca25bc1bab672c68
8962 Reviewed-on: https://code.wireshark.org/review/4798
8963 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8966 Author: Guy Harris <guy@alum.mit.edu>
8967 Date: Fri Oct 17 16:30:56 2014 -0700
8969 Get rid of unnecessary includes of ctype.h.
8971 Change-Id: Ibb194cd839d174af9c96f7bb1e2941b3dd6c1ce1
8972 Reviewed-on: https://code.wireshark.org/review/4797
8973 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8976 Author: Guy Harris <guy@alum.mit.edu>
8977 Date: Fri Oct 17 16:10:53 2014 -0700
8979 Don't use ctype.h routines.
8981 That avoids locale dependency and handles possibly-signed chars (which
8982 we weren't always doing before).
8984 Change-Id: Ieceb93029252f646397b6488f2df8a57c6d2a23d
8985 Reviewed-on: https://code.wireshark.org/review/4794
8986 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8989 Author: Guy Harris <guy@alum.mit.edu>
8990 Date: Fri Oct 17 14:59:09 2014 -0700
8992 strptime.c needs ctype.h.
8994 Change-Id: Icf4020426d3a5e0a6bd2012a266cf07be9928abf
8995 Reviewed-on: https://code.wireshark.org/review/4793
8996 Reviewed-by: Guy Harris <guy@alum.mit.edu>
8999 Author: Guy Harris <guy@alum.mit.edu>
9000 Date: Fri Oct 17 14:27:07 2014 -0700
9002 Get rid of unnecessary include of ctype.h.
9004 Change-Id: Ib83e707ebbbb420ce269a652ede6b7366d24240e
9005 Reviewed-on: https://code.wireshark.org/review/4792
9006 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9009 Author: Guy Harris <guy@alum.mit.edu>
9010 Date: Fri Oct 17 14:22:24 2014 -0700
9012 Get rid of unnecessary includes of ctype.h.
9014 Change-Id: Ic23203f13fd6627b664e8ed1438d328c46328b9f
9015 Reviewed-on: https://code.wireshark.org/review/4790
9016 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9019 Author: Guy Harris <guy@alum.mit.edu>
9020 Date: Fri Oct 17 14:10:52 2014 -0700
9022 Don't use ctype.h routines.
9024 That avoids locale dependency and handles possibly-signed chars (which
9025 we weren't doing before).
9027 Change-Id: I189222eff624ad2d2e960bc0b69f3f22d35f351f
9028 Reviewed-on: https://code.wireshark.org/review/4787
9029 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9032 Author: Guy Harris <guy@alum.mit.edu>
9033 Date: Fri Oct 17 14:04:37 2014 -0700
9035 Get rid of unused includes of <ctype.h>.
9037 Change-Id: Iab9eaeb0f5765748b2582177396264e4e69bc6d1
9038 Reviewed-on: https://code.wireshark.org/review/4786
9039 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9042 Author: Guy Harris <guy@alum.mit.edu>
9043 Date: Fri Oct 17 13:37:11 2014 -0700
9045 Don't use ctype.h routines.
9047 That avoids locale dependency and handles possibly-signed chars (which
9048 we weren't doing before).
9050 Change-Id: I70f3d993c9a8fbf870901f12b430d733968c3fa8
9051 Reviewed-on: https://code.wireshark.org/review/4781
9052 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9055 Author: Hannes Mezger <hannes.mezger@ascolab.com>
9056 Date: Thu Oct 16 20:02:51 2014 +0200
9058 Use proto_tree_add_bitmask for ExpandedNodeId EncodingMask
9060 Instead of adding the items using proto_tree_add_item, use proto_tree_add_bitmask in parseExpandedNodeId(). Also, the redundant 'NodeId ' text is removed from hf_opcua_nodeid_... items for better readability.
9062 Change-Id: Ie68f1d280dd733fd2eede0b2b73ad8d7f28396b3
9063 Reviewed-on: https://code.wireshark.org/review/4730
9064 Reviewed-by: Michael Mann <mmann78@netscape.net>
9067 Author: AndersBroman <anders.broman@ericsson.com>
9068 Date: Fri Oct 17 16:48:48 2014 +0200
9070 SGsAP Update to V12.6.0 except for IE TMSI based NRI container.
9072 Change-Id: Iafb62a27589de1810d4d3bd1e32f1c89898e9171
9073 Reviewed-on: https://code.wireshark.org/review/4777
9074 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9077 Author: Hannes Mezger <hannes.mezger@ascolab.com>
9078 Date: Thu Oct 16 19:06:31 2014 +0200
9080 Add argument 'packet_info *pinfo' to all dissecting functions
9082 Change-Id: Ie02326e365ee3f620fcbe3f2e8e45dc5300d3418
9083 Reviewed-on: https://code.wireshark.org/review/4728
9084 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
9085 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9086 Reviewed-by: Michael Mann <mmann78@netscape.net>
9089 Author: AndersBroman <anders.broman@ericsson.com>
9090 Date: Fri Oct 17 13:57:56 2014 +0200
9092 Dissect CDMA2000 PDU if GCSNA dissector exists.
9094 Change-Id: I866fb9bbc3e94df63231959d6745f3d45ca84020
9095 Reviewed-on: https://code.wireshark.org/review/4772
9096 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9099 Author: AndersBroman <anders.broman@ericsson.com>
9100 Date: Fri Oct 17 10:49:58 2014 +0200
9102 isdigit -> g_ascii_isdigit to make the build work.
9104 Change-Id: I670b7b83976a9db9491e017015d570a4dc8f433d
9105 Reviewed-on: https://code.wireshark.org/review/4771
9106 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9109 Author: Guy Harris <guy@alum.mit.edu>
9110 Date: Fri Oct 17 00:02:08 2014 -0700
9112 Eliminate include of <ctype.h>.
9114 This is not built if we have glibc (as we already have getopt() from
9115 it), and it's not part of glibc, so....
9117 Change-Id: Iae4ff944c78fc55a8cd2eaf523a3696c47b741d7
9118 Reviewed-on: https://code.wireshark.org/review/4769
9119 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9122 Author: Guy Harris <guy@alum.mit.edu>
9123 Date: Thu Oct 16 23:57:03 2014 -0700
9125 Remove unnecessary includes of <ctype.h>.
9127 Change-Id: I8eacec5fa8d57b10d40a3627197461dae89c6cb2
9128 Reviewed-on: https://code.wireshark.org/review/4768
9129 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9132 Author: Guy Harris <guy@alum.mit.edu>
9133 Date: Thu Oct 16 23:53:21 2014 -0700
9135 Use g_ascii_isspace() instead of isascii() && isspace().
9137 This eliminates one more use of <ctype.h> macros; we're using
9138 g_ascii_isXXX() instead of isXXX() elsewhere.
9140 Change-Id: I184caeefab95dda2cf207acf9539eabbd7c32a51
9141 Reviewed-on: https://code.wireshark.org/review/4767
9142 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9145 Author: Guy Harris <guy@alum.mit.edu>
9146 Date: Thu Oct 16 23:41:29 2014 -0700
9148 Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
9150 This avoids locale-dependent tests, and fixes cases where we passed
9151 signed char values to those macros (which is not safe with char being
9152 signed, as it is on most, but not all, platforms).
9154 Change-Id: Iea962cd7e4dfaf33c3c873ba43814cc6ed298d94
9155 Reviewed-on: https://code.wireshark.org/review/4764
9156 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9159 Author: Guy Harris <guy@alum.mit.edu>
9160 Date: Thu Oct 16 23:29:07 2014 -0700
9162 Remove unnecessary include of <ctype.h>.
9164 Change-Id: I596b252d5fb41e654961483cb530754442f25bc7
9165 Reviewed-on: https://code.wireshark.org/review/4763
9166 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9169 Author: Guy Harris <guy@alum.mit.edu>
9170 Date: Thu Oct 16 23:20:52 2014 -0700
9172 Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
9174 This avoids locale-dependent tests, and fixes cases where we passed
9175 signed char values to those macros (which is not safe with char being
9176 signed, as it is on most, but not all, platforms).
9178 Change-Id: I51d9716fe3eb02a6e98208334285c07597a6be79
9179 Reviewed-on: https://code.wireshark.org/review/4761
9180 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9183 Author: Guy Harris <guy@alum.mit.edu>
9184 Date: Thu Oct 16 23:08:42 2014 -0700
9186 Don't use <ctype.h> macros, and eliminate an include of <ctype.h>.
9188 This avoids locale-dependent tests.
9190 Change-Id: I709ff6b1a837fb0390b29f911d3b9ef1015a2d1e
9191 Reviewed-on: https://code.wireshark.org/review/4758
9192 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9195 Author: Guy Harris <guy@alum.mit.edu>
9196 Date: Thu Oct 16 23:01:14 2014 -0700
9198 Don't use ctype.h routines.
9200 That avoids locale dependency and handles possibly-signed chars (which
9201 we weren't doing before).
9203 Change-Id: I2afab254044e0d39dfa67acd840b9fe4ff1e6d08
9204 Reviewed-on: https://code.wireshark.org/review/4756
9205 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9208 Author: Guy Harris <guy@alum.mit.edu>
9209 Date: Thu Oct 16 18:26:03 2014 -0700
9211 Don't use <ctype.h> macros.
9213 They're locale-dependent (although those *particular* ones might not
9216 Remove no-longer necessary (or not-even-necessary-before-this-change)
9217 includes of <ctype.h>
9219 Change-Id: I1384e3ae4ccba6af9220a08773abcde7ea320573
9220 Reviewed-on: https://code.wireshark.org/review/4755
9221 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9224 Author: Guy Harris <guy@alum.mit.edu>
9225 Date: Thu Oct 16 18:21:20 2014 -0700
9227 No need for our own wrappers around tolower() and toupper().
9229 We can just use g_ascii_tolower() and g_ascii_toupper();
9231 Change-Id: I8a88a096d16ce8c60dd9151e5bdddf6747702145
9232 Reviewed-on: https://code.wireshark.org/review/4754
9233 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9236 Author: Guy Harris <guy@alum.mit.edu>
9237 Date: Thu Oct 16 16:41:59 2014 -0700
9239 Use g_ascii_isalnum() rather than isalnum().
9241 That way, we don't have to worry about casting the argument (which, in
9242 one place, was done wrong - casting to int preserves the sign-extension
9243 done with signed chars), and don't have to worry about a locale in which
9244 particular 8-bit byte values are considered alphanumeric characters.
9246 Change-Id: I129b4bfdad70ade4ab6e0a1d2c13d59ae9e6f524
9247 Reviewed-on: https://code.wireshark.org/review/4751
9248 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9251 Author: Guy Harris <guy@alum.mit.edu>
9252 Date: Thu Oct 16 16:03:58 2014 -0700
9254 Just have get_mac_lte_rapid_description() return the description string.
9256 If get_mac_lte_rapid_description() returned FALSE, we always used "" as
9257 the description string; just have it return the string, or return "" if
9258 rapid ranges haven't been configured, and just use the string.
9260 (If the code ever needs to determine in other places whether rapid ranges
9261 have been configured, it can check s_rapid_ranges_configured, or
9262 get_mac_lte_rapid_description() could return NULL in that case and the
9263 code using the string can check for a null value.)
9265 This should squelch some incorrect used-but-not-set warnings from at
9268 Change-Id: I3ed495a4beb4a553e453e7bca764d1d8a07c5e53
9269 Reviewed-on: https://code.wireshark.org/review/4750
9270 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9273 Author: Guy Harris <guy@alum.mit.edu>
9274 Date: Thu Oct 16 14:55:06 2014 -0700
9276 Make sort_alphabet() not fail too badly with characters in [128,255].
9278 Treat all values in the alphabet as unsigned.
9280 Change-Id: I4476c75352f32673a9cd131ea233465f3376fa25
9281 Reviewed-on: https://code.wireshark.org/review/4747
9282 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9285 Author: Martin Kaiser <wireshark@kaiser.cx>
9286 Date: Thu Oct 16 23:23:20 2014 +0200
9288 use supported/unsupported for the bitfield elements
9289 order them from MSB to LSB
9291 Change-Id: Ie758285c2cf5d19e00d6d256c49acca15ce81168
9292 Reviewed-on: https://code.wireshark.org/review/4746
9293 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
9294 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
9297 Author: Martin Kaiser <wireshark@kaiser.cx>
9298 Date: Thu Oct 16 21:58:59 2014 +0200
9300 smartcard descriptor: start a bitfield for the features
9302 Change-Id: I636cfdfcd61d6d5dc041f9dbc657244d94e88b7f
9303 Reviewed-on: https://code.wireshark.org/review/4745
9304 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
9305 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
9308 Author: AndersBroman <a.broman@bredband.net>
9309 Date: Thu Oct 16 22:28:43 2014 +0200
9311 GTPv2 in Complete Request Message call the NAS dissector with a tvb only
9312 containing the IE not the rest of the tvb.
9314 Change-Id: I3eead5047b4f8de47e280ac447c66b110592bccd
9315 Reviewed-on: https://code.wireshark.org/review/4744
9316 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9319 Author: Guy Harris <guy@alum.mit.edu>
9320 Date: Thu Oct 16 13:03:52 2014 -0700
9322 Oops, I missed one "cast a char to int and use it as a subscript" case.
9324 Casting a signed char with a negative value to int will preserve the
9325 value, so it'll still be a negative subscript. Cast to guchar instead,
9326 to make sure 0x80 through 0xFF are treated as 128 to 255, not -128 to
9329 Change-Id: I1f0b33ba3686e963d45317b45465ff335431d17f
9330 Reviewed-on: https://code.wireshark.org/review/4742
9331 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9334 Author: Guy Harris <guy@alum.mit.edu>
9335 Date: Thu Oct 16 12:05:26 2014 -0700
9337 Better fix - just check that the upper and lower nibbles are >= 0xA.
9339 An unsigned 8-bit integer is always <= 0xFF; that was the cause of the
9342 To see whether a byte, when represented as hex, has letters for its
9343 upper and lower nibbles, just check whether both nibbles are >= 0xA.
9344 Cast the extracted nibbles to make sure there's no sign-extension.
9346 Change-Id: If4c7717a5d2fe341c02e9309ee6b89973a6ac292
9347 Reviewed-on: https://code.wireshark.org/review/4739
9348 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9351 Author: Dario Lombardo <lomato@gmail.com>
9352 Date: Thu Oct 16 09:12:25 2014 +0200
9354 Added italian translation to qt.
9356 Change-Id: If58ed29e78a9994fc488a4d01cf665f7e8d82830
9357 Reviewed-on: https://code.wireshark.org/review/4707
9358 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
9361 Author: Guy Harris <guy@alum.mit.edu>
9362 Date: Thu Oct 16 11:44:06 2014 -0700
9364 gchar is not guaranteed to be signed; use gint8.
9366 C does not guarantee that char is signed (that's why there's a keyword
9367 "signed"). Use gint8, to indicate that it's not a character, it's an
9368 8-bit signed integer.
9370 Change-Id: Id632df23352840cbc86a4d88f4c7dade95ab7837
9371 Reviewed-on: https://code.wireshark.org/review/4736
9372 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9375 Author: Guy Harris <guy@alum.mit.edu>
9376 Date: Thu Oct 16 11:16:11 2014 -0700
9378 Fix some more "char is unsigned" issues, and a possible "char is signed" one.
9380 C neither guarantees that char is signed nor that it's unsigned. Make
9381 the str_to_nibble tables arrays of gint8, to make sure they can hold
9382 numbers between 0 and 15 as well as -1. Cast gchar to guchar, not int,
9383 when using it as a subscript into that array, so that the subscripts are
9384 in the range 0 to 255, not -128 to 127.
9386 Change-Id: Ib85de5aa4e83ae9efd808c78ce3f86f45b4a3f2a
9387 Reviewed-on: https://code.wireshark.org/review/4734
9388 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9391 Author: Guy Harris <guy@alum.mit.edu>
9392 Date: Thu Oct 16 11:06:06 2014 -0700
9394 Fix issues in some ARM compilers, due to char being unsigned?
9396 I'm not 100% certain the comparisons were right even with signed char;
9397 make the comparisons unsigned vs. unsigned, regardless of whether char
9398 is signed or not. (No, C doesn't require it to be signed; that's why
9399 there's a "signed" keyword.)
9401 Change-Id: Icbbd1019a2f7d4ebb40d821255834f825cd7c5a7
9402 Reviewed-on: https://code.wireshark.org/review/4731
9403 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9406 Author: Hannes Mezger <hannes.mezger@ascolab.com>
9407 Date: Thu Oct 16 14:59:53 2014 +0200
9409 Replace proto_tree_add_text in non-generated files
9411 As requested by Michael Mann, most of the occurences of proto_tree_add_text/proto_item_add_subtree are replaced with proto_tree_add_subtree(_format) or proto_tree_add_item/proto_item_append_text in the non-generated files.
9413 Change-Id: I27cccde88780adef43c78efd26333f47af098ad6
9414 Reviewed-on: https://code.wireshark.org/review/4726
9415 Petri-Dish: Michael Mann <mmann78@netscape.net>
9416 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9417 Reviewed-by: Michael Mann <mmann78@netscape.net>
9420 Author: Pascal Quantin <pascal.quantin@gmail.com>
9421 Date: Thu Oct 16 17:58:05 2014 +0200
9423 ETSI CAT: fix a typo and remove deprecated API call
9425 Change-Id: I7df02d6a605ca0912c179caa04a405c5c18eb552
9426 Reviewed-on: https://code.wireshark.org/review/4727
9427 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
9430 Author: Hannes Mezger <hannes.mezger@ascolab.com>
9431 Date: Thu Oct 16 14:35:10 2014 +0200
9433 Replace proto_tree_add_text with proto_tree_add_subtree(_format) in generated files
9435 As requested by Michael Mann, all occurences of proto_tree_add_text/proto_item_add_subtree are replaced with proto_tree_add_subtree(_format) in the generated files. Our generator templates have also been updated accordingly.
9437 Change-Id: I49ddd664dffef4b3ceda77edd1b2d7e01da363f3
9438 Reviewed-on: https://code.wireshark.org/review/4725
9439 Petri-Dish: Michael Mann <mmann78@netscape.net>
9440 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9441 Reviewed-by: Michael Mann <mmann78@netscape.net>
9444 Author: Guy Harris <guy@alum.mit.edu>
9445 Date: Thu Oct 16 03:01:28 2014 -0700
9447 Don't try to compute time stamps for files from Packet Builder.
9449 I don't trust Packet Builder's ability to convert time stamps between
9450 Capsa format and pcap.
9452 Change-Id: I0ac2e14216e37127d81d5bf1c6d48a2c20841a8e
9453 Reviewed-on: https://code.wireshark.org/review/4721
9454 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9457 Author: Guy Harris <guy@alum.mit.edu>
9458 Date: Thu Oct 16 00:00:45 2014 -0700
9460 Fix a debugging printout.
9462 Change-Id: I06bc40bece3ea98578a252217c9de4748276a440
9463 Reviewed-on: https://code.wireshark.org/review/4720
9464 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9467 Author: Guy Harris <guy@alum.mit.edu>
9468 Date: Wed Oct 15 23:53:45 2014 -0700
9470 Get rid of some set-but-no-longer-used variables.
9472 Change-Id: Iaf7267b6ee3d4ab288c8ffa487f5de736bc4aead
9473 Reviewed-on: https://code.wireshark.org/review/4719
9474 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9477 Author: Guy Harris <guy@alum.mit.edu>
9478 Date: Wed Oct 15 18:15:15 2014 -0700
9480 Make sure *err and *err_info are set when returning PCAPNG_BLOCK_NOT_SHB.
9482 Clean up a comment and indentation while we're at it.
9484 Change-Id: Ia2b0a3f642849dcd464e04cdca13ff05c2fbe2e6
9485 Reviewed-on: https://code.wireshark.org/review/4717
9486 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9489 Author: Guy Harris <guy@alum.mit.edu>
9490 Date: Wed Oct 15 17:55:04 2014 -0700
9492 The record offset block begins with a 1-byte(!) header.
9494 Clean up the code to read the block according to that description.
9496 Change-Id: Icb332e293c4b41d91989aa17a7546f298068e908
9497 Reviewed-on: https://code.wireshark.org/review/4716
9498 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9501 Author: Guy Harris <guy@alum.mit.edu>
9502 Date: Wed Oct 15 17:19:33 2014 -0700
9504 Get rid of another unused variable.
9506 Change-Id: Id3e9bdd9308342460f84b5d4aeb13e9d6d52616c
9507 Reviewed-on: https://code.wireshark.org/review/4715
9508 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9511 Author: Guy Harris <guy@alum.mit.edu>
9512 Date: Wed Oct 15 16:55:54 2014 -0700
9514 Don't allocate the interfaces array until we've read the SHB.
9516 Nothing from the SHB gets stored in the interfaces array - it's filled
9517 in from IDBs - so it doesn't need to exist when we read the first SHB,
9518 and thus doesn't need to be freed if the attempt to read the SHB gets an
9519 error or a "this isn't a pcap-ng file" indication.
9521 Update a comment while we're at it.
9523 Change-Id: Ie67edb52dcf13c974607e95e290661bf48be68ae
9524 Reviewed-on: https://code.wireshark.org/review/4711
9525 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9528 Author: Guy Harris <guy@alum.mit.edu>
9529 Date: Wed Oct 15 16:45:51 2014 -0700
9531 Clean up the read routines.
9533 The block read routines don't need to return a "bytes read" amount any
9536 Have pcapng_read_block() just return an indication:
9538 PCAPNG_BLOCK_OK - the read succeeded;
9540 PCAPNG_BLOCK_NOT_SHB - the read failed in a fashion that
9541 indicates that we might just not be reading a pcap-ng file;
9543 PCAPNG_BLOCK_ERROR - the read failed in some other fashion
9544 (i.e., we already have concluded that the file is a pcap-ng
9545 file, or we got an I/O error).
9547 In the cases where it needs to know whether it's reading the first block
9548 for an open, have it check the shb_read flag, rather than being passed a
9549 separate Boolean argument.
9551 This means that pcapng_read_section_header_block() should return such an
9554 Make the other block-reading routines return a Boolean success/failure
9557 Change-Id: Id371457018a008ece9058d6042da44d631e51889
9558 Reviewed-on: https://code.wireshark.org/review/4710
9559 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9562 Author: Michael Mann <mmann78@netscape.net>
9563 Date: Wed Oct 15 12:55:08 2014 -0400
9565 Eliminate some proto_tree_add_text from GSM dissectors (so now there are no dissectors with 100+ proto_tree_add_text calls).
9567 Add tfs_allocated_by_receiver_sender to tfs.h because it seems "popular" enough.
9569 Change-Id: I478461d9b951a2c3e3aec6aaf996d95ba2c0feee
9570 Reviewed-on: https://code.wireshark.org/review/4708
9571 Reviewed-by: Michael Mann <mmann78@netscape.net>
9572 Petri-Dish: Michael Mann <mmann78@netscape.net>
9573 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9574 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9577 Author: Dario Lombardo <lomato@gmail.com>
9578 Date: Fri Oct 10 11:30:59 2014 +0200
9580 Typos in source code and in README.qt
9582 Change-Id: I5aef31ef7ad604352f6e108835f0e9c2d10cdf8a
9583 Reviewed-on: https://code.wireshark.org/review/4706
9584 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
9587 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
9588 Date: Wed Oct 15 09:37:21 2014 +0200
9590 IPv6: Calipso option length is not used properly
9592 This field indeed indicates the length of the Compartment Bitmap but *in 32-bit words*, which means that the value of 12 means the compartment bitmap is 48 bytes long.
9597 Change-Id: I6c6ac25d0680837594d7cc6d2e4807a60a523b80
9598 Reviewed-on: https://code.wireshark.org/review/4697
9599 Reviewed-by: Michael Mann <mmann78@netscape.net>
9602 Author: Evan Huus <eapache@gmail.com>
9603 Date: Wed Oct 15 08:22:09 2014 -0400
9605 smb2: fully initialize dummy session
9607 A few fields weren't being zeroed and were causing valgrind warnings.
9610 Change-Id: I30e1e70c9445376806f385f3578b65bf6e320f8b
9611 Reviewed-on: https://code.wireshark.org/review/4702
9612 Reviewed-by: Evan Huus <eapache@gmail.com>
9615 Author: Stig Bjørlykke <stig@bjorlykke.org>
9616 Date: Wed Oct 15 14:18:21 2014 +0200
9618 WSUG: Fixed some typos.
9620 This was reported by Emre Baris.
9622 Change-Id: Ia37527e2a612fcbabd3ce7c6d8faf33905bbe52d
9623 Reviewed-on: https://code.wireshark.org/review/4701
9624 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
9627 Author: AndersBroman <anders.broman@ericsson.com>
9628 Date: Wed Oct 15 13:12:24 2014 +0200
9630 GTPv2: Fully dissect Presence Reporting Area Action.
9632 Change-Id: If38f639049bd897587ed61cc2d94f974131ccd20
9633 Reviewed-on: https://code.wireshark.org/review/4700
9634 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9637 Author: Stig Bjørlykke <stig@bjorlykke.org>
9638 Date: Wed Oct 15 11:58:40 2014 +0200
9640 LDAP: Improved a if-check to avoid a analyzis warning.
9642 Change-Id: Iceeaa94a80543570a720281ac39d3ccd9ac924fa
9643 Reviewed-on: https://code.wireshark.org/review/4699
9644 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
9647 Author: Gerald Combs <gerald@wireshark.org>
9648 Date: Tue Oct 14 21:52:15 2014 -0500
9650 CMake: When creating a bundle add convenience symlinks.
9652 Change-Id: Ic6c02c8879e406b733d834e895a3ccb1e9322a9d
9653 Reviewed-on: https://code.wireshark.org/review/4696
9654 Reviewed-by: Gerald Combs <gerald@wireshark.org>
9657 Author: Bill Meier <wmeier@newsguy.com>
9658 Date: Tue Oct 14 21:12:13 2014 -0400
9660 raknet: fix two checkfiltername errors; mcpe,raknet: minor cleanup;
9662 Change-Id: Ieac370d232c6349f7acc45f4817637a80915e315
9663 Reviewed-on: https://code.wireshark.org/review/4695
9664 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9667 Author: Bill Meier <wmeier@newsguy.com>
9668 Date: Tue Oct 14 20:10:13 2014 -0400
9670 packet-raknet.c: value_string array (created at runtime) must be terminated with {0, NULL}.
9672 This should fix crash in 'tshark -G values' seen on 64 bit tshark.
9674 Change-Id: Ia183fc5d5604f71b824cf4f758c18ff1ccd4540f
9675 Reviewed-on: https://code.wireshark.org/review/4694
9676 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9679 Author: Guy Harris <guy@alum.mit.edu>
9680 Date: Tue Oct 14 16:53:03 2014 -0700
9682 We can't check the length of an SHB until we determine the byte order.
9684 Don't check a possibly-byte-swapped length against the minimum SHB size;
9685 it'll probably look huge if it's byte-swapped, so the test won't fail
9686 even if it is too small, and a really huge SHB's length could look too
9687 small if it's byte-swapped.
9689 Do the check *after* we've read the fixed-length portion of the block;
9690 yes, that means we've read past the purported size of the block at that
9691 point, but if that read succeeds, that doesn't matter, and if that read
9692 fails, it just means we'll report "file cut short" rather than "bad SHB
9693 length", *both* of which are problems with the file.
9695 Change-Id: Ie3b5700662f2a6da40d373a84f00a8fc2cf0ce1b
9696 Reviewed-on: https://code.wireshark.org/review/4692
9697 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9700 Author: Guy Harris <guy@alum.mit.edu>
9701 Date: Tue Oct 14 16:39:17 2014 -0700
9703 Don't assume pcap_read_block() returns the number of bytes read.
9705 Recent changes must have made it not do so in some cases, and
9706 our current version of file_tell(), unlike ftell() around which the
9707 older file_tell() was a wrapper, is known to be cheap (ftell() would
9708 make a system call to get the position). Just use file_tell() before
9711 (Further cleanup is called for.)
9714 Change-Id: Ib92057b2b87ec6eb16fd612bc91baeb668d1e1c7
9715 Reviewed-on: https://code.wireshark.org/review/4691
9716 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9719 Author: Guy Harris <guy@alum.mit.edu>
9720 Date: Tue Oct 14 13:41:36 2014 -0700
9722 Don't log warnings if no block-type handlers are registered.
9724 Check whether the block-type hash table exists before trynig to look
9727 Change-Id: I0aeb7f6454903bfcbdd0716909a0b72851d87233
9728 Reviewed-on: https://code.wireshark.org/review/4689
9729 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9732 Author: Bill Meier <wmeier@newsguy.com>
9733 Date: Tue Oct 14 15:58:21 2014 -0400
9735 Always put editor-modelines at the end of the file ...
9737 ... to ensure that there are no potential issues with respect to
9738 editors limiting the number of lines scanned at the end of the file
9739 when checking for editor modelines.
9741 Change-Id: Ic85cbb108bb5159d6ec4116fea11f5eebb4e44a4
9742 Reviewed-on: https://code.wireshark.org/review/4688
9743 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9746 Author: Bill Meier <wmeier@newsguy.com>
9747 Date: Tue Oct 14 14:19:59 2014 -0400
9749 packet-assa_r3.c: Use editor modelines from http://www.wireshark.org/tools/modelines.html
9751 Change-Id: I2d9accd2336448ced30dca1878a3e27cdba29566
9752 Reviewed-on: https://code.wireshark.org/review/4687
9753 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9756 Author: Nick Carter <ncarter100@gmail.com>
9757 Date: Tue Oct 7 19:21:46 2014 +0100
9759 Add RakNet protocol dissector
9762 Change-Id: Id56008da0c21a5f3a0309cdf21aff287c7820dcf
9763 Reviewed-on: https://code.wireshark.org/review/4372
9764 Petri-Dish: Michael Mann <mmann78@netscape.net>
9765 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9766 Reviewed-by: Michael Mann <mmann78@netscape.net>
9769 Author: Guy Harris <guy@alum.mit.edu>
9770 Date: Tue Oct 14 12:31:49 2014 -0700
9772 Get rid of no-longer-used #define.
9774 Change-Id: Ibaebda819094f09610dc9cf8a303440b93bf2da0
9775 Reviewed-on: https://code.wireshark.org/review/4686
9776 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9779 Author: Guy Harris <guy@alum.mit.edu>
9780 Date: Tue Oct 14 12:30:00 2014 -0700
9782 Don't supply time stamps for Capsa packets for now.
9784 The time stamps aren't known to be right, so don't provide them - that
9785 way, instead of users reading Capsa files and getting the wrong idea
9786 about the time stamps, they'll get no time stamps and have to ask for
9787 our help, at which point we can ask them for *their* help in seeing what
9788 Capsa thinks the time stamps are. (The joys of reverse-engineering.)
9790 Change-Id: I77e12c09f2bc74b50a1b2b226fa6da3e8c0fedf9
9791 Reviewed-on: https://code.wireshark.org/review/4685
9792 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9795 Author: Bill Meier <wmeier@newsguy.com>
9796 Date: Tue Oct 14 12:54:34 2014 -0400
9798 packet-gvsp.c: removed an unused #define
9800 Change-Id: If330124cdc459867b33e1bbbe960c969deb85b10
9801 Reviewed-on: https://code.wireshark.org/review/4684
9802 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9805 Author: Bill Meier <wmeier@newsguy.com>
9806 Date: Tue Oct 14 11:12:16 2014 -0400
9808 Add editor-modelines; adjust whitespace.
9810 Change-Id: I8cad872cee972a6d22a72852dac57fd188daca84
9811 Reviewed-on: https://code.wireshark.org/review/4683
9812 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9815 Author: AndersBroman <anders.broman@ericsson.com>
9816 Date: Tue Oct 14 15:56:49 2014 +0200
9818 GTPv2 Dissect more bits in IE Indication.
9820 Change-Id: I19d0b67e06ec22bfc5bafc58fdeb445e30e25f95
9821 Reviewed-on: https://code.wireshark.org/review/4682
9822 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9825 Author: Stig Bjørlykke <stig@bjorlykke.org>
9826 Date: Tue Oct 14 10:56:02 2014 +0200
9828 PIM: Disable unused pimbdirdfvals.
9830 Change-Id: I2b023868d9f84e891e36f2cfcfd4ad25e1e43592
9831 Reviewed-on: https://code.wireshark.org/review/4681
9832 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9835 Author: AndersBroman <anders.broman@ericsson.com>
9836 Date: Tue Oct 14 10:54:57 2014 +0200
9838 Add new Event-Trigger values.
9840 Change-Id: Idd18a710fd8630d5b50c5ac180d7aa45a40596d7
9841 Reviewed-on: https://code.wireshark.org/review/4680
9842 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9845 Author: Guy Harris <guy@alum.mit.edu>
9846 Date: Tue Oct 14 01:47:37 2014 -0700
9850 Change-Id: I3f11d48f74d71367cc76c76dfc88763894f23f2c
9851 Reviewed-on: https://code.wireshark.org/review/4679
9852 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9855 Author: Bill Meier <wmeier@newsguy.com>
9856 Date: Tue Oct 14 03:29:58 2014 -0400
9858 packet-gvsp.c: sort pixeltypenames[] for extended value-string use.
9860 Change-Id: Iaf753d432603422922ad7ef4ba7a2c2b3cd84136
9861 Reviewed-on: https://code.wireshark.org/review/4678
9862 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9865 Author: Guy Harris <guy@alum.mit.edu>
9866 Date: Tue Oct 14 00:11:16 2014 -0700
9868 And another warning.
9870 (So why can't GCC or Clang be taught to warn about *all* implicit
9871 shortenings, as MSVC does, not just 64-bit-to-32-bit shortenings?)
9873 Change-Id: I88c0b0aa2f1b306f58952589ff8bcae17bc29768
9874 Reviewed-on: https://code.wireshark.org/review/4676
9875 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9878 Author: Guy Harris <guy@alum.mit.edu>
9879 Date: Tue Oct 14 00:08:45 2014 -0700
9881 Squelch another warning.
9883 (Yes, we should, on platforms with a 32-bit time_t, check to make sure
9884 the time stamp fits and do something if it doesn't. Or we should make
9885 the seconds part of an nstime_t be 64-bit and handle overly-large values
9886 when converting them to year/month/day/hour/minute/second.)
9888 Change-Id: If219534985dce29d00754ff151f6c4b5893080d8
9889 Reviewed-on: https://code.wireshark.org/review/4675
9890 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9893 Author: Guy Harris <guy@alum.mit.edu>
9894 Date: Tue Oct 14 00:07:16 2014 -0700
9896 Squelch a compiler warning.
9898 Change-Id: I5b383c967c465882819ac449fbd54915bc692687
9899 Reviewed-on: https://code.wireshark.org/review/4674
9900 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9903 Author: Guy Harris <guy@alum.mit.edu>
9904 Date: Mon Oct 13 23:55:08 2014 -0700
9908 Change-Id: I9a620da95c1dd9b173cebe28f790eeb50e3f9a8f
9909 Reviewed-on: https://code.wireshark.org/review/4673
9910 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9913 Author: Guy Harris <guy@alum.mit.edu>
9914 Date: Mon Oct 13 23:47:24 2014 -0700
9916 Get rid of out-of-date comment.
9918 Change-Id: I68e85e2e29e1154170ccc50488ec943958978150
9919 Reviewed-on: https://code.wireshark.org/review/4672
9920 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9923 Author: Guy Harris <guy@alum.mit.edu>
9924 Date: Mon Oct 13 23:45:05 2014 -0700
9926 Initial version of support for Colasoft Capsa files.
9928 The time stamp origin is not correct. Capsa's absolute time stamp for
9929 the sample captures from their Web site would be helpful.
9931 Change-Id: I365daf7b42240e33f54df76939254f41ed57a9b2
9932 Reviewed-on: https://code.wireshark.org/review/4671
9933 Reviewed-by: Guy Harris <guy@alum.mit.edu>
9936 Author: Bill Meier <wmeier@newsguy.com>
9937 Date: Tue Oct 14 02:02:10 2014 -0400
9939 packet-gvsp.c: Fix license; Remove unneeded code from proto_reg_handoff..(); adjust whitespace.
9941 Change-Id: I24a9033bbed3d50daf886f3d00239c1580894c35
9942 Reviewed-on: https://code.wireshark.org/review/4670
9943 Reviewed-by: Bill Meier <wmeier@newsguy.com>
9946 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
9947 Date: Tue Aug 26 16:44:04 2014 +0200
9949 NSIS: Wireshark GTK is Wireshark legacy (and no Wireshark 1...) !
9951 Change-Id: I3b4f4ca28bc7d363474bc888b6a3a8ddbdb7dab9
9952 Reviewed-on: https://code.wireshark.org/review/3867
9953 Reviewed-by: Evan Huus <eapache@gmail.com>
9954 Reviewed-by: Gerald Combs <gerald@wireshark.org>
9955 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9958 Author: warrenm <warrenmptgrey@gmail.com>
9959 Date: Fri Oct 10 10:45:07 2014 -0700
9961 Adding GigEVision GVSP dissector
9964 Change-Id: I4e8270c76291d6ea0e0187f00a342804275f2c11
9965 Reviewed-on: https://code.wireshark.org/review/4547
9966 Reviewed-by: Michael Mann <mmann78@netscape.net>
9967 Petri-Dish: Michael Mann <mmann78@netscape.net>
9968 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9969 Reviewed-by: Anders Broman <a.broman58@gmail.com>
9972 Author: Hannes Mezger <hannes.mezger@ascolab.com>
9973 Date: Mon Oct 13 17:51:15 2014 +0200
9975 fix forward declarations in opcua_serviceparser.h
9977 The declarations from opcua_complextypeparser.h were used instead of the serviceparser ones, this is also fixed in our generator
9979 Change-Id: I3d78d26a3b2b4995dfd4556720d29ecdd6960c4b
9980 Reviewed-on: https://code.wireshark.org/review/4650
9981 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
9982 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
9983 Reviewed-by: Evan Huus <eapache@gmail.com>
9986 Author: Pascal Quantin <pascal.quantin@gmail.com>
9987 Date: Mon Oct 13 23:14:19 2014 +0200
9989 NCP: cast to guint instead of gulong
9991 Change-Id: Idc8f8f3177703ce5546b8a472034705cb6070707
9992 Reviewed-on: https://code.wireshark.org/review/4666
9993 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
9996 Author: Martin Kaiser <wireshark@kaiser.cx>
9997 Date: Fri Oct 10 22:17:23 2014 +0200
9999 smartcard descriptor: bitmask for pin support field
10001 Change-Id: If0e5cd90ff73bfbb211970f9a24974119c6ec550
10002 Reviewed-on: https://code.wireshark.org/review/4664
10003 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
10004 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
10007 Author: Martin Kaiser <wireshark@kaiser.cx>
10008 Date: Fri Oct 10 21:34:57 2014 +0200
10010 smartcard descriptor:
10011 dissect number of lines, characters per line in the lcd layout
10013 Change-Id: I36c9c6f2e73cdfde8a9b7c4ad0450d93722fca2b
10014 Reviewed-on: https://code.wireshark.org/review/4663
10015 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
10016 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
10019 Author: Martin Kaiser <wireshark@kaiser.cx>
10020 Date: Fri Oct 10 20:50:02 2014 +0200
10022 smartcard descriptor: the lcd layout is two bytes long
10024 Change-Id: Ie8fd82d652a9a3fc1d3139ab610bbaa7a5ecd32d
10025 Reviewed-on: https://code.wireshark.org/review/4662
10026 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
10027 Tested-by: Martin Kaiser <wireshark@kaiser.cx>
10030 Author: Pascal Quantin <pascal.quantin@gmail.com>
10031 Date: Mon Oct 13 21:37:01 2014 +0200
10033 Add Kerberos 3.2.2 package for Win64
10035 Change-Id: If02469aa1a01972d2032478dce3bf872802f37cb
10036 Reviewed-on: https://code.wireshark.org/review/4661
10037 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
10038 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10041 Author: Pascal Quantin <pascal.quantin@gmail.com>
10042 Date: Mon Oct 13 21:01:11 2014 +0200
10044 Upgrade Win64 GTK2 package to 2.24.23-3.39
10046 Change-Id: I0f5f27aa2fc13f38af73a42e1c6e4a36636d2fc7
10047 Reviewed-on: https://code.wireshark.org/review/4656
10048 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
10049 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10052 Author: Roland Knall <roland.knall@br-automation.com>
10053 Date: Mon Oct 13 16:18:28 2014 +0200
10055 extcap: Remove single-space argument for boolflags
10057 Boolflags will be added with a NULL argument to the
10058 list and therefore the original fix will work.
10060 Note: extcap_get_complex_as_string will convert any NULL
10061 value into a single character argument (' '). Therefore
10062 any argument type, where NULL is a special value should
10063 be handled seperately here. For now, the only datatype
10066 Change-Id: Icfc9b573214e05ea713a3b70ea37953d470dafae
10067 Reviewed-on: https://code.wireshark.org/review/4649
10068 Reviewed-by: Roland Knall <rknall@gmail.com>
10069 Reviewed-by: Tomasz Moń <desowin@gmail.com>
10070 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10073 Author: Mikael Kanstrup <mikael.kanstrup@gmail.com>
10074 Date: Sat Oct 11 22:41:10 2014 +0200
10076 Split ws80211_get_phys callback handler
10078 Split up the ws80211_get_phys parser callback handler function into
10079 separate functions for each attribute parsed. This is done in
10080 preparation for supporting split wiphy dump feature where the function
10081 logics will need modications.
10083 Change-Id: Ic0b497fc628f0e7453cd62eb8199f17f9a308a7f
10084 Reviewed-on: https://code.wireshark.org/review/4610
10085 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
10086 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10087 Reviewed-by: Evan Huus <eapache@gmail.com>
10088 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10091 Author: Stig Bjørlykke <stig@bjorlykke.org>
10092 Date: Mon Oct 13 14:05:29 2014 +0200
10094 BER: Code cleanup in call functions
10096 Change-Id: I0ba958485dffd3cc1e419fb27cf7f2bc492d05fe
10097 Reviewed-on: https://code.wireshark.org/review/4643
10098 Petri-Dish: Anders Broman <a.broman58@gmail.com>
10099 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10100 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10103 Author: Bill Meier <wmeier@newsguy.com>
10104 Date: Mon Oct 13 15:04:21 2014 -0400
10106 Add editor modelines and/or adjust whilespace.
10108 Change-Id: I626b7bd8ac6e4b91c57cc9152e7ce038754e7278
10109 Reviewed-on: https://code.wireshark.org/review/4658
10110 Reviewed-by: Bill Meier <wmeier@newsguy.com>
10113 Author: Pascal Quantin <pascal.quantin@gmail.com>
10114 Date: Mon Oct 13 21:04:09 2014 +0200
10116 NCP: add a missing cast following g6ca40c5
10118 Change-Id: I0b93c4faab52d830b8160d89b9bb8026ab2a216e
10119 Reviewed-on: https://code.wireshark.org/review/4657
10120 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10123 Author: Stig Bjørlykke <stig@bjorlykke.org>
10124 Date: Sun Oct 12 22:27:54 2014 +0200
10126 Lua: luaL_checkstring does not return NULL
10128 Removed all checks for NULL strings to cleanup the code.
10130 Change-Id: Ia890cd9b206296f586e85214f07765f14984580b
10131 Reviewed-on: https://code.wireshark.org/review/4632
10132 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
10133 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
10136 Author: Roland Knall <roland.knall@br-automation.com>
10137 Date: Mon Oct 13 13:26:21 2014 +0200
10139 extcap: Catch unknown arguments to fix spaces
10141 - If boolflags are being used, an extra space is added
10142 to the call of the extcap filter. This leads to the
10143 argumentparser of python to exit with an error-code,
10144 and the extcap filter will not start. This patch instead
10145 catches the unknown arguments and prints them on stdout,
10146 as well as running the dissection with the rest of the
10149 Basically this is a work-around, for a behaviour not
10150 yet fixed in extcap, but it stabilizes the usage of the demo
10152 Change-Id: I7589292692b0b3c839909fd09d62a4714cbe869e
10153 Reviewed-on: https://code.wireshark.org/review/4638
10154 Reviewed-by: Roland Knall <rknall@gmail.com>
10155 Reviewed-by: Tomasz Moń <desowin@gmail.com>
10156 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10159 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10160 Date: Mon Oct 13 10:21:39 2014 +0200
10162 IPv6: use proto_tree_add_item for IPv6 Routing Header Next and Length
10164 Like other header (Fragment, Hop by Hop...)
10166 Change-Id: I5d0a85bf285b37eed38345d659439400c5f50d06
10167 Reviewed-on: https://code.wireshark.org/review/4634
10168 Petri-Dish: Michael Mann <mmann78@netscape.net>
10169 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10170 Reviewed-by: Michael Mann <mmann78@netscape.net>
10173 Author: Evan Huus <eapache@gmail.com>
10174 Date: Mon Oct 13 12:55:40 2014 -0400
10176 ncp2222: don't overflow buffer constructing string
10178 Fixes stack-smashing vuln.
10180 Somehow there was already an XXX in the code about this, but nobody realized at
10181 the time it was worth fixing... really?
10184 Change-Id: I849068bd6c45146339444f295b72430d3c6e08f2
10185 Reviewed-on: https://code.wireshark.org/review/4653
10186 Reviewed-by: Evan Huus <eapache@gmail.com>
10189 Author: Evan Huus <eapache@gmail.com>
10190 Date: Mon Oct 13 12:08:43 2014 -0400
10192 extcap: remove use of g_list_free_full
10194 It requires a newer glib than we support
10196 Change-Id: Id8f14d4188a9ba55e0a5196bb877e2fe6a0c8d3f
10197 Reviewed-on: https://code.wireshark.org/review/4652
10198 Reviewed-by: Evan Huus <eapache@gmail.com>
10201 Author: Stig Bjørlykke <stig@bjorlykke.org>
10202 Date: Mon Oct 13 14:04:23 2014 +0200
10204 RTSE: Return dissected length from call_rtse_oid_callback
10206 Change-Id: I6766135ddcdfe25d9bcc060bb2a47376abb36794
10207 Reviewed-on: https://code.wireshark.org/review/4642
10208 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10209 Reviewed-by: Evan Huus <eapache@gmail.com>
10212 Author: Stig Bjørlykke <stig@bjorlykke.org>
10213 Date: Mon Oct 13 13:59:38 2014 +0200
10215 ROS: Return dissected length from call_ros_oid_callback
10217 Change-Id: I8d119cd3dc9ac0a724497400680a70f39fc21ede
10218 Reviewed-on: https://code.wireshark.org/review/4641
10219 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10220 Reviewed-by: Evan Huus <eapache@gmail.com>
10223 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10224 Date: Sun Oct 12 20:56:17 2014 +0200
10226 IPv6 RPL option is read as less bytes than it is
10228 Add check if the opt len equal to the "calculcate" length
10229 and display expert info if not.. also replace offset by the opt len
10233 Change-Id: I6e80e4055b6d0c5ef3f030c544cd1629e6b9abec
10234 Reviewed-on: https://code.wireshark.org/review/4627
10235 Reviewed-by: Evan Huus <eapache@gmail.com>
10238 Author: Tim (Thanh) Nguyen <tnnguyen@broadcom.com>
10239 Date: Sun Oct 12 10:31:03 2014 -0400
10241 RoCE and CM dissector fixes
10243 - fixed cm.req cm.rep bit fields
10244 - fixed packetLength and CRC length for RoCE
10245 - use "RoCE" or "RRoCE" instead of "InfiniBand" in COL_PROTOCOL where appropriate
10247 Change-Id: Id491658f9368034bb2267922fa5618e1c259cd56
10248 Reviewed-on: https://code.wireshark.org/review/4614
10249 Petri-Dish: Bill Meier <wmeier@newsguy.com>
10250 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10251 Reviewed-by: Evan Huus <eapache@gmail.com>
10254 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10255 Date: Sun Oct 12 19:22:58 2014 +0200
10257 extcap (GTK): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
10259 Change-Id: Ifdba972e3a12e01ac80bc920a2100bd7aa0f733c
10260 Reviewed-on: https://code.wireshark.org/review/4622
10261 Reviewed-by: Evan Huus <eapache@gmail.com>
10264 Author: Pascal Quantin <pascal.quantin@gmail.com>
10265 Date: Mon Oct 13 14:17:35 2014 +0200
10267 Follow-up of ged0b19b (Make boolean bitmask type 64-bit wide)
10269 - use G_GINT64_MODIFIER instead of "%ll"
10270 - use G_GUINT64_CONSTANT instead of ULL
10271 - add some missing explicit casts
10273 Change-Id: Ic048d9ee8966ea504ea542cefe55688edcfb2dc7
10274 Reviewed-on: https://code.wireshark.org/review/4644
10275 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10276 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
10277 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10278 Reviewed-by: Michael Mann <mmann78@netscape.net>
10281 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10282 Date: Mon Oct 13 12:30:26 2014 +0200
10284 SPDY: Add Slot field for SYN_STREAM (and also unused field...)
10287 Change-Id: I4d3d991eb8b5ede349a361d1f6b605b4a67a98b6
10288 Reviewed-on: https://code.wireshark.org/review/4645
10289 Reviewed-by: Michael Mann <mmann78@netscape.net>
10292 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10293 Date: Mon Oct 13 11:55:34 2014 +0200
10295 SPDY: Fix bitmask for priority bit
10297 Found by yurui ming
10301 Change-Id: I92e784eb91dc6c88af409e2936671b0ea473fba9
10302 Reviewed-on: https://code.wireshark.org/review/4637
10303 Reviewed-by: Michael Mann <mmann78@netscape.net>
10306 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10307 Date: Mon Oct 13 10:50:50 2014 +0200
10309 SPDY: Fix the display of COL_INFO...
10311 Clear the COL_INFO before start to dissect SPDY PDU
10313 Change-Id: I7a22515f1c2c89b5647003320ff455a74fbce42a
10315 Reviewed-on: https://code.wireshark.org/review/4636
10316 Reviewed-by: Michael Mann <mmann78@netscape.net>
10319 Author: Stig Bjørlykke <stig@bjorlykke.org>
10320 Date: Tue Oct 7 22:41:47 2014 +0200
10322 ASN1: Register BER syntaxes as NEW
10324 Change-Id: Id85eaecd84dbe1115935e1977dca321fd601d986
10325 Reviewed-on: https://code.wireshark.org/review/4639
10326 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
10327 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10328 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
10331 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10332 Date: Mon Oct 13 09:50:46 2014 +0200
10334 IPv6: Fix typo for Fragment nxt (Next Header)
10336 Change-Id: Id7d6cd4a4c09238890394d5dc887ec840dc2d2af
10337 Reviewed-on: https://code.wireshark.org/review/4633
10338 Reviewed-by: Michael Mann <mmann78@netscape.net>
10341 Author: Stig Bjørlykke <stig@bjorlykke.org>
10342 Date: Mon Oct 13 13:37:24 2014 +0200
10344 P1: Added ORAddress and ORName syntax.
10346 Change-Id: Icf8e8cb2988d9134aa65f04a3459e4a4c4a5721f
10347 Reviewed-on: https://code.wireshark.org/review/4640
10348 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
10349 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
10352 Author: Stig Bjørlykke <stig@bjorlykke.org>
10353 Date: Mon Oct 6 15:31:47 2014 +0200
10355 ASN1: Register PDU-dissectors as NEW
10357 Change-Id: I1a317b19d8076588c9305dae6287bb80cc14da64
10358 Reviewed-on: https://code.wireshark.org/review/4494
10359 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
10360 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10361 Reviewed-by: Michael Mann <mmann78@netscape.net>
10362 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
10363 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
10366 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10367 Date: Mon Oct 13 10:32:38 2014 +0200
10369 SPDY: Fix typo about length for Control bit
10371 Found by yurui ming
10373 Change-Id: Ibef07fa13af0de8357bdf98a038460706d0972f7
10375 Reviewed-on: https://code.wireshark.org/review/4635
10376 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10379 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10380 Date: Sun Oct 12 19:37:02 2014 +0200
10382 USB Mass Storage: Display target number for SCM USB-SCSI converters
10384 The USB Mass Storage Class (Bulk Only Transport) has the LUN in bits [3:0] of byte 13 of the command block wrapper. Bits [7:4] of that byte are undefined/reserved.
10386 USB-SCSI converters based on a chipset from SCM Microsystems can work with multiple SCSI devices. After enabling multi-target mode (which the vendor driver and Linux do), the target number is given in bits [6:4] of CBW byte 13.
10391 Change-Id: I8e6d9b7d47ff4296d41e8b9b15f4bd44c89238c9
10392 Reviewed-on: https://code.wireshark.org/review/4625
10393 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10396 Author: Joseph Huffman <jhuffman@codeaurora.org>
10397 Date: Thu Sep 25 16:27:41 2014 -0700
10399 Fixed missing padding. Fixed ENC_NA/ENC_BIG_ENDIAN errors.
10401 There was no tree items for padding in the many instances where there were
10402 bytes added to make certain data types align on even boundaries of 2, 4, or
10403 8 bytes. These instances now show up as "Padding" in the display.
10405 There were many instances where ENC_NA was used for fields of more than one
10406 byte. This wasn't noticed before because ENC_NA was ENC_BIG_ENDIAN for
10407 historical reasons and all these fields are big endian fields.
10409 Change-Id: Iabadd46eacc9ceb8ca85f4a5ba42b6583375c5f0
10410 Signed-off-by: Joseph Huffman <jhuffman@codeaurora.org>
10411 Reviewed-on: https://code.wireshark.org/review/4413
10412 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10415 Author: Matthieu Texier <matthieu@texier.tv>
10416 Date: Mon Sep 15 16:10:51 2014 +0200
10418 Aliging PIM hello message type to IANA in order to fix BUG 10231
10420 Change-Id: Ie9a126d106c08935eb385fd93d011e481913ab3c
10421 Reviewed-on: https://code.wireshark.org/review/4448
10422 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10425 Author: Michael Mann <mmann78@netscape.net>
10426 Date: Sun Oct 12 22:09:35 2014 -0400
10428 Eliminate proto_tree_add_text from IP dissectors
10430 Change-Id: I81fc364cbff3c5b305d61b2d444bf8599fbd19e7
10431 Reviewed-on: https://code.wireshark.org/review/4631
10432 Reviewed-by: Michael Mann <mmann78@netscape.net>
10433 Petri-Dish: Michael Mann <mmann78@netscape.net>
10434 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10435 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10438 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10439 Date: Sun Oct 12 20:58:59 2014 +0200
10441 IPv6 RPL: Display RPL flag on HEX
10443 Change-Id: I0b3bb9e1a0de388135a71bc6a97602d6abf6a9dc
10444 Reviewed-on: https://code.wireshark.org/review/4628
10445 Reviewed-by: Michael Mann <mmann78@netscape.net>
10448 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10449 Date: Sun Oct 12 17:51:29 2014 +0200
10451 Remove DIRTY_DISSECTOR_SRC
10453 x11 dissector don't have longer warning !
10454 and fix different between Autotools and CMake (about gsm_a_common dissector)
10456 Change-Id: Id9da62d84b8b0bb4b0ed5d8fc62abba4e2442ed2
10457 Reviewed-on: https://code.wireshark.org/review/4621
10458 Petri-Dish: Michael Mann <mmann78@netscape.net>
10459 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10460 Reviewed-by: Michael Mann <mmann78@netscape.net>
10463 Author: Pascal Quantin <pascal.quantin@gmail.com>
10464 Date: Sun Oct 12 22:56:19 2014 +0200
10466 GlusterFS: fix OSX compilation failure
10468 ged0b19b introduced support for 64 bits bitmask. Make use of it and add an explicit cast to fix a compilation error
10470 Change-Id: I9f2202d851aedc0dc78655c505b5a0b26b224c0e
10471 Reviewed-on: https://code.wireshark.org/review/4630
10472 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10473 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
10474 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
10475 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
10478 Author: Tomasz Moń <desowin@gmail.com>
10479 Date: Sun Oct 12 21:07:48 2014 +0200
10483 This double free involves damaging GHashTable internals (key and value).
10485 Change-Id: I17c8a473b96ab28e611ccf79ddd2b3da56512184
10486 Reviewed-on: https://code.wireshark.org/review/4629
10487 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
10488 Reviewed-by: Tomasz Moń <desowin@gmail.com>
10489 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10492 Author: Tomasz Moń <desowin@gmail.com>
10493 Date: Sun Oct 12 17:26:04 2014 +0200
10495 Fix handling of extcap boolflags which defaults to true.
10498 arg {number=0}{call=--test}{type=boolflag}{default=true}
10500 Before this change --test was never added to argument list (no matter if
10501 user left it selected or explicitly deselected it).
10503 After this change --test will be added to argument list unless user
10504 explicitly deselects it.
10506 Change-Id: Ia5bc11f900b03e630aba882ef918dcb7f0b79291
10507 Reviewed-on: https://code.wireshark.org/review/4618
10508 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10509 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
10512 Author: Bill Meier <wmeier@newsguy.com>
10513 Date: Sun Oct 12 14:56:12 2014 -0400
10515 Add editor modelines; Adjust whitespace as needed.
10517 Change-Id: I4da7b335d905dbca10bbce03aa88e1cdeeb1f8ad
10518 Reviewed-on: https://code.wireshark.org/review/4626
10519 Reviewed-by: Bill Meier <wmeier@newsguy.com>
10522 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10523 Date: Sun Oct 12 17:44:04 2014 +0200
10525 DCERPC: Remove DIRTY_PIDL_DISSECTOR_SRC
10527 Now mapi and drsuapi build without warning !
10529 Change-Id: Iae19af2fd06fd998a13696ba2adf6cd12d311f58
10530 Reviewed-on: https://code.wireshark.org/review/4619
10531 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
10532 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10533 Reviewed-by: Michael Mann <mmann78@netscape.net>
10536 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10537 Date: Sun Oct 12 17:24:35 2014 +0200
10539 PIDL (DCERPC misc): enhance dissector
10541 * Fix -Wunused-function (Set NOEMIT winreg_Data and remove unused function)
10542 * Remove dissector DCERPC misc from DIRTY list
10544 Change-Id: If59b14f8db33354a2d5248e8bc256cadee3ea4bf
10545 Reviewed-on: https://code.wireshark.org/review/4345
10546 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
10547 Reviewed-by: Michael Mann <mmann78@netscape.net>
10550 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10551 Date: Sun Oct 12 19:23:39 2014 +0200
10553 ISUP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
10555 Change-Id: I17163b18348919d19d3d336ccf9c1310d473a05d
10556 Reviewed-on: https://code.wireshark.org/review/4624
10557 Reviewed-by: Michael Mann <mmann78@netscape.net>
10560 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
10561 Date: Sun Oct 12 19:23:17 2014 +0200
10563 LMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
10565 Change-Id: Ie651e8a7d0309330504a77664bb2eac75c00d968
10566 Reviewed-on: https://code.wireshark.org/review/4623
10567 Reviewed-by: Michael Mann <mmann78@netscape.net>
10570 Author: Stig Bjørlykke <stig@bjorlykke.org>
10571 Date: Sun Oct 12 18:41:36 2014 +0200
10573 Add back get_uinteger for boolean_type.
10575 This was removed in ed0b19b94bf07056b5e0cfe64d4d05c3ebae801a
10577 Change-Id: I548ca955eda6e0b6991a0f6731cbbb3bf82e0e2b
10578 Reviewed-on: https://code.wireshark.org/review/4620
10579 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
10580 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
10583 Author: Gerald Combs <gerald@wireshark.org>
10584 Date: Sun Oct 12 08:06:04 2014 -0700
10586 [Automatic manuf, services and enterprise-numbers update for 2014-10-12]
10588 Change-Id: Icc98f156e55bc8523490bb8a8d712ca80076649e
10589 Reviewed-on: https://code.wireshark.org/review/4615
10590 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10593 Author: Pascal Quantin <pascal.quantin@gmail.com>
10594 Date: Sun Oct 12 15:47:11 2014 +0200
10596 E-LMI: add what seems to be a missing break (Coverity CID 1245648)
10598 Change-Id: I6b35ea96fba142bdabf17d3fc3f9db23dc390d31
10599 Reviewed-on: https://code.wireshark.org/review/4613
10600 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
10603 Author: Daniel Mack <daniel@zonque.org>
10604 Date: Wed Sep 17 18:39:22 2014 +0200
10606 Make boolean bitmask type 64-bit wide
10608 There are protocols out there that have 64-bit wide bit mask fields, so
10609 make the internal representation and bitfield decoders 64-bit aware.
10611 For this, the ws_ctz() fallback and bits_count_ones() have to be tweaked
10614 Change-Id: I19237b954a69c9e6c55864f281993c1e8731a233
10615 Reviewed-on: https://code.wireshark.org/review/4158
10616 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
10617 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10618 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
10619 Reviewed-by: Michael Mann <mmann78@netscape.net>
10622 Author: Matthieu Patou <mat@matws.net>
10623 Date: Fri Oct 10 20:30:59 2014 -0400
10625 Add support for NTTIME_hyper and NTTIME_1sec
10627 It's hyper with 8 bytes alignment it can have 1/100000 sec resolution or 1sec resolution
10630 Change-Id: Iecc4c6d1bd1695a4c02db72e1617134254810cd9
10631 Reviewed-on: https://code.wireshark.org/review/4606
10632 Petri-Dish: Michael Mann <mmann78@netscape.net>
10633 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10634 Reviewed-by: Michael Mann <mmann78@netscape.net>
10637 Author: Guy Harris <guy@alum.mit.edu>
10638 Date: Sat Oct 11 16:06:57 2014 -0700
10640 Use the wtap_read_bytes{_or_eof}() routines.
10642 Change-Id: I4f707bc714b2643d0f6c568f3367e712ee635d8e
10643 Reviewed-on: https://code.wireshark.org/review/4612
10644 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10647 Author: Stig Bjørlykke <stig@bjorlykke.org>
10648 Date: Sat Oct 11 22:39:17 2014 +0200
10650 Use variable name 'len' when handling length.
10652 Change-Id: Icb1d81316d1ead3455c68ad55e52b8120b7dccf9
10653 Reviewed-on: https://code.wireshark.org/review/4609
10654 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
10655 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
10658 Author: Guy Harris <guy@alum.mit.edu>
10659 Date: Sat Oct 11 13:10:14 2014 -0700
10661 Use the count-of-records fields to figure out how many records to read.
10663 Fetch the count of records from one of the locations where it appears to
10664 be, and, currently, require that it be equal to the count at the other
10665 location where it appears to be; if they ever differ, we'll need the
10666 file in order to reverse-engineer some more.
10668 Fix the way we *write* .rf5 files - it turns out that we were
10670 1) not writing the full file size;
10672 2) not writing the packet count in the right location.
10674 Detect files written by the old code, and get the packet count from the
10675 right location for those files.
10677 Change-Id: I7ce83afbc9dbbd300c81c96ef8f7785a0aeefa7a
10678 Reviewed-on: https://code.wireshark.org/review/4608
10679 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10682 Author: Matthieu Patou <mat@matws.net>
10683 Date: Fri Oct 10 19:34:48 2014 -0400
10685 Add dissection of MIDL_NDRHEADERBLOB used in drsuapi and some other protocols
10688 Change-Id: If4a8603a7cb62894cc46094056dd5313039884b2
10689 Reviewed-on: https://code.wireshark.org/review/4604
10690 Petri-Dish: Michael Mann <mmann78@netscape.net>
10691 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10692 Reviewed-by: Michael Mann <mmann78@netscape.net>
10695 Author: Gerald Combs <gerald@wireshark.org>
10696 Date: Fri Oct 10 17:19:55 2014 -0700
10698 CMake: Don't add Custom.make to the bundle.
10700 Change-Id: I08f2701e4450f34aa9d840cc5f507e9348e115bd
10701 Reviewed-on: https://code.wireshark.org/review/4605
10702 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10705 Author: Michael Mann <mmann78@netscape.net>
10706 Date: Fri Oct 10 19:22:45 2014 -0400
10708 Dissection of sid28 needs null check.
10711 Change-Id: I8fcfbbd96833af2c57754a4c8f96cf702972e22a
10712 Reviewed-on: https://code.wireshark.org/review/4603
10713 Reviewed-by: Michael Mann <mmann78@netscape.net>
10716 Author: Gerald Combs <gerald@wireshark.org>
10717 Date: Fri Oct 10 15:03:26 2014 -0700
10719 Update READMEs to reflect recent CMake environment changes.
10721 Change-Id: Idbf879f20448eea0b69e793271439dec877832e9
10722 Reviewed-on: https://code.wireshark.org/review/4602
10723 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10726 Author: Guy Harris <guy@alum.mit.edu>
10727 Date: Fri Oct 10 13:20:02 2014 -0700
10729 Use names more like the other names in open_info.
10731 For open_info, use names based on the names in other lists.
10733 Also, in comments, indicate what the three count 'em three tables are
10734 used for, and clean up the type/subtype table.
10736 Change-Id: I7a763119e790d5970f87dff05284f465eebfb7e7
10737 Reviewed-on: https://code.wireshark.org/review/4599
10738 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10741 Author: cbontje <cbontje@gmail.com>
10742 Date: Fri Oct 10 14:00:48 2014 -0600
10744 DNP3 Protocol Bugfix / Enhancement
10746 - Fix for Single-bit Objects offset-pointer
10747 - Enhancement for Obj 12 Var 2 (Pattern Control Block) and Var 3 (Pattern Mask) Decoding
10750 Change-Id: I8d3f6cee4acbab09d0b93dab6b868cddd842b682
10751 Reviewed-on: https://code.wireshark.org/review/4597
10752 Reviewed-by: Michael Mann <mmann78@netscape.net>
10755 Author: Anish Bhatt <anish@chelsio.com>
10756 Date: Wed Oct 8 22:02:31 2014 -0700
10758 [ELMI] Add missing information elements, add support for sub-information elements.
10761 Updated with Bandwidth Profile support
10763 Change-Id: I0f31eb6c78a5e34bcb1c286a9a10730b3b63481c
10764 Reviewed-on: https://code.wireshark.org/review/4571
10765 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
10766 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
10767 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10768 Reviewed-by: Michael Mann <mmann78@netscape.net>
10771 Author: Michael Mann <mmann78@netscape.net>
10772 Date: Fri Oct 10 08:44:13 2014 -0400
10774 Remove (almost all) proto_tree_add_text calls in ISUP dissector.
10776 Change-Id: I57a01eacaa02e45c23bb4827ae982c897fb308ee
10777 Reviewed-on: https://code.wireshark.org/review/4592
10778 Reviewed-by: Michael Mann <mmann78@netscape.net>
10779 Petri-Dish: Michael Mann <mmann78@netscape.net>
10780 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
10781 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10784 Author: Pascal Quantin <pascal.quantin@gmail.com>
10785 Date: Fri Oct 10 07:16:21 2014 +0200
10787 NCP: switch to wmem memory and ensure that all fields are initialized
10789 Change-Id: Ia17e189baed05d8020654e6702a51f51bd384f26
10790 Reviewed-on: https://code.wireshark.org/review/4589
10791 Reviewed-by: Evan Huus <eapache@gmail.com>
10792 Reviewed-by: Michael Mann <mmann78@netscape.net>
10795 Author: Guy Harris <guy@alum.mit.edu>
10796 Date: Fri Oct 10 11:40:08 2014 -0700
10798 Version 3 has only absolute timestamps; don't set nsg_creltime.
10800 Version 3's time stamps are all absolute, so we can directly use the
10801 value in the file; we don't need to keep track of the time in the
10802 private data structure, and some compilers issue warnings due to setting
10803 it and then not using the value to which we set it.
10805 Change some names and indentation to match other file versions while
10808 Change-Id: I97698d933b87a8ad58d9e88ceedd75004797df69
10809 Reviewed-on: https://code.wireshark.org/review/4596
10810 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10813 Author: Pascal Quantin <pascal.quantin@gmail.com>
10814 Date: Thu Oct 9 22:48:59 2014 +0200
10816 GSM MAP: fix detection of SMS direction when application context version is < 3
10819 Change-Id: I4708fd9977e635c66ef1350ce5098520e4c2ce1e
10820 Reviewed-on: https://code.wireshark.org/review/4579
10821 Reviewed-by: Michael Mann <mmann78@netscape.net>
10824 Author: Gerald Combs <gerald@wireshark.org>
10825 Date: Fri Oct 10 08:32:51 2014 -0700
10827 CMake: Bundle the "share" directory files and directories.
10829 Work around a CMake bug using file globbing.
10831 Change-Id: I67dc8268154e05834e5d4e7d8f22c6eb25b24c1f
10832 Reviewed-on: https://code.wireshark.org/review/4595
10833 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10836 Author: Bill Meier <wmeier@newsguy.com>
10837 Date: Fri Oct 10 10:41:10 2014 -0400
10839 Add editor modelines; Adjust whitespace as needed.
10841 Change-Id: I3dc57f4c2ca57585103e3b71503ac4c332903e50
10842 Reviewed-on: https://code.wireshark.org/review/4594
10843 Reviewed-by: Bill Meier <wmeier@newsguy.com>
10846 Author: AndersBroman <anders.broman@ericsson.com>
10847 Date: Fri Oct 10 15:41:53 2014 +0200
10849 GTPv2: Presence-Reporting-Area-Elements-List do full dissection of ECGI
10852 Change-Id: I95d9ebf1d6f4eabe30b557fdc937d56006f8b123
10853 Reviewed-on: https://code.wireshark.org/review/4593
10854 Reviewed-by: Anders Broman <a.broman58@gmail.com>
10857 Author: Guy Harris <guy@alum.mit.edu>
10858 Date: Fri Oct 10 03:21:57 2014 -0700
10860 wtap_file_read_till_separator() can return values other than 1 on success.
10862 It returns the length of the string it read, so only treat 0 and -1 as
10863 errors. (0 either means "EOF" or "string is zero length", but this is
10864 only in the code that reads numbers, and a number needs at least 1
10865 digit, so both EOF and "zero-length string" mean "this isn't a valid
10866 Peek tagged file".)
10868 Change-Id: Ib83eb2f1e53d912a2138be01480e2b464cf936db
10869 Reviewed-on: https://code.wireshark.org/review/4591
10870 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10873 Author: Guy Harris <guy@alum.mit.edu>
10874 Date: Fri Oct 10 01:14:06 2014 -0700
10876 Fix some more int-to-enum conversion complaint.
10878 While we're at it, log a message if a Lua file format module lacks a
10879 read or a seek-read routine, rather than completely silently ignoring
10880 that module if it claims a file.
10882 Change-Id: I9778f7835922439e2d3708614689280ef7b61d33
10883 Reviewed-on: https://code.wireshark.org/review/4590
10884 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10887 Author: Gerald Combs <gerald@zing.org>
10888 Date: Thu Oct 9 18:24:18 2014 -0700
10890 CMake: Bundle our libraries.
10892 Change-Id: I5df4d794602f7e53c2f4f496597f8eaf7c7b6eaa
10893 Reviewed-on: https://code.wireshark.org/review/4588
10894 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10897 Author: Gerald Combs <gerald@zing.org>
10898 Date: Thu Oct 9 18:36:12 2014 -0700
10900 Add back a value_string conversion lost in g58cc452.
10902 I don't have a capture to check but this appears to be correct.
10904 Change-Id: I93405d1e3ec4aac3761d06e257db3ec2e32b2fc2
10905 Reviewed-on: https://code.wireshark.org/review/4587
10906 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10909 Author: Guy Harris <guy@alum.mit.edu>
10910 Date: Thu Oct 9 18:30:18 2014 -0700
10914 Change-Id: I0847846d50d6979f0f50a00438a834c7c7c2acc0
10915 Reviewed-on: https://code.wireshark.org/review/4586
10916 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10919 Author: Guy Harris <guy@alum.mit.edu>
10920 Date: Thu Oct 9 18:14:12 2014 -0700
10922 Don't treat int return values as valid wtap_open_return_val values.
10924 They happen to be, at least now, but that's not valid in C++, and it's
10925 probably unwise in any case.
10927 Change-Id: Ifd49920cfaa376e5e7788329ee83db3956a7cdff
10928 Reviewed-on: https://code.wireshark.org/review/4585
10929 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10932 Author: Guy Harris <guy@alum.mit.edu>
10933 Date: Thu Oct 9 18:09:06 2014 -0700
10935 Cast size_t to to gulong as the length argument to g_snprintf().
10937 Sadly, the GTK+ folks decided not to use size_t for the size argument,
10938 so it doesn't do the right thing on LLP64 platforms such as Windows.
10940 Change-Id: I2aa9096215c488b48f1cf68d2a285a48abb6f07f
10941 Reviewed-on: https://code.wireshark.org/review/4584
10942 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10945 Author: Guy Harris <guy@alum.mit.edu>
10946 Date: Thu Oct 9 18:04:16 2014 -0700
10948 Fix declared types of open routines.
10950 Change-Id: Ifa38dfec31ec5b03f00d6e077902184a9ae2ee0e
10951 Reviewed-on: https://code.wireshark.org/review/4583
10952 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10955 Author: Gerald Combs <gerald@wireshark.org>
10956 Date: Thu Oct 9 16:41:37 2014 -0700
10958 CMake: Bundle our plugins.
10960 plugins/*/CMakeLists.txt has a lot of repitition. We might want to
10961 create a module or include file to simplify things.
10963 Change-Id: Iadd453c286a4127beacd80edf6dc200aa9148852
10964 Reviewed-on: https://code.wireshark.org/review/4582
10965 Reviewed-by: Gerald Combs <gerald@wireshark.org>
10968 Author: Guy Harris <guy@alum.mit.edu>
10969 Date: Thu Oct 9 16:44:15 2014 -0700
10971 Use an enum for the open-routine return value, as per Evan Huus's suggestion.
10973 Clean up some things we ran across while making those changes.
10975 Change-Id: Ic0d8943d36e6e120d7af0a6148fad98015d1e83e
10976 Reviewed-on: https://code.wireshark.org/review/4581
10977 Reviewed-by: Guy Harris <guy@alum.mit.edu>
10980 Author: Pascal Quantin <pascal.quantin@gmail.com>
10981 Date: Wed Oct 8 23:58:18 2014 +0200
10983 Kerberos: fix decryption of DCERPC with Kerberos encryption
10986 Change-Id: I4e6feaf218da7f977f6c63d8bc204635f387672c
10987 Reviewed-on: https://code.wireshark.org/review/4566
10988 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
10991 Author: Pascal Quantin <pascal.quantin@gmail.com>
10992 Date: Thu Oct 9 00:09:50 2014 +0200
10994 Kerberos: remove debug logs when loading a keytab
10997 Change-Id: I9ea20cd4d046cc072c21fd3f87f6d6be40b08b27
10998 Reviewed-on: https://code.wireshark.org/review/4567
10999 Reviewed-by: Michael Mann <mmann78@netscape.net>
11000 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
11003 Author: Pascal Quantin <pascal.quantin@gmail.com>
11004 Date: Thu Oct 9 22:14:01 2014 +0200
11006 GTPv2: fix an infinite loop
11009 Change-Id: I916e15cecf0ec9dc607362b902709567d69243df
11010 Reviewed-on: https://code.wireshark.org/review/4578
11011 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
11012 Tested-by: Pascal Quantin <pascal.quantin@gmail.com>
11015 Author: Gerald Combs <gerald@wireshark.org>
11016 Date: Thu Oct 9 11:37:27 2014 -0700
11018 CMake: Build an application bundle (Wireshark.app) on OS X.
11020 Add an ENABLE_APPLICATION_BUNDLE option which is enabled by default on
11021 OS X and disabled elsewhere. The bundle is currently bare-bones and only
11022 contains the main executables, Info.plist, and application icon.
11024 Capitalize the main application name when ENABLE_APPLICATION_BUNDLE is
11025 set and on Windows.
11027 Start updating CPackConfig.txt for OS X packaging.
11031 - Add supporting libraries and frameworks.
11033 - Make the bundle standalone. I.e. call FIXUP_BUNDLE or
11034 replicate the relevant parts of osx-app.sh
11036 Change-Id: I4e25abd3b8cbe121ec8615b98706a15c58812cdb
11037 Reviewed-on: https://code.wireshark.org/review/4577
11038 Petri-Dish: Gerald Combs <gerald@wireshark.org>
11039 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
11040 Reviewed-by: Gerald Combs <gerald@wireshark.org>
11043 Author: Michael Mann <mmann78@netscape.net>
11044 Date: Thu Oct 9 09:09:58 2014 -0400
11046 Eliminate proto_tree_add_text from packet-lmp.c
11048 Also "refactored" a few fields into proto_tree_add_bitmask calls.
11050 Change-Id: I3a222b38e1992943d6ee4bd300026bc28c5bbb78
11051 Reviewed-on: https://code.wireshark.org/review/4575
11052 Petri-Dish: Michael Mann <mmann78@netscape.net>
11053 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
11054 Reviewed-by: Michael Mann <mmann78@netscape.net>
11057 Author: Sean O. Stalley <sean.stalley@intel.com>
11058 Date: Thu Oct 9 11:27:17 2014 -0700
11060 Add Dissection of MA packets over UDP
11062 Change-Id: Ic6e1cbb623f3e84b73ce7e4608f291baadc77bf6
11063 Reviewed-on: https://code.wireshark.org/review/4576
11064 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
11067 Author: Michael Mann <mmann78@netscape.net>
11068 Date: Wed Oct 8 19:45:41 2014 -0400
11070 Eliminate proto_tree_add_text from packet-nbns.c
11072 Some other cleanup while in the neighborhood. Not sure the all the proto_tree_add_expert calls are needed after each field (having implicit bounds error thrown should be sufficient), but left them in there.
11074 Change-Id: I3ca75ec9f51ccbed6b6ca792789daa8e7cebf34a
11075 Reviewed-on: https://code.wireshark.org/review/4574
11076 Petri-Dish: Michael Mann <mmann78@netscape.net>
11077 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
11078 Reviewed-by: Michael Mann <mmann78@netscape.net>
11081 Author: Anish Bhatt <anish@chelsio.com>
11082 Date: Wed Oct 8 22:21:34 2014 -0700
11084 [BACnet][trivial] change strings as per Bug 9640
11086 Change-Id: I542b5a96bcff6c779359b80ddce513524852272c
11087 Reviewed-on: https://code.wireshark.org/review/4572
11088 Reviewed-by: Anders Broman <a.broman58@gmail.com>
11091 Author: Stig Bjørlykke <stig@bjorlykke.org>
11092 Date: Wed Oct 8 19:32:55 2014 +0200
11094 Lua: Improved TreeItem:add documentation.
11096 The protofield is optional and can not be replaced with 'nil'
11097 as with the other fields for this function.
11099 Change-Id: I2b1dd7f290264394b400cea2110b65b657c71456
11100 Reviewed-on: https://code.wireshark.org/review/4549
11101 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
11102 Tested-by: Hadriel Kaplan <hadrielk@yahoo.com>
11103 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
11104 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
11107 Author: Guy Harris <guy@alum.mit.edu>
11108 Date: Wed Oct 8 17:27:08 2014 -0700
11110 Make the OPEN_INFO_ values members of an enum.
11112 Change-Id: I93dbd14f81492764bf5854ee40eebcd1e04f3e01
11113 Reviewed-on: https://code.wireshark.org/review/4570
11114 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11117 Author: Gerald Combs <gerald@wireshark.org>
11118 Date: Wed Oct 8 15:43:58 2014 -0700
11120 Be less lazy about disabling a Visual C++ warning.
11122 As Graham pointed out, "#pragma warning(disable..." affects the rest
11123 of the file. Add a push+pop so that we only operate on the line in
11124 question. Ideally we'd be able to use "suppress" but an "#endif"
11127 Change-Id: Ia01d6c245879f1c845dc68c18caea2cbceb273ef
11128 Reviewed-on: https://code.wireshark.org/review/4569
11129 Reviewed-by: Gerald Combs <gerald@wireshark.org>
11132 Author: Guy Harris <guy@alum.mit.edu>
11133 Date: Wed Oct 8 15:48:37 2014 -0700
11135 Use WTAP_ERR_DECOMPRESS for decompression errors.
11137 Distringuish "the compression data has a problem" from "the capture file
11138 (not compressed, or after decompression) data has a problem", with
11139 WTAP_ERR_DECOMPRESS used for the former (whether it's the gzipping
11140 decoded by our gunzip code or the Sniffer compression) and
11141 WTAP_ERR_BAD_FILE used for the latter.
11143 Change-Id: I8e6bff7edb480deba00c52a9e5afff607492e085
11144 Reviewed-on: https://code.wireshark.org/review/4568
11145 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11148 Author: Tomasz Moń <desowin@gmail.com>
11149 Date: Wed Oct 8 19:45:11 2014 +0200
11151 Fix --extcap-dlts call in extcap_example.py.
11153 There is regular expression that extracts only the number from
11154 --extcap-interface argument and only that number (as string) is being
11155 passed to extcap_dlts().
11157 Change-Id: I5159f9405a766c1edff792213b2aef72b9a29ba4
11158 Reviewed-on: https://code.wireshark.org/review/4550
11159 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
11162 Author: Guy Harris <guy@alum.mit.edu>
11163 Date: Wed Oct 8 14:12:54 2014 -0700
11165 Only set err_info on an error, and use g_strdup_printf().
11167 If the goal is to look like a libwiretap routine, we only need to set
11168 *err_info on an error, and we should set it to a g_mallocated string (or
11171 Handle WTAP_ERR_UNSUPPORTED while we're at it - we never return it, but
11172 we never return WTAP_ERR_UNSUPPORTED_ENCAP, either, but we handle it.
11174 Change-Id: I9d93c43278d22f0fa77ec1cf7f29b476c8dd0dd0
11175 Reviewed-on: https://code.wireshark.org/review/4565
11176 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11179 Author: Guy Harris <guy@alum.mit.edu>
11180 Date: Wed Oct 8 14:04:45 2014 -0700
11182 No need to set *err_info if there's no error.
11184 Change-Id: I98ae9ec50e079d48b6247bb208528b7c5ad16027
11185 Reviewed-on: https://code.wireshark.org/review/4564
11186 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11189 Author: Guy Harris <guy@alum.mit.edu>
11190 Date: Wed Oct 8 13:54:13 2014 -0700
11192 Robopatch and remove #MISSING comments.
11194 Change-Id: I611882a8b268046665488381be64aca89cdf3194
11195 Reviewed-on: https://code.wireshark.org/review/4563
11196 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11199 Author: Guy Harris <guy@alum.mit.edu>
11200 Date: Wed Oct 8 13:50:17 2014 -0700
11202 Use WTAP_ERR_BAD_FILE for malformed compressed data in DOS Sniffer files.
11204 Get rid of WTAP_ERR_UNC_TRUNCATED and WTAP_ERR_UNC_BAD_OFFSET, and lump
11205 them under WTAP_ERR_BAD_FILE, with an error string; they're just another
11206 form of "this file isn't a valid file of the type in question".
11208 Change-Id: I0e9ac7c2ee66c8d789234a301c1dc2173aef1312
11209 Reviewed-on: https://code.wireshark.org/review/4562
11210 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11213 Author: Gerald Combs <gerald@wireshark.org>
11214 Date: Wed Oct 8 13:44:46 2014 -0700
11216 Make sure we don't dereference a null pointer.
11218 Change-Id: I033c60cdc5b78f4db31903277c659661e0dc5123
11219 Reviewed-on: https://code.wireshark.org/review/4561
11220 Reviewed-by: Gerald Combs <gerald@wireshark.org>
11223 Author: Guy Harris <guy@alum.mit.edu>
11224 Date: Wed Oct 8 13:24:57 2014 -0700
11228 Change-Id: I0ebaa1b99bc9c7e51be10f3f8825280782f26190
11229 Reviewed-on: https://code.wireshark.org/review/4560
11230 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11233 Author: Stig Bjørlykke <stig@bjorlykke.org>
11234 Date: Wed Oct 8 21:50:15 2014 +0200
11236 ANSI 683: Removed unused assignments.
11238 Change-Id: I952ce5329f69fa947e39b020a70a06f2bbf8a014
11239 Reviewed-on: https://code.wireshark.org/review/4558
11240 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
11243 Author: Guy Harris <guy@alum.mit.edu>
11244 Date: Wed Oct 8 13:09:46 2014 -0700
11246 "long" does not necessary mean "64-bit". Use G_GINT64_MODIFIER.
11248 Change-Id: I2521bf368ea30ac691af50c760a63b81efedeeae
11249 Reviewed-on: https://code.wireshark.org/review/4559
11250 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11253 Author: Gerald Combs <gerald@wireshark.org>
11254 Date: Tue Oct 7 10:11:45 2014 -0700
11256 Try to speed up ping-dependent capture tests.
11258 Ping four times a second for ~60 seconds. Save the subprocess PID so that
11259 we can kill it when we're done with each test instead of waiting for it
11262 Change-Id: I64f889c700e8a6fa1bc1c3916ef045341ef59cc6
11263 Reviewed-on: https://code.wireshark.org/review/4557
11264 Reviewed-by: Gerald Combs <gerald@wireshark.org>
11267 Author: Guy Harris <guy@alum.mit.edu>
11268 Date: Wed Oct 8 11:44:03 2014 -0700
11270 Set err_info to null for errors that don't have an informaton string.
11272 Change-Id: Ibbcf3496ebfb20c53b953db84b2ddb69083dcb86
11273 Reviewed-on: https://code.wireshark.org/review/4556
11274 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11277 Author: Tomasz Moń <desowin@gmail.com>
11278 Date: Wed Oct 8 19:35:25 2014 +0200
11280 Remove redundant and erroneous debug log message.
11282 Change-Id: I91d6131b3b4b7ef670f0d188ebd6da3947c49bdc
11283 Reviewed-on: https://code.wireshark.org/review/4548
11284 Reviewed-by: Michael Mann <mmann78@netscape.net>
11287 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
11288 Date: Wed Oct 8 19:57:49 2014 +0200
11290 DCERPC (DRSUAPI) Fix typo found on idl file
11292 Change-Id: I79ad05122ae48de671c9c919bab6b3e8d94a50de
11293 Reviewed-on: https://code.wireshark.org/review/4554
11294 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
11297 Author: Johan Wahl <johan.wahl@ericsson.com>
11298 Date: Wed Oct 8 10:55:57 2014 +0200
11300 SIP Enhance dissecion of PATH
11302 Change-Id: I0508a886fb664f36b51464a9dfd6936092e197f8
11303 Reviewed-on: https://code.wireshark.org/review/4543
11304 Reviewed-by: Anders Broman <a.broman58@gmail.com>
11307 Author: Anish Bhatt <anish@chelsio.com>
11308 Date: Tue Oct 7 21:18:18 2014 -0700
11310 elmi: Fix bug in message type coding
11313 Change-Id: Ide6237afb71c79243347dedd1c744b3e97ff612e
11314 Reviewed-on: https://code.wireshark.org/review/4542
11315 Reviewed-by: Evan Huus <eapache@gmail.com>
11318 Author: Anish Bhatt <anish@chelsio.com>
11319 Date: Wed Oct 8 03:42:55 2014 -0700
11321 [tools] Add missing GPL license to generate-bacnet-vendors.py
11323 Change-Id: I15336a5f759fea6b1fb4f6c5a05807d797a7f5aa
11324 Reviewed-on: https://code.wireshark.org/review/4544
11325 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
11328 Author: Evan Huus <eapache@gmail.com>
11329 Date: Tue Oct 7 17:43:18 2014 -0400
11331 Qt capture interfaces dialogue string tweaks
11333 To clarify that capturing always uses a file, the checkbox only controls whether
11334 that file is temporary or persisted.
11336 Change-Id: I939e1fdf488f53245166612193c60a366f63a18b
11337 Reviewed-on: https://code.wireshark.org/review/4537
11338 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
11341 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
11342 Date: Sun Oct 5 19:34:46 2014 +0200
11344 Remove #pragma warning (MSVC) for PIDL generate dissector
11346 Change-Id: I1e4c7944a2cd877f5c707703dcff44fe9f955a2c
11347 Reviewed-on: https://code.wireshark.org/review/4479
11348 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
11351 Author: Tomasz Moń <desowin@gmail.com>
11352 Date: Tue Oct 7 23:14:21 2014 +0200
11354 Fix extcap boolean flag handling.
11356 Change-Id: I4c6b32805d4138ef0912fbf1b129a5e97776ab9c
11357 Reviewed-on: https://code.wireshark.org/review/4535
11358 Reviewed-by: Roland Knall <rknall@gmail.com>
11359 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
11362 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
11363 Date: Tue Oct 7 08:40:19 2014 +0200
11365 DCERPC DFS: Remove from Dirty PIDL list
11367 Change-Id: I87bd196d1c4ba14d9af6d174754b37d2b4d772c8
11368 Reviewed-on: https://code.wireshark.org/review/4527
11369 Petri-Dish: Anders Broman <a.broman58@gmail.com>
11370 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
11371 Reviewed-by: Anders Broman <a.broman58@gmail.com>
11374 Author: Anish Bhatt <anish@chelsio.com>
11375 Date: Tue Oct 7 00:53:18 2014 -0700
11377 [bacnet] update vendors list, fix whitespace issues, all generated via script
11379 Change-Id: Ieb4b169dfcf5e89b7b2a2cb90b6572a3d973d744
11380 Reviewed-on: https://code.wireshark.org/review/4519
11381 Reviewed-by: Michael Mann <mmann78@netscape.net>
11384 Author: Lorand Jakab <ljakab@ac.upc.edu>
11385 Date: Mon Sep 22 11:10:45 2014 -0700
11387 Add support for LISP over TCP control messages
11389 draft-kouvelas-lisp-rloc-membership-00 specifies 9 new LISP control
11390 message types using TCP transport instead of UDP (which is used by all
11391 existing messages). These new messages are related to each other and
11392 are used to exchange RLOC membership information between a tunnel router
11396 Change-Id: I129f0d6344693092bd5d0efb06b025e89fd26bf2
11397 Signed-off-by: Lorand Jakab <ljakab@ac.upc.edu>
11398 Reviewed-on: https://code.wireshark.org/review/4253
11399 Petri-Dish: Michael Mann <mmann78@netscape.net>
11400 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
11401 Reviewed-by: Michael Mann <mmann78@netscape.net>
11404 Author: Guy Harris <guy@alum.mit.edu>
11405 Date: Tue Oct 7 16:22:53 2014 -0700
11407 Provide an error message for WTAP_ERR_CANT_WRITE.
11409 Change-Id: Iffc762ba60ac523148310ea2a432d4953bc64a94
11410 Reviewed-on: https://code.wireshark.org/review/4541
11411 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11414 Author: Guy Harris <guy@alum.mit.edu>
11415 Date: Tue Oct 7 16:18:47 2014 -0700
11417 No need for WTAP_ERR_CANT_READ.
11419 Unlike the standard I/O routines, the code we introduced that supports
11420 fast random seeking on gzipped files will always supply some specific
11421 error code for read errors, so we don't need WTAP_ERR_CANT_READ.
11423 Add WTAP_ERR_CANT_WRITE for writing, as we're still using the standard
11424 I/O routines for that. Set errno to WTAP_ERR_CANT_WRITE before calling
11425 fwrite() in wtap_dump_file_write(), so that it's used if fwrite() fails
11426 without setting errno.
11428 Change-Id: I6bf066a6838284a532737aa65fd0c9bb3639ad63
11429 Reviewed-on: https://code.wireshark.org/review/4540
11430 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11433 Author: Guy Harris <guy@alum.mit.edu>
11434 Date: Tue Oct 7 15:48:29 2014 -0700
11436 Replace another file_read() call with wtap_read_bytes().
11438 Change-Id: I7b5e82c3a2fc4b4c16bf466508546558c584c150
11439 Reviewed-on: https://code.wireshark.org/review/4539
11440 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11443 Author: Guy Harris <guy@alum.mit.edu>
11444 Date: Tue Oct 7 15:07:25 2014 -0700
11446 Close some memory leaks for bad K12 RF5 files.
11448 Change-Id: Ic4272a5637463fdb4d23f80d81341a0e6ea33de3
11449 Reviewed-on: https://code.wireshark.org/review/4538
11450 Reviewed-by: Guy Harris <guy@alum.mit.edu>
11453 Author: Anish Bhatt <anish@chelsio.com>
11454 Date: Tue Oct 7 00:55:33 2014 -0700
11456 [tools] add script to automatically generate bacnet vendors
11458 Requires beautifulsoup4 for parsing, translitcodec for converting accents/diaeresis etc to regular text
11460 Change-Id: I4d400f15916ee3ab07fa14b09fca12beac2010f3
11461 Reviewed-on: https://code.wireshark.org/review/4518
11462 Reviewed-by: Evan Huus <eapache@gmail.com>
11463 Reviewed-by: Anders Broman <a.broman58@gmail.com>
11466 Author: Evan Huus <eapache@gmail.com>
11467 Date: Tue Oct 7 17:24:17 2014 -0400
11469 ANSI683: Fix mobile country code base
11472 Field 'Mobile country code (MCC_T)' (ansi_683.mcc_t) is an integral value
11473 (FT_UINT16) but is being displayed as BASE_NONE
11475 Change-Id: I2d87075b0c982bcaf0e855653d49eb891e83b70d
11476 Reviewed-on: https://code.wireshark.org/review/4536
11477 Reviewed-by: Evan Huus <eapache@gmail.com>
11480 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
11481 Date: Tue Oct 7 08:40:03 2014 +0200
11483 GSM (bssmap): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
11485 Change-Id: I9fadd0edc26e5525cfdd15fc62062f19fef16d10
11486 Reviewed-on: https://code.wireshark.org/review/4526
11487 Reviewed-by: Anders Broman <a.broman58@gmail.com>
11490 Author: Michael Mann <mmann78@netscape.net>
11491 Date: Tue Oct 7 07:51:52 2014 -0400
11493 Overhaul the filterability of packet-ansi_683.c
11495 It's (ab)use of proto_tree_add_text was "hidden" behind a single FT_NONE hf item, that effectively had the same behavior of proto_tree_add_text, but wouldn't show up in checkAPIs.pl. Replaced the (over 200+) proto_tree_add_none_format calls with proto_tree_add_text and then ran convert_proto_tree_add_text.pl on the dissector. That started the cleanup, and I did more while in the neighborhood.
11497 Change-Id: I89e09cf23e8998bcc9197f9a4043e1fc2850fc8c
11498 Reviewed-on: https://code.wireshark.org/review/4521
11499 Petri-Dish: Michael Mann <mmann78@netscape.net>
11500 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
11501 Reviewed-by: Michael Mann <mmann78@netscape.net>
11504 Author: Anish Bhatt <anish@chelsio.com>
11505 Date: Mon Oct 6 22:34:02 2014 -0700
11507 [iSCSI] Fix incorrect heuristic.
11509 The only valid check for Expected Data Transfer Length is :
11510 R and W MUST NOT both be 0 when the Expected Data Transfer Length and/or
11511 Bidirectional Read Expected Data Transfer Length are not 0
11514 Change-Id: I5503a5ad524c4e237b143696fc8eda895bcb9172
11515 Reviewed-on: https://code.wireshark.org/review/4514
11516 Reviewed-by: Michael Mann <mmann78@netscape.net>
11519 Author: Stig Bjørlykke <stig@bjorlykke.org>
11520 Date: Tue Oct 7 18:18:32 2014 +0200
11522 asn2wrs: Added support for #.SYNTAX_NEW
11524 This allows syntaxes to be registered as "new" dissectors.
11526 Change-Id: Ibb76688d9d3cbf47222610956aa627fa374bcbce
11527 Reviewed-on: https://code.wireshark.org/review/4524
11528 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
11529 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
11532 Author: Stig Bjørlykke <stig@bjorlykke.org>
11533 Date: Mon Oct 6 15:17:46 2014 +0200
11535 ASN1: Added support for using #.REGISTER_NEW
11537 This will register BER PDU-dissectors as "new".
11538 Return number of bytes dissected from dissector_try_* functions.
11539 Return number of bytes dissected in DissectorTable:try()
11541 This will make it possible to get dissected length when using
11542 dissector_try_*() and dissected ASN.1 length in Lua when using
11543 DissectorTable:try() (as we already have for Dissector:call).
11545 Change-Id: Iee17a68dc214fa0fb50b25fc927026ad7c1cbce4
11546 Reviewed-on: https://code.wireshark.org/review/4531
11547 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
11548 Tested-by: Stig Bjørlykke <stig@bjorlykke.org>
11551 Author: Michał Orynicz <michal.orynicz@tieto.com>
11552 Date: Thu Oct 2 10:37:53 2014 +0200
11554 Add proper decoding for type field in OBEX headers
11556 Change type field type from byte sequence to string.
11558 Change-Id: I3e2ac6fbb5ce7187ba1183d63236e9a2bcd824ee
11559 Reviewed-on: https://code.wireshark.org/review/4417
11560 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
11561 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
11562 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
11563 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
11566 Author: Guy Harris <guy@alum.mit.edu>
11567 Date: Tue Oct 7 12:49:14 2014 -0700
11569 Make the code a bit more like the pre-new-APIs code.
11571 Change-Id: I40282d8825936d24480c9b77e2e7d9374b1de6b5
11572 Reviewed-on: https://code.wireshark.org/review/4534
11573 Reviewed-by: Guy Harris <guy@alum.mit.edu>