2 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3 Date: Sun Aug 30 23:18:34 2015 +0100
5 Allow "Decode As" for IPv6 over UDP
7 Change-Id: Ib28206e9573f1dd624be1d3c265fef405f65b19a
8 Reviewed-on: https://code.wireshark.org/review/10351
9 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
10 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
11 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
12 Reviewed-by: Michael Mann <mmann78@netscape.net>
15 Author: Dario Lombardo <lomato@gmail.com>
16 Date: Wed Sep 2 13:40:46 2015 +0200
18 idl2wrs: fix clang analyzer Warning complains.
20 890:9: warning: Access to field 'str' results in a dereference of a null pointer (loaded from variable 'token_list')
21 3132:4: warning: Value stored to 'str' is never read
22 3155:4: warning: Value stored to 'str' is never read
23 3166:4: warning: Value stored to 'str' is never read
24 3183:4: warning: Value stored to 'str' is never read
25 3192:4: warning: Value stored to 'str' is never read
26 3203:4: warning: Value stored to 'str' is never read
27 3220:4: warning: Value stored to 'str' is never read
30 Change-Id: If1a1acfc331e0648f95f6d6defe6533b6927ccaa
31 Reviewed-on: https://code.wireshark.org/review/10357
32 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
35 Author: Pascal Quantin <pascal.quantin@gmail.com>
36 Date: Wed Sep 2 12:43:23 2015 +0200
38 PER: followup of g59453fb
40 Change-Id: I45c02a249444e5f17d99eeb0ca8dea6f7a012262
41 Reviewed-on: https://code.wireshark.org/review/10356
42 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
43 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
44 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
45 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
48 Author: Dario Lombardo <lomato@gmail.com>
49 Date: Wed Sep 2 12:27:31 2015 +0200
51 dcerpc: fixed distcheck.
53 Change-Id: Ide0b95278786d45d9c41fb0fe3214dce0880b830
54 Reviewed-on: https://code.wireshark.org/review/10355
55 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
58 Author: Tom Haynes <loghyr@primarydata.com>
59 Date: Tue Sep 1 14:07:30 2015 -0700
61 nfs: Fix order of octets in IPv4 address
65 skull:bugs loghyr$ ~/ipv4/wireshark/tshark -r 2-layoutstats-in-1-compound.pcap -Y nfs -V | grep -i ipv4
66 [IPv4 address 113.12.31.172, protocol=tcp, port=2049]
70 skull:bugs loghyr$ ~/ipv4/wireshark/tshark -r 2-layoutstats-in-1-compound.pcap -Y nfs -V | grep -i ipv4
71 [IPv4 address 172.31.12.113, protocol=tcp, port=2049]
74 Change-Id: Ia6097ae76411f6ff9de1f53191c8fc767856e2d1
75 Signed-off-by: Tom Haynes <loghyr@primarydata.com>
76 Reviewed-on: https://code.wireshark.org/review/10347
77 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
78 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
79 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
82 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
83 Date: Wed Sep 2 07:48:34 2015 +0200
85 idl2wrs: Make Mac OSX buildbot happy
87 Change-Id: I5f9c860bec0f8d323d9f3cd7cf55e348654c8b8b
88 Reviewed-on: https://code.wireshark.org/review/10354
89 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
92 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
93 Date: Wed Sep 2 01:33:22 2015 +0100
95 IPv4: Remove extraneous colon from format string
97 Change-Id: If52f8086ec971cc43947ece3d8e062da8378fa95
98 Reviewed-on: https://code.wireshark.org/review/10352
99 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
102 Author: Michael Mann <mmann78@netscape.net>
103 Date: Tue Sep 1 22:14:47 2015 -0400
105 Eliminate proto_tree_add_text from packet-per.c
107 Change-Id: I67f572129821fb00e4478a30bfd4a52287b8b1a1
108 Reviewed-on: https://code.wireshark.org/review/10350
109 Petri-Dish: Michael Mann <mmann78@netscape.net>
110 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
111 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
114 Author: Michael Mann <mmann78@netscape.net>
115 Date: Tue Sep 1 20:18:15 2015 -0400
117 Eliminate proto_tree_add_text from some dissectors.
119 Change-Id: If617016f588bbf940f37699e27559dc5c59cf508
120 Reviewed-on: https://code.wireshark.org/review/10349
121 Reviewed-by: Michael Mann <mmann78@netscape.net>
122 Petri-Dish: Michael Mann <mmann78@netscape.net>
123 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
124 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
127 Author: Michael Mann <mmann78@netscape.net>
128 Date: Tue Sep 1 13:28:56 2015 -0400
130 Eliminate proto_tree_add_text from packet-rsvp.c
132 Change-Id: I95edc1b40c07a4addf194df6a2056e7b61193e5a
133 Reviewed-on: https://code.wireshark.org/review/10348
134 Reviewed-by: Michael Mann <mmann78@netscape.net>
135 Petri-Dish: Michael Mann <mmann78@netscape.net>
136 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
137 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
140 Author: Dario Lombardo <lomato@gmail.com>
141 Date: Fri Aug 14 12:02:38 2015 +0200
143 idl2wrs: some code cleanups.
145 Code cleanups include:
146 - sanity checks for malloc()
147 - change forbidden APIs into g_* versions
148 - minor indentation fixes
150 - add compilation for cmake and autotools
153 Change-Id: I825f04d9703448f9165d188be2bdd185fce5ff5d
154 Reviewed-on: https://code.wireshark.org/review/10030
155 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
156 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
157 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
158 Reviewed-by: Michael Mann <mmann78@netscape.net>
161 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
162 Date: Mon Aug 31 13:59:28 2015 +0200
164 MSDP: fix will never be executed [-Wunreachable-code]
166 Move tvbuff declaration for avoid https://llvm.org/bugs/show_bug.cgi?id=19020
170 Change-Id: I299d2413dc4effc5e6e34c289152b8f401f19342
171 Reviewed-on: https://code.wireshark.org/review/10326
172 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
173 Reviewed-by: Michael Mann <mmann78@netscape.net>
176 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
177 Date: Tue Sep 1 19:50:52 2015 +0200
179 ANSI: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
181 Change-Id: I981336271a8f6b41fe777f732069639df494c5d2
182 Reviewed-on: https://code.wireshark.org/review/10346
183 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
184 Reviewed-by: Michael Mann <mmann78@netscape.net>
187 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
188 Date: Mon Aug 31 14:01:46 2015 +0200
190 UMTS (mac): fix will never be executed [-Wunreachable-code]
193 Move tvbuff_t declaration for avoid https://llvm.org/bugs/show_bug.cgi?id=19020
198 Change-Id: Id26fd62273d6838774db161a8b3f6c7db94a2de1
199 Reviewed-on: https://code.wireshark.org/review/10328
200 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
201 Reviewed-by: Michael Mann <mmann78@netscape.net>
204 Author: Pascal Quantin <pascal.quantin@gmail.com>
205 Date: Tue Sep 1 19:39:44 2015 +0200
207 ANSI A: fix dissection of numerous fields broken in g7298a31
209 Change-Id: I09898cfc1aedc4b8067c6d12c94effc51a5ebbc0
210 Reviewed-on: https://code.wireshark.org/review/10345
211 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
212 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
213 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
216 Author: Gerald Combs <gerald@wireshark.org>
217 Date: Tue Sep 1 08:24:58 2015 -0700
219 Update the release notes.
221 Change-Id: I0ab4cc92c24048e4e77b12bcc205d7a15a5ddb74
222 Reviewed-on: https://code.wireshark.org/review/10343
223 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
224 Reviewed-by: Gerald Combs <gerald@wireshark.org>
227 Author: Gerald Combs <gerald@wireshark.org>
228 Date: Tue Sep 1 07:37:45 2015 -0700
230 Fixup the main window tab order.
232 Make sure the packet list is directly after the display filter edit in
233 the main window tab order. When we press enter in the display filter
234 edit, go to the next child in the tab order.
236 Change-Id: If46e178365dbd59feb5985e9f8fa8b55d004d864
237 Reviewed-on: https://code.wireshark.org/review/10342
238 Reviewed-by: Gerald Combs <gerald@wireshark.org>
241 Author: AndersBroman <anders.broman@ericsson.com>
242 Date: Tue Sep 1 09:53:38 2015 +0200
244 [mtp3_summary_dialog] Unused parameter warning with MSVC
245 mtp3_summary_dialog.cpp(315) : warning C4100: 'edt' : unreferenced formal para
246 mtp3_summary_dialog.cpp(314) : warning C4100: 'pinfo' -
248 Change-Id: Ia21e15ff6348f34bf8ae240f867f0ab2cade606a
249 Reviewed-on: https://code.wireshark.org/review/10340
250 Reviewed-by: Anders Broman <a.broman58@gmail.com>
253 Author: Michael Mann <mmann78@netscape.net>
254 Date: Mon Aug 31 00:20:49 2015 -0400
256 Eliminate proto_tree_add_text from ANSI dissectors.
258 Change-Id: I22dccb2f2d71897334e11632f4060ccfbf4794ad
259 Reviewed-on: https://code.wireshark.org/review/10334
260 Petri-Dish: Michael Mann <mmann78@netscape.net>
261 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
262 Reviewed-by: Anders Broman <a.broman58@gmail.com>
265 Author: Gerald Combs <gerald@wireshark.org>
266 Date: Mon Aug 31 16:06:33 2015 -0700
268 Convert the WSP stats to generic stat API.
270 Add support for multiple tables to SimpleStatisticsDialog.
272 Change-Id: I843d901db092d2f2856d3d1a16f29f85fb41374b
273 Reviewed-on: https://code.wireshark.org/review/10339
274 Petri-Dish: Gerald Combs <gerald@wireshark.org>
275 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
276 Reviewed-by: Gerald Combs <gerald@wireshark.org>
279 Author: Gerald Combs <gerald@wireshark.org>
280 Date: Mon Aug 31 12:24:48 2015 -0700
282 Convert the MTP3 stats to new "generic stat API".
284 Convert both the MTP3 statistics and summary. As with the GSM stats this
287 Change-Id: I7af8d5f21c8161dc95f7f2c710f32364b6f6a431
288 Reviewed-on: https://code.wireshark.org/review/10338
289 Petri-Dish: Gerald Combs <gerald@wireshark.org>
290 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
291 Reviewed-by: Gerald Combs <gerald@wireshark.org>
294 Author: Pascal Quantin <pascal.quantin@gmail.com>
295 Date: Mon Aug 31 12:19:34 2015 +0200
297 Windows: update GeoIP library to 1.6.6
299 Change-Id: I56f58e52fa39fdddd35bcc7ef6d96cfa4042892d
300 Reviewed-on: https://code.wireshark.org/review/10333
301 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
302 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
303 Reviewed-by: Anders Broman <a.broman58@gmail.com>
306 Author: Pascal Quantin <pascal.quantin@gmail.com>
307 Date: Mon Aug 31 22:10:23 2015 +0200
311 Change-Id: Iba5f12637e0f494805f2d9aab370fb42a32c1cb9
312 Reviewed-on: https://code.wireshark.org/review/10335
313 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
316 Author: Stig Bjørlykke <stig@bjorlykke.org>
317 Date: Sat Aug 29 22:59:00 2015 +0200
319 Qt/Lua: Call atclose when TextWindow closes
321 The close callback was never called because the destructor was never called.
323 Change-Id: I9f6204858bc5d5e48d0aedc90b0e242ab70e161c
324 Reviewed-on: https://code.wireshark.org/review/10321
325 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
328 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
329 Date: Wed Aug 12 20:58:52 2015 +0200
331 NGHTTP2: Update to 1.3.0
333 Change-Id: Ia12396b3b4a2bb4dcbdce63d06558b6474cd588e
334 Reviewed-on: https://code.wireshark.org/review/10324
335 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
336 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
337 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
340 Author: Gerald Combs <gerald@wireshark.org>
341 Date: Mon Aug 31 08:37:15 2015 -0700
343 Redraw timestamps when time display settings change.
345 As with g3bec655, we need to call columnsChanged (which invalidates
346 cached column strings) whenever any settings that generate those strings
347 change. Do so for the time display preferences in the View menu.
350 Change-Id: I71bf1cc0df2800902ecb7b734b8f12ebd85a4de5
351 Reviewed-on: https://code.wireshark.org/review/10331
352 Petri-Dish: Gerald Combs <gerald@wireshark.org>
353 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
354 Reviewed-by: Gerald Combs <gerald@wireshark.org>
357 Author: Gerald Combs <gerald@wireshark.org>
358 Date: Mon Aug 31 09:24:49 2015 -0700
360 Add a Telephony→SCTP submenu.
362 Add the current SCTP actions to the telephony menu to match the GTK+ UI.
364 Change-Id: Ie7471bcbd1a82fe3f203d60f5ea8a72d923f34b9
365 Reviewed-on: https://code.wireshark.org/review/10332
366 Reviewed-by: Gerald Combs <gerald@wireshark.org>
369 Author: Gerald Combs <gerald@wireshark.org>
370 Date: Fri Aug 28 16:46:17 2015 -0700
372 Redraw the packet list when name resolution changes.
374 Call columnsChanged (which invalidates cached column strings) when we
375 change our name resolution preferences from the View menu.
377 Remove the last sorted column tracking from gf19a173 while we're here
378 (it didn't work properly).
381 Change-Id: I7fea58d702b283028235d023f27ab0336d8643a4
382 Reviewed-on: https://code.wireshark.org/review/10301
383 Petri-Dish: Gerald Combs <gerald@wireshark.org>
384 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
385 Reviewed-by: Gerald Combs <gerald@wireshark.org>
388 Author: Michael Mann <mmann78@netscape.net>
389 Date: Fri Aug 28 22:41:07 2015 -0400
391 Eliminate proto_tree_add_text from packet-rtps.c
393 Change-Id: I353b4fcb3091e731a4b2a68e1932a5abc60c6038
394 Reviewed-on: https://code.wireshark.org/review/10323
395 Petri-Dish: Michael Mann <mmann78@netscape.net>
396 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
397 Reviewed-by: Anders Broman <a.broman58@gmail.com>
400 Author: Joerg Mayer <jmayer@loplof.de>
401 Date: Mon Aug 31 06:00:28 2015 +0400
403 Add a hidden item that allows to allow filtering on the station address.
404 This currently only works for data frames. A Fixme is in place for
407 Change-Id: I0a72a9a3e40cf8269856fbbcd97b270af422afa2
408 Reviewed-on: https://code.wireshark.org/review/10322
409 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
412 Author: Martin Kaiser <wireshark@kaiser.cx>
413 Date: Sun Aug 30 20:31:35 2015 +0200
415 dlsw: don't THROW() an exception from a dissector
417 Change-Id: I897202e7fb2987f608ca4f98aa1a1dc4b7dbd995
418 Reviewed-on: https://code.wireshark.org/review/10320
419 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
422 Author: Martin Kaiser <wireshark@kaiser.cx>
423 Date: Sun Aug 30 20:08:53 2015 +0200
425 dlsw: remove unnecessary if (tree) checks
427 don't create an expert info under if (tree)
429 Change-Id: I2c8f90483c434d708a97b621621ca123fc505edc
430 Reviewed-on: https://code.wireshark.org/review/10319
431 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
434 Author: Hadriel Kaplan <hadrielk@yahoo.com>
435 Date: Sun Aug 30 10:16:16 2015 -0400
437 Add debug printing to tshark
439 Add g_warning functions for tshark debug printing, disabled by default.
441 Change-Id: If1720b790b75bd1228afa62efac49dc04bc8addb
442 Reviewed-on: https://code.wireshark.org/review/10314
443 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
446 Author: Pascal Quantin <pascal.quantin@gmail.com>
447 Date: Sat Aug 29 22:28:01 2015 +0200
449 Add Lua 5.2.3 built with MSVC2015
451 Change-Id: I9b173f5136f858e4f95fb5b0688ef02c08a8d9e4
452 Reviewed-on: https://code.wireshark.org/review/10313
453 Reviewed-by: Anders Broman <a.broman58@gmail.com>
456 Author: Gerald Combs <gerald@wireshark.org>
457 Date: Sun Aug 30 08:10:04 2015 -0700
459 [Automatic update for 2015-08-30]
461 Update manuf, services enterprise-numbers, translations, and other items.
463 Change-Id: I37400bf1fac15fcd5f2946913b96184b1828f091
464 Reviewed-on: https://code.wireshark.org/review/10317
465 Reviewed-by: Gerald Combs <gerald@wireshark.org>
468 Author: Pyeole <pyeole@ncsu.edu>
469 Date: Sat Aug 29 15:36:41 2015 -0400
471 BGP: fixed incorrect NLRI decoding
474 Change-Id: I967b9596edad1e3656e139d0ca3a0e3c389d80ea
475 Reviewed-on: https://code.wireshark.org/review/10308
476 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
479 Author: Dario Lombardo <lomato@gmail.com>
480 Date: Thu Aug 27 18:01:27 2015 +0200
482 stanag4607: add check for wtap max size.
485 Change-Id: Ic269046e697ac5e65301caf4ea5586098d030458
486 Reviewed-on: https://code.wireshark.org/review/10279
487 Reviewed-by: Evan Huus <eapache@gmail.com>
488 Petri-Dish: Evan Huus <eapache@gmail.com>
489 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
490 Reviewed-by: Anders Broman <a.broman58@gmail.com>
493 Author: Pascal Quantin <pascal.quantin@gmail.com>
494 Date: Sat Aug 29 22:54:54 2015 +0200
496 CBOR: fix definition of cbor.type.tag64 field
499 Change-Id: I070c8c397a41c0c8231720c611938d7282c03d19
500 Reviewed-on: https://code.wireshark.org/review/10310
501 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
502 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
503 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
506 Author: Hadriel Kaplan <hadrielk@yahoo.com>
507 Date: Sat Aug 29 19:14:13 2015 -0400
509 pcapng: drop count is unknown for ISB without isb_if_drop option
512 Change-Id: I38bcc2570c2efc461e4eb0edbff8ac2a7371c725
513 Reviewed-on: https://code.wireshark.org/review/10311
514 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
515 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
516 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
519 Author: Hadriel Kaplan <hadrielk@yahoo.com>
520 Date: Sat Aug 29 14:16:52 2015 -0400
522 pcapng: handle NRB with options
524 If a pcapng Name Resolution Block has options, they should not screw up the
525 pcapng reader and cause it to fail to read the file.
528 Change-Id: Ic27cba937b6d93a3d9ed92522ed6b39ae2daeb8f
529 Reviewed-on: https://code.wireshark.org/review/10307
530 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
531 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
532 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
535 Author: Kevin Bracey <kevin.bracey@arm.com>
536 Date: Wed Jul 22 15:36:07 2015 +0300
538 6LoWPAN: IPv6 Fragment Headers don't have a Length field
540 RFC 6282 specifies special handling of the "Length" field in compressed
541 IPv6 extension headers. However, the Fragment Header does not have a
542 Length field, so this special handling does not apply - the second octet
543 should be treated as opaque data, and the header length is always 8
547 Change-Id: I28fcd66d96f58a5959bb669caf4244afaca9e67e
548 Reviewed-on: https://code.wireshark.org/review/10231
549 Reviewed-by: Michael Mann <mmann78@netscape.net>
550 Petri-Dish: Michael Mann <mmann78@netscape.net>
551 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
552 Reviewed-by: Evan Huus <eapache@gmail.com>
555 Author: Hadriel Kaplan <hadrielk@yahoo.com>
556 Date: Sat Aug 29 10:30:15 2015 -0400
558 pcapng: do not byte-swap NRB IPv4 address
560 Per the spec, it's always encoded in network order (4 separate bytes), and
561 thus should not be swapped on read.
564 Change-Id: I6a650896b324f42bfd2e05759c84e87ace733372
565 Reviewed-on: https://code.wireshark.org/review/10304
566 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
567 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
568 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
571 Author: Hadriel Kaplan <hadrielk@yahoo.com>
572 Date: Sat Aug 29 10:00:02 2015 -0400
574 pcapng: make SPB cap_len the same as packet_len if IDB snaplen is 0
576 An IDB snaplen of 0 means no limit, so a Simple Packet Block's capture
577 length should be the same as its encoded packet length in such a case.
580 Change-Id: I8856d6c6a669a0048ea64b3adbd23c37a598431d
581 Reviewed-on: https://code.wireshark.org/review/10303
582 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
583 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
584 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
587 Author: Jim Young <jyoung@gsu.edu>
588 Date: Fri Jul 10 01:50:19 2015 -0400
590 Insure Qt Capture preferences dialog displays default capture device (if any)
592 In CapturePreferencesFrame::updateWidgets() save and restore the default
593 capture device name because the first call (and only the first call) in
594 the loop with addItem() triggers on_defaultInterfaceComboBox_editTextChanged()
595 which unconditionally sets the default name as the first non-hidden device.
598 Change-Id: Ie93f84010a19e8144efa46ce889fb9064979e0e9
599 Reviewed-on: https://code.wireshark.org/review/9584
600 Reviewed-by: Gerald Combs <gerald@wireshark.org>
601 Petri-Dish: Gerald Combs <gerald@wireshark.org>
602 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
603 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
606 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
607 Date: Fri Aug 28 15:53:42 2015 +0200
609 CBOR: fix no previous prototype for proto_reg*_cbor [-Wmissing-prototypes]
611 Change-Id: I20476046fc2338484ab85757cad7b19f4e41e4be
612 Reviewed-on: https://code.wireshark.org/review/10283
613 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
614 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
615 Reviewed-by: Anders Broman <a.broman58@gmail.com>
618 Author: Jeffrey Smith <whydoubt@gmail.com>
619 Date: Fri Aug 28 17:28:31 2015 -0500
621 bootp/dhcp: fix Alcatel suboption detection bug
623 Change-Id: I4a4222f3f30bf8e996770295756dd206b5ce101b
624 Reviewed-on: https://code.wireshark.org/review/10297
625 Reviewed-by: Anders Broman <a.broman58@gmail.com>
628 Author: Stig Bjørlykke <stig@bjorlykke.org>
629 Date: Fri Aug 28 19:45:28 2015 +0200
631 Added Reload Lua plugins to the release notes.
633 Change-Id: I2ea50b331322e0bc66bf5f3b48d9c2e78bbdd1e5
634 Reviewed-on: https://code.wireshark.org/review/10285
635 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
638 Author: Gerald Combs <gerald@wireshark.org>
639 Date: Fri Aug 28 15:49:22 2015 -0700
641 Fix a GHashTable assertion in DecodeAsDialog.
643 Make sure we don't call g_hash_table_removed from g_hash_table_foreach,
644 which generates an assertion error.
647 Change-Id: I00283c97b0fc63551b901c0fd526b60c0fb80ace
648 Reviewed-on: https://code.wireshark.org/review/10296
649 Petri-Dish: Gerald Combs <gerald@wireshark.org>
650 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
651 Reviewed-by: Gerald Combs <gerald@wireshark.org>
654 Author: Guy Harris <guy@alum.mit.edu>
655 Date: Fri Aug 28 16:31:33 2015 -0700
657 Block sizes are unsigned 32-bit quantities; don't stuff them into an int.
659 *Especially* don't stuff the amount of remaining data in a block into an
660 int that will then be passed to file_skip() as an amount to skip ahead,
661 as a Really Large Value will turn into a negative value and produce
662 various forms of bizarre and tricky-to-debug behavior.
664 Change-Id: I4d0a6b36fe50df84925690ad688a3ab0433ceb17
665 Reviewed-on: https://code.wireshark.org/review/10299
666 Reviewed-by: Guy Harris <guy@alum.mit.edu>
669 Author: Stig Bjørlykke <stig@bjorlykke.org>
670 Date: Fri Aug 28 23:30:30 2015 +0200
672 Qt: Fix use-after-free pattern
674 Change-Id: I7f6d9316234c1ccfec1ec5b5c3675b3237f22eda
675 Reviewed-on: https://code.wireshark.org/review/10294
676 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
677 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
678 Reviewed-by: Gerald Combs <gerald@wireshark.org>
681 Author: Gerald Combs <gerald@wireshark.org>
682 Date: Fri Aug 28 14:03:34 2015 -0700
684 Disable most of the main window while we're tapping.
686 Our event loop is nested when we read packets. Disable the main window's
687 central widget while we're retapping packets in order to minimize the
688 chance of ending up in an unexpected state while analyzing packets.
690 Note that we will probably want to disable more of the main window and
691 do so in other parts of the code.
693 Change-Id: I68a00fe43d2ac9e7c0749751abd1c10c47155b3b
694 Reviewed-on: https://code.wireshark.org/review/10293
695 Petri-Dish: Gerald Combs <gerald@wireshark.org>
696 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
697 Reviewed-by: Gerald Combs <gerald@wireshark.org>
700 Author: Guy Harris <guy@alum.mit.edu>
701 Date: Fri Aug 28 15:54:53 2015 -0700
703 Have separate variables for read and write errors.
705 That way, when we check for read errors, we don't run the risk of
706 thinking we have a read error after we get a write error.
708 Change-Id: Idb79822d30989b2529433878798c577a76eacca7
709 Reviewed-on: https://code.wireshark.org/review/10295
710 Reviewed-by: Guy Harris <guy@alum.mit.edu>
713 Author: Gerald Combs <gerald@wireshark.org>
714 Date: Fri Aug 28 12:57:57 2015 -0700
716 Don't show a progress frame if our file was closed.
718 Change-Id: Ie363f6764f4e8b2b5c476b85f7ddb0233a127f6e
719 Reviewed-on: https://code.wireshark.org/review/10290
720 Petri-Dish: Gerald Combs <gerald@wireshark.org>
721 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
722 Reviewed-by: Gerald Combs <gerald@wireshark.org>
725 Author: Gerald Combs <gerald@wireshark.org>
726 Date: Fri Aug 28 12:28:24 2015 -0700
728 Don't dissect twice from TapParameterDialog.
730 When the user applies a display filter in TapParameterDialog we're about
731 to start tapping. We need to set the display filter in the main window
732 but we shouldn't apply it.
734 Change-Id: I08bed5c7f470f1dbf32817a7d999f09d2c52f168
735 Reviewed-on: https://code.wireshark.org/review/10287
736 Petri-Dish: Gerald Combs <gerald@wireshark.org>
737 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
738 Reviewed-by: Gerald Combs <gerald@wireshark.org>
741 Author: Guy Harris <guy@alum.mit.edu>
742 Date: Fri Aug 28 12:49:18 2015 -0700
744 Get rid of trailing blanks.
746 Change-Id: I0b705c924464dcc4987ed0e7c67b106b2b648dce
747 Reviewed-on: https://code.wireshark.org/review/10289
748 Reviewed-by: Guy Harris <guy@alum.mit.edu>
751 Author: Guy Harris <guy@alum.mit.edu>
752 Date: Fri Aug 28 12:46:11 2015 -0700
754 Don't check the radio information when testing for an HT Control header.
756 I now read 8.2.4.1.10 "Order field" in 802.11-2012 as saying that, in
757 management and QoS data frames, the Order bit shouldn't be set for
758 non-HT, non-VHT frames, so we can just test it for those frame types
759 without bothering to check the radio metadata to see if the frame is an
762 This handles cases where the radio metadata isn't complete, e.g. an HT
763 frame with a radiotap header but no MCS field.
765 Handle this for *all* QoS data frames when capturing.
767 Get rid of the "fixed-length link-layer header" stuff; it's not being
770 Fix a case where we're appending text to a tree item without a space
771 separating it from the previous text.
774 Change-Id: I980f5b7509603b0c22c297fddc19434c08817913
775 Reviewed-on: https://code.wireshark.org/review/10288
776 Reviewed-by: Guy Harris <guy@alum.mit.edu>
779 Author: Guy Harris <guy@alum.mit.edu>
780 Date: Fri Aug 28 12:05:20 2015 -0700
782 Clean up scanning to guess the bitrate of an MPEG-2 Transport Stream file.
784 Don't treat an EOF at the beginning of a frame as an error.
786 Treat I/O errors as hard errors; treat short reads as an indication that
787 the file isn't an MPEG-2 Transport Stream file.
789 Treat the PCR for a given PID not going forward as an indication that
790 the file isn't an MPEG-2 Transport Stream file.
793 Change-Id: I42b5887049423f8265db9d121d7b5bd388e5b244
794 Reviewed-on: https://code.wireshark.org/review/10286
795 Reviewed-by: Guy Harris <guy@alum.mit.edu>
798 Author: Pascal Quantin <pascal.quantin@gmail.com>
799 Date: Thu Aug 27 23:35:58 2015 +0200
801 Preparation Host Flows: make ICMP(v6) code and type retrieval more robust
803 Do not retrieve type and code base on the info column content.
804 Instead store type and code in pinfo structure and retrieve them in sequence analysis tap.
806 Change-Id: I71cd505d7faf713c2372731495d47b45928a41f8
807 Reviewed-on: https://code.wireshark.org/review/10280
808 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
809 Reviewed-by: Pascal Artho <pascalartho@gmail.com>
810 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
811 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
814 Author: Gerald Combs <gerald@wireshark.org>
815 Date: Fri Aug 28 09:50:26 2015 -0700
817 Update the release notes.
819 Change-Id: I7fb0d307355320a77f011b59c71d1d54066b7d08
820 Reviewed-on: https://code.wireshark.org/review/10284
821 Reviewed-by: Gerald Combs <gerald@wireshark.org>
824 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
825 Date: Mon Jul 27 17:00:18 2015 +0200
827 ISAKMP: Add new CHACHA20/POLY1305 Transform Types Values (RFC7634)
829 From IANA ikev2-parameters (2015-08-24)
831 Change-Id: I02bfd9a0ffc9f863f4d266fcc56cd707c3e71725
832 Reviewed-on: https://code.wireshark.org/review/10282
833 Reviewed-by: Anders Broman <a.broman58@gmail.com>
836 Author: Gerald Combs <gerald@wireshark.org>
837 Date: Wed Aug 26 17:14:39 2015 -0700
839 Speed up column sorting.
841 The GTK+ UI sequentially dissects and caches column strings for all rows
842 before sorting a column. Do the same in the Qt UI, which can improve
843 performance considerably.
845 Don't colorize packets when sorting in the Qt UI unless it's necessary.
847 When sorting in the Qt UI, let the user cancel the initial packet
848 dissection. Note that we'll need to replace std::sort in order to
849 cancel out of sorting.
851 Use a pre-allocated and pre-compiled GRexex when we prime columns. Note
852 that we probably shouldn't parse a regular expression there.
854 Cache the last result of proto_registrar_get_byname.
856 Note performance hot spots elsewhere in the code.
860 GeoIP in packet-ip.c is pretty slow.
863 Change-Id: Ib34038fee08ef0319261faeffc4eca01e52f4bd3
864 Reviewed-on: https://code.wireshark.org/review/10275
865 Petri-Dish: Gerald Combs <gerald@wireshark.org>
866 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
867 Reviewed-by: Gerald Combs <gerald@wireshark.org>
870 Author: Gerald Combs <gerald@wireshark.org>
871 Date: Wed Aug 26 12:48:56 2015 -0700
873 More retapping fixups.
875 Disable the main file close and reload actions while we're retapping,
876 otherwise many of our dialogs will crash.
878 Disable the TapParameterDialog filter entry while we're retapping. This
879 keeps us from enabling the "Apply" button when we shouldn't.
881 Don't prematurely disconnect our signals in WiresharkDialog.
883 Change-Id: Iaf507eb4503b9c296766f109f2b8c71343263982
884 Reviewed-on: https://code.wireshark.org/review/10274
885 Petri-Dish: Gerald Combs <gerald@wireshark.org>
886 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
887 Reviewed-by: Gerald Combs <gerald@wireshark.org>
890 Author: Michael Mann <mmann78@netscape.net>
891 Date: Tue Aug 25 20:58:09 2015 -0400
893 Eliminate proto_tree_add_text from some dissectors.
895 Change-Id: I066b70cfd58f5fb3ffbcb2e238416747d9e7dd57
896 Reviewed-on: https://code.wireshark.org/review/10269
897 Reviewed-by: Michael Mann <mmann78@netscape.net>
898 Petri-Dish: Michael Mann <mmann78@netscape.net>
899 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
900 Reviewed-by: Anders Broman <a.broman58@gmail.com>
903 Author: Stig Bjørlykke <stig@bjorlykke.org>
904 Date: Mon Aug 24 15:00:39 2015 +0200
906 Support BER files bigger than 256kB
908 Also support APPLICATION as starting tag.
910 Change-Id: Id85b08e2594969c98c530532a32268b01d50965e
911 Reviewed-on: https://code.wireshark.org/review/10233
912 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
913 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
914 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
917 Author: Didier Arenzana <darenzana@yahoo.fr>
918 Date: Sun Aug 23 20:54:38 2015 +0200
920 RADIUS: Validation of response authenticators
922 This patch enables validation of response authenticator messages when
923 the shared secret is known.
924 The validation can be activated in the preferences.
925 It implements the validation protocol described in RFC 2865 page 16: Response Authenticator.
926 When an authenticator is invalid, the information is added in the header information.
927 It adds two flags for the display filter : radius.authenticator.valid and
928 radius.authenticator.invalid: since verification is not always possible we use
929 two flags to determine if the verification has been made or not, in the same way as
930 udp and tcp checksum validation is implemented.
931 The Authenticator field becomes a tree, and the value of the flags are visible in
934 Change-Id: I33a664f2265c6248e106cee7904c754089d50445
935 Reviewed-on: https://code.wireshark.org/review/10216
936 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
937 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
938 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
941 Author: Stig Bjørlykke <stig@bjorlykke.org>
942 Date: Tue Aug 25 14:51:50 2015 +0200
944 Qt: Fixed some memory leakages
946 Change-Id: I5bccf706001f9ff41197ed13b1be5a7404ca594f
947 Reviewed-on: https://code.wireshark.org/review/10251
948 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
949 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
950 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
953 Author: Stig Bjørlykke <stig@bjorlykke.org>
954 Date: Tue Aug 25 15:18:51 2015 +0200
956 Qt: Fixed some memory leakages
958 Change-Id: Ie8c9b7f8c9203acb5aec00d5553b911e0299f53c
959 Reviewed-on: https://code.wireshark.org/review/10253
960 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
961 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
962 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
965 Author: Stig Bjørlykke <stig@bjorlykke.org>
966 Date: Tue Aug 25 20:18:46 2015 +0200
968 Qt: Fixed some memory leakages
970 And changed strdup -> g_strdup
972 Change-Id: I62de106462259194738d633f16297eb1210f8ccf
973 Reviewed-on: https://code.wireshark.org/review/10259
974 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
977 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
978 Date: Wed Aug 26 10:32:52 2015 +0200
980 Lemon grammar: fix indent (use tabs)
982 Change-Id: I6fa38d5d85b25ac6c55fcfa67d6c8dba8482cc8c
983 Reviewed-on: https://code.wireshark.org/review/10266
984 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
985 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
986 Reviewed-by: Anders Broman <a.broman58@gmail.com>
989 Author: Michael Mann <mmann78@netscape.net>
990 Date: Tue Aug 25 19:14:59 2015 -0400
992 Remove calls of tvb_ensure_length_remaining.
994 The remaining calls seem to fall into 3 categories:
995 1. passing it to tvb_find_line_end when -1 (for length) will do.
996 2. duplicating the checking of tvb_reported_length_remaining, which is already in use near the tvb_ensure_length_remaining call.
997 3. Those that (probably) need tvb_ensure_capture_length_remaining
999 Change-Id: I1e77695251e055644bcbbb89f3c181c65d1671ca
1000 Reviewed-on: https://code.wireshark.org/review/10268
1001 Petri-Dish: Michael Mann <mmann78@netscape.net>
1002 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1003 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1006 Author: Gerald Combs <gerald@wireshark.org>
1007 Date: Wed Aug 26 11:24:29 2015 -0700
1009 Don't emit app signals from dialogs.
1011 Emitting PacketDissectionChanged from a dialog on can render the main
1012 window unusable on OS X. A workaround for this was added to the
1013 preferences dialog in g8fc2327. Generalize the workaround and use it
1016 Fix the "Enabled Protocols" action name while we're here.
1020 Change-Id: I89e98daaaedc877d3b13b0d33b6f3be033e323d7
1021 Reviewed-on: https://code.wireshark.org/review/10271
1022 Petri-Dish: Gerald Combs <gerald@wireshark.org>
1023 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1024 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1027 Author: Martin Kaiser <wireshark@kaiser.cx>
1028 Date: Wed Aug 26 22:52:06 2015 +0200
1030 sv: remove some unnecessary checks
1032 http://personal.strath.ac.uk/robert.c.atkinson/papers/sgms2011.pdf
1033 implies that appid, length and the two reserved fields are mandatory
1034 just try to dissect them, don't check if there's enough bytes remaining
1036 correct a typo while at it
1038 Change-Id: I09a315fc2c70161af527dca5661f877e09b63ff6
1039 Reviewed-on: https://code.wireshark.org/review/10273
1040 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
1043 Author: Stig Bjørlykke <stig@bjorlykke.org>
1044 Date: Mon Aug 24 22:12:17 2015 +0200
1046 Reload IO Graph Y fields when reload Lua plugins
1048 Change-Id: Ic3b9096c3c25839dd7d7bfe7af71eeb5b0bd745d
1049 Reviewed-on: https://code.wireshark.org/review/10239
1050 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
1051 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1052 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1055 Author: Jeffrey Smith <whydoubt@gmail.com>
1056 Date: Tue Aug 25 18:40:45 2015 -0500
1058 bootp/dhcp: tighten check for Alcatel extensions
1060 The check for Alcatel extensions in bootp/dhcp packets is very weak,
1061 resulting in some false positives. Then when trying to parse the
1062 suboptions, the result is an error on the packet.
1064 This change eliminates some false positives by adding a test that the
1065 vendor-specific option contents match the encapsulated format described
1066 in section 8.4 of RFC2132.
1068 Change-Id: Ie4188ff900426c2d80a5694fbba5c88385625a61
1069 Reviewed-on: https://code.wireshark.org/review/10267
1070 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1073 Author: Gerald Combs <gerald@wireshark.org>
1074 Date: Wed Aug 26 08:41:50 2015 -0700
1076 Add missing callback support.
1078 Change-Id: I90838ccb701c93b11b216d0eb9973cbac8627129
1079 Reviewed-on: https://code.wireshark.org/review/10270
1080 Petri-Dish: Gerald Combs <gerald@wireshark.org>
1081 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1082 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1085 Author: Gerald Combs <gerald@wireshark.org>
1086 Date: Mon Aug 24 12:30:56 2015 -0700
1088 Rework tapping in Qt dialogs.
1090 Add cf_cb_file_retap_started and cf_cb_file_retap_finished to file.[ch].
1091 Add their associated signals to CaptureFile.
1093 Add registerTapListener and removeTapListeners to WiresharkDialog, which
1094 collect and automatically remove tap listeners. Add beginRetapPackets
1095 and endRetapPackets, which can be used to wrap critical sections so that
1096 we don't delete ourselves while tapping. Don't cancel tapping on close
1099 Use beginRetapPackets and endRetapPackets in WiresharkDialog and
1100 FollowStreamDialog. We will likely need to add them elsewhere.
1104 Change-Id: I1788a6ade0817c31aa3419216df96be5e36b2178
1105 Reviewed-on: https://code.wireshark.org/review/10261
1106 Petri-Dish: Gerald Combs <gerald@wireshark.org>
1107 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1108 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1111 Author: Gerald Combs <gerald@wireshark.org>
1112 Date: Mon Aug 24 12:33:49 2015 -0700
1114 Add per-dialog progress frames.
1116 Add ProgressFame::addToButtonBox, which violates the UX guidelines on
1117 every platform we support by inserting a ProgressFrame into a
1120 Call addToButtonBox in the constructors of a bunch of dialogs.
1122 Change-Id: I33ac5fd7a976ee6e0527de569a5c4b528980dae1
1123 Reviewed-on: https://code.wireshark.org/review/10242
1124 Petri-Dish: Gerald Combs <gerald@wireshark.org>
1125 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1126 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1129 Author: tkc <chaitanya.mgit@gmail.com>
1130 Date: Tue Aug 25 16:58:43 2015 +0530
1132 ieee80211: Qos Control bit4 handling: Make the default case as EOSP, to handle TDLS Packets.
1134 When parsing TDLS direct link packets the ToDS: 0 and FromDS:0
1135 so the wireshark treats the 4th bit in QoS Control as "bit4", but it
1136 should be treated as EOSP.
1138 So changed the default case to EOSP and only when TODS is set
1141 Change-Id: Ie2a73320dc9921aed4547e32836e6cd7d89ef109
1142 Reviewed-on: https://code.wireshark.org/review/10250
1143 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1146 Author: Joerg Mayer <jmayer@loplof.de>
1147 Date: Wed Aug 26 08:50:09 2015 +0400
1149 cmake: rework version.h handling to treat it like config.h
1151 It wasn't working on my system: I kept seeing the old git revision
1152 in '...shark -v' even after deleting version.h
1154 Change-Id: I75f41a7afcee4b9384f33a56014e4af6b527fec5
1155 Reviewed-on: https://code.wireshark.org/review/10265
1156 Petri-Dish: Jörg Mayer <jmayer@loplof.de>
1157 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1158 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1161 Author: Stig Bjørlykke <stig@bjorlykke.org>
1162 Date: Tue Aug 25 15:16:29 2015 +0200
1164 Qt SCTP: Changed prohibited APIs
1167 sprintf ->g_snprintf
1169 Also initialize some temp variables.
1171 Change-Id: I4d2fa1b0325c6e59aa13ebeb0d9c25d5ff7c4d9c
1172 Reviewed-on: https://code.wireshark.org/review/10252
1173 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
1174 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1175 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1178 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1179 Date: Tue Aug 25 19:36:28 2015 +0200
1181 Camel: fix indent (use 2 spaces)
1183 Change-Id: I0e8047fca7f24e60e4db8ad77254bcff5f8d6651
1184 Reviewed-on: https://code.wireshark.org/review/10257
1185 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1188 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1189 Date: Sat Aug 22 18:31:41 2015 +0100
1191 Do not treat all unknown IP protocols as unknown IPv6 extension headers
1193 Change-Id: I229260ce668b60a9756cd3f2e343c278ae27c211
1195 Reviewed-on: https://code.wireshark.org/review/10196
1196 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1197 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1198 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1201 Author: Guy Harris <guy@alum.mit.edu>
1202 Date: Tue Aug 25 16:56:37 2015 -0700
1204 Explain why the MSDU length field in an A-MSDU is big-endian.
1206 Change-Id: I4a1cfd09395860348d71e9f4c86b6343cfdcd02a
1207 Reviewed-on: https://code.wireshark.org/review/10262
1208 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1211 Author: Guy Harris <guy@alum.mit.edu>
1212 Date: Tue Aug 25 15:40:00 2015 -0700
1214 Get subset TVBs correctly.
1216 If you know the actual data length, use tvb_new_subset_length(); it will
1217 use that as the *reported* length, which is how it *should* be used, and
1218 will calculate the *captured* length for you as appropriate.
1220 Change-Id: I86dde999f59fdfec58b118729b7b881737983033
1221 Reviewed-on: https://code.wireshark.org/review/10260
1222 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1225 Author: Pascal Quantin <pascal.quantin@gmail.com>
1226 Date: Tue Aug 25 19:55:56 2015 +0200
1228 SIGCOMP: fix sigcomp.copying_bytes_literally field
1230 Change-Id: Ib1baa3437579a413899aaba5dd8d31982cda1b0d
1231 Reviewed-on: https://code.wireshark.org/review/10258
1232 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1235 Author: Joerg Mayer <jmayer@loplof.de>
1236 Date: Mon Aug 24 04:34:06 2015 +0400
1240 Change-Id: Id3144ecaf9289dbe53cd2f5d3e3de57e8de955f6
1241 Reviewed-on: https://code.wireshark.org/review/10256
1242 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1245 Author: Michael Mann <mmann78@netscape.net>
1246 Date: Mon Aug 24 22:30:46 2015 -0400
1248 Eliminate proto_tree_add_text from packet-sigcomp.c
1250 Some other cleanup noted by the check* scripts.
1252 Change-Id: I14d7bfa81c689fff00fc82e966d50d4ae9f0988d
1253 Reviewed-on: https://code.wireshark.org/review/10254
1254 Reviewed-by: Michael Mann <mmann78@netscape.net>
1255 Petri-Dish: Michael Mann <mmann78@netscape.net>
1256 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1257 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1260 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1261 Date: Sun Aug 23 03:46:36 2015 +0100
1263 Replace "IPv6 header length" with the more correct "payload length"
1265 Change-Id: I3e667ba2e3ac49ce99e7a2035d9ff604fd7cbcca
1266 Reviewed-on: https://code.wireshark.org/review/10205
1267 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1268 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1269 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1270 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1273 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1274 Date: Mon Aug 24 10:29:18 2015 +0200
1276 Multicast Stream: Fix Dereference of null pointer found by Clang analyzer
1278 Change-Id: I419f49132f8b0853c17b2fd1b4e9869ef3fafd13
1279 Reviewed-on: https://code.wireshark.org/review/10224
1280 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1283 Author: AndersBroman <anders.broman@ericsson.com>
1284 Date: Tue Aug 25 12:45:01 2015 +0200
1286 [Camel] The tags used in EstablishTemporaryConnectionArg differs in V2 and
1287 V3 versions of Camel.
1288 Add ASN1 code for EstablishTemporaryConnectionArgV2
1292 Change-Id: I0dbb9c83e520c269dd567f3c3bc34c99c9aa5e15
1293 Reviewed-on: https://code.wireshark.org/review/10249
1294 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1297 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1298 Date: Sun Aug 23 21:34:21 2015 +0100
1300 Add more validity checks to the IPv6 dissector
1302 Check for IP version and header size
1304 Change-Id: I69102dda4e0e91ac1617d9a48fe9b0bab26aa9fe
1305 Reviewed-on: https://code.wireshark.org/review/10218
1306 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1307 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
1308 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1309 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1312 Author: Pascal Quantin <pascal.quantin@gmail.com>
1313 Date: Sat Aug 22 20:08:31 2015 +0200
1315 win32: add detection of Npcap to Windows installer
1317 If Npcap is installed without WinPcap API-compatible mode, propose to install WinPcap
1318 If Npcap is installed with WinPcap API-compatible mode, do not allow to install Winpcap without manually uninstalling Npcap first
1320 Change-Id: I606f8b11c950fd54cf7fdda7f4a1886cc2580d31
1321 Reviewed-on: https://code.wireshark.org/review/10197
1322 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1323 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1324 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1325 Reviewed-by: Yang Luo <hsluoyz@sohu.com>
1326 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1329 Author: Pascal Quantin <pascal.quantin@gmail.com>
1330 Date: Mon Aug 24 11:21:29 2015 +0200
1332 win32: update the list of NdisMedium and NdisPhysicalMedium defines used by GTK UI
1334 Use hardcoded values instead of enum values so as to avoid any dependency on newest Microsoft SDK.
1335 Add WinPcap specific NdisMediumXXX values.
1336 Also rename "Medium in use" to "Media in use" to better match the OID query name.
1338 Change-Id: I7ccc2763364b65df77927cbf1c265195fc295642
1339 Reviewed-on: https://code.wireshark.org/review/10225
1340 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1341 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1342 Reviewed-by: Yang Luo <hsluoyz@sohu.com>
1343 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1344 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1347 Author: Richard Sharpe <rsharpe@samba.org>
1348 Date: Mon Aug 24 07:39:44 2015 -0700
1350 Remove the search back up the proto tree for the capture frequency that was
1351 being used to determine if we are dissecting 802.11ad in several places.
1353 Since we now have a macro for testing that and the frequency is in the phdr
1354 we really should use that. This also prevents problems during display filter
1355 execution with respect to fields that are only present for 802.11ad.
1357 Change-Id: Id04a31c15b04378b6b0f056baa1f37d94a65b71c
1358 Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
1359 Reviewed-on: https://code.wireshark.org/review/10234
1360 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1363 Author: Guy Harris <guy@alum.mit.edu>
1364 Date: Mon Aug 24 18:46:56 2015 -0700
1366 Point to GitHub for the pcapng specification.
1368 Change-Id: I33faa41e8b0f36ee49d29fe391feafd94d0a7e80
1369 Reviewed-on: https://code.wireshark.org/review/10245
1370 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1373 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
1374 Date: Mon Aug 24 20:26:30 2015 -0400
1376 Use one variable that was set but not previously used and delete another.
1378 Change-Id: I6bd7a16e3ea97659a0007edfd9f90dbd2060e443
1379 Reviewed-on: https://code.wireshark.org/review/10244
1380 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
1383 Author: Guy Harris <guy@alum.mit.edu>
1384 Date: Mon Aug 24 15:13:59 2015 -0700
1386 Some beamforming stuff from 802.11ac.
1388 Extracted from Joerg Mayer's Ixia-derived patch to 1.12 in bug 11464.
1389 Most of the changes there are already in the trunk.
1391 Change-Id: I90ba04e145ffb2b164810320e3510a5bed847ed4
1393 Reviewed-on: https://code.wireshark.org/review/10243
1394 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1397 Author: Stig Bjørlykke <stig@bjorlykke.org>
1398 Date: Mon Aug 24 22:59:21 2015 +0200
1400 Remove unused signal
1402 Change-Id: Ic2d4057ee95849bc1b026663dae1430432ad9707
1403 Reviewed-on: https://code.wireshark.org/review/10241
1404 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1407 Author: Stig Bjørlykke <stig@bjorlykke.org>
1408 Date: Mon Aug 24 22:19:01 2015 +0200
1410 Use signal to close packet dialogs
1412 Change-Id: I312f8de8de933e576b60d2b158e4c4f2d1147ef1
1413 Reviewed-on: https://code.wireshark.org/review/10238
1414 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1417 Author: Gerald Combs <gerald@wireshark.org>
1418 Date: Mon Aug 24 10:56:04 2015 -0700
1420 Add notes about using CMake + Qt Creator.
1422 Change-Id: Ib10cc0a407721d62b39628af858f14e749c94d22
1423 Reviewed-on: https://code.wireshark.org/review/10237
1424 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1427 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1428 Date: Mon Aug 24 10:21:55 2015 +0200
1430 Multicast Statistics (Qt Dialog): Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
1432 Change-Id: Ie2802293576bf9edb28bccf7d464b5e687185096
1433 Reviewed-on: https://code.wireshark.org/review/10223
1434 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1437 Author: Gerald Combs <gerald@wireshark.org>
1438 Date: Mon Aug 24 09:01:09 2015 -0700
1440 Add FOP 2.0 to the search list.
1442 Change-Id: Ifc462a69e28b875f05770c453b06689c69008c52
1443 Reviewed-on: https://code.wireshark.org/review/10235
1444 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1447 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1448 Date: Mon Aug 24 12:16:06 2015 +0100
1450 IPv6 RPL: "cmprI" should be "cumprE"
1453 Change-Id: I7cf9fb8ad39d128ed375abb8703937be8e3795b3
1454 Reviewed-on: https://code.wireshark.org/review/10228
1455 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1458 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1459 Date: Sat Aug 22 19:20:25 2015 +0100
1461 Remove space from field description for consistency
1463 Change-Id: I74b0be1724d0754b7d1b724e177d44c4894d0e6b
1464 Reviewed-on: https://code.wireshark.org/review/10198
1465 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1468 Author: Martin Kaiser <wireshark@kaiser.cx>
1469 Date: Sun Aug 23 18:44:31 2015 +0200
1471 fc: don't THROW() an exception from a dissector
1473 bring up an expert info and exit
1475 Change-Id: Icbbafb8b7187a66d3ddc9a674502ad728b7c4ffc
1476 Reviewed-on: https://code.wireshark.org/review/10222
1477 Petri-Dish: Anders Broman <a.broman58@gmail.com>
1478 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1479 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1482 Author: Martin Kaiser <wireshark@kaiser.cx>
1483 Date: Thu Aug 20 23:06:44 2015 +0200
1485 cigi: don't THROW() an exception from a dissector
1487 stop the dissection instead and bring up an expert info in the main function
1489 Change-Id: I391bf821422ef8e6ae01849c88096e90e4295920
1490 Reviewed-on: https://code.wireshark.org/review/10221
1491 Petri-Dish: Anders Broman <a.broman58@gmail.com>
1492 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1493 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1496 Author: AndersBroman <anders.broman@ericsson.com>
1497 Date: Mon Aug 24 12:41:04 2015 +0200
1499 [Q.2931] Don't use BASE_EXT_STRING for a value_string, fixes the test
1502 ** (process:10080): WARNING **: Invalid value_string_ext ptr for: q2931.atm_identifier
1504 Change-Id: Id4ec745629af7774e480e91fba01ed8da5aac1bd
1505 Reviewed-on: https://code.wireshark.org/review/10227
1506 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1509 Author: Stig Bjørlykke <stig@bjorlykke.org>
1510 Date: Mon Aug 24 11:52:29 2015 +0200
1512 Fixed typo in hfinfo_remove_from_gpa_name_map
1514 Change-Id: Ic80fbe9397e50c41fa01ef9147319dd2ac0c0b91
1515 Reviewed-on: https://code.wireshark.org/review/10226
1516 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1519 Author: Pascal Quantin <pascal.quantin@gmail.com>
1520 Date: Sun Aug 23 19:02:23 2015 +0200
1522 ip: fix ip.hdr_len filter value when the header length is too small
1524 Change-Id: Ia510d0f4e496ef0577856bf633d6ca19f0b3e1cb
1525 Reviewed-on: https://code.wireshark.org/review/10210
1526 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1527 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1528 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1531 Author: Michael Mann <mmann78@netscape.net>
1532 Date: Sat Aug 22 22:14:30 2015 -0400
1534 Eliminate proto_tree_add_text from packet-q931.c and packet-q2931.c
1536 Change-Id: I681b05755429fd7420c423ff88e5a4d3dc95db64
1537 Reviewed-on: https://code.wireshark.org/review/10219
1538 Reviewed-by: Michael Mann <mmann78@netscape.net>
1539 Petri-Dish: Michael Mann <mmann78@netscape.net>
1540 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1543 Author: Stig Bjørlykke <stig@bjorlykke.org>
1544 Date: Sat Aug 22 22:59:42 2015 +0200
1546 Close packet dialogs when reload Lua plugins.
1548 We could keep the dialogs with the current content if postponing
1549 proto_free_deregistered_fields() until all dialogs are closed.
1550 This would give a feature where the user is able to compare packets
1551 before and after a reload.
1553 Or we could add functions in PacketDialog to reload the packet details
1554 in all open dialogs. This would give a feature to always have a
1555 updated dialog for all interesting packets.
1557 Change-Id: I805352b65844eafafafc54cd61f08b4605416e64
1558 Reviewed-on: https://code.wireshark.org/review/10201
1559 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
1560 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1561 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1564 Author: Stig Bjørlykke <stig@bjorlykke.org>
1565 Date: Thu Aug 20 21:39:12 2015 +0200
1567 Disable streamNumberSpinBox while reloading capture
1569 When changing stream in TCPStreamDialog it should not be possible
1570 to change stream again until the capture has reloaded, because
1571 this will give a crash when doing graph_segment_list_free() or
1572 graph_segment_list_get() while already doing this.
1574 Also disable mouseMove event (showing packet details) while reloading,
1575 as this also will give a crash.
1577 We should consider also having a reload progress bar in the
1578 TCPStreamDialog to indicate that this is happening when having
1579 large capture files, as the main window may not be visible.
1581 Change-Id: I622f9e0de8205bc1fd18101dc03100079d7a2d06
1582 Reviewed-on: https://code.wireshark.org/review/10159
1583 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
1584 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1585 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1588 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1589 Date: Fri Aug 21 09:33:17 2015 +0100
1591 Check if IPv6 payload length exceeds framing byte length
1594 Change-Id: Icbb980fda4f7addf52db59bc4f2aa27fc8f85837
1595 Reviewed-on: https://code.wireshark.org/review/10176
1596 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1599 Author: Stig Bjørlykke <stig@bjorlykke.org>
1600 Date: Thu Aug 20 22:50:58 2015 +0200
1602 Disable apply button while adding the filter
1604 Pressing multiple apply while reloading the capture file will
1607 Change-Id: I3587b9ab6b6b7f1437f3a7becb8c35277bb5c62c
1608 Reviewed-on: https://code.wireshark.org/review/10161
1609 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1612 Author: Stig Bjørlykke <stig@bjorlykke.org>
1613 Date: Sun Aug 23 20:11:06 2015 +0200
1615 Lua: Support deregister ProtoField with existing abbrev
1617 Change-Id: Icb06792bb2662dcee6e5495359ceef420a5b4498
1618 Reviewed-on: https://code.wireshark.org/review/10212
1619 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1622 Author: Michael Mann <mmann78@netscape.net>
1623 Date: Thu Aug 20 06:16:22 2015 -0400
1625 Eliminate proto_tree_add_text from some dissectors
1627 Change-Id: Id710ab10093227b27ef5f18b0d2960e31d0b95a9
1628 Reviewed-on: https://code.wireshark.org/review/10200
1629 Reviewed-by: Michael Mann <mmann78@netscape.net>
1630 Petri-Dish: Michael Mann <mmann78@netscape.net>
1631 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1632 Reviewed-by: Anders Broman <a.broman58@gmail.com>
1635 Author: Richard Sharpe <rsharpe@samba.org>
1636 Date: Sat Aug 22 09:51:25 2015 -0700
1638 Add some symbols to wtap.h so that we can correctly support 802.11ad.
1639 Currently there are a lot of local hacks in the 802.11ad support and
1640 better support can be provided.
1642 Also add a structure to track 802.11ad (DMG) specific features in the phdr
1643 structure as suggested by Guy Harris.
1645 Also, respond to some suggestions by Guy Harris.
1647 Change-Id: I8459e3986a134a08ee2e31f0158b8aa5c9b91d86
1648 Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
1649 Reviewed-on: https://code.wireshark.org/review/10204
1650 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1653 Author: Guy Harris <guy@alum.mit.edu>
1654 Date: Sun Aug 23 16:13:20 2015 -0700
1656 Don't assume we have interface information.
1658 Not all capture file formats provide interface information. Check
1659 whether we have it, and don't fail if we don't have any.
1661 (Note that the current version of the pcapng specification in the Git
1662 repository does not require that there be at least one IDB in a file,
1663 only that there must be an IDB for each interface to which other blocks
1666 Change-Id: Ia796f639ed3a8cb21e1dbe9b2bc6b4b66c7be479
1667 Reviewed-on: https://code.wireshark.org/review/10220
1668 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1671 Author: Pascal Quantin <pascal.quantin@gmail.com>
1672 Date: Sun Aug 23 21:02:24 2015 +0200
1674 CBOR: get rid of INFINITY and NAN defines
1676 This triggers an "overflow in constant arithmetic" warning with MSVC2013
1678 Change-Id: Ie3b076019c4722857c8e57f8568a0cb124fd13ad
1679 Reviewed-on: https://code.wireshark.org/review/10217
1680 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
1681 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1682 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1685 Author: Guy Harris <guy@alum.mit.edu>
1686 Date: Sun Aug 23 11:38:13 2015 -0700
1688 See if this makes MSVC happy.
1690 It's complaining about an "overflow in constant arithmetic". Neither
1691 INFINITY nor NAN are specified by C90; C99 specifies that they are both
1692 floats. Until recently, Microsoft had no interest in C99; if the
1693 version we're using supports C99's INFINITY and NAN, it should be OK to
1694 assign them to a variable (no "arithmetic" involved), so I'm guessing
1695 that the "arithmetic" in question is the use of conditional operators ?
1696 and :, so I'm writing it as an if statement instead.
1698 Change-Id: I532b9b5943be32e0897e4f03ac4e625ac41ee63b
1699 Reviewed-on: https://code.wireshark.org/review/10215
1700 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1703 Author: Stig Bjørlykke <stig@bjorlykke.org>
1704 Date: Sun Aug 23 20:36:33 2015 +0200
1706 Lua: remove unneeded todo comments
1708 Change-Id: I2591a0f21092a251e6fc4393e97ae0594318dfdf
1709 Reviewed-on: https://code.wireshark.org/review/10214
1710 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1713 Author: Guy Harris <guy@alum.mit.edu>
1714 Date: Sun Aug 23 11:20:39 2015 -0700
1716 Use G_GINT64_MODIFIER, not l, in format strings for 64-bit integers.
1718 64-bit integers are *not* guaranteed to be longs and, in fact, are *not*
1719 longs on ILP32 platforms such as 32-bit UN*Xes and 32-bit Windows and on
1720 LLP64 platforms such as 64-bit Windows.
1722 Change-Id: I6408778f638bb6cea52ffb64be39ea26c9b2ee64
1723 Reviewed-on: https://code.wireshark.org/review/10213
1724 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1727 Author: Guy Harris <guy@alum.mit.edu>
1728 Date: Sun Aug 23 11:12:43 2015 -0700
1730 Rename variable to avoid collisions with math.h's exp().
1732 Spell out "mantissa" while we're at it.
1734 Change-Id: I47ddb9882f45ef58a6f7101818683e68bc54983b
1735 Reviewed-on: https://code.wireshark.org/review/10211
1736 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1739 Author: Hauke Mehrtens <hauke@hauke-m.de>
1740 Date: Mon Jul 20 23:36:03 2015 +0200
1742 CBOR: add Concise Binary Object Representation (RFC 7049) dissector
1744 This adds a dissector Concise Binary Object Representation (CBOR) (RFC 7049).
1745 CBOR is a binary data format designed for implementations with small
1746 code size as used in the IoT. It uses a structure similar to JSON, but
1747 encodes the data in binary format. This is used on top of CoAP for
1750 Change-Id: I9d7b7d4f7609c899bfc68250cdfebd5dc64e0402
1751 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
1752 Reviewed-on: https://code.wireshark.org/review/9848
1753 Reviewed-by: Michael Mann <mmann78@netscape.net>
1754 Petri-Dish: Michael Mann <mmann78@netscape.net>
1755 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1756 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1759 Author: Peter Wu <peter@lekensteyn.nl>
1760 Date: Fri Jul 17 16:31:32 2015 +0200
1762 dtls: do not try to add a zero-length fragment
1764 fragment_add does not like adding zero-length fragments, it causes a
1765 zero-length memcpy to NULL.
1767 According to RFC 6347, fragment_offset=0 and fragment_length=length is
1768 an unfragmented message, so fragment>0 and fragment_length=length=0 is a
1771 An empty fragment does not extend a previous message, so ignore it.
1772 Such fragments are produced by at least GnuTLS 3.3.7[1], so raise a
1773 warning instead of an error.
1777 epan/tvbuff.c:783:10: runtime error: null pointer passed as argument 1, which is declared to never be null
1779 #0 0x7f5319f6ed64 in tvb_memcpy epan/tvbuff.c:783
1781 #13 0x7f5319f27e2b in fragment_add epan/reassemble.c:1394
1782 #14 0x7f531a5c70a4 in dissect_dtls_handshake epan/dissectors/packet-dtls.c:1257
1784 [1]: http://comments.gmane.org/gmane.network.gnutls.general/3582
1786 Change-Id: I70bf16d2fb64793d0deaabe612147e238b743b2e
1788 Reviewed-on: https://code.wireshark.org/review/9689
1789 Petri-Dish: Peter Wu <peter@lekensteyn.nl>
1790 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1791 Reviewed-by: Peter Wu <peter@lekensteyn.nl>
1794 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1795 Date: Sat Aug 22 19:56:34 2015 +0100
1797 Fix ip_try_dissect() boolean return
1799 If dissector_try_heuristic() succeeds return TRUE and vice-versa.
1801 Change-Id: I3fb2595604f2f3981468473d0a966efe7387745e
1802 Reviewed-on: https://code.wireshark.org/review/10199
1803 Reviewed-by: Michael Mann <mmann78@netscape.net>
1804 Petri-Dish: Michael Mann <mmann78@netscape.net>
1805 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1806 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1809 Author: Robert Grange <robionekenobi@bluewin.ch>
1810 Date: Thu Aug 13 15:35:01 2015 +0200
1812 packet-mq: Add new Const/Def for WMQ800 FP3
1814 Add new Const/Def for WMQ800 FP3
1815 Improve Detection of EBCDIC String in MQCONN_REPLY
1816 Add Value in comments
1818 Change-Id: I695a3afa64fee7f22918f68540901c97dfd38464
1819 Reviewed-on: https://code.wireshark.org/review/10012
1820 Reviewed-by: Robert Grange <robionekenobi@bluewin.ch>
1821 Reviewed-by: Michael Mann <mmann78@netscape.net>
1822 Petri-Dish: Michael Mann <mmann78@netscape.net>
1823 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1824 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
1827 Author: Gerald Combs <gerald@wireshark.org>
1828 Date: Sun Aug 23 08:06:46 2015 -0700
1830 [Automatic update for 2015-08-23]
1832 Update manuf, services enterprise-numbers, translations, and other items.
1834 Change-Id: I3726aa80e1e4d23301500fca326ae2b952bf38f6
1835 Reviewed-on: https://code.wireshark.org/review/10208
1836 Reviewed-by: Gerald Combs <gerald@wireshark.org>
1839 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
1840 Date: Sat Aug 22 11:27:00 2015 +0200
1842 OSPF: Fix indent (use 4 spaces)
1844 Change-Id: I4bd3c4a983b12e8fa053c2362f80dd723b9de572
1845 Reviewed-on: https://code.wireshark.org/review/10191
1846 Reviewed-by: Michael Mann <mmann78@netscape.net>
1849 Author: Joerg Mayer <jmayer@loplof.de>
1850 Date: Sun Aug 23 17:02:47 2015 +0400
1852 Remove some svn $Author$ lines that escaped previous cleanups.
1853 git does keep of this in a much better way anyway.
1855 Change-Id: I9923516105e63e72878e0ed34c74eed44453ab01
1856 Reviewed-on: https://code.wireshark.org/review/10207
1857 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1860 Author: Guy Harris <guy@alum.mit.edu>
1861 Date: Sat Aug 22 15:33:15 2015 -0700
1863 Call the MCS field by its correct name.
1865 Yes, it *should* have been called "HT", but hindsight is always 20-20.
1867 If you want less confusingly named information, look at what the "802.11
1868 radio information" dissector puts into the protocol tree; the radiotap
1869 dissection is for people debugging radiotap implementations or looking
1870 for vendor-specific information that's not (yet) put into the generic
1871 802.11 radio information.
1873 Change-Id: If6e97f82595a6f11a45e34d5a52e70e9ca686d7c
1874 Reviewed-on: https://code.wireshark.org/review/10202
1875 Reviewed-by: Guy Harris <guy@alum.mit.edu>
1878 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1879 Date: Tue Aug 18 07:01:35 2015 +0100
1881 [CLI, GTK] comparestat: Fix typos, output format, argument parsing
1883 Optional filter argument wasn't correctly parsed.
1885 Change-Id: Ic0418fa866e1a00880b4e41bb28267a155a71aa5
1886 Reviewed-on: https://code.wireshark.org/review/10088
1887 Petri-Dish: Michael Mann <mmann78@netscape.net>
1888 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1889 Reviewed-by: Michael Mann <mmann78@netscape.net>
1892 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1893 Date: Tue Aug 18 08:11:34 2015 +0100
1895 [GTK] Fix crash in comparestat.c
1897 Selecting a row in the statistics table causes a Glib assertion failure.
1899 GLib:ERROR:ghash.c:373:g_hash_table_lookup_node: assertion failed: (hash_table->ref_count > 0)
1901 When the comparestat_draw() function is called, the cs->ip_id_set hash table
1902 is created and then immediately destroyed, but the hash table lookup
1903 to cs->ip_id_set in new_tree_view_selection_changed() can happen anytime
1904 the user clicks on a table row.
1907 Change-Id: I6c7a39c947ca11327c3fc3ab0d4caa735798d142
1908 Reviewed-on: https://code.wireshark.org/review/10096
1909 Petri-Dish: Michael Mann <mmann78@netscape.net>
1910 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1911 Reviewed-by: Michael Mann <mmann78@netscape.net>
1914 Author: Michael Mann <mmann78@netscape.net>
1915 Date: Fri Aug 14 21:13:51 2015 -0400
1917 Correct logic for finding shadow variables.
1919 Change-Id: Ide03c3b92f70d5dad8d0dceca179ea6f3b9e1fd6
1920 Reviewed-on: https://code.wireshark.org/review/10037
1921 Reviewed-by: Michael Mann <mmann78@netscape.net>
1924 Author: Joerg Mayer <jmayer@loplof.de>
1925 Date: Sat Aug 22 16:11:35 2015 +0400
1928 1) Introduced by me in commit c4fe7129d802752aa4cc89a66d2d5d5f2698e020
1929 where I didn't honor the "print lsa header only" flag properly for
1931 2) Introduced in 2001 with commit dd1b7eafafb5748757a0396f4cc6ad6e65f37483
1932 which moved offset increasing into an "if (tree)" statement with code
1933 after the if statement continuing to work with offset.
1934 Also make display of v2 and v3 LSAs the same again (forgot one case in
1938 Change-Id: I1986c19842f1fa9c8a6d0a7c9a79c64939eeb9d0
1939 Reviewed-on: https://code.wireshark.org/review/10192
1940 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1943 Author: Stig Bjørlykke <stig@bjorlykke.org>
1944 Date: Fri Aug 21 12:43:55 2015 +0200
1946 Initialize extcap for pipes
1948 Change-Id: Ia731f281ee9af171c759d7f6f7c614c350cbb4e7
1949 Reviewed-on: https://code.wireshark.org/review/10178
1950 Reviewed-by: Michael Mann <mmann78@netscape.net>
1951 Petri-Dish: Michael Mann <mmann78@netscape.net>
1952 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1953 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
1956 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
1957 Date: Sun Aug 16 18:41:53 2015 +0100
1959 Add support for IPv6 stats tree statistics
1961 Also add support for alphabetizing stat tree items as the addition of IPv6 stats tree makes it more obvious its needed.
1963 Change-Id: I8b319ceac805ce7e3a1fd59f92c1c6fe2a54d3de
1964 Reviewed-on: https://code.wireshark.org/review/10062
1965 Reviewed-by: Michael Mann <mmann78@netscape.net>
1966 Petri-Dish: Michael Mann <mmann78@netscape.net>
1967 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
1968 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
1971 Author: Joerg Mayer <jmayer@loplof.de>
1972 Date: Sat Aug 22 08:33:27 2015 +0400
1974 Print two reserved elements as reserved instead of skipping them
1976 Change-Id: Ic91e07df4881dfff0f0dd1c4809903cbdee8ef60
1977 Reviewed-on: https://code.wireshark.org/review/10190
1978 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1981 Author: Joerg Mayer <jmayer@loplof.de>
1982 Date: Sat Aug 22 08:11:45 2015 +0400
1984 Small cleanups and improvements
1985 Show the LSA type and length in the summary line
1986 Improve a message to make it clear when we are talking about a LLS TLV
1987 Add an expert item for LLS bit set but data block missing
1988 PI_MALFORMED is an error not a warning.
1990 Change-Id: I516c2a2f0c27fcf101671527d4e4f018e17d3025
1991 Reviewed-on: https://code.wireshark.org/review/10189
1992 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
1995 Author: Gerald Combs <gerald@wireshark.org>
1996 Date: Fri Aug 21 17:12:39 2015 -0700
1998 Add the display filter macros dialog.
2000 Add some missing functionality to UatDialog.
2002 Remove what appears to be unused dfilter macro code.
2004 Change-Id: I8a8d6358523f24d5ddfe953d7741fe9af25d98eb
2005 Reviewed-on: https://code.wireshark.org/review/10187
2006 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2007 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2008 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2011 Author: Joerg Mayer <jmayer@loplof.de>
2012 Date: Sat Aug 22 05:43:46 2015 +0400
2014 OSPF database packets and OSPF hellos in DC mode are unicast. At
2015 least Cisco sends out these packets with a TTL of 1.
2017 Change-Id: I9ef0cd486d200a768329cfb758b87e20e3456663
2018 Reviewed-on: https://code.wireshark.org/review/10188
2019 Reviewed-by: Jörg Mayer <jmayer@loplof.de>
2022 Author: Gerald Combs <gerald@wireshark.org>
2023 Date: Fri Aug 21 15:02:20 2015 -0700
2025 Statistics dialog fixups.
2027 Fix the "retap on show" behavior in TapParameterDialog. It was filling
2028 in the tree when it shouldn't have.
2030 Set the capture stop flag when WiresharkDialog closes.
2032 Change-Id: I5e85f11cab32e8b958deabb58186a855b5fcaa84
2033 Reviewed-on: https://code.wireshark.org/review/10186
2034 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2035 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2036 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2039 Author: Gerald Combs <gerald@wireshark.org>
2040 Date: Fri Aug 21 08:46:43 2015 -0700
2042 Add packet comments to the properties dialog.
2044 This pulls in missing functionality from the comment summary dialog.
2046 Change-Id: Ib417896a6e8f2b2f903520b26193c249677bbb83
2047 Reviewed-on: https://code.wireshark.org/review/10185
2048 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2049 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2050 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2053 Author: Bill Parker <wp02855@gmail.com>
2054 Date: Fri Aug 21 15:24:41 2015 +0200
2056 [echld common] Call to fcntl() missing a test for a return value < 0,
2061 Change-Id: I87aef31d874224f38226df1725cc29d13ad16b54
2062 Reviewed-on: https://code.wireshark.org/review/10182
2063 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2064 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2065 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2068 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2069 Date: Fri Aug 21 11:59:34 2015 -0400
2071 Lua: check sscanf return value
2073 Wslua's Int64.fromhex() and UInt64.fromhex() need to check the sscanf return
2074 value. Found by coverity (CID 1191368 &1191369).
2076 Change-Id: I67fba027e18341d429787515f94c794573dc41c2
2077 Reviewed-on: https://code.wireshark.org/review/10183
2078 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2081 Author: Gerald Combs <gerald@wireshark.org>
2082 Date: Fri Aug 21 09:45:48 2015 -0700
2084 Multicast and wireless lan statistics fixups.
2086 Make sure "-z multicast,stat[,filter]" and "-z wlan,stat[,filter]" work.
2088 Add some missing "-z" items to the man page.
2090 Try to fix some MSVC++ warnings.
2092 Change-Id: Ie18e5355d595e351f000f14d82781dcdf33141c3
2093 Reviewed-on: https://code.wireshark.org/review/10184
2094 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2095 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2096 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2099 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2100 Date: Fri Aug 21 08:45:49 2015 +0100
2102 Add "ip.version" field to bogus IP for filter matching
2104 Change-Id: Ibb05b8742e41c1b16c1335ad97af99324ab95223
2105 Reviewed-on: https://code.wireshark.org/review/10175
2106 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2107 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2108 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2109 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2112 Author: Bill Parker <wp02855@gmail.com>
2113 Date: Fri Aug 21 15:13:16 2015 +0200
2115 [Kerberos] Call to 'fseek()' without a check for a return value < 0,
2120 Change-Id: Iaa6b7ca07626b78c77e3c1507726ec579764a582
2121 Reviewed-on: https://code.wireshark.org/review/10181
2122 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2123 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2124 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2127 Author: Luke Mewburn <luke@mewburn.net>
2128 Date: Wed Aug 19 10:42:59 2015 +1000
2130 LWM: fix compilation without libgcrypt
2132 Add HAVE_LIBGCRYPT compilation guards.
2133 Move gcrypt-related variables into the scope they're used.
2135 Change-Id: I81a2c8a54514fb51de53640fa8eceeddb2bf24d9
2136 Reviewed-on: https://code.wireshark.org/review/10118
2137 Reviewed-by: Michael Mann <mmann78@netscape.net>
2138 Petri-Dish: Michael Mann <mmann78@netscape.net>
2139 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2140 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2143 Author: Dave Rigby <daver@couchbase.com>
2144 Date: Thu Aug 20 16:05:57 2015 +0100
2146 Couchbase: dissect sub-document commands
2148 Add support for dissecting Couchbase sub-document commands (those
2149 which operate on a subset of a whole document).
2152 https://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=couchbase_subdoc_multi.pcap
2154 Change-Id: I5394a6f86c036ebd339574bac4e52f7d0821e4bf
2155 Reviewed-on: https://code.wireshark.org/review/10151
2156 Reviewed-by: Michael Mann <mmann78@netscape.net>
2157 Petri-Dish: Michael Mann <mmann78@netscape.net>
2158 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2159 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2162 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2163 Date: Fri Aug 21 03:10:10 2015 +0100
2165 Make IPv6 extension header protocol names uniform and consistent with RFC 2460
2167 Example from RFC 2460 (page 7):
2170 Hop-by-Hop Options header
2171 Destination Options header (note 1)
2174 Authentication header (note 2)
2175 Encapsulating Security Payload header (note 2)
2176 Destination Options header (note 3)
2178 Change-Id: I03c1ebedf581f71047b303856052609574110c61
2179 Reviewed-on: https://code.wireshark.org/review/10173
2180 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2181 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2182 Reviewed-by: Michael Mann <mmann78@netscape.net>
2185 Author: AndersBroman <anders.broman@ericsson.com>
2186 Date: Fri Aug 21 13:54:53 2015 +0200
2188 [Expert] Enhance error output to identify the duplicated field.
2190 Change-Id: Ie38f51e2fa0f846dbcfd7a19f29eac1bd07cffbc
2191 Reviewed-on: https://code.wireshark.org/review/10179
2192 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2195 Author: Peter Lemenkov <lemenkov@gmail.com>
2196 Date: Thu Aug 13 18:13:45 2015 +0300
2198 Allow redefining all ports for RADIUS
2200 RADIUS configuration sometimes uses more ports - for example, one for
2201 authentication, another one for accounting. Sometimes it uses the entire
2202 port ranges. In case of FreeRADIUS 2.x.x server it might look like this:
2217 Unfortunately we allow only one port to be redefined, not more. So it
2218 forces a person who's analyzing a traffic from such a RADIUS server
2219 manually select "Decode as" every time for each port.
2221 It was requested at least once to lift this limitation:
2223 * https://ask.wireshark.org/questions/2189/decode-multiple-ports-as-radius
2227 With this commit it's possible to set a port ranges for RADIUS dissector
2228 to handle. An example (default) configuration looks like (see
2229 ~/.wireshark/preferences):
2231 radius.ports: 1645,1646,1700,1812,1813,3799
2233 Old "alternate_port" preference is marked as obsolete. It won't be shown
2234 to a user but it will still be used if exists (remained from a previous
2238 Old alternate_port value is copied to the ports range, thus making
2239 transition even more smooth.
2241 Change-Id: Ibdd6f4f9fa1e0ac186147cec380bbfc62d509b17
2242 Signed-off-by: Peter Lemenkov <lemenkov@gmail.com>
2243 Reviewed-on: https://code.wireshark.org/review/10015
2244 Petri-Dish: Anders Broman <a.broman58@gmail.com>
2245 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2246 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2247 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2250 Author: Timo Warns <timow+github@DiningPhilosopher.DE>
2251 Date: Fri Jul 31 22:30:16 2015 +0200
2253 SSL: refine KEX handling and fix _anon KEX dissecting
2255 Dissecting client and server KEX messages requires to precisely distinguish KEX
2256 algos. For example, Server KEX for DH_anon do not contain a signature, while
2257 DHE_DSS and DHE_RSA do. The patch introduces KEX distinction with full
2258 precision and fixes dissecting _anon KEX messages.
2260 Change-Id: I0bcd5e2bf899ba9cac79476d5b7a1ffb3accf0db
2261 Reviewed-on: https://code.wireshark.org/review/9836
2262 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2263 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2264 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2267 Author: AndersBroman <anders.broman@ericsson.com>
2268 Date: Fri Aug 21 10:43:27 2015 +0200
2270 Try to fix: wlan_statistics_dialog.cpp:466:1: error: unused parameter
\91filter
\92 [-Werror=unused-parameter]
2272 Change-Id: Ib9b2fe245b126f9413dbdcced94c61eacf4d1c5d
2273 Reviewed-on: https://code.wireshark.org/review/10177
2274 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2277 Author: Pascal Quantin <pascal.quantin@gmail.com>
2278 Date: Thu Aug 20 15:06:41 2015 +0200
2280 file-pcapng: always set pinfo->fd->num before calling next layer dissectors/file-pcapng
2282 Also fix an off by 1 error for EPB case
2284 Change-Id: I895d82a58ec02c577dcaa67a97d456b42460b947
2285 Reviewed-on: https://code.wireshark.org/review/10149
2286 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2289 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2290 Date: Thu Aug 20 19:39:26 2015 +0200
2292 GSM_map: Fix indent (use 2 spaces) and add modelines
2294 Change-Id: I1549eb55e1fa87c46e2493c37f3ed352970b794b
2295 Reviewed-on: https://code.wireshark.org/review/10168
2296 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2299 Author: Paul Emge <paul.emge@digidescorp.com>
2300 Date: Thu Aug 6 11:00:22 2015 -0500
2302 Fix bug with MVRP dissection where only one message was dissected.
2304 Fix whitespace and replace tvb_captured_length with tvb_reported_length
2306 Change-Id: I3952e7a1ac00b68e6f6eb1283977bc6299b0baaf
2307 Reviewed-on: https://code.wireshark.org/review/9900
2308 Reviewed-by: Michael Mann <mmann78@netscape.net>
2309 Petri-Dish: Michael Mann <mmann78@netscape.net>
2310 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2311 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2314 Author: Pascal Artho <pascalartho@gmail.com>
2315 Date: Tue Aug 18 08:44:37 2015 +0200
2317 Preparation Host Flows: Syntax Line Edit (allow longer filter text)
2319 The "Syntax Line Edit" is based on "QLineEdit". By default, the maximum
2320 permitted length of a QLineEdit text is 32767 (16 bits).
2322 As the "Host Flows" extension uses the Wireshark filter syntax to filter
2323 the data, the filter can be become large. To avoid errors, I increased
2324 the maximum permitted length value to the maximum of quint32.
2326 Change-Id: I756efa76e1fc84449caef8fea368e6e38e776235
2327 Reviewed-on: https://code.wireshark.org/review/10099
2328 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2329 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2330 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2333 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2334 Date: Thu Aug 20 23:03:01 2015 +0200
2336 gsm map summary (GTK): fix no previous prototype for ‘gsm_map_stat_gtk_sum_cb’ [-Wmissing-prototypes]
2338 Change-Id: Ic97434112bc71202354004626ba51e1a22c39abf
2339 Reviewed-on: https://code.wireshark.org/review/10165
2340 Reviewed-by: Michael Mann <mmann78@netscape.net>
2341 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2344 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2345 Date: Thu Aug 20 22:08:18 2015 +0200
2347 SPDY: fix no previous prototype for 'dissect_spdy_heur' [-Wmissing-prototypes]
2349 Change-Id: Ife5f44a333227b1df3d2377d12dbec65a4b4d5c3
2350 Reviewed-on: https://code.wireshark.org/review/10164
2351 Reviewed-by: Michael Mann <mmann78@netscape.net>
2352 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2355 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2356 Date: Thu Aug 20 19:34:47 2015 +0200
2358 GSM/ANSI/CAMEL...: fix no previous prototype for '*_stat_init' [-Wmissing-prototypes]
2360 Change-Id: I0aedefbb77899ebceac7fb08249faf47964d785b
2361 Reviewed-on: https://code.wireshark.org/review/10163
2362 Reviewed-by: Michael Mann <mmann78@netscape.net>
2363 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2366 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2367 Date: Thu Aug 20 14:38:35 2015 -0400
2369 Fix memory leaks of dumper SHB and IDB infos
2371 Change-Id: I6b81d3e853d503c6a81f9793957b48ab34c6808c
2372 Reviewed-on: https://code.wireshark.org/review/10156
2373 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
2374 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2375 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2378 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
2379 Date: Wed Aug 12 13:57:20 2015 -0400
2381 Generate Diameter's expert info's even when there's no tree so that they show
2382 up in the Expert Infos dialog.
2384 Push the if(tree) check down into the basic type dissectors since we can't
2385 generate/fill the label (which won't be used anyway) when we're not building
2386 the tree (since the proto_item will be faked/NULL).
2388 Change-Id: Ie4f1f6856cfad0dabc7c58cdee2c16c8fc032c6d
2389 Reviewed-on: https://code.wireshark.org/review/10001
2390 Petri-Dish: Jeff Morriss <jeff.morriss.ws@gmail.com>
2391 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2392 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2395 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
2396 Date: Thu Aug 20 11:00:17 2015 -0400
2398 Add some Gx AVPs from 3GPP 29.212.
2400 Change-Id: Iaf2cc67d4d235193b25045895441742bc6531370
2401 Reviewed-on: https://code.wireshark.org/review/10150
2402 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2405 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2406 Date: Tue Aug 18 13:34:30 2015 +0200
2408 lemonflex: fix warning: no previous prototype for 'df_scanner_*' [-Wmissing-prototypes]
2410 lemonflex-tail.inc:44:1: warning: no previous prototype for 'df_scanner_text' [-Wmissing-prototypes]
2411 lemonflex-tail.inc:50:1: warning: no previous prototype for 'df_scanner_file' [-Wmissing-prototypes]
2412 lemonflex-tail.inc:59:1: warning: no previous prototype for 'df_scanner_cleanup' [-Wmissing-prototypes]
2414 Change-Id: If0476b430592df225234c5c685c8009ab08b5ab6
2415 Reviewed-on: https://code.wireshark.org/review/10162
2416 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2419 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2420 Date: Thu Aug 20 23:16:04 2015 +0200
2422 proto_dlg: fix no previous prototype for ‘heur_*_all_cb’ [-Wmissing-prototypes]
2424 Change-Id: I330ec2cee965f8cc3128c4a7bf794e52581ac290
2425 Reviewed-on: https://code.wireshark.org/review/10166
2426 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2427 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2428 Reviewed-by: Michael Mann <mmann78@netscape.net>
2431 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2432 Date: Fri Aug 21 03:54:36 2015 +0100
2434 Rename 'ip_next_header_dissector_table' to 'ipv6_next_header_dissector_table' in IPv6 dissector
2436 Provides better readability, the dissector table is only used for IPv6
2439 Change-Id: I87d877a89c6465d4475f2f0a40636ccd1b6cdd92
2440 Reviewed-on: https://code.wireshark.org/review/10174
2441 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2444 Author: Guy Harris <guy@alum.mit.edu>
2445 Date: Thu Aug 20 17:06:04 2015 -0700
2447 There is no wlan_statistics_dialog.ui.
2449 Change-Id: Ibedb3904cbab88ebae3bc9ec1588263af933dfc1
2450 Reviewed-on: https://code.wireshark.org/review/10172
2451 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2454 Author: Gerald Combs <gerald@wireshark.org>
2455 Date: Tue Aug 18 11:46:12 2015 -0700
2457 Add the WLAN statistics dialog.
2459 Instead of splitting the stats into two lists as with the GTK+ UI, add
2460 everything to an expandable tree. This allows viewing nodes on more than
2463 Rename the top-level Bluetooth menu item to Wireless and put the WLAN
2466 The Qt UI matches SSIDs (WlanNetworkTreeWidgetItem::isMatch) a bit
2467 differently than the GTK+ UI. Try to make the logic as plain as possible
2468 since we'll likely have to update it in the future.
2470 The addition of a custom BSSID address types means that we can't assume
2471 that everything is AT_ETHER. Add routines for checking for broadcast
2472 BSSIDs and comparing only the data portions of addresses.
2474 Move PercentBarDelegate into its own module. Use it in
2475 WlanStatisticsDialog.
2477 Change-Id: Ie4214eb00671a890871380c4a07213ebfb7585c6
2478 Reviewed-on: https://code.wireshark.org/review/10171
2479 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2482 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2483 Date: Thu Aug 20 22:56:56 2015 +0200
2485 BOOTP: fix indent (use tab)
2487 Change-Id: I32ea4d1b9cd8aa351cbdb2bab0642e4ed0c191fb
2488 Reviewed-on: https://code.wireshark.org/review/10169
2489 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2492 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2493 Date: Thu Aug 20 22:02:50 2015 +0200
2497 Change-Id: I641a9525ec5a6315cc4a2d97506a885605b3504b
2498 Reviewed-on: https://code.wireshark.org/review/10170
2499 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2502 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2503 Date: Thu Aug 20 21:38:19 2015 +0200
2505 Camel: Fix indent (use 2 spaces) and add modelines
2507 Change-Id: I6fe835e78e58faabd5cfeeb84e39793b48d3df25
2508 Reviewed-on: https://code.wireshark.org/review/10167
2509 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2512 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2513 Date: Thu Aug 20 07:48:58 2015 +0200
2515 Translations: fix typo
2517 coversation => conversation
2519 Found by s3erios (Ukrainian translator)
2521 Change-Id: Iaecb4e139d049c212956fa8567ee480d2f2aa0d2
2522 Reviewed-on: https://code.wireshark.org/review/10152
2523 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2526 Author: Gerald Combs <gerald@wireshark.org>
2527 Date: Thu Aug 20 11:54:04 2015 -0700
2529 CMake: Fixup appending to WS_WIN_LIBS
2531 In the world of CMake calling "set" with multiple values creates a
2532 semicolon-separated list. For WS_WIN_LIBS we want a single string so we
2533 need to call "set" with a single, quoted value.
2535 Change-Id: I96c5085af58adfb97ce16195eb27cc8ddb612d6a
2536 Reviewed-on: https://code.wireshark.org/review/10158
2537 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2538 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
2539 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2540 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2543 Author: Gerald Combs <gerald@wireshark.org>
2544 Date: Thu Aug 20 11:39:02 2015 -0700
2546 Squelch recent display filter warnings.
2548 Try to keep the main display filter editor from emitting warnings when
2549 we populate the recent item list.
2551 Change-Id: Ib0c150093e03d4d2ca2ac6cd72c0e37d041fe98b
2553 Reviewed-on: https://code.wireshark.org/review/10157
2554 Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2555 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2558 Author: Gerald Combs <gerald@wireshark.org>
2559 Date: Thu Aug 20 08:56:04 2015 -0700
2561 Tap parameter and stats dialog fixups.
2563 If we run into an error when trying to register a tap listener, return
2564 instead of tapping packets. This should fix some (but likely not all)
2565 double frees found by Stig. For now close each statistics dialog if we
2566 find an error. Note that we might want to keep them open instead.
2568 Add checks and cleanups to some of the stats table free routines.
2570 Call fillTree once in TapParameterDialog's constructor instead of each
2571 time it's shown. Make fillTree a slot which lets us use a delay timer so
2572 that the dialog is visible when we retap packets.
2574 Change-Id: Id49f2f2a99bc8e5b1d32990024986b3c8b1abe24
2575 Reviewed-on: https://code.wireshark.org/review/10153
2576 Reviewed-by: Gerald Combs <gerald@wireshark.org>
2579 Author: Gerald Combs <gerald@wireshark.org>
2580 Date: Thu Aug 20 10:05:39 2015 -0700
2582 Make sure we can apply deprecated display filters.
2584 Deprecated filters are still valid. Update display filter checks to make
2585 sure we can apply them.
2588 Change-Id: Ib5e009c070b40912434e0ffd771203ed1e1ba093
2589 Reviewed-on: https://code.wireshark.org/review/10154
2590 Petri-Dish: Gerald Combs <gerald@wireshark.org>
2591 Tested-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
2592 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2595 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2596 Date: Mon Aug 17 01:38:00 2015 +0100
2598 Check for IP version errors in dissect_ip()
2600 Change-Id: I7db4ed54be820e5667e1e93880013cc7abf95256
2601 Reviewed-on: https://code.wireshark.org/review/10064
2602 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2605 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2606 Date: Thu Aug 20 08:48:46 2015 -0400
2608 Link setargv.obj for Windows in CMake so mergecap works
2612 Change-Id: I511dd3d7d70fa33e246085c8cb79925e92945ebc
2613 Reviewed-on: https://code.wireshark.org/review/10148
2614 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2617 Author: Stig Bjørlykke <stig@bjorlykke.org>
2618 Date: Thu Aug 20 13:00:24 2015 +0200
2620 pcapng: Fixed copying if_filter_bpf_bytes
2623 Change-Id: Ic99ff1bcd7dad65b3ade5a9f46ce0f64573cb059
2624 Reviewed-on: https://code.wireshark.org/review/10147
2625 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
2626 Reviewed-by: Evan Huus <eapache@gmail.com>
2627 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2628 Reviewed-by: Dario Lombardo <lomato@gmail.com>
2629 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2632 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2633 Date: Wed Aug 19 21:47:50 2015 +0100
2635 UDP jumbogram expert info fix
2637 Change-Id: Ifa6170622bc8331097bc3fe9c567c97ce826c340
2638 Reviewed-on: https://code.wireshark.org/review/10140
2639 Petri-Dish: Michael Mann <mmann78@netscape.net>
2640 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2641 Reviewed-by: Michael Mann <mmann78@netscape.net>
2644 Author: Pascal Quantin <pascal.quantin@gmail.com>
2645 Date: Wed Aug 19 21:57:25 2015 +0200
2647 file-pcapng: differentiate captured length and reported length when calling next dissector and catch bound errors
2649 Otherwise dissection will fail when analyzing a capture with a snap length set
2651 Change-Id: If6714364efffdd1fbf88c947743929a71f75c663
2652 Reviewed-on: https://code.wireshark.org/review/10135
2653 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
2654 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2655 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2656 Reviewed-by: Michael Mann <mmann78@netscape.net>
2659 Author: Pascal Quantin <pascal.quantin@gmail.com>
2660 Date: Wed Aug 19 21:54:47 2015 +0200
2662 file-pcap: differentiate captured length and reported length when calling next dissector and catch bound errors
2664 Otherwise dissection will fail when analyzing a capture with a snap length set
2666 Change-Id: I764f48c624d0cc411b04ee62f8ecccaf6abb6f0c
2667 Reviewed-on: https://code.wireshark.org/review/10134
2668 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2669 Reviewed-by: Michael Mann <mmann78@netscape.net>
2672 Author: Pascal Quantin <pascal.quantin@gmail.com>
2673 Date: Wed Aug 19 21:48:46 2015 +0200
2675 file-pcapng: fix dissection of options in blocks
2677 - fix the loop logic
2678 - flags in EPB include link-layer-dependent errors
2680 Change-Id: Iae0b4869b556abbf3c14f3b865d0f23cee182c84
2681 Reviewed-on: https://code.wireshark.org/review/10132
2682 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2685 Author: Stig Bjørlykke <stig@bjorlykke.org>
2686 Date: Thu Aug 20 10:29:03 2015 +0200
2688 Added a missing break
2690 Change-Id: Ia04a112d8df195e271dc11565750a6e28bd7f0c9
2691 Reviewed-on: https://code.wireshark.org/review/10146
2692 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2695 Author: Stig Bjørlykke <stig@bjorlykke.org>
2696 Date: Wed Aug 19 15:38:10 2015 +0200
2698 IO Graphs: Don't show unchecked graphs in legend
2700 Change-Id: I0a9c4d967ee03a0a8dfc93f87dbe38e4e3a0404c
2701 Reviewed-on: https://code.wireshark.org/review/10128
2702 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2705 Author: Stig Bjørlykke <stig@bjorlykke.org>
2706 Date: Thu Aug 20 10:09:13 2015 +0200
2708 Make empty filter valid in checkFilter
2710 Change-Id: Ia5293a228a7044a4cd01b3b2f62f1d7a8f7747e2
2711 Reviewed-on: https://code.wireshark.org/review/10145
2712 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2715 Author: Stig Bjørlykke <stig@bjorlykke.org>
2716 Date: Thu Aug 20 10:06:48 2015 +0200
2718 Clear display filter when filterPackets with empty filter
2720 Change-Id: Ie3f763d53f5c250bbc58e32490eb83bb2e076a62
2721 Reviewed-on: https://code.wireshark.org/review/10144
2722 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2725 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2726 Date: Wed Aug 19 23:29:13 2015 -0400
2728 Link setargv.obj for Windows in CMake so mergecap works
2730 Mergecap needs setargv.obj in order to get wildcard support. This is linked
2731 in nmake but not cmake.
2734 Change-Id: Icccf6b36495ac4b376f651d689b4a1f9e2c6042d
2735 Reviewed-on: https://code.wireshark.org/review/10143
2736 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2739 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2740 Date: Wed Aug 19 21:38:13 2015 -0400
2742 Get the windows buildbot working for mergecap test suite
2744 Change-Id: Ic9351b9bb8df85086eee3ab21908a2f9a04db767
2745 Reviewed-on: https://code.wireshark.org/review/10141
2746 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2749 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2750 Date: Wed Aug 19 18:30:29 2015 -0400
2752 Remove unused struct member from wtap
2754 The 'number_of_interfaces' member of struct wtap is not used - nor is it
2755 needed since the interface_data is a GArray with its own 'len' member.
2757 Change-Id: Id0fb25248dea4bea9fc88a8ea35c09ba55029d89
2758 Reviewed-on: https://code.wireshark.org/review/10138
2759 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
2760 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2761 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2764 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2765 Date: Wed Aug 19 18:42:59 2015 -0400
2767 Pcap: wtap does not set interface timestamp precision when reading pcap
2769 Like bug 11447, when wiretap reads a legacy PCAP file it needs to
2770 set the interface description's tsprecision member. And like bug
2771 11447, I'm wondering why we have the field to begin with. But I'm
2772 fixing this so that the Windows buildbots can get going again.
2774 Change-Id: I71d0fe2e999ee7d11f1f5cc424681a99e17b1b1b
2775 Reviewed-on: https://code.wireshark.org/review/10139
2776 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2779 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2780 Date: Wed Aug 19 17:59:27 2015 -0400
2782 Add more debug infor for windows buildbot test suite failure
2784 Down the rabbit hole we go...
2786 Change-Id: I8371b95b85128209b56960eb6e54648a6babbb84
2787 Reviewed-on: https://code.wireshark.org/review/10137
2788 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2791 Author: Pascal Quantin <pascal.quantin@gmail.com>
2792 Date: Wed Aug 19 18:34:20 2015 +0200
2794 PNRP: capitalize protocol name
2796 Change-Id: I1cf5d22e12241ef330319ef8fdf176becdefe300
2797 Reviewed-on: https://code.wireshark.org/review/10131
2798 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2801 Author: Pascal Quantin <pascal.quantin@gmail.com>
2802 Date: Wed Aug 19 21:52:30 2015 +0200
2804 file-pcapng: remove useless hf_pcapng_timestamp_data entry
2806 Change-Id: I82b2d4e4b0be8179103b827e0d11a0d8b10e1374
2807 Reviewed-on: https://code.wireshark.org/review/10133
2808 Reviewed-by: Guy Harris <guy@alum.mit.edu>
2811 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2812 Date: Wed Aug 19 16:25:54 2015 -0400
2814 Try to debug merge test suite failure on windows buildbot
2816 This change will be undone once the problem is found.
2818 Change-Id: Ica9cfe31b4e30fad2bb9de508af61baa1c455cc1
2819 Reviewed-on: https://code.wireshark.org/review/10136
2820 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2823 Author: Balint Reczey <balint@balintreczey.hu>
2824 Date: Sat Aug 15 21:12:17 2015 +0200
2826 Use system's GeoIP database by default on Debian
2828 Change-Id: I58c1cbb242c20737dd16a0477858b0225c0b5d14
2829 Reviewed-on: https://code.wireshark.org/review/10051
2830 Petri-Dish: Balint Reczey <balint@balintreczey.hu>
2831 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2832 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2835 Author: Balint Reczey <balint@balintreczey.hu>
2836 Date: Sat Aug 15 21:10:20 2015 +0200
2838 Use system's OpenLayers.js on Debian
2840 Change-Id: Id790ee61d3443e2f96a83260514fa3a6d31d09da
2841 Reviewed-on: https://code.wireshark.org/review/10050
2842 Reviewed-by: Balint Reczey <balint@balintreczey.hu>
2845 Author: Pascal Quantin <pascal.quantin@gmail.com>
2846 Date: Wed Aug 19 18:13:36 2015 +0200
2848 ixiatrailer: remove execute bit
2850 Change-Id: I6cd8f98518b21e935b329f5470b706ec059c91eb
2851 Reviewed-on: https://code.wireshark.org/review/10129
2852 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
2855 Author: Pascal Artho <pascalartho@gmail.com>
2856 Date: Tue Aug 18 08:44:04 2015 +0200
2858 Preparation Host Flows: Tap Sequence Analysis
2860 The tap_sequence_analysis was adapted to store the protocol of each
2861 frame. Therefore a new variable was introduced. In case of an ICMP or
2862 ICMPv6 packet, the ICMP message type and code is retrieved. The adapted
2863 ICMP and ICMPv6 dissector stores both values in packet info (see [1]).
2865 In case of ICMP and ICMPv6 packets, the source and destination port is
2866 not set or 0, respectively. Compared to that, the NetFlow service export
2867 protocol [2] codes the ICMP message type and code into the port numbers.
2868 The source port is zero while the destination is defined as: destination
2869 port = ICMP type * 256 + ICMP code. This definition was implemented for
2870 the ICMP and ICMPv6 packets.
2873 [1] https://code.wireshark.org/review/10097
2874 [2] http://www.ietf.org/rfc/rfc3954.txt
2876 Change-Id: I07518e360975682a3f45e80cb24f82f58cfb15f0
2877 Reviewed-on: https://code.wireshark.org/review/10098
2878 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2879 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2880 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2881 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2884 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2885 Date: Wed Aug 19 11:52:51 2015 +0200
2887 Bluetooth: ATT: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
2889 Found also by Coverity (CID 1316607)
2891 Change-Id: Ib6a4437fd24b51a8aa87d4bcdb5ee2a1dc43dae3
2892 Reviewed-on: https://code.wireshark.org/review/10124
2893 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2896 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2897 Date: Wed Aug 19 11:58:44 2015 +0200
2899 Bluetooth: ATT: Fix code will never be executed [-Wunreachable-code]
2901 Change-Id: I5048da723ddecde931956ed1af77438f823c1990
2902 Reviewed-on: https://code.wireshark.org/review/10125
2903 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
2904 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2905 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2908 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2909 Date: Wed Aug 19 12:33:06 2015 +0200
2911 btsnoop: Missing break in switch (CID 1316606)
2913 Change-Id: I105da06b7161a5b5f0cc2b4ce5303c4d5c989280
2914 Reviewed-on: https://code.wireshark.org/review/10126
2915 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
2918 Author: Stig Bjørlykke <stig@bjorlykke.org>
2919 Date: Wed Aug 19 09:00:54 2015 +0200
2921 Recompile dfilter for all tap listeners when fields changed
2923 When fields have changed the compiled display filter may be invalid
2924 or need a recompile to be valid.
2926 Filters which are not valid after a recompile is set to a filter
2927 matching no packets (frame.number == 0) to indicate that this does
2928 no longer match anything. We should probably have a better filter
2929 matching no packet for this purpose.
2931 Change-Id: Id27efa9f46e77e20df50d7366f26d5cada186f93
2932 Reviewed-on: https://code.wireshark.org/review/10123
2933 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
2934 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2935 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
2938 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2939 Date: Wed Aug 19 05:28:17 2015 +0100
2941 Use MAC address documentation range in filter examples
2943 https://www.iana.org/assignments/ethernet-numbers/ethernet-numbers.xhtml
2945 Change-Id: I997440b7622dae4ea25d94e4041971f89b63fd04
2946 Reviewed-on: https://code.wireshark.org/review/10121
2947 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2950 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
2951 Date: Wed Aug 19 07:11:23 2015 +0100
2953 IPv6: Minor variable name fix
2955 Change-Id: Iaef41fa2a212577f1fbdf7705eca65a928faa8c3
2956 Reviewed-on: https://code.wireshark.org/review/10122
2957 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
2960 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
2961 Date: Mon Aug 17 13:30:01 2015 +0200
2963 .mailmap: sort using sort -u
2965 Change-Id: I276331070c654e6c57bccb2c26cd0430ac656b26
2966 Reviewed-on: https://code.wireshark.org/review/10069
2967 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2970 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2971 Date: Mon Aug 17 19:22:42 2015 -0400
2973 Mergecap: add test suite for various merging scenarios
2975 Add a test suite for mergecap (and indirectly capinfos I guess).
2976 This is not exhaustive, but it's a start.
2978 Change-Id: I9442b4c32e31a74b1673961ad6ab50821441de3e
2979 Reviewed-on: https://code.wireshark.org/review/10082
2980 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
2981 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2984 Author: Hadriel Kaplan <hadrielk@yahoo.com>
2985 Date: Sun Aug 16 12:37:11 2015 -0400
2987 capinfos: add more info about file and interfaces
2989 Add more information about the capture file, and about the interface
2990 descriptions in it. Also remove long-unused g_options code.
2992 Change-Id: I93cbd70fc7b09ec1b8b2fd6c85bb885c7f749543
2993 Reviewed-on: https://code.wireshark.org/review/10073
2994 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
2995 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
2996 Reviewed-by: Anders Broman <a.broman58@gmail.com>
2999 Author: Andrew Chernyh <andrew.chernyh@gmail.com>
3000 Date: Mon Jul 6 10:29:48 2015 +0600
3002 Added TDMoP protocol dissector
3005 Change-Id: I04408db376718c7a5392f9521d7d75d0481ec30e
3006 Reviewed-on: https://code.wireshark.org/review/9514
3007 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3010 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3011 Date: Mon Aug 17 20:07:58 2015 +0100
3013 [IPv6] Make "ip.version" field pretty(er)
3015 Change-Id: I1e32f666118e36f48edcc1678d75db3ca3f62776
3016 Reviewed-on: https://code.wireshark.org/review/10075
3017 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3020 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3021 Date: Mon Aug 17 13:27:53 2015 +0200
3025 Change-Id: Ib61ed614c3cfb6885d81a61d82b0974beba786f5
3026 Reviewed-on: https://code.wireshark.org/review/10068
3027 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3030 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3031 Date: Tue Aug 18 18:51:32 2015 +0100
3033 IPv6 Jumbogram expert info cleanup
3035 Change-Id: Ic06e50a30330758d6ed0b1b1d9ba0d7f74929a9a
3036 Reviewed-on: https://code.wireshark.org/review/10111
3037 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3040 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3041 Date: Sun Aug 16 21:02:35 2015 +0100
3043 Add IPv6 examples to capture/display filters
3045 Also use TEST-NET-1 for IPv4 examples.
3047 Replaced note using comma with parentheses
3049 Change-Id: I9855207aec7a335b80986aa63bd235edc4278d3a
3050 Reviewed-on: https://code.wireshark.org/review/10061
3051 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3052 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3055 Author: Luke Mewburn <luke@mewburn.net>
3056 Date: Wed Aug 19 10:47:57 2015 +1000
3058 DVBCI: fix typo in comment
3060 Change-Id: I0f6e57b7f16526e7c1b96fb8bd69c003c89b7f42
3061 Reviewed-on: https://code.wireshark.org/review/10119
3062 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3065 Author: Gerald Combs <gerald@wireshark.org>
3066 Date: Wed Aug 12 14:09:35 2015 -0700
3068 UDP multicast stream dialog.
3070 Add the UDP multicast stream dialog. Abuse TapParameterDialog a bit more
3071 so that we can edit parameters.
3073 Remove some unused struct members and an unused function.
3075 Change-Id: I962c70344e792f0959527e4bcba8a20bd7e8acf9
3076 Reviewed-on: https://code.wireshark.org/review/10084
3077 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3078 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3081 Author: Gerald Combs <gerald@wireshark.org>
3082 Date: Tue Aug 18 10:36:04 2015 -0700
3084 Move an include guard.
3086 Move an include guard to match our conventions (and make it easier
3089 Change-Id: I4bad61a0194219f69217713d051e0ff53ff5a76a
3090 Reviewed-on: https://code.wireshark.org/review/10110
3091 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3094 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3095 Date: Tue Aug 18 21:56:52 2015 +0200
3097 simple_statistics_dialog(.h): fix parameter 'st_table' not found in the function declaration [-Wdocumentation]
3099 Change-Id: I69814a05fa6ad65315e36fa75ae60634e934be5c
3100 Reviewed-on: https://code.wireshark.org/review/10117
3101 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3104 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3105 Date: Tue Aug 18 21:10:13 2015 +0200
3107 pcapng(file): fix duplicate break
3109 Change-Id: Ife7170c050402ab94d368acc6c233714be764824
3110 Reviewed-on: https://code.wireshark.org/review/10114
3111 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3114 Author: Stig Bjørlykke <stig@bjorlykke.org>
3115 Date: Tue Aug 18 21:15:27 2015 +0200
3117 Qt: Syntax check display filter when fields changed
3119 Change-Id: I7179d7918e7958373806fb9627a36554ab4b9ddc
3120 Reviewed-on: https://code.wireshark.org/review/10115
3121 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3124 Author: Guy Harris <guy@alum.mit.edu>
3125 Date: Tue Aug 18 12:14:07 2015 -0700
3127 Clean up handling of time stamps.
3129 Use common code for all time stamps, so it's handled the same for the
3130 Packet Block, Enhanced Packet Block, and Interface Statistics Block.
3132 Show the high and low parts of the time stamp as fields; file dissectors
3133 should show the raw file details. Mark the calculated time stamp as
3134 generated, as it's not the raw file data.
3136 Get the 64-bit time stamp by shifting the high part left 32 bits and
3137 ORing in the low part; no need to play games with unions and byte order
3139 Change-Id: I19b2c3227a3ca1e93ec653f279136aa18687581f
3140 Reviewed-on: https://code.wireshark.org/review/10116
3141 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3144 Author: Guy Harris <guy@alum.mit.edu>
3145 Date: Tue Aug 18 11:51:36 2015 -0700
3147 Cast away 64 -> 32 narrowing complaints.
3149 "secs" in an nstime_t is a time_t; cast the calculated seconds portion
3152 Change-Id: Ieaad4c18bb21384a5781f50eadd3a537b414a369
3153 Reviewed-on: https://code.wireshark.org/review/10113
3154 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3157 Author: Dario Lombardo <lomato@gmail.com>
3158 Date: Tue Aug 18 15:58:34 2015 +0200
3160 Init values set (found by American Fuzzy Lop).
3162 Change-Id: Iddd2b4a0ceb409db1afb1a412339134634de631c
3163 Reviewed-on: https://code.wireshark.org/review/10104
3164 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3165 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3166 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3169 Author: Guy Harris <guy@alum.mit.edu>
3170 Date: Tue Aug 18 10:32:16 2015 -0700
3174 Change-Id: I51e14a280ba898a321455168ac8ded1853f55e64
3175 Reviewed-on: https://code.wireshark.org/review/10109
3176 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3179 Author: Stig Bjørlykke <stig@bjorlykke.org>
3180 Date: Tue Aug 18 19:18:07 2015 +0200
3182 Qt: Reload widgets using prefs when reloading Lua plugins
3184 Widgets using prefs must be closed because the prefs may have
3185 been free'd when reloading Lua plugins.
3187 Change-Id: I4b79b7aff18d7923c77a9eb05acadc29b156edbf
3188 Reviewed-on: https://code.wireshark.org/review/10108
3189 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3192 Author: Hadriel Kaplan <hadrielk@yahoo.com>
3193 Date: Sun Aug 16 12:37:11 2015 -0400
3195 Improve file merging for mergecap and wireshark
3197 Refactor the file merging code by removing the duplicate logic from mergecap.c
3198 and file.c's cf_merge_files(), into a new merge_files() function in merge.c.
3199 Also the following user-visible changes:
3201 * Removed the '-T' encap type option from mergecap, as it's illogical for
3202 mergecap and would complicate common merge code.
3204 * Input files with IDBs of different name, speed, tsprecision, etc., will produce
3205 an output PCAPNG file with separate IDBs, even if their encap types are the same.
3207 * Added a '-I' IDB merge mode option for mergecap, to control how IDBs are merged.
3209 * Changed Wireshark's drag-and-drop merging to use PCAPNG instead of PCAP.
3213 Change-Id: Icc30d217e093d6f40114422204afd2e332834f71
3214 Reviewed-on: https://code.wireshark.org/review/10058
3215 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3216 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3217 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3220 Author: AndersBroman <anders.broman@ericsson.com>
3221 Date: Tue Aug 18 16:47:08 2015 +0200
3223 Add casts to passify buildboot.
3225 Change-Id: I8aa4695f1f8dfdfc5bfcd4fb4f36e1b332581d5a
3226 Reviewed-on: https://code.wireshark.org/review/10106
3227 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3230 Author: Dario Lombardo <lomato@gmail.com>
3231 Date: Tue Aug 18 16:29:19 2015 +0200
3233 pcap: add init value.
3235 Found compiling with gcc version 4.8.4 (Ubuntu 4.8.4-2ubuntu1~14.04).
3237 Change-Id: I21bd3a5ab3365f0065c919aba7d6bd00b878d041
3238 Reviewed-on: https://code.wireshark.org/review/10105
3239 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3240 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
3243 Author: Michal Labedzki <michal.labedzki@tieto.com>
3244 Date: Tue Aug 18 15:34:53 2015 +0200
3246 Fix typo in makefile
3249 file.pcapng.c -> file-pcapng.c
3251 Change-Id: I72c40fd086f1b68b69e950c065877b2733279a04
3252 Reviewed-on: https://code.wireshark.org/review/10102
3253 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
3254 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3257 Author: Michal Labedzki <michal.labedzki@tieto.com>
3258 Date: Sat Feb 15 19:05:44 2014 +0100
3260 File-format: BTSNOOP: Add option to dissect next layers
3262 Show next layers of each packet.
3264 Change-Id: I8c56eab969fef9a0a712b479dc2cdef6cc1578ae
3265 Reviewed-on: https://code.wireshark.org/review/221
3266 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3269 Author: Michal Labedzki <michal.labedzki@tieto.com>
3270 Date: Fri Jun 26 15:40:22 2015 +0200
3272 File-format: Add PCAP and PCAPNG dissectors
3274 They have educational values and can be used to debugging some issues.
3275 Now Wireshark can open three files (BTSNOOP, PCAP, PCAPNG)
3276 in two modes: Capture (Traditional) and File-Format.
3278 Change-Id: I833b2464d11864f170923dc989a1925d3d217943
3279 Reviewed-on: https://code.wireshark.org/review/10089
3280 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3283 Author: Michael Mann <mmann78@netscape.net>
3284 Date: Mon Aug 17 20:34:47 2015 -0400
3286 Add udp_dissect_pdus.
3288 It works similar to tcp_dissect_pdus, but only works on a single packet. Intended for protocols that go over TCP and UDP so that they can have a common dissection function.
3289 Will of course, also work on UDP-only protocols with a fixed length header and size.
3291 Used DNP3 as a guinea pig since "multiple PDU support" over UDP was just added.
3293 Change-Id: Ib7af8eaf7102c96b4f8b5c1b891ae2d8f0886f9d
3294 Reviewed-on: https://code.wireshark.org/review/10083
3295 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3296 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3297 Reviewed-by: Dario Lombardo <lomato@gmail.com>
3298 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3301 Author: Michal Labedzki <michal.labedzki@tieto.com>
3302 Date: Sat Jun 6 19:37:20 2015 +0200
3304 Bluetooth: Update Assign Numbers
3306 +18 ATT attributes to be implemented (IPS 1.0 - 19 May 2015, etc.)
3308 Change-Id: Ib30ea20fe9b32a4be842f01ad5b8e8ee081a14ff
3309 Reviewed-on: https://code.wireshark.org/review/10095
3310 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3313 Author: Michal Labedzki <michal.labedzki@tieto.com>
3314 Date: Thu Jan 22 08:27:40 2015 +0100
3316 Bluetooth: ATT: Add some remaining attributes
3318 Add 14 attributes (not as easy as the previous),
3319 there are still 19 + 3 (no idea for now [Valid Range, Report, IEEE 11073-20601
3320 Regulatory Certification Data List]) attributes to be implemented (soon).
3322 Change-Id: Iee5cde4673b62f93084923a592b11824c0683605
3323 Reviewed-on: https://code.wireshark.org/review/10094
3324 Petri-Dish: Anders Broman <a.broman58@gmail.com>
3325 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3326 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3329 Author: Stig Bjørlykke <stig@bjorlykke.org>
3330 Date: Mon Aug 17 13:18:30 2015 +0200
3332 Qt: Fix use-after-free pattern
3334 QString.toUtf8() returns a QByteArray object and .constData() returns
3335 a pointer inside that object. It is not safe to store this pointer as
3336 it will become invalid after the statement.
3338 Change-Id: I8f54ede75577719008835038934e935cd5feba3f
3339 Reviewed-on: https://code.wireshark.org/review/10067
3340 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3341 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3342 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3343 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3346 Author: Pascal Artho <pascalartho@gmail.com>
3347 Date: Tue Aug 18 08:43:06 2015 +0200
3349 Preparation Host Flows: Dissector Packet ICMP and ICMPv6
3351 see https://code.wireshark.org/review/#/c/9976/
3353 Change-Id: Ic301db4deea1a02b9e08c123b3e21e70817a2c85
3354 Reviewed-on: https://code.wireshark.org/review/10097
3355 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3358 Author: Michal Labedzki <michal.labedzki@tieto.com>
3359 Date: Wed Jul 22 17:38:51 2015 +0200
3361 Qt: Add another C++ missing header: <algorithm> for std::sort()
3364 ui/qt/packet_list_model.cpp:270:5: error: 'sort' is not a member of 'std'
3365 std::sort(visible_rows_.begin(), visible_rows_.end(), recordLessThan);
3367 Change-Id: I3a577a268f6c12e8fd97b7b6fd2429989c28e2f5
3368 Reviewed-on: https://code.wireshark.org/review/10092
3369 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
3370 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3371 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3374 Author: Michal Labedzki <michal.labedzki@tieto.com>
3375 Date: Sat Jul 18 18:25:36 2015 +0200
3377 Qt/Minimap: Fix for Qt < 4.8
3379 I hope it is quite right solution.
3381 Change-Id: Ia9c883a832ddd03985eda37a9b344c4d7c8135e2
3382 Reviewed-on: https://code.wireshark.org/review/10091
3383 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3386 Author: Hadriel Kaplan <hadrielk@yahoo.com>
3387 Date: Mon Jul 20 11:09:06 2015 -0400
3389 Pcapng: clean up Section Header Block handling
3391 Change-Id: I8516d0c561ed0b63e49a3594027c9c15bb789258
3392 Reviewed-on: https://code.wireshark.org/review/9726
3393 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3394 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3395 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3396 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3399 Author: Martin Kaiser <wireshark@kaiser.cx>
3400 Date: Thu Aug 13 23:00:29 2015 +0200
3402 rewrite the H1 dissector
3404 * use the offset variable to keep track of where we are,
3405 remove the position variable
3406 (previously, offset remained 0 all the time...)
3407 * use proto_tree_add_item()
3408 * highlight the correct bytes for each field
3409 * define a block type and block length instead of
3410 naming these fields differently for each block
3411 * indent by 4 spaces
3413 Change-Id: Ie0995e5fe6364605fd30020f171e51458844fa59
3414 Reviewed-on: https://code.wireshark.org/review/10080
3415 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
3416 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3417 Reviewed-by: Michael Mann <mmann78@netscape.net>
3418 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3421 Author: Michael Mann <mmann78@netscape.net>
3422 Date: Mon Aug 17 23:06:21 2015 -0400
3424 Eliminate proto_tree_add_text from XMPP dissectors.
3426 Change-Id: I32fdf085ef484d147d9f0b27c56efba41bb827bf
3427 Reviewed-on: https://code.wireshark.org/review/10086
3428 Reviewed-by: Michael Mann <mmann78@netscape.net>
3429 Petri-Dish: Michael Mann <mmann78@netscape.net>
3430 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3433 Author: Hadriel Kaplan <hadrielk@yahoo.com>
3434 Date: Mon Aug 17 23:06:50 2015 -0400
3436 Lua: add FT_PROTOCOL as a ProtoField type
3439 Change-Id: Ic77ddd193246c0202efcc9c11e61e8f6f85329c5
3440 Reviewed-on: https://code.wireshark.org/review/10087
3441 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3442 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3443 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3446 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
3447 Date: Mon Aug 17 16:50:39 2015 -0400
3451 It was in the list of packages but not in the final command line.
3453 Change-Id: I361e660cc4ac91121314a3f8a7388b48fb2c61b7
3454 Reviewed-on: https://code.wireshark.org/review/10081
3455 Reviewed-by: Jeff Morriss <jeff.morriss.ws@gmail.com>
3458 Author: Gerald Combs <gerald@wireshark.org>
3459 Date: Mon Aug 17 10:47:46 2015 -0700
3461 Fixup tap listener registration.
3463 Make sure we run make-tap-reg.py on files that register tap
3464 listeners. Make sure Qt-specific registration routines start with
3465 register_tap_listener_qt_.
3467 Change-Id: Idca382180f475db71e4d1965a70ae4cc2fa4f9d5
3468 Reviewed-on: https://code.wireshark.org/review/10074
3469 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3470 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3471 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3474 Author: Martin Kaiser <wireshark@kaiser.cx>
3475 Date: Thu Aug 13 22:44:29 2015 +0200
3477 h1: remove if (tree) checks, indent according to the modelines
3479 Change-Id: I878aa23b5d718653b9039aeb94a0ece88c9c03cf
3480 Reviewed-on: https://code.wireshark.org/review/10079
3481 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
3484 Author: Martin Kaiser <wireshark@kaiser.cx>
3485 Date: Thu Aug 13 22:32:43 2015 +0200
3487 h1: don't THROW() an exception from a dissector
3489 leaving the parsing loop should be enough in this case...
3491 Change-Id: Ic250961aeb4d3cfcd74ee8caacb59657c32444de
3492 Reviewed-on: https://code.wireshark.org/review/10078
3493 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
3496 Author: Stig Bjørlykke <stig@bjorlykke.org>
3497 Date: Mon Aug 17 22:00:57 2015 +0200
3499 Qt: Avoid double call to toUtf8()
3501 Change-Id: I4d31063b4aa37e4b0a68b5dbc17be22ef2cd151a
3502 Reviewed-on: https://code.wireshark.org/review/10077
3503 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3506 Author: Stig Bjørlykke <stig@bjorlykke.org>
3507 Date: Mon Aug 17 21:39:41 2015 +0200
3509 Qt: Always rebuild columns when fields changed
3511 The columns must be recreated even if no capture file is loaded
3512 because custom columns may have reference to deregistered fields.
3514 Change-Id: I4ed7345b3200e5af211695f1a6511ee229d5f13c
3515 Reviewed-on: https://code.wireshark.org/review/10076
3516 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3519 Author: Gerald Combs <gerald@wireshark.org>
3520 Date: Wed Aug 12 15:11:39 2015 -0700
3522 Improve multicast address checking.
3524 Check for IPv4 and IPv6 multicast addresses. We might have captured on
3525 an "any" interface, or on a PPP link, or used some other method that
3526 doesn't result in dl_dst.type == AT_ETHER.
3528 Change-Id: I18b0597fd432e4cec8c388a3c7d2d18ac4da0fad
3529 Reviewed-on: https://code.wireshark.org/review/10009
3530 Petri-Dish: Gerald Combs <gerald@wireshark.org>
3531 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3532 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3535 Author: Selvamegala <sselvamegala@gmail.com>
3536 Date: Sat Aug 8 20:35:30 2015 -0400
3538 Add Decryption support for Lwmesh
3541 Change-Id: Id598838f036b1f312791d9dddbf3767dcbfd1aee
3542 Reviewed-on: https://code.wireshark.org/review/9937
3543 Petri-Dish: Michael Mann <mmann78@netscape.net>
3544 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3545 Reviewed-by: Michael Mann <mmann78@netscape.net>
3548 Author: Hadriel Kaplan <hadrielk@yahoo.com>
3549 Date: Mon Aug 17 11:12:12 2015 -0400
3551 Pcapng: set interface description's tsprecision when reading file
3554 Change-Id: I5fe14616ed6e86e0bfe02c58cc9fb31e43bc23ef
3555 Reviewed-on: https://code.wireshark.org/review/10071
3556 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3557 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3558 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3561 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
3562 Date: Mon Aug 17 13:35:40 2015 +0200
3564 BPDU: Fix some Dead Store (Dead assignement/Dead increment) Warning found by Clang
3566 Change-Id: I91cc96f92ae2e6b07144120d70f8db5b7ad45fce
3567 Reviewed-on: https://code.wireshark.org/review/10070
3568 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3571 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3572 Date: Mon Aug 17 06:00:27 2015 +0100
3574 dissect_ip_heur(): Remove TODO (done)
3576 Change-Id: I0c36179b63f5d60037de80badfea352c903c2525
3577 Reviewed-on: https://code.wireshark.org/review/10065
3578 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3581 Author: Michael Mann <mmann78@netscape.net>
3582 Date: Sun Aug 16 20:06:50 2015 -0400
3584 Remove proto_tree_add_text from packet-xml.c
3586 Required introducing packet_info* to xml_frame_t structure.
3588 Change-Id: Ie777fe3bc8c7ea052d3441dd31e0631ce47324cb
3589 Reviewed-on: https://code.wireshark.org/review/10063
3590 Reviewed-by: Michael Mann <mmann78@netscape.net>
3591 Petri-Dish: Michael Mann <mmann78@netscape.net>
3592 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3593 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3596 Author: Dario Lombardo <lomato@gmail.com>
3597 Date: Thu Aug 13 16:08:18 2015 +0200
3599 DNP3: add support for udp multi frame packets.
3602 Change-Id: I1f3006a4276e8a95d028294ebb9635f71be0f75e
3603 Reviewed-on: https://code.wireshark.org/review/10013
3604 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
3605 Petri-Dish: Graham Bloice <graham.bloice@trihedral.com>
3606 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3607 Reviewed-by: Michael Mann <mmann78@netscape.net>
3610 Author: Guy Harris <guy@alum.mit.edu>
3611 Date: Sun Aug 16 12:33:31 2015 -0700
3613 Fix the conversion of milliseconds to seconds and nanoseconds.
3615 1 millisecond = 1000000 nanoseconds, not 1000 nanoseconds, and
3616 nstime->nsecs is nanoseconds, not microseconds.
3618 Change-Id: I6925ff80f6443015f83ca00bad2a347d10eadd7c
3619 Reviewed-on: https://code.wireshark.org/review/10060
3620 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3623 Author: Petr Gotthard <petr.gotthard@honeywell.com>
3624 Date: Sun Aug 16 16:50:52 2015 +0200
3626 AMQP 1.0: Fix OSX build errors
3628 packet-amqp.c:10660: warning: implicit conversion shortens 64-bit value into a 32-bit value
3629 packet-amqp.c:10661: warning: implicit conversion shortens 64-bit value into a 32-bit value
3631 Change-Id: Ic1c19edf10432dccb5fc4f3ea07defd45b9eef17
3632 Reviewed-on: https://code.wireshark.org/review/10054
3633 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3634 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3635 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3638 Author: ff <francesco.fondelli@gmail.com>
3639 Date: Sun Aug 16 17:27:01 2015 +0200
3641 A new Early Allocation Request for draft-ietf-pce-lsp-setup-type and
3642 draft-ietf-pce-segment-routing has been issued. Reference:
3643 https://mailarchive.ietf.org/arch/msg/pce/Zdsc0HHl1SLvpANRWhpLvIzJQyI
3644 There are implementations out there that are using 5 as SR-ERO subobject
3645 identifier (instead of 36 that will be assigned by IANA) and 27 as the
3646 PATH-SETUP-TYPE TLV identifier (instead of 28 that will be assigned by
3647 IANA). This patch decodes both 5/36 as SR-ERO subobject and 27/28 as
3648 PATH-SETUP-TYPE. It is unlikely that IANA will re-assign code points 5
3649 and 27 in the near future.
3651 Change-Id: Ie2efa869344e4c1121f19f1ee3a71711d566a037
3652 Signed-off-by: ff <francesco.fondelli@gmail.com>
3653 Reviewed-on: https://code.wireshark.org/review/10057
3654 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
3655 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3656 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3659 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3660 Date: Sun Aug 16 07:35:24 2015 +0100
3662 Fix IP Destinations stats tree
3664 Change-Id: I875ecb05e0919e81e6d8d1d00f802c8d5df5b214
3665 Reviewed-on: https://code.wireshark.org/review/10053
3666 Reviewed-by: Michael Mann <mmann78@netscape.net>
3667 Petri-Dish: Michael Mann <mmann78@netscape.net>
3668 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3669 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3672 Author: Gerald Combs <gerald@wireshark.org>
3673 Date: Sat Aug 15 17:05:17 2015 -0700
3675 Run abicheck commands at compile time.
3677 The CMake dumpbabi targets collectively copy over 800 files. Do
3678 that when when we build the actual targets instead of at configure
3679 time. Hopefully this will speed up initial CMake runs.
3681 Change-Id: I6e4d691e24c73ea05d638a0f897f570541c84e38
3682 Reviewed-on: https://code.wireshark.org/review/10052
3683 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3686 Author: Gerald Combs <gerald@wireshark.org>
3687 Date: Sun Aug 16 08:10:40 2015 -0700
3689 [Automatic update for 2015-08-16]
3691 Update manuf, services enterprise-numbers, translations, and other items.
3693 Change-Id: Idb8a2cff075a1ffe5e3cd1d6f4d3fb1b6c357cdb
3694 Reviewed-on: https://code.wireshark.org/review/10055
3695 Reviewed-by: Gerald Combs <gerald@wireshark.org>
3698 Author: Petr Gotthard <petr.gotthard@honeywell.com>
3699 Date: Sat Jul 4 01:19:02 2015 +0200
3701 AMQP 1.0: Refactor to fix parsing of timestamps
3703 Timestamps are currently dissected as integer numbers; two aspects need to
3704 be recatored to correctly dissect timestamps:
3705 - the add_1_0_proto_item() function
3706 - protocol fields (hf_xxx) and the get_amqp_1_0_value_formatter()
3709 The AMQP 1.0 dissector rely on the proto_tree_add_item. There is only one
3710 invocation common for all datatypes (in add_1_0_proto_item), which cannot
3711 pass any type-specific ENC_xxx specifiers and it cannot handle custom
3712 datatypes like AMQP timestamp.
3714 I propose to replace the add_1_0_proto_item() by type-specific dissectors that
3715 will correctly set the ENC_xxx specifiers and handle exceptional cases like
3716 the AMQP timestamp or the zero-length true/false datatypes.
3719 The get_amqp_1_0_value_formatter implements a table-driven magic to select
3720 alternate hf_xxx field based on the actual datatype. This however
3721 - defines alternate fields where the standard permits only one datatype
3722 - does not support fields that can contain any datatype ("*")
3723 - does not support FT_TIMESTAMP
3725 I propose to make this mechanism less table-driven (more explicit and more
3726 flexible) and allow all alternates permitted by the standard.
3728 Change-Id: Ib2cbda632d4c81ec3e6b81f539fe77bb913afc1c
3729 Reviewed-on: https://code.wireshark.org/review/9528
3730 Petri-Dish: Michael Mann <mmann78@netscape.net>
3731 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3732 Reviewed-by: Michael Mann <mmann78@netscape.net>
3735 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3736 Date: Sat Aug 15 18:07:10 2015 +0100
3738 make-taps.pl: Remove duplicate slash in pathname
3740 Change-Id: Id5e13df24409267c405cdd05479610a8ba898289
3741 Reviewed-on: https://code.wireshark.org/review/10047
3742 Reviewed-by: Michael Mann <mmann78@netscape.net>
3745 Author: Michael Mann <mmann78@netscape.net>
3746 Date: Sat Aug 15 09:39:05 2015 -0400
3748 Conversion of random proto_tree_add_text calls.
3750 Change-Id: I6505ce34de84bfe46d5bc7b4d6a3c6044f3fb4b5
3751 Reviewed-on: https://code.wireshark.org/review/10041
3752 Petri-Dish: Michael Mann <mmann78@netscape.net>
3753 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3754 Reviewed-by: Michael Mann <mmann78@netscape.net>
3757 Author: Guy Harris <guy@alum.mit.edu>
3758 Date: Sat Aug 15 11:34:46 2015 -0700
3760 Un-reference actions after adding them to an action group.
3762 When created, they have a reference count of 1; when added to an action
3763 group, the reference count is increased as a pointer is held by the
3764 action group. Release the reference we got, as we're not holding onto
3767 Also, rename "menu_item" to "menu_action", to indicate that it's an action.
3769 Change-Id: I54543dcc2e6c3b341a9f584fe1b6099a134771b3
3770 Reviewed-on: https://code.wireshark.org/review/10049
3771 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3774 Author: Guy Harris <guy@alum.mit.edu>
3775 Date: Sat Aug 15 11:20:36 2015 -0700
3777 Do the "plugin" menu stuff in one pass.
3779 Also, use g_strconcat() in other places where we prepend / to action
3782 Hopefully, this will make it easier to find common code between all the
3783 N different places where we add menus and menu items.
3785 Change-Id: Iee876866730cada64428df17f1f3c4552cc3ac93
3786 Reviewed-on: https://code.wireshark.org/review/10048
3787 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3790 Author: Guy Harris <guy@alum.mit.edu>
3791 Date: Sat Aug 15 10:49:51 2015 -0700
3793 Fix creation of menu actions in ws_menubar_create_action_group().
3795 Action names are expected to begin with /, so prepend a /.
3797 Fixes the "plugin" menu mechanism (which could be used by built-in code
3798 as well, so it's not really a "plugin" menu mechanism).
3800 Change-Id: Ic45412399078796359649cc876d2c8bfc9a790c6
3801 Reviewed-on: https://code.wireshark.org/review/10046
3802 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3805 Author: Stig Bjørlykke <stig@bjorlykke.org>
3806 Date: Sat Aug 15 19:31:51 2015 +0200
3808 Fixed a comment in cleanup_dissection
3810 Change-Id: I445e09803023d1a22a663ba0501c013f113b5bfe
3811 Reviewed-on: https://code.wireshark.org/review/10045
3812 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3815 Author: Stig Bjørlykke <stig@bjorlykke.org>
3816 Date: Sat Aug 15 19:25:13 2015 +0200
3818 Lua: Free true_false_string values at reload
3820 Change-Id: I8ab194bf094e82f08ddafb0a1451aec42989b93d
3821 Reviewed-on: https://code.wireshark.org/review/10044
3822 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3825 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3826 Date: Sat Aug 15 17:55:27 2015 +0100
3828 Add a newline for readability
3830 Change-Id: I7dbfa8f82454bd93ca5a66f22c29982923803918
3831 Reviewed-on: https://code.wireshark.org/review/10043
3832 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
3835 Author: Guy Harris <guy@alum.mit.edu>
3836 Date: Sat Aug 15 09:26:45 2015 -0700
3840 Change-Id: Ib415582f4bf2529c412bed329b3ee7daccde29b0
3841 Reviewed-on: https://code.wireshark.org/review/10042
3842 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3845 Author: Michael Mann <mmann78@netscape.net>
3846 Date: Sun Aug 9 08:03:21 2015 -0400
3848 Don't clear the tcp_analysis if a conversation is not provided to get_tcp_conversation_data().
3850 Callers may need to know information like retransmissions, etc which will be lost.
3852 Change-Id: I3f8b6b0aeb308701eb34ae6f6f735af6995ed441
3853 Reviewed-on: https://code.wireshark.org/review/9940
3854 Reviewed-by: Michael Mann <mmann78@netscape.net>
3857 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3858 Date: Sat Aug 15 08:29:51 2015 +0100
3860 udp: fix minimum jumbo length
3862 Change-Id: I5ab4974cc60cdec0c3571bdec815c8cb9e8f7255
3863 Reviewed-on: https://code.wireshark.org/review/10040
3864 Reviewed-by: Michael Mann <mmann78@netscape.net>
3867 Author: Evan Huus <eapache@gmail.com>
3868 Date: Tue Aug 11 18:35:45 2015 -0400
3870 btatt: guard against incomplete reassembly
3872 If we try and reassemble a fragment whose end does not line up exactly with the
3873 start of the following fragment, abort or else we will leave uninitialized gaps
3874 in the resulting buffer.
3877 Change-Id: I4cd05c1a9ac4404bf70a3945f80b12f7bf5f74ee
3878 Reviewed-on: https://code.wireshark.org/review/9983
3879 Reviewed-by: Evan Huus <eapache@gmail.com>
3880 Petri-Dish: Evan Huus <eapache@gmail.com>
3881 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3882 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3885 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
3886 Date: Sun Aug 9 23:13:06 2015 +0100
3888 Add IPv6 Jumbogram support (RFC 2675)
3890 Change-Id: Icea1659395d7bc16e367b74a695586926b33149b
3891 Reviewed-on: https://code.wireshark.org/review/9968
3892 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
3893 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3894 Reviewed-by: Michael Mann <mmann78@netscape.net>
3895 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3898 Author: Michael Mann <mmann78@netscape.net>
3899 Date: Wed Aug 12 09:01:45 2015 -0400
3901 Eliminate proto_tree_add_text from GSM dissectors.
3903 Change-Id: I36a3d15a4fa86847a83d1dbea40111d36d7cfd61
3904 Reviewed-on: https://code.wireshark.org/review/10036
3905 Reviewed-by: Michael Mann <mmann78@netscape.net>
3906 Petri-Dish: Michael Mann <mmann78@netscape.net>
3907 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
3908 Reviewed-by: Anders Broman <a.broman58@gmail.com>
3911 Author: Guy Harris <guy@alum.mit.edu>
3912 Date: Fri Aug 14 20:54:22 2015 -0700
3914 Update the previously-added comment.
3916 At least with kqueues, NOTE_REVOKE is delivered if the file system
3917 containing the vnode in question is unmounted, and that gets mapped to a
3918 change notification by QFileSystemWatcher, so the right thing should
3921 I'm not sure whether the right thing happens on Windows.
3923 Change-Id: I1e4c0d510f31f68d574c4d4cf20524666382930f
3924 Reviewed-on: https://code.wireshark.org/review/10039
3925 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3928 Author: Guy Harris <guy@alum.mit.edu>
3929 Date: Fri Aug 14 18:49:17 2015 -0700
3931 Discuss alternatives to polling all the recent files every 2 seconds.
3933 Somebody asked about repeated SMB traffic when running the Qt Wireshark:
3935 https://ask.wireshark.org/questions/45036/permanent-smb2-traffic-with-1997
3937 and that's due to said polling. On the main desktop platforms (Windows,
3938 OS X, Linux) we can use QFileSystemWatcher plus, on Windows and OS X,
3939 some additional stuff to check for unmounts (and get FreeBSD as a
3940 freebie, as it works the same as OS X), and avoid timeout-based polling.
3942 Change-Id: I3a1d0110fedcdb442ed09c16dab4bf0cb06ca331
3943 Reviewed-on: https://code.wireshark.org/review/10038
3944 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3947 Author: Guy Harris <guy@alum.mit.edu>
3948 Date: Fri Aug 14 17:19:37 2015 -0700
3950 Fix for the current wireshark.desktop.
3952 The default version doesn't use GTK+ any more, so the version we
3953 distribute doesn't have "Categories=System;Monitor;GTK;", and the Debian
3954 version presumably shouldn't put it into category "GNOME".
3956 Change-Id: I4e59026b5c4f26d02e4a96686e339f8d54bdcd1e
3957 Reviewed-on: https://code.wireshark.org/review/10035
3958 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3961 Author: Guy Harris <guy@alum.mit.edu>
3962 Date: Fri Aug 14 16:19:13 2015 -0700
3964 Put it in the Qt category, not the GTK category.
3966 The default binary, "wireshark", is now a Qt binary; "wireshark-gtk" is
3969 Change-Id: Ibfec5d796a9796c2588c4305b18dc4506a435228
3970 Reviewed-on: https://code.wireshark.org/review/10034
3971 Reviewed-by: Guy Harris <guy@alum.mit.edu>
3974 Author: Hadriel Kaplan <hadrielk@yahoo.com>
3975 Date: Fri Aug 14 10:44:11 2015 -0400
3977 Ident the merge.c/h files by 4 spaces
3979 Using 2 spaces for indent is way past its prime.
3981 Change-Id: I80caf89f15e576f9aeb25754576a9f18215ccb3c
3982 Reviewed-on: https://code.wireshark.org/review/10032
3983 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
3986 Author: Stig Bjørlykke <stig@bjorlykke.org>
3987 Date: Fri Aug 14 14:48:49 2015 +0200
3989 Added some missing breaks
3991 Change-Id: I3b2f25832ca878ec3e7f9e4dcce258dc870fc5ad
3992 Reviewed-on: https://code.wireshark.org/review/10031
3993 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
3996 Author: Stig Bjørlykke <stig@bjorlykke.org>
3997 Date: Fri Aug 14 13:46:01 2015 +0200
3999 Free all hfi->strings in free_deregister_field
4001 Change-Id: I6fe78266a2e881fa80e1e3a3423b685d3c1764de
4002 Reviewed-on: https://code.wireshark.org/review/10029
4003 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4006 Author: Stig Bjørlykke <stig@bjorlykke.org>
4007 Date: Fri Aug 14 11:02:10 2015 +0200
4009 Qt: Fixed funnel text dialog append and prepend
4011 Append to end and prepend to start, not the opposite.
4013 Change-Id: Ic0e2a7f04a0d9ff18a6fd7063d0550ad35eece1a
4014 Reviewed-on: https://code.wireshark.org/review/10027
4015 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4018 Author: Stig Bjørlykke <stig@bjorlykke.org>
4019 Date: Fri Aug 14 09:26:50 2015 +0200
4021 Free protocol in proto_free_deregistered_fields
4023 This fixes some issues with use-after-free when reload Lua plugins.
4025 Change-Id: I63f3fd9ebe8a19008f560e72067f2078f5eaf759
4026 Reviewed-on: https://code.wireshark.org/review/10026
4027 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4030 Author: Stig Bjørlykke <stig@bjorlykke.org>
4031 Date: Fri Aug 14 07:54:51 2015 +0200
4033 Qt: Avoid redissect twice when changing fields
4035 Changing fields in http, imf or ldap used to trigger redissect twice
4036 because of UAT_AFFECTS_FIELDS and UAT_AFFECTS_DISSECTION.
4037 Also changed from redrawVisiblePackets() to columnsChanged() because
4038 fields in a custom column may have changed.
4040 This also fixes reloading Lua plugins with Lua fields in custom columns.
4042 Change-Id: I805a765690decbe7434dbf1c33ebd1113e23d16d
4043 Reviewed-on: https://code.wireshark.org/review/10025
4044 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4047 Author: Guy Harris <guy@alum.mit.edu>
4048 Date: Thu Aug 13 20:05:43 2015 -0700
4050 Clean up heuristic checks.
4052 Fix heuristic checks to handle sliced packets correctly. "Correctly"
4053 means "fail the heuristic", as the heuristic checks every single byte of
4054 the putative Ixia trailer, as one thing it does is check the checksum,
4055 which is in the last 2 bytes of the trailer and checks everything before
4056 it. So just return 0 if the full trailer isn't part of the captured
4059 Try to handle being handed a tvbuff that contains an FCS by looking at
4060 the putative "magic number" locations where it would be if the tvbuff
4061 didn't include the FCS and, if that doesn't match, where it would be if
4062 it *did* include the FCS. If the former doesn't match but the latter
4063 does, assume that means it does include the FCS, and do all other
4064 processing under that assumption.
4066 Clean up some comments.
4068 Fix an hf_ variable name to match the field name, and put the tvbuff
4069 value fields in the order of their types.
4071 Don't fail if the field length is 0 - it's a value length, so it could
4072 in theory be 0. Rely on the length checks for individual types to catch
4075 Change-Id: Idc834aa6637cfbbafd6499060a007e720378154e
4076 Reviewed-on: https://code.wireshark.org/review/10024
4077 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4080 Author: Guy Harris <guy@alum.mit.edu>
4081 Date: Thu Aug 13 16:36:03 2015 -0700
4083 Get rid of trailing whitespace.
4085 Change-Id: I035fad79dd8d01aa3121732f2a9b07d20cc4384f
4086 Reviewed-on: https://code.wireshark.org/review/10023
4087 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4090 Author: Guy Harris <guy@alum.mit.edu>
4091 Date: Thu Aug 13 16:30:51 2015 -0700
4093 Update to reflect reality.
4095 The Ixia trailer is a variable-length sequence of TLVs followed by some
4096 fixed-length fields. Describe it as such.
4098 Realign some #defines while we're at it.
4100 Change-Id: I5fc45a1d44978f1dc1f13e7098c3f797838db7b3
4101 Reviewed-on: https://code.wireshark.org/review/10022
4102 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4105 Author: Ionut Ceausu <ionut.ceausu@gmail.com>
4106 Date: Mon Aug 3 18:06:54 2015 +0300
4108 ixiatrailer: Change format of the protocol so that is supports future fields.
4110 Protocol is TLV protocol and with this change I add one more field to it.
4111 It is entire backward compatible.
4112 Format is as follow:
4113 Fields Trailer Length 0xAF12(Signature) Trailer Checksum
4115 The fields portion of the trailer is a series of 2-byte fields followed by variable
4116 length data. The first byte indicates the field type, the 2nd byte indicates the
4117 field length. The values supported are listed below:
4118 1 Reserved (Original Packet Size)
4119 3 Timestamp (From Local Timebase)
4120 4 Timestamp (From NTP source)
4121 5 Timestamp (From GPS)
4122 6 Timestamp (From 1588)
4123 7 Timestamp (From Holdover)
4125 Change-Id: I0a3b31cfbc5b6273e1f5326d9841e449735967fe
4126 Reviewed-on: https://code.wireshark.org/review/9854
4127 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
4128 Petri-Dish: Martin Mathieson <martin.r.mathieson@googlemail.com>
4131 Author: Bill Meier <wmeier@newsguy.com>
4132 Date: Thu Aug 13 12:02:33 2015 -0400
4134 [config.nmake] Add minor comment about /Zo option for MSVC-2015
4136 Change-Id: Ia4ffc543965160aaf6c39dc19764e62e9e82faa8
4137 Reviewed-on: https://code.wireshark.org/review/10020
4138 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4141 Author: Dario Lombardo <lomato@gmail.com>
4142 Date: Thu Aug 13 17:27:10 2015 +0200
4144 ieee802.11: changed blurb to stop checkAPI complains.
4146 Change-Id: I9ec74a7af229a1af3ca946acc5af94ede1913c29
4147 Reviewed-on: https://code.wireshark.org/review/10016
4148 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4151 Author: Pascal Quantin <pascal.quantin@gmail.com>
4152 Date: Thu Aug 13 17:38:09 2015 +0200
4154 Qt: fix copy of newer files when building with qmake
4156 Change-Id: I8ea5e2770a0c5be3d981d986fa96fe30445db167
4157 Reviewed-on: https://code.wireshark.org/review/10018
4158 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4161 Author: Pascal Quantin <pascal.quantin@gmail.com>
4162 Date: Thu Aug 13 16:16:03 2015 +0200
4164 GVCP: fix dissection of Stream Channel Packet Size register
4167 Change-Id: I1c187bdf7ffd14b2a4f66d29883a4b112486bd35
4168 Reviewed-on: https://code.wireshark.org/review/10014
4169 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4170 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4173 Author: Anders <anders.broman@ericsson.com>
4174 Date: Fri May 29 10:33:58 2015 +0200
4176 Make building with MSVC2015 work
4179 - LUA is commented out probably needs to be built with MSVC 2015.
4180 - GeoIP is commented out, causes packet-ip* to not build.
4181 - Qt not built, needs Qt with MSVC 2015
4183 Change-Id: I1658077931b89b9a22ee32e5ed7de38e07fb6a55
4184 Reviewed-on: https://code.wireshark.org/review/8683
4185 Petri-Dish: Anders Broman <a.broman58@gmail.com>
4186 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4187 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4190 Author: Dario Lombardo <lomato@gmail.com>
4191 Date: Thu Aug 13 10:13:52 2015 +0200
4193 fuzz-test.sh: added missing option in help.
4195 Change-Id: I7651e18ec6e8338cddc82be90257c5f183804c7c
4196 Reviewed-on: https://code.wireshark.org/review/10011
4197 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4200 Author: Michael Mann <mmann78@netscape.net>
4201 Date: Tue Aug 11 19:50:43 2015 -0400
4203 Eliminate proto_tree_add_text from some dissectors.
4205 Change-Id: I1e6bf52fad1b1fffefc174a557ff836f400e8fd7
4206 Reviewed-on: https://code.wireshark.org/review/9996
4207 Reviewed-by: Michael Mann <mmann78@netscape.net>
4208 Petri-Dish: Michael Mann <mmann78@netscape.net>
4209 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4210 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4213 Author: Gerald Combs <gerald@wireshark.org>
4214 Date: Wed Aug 12 15:19:25 2015 -0700
4216 Initialize another variable.
4218 Change-Id: Ie53a16dc482a9c38538077f6d6a2717cfaddbaa4
4219 Reviewed-on: https://code.wireshark.org/review/10010
4220 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4223 Author: Dario Lombardo <lomato@gmail.com>
4224 Date: Tue Aug 11 23:58:54 2015 +0200
4226 editcap: add change offset.
4228 This option skips some bytes when fuzzing, that prevents some headers from being changed. This focuses fuzzer to a smaller part of the packet.
4230 Change-Id: I1db83235e93f2774a9991e3af70f633487b816fa
4231 Reviewed-on: https://code.wireshark.org/review/9982
4232 Petri-Dish: Anders Broman <a.broman58@gmail.com>
4233 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4234 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4237 Author: Gerald Combs <gerald@wireshark.org>
4238 Date: Wed Aug 12 14:12:24 2015 -0700
4240 Initialize a couple of variables.
4242 Change-Id: I10471b770356ad46a10740198156055e1480eeb3
4243 Reviewed-on: https://code.wireshark.org/review/10008
4244 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4247 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4248 Date: Wed Aug 12 20:58:14 2015 +0200
4250 Qt (main_window) fix no previous prototype for '...' [-Wmissing-prototypes]
4253 Change-Id: I43901d37817f9b79d508336253e766d740939e70
4254 Reviewed-on: https://code.wireshark.org/review/10003
4255 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4256 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4257 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4260 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4261 Date: Wed Aug 12 21:06:08 2015 +0200
4263 GTP: fix indent (use 4 spaces)
4265 Change-Id: I2f0645adee2aff32122a8ccb60843e1bfd0897e1
4266 Reviewed-on: https://code.wireshark.org/review/10004
4267 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4270 Author: Bill Meier <wmeier@newsguy.com>
4271 Date: Wed Aug 12 16:47:36 2015 -0400
4273 [lwres] Fix (32 bit ?) MSVC-2015 warning: "conversion from 'size_t' to 'guint16', possible loss of data"
4275 Change-Id: Ifc71d1c2afc3ff16f950f2f1c3c9e7142d62fc16
4276 Reviewed-on: https://code.wireshark.org/review/10007
4277 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4280 Author: Bill Meier <wmeier@newsguy.com>
4281 Date: Wed Aug 12 16:24:03 2015 -0400
4283 [pdc] Fix a few [msvc-2015?] warnings about 'constant compared to constant'
4285 Essentially: Do the version checks at compile time using
4286 #if statements (even though the compiler
4287 probably optimized out the run time checks).
4289 Change-Id: I4879b39729ba5bd6b1c478ac43c107cb9fb445b3
4290 Reviewed-on: https://code.wireshark.org/review/10006
4291 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4294 Author: Bill Meier <wmeier@newsguy.com>
4295 Date: Wed Aug 12 16:15:05 2015 -0400
4297 [pdc] [msvc-2015] Change a variable type to prevent 32-bit MSVC-2015 "internal error"
4299 [...]\packet-pdc.c(205) : fatal error C1001: An internal error has occurred in the compiler.
4301 (compiler file 'f:\dd\vctools\compiler\utc\src\p2\main.c', line 246)
4302 To work around this problem, try simplifying or changing the program near the locations listed above.
4303 Please choose the Technical Support command on the Visual C++
4304 Help menu, or open the Technical Support help file for more information
4306 INTERNAL COMPILER ERROR in 'C:\Program Files\Microsoft Visual Studio 14.0\VC\BIN\cl.EXE'
4307 Please choose the Technical Support command on the Visual C++
4308 Help menu, or open the Technical Support help file for more information
4310 Change-Id: I505898d0c76244a56d75af1a1c5bf30554dd9a2b
4311 Reviewed-on: https://code.wireshark.org/review/10005
4312 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4315 Author: Gerald Combs <gerald@wireshark.org>
4316 Date: Tue Aug 11 11:48:07 2015 -0700
4318 Add DCE-RPC and ONC-RPC service response time dialogs.
4320 Add RpcServiceResponseTimeDialog, which handles DCE-RPC and ONC-RPC
4321 service response time statistics. Try to make it as lightweight as
4322 possible, since we might want to pull this into the RPC dissectors
4323 similar to the other SRT statistics.
4325 Allow program names on the command line in place of numbers or UUIDs. Make
4326 matches case-insensitive. E.g. the following are equivalent:
4332 as are the following:
4334 -z dcerpc,srt,f5cc5a18-4264-101a-8c59-08002b2f8426,56
4335 -z dcerpc,srt,nspi,56
4336 -z dcerpc,srt,NSPI,56
4338 Change-Id: Ie451c64bf6fbc776f27d81e3bc248435c5cbc9e4
4339 Reviewed-on: https://code.wireshark.org/review/9981
4340 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4341 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4342 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4345 Author: Gerald Combs <gerald@wireshark.org>
4346 Date: Wed Aug 12 10:49:34 2015 -0700
4348 Expert information dialog performance improvements.
4350 Inserting QTreeWidgetItems individually is slow. This isn't a problem if
4351 you only have a few items but the Expert Information dialog can have
4352 thousands. Add "packet" tree items in groups, which should be much
4353 faster. Note that we still add "group" tree items individually since
4354 that gives us a nice progress indicator.
4356 While we're here, make sure we show the dialog before tapping packets.
4359 Change-Id: I8a182f4158d078cae5f42b8d1355414197f423e1
4360 Reviewed-on: https://code.wireshark.org/review/10000
4361 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4362 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4363 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4366 Author: Stig Bjørlykke <stig@bjorlykke.org>
4367 Date: Wed Aug 12 15:21:46 2015 +0200
4369 Lua: Moved deregister out of wslua_cleanup
4371 Change-Id: Ia43aa0e5f09400ef9923288b362256094a1241b8
4372 Reviewed-on: https://code.wireshark.org/review/9998
4373 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4376 Author: Stig Bjørlykke <stig@bjorlykke.org>
4377 Date: Wed Aug 12 14:51:29 2015 +0200
4379 Initialize is_reloading_lua at startup
4381 Change-Id: I211e0f4b86cff1c311d4ae67cbb47de14846144f
4382 Reviewed-on: https://code.wireshark.org/review/9997
4383 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4386 Author: Stig Bjørlykke <stig@bjorlykke.org>
4387 Date: Wed Aug 12 14:07:24 2015 +0200
4389 Added guards for deregistered fields
4391 This is functions used when redissecting after a Lua plugins reload.
4393 Change-Id: Ida14526faec1992006938a6732ee894ac83c2d12
4394 Reviewed-on: https://code.wireshark.org/review/9995
4395 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4398 Author: AndersBroman <anders.broman@ericsson.com>
4399 Date: Wed Aug 12 13:24:06 2015 +0200
4403 Change-Id: Iab59ba51700b018337552018c76e30dcbd41f3f6
4404 Reviewed-on: https://code.wireshark.org/review/9993
4405 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4408 Author: AndersBroman <anders.broman@ericsson.com>
4409 Date: Wed Aug 12 10:00:01 2015 +0200
4411 [GTP] Direct Tunnel Flags 7.7.81 is currently specified with one data
4414 Change-Id: Iab7917b23e6be03f63a92ef0aaf0814c9cbea2c3
4415 Reviewed-on: https://code.wireshark.org/review/9992
4416 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4419 Author: Michael Mann <mmann78@netscape.net>
4420 Date: Mon Aug 10 19:28:54 2015 -0400
4422 Eliminate proto_tree_add_text from some dissectors.
4424 Change-Id: I7a7778802c442b254626a7676cb74ca2855fa65e
4425 Reviewed-on: https://code.wireshark.org/review/9977
4426 Reviewed-by: Michael Mann <mmann78@netscape.net>
4427 Petri-Dish: Michael Mann <mmann78@netscape.net>
4428 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4429 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4432 Author: Guy Harris <guy@alum.mit.edu>
4433 Date: Tue Aug 11 22:42:26 2015 -0700
4435 Some further questions, asked in comments.
4437 Change-Id: I41c7918b7396934c651fb957d3b61db0c7a19527
4438 Reviewed-on: https://code.wireshark.org/review/9990
4439 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4442 Author: Guy Harris <guy@alum.mit.edu>
4443 Date: Tue Aug 11 19:00:26 2015 -0700
4445 Clean up the file header description.
4447 Change-Id: I4928f99cdc2b8fc2a3aef648b613ce0b93ed3563
4448 Reviewed-on: https://code.wireshark.org/review/9989
4449 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4452 Author: Guy Harris <guy@alum.mit.edu>
4453 Date: Tue Aug 11 18:38:08 2015 -0700
4457 Change-Id: I4b0b4bb31901208e09a535ef922e134116309531
4458 Reviewed-on: https://code.wireshark.org/review/9988
4459 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4462 Author: Guy Harris <guy@alum.mit.edu>
4463 Date: Tue Aug 11 18:32:18 2015 -0700
4465 Document Colasoft Capsa file support.
4467 Change-Id: I89374413f3e08e2a35923b8bd4c128b3c659158a
4468 Reviewed-on: https://code.wireshark.org/review/9987
4469 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4472 Author: Guy Harris <guy@alum.mit.edu>
4473 Date: Tue Aug 11 18:27:10 2015 -0700
4475 It looks as if the origin of the time stamps is the UN*X epoch.
4477 If we assume that, the time stamps of the sample captures on the
4478 Colasoft site are in the range 2000-2014, and the HTTP time stamps in
4479 the HTTP capture from there are close to the packet time stamps.
4481 Change-Id: Id0e29c03dc8ada40f1040b95f169b4f3a8954a0f
4482 Reviewed-on: https://code.wireshark.org/review/9986
4483 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4486 Author: Martin Kaiser <wireshark@kaiser.cx>
4487 Date: Tue Aug 11 21:57:11 2015 +0200
4489 [Qt Expert Info dialogue] remove our tap listener when the dialogue is destroyed
4491 if we don't do this, there'll be a dangling tap listener and we'll see a
4492 crash when its reset method is called
4494 this can be triggered by opening another expert info dialogue, this will
4495 invoke cf_retap_packets() and reset_tap_listeners() which in turn calls
4496 the reset method of each registered tap listener
4499 Change-Id: I8fc13351666c875e1a3641f31bada8e80d167ab2
4500 Reviewed-on: https://code.wireshark.org/review/9979
4501 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
4502 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4505 Author: Stig Bjørlykke <stig@bjorlykke.org>
4506 Date: Tue Aug 11 22:04:58 2015 +0200
4508 Lua: Remove unneeded call in wslua_cleanup
4510 Change-Id: I0cda00001b40e5951d680d72dbc8043cbe8b9309
4511 Reviewed-on: https://code.wireshark.org/review/9980
4512 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4515 Author: Stig Bjørlykke <stig@bjorlykke.org>
4516 Date: Tue Aug 11 21:52:32 2015 +0200
4518 wmem: Fix wmem_tree_remove_string
4520 Always set is_removed when insert data in a node.
4522 Change-Id: I8fb50932a369e3f4fe8a1f743462683fff705cc2
4523 Reviewed-on: https://code.wireshark.org/review/9978
4524 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4527 Author: Guy Harris <guy@alum.mit.edu>
4528 Date: Tue Aug 11 12:16:23 2015 -0700
4530 Sort dump_open_table_base[] in the right order.
4532 As the comment says, "Entries must be sorted by
4533 WTAP_FILE_TYPE_SUBTYPE_xxx values in ascending order." If they're not,
4534 the file type to file type string routines don't give the right answer.
4536 Change-Id: I06afe7bb98cb36c54ddc831113bb632598ab2eb0
4537 Reviewed-on: https://code.wireshark.org/review/9975
4538 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4541 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4542 Date: Sat Aug 8 19:11:20 2015 +0200
4544 H225: fix indent (use 2 spaces) and add modelines info
4546 Change-Id: Ibe4cf8d004c6c94f745e5c620100af9483fa6a31
4547 Reviewed-on: https://code.wireshark.org/review/9934
4548 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4551 Author: Stig Bjørlykke <stig@bjorlykke.org>
4552 Date: Tue Aug 11 16:11:46 2015 +0200
4554 wmem: Mark removed strings with is_removed
4556 This will allow integer value 0 again.
4558 Change-Id: Ibfa4249ea8b887971d3b3214ad9e4d095d20d155
4559 Reviewed-on: https://code.wireshark.org/review/9973
4560 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4563 Author: Stig Bjørlykke <stig@bjorlykke.org>
4564 Date: Tue Aug 11 14:08:08 2015 +0200
4566 Added Reload Lua plugins.
4568 This is initial support for reloading Lua plugins without
4569 restarting the application.
4572 - Deregister FileHandlers
4573 - Support deregister ProtoField with existing abbrev (same_name_hfinfo)
4574 - Add a progress dialog when reloading many plugins
4575 - Search for memory leakages in wslua functions
4577 Change-Id: I48870d8741251705ca15ffe1068613fcb0cb18c1
4578 Reviewed-on: https://code.wireshark.org/review/5028
4579 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
4582 Author: AndersBroman <anders.broman@ericsson.com>
4583 Date: Tue Aug 11 13:52:34 2015 +0200
4585 [SMCR] Minimum 4 bytes is required to perform the heuristic check.
4587 Change-Id: I29426147cb1443af3c9cc9dc1b60beabe9a94277
4588 Reviewed-on: https://code.wireshark.org/review/9972
4589 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4592 Author: AndersBroman <anders.broman@ericsson.com>
4593 Date: Tue Aug 11 13:32:41 2015 +0200
4595 [Diameter] Add expert info to subdissection of 3GPP AVP:s
4597 Change-Id: Ic2ec0696f1f6b8bb918dd04aa898dccdb8b90ece
4598 Reviewed-on: https://code.wireshark.org/review/9971
4599 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4602 Author: AndersBroman <anders.broman@ericsson.com>
4603 Date: Tue Aug 11 13:06:40 2015 +0200
4605 [ENEA LINX over TCP] Make the TCP port registration a preference defalted
4608 Change-Id: I837bf8ac9d5724dd485f0bc62f3fe32bedd3eb0e
4609 Reviewed-on: https://code.wireshark.org/review/9970
4610 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4613 Author: AndersBroman <anders.broman@ericsson.com>
4614 Date: Tue Aug 11 11:08:20 2015 +0200
4616 [GIOP] A GIOP message can have size = 0 (CloseConnection)
4618 Change-Id: I1feb6135c79191aa3ac7f36bbc969e6b36314107
4619 Reviewed-on: https://code.wireshark.org/review/9969
4620 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4623 Author: Martin Kaiser <wireshark@kaiser.cx>
4624 Date: Mon Aug 10 23:09:16 2015 +0200
4626 zbee-nwk-gp: fix a memory leak when keys are defined in the preferences
4628 ==5932== 33 (32 direct, 1 indirect) bytes in 1 blocks are definitely lost in loss record 2,124 of 4,121
4629 ==5932== at 0x4C28BED: malloc (vg_replace_malloc.c:263)
4630 ==5932== by 0xA024F30: g_malloc (gmem.c:159)
4631 ==5932== by 0xA03A9E5: g_memdup (gstrfuncs.c:384)
4632 ==5932== by 0x70754D2: gp_init_zbee_security (packet-zbee-nwk-gp.c:1459)
4633 ==5932== by 0xA03A78C: g_slist_foreach (gslist.c:840)
4634 ==5932== by 0x67E867C: init_dissection (packet.c:249)
4635 ==5932== by 0x67DC202: epan_new (epan.c:160)
4636 ==5932== by 0x414B16: cf_open (tshark.c:2464)
4637 ==5932== by 0x40CF8A: main (tshark.c:2169)
4639 Change-Id: I7c0ce0717957525ca18eb4888ed3389debc89a49
4640 Reviewed-on: https://code.wireshark.org/review/9967
4641 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
4642 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4643 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4646 Author: Martin Kaiser <wireshark@kaiser.cx>
4647 Date: Mon Aug 10 22:41:13 2015 +0200
4649 zigbee: remove some more if (tree) checks
4651 Change-Id: I81b46ec7d9d919ff2779d1005063e9ef6c92e097
4652 Reviewed-on: https://code.wireshark.org/review/9966
4653 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
4656 Author: Martin Kaiser <wireshark@kaiser.cx>
4657 Date: Mon Aug 10 22:27:58 2015 +0200
4659 remove some unnecessary if (tree) checks
4661 Change-Id: Ib0f4cc47ede7b840cba38ecad04bd17bb6bccd55
4662 Reviewed-on: https://code.wireshark.org/review/9965
4663 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
4666 Author: AndersBroman <anders.broman@ericsson.com>
4667 Date: Mon Aug 10 13:19:25 2015 +0200
4669 Try to fix the build bou by copying tha cast made in glib.
4671 Change-Id: I6da06b8e6ae272b940ef4ee47ce6b253bf9f3699
4672 Reviewed-on: https://code.wireshark.org/review/9961
4673 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4676 Author: Pascal Quantin <pascal.quantin@gmail.com>
4677 Date: Fri Aug 7 16:29:50 2015 +0200
4679 editcap: fix -T <encapsulation type> option when output format is pcapng
4681 Right now the output encapsulation type is ignored if the output (default) format is set to pcapng.
4683 Change-Id: Ibffaaed5979bf63ed4e3fa3b1f859a82b401d80b
4684 Reviewed-on: https://code.wireshark.org/review/9911
4685 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
4686 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4687 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4690 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4691 Date: Sat Aug 8 16:52:38 2015 +0200
4693 GSM (a_common): fix indent (replace tab by 8 spaces)
4695 Change-Id: Id1d6bfcb04ac75d767fe6f09454dc8235de7bc75
4696 Reviewed-on: https://code.wireshark.org/review/9928
4697 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4700 Author: AndersBroman <anders.broman@ericsson.com>
4701 Date: Mon Aug 10 10:26:16 2015 +0200
4703 g_slist_free_full () does not exist until GLIB 2.28
4705 Change-Id: I81df5b4dbe1916eca51cdb72199de7a90471bd07
4706 Reviewed-on: https://code.wireshark.org/review/9960
4707 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4710 Author: Guy Harris <guy@alum.mit.edu>
4711 Date: Mon Aug 10 00:53:34 2015 -0700
4713 Get rid of trailing white space.
4715 Change-Id: I3c0091612bdd518f749abbfbefbd0e2097b8c18b
4716 Reviewed-on: https://code.wireshark.org/review/9958
4717 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4720 Author: Guy Harris <guy@alum.mit.edu>
4721 Date: Mon Aug 10 00:30:33 2015 -0700
4723 Don't try to decrypt the payload if it was cut short by the snapshot length.
4725 It's not clear that the decryption code can handle an incomplete
4726 payload. If it can, please fix this (bear in mind that you won't have
4727 all the MIC, and may not have *any* of the MIC, so...).
4730 Change-Id: Ie863ddc5c4aa7fbf6cde317823a413d226a41c0d
4731 Reviewed-on: https://code.wireshark.org/review/9954
4732 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4735 Author: Guy Harris <guy@alum.mit.edu>
4736 Date: Sun Aug 9 23:55:55 2015 -0700
4738 Use the reported length where appropriate.
4740 Use the captured length to know how much data to decrypt. Use the
4741 reported length to determine whether we have a null payload and to se
4742 the reported length of the decrypted payload and of tvbuffs for the
4743 un-decrypted payload.
4746 Change-Id: I4395c5a48c16110fcf31b611b99749c61000d489
4747 Reviewed-on: https://code.wireshark.org/review/9953
4748 Reviewed-by: Guy Harris <guy@alum.mit.edu>
4751 Author: Martin Kaiser <wireshark@kaiser.cx>
4752 Date: Sun Aug 9 18:06:47 2015 +0200
4754 zigbee: fix two memory leaks
4756 ==17992== 4 bytes in 1 blocks are definitely lost in loss record 68 of 4,102
4757 ==17992== at 0x4C28BED: malloc (vg_replace_malloc.c:263)
4758 ==17992== by 0x9FB2F30: g_malloc (gmem.c:159)
4759 ==17992== by 0x9FC89E5: g_memdup (gstrfuncs.c:384)
4760 ==17992== by 0x703F977: dissect_zbee_aps (packet-zbee-aps.c:1300)
4761 ==17992== by 0x67B4F1E: call_dissector_through_handle (packet.c:618)
4763 ==17992== 8 bytes in 1 blocks are definitely lost in loss record 580 of 4,102
4764 ==17992== at 0x4C272B8: calloc (vg_replace_malloc.c:566)
4765 ==17992== by 0x9FB2F88: g_malloc0 (gmem.c:189)
4766 ==17992== by 0x703F962: dissect_zbee_aps (packet-zbee-aps.c:1299)
4767 ==17992== by 0x67B4F1E: call_dissector_through_handle (packet.c:618)
4769 second version that uses glib memory routines and does not mix
4770 g_hash_table and wmem
4772 remove an obsolete comment and an unnecessary return; while at it
4774 Change-Id: I2e92db0613f01b6c3009e8ad82ceb65a87cba12e
4775 Reviewed-on: https://code.wireshark.org/review/9830
4776 Petri-Dish: Martin Kaiser <wireshark@kaiser.cx>
4777 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4778 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4781 Author: Michael Mann <mmann78@netscape.net>
4782 Date: Sun Aug 9 18:33:30 2015 -0400
4784 Eliminate proto_tree_add_text from packet-wbxml.c
4786 While I was at it, some (mostly) duplicate functionality allowed rearranging of functions to eliminate most forward declarations.
4788 Change-Id: I2d7027d336c391d81dfe81c7a1ebf0d56c0826b2
4789 Reviewed-on: https://code.wireshark.org/review/9951
4790 Reviewed-by: Michael Mann <mmann78@netscape.net>
4791 Petri-Dish: Michael Mann <mmann78@netscape.net>
4792 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4793 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4796 Author: João Valverde <joao.valverde@tecnico.ulisboa.pt>
4797 Date: Thu Aug 6 22:35:23 2015 +0100
4799 Cleanup variable name in dissect_frag6()
4801 Change-Id: Ib6bdea5dbc95b5221e41ca30c11288ff8c1dbb7f
4802 Reviewed-on: https://code.wireshark.org/review/9952
4803 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4806 Author: Martin Kaiser <wireshark@kaiser.cx>
4807 Date: Mon Aug 10 00:00:21 2015 +0200
4809 use the captured length as payload length for zigbee decryption
4811 this length is used for allocating a buffer and for crypto calculations
4812 we should use the bytes that were actually captured, not the reported
4815 the capture in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11389
4816 has one packet with a stupidly large reported length and a reasonable
4817 capture length (and one completely bogus packet) - this fix ensures that
4818 the decryption does not break for the former packet
4820 also, tvb_reported_length_remaining() does not return values < 0 any
4821 more, remove the check for this
4824 Change-Id: I42cb4526483160416b51e3cb72442148b5fac4f3
4825 Reviewed-on: https://code.wireshark.org/review/9950
4826 Reviewed-by: Anders Broman <a.broman58@gmail.com>
4829 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4830 Date: Sat Aug 8 16:55:15 2015 +0200
4832 H225: fix no previous prototype for 'h225_stat_init' [-Wmissing-prototypes]
4834 Change-Id: I945bbbb3b10258f22c60b04b19cf55671fc6ed94
4835 Reviewed-on: https://code.wireshark.org/review/9933
4836 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4839 Author: Bill Meier <wmeier@newsguy.com>
4840 Date: Sun Aug 9 14:55:27 2015 -0400
4842 [wiretap/nettrace_3gpp_32_423] Add editor modelines
4844 Change-Id: Ie2b9da2b3a08d18fc913a00cf076aa881a583552
4845 Reviewed-on: https://code.wireshark.org/review/9949
4846 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4849 Author: Bill Meier <wmeier@newsguy.com>
4850 Date: Sun Aug 9 14:16:22 2015 -0400
4852 [skinny] Add missing change to source (.in); Also do minor cleanup.
4854 packet-skinny.c is generated from packet-skinny.in and etc.
4855 So: Change committed in gceb8d95 to packet-skinny.c should really
4856 have been applied as well to packet-skinny.c.in.
4859 Remove a few unneeded initializers;
4860 Remove unneeded code in proto_reg_handoff_skinny();
4861 Replace a tab by spaces;
4862 Change editor tab-width specification to be 8 (not 2). No actual
4863 indentation change since tabs not used in the file.
4865 packet-skinny.c regenerated using 'cog'
4867 Change-Id: Ib3510c257e0b98bb7da8fae9aa010e134ec381cb
4868 Reviewed-on: https://code.wireshark.org/review/9948
4869 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4872 Author: Evan Huus <eapache@gmail.com>
4873 Date: Sun Aug 9 10:36:18 2015 -0400
4875 t124: kill evil global variables
4878 Change-Id: Ia4196ff693806dc1e20eae4075dda7dfe272c5b6
4879 Reviewed-on: https://code.wireshark.org/review/9941
4880 Petri-Dish: Evan Huus <eapache@gmail.com>
4881 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4882 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
4883 Reviewed-by: Evan Huus <eapache@gmail.com>
4886 Author: Martin Kaiser <wireshark@kaiser.cx>
4887 Date: Sun Aug 9 18:33:04 2015 +0200
4889 zigbee: remove a numer of unnecessary if (tree) checks
4891 Change-Id: Ifd0dcc220cfdd0809f2e7cf2fc54fc8bdeb987be
4892 Reviewed-on: https://code.wireshark.org/review/9947
4893 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
4896 Author: Bill Meier <wmeier@newsguy.com>
4897 Date: Sun Aug 9 12:20:54 2015 -0400
4899 Trivial: Convert 'tabs' indentation to '4 space' indentation
4901 Change-Id: If71dd8a04050ce11e37ad88ee862419313c06639
4902 Reviewed-on: https://code.wireshark.org/review/9946
4903 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4906 Author: Bill Meier <wmeier@newsguy.com>
4907 Date: Sun Aug 9 12:14:39 2015 -0400
4909 Trivial: Change editor-modelines tab-width specification from 4 to 8.
4911 [There were no actual indentation changes since since none of the files
4914 Change-Id: I92ff551e70274f459c466e1c1d449905e0e7dc92
4915 Reviewed-on: https://code.wireshark.org/review/9945
4916 Reviewed-by: Bill Meier <wmeier@newsguy.com>
4919 Author: Gerald Combs <gerald@zing.org>
4920 Date: Sun Aug 9 08:57:29 2015 -0700
4922 Switch the guides back to html output.
4924 DocBook's xhtml5 stylesheet output didn't render correctly in Firefox.
4926 This reverts commit dc09d18e8ecdc55de2361d8ff6d2b0bf36345a70.
4927 This reverts commit 62e56ad92a50c7dd58e83447207b8be0cc0bbb76.
4928 This reverts commit 53a80334bcb3ca40a5aaef504e2aca0f04bcc9f3.
4930 Change-Id: Iafcf18cfce25772146fc2e155728401fd105a44b
4931 Reviewed-on: https://code.wireshark.org/review/9944
4932 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4935 Author: Gerald Combs <gerald@wireshark.org>
4936 Date: Sun Aug 9 08:10:47 2015 -0700
4938 [Automatic update for 2015-08-09]
4940 Update manuf, services enterprise-numbers, translations, and other items.
4942 Change-Id: I14806e32e93b7f189ccc68834afa4645bda3e1aa
4943 Reviewed-on: https://code.wireshark.org/review/9942
4944 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4947 Author: Gerald Combs <gerald@zing.org>
4948 Date: Sat Aug 8 16:29:24 2015 -0700
4950 Reset the splash timer after processing events.
4952 Change-Id: Id71a3ac5e8f04df6a19e92021e47ea64728c2595
4953 Reviewed-on: https://code.wireshark.org/review/9936
4954 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4957 Author: Gerald Combs <gerald@zing.org>
4958 Date: Sat Aug 8 15:44:02 2015 -0700
4960 Generate DocBook conditionally.
4962 Add back a check when generating DocBook.
4964 Change-Id: I00679853d537f543db6f37a60ae4c46b3cce76e6
4965 Reviewed-on: https://code.wireshark.org/review/9935
4966 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4967 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4968 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4971 Author: Gerald Combs <gerald@wireshark.org>
4972 Date: Fri Aug 7 18:17:04 2015 -0700
4974 CMake: Try to fix generated docbook dependencies.
4976 Add custom {developer,user}_guide_docbook targets for docbook output. Make
4977 sure the HTML, PDF, and CHM outputs depend on their associated docbook
4978 target and not on the output .xml file. This keeps us from running a2x
4979 instances in parallel.
4981 Change-Id: I73b0db50ae92f62eb08ae284d498cdf2d697ac00
4982 Reviewed-on: https://code.wireshark.org/review/9920
4983 Petri-Dish: Gerald Combs <gerald@wireshark.org>
4984 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4985 Reviewed-by: Gerald Combs <gerald@wireshark.org>
4988 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
4989 Date: Sat Aug 8 16:50:17 2015 +0200
4991 GSM (a_common): fix no previous prototype for 'gsm_a_*_init' [-Wmissing-prototypes]
4993 Change-Id: I2990cb3432ad377cbed7039ad8fe15019eb7e7f5
4994 Reviewed-on: https://code.wireshark.org/review/9927
4995 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
4996 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
4997 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
4998 Reviewed-by: Michael Mann <mmann78@netscape.net>
5001 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5002 Date: Sat Aug 8 16:46:45 2015 +0200
5004 GSM (a_common): fix comma at end of enumerator list [-Wpedantic]
5006 Change-Id: I0ea06451861412b642d033a70e0a639aae753beb
5007 Reviewed-on: https://code.wireshark.org/review/9926
5008 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5009 Reviewed-by: Michael Mann <mmann78@netscape.net>
5012 Author: Guy Harris <guy@alum.mit.edu>
5013 Date: Sat Aug 8 10:04:47 2015 -0700
5017 Change-Id: I1fee679b4b0f582806b0e9302c3e404c0222cd6d
5018 Reviewed-on: https://code.wireshark.org/review/9930
5019 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5022 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5023 Date: Sat Aug 8 16:37:58 2015 +0200
5025 IEEE802.11: Fix typo
5029 Change-Id: I34700b3392bfd7e47e79cb2cad0f65a1046a26a2
5030 Reviewed-on: https://code.wireshark.org/review/9925
5031 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5034 Author: Michael Mann <mmann78@netscape.net>
5035 Date: Sat Aug 8 09:57:14 2015 -0400
5037 If SOCKS server doesnt't require authentication, then client should be ready for commands.
5040 Change-Id: I62c6d94923dcda2ef8297086faac7d7c4b85a3fb
5041 Reviewed-on: https://code.wireshark.org/review/9923
5042 Reviewed-by: Michael Mann <mmann78@netscape.net>
5043 Petri-Dish: Michael Mann <mmann78@netscape.net>
5044 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5045 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5048 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5049 Date: Sat Aug 8 16:10:48 2015 +0200
5051 NCP2222.py : fix generate indent (use 4 spaces)
5053 Change-Id: Ibe55260e837f0a839649675c08e1bf66d8bcdb52
5054 Reviewed-on: https://code.wireshark.org/review/9924
5055 Reviewed-by: Michael Mann <mmann78@netscape.net>
5058 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5059 Date: Sat Aug 8 13:20:52 2015 +0200
5061 NCP2222(.inc): fix indent (use 4 spaces)
5063 Change-Id: I8161423ae270f685c28003eac36adf15be83c5fd
5064 Reviewed-on: https://code.wireshark.org/review/9922
5065 Reviewed-by: Michael Mann <mmann78@netscape.net>
5068 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5069 Date: Sat Aug 8 13:08:57 2015 +0200
5071 GTPv2: fix indent (use 4 spaces)
5073 Change-Id: I7836360ae4fe67098776911a496ecc969d3e093d
5074 Reviewed-on: https://code.wireshark.org/review/9921
5075 Reviewed-by: Michael Mann <mmann78@netscape.net>
5078 Author: Gerald Combs <gerald@wireshark.org>
5079 Date: Fri Aug 7 15:38:34 2015 -0700
5081 Add a missing dependency.
5083 Change-Id: I2c9814419882f9bee30e70697d6f284393f275a9
5084 Reviewed-on: https://code.wireshark.org/review/9919
5085 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5088 Author: Gerald Combs <gerald@wireshark.org>
5089 Date: Fri Aug 7 15:08:22 2015 -0700
5091 Rework CMake dependendencies in the docbook directory.
5093 Create dependencies explicitly using add_dependencies. Otherwise MSBuild
5094 only builds one output per run.
5096 Change-Id: If42605d7e7df499cf4d4b70336d97ac6d37e8ba6
5097 Reviewed-on: https://code.wireshark.org/review/9918
5098 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5101 Author: Guy Harris <guy@alum.mit.edu>
5102 Date: Fri Aug 7 15:27:11 2015 -0700
5104 Avoid (unlikely) NRB record size overflows.
5106 If a host name is *so* long that an entry for it won't fit in a
5107 65535-byte Name Resolution Block record, ignore the entry for that host.
5109 Use more appropriate data types (guint32 for sizes that are 32-bit
5110 unsigned integers, guint16 for the host name length as it'd better fit
5113 Clean up some comments.
5115 Remove a _U_ that's applied to a variable that *is* used.
5117 Change-Id: I153d5aa885105149c62a5e5d2b78b54cf6ed7b4e
5118 Reviewed-on: https://code.wireshark.org/review/9917
5119 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5122 Author: Timothy Geiser <slimshady007@inbox.lv>
5123 Date: Wed Aug 5 15:19:48 2015 -0400
5125 Add SHA2 algos to certificate dissection in SSL
5127 Change-Id: If1315496d231e5c8efc44b9235ec8ffb3ce9d8a9
5128 Reviewed-on: https://code.wireshark.org/review/9880
5129 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5130 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5131 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5134 Author: Gerald Combs <gerald@wireshark.org>
5135 Date: Fri Aug 7 12:37:33 2015 -0700
5137 Fixup the Qt splash overlay progress calculations.
5139 Fix a couple of issues in the way we calculate the splash overlay
5142 Avoid unnecessary repaints.
5144 Change-Id: I1f4800b2c2836b67ca9ff3d6d24af150f4379ba9
5145 Reviewed-on: https://code.wireshark.org/review/9916
5146 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5149 Author: Gerald Combs <gerald@wireshark.org>
5150 Date: Fri Aug 7 10:19:22 2015 -0700
5152 More casting issues with older versions of GLib.
5156 packet-btl2cap.c: In function 'btl2cap_cid_value':
5157 packet-btl2cap.c:425: warning: cast to pointer from integer of different size
5158 packet-btl2cap.c: In function 'btl2cap_psm_value':
5159 packet-btl2cap.c:448: warning: cast to pointer from integer of different size
5161 packet-btrfcomm.c: In function 'btrfcomm_directed_channel_value':
5162 packet-btrfcomm.c:287: warning: cast to pointer from integer of different size
5164 packet-btobex.c: In function 'btobex_profile_value':
5165 packet-btobex.c:1134: warning: cast to pointer from integer of different size
5167 on the 32-bit OS X builder.
5169 Change-Id: Ieb2fe6c31fdad0cf776c24bada7a6a83e8aa91ec
5170 Reviewed-on: https://code.wireshark.org/review/9915
5171 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5174 Author: Gerald Combs <gerald@wireshark.org>
5175 Date: Fri Aug 7 08:39:09 2015 -0700
5177 Switch the floats in stat_tap table items to doubles.
5179 Use doubles instead of floats in stat_tap_table_item_type. This should
5180 make stat taps easier to use with a lot of our API (e.g. nstime) along
5181 with Qt and the C math library.
5183 This reverts commit 5bbb6ff5e43511ddc57b0b771f3d60da1eb82c02.
5185 Change-Id: I113b44fb944a883cde016b7a8961597658be4c0a
5186 Reviewed-on: https://code.wireshark.org/review/9912
5187 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5188 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
5191 Author: Stig Bjørlykke <stig@bjorlykke.org>
5192 Date: Fri Aug 7 14:55:50 2015 +0200
5194 Lua: Count Lua plugins in splash screen
5196 This will avoid slow startup when having many Lua plugins.
5198 Change-Id: I67b5f38108a5c500682bc727734375da5fa762c8
5199 Reviewed-on: https://code.wireshark.org/review/9910
5200 Petri-Dish: Stig Bjørlykke <stig@bjorlykke.org>
5201 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5202 Reviewed-by: Stig Bjørlykke <stig@bjorlykke.org>
5205 Author: Gerald Combs <gerald@wireshark.org>
5206 Date: Fri Aug 7 09:10:39 2015 -0700
5208 Try to fix casting issues with older versions of GLib.
5212 packet-btatt.c: In function 'btatt_handle_value':
5213 packet-btatt.c:1420: warning: cast to pointer from integer of different size
5214 packet-btatt.c: In function 'btatt_uuid16_value':
5215 packet-btatt.c:1443: warning: cast to pointer from integer of different size
5217 on the 32-bit OS X builder.
5219 Change-Id: I02884c02e7f7f5f7b50da122127fa96c41c3603a
5220 Reviewed-on: https://code.wireshark.org/review/9913
5221 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5224 Author: Bill Meier <wmeier@newsguy.com>
5225 Date: Thu Aug 6 17:44:42 2015 -0400
5227 [ieee80211] Rework QoS Capability and QoS info code.
5230 - Replace/remove much of 'dissect_qos_capability()' code to use
5231 existing 'fixed field' code to dissect QoS_Info field.
5232 Note: Much of the code added in g40d6131 to dissect the QoS Info
5233 field duplicated already existing (but unused) "fixed field"
5235 - Rework some QoS Info field filter names, variable names and
5236 value-strings to better match the text used in 802.11-2012.
5238 - Rename 'dissect_qos_info()' to 'dissect_wme_qos_info()' to
5239 reflect the fact that this code is only for the (now preumably obsolete)
5240 original WME(WMM) specification for the QoS Info field.
5242 Change-Id: Id89780dfe60b2e4c63332bdb946cc29c67b5127a
5243 Reviewed-on: https://code.wireshark.org/review/9903
5244 Petri-Dish: Bill Meier <wmeier@newsguy.com>
5245 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5246 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5247 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5250 Author: AndersBroman <anders.broman@ericsson.com>
5251 Date: Fri Aug 7 14:50:02 2015 +0200
5253 [GTPv2] Mark a parameter as unused.
5255 Change-Id: I37c983d756f23469e4cf1abd31b9c591f5612542
5256 Reviewed-on: https://code.wireshark.org/review/9909
5257 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5260 Author: AndersBroman <anders.broman@ericsson.com>
5261 Date: Fri Aug 7 14:19:30 2015 +0200
5263 Try to fix packet-rpc.c:3909: warning: implicit conversion shortens 64-bit value into a 32-bit value
5265 Change-Id: I8962f93662047d01ef71ba9689b338d095f31300
5266 Reviewed-on: https://code.wireshark.org/review/9908
5267 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5270 Author: AndersBroman <anders.broman@ericsson.com>
5271 Date: Fri Aug 7 14:04:52 2015 +0200
5273 [GTPv2] Dissect IE MM Context for CS to PS SRVCC, update value strings.
5276 Change-Id: I5a845e40fcbd4e06dec60c64edca9e8fea1459e1
5277 Reviewed-on: https://code.wireshark.org/review/9907
5278 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5281 Author: Gerald Combs <gerald@wireshark.org>
5282 Date: Thu Aug 6 10:56:22 2015 -0700
5284 Add ONC RPC program stats.
5286 Convert ONC RPC program stats to the stat_tap API.
5288 Add a "user_data" member to the stat_tap_table_item_type struct.
5290 Change-Id: I5cbf000a447ff93d30fa7f098124bdcbc34f2935
5291 Reviewed-on: https://code.wireshark.org/review/9904
5292 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5293 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5296 Author: Jan-Hendrik Bolte <jabolte@uos.de>
5297 Date: Mon Jul 20 14:37:49 2015 +0200
5299 Add dissector for MQTT-SN v1.2
5302 Change-Id: I5d961b19132a9904080e9494467826d15659c54e
5303 Reviewed-on: https://code.wireshark.org/review/9711
5304 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5305 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5306 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5307 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5310 Author: Michal Labedzki <michal.labedzki@tieto.com>
5311 Date: Wed Aug 5 17:30:47 2015 +0200
5313 androiddump: Try to make MVS14.0 happy
5315 I guess using glib's gssize instead of ssize_t should be enough for:
5317 extcap/androiddump.c(736): error C2220: warning treated as error - no 'object' f
5319 extcap/androiddump.c(736): warning C4477: 'fprintf' : format string '%I64i' requ
5320 ires an argument of type '__int64', but variadic argument 3 has type 'ssize_t'
5321 extcap/androiddump.c(736): note: to simplify migration, consider the temporary
5322 use of /Wv:18 flag with the version of the compiler with which you used to
5323 build without warnings
5324 extcap/androiddump.c(736): note: consider using '%i' in the format string
5325 extcap/androiddump.c(736): note: consider using '%I32i' in the format string
5327 Change-Id: I1030694aed61d413be1aad54531f99db45e99c9d
5328 Reviewed-on: https://code.wireshark.org/review/9876
5329 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5330 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5331 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5334 Author: Bill Meier <wmeier@newsguy.com>
5335 Date: Thu Aug 6 21:47:37 2015 -0400
5337 [ieee80211] Change one ENC_LITTLE_ENDIAN MAC address to ENC_NA; byte order doesn't
5340 Change-Id: I4b0fcfe5d970877d7f8453e6c6f8c48ee69c2e38
5341 Reviewed-on: https://code.wireshark.org/review/9905
5342 Reviewed-by: Bill Meier <wmeier@newsguy.com>
5345 Author: Gerald Combs <gerald@wireshark.org>
5346 Date: Thu Aug 6 11:23:55 2015 -0700
5348 Fixup stat_tap table freeing.
5350 As it turns out we *do* need to free table elements. We also need to
5351 free the tables themselves and clear the table array. Do so.
5353 Change-Id: Ic1c81388eac8f47f74caea0169c79685a83aaff9
5354 Reviewed-on: https://code.wireshark.org/review/9901
5355 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5356 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5359 Author: Gerald Combs <gerald@wireshark.org>
5360 Date: Thu Aug 6 12:31:21 2015 -0700
5362 Add an elide mode preference for the Qt packet list.
5364 Change-Id: I081cc1e9b2a0eea7f0a3ef1157561c50beb4c4db
5365 Reviewed-on: https://code.wireshark.org/review/9902
5366 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5367 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5368 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5371 Author: Gerald Combs <gerald@wireshark.org>
5372 Date: Thu Aug 6 08:39:22 2015 -0700
5374 Use int_to_qstring in a few more places.
5376 Change-Id: Id324fe21f436a233088d106553db2ed6f6e410ac
5377 Reviewed-on: https://code.wireshark.org/review/9899
5378 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5379 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5380 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5383 Author: AndersBroman <anders.broman@ericsson.com>
5384 Date: Thu Aug 6 13:30:59 2015 +0200
5386 [MSVC 2015]Once agin revert tho original, now as a separate patch.
5388 Change-Id: If25a1e4ced74d88c87def010b9d8032b5d870307
5389 Reviewed-on: https://code.wireshark.org/review/9898
5390 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5393 Author: AndersBroman <anders.broman@ericsson.com>
5394 Date: Thu Aug 6 13:21:26 2015 +0200
5396 include <stdlib.h> to make windows build boot happy.
5398 Change-Id: I7a8b259698fdca0707464929a77c0b320f6a19f1
5399 Reviewed-on: https://code.wireshark.org/review/9897
5400 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5403 Author: AndersBroman <anders.broman@ericsson.com>
5404 Date: Thu Aug 6 13:01:45 2015 +0200
5406 Fix pcapng.c:3788: warning: implicit conversion shortens 64-bit value into a 32-bit value
5408 Change-Id: Ie796cee755470bea0416b46ff8ff6a94cd8d93d3
5409 Reviewed-on: https://code.wireshark.org/review/9896
5410 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5413 Author: Michal Labedzki <michal.labedzki@tieto.com>
5414 Date: Thu Aug 6 10:59:51 2015 +0200
5416 Bluetooth: Fix some MSVC2015 warnings/errors
5418 packet-btobex.c(1134): error C2220: warning treated as error - no 'object' file generated
5419 packet-btobex.c(1134): warning C4312: 'type cast': conversion from 'gulong' to ' gpointer' of greater size
5420 packet-btatt.c(1420): error C2220: warning treated as error - no 'object' file generated
5421 packet-btatt.c(1420): warning C4312: 'type cast': conversion from 'gulong' to 'gpointer' of greater size
5422 packet-btatt.c(1443): warning C4312: 'type cast': conversion from 'gulong' to 'gpointer' of greater size
5423 packet-btl2cap.c(425): error C2220: warning treated as error - no 'object' file generated
5424 packet-btl2cap.c(425): warning C4312: 'type cast': conversion from 'gulong' to 'gpointer' of greater size
5425 packet-btl2cap.c(448): warning C4312: 'type cast': conversion from 'gulong' to 'gpointer' of greater size
5426 packet-btrfcomm.c(287): error C2220: warning treated as error - no 'object' file generated
5427 packet-btrfcomm.c(287): warning C4312: 'type cast': conversion from 'gulong' to 'gpointer' of greater size
5429 Change-Id: Ie5b4fd1c47725b966f9b98d9480c1858b553efff
5430 Reviewed-on: https://code.wireshark.org/review/9894
5431 Petri-Dish: Michal Labedzki <michal.labedzki@tieto.com>
5432 Reviewed-by: Michal Labedzki <michal.labedzki@tieto.com>
5433 Tested-by: Michal Labedzki <michal.labedzki@tieto.com>
5436 Author: Gerald Combs <gerald@wireshark.org>
5437 Date: Wed Aug 5 20:44:09 2015 -0700
5441 Change-Id: I04c4a06f8d2db4d9ac1a09fea25d4f587c1f1fc1
5442 Reviewed-on: https://code.wireshark.org/review/9893
5443 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5446 Author: Hadriel Kaplan <hadrielk@yahoo.com>
5447 Date: Mon Jul 20 10:35:06 2015 -0400
5449 Pcapng: support Name Resolution Block options
5451 Make pcapng decode options in an NRB during read, and store the comment
5452 option, and write it back out as well. Also make it handle plugin handlers
5453 for unknown options in received NRB(s).
5455 Change-Id: I81863ef8d85cb1c8b5ba6673ba0e562efe77714f
5456 Reviewed-on: https://code.wireshark.org/review/9723
5457 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
5458 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5459 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5462 Author: Guy Harris <guy@alum.mit.edu>
5463 Date: Wed Aug 5 20:12:31 2015 -0700
5465 Add ui_gsm_map_summary_dialog.h so it goes into the source tarball.
5467 Change-Id: Ib0780e5ba62d069d2b41ef7ac7da513981660c7f
5468 Reviewed-on: https://code.wireshark.org/review/9892
5469 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5472 Author: Guy Harris <guy@alum.mit.edu>
5473 Date: Wed Aug 5 19:45:12 2015 -0700
5475 Fix some encoding arguments.
5477 802.11 is overwhelmingly little-endian; change all 1-byte fields that
5478 were ENC_BIG_ENDIAN to ENC_LITTLE_ENDIAN.
5480 Change one ENC_BIG_ENDIAN MAC address to ENC_NA; byte order doesn't
5483 The remaining ENC_BIG_ENDIANs should be checked.
5485 Change-Id: I3dc51a5555b99c25dce0d3b7f3be4c441b13d1a3
5486 Reviewed-on: https://code.wireshark.org/review/9890
5487 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5490 Author: Guy Harris <guy@alum.mit.edu>
5491 Date: Wed Aug 5 19:08:36 2015 -0700
5493 Fix a bunch of typoes in variable and field names.
5495 Fix spelling, get rid of period at end of some field names.
5497 Change-Id: I1963cdc92657dca8708133796f8835bdffee0c47
5498 Reviewed-on: https://code.wireshark.org/review/9888
5499 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5502 Author: Gerald Combs <gerald@wireshark.org>
5503 Date: Tue Aug 4 17:42:53 2015 -0700
5505 Convert the GSM MAP stats to new "generic stat API".
5507 Convert both the MAP statistics and summary. As with the GSM A stats
5508 this are mostly untested.
5510 Change-Id: Ibd3a7346b09d1401e78724c0197ec2a38deb97a3
5511 Reviewed-on: https://code.wireshark.org/review/9883
5512 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5513 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5516 Author: Gerald Combs <gerald@wireshark.org>
5517 Date: Wed Aug 5 17:03:03 2015 -0700
5519 Add proper base prefixes in display filter expressions.
5521 When the user selects an enum in the display filter expression dialog
5522 make sure we add the proper base prefix
5524 Add a Qt UI convenience routine for formatting integers. Because
5525 deprecating QString::sprintf was a well-thought-out decision that will
5526 be regarded highly for decades to come.
5528 Fix search visibility while we're here.
5531 Change-Id: I1368bc8f464983793bdc90760cf3b7c18b6bd859
5532 Reviewed-on: https://code.wireshark.org/review/9885
5533 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5536 Author: Guy Harris <guy@alum.mit.edu>
5537 Date: Wed Aug 5 18:23:53 2015 -0700
5539 Cleanup a bunch of 802.11ad stuff.
5541 Make all the multi-byte fields, except for OUIs, little-endian -
5542 including fields that contain bitfields. Make the bits in the bitfields
5543 little-endian as well.
5545 For the "number of taps" bitfields, interpret the values.
5547 Fix a typo ("pseduo" -> "pseudo").
5549 The length of an OCT MMPDU is 16 bits, not 8 bits, and it's not a text
5550 string, it's an octet string.
5552 The Beacon Interval Control is 48 bits, not 64 bits.
5554 Handle the beam refinement UI as a 2-byte field that overlaps with a
5555 4-byte field - *none* of the bitfields align on nice 8-bit boundaries,
5556 so that's the best we can do.
5559 Change-Id: Ib00ad030ecb33cf676bec23c05b15a4211c75c07
5560 Reviewed-on: https://code.wireshark.org/review/9886
5561 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5564 Author: Gerald Combs <gerald@wireshark.org>
5565 Date: Wed Aug 5 16:19:24 2015 -0700
5567 Output xhtml guides everywhere.
5569 Update Autotools / Nmake to generate xhtml5 user and developer guides.
5571 Change-Id: I5024151aecaee62ea6d8469807fabda552d3f663
5572 Reviewed-on: https://code.wireshark.org/review/9884
5573 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5576 Author: Roland Knall <roland.knall@br-automation.com>
5577 Date: Wed Aug 5 09:36:20 2015 +0200
5579 epl: Fix Payload sub-dissection
5581 Current implementation gives all remaining data to sub-dissector.
5582 This is not correct, as with "Write Multiple by Index" the data
5583 given includes the following indeces and their datasets
5585 Change-Id: I5343bf61431a7b5507b51f53f0de8c6e3dc72cf1
5586 Reviewed-on: https://code.wireshark.org/review/9870
5587 Reviewed-by: Roland Knall <rknall@gmail.com>
5588 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5589 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5590 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5593 Author: Guy Harris <guy@alum.mit.edu>
5594 Date: Wed Aug 5 13:00:38 2015 -0700
5596 Clean up some fields.
5598 The "LEN" field is the "length of the MAC frame", in bytes; confusingly,
5599 it includes the extended header length, but not the fixed-length part of
5600 the header (including the FCS), so it's not the "length after HCS".
5602 Rename it to "docsis.len", as it's always LEN, not SID; there's a
5603 separate field for the SID.
5605 Rename the Extended Header Length field to docsis.ehdrlen, and the
5606 Number of Concatenated Frames to docsis.concat_cnt, so that different
5607 uses of the "MACPARM" part of the header are flagged differently.
5609 Update some comments while we're at it.
5611 Change-Id: Ib7c4a0cda65cef25dcaf0051b3de89758ef4c29c
5612 Reviewed-on: https://code.wireshark.org/review/9881
5613 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5616 Author: Roland Knall <roland.knall@br-automation.com>
5617 Date: Wed Aug 5 09:39:08 2015 +0200
5619 openSAFETY: Better display of packet info
5621 If multiple packets of openSAFETY are present in a single network
5622 packet, searching for the packet needed is complicated. This patch
5623 increases the information along the same lines as the eth and frame
5626 Change-Id: Id3d237135cfadb35c839208749aeeb1652b29830
5627 Reviewed-on: https://code.wireshark.org/review/9871
5628 Reviewed-by: Roland Knall <rknall@gmail.com>
5629 Reviewed-by: Michael Mann <mmann78@netscape.net>
5630 Petri-Dish: Michael Mann <mmann78@netscape.net>
5631 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5632 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5635 Author: Gerald Combs <gerald@wireshark.org>
5636 Date: Wed Aug 5 10:59:51 2015 -0700
5638 Make sure we use "*.html" in our chunked output.
5640 Change-Id: Idb441084ec50ec336b7f514895aba799832e8f66
5641 Reviewed-on: https://code.wireshark.org/review/9879
5642 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5645 Author: Michal Labedzki <michal.labedzki@tieto.com>
5646 Date: Wed Aug 5 16:25:16 2015 +0000
5648 Revert "[MSVC 2015] Fix errors seen with the released version by reverting the code to what failed on the RC version *sigh*"
5650 Reverted commit break DecodeAs for Bluetooth, also caused crashes.
5652 This reverts commit 2221153a9cc083a50248a72a4b4009908d84e38b.
5654 Change-Id: Idb91747b986f110fffa3444f8c52d800c128e141
5655 Reviewed-on: https://code.wireshark.org/review/9877
5656 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5659 Author: Gerald Combs <gerald@wireshark.org>
5660 Date: Wed Aug 5 09:30:40 2015 -0700
5662 Generate XHTML5 documentation.
5664 When converting from DocBook to HTML, use DocBook's xhtml5 XSL
5667 Change-Id: I7a49d60c46a17e1e639b78ee10c4b9fa832d4a77
5668 Reviewed-on: https://code.wireshark.org/review/9878
5669 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5672 Author: AndersBroman <anders.broman@ericsson.com>
5673 Date: Wed Aug 5 14:37:20 2015 +0200
5675 [MSVC 2015] Fix errors seen with the released version by reverting the
5676 code to what failed on the RC version *sigh*
5678 Change-Id: I1b7f6d57da4cb71473a074291da7e5a0d5242c95
5679 Reviewed-on: https://code.wireshark.org/review/9874
5680 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5683 Author: AndersBroman <anders.broman@ericsson.com>
5684 Date: Wed Aug 5 14:30:27 2015 +0200
5686 [MSVC 2015] Compiler and visual studio version are off by 5 not 6 in MSVC
5689 Change-Id: I5476656789893af2c8aeb5dfe5cf06972fd8bd4b
5690 Reviewed-on: https://code.wireshark.org/review/9873
5691 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5694 Author: Pascal Quantin <pascal.quantin@gmail.com>
5695 Date: Mon Aug 3 22:21:24 2015 +0200
5697 MAC CTRL: fix dissection of PAUSE frame
5699 According to 802.3 table 31A-1, only opcodes from 0x0002 to 0x0006 have a timestamp
5700 While we are at it, rename the opcodes to a name matching the specification
5703 Change-Id: Iaadc2b801e86523e962b4eb319541bc74de22071
5704 Reviewed-on: https://code.wireshark.org/review/9857
5705 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5706 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5707 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5708 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5711 Author: Gerald Combs <gerald@wireshark.org>
5712 Date: Tue Aug 4 14:56:46 2015 -0700
5714 Convert the GSM A stats to new "generic stat API".
5716 These are largely untested, but the two abis captures on the wiki seem
5717 to work OK. The menu item names could also use some work. Patches
5720 Change-Id: I19a5b5fe3476b49d1dd0b684cbb7f367c6ebd4b4
5721 Reviewed-on: https://code.wireshark.org/review/9869
5722 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5723 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5724 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5727 Author: Gerald Combs <gerald@wireshark.org>
5728 Date: Tue Aug 4 08:56:28 2015 -0700
5730 Convert Camel tap stats to new "generic stat API".
5732 Migrate the Camel stats similar to the recent BOOTP and H.225
5735 Change-Id: If82617068ff4b8fa186899f66dc34a08585f66cb
5736 Reviewed-on: https://code.wireshark.org/review/9865
5737 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5738 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5741 Author: Gerald Combs <gerald@wireshark.org>
5742 Date: Tue Aug 4 10:16:23 2015 -0700
5744 Remove the CLI H.225 counter.
5746 Stats were moved to the dissector in g03802cc.
5748 Change-Id: I1aaf43789695ba3aae54cfaf201263cd0aed74ea
5749 Reviewed-on: https://code.wireshark.org/review/9867
5750 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5751 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5752 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5755 Author: Gerald Combs <gerald@wireshark.org>
5756 Date: Tue Aug 4 11:45:24 2015 -0700
5758 Don't zero stat tap elements.
5760 Let the reset callback take care of resetting our rows.
5762 Change-Id: I59b0e9d36a9a1cedc5a5893664c875b7416a5229
5763 Reviewed-on: https://code.wireshark.org/review/9868
5764 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5767 Author: Gerald Combs <gerald@wireshark.org>
5768 Date: Tue Aug 4 10:00:23 2015 -0700
5770 Fix the selected packet indicator width.
5772 Change-Id: Ic792c232524b4124bb4607cbe1979cdce8fd7e23
5773 Reviewed-on: https://code.wireshark.org/review/9866
5774 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5777 Author: Gerald Combs <gerald@wireshark.org>
5778 Date: Mon Aug 3 10:30:04 2015 -0700
5780 Convert H.225 tap stats to new "generic stat API".
5782 Migrate the H.225 stats similar to the recent BOOTP migration.
5784 Change-Id: I70ff7ab6cf3e9796f257412ba7d65ec9fe7f77ad
5785 Reviewed-on: https://code.wireshark.org/review/9859
5786 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5787 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5788 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5791 Author: Gerald Combs <gerald@wireshark.org>
5792 Date: Mon Aug 3 21:25:00 2015 -0700
5794 Zero stat table elements instead of freeing them.
5796 Stat table element arrays are allocated once at startup. Reset each
5797 element in free_stat_table() instead of freeing them.
5799 Change-Id: Ia63af93c76a1348bbb809137a521eead58a52dd1
5800 Reviewed-on: https://code.wireshark.org/review/9860
5801 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5802 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5803 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5806 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
5807 Date: Sat Jul 25 20:07:59 2015 +0200
5809 EPL: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
5811 Change-Id: Id8fac193a2f3521986c0f91df84950ff581d4b6b
5812 Reviewed-on: https://code.wireshark.org/review/9790
5813 Reviewed-by: Roland Knall <rknall@gmail.com>
5814 Petri-Dish: Anders Broman <a.broman58@gmail.com>
5815 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5816 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5819 Author: AndersBroman <anders.broman@ericsson.com>
5820 Date: Tue Aug 4 16:48:06 2015 +0200
5822 MIB/OID Fix assertion in proto.c tmp_fld_check_assert().
5823 It seems like oid_data->name may get freed so do a g_strdup() as it's done
5824 for hf.hfinfo.abbrev.
5826 Change-Id: Ie05fb42d59556aec300d4e007b1db5cc79d8d6f1
5827 Reviewed-on: https://code.wireshark.org/review/9864
5828 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5831 Author: Luke Mewburn <luke@mewburn.net>
5832 Date: Tue Aug 4 19:42:19 2015 +1000
5834 Rename nettrace3gpp324423 to 3gpp32423
5836 Use "3gpp32423" instead of "nettrace3gpp324423":
5837 - There were too many "4"s in the previous name ("324423" vs "32423").
5838 - "nettrace" isn't an official name, per 3GPP TS 32 423
5841 Change-Id: Ic981d0351a3014fb79702955ebef7b13f6ce4a2e
5842 Reviewed-on: https://code.wireshark.org/review/9863
5843 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5846 Author: AndersBroman <anders.broman@ericsson.com>
5847 Date: Tue Aug 4 10:58:45 2015 +0200
5849 [ISUP] Read the country code at offset
5851 Change-Id: I5a03fdbdf7079c354bc9b63acba3d205f82a4e8a
5852 Reviewed-on: https://code.wireshark.org/review/9862
5853 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5856 Author: AndersBroman <anders.broman@ericsson.com>
5857 Date: Tue Aug 4 10:46:48 2015 +0200
5859 tvb_new_octet_aligned() should return both the captured and reported
5860 length set to datalen in the returned tvb.
5862 Change-Id: Ie6649a285a9fa4a0564e29ce18ec9459b8da2541
5863 Reviewed-on: https://code.wireshark.org/review/9861
5864 Reviewed-by: Anders Broman <a.broman58@gmail.com>
5867 Author: Guy Harris <guy@alum.mit.edu>
5868 Date: Mon Aug 3 14:14:50 2015 -0700
5870 Update a comment to reflect reality as of 1997.
5872 "IEEE 802.3" has, since IEEE 802.3y-1997, supported a type/length field,
5873 not just a length field (i.e., they acknowledged reality), so it's no
5874 as if there are "802.3" as opposed to "D/I/X" or "Ethernet II" frames.
5876 Change-Id: Ie7f61e48cb2a343a7c83e0747a6eee46964fc335
5877 Reviewed-on: https://code.wireshark.org/review/9858
5878 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5881 Author: Guy Harris <guy@alum.mit.edu>
5882 Date: Mon Aug 3 11:58:36 2015 -0700
5884 Give an I-D reference for this.
5886 Change-Id: I5bbc1b390215e11cba86af9b325ae94d3708ae93
5887 Reviewed-on: https://code.wireshark.org/review/9855
5888 Reviewed-by: Guy Harris <guy@alum.mit.edu>
5891 Author: Martin Mathieson <martin.r.mathieson@googlemail.com>
5892 Date: Mon Aug 3 12:02:37 2015 +0100
5894 TFTP: strengthen heuristic used over STUN/TURN
5896 Change-Id: I133199abda100a89e219804c3003dee76389c43a
5897 Reviewed-on: https://code.wireshark.org/review/9839
5898 Reviewed-by: Martin Mathieson <martin.r.mathieson@googlemail.com>
5901 Author: Gerald Combs <gerald@zing.org>
5902 Date: Sun Aug 2 15:33:07 2015 -0700
5904 Make sure per-packet tap callbacks return gbooleans.
5906 The tap API changed the return type of per-packet listener callbacks
5907 from int to gboolean back in 2009. Update a bunch of functions and some
5908 documentation accordingly.
5910 Change-Id: I79affe65db975caed3cc296a7e2985b7b9cdf4cc
5911 Reviewed-on: https://code.wireshark.org/review/9853
5912 Petri-Dish: Gerald Combs <gerald@wireshark.org>
5913 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5914 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5917 Author: Evan Huus <eapache@gmail.com>
5918 Date: Sun Aug 2 08:41:27 2015 -0400
5920 Skip files larger than 8MB in valgrind fuzzing
5922 Follow-up to g2eabd35 which added a 20MB limit, this lowers it quite a bit since
5923 we're still seeing out-of-memory failures with files slightly larger than 8MB.
5925 Based on a quick scan of the menagerie this only excludes another dozen or so
5926 files so we won't lose much coverage.
5929 Change-Id: I8d684bebad553408c68b125330f2878deedc3bff
5930 Reviewed-on: https://code.wireshark.org/review/9849
5931 Reviewed-by: Evan Huus <eapache@gmail.com>
5934 Author: Evan Huus <eapache@gmail.com>
5935 Date: Sun Aug 2 09:12:23 2015 -0400
5937 qt: fix scrollbar crash applying conv. filter
5939 When applying a conversation filter via context menu on the packet list,
5940 something triggers the scrollbar to redraw when it has a maximum value of 0,
5941 leading to a div-by-0. Guard against that (for now) though there may be a better
5944 Change-Id: I5fa0cac3e67f50a6c603a6fa10b117de5540d444
5945 Reviewed-on: https://code.wireshark.org/review/9850
5946 Reviewed-by: Gerald Combs <gerald@wireshark.org>
5949 Author: Pascal Quantin <pascal.quantin@gmail.com>
5950 Date: Sat Aug 1 11:38:03 2015 +0200
5952 HTTP2: remove weak part of the heuristic
5954 It is so fragile that it triggers too many false positives and it was not
5955 activated by default prior to g21e5a95.
5956 If required, a user can still use 'Decode As' functionality.
5958 Change-Id: I0236609665c57c6f3961cb9596c47b54da777641
5959 Reviewed-on: https://code.wireshark.org/review/9842
5960 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
5961 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
5962 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5963 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5966 Author: Pascal Quantin <pascal.quantin@gmail.com>
5967 Date: Sat Aug 1 18:38:15 2015 +0200
5969 proto.c: exclude hf_text_only from proto_registrar_is_protocol()
5971 This pseudo field is a specific case that is not linked to any protocol (despite parent being set to -1).
5972 This prevents a crash in Qt GUI when selecting a line added with proto_tree_add_subtree() or similar.
5974 Change-Id: I3b1cc2e6c7e71a71898f2ee9a02e9158eccf6fac
5975 Reviewed-on: https://code.wireshark.org/review/9845
5976 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
5977 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
5978 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5981 Author: Hauke Mehrtens <hauke@hauke-m.de>
5982 Date: Mon Jul 20 23:31:43 2015 +0200
5984 CoAP: add media type number for application/cbor
5986 application/cbor got the number 60 by the IANA, see
5987 https://www.iana.org/assignments/core-parameters/core-parameters.xml#content-formats
5989 Change-Id: I4dbfd9eff8bacb46e815140c4640359f9a951869
5990 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
5991 Reviewed-on: https://code.wireshark.org/review/9847
5992 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
5995 Author: Gerald Combs <gerald@wireshark.org>
5996 Date: Sun Aug 2 08:10:45 2015 -0700
5998 [Automatic update for 2015-08-02]
6000 Update manuf, services enterprise-numbers, translations, and other items.
6002 Change-Id: I1c6b1044870e93459bcf4743f00be68ff8ce8ff6
6003 Reviewed-on: https://code.wireshark.org/review/9851
6004 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6007 Author: Guy Harris <guy@alum.mit.edu>
6008 Date: Sat Aug 1 11:27:09 2015 -0700
6010 Set the reported length of chunk data correctly.
6012 The reported length should be the size of the chunk, not the remaining
6013 size of dechunked data.
6015 Update some comments while we're at it.
6017 Change-Id: Ia71948fb5ecebdaae3e171c53fd88cf72dcf76a3
6018 Reviewed-on: https://code.wireshark.org/review/9846
6019 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6022 Author: Pascal Quantin <pascal.quantin@gmail.com>
6023 Date: Sat Aug 1 13:28:01 2015 +0200
6025 MS-WSP: fix some Coverity warnings
6027 - prevent some NULL pointer deference pointer
6028 - remove DISSECTOR_ASSERT calls: it should be used only for dissector bugs
6029 - replace g_slist_next macro calls as the NULL pointer checks are already performed in the for loop
6031 Change-Id: If4efd5bb055c7806107ec9646e9864c7e345246d
6032 Reviewed-on: https://code.wireshark.org/review/9843
6033 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6034 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6035 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6038 Author: Pascal Quantin <pascal.quantin@gmail.com>
6039 Date: Sat Aug 1 16:41:52 2015 +0200
6041 PNRP: add support for message reassembly
6044 Change-Id: I2e8ca62e1babbca20654e8907e8a0b04991bb18f
6045 Reviewed-on: https://code.wireshark.org/review/9844
6046 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6047 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6048 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6051 Author: Gerald Combs <gerald@wireshark.org>
6052 Date: Fri Jul 31 16:52:37 2015 -0700
6054 More packet detail context menu items.
6056 Add the wiki and field reference items to the packet detail context
6057 menu. Add the "Go To Linked Packet" item in the Go menu and packet
6058 detail context menu. Use "Linked Packet" instead of "Packet Reference"
6059 and "Corresponding Packet". Remove more pending item comments.
6061 Change-Id: I66c40f71738f0996690f4818a546520ea0747088
6062 Reviewed-on: https://code.wireshark.org/review/9841
6063 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6064 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6065 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6068 Author: Guy Harris <guy@alum.mit.edu>
6069 Date: Fri Jul 31 15:37:49 2015 -0700
6071 Print times with the resolution from the capture file.
6073 Print the first packet and last packet time stamps with the resolution
6074 supplied for them, and print the difference between them with the higher
6075 of those two resolutions.
6077 Change-Id: I111fbbf91b5957e63dca650b85f182c5f103c5fd
6078 Reviewed-on: https://code.wireshark.org/review/9840
6079 Reviewed-by: Guy Harris <guy@alum.mit.edu>
6082 Author: Pascal Quantin <pascal.quantin@gmail.com>
6083 Date: Fri Jul 31 22:20:34 2015 +0200
6085 RRC: upgrade dissector to v12.6.0
6087 Change-Id: Ied56f90a8689a25d4093795bfd97d57d40e382c6
6088 Reviewed-on: https://code.wireshark.org/review/9838
6089 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6090 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6091 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6094 Author: Gerald Combs <gerald@wireshark.org>
6095 Date: Fri Jul 31 13:44:42 2015 -0700
6097 Fix binary data copying.
6099 As the QClipboard::setMimeData documentation says, "Ownership of the
6100 data is transferred to the clipboard." Allocate the mime data object
6103 Note the results of trying to paste into hex editors on Windows.
6104 Frhed works. Hex Editor Neo and HxD do not.
6106 Change-Id: I46691ba95bf1f5c38817cd42ded73e8e67e4ee97
6107 Reviewed-on: https://code.wireshark.org/review/9837
6108 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6111 Author: Gerald Combs <gerald@wireshark.org>
6112 Date: Fri Jul 31 12:21:28 2015 -0700
6114 More spacing fixups.
6116 Make spacing more consistent.
6118 Change-Id: I8980a84ca70660057016985299b0f95761076893
6119 Reviewed-on: https://code.wireshark.org/review/9835
6120 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6123 Author: Gerald Combs <gerald@wireshark.org>
6124 Date: Fri Jul 31 12:08:30 2015 -0700
6128 Change-Id: Iabf5f7610ea5205ad4500502e2b531a8ee130484
6129 Reviewed-on: https://code.wireshark.org/review/9834
6130 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6133 Author: Gerald Combs <gerald@wireshark.org>
6134 Date: Fri Jul 31 10:34:43 2015 -0700
6136 Use an ellipsis character instead of three dots.
6138 The OS X Human Interface Guidelines at
6140 https://developer.apple.com/library/mac/documentation/UserExperience/Conceptual/OSXHIGuidelines/TerminologyWording.html#//apple_ref/doc/uid/20000957-CH15-SW3
6144 "Be sure to create the ellipsis character using the key combination
6145 Option-; (Option-semicolon). This ensures that an assistive app can
6146 provide the correct interpretation of the character to a disabled user.
6147 If you use three period characters to simulate an ellipsis, many
6148 assistive apps will be unable to make sense of them. Also, three period
6149 characters and an ellipsis don't look the same because the periods are
6150 spaced differently than the points of an ellipsis."
6152 The Windows desktop applications guidelines has a section on ellipses:
6154 https://msdn.microsoft.com/en-us/library/windows/desktop/dn742478.aspx
6156 but doesn't specify the a single glyph vs three dots.
6160 https://developer.gnome.org/hig/stable/typography.html.en
6162 says "Take Advantage of Unicode" then specifically says to use U+2026
6163 HORIZONTAL ELLIPSIS.
6165 Remove the ellipsis from "Find Next" and "Find Previous". Neither
6166 requires user interaction.
6168 Change-Id: I0e6c28bb8b3a84b242731e2ca96f1a6f6f42c303
6169 Reviewed-on: https://code.wireshark.org/review/9833
6170 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6171 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6172 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6175 Author: Noel Power <noel.power@suse.com>
6176 Date: Thu Jul 30 14:27:01 2015 +0100
6178 MSWSP: Fix clang warnings and handle gracefully needed missing messages
6180 In addition to fixing some clang warnings code now handles the scenario
6181 where some needed messages may be missing in the capture, instead of
6182 silently ignoring now tell how many bytes we can't dissect and why.
6184 Change-Id: Ia6fd70d204d279799bc02209865c7f1da35d8191
6185 Signed-off-by: Noel Power <noel.power@suse.com>
6186 Reviewed-on: https://code.wireshark.org/review/9824
6187 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6190 Author: Gerald Combs <gerald@wireshark.org>
6191 Date: Thu Jul 30 16:15:40 2015 -0700
6193 Add Colorize to the packet detail menu.
6195 Change-Id: Idaac0b52e6e4534f40e13839e6dbce2408ca6bfa
6196 Reviewed-on: https://code.wireshark.org/review/9831
6197 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6200 Author: Gerald Combs <gerald@wireshark.org>
6201 Date: Thu Jul 30 13:55:46 2015 -0700
6203 More context menu updates.
6205 Add "Follow" and "Export Packet Bytes" to the packet detail context
6206 menu. Remove duplicate SCTP menu. Remove redunant action text.
6208 Change-Id: If69815dc774806e267fbd71aa390b0af6f3b0d14
6209 Reviewed-on: https://code.wireshark.org/review/9829
6210 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6213 Author: Gerald Combs <gerald@wireshark.org>
6214 Date: Thu Jul 30 12:34:53 2015 -0700
6216 Make copy menu item names more consistent.
6218 Change-Id: Ia7b2a87ba9ad843dfa9200d69eeb94275a3dc0bb
6219 Reviewed-on: https://code.wireshark.org/review/9827
6220 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6223 Author: Gerald Combs <gerald@wireshark.org>
6224 Date: Thu Jul 30 12:23:03 2015 -0700
6226 Add a missing menu item.
6228 Add "Copy as Filter" to the packet list context menu. Remove completed
6231 Change-Id: I1e2d9ebcff2fb36918d3e7525690cfb105cb1b13
6232 Reviewed-on: https://code.wireshark.org/review/9826
6233 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6236 Author: Gerald Combs <gerald@wireshark.org>
6237 Date: Wed Jul 29 16:24:39 2015 -0700
6239 Packet list and detail context menu updates.
6241 Add some missing items to the packet list and detail "Copy" context
6242 menus. Don't nest the "Copy" items so deeply. Add YAML to the supported
6245 Note that "Copy as Binary" copies to the clipboard as
6246 application/octet-stream, which is a) arguably correct, and b) not very
6247 useful. Fixes welcome.
6249 Enable and disable packet detail context menu items from a set of
6250 booleans similar to the packet list.
6252 Change-Id: Iaa931c766aa476c33f27de089e5c4dbaf9ce74d6
6255 Reviewed-on: https://code.wireshark.org/review/9825
6256 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6259 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6260 Date: Mon Jul 27 23:21:15 2015 +0200
6262 conversation: fix indent (use tabs)
6264 Change-Id: I256c364954e1b9edd479e5f25a1d742cc216ffff
6265 Reviewed-on: https://code.wireshark.org/review/9809
6266 Reviewed-by: Michael Mann <mmann78@netscape.net>
6269 Author: Bill Meier <wmeier@newsguy.com>
6270 Date: Wed Jul 29 18:48:14 2015 -0400
6272 [ieee80211] Don't call expert_...() under 'if (tree)'
6274 Change-Id: Idcda58191ca664412ef874a69f40eb09a5b38234
6275 Reviewed-on: https://code.wireshark.org/review/9820
6276 Reviewed-by: Bill Meier <wmeier@newsguy.com>
6279 Author: Gerald Combs <gerald@wireshark.org>
6280 Date: Wed Jul 29 12:09:28 2015 -0700
6282 Main menu and packet list menu updates.
6284 Enable and disable packet list-relasted menu items in one place. Add
6285 "Colorize Conversation" items to the packet list context menu.
6287 In the GTK+ UI we tend to disable entire menus, which makes their items
6288 inaccessible. Try not to do that in the Qt UI so that menu items are
6289 always visible even if they're disabled.
6291 Remove commented items which are now complete.
6293 Change-Id: I69b878b45334bf88014694b1bf016278fa55a94b
6294 Reviewed-on: https://code.wireshark.org/review/9819
6295 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6298 Author: Gerald Combs <gerald@wireshark.org>
6299 Date: Wed Jul 29 10:36:46 2015 -0700
6301 Capture file retapping fixups.
6303 Add CaptureFile::delayedRetapPackets, which starts retapping after the
6304 current batch of UI event are processed. Call it in the constructors of
6305 various dialogs so that they are shown before tapping starts.
6307 This *might* fix a crash found when following large streams from the
6308 Conversations dialog.
6310 Change-Id: If1b87491621ab7efcc0519f95891d34dcd9d18c1
6311 Reviewed-on: https://code.wireshark.org/review/9818
6312 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6313 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6314 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6317 Author: Luca Melette <luca@srlabs.de>
6318 Date: Fri Jul 10 22:55:27 2015 +0200
6320 GSM_MAP: adding dissector for sendParameters (MAPv1)
6322 The current ASN.1 description of MAP (3GPP 29.002) is missing this operation.
6323 I recovered the needed code from an old MAP description (ets_300599e01p) and
6324 integrated the missing parts into the asn tree and C template file (via asn2wrs).
6326 Change-Id: Ibe05e6a99f3f95ac66740b5d319a7200fdb3e54b
6327 Reviewed-on: https://code.wireshark.org/review/9594
6328 Petri-Dish: Anders Broman <a.broman58@gmail.com>
6329 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6332 Author: Noel Power <noel.power@suse.com>
6333 Date: Mon Jul 27 12:44:56 2015 +0100
6335 SMB2: only move ssi for request if request is really complete
6337 MS-SMB2 section '3.2.5.1.5 Handling Asynchronous Responses' states
6339 "If SMB2_FLAGS_ASYNC_COMMAND is set in the Flags field of the SMB2
6340 header and Status is not STATUS_PENDING, this is a final response
6341 to a request which was processed by the server asynchronously"
6343 This patch delays moving ssi information for a processed request
6344 to the matched hashmap until the request is actually completed.
6345 Without this patch the ssi information for the *final* matching
6346 message id response will not be available (on first pass) so a
6347 subdissector (e.g. MS-WSP) will not have the ssi information available
6348 to it. After this patch the ssi infomation will remain in the 'unmatched'
6349 hashmap until the 'final' response for the request is seen. While
6350 processing the 'final' matching response the ssi will be moved to
6351 the matched hashmap.
6353 Change-Id: Id501179ecb4f967a34c82b07d34dcdcd92537dc3
6355 Signed-off-by: Noel Power <noel.power@suse.com>
6356 Reviewed-on: https://code.wireshark.org/review/9805
6357 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6358 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6359 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6360 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6363 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6364 Date: Mon Jul 27 16:06:32 2015 +0200
6366 MSWSP: Enhance dissector
6368 * Use a value_string for display OS version
6369 * Remove unused pref modules
6370 * Remove boiteplate comment
6371 * Use boolean for TRUE/FALSE
6372 * Replace parseBoolean by proto_tree_add_bitmask
6373 * Remove unneed #include
6377 Change-Id: I007dc2a92e8c8f8a9a921c2c091e6c9276f1873b
6378 Reviewed-on: https://code.wireshark.org/review/9806
6379 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6380 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6381 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6382 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6385 Author: Gerald Combs <gerald@wireshark.org>
6386 Date: Mon Jul 27 16:17:44 2015 -0700
6388 Add "Disable Protocol..." to the ProtoTree context menu.
6390 Assume that "I don't want to see this" counts as a preference and add it
6391 under the "Protocol Preferences" submenu.
6393 Change-Id: I396e2476509db9df895826f8817b191893bcb14a
6394 Reviewed-on: https://code.wireshark.org/review/9812
6395 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6396 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6397 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6400 Author: Gerald Combs <gerald@wireshark.org>
6401 Date: Mon Jul 27 15:28:50 2015 -0700
6403 Fixup packet list context menu behavior.
6405 Add logic to setMenusForSelectedPacket for setting the enabled states
6406 for the "Apply As" and "Prepare A" actions. Update the PacketList
6407 context menu code to fill in the right filter at the right time.
6409 Exit out of setMenusForSelectedTreeRow if the packet list has focus so
6410 that we don't clobber the enabled states of various actions.
6412 Take the "Apply As" and "Prepare A" context menu titles from their main
6413 window counterparts. Remove actionApply_as_Filter and
6414 actionPrepare_a_Filter.
6416 Remove completed to-do items.
6418 Change-Id: I8f6f538bb7786d8df02a999f3b449dfde640e847
6419 Reviewed-on: https://code.wireshark.org/review/9810
6420 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6421 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6422 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6425 Author: Evan Huus <eapache@gmail.com>
6426 Date: Sun Jul 26 22:29:58 2015 -0400
6428 tcp: only reset dupACK counter when ACk# changes
6430 Otherwise things like window changes will reset the dup-ack counter incorrectly
6434 Change-Id: I80b63cf989a952547bec48562a92078c8ab29081
6435 Reviewed-on: https://code.wireshark.org/review/9802
6436 Petri-Dish: Evan Huus <eapache@gmail.com>
6437 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6438 Reviewed-by: Evan Huus <eapache@gmail.com>
6441 Author: Gerald Combs <gerald@zing.org>
6442 Date: Sun Jul 26 13:21:40 2015 -0700
6444 Add an application-wide style sheet.
6446 Use it to work around poorly drawn splitters on OS X.
6448 Change-Id: Ic8e7331b1ba37fe783312b4460961f361297c7f0
6449 Reviewed-on: https://code.wireshark.org/review/9798
6450 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6453 Author: Luke Mewburn <luke@mewburn.net>
6454 Date: Sun Jul 26 21:54:12 2015 +1000
6456 nettrace3gpp324423: fix name consistency
6458 Improve consistency when referring to 3GPP TS 32.423:
6459 - The standard name is "3GPP TS 32.423" (with "TS", and "." separator).
6460 - Fix typo in number series ("32" not "34").
6461 - The standard refers to "Trace", not "Nettrace".
6463 Change-Id: If9994b9c6de69b6e1bdfc6679fbaabe698971949
6464 Reviewed-on: https://code.wireshark.org/review/9795
6465 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6466 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6467 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6468 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6471 Author: Hadriel Kaplan <hadrielk@yahoo.com>
6472 Date: Sun Jul 26 17:31:26 2015 -0400
6474 Tshark doesn't display column text as field in 2-pass mode
6477 Change-Id: I6aa43d5cdd996aaf0980ab59b690212e41046acc
6478 Reviewed-on: https://code.wireshark.org/review/9800
6479 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
6480 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6481 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
6484 Author: Gerald Combs <gerald@wireshark.org>
6485 Date: Sun Jul 26 08:10:01 2015 -0700
6487 [Automatic update for 2015-07-26]
6489 Update manuf, services enterprise-numbers, translations, and other items.
6491 Change-Id: I3ddd31b2ebded50dcbe974ce99ef9b417b39aa2f
6492 Reviewed-on: https://code.wireshark.org/review/9796
6493 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6496 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6497 Date: Sun Jul 26 10:53:02 2015 +0200
6499 MSWSP: Remove usage of stdbool.h
6501 For fix build on Solaris
6502 "/usr/include/stdbool.h", line 42: #error: "Use of <stdbool.h> is valid only in a c99 compilation environment."
6504 Replace bool -> gboolean
6505 Replace true -> TRUE, false -> FALSE (for fix Wcompat error..)
6507 Change-Id: Ia3f39bfbbaf7cf35a916eb37edfc6745ea50ad36
6508 Reviewed-on: https://code.wireshark.org/review/9793
6509 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6510 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6511 Reviewed-by: Graham Bloice <graham.bloice@trihedral.com>
6514 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6515 Date: Sun Jul 26 11:17:04 2015 +0200
6517 MSWSP: Try to fix Mac OS X Buildbot
6519 Change-Id: I0c7bd3ea3900630ce4516cb00e6400cca353b672
6520 Reviewed-on: https://code.wireshark.org/review/9794
6521 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6522 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6523 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6524 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
6527 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6528 Date: Sun Jul 26 10:32:41 2015 +0200
6530 VoIP Call: fix Ubuntu Buildbot
6532 Missing init of new sip_frame_num variable...
6534 voip_calls_dlg.c: In function ‘voip_calls_get_info’:
6535 voip_calls_dlg.c:132:3: error: enum conversion in initialization is invalid in C++ [-Werror=c++-compat]
6536 voip_calls_dlg.c:132:3: error: (near initialization for ‘the_tapinfo_struct.fs_option’) [-Werror=c++-compat]
6537 voip_calls_dlg.c:132:3: error: missing initializer for field ‘redraw’ of ‘voip_calls_tapinfo_t’ [-Werror=missing-field-initializers]
6540 Change-Id: Ib76dec02d03f66d365ef18926bc4507a6f70556d
6541 Reviewed-on: https://code.wireshark.org/review/9792
6542 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6545 Author: Michal Pazdera <michal.pazdera@gmail.com>
6546 Date: Fri Jul 3 10:21:04 2015 +0200
6548 Avoid duplicate SIP and Q.931 calls in VoIP Calls list in case of Q.931
6549 transported over SIP as described in RFC 3204, 3.2 QSIG Media Type.
6551 Change-Id: Ida30a7b115e60fa64d30cfc1f4b7c11be724f8ee
6552 Reviewed-on: https://code.wireshark.org/review/9479
6553 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6556 Author: Gerald Combs <gerald@wireshark.org>
6557 Date: Fri Jul 24 09:53:09 2015 -0700
6559 Minor Enabled Protocols tweaks.
6561 Try to keep long protocol names from widening the first column too much.
6563 Expand all tree items.
6565 Change-Id: I4f09aa2a895aa0ee5a6faab8242768b62b1208bc
6566 Reviewed-on: https://code.wireshark.org/review/9771
6567 Reviewed-by: Michael Mann <mmann78@netscape.net>
6568 Petri-Dish: Michael Mann <mmann78@netscape.net>
6569 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6570 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6573 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6574 Date: Thu Jul 23 22:38:41 2015 +0200
6576 ISAKMP: Remove uneeded space before HF name and HF filter
6578 Change-Id: I5669277b9a03cba17067d52e6a9f9df933c3eb5d
6579 Reviewed-on: https://code.wireshark.org/review/9767
6580 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6583 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6584 Date: Mon Jul 6 09:51:11 2015 +0200
6586 lemon (tools): Fix Dead Store (Dead assignement/Dead increment) warning found by Clang
6588 Change-Id: Ibfa0bfd589e77a58b7b242c7c2fe25ef052a874e
6589 Reviewed-on: https://code.wireshark.org/review/9516
6590 Reviewed-by: Martin Kaiser <wireshark@kaiser.cx>
6591 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6594 Author: Richard Sharpe <rsharpe@samba.org>
6595 Date: Fri Jul 24 20:41:31 2015 -0700
6597 Fix an error where we expect the tagged parameters field to be present even
6598 though the spec (802.11ad-2012) says they are optional.
6600 Communicated to me by the WiFi Alliance. I have captures. Not sure if I can
6603 Change-Id: Id5998594214ac4b6a1d3baf3cb2f0d4fe6227b40
6604 Signed-off-by: Richard Sharpe <realrichardsharpe@gmail.com>
6605 Reviewed-on: https://code.wireshark.org/review/9785
6606 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6607 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6608 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6611 Author: Andrei Cipu <acipu@ixiacom.com>
6612 Date: Thu Jul 23 17:25:57 2015 +0300
6614 ISAKMP: Add 3GPP IMS Options for IKEv2
6618 Change-Id: I53045f25cf9f3daf910e9fd5240033ffcd1941a2
6619 Reviewed-on: https://code.wireshark.org/review/9757
6620 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6621 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6622 Reviewed-by: Alexis La Goutte <alexis.lagoutte@gmail.com>
6625 Author: Alexis La Goutte <alexis.lagoutte@gmail.com>
6626 Date: Thu Jul 23 22:31:09 2015 +0200
6628 ISAKMP: The modecfg attribute type INTERNAL_IP6_ADDRESS is not decoded correctly
6630 According to RFC7296, section 3.15.1:
6632 "The INTERNAL_IP6_ADDRESS is made up of two fields: the first is a 16-octet IPv6 address, and the second is a one-octet prefix-length as defined in [ADDRIPV6]."
6634 In the code, the type is declared as FT_IPv4 and the field is decoded only if it has 16 bytes. Instead, it should be declared as FT_IPv6 and the first 16 bytes should be added to the tree.
6636 Issue reported by Andrei Cipu
6640 Change-Id: I8dbc268e71fd6239dffa5469652345a68e0adc86
6641 Reviewed-on: https://code.wireshark.org/review/9761
6642 Petri-Dish: Alexis La Goutte <alexis.lagoutte@gmail.com>
6643 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6644 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6647 Author: Pascal Quantin <pascal.quantin@gmail.com>
6648 Date: Sat Jul 25 17:10:31 2015 +0200
6650 MAC LTE: fix dissection of Long DRX Command Control Element
6652 Change-Id: I2d122a9ad8cd768499bff8e1af8754d2eb504594
6653 Reviewed-on: https://code.wireshark.org/review/9788
6654 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6655 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6656 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6659 Author: Pascal Quantin <pascal.quantin@gmail.com>
6660 Date: Sat Jul 25 16:30:55 2015 +0200
6662 MAC LTE: fix dissection of CCCH SDU for Category 0 UE
6664 Change-Id: I2d840ad2ba70cdf87b3cd12b9d4a433f05e0b1b2
6665 Reviewed-on: https://code.wireshark.org/review/9787
6666 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6669 Author: Hadriel Kaplan <hadrielk@yahoo.com>
6670 Date: Sat Jul 25 09:24:48 2015 -0400
6672 DNS: move DNS name resolution pref to Name Resolution prefs
6674 Move the boolean flag for using captured DNS packet info for name resolution
6675 to the Name Resolution preferences settings, as it was rather surprising to
6676 disable Name Resolution preferences and still have names being resolved. Also
6677 disble them all if the '-n' command line switch is used, and re-enable it for
6678 a 'd' character in the '-N' option.
6681 Change-Id: Ie4d47bab0100db3360cc447cd3e446b2e39aa917
6682 Reviewed-on: https://code.wireshark.org/review/9786
6683 Petri-Dish: Hadriel Kaplan <hadrielk@yahoo.com>
6684 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6685 Reviewed-by: Hadriel Kaplan <hadrielk@yahoo.com>
6688 Author: Jeff Morriss <jeff.morriss.ws@gmail.com>
6689 Date: Fri Jul 24 14:51:37 2015 -0400
6691 Fix ptvcursor_add() so it can dissect the last bytes in a TVB again.
6693 ptvc->offset has already been incremented by the item length so don't use it as
6694 the offset to test_length(); we need to use the original offset.
6696 Problem introduced by Idfd258c734e7a946300b2564bebf6e4cb374c8d1 .
6698 Change-Id: I0421539bde6e8eb7b5aa3e22dbb0ca8098e88d6f
6699 Reviewed-on: https://code.wireshark.org/review/9779
6700 Reviewed-by: Michael Mann <mmann78@netscape.net>
6701 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6704 Author: Gregor Beck <gbeck@sernet.de>
6705 Date: Mon Sep 17 13:22:32 2012 +0200
6707 MSWSP: Initial implementation of MS-WSP (windows search protocol) dissector
6709 This changeset is a forward port of Gregors ms-wsp branch from his
6710 repo http://repo.or.cz/w/wireshark-wip.git. Most of the messages of
6711 the MS-WSP protocol are implemented here and as such consists of the
6712 majority of the changes for the dissector.
6714 In addition to the forward porting Gregors work I added some extra bits
6715 1) cater for SMB2 Read Response and Write Request msgs that can also
6716 contain MSWSP messages
6717 2) update property specifications with info extracted from MS-WSP protocol
6719 3) store some basic data about previously seen messages that are needed
6720 for dissecting CPMGetRows request
6721 4) expand/update dissect_CPMSetBindings & parse_CTableColumn routines
6722 5) parse and store CTableColumn & CPMSetBindingsIn structures in conversation
6723 related data for use later.
6724 6) fully dissect/parse SeekDesciption of CPMGetRowsOut
6725 7) dissect CPMGetRows out message specifically the Rows & Columns
6726 8) flesh out the boolean properties of uBooleanOptions field
6727 9) flesh out various other dissectors:
6730 CPMCompareBmkIn/CPMCompareBmkOut
6731 CPMGetApproximatePosition
6737 Change-Id: I68b5c2f3e63874c1dbb271feab89b2b8aa65ac39
6738 Signed-off-by: Noel Power <noel.power@suse.com>
6739 Reviewed-on: https://code.wireshark.org/review/9440
6740 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6741 Reviewed-by: Anders Broman <a.broman58@gmail.com>
6744 Author: Pascal Quantin <pascal.quantin@gmail.com>
6745 Date: Sat Jul 25 00:08:52 2015 +0200
6747 MAC LTE: fix dump of last SDU
6749 Change-Id: Ice39b71fab564cde0688c451bdf46c7e426475ce
6750 Reviewed-on: https://code.wireshark.org/review/9782
6751 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6754 Author: Gerald Combs <gerald@wireshark.org>
6755 Date: Fri Jul 24 10:24:15 2015 -0700
6757 Try deleting WiresharkDialog when we close it.
6759 QDialog::accept and ::reject hide the dialog but don't delete it. In the
6760 case of WiresharkDialog and its subclasses we might leak memory or leave
6761 files open. Call deleteLater when we close the dialog.
6763 Change-Id: Ie0b848a7deeeee4667925b0d886e498f13a86bfc
6764 Reviewed-on: https://code.wireshark.org/review/9781
6765 Petri-Dish: Gerald Combs <gerald@wireshark.org>
6766 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6767 Reviewed-by: Gerald Combs <gerald@wireshark.org>
6770 Author: Pascal Quantin <pascal.quantin@gmail.com>
6771 Date: Fri Jul 24 19:50:29 2015 +0200
6773 MAC LTE: fix dissection when only header is captured but full PDU length is reported
6775 Change-Id: I66ccfc26b3a0e948fdcf8dfe4ec8e87e6ed756da
6776 Reviewed-on: https://code.wireshark.org/review/9778
6777 Petri-Dish: Pascal Quantin <pascal.quantin@gmail.com>
6778 Tested-by: Petri Dish Buildbot <buildbot-no-reply@wireshark.org>
6779 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6782 Author: Pascal Quantin <pascal.quantin@gmail.com>
6783 Date: Fri Jul 24 19:13:31 2015 +0200
6785 RLC: fix dissection when only header is captured but full PDU length is reported
6787 Change-Id: I06e7bed71a42c6cbe500d7f1994a625b37d6586c
6788 Reviewed-on: https://code.wireshark.org/review/9777
6789 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6792 Author: Pascal Quantin <pascal.quantin@gmail.com>
6793 Date: Fri Jul 24 19:12:45 2015 +0200
6795 RLC LTE: fix dissection when only header is captured but full PDU length is reported
6797 Change-Id: I67654bb0ca30d9bb56c9a4b3be179161ecd0de3a
6798 Reviewed-on: https://code.wireshark.org/review/9776
6799 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6802 Author: Pascal Quantin <pascal.quantin@gmail.com>
6803 Date: Fri Jul 24 19:10:30 2015 +0200
6805 PDCP LTE: fix dissection when only header is captured but full PDU length is reported
6807 Change-Id: I62c89a49f3cf2ed566e16a978b2ed237f09d466e
6808 Reviewed-on: https://code.wireshark.org/review/9775
6809 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6812 Author: Pascal Quantin <pascal.quantin@gmail.com>
6813 Date: Fri Jul 24 18:32:26 2015 +0200
6815 SIP: heuristic dissectors should use the captured length, not the reported one
6817 Otherwise it triggers a "packet size limited during capture" exception
6818 preventing following heuristic dissectors to be called
6820 Change-Id: Ifc97e84b4e40a1c7dc0b0c63b7b9e015bd99d178
6821 Reviewed-on: https://code.wireshark.org/review/9774
6822 Reviewed-by: Pascal Quantin <pascal.quantin@gmail.com>
6825 Author: Gerald Combs <gerald@wireshark.org>
6826 Date: Fri Jul 24 12:04:27 2015 -0700
6830 Change-Id: I014399c332136a10b1c560d4c68be5b8bab97552
6831 Reviewed-on: https://code.wireshark.org/review/9780
6832 Reviewed-by: Gerald Combs <gerald@wireshark.org>