s4-torture: simplify smb2_util_oplock_level(), it's always called with only one option.
authorGünther Deschner <gd@samba.org>
Tue, 19 Jan 2016 13:53:20 +0000 (14:53 +0100)
committerStefan Metzmacher <metze@samba.org>
Mon, 10 Feb 2020 14:12:11 +0000 (15:12 +0100)
Guenther

Signed-off-by: Guenther Deschner <gd@samba.org>
source4/torture/smb2/util.c

index 7bb7bf0a0ac8f1e25c14a07420efcbcd597943df..dae533826591f948e4300672aca67d2a57d3e7d8 100644 (file)
@@ -825,19 +825,20 @@ uint32_t smb2_util_share_access(const char *sharemode)
 uint8_t smb2_util_oplock_level(const char *op)
 {
        uint8_t val = SMB2_OPLOCK_LEVEL_NONE;
-       int i;
 
-       for (i = 0; i < strlen(op); i++) {
-               switch (op[i]) {
-               case 's':
-                       return SMB2_OPLOCK_LEVEL_II;
-               case 'x':
-                       return SMB2_OPLOCK_LEVEL_EXCLUSIVE;
-               case 'b':
-                       return SMB2_OPLOCK_LEVEL_BATCH;
-               default:
-                       continue;
-               }
+       if (op == NULL) {
+               return val;
+       }
+
+       switch (op[0]) {
+       case 's':
+               return SMB2_OPLOCK_LEVEL_II;
+       case 'x':
+               return SMB2_OPLOCK_LEVEL_EXCLUSIVE;
+       case 'b':
+               return SMB2_OPLOCK_LEVEL_BATCH;
+       default:
+               break;
        }
 
        return val;