s3: Slightly simplify is_stat_open
authorVolker Lendecke <vl@samba.org>
Wed, 5 Sep 2012 13:24:46 +0000 (15:24 +0200)
committerVolker Lendecke <vl@samba.org>
Tue, 25 Sep 2012 18:05:06 +0000 (20:05 +0200)
The "access_bits" clause is redundant. is_stat_open says that exactly
at least one of the stat_open_bits must be set and none else.

Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Sep 25 20:05:06 CEST 2012 on sn-devel-104

source3/smbd/open.c

index eff78d45339d0fa3e60f15760f20381de167c011..34d552620dde59c5fc3ee0dc3fe52723c9e35f91 100644 (file)
@@ -1071,9 +1071,8 @@ bool is_stat_open(uint32 access_mask)
                 FILE_READ_ATTRIBUTES|
                 FILE_WRITE_ATTRIBUTES);
 
-       return (access_mask &&
-               ((access_mask & ~stat_open_bits) == 0) &&
-               ((access_mask & stat_open_bits) != 0));
+       return (((access_mask &  stat_open_bits) != 0) &&
+               ((access_mask & ~stat_open_bits) == 0));
 }
 
 /****************************************************************************